ui: ceph pool edit: rework with controller and formulas

instead of relying purely on listeners that then manually change other
components, we can use binds, formulas and a basic controller.

This makes it quite a bit easier to let multiple components react to
changes.

A cbind is used for the size component to set the initial start value.
Other options, like using setValue in the controller init, will trigger
the change listener and therefore can affect the min size without any
user interaction.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 0ad59baf44ae10d5035e0f165ce12bde772cbce8..c61d4f71baea88aa4e8f646b2aba7021411591a8 100644 (file)
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -11,6 +11,48 @@ Ext.define('PVE.CephPoolInputPanel', {
     defaultSize: undefined,
     defaultMinSize: undefined,
 
+    controller: {
+       xclass: 'Ext.app.ViewController',
+
+       init: function(view) {
+           let vm = this.getViewModel();
+           vm.set('size', Number(view.defaultSize));
+           vm.set('minSize', Number(view.defaultMinSize));
+       },
+       sizeChange: function(field, val) {
+           let vm = this.getViewModel();
+           let minSize = Math.round(val / 2);
+           if (minSize > 1) {
+               vm.set('minSize', minSize);
+           }
+           vm.set('size', val); // bind does not work in a pmxDisplayEditField, update manually
+       },
+    },
+
+    viewModel: {
+       data: {
+           minSize: null,
+           size: null,
+       },
+       formulas: {
+           minSizeLabel: (get) => {
+               if (get('showMinSizeOneWarning') || get('showMinSizeHalfWarning')) {
+                   return `${gettext('Min. Size')} <i class="fa fa-exclamation-triangle warning"></i>`;
+               }
+               return gettext('Min. Size');
+           },
+           showMinSizeOneWarning: (get) => get('minSize') === 1,
+           showMinSizeHalfWarning: (get) => {
+               let minSize = get('minSize');
+               let size = get('size');
+               if (minSize === 1) {
+                   return false;
+               }
+               return minSize < (size / 2) && minSize !== size;
+           },
+       },
+    },
+
     column1: [
        {
            xtype: 'pmxDisplayEditField',
@@ -38,12 +80,7 @@ Ext.define('PVE.CephPoolInputPanel', {
                maxValue: 7,
                allowBlank: false,
                listeners: {
-                   change: function(field, val) {
-                       let size = Math.round(val / 2);
-                       if (size > 1) {
-                           field.up('inputpanel').down('field[name=min_size]').setValue(size);
-                       }
-                   },
+                   change: 'sizeChange',
                },
            },
        },
@@ -81,7 +118,10 @@ Ext.define('PVE.CephPoolInputPanel', {
     advancedColumn1: [
        {
            xtype: 'proxmoxintegerfield',
-           fieldLabel: gettext('Min. Size'),
+           bind: {
+               fieldLabel: '{minSizeLabel}',
+               value: '{minSize}',
+           },
            name: 'min_size',
            cbind: {
                value: (get) => get('defaultMinSize'),
@@ -95,28 +135,24 @@ Ext.define('PVE.CephPoolInputPanel', {
            },
            maxValue: 7,
            allowBlank: false,
-           listeners: {
-               change: function(field, minSize) {
-                   let panel = field.up('inputpanel');
-                   let size = panel.down('field[name=size]').getValue();
-
-                   let showWarning = minSize < (size / 2) && minSize !== size;
-
-                   let fieldLabel = gettext('Min. Size');
-                   if (showWarning) {
-                       fieldLabel = gettext('Min. Size') + ' <i class="fa fa-exclamation-triangle warning"></i>';
-                   }
-                   panel.down('field[name=min_size-warning]').setHidden(!showWarning);
-                   field.setFieldLabel(fieldLabel);
-               },
-           },
        },
        {
            xtype: 'displayfield',
-           name: 'min_size-warning',
+           bind: {
+               hidden: '{!showMinSizeHalfWarning}',
+           },
+           hidden: true,
            userCls: 'pmx-hint',
            value: gettext('min_size < size/2 can lead to data loss, incomplete PGs or unfound objects.'),
+       },
+       {
+           xtype: 'displayfield',
+           bind: {
+               hidden: '{!showMinSizeOneWarning}',
+           },
            hidden: true,
+           userCls: 'pmx-hint',
+           value: gettext('a min_size of 1 is not recommended and can lead to data loss'),
        },
        {
            xtype: 'pmxDisplayEditField',