]> git.proxmox.com Git - pve-manager.git/commitdiff
ui: esxi storage edit: make user and password always editable
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 13 Mar 2024 06:28:44 +0000 (07:28 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Thu, 14 Mar 2024 14:17:43 +0000 (15:17 +0100)
Those can change somewhat frequently, e.g., as part of credentials
rotation policies.

Keep the 'server' one for now as is, while it can make sense to change
that too, e.g., from IP to FQDN, it's currently uncommon for PVE to
allow that in the UI, if we should evaluate all storage types for such
things and for that we also should improve the re-mount/activate story
in the storage lib.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
www/manager6/storage/ESXIEdit.js

index 01c8bd237aa6e2be98bf83ae58427e43cc0dd9f9..9ffff32ae437e9a3f71b8b0f688907a7d343ff27 100644 (file)
@@ -20,30 +20,26 @@ Ext.define('PVE.storage.ESXIInputPanel', {
        me.column1 = [
            {
                xtype: 'pmxDisplayEditField',
-               editable: me.isCreate,
                name: 'server',
                fieldLabel: gettext('Server'),
+               editable: me.isCreate,
+               emptyText: gettext('IP address or hostname'),
                allowBlank: false,
            },
            {
-               xtype: 'pmxDisplayEditField',
-               editable: me.isCreate,
+               xtype: 'textfield',
                name: 'username',
                fieldLabel: gettext('Username'),
                allowBlank: false,
            },
            {
-               xtype: 'pmxDisplayEditField',
-               editable: me.isCreate,
+               xtype: 'proxmoxtextfield',
                name: 'password',
-               value: me.isCreate ? '' : '********',
-               minLength: 1,
-               editConfig: {
-                   inputType: 'password',
-                   name: 'password',
-               },
                fieldLabel: gettext('Password'),
-               allowBlank: false,
+               inputType: 'password',
+               emptyText: gettext('Unchanged'),
+               minLength: 1,
+               allowBlank: !me.isCreate,
            },
        ];