ui: pci map edit: reintroduce warnings checks

they got lost in my last rebase/refactor.

the onLoadCallBack is used to check by the window if there are iommu
groups at all, and the checkIsolated function checks if the selected
ones are in a separate group (in regards to the other devices)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/www/manager6/form/MultiPCISelector.js b/www/manager6/form/MultiPCISelector.js
index e1ef691aecbe86dcb6380b02ba3669aa5655dd77..d4fb636452e8b25bb599ff76b10f567e4a8871bf 100644 (file)
--- a/www/manager6/form/MultiPCISelector.js
+++ b/www/manager6/form/MultiPCISelector.js
@@ -8,6 +8,9 @@ Ext.define('PVE.form.MultiPCISelector', {
        field: 'Ext.form.field.Field',
     },
 
+    // will be called after loading finished
+    onLoadCallBack: Ext.emptyFn,
+
     getValue: function() {
        let me = this;
        return me.value ?? [];
@@ -287,6 +290,8 @@ Ext.define('PVE.form.MultiPCISelector', {
 
        me.callParent();
 
+       me.mon(me.getStore(), 'load', me.onLoadCallBack);
+
        Proxmox.Utils.monStoreErrors(me, me.getStore(), true);
 
        me.setNodename(nodename);

diff --git a/www/manager6/window/PCIMapEdit.js b/www/manager6/window/PCIMapEdit.js
index 516678e095285b6af86f2b7563c97abbd093311f..8c1a95e3216150033b83e20b66a535656cf983eb 100644 (file)
--- a/www/manager6/window/PCIMapEdit.js
+++ b/www/manager6/window/PCIMapEdit.js
@@ -70,6 +70,46 @@ Ext.define('PVE.window.PCIMapEditWindow', {
            me.lookup('iommu_warning').setVisible(
                records.every((val) => val.data.iommugroup === -1),
            );
+
+           let value = me.lookup('pciselector').getValue();
+           me.checkIsolated(value);
+       },
+
+       checkIsolated: function(value) {
+           let me = this;
+
+           let store = me.lookup('pciselector').getStore();
+
+           let isIsolated = function(entry) {
+               let isolated = true;
+               let parsed = PVE.Parser.parsePropertyString(entry);
+               parsed.iommugroup = parseInt(parsed.iommugroup, 10);
+               if (!parsed.iommugroup) {
+                   return isolated;
+               }
+               store.each(({ data }) => {
+                   let isSubDevice = data.id.startsWith(parsed.path);
+                   if (data.iommugroup === parsed.iommugroup && data.id !== parsed.path && !isSubDevice) {
+                       isolated = false;
+                       return false;
+                   }
+                   return true;
+               });
+               return isolated;
+           };
+
+           let showWarning = false;
+           if (Ext.isArray(value)) {
+               for (const entry of value) {
+                   if (!isIsolated(entry)) {
+                       showWarning = true;
+                       break;
+                   }
+               }
+           } else {
+               showWarning = isIsolated(value);
+           }
+           me.lookup('group_warning').setVisible(showWarning);
        },
 
        mdevChange: function(mdevField, value) {
@@ -83,6 +123,7 @@ Ext.define('PVE.window.PCIMapEditWindow', {
        pciChange: function(_field, value) {
            let me = this;
            me.lookup('multiple_warning').setVisible(Ext.isArray(value) && value.length > 1);
+           me.checkIsolated(value);
        },
 
        control: {