ui: eslint: Miscellaneous eslint fixes

Function syntax, raw words, string templates, no prototype builtins

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/www/manager6/lxc/MPResize.js b/www/manager6/lxc/MPResize.js
index f73c5c3fa3727b6d56518b45afceac1749134d6c..881c037b067520fc2b9523d05f384bdc4e3e22be 100644 (file)
--- a/www/manager6/lxc/MPResize.js
+++ b/www/manager6/lxc/MPResize.js
@@ -91,11 +91,6 @@ Ext.define('PVE.window.MPResize', {
            items: [me.formPanel],
        });
 
-
        me.callParent();
-
-       if (!me.disk) {
-           return;
-       }
     },
 });

diff --git a/www/manager6/qemu/HDResize.js b/www/manager6/qemu/HDResize.js
index a18e242cb40cd8b60ff78efb2e6a85dfa906de64..f9c7290d172d753bdf592148b528185855f69f1b 100644 (file)
--- a/www/manager6/qemu/HDResize.js
+++ b/www/manager6/qemu/HDResize.js
@@ -92,9 +92,5 @@ Ext.define('PVE.window.HDResize', {
 
 
        me.callParent();
-
-       if (!me.disk) {
-           return;
-       }
     },
 });

diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index 8e5856510268b7b4446d2de32819110ddf89a228..f464133e53561309e109ee8bf3ca7179de043dfa 100644 (file)
--- a/www/manager6/qemu/OSDefaults.js
+++ b/www/manager6/qemu/OSDefaults.js
@@ -24,7 +24,7 @@ Ext.define('PVE.qemu.OSDefaults', {
        var me = this;
 
        var addOS = function(settings) {
-               if (me.hasOwnProperty(settings.parent)) {
+               if (Object.prototype.hasOwnProperty.call(settings, 'parent')) {
                    var child = Ext.clone(me[settings.parent]);
                    me[settings.pveOS] = Ext.apply(child, settings);
                } else {

diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
index 4336d634f0b32ff0094a354c5fde909b922ad31d..20ec3464396c0d78824d5448d43a6caf4247a1f2 100644 (file)
--- a/www/manager6/storage/Base.js
+++ b/www/manager6/storage/Base.js
@@ -78,7 +78,7 @@ Ext.define('PVE.panel.StoragePruneInputPanel', {
            }
            // always delete old 'maxfiles' on edit, we map it to keep-last on window load
            return {
-               delete: ['prune-backups', 'maxfiles'],
+               'delete': ['prune-backups', 'maxfiles'],
            };
        }
        let options = { 'prune-backups': retention };

diff --git a/www/manager6/storage/ImageView.js b/www/manager6/storage/ImageView.js
index dda4b8e621c22142e5d38e2477cfc91dd0e75307..69517b5ef3911011caf76385df6fab5aae7b3672 100644 (file)
--- a/www/manager6/storage/ImageView.js
+++ b/www/manager6/storage/ImageView.js
@@ -33,8 +33,7 @@ Ext.define('PVE.storage.ImageView', {
                text: gettext('Remove'),
                disabled: true,
                handler: function(btn, event, rec) {
-                   var url = "/nodes/" + nodename + "/storage/" + storage +
-                             "/content" + '/' + rec.data.volid;
+                   let url = `/nodes/${nodename}/storage/${storage}/content/${rec.data.volid}`;
                    var vmid = rec.data.vmid;
 
                    var store = PVE.data.ResourceStore;

diff --git a/www/manager6/storage/ZFSEdit.js b/www/manager6/storage/ZFSEdit.js
index e348d1a15023f50b1d02413c21759a9be2e1bfa5..0c5a3ceba9fd862de49d8998e04be1182bf51a87 100644 (file)
--- a/www/manager6/storage/ZFSEdit.js
+++ b/www/manager6/storage/ZFSEdit.js
@@ -38,7 +38,7 @@ Ext.define('PVE.storage.ZFSInputPanel', {
        return me.callParent([values]);
     },
 
-    setValues: function diff(values) {
+    setValues: function(values) {
        values.writecache = values.nowritecache ? 0 : 1;
        this.callParent([values]);
     },