]> git.proxmox.com Git - pve-manager.git/commitdiff
ui: ceph/ServiceList: stop leaky versionsstores
authorDominik Csapak <d.csapak@proxmox.com>
Thu, 2 Apr 2020 08:53:44 +0000 (10:53 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Thu, 2 Apr 2020 09:10:48 +0000 (11:10 +0200)
on the view destroy we have to stop the updatestore again,
they do not get cleaned up by a destroy because until they are stopped
the have a reference on themselves, which prevent a garbage collection

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
www/manager6/ceph/ServiceList.js

index b7670395cfbcf0217a2114d85ed42931001c77c0..d5c317c1f9ac2598f3ee5903092e16eaf102e68a 100644 (file)
@@ -132,6 +132,7 @@ Ext.define('PVE.node.CephServiceList', {
            });
 
            view.versionsstore.on('load', this.getMaxVersions, this);
+           view.on('destroy', view.versionsstore.stopUpdate);
 
            view.rstore = Ext.create('Proxmox.data.UpdateStore', {
                autoLoad: true,