my $plugins = PVE::Network::SDN::Dhcp::Plugin->lookup_types();
+ my $any_zone_needs_dhcp = grep { $_->{dhcp} } values $zone_cfg->{ids}->%*;
+
foreach my $plugin_name (@$plugins) {
my $plugin = PVE::Network::SDN::Dhcp::Plugin->lookup($plugin_name);
- eval { $plugin->before_regenerate() };
+ eval { $plugin->before_regenerate(!$any_zone_needs_dhcp) };
die "Could not run before_regenerate for DHCP plugin $plugin_name $@\n" if $@;
}
warn "Could not configure vnet $vnetid: $@\n" if $@;
}
- eval { $dhcp_plugin->after_configure($zoneid) };
+ eval { $dhcp_plugin->after_configure($zoneid, !$any_zone_needs_dhcp) };
warn "Could not run after_configure for DHCP server $zoneid $@\n" if $@;
}
return 'dnsmasq';
}
+my sub assert_dnsmasq_installed {
+ my ($noerr) = @_;
+
+ my $bin_path = "/usr/sbin/dnsmasq";
+ if (!-e $bin_path) {
+ log_warn("please install the 'dnsmasq' package in order to use the DHCP feature!");
+ return if $noerr; # just ignore, e.g., in case zone doesn't use DHCP at all
+ die "cannot reload with missing 'dnsmasq' package\n";
+ }
+ return 1;
+}
+
sub add_ip_mapping {
my ($class, $dhcpid, $macdb, $mac, $ip4, $ip6) = @_;
}
sub after_configure {
- my ($class, $dhcpid) = @_;
+ my ($class, $dhcpid, $noerr) = @_;
+
+ return if !assert_dnsmasq_installed($noerr);
my $service_name = "dnsmasq\@$dhcpid";
}
sub before_regenerate {
- my ($class) = @_;
+ my ($class, $noerr) = @_;
- my $bin_path = "/usr/sbin/dnsmasq";
- if (!-e $bin_path) {
- log_warn("Please install dnsmasq in order to use the DHCP feature!");
- die;
- }
+ return if !assert_dnsmasq_installed($noerr);
PVE::Tools::run_command(['systemctl', 'stop', "dnsmasq@*"]);
PVE::Tools::run_command(['systemctl', 'disable', 'dnsmasq@']);