]>
Commit | Line | Data |
---|---|---|
6838f038 WB |
1 | From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 |
2 | From: Wolfgang Bumiller <w.bumiller@proxmox.com> | |
3 | Date: Wed, 29 Nov 2017 11:11:46 +0100 | |
4 | Subject: [PATCH] block/file: change locking default to off | |
5 | ||
6 | 'auto' only checks whether the system generally supports OFD | |
7 | locks but not whether the storage the file resides on | |
8 | supports any locking, causing issues with NFS. | |
9 | ||
10 | Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com> | |
11 | --- | |
12 | block/file-posix.c | 4 ++-- | |
13 | 1 file changed, 2 insertions(+), 2 deletions(-) | |
14 | ||
15 | diff --git a/block/file-posix.c b/block/file-posix.c | |
9b05d1d4 | 16 | index 275953fdc6..b639206879 100644 |
6838f038 WB |
17 | --- a/block/file-posix.c |
18 | +++ b/block/file-posix.c | |
19 | @@ -405,7 +405,7 @@ static QemuOptsList raw_runtime_opts = { | |
20 | { | |
21 | .name = "locking", | |
22 | .type = QEMU_OPT_STRING, | |
23 | - .help = "file locking mode (on/off/auto, default: auto)", | |
24 | + .help = "file locking mode (on/off/auto, default: off)", | |
25 | }, | |
26 | { | |
27 | .name = "pr-manager", | |
28 | @@ -481,7 +481,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, | |
29 | s->use_lock = false; | |
30 | break; | |
31 | case ON_OFF_AUTO_AUTO: | |
32 | - s->use_lock = qemu_has_ofd_lock(); | |
33 | + s->use_lock = false; | |
34 | break; | |
35 | default: | |
36 | abort(); | |
37 | -- | |
38 | 2.11.0 | |
39 |