]>
Commit | Line | Data |
---|---|---|
e220dcdd WB |
1 | From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 |
2 | From: Wolfgang Bumiller <w.bumiller@proxmox.com> | |
3 | Date: Mon, 26 Mar 2018 14:20:31 +0200 | |
4 | Subject: [PATCH] rbd: fix cache mode behavior | |
5 | ||
6 | Either the cache mode asks for a cache or not. There's no | |
7 | point in having a "temporary" cache mode. This option AFAIK | |
8 | was introduced as a hack for ancient virtio drivers. If | |
9 | anything, we should have a separate option for it. Better | |
10 | yet, VMs affected by the related issue should simply | |
11 | explicitly choose writethrough. | |
12 | ||
13 | Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com> | |
14 | --- | |
15 | block/rbd.c | 2 -- | |
16 | 1 file changed, 2 deletions(-) | |
17 | ||
18 | diff --git a/block/rbd.c b/block/rbd.c | |
9b05d1d4 | 19 | index c4732a4b12..0374f3db27 100644 |
e220dcdd WB |
20 | --- a/block/rbd.c |
21 | +++ b/block/rbd.c | |
9b05d1d4 | 22 | @@ -643,9 +643,7 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags, |
e220dcdd WB |
23 | rados_conf_set(s->cluster, "rbd_cache", "true"); |
24 | } | |
25 | ||
26 | - if (flags & BDRV_O_NO_FLUSH) { | |
27 | rados_conf_set(s->cluster, "rbd_cache_writethrough_until_flush", "false"); | |
28 | - } | |
29 | ||
30 | r = rados_connect(s->cluster); | |
31 | if (r < 0) { | |
32 | -- | |
33 | 2.11.0 | |
34 |