]>
Commit | Line | Data |
---|---|---|
83faa3fe | 1 | From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 |
059a9447 | 2 | From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> |
83faa3fe TL |
3 | Date: Mon, 6 Apr 2020 12:17:05 +0200 |
4 | Subject: [PATCH] mirror: add check for bitmap-mode without bitmap | |
059a9447 FG |
5 | MIME-Version: 1.0 |
6 | Content-Type: text/plain; charset=UTF-8 | |
7 | Content-Transfer-Encoding: 8bit | |
8 | ||
9 | as one without the other does not make much sense with the current set | |
10 | of modes. | |
11 | ||
12 | Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> | |
13 | --- | |
14 | blockdev.c | 3 +++ | |
15 | 1 file changed, 3 insertions(+) | |
16 | ||
17 | diff --git a/blockdev.c b/blockdev.c | |
d333327a | 18 | index 02d58e7645..0d480f02c7 100644 |
059a9447 FG |
19 | --- a/blockdev.c |
20 | +++ b/blockdev.c | |
d333327a | 21 | @@ -2974,6 +2974,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs, |
059a9447 FG |
22 | if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_ALLOW_RO, errp)) { |
23 | return; | |
24 | } | |
25 | + } else if (has_bitmap_mode) { | |
26 | + error_setg(errp, "Cannot specify bitmap sync mode without a bitmap"); | |
27 | + return; | |
28 | } | |
29 | ||
30 | if (has_replaces) { |