]> git.proxmox.com Git - pve-storage.git/blob - PVE/Storage/RBDPlugin.pm
rbd: use add/delete hooks
[pve-storage.git] / PVE / Storage / RBDPlugin.pm
1 package PVE::Storage::RBDPlugin;
2
3 use strict;
4 use warnings;
5 use IO::File;
6 use Net::IP;
7 use PVE::Tools qw(run_command trim);
8 use PVE::Storage::Plugin;
9 use PVE::JSONSchema qw(get_standard_option);
10 use PVE::RADOS;
11
12 use base qw(PVE::Storage::Plugin);
13
14 my $rbd_unittobytes = {
15 "k" => 1024,
16 "M" => 1024*1024,
17 "G" => 1024*1024*1024,
18 "T" => 1024*1024*1024*1024,
19 };
20
21 my $add_pool_to_disk = sub {
22 my ($scfg, $disk) = @_;
23
24 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
25
26 return "$pool/$disk";
27 };
28
29 my $hostlist = sub {
30 my ($list_text, $separator) = @_;
31
32 my @monhostlist = PVE::Tools::split_list($list_text);
33 return join($separator, map {
34 my ($host, $port) = PVE::Tools::parse_host_and_port($_);
35 $port = defined($port) ? ":$port" : '';
36 $host = "[$host]" if Net::IP::ip_is_ipv6($host);
37 "${host}${port}"
38 } @monhostlist);
39 };
40
41 my $ceph_connect_option = sub {
42 my ($scfg, $storeid, %options) = @_;
43
44 my $cmd_option = {};
45 my $ceph_storeid_conf = "/etc/pve/priv/ceph/${storeid}.conf";
46 my $pveceph_config = '/etc/pve/ceph.conf';
47 my $keyring = "/etc/pve/priv/ceph/${storeid}.keyring";
48 my $pveceph_managed = !defined($scfg->{monhost});
49
50 $cmd_option->{ceph_conf} = $pveceph_config if $pveceph_managed;
51
52 if (-e $ceph_storeid_conf) {
53 if ($pveceph_managed) {
54 warn "ignoring custom ceph config for storage '$storeid', 'monhost' is not set (assuming pveceph managed cluster)!\n";
55 } else {
56 $cmd_option->{ceph_conf} = $ceph_storeid_conf;
57 }
58 }
59
60 $cmd_option->{keyring} = $keyring if (-e $keyring);
61 $cmd_option->{auth_supported} = (defined $cmd_option->{keyring}) ? 'cephx' : 'none';
62 $cmd_option->{userid} = $scfg->{username} ? $scfg->{username} : 'admin';
63 $cmd_option->{mon_host} = $hostlist->($scfg->{monhost}, ',') if (defined($scfg->{monhost}));
64
65 if (%options) {
66 foreach my $k (keys %options) {
67 $cmd_option->{$k} = $options{$k};
68 }
69 }
70
71 return $cmd_option;
72
73 };
74
75 my $build_cmd = sub {
76 my ($binary, $scfg, $storeid, $op, @options) = @_;
77
78 my $cmd_option = $ceph_connect_option->($scfg, $storeid);
79 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
80
81 my $cmd = [$binary, '-p', $pool];
82
83 push @$cmd, '-c', $cmd_option->{ceph_conf} if ($cmd_option->{ceph_conf});
84 push @$cmd, '-m', $cmd_option->{mon_host} if ($cmd_option->{mon_host});
85 push @$cmd, '--auth_supported', $cmd_option->{auth_supported} if ($cmd_option->{auth_supported});
86 push @$cmd, '-n', "client.$cmd_option->{userid}" if ($cmd_option->{userid});
87 push @$cmd, '--keyring', $cmd_option->{keyring} if ($cmd_option->{keyring});
88
89 push @$cmd, $op;
90
91 push @$cmd, @options if scalar(@options);
92
93 return $cmd;
94 };
95
96 my $rbd_cmd = sub {
97 my ($scfg, $storeid, $op, @options) = @_;
98
99 return $build_cmd->('/usr/bin/rbd', $scfg, $storeid, $op, @options);
100 };
101
102 my $rados_cmd = sub {
103 my ($scfg, $storeid, $op, @options) = @_;
104
105 return $build_cmd->('/usr/bin/rados', $scfg, $storeid, $op, @options);
106 };
107
108 my $librados_connect = sub {
109 my ($scfg, $storeid, $options) = @_;
110
111 my $librados_config = $ceph_connect_option->($scfg, $storeid);
112
113 my $rados = PVE::RADOS->new(%$librados_config);
114
115 return $rados;
116 };
117
118 # needed for volumes created using ceph jewel (or higher)
119 my $krbd_feature_disable = sub {
120 my ($scfg, $storeid, $name) = @_;
121
122 return 1 if !$scfg->{krbd};
123
124 my ($major, undef, undef, undef) = ceph_version();
125 return 1 if $major < 10;
126
127 my $krbd_feature_blacklist = ['deep-flatten', 'fast-diff', 'object-map', 'exclusive-lock'];
128 my (undef, undef, undef, undef, $features) = rbd_volume_info($scfg, $storeid, $name);
129
130 my $active_features = { map { $_ => 1 } PVE::Tools::split_list($features)};
131 my $incompatible_features = join(',', grep { %$active_features{$_} } @$krbd_feature_blacklist);
132
133 if ($incompatible_features) {
134 my $feature_cmd = &$rbd_cmd($scfg, $storeid, 'feature', 'disable', $name, $incompatible_features);
135 run_rbd_command($feature_cmd, errmsg => "could not disable krbd-incompatible image features of rbd volume $name");
136 }
137 };
138
139 my $ceph_version_parser = sub {
140 my $line = shift;
141 if ($line =~ m/^ceph version ((\d+)\.(\d+)\.(\d+))(?: \([a-fA-F0-9]+\))/) {
142 return ($2, $3, $4, $1);
143 } else {
144 warn "Could not parse Ceph version: '$line'\n";
145 }
146 };
147
148 sub ceph_version {
149 my ($cache) = @_;
150
151 my $version_string = $cache;
152
153 my $major;
154 my $minor;
155 my $bugfix;
156
157 if (defined($version_string)) {
158 ($major, $minor, $bugfix, $version_string) = &$ceph_version_parser($version_string);
159 } else {
160 run_command('ceph --version', outfunc => sub {
161 my $line = shift;
162 ($major, $minor, $bugfix, $version_string) = &$ceph_version_parser($line);
163 });
164 }
165 return undef if !defined($version_string);
166 return wantarray ? ($major, $minor, $bugfix, $version_string) : $version_string;
167 }
168
169 sub run_rbd_command {
170 my ($cmd, %args) = @_;
171
172 my $lasterr;
173 my $errmsg = $args{errmsg} . ": " || "";
174 if (!exists($args{errfunc})) {
175 # ' error: 2014-02-06 11:51:59.839135 7f09f94d0760 -1 librbd: snap_unprotect: can't unprotect;
176 # at least 1 child(ren) in pool cephstor1
177 $args{errfunc} = sub {
178 my $line = shift;
179 if ($line =~ m/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}\.\d+ [0-9a-f]+ [\-\d]+ librbd: (.*)$/) {
180 $lasterr = "$1\n";
181 } else {
182 $lasterr = $line;
183 }
184 print STDERR $lasterr;
185 *STDERR->flush();
186 };
187 }
188
189 eval { run_command($cmd, %args); };
190 if (my $err = $@) {
191 die $errmsg . $lasterr if length($lasterr);
192 die $err;
193 }
194
195 return undef;
196 }
197
198 sub rbd_ls {
199 my ($scfg, $storeid) = @_;
200
201 my $cmd = &$rbd_cmd($scfg, $storeid, 'ls', '-l');
202 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
203
204 my $list = {};
205
206 my $parser = sub {
207 my $line = shift;
208
209 if ($line =~ m/^((vm|base)-(\d+)-\S+)\s+(\d+)(k|M|G|T)\s((\S+)\/((vm|base)-\d+-\S+@\S+))?/) {
210 my ($image, $owner, $size, $unit, $parent) = ($1, $3, $4, $5, $8);
211 return if $image =~ /@/; #skip snapshots
212
213 $list->{$pool}->{$image} = {
214 name => $image,
215 size => $size*$rbd_unittobytes->{$unit},
216 parent => $parent,
217 vmid => $owner
218 };
219 }
220 };
221
222 eval {
223 run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser);
224 };
225 my $err = $@;
226
227 die $err if $err && $err !~ m/doesn't contain rbd images/ ;
228
229 return $list;
230 }
231
232 sub rbd_volume_info {
233 my ($scfg, $storeid, $volname, $snap) = @_;
234
235 my $cmd = undef;
236
237 if($snap){
238 $cmd = &$rbd_cmd($scfg, $storeid, 'info', $volname, '--snap', $snap);
239 }else{
240 $cmd = &$rbd_cmd($scfg, $storeid, 'info', $volname);
241 }
242
243 my $size = undef;
244 my $parent = undef;
245 my $format = undef;
246 my $protected = undef;
247 my $features = undef;
248
249 my $parser = sub {
250 my $line = shift;
251
252 if ($line =~ m/size (\d+) (k|M|G|T)B in (\d+) objects/) {
253 $size = $1 * $rbd_unittobytes->{$2} if ($1);
254 } elsif ($line =~ m/parent:\s(\S+)\/(\S+)/) {
255 $parent = $2;
256 } elsif ($line =~ m/format:\s(\d+)/) {
257 $format = $1;
258 } elsif ($line =~ m/protected:\s(\S+)/) {
259 $protected = 1 if $1 eq "True";
260 } elsif ($line =~ m/features:\s(.+)/) {
261 $features = $1;
262 }
263
264 };
265
266 run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser);
267
268 return ($size, $parent, $format, $protected, $features);
269 }
270
271 # Configuration
272
273 sub type {
274 return 'rbd';
275 }
276
277 sub plugindata {
278 return {
279 content => [ {images => 1, rootdir => 1}, { images => 1 }],
280 };
281 }
282
283 sub properties {
284 return {
285 monhost => {
286 description => "IP addresses of monitors (for external clusters).",
287 type => 'string', format => 'pve-storage-portal-dns-list',
288 },
289 pool => {
290 description => "Pool.",
291 type => 'string',
292 },
293 username => {
294 description => "RBD Id.",
295 type => 'string',
296 },
297 authsupported => {
298 description => "Authsupported.",
299 type => 'string',
300 },
301 krbd => {
302 description => "Access rbd through krbd kernel module.",
303 type => 'boolean',
304 },
305 };
306 }
307
308 sub options {
309 return {
310 nodes => { optional => 1 },
311 disable => { optional => 1 },
312 monhost => { optional => 1},
313 pool => { optional => 1 },
314 username => { optional => 1 },
315 content => { optional => 1 },
316 krbd => { optional => 1 },
317 bwlimit => { optional => 1 },
318 };
319 }
320
321 # Storage implementation
322
323 sub on_add_hook {
324 my ($class, $storeid, $scfg, %param) = @_;
325
326 return if defined($scfg->{monhost}); # nothing to do if not pve managed ceph
327
328 my $ceph_admin_keyring = '/etc/pve/priv/ceph.client.admin.keyring';
329 my $ceph_storage_keyring = "/etc/pve/priv/ceph/${storeid}.keyring";
330
331 die "ceph authx keyring file for storage '$storeid' already exists!\n"
332 if -e $ceph_storage_keyring;
333
334 eval {
335 mkdir '/etc/pve/priv/ceph';
336 PVE::Tools::file_copy($ceph_admin_keyring, $ceph_storage_keyring);
337 };
338 if (my $err = $@) {
339 unlink $ceph_storage_keyring;
340 die "failed to copy ceph authx keyring for storage '$storeid': $err\n";
341 }
342
343 }
344
345 sub on_delete_hook {
346 my ($class, $storeid, $scfg) = @_;
347
348 return if defined($scfg->{monhost}); # nothing to do if not pve managed ceph
349
350 my $ceph_storage_keyring = "/etc/pve/priv/ceph/${storeid}.keyring";
351 if (-f $ceph_storage_keyring) {
352 unlink($ceph_storage_keyring) or warn "removing keyring of storage failed: $!\n";
353 }
354
355 }
356
357 sub parse_volname {
358 my ($class, $volname) = @_;
359
360 if ($volname =~ m/^((base-(\d+)-\S+)\/)?((base)?(vm)?-(\d+)-\S+)$/) {
361 return ('images', $4, $7, $2, $3, $5, 'raw');
362 }
363
364 die "unable to parse rbd volume name '$volname'\n";
365 }
366
367 sub path {
368 my ($class, $scfg, $volname, $storeid, $snapname) = @_;
369
370 my $cmd_option = $ceph_connect_option->($scfg, $storeid);
371 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
372 $name .= '@'.$snapname if $snapname;
373
374 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
375 return ("/dev/rbd/$pool/$name", $vmid, $vtype) if $scfg->{krbd};
376
377 my $path = "rbd:$pool/$name";
378
379 $path .= ":conf=$cmd_option->{ceph_conf}" if $cmd_option->{ceph_conf};
380 if (defined($scfg->{monhost})) {
381 my $monhost = $hostlist->($scfg->{monhost}, ';');
382 $monhost =~ s/:/\\:/g;
383 $path .= ":mon_host=$monhost";
384 $path .= ":auth_supported=$cmd_option->{auth_supported}";
385 }
386
387 $path .= ":id=$cmd_option->{userid}:keyring=$cmd_option->{keyring}" if ($cmd_option->{keyring});
388
389 return ($path, $vmid, $vtype);
390 }
391
392 my $find_free_diskname = sub {
393 my ($storeid, $scfg, $vmid) = @_;
394
395 my $cmd = &$rbd_cmd($scfg, $storeid, 'ls');
396 my $disk_ids = {};
397
398 my $parser = sub {
399 my $line = shift;
400
401 if ($line =~ m/^(vm|base)-\Q$vmid\E+-disk-(\d+)$/) {
402 $disk_ids->{$2} = 1;
403 }
404 };
405
406 eval {
407 run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser);
408 };
409 my $err = $@;
410
411 die $err if $err && $err !~ m/doesn't contain rbd images/;
412
413 #fix: can we search in $rbd hash key with a regex to find (vm|base) ?
414 for (my $i = 1; $i < 100; $i++) {
415 if (!$disk_ids->{$i}) {
416 return "vm-$vmid-disk-$i";
417 }
418 }
419
420 die "unable to allocate an image name for VM $vmid in storage '$storeid'\n";
421 };
422
423 sub create_base {
424 my ($class, $storeid, $scfg, $volname) = @_;
425
426 my $snap = '__base__';
427
428 my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =
429 $class->parse_volname($volname);
430
431 die "create_base not possible with base image\n" if $isBase;
432
433 my ($size, $parent, $format, undef) = rbd_volume_info($scfg, $storeid, $name);
434 die "rbd volume info on '$name' failed\n" if !($size);
435
436 die "rbd image must be at format V2" if $format ne "2";
437
438 die "volname '$volname' contains wrong information about parent $parent $basename\n"
439 if $basename && (!$parent || $parent ne $basename."@".$snap);
440
441 my $newname = $name;
442 $newname =~ s/^vm-/base-/;
443
444 my $newvolname = $basename ? "$basename/$newname" : "$newname";
445
446 my $cmd = &$rbd_cmd($scfg, $storeid, 'rename', &$add_pool_to_disk($scfg, $name), &$add_pool_to_disk($scfg, $newname));
447 run_rbd_command($cmd, errmsg => "rbd rename '$name' error");
448
449 my $running = undef; #fixme : is create_base always offline ?
450
451 $class->volume_snapshot($scfg, $storeid, $newname, $snap, $running);
452
453 my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $newname, $snap);
454
455 if (!$protected){
456 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'protect', $newname, '--snap', $snap);
457 run_rbd_command($cmd, errmsg => "rbd protect $newname snap '$snap' error");
458 }
459
460 return $newvolname;
461
462 }
463
464 sub clone_image {
465 my ($class, $scfg, $storeid, $volname, $vmid, $snapname) = @_;
466
467 my $snap = '__base__';
468 $snap = $snapname if length $snapname;
469
470 my ($vtype, $basename, $basevmid, undef, undef, $isBase) =
471 $class->parse_volname($volname);
472
473 die "$volname is not a base image and snapname is not provided\n"
474 if !$isBase && !length($snapname);
475
476 my $name = &$find_free_diskname($storeid, $scfg, $vmid);
477
478 warn "clone $volname: $basename snapname $snap to $name\n";
479
480 if (length($snapname)) {
481 my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $volname, $snapname);
482
483 if (!$protected) {
484 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'protect', $volname, '--snap', $snapname);
485 run_rbd_command($cmd, errmsg => "rbd protect $volname snap $snapname error");
486 }
487 }
488
489 my $newvol = "$basename/$name";
490 $newvol = $name if length($snapname);
491
492 my $cmd = &$rbd_cmd($scfg, $storeid, 'clone', &$add_pool_to_disk($scfg, $basename),
493 '--snap', $snap, &$add_pool_to_disk($scfg, $name));
494
495 run_rbd_command($cmd, errmsg => "rbd clone '$basename' error");
496
497 &$krbd_feature_disable($scfg, $storeid, $name);
498
499 return $newvol;
500 }
501
502 sub alloc_image {
503 my ($class, $storeid, $scfg, $vmid, $fmt, $name, $size) = @_;
504
505
506 die "illegal name '$name' - should be 'vm-$vmid-*'\n"
507 if $name && $name !~ m/^vm-$vmid-/;
508
509 $name = &$find_free_diskname($storeid, $scfg, $vmid) if !$name;
510
511 my $cmd = &$rbd_cmd($scfg, $storeid, 'create', '--image-format' , 2, '--size', int(($size+1023)/1024), $name);
512 run_rbd_command($cmd, errmsg => "rbd create $name' error");
513
514 &$krbd_feature_disable($scfg, $storeid, $name);
515
516 return $name;
517 }
518
519 sub free_image {
520 my ($class, $storeid, $scfg, $volname, $isBase) = @_;
521
522 my ($vtype, $name, $vmid, undef, undef, undef) =
523 $class->parse_volname($volname);
524
525 if ($isBase) {
526 my $snap = '__base__';
527 my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $name, $snap);
528 if ($protected){
529 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'unprotect', $name, '--snap', $snap);
530 run_rbd_command($cmd, errmsg => "rbd unprotect $name snap '$snap' error");
531 }
532 }
533
534 $class->deactivate_volume($storeid, $scfg, $volname);
535
536 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'purge', $name);
537 run_rbd_command($cmd, errmsg => "rbd snap purge '$volname' error");
538
539 $cmd = &$rbd_cmd($scfg, $storeid, 'rm', $name);
540 run_rbd_command($cmd, errmsg => "rbd rm '$volname' error");
541
542 return undef;
543 }
544
545 sub list_images {
546 my ($class, $storeid, $scfg, $vmid, $vollist, $cache) = @_;
547
548 $cache->{rbd} = rbd_ls($scfg, $storeid) if !$cache->{rbd};
549 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
550
551 my $res = [];
552
553 if (my $dat = $cache->{rbd}->{$pool}) {
554 foreach my $image (keys %$dat) {
555
556 my $info = $dat->{$image};
557
558 my $volname = $info->{name};
559 my $parent = $info->{parent};
560 my $owner = $info->{vmid};
561
562 if ($parent && $parent =~ m/^(base-\d+-\S+)\@__base__$/) {
563 $info->{volid} = "$storeid:$1/$volname";
564 } else {
565 $info->{volid} = "$storeid:$volname";
566 }
567
568 if ($vollist) {
569 my $found = grep { $_ eq $info->{volid} } @$vollist;
570 next if !$found;
571 } else {
572 next if defined ($vmid) && ($owner ne $vmid);
573 }
574
575 $info->{format} = 'raw';
576
577 push @$res, $info;
578 }
579 }
580
581 return $res;
582 }
583
584 sub status {
585 my ($class, $storeid, $scfg, $cache) = @_;
586
587
588 my $rados = &$librados_connect($scfg, $storeid);
589 my $df = $rados->mon_command({ prefix => 'df', format => 'json' });
590
591 my ($d) = grep { $_->{name} eq $scfg->{pool} } @{$df->{pools}};
592
593 # max_avail -> max available space for data w/o replication in the pool
594 # bytes_used -> data w/o replication in the pool
595 my $free = $d->{stats}->{max_avail};
596 my $used = $d->{stats}->{bytes_used};
597 my $total = $used + $free;
598 my $active = 1;
599
600 return ($total, $free, $used, $active);
601 }
602
603 sub activate_storage {
604 my ($class, $storeid, $scfg, $cache) = @_;
605 return 1;
606 }
607
608 sub deactivate_storage {
609 my ($class, $storeid, $scfg, $cache) = @_;
610 return 1;
611 }
612
613 sub activate_volume {
614 my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
615
616 return 1 if !$scfg->{krbd};
617
618 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
619 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
620
621 my $path = "/dev/rbd/$pool/$name";
622 $path .= '@'.$snapname if $snapname;
623 return if -b $path;
624
625 $name .= '@'.$snapname if $snapname;
626 my $cmd = &$rbd_cmd($scfg, $storeid, 'map', $name);
627 run_rbd_command($cmd, errmsg => "can't mount rbd volume $name");
628
629 return 1;
630 }
631
632 sub deactivate_volume {
633 my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
634
635 return 1 if !$scfg->{krbd};
636
637 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
638 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
639
640 my $path = "/dev/rbd/$pool/$name";
641 $path .= '@'.$snapname if $snapname;
642 return if ! -b $path;
643
644 my $cmd = &$rbd_cmd($scfg, $storeid, 'unmap', $path);
645 run_rbd_command($cmd, errmsg => "can't unmap rbd volume $name");
646
647 return 1;
648 }
649
650 sub volume_size_info {
651 my ($class, $scfg, $storeid, $volname, $timeout) = @_;
652
653 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
654 my ($size, undef) = rbd_volume_info($scfg, $storeid, $name);
655 return $size;
656 }
657
658 sub volume_resize {
659 my ($class, $scfg, $storeid, $volname, $size, $running) = @_;
660
661 return 1 if $running && !$scfg->{krbd};
662
663 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
664
665 my $cmd = &$rbd_cmd($scfg, $storeid, 'resize', '--allow-shrink', '--size', ($size/1024/1024), $name);
666 run_rbd_command($cmd, errmsg => "rbd resize '$volname' error");
667 return undef;
668 }
669
670 sub volume_snapshot {
671 my ($class, $scfg, $storeid, $volname, $snap) = @_;
672
673 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
674
675 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'create', '--snap', $snap, $name);
676 run_rbd_command($cmd, errmsg => "rbd snapshot '$volname' error");
677 return undef;
678 }
679
680 sub volume_snapshot_rollback {
681 my ($class, $scfg, $storeid, $volname, $snap) = @_;
682
683 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
684
685 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'rollback', '--snap', $snap, $name);
686 run_rbd_command($cmd, errmsg => "rbd snapshot $volname to '$snap' error");
687 }
688
689 sub volume_snapshot_delete {
690 my ($class, $scfg, $storeid, $volname, $snap, $running) = @_;
691
692 return 1 if $running && !$scfg->{krbd};
693
694 $class->deactivate_volume($storeid, $scfg, $volname, $snap, {});
695
696 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
697
698 my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $name, $snap);
699 if ($protected){
700 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'unprotect', $name, '--snap', $snap);
701 run_rbd_command($cmd, errmsg => "rbd unprotect $name snap '$snap' error");
702 }
703
704 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'rm', '--snap', $snap, $name);
705
706 run_rbd_command($cmd, errmsg => "rbd snapshot '$volname' error");
707
708 return undef;
709 }
710
711 sub volume_has_feature {
712 my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running) = @_;
713
714 my $features = {
715 snapshot => { current => 1, snap => 1},
716 clone => { base => 1, snap => 1},
717 template => { current => 1},
718 copy => { base => 1, current => 1, snap => 1},
719 sparseinit => { base => 1, current => 1},
720 };
721
722 my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =
723 $class->parse_volname($volname);
724
725 my $key = undef;
726 if($snapname){
727 $key = 'snap';
728 }else{
729 $key = $isBase ? 'base' : 'current';
730 }
731 return 1 if $features->{$feature}->{$key};
732
733 return undef;
734 }
735
736 1;