PVE/Storage/RBDPlugin.pm

   1 package PVE::Storage::RBDPlugin;
   2
   3 use strict;
   4 use warnings;
   5
   6 use IO::File;
   7 use JSON;
   8 use Net::IP;
   9
  10 use PVE::CephConfig;
  11 use PVE::JSONSchema qw(get_standard_option);
  12 use PVE::ProcFSTools;
  13 use PVE::RADOS;
  14 use PVE::Storage::Plugin;
  15 use PVE::Tools qw(run_command trim);
  16
  17 use base qw(PVE::Storage::Plugin);
  18
  19 my $get_parent_image_name = sub {
  20     my ($parent) = @_;
  21     return undef if !$parent;
  22     return $parent->{image} . "@" . $parent->{snapshot};
  23 };
  24
  25 my $add_pool_to_disk = sub {
  26     my ($scfg, $disk) = @_;
  27
  28     my $pool =  $scfg->{pool} ? $scfg->{pool} : 'rbd';
  29
  30     return "$pool/$disk";
  31 };
  32
  33 my $build_cmd = sub {
  34     my ($binary, $scfg, $storeid, $op, @options) = @_;
  35
  36     my $cmd_option = PVE::CephConfig::ceph_connect_option($scfg, $storeid);
  37     my $pool =  $scfg->{pool} ? $scfg->{pool} : 'rbd';
  38
  39     my $cmd = [$binary, '-p', $pool];
  40
  41     push @$cmd, '-c', $cmd_option->{ceph_conf} if ($cmd_option->{ceph_conf});
  42     push @$cmd, '-m', $cmd_option->{mon_host} if ($cmd_option->{mon_host});
  43     push @$cmd, '--auth_supported', $cmd_option->{auth_supported} if ($cmd_option->{auth_supported});
  44     push @$cmd, '-n', "client.$cmd_option->{userid}" if ($cmd_option->{userid});
  45     push @$cmd, '--keyring', $cmd_option->{keyring} if ($cmd_option->{keyring});
  46
  47     push @$cmd, $op;
  48
  49     push @$cmd, @options if scalar(@options);
  50
  51     return $cmd;
  52 };
  53
  54 my $rbd_cmd = sub {
  55     my ($scfg, $storeid, $op, @options) = @_;
  56
  57     return $build_cmd->('/usr/bin/rbd', $scfg, $storeid, $op, @options);
  58 };
  59
  60 my $rados_cmd = sub {
  61     my ($scfg, $storeid, $op, @options) = @_;
  62
  63     return $build_cmd->('/usr/bin/rados', $scfg, $storeid, $op, @options);
  64 };
  65
  66 my $librados_connect = sub {
  67     my ($scfg, $storeid, $options) = @_;
  68
  69     my $librados_config = PVE::CephConfig::ceph_connect_option($scfg, $storeid);
  70
  71     my $rados = PVE::RADOS->new(%$librados_config);
  72
  73     return $rados;
  74 };
  75
  76 # needed for volumes created using ceph jewel (or higher)
  77 my $krbd_feature_update = sub {
  78     my ($scfg, $storeid, $name) = @_;
  79
  80     my (@disable, @enable);
  81     my ($kmajor, $kminor) = PVE::ProcFSTools::kernel_version();
  82
  83     if ($kmajor > 5 || $kmajor == 5 && $kminor >= 3) {
  84         # 'deep-flatten' can only be disabled, not enabled after image creation
  85         push @enable, 'fast-diff', 'object-map';
  86     } else {
  87         push @disable, 'fast-diff', 'object-map', 'deep-flatten';
  88     }
  89
  90     if ($kmajor >= 5) {
  91         push @enable, 'exclusive-lock';
  92     } else {
  93         push @disable, 'exclusive-lock';
  94     }
  95
  96     my $active_features_list = (rbd_volume_info($scfg, $storeid, $name))[4];
  97     my $active_features = { map { $_ => 1 } @$active_features_list };
  98
  99     my $to_disable = join(',', grep {  $active_features->{$_} } @disable);
 100     my $to_enable  = join(',', grep { !$active_features->{$_} } @enable );
 101
 102     if ($to_disable) {
 103         print "disable RBD image features this kernel RBD drivers is not compatible with: $to_disable\n";
 104         my $cmd = $rbd_cmd->($scfg, $storeid, 'feature', 'disable', $name, $to_disable);
 105         run_rbd_command(
 106             $cmd,
 107             errmsg => "could not disable krbd-incompatible image features '$to_disable' for rbd image: $name",
 108         );
 109     }
 110     if ($to_enable) {
 111         print "enable RBD image features this kernel RBD drivers supports: $to_enable\n";
 112         eval {
 113             my $cmd = $rbd_cmd->($scfg, $storeid, 'feature', 'enable', $name, $to_enable);
 114             run_rbd_command(
 115                 $cmd,
 116                 errmsg => "could not enable krbd-compatible image features '$to_enable' for rbd image: $name",
 117             );
 118         };
 119         warn "$@" if $@;
 120     }
 121 };
 122
 123 sub run_rbd_command {
 124     my ($cmd, %args) = @_;
 125
 126     my $lasterr;
 127     my $errmsg = $args{errmsg} . ": " || "";
 128     if (!exists($args{errfunc})) {
 129         # ' error: 2014-02-06 11:51:59.839135 7f09f94d0760 -1 librbd: snap_unprotect: can't unprotect;
 130         # at least 1 child(ren) in pool cephstor1
 131         $args{errfunc} = sub {
 132             my $line = shift;
 133             if ($line =~ m/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}\.\d+ [0-9a-f]+ [\-\d]+ librbd: (.*)$/) {
 134                 $lasterr = "$1\n";
 135             } else {
 136                 $lasterr = $line;
 137             }
 138             print STDERR $lasterr;
 139             *STDERR->flush();
 140         };
 141     }
 142
 143     eval { run_command($cmd, %args); };
 144     if (my $err = $@) {
 145         die $errmsg . $lasterr if length($lasterr);
 146         die $err;
 147     }
 148
 149     return undef;
 150 }
 151
 152 sub rbd_ls {
 153     my ($scfg, $storeid) = @_;
 154
 155     my $cmd = &$rbd_cmd($scfg, $storeid, 'ls', '-l', '--format', 'json');
 156     my $pool =  $scfg->{pool} ? $scfg->{pool} : 'rbd';
 157
 158     my $raw = '';
 159     my $parser = sub { $raw .= shift };
 160
 161     eval {
 162         run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser);
 163     };
 164     my $err = $@;
 165
 166     die $err if $err && $err !~ m/doesn't contain rbd images/ ;
 167
 168     my $result;
 169     if ($raw eq '') {
 170         $result = [];
 171     } elsif ($raw =~ m/^(\[.*\])$/s) { # untaint
 172         $result = JSON::decode_json($1);
 173     } else {
 174         die "got unexpected data from rbd ls: '$raw'\n";
 175     }
 176
 177     my $list = {};
 178
 179     foreach my $el (@$result) {
 180         next if defined($el->{snapshot});
 181
 182         my $image = $el->{image};
 183
 184         my ($owner) = $image =~ m/^(?:vm|base)-(\d+)-/;
 185         next if !defined($owner);
 186
 187         $list->{$pool}->{$image} = {
 188             name => $image,
 189             size => $el->{size},
 190             parent => $get_parent_image_name->($el->{parent}),
 191             vmid => $owner
 192         };
 193     }
 194
 195     return $list;
 196 }
 197
 198 sub rbd_ls_snap {
 199     my ($scfg, $storeid, $name) = @_;
 200
 201     my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'ls', $name, '--format', 'json');
 202
 203     my $raw = '';
 204     run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => sub { $raw .= shift; });
 205
 206     my $list;
 207     if ($raw =~ m/^(\[.*\])$/s) { # untaint
 208         $list = eval { JSON::decode_json($1) };
 209         die "invalid JSON output from 'rbd snap ls $name': $@\n" if $@;
 210     } else {
 211         die "got unexpected data from 'rbd snap ls $name': '$raw'\n";
 212     }
 213
 214     $list = [] if !defined($list);
 215
 216     my $res = {};
 217     foreach my $el (@$list) {
 218         my $snap = $el->{name};
 219         my $protected = defined($el->{protected}) && $el->{protected} eq "true" ? 1 : undef;
 220         $res->{$snap} = {
 221             name => $snap,
 222             id => $el->{id} // undef,
 223             size => $el->{size} // 0,
 224             protected => $protected,
 225         };
 226     }
 227     return $res;
 228 }
 229
 230 sub rbd_volume_info {
 231     my ($scfg, $storeid, $volname, $snap) = @_;
 232
 233     my $cmd = undef;
 234
 235     my @options = ('info', $volname, '--format', 'json');
 236     if ($snap) {
 237         push @options, '--snap', $snap;
 238     }
 239
 240     $cmd = &$rbd_cmd($scfg, $storeid, @options);
 241
 242     my $raw = '';
 243     my $parser = sub { $raw .= shift };
 244
 245     run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser);
 246
 247     my $volume;
 248     if ($raw eq '') {
 249         $volume = {};
 250     } elsif ($raw =~ m/^(\{.*\})$/s) { # untaint
 251         $volume = JSON::decode_json($1);
 252     } else {
 253         die "got unexpected data from rbd info: '$raw'\n";
 254     }
 255
 256     $volume->{parent} = $get_parent_image_name->($volume->{parent});
 257     $volume->{protected} = defined($volume->{protected}) && $volume->{protected} eq "true" ? 1 : undef;
 258
 259     return $volume->@{qw(size parent format protected features)};
 260 }
 261
 262 # Configuration
 263
 264 sub type {
 265     return 'rbd';
 266 }
 267
 268 sub plugindata {
 269     return {
 270         content => [ {images => 1, rootdir => 1}, { images => 1 }],
 271     };
 272 }
 273
 274 sub properties {
 275     return {
 276         monhost => {
 277             description => "IP addresses of monitors (for external clusters).",
 278             type => 'string', format => 'pve-storage-portal-dns-list',
 279         },
 280         pool => {
 281             description => "Pool.",
 282             type => 'string',
 283         },
 284         username => {
 285             description => "RBD Id.",
 286             type => 'string',
 287         },
 288         authsupported => {
 289             description => "Authsupported.",
 290             type => 'string',
 291         },
 292         krbd => {
 293             description => "Always access rbd through krbd kernel module.",
 294             type => 'boolean',
 295         },
 296     };
 297 }
 298
 299 sub options {
 300     return {
 301         nodes => { optional => 1 },
 302         disable => { optional => 1 },
 303         monhost => { optional => 1},
 304         pool => { optional => 1 },
 305         username => { optional => 1 },
 306         content => { optional => 1 },
 307         krbd => { optional => 1 },
 308         bwlimit => { optional => 1 },
 309     };
 310 }
 311
 312 # Storage implementation
 313
 314 sub on_add_hook {
 315     my ($class, $storeid, $scfg, %param) = @_;
 316
 317     return if defined($scfg->{monhost}); # nothing to do if not pve managed ceph
 318
 319     PVE::CephConfig::ceph_create_keyfile($scfg->{type}, $storeid);
 320
 321     return;
 322 }
 323
 324 sub on_delete_hook {
 325     my ($class, $storeid, $scfg) = @_;
 326
 327     return if defined($scfg->{monhost}); # nothing to do if not pve managed ceph
 328
 329     PVE::CephConfig::ceph_remove_keyfile($scfg->{type}, $storeid);
 330
 331     return;
 332 }
 333
 334 sub parse_volname {
 335     my ($class, $volname) = @_;
 336
 337     if ($volname =~ m/^((base-(\d+)-\S+)\/)?((base)?(vm)?-(\d+)-\S+)$/) {
 338         return ('images', $4, $7, $2, $3, $5, 'raw');
 339     }
 340
 341     die "unable to parse rbd volume name '$volname'\n";
 342 }
 343
 344 sub path {
 345     my ($class, $scfg, $volname, $storeid, $snapname) = @_;
 346
 347     my $cmd_option = PVE::CephConfig::ceph_connect_option($scfg, $storeid);
 348     my ($vtype, $name, $vmid) = $class->parse_volname($volname);
 349     $name .= '@'.$snapname if $snapname;
 350
 351     my $pool =  $scfg->{pool} ? $scfg->{pool} : 'rbd';
 352     return ("/dev/rbd/$pool/$name", $vmid, $vtype) if $scfg->{krbd};
 353
 354     my $path = "rbd:$pool/$name";
 355
 356     $path .= ":conf=$cmd_option->{ceph_conf}" if $cmd_option->{ceph_conf};
 357     if (defined($scfg->{monhost})) {
 358         my $monhost = PVE::CephConfig::hostlist($scfg->{monhost}, ';');
 359         $monhost =~ s/:/\\:/g;
 360         $path .= ":mon_host=$monhost";
 361         $path .= ":auth_supported=$cmd_option->{auth_supported}";
 362     }
 363
 364     $path .= ":id=$cmd_option->{userid}:keyring=$cmd_option->{keyring}" if ($cmd_option->{keyring});
 365
 366     return ($path, $vmid, $vtype);
 367 }
 368
 369 sub find_free_diskname {
 370     my ($class, $storeid, $scfg, $vmid, $fmt, $add_fmt_suffix) = @_;
 371
 372     my $cmd = &$rbd_cmd($scfg, $storeid, 'ls');
 373     my $disk_list = [];
 374
 375     my $parser = sub {
 376         my $line = shift;
 377         if ($line =~ m/^(.*)$/) { # untaint
 378             push @$disk_list, $1;
 379         }
 380     };
 381
 382     eval {
 383         run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser);
 384     };
 385     my $err = $@;
 386
 387     die $err if $err && $err !~ m/doesn't contain rbd images/;
 388
 389     return PVE::Storage::Plugin::get_next_vm_diskname($disk_list, $storeid, $vmid, undef, $scfg);
 390 }
 391
 392 sub create_base {
 393     my ($class, $storeid, $scfg, $volname) = @_;
 394
 395     my $snap = '__base__';
 396
 397     my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =
 398         $class->parse_volname($volname);
 399
 400     die "create_base not possible with base image\n" if $isBase;
 401
 402     my ($size, $parent, $format, undef) = rbd_volume_info($scfg, $storeid, $name);
 403     die "rbd volume info on '$name' failed\n" if !($size);
 404
 405     die "rbd image must be at format V2" if $format ne "2";
 406
 407     die "volname '$volname' contains wrong information about parent $parent $basename\n"
 408         if $basename && (!$parent || $parent ne $basename."@".$snap);
 409
 410     my $newname = $name;
 411     $newname =~ s/^vm-/base-/;
 412
 413     my $newvolname = $basename ? "$basename/$newname" : "$newname";
 414
 415     my $cmd = &$rbd_cmd($scfg, $storeid, 'rename', &$add_pool_to_disk($scfg, $name), &$add_pool_to_disk($scfg, $newname));
 416     run_rbd_command($cmd, errmsg => "rbd rename '$name' error");
 417
 418     my $running  = undef; #fixme : is create_base always offline ?
 419
 420     $class->volume_snapshot($scfg, $storeid, $newname, $snap, $running);
 421
 422     my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $newname, $snap);
 423
 424     if (!$protected){
 425         my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'protect', $newname, '--snap', $snap);
 426         run_rbd_command($cmd, errmsg => "rbd protect $newname snap '$snap' error");
 427     }
 428
 429     return $newvolname;
 430
 431 }
 432
 433 sub clone_image {
 434     my ($class, $scfg, $storeid, $volname, $vmid, $snapname) = @_;
 435
 436     my $snap = '__base__';
 437     $snap = $snapname if length $snapname;
 438
 439     my ($vtype, $basename, $basevmid, undef, undef, $isBase) =
 440         $class->parse_volname($volname);
 441
 442     die "$volname is not a base image and snapname is not provided\n"
 443         if !$isBase && !length($snapname);
 444
 445     my $name = $class->find_free_diskname($storeid, $scfg, $vmid);
 446
 447     warn "clone $volname: $basename snapname $snap to $name\n";
 448
 449     if (length($snapname)) {
 450         my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $volname, $snapname);
 451
 452         if (!$protected) {
 453             my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'protect', $volname, '--snap', $snapname);
 454             run_rbd_command($cmd, errmsg => "rbd protect $volname snap $snapname error");
 455         }
 456     }
 457
 458     my $newvol = "$basename/$name";
 459     $newvol = $name if length($snapname);
 460
 461     my $cmd = &$rbd_cmd($scfg, $storeid, 'clone', &$add_pool_to_disk($scfg, $basename),
 462                         '--snap', $snap, &$add_pool_to_disk($scfg, $name));
 463
 464     run_rbd_command($cmd, errmsg => "rbd clone '$basename' error");
 465
 466     return $newvol;
 467 }
 468
 469 sub alloc_image {
 470     my ($class, $storeid, $scfg, $vmid, $fmt, $name, $size) = @_;
 471
 472
 473     die "illegal name '$name' - should be 'vm-$vmid-*'\n"
 474         if  $name && $name !~ m/^vm-$vmid-/;
 475
 476     $name = $class->find_free_diskname($storeid, $scfg, $vmid) if !$name;
 477
 478     my $cmd = &$rbd_cmd($scfg, $storeid, 'create', '--image-format' , 2, '--size', int(($size+1023)/1024), $name);
 479     run_rbd_command($cmd, errmsg => "rbd create $name' error");
 480
 481     return $name;
 482 }
 483
 484 sub free_image {
 485     my ($class, $storeid, $scfg, $volname, $isBase) = @_;
 486
 487     my ($vtype, $name, $vmid, undef, undef, undef) =
 488         $class->parse_volname($volname);
 489
 490     my $snaps = rbd_ls_snap($scfg, $storeid, $name);
 491     foreach my $snap (keys %$snaps) {
 492         if ($snaps->{$snap}->{protected}) {
 493             my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'unprotect', $name, '--snap', $snap);
 494             run_rbd_command($cmd, errmsg => "rbd unprotect $name snap '$snap' error");
 495         }
 496     }
 497
 498     $class->deactivate_volume($storeid, $scfg, $volname);
 499
 500     my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'purge',  $name);
 501     run_rbd_command($cmd, errmsg => "rbd snap purge '$volname' error");
 502
 503     $cmd = &$rbd_cmd($scfg, $storeid, 'rm', $name);
 504     run_rbd_command($cmd, errmsg => "rbd rm '$volname' error");
 505
 506     return undef;
 507 }
 508
 509 sub list_images {
 510     my ($class, $storeid, $scfg, $vmid, $vollist, $cache) = @_;
 511
 512     $cache->{rbd} = rbd_ls($scfg, $storeid) if !$cache->{rbd};
 513     my $pool =  $scfg->{pool} ? $scfg->{pool} : 'rbd';
 514
 515     my $res = [];
 516
 517     if (my $dat = $cache->{rbd}->{$pool}) {
 518         foreach my $image (keys %$dat) {
 519
 520             my $info = $dat->{$image};
 521
 522             my $volname = $info->{name};
 523             my $parent = $info->{parent};
 524             my $owner = $info->{vmid};
 525
 526             if ($parent && $parent =~ m/^(base-\d+-\S+)\@__base__$/) {
 527                 $info->{volid} = "$storeid:$1/$volname";
 528             } else {
 529                 $info->{volid} = "$storeid:$volname";
 530             }
 531
 532             if ($vollist) {
 533                 my $found = grep { $_ eq $info->{volid} } @$vollist;
 534                 next if !$found;
 535             } else {
 536                 next if defined ($vmid) && ($owner ne $vmid);
 537             }
 538
 539             $info->{format} = 'raw';
 540
 541             push @$res, $info;
 542         }
 543     }
 544
 545     return $res;
 546 }
 547
 548 sub status {
 549     my ($class, $storeid, $scfg, $cache) = @_;
 550
 551
 552     my $rados = &$librados_connect($scfg, $storeid);
 553     my $df = $rados->mon_command({ prefix => 'df', format => 'json' });
 554
 555     my ($d) = grep { $_->{name} eq $scfg->{pool} } @{$df->{pools}};
 556
 557     # max_avail -> max available space for data w/o replication in the pool
 558     # bytes_used -> data w/o replication in the pool
 559     my $free = $d->{stats}->{max_avail};
 560     my $used = $d->{stats}->{stored} // $d->{stats}->{bytes_used};
 561     my $total = $used + $free;
 562     my $active = 1;
 563
 564     return ($total, $free, $used, $active);
 565 }
 566
 567 sub activate_storage {
 568     my ($class, $storeid, $scfg, $cache) = @_;
 569     return 1;
 570 }
 571
 572 sub deactivate_storage {
 573     my ($class, $storeid, $scfg, $cache) = @_;
 574     return 1;
 575 }
 576
 577 my $get_kernel_device_name = sub {
 578     my ($pool, $name) = @_;
 579
 580     return "/dev/rbd/$pool/$name";
 581 };
 582
 583 sub map_volume {
 584     my ($class, $storeid, $scfg, $volname, $snapname) = @_;
 585
 586     my ($vtype, $img_name, $vmid) = $class->parse_volname($volname);
 587
 588     my $name = $img_name;
 589     $name .= '@'.$snapname if $snapname;
 590
 591     my $pool =  $scfg->{pool} ? $scfg->{pool} : 'rbd';
 592
 593     my $kerneldev = $get_kernel_device_name->($pool, $name);
 594
 595     return $kerneldev if -b $kerneldev; # already mapped
 596
 597     # features can only be enabled/disabled for image, not for snapshot!
 598     $krbd_feature_update->($scfg, $storeid, $img_name);
 599
 600     my $cmd = &$rbd_cmd($scfg, $storeid, 'map', $name);
 601     run_rbd_command($cmd, errmsg => "can't map rbd volume $name");
 602
 603     return $kerneldev;
 604 }
 605
 606 sub unmap_volume {
 607     my ($class, $storeid, $scfg, $volname, $snapname) = @_;
 608
 609     my ($vtype, $name, $vmid) = $class->parse_volname($volname);
 610     $name .= '@'.$snapname if $snapname;
 611
 612     my $pool =  $scfg->{pool} ? $scfg->{pool} : 'rbd';
 613
 614     my $kerneldev = $get_kernel_device_name->($pool, $name);
 615
 616     if (-b $kerneldev) {
 617         my $cmd = &$rbd_cmd($scfg, $storeid, 'unmap', $kerneldev);
 618         run_rbd_command($cmd, errmsg => "can't unmap rbd device $kerneldev");
 619     }
 620
 621     return 1;
 622 }
 623
 624 sub activate_volume {
 625     my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
 626
 627     $class->map_volume($storeid, $scfg, $volname, $snapname) if $scfg->{krbd};
 628
 629     return 1;
 630 }
 631
 632 sub deactivate_volume {
 633     my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
 634
 635     $class->unmap_volume($storeid, $scfg, $volname, $snapname);
 636
 637     return 1;
 638 }
 639
 640 sub volume_size_info {
 641     my ($class, $scfg, $storeid, $volname, $timeout) = @_;
 642
 643     my ($vtype, $name, $vmid) = $class->parse_volname($volname);
 644     my ($size, undef) = rbd_volume_info($scfg, $storeid, $name);
 645     return $size;
 646 }
 647
 648 sub volume_resize {
 649     my ($class, $scfg, $storeid, $volname, $size, $running) = @_;
 650
 651     return 1 if $running && !$scfg->{krbd}; # FIXME???
 652
 653     my ($vtype, $name, $vmid) = $class->parse_volname($volname);
 654
 655     my $cmd = &$rbd_cmd($scfg, $storeid, 'resize', '--allow-shrink', '--size', ($size/1024/1024), $name);
 656     run_rbd_command($cmd, errmsg => "rbd resize '$volname' error");
 657     return undef;
 658 }
 659
 660 sub volume_snapshot {
 661     my ($class, $scfg, $storeid, $volname, $snap) = @_;
 662
 663     my ($vtype, $name, $vmid) = $class->parse_volname($volname);
 664
 665     my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'create', '--snap', $snap, $name);
 666     run_rbd_command($cmd, errmsg => "rbd snapshot '$volname' error");
 667     return undef;
 668 }
 669
 670 sub volume_snapshot_rollback {
 671     my ($class, $scfg, $storeid, $volname, $snap) = @_;
 672
 673     my ($vtype, $name, $vmid) = $class->parse_volname($volname);
 674
 675     my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'rollback', '--snap', $snap, $name);
 676     run_rbd_command($cmd, errmsg => "rbd snapshot $volname to '$snap' error");
 677 }
 678
 679 sub volume_snapshot_delete {
 680     my ($class, $scfg, $storeid, $volname, $snap, $running) = @_;
 681
 682     return 1 if $running && !$scfg->{krbd}; # FIXME: ????
 683
 684     $class->deactivate_volume($storeid, $scfg, $volname, $snap, {});
 685
 686     my ($vtype, $name, $vmid) = $class->parse_volname($volname);
 687
 688     my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $name, $snap);
 689     if ($protected){
 690         my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'unprotect', $name, '--snap', $snap);
 691         run_rbd_command($cmd, errmsg => "rbd unprotect $name snap '$snap' error");
 692     }
 693
 694     my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'rm', '--snap', $snap, $name);
 695
 696     run_rbd_command($cmd, errmsg => "rbd snapshot '$volname' error");
 697
 698     return undef;
 699 }
 700
 701 sub volume_snapshot_needs_fsfreeze {
 702
 703     return 1;
 704 }
 705
 706 sub volume_has_feature {
 707     my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running) = @_;
 708
 709    my $features = {
 710         snapshot => { current => 1, snap => 1},
 711         clone => { base => 1, snap => 1},
 712         template => { current => 1},
 713         copy => { base => 1, current => 1, snap => 1},
 714         sparseinit => { base => 1, current => 1},
 715     };
 716
 717     my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =
 718         $class->parse_volname($volname);
 719
 720     my $key = undef;
 721     if($snapname){
 722         $key = 'snap';
 723     }else{
 724         $key =  $isBase ? 'base' : 'current';
 725     }
 726     return 1 if $features->{$feature}->{$key};
 727
 728     return undef;
 729 }
 730
 731 1;