}
sub get_smart_data {
- my ($disk) = @_;
+ my ($disk, $healthonly) = @_;
assert_blockdev($disk);
my $smartdata = {};
$disk =~ s/n\d+$//
if $disk =~ m!^/dev/nvme\d+n\d+$!;
+ my $cmd = [$SMARTCTL, '-H'];
+ push @$cmd, '-A', '-f', 'brief' if !$healthonly;
+ push @$cmd, $disk;
+
eval {
- $returncode = run_command([$SMARTCTL, '-H', '-A', '-f', 'brief', $disk], noerr => 1, outfunc => sub{
+ $returncode = run_command($cmd, noerr => 1, outfunc => sub{
my ($line) = @_;
# ATA SMART attributes, e.g.:
} elsif (defined($type) && $type eq 'text') {
$smartdata->{text} = '' if !defined $smartdata->{text};
$smartdata->{text} .= "$line\n";
+ } elsif ($line =~ m/SMART Disabled/) {
+ $smartdata->{health} = "SMART Disabled";
}
});
};
return $smartdata;
}
-sub get_smart_health {
- my ($disk) = @_;
-
- return "NOT A DEVICE" if !assert_blockdev($disk, 1);
-
- my $message;
- $disk =~ s/n\d+$//
- if $disk =~ m!^/dev/nvme\d+n\d+$!;
-
- run_command([$SMARTCTL, '-H', $disk], noerr => 1, outfunc => sub {
- my ($line) = @_;
-
- if ($line =~ m/test result: (.*)$/) {
- $message = $1;
- } elsif ($line =~ m/open device: (.*) failed: (.*)$/) {
- $message = "FAILED TO OPEN";
- } elsif ($line =~ m/^SMART Disabled/) {
- $message = "SMART DISABLED";
- }
- });
-
- return $message;
-}
-
sub get_zfs_devices {
my $list = {};
if (!$nosmart) {
eval {
+ my $smartdata = get_smart_data($devpath, ($type ne 'ssd'));
+ $health = $smartdata->{health} if $smartdata->{health};
+
if ($type eq 'ssd') {
# if we have an ssd we try to get the wearout indicator
$wearout = 'N/A';
- my $smartdata = get_smart_data($devpath);
- $health = $smartdata->{health};
foreach my $attr (@{$smartdata->{attributes}}) {
# ID 233 is media wearout indicator on intel and sandisk
# ID 177 is media wearout indicator on samsung
# prefer the 233 value
last if ($attr->{id} == 233);
}
- } else {
- # else we just get the health
- $health = get_smart_health($devpath);
}
};
}