hugepages: fix memory size checking

The codepath for "any" hugepages did not check if memory size was even,
leading to the code below trying to allocate half a hugepage (e.g. VM
with 2049MiB RAM would lead to 1024.5 2kB hugepages).

Also improve error message for systems with only 1GB hugepages enabled.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>

diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm
index 5aceabf266df7daf8bb89dbe1c2ab306e1713fd0..04f80183f20dcb4df4c67c4f2f00304b2d53f7b6 100644 (file)
--- a/PVE/QemuServer/Memory.pm
+++ b/PVE/QemuServer/Memory.pm
@@ -402,10 +402,11 @@ sub hugepages_size {
        if ($gb_exists && ($size % 1024 == 0)) {
            return 1024;
        } elsif (-d "/sys/kernel/mm/hugepages/hugepages-2048kB") {
+           die "memory size must be even to use hugepages\n" if $size % 2 != 0;
            return 2;
        }
 
-       die "your system doesn't support hugepages for memory size $size\n"
+       die "your system doesn't support hugepages for memory size $size (1GB hugepages would be supported)\n"
            if $gb_exists;
 
        die "your system doesn't support hugepages\n";