]> git.proxmox.com Git - qemu-server.git/commitdiff
qemu_volume_snapshot_delete : fix krbd snapshot delete
authorAlexandre Derumier <aderumier@odiso.com>
Mon, 14 Nov 2016 12:01:21 +0000 (13:01 +0100)
committerDietmar Maurer <dietmar@proxmox.com>
Thu, 17 Nov 2016 08:46:16 +0000 (09:46 +0100)
like for snapshot, we need to check if krbd is enabled, to known
if we need to use qmp delete-drive-snapshot or storage command directly

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
PVE/QemuServer.pm

index 46926c0d87eb547ae4162100de645c5e6eb9fea9..d228180f9db52fbd9afe77f605dc5b4f6741d625 100644 (file)
@@ -3990,11 +3990,11 @@ sub qemu_volume_snapshot_delete {
 
     my $running = check_running($vmid);
 
-    return if !PVE::Storage::volume_snapshot_delete($storecfg, $volid, $snap, $running);
-
-    return if !$running;
-
-    vm_mon_cmd($vmid, "delete-drive-snapshot", device => $deviceid, name => $snap);
+    if ($running && do_snapshots_with_qemu($storecfg, $volid)){
+       vm_mon_cmd($vmid, "delete-drive-snapshot", device => $deviceid, name => $snap);
+    } else {
+       PVE::Storage::volume_snapshot_delete($storecfg, $volid, $snap, $running);
+    }
 }
 
 sub set_migration_caps {