]> git.proxmox.com Git - qemu-server.git/commitdiff
memory: replace deprecated check_running() call
authorFiona Ebner <f.ebner@proxmox.com>
Mon, 4 Sep 2023 11:39:47 +0000 (13:39 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 18 Sep 2023 15:08:48 +0000 (17:08 +0200)
PVE::QemuServer::check_running() does both
PVE::QemuConfig::assert_config_exists_on_node()
PVE::QemuServer::Helpers::vm_running_locally()

The former one isn't needed here when doing hotplug, because the API
already assert that the VM config exists. It also would introduce a
new cyclic dependency between PVE::QemuServer::Memory <->
PVE::QemuConfig with the proposed virtio-mem patch set.

In preparation to remove the cyclic include of PVE::QemuServer in the
memory module.

No functional change intended.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
PVE/QemuServer/Memory.pm

index c5c3a0a6d8928c14ea3e97b44a5267c939a904f0..6ec5ceec5f908dc0ed91447267f4ffe924a55c3d 100644 (file)
@@ -175,7 +175,7 @@ sub foreach_dimm{
 sub qemu_memory_hotplug {
     my ($vmid, $conf, $defaults, $value) = @_;
 
-    return $value if !PVE::QemuServer::check_running($vmid);
+    return $value if !PVE::QemuServer::Helpers::vm_running_locally($vmid);
 
     my $sockets = $conf->{sockets} || 1;