fix #2862: allow sata/ide template backups

for IDE and SATA, setting the whole drive into readonly mode is not
possible. skip the readonly flag for such drives as a workaround until
we find a better solution.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index e7680723c8bbaac3c806ccce9f45849b6375b75e..638077c840af66d133a3dbc4f5c15ee00b44d5f9 100644 (file)
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3647,7 +3647,13 @@ sub config_to_command {
        }
 
        my $drive_cmd = print_drive_commandline_full($storecfg, $vmid, $drive, $pbs_name);
-       $drive_cmd .= ',readonly' if PVE::QemuConfig->is_template($conf);
+
+       # extra protection for templates, but SATA and IDE don't support it..
+       my $read_only = PVE::QemuConfig->is_template($conf)
+           && $drive->{interface} ne 'sata'
+           && $drive->{interface} ne 'ide';
+
+       $drive_cmd .= ',readonly' if $read_only;
 
        push @$devices, '-drive',$drive_cmd;
        push @$devices, '-device', print_drivedevice_full(