cd rom handling: refactor cd rom path helper function

to stop returning results of assignments

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index ceb383204d5e052a45273b97046aeea944652cda..6155f4daf7d228d88f259ac68ea0f01d06ac89a5 100644 (file)
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1289,12 +1289,16 @@ sub get_cdrom_path {
 
     return $cdrom_path if defined($cdrom_path);
 
-    return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom";
-    return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1";
-    return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2";
-
-    log_warn("no physical CD-ROM available, ignoring");
-    $cdrom_path = '';
+    if (-l "/dev/cdrom") {
+       $cdrom_path = "/dev/cdrom";
+    } elsif (-l "/dev/cdrom1") {
+       $cdrom_path = "/dev/cdrom1";
+    } elsif (-l "/dev/cdrom2") {
+       $cdrom_path = "/dev/cdrom2";
+    } else {
+       log_warn("no physical CD-ROM available, ignoring");
+       $cdrom_path = '';
+    }
 
     return $cdrom_path;
 }