]> git.proxmox.com Git - qemu-server.git/commitdiff
ivmshmem: comment deletion of shm on VM stop in code
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 26 Feb 2019 07:20:37 +0000 (08:20 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 26 Feb 2019 07:30:13 +0000 (08:30 +0100)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
PVE/QemuServer.pm

index 1dc3ca7fbef0cbd276292005264da143da5b952d..4e9db0c8a0f67ca415b8fb350bea6527e706b745 100644 (file)
@@ -5506,6 +5506,10 @@ sub vm_stop_cleanup {
 
        if ($conf->{ivshmem}) {
            my $ivshmem = PVE::JSONSchema::parse_property_string($ivshmem_fmt, $conf->{ivshmem});
+           # just delete it for now, VMs which have this already open do not
+           # are affected, but new VMs will get a separated one. If this
+           # becomes an issue we either add some sort of ref-counting or just
+           # add a "don't delete on stop" flag to the ivshmem format.
            unlink '/dev/shm/pve-shm-' . ($ivshmem->{name} // $vmid);
        }