qmeventd: VMID from PID: avoid goto

If strtol() returns an errno, make sure not to print the error message
twice after the refactoring.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>

diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeventd.c
index 76a894cb56d1bc2ba01da9cea605cf20935bf015..002b2ac46844cfe6eead55cc984f1db73b40accb 100644 (file)
--- a/qmeventd/qmeventd.c
+++ b/qmeventd/qmeventd.c
@@ -134,20 +134,18 @@ get_vmid_from_pid(pid_t pid)
            continue;
        }
        if (errno != 0) {
-           fprintf(stderr, "error parsing vmid for %d: %s\n", pid, strerror(errno));
            vmid = 0;
        }
 
-       goto ret;
+       break;
     }
 
     if (errno) {
        fprintf(stderr, "error parsing vmid for %d: %s\n", pid, strerror(errno));
-    } else {
+    } else if (!vmid) {
        fprintf(stderr, "error parsing vmid for %d: no matching qemu.slice cgroup entry\n", pid);
     }
 
-ret:
     free(buf);
     fclose(fp);
     return vmid;