]> git.proxmox.com Git - qemu-server.git/commitdiff
forbid hot-unplug of virtioscsi + iothread drive
authorAlexandre Derumier <aderumier@odiso.com>
Wed, 1 Apr 2015 03:11:44 +0000 (05:11 +0200)
committerDietmar Maurer <dietmar@proxmox.com>
Wed, 1 Apr 2015 04:16:16 +0000 (06:16 +0200)
qemu (<=2.3) currently segfault on drive_del

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
PVE/QemuServer.pm

index 6b2bab84efbff64784e74692faa31075fe7e02ec..9fe168479971e8ddccc27cd3a4d3fbe5a8df1811 100644 (file)
@@ -3379,6 +3379,10 @@ sub vm_deviceunplug {
 
     } elsif ($deviceid =~ m/^(scsi)(\d+)$/) {
 
+       #qemu 2.3 segfault on drive_del with virtioscsi + iothread
+       my $device = parse_drive($deviceid, $conf->{$deviceid});
+       die "virtioscsi with iothread is not hot-unplugglable currently" if $device->{iothread};
+
         qemu_devicedel($vmid, $deviceid);
         qemu_drivedel($vmid, $deviceid);
        qemu_deletescsihw($conf, $vmid, $deviceid);