]> git.proxmox.com Git - qemu-server.git/log
qemu-server.git
7 years agoadd setup_environment hook to CLIHandler classes
Dietmar Maurer [Thu, 12 Jan 2017 13:10:24 +0000 (14:10 +0100)]
add setup_environment hook to CLIHandler classes

7 years agocleanup: drop superfluous condition in assignment
Wolfgang Bumiller [Mon, 9 Jan 2017 14:33:10 +0000 (15:33 +0100)]
cleanup: drop superfluous condition in assignment

Its use later on already uses itself as condition.

7 years agoadd romfile option to hostpci
Alexandre Derumier [Mon, 9 Jan 2017 13:36:24 +0000 (14:36 +0100)]
add romfile option to hostpci

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoadd with-local-disks option for live storage migration
Alexandre Derumier [Fri, 6 Jan 2017 09:15:07 +0000 (10:15 +0100)]
add with-local-disks option for live storage migration

As Fabian as required,
add an extra flag "with-local-disks"  to enable live storage migration with localdisk.

default target storage is same sid than source, this can be overrided with
"targetstorage" option.

I will try improve this later, with optionnal mapping, disk by disk.

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agocleanup: error messages
Wolfgang Bumiller [Thu, 5 Jan 2017 08:54:07 +0000 (09:54 +0100)]
cleanup: error messages

7 years agodrive-mirror: bump timeout to 5s, add 30s inactivity timeout
Wolfgang Bumiller [Thu, 5 Jan 2017 08:40:44 +0000 (09:40 +0100)]
drive-mirror: bump timeout to 5s, add 30s inactivity timeout

7 years agodrive-mirror: warn use POSIX::_exit on exec failure
Wolfgang Bumiller [Thu, 5 Jan 2017 08:39:13 +0000 (09:39 +0100)]
drive-mirror: warn use POSIX::_exit on exec failure

7 years agocleanup: whitespaces & style
Wolfgang Bumiller [Thu, 5 Jan 2017 08:16:28 +0000 (09:16 +0100)]
cleanup: whitespaces & style

7 years agolive clone_vm : suspend or freezefs before block-job-cancel
Alexandre Derumier [Tue, 3 Jan 2017 14:03:19 +0000 (15:03 +0100)]
live clone_vm : suspend or freezefs before block-job-cancel

if qga is enabled, we try to freeze the fs before cancelling block job.
if not , we pause the vm.

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoadd socat and unix socket for storage migration
Alexandre Derumier [Tue, 3 Jan 2017 14:03:18 +0000 (15:03 +0100)]
add socat and unix socket for storage migration

This is a workaround for nbd infinite timeout connect

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoadd live storage migration with vm migration
Alexandre Derumier [Tue, 3 Jan 2017 14:03:17 +0000 (15:03 +0100)]
add live storage migration with vm migration

This allow to migrate disks on local storage  to a remote node storage.

When the target node start, a new volumes are created and exposed through qemu embedded nbd server.

qemu drive-mirror is launch on source vm for each disk with nbd server as target.

when drive-mirror reach 100% of 1 disk, we don't complete the block jobs and begin mirror of next disk.
(mirroring are parralel, but we try to mirroring them 1 by 1 to avoid storage && network overload)

Then we live migrate the vm to destination node. (drive-mirror still occur at the same time).

We the vm is livemigrate (source vm paused, target vm pause), we complete the block jobs mirror.

When is done we stop the source vm and resume the target vm

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoadd qm nbdstop
Alexandre Derumier [Tue, 3 Jan 2017 14:03:16 +0000 (15:03 +0100)]
add qm nbdstop

we use it to stop remote nbd server

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoadd targetstorage to vm_start
Alexandre Derumier [Tue, 3 Jan 2017 14:03:15 +0000 (15:03 +0100)]
add targetstorage to vm_start

This will create a new drive for each local drive found,
and start the vm with this new drives.

if targetstorage == 1, we use same sid than original vm disk

a nbd server is started in qemu and expose local volumes to network port

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoclone live vm : add support for multiple jobs
Alexandre Derumier [Tue, 3 Jan 2017 14:03:14 +0000 (15:03 +0100)]
clone live vm : add support for multiple jobs

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoqemu_drive_mirror : handle multiple jobs
Alexandre Derumier [Tue, 3 Jan 2017 14:03:13 +0000 (15:03 +0100)]
qemu_drive_mirror : handle multiple jobs

we can use multiple drive_mirror in parralel.

block-job-complete can be skipped, if we want to add more mirror job later.

also add support for nbd uri to qemu_drive_mirror

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoqmpclient : block-job-(complete|cancel) : set timeout to 10min
Alexandre Derumier [Tue, 3 Jan 2017 14:03:12 +0000 (15:03 +0100)]
qmpclient : block-job-(complete|cancel) : set timeout to 10min

like query-block-jobs.

qmp socket can be busy when block job are running

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agobump version to 4.0-103
Dietmar Maurer [Thu, 22 Dec 2016 11:41:13 +0000 (12:41 +0100)]
bump version to 4.0-103

7 years agodestroy_vm: allow vdisk_free to fail
Fabian Grünbichler [Tue, 20 Dec 2016 11:30:57 +0000 (12:30 +0100)]
destroy_vm: allow vdisk_free to fail

otherwise we end up with undeletable VM configs in case
vdisk_free fails (which could happen because of cluster-wide
lock contention, storage problems, ..).

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
7 years agoDisplay volume size in log when doing a volume backup
Emmanuel Kasper [Tue, 20 Dec 2016 10:33:01 +0000 (11:33 +0100)]
Display volume size in log when doing a volume backup

Output before this patch
INFO: include disk 'scsi0' 'file=pve4tank:vm-402-disk-1'

Output after this patch:
INFO: include disk 'scsi0' 'file=pve4tank:vm-402-disk-1' 64G

we're mainly intersted by the volume size here, it was requested in #351

7 years agobump version to 4.0-102
Dietmar Maurer [Tue, 20 Dec 2016 09:13:36 +0000 (10:13 +0100)]
bump version to 4.0-102

and remove useless RELEASE

7 years agoavoid "No balloon device has been activated" warnings in vmstatus
Dietmar Maurer [Tue, 20 Dec 2016 09:11:56 +0000 (10:11 +0100)]
avoid "No balloon device has been activated" warnings in vmstatus

7 years agobump version to 4.0-101
Fabian Grünbichler [Mon, 5 Dec 2016 11:39:24 +0000 (12:39 +0100)]
bump version to 4.0-101

7 years agoallow migration of local qcow2 snapshots
Dominik Csapak [Mon, 5 Dec 2016 10:21:15 +0000 (11:21 +0100)]
allow migration of local qcow2 snapshots

we can migrate local snapshots when on zfs or dir storage with qcow2,
but the check was incorrect

we checked for if (zfs && !qcow2) instead of  if (zfs || qcow2)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
7 years agobump version to 4.0-100
Dietmar Maurer [Fri, 2 Dec 2016 17:51:23 +0000 (18:51 +0100)]
bump version to 4.0-100

7 years agoallow insecure migrations from older qemu-servers
Thomas Lamprecht [Fri, 2 Dec 2016 16:55:29 +0000 (17:55 +0100)]
allow insecure migrations from older qemu-servers

When trying to migrate a VM from a node with qemu server <= 4.0-92 to
a node with qemu server >= 4.0-93 we failed as the remote qemu-server
got no explicit migration_type' from the older qemu server on the
source.

Check if migration_type is defined on a incoming migration start, if
not set it.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
7 years agobump version to 4.0-99
Dietmar Maurer [Thu, 1 Dec 2016 06:59:24 +0000 (07:59 +0100)]
bump version to 4.0-99

7 years agoqm agent: remove 'guest-' prefix from commands
Dietmar Maurer [Thu, 1 Dec 2016 06:55:51 +0000 (07:55 +0100)]
qm agent: remove 'guest-' prefix from commands

7 years agoqm agent: pass command as second required argument
Dietmar Maurer [Thu, 1 Dec 2016 06:49:30 +0000 (07:49 +0100)]
qm agent: pass command as second required argument

usage: qm agent <vmid> <command>

7 years agoqm agent: add output formatter
Dietmar Maurer [Thu, 1 Dec 2016 06:42:37 +0000 (07:42 +0100)]
qm agent: add output formatter

7 years agoqm agent: directly return result
Dietmar Maurer [Thu, 1 Dec 2016 05:58:36 +0000 (06:58 +0100)]
qm agent: directly return result

This is required for correct error handling. The previous
code simply cought all exceptions.

7 years agoqm agent: enumerate possible guest commands
Dietmar Maurer [Thu, 1 Dec 2016 05:45:00 +0000 (06:45 +0100)]
qm agent: enumerate possible guest commands

7 years agocleanup: reorder code so that emacs font-lock-mode works again
Dietmar Maurer [Wed, 30 Nov 2016 12:07:52 +0000 (13:07 +0100)]
cleanup: reorder code so that emacs font-lock-mode works again

This is just a work around for emacs bugs.

7 years agoqm agent: add command line completion for vmid
Dietmar Maurer [Wed, 30 Nov 2016 11:47:03 +0000 (12:47 +0100)]
qm agent: add command line completion for vmid

7 years agobump version to 4.0-98
Dietmar Maurer [Wed, 30 Nov 2016 11:32:02 +0000 (12:32 +0100)]
bump version to 4.0-98

7 years agoAdd qm agent.
Wolfgang Link [Thu, 3 Nov 2016 14:26:50 +0000 (15:26 +0100)]
Add qm agent.

This command makes it possible to run commnads on the Qemu-Guest-Agent if it is installed and running.

7 years agoincrease timeout from guest-fsfreeze-freeze
Thomas Lamprecht [Wed, 23 Nov 2016 10:40:41 +0000 (11:40 +0100)]
increase timeout from guest-fsfreeze-freeze

The qmp command 'guest-fsfreeze-freeze' issues in linux a FIFREEZE
ioctl call on all mounted guest FS.
This ioctl call locks the filesystem and gets it into an consistent
state. For this all caches must be synced after blocking new writes
to the FS, which may need a relative long time, especially under high
IO load on the backing storage.

In windows a VSS (Volume Shadow Copy Service) request_freeze will
issued. As of the closed Windows nature the exact mechanisms cannot
be checked but some microsoft blog posts and other forum post suggest
that it should return fast but certain workloads can still trigger a
long delay resulting an similar problems.

Thus try to minimize the error probability and increase the timeout
significantly.
We use 60 minutes as timeout as this seems a limit which should not
get trespassed in a somewhat healthy system.

See:
https://forum.proxmox.com/threads/22192/

see the 'freeze_super' and 'thaw_super' function in fs/super.c from
the linux kernel tree for more details on the freeze behavior in
Linux guests.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
7 years agobump version to 4.0-97
Dietmar Maurer [Tue, 29 Nov 2016 08:09:39 +0000 (09:09 +0100)]
bump version to 4.0-97

7 years agoAdd entry for windows 10 and 2016 support
Emmanuel Kasper [Thu, 17 Nov 2016 14:03:38 +0000 (15:03 +0100)]
Add entry for windows 10 and 2016 support

All special flags for Windows 8 and Windows 2012 (win8 type)
are kept the same , since we set flags based on checking  if
/^win(\d+)$/ is greater than 6 or 7

7 years agobump version to 4.0-96
Dietmar Maurer [Wed, 23 Nov 2016 09:02:55 +0000 (10:02 +0100)]
bump version to 4.0-96

7 years agorestrict monitor API to Sys.Modify for most commands
Fabian Grünbichler [Wed, 23 Nov 2016 08:17:07 +0000 (09:17 +0100)]
restrict monitor API to Sys.Modify for most commands

because these allow adding arbitrary devices to VMs (and
other potentially dangerous things).

whitelist 'info *' and 'help' as usable with just
VM.Monitor, if more are desired and requested they can be
added later.

7 years agobump version to 4.0-95
Dietmar Maurer [Wed, 23 Nov 2016 07:11:33 +0000 (08:11 +0100)]
bump version to 4.0-95

7 years agovm_shutdown: request 'stopped' state for HA enabled VMs
Dietmar Maurer [Wed, 23 Nov 2016 07:03:08 +0000 (08:03 +0100)]
vm_shutdown: request 'stopped' state for HA enabled VMs

7 years agocombine option 'format' with previous line (avoid emacs confusion)
Dietmar Maurer [Wed, 23 Nov 2016 05:40:33 +0000 (06:40 +0100)]
combine option 'format' with previous line (avoid emacs confusion)

7 years agouse ha-manager 'stopped' state instead of 'disabled'
Dietmar Maurer [Wed, 23 Nov 2016 05:23:21 +0000 (06:23 +0100)]
use ha-manager 'stopped' state instead of 'disabled'

7 years agoswitch to 'ha-manager set'
Thomas Lamprecht [Fri, 18 Nov 2016 16:42:17 +0000 (17:42 +0100)]
switch to 'ha-manager set'

ha-manager enabled/disabled will get removed

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
7 years agovmstate snapshot : activate|deactivate volume
Alexandre Derumier [Mon, 14 Nov 2016 12:23:02 +0000 (13:23 +0100)]
vmstate snapshot : activate|deactivate volume

This fix vmstate snasphot on krbd volume

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoqemu_volume_snapshot_delete : fix krbd snapshot delete
Alexandre Derumier [Mon, 14 Nov 2016 12:01:21 +0000 (13:01 +0100)]
qemu_volume_snapshot_delete : fix krbd snapshot delete

like for snapshot, we need to check if krbd is enabled, to known
if we need to use qmp delete-drive-snapshot or storage command directly

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoVZDump/QemuServer: set bless clas correctly
Stefan Priebe [Wed, 16 Nov 2016 19:10:40 +0000 (20:10 +0100)]
VZDump/QemuServer: set bless clas correctly

Signed-off-by: Stefan Priebe <s.priebe@profihost.ag>
7 years agoqxlnum: use $winversion
Alexandre Derumier [Fri, 11 Nov 2016 08:32:11 +0000 (09:32 +0100)]
qxlnum: use $winversion

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agohv_vendor_id : for winversion >= 6 , not >=7.
Alexandre Derumier [Fri, 11 Nov 2016 08:32:10 +0000 (09:32 +0100)]
hv_vendor_id : for winversion >= 6 , not >=7.

as It was previously.

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agocleanup windows version handling and hyperv enlightments
Alexandre Derumier [Tue, 8 Nov 2016 01:56:01 +0000 (02:56 +0100)]
cleanup windows version handling and hyperv enlightments

This cleanup windows guest os version handling,
with normalizing ostype with numbers in a new windows_version sub.

if($ostype eq 'wxp' || $ostype eq 'w2k3' || $ostype eq 'w2k') {
      $winversion = 5;
} elsif($ostype eq 'w2k8' || $ostype eq 'wvista') {
      $winversion = 6;
} elsif ($ostype =~ m/^win(\d+)$/) {
      $winversion = $1;
}

so we can simply do test on windows version with lower or upper version

Hyperv enlightments configuration is centralized
in a new add_hyperv_enlighments sub.

Also disable hyperv with win < 8 + ovmf.

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoremove format_description from $met_fmt->{model}
Dietmar Maurer [Sat, 5 Nov 2016 15:28:59 +0000 (16:28 +0100)]
remove format_description from $met_fmt->{model}

7 years agoremove unnecessary format_description from cputype
Dietmar Maurer [Sat, 5 Nov 2016 14:56:12 +0000 (15:56 +0100)]
remove unnecessary format_description from cputype

7 years agoregister new standard option 'pve-qm-image-format'
Dietmar Maurer [Thu, 3 Nov 2016 12:21:53 +0000 (13:21 +0100)]
register new standard option 'pve-qm-image-format'

7 years agobump version to 4.0-94
Dietmar Maurer [Thu, 3 Nov 2016 11:54:05 +0000 (12:54 +0100)]
bump version to 4.0-94

7 years agofix add_throttle_desc - pass correct units
Dietmar Maurer [Thu, 3 Nov 2016 11:48:24 +0000 (12:48 +0100)]
fix add_throttle_desc - pass correct units

7 years agobump version to 4.0-93
Dietmar Maurer [Thu, 3 Nov 2016 09:26:51 +0000 (10:26 +0100)]
bump version to 4.0-93

7 years agoClose #1195: support iops/bps_max_length throttling options
Wolfgang Bumiller [Thu, 3 Nov 2016 07:17:28 +0000 (08:17 +0100)]
Close #1195: support iops/bps_max_length throttling options

7 years agofix a perl warning when failing to parse a new drive string
Wolfgang Bumiller [Thu, 3 Nov 2016 07:17:15 +0000 (08:17 +0100)]
fix a perl warning when failing to parse a new drive string

7 years agofix a warning: discard is not a number
Wolfgang Bumiller [Thu, 3 Nov 2016 07:17:14 +0000 (08:17 +0100)]
fix a warning: discard is not a number

7 years agoallow dedicated migration network, bug #1177
Thomas Lamprecht [Mon, 31 Oct 2016 08:42:31 +0000 (09:42 +0100)]
allow dedicated migration network, bug #1177

Without this patch we use the network were the cluster traffic runs
for sending migration traffic. This is not ideal as it may hinder
cluster traffic. Further some users have a powerful network which
would be perfect for migrations, with this patch they can run the
migration traffic over such a network without having the corosync
traffic on the same network.

The network is configurable through /etc/pve/datacenter.cfg which
got a new property, namely migration. migration has two
subproperties: type (replaces the old migration_unsecure property)
and network.

For the case of a network failure or that a VM has to be moved over
another network for arbitrary other reasons I added the
migration_type and migration_network parameters to qm migrate (and
respectively vm_start as this gets used on migration).
They allow overwriting the datacenter.cfg settings.

Fixes bug #1177

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
7 years agochange default value for cpuunits to 1024
Dietmar Maurer [Thu, 27 Oct 2016 05:23:32 +0000 (07:23 +0200)]
change default value for cpuunits to 1024

Use the same default as containers.

7 years agobump version to 4.0-92
Dietmar Maurer [Fri, 21 Oct 2016 07:14:18 +0000 (09:14 +0200)]
bump version  to 4.0-92

7 years agoClose #351: add more info to backup log
Emmanuel Kasper [Thu, 20 Oct 2016 09:20:13 +0000 (11:20 +0200)]
Close #351: add more info to backup log

Before patch:
INFO: exclude disk 'scsi1' (backup=no)
INFO: skip unused drive 'local:401/vm-401-disk-3.raw' (not included into backup)
INFO: skip unused drive 'local:401/vm-401-disk-1.raw' (not included into backup)

After patch applied:
INFO: include disk 'scsi0' local:401/vm-401-disk-4.qcow2
INFO: exclude disk 'scsi1' local:401/vm-401-disk-2.raw (backup=no)
INFO: include disk 'scsi2' pve4tank:vm-401-disk-1
INFO: skip unused drive 'local:401/vm-401-disk-3.raw' (not included into backup)
INFO: skip unused drive 'local:401/vm-401-disk-1.raw' (not included into backup)

7 years agosnapshot_list: add bash completion for vmid
Dietmar Maurer [Wed, 19 Oct 2016 09:57:53 +0000 (11:57 +0200)]
snapshot_list: add bash completion for vmid

7 years agoadd qm listsnapshot call
Dominik Csapak [Fri, 7 Oct 2016 08:51:13 +0000 (10:51 +0200)]
add qm listsnapshot call

the api call is already there, just not used in qm.pm
copied mostly from pct.pm

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
7 years agoFix #1174: remove pve-qm-drive
Wolfgang Bumiller [Tue, 18 Oct 2016 08:38:58 +0000 (10:38 +0200)]
Fix #1174: remove pve-qm-drive

Let 'cdrom' use the pve-qm-ide format, as it's supposed to
be an alias to ide2.
We're not using the 'alias' schema property since the qemu
configs still use a custom parser (due to the
pending-changes system and the filename-to-volume-id
conversion for legacy support) which does not deal with
schema aliases.

7 years agoFix typo
Emmanuel Kasper [Thu, 13 Oct 2016 12:33:28 +0000 (14:33 +0200)]
Fix typo

7 years agoimprove error messages
Wolfgang Bumiller [Mon, 17 Oct 2016 12:49:05 +0000 (14:49 +0200)]
improve error messages

7 years agoenable drive-mirror with iothread for qemu 2.7 v2
Alexandre Derumier [Mon, 17 Oct 2016 10:20:45 +0000 (12:20 +0200)]
enable drive-mirror with iothread for qemu 2.7 v2

changelog : check running qemu binary version

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoadd get_running_qemu_version
Alexandre Derumier [Mon, 17 Oct 2016 10:20:43 +0000 (12:20 +0200)]
add get_running_qemu_version

return current running qemu process version

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agocpu hotplug : add new cpu hotplug method for qemu 2.7
Alexandre Derumier [Mon, 17 Oct 2016 10:18:57 +0000 (12:18 +0200)]
cpu hotplug : add new cpu hotplug method for qemu 2.7

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agocpu hotplug : add cpu hot-unplug support
Alexandre Derumier [Mon, 17 Oct 2016 10:18:56 +0000 (12:18 +0200)]
cpu hotplug : add cpu hot-unplug support

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agocpu hotplug : add coldplugged cpu to qemu command line
Alexandre Derumier [Mon, 17 Oct 2016 10:18:55 +0000 (12:18 +0200)]
cpu hotplug : add coldplugged cpu to qemu command line

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agocpu hotplug : add print_cpu_device
Alexandre Derumier [Mon, 17 Oct 2016 10:18:54 +0000 (12:18 +0200)]
cpu hotplug : add print_cpu_device

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agonumaX : use cpus option multiple time if cpulist
Alexandre Derumier [Mon, 10 Oct 2016 07:36:55 +0000 (09:36 +0200)]
numaX : use cpus option multiple time if cpulist

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agobump version to 4.0-91
Dietmar Maurer [Fri, 7 Oct 2016 06:21:51 +0000 (08:21 +0200)]
bump version to 4.0-91

7 years agofix #1131: activate volume before copying efidisk
Dominik Csapak [Thu, 6 Oct 2016 09:56:00 +0000 (11:56 +0200)]
fix #1131: activate volume before copying efidisk

before copying the efidisk image to a storage,
we first have to activate the volume

also, add the -n flag to qemu-img convert (prevents
creation of the target volume)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
7 years agobump version to 4.0-90
Dietmar Maurer [Wed, 5 Oct 2016 05:13:52 +0000 (07:13 +0200)]
bump version to 4.0-90

7 years agofix #1111: qm showcmd wrong escape sequence
Wolfgang Link [Wed, 21 Sep 2016 13:14:18 +0000 (15:14 +0200)]
fix #1111: qm showcmd wrong escape sequence

7 years agoAvoid to parse empty property string.
Wolfgang Link [Wed, 28 Sep 2016 07:19:19 +0000 (09:19 +0200)]
Avoid to parse empty property string.

Check if string exists before you try to parse it. Remove unnecessary
eval.

7 years agofix manual page, bump version to 4.0-89
Dietmar Maurer [Thu, 29 Sep 2016 10:21:41 +0000 (12:21 +0200)]
fix manual page, bump version to 4.0-89

7 years agobump version to 4.0-88
Dietmar Maurer [Fri, 16 Sep 2016 05:50:02 +0000 (07:50 +0200)]
bump version to 4.0-88

7 years agorestore: better error handling for vdisk deletion
Fabian Grünbichler [Thu, 15 Sep 2016 11:24:35 +0000 (13:24 +0200)]
restore: better error handling for vdisk deletion

when restoring into an existing VM, we don't want to die
half-way through because we can't delete one of the existing
volumes. instead, warn about the deletion failure, but
continue anyway. the not deleted disk is then added as
unused automatically.

7 years agoforbid migration of template with local base image
Fabian Grünbichler [Thu, 15 Sep 2016 11:23:56 +0000 (13:23 +0200)]
forbid migration of template with local base image

7 years agoforbid restore into existing template
Fabian Grünbichler [Thu, 15 Sep 2016 11:23:12 +0000 (13:23 +0200)]
forbid restore into existing template

7 years agobump version to 4.0-87
Dietmar Maurer [Thu, 8 Sep 2016 10:34:41 +0000 (12:34 +0200)]
bump version to 4.0-87

7 years agoadd seabios bootsplash and use it
Dominik Csapak [Thu, 8 Sep 2016 07:25:57 +0000 (09:25 +0200)]
add seabios bootsplash and use it

this adds a bootsplash image in /usr/share/qemu-server
and if this file exists, use it for seabios

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
7 years agouse efidisk0 for efivars
Dominik Csapak [Thu, 8 Sep 2016 09:03:01 +0000 (11:03 +0200)]
use efidisk0 for efivars

if efidisk0 is defined, use it as a efivars disk,
to permanently store efivars (such as boot options)

we check if the files exist, and act accordingly

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
7 years agocopy efivars disk on create
Dominik Csapak [Thu, 8 Sep 2016 09:03:00 +0000 (11:03 +0200)]
copy efivars disk on create

when we create the efidisk0 over the api,
we discard the size, and create a 128kbyte vdisk
and copy it there with qemu-img convert

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
7 years agoadd efidisk0 to config
Dominik Csapak [Thu, 8 Sep 2016 09:02:59 +0000 (11:02 +0200)]
add efidisk0 to config

just a simple disk (only size, format and volid) for
efivars disk

also do not add it to command line in foreach_drive

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
7 years agobump version to 4.0-86
Dietmar Maurer [Mon, 29 Aug 2016 08:11:40 +0000 (10:11 +0200)]
bump version to 4.0-86

7 years agohostpci: bring back multifunction pass-through shortcut
Wolfgang Bumiller [Wed, 24 Aug 2016 07:55:49 +0000 (09:55 +0200)]
hostpci: bring back multifunction pass-through shortcut

7 years agodisable drive-mirror when iothread is enabled
Alexandre Derumier [Sat, 20 Aug 2016 08:02:29 +0000 (10:02 +0200)]
disable drive-mirror when iothread is enabled

drive-mirror is not working with qemu 2.6 when iothread is enabled.

with virtio-blk : mirror is working, but block-job-completed crash the vm
with virtio-scsi : mirror hang at start.

This should be fixed in qemu 2.7

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agomemory: hugepages: map numa node IDs to host and guest correctly
Wolfgang Bumiller [Fri, 29 Jul 2016 11:26:29 +0000 (13:26 +0200)]
memory: hugepages: map numa node IDs to host and guest correctly

foreach_dimm() provides a guest numa node index, when used
in conjunction with the guest-to-host numa node topology
mapping one has to make sure that the correct host-side
indices are used.

This covers situations where the user defines a numaX with
hostnodes=Y with Y != X.

For instance:
  cores: 2
  hotplug: disk,network,cpu,memory
  hugepages: 2
  memory: 2048
  numa: 1
  numa1: memory=512,hostnodes=0,cpus=0-1,policy=bind
  numa2: memory=512,hostnodes=0,cpus=2-3,policy=bind

Both numa IDs 1 and 2 passed by foreach_dimm() have to be
mapped to host node 0.

Note that this also reverses the foreach_reverse_dimm() numa
node numbering as the current code, while walking sizes
backwards, walked the numa IDs inside each size forward,
which makes more sense. (Memory hot-unplug is still working
with this.)

7 years agohugepages: use hostnodes value as numanode for topology
Alexandre Derumier [Fri, 29 Jul 2016 03:17:34 +0000 (05:17 +0200)]
hugepages: use hostnodes value as numanode for topology

also disallow more than 1 hostnode value

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agoqemu-img convert : use default cache=unsafe instead writeback
Alexandre Derumier [Mon, 1 Aug 2016 06:51:00 +0000 (08:51 +0200)]
qemu-img convert : use default cache=unsafe instead writeback

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agohugepages: check if numa node exist only if hugepages are enabled
Alexandre Derumier [Fri, 29 Jul 2016 03:17:33 +0000 (05:17 +0200)]
hugepages: check if numa node exist only if hugepages are enabled

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
7 years agofix verbose qm status output
Dominik Csapak [Mon, 18 Jul 2016 08:50:31 +0000 (10:50 +0200)]
fix verbose qm status output

we did not check if some values were hash refs in
the verbose output.

this patch adds a recursive hash print sub and uses it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
7 years agoFix #1057: make protection a fast-plug option
Wolfgang Bumiller [Tue, 19 Jul 2016 07:17:36 +0000 (09:17 +0200)]
Fix #1057: make protection a fast-plug option

Otherwise you need to shutdown a VM to disable protection,
which is inconvenient for a few tasks such as for instance
deleting an unused disk.