]> git.proxmox.com Git - qemu.git/commit
block: fix sector comparism in multiwrite_req_compare
authorChristoph Hellwig <hch@lst.de>
Wed, 19 May 2010 18:53:10 +0000 (20:53 +0200)
committerAurelien Jarno <aurelien@aurel32.net>
Thu, 27 May 2010 11:58:34 +0000 (13:58 +0200)
commit1fb9798b69d7a2fccce70aebe5c5162cf069d596
treeca2e4491f6bc331b4ed40f424c20284521876939
parent9f6a84bc438df9397824276a8c2ec65c7f68bcf2
block: fix sector comparism in multiwrite_req_compare

The difference between the start sectors of two requests can be larger
than the size of the "int" type, which can lead to a not correctly
sorted multiwrite array and thus spurious I/O errors and filesystem
corruption due to incorrect request merges.

So instead of doing the cute sector arithmetics trick spell out the
exact comparisms.

Spotted by Kevin Wolf based on a testcase from Michael Tokarev.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 77be4366baface6613cfc312ba281f8e5860997c)
block.c