]> git.proxmox.com Git - qemu.git/commitdiff
iscsi: fix segfault in url parsing
authorPeter Lieven <pl@dlhnet.de>
Thu, 15 Nov 2012 14:42:06 +0000 (15:42 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 28 Nov 2012 11:46:13 +0000 (12:46 +0100)
If an invalid URL is specified iscsi_get_error(iscsi) is called
with iscsi == NULL.

Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
block/iscsi.c

index a6a819d68f6833868f275ca20d5720d140e6f4de..5cd8b49a3fff45d7855d6759eb6104052a228227 100644 (file)
@@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const char *filename, int flags)
 
     iscsi_url = iscsi_parse_full_url(iscsi, filename);
     if (iscsi_url == NULL) {
-        error_report("Failed to parse URL : %s %s", filename,
-                     iscsi_get_error(iscsi));
+        error_report("Failed to parse URL : %s", filename);
         ret = -EINVAL;
         goto out;
     }