]> git.proxmox.com Git - qemu.git/commitdiff
qemu-ga: Plug fd leak on ga_channel_open() error paths
authorMarkus Armbruster <armbru@redhat.com>
Fri, 11 Jan 2013 10:25:01 +0000 (11:25 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 14 Jan 2013 18:07:59 +0000 (12:07 -0600)
Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qga/channel-posix.c

index 9a5c05d666b4fc8490c517d68b7d38a40b939e2e..05e83860cac439869323ec037e5e6bd19f9ff2a9 100644 (file)
@@ -154,6 +154,7 @@ static gboolean ga_channel_open(GAChannel *c, const gchar *path, GAChannelMethod
         ret = ga_channel_client_add(c, fd);
         if (ret) {
             g_critical("error adding channel to main loop");
+            close(fd);
             return false;
         }
         break;