]>
Commit | Line | Data |
---|---|---|
30a3378a DM |
1 | package PVE::QMPClient; |
2 | ||
3 | use strict; | |
990fc5e2 | 4 | use warnings; |
7c2d9b40 | 5 | |
30a3378a DM |
6 | use IO::Multiplex; |
7 | use JSON; | |
7c2d9b40 | 8 | use POSIX qw(EINTR EAGAIN); |
b3ea07f7 | 9 | use Scalar::Util qw(weaken); |
7c2d9b40 | 10 | use Time::HiRes qw(usleep gettimeofday tv_interval); |
2ae10d4e | 11 | |
7c2d9b40 | 12 | use PVE::IPCC; |
d036e418 | 13 | use PVE::QemuServer::Helpers; |
30a3378a DM |
14 | |
15 | # Qemu Monitor Protocol (QMP) client. | |
16 | # | |
17 | # This implementation uses IO::Multiplex (libio-multiplex-perl) and | |
7a6c2150 | 18 | # allows you to issue qmp and qga commands to different VMs in parallel. |
30a3378a | 19 | |
f7d1505b | 20 | # Note: qemu can only handle 1 connection, so we close connections asap |
30a3378a DM |
21 | |
22 | sub new { | |
c5a07de5 | 23 | my ($class, $eventcb) = @_; |
30a3378a | 24 | |
f7d1505b | 25 | my $mux = IO::Multiplex->new(); |
30a3378a DM |
26 | |
27 | my $self = bless { | |
28 | mux => $mux, | |
7a6c2150 DM |
29 | queue_lookup => {}, # $fh => $queue_info |
30 | queue_info => {}, | |
30a3378a DM |
31 | }, $class; |
32 | ||
33 | $self->{eventcb} = $eventcb if $eventcb; | |
34 | ||
35 | $mux->set_callback_object($self); | |
36 | ||
558f1644 | 37 | # make sure perl doesn't believe this is a circular reference as we |
b3ea07f7 DM |
38 | # delete mux in DESTROY |
39 | weaken($mux->{_object}); | |
40 | ||
30a3378a DM |
41 | return $self; |
42 | } | |
43 | ||
7a6c2150 DM |
44 | # Note: List of special QGA command. Those commands can close the connection |
45 | # without sending a response. | |
46 | ||
47 | my $qga_allow_close_cmds = { | |
48 | 'guest-shutdown' => 1, | |
49 | 'guest-suspend-ram' => 1, | |
50 | 'guest-suspend-disk' => 1, | |
51 | 'guest-suspend-hybrid' => 1, | |
52 | }; | |
53 | ||
54 | my $push_cmd_to_queue = sub { | |
55 | my ($self, $vmid, $cmd) = @_; | |
56 | ||
57 | my $execute = $cmd->{execute} || die "no command name specified"; | |
58 | ||
59 | my $qga = ($execute =~ /^guest\-+/) ? 1 : 0; | |
a022e3fd | 60 | |
d036e418 | 61 | my $sname = PVE::QemuServer::Helpers::qmp_socket($vmid, $qga); |
7a6c2150 | 62 | |
a022e3fd | 63 | $self->{queue_info}->{$sname} = { qga => $qga, vmid => $vmid, sname => $sname, cmds => [] } |
7a6c2150 DM |
64 | if !$self->{queue_info}->{$sname}; |
65 | ||
66 | push @{$self->{queue_info}->{$sname}->{cmds}}, $cmd; | |
67 | ||
68 | return $self->{queue_info}->{$sname}; | |
69 | }; | |
70 | ||
558f1644 | 71 | # add a single command to the queue for later execution |
30a3378a DM |
72 | # with queue_execute() |
73 | sub queue_cmd { | |
74 | my ($self, $vmid, $callback, $execute, %params) = @_; | |
75 | ||
76 | my $cmd = {}; | |
77 | $cmd->{execute} = $execute; | |
78 | $cmd->{arguments} = \%params; | |
79 | $cmd->{callback} = $callback; | |
80 | ||
7a6c2150 DM |
81 | &$push_cmd_to_queue($self, $vmid, $cmd); |
82 | ||
d1c1af4b | 83 | return; |
30a3378a DM |
84 | } |
85 | ||
86 | # execute a single command | |
87 | sub cmd { | |
f0002f62 | 88 | my ($self, $vmid, $cmd, $timeout) = @_; |
30a3378a DM |
89 | |
90 | my $result; | |
91 | ||
92 | my $callback = sub { | |
93 | my ($vmid, $resp) = @_; | |
94 | $result = $resp->{'return'}; | |
1928c201 | 95 | $result = { error => $resp->{'error'} } if !defined($result) && $resp->{'error'}; |
30a3378a DM |
96 | }; |
97 | ||
7a6c2150 | 98 | die "no command specified" if !($cmd && $cmd->{execute}); |
f0002f62 | 99 | |
30a3378a DM |
100 | $cmd->{callback} = $callback; |
101 | $cmd->{arguments} = {} if !defined($cmd->{arguments}); | |
102 | ||
7a6c2150 | 103 | my $queue_info = &$push_cmd_to_queue($self, $vmid, $cmd); |
30a3378a | 104 | |
f0002f62 DM |
105 | if (!$timeout) { |
106 | # hack: monitor sometime blocks | |
107 | if ($cmd->{execute} eq 'query-migrate') { | |
108 | $timeout = 60*60; # 1 hour | |
109 | } elsif ($cmd->{execute} =~ m/^(eject|change)/) { | |
110 | $timeout = 60; # note: cdrom mount command is slow | |
cfb7a701 TL |
111 | } elsif ($cmd->{execute} eq 'guest-fsfreeze-freeze') { |
112 | # freeze syncs all guest FS, if we kill it it stays in an unfreezable | |
113 | # locked state with high probability, so use an generous timeout | |
114 | $timeout = 60*60; # 1 hour | |
115 | } elsif ($cmd->{execute} eq 'guest-fsfreeze-thaw') { | |
d11391ff FE |
116 | # While it should return instantly or never (dead locked) for Linux guests, |
117 | # the variance for Windows guests can be big. And there might be hook scripts | |
118 | # that are executed upon thaw, so use 3 minutes to be on the safe side. | |
119 | $timeout = 3 * 60; | |
46336bd2 TL |
120 | } elsif ( |
121 | $cmd->{execute} eq 'savevm-start' || | |
122 | $cmd->{execute} eq 'savevm-end' || | |
123 | $cmd->{execute} eq 'query-backup' || | |
124 | $cmd->{execute} eq 'query-block-jobs' || | |
125 | $cmd->{execute} eq 'block-job-cancel' || | |
126 | $cmd->{execute} eq 'block-job-complete' || | |
127 | $cmd->{execute} eq 'backup-cancel' || | |
128 | $cmd->{execute} eq 'query-savevm' || | |
129 | $cmd->{execute} eq 'delete-drive-snapshot' || | |
130 | $cmd->{execute} eq 'guest-shutdown' || | |
131 | $cmd->{execute} eq 'blockdev-snapshot-internal-sync' || | |
132 | $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync' || | |
133 | $cmd->{execute} eq 'snapshot-drive' | |
134 | ) { | |
9d689077 | 135 | $timeout = 10*60; # 10 mins ? |
14db5366 DM |
136 | } else { |
137 | $timeout = 3; # default | |
f0002f62 DM |
138 | } |
139 | } | |
140 | ||
c8125172 | 141 | $self->queue_execute($timeout, 2); |
7a6c2150 DM |
142 | |
143 | die "VM $vmid qmp command '$cmd->{execute}' failed - $queue_info->{error}" | |
144 | if defined($queue_info->{error}); | |
30a3378a DM |
145 | |
146 | return $result; | |
147 | }; | |
148 | ||
149 | my $cmdid_seq = 0; | |
c5a07de5 | 150 | my $cmdid_seq_qga = 0; |
7a6c2150 | 151 | |
30a3378a | 152 | my $next_cmdid = sub { |
c5a07de5 WL |
153 | my ($qga) = @_; |
154 | ||
155 | if($qga){ | |
156 | $cmdid_seq_qga++; | |
157 | return "$$"."0".$cmdid_seq_qga; | |
158 | } else { | |
159 | $cmdid_seq++; | |
160 | return "$$:$cmdid_seq"; | |
161 | } | |
30a3378a DM |
162 | }; |
163 | ||
7a6c2150 DM |
164 | my $lookup_queue_info = sub { |
165 | my ($self, $fh, $noerr) = @_; | |
558f1644 | 166 | |
a022e3fd | 167 | my $queue_info = $self->{queue_lookup}->{$fh}; |
7a6c2150 DM |
168 | if (!$queue_info) { |
169 | warn "internal error - unable to lookup queue info" if !$noerr; | |
d1c1af4b | 170 | return; |
7a6c2150 DM |
171 | } |
172 | return $queue_info; | |
173 | }; | |
558f1644 | 174 | |
7a6c2150 DM |
175 | my $close_connection = sub { |
176 | my ($self, $queue_info) = @_; | |
30a3378a | 177 | |
7a6c2150 DM |
178 | if (my $fh = delete $queue_info->{fh}) { |
179 | delete $self->{queue_lookup}->{$fh}; | |
c8125172 | 180 | $self->{mux}->close($fh); |
a022e3fd | 181 | } |
30a3378a DM |
182 | }; |
183 | ||
184 | my $open_connection = sub { | |
7a6c2150 DM |
185 | my ($self, $queue_info, $timeout) = @_; |
186 | ||
187 | die "duplicate call to open" if defined($queue_info->{fh}); | |
188 | ||
189 | my $vmid = $queue_info->{vmid}; | |
190 | my $qga = $queue_info->{qga}; | |
30a3378a | 191 | |
d036e418 | 192 | my $sname = PVE::QemuServer::Helpers::qmp_socket($vmid, $qga); |
30a3378a | 193 | |
6d042176 DM |
194 | $timeout = 1 if !$timeout; |
195 | ||
2ae10d4e DM |
196 | my $fh; |
197 | my $starttime = [gettimeofday]; | |
198 | my $count = 0; | |
7a6c2150 DM |
199 | |
200 | my $sotype = $qga ? 'qga' : 'qmp'; | |
201 | ||
2ae10d4e DM |
202 | for (;;) { |
203 | $count++; | |
204 | $fh = IO::Socket::UNIX->new(Peer => $sname, Blocking => 0, Timeout => 1); | |
205 | last if $fh; | |
206 | if ($! != EINTR && $! != EAGAIN) { | |
7a6c2150 | 207 | die "unable to connect to VM $vmid $sotype socket - $!\n"; |
2ae10d4e DM |
208 | } |
209 | my $elapsed = tv_interval($starttime, [gettimeofday]); | |
6d042176 | 210 | if ($elapsed >= $timeout) { |
7a6c2150 | 211 | die "unable to connect to VM $vmid $sotype socket - timeout after $count retries\n"; |
2ae10d4e DM |
212 | } |
213 | usleep(100000); | |
214 | } | |
30a3378a | 215 | |
7a6c2150 DM |
216 | $queue_info->{fh} = $fh; |
217 | ||
218 | $self->{queue_lookup}->{$fh} = $queue_info; | |
219 | ||
30a3378a | 220 | $self->{mux}->add($fh); |
7a6c2150 | 221 | $self->{mux}->set_timeout($fh, $timeout); |
558f1644 | 222 | |
30a3378a DM |
223 | return $fh; |
224 | }; | |
225 | ||
226 | my $check_queue = sub { | |
227 | my ($self) = @_; | |
228 | ||
229 | my $running = 0; | |
558f1644 | 230 | |
7a6c2150 DM |
231 | foreach my $sname (keys %{$self->{queue_info}}) { |
232 | my $queue_info = $self->{queue_info}->{$sname}; | |
233 | my $fh = $queue_info->{fh}; | |
30a3378a DM |
234 | next if !$fh; |
235 | ||
7a6c2150 DM |
236 | my $qga = $queue_info->{qga}; |
237 | ||
238 | if ($queue_info->{error}) { | |
239 | &$close_connection($self, $queue_info); | |
30a3378a DM |
240 | next; |
241 | } | |
242 | ||
7a6c2150 | 243 | if ($queue_info->{current}) { # command running, waiting for response |
30a3378a DM |
244 | $running++; |
245 | next; | |
246 | } | |
247 | ||
7a6c2150 DM |
248 | if (!scalar(@{$queue_info->{cmds}})) { # no more commands |
249 | &$close_connection($self, $queue_info); | |
30a3378a DM |
250 | next; |
251 | } | |
252 | ||
253 | eval { | |
254 | ||
7a6c2150 DM |
255 | my $cmd = $queue_info->{current} = shift @{$queue_info->{cmds}}; |
256 | $cmd->{id} = &$next_cmdid($qga); | |
30a3378a | 257 | |
558f1644 | 258 | my $fd = -1; |
a0e7a5d0 | 259 | if ($cmd->{execute} eq 'add-fd' || $cmd->{execute} eq 'getfd') { |
558f1644 DM |
260 | $fd = $cmd->{arguments}->{fd}; |
261 | delete $cmd->{arguments}->{fd}; | |
262 | } | |
263 | ||
7a6c2150 | 264 | my $qmpcmd; |
a45a14fc | 265 | |
7a6c2150 | 266 | if ($qga) { |
a45a14fc | 267 | |
a022e3fd | 268 | $qmpcmd = to_json({ execute => 'guest-sync-delimited', |
148850f6 KT |
269 | arguments => { id => int($cmd->{id})}}) . "\n" . |
270 | to_json({ execute => $cmd->{execute}, arguments => $cmd->{arguments}}) . "\n"; | |
a45a14fc | 271 | |
7a6c2150 | 272 | } else { |
a45a14fc AD |
273 | |
274 | $qmpcmd = to_json({ | |
275 | execute => $cmd->{execute}, | |
276 | arguments => $cmd->{arguments}, | |
277 | id => $cmd->{id}}); | |
278 | } | |
30a3378a | 279 | |
558f1644 DM |
280 | if ($fd >= 0) { |
281 | my $ret = PVE::IPCC::sendfd(fileno($fh), $fd, $qmpcmd); | |
282 | die "sendfd failed" if $ret < 0; | |
283 | } else { | |
284 | $self->{mux}->write($fh, $qmpcmd); | |
285 | } | |
30a3378a DM |
286 | }; |
287 | if (my $err = $@) { | |
7a6c2150 | 288 | $queue_info->{error} = $err; |
30a3378a DM |
289 | } else { |
290 | $running++; | |
291 | } | |
292 | } | |
293 | ||
294 | $self->{mux}->endloop() if !$running; | |
295 | ||
296 | return $running; | |
297 | }; | |
298 | ||
299 | # execute all queued command | |
c8125172 | 300 | |
30a3378a | 301 | sub queue_execute { |
c8125172 | 302 | my ($self, $timeout, $noerr) = @_; |
30a3378a DM |
303 | |
304 | $timeout = 3 if !$timeout; | |
305 | ||
30a3378a | 306 | # open all necessary connections |
7a6c2150 DM |
307 | foreach my $sname (keys %{$self->{queue_info}}) { |
308 | my $queue_info = $self->{queue_info}->{$sname}; | |
309 | next if !scalar(@{$queue_info->{cmds}}); # no commands | |
a022e3fd | 310 | |
7a6c2150 DM |
311 | $queue_info->{error} = undef; |
312 | $queue_info->{current} = undef; | |
c5a07de5 | 313 | |
a022e3fd | 314 | eval { |
7a6c2150 | 315 | &$open_connection($self, $queue_info, $timeout); |
c6fb6a69 | 316 | |
7a6c2150 DM |
317 | if (!$queue_info->{qga}) { |
318 | my $cap_cmd = { execute => 'qmp_capabilities', arguments => {} }; | |
319 | unshift @{$queue_info->{cmds}}, $cap_cmd; | |
c6fb6a69 | 320 | } |
30a3378a DM |
321 | }; |
322 | if (my $err = $@) { | |
7a6c2150 | 323 | $queue_info->{error} = $err; |
30a3378a DM |
324 | } |
325 | } | |
326 | ||
327 | my $running; | |
328 | ||
329 | for (;;) { | |
330 | ||
331 | $running = &$check_queue($self); | |
332 | ||
333 | last if !$running; | |
334 | ||
335 | $self->{mux}->loop; | |
336 | } | |
337 | ||
338 | # make sure we close everything | |
c8125172 | 339 | my $errors = ''; |
7a6c2150 | 340 | foreach my $sname (keys %{$self->{queue_info}}) { |
c8125172 DM |
341 | my $queue_info = $self->{queue_info}->{$sname}; |
342 | &$close_connection($self, $queue_info); | |
343 | if ($queue_info->{error}) { | |
344 | if ($noerr) { | |
345 | warn $queue_info->{error} if $noerr < 2; | |
346 | } else { | |
347 | $errors .= $queue_info->{error} | |
348 | } | |
349 | } | |
30a3378a DM |
350 | } |
351 | ||
7a6c2150 | 352 | $self->{queue_info} = $self->{queue_lookup} = {}; |
c8125172 DM |
353 | |
354 | die $errors if $errors; | |
30a3378a DM |
355 | } |
356 | ||
b006e70b DM |
357 | sub mux_close { |
358 | my ($self, $mux, $fh) = @_; | |
359 | ||
a022e3fd | 360 | my $queue_info = &$lookup_queue_info($self, $fh, 1); |
7a6c2150 | 361 | return if !$queue_info; |
b006e70b | 362 | |
a022e3fd | 363 | $queue_info->{error} = "client closed connection\n" |
7a6c2150 | 364 | if !$queue_info->{error}; |
b006e70b DM |
365 | } |
366 | ||
c8125172 | 367 | # mux_input is called when input is available on one of the descriptors. |
30a3378a DM |
368 | sub mux_input { |
369 | my ($self, $mux, $fh, $input) = @_; | |
370 | ||
a022e3fd | 371 | my $queue_info = &$lookup_queue_info($self, $fh); |
7a6c2150 DM |
372 | return if !$queue_info; |
373 | ||
a022e3fd AL |
374 | my $sname = $queue_info->{sname}; |
375 | my $vmid = $queue_info->{vmid}; | |
7a6c2150 | 376 | my $qga = $queue_info->{qga}; |
c5a07de5 | 377 | |
7a6c2150 DM |
378 | my $curcmd = $queue_info->{current}; |
379 | die "unable to lookup current command for VM $vmid ($sname)\n" if !$curcmd; | |
a022e3fd | 380 | |
bcfbc40b AD |
381 | my $raw; |
382 | ||
7a6c2150 | 383 | if ($qga) { |
5cb6fe54 | 384 | return if $$input !~ s/^.*\xff([^\n]+}\r?\n[^\n]+})\r?\n(.*)$/$2/so; |
bcfbc40b | 385 | $raw = $1; |
c5a07de5 | 386 | } else { |
edb52f14 | 387 | return if $$input !~ s/^(.*})\r?\n(.*)$/$2/so; |
bcfbc40b AD |
388 | $raw = $1; |
389 | } | |
30a3378a | 390 | |
30a3378a DM |
391 | eval { |
392 | my @jsons = split("\n", $raw); | |
393 | ||
7a6c2150 | 394 | if ($qga) { |
bcfbc40b AD |
395 | |
396 | die "response is not complete" if @jsons != 2 ; | |
397 | ||
398 | my $obj = from_json($jsons[0]); | |
c8125172 | 399 | |
7a6c2150 | 400 | my $cmdid = $obj->{'return'}; |
bcfbc40b | 401 | die "received responsed without command id\n" if !$cmdid; |
5cb6fe54 DM |
402 | |
403 | # skip results fro previous commands | |
404 | return if $cmdid < $curcmd->{id}; | |
a022e3fd | 405 | |
bcfbc40b AD |
406 | if ($curcmd->{id} ne $cmdid) { |
407 | die "got wrong command id '$cmdid' (expected $curcmd->{id})\n"; | |
408 | } | |
409 | ||
c8125172 DM |
410 | delete $queue_info->{current}; |
411 | ||
bcfbc40b AD |
412 | $obj = from_json($jsons[1]); |
413 | ||
414 | if (my $callback = $curcmd->{callback}) { | |
415 | &$callback($vmid, $obj); | |
416 | } | |
417 | ||
418 | return; | |
419 | } | |
420 | ||
30a3378a DM |
421 | foreach my $json (@jsons) { |
422 | my $obj = from_json($json); | |
423 | next if defined($obj->{QMP}); # skip monitor greeting | |
424 | ||
425 | if (exists($obj->{error}->{desc})) { | |
426 | my $desc = $obj->{error}->{desc}; | |
427 | chomp $desc; | |
428 | die "$desc\n" if $desc !~ m/Connection can not be completed immediately/; | |
429 | next; | |
430 | } | |
431 | ||
30a3378a DM |
432 | if (defined($obj->{event})) { |
433 | if (my $eventcb = $self->{eventcb}) { | |
434 | &$eventcb($obj); | |
435 | } | |
436 | next; | |
437 | } | |
438 | ||
439 | my $cmdid = $obj->{id}; | |
440 | die "received responsed without command id\n" if !$cmdid; | |
441 | ||
30a3378a DM |
442 | if ($curcmd->{id} ne $cmdid) { |
443 | die "got wrong command id '$cmdid' (expected $curcmd->{id})\n"; | |
444 | } | |
445 | ||
c8125172 DM |
446 | delete $queue_info->{current}; |
447 | ||
30a3378a DM |
448 | if (my $callback = $curcmd->{callback}) { |
449 | &$callback($vmid, $obj); | |
450 | } | |
451 | } | |
452 | }; | |
453 | if (my $err = $@) { | |
7a6c2150 | 454 | $queue_info->{error} = $err; |
30a3378a DM |
455 | } |
456 | ||
457 | &$check_queue($self); | |
458 | } | |
459 | ||
460 | # This gets called every second to update player info, etc... | |
461 | sub mux_timeout { | |
462 | my ($self, $mux, $fh) = @_; | |
463 | ||
a022e3fd | 464 | if (my $queue_info = &$lookup_queue_info($self, $fh)) { |
7a6c2150 | 465 | $queue_info->{error} = "got timeout\n"; |
c8125172 | 466 | $self->{mux}->inbuffer($fh, ''); # clear to avoid warnings |
30a3378a DM |
467 | } |
468 | ||
469 | &$check_queue($self); | |
470 | } | |
471 | ||
1c0c1c17 WL |
472 | sub mux_eof { |
473 | my ($self, $mux, $fh, $input) = @_; | |
c8125172 | 474 | |
7a6c2150 DM |
475 | my $queue_info = &$lookup_queue_info($self, $fh); |
476 | return if !$queue_info; | |
1c0c1c17 | 477 | |
a022e3fd AL |
478 | my $sname = $queue_info->{sname}; |
479 | my $vmid = $queue_info->{vmid}; | |
7a6c2150 | 480 | my $qga = $queue_info->{qga}; |
a022e3fd | 481 | |
7a6c2150 DM |
482 | my $curcmd = $queue_info->{current}; |
483 | die "unable to lookup current command for VM $vmid ($sname)\n" if !$curcmd; | |
1c0c1c17 | 484 | |
7a6c2150 | 485 | if ($qga && $qga_allow_close_cmds->{$curcmd->{execute}}) { |
1c0c1c17 | 486 | |
5cb6fe54 | 487 | return if $$input !~ s/^.*\xff([^\n]+})\r?\n(.*)$/$2/so; |
1c0c1c17 | 488 | |
c8125172 DM |
489 | my $raw = $1; |
490 | ||
491 | eval { | |
492 | my $obj = from_json($raw); | |
1c0c1c17 | 493 | |
c8125172 DM |
494 | my $cmdid = $obj->{'return'}; |
495 | die "received responsed without command id\n" if !$cmdid; | |
7a6c2150 | 496 | |
c8125172 | 497 | delete $queue_info->{current}; |
7a6c2150 | 498 | |
c8125172 DM |
499 | if (my $callback = $curcmd->{callback}) { |
500 | &$callback($vmid, undef); | |
501 | } | |
502 | }; | |
503 | if (my $err = $@) { | |
504 | $queue_info->{error} = $err; | |
505 | } | |
1c0c1c17 | 506 | |
7a6c2150 | 507 | &$close_connection($self, $queue_info); |
c8125172 DM |
508 | |
509 | if (scalar(@{$queue_info->{cmds}}) && !$queue_info->{error}) { | |
510 | $queue_info->{error} = "Got EOF but command queue is not empty.\n"; | |
511 | } | |
1c0c1c17 | 512 | } |
1c0c1c17 WL |
513 | } |
514 | ||
56afd466 WB |
515 | sub DESTROY { |
516 | my ($self) = @_; | |
517 | ||
518 | foreach my $sname (keys %{$self->{queue_info}}) { | |
519 | my $queue_info = $self->{queue_info}->{$sname}; | |
520 | $close_connection->($self, $queue_info); | |
521 | } | |
522 | } | |
523 | ||
26f11676 | 524 | 1; |