1 package PVE
::CLI
::pve6to7
;
10 use PVE
::API2
::Certificates
;
12 use PVE
::AccessControl
;
19 use PVE
::RPCEnvironment
;
21 use PVE
::Storage
::Plugin
;
22 use PVE
::Tools
qw(run_command split_list);
25 use PVE
::VZDump
::Common
;
34 use base
qw(PVE::CLIHandler);
36 my $nodename = PVE
::INotify
::nodename
();
38 sub setup_environment
{
39 PVE
::RPCEnvironment-
>setup_default_cli_env();
42 my $min_pve_major = 6;
43 my $min_pve_minor = 4;
44 my $min_pve_pkgrel = 1;
54 my ($level, $line) = @_;
56 $counters->{$level}++ if defined($level) && defined($counters->{$level});
58 print uc($level), ': ' if defined($level);
64 $log_line->('pass', @_);
69 $log_line->('info', @_);
72 $log_line->('skip', @_);
75 print color
('yellow');
76 $log_line->('warn', @_);
81 $log_line->('fail', @_);
85 my $print_header_first = 1;
88 print "\n" if !$print_header_first;
90 $print_header_first = 0;
93 my $get_systemd_unit_state = sub {
97 my $filter_output = sub {
102 run_command
(['systemctl', 'is-enabled', "$unit"], outfunc
=> $filter_output, noerr
=> 1);
103 return if !defined($state);
104 run_command
(['systemctl', 'is-active', "$unit"], outfunc
=> $filter_output, noerr
=> 1);
107 return $state // 'unknown';
109 my $log_systemd_unit_state = sub {
110 my ($unit, $no_fail_on_inactive) = @_;
112 my $log_method = \
&log_warn
;
114 my $state = $get_systemd_unit_state->($unit);
115 if ($state eq 'active') {
116 $log_method = \
&log_pass
;
117 } elsif ($state eq 'inactive') {
118 $log_method = $no_fail_on_inactive ? \
&log_warn
: \
&log_fail
;
119 } elsif ($state eq 'failed') {
120 $log_method = \
&log_fail
;
123 $log_method->("systemd unit '$unit' is in state '$state'");
130 $versions = eval { PVE
::API2
::APT-
>versions({ node
=> $nodename }) } if !defined($versions);
132 if (!defined($versions)) {
133 my $msg = "unable to retrieve package version information";
134 $msg .= "- $@" if $@;
139 my $pkgs = [ grep { $_->{Package
} eq $pkg } @$versions ];
140 if (!defined $pkgs || $pkgs == 0) {
141 log_fail
("unable to determine installed $pkg version.");
148 sub check_pve_packages
{
149 print_header
("CHECKING VERSION INFORMATION FOR PVE PACKAGES");
151 print "Checking for package updates..\n";
152 my $updates = eval { PVE
::API2
::APT-
>list_updates({ node
=> $nodename }); };
153 if (!defined($updates)) {
154 log_warn
("$@") if $@;
155 log_fail
("unable to retrieve list of package updates!");
156 } elsif (@$updates > 0) {
157 my $pkgs = join(', ', map { $_->{Package
} } @$updates);
158 log_warn
("updates for the following packages are available:\n $pkgs");
160 log_pass
("all packages uptodate");
163 print "\nChecking proxmox-ve package version..\n";
164 if (defined(my $proxmox_ve = $get_pkg->('proxmox-ve'))) {
165 my $min_pve_ver = "$min_pve_major.$min_pve_minor-$min_pve_pkgrel";
167 my ($maj, $min, $pkgrel) = $proxmox_ve->{OldVersion
} =~ m/^(\d+)\.(\d+)-(\d+)/;
171 if ($maj > $min_pve_major) {
172 log_pass
("already upgraded to Proxmox VE " . ($min_pve_major + 1));
174 } elsif ($maj >= $min_pve_major && $min >= $min_pve_minor && $pkgrel >= $min_pve_pkgrel) {
175 log_pass
("proxmox-ve package has version >= $min_pve_ver");
177 log_fail
("proxmox-ve package is too old, please upgrade to >= $min_pve_ver!");
180 my ($krunning, $kinstalled) = (qr/5\.11/, 'pve-kernel-5.11');
182 ($krunning, $kinstalled) = (qr/5\.(?:4|11)/, 'pve-kernel-4.15');
185 print "\nChecking running kernel version..\n";
186 my $kernel_ver = $proxmox_ve->{RunningKernel
};
187 if (!defined($kernel_ver)) {
188 log_fail
("unable to determine running kernel version.");
189 } elsif ($kernel_ver =~ /^$krunning/) {
190 log_pass
("expected running kernel '$kernel_ver'.");
191 } elsif ($get_pkg->($kinstalled)) {
192 log_warn
("expected kernel '$kinstalled' intalled but not yet rebooted!");
194 log_warn
("unexpected running and installed kernel '$kernel_ver'.");
197 log_fail
("proxmox-ve package not found!");
202 sub check_storage_health
{
203 print_header
("CHECKING CONFIGURED STORAGES");
204 my $cfg = PVE
::Storage
::config
();
208 my $info = PVE
::Storage
::storage_info
($cfg);
210 foreach my $storeid (sort keys %$info) {
211 my $d = $info->{$storeid};
213 if ($d->{type
} eq 'sheepdog') {
214 log_fail
("storage '$storeid' of type 'sheepdog' is enabled - experimental sheepdog support dropped in PVE 6")
215 } elsif ($d->{active
}) {
216 log_pass
("storage '$storeid' enabled and active.");
218 log_warn
("storage '$storeid' enabled but not active!");
221 log_skip
("storage '$storeid' disabled.");
226 sub check_cluster_corosync
{
227 print_header
("CHECKING CLUSTER HEALTH/SETTINGS");
229 if (!PVE
::Corosync
::check_conf_exists
(1)) {
230 log_skip
("standalone node.");
234 $log_systemd_unit_state->('pve-cluster.service');
235 $log_systemd_unit_state->('corosync.service');
237 if (PVE
::Cluster
::check_cfs_quorum
(1)) {
238 log_pass
("Cluster Filesystem is quorate.");
240 log_fail
("Cluster Filesystem readonly, lost quorum?!");
243 my $conf = PVE
::Cluster
::cfs_read_file
('corosync.conf');
244 my $conf_nodelist = PVE
::Corosync
::nodelist
($conf);
247 print "\nAnalzying quorum settings and state..\n";
248 if (!defined($conf_nodelist)) {
249 log_fail
("unable to retrieve nodelist from corosync.conf");
251 if (grep { $conf_nodelist->{$_}->{quorum_votes
} != 1 } keys %$conf_nodelist) {
252 log_warn
("non-default quorum_votes distribution detected!");
254 map { $node_votes += $conf_nodelist->{$_}->{quorum_votes
} // 0 } keys %$conf_nodelist;
257 my ($expected_votes, $total_votes);
258 my $filter_output = sub {
260 ($expected_votes) = $line =~ /^Expected votes:\s*(\d+)\s*$/
261 if !defined($expected_votes);
262 ($total_votes) = $line =~ /^Total votes:\s*(\d+)\s*$/
263 if !defined($total_votes);
266 run_command
(['corosync-quorumtool', '-s'], outfunc
=> $filter_output, noerr
=> 1);
269 if (!defined($expected_votes)) {
270 log_fail
("unable to get expected number of votes, setting to 0.");
273 if (!defined($total_votes)) {
274 log_fail
("unable to get expected number of votes, setting to 0.");
278 my $cfs_nodelist = PVE
::Cluster
::get_clinfo
()->{nodelist
};
279 my $offline_nodes = grep { $cfs_nodelist->{$_}->{online
} != 1 } keys %$cfs_nodelist;
280 if ($offline_nodes > 0) {
281 log_fail
("$offline_nodes nodes are offline!");
284 my $qdevice_votes = 0;
285 if (my $qdevice_setup = $conf->{main
}->{quorum
}->{device
}) {
286 $qdevice_votes = $qdevice_setup->{votes
} // 1;
289 log_info
("configured votes - nodes: $node_votes");
290 log_info
("configured votes - qdevice: $qdevice_votes");
291 log_info
("current expected votes: $expected_votes");
292 log_info
("current total votes: $total_votes");
294 log_warn
("expected votes set to non-standard value '$expected_votes'.")
295 if $expected_votes != $node_votes + $qdevice_votes;
296 log_warn
("total votes < expected votes: $total_votes/$expected_votes!")
297 if $total_votes < $expected_votes;
299 my $conf_nodelist_count = scalar(keys %$conf_nodelist);
300 my $cfs_nodelist_count = scalar(keys %$cfs_nodelist);
301 log_warn
("cluster consists of less than three quorum-providing nodes!")
302 if $conf_nodelist_count < 3 && $conf_nodelist_count + $qdevice_votes < 3;
304 log_fail
("corosync.conf ($conf_nodelist_count) and pmxcfs ($cfs_nodelist_count) don't agree about size of nodelist.")
305 if $conf_nodelist_count != $cfs_nodelist_count;
307 print "\nChecking nodelist entries..\n";
308 my $nodelist_pass = 1;
309 for my $cs_node (sort keys %$conf_nodelist) {
310 my $entry = $conf_nodelist->{$cs_node};
311 if (!defined($entry->{name
})) {
313 log_fail
("$cs_node: no name entry in corosync.conf.");
315 if (!defined($entry->{nodeid
})) {
317 log_fail
("$cs_node: no nodeid configured in corosync.conf.");
320 for my $link (0..7) {
321 $gotLinks++ if defined($entry->{"ring${link}_addr"});
323 if ($gotLinks <= 0) {
325 log_fail
("$cs_node: no ringX_addr (0 <= X <= 7) link defined in corosync.conf.");
328 my $verify_ring_ip = sub {
330 if (defined(my $ring = $entry->{$key})) {
331 my ($resolved_ip, undef) = PVE
::Corosync
::resolve_hostname_like_corosync
($ring, $conf);
332 if (defined($resolved_ip)) {
333 if ($resolved_ip ne $ring) {
335 log_warn
("$cs_node: $key '$ring' resolves to '$resolved_ip'.\n Consider replacing it with the currently resolved IP address.");
339 log_fail
("$cs_node: unable to resolve $key '$ring' to an IP address according to Corosync's resolve strategy - cluster will potentially fail with Corosync 3.x/kronosnet!");
343 for my $link (0..7) {
344 $verify_ring_ip->("ring${link}_addr");
347 log_pass
("nodelist settings OK") if $nodelist_pass;
349 print "\nChecking totem settings..\n";
350 my $totem = $conf->{main
}->{totem
};
353 my $transport = $totem->{transport
};
354 if (defined($transport)) {
355 if ($transport ne 'knet') {
357 log_fail
("Corosync transport explicitly set to '$transport' instead of implicit default!");
361 # TODO: are those values still up-to-date?
362 if ((!defined($totem->{secauth
}) || $totem->{secauth
} ne 'on') && (!defined($totem->{crypto_cipher
}) || $totem->{crypto_cipher
} eq 'none')) {
364 log_fail
("Corosync authentication/encryption is not explicitly enabled (secauth / crypto_cipher / crypto_hash)!");
365 } elsif (defined($totem->{crypto_cipher
}) && $totem->{crypto_cipher
} eq '3des') {
367 log_fail
("Corosync encryption cipher set to '3des', no longer supported in Corosync 3.x!"); # FIXME: can be removed?
370 log_pass
("totem settings OK") if $totem_pass;
372 log_info
("run 'pvecm status' to get detailed cluster status..");
374 if (defined(my $corosync = $get_pkg->('corosync'))) {
375 if ($corosync->{OldVersion
} =~ m/^2\./) {
376 log_fail
("\ncorosync 2.x installed, cluster-wide upgrade to 3.x needed!");
377 } elsif ($corosync->{OldVersion
} !~ m/^3\./) {
378 log_fail
("\nunexpected corosync version installed: $corosync->{OldVersion}!");
384 print_header
("CHECKING HYPER-CONVERGED CEPH STATUS");
386 if (PVE
::Ceph
::Tools
::check_ceph_inited
(1)) {
387 log_info
("hyper-converged ceph setup detected!");
389 log_skip
("no hyper-converged ceph setup detected!");
393 log_info
("getting Ceph status/health information..");
394 my $ceph_status = eval { PVE
::API2
::Ceph-
>status({ node
=> $nodename }); };
395 my $osd_flags = eval { PVE
::API2
::Ceph-
>get_flags({ node
=> $nodename }); };
396 my $noout_wanted = 1;
397 my $noout = $osd_flags && $osd_flags =~ m/noout/;
399 if (!$ceph_status || !$ceph_status->{health
}) {
400 log_fail
("unable to determine Ceph status!");
402 my $ceph_health = $ceph_status->{health
}->{status
};
404 log_fail
("unable to determine Ceph health!");
405 } elsif ($ceph_health eq 'HEALTH_OK') {
406 log_pass
("Ceph health reported as 'HEALTH_OK'.");
407 } elsif ($ceph_health eq 'HEALTH_WARN' && $noout && (keys %{$ceph_status->{health
}->{checks
}} == 1)) {
408 log_pass
("Ceph health reported as 'HEALTH_WARN' with a single failing check and 'noout' flag set.");
410 log_warn
("Ceph health reported as '$ceph_health'.\n Use the PVE ".
411 "dashboard or 'ceph -s' to determine the specific issues and try to resolve them.");
415 log_info
("getting Ceph OSD flags..");
418 log_fail
("unable to get Ceph OSD flags!");
420 if (!($osd_flags =~ m/recovery_deletes/ && $osd_flags =~ m/purged_snapdirs/)) {
421 log_fail
("missing 'recovery_deletes' and/or 'purged_snapdirs' flag, scrub of all PGs required before upgrading to Nautilus!");
426 # TODO: check OSD min-required version, if to low it breaks stuff!
428 log_info
("getting Ceph daemon versions..");
429 my $ceph_versions = eval { PVE
::Ceph
::Tools
::get_cluster_versions
(undef, 1); };
430 if (!$ceph_versions) {
431 log_fail
("unable to determine Ceph daemon versions!");
434 { 'key' => 'mon', 'name' => 'monitor' },
435 { 'key' => 'mgr', 'name' => 'manager' },
436 { 'key' => 'mds', 'name' => 'MDS' },
437 { 'key' => 'osd', 'name' => 'OSD' },
440 foreach my $service (@$services) {
441 my $name = $service->{name
};
442 if (my $service_versions = $ceph_versions->{$service->{key
}}) {
443 if (keys %$service_versions == 0) {
444 log_skip
("no running instances detected for daemon type $name.");
445 } elsif (keys %$service_versions == 1) {
446 log_pass
("single running version detected for daemon type $name.");
448 log_warn
("multiple running versions detected for daemon type $name!");
451 log_skip
("unable to determine versions of running Ceph $name instances.");
455 my $overall_versions = $ceph_versions->{overall
};
456 if (!$overall_versions) {
457 log_warn
("unable to determine overall Ceph daemon versions!");
458 } elsif (keys %$overall_versions == 1) {
459 log_pass
("single running overall version detected for all Ceph daemon types.");
460 if ((keys %$overall_versions)[0] =~ /^ceph version 15\./) {
464 log_warn
("overall version mismatch detected, check 'ceph versions' output for details!");
470 log_pass
("'noout' flag set to prevent rebalancing during cluster-wide upgrades.");
472 log_warn
("'noout' flag set, Ceph cluster upgrade seems finished.");
474 } elsif ($noout_wanted) {
475 log_warn
("'noout' flag not set - recommended to prevent rebalancing during upgrades.");
478 log_info
("checking Ceph config..");
479 my $conf = PVE
::Cluster
::cfs_read_file
('ceph.conf');
481 my $global = $conf->{global
};
483 my $global_monhost = $global->{mon_host
} // $global->{"mon host"} // $global->{"mon-host"};
484 if (!defined($global_monhost)) {
485 log_warn
("No 'mon_host' entry found in ceph config.\n It's recommended to add mon_host with all monitor addresses (without ports) to the global section.");
487 log_pass
("Found 'mon_host' entry.");
490 my $ipv6 = $global->{ms_bind_ipv6
} // $global->{"ms bind ipv6"} // $global->{"ms-bind-ipv6"};
492 my $ipv4 = $global->{ms_bind_ipv4
} // $global->{"ms bind ipv4"} // $global->{"ms-bind-ipv4"};
493 if ($ipv6 eq 'true' && (!defined($ipv4) || $ipv4 ne 'false')) {
494 log_warn
("'ms_bind_ipv6' is enabled but 'ms_bind_ipv4' is not disabled.\n Make sure to disable 'ms_bind_ipv4' for ipv6 only clusters, or add an ipv4 network to public/cluster network.");
496 log_pass
("'ms_bind_ipv6' is enabled and 'ms_bind_ipv4' disabled");
499 log_pass
("'ms_bind_ipv6' not enabled");
502 if (defined($global->{keyring
})) {
503 log_warn
("[global] config section contains 'keyring' option, which will prevent services from starting with Nautilus.\n Move 'keyring' option to [client] section instead.");
505 log_pass
("no 'keyring' option in [global] section found.");
509 log_warn
("Empty ceph config found");
512 my $local_ceph_ver = PVE
::Ceph
::Tools
::get_local_version
(1);
513 if (defined($local_ceph_ver)) {
514 if ($local_ceph_ver == 14) {
515 my $ceph_volume_osds = PVE
::Ceph
::Tools
::ceph_volume_list
();
516 my $scanned_osds = PVE
::Tools
::dir_glob_regex
('/etc/ceph/osd', '^.*\.json$');
517 if (-e
'/var/lib/ceph/osd/' && !defined($scanned_osds) && !(keys %$ceph_volume_osds)) {
518 log_warn
("local Ceph version is Nautilus, local OSDs detected, but no conversion from ceph-disk to ceph-volume done (yet).");
522 log_fail
("unable to determine local Ceph version.");
526 sub check_backup_retention_settings
{
527 log_info
("Checking backup retention settings..");
531 my $node_has_retention;
533 my $maxfiles_msg = "parameter 'maxfiles' is deprecated with PVE 7.x and will be removed in a " .
534 "future version, use 'prune-backups' instead.";
537 my $confdesc = PVE
::VZDump
::Common
::get_confdesc
();
539 my $fn = "/etc/vzdump.conf";
540 my $raw = PVE
::Tools
::file_get_contents
($fn);
542 my $conf_schema = { type
=> 'object', properties
=> $confdesc, };
543 my $param = PVE
::JSONSchema
::parse_config
($conf_schema, $fn, $raw);
545 if (defined($param->{maxfiles
})) {
547 log_warn
("$fn - $maxfiles_msg");
550 $node_has_retention = defined($param->{maxfiles
}) || defined($param->{'prune-backups'});
554 log_warn
("unable to parse node's VZDump configuration - $err");
557 my $storage_cfg = PVE
::Storage
::config
();
559 for my $storeid (keys $storage_cfg->{ids
}->%*) {
560 my $scfg = $storage_cfg->{ids
}->{$storeid};
562 if (defined($scfg->{maxfiles
})) {
564 log_warn
("storage '$storeid' - $maxfiles_msg");
567 next if !$scfg->{content
}->{backup
};
568 next if defined($scfg->{maxfiles
}) || defined($scfg->{'prune-backups'});
569 next if $node_has_retention;
571 log_info
("storage '$storeid' - no backup retention settings defined - by default, PVE " .
572 "7.x will no longer keep only the last backup, but all backups");
576 my $vzdump_cron = PVE
::Cluster
::cfs_read_file
('vzdump.cron');
578 # only warn once, there might be many jobs...
579 if (scalar(grep { defined($_->{maxfiles
}) } $vzdump_cron->{jobs
}->@*)) {
581 log_warn
("/etc/pve/vzdump.cron - $maxfiles_msg");
586 log_warn
("unable to parse node's VZDump configuration - $err");
589 log_pass
("no problems found.") if $pass;
592 sub check_cifs_credential_location
{
593 log_info
("checking CIFS credential location..");
595 my $regex = qr/^(.*)\.cred$/;
599 PVE
::Tools
::dir_glob_foreach
('/etc/pve/priv/', $regex, sub {
602 my ($basename) = $filename =~ $regex;
604 log_warn
("CIFS credentials '/etc/pve/priv/$filename' will be moved to " .
605 "'/etc/pve/priv/storage/$basename.pw' during the update");
610 log_pass
("no CIFS credentials at outdated location found.") if !$found;
613 sub check_custom_pool_roles
{
614 log_info
("Checking custom roles for pool permissions..");
616 if (! -f
"/etc/pve/user.cfg") {
617 log_skip
("user.cfg does not exist");
621 my $raw = eval { PVE
::Tools
::file_get_contents
('/etc/pve/user.cfg'); };
623 log_fail
("Failed to read '/etc/pve/user.cfg' - $@");
628 while ($raw =~ /^\s*(.+?)\s*$/gm) {
632 foreach my $d (split (/:/, $line)) {
638 my $et = shift @data;
639 next if $et ne 'role';
641 my ($role, $privlist) = @data;
642 if (!PVE
::AccessControl
::verify_rolename
($role, 1)) {
643 warn "user config - ignore role '$role' - invalid characters in role name\n";
647 $roles->{$role} = {} if !$roles->{$role};
648 foreach my $priv (split_list
($privlist)) {
649 $roles->{$role}->{$priv} = 1;
653 foreach my $role (sort keys %{$roles}) {
654 if (PVE
::AccessControl
::role_is_special
($role)) {
658 if ($role eq "PVEPoolUser") {
659 # the user created a custom role named PVEPoolUser
660 log_fail
("Custom role '$role' has a restricted name - a built-in role 'PVEPoolUser' will be available with the upgrade");
662 log_pass
("Custom role '$role' has no restricted name");
665 my $perms = $roles->{$role};
666 if ($perms->{'Pool.Allocate'} && $perms->{'Pool.Audit'}) {
667 log_pass
("Custom role '$role' contains updated pool permissions");
668 } elsif ($perms->{'Pool.Allocate'}) {
669 log_warn
("Custom role '$role' contains permission 'Pool.Allocate' - to ensure same behavior add 'Pool.Audit' to this role");
671 log_pass
("Custom role '$role' contains no permissions that need to be updated");
676 my sub check_max_length
{
677 my ($raw, $max_length, $warning) = @_;
678 log_warn
($warning) if defined($raw) && length($raw) > $max_length;
681 sub check_description_lengths
{
682 log_info
("Checking node and guest description/note legnth..");
684 my @affected_nodes = grep {
685 my $desc = PVE
::NodeConfig
::load_config
($_)->{desc
};
686 defined($desc) && length($desc) > 64 * 1024
687 } PVE
::Cluster
::get_nodelist
();
689 if (scalar(@affected_nodes) > 0) {
690 log_warn
("Node config description of the following nodes too long for new limit of 64 KiB:\n "
691 . join(', ', @affected_nodes));
693 log_pass
("All node config descriptions fit in the new limit of 64 KiB");
696 my $affected_guests = [];
698 my $cts = PVE
::LXC
::config_list
();
699 for my $vmid (sort { $a <=> $b } keys %$cts) {
700 my $desc = PVE
::LXC
::Config-
>load_config($vmid)->{description
};
701 push @$affected_guests, "CT $vmid" if defined($desc) && length($desc) > 8 * 1024;
703 my $vms = PVE
::QemuServer
::config_list
();
704 for my $vmid (sort { $a <=> $b } keys %$vms) {
705 my $desc = PVE
::QemuConfig-
>load_config($vmid)->{description
};
706 push @$affected_guests, "VM $vmid" if defined($desc) && length($desc) > 8 * 1024;
708 if (scalar($affected_guests->@*) > 0) {
709 log_warn
("Guest config description of the following virtual-guests too long for new limit of 64 KiB:\n"
710 ." * " . join("\n * ", $affected_guests->@*));
712 log_pass
("All guest config descriptions fit in the new limit of 8 KiB");
716 sub check_storage_content
{
717 log_info
("Checking storage content type configuration..");
719 my $found_referenced;
720 my $found_unreferenced;
723 my $storage_cfg = PVE
::Storage
::config
();
725 my $potentially_affected = {};
726 my $referenced_volids = {};
728 for my $storeid (sort keys $storage_cfg->{ids
}->%*) {
729 my $scfg = $storage_cfg->{ids
}->{$storeid};
731 next if !PVE
::Storage
::storage_check_enabled
($storage_cfg, $storeid, undef, 1);
733 my $valid_content = PVE
::Storage
::Plugin
::valid_content_types
($scfg->{type
});
735 if (scalar(keys $scfg->{content
}->%*) == 0 && !$valid_content->{none
}) {
737 log_fail
("storage '$storeid' does not support configured content type 'none'");
738 delete $scfg->{content
}->{none
}; # scan for guest images below
741 next if $scfg->{content
}->{images
} && $scfg->{content
}->{rootdir
};
743 # Skip 'iscsi(direct)' (and foreign plugins with potentially similiar behavior) with 'none',
744 # because that means "use LUNs directly" and vdisk_list() in PVE 6.x still lists those.
745 # It's enough to *not* skip 'dir', because it is the only other storage that supports 'none'
746 # and 'images' or 'rootdir', hence being potentially misconfigured.
747 next if $scfg->{type
} ne 'dir' && $scfg->{content
}->{none
};
749 eval { PVE
::Storage
::activate_storage
($storage_cfg, $storeid) };
751 log_warn
("activating '$storeid' failed - $err");
755 my $res = eval { PVE
::Storage
::vdisk_list
($storage_cfg, $storeid); };
757 log_warn
("listing images on '$storeid' failed - $err");
760 my @volids = map { $_->{volid
} } $res->{$storeid}->@*;
762 for my $volid (@volids) {
763 $potentially_affected->{$volid} = 1;
766 my $number = scalar(@volids);
767 if ($number > 0 && !$scfg->{content
}->{images
} && !$scfg->{content
}->{rootdir
}) {
768 log_info
("storage '$storeid' - neither content type 'images' nor 'rootdir' configured"
769 .", but found $number guest volume(s)");
773 my $check_volid = sub {
774 my ($volid, $vmid, $vmtype, $reference) = @_;
776 $referenced_volids->{$volid} = 1 if $reference ne 'unreferenced';
778 my $guesttext = $vmtype eq 'qemu' ?
'VM' : 'CT';
779 my $prefix = "$guesttext $vmid - volume '$volid' ($reference)";
781 my ($storeid) = PVE
::Storage
::parse_volume_id
($volid, 1);
782 return if !defined($storeid);
784 my $scfg = $storage_cfg->{ids
}->{$storeid};
787 log_warn
("$prefix - storage does not exist!");
791 # cannot use parse_volname for containers, as it can return 'images'
792 # but containers cannot have ISO images attached, so assume 'rootdir'
793 my $vtype = 'rootdir';
794 if ($vmtype eq 'qemu') {
795 ($vtype) = eval { PVE
::Storage
::parse_volname
($storage_cfg, $volid); };
799 if (!$scfg->{content
}->{$vtype}) {
800 $found_referenced = 1 if $reference ne 'unreferenced';
801 $found_unreferenced = 1 if $reference eq 'unreferenced';
803 log_warn
("$prefix - storage does not have content type '$vtype' configured.");
809 my $cts = PVE
::LXC
::config_list
();
810 for my $vmid (sort { $a <=> $b } keys %$cts) {
811 $guests->{$vmid} = 'lxc';
813 my $conf = PVE
::LXC
::Config-
>load_config($vmid);
818 my ($ms, $mountpoint, $reference) = @_;
820 my $volid = $mountpoint->{volume
};
821 return if !$volid || $mountpoint->{type
} ne 'volume';
823 return if $volhash->{$volid}; # volume might be referenced multiple times
825 $volhash->{$volid} = 1;
827 $check_volid->($volid, $vmid, 'lxc', $reference);
830 my $opts = { include_unused
=> 1 };
831 PVE
::LXC
::Config-
>foreach_volume_full($conf, $opts, $check, 'in config');
832 for my $snapname (keys $conf->{snapshots
}->%*) {
833 my $snap = $conf->{snapshots
}->{$snapname};
834 PVE
::LXC
::Config-
>foreach_volume_full($snap, $opts, $check, "in snapshot '$snapname'");
838 my $vms = PVE
::QemuServer
::config_list
();
839 for my $vmid (sort { $a <=> $b } keys %$vms) {
840 $guests->{$vmid} = 'qemu';
842 my $conf = PVE
::QemuConfig-
>load_config($vmid);
847 my ($key, $drive, $reference) = @_;
849 my $volid = $drive->{file
};
850 return if $volid =~ m
|^/|;
852 return if $volhash->{$volid}; # volume might be referenced multiple times
854 $volhash->{$volid} = 1;
856 $check_volid->($volid, $vmid, 'qemu', $reference);
860 extra_keys
=> ['vmstate'],
863 # startup from a suspended state works even without 'images' content type on the
864 # state storage, so do not check 'vmstate' for $conf
865 PVE
::QemuConfig-
>foreach_volume_full($conf, { include_unused
=> 1 }, $check, 'in config');
866 for my $snapname (keys $conf->{snapshots
}->%*) {
867 my $snap = $conf->{snapshots
}->{$snapname};
868 PVE
::QemuConfig-
>foreach_volume_full($snap, $opts, $check, "in snapshot '$snapname'");
872 if ($found_referenced) {
873 log_warn
("Proxmox VE 7.0 enforces stricter content type checks. The guests above " .
874 "might not work until the storage configuration is fixed.");
877 for my $volid (sort keys $potentially_affected->%*) {
878 next if $referenced_volids->{$volid}; # already checked
880 my (undef, undef, $vmid) = PVE
::Storage
::parse_volname
($storage_cfg, $volid);
881 my $vmtype = $guests->{$vmid};
884 $check_volid->($volid, $vmid, $vmtype, 'unreferenced');
887 if ($found_unreferenced) {
888 log_warn
("When migrating, Proxmox VE 7.0 only scans storages with the appropriate " .
889 "content types for unreferenced guest volumes.");
893 log_pass
("no problems found");
897 sub check_containers_cgroup_compat
{
899 my $kernel_cli = PVE
::Tools
::file_get_contents
('/proc/cmdline');
900 if ($kernel_cli =~ /systemd.unified_cgroup_hierarchy=0/){
901 log_skip
("System explicitly configured for legacy hybrid cgroup hierarchy.");
905 my $supports_cgroupv2 = sub {
906 my ($conf, $rootdir, $ctid) = @_;
908 my $get_systemd_version = sub {
911 my $sd_lib_dir = -d
"/lib/systemd" ?
"/lib/systemd" : "/usr/lib/systemd";
912 my $libsd = PVE
::Tools
::dir_glob_regex
($sd_lib_dir, "libsystemd-shared-.+\.so");
913 if (defined($libsd) && $libsd =~ /libsystemd-shared-(\d+)\.so/) {
920 my $unified_cgroupv2_support = sub {
923 # https://www.freedesktop.org/software/systemd/man/systemd.html
924 # systemd is installed as symlink to /sbin/init
925 my $systemd = CORE
::readlink('/sbin/init');
927 # assume non-systemd init will run with unified cgroupv2
928 if (!defined($systemd) || $systemd !~ m
@/systemd$@) {
932 # systemd version 232 (e.g. debian stretch) supports the unified hierarchy
933 my $sdver = $get_systemd_version->();
934 if (!defined($sdver) || $sdver < 232) {
941 my $ostype = $conf->{ostype
};
942 if (!defined($ostype)) {
943 log_warn
("Found CT ($ctid) without 'ostype' set!");
944 } elsif ($ostype eq 'devuan' || $ostype eq 'alpine') {
945 return 1; # no systemd, no cgroup problems
948 my $lxc_setup = PVE
::LXC
::Setup-
>new($conf, $rootdir);
949 return $lxc_setup->protected_call($unified_cgroupv2_support);
952 my $log_problem = sub {
954 log_warn
("Found at least one CT ($ctid) which does not support running in a unified cgroup v2" .
955 " layout.\n Either upgrade the Container distro or set systemd.unified_cgroup_hierarchy=0 " .
956 "in the Proxmox VE hosts' kernel cmdline! Skipping further CT compat checks."
960 my $cts = eval { PVE
::API2
::LXC-
>vmlist({ node
=> $nodename }) };
962 log_warn
("Failed to retrieve information about this node's CTs - $@");
966 if (!defined($cts) || !scalar(@$cts)) {
967 log_skip
("No containers on node detected.");
971 my @running_cts = sort { $a <=> $b } grep { $_->{status
} eq 'running' } @$cts;
972 my @offline_cts = sort { $a <=> $b } grep { $_->{status
} ne 'running' } @$cts;
974 for my $ct (@running_cts) {
975 my $ctid = $ct->{vmid
};
976 my $pid = eval { PVE
::LXC
::find_lxc_pid
($ctid) };
978 log_warn
("Failed to get PID for running CT $ctid - $err");
981 my $rootdir = "/proc/$pid/root";
982 my $conf = PVE
::LXC
::Config-
>load_config($ctid);
984 my $ret = eval { $supports_cgroupv2->($conf, $rootdir, $ctid) };
986 log_warn
("Failed to get cgroup support status for CT $ctid - $err");
990 $log_problem->($ctid);
995 my $storage_cfg = PVE
::Storage
::config
();
996 for my $ct (@offline_cts) {
997 my $ctid = $ct->{vmid
};
998 my ($conf, $rootdir, $ret);
1000 $conf = PVE
::LXC
::Config-
>load_config($ctid);
1001 $rootdir = PVE
::LXC
::mount_all
($ctid, $storage_cfg, $conf);
1002 $ret = $supports_cgroupv2->($conf, $rootdir, $ctid);
1005 log_warn
("Failed to load config and mount CT $ctid - $err");
1006 eval { PVE
::LXC
::umount_all
($ctid, $storage_cfg, $conf) };
1010 $log_problem->($ctid);
1011 eval { PVE
::LXC
::umount_all
($ctid, $storage_cfg, $conf) };
1015 eval { PVE
::LXC
::umount_all
($ctid, $storage_cfg, $conf) };
1020 print_header
("MISCELLANEOUS CHECKS");
1021 my $ssh_config = eval { PVE
::Tools
::file_get_contents
('/root/.ssh/config') };
1022 if (defined($ssh_config)) {
1023 log_fail
("Unsupported SSH Cipher configured for root in /root/.ssh/config: $1")
1024 if $ssh_config =~ /^Ciphers .*(blowfish|arcfour|3des).*$/m;
1026 log_skip
("No SSH config file found.");
1029 log_info
("Checking common daemon services..");
1030 $log_systemd_unit_state->('pveproxy.service');
1031 $log_systemd_unit_state->('pvedaemon.service');
1032 $log_systemd_unit_state->('pvestatd.service');
1034 my $root_free = PVE
::Tools
::df
('/', 10);
1035 log_warn
("Less than 4 GiB free space on root file system.")
1036 if defined($root_free) && $root_free->{avail
} < 4*1024*1024*1024;
1038 log_info
("Checking for running guests..");
1039 my $running_guests = 0;
1041 my $vms = eval { PVE
::API2
::Qemu-
>vmlist({ node
=> $nodename }) };
1042 log_warn
("Failed to retrieve information about this node's VMs - $@") if $@;
1043 $running_guests += grep { $_->{status
} eq 'running' } @$vms if defined($vms);
1045 my $cts = eval { PVE
::API2
::LXC-
>vmlist({ node
=> $nodename }) };
1046 log_warn
("Failed to retrieve information about this node's CTs - $@") if $@;
1047 $running_guests += grep { $_->{status
} eq 'running' } @$cts if defined($cts);
1049 if ($running_guests > 0) {
1050 log_warn
("$running_guests running guest(s) detected - consider migrating or stopping them.")
1052 log_pass
("no running guest detected.")
1055 log_info
("Checking if the local node's hostname '$nodename' is resolvable..");
1056 my $local_ip = eval { PVE
::Network
::get_ip_from_hostname
($nodename) };
1058 log_warn
("Failed to resolve hostname '$nodename' to IP - $@");
1060 log_info
("Checking if resolved IP is configured on local node..");
1061 my $cidr = Net
::IP
::ip_is_ipv6
($local_ip) ?
"$local_ip/128" : "$local_ip/32";
1062 my $configured_ips = PVE
::Network
::get_local_ip_from_cidr
($cidr);
1063 my $ip_count = scalar(@$configured_ips);
1065 if ($ip_count <= 0) {
1066 log_fail
("Resolved node IP '$local_ip' not configured or active for '$nodename'");
1067 } elsif ($ip_count > 1) {
1068 log_warn
("Resolved node IP '$local_ip' active on multiple ($ip_count) interfaces!");
1070 log_pass
("Resolved node IP '$local_ip' configured and active on single interface.");
1074 log_info
("Check node certificate's RSA key size");
1075 my $certs = PVE
::API2
::Certificates-
>info({ node
=> $nodename });
1077 'rsaEncryption' => {
1081 'id-ecPublicKey' => {
1087 my $certs_check_failed = 0;
1088 foreach my $cert (@$certs) {
1089 my ($type, $size, $fn) = $cert->@{qw(public-key-type public-key-bits filename)};
1091 if (!defined($type) || !defined($size)) {
1092 log_warn
("'$fn': cannot check certificate, failed to get it's type or size!");
1095 my $check = $certs_check->{$type};
1096 if (!defined($check)) {
1097 log_warn
("'$fn': certificate's public key type '$type' unknown, check Debian Busters release notes");
1101 if ($size < $check->{minsize
}) {
1102 log_fail
("'$fn', certificate's $check->{name} public key size is less than 2048 bit");
1103 $certs_check_failed = 1;
1105 log_pass
("Certificate '$fn' passed Debian Busters security level for TLS connections ($size >= 2048)");
1109 check_backup_retention_settings
();
1110 check_cifs_credential_location
();
1111 check_custom_pool_roles
();
1112 check_description_lengths
();
1113 check_storage_content
();
1116 __PACKAGE__-
>register_method ({
1117 name
=> 'checklist',
1118 path
=> 'checklist',
1120 description
=> 'Check (pre-/post-)upgrade conditions.',
1122 additionalProperties
=> 0,
1125 description
=> 'perform additional, expensive checks.',
1132 returns
=> { type
=> 'null' },
1136 check_pve_packages
();
1137 check_cluster_corosync
();
1139 check_storage_health
();
1142 if ($param->{full
}) {
1143 check_containers_cgroup_compat
();
1145 log_skip
("Expensive checks not performed without 'full' parameter");
1148 print_header
("SUMMARY");
1151 $total += $_ for values %$counters;
1153 print "TOTAL: $total\n";
1154 print colored
("PASSED: $counters->{pass}\n", 'green');
1155 print "SKIPPED: $counters->{skip}\n";
1156 print colored
("WARNINGS: $counters->{warn}\n", 'yellow');
1157 print colored
("FAILURES: $counters->{fail}\n", 'red');
1159 if ($counters->{warn} > 0 || $counters->{fail
} > 0) {
1160 my $color = $counters->{fail
} > 0 ?
'red' : 'yellow';
1161 print colored
("\nATTENTION: Please check the output for detailed information!\n", $color);
1162 print colored
("Try to solve the problems one at a time and then run this checklist tool again.\n", $color) if $counters->{fail
} > 0;
1168 our $cmddef = [ __PACKAGE__
, 'checklist', [], {}];