]> git.proxmox.com Git - qemu-server.git/blob - PVE/QemuServer/ImportDisk.pm
Add skiplock to do_import
[qemu-server.git] / PVE / QemuServer / ImportDisk.pm
1 package PVE::QemuServer::ImportDisk;
2
3 use strict;
4 use warnings;
5
6 use PVE::Storage;
7 use PVE::QemuServer;
8 use PVE::Tools qw(run_command extract_param);
9
10 # imports an external disk image to an existing VM
11 # and creates by default a drive entry unused[n] pointing to the created volume
12 # $optional->{drive_name} may be used to specify ide0, scsi1, etc ...
13 # $optional->{format} may be used to specify qcow2, raw, etc ...
14 sub do_import {
15 my ($src_path, $vmid, $storage_id, $skiplock, $optional) = @_;
16
17 my $drive_name = extract_param($optional, 'drive_name');
18 my $format = extract_param($optional, 'format');
19 my $debug = extract_param($optional, 'debug');
20 if ($drive_name && !(PVE::QemuServer::is_valid_drivename($drive_name))) {
21 die "invalid drive name: $drive_name\n";
22 }
23
24 # get the needed size from source disk
25 my $src_size = PVE::Storage::file_size_info($src_path);
26
27 # get target format, target image's path, and whether it's possible to sparseinit
28 my $storecfg = PVE::Storage::config();
29 my $dst_format = PVE::QemuServer::resolve_dst_disk_format($storecfg,
30 $storage_id, undef, $format);
31 warn "format : $dst_format\n" if $debug;
32
33 my $dst_volid = PVE::Storage::vdisk_alloc($storecfg, $storage_id, $vmid,
34 $dst_format, undef, $src_size / 1024);
35 my $dst_path = PVE::Storage::path($storecfg, $dst_volid);
36
37 warn "args: $src_path, $vmid, $storage_id, $optional\n",
38 "\$dst_volid: $dst_volid\n", if $debug;
39
40 my $zeroinit = PVE::Storage::volume_has_feature($storecfg, 'sparseinit', $dst_volid);
41
42 my $create_drive = sub {
43 my $vm_conf = PVE::QemuConfig->load_config($vmid);
44 if (!$skiplock) {
45 PVE::QemuConfig->check_lock($vm_conf);
46 }
47
48 if ($drive_name) {
49 # should never happen as setting $drive_name is not exposed to public interface
50 die "cowardly refusing to overwrite existing entry: $drive_name\n" if $vm_conf->{$drive_name};
51
52 my $modified = {}; # record what $option we modify
53 $modified->{$drive_name} = 1;
54 $vm_conf->{pending}->{$drive_name} = $dst_volid;
55 PVE::QemuConfig->write_config($vmid, $vm_conf);
56
57 my $running = PVE::QemuServer::check_running($vmid);
58 if ($running) {
59 my $errors = {};
60 PVE::QemuServer::vmconfig_hotplug_pending($vmid, $vm_conf, $storecfg, $modified, $errors);
61 if (scalar(keys %$errors)) {
62 foreach my $k (keys %$errors) {
63 warn "$k: $errors->{$k}\n" if $debug;
64 warn "hotplugging imported disk failed\n";
65 }
66 }
67 } else {
68 PVE::QemuServer::vmconfig_apply_pending($vmid, $vm_conf, $storecfg);
69 }
70
71 } else {
72 PVE::QemuConfig->add_unused_volume($vm_conf, $dst_volid);
73 PVE::QemuConfig->write_config($vmid, $vm_conf);
74 }
75
76 };
77
78 eval {
79 # trap interrupts so we have a chance to clean up
80 local $SIG{INT} =
81 local $SIG{TERM} =
82 local $SIG{QUIT} =
83 local $SIG{HUP} =
84 local $SIG{PIPE} = sub { die "interrupted by signal\n"; };
85 PVE::Storage::activate_volumes($storecfg, [$dst_volid]);
86 PVE::QemuServer::qemu_img_convert($src_path, $dst_volid, $src_size, undef, $zeroinit);
87 PVE::Storage::deactivate_volumes($storecfg, [$dst_volid]);
88 PVE::QemuConfig->lock_config($vmid, $create_drive);
89 };
90
91 my $err = $@;
92 if ($err) {
93 eval { # do not die before we returned $err
94 PVE::Storage::vdisk_free($storecfg, $dst_volid);
95 };
96 die $err;
97 }
98 }
99
100 1;