]> git.proxmox.com Git - qemu-server.git/blobdiff - PVE/QemuMigrate.pm
Remove unused 'sharedvm' variable
[qemu-server.git] / PVE / QemuMigrate.pm
index 6bb19db61505e3df2d95450c4daf45369d3f939d..49848e8e57af492350283b01d9d3a0b32219a93a 100644 (file)
@@ -11,6 +11,8 @@ use PVE::Tools;
 use PVE::Cluster;
 use PVE::Storage;
 use PVE::QemuServer;
+use PVE::QemuServer::Machine;
+use PVE::QemuServer::Monitor qw(mon_cmd);
 use Time::HiRes qw( usleep );
 use PVE::RPCEnvironment;
 use PVE::ReplicationConfig;
@@ -215,13 +217,13 @@ sub prepare {
        die "can't migrate running VM without --online\n" if !$online;
        $running = $pid;
 
-       $self->{forcemachine} = PVE::QemuServer::qemu_machine_pxe($vmid, $conf);
+       $self->{forcemachine} = PVE::QemuServer::Machine::qemu_machine_pxe($vmid, $conf);
 
     }
-
-    if (my $loc_res = PVE::QemuServer::check_local_resources($conf, 1)) {
+    my $loc_res = PVE::QemuServer::check_local_resources($conf, 1);
+    if (scalar @$loc_res) {
        if ($self->{running} || !$self->{opts}->{force}) {
-           die "can't migrate VM which uses local devices\n";
+           die "can't migrate VM which uses local devices: " . join(", ", @$loc_res) . "\n";
        } else {
            $self->log('info', "migrating VM which uses local devices");
        }
@@ -280,8 +282,6 @@ sub sync_disks {
        my $other_errors = [];
        my $abort = 0;
 
-       my $sharedvm = 1;
-
        my $log_error = sub {
            my ($msg, $volid) = @_;
 
@@ -308,7 +308,6 @@ sub sync_disks {
 
            # check if storage is available on target node
            PVE::Storage::storage_check_node($self->{storecfg}, $targetsid, $self->{node});
-           $sharedvm = 0; # there is a non-shared disk
 
            PVE::Storage::foreach_volid($dl, sub {
                my ($volid, $sid, $volname) = @_;
@@ -350,8 +349,6 @@ sub sync_disks {
 
            return if $scfg->{shared};
 
-           $sharedvm = 0;
-
            $local_volumes->{$volid}->{ref} = $attr->{referenced_in_config} ? 'config' : 'snapshot';
 
            if ($attr->{cdrom}) {
@@ -424,8 +421,7 @@ sub sync_disks {
            my ($sid, $volname) = PVE::Storage::parse_volume_id($volid);
            my $scfg =  PVE::Storage::storage_config($self->{storecfg}, $sid);
 
-           my $migratable = ($scfg->{type} eq 'dir') || ($scfg->{type} eq 'zfspool') ||
-               ($scfg->{type} eq 'lvmthin') || ($scfg->{type} eq 'lvm');
+           my $migratable = $scfg->{type} =~ /^(?:dir|zfspool|lvmthin|lvm)$/;
 
            die "can't migrate '$volid' - storage type '$scfg->{type}' not supported\n"
                if !$migratable;
@@ -436,21 +432,30 @@ sub sync_disks {
            }
        }
 
-       my $rep_volumes;
-
-       $self->log('info', "copying disk images");
-
        my $rep_cfg = PVE::ReplicationConfig->new();
-
        if (my $jobcfg = $rep_cfg->find_local_replication_job($vmid, $self->{node})) {
            die "can't live migrate VM with replicated volumes\n" if $self->{running};
+           $self->log('info', "replicating disk images");
            my $start_time = time();
-           my $logfunc = sub { my ($msg) = @_;  $self->log('info', $msg); };
-           $rep_volumes = PVE::Replication::run_replication(
+           my $logfunc = sub { $self->log('info', shift) };
+           $self->{replicated_volumes} = PVE::Replication::run_replication(
               'PVE::QemuConfig', $jobcfg, $start_time, $start_time, $logfunc);
-           $self->{replicated_volumes} = $rep_volumes;
        }
 
+       # sizes in config have to be accurate for remote node to correctly
+       # allocate disks, rescan to be sure
+       my $volid_hash = PVE::QemuServer::scan_volids($self->{storecfg}, $vmid);
+       PVE::QemuServer::foreach_drive($conf, sub {
+           my ($key, $drive) = @_;
+           my ($updated, $old_size, $new_size) = PVE::QemuServer::update_disksize($drive, $volid_hash);
+           if (defined($updated)) {
+               $conf->{$key} = PVE::QemuServer::print_drive($updated);
+               $self->log('info', "size of disk '$updated->{file}' ($key) updated from $old_size to $new_size\n");
+           }
+       });
+
+       $self->log('info', "copying local disk images") if scalar(%$local_volumes);
+
        foreach my $volid (keys %$local_volumes) {
            my ($sid, $volname) = PVE::Storage::parse_volume_id($volid);
            my $targetsid = $override_targetsid // $sid;
@@ -458,16 +463,23 @@ sub sync_disks {
            if ($self->{running} && $ref eq 'config') {
                push @{$self->{online_local_volumes}}, $volid;
            } elsif ($ref eq 'generated') {
+               die "can't live migrate VM with local cloudinit disk. use a shared storage instead\n" if $self->{running};
                # skip all generated volumes but queue them for deletion in phase3_cleanup
                push @{$self->{volumes}}, $volid;
                next;
            } else {
-               next if $rep_volumes->{$volid};
+               next if $self->{replicated_volumes}->{$volid};
                push @{$self->{volumes}}, $volid;
-               my $insecure = $self->{opts}->{migration_type} eq 'insecure';
+               my $opts = $self->{opts};
+               my $insecure = $opts->{migration_type} eq 'insecure';
                my $with_snapshots = $local_volumes->{$volid}->{snapshots};
+               # use 'migrate' limit for transfer to other node
+               my $bwlimit = PVE::Storage::get_bandwidth_limit('migrate', [$targetsid, $sid], $opts->{bwlimit});
+               # JSONSchema and get_bandwidth_limit use kbps - storage_migrate bps
+               $bwlimit = $bwlimit * 1024 if defined($bwlimit);
+
                PVE::Storage::storage_migrate($self->{storecfg}, $volid, $self->{ssh_info}, $targetsid,
-                                             undef, undef, undef, undef, $insecure, $with_snapshots);
+                                             undef, undef, undef, $bwlimit, $insecure, $with_snapshots);
            }
        }
     };
@@ -505,6 +517,9 @@ sub phase1 {
 
     sync_disks($self, $vmid);
 
+    # sync_disks fixes disk sizes to match their actual size, write changes so
+    # target allocates correct volumes
+    PVE::QemuConfig->write_config($vmid, $conf);
 };
 
 sub phase1_cleanup {
@@ -544,7 +559,7 @@ sub phase2 {
 
     my $spice_ticket;
     if (PVE::QemuServer::vga_conf_has_spice($conf->{vga})) {
-       my $res = PVE::QemuServer::vm_mon_cmd($vmid, 'query-spice');
+       my $res = mon_cmd($vmid, 'query-spice');
        $spice_ticket = $res->{ticket};
     }
 
@@ -575,7 +590,7 @@ sub phase2 {
 
     # Note: We try to keep $spice_ticket secret (do not pass via command line parameter)
     # instead we pipe it through STDIN
-    PVE::Tools::run_command($cmd, input => $spice_ticket, outfunc => sub {
+    my $exitcode = PVE::Tools::run_command($cmd, input => $spice_ticket, outfunc => sub {
        my $line = shift;
 
        if ($line =~ m/^migration listens on tcp:(localhost|[\d\.]+|\[[\d\.:a-fA-F]+\]):(\d+)$/) {
@@ -605,11 +620,15 @@ sub phase2 {
            $self->{target_drive}->{$targetdrive}->{volid} = $volid;
            $self->{target_drive}->{$targetdrive}->{nbd_uri} = $nbd_uri;
 
+       } elsif ($line =~ m/^QEMU: (.*)$/) {
+           $self->log('info', "[$self->{node}] $1\n");
        }
     }, errfunc => sub {
        my $line = shift;
-       $self->log('info', $line);
-    });
+       $self->log('info', "[$self->{node}] $line");
+    }, noerr => 1);
+
+    die "remote command failed with exit code $exitcode\n" if $exitcode;
 
     die "unable to detect remote migration address\n" if !$raddr;
 
@@ -655,6 +674,8 @@ sub phase2 {
 
     my $start = time();
 
+    my $opt_bwlimit = $self->{opts}->{bwlimit};
+
     if (defined($self->{online_local_volumes})) {
        $self->{storage_migration} = 1;
        $self->{storage_migration_jobs} = {};
@@ -663,9 +684,14 @@ sub phase2 {
        die "The number of local disks does not match between the source and the destination.\n"
            if (scalar(keys %{$self->{target_drive}}) != scalar @{$self->{online_local_volumes}});
        foreach my $drive (keys %{$self->{target_drive}}){
-           my $nbd_uri = $self->{target_drive}->{$drive}->{nbd_uri};
+           my $target = $self->{target_drive}->{$drive};
+           my $nbd_uri = $target->{nbd_uri};
+           my $source_sid = PVE::Storage::Plugin::parse_volume_id($conf->{$drive});
+           my $target_sid = PVE::Storage::Plugin::parse_volume_id($target->{volid});
+           my $bwlimit = PVE::Storage::get_bandwidth_limit('migrate', [$source_sid, $target_sid], $opt_bwlimit);
+
            $self->log('info', "$drive: start migration to $nbd_uri");
-           PVE::QemuServer::qemu_drive_mirror($vmid, $drive, $nbd_uri, $vmid, undef, $self->{storage_migration_jobs}, 1);
+           PVE::QemuServer::qemu_drive_mirror($vmid, $drive, $nbd_uri, $vmid, undef, $self->{storage_migration_jobs}, 1, undef, $bwlimit);
        }
     }
 
@@ -675,14 +701,24 @@ sub phase2 {
     # load_defaults
     my $defaults = PVE::QemuServer::load_defaults();
 
-    # always set migrate speed (overwrite kvm default of 32m)
-    # we set a very hight default of 8192m which is basically unlimited
-    my $migrate_speed = $defaults->{migrate_speed} || 8192;
-    $migrate_speed = $conf->{migrate_speed} || $migrate_speed;
-    $migrate_speed = $migrate_speed * 1048576;
+    # migrate speed can be set via bwlimit (datacenter.cfg and API) and via the
+    # migrate_speed parameter in qm.conf - take the lower of the two.
+    my $bwlimit = PVE::Storage::get_bandwidth_limit('migrate', undef, $opt_bwlimit) // 0;
+    my $migrate_speed = $conf->{migrate_speed} // $bwlimit;
+    # migrate_speed is in MB/s, bwlimit in KB/s
+    $migrate_speed *= 1024;
+
+    $migrate_speed = ($bwlimit < $migrate_speed) ? $bwlimit : $migrate_speed;
+
+    # always set migrate speed (overwrite kvm default of 32m) we set a very high
+    # default of 8192m which is basically unlimited
+    $migrate_speed ||= ($defaults->{migrate_speed} || 8192) * 1024;
+
+    # qmp takes migrate_speed in B/s.
+    $migrate_speed *= 1024;
     $self->log('info', "migrate_set_speed: $migrate_speed");
     eval {
-        PVE::QemuServer::vm_mon_cmd_nocheck($vmid, "migrate_set_speed", value => int($migrate_speed));
+       mon_cmd($vmid, "migrate_set_speed", value => int($migrate_speed));
     };
     $self->log('info', "migrate_set_speed error: $@") if $@;
 
@@ -691,7 +727,7 @@ sub phase2 {
     if (defined($migrate_downtime)) {
        $self->log('info', "migrate_set_downtime: $migrate_downtime");
        eval {
-           PVE::QemuServer::vm_mon_cmd_nocheck($vmid, "migrate_set_downtime", value => int($migrate_downtime*100)/100);
+           mon_cmd($vmid, "migrate_set_downtime", value => int($migrate_downtime*100)/100);
        };
        $self->log('info', "migrate_set_downtime error: $@") if $@;
     }
@@ -709,7 +745,7 @@ sub phase2 {
 
     $self->log('info', "set cachesize: $cachesize");
     eval {
-       PVE::QemuServer::vm_mon_cmd_nocheck($vmid, "migrate-set-cache-size", value => int($cachesize));
+       mon_cmd($vmid, "migrate-set-cache-size", value => int($cachesize));
     };
     $self->log('info', "migrate-set-cache-size error: $@") if $@;
 
@@ -725,8 +761,8 @@ sub phase2 {
        $self->log('info', "spice client_migrate_info");
 
        eval {
-           PVE::QemuServer::vm_mon_cmd_nocheck($vmid, "client_migrate_info", protocol => 'spice', 
-                                               hostname => $proxyticket, 'tls-port' => $spice_port, 
+           mon_cmd($vmid, "client_migrate_info", protocol => 'spice',
+                                               hostname => $proxyticket, 'port' => 0, 'tls-port' => $spice_port,
                                                'cert-subject' => $subject);
        };
        $self->log('info', "client_migrate_info error: $@") if $@;
@@ -735,7 +771,7 @@ sub phase2 {
 
     $self->log('info', "start migrate command to $ruri");
     eval {
-        PVE::QemuServer::vm_mon_cmd_nocheck($vmid, "migrate", uri => $ruri);
+       mon_cmd($vmid, "migrate", uri => $ruri);
     };
     my $merr = $@;
     $self->log('info', "migrate uri => $ruri failed: $merr") if $merr;
@@ -753,7 +789,7 @@ sub phase2 {
        usleep($usleep);
        my $stat;
        eval {
-           $stat = PVE::QemuServer::vm_mon_cmd_nocheck($vmid, "query-migrate");
+           $stat = mon_cmd($vmid, "query-migrate");
        };
        if (my $err = $@) {
            $err_count++;
@@ -822,7 +858,7 @@ sub phase2 {
                    $migrate_downtime *= 2;
                    $self->log('info', "migrate_set_downtime: $migrate_downtime");
                    eval {
-                       PVE::QemuServer::vm_mon_cmd_nocheck($vmid, "migrate_set_downtime", value => int($migrate_downtime*100)/100);
+                       mon_cmd($vmid, "migrate_set_downtime", value => int($migrate_downtime*100)/100);
                    };
                    $self->log('info', "migrate_set_downtime error: $@") if $@;
                }
@@ -831,7 +867,7 @@ sub phase2 {
 
 
            $lstat = $stat->{ram}->{transferred};
-           
+
        } else {
            die $merr if $merr;
            die "unable to parse migration status '$stat->{status}' - aborting\n";
@@ -849,7 +885,7 @@ sub phase2_cleanup {
 
     $self->log('info', "migrate_cancel");
     eval {
-       PVE::QemuServer::vm_mon_cmd_nocheck($vmid, "migrate_cancel");
+       mon_cmd($vmid, "migrate_cancel");
     };
     $self->log('info', "migrate_cancel error: $@") if $@;
 
@@ -875,7 +911,7 @@ sub phase2_cleanup {
     }
 
     my $nodename = PVE::INotify::nodename();
+
     my $cmd = [@{$self->{rem_ssh}}, 'qm', 'stop', $vmid, '--skiplock', '--migratedfrom', $nodename];
     eval{ PVE::Tools::run_command($cmd, outfunc => sub {}, errfunc => sub {}) };
     if (my $err = $@) {
@@ -924,11 +960,11 @@ sub phase3_cleanup {
        if (my $err = $@) {
            eval { PVE::QemuServer::qemu_blockjobs_cancel($vmid, $self->{storage_migration_jobs}) };
            eval { PVE::QemuMigrate::cleanup_remotedisks($self) };
-           die "Failed to completed storage migration\n";
+           die "Failed to complete storage migration: $err\n";
        } else {
            foreach my $target_drive (keys %{$self->{target_drive}}) {
                my $drive = PVE::QemuServer::parse_drive($target_drive, $self->{target_drive}->{$target_drive}->{volid});
-               $conf->{$target_drive} = PVE::QemuServer::print_drive($vmid, $drive);
+               $conf->{$target_drive} = PVE::QemuServer::print_drive($drive);
                PVE::QemuConfig->write_config($vmid, $conf);
            }
        }
@@ -1000,7 +1036,7 @@ sub phase3_cleanup {
        if (PVE::QemuServer::vga_conf_has_spice($conf->{vga}) && $self->{running}) {
            $self->log('info', "Waiting for spice server migration");
            while (1) {
-               my $res = PVE::QemuServer::vm_mon_cmd_nocheck($vmid, 'query-spice');
+               my $res = mon_cmd($vmid, 'query-spice');
                last if int($res->{'migrated'}) == 1;
                last if $timer > 50;
                $timer ++;