use strict;
use warnings;
+
use Fcntl ':flock';
-use PVE::Exception qw(raise_param_exc);
-use PVE::SafeSyslog;
+use File::Path;
use IO::File;
use IO::Select;
use IPC::Open3;
use POSIX qw(strftime);
-use File::Path;
-use PVE::RPCEnvironment;
-use PVE::Storage;
-use PVE::Cluster qw(cfs_read_file);
-use Time::localtime;
use Time::Local;
-use PVE::JSONSchema qw(get_standard_option);
-use PVE::HA::Env::PVE2;
+
+use PVE::Cluster qw(cfs_read_file);
+use PVE::DataCenterConfig;
+use PVE::Exception qw(raise_param_exc);
use PVE::HA::Config;
+use PVE::HA::Env::PVE2;
+use PVE::JSONSchema qw(get_standard_option);
+use PVE::RPCEnvironment;
+use PVE::Storage;
+use PVE::VZDump::Common;
+use PVE::VZDump::Plugin;
+use PVE::Tools qw(extract_param split_list);
+use PVE::API2Tools;
my @posix_filesystems = qw(ext3 ext4 nfs nfs4 reiserfs xfs);
my $lockfile = '/var/run/vzdump.lock';
-
my $pidfile = '/var/run/vzdump.pid';
-
my $logdir = '/var/log/vzdump';
my @plugins = qw();
-my $confdesc = {
- vmid => {
- type => 'string', format => 'pve-vmid-list',
- description => "The ID of the guest system you want to backup.",
- completion => \&PVE::Cluster::complete_local_vmid,
- optional => 1,
- },
- node => get_standard_option('pve-node', {
- description => "Only run if executed on this node.",
- completion => \&PVE::Cluster::get_nodelist,
- optional => 1,
- }),
- all => {
- type => 'boolean',
- description => "Backup all known guest systems on this host.",
- optional => 1,
- default => 0,
- },
- stdexcludes => {
- type => 'boolean',
- description => "Exclude temporary files and logs.",
- optional => 1,
- default => 1,
- },
- compress => {
- type => 'string',
- description => "Compress dump file.",
- optional => 1,
- enum => ['0', '1', 'gzip', 'lzo'],
- default => '0',
- },
- pigz=> {
- type => "integer",
- description => "Use pigz instead of gzip when N>0.".
- " N=1 uses half of cores, N>1 uses N as thread count.",
- optional => 1,
- default => 0,
- },
- quiet => {
- type => 'boolean',
- description => "Be quiet.",
- optional => 1,
- default => 0,
- },
- mode => {
- type => 'string',
- description => "Backup mode.",
- optional => 1,
- default => 'snapshot',
- enum => [ 'snapshot', 'suspend', 'stop' ],
- },
- exclude => {
- type => 'string', format => 'pve-vmid-list',
- description => "Exclude specified guest systems (assumes --all)",
- optional => 1,
- },
- 'exclude-path' => {
- type => 'string', format => 'string-alist',
- description => "Exclude certain files/directories (shell globs).",
- optional => 1,
- },
- mailto => {
- type => 'string', format => 'string-list',
- description => "Comma-separated list of email addresses that should" .
- " receive email notifications.",
- optional => 1,
- },
- mailnotification => {
- type => 'string',
- description => "Specify when to send an email",
- optional => 1,
- enum => [ 'always', 'failure' ],
- default => 'always',
- },
- tmpdir => {
- type => 'string',
- description => "Store temporary files to specified directory.",
- optional => 1,
- },
- dumpdir => {
- type => 'string',
- description => "Store resulting files to specified directory.",
- optional => 1,
- },
- script => {
- type => 'string',
- description => "Use specified hook script.",
- optional => 1,
- },
- storage => get_standard_option('pve-storage-id', {
- description => "Store resulting file to this storage.",
- completion => \&complete_backup_storage,
- optional => 1,
- }),
- stop => {
- type => 'boolean',
- description => "Stop runnig backup jobs on this host.",
- optional => 1,
- default => 0,
- },
- size => {
- type => 'integer',
- description => "Unused, will be removed in a future release.",
- optional => 1,
- minimum => 500,
- default => 1024,
- },
- bwlimit => {
- type => 'integer',
- description => "Limit I/O bandwidth (KBytes per second).",
- optional => 1,
- minimum => 0,
- default => 0,
- },
- ionice => {
- type => 'integer',
- description => "Set CFQ ionice priority.",
- optional => 1,
- minimum => 0,
- maximum => 8,
- default => 7,
- },
- lockwait => {
- type => 'integer',
- description => "Maximal time to wait for the global lock (minutes).",
- optional => 1,
- minimum => 0,
- default => 3*60, # 3 hours
- },
- stopwait => {
- type => 'integer',
- description => "Maximal time to wait until a guest system is stopped (minutes).",
- optional => 1,
- minimum => 0,
- default => 10, # 10 minutes
- },
- maxfiles => {
- type => 'integer',
- description => "Maximal number of backup files per guest system.",
- optional => 1,
- minimum => 1,
- default => 1,
- },
- remove => {
- type => 'boolean',
- description => "Remove old backup files if there are more than 'maxfiles' backup files.",
- optional => 1,
- default => 1,
- },
-};
+my $confdesc = PVE::VZDump::Common::get_confdesc();
# Load available plugins
my @pve_vzdump_classes = qw(PVE::VZDump::QemuServer PVE::VZDump::LXC);
$plug->import ();
push @plugins, $plug;
} else {
- warn $@;
+ die $@;
}
}
}
# helper functions
-my $debugstattxt = {
- err => 'ERROR:',
- info => 'INFO:',
- warn => 'WARN:',
-};
-
sub debugmsg {
my ($mtype, $msg, $logfd, $syslog) = @_;
- chomp $msg;
-
- return if !$msg;
-
- my $pre = $debugstattxt->{$mtype} || $debugstattxt->{'err'};
-
- my $timestr = strftime ("%b %d %H:%M:%S", CORE::localtime);
-
- syslog ($mtype eq 'info' ? 'info' : 'err', "$pre $msg") if $syslog;
-
- foreach my $line (split (/\n/, $msg)) {
- print STDERR "$pre $line\n";
- print $logfd "$timestr $pre $line\n" if $logfd;
- }
+ PVE::VZDump::Plugin::debugmsg(@_);
}
sub run_command {
PVE::Tools::run_command($cmdstr, %param, logfunc => $logfunc);
}
+my $parse_prune_backups_maxfiles = sub {
+ my ($param, $kind) = @_;
+
+ my $maxfiles = delete $param->{maxfiles};
+ my $prune_backups = $param->{'prune-backups'};
+
+ debugmsg('warn', "both 'maxfiles' and 'prune-backups' defined as ${kind} - ignoring 'maxfiles'")
+ if defined($maxfiles) && defined($prune_backups);
+
+ if (defined($prune_backups)) {
+ return if ref($prune_backups) eq 'HASH'; # already parsed
+ $param->{'prune-backups'} = PVE::JSONSchema::parse_property_string(
+ 'prune-backups',
+ $prune_backups
+ );
+ } elsif (defined($maxfiles)) {
+ if ($maxfiles) {
+ $param->{'prune-backups'} = { 'keep-last' => $maxfiles };
+ } else {
+ $param->{'prune-backups'} = { 'keep-all' => 1 };
+ }
+ }
+};
+
sub storage_info {
my $storage = shift;
my $cfg = PVE::Storage::config();
my $scfg = PVE::Storage::storage_config($cfg, $storage);
my $type = $scfg->{type};
-
- die "can't use storage type '$type' for backup\n"
- if (!($type eq 'dir' || $type eq 'nfs' || $type eq 'glusterfs'));
- die "can't use storage '$storage' for backups - wrong content type\n"
- if (!$scfg->{content}->{backup});
- PVE::Storage::activate_storage($cfg, $storage);
+ die "can't use storage type '$type' for backup\n"
+ if (!($type eq 'dir' || $type eq 'nfs' || $type eq 'glusterfs'
+ || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs'));
+ die "can't use storage '$storage' for backups - wrong content type\n"
+ if (!$scfg->{content}->{backup});
- return {
- dumpdir => PVE::Storage::get_backup_dir($cfg, $storage),
- maxfiles => $scfg->{maxfiles},
+ my $info = {
+ scfg => $scfg,
};
+
+ $info->{'prune-backups'} = PVE::JSONSchema::parse_property_string('prune-backups', $scfg->{'prune-backups'})
+ if defined($scfg->{'prune-backups'});
+
+ if ($type eq 'pbs') {
+ $info->{pbs} = 1;
+ } else {
+ $info->{dumpdir} = PVE::Storage::get_backup_dir($cfg, $storage);
+ }
+
+ return $info;
}
sub format_size {
}
my $mb = $size / (1024*1024);
-
if ($mb < 1024) {
return int ($mb) . "MB";
- } else {
- my $gb = $mb / 1024;
+ }
+ my $gb = $mb / 1024;
+ if ($gb < 1024) {
return sprintf ("%.2fGB", $gb);
- }
+ }
+ my $tb = $gb / 1024;
+ return sprintf ("%.2fTB", $tb);
}
sub format_time {
my (@vmids) = @_;
my $res = [];
- foreach my $vmid (@vmids) {
+ for my $vmid (sort {$a <=> $b} @vmids) {
die "ERROR: strange VM ID '${vmid}'\n" if $vmid !~ m/^\d+$/;
$vmid = int ($vmid); # remove leading zeros
next if !$vmid;
defined($default) ? ($_ => $default) : ()
} keys %$confdesc
};
+ $parse_prune_backups_maxfiles->($defaults, "defaults in VZDump schema");
my $raw;
eval { $raw = PVE::Tools::file_get_contents($fn); };
$res->{'exclude-path'} = PVE::Tools::split_args($excludes);
}
if (defined($res->{mailto})) {
- my @mailto = PVE::Tools::split_list($res->{mailto});
+ my @mailto = split_list($res->{mailto});
$res->{mailto} = [ @mailto ];
}
+ $parse_prune_backups_maxfiles->($res, "options in '$fn'");
foreach my $key (keys %$defaults) {
$res->{$key} = $defaults->{$key} if !defined($res->{$key});
}
+ if (defined($res->{storage}) && defined($res->{dumpdir})) {
+ debugmsg('warn', "both 'storage' and 'dumpdir' defined in '$fn' - ignoring 'dumpdir'");
+ delete $res->{dumpdir};
+ }
+
return $res;
}
+use constant MAX_MAIL_SIZE => 1024*1024;
sub sendmail {
- my ($self, $tasklist, $totaltime, $err) = @_;
+ my ($self, $tasklist, $totaltime, $err, $detail_pre, $detail_post) = @_;
my $opts = $self->{opts};
chomp $task->{msg} if $task->{msg};
$task->{backuptime} = 0 if !$task->{backuptime};
$task->{size} = 0 if !$task->{size};
- $task->{tarfile} = 'unknown' if !$task->{tarfile};
+ $task->{target} = 'unknown' if !$task->{target};
$task->{hostname} = "VM $task->{vmid}" if !$task->{hostname};
if ($task->{state} eq 'todo') {
# text part
my $text = $err ? "$err\n\n" : '';
- $text .= sprintf ("%-10s %-6s %10s %10s %s\n", qw(VMID STATUS TIME SIZE FILENAME));
+ my $namelength = 20;
+ $text .= sprintf (
+ "%-10s %-${namelength}s %-6s %10s %10s %s\n",
+ qw(VMID NAME STATUS TIME SIZE FILENAME)
+ );
foreach my $task (@$tasklist) {
- my $vmid = $task->{vmid};
- if ($task->{state} eq 'ok') {
-
- $text .= sprintf ("%-10s %-6s %10s %10s %s\n", $vmid,
- $task->{state},
- format_time($task->{backuptime}),
- format_size ($task->{size}),
- $task->{tarfile});
- } else {
- $text .= sprintf ("%-10s %-6s %10s %8.2fMB %s\n", $vmid,
- $task->{state},
- format_time($task->{backuptime}),
- 0, '-');
- }
+ my $name = substr($task->{hostname}, 0, $namelength);
+ my $successful = $task->{state} eq 'ok';
+ my $size = $successful ? format_size ($task->{size}) : 0;
+ my $filename = $successful ? $task->{target} : '-';
+ my $size_fmt = $successful ? "%10s": "%8.2fMB";
+ $text .= sprintf(
+ "%-10s %-${namelength}s %-6s %10s $size_fmt %s\n",
+ $task->{vmid},
+ $name,
+ $task->{state},
+ format_time($task->{backuptime}),
+ $size,
+ $filename,
+ );
}
- $text .= "Detailed backup logs:\n\n";
- $text .= "$cmdline\n\n";
+ my $text_log_part;
+ $text_log_part .= "\nDetailed backup logs:\n\n";
+ $text_log_part .= "$cmdline\n\n";
+ $text_log_part .= $detail_pre . "\n" if defined($detail_pre);
foreach my $task (@$tasklist) {
my $vmid = $task->{vmid};
my $log = $task->{tmplog};
if (!$log) {
- $text .= "$vmid: no log available\n\n";
+ $text_log_part .= "$vmid: no log available\n\n";
next;
}
- open (TMP, "$log");
- while (my $line = <TMP>) { $text .= encode8bit ("$vmid: $line"); }
- close (TMP);
- $text .= "\n";
+ if (open (my $TMP, '<', "$log")) {
+ while (my $line = <$TMP>) {
+ next if $line =~ /^status: \d+/; # not useful in mails
+ $text_log_part .= encode8bit ("$vmid: $line");
+ }
+ close ($TMP);
+ } else {
+ $text_log_part .= "$vmid: Could not open log file\n\n";
+ }
+ $text_log_part .= "\n";
}
+ $text_log_part .= $detail_post if defined($detail_post);
# html part
my $html = "<html><body>\n";
$html .= "<tr><td>VMID<td>NAME<td>STATUS<td>TIME<td>SIZE<td>FILENAME</tr>\n";
my $ssize = 0;
-
foreach my $task (@$tasklist) {
my $vmid = $task->{vmid};
my $name = $task->{hostname};
if ($task->{state} eq 'ok') {
-
$ssize += $task->{size};
- $html .= sprintf ("<tr><td>%s<td>%s<td>OK<td>%s<td align=right>%s<td>%s</tr>\n",
- $vmid, $name,
- format_time($task->{backuptime}),
- format_size ($task->{size}),
- escape_html ($task->{tarfile}));
+ $html .= sprintf (
+ "<tr><td>%s<td>%s<td>OK<td>%s<td align=right>%s<td>%s</tr>\n",
+ $vmid,
+ $name,
+ format_time($task->{backuptime}),
+ format_size ($task->{size}),
+ escape_html ($task->{target}),
+ );
} else {
- $html .= sprintf ("<tr><td>%s<td>%s<td><font color=red>FAILED<td>%s<td colspan=2>%s</tr>\n",
- $vmid, $name, format_time($task->{backuptime}),
- escape_html ($task->{msg}));
+ $html .= sprintf (
+ "<tr><td>%s<td>%s<td><font color=red>FAILED<td>%s<td colspan=2>%s</tr>\n",
+ $vmid,
+ $name,
+ format_time($task->{backuptime}),
+ escape_html ($task->{msg}),
+ );
}
}
$html .= sprintf ("<tr><td align=left colspan=3>TOTAL<td>%s<td>%s<td></tr>",
format_time ($totaltime), format_size ($ssize));
- $html .= "</table><br><br>\n";
- $html .= "Detailed backup logs:<br /><br />\n";
- $html .= "<pre>\n";
- $html .= escape_html($cmdline) . "\n\n";
+ $html .= "\n</table><br><br>\n";
+ my $html_log_part;
+ $html_log_part .= "Detailed backup logs:<br /><br />\n";
+ $html_log_part .= "<pre>\n";
+ $html_log_part .= escape_html($cmdline) . "\n\n";
+ $html_log_part .= escape_html($detail_pre) . "\n" if defined($detail_pre);
foreach my $task (@$tasklist) {
my $vmid = $task->{vmid};
my $log = $task->{tmplog};
if (!$log) {
- $html .= "$vmid: no log available\n\n";
+ $html_log_part .= "$vmid: no log available\n\n";
next;
}
- open (TMP, "$log");
- while (my $line = <TMP>) {
- if ($line =~ m/^\S+\s\d+\s+\d+:\d+:\d+\s+(ERROR|WARN):/) {
- $html .= encode8bit ("$vmid: <font color=red>".
- escape_html ($line) . "</font>");
- } else {
- $html .= encode8bit ("$vmid: " . escape_html ($line));
+ if (open (my $TMP, '<', "$log")) {
+ while (my $line = <$TMP>) {
+ next if $line =~ /^status: \d+/; # not useful in mails
+ if ($line =~ m/^\S+\s\d+\s+\d+:\d+:\d+\s+(ERROR|WARN):/) {
+ $html_log_part .= encode8bit ("$vmid: <font color=red>".
+ escape_html ($line) . "</font>");
+ } else {
+ $html_log_part .= encode8bit ("$vmid: " . escape_html ($line));
+ }
}
+ close ($TMP);
+ } else {
+ $html_log_part .= "$vmid: Could not open log file\n\n";
}
- close (TMP);
- $html .= "\n";
+ $html_log_part .= "\n";
}
- $html .= "</pre></body></html>\n";
+ $html_log_part .= escape_html($detail_post) if defined($detail_post);
+ $html_log_part .= "</pre>";
+ my $html_end = "\n</body></html>\n";
# end html part
+ if (length($text) + length($text_log_part) +
+ length($html) + length($html_log_part) +
+ length($html_end) < MAX_MAIL_SIZE)
+ {
+ $html .= $html_log_part;
+ $html .= $html_end;
+ $text .= $text_log_part;
+ } else {
+ my $msg = "Log output was too long to be sent by mail. ".
+ "See Task History for details!\n";
+ $text .= $msg;
+ $html .= "<p>$msg</p>";
+ $html .= $html_end;
+ }
+
my $subject = "vzdump backup status ($hostname) : $stat";
my $dcconf = PVE::Cluster::cfs_read_file('datacenter.cfg');
my $defaults = read_vzdump_defaults();
- my $maxfiles = $opts->{maxfiles}; # save here, because we overwrite with default
-
- $opts->{remove} = 1 if !defined($opts->{remove});
-
foreach my $k (keys %$defaults) {
- next if $k eq 'exclude-path'; # dealt with separately
+ next if $k eq 'exclude-path' || $k eq 'prune-backups'; # dealt with separately
if ($k eq 'dumpdir' || $k eq 'storage') {
$opts->{$k} = $defaults->{$k} if !defined ($opts->{dumpdir}) &&
!defined ($opts->{storage});
$opts->{tmpdir} =~ s|/+$|| if ($opts->{tmpdir});
$skiplist = [] if !$skiplist;
- my $self = bless { cmdline => $cmdline, opts => $opts, skiplist => $skiplist };
+ my $self = bless {
+ cmdline => $cmdline,
+ opts => $opts,
+ skiplist => $skiplist,
+ }, $class;
my $findexcl = $self->{findexcl} = [];
if ($defaults->{'exclude-path'}) {
}
if ($opts->{stdexcludes}) {
- push @$findexcl, '/var/log/?*',
- '/tmp/?*',
- '/var/tmp/?*',
- '/var/run/?*.pid';
+ push @$findexcl,
+ '/tmp/?*',
+ '/var/tmp/?*',
+ '/var/run/?*.pid',
+ ;
}
foreach my $p (@plugins) {
-
- my $pd = $p->new ($self);
+ my $pd = $p->new($self);
push @{$self->{plugins}}, $pd;
}
+ if (defined($opts->{storage}) && $opts->{stdout}) {
+ die "cannot use options 'storage' and 'stdout' at the same time\n";
+ } elsif (defined($opts->{storage}) && defined($opts->{dumpdir})) {
+ die "cannot use options 'storage' and 'dumpdir' at the same time\n";
+ }
+
if (!$opts->{dumpdir} && !$opts->{storage}) {
$opts->{storage} = 'local';
}
my $errors = '';
if ($opts->{storage}) {
- my $info = storage_info ($opts->{storage});
- $opts->{dumpdir} = $info->{dumpdir};
- $maxfiles = $info->{maxfiles} if !defined($maxfiles) && defined($info->{maxfiles});
+ my $storage_cfg = PVE::Storage::config();
+ eval { PVE::Storage::activate_storage($storage_cfg, $opts->{storage}) };
+ if (my $err = $@) {
+ chomp($err);
+ $errors .= "could not activate storage '$opts->{storage}': $err";
+ }
+
+ my $info = eval { storage_info ($opts->{storage}) };
+ if (my $err = $@) {
+ chomp($err);
+ $errors .= "could not get storage information for '$opts->{storage}': $err";
+ } else {
+ $opts->{dumpdir} = $info->{dumpdir};
+ $opts->{scfg} = $info->{scfg};
+ $opts->{pbs} = $info->{pbs};
+ $opts->{'prune-backups'} //= $info->{'prune-backups'};
+ }
} elsif ($opts->{dumpdir}) {
$errors .= "dumpdir '$opts->{dumpdir}' does not exist"
if ! -d $opts->{dumpdir};
} else {
- die "internal error";
+ die "internal error";
}
+ $opts->{'prune-backups'} //= $defaults->{'prune-backups'};
+
+ # avoid triggering any remove code path if keep-all is set
+ $opts->{remove} = 0 if $opts->{'prune-backups'}->{'keep-all'};
+
if ($opts->{tmpdir} && ! -d $opts->{tmpdir}) {
$errors .= "\n" if $errors;
$errors .= "tmpdir '$opts->{tmpdir}' does not exist";
die "$errors\n";
}
- $opts->{maxfiles} = $maxfiles if defined($maxfiles);
-
return $self;
-
}
sub get_mount_info {
my ($self, $upid) = @_;
my $fh;
-
+
my $maxwait = $self->{opts}->{lockwait} || $self->{lockwait};
-
- die "missimg UPID" if !$upid; # should not happen
- if (!open (SERVER_FLCK, ">>$lockfile")) {
+ die "missing UPID" if !$upid; # should not happen
+
+ my $SERVER_FLCK;
+ if (!open ($SERVER_FLCK, '>>', "$lockfile")) {
debugmsg ('err', "can't open lock on file '$lockfile' - $!", undef, 1);
die "can't open lock on file '$lockfile' - $!";
}
- if (!flock (SERVER_FLCK, LOCK_EX|LOCK_NB)) {
-
+ if (!flock ($SERVER_FLCK, LOCK_EX|LOCK_NB)) {
if (!$maxwait) {
- debugmsg ('err', "can't aquire lock '$lockfile' (wait = 0)", undef, 1);
- die "can't aquire lock '$lockfile' (wait = 0)";
+ debugmsg ('err', "can't acquire lock '$lockfile' (wait = 0)", undef, 1);
+ die "can't acquire lock '$lockfile' (wait = 0)";
}
debugmsg('info', "trying to get global lock - waiting...", undef, 1);
-
eval {
alarm ($maxwait * 60);
-
+
local $SIG{ALRM} = sub { alarm (0); die "got timeout\n"; };
- if (!flock (SERVER_FLCK, LOCK_EX)) {
+ if (!flock ($SERVER_FLCK, LOCK_EX)) {
my $err = $!;
- close (SERVER_FLCK);
+ close ($SERVER_FLCK);
alarm (0);
die "$err\n";
}
alarm (0);
};
alarm (0);
-
+
my $err = $@;
-
+
if ($err) {
- debugmsg ('err', "can't aquire lock '$lockfile' - $err", undef, 1);
- die "can't aquire lock '$lockfile' - $err";
+ debugmsg ('err', "can't acquire lock '$lockfile' - $err", undef, 1);
+ die "can't acquire lock '$lockfile' - $err";
}
debugmsg('info', "got global lock", undef, 1);
}
PVE::Tools::file_set_contents($pidfile, $upid);
+
+ return $SERVER_FLCK;
}
sub run_hook_script {
my $opts = $self->{opts};
my $script = $opts->{script};
-
return if !$script;
- my $cmd = "$script $phase";
+ if (!-x $script) {
+ die "The hook script '$script' is not executable.\n";
+ }
- $cmd .= " $task->{mode} $task->{vmid}" if ($task);
+ my $cmd = [$script, $phase];
- local %ENV;
+ if ($task) {
+ push @$cmd, $task->{mode};
+ push @$cmd, $task->{vmid};
+ }
+ local %ENV;
# set immutable opts directly (so they are available in all phases)
$ENV{STOREID} = $opts->{storage} if $opts->{storage};
$ENV{DUMPDIR} = $opts->{dumpdir} if $opts->{dumpdir};
- foreach my $ek (qw(vmtype hostname tarfile logfile)) {
+ foreach my $ek (qw(vmtype hostname target logfile)) {
$ENV{uc($ek)} = $task->{$ek} if $task->{$ek};
}
+ # FIXME: for backwards compatibility - drop with PVE 7.0
+ $ENV{TARFILE} = $task->{target} if $task->{target};
run_command ($logfd, $cmd);
}
return ('lzop', 'lzo');
} elsif ($opt_compress eq 'gzip') {
if ($opts->{pigz} > 0) {
- # As default use int((#cores + 1)/2), we need #cores+1 for the case that #cores = 1
- my $cores = POSIX::sysconf(84);
- my $pigz_threads = ($opts->{pigz} > 1) ? $opts->{pigz} : int(($cores + 1)/2);
- return ("pigz -p ${pigz_threads}", 'gz');
+ my $pigz_threads = $opts->{pigz};
+ if ($pigz_threads == 1) {
+ my $cpuinfo = PVE::ProcFSTools::read_cpuinfo();
+ $pigz_threads = int(($cpuinfo->{cpus} + 1)/2);
+ }
+ return ("pigz -p ${pigz_threads} --rsyncable", 'gz');
} else {
- return ('gzip', 'gz');
+ return ('gzip --rsyncable', 'gz');
}
+ } elsif ($opt_compress eq 'zstd') {
+ my $zstd_threads = $opts->{zstd} // 1;
+ if ($zstd_threads == 0) {
+ my $cpuinfo = PVE::ProcFSTools::read_cpuinfo();
+ $zstd_threads = int(($cpuinfo->{cpus} + 1)/2);
+ }
+ return ("zstd --rsyncable --threads=${zstd_threads}", 'zst');
} else {
die "internal error - unknown compression option '$opt_compress'";
}
my $bklist = [];
foreach my $fn (<$dir/${bkname}-*>) {
next if $exclude_fn && $fn eq $exclude_fn;
- if ($fn =~ m!/(${bkname}-(\d{4})_(\d{2})_(\d{2})-(\d{2})_(\d{2})_(\d{2})\.(tgz|((tar|vma)(\.(gz|lzo))?)))$!) {
- $fn = "$dir/$1"; # untaint
- my $t = timelocal ($7, $6, $5, $4, $3 - 1, $2 - 1900);
- push @$bklist, [$fn, $t];
+
+ my $archive_info = eval { PVE::Storage::archive_info($fn) } // {};
+ if ($archive_info->{is_std_name}) {
+ my $filename = $archive_info->{filename};
+ my $backup = {
+ 'path' => "$dir/$filename",
+ 'ctime' => $archive_info->{ctime},
+ };
+ push @{$bklist}, $backup;
}
}
return $bklist;
}
-
+
sub exec_backup_task {
my ($self, $task) = @_;
-
+
my $opts = $self->{opts};
+ my $cfg = PVE::Storage::config();
my $vmid = $task->{vmid};
my $plugin = $task->{plugin};
+ $task->{backup_time} = time();
+
+ my $pbs_group_name;
+ my $pbs_snapshot_name;
+
my $vmstarttime = time ();
-
+
my $logfd;
my $cleanup = {};
- my $vmstoptime = 0;
+ my $log_vm_online_again = sub {
+ return if !defined($task->{vmstoptime});
+ $task->{vmconttime} //= time();
+ my $delay = $task->{vmconttime} - $task->{vmstoptime};
+ $delay = '<1' if $delay < 1;
+ debugmsg ('info', "guest is online again after $delay seconds", $logfd);
+ };
eval {
die "unable to find VM '$vmid'\n" if !$plugin;
+ my $vmtype = $plugin->type();
+
+ if ($self->{opts}->{pbs}) {
+ if ($vmtype eq 'lxc') {
+ $pbs_group_name = "ct/$vmid";
+ } elsif ($vmtype eq 'qemu') {
+ $pbs_group_name = "vm/$vmid";
+ } else {
+ die "pbs backup not implemented for plugin type '$vmtype'\n";
+ }
+ my $btime = strftime("%FT%TZ", gmtime($task->{backup_time}));
+ $pbs_snapshot_name = "$pbs_group_name/$btime";
+ }
+
# for now we deny backups of a running ha managed service in *stop* mode
- # as it interferes with the HA stack (enabled services should not stop).
+ # as it interferes with the HA stack (started services should not stop).
if ($opts->{mode} eq 'stop' &&
- PVE::HA::Config::vm_is_ha_managed($vmid, 'enabled'))
+ PVE::HA::Config::vm_is_ha_managed($vmid, 'started'))
{
die "Cannot execute a backup with stop mode on a HA managed and".
" enabled Service. Use snapshot mode or disable the Service.\n";
}
- my $vmtype = $plugin->type();
-
my $tmplog = "$logdir/$vmtype-$vmid.log";
- my $lt = localtime();
-
my $bkname = "vzdump-$vmtype-$vmid";
- my $basename = sprintf "${bkname}-%04d_%02d_%02d-%02d_%02d_%02d",
- $lt->year + 1900, $lt->mon + 1, $lt->mday,
- $lt->hour, $lt->min, $lt->sec;
+ my $basename = $bkname . strftime("-%Y_%m_%d-%H_%M_%S", localtime($task->{backup_time}));
- my $maxfiles = $opts->{maxfiles};
+ my $prune_options = $opts->{'prune-backups'};
- if ($maxfiles && !$opts->{remove}) {
- my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname);
- die "only $maxfiles backup(s) allowed - please consider to remove old backup files.\n"
- if scalar(@$bklist) >= $maxfiles;
+ my $backup_limit = 0;
+ if (!$prune_options->{'keep-all'}) {
+ foreach my $keep (values %{$prune_options}) {
+ $backup_limit += $keep;
+ }
}
- my $logfile = $task->{logfile} = "$opts->{dumpdir}/$basename.log";
+ if ($backup_limit && !$opts->{remove}) {
+ my $count;
+ if ($self->{opts}->{pbs}) {
+ my $res = PVE::Storage::PBSPlugin::run_client_cmd($opts->{scfg}, $opts->{storage}, 'snapshots', $pbs_group_name);
+ $count = scalar(@$res);
+ } else {
+ my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname);
+ $count = scalar(@$bklist);
+ }
+ die "There is a max backup limit of $backup_limit enforced by the".
+ " target storage or the vzdump parameters.".
+ " Either increase the limit or delete old backup(s).\n"
+ if $count >= $backup_limit;
+ }
+
+ if (!$self->{opts}->{pbs}) {
+ $task->{logfile} = "$opts->{dumpdir}/$basename.log";
+ }
my $ext = $vmtype eq 'qemu' ? '.vma' : '.tar';
my ($comp, $comp_ext) = compressor_info($opts);
$ext .= ".${comp_ext}";
}
- if ($opts->{stdout}) {
- $task->{tarfile} = '-';
+ if ($self->{opts}->{pbs}) {
+ die "unable to pipe backup to stdout\n" if $opts->{stdout};
+ $task->{target} = $pbs_snapshot_name;
} else {
- my $tarfile = $task->{tarfile} = "$opts->{dumpdir}/$basename$ext";
- $task->{tmptar} = $task->{tarfile};
- $task->{tmptar} =~ s/\.[^\.]+$/\.dat/;
- unlink $task->{tmptar};
+ if ($opts->{stdout}) {
+ $task->{target} = '-';
+ } else {
+ $task->{target} = $task->{tmptar} = "$opts->{dumpdir}/$basename$ext";
+ $task->{tmptar} =~ s/\.[^\.]+$/\.dat/;
+ unlink $task->{tmptar};
+ }
}
$task->{vmtype} = $vmtype;
+ my $pid = $$;
if ($opts->{tmpdir}) {
- $task->{tmpdir} = "$opts->{tmpdir}/vzdumptmp$$";
+ $task->{tmpdir} = "$opts->{tmpdir}/vzdumptmp${pid}_$vmid/";
+ } elsif ($self->{opts}->{pbs}) {
+ $task->{tmpdir} = "/var/tmp/vzdumptmp${pid}_$vmid";
} else {
# dumpdir is posix? then use it as temporary dir
my $info = get_mount_info($opts->{dumpdir});
- if ($vmtype eq 'qemu' ||
+ if ($vmtype eq 'qemu' ||
grep ($_ eq $info->{fstype}, @posix_filesystems)) {
$task->{tmpdir} = "$opts->{dumpdir}/$basename.tmp";
} else {
- $task->{tmpdir} = "/var/tmp/vzdumptmp$$";
+ $task->{tmpdir} = "/var/tmp/vzdumptmp${pid}_$vmid";
debugmsg ('info', "filesystem type on dumpdir is '$info->{fstype}' -" .
"using $task->{tmpdir} for temporary files", $logfd);
}
$task->{dumpdir} = $opts->{dumpdir};
$task->{storeid} = $opts->{storage};
+ $task->{scfg} = $opts->{scfg};
$task->{tmplog} = $tmplog;
- unlink $logfile;
+ unlink $task->{logfile} if defined($task->{logfile});
- debugmsg ('info', "Starting Backup of VM $vmid ($vmtype)", $logfd, 1);
+ debugmsg ('info', "Starting Backup of VM $vmid ($vmtype)", $logfd, 1);
+ debugmsg ('info', "Backup started at " . strftime("%F %H:%M:%S", localtime()));
$plugin->set_logfd ($logfd);
# prepare
- my $mode = $running ? $opts->{mode} : 'stop';
+ my $mode = $running ? $task->{mode} : 'stop';
if ($mode eq 'snapshot') {
my %saved_task = %$task;
debugmsg ('info', $err, $logfd);
debugmsg ('info', "trying 'suspend' mode instead", $logfd);
$mode = 'suspend'; # so prepare is called again below
- %$task = %saved_task;
+ %$task = %saved_task;
}
}
+ $cleanup->{prepared} = 1;
+
$task->{mode} = $mode;
debugmsg ('info', "backup mode: $mode", $logfd);
if ($running) {
debugmsg ('info', "stopping vm", $logfd);
- $vmstoptime = time ();
+ $task->{vmstoptime} = time();
$self->run_hook_script ('pre-stop', $task, $logfd);
$plugin->stop_vm ($task, $vmid);
$cleanup->{restart} = 1;
}
-
+
} elsif ($mode eq 'suspend') {
$plugin->copy_data_phase1($task, $vmid);
}
- debugmsg ('info', "suspend vm", $logfd);
- $vmstoptime = time ();
+ debugmsg ('info', "suspending guest", $logfd);
+ $task->{vmstoptime} = time ();
$self->run_hook_script ('pre-stop', $task, $logfd);
$plugin->suspend_vm ($task, $vmid);
$cleanup->{resume} = 1;
# post-suspend rsync
$plugin->copy_data_phase2($task, $vmid);
- debugmsg ('info', "resume vm", $logfd);
+ debugmsg ('info', "resuming guest", $logfd);
$cleanup->{resume} = 0;
$self->run_hook_script('pre-restart', $task, $logfd);
$plugin->resume_vm($task, $vmid);
$self->run_hook_script('post-restart', $task, $logfd);
- my $delay = time () - $vmstoptime;
- debugmsg('info', "vm is online again after $delay seconds", $logfd);
+ $log_vm_online_again->();
}
-
+
} elsif ($mode eq 'snapshot') {
$self->run_hook_script ('backup-start', $task, $logfd);
if ($snapshot_count > 1) {
debugmsg ('info', "suspend vm to make snapshot", $logfd);
- $vmstoptime = time ();
+ $task->{vmstoptime} = time ();
$plugin->suspend_vm ($task, $vmid);
$cleanup->{resume} = 1;
}
debugmsg ('info', "resume vm", $logfd);
$cleanup->{resume} = 0;
$plugin->resume_vm ($task, $vmid);
- my $delay = time () - $vmstoptime;
- debugmsg ('info', "vm is online again after $delay seconds", $logfd);
+ $log_vm_online_again->();
}
$self->run_hook_script ('post-restart', $task, $logfd);
# assemble archive image
$plugin->assemble ($task, $vmid);
-
- # produce archive
+
+ # produce archive
if ($opts->{stdout}) {
debugmsg ('info', "sending archive to stdout", $logfd);
return;
}
- debugmsg ('info', "creating archive '$task->{tarfile}'", $logfd);
+ my $archive_txt = $self->{opts}->{pbs} ? 'Proxmox Backup Server' : 'vzdump';
+ debugmsg('info', "creating $archive_txt archive '$task->{target}'", $logfd);
$plugin->archive($task, $vmid, $task->{tmptar}, $comp);
- rename ($task->{tmptar}, $task->{tarfile}) ||
- die "unable to rename '$task->{tmptar}' to '$task->{tarfile}'\n";
+ if ($self->{opts}->{pbs}) {
+ # size is added to task struct in guest vzdump plugins
+ } else {
+ rename ($task->{tmptar}, $task->{target}) ||
+ die "unable to rename '$task->{tmptar}' to '$task->{target}'\n";
- # determine size
- $task->{size} = (-s $task->{tarfile}) || 0;
- my $cs = format_size ($task->{size});
- debugmsg ('info', "archive file size: $cs", $logfd);
+ # determine size
+ $task->{size} = (-s $task->{target}) || 0;
+ my $cs = format_size ($task->{size});
+ debugmsg ('info', "archive file size: $cs", $logfd);
+ }
# purge older backup
+ if ($opts->{remove}) {
+ if (!defined($opts->{storage})) {
+ my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname, $task->{target});
+ PVE::Storage::prune_mark_backup_group($bklist, $prune_options);
- if ($maxfiles && $opts->{remove}) {
- my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname, $task->{tarfile});
- $bklist = [ sort { $b->[1] <=> $a->[1] } @$bklist ];
-
- while (scalar (@$bklist) >= $maxfiles) {
- my $d = pop @$bklist;
- debugmsg ('info', "delete old backup '$d->[0]'", $logfd);
- unlink $d->[0];
- my $logfn = $d->[0];
- $logfn =~ s/\.(tgz|((tar|vma)(\.(gz|lzo))?))$/\.log/;
- unlink $logfn;
+ foreach my $prune_entry (@{$bklist}) {
+ next if $prune_entry->{mark} ne 'remove';
+
+ my $archive_path = $prune_entry->{path};
+ debugmsg ('info', "delete old backup '$archive_path'", $logfd);
+ PVE::Storage::archive_remove($archive_path);
+ }
+ } else {
+ my $logfunc = sub { debugmsg($_[0], $_[1], $logfd) };
+ PVE::Storage::prune_backups($cfg, $opts->{storage}, $prune_options, $vmid, $vmtype, 0, $logfunc);
}
}
warn $@ if $@;
}
- if (defined($task->{mode})) {
+ if ($cleanup->{prepared}) {
# only call cleanup when necessary (when prepare was executed)
eval { $plugin->cleanup ($task, $vmid) };
warn $@ if $@;
eval { $plugin->set_logfd (undef); };
warn $@ if $@;
- if ($cleanup->{resume} || $cleanup->{restart}) {
- eval {
+ if ($cleanup->{resume} || $cleanup->{restart}) {
+ eval {
$self->run_hook_script ('pre-restart', $task, $logfd);
if ($cleanup->{resume}) {
debugmsg ('info', "resume vm", $logfd);
if ($err) {
warn $err;
} else {
- my $delay = time () - $vmstoptime;
- debugmsg ('info', "vm is online again after $delay seconds", $logfd);
+ $log_vm_online_again->();
}
}
}
$task->{state} = 'err';
$task->{msg} = $err;
debugmsg ('err', "Backup of VM $vmid failed - $err", $logfd, 1);
+ debugmsg ('info', "Failed at " . strftime("%F %H:%M:%S", localtime()));
eval { $self->run_hook_script ('backup-abort', $task, $logfd); };
$task->{state} = 'ok';
my $tstr = format_time ($delay);
debugmsg ('info', "Finished Backup of VM $vmid ($tstr)", $logfd, 1);
+ debugmsg ('info', "Backup finished at " . strftime("%F %H:%M:%S", localtime()));
}
close ($logfd) if $logfd;
-
- if ($task->{tmplog} && $task->{logfile}) {
- system ("cp '$task->{tmplog}' '$task->{logfile}'");
+
+ if ($task->{tmplog}) {
+ if ($self->{opts}->{pbs}) {
+ if ($task->{state} eq 'ok') {
+ eval {
+ PVE::Storage::PBSPlugin::run_raw_client_cmd(
+ $opts->{scfg},
+ $opts->{storage},
+ 'upload-log',
+ [ $pbs_snapshot_name, $task->{tmplog} ],
+ errmsg => "uploading backup task log failed",
+ );
+ };
+ debugmsg('warn', "$@") if $@; # $@ contains already error prefix
+ }
+ } elsif ($task->{logfile}) {
+ system {'cp'} 'cp', $task->{tmplog}, $task->{logfile};
+ }
}
eval { $self->run_hook_script ('log-end', $task); };
my $opts = $self->{opts};
debugmsg ('info', "starting new backup job: $self->{cmdline}", undef, 1);
- debugmsg ('info', "skip external VMs: " . join(', ', @{$self->{skiplist}}))
- if scalar(@{$self->{skiplist}});
-
+
+ if (scalar(@{$self->{skiplist}})) {
+ my $skip_string = join(', ', sort { $a <=> $b } @{$self->{skiplist}});
+ debugmsg ('info', "skip external VMs: $skip_string");
+ }
+
my $tasklist = [];
+ my $vzdump_plugins = {};
+ foreach my $plugin (@{$self->{plugins}}) {
+ my $type = $plugin->type();
+ next if exists $vzdump_plugins->{$type};
+ $vzdump_plugins->{$type} = $plugin;
+ }
- if ($opts->{all}) {
- foreach my $plugin (@{$self->{plugins}}) {
- my $vmlist = $plugin->vmlist();
- foreach my $vmid (sort @$vmlist) {
- next if grep { $_ eq $vmid } @{$opts->{exclude}};
- next if !$rpcenv->check($authuser, "/vms/$vmid", [ 'VM.Backup' ], 1);
- push @$tasklist, { vmid => $vmid, state => 'todo', plugin => $plugin };
- }
- }
- } else {
- foreach my $vmid (sort @{$opts->{vmids}}) {
- my $plugin;
- foreach my $pg (@{$self->{plugins}}) {
- my $vmlist = $pg->vmlist();
- if (grep { $_ eq $vmid } @$vmlist) {
- $plugin = $pg;
- last;
- }
- }
- $rpcenv->check($authuser, "/vms/$vmid", [ 'VM.Backup' ]);
- push @$tasklist, { vmid => $vmid, state => 'todo', plugin => $plugin };
+ my $vmlist = PVE::Cluster::get_vmlist();
+ my $vmids = [ sort { $a <=> $b } @{$opts->{vmids}} ];
+ foreach my $vmid (@{$vmids}) {
+ my $plugin;
+ if (defined($vmlist->{ids}->{$vmid})) {
+ my $guest_type = $vmlist->{ids}->{$vmid}->{type};
+ $plugin = $vzdump_plugins->{$guest_type};
+ next if !$rpcenv->check($authuser, "/vms/$vmid", [ 'VM.Backup' ], $opts->{all});
}
+ push @$tasklist, {
+ mode => $opts->{mode},
+ plugin => $plugin,
+ state => 'todo',
+ vmid => $vmid,
+ };
}
+ # Use in-memory files for the outer hook logs to pass them to sendmail.
+ my $job_start_log = '';
+ my $job_end_log = '';
+ open my $job_start_fd, '>', \$job_start_log;
+ open my $job_end_fd, '>', \$job_end_log;
+
my $starttime = time();
my $errcount = 0;
eval {
- $self->run_hook_script ('job-start');
+ $self->run_hook_script ('job-start', undef, $job_start_fd);
foreach my $task (@$tasklist) {
$self->exec_backup_task ($task);
$errcount += 1 if $task->{state} ne 'ok';
}
- $self->run_hook_script ('job-end');
+ $self->run_hook_script ('job-end', undef, $job_end_fd);
};
my $err = $@;
- $self->run_hook_script ('job-abort') if $err;
+ $self->run_hook_script ('job-abort', undef, $job_end_fd) if $err;
if ($err) {
debugmsg ('err', "Backup job failed - $err", undef, 1);
}
}
+ close $job_start_fd;
+ close $job_end_fd;
+
my $totaltime = time() - $starttime;
- eval { $self->sendmail ($tasklist, $totaltime); };
+ eval { $self->sendmail ($tasklist, $totaltime, undef, $job_start_log, $job_end_log); };
debugmsg ('err', $@) if $@;
die $err if $err;
- die "job errors\n" if $errcount;
+ die "job errors\n" if $errcount;
unlink $pidfile;
}
return defined($confdesc->{$key});
}
-# add JSON properties for create and set function
-sub json_config_properties {
- my $prop = shift;
+# NOTE it might make sense to merge this and verify_vzdump_parameters(), but one
+# needs to adapt command_line() in guest-common's PVE/VZDump/Common.pm and detect
+# a second parsing attempt, because verify_vzdump_parameters() is called twice
+# during the update_job API call.
+sub parse_mailto_exclude_path {
+ my ($param) = @_;
+
+ # exclude-path list need to be 0 separated
+ if (defined($param->{'exclude-path'})) {
+ my @expaths = split(/\0/, $param->{'exclude-path'} || '');
+ $param->{'exclude-path'} = [ @expaths ];
+ }
- foreach my $opt (keys %$confdesc) {
- $prop->{$opt} = $confdesc->{$opt};
+ if (defined($param->{mailto})) {
+ my @mailto = PVE::Tools::split_list(extract_param($param, 'mailto'));
+ $param->{mailto} = [ @mailto ];
}
- return $prop;
+ return;
}
sub verify_vzdump_parameters {
raise_param_exc({ exclude => "option conflicts with option 'vmid'"})
if $param->{exclude} && $param->{vmid};
- $param->{all} = 1 if defined($param->{exclude});
+ raise_param_exc({ pool => "option conflicts with option 'vmid'"})
+ if $param->{pool} && $param->{vmid};
+
+ raise_param_exc({ 'prune-backups' => "option conflicts with option 'maxfiles'"})
+ if defined($param->{'prune-backups'}) && defined($param->{maxfiles});
+
+ $parse_prune_backups_maxfiles->($param, 'CLI parameters');
- warn "option 'size' is deprecated and will be removed in a future " .
- "release, please update your script/configuration!\n"
- if defined($param->{size});
+ $param->{all} = 1 if (defined($param->{exclude}) && !$param->{pool});
return if !$check_missing;
raise_param_exc({ vmid => "property is missing"})
- if !($param->{all} || $param->{stop}) && !$param->{vmid};
+ if !($param->{all} || $param->{stop} || $param->{pool}) && !$param->{vmid};
}
my $task = PVE::Tools::upid_decode($upid);
- if (PVE::ProcFSTools::check_process_running($task->{pid}, $task->{pstart}) &&
+ if (PVE::ProcFSTools::check_process_running($task->{pid}, $task->{pstart}) &&
PVE::ProcFSTools::read_proc_starttime($task->{pid}) == $task->{pstart}) {
kill(15, $task->{pid});
# wait max 15 seconds to shut down (else, do nothing for now)
last if !PVE::ProcFSTools::check_process_running(($task->{pid}, $task->{pstart}));
sleep (1);
}
- die "stoping backup process $task->{pid} failed\n" if $i == 0;
+ die "stopping backup process $task->{pid} failed\n" if $i == 0;
}
}
-sub command_line {
- my ($param) = @_;
+sub get_included_guests {
+ my ($job) = @_;
- my $cmd = "vzdump";
+ my $vmids = [];
+ my $vmids_per_node = {};
- if ($param->{vmid}) {
- $cmd .= " " . join(' ', PVE::Tools::split_list($param->{vmid}));
- }
+ my $vmlist = PVE::Cluster::get_vmlist();
- foreach my $p (keys %$param) {
- next if $p eq 'id' || $p eq 'vmid' || $p eq 'starttime' ||
- $p eq 'dow' || $p eq 'stdout' || $p eq 'enabled';
- my $v = $param->{$p};
- my $pd = $confdesc->{$p} || die "no such vzdump option '$p'\n";
- if ($p eq 'exclude-path') {
- foreach my $path (split(/\0/, $v || '')) {
- $cmd .= " --$p " . PVE::Tools::shellquote($path);
- }
- } else {
- $cmd .= " --$p " . PVE::Tools::shellquote($v) if defined($v) && $v ne '';
+ if ($job->{pool}) {
+ $vmids = PVE::API2Tools::get_resource_pool_guest_members($job->{pool});
+ } elsif ($job->{vmid}) {
+ $vmids = [ split_list($job->{vmid}) ];
+ } elsif ($job->{all}) {
+ # all or exclude
+ my $exclude = check_vmids(split_list($job->{exclude}));
+ my $excludehash = { map { $_ => 1 } @$exclude };
+
+ for my $id (keys %{$vmlist->{ids}}) {
+ next if $excludehash->{$id};
+ push @$vmids, $id;
}
+ } else {
+ return $vmids_per_node;
}
+ $vmids = check_vmids(@$vmids);
- return $cmd;
-}
-
-# bash completion helpers
-sub complete_backup_storage {
-
- my $cfg = PVE::Storage::config();
- my $ids = $cfg->{ids};
-
- my $nodename = PVE::INotify::nodename();
+ for my $vmid (@$vmids) {
+ if (defined($vmlist->{ids}->{$vmid})) {
+ my $node = $vmlist->{ids}->{$vmid}->{node};
+ next if (defined $job->{node} && $job->{node} ne $node);
- my $res = [];
- foreach my $sid (keys %$ids) {
- my $scfg = $ids->{$sid};
- next if !PVE::Storage::storage_check_enabled($cfg, $sid, $nodename, 1);
- next if !$scfg->{content}->{backup};
- push @$res, $sid;
+ push @{$vmids_per_node->{$node}}, $vmid;
+ } else {
+ push @{$vmids_per_node->{''}}, $vmid;
+ }
}
- return $res;
+ return $vmids_per_node;
}
1;