]> git.proxmox.com Git - mirror_zfs.git/blobdiff - module/zfs/vdev_label.c
Correct snprintf() size argument
[mirror_zfs.git] / module / zfs / vdev_label.c
index 7ea8da1e6ed3a4fd3d8a3d8cf7b0c73814332e4a..a0e373b3dfc51850cb2ddd9f5f1cc79abbdf1636 100644 (file)
@@ -21,7 +21,9 @@
 
 /*
  * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2018 by Delphix. All rights reserved.
  * Copyright (c) 2012, 2016 by Delphix. All rights reserved.
+ * Copyright (c) 2017, Intel Corporation.
  */
 
 /*
@@ -226,8 +228,6 @@ vdev_config_generate_stats(vdev_t *vd, nvlist_t *nv)
        fnvlist_add_uint64_array(nv, ZPOOL_CONFIG_VDEV_STATS,
            (uint64_t *)vs, sizeof (*vs) / sizeof (uint64_t));
 
-       kmem_free(vs, sizeof (*vs));
-
        /*
         * Add extended stats into a special extended stats nvlist.  This keeps
         * all the extended stats nicely grouped together.  The extended stats
@@ -251,6 +251,9 @@ vdev_config_generate_stats(vdev_t *vd, nvlist_t *nv)
        fnvlist_add_uint64(nvx, ZPOOL_CONFIG_VDEV_SCRUB_ACTIVE_QUEUE,
            vsx->vsx_active_queue[ZIO_PRIORITY_SCRUB]);
 
+       fnvlist_add_uint64(nvx, ZPOOL_CONFIG_VDEV_TRIM_ACTIVE_QUEUE,
+           vsx->vsx_active_queue[ZIO_PRIORITY_TRIM]);
+
        /* ZIOs pending */
        fnvlist_add_uint64(nvx, ZPOOL_CONFIG_VDEV_SYNC_R_PEND_QUEUE,
            vsx->vsx_pend_queue[ZIO_PRIORITY_SYNC_READ]);
@@ -267,6 +270,9 @@ vdev_config_generate_stats(vdev_t *vd, nvlist_t *nv)
        fnvlist_add_uint64(nvx, ZPOOL_CONFIG_VDEV_SCRUB_PEND_QUEUE,
            vsx->vsx_pend_queue[ZIO_PRIORITY_SCRUB]);
 
+       fnvlist_add_uint64(nvx, ZPOOL_CONFIG_VDEV_TRIM_PEND_QUEUE,
+           vsx->vsx_pend_queue[ZIO_PRIORITY_TRIM]);
+
        /* Histograms */
        fnvlist_add_uint64_array(nvx, ZPOOL_CONFIG_VDEV_TOT_R_LAT_HISTO,
            vsx->vsx_total_histo[ZIO_TYPE_READ],
@@ -304,6 +310,10 @@ vdev_config_generate_stats(vdev_t *vd, nvlist_t *nv)
            vsx->vsx_queue_histo[ZIO_PRIORITY_SCRUB],
            ARRAY_SIZE(vsx->vsx_queue_histo[ZIO_PRIORITY_SCRUB]));
 
+       fnvlist_add_uint64_array(nvx, ZPOOL_CONFIG_VDEV_TRIM_LAT_HISTO,
+           vsx->vsx_queue_histo[ZIO_PRIORITY_TRIM],
+           ARRAY_SIZE(vsx->vsx_queue_histo[ZIO_PRIORITY_TRIM]));
+
        /* Request sizes */
        fnvlist_add_uint64_array(nvx, ZPOOL_CONFIG_VDEV_SYNC_IND_R_HISTO,
            vsx->vsx_ind_histo[ZIO_PRIORITY_SYNC_READ],
@@ -325,6 +335,10 @@ vdev_config_generate_stats(vdev_t *vd, nvlist_t *nv)
            vsx->vsx_ind_histo[ZIO_PRIORITY_SCRUB],
            ARRAY_SIZE(vsx->vsx_ind_histo[ZIO_PRIORITY_SCRUB]));
 
+       fnvlist_add_uint64_array(nvx, ZPOOL_CONFIG_VDEV_IND_TRIM_HISTO,
+           vsx->vsx_ind_histo[ZIO_PRIORITY_TRIM],
+           ARRAY_SIZE(vsx->vsx_ind_histo[ZIO_PRIORITY_TRIM]));
+
        fnvlist_add_uint64_array(nvx, ZPOOL_CONFIG_VDEV_SYNC_AGG_R_HISTO,
            vsx->vsx_agg_histo[ZIO_PRIORITY_SYNC_READ],
            ARRAY_SIZE(vsx->vsx_agg_histo[ZIO_PRIORITY_SYNC_READ]));
@@ -345,13 +359,52 @@ vdev_config_generate_stats(vdev_t *vd, nvlist_t *nv)
            vsx->vsx_agg_histo[ZIO_PRIORITY_SCRUB],
            ARRAY_SIZE(vsx->vsx_agg_histo[ZIO_PRIORITY_SCRUB]));
 
+       fnvlist_add_uint64_array(nvx, ZPOOL_CONFIG_VDEV_AGG_TRIM_HISTO,
+           vsx->vsx_agg_histo[ZIO_PRIORITY_TRIM],
+           ARRAY_SIZE(vsx->vsx_agg_histo[ZIO_PRIORITY_TRIM]));
+
+       /* IO delays */
+       fnvlist_add_uint64(nvx, ZPOOL_CONFIG_VDEV_SLOW_IOS, vs->vs_slow_ios);
+
        /* Add extended stats nvlist to main nvlist */
        fnvlist_add_nvlist(nv, ZPOOL_CONFIG_VDEV_STATS_EX, nvx);
 
        fnvlist_free(nvx);
+       kmem_free(vs, sizeof (*vs));
        kmem_free(vsx, sizeof (*vsx));
 }
 
+static void
+root_vdev_actions_getprogress(vdev_t *vd, nvlist_t *nvl)
+{
+       spa_t *spa = vd->vdev_spa;
+
+       if (vd != spa->spa_root_vdev)
+               return;
+
+       /* provide either current or previous scan information */
+       pool_scan_stat_t ps;
+       if (spa_scan_get_stats(spa, &ps) == 0) {
+               fnvlist_add_uint64_array(nvl,
+                   ZPOOL_CONFIG_SCAN_STATS, (uint64_t *)&ps,
+                   sizeof (pool_scan_stat_t) / sizeof (uint64_t));
+       }
+
+       pool_removal_stat_t prs;
+       if (spa_removal_get_stats(spa, &prs) == 0) {
+               fnvlist_add_uint64_array(nvl,
+                   ZPOOL_CONFIG_REMOVAL_STATS, (uint64_t *)&prs,
+                   sizeof (prs) / sizeof (uint64_t));
+       }
+
+       pool_checkpoint_stat_t pcs;
+       if (spa_checkpoint_get_stats(spa, &pcs) == 0) {
+               fnvlist_add_uint64_array(nvl,
+                   ZPOOL_CONFIG_CHECKPOINT_STATS, (uint64_t *)&pcs,
+                   sizeof (pcs) / sizeof (uint64_t));
+       }
+}
+
 /*
  * Generate the nvlist representing this vdev's config.
  */
@@ -432,6 +485,28 @@ vdev_config_generate(spa_t *spa, vdev_t *vd, boolean_t getstats,
                        fnvlist_add_uint64(nv, ZPOOL_CONFIG_REMOVING,
                            vd->vdev_removing);
                }
+
+               /* zpool command expects alloc class data */
+               if (getstats && vd->vdev_alloc_bias != VDEV_BIAS_NONE) {
+                       const char *bias = NULL;
+
+                       switch (vd->vdev_alloc_bias) {
+                       case VDEV_BIAS_LOG:
+                               bias = VDEV_ALLOC_BIAS_LOG;
+                               break;
+                       case VDEV_BIAS_SPECIAL:
+                               bias = VDEV_ALLOC_BIAS_SPECIAL;
+                               break;
+                       case VDEV_BIAS_DEDUP:
+                               bias = VDEV_ALLOC_BIAS_DEDUP;
+                               break;
+                       default:
+                               ASSERT3U(vd->vdev_alloc_bias, ==,
+                                   VDEV_BIAS_NONE);
+                       }
+                       fnvlist_add_string(nv, ZPOOL_CONFIG_ALLOCATION_BIAS,
+                           bias);
+               }
        }
 
        if (vd->vdev_dtl_sm != NULL) {
@@ -457,6 +532,10 @@ vdev_config_generate(spa_t *spa, vdev_t *vd, boolean_t getstats,
        if (vd->vdev_crtxg)
                fnvlist_add_uint64(nv, ZPOOL_CONFIG_CREATE_TXG, vd->vdev_crtxg);
 
+       if (vd->vdev_expansion_time)
+               fnvlist_add_uint64(nv, ZPOOL_CONFIG_EXPANSION_TIME,
+                   vd->vdev_expansion_time);
+
        if (flags & VDEV_CONFIG_MOS) {
                if (vd->vdev_leaf_zap != 0) {
                        ASSERT(vd->vdev_ops->vdev_op_leaf);
@@ -469,25 +548,18 @@ vdev_config_generate(spa_t *spa, vdev_t *vd, boolean_t getstats,
                        fnvlist_add_uint64(nv, ZPOOL_CONFIG_VDEV_TOP_ZAP,
                            vd->vdev_top_zap);
                }
+
+               if (vd->vdev_resilver_deferred) {
+                       ASSERT(vd->vdev_ops->vdev_op_leaf);
+                       ASSERT(spa->spa_resilver_deferred);
+                       fnvlist_add_boolean(nv, ZPOOL_CONFIG_RESILVER_DEFER);
+               }
        }
 
        if (getstats) {
                vdev_config_generate_stats(vd, nv);
 
-               /* provide either current or previous scan information */
-               pool_scan_stat_t ps;
-               if (spa_scan_get_stats(spa, &ps) == 0) {
-                       fnvlist_add_uint64_array(nv,
-                           ZPOOL_CONFIG_SCAN_STATS, (uint64_t *)&ps,
-                           sizeof (pool_scan_stat_t) / sizeof (uint64_t));
-               }
-
-               pool_removal_stat_t prs;
-               if (spa_removal_get_stats(spa, &prs) == 0) {
-                       fnvlist_add_uint64_array(nv,
-                           ZPOOL_CONFIG_REMOVAL_STATS, (uint64_t *)&prs,
-                           sizeof (prs) / sizeof (uint64_t));
-               }
+               root_vdev_actions_getprogress(vd, nv);
 
                /*
                 * Note: this can be called from open context
@@ -1127,10 +1199,35 @@ static int
 vdev_uberblock_compare(const uberblock_t *ub1, const uberblock_t *ub2)
 {
        int cmp = AVL_CMP(ub1->ub_txg, ub2->ub_txg);
+
        if (likely(cmp))
                return (cmp);
 
-       return (AVL_CMP(ub1->ub_timestamp, ub2->ub_timestamp));
+       cmp = AVL_CMP(ub1->ub_timestamp, ub2->ub_timestamp);
+       if (likely(cmp))
+               return (cmp);
+
+       /*
+        * If MMP_VALID(ub) && MMP_SEQ_VALID(ub) then the host has an MMP-aware
+        * ZFS, e.g. zfsonlinux >= 0.7.
+        *
+        * If one ub has MMP and the other does not, they were written by
+        * different hosts, which matters for MMP.  So we treat no MMP/no SEQ as
+        * a 0 value.
+        *
+        * Since timestamp and txg are the same if we get this far, either is
+        * acceptable for importing the pool.
+        */
+       unsigned int seq1 = 0;
+       unsigned int seq2 = 0;
+
+       if (MMP_VALID(ub1) && MMP_SEQ_VALID(ub1))
+               seq1 = MMP_SEQ(ub1);
+
+       if (MMP_VALID(ub2) && MMP_SEQ_VALID(ub2))
+               seq2 = MMP_SEQ(ub2);
+
+       return (AVL_CMP(seq1, seq2));
 }
 
 struct ubl_cbdata {
@@ -1525,11 +1622,10 @@ vdev_config_sync(vdev_t **svd, int svdcount, uint64_t txg)
 {
        spa_t *spa = svd[0]->vdev_spa;
        uberblock_t *ub = &spa->spa_uberblock;
-       vdev_t *vd;
-       zio_t *zio;
        int error = 0;
        int flags = ZIO_FLAG_CONFIG_WRITER | ZIO_FLAG_CANFAIL;
 
+       ASSERT(svdcount != 0);
 retry:
        /*
         * Normally, we don't want to try too hard to write every label and
@@ -1571,9 +1667,10 @@ retry:
         * written in this txg will be committed to stable storage
         * before any uberblock that references them.
         */
-       zio = zio_root(spa, NULL, NULL, flags);
+       zio_t *zio = zio_root(spa, NULL, NULL, flags);
 
-       for (vd = txg_list_head(&spa->spa_vdev_txg_list, TXG_CLEAN(txg)); vd;
+       for (vdev_t *vd =
+           txg_list_head(&spa->spa_vdev_txg_list, TXG_CLEAN(txg)); vd != NULL;
            vd = txg_list_next(&spa->spa_vdev_txg_list, vd, TXG_CLEAN(txg)))
                zio_flush(zio, vd);
 
@@ -1588,8 +1685,14 @@ retry:
         * the new labels to disk to ensure that all even-label updates
         * are committed to stable storage before the uberblock update.
         */
-       if ((error = vdev_label_sync_list(spa, 0, txg, flags)) != 0)
+       if ((error = vdev_label_sync_list(spa, 0, txg, flags)) != 0) {
+               if ((flags & ZIO_FLAG_TRYHARD) != 0) {
+                       zfs_dbgmsg("vdev_label_sync_list() returned error %d "
+                           "for pool '%s' when syncing out the even labels "
+                           "of dirty vdevs", error, spa_name(spa));
+               }
                goto retry;
+       }
 
        /*
         * Sync the uberblocks to all vdevs in svd[].
@@ -1606,8 +1709,13 @@ retry:
         *      been successfully committed) will be valid with respect
         *      to the new uberblocks.
         */
-       if ((error = vdev_uberblock_sync_list(svd, svdcount, ub, flags)) != 0)
+       if ((error = vdev_uberblock_sync_list(svd, svdcount, ub, flags)) != 0) {
+               if ((flags & ZIO_FLAG_TRYHARD) != 0) {
+                       zfs_dbgmsg("vdev_uberblock_sync_list() returned error "
+                           "%d for pool '%s'", error, spa_name(spa));
+               }
                goto retry;
+       }
 
        if (spa_multihost(spa))
                mmp_update_uberblock(spa, ub);
@@ -1622,8 +1730,14 @@ retry:
         * to disk to ensure that all odd-label updates are committed to
         * stable storage before the next transaction group begins.
         */
-       if ((error = vdev_label_sync_list(spa, 1, txg, flags)) != 0)
+       if ((error = vdev_label_sync_list(spa, 1, txg, flags)) != 0) {
+               if ((flags & ZIO_FLAG_TRYHARD) != 0) {
+                       zfs_dbgmsg("vdev_label_sync_list() returned error %d "
+                           "for pool '%s' when syncing out the odd labels of "
+                           "dirty vdevs", error, spa_name(spa));
+               }
                goto retry;
+       }
 
        return (0);
 }