]> git.proxmox.com Git - mirror_zfs.git/blobdiff - scripts/kmodtool
Remove compat spl-x.y.z from the distribution
[mirror_zfs.git] / scripts / kmodtool
index 2170c4a908ae2b4b9d53a53cd07911c0371749b0..f66341196acb22fbbff45ad7ce2dc9951aa36521 100755 (executable)
@@ -1,4 +1,5 @@
-#!/bin/bash
+#!/usr/bin/env bash
+# shellcheck disable=SC2086
 
 # kmodtool - Helper script for building kernel module RPMs
 # Copyright (c) 2003-2012 Ville Skyttä <ville.skytta@iki.fi>,
@@ -37,23 +38,25 @@ kernel_versions_to_build_for=
 prefix=
 filterfile=
 target=
+buildroot=
+dashvariant=
 
 error_out()
 {
        local errorlevel=${1}
        shift
-       echo "Error: $@" >&2
+       echo "Error: $*" >&2
        # the next line is not multi-line safe -- not needed *yet*
-       echo "%global kmodtool_check echo \"kmodtool error: $@\"; exit ${errorlevel};"
-       exit ${errorlevel}
+       echo "%global kmodtool_check echo \"kmodtool error: $*\"; exit ${errorlevel};"
+       exit "${errorlevel}"
 }
 
 print_rpmtemplate_header()
 {
        echo
-       echo '%global kmodinstdir_prefix  '${prefix}/lib/modules/
-       echo '%global kmodinstdir_postfix '/extra/${kmodname}/
-       echo '%global kernel_versions     '${kernel_versions}
+       echo "%global kmodinstdir_prefix  ${prefix}/lib/modules/"
+       echo "%global kmodinstdir_postfix /extra/${kmodname}/"
+       echo "%global kernel_versions     ${kernel_versions}"
        echo
 }
 
@@ -63,7 +66,7 @@ print_akmodtemplate ()
        cat <<EOF
 
 %global akmod_install mkdir -p \$RPM_BUILD_ROOT/%{_usrsrc}/akmods/; \\\
-rpmbuild --define "_sourcedir %{_sourcedir}" \\\
+LANG=C rpmbuild --define "_sourcedir %{_sourcedir}" \\\
 --define "_srcrpmdir \$RPM_BUILD_ROOT/%{_usrsrc}/akmods/" \\\
 -bs --nodeps %{_specdir}/%{name}.spec ; \\\
 ln -s \$(ls \$RPM_BUILD_ROOT/%{_usrsrc}/akmods/) \$RPM_BUILD_ROOT/%{_usrsrc}/akmods/${kmodname}-kmod.latest
@@ -79,7 +82,7 @@ Requires:     ${kmodname}-kmod-common >= %{?epoch:%{epoch}:}%{version}
 Provides:      ${kmodname}-kmod = %{?epoch:%{epoch}:}%{version}-%{release}
 EOF
 
-       if [[ ${obsolete_name} ]]; then
+       if [ -n "${obsolete_name}" ]; then
                echo "Provides:   akmod-${obsolete_name} = ${obsolete_version}"
                echo "Obsoletes:  akmod-${obsolete_name} < ${obsolete_version}"
        fi
@@ -113,7 +116,7 @@ Provides:        kmod-${kmodname}-PAE = %{?epoch:%{epoch}:}%{version}-%{release}
 Requires:        akmod-${kmodname} = %{?epoch:%{epoch}:}%{version}-%{release}
 EOF
 
-       if [[ ${obsolete_name} ]]; then
+       if [ -n "${obsolete_name}" ]; then
                echo "Provides:        kmod-${obsolete_name} = ${obsolete_version}"
                echo "Obsoletes:       kmod-${obsolete_name} < ${obsolete_version}"
        fi
@@ -131,10 +134,10 @@ EOF
 
 print_rpmtemplate_per_kmodpkg ()
 {
-       if [[ "${1}" == "--custom" ]]; then
+       if [ "${1}" = "--custom" ]; then
                shift
                local customkernel=true
-       elif [[ "${1}" == "--redhat" ]]; then
+       elif [ "${1}" = "--redhat" ]; then
                # this is needed for akmods
                shift
                local redhatkernel=true
@@ -143,7 +146,13 @@ print_rpmtemplate_per_kmodpkg ()
        local kernel_uname_r=${1}
        local kernel_variant="${2:+-${2}}"
 
-    # first part
+       # Detect depmod install location
+       local depmod_path=/sbin/depmod
+       if [ ! -f "${depmod_path}" ]; then
+               depmod_path=/usr/sbin/depmod
+       fi
+
+       # first part
        cat <<EOF
 %package       -n kmod-${kmodname}-${kernel_uname_r}
 Summary:          ${kmodname} kernel module(s) for ${kernel_uname_r}
@@ -152,35 +161,52 @@ Provides:         kernel-modules-for-kernel = ${kernel_uname_r}
 Provides:         kmod-${kmodname}-uname-r = ${kernel_uname_r}
 Provides:         ${kmodname}-kmod = %{?epoch:%{epoch}:}%{version}-%{release}
 Requires:         ${kmodname}-kmod-common >= %{?epoch:%{epoch}:}%{version}
-Requires(post):   ${prefix}/sbin/depmod
-Requires(postun): ${prefix}/sbin/depmod
-%{?KmodsRequires:Requires: %{KmodsRequires}-uname-r = ${kernel_uname_r}}
-%{?KmodsBuildRequires:BuildRequires: %{KmodsBuildRequires}-uname-r = ${kernel_uname_r}}
-%{?KmodsBuildRequires:BuildRequires: %{KmodsBuildRequires}}
+
+%if 0%{?rhel} == 6 || 0%{?centos} == 6
+Requires(post):   module-init-tools
+Requires(postun): module-init-tools
+%else
+Requires(post):   kmod
+Requires(postun): kmod
+%endif
 EOF
 
-       if [[ ${obsolete_name} ]]; then
+       if [ -n "${obsolete_name}" ]; then
                echo "Provides:        kmod-${obsolete_name}-${kernel_uname_r} = ${obsolete_version}"
                echo "Obsoletes:       kmod-${obsolete_name}-${kernel_uname_r} < ${obsolete_version}"
        fi
 
        # second part
-       if [[ ! "${customkernel}" ]]; then
+       if [ -z "${customkernel}" ]; then
             cat <<EOF
 Requires:         kernel-uname-r = ${kernel_uname_r}
 BuildRequires:   kernel-devel-uname-r = ${kernel_uname_r}
+%{?KmodsRequires:Requires: %{KmodsRequires}-uname-r = ${kernel_uname_r}}
+%{?KmodsRequires:BuildRequires: %{KmodsRequires}-uname-r = ${kernel_uname_r}}
 %post          -n kmod-${kmodname}-${kernel_uname_r}
-${prefix}/sbin/depmod -aeF /boot/System.map-${kernel_uname_r} ${kernel_uname_r} > /dev/null || :
+if [ -f "/boot/System.map-${kernel_uname_r}" ]; then
+       ${prefix}${depmod_path} -aeF /boot/System.map-${kernel_uname_r} ${kernel_uname_r} > /dev/null || :
+elif [ -f "/lib/modules/${kernel_uname_r}/System.map" ]; then
+       ${prefix}${depmod_path} -aeF /lib/modules/${kernel_uname_r}/System.map ${kernel_uname_r} > /dev/null || :
+else
+       ${prefix}${depmod_path} -ae ${kernel_uname_r} &> /dev/null || :
+fi
 %postun        -n kmod-${kmodname}-${kernel_uname_r}
-${prefix}/sbin/depmod  -aF /boot/System.map-${kernel_uname_r} ${kernel_uname_r} &> /dev/null || :
+if [ -f "/boot/System.map-${kernel_uname_r}" ]; then
+       ${prefix}${depmod_path} -aF /boot/System.map-${kernel_uname_r} ${kernel_uname_r} &> /dev/null || :
+elif [ -f "/lib/modules/${kernel_uname_r}/System.map" ]; then
+       ${prefix}${depmod_path} -aF /lib/modules/${kernel_uname_r}/System.map ${kernel_uname_r} &> /dev/null || :
+else
+       ${prefix}${depmod_path} -a ${kernel_uname_r} &> /dev/null || :
+fi
 
 EOF
        else
          cat <<EOF
 %post          -n kmod-${kmodname}-${kernel_uname_r}
-[[ "$(uname -r)" == "${kernel_uname_r}"  ]] && ${prefix}/sbin/depmod -a > /dev/null || :
+[ "\$(uname -r)" = "${kernel_uname_r}"  ] && ${prefix}${depmod_path} -a > /dev/null || :
 %postun        -n kmod-${kmodname}-${kernel_uname_r}
-[[ "$(uname -r)" == "${kernel_uname_r}"  ]] && ${prefix}/sbin/depmod -a > /dev/null || :
+[ "\$(uname -r)" = "${kernel_uname_r}"  ] && ${prefix}${depmod_path} -a > /dev/null || :
 
 EOF
        fi
@@ -201,15 +227,38 @@ EOF
 
 print_rpmtemplate_kmoddevelpkg ()
 {
+       if [ "${1}" = "--custom" ]; then
+               shift
+               local customkernel=true
+       elif [ "${1}" = "--redhat" ]; then
+               shift
+               local redhatkernel=true
+       fi
+
+       local kernel_uname_r=${1}
+
        cat <<EOF
 %package       -n kmod-${kmodname}-devel
 Summary:          ${kmodname} kernel module(s) devel common
 Group:            System Environment/Kernel
-Provides:         ${kmodname}-devel-kmod-common = %{?epoch:%{epoch}:}%{version}-%{release}
+Provides:         ${kmodname}-devel-kmod = %{?epoch:%{epoch}:}%{version}-%{release}
+EOF
+
+       if [ -z "${customkernel}" ] && [ -z "${redhatkernel}" ]; then
+               echo "Requires:        kmod-${kmodname}-devel-${kernel_uname_r} >= %{?epoch:%{epoch}:}%{version}-%{release}"
+       fi
+
+       if [ -n "${obsolete_name}" ]; then
+               echo "Provides:        kmod-${obsolete_name}-devel = ${obsolete_version}"
+               echo "Obsoletes:       kmod-${obsolete_name}-devel < ${obsolete_version}"
+       fi
 
+       cat <<EOF
 %description  -n kmod-${kmodname}-devel
 This package provides the common header files to build kernel modules
-which depend on the ${kmodname} kernel module.
+which depend on the ${kmodname} kernel module.  It may optionally require
+the ${kmodname}-devel-<kernel> objects for the newest kernel.
+
 %files        -n kmod-${kmodname}-devel
 %defattr(644,root,root,755)
 %{_usrsrc}/${kmodname}-%{version}
@@ -226,10 +275,10 @@ EOF
 
 print_rpmtemplate_per_kmoddevelpkg ()
 {
-       if [[ "${1}" == "--custom" ]]; then
+       if [ "${1}" = "--custom" ]; then
                shift
                local customkernel=true
-       elif [[ "${1}" == "--redhat" ]]; then
+       elif [ "${1}" = "--redhat" ]; then
                # this is needed for akmods
                shift
                local redhatkernel=true
@@ -238,22 +287,32 @@ print_rpmtemplate_per_kmoddevelpkg ()
        local kernel_uname_r=${1}
        local kernel_variant="${2:+-${2}}"
 
+       # first part
        cat <<EOF
 %package       -n kmod-${kmodname}-devel-${kernel_uname_r}
 Summary:          ${kmodname} kernel module(s) devel for ${kernel_uname_r}
 Group:            System Environment/Kernel
-Requires:         ${kmodname}-devel-kmod-common = %{?epoch:%{epoch}:}%{version}-%{release}
+Provides:         kernel-objects-for-kernel = ${kernel_uname_r}
+Provides:         ${kmodname}-devel-kmod = %{?epoch:%{epoch}:}%{version}-%{release}
 Provides:         kmod-${kmodname}-devel-uname-r = ${kernel_uname_r}
 EOF
 
+       if [ -n "${obsolete_name}" ]; then
+               echo "Provides:        kmod-${obsolete_name}-devel-${kernel_uname_r} = ${obsolete_version}"
+               echo "Obsoletes:       kmod-${obsolete_name}-devel-${kernel_uname_r} < ${obsolete_version}"
+       fi
+
        # second part
-       if [[ ! "${customkernel}" ]]; then
+       if [ -z "${customkernel}" ]; then
                cat <<EOF
-Requires:         kernel-uname-r = ${kernel_uname_r}
+Requires:         kernel-devel-uname-r = ${kernel_uname_r}
 BuildRequires:    kernel-devel-uname-r = ${kernel_uname_r}
+%{?KmodsDevelRequires:Requires: %{KmodsDevelRequires}-uname-r = ${kernel_uname_r}}
+%{?KmodsDevelRequires:BuildRequires: %{KmodsDevelRequires}-uname-r = ${kernel_uname_r}}
 EOF
        fi
 
+       # third part
        cat <<EOF
 %description  -n kmod-${kmodname}-devel-${kernel_uname_r}
 This package provides objects and symbols required to build kernel modules
@@ -262,8 +321,6 @@ kernel ${kernel_uname_r} for the %{_target_cpu} family of processors.
 %files        -n kmod-${kmodname}-devel-${kernel_uname_r}
 %defattr(644,root,root,755)
 %{_usrsrc}/${kmodname}-%{version}/${kernel_uname_r}
-
-
 EOF
 }
 
@@ -279,9 +336,10 @@ Group:           System Environment/Kernel
 
 Provides:        ${kmodname}-kmod = %{?epoch:%{epoch}:}%{version}-%{release}
 Requires:        kmod-${kmodname}-${kernel_uname_r} >= %{?epoch:%{epoch}:}%{version}-%{release}
+%{?KmodsMetaRequires:Requires: %{?KmodsMetaRequires}}
 EOF
-       
-               if [[ ${obsolete_name} ]]; then
+
+               if [ -n "${obsolete_name}" ]; then
                        echo "Provides:        kmod-${obsolete_name}${kernel_variant} = ${obsolete_version}"
                        echo "Obsoletes:       kmod-${obsolete_name}${kernel_variant} < ${obsolete_version}"
                fi
@@ -304,19 +362,23 @@ print_customrpmtemplate ()
 {
        for kernel in ${1}
        do
-               if      [[ -e "/usr/src/kernels/${kernel}" ]] ; then
+               if [ -e "${buildroot}/usr/src/kernels/${kernel}" ] ; then
                        # this looks like a Fedora/RH kernel -- print a normal template (which includes the proper BR) and be happy :)
-                       kernel_versions="${kernel_versions}${kernel}___%{_usrsrc}/kernels/${kernel} "
+                       kernel_versions="${kernel_versions}${kernel}___${buildroot}%{_usrsrc}/kernels/${kernel} "
 
                        # parse kernel versions string and print template
                        local kernel_verrelarch=${kernel%%${kernels_known_variants}}
                        print_rpmtemplate_per_kmodpkg --redhat ${kernel} ${kernel##${kernel_verrelarch}}
 
                        # create development package
-                       if [[ "${devel}" ]]; then
+                       if [ -n "${devel}" ]; then
+                               # create devel package including common headers
+                               print_rpmtemplate_kmoddevelpkg --redhat ${kernel} ${kernel##${kernel_verrelarch}}
+
+                               # create devel package
                                print_rpmtemplate_per_kmoddevelpkg --redhat ${kernel} ${kernel##${kernel_verrelarch}}
                        fi
-               elif [[ -e ${prefix}/lib/modules/"${kernel}"/build/Makefile ]] ; then 
+               elif [ -e "${prefix}/lib/modules/${kernel}/build/Makefile" ]; then 
                        # likely a user-build-kernel with available buildfiles
                        # fixme: we should check if uname from Makefile is the same as ${kernel}
 
@@ -324,7 +386,11 @@ print_customrpmtemplate ()
                        print_rpmtemplate_per_kmodpkg --custom "${kernel}"
 
                        # create development package
-                       if [[ "${devel}" ]]; then
+                       if [ -n "${devel}" ]; then
+                               # create devel package including common headers
+                               print_rpmtemplate_kmoddevelpkg --custom "${kernel}"
+
+                               # create devel package
                                print_rpmtemplate_per_kmoddevelpkg --custom "${kernel}"
                        fi
                else
@@ -332,11 +398,6 @@ print_customrpmtemplate ()
                fi
        done
 
-       # create common development package
-       if [[ "${devel}" ]]; then
-               print_rpmtemplate_kmoddevelpkg "${1}"
-       fi
-
        # well, it's no header anymore, but who cares ;-)
        print_rpmtemplate_header
 }
@@ -353,35 +414,34 @@ print_rpmtemplate ()
        # and print it and some other required stuff as macro
        print_rpmtemplate_header
 
-       # now print the packages itselfs
+       # now print the packages
        for kernel in ${kernel_versions_to_build_for} ; do
 
                local kernel_verrelarch=${kernel%%${kernels_known_variants}}
 
                # create metapackage 
-               print_rpmtemplate_kmodmetapkg ${kernel} ${kernel##${kernel_verrelarch}}
+               print_rpmtemplate_kmodmetapkg "${kernel}" "${kernel##${kernel_verrelarch}}"
 
                # create package
-               print_rpmtemplate_per_kmodpkg ${kernel} ${kernel##${kernel_verrelarch}}
+               print_rpmtemplate_per_kmodpkg "${kernel}" "${kernel##${kernel_verrelarch}}"
+
+               if [ -n "${devel}" ]; then
+                       # create devel package including common headers
+                       print_rpmtemplate_kmoddevelpkg "${kernel}" "${kernel##${kernel_verrelarch}}"
 
-               # create development package
-               if [[ "${devel}" ]]; then
-                       print_rpmtemplate_per_kmoddevelpkg ${kernel} ${kernel##${kernel_verrelarch}}
+                       # create devel package
+                       print_rpmtemplate_per_kmoddevelpkg "${kernel}" "${kernel##${kernel_verrelarch}}"
                fi
        done
-
-       # create common development package
-       if [[ "${devel}" ]]; then
-               print_rpmtemplate_kmoddevelpkg "${1}"
-       fi
 }
 
 myprog_help ()
 {
-       echo "Usage: $(basename ${0}) [OPTIONS]"
-       echo $'\n'"Creates a template to be used during kmod building"
-       echo $'\n'"Available options:"
-       # FIXME echo " --datadir <dir>     -- look for our shared files in <dir>"
+       echo "Usage: ${0##*/} [OPTIONS]"
+       echo
+       echo "Creates a template to be used during kmod building"
+       echo
+       echo "Available options:"
        echo " --filterfile <file>  -- filter the results with grep --file <file>"
        echo " --for-kernels <list> -- created templates only for these kernels"
        echo " --kmodname <file>    -- name of the kmod (required)"
@@ -389,15 +449,16 @@ myprog_help ()
        echo " --noakmod            -- no akmod package"
        echo " --repo <name>        -- use buildsys-build-<name>-kerneldevpkgs"
        echo " --target <arch>      -- target-arch (required)"
+       echo " --buildroot <dir>    -- Build root (place to look for build files)"
 }
 
-while [ "${1}" ] ; do
+while [ -n "${1}" ] ; do
        case "${1}" in
                --filterfile)
                        shift
-                       if [[ ! "${1}" ]] ; then
+                       if [ -z "${1}" ] ; then
                                error_out 2 "Please provide path to a filter-file together with --filterfile" >&2
-                       elif [[ ! -e "${1}" ]]; then    
+                       elif [ ! -e "${1}" ]; then      
                                error_out 2 "Filterfile ${1} not found" >&2
                        fi
                        filterfile="${1}"
@@ -405,7 +466,7 @@ while [ "${1}" ] ; do
                        ;;
                --kmodname)
                        shift
-                       if [[ ! "${1}" ]] ; then
+                       if [ -z "${1}" ] ; then
                                error_out 2 "Please provide the name of the kmod together with --kmodname" >&2
                    fi
                        # strip pending -kmod
@@ -418,7 +479,7 @@ while [ "${1}" ] ; do
                        ;;
                --prefix)
                        shift
-                       if [[ ! "${1}" ]] ; then
+                       if [ -z "${1}" ] ; then
                                error_out 2 "Please provide a prefix with --prefix" >&2
                    fi
                        prefix="${1}"
@@ -426,7 +487,7 @@ while [ "${1}" ] ; do
                        ;;
                --repo)
                        shift
-                       if [[ ! "${1}" ]] ; then
+                       if [ -z "${1}" ] ; then
                                error_out 2 "Please provide the name of the repo together with --repo" >&2
                    fi
                        repo=${1}
@@ -434,7 +495,7 @@ while [ "${1}" ] ; do
                        ;;
                --for-kernels)
                        shift
-                       if [[ ! "${1}" ]] ; then
+                       if [ -z "${1}" ] ; then
                                error_out 2 "Please provide the name of the kmod together with --kmodname" >&2
                        fi
                        for_kernels="${1}"
@@ -446,16 +507,16 @@ while [ "${1}" ] ; do
                        ;;
                --obsolete-name)
                        shift
-                       if [[ ! "${1}" ]] ; then
-                               error_out 2 "Please provide the name of the kmod to obsolte together with --obsolete-name" >&2
+                       if [ -z "${1}" ] ; then
+                               error_out 2 "Please provide the name of the kmod to obsolete together with --obsolete-name" >&2
                        fi
                        obsolete_name="${1}"
                        shift
                        ;;
                --obsolete-version)
                        shift
-                       if [[ ! "${1}" ]] ; then
-                               error_out 2 "Please provide the version of the kmod to obsolte together with --obsolete-version" >&2
+                       if [ -z "${1}" ] ; then
+                               error_out 2 "Please provide the version of the kmod to obsolete together with --obsolete-version" >&2
                        fi
                        obsolete_version="${1}"
                        shift
@@ -477,6 +538,11 @@ while [ "${1}" ] ; do
                        shift
                        build_kernels="current"
                        ;;
+               --buildroot)
+                       shift
+                       buildroot="${1}"
+                       shift
+                       ;;
                --help)
                        myprog_help
                        exit 0
@@ -493,30 +559,30 @@ while [ "${1}" ] ; do
        esac
 done
 
-if [[ -e ./kmodtool-kernel-variants ]]; then
+if [ -e ./kmodtool-kernel-variants ]; then
        kernels_known_variants="$(cat ./kmodtool-kernel-variants)"
-elif [[ -e /usr/share/kmodtool/kernel-variants ]] ; then
+elif [ -e /usr/share/kmodtool/kernel-variants ] ; then
        kernels_known_variants="$(cat /usr/share/kmodtool/kernel-variants)"
 else
        kernels_known_variants="@(smp?(-debug)|PAE?(-debug)|debug|kdump|xen|kirkwood|highbank|imx|omap|tegra)"
 fi
 
 # general sanity checks
-if [[ ! "${target}" ]]; then
+if [ -z "${target}" ]; then
                error_out 2 "please pass target arch with --target"
-elif [[ ! "${kmodname}" ]]; then
+elif [ -z "${kmodname}" ]; then
                error_out 2 "please pass kmodname with --kmodname"
-elif [[ ! "${kernels_known_variants}" ]] ; then
+elif [ -z "${kernels_known_variants}" ] ; then
                error_out 2 "could not determine known variants"
-elif ( [[ "${obsolete_name}" ]] && [[ ! "${obsolete_version}" ]] ) ||  ( [[ ! "${obsolete_name}" ]] && [[ "${obsolete_version}" ]] ) ; then
+elif { [ -n "${obsolete_name}" ] && [ -z "${obsolete_version}" ]; } ||  { [ -z "${obsolete_name}" ] && [ -n "${obsolete_version}" ]; } ; then
                error_out 2 "you need to provide both --obsolete-name and --obsolete-version"
 fi
 
 # go
-if [[ "${for_kernels}" ]]; then
+if [ -n "${for_kernels}" ]; then
        # this is easy:
        print_customrpmtemplate "${for_kernels}"
-elif [[ "${build_kernels}" == "akmod" ]]; then
+elif [ "${build_kernels}" = "akmod" ]; then
        # do only a akmod package
        print_akmodtemplate
        print_akmodmeta
@@ -524,9 +590,9 @@ else
        # seems we are on out own to decide for which kernels to build
 
        # we need more sanity checks in this case
-       if [[ ! "${repo}" ]]; then
+       if [ -z "${repo}" ]; then
                error_out 2 "please provide repo name with --repo"
-       elif ! $(which buildsys-build-${repo}-kerneldevpkgs &> /dev/null) ; then
+       elif ! command -v "buildsys-build-${repo}-kerneldevpkgs" > /dev/null 2>&1; then
                error_out 2 "buildsys-build-${repo}-kerneldevpkgs not found"
        fi
 
@@ -534,17 +600,18 @@ else
        cmdoptions="--target ${target}"
 
        # filterfile to filter list of kernels? 
-       if [[ "${filterfile}" ]] ; then
+       if [ -n "${filterfile}" ] ; then
                 cmdoptions="${cmdoptions} --filterfile ${filterfile}"
        fi
 
-       kernel_versions_to_build_for="$(buildsys-build-${repo}-kerneldevpkgs --${build_kernels} ${cmdoptions})"
+       kernel_versions_to_build_for=$(buildsys-build-${repo}-kerneldevpkgs "--${build_kernels}" ${cmdoptions})
        returncode=$?
-       if (( ${returncode} != 0 )); then
-               error_out 2 "buildsys-build-${repo}-kerneldevpkgs failed: $(buildsys-build-${repo}-kerneldevpkgs --${build_kernels} ${cmdoptions})"
+       if [ "$returncode" -ne 0 ]; then
+               
+               error_out 2 "buildsys-build-${repo}-kerneldevpkgs failed: ${kernel_versions_to_build_for}"
        fi
 
-       if [[ "${build_kernels}" == "current" ]] && [[ ! "${noakmod}" ]]; then
+       if [ "${build_kernels}" = "current" ] && [ -z "${noakmod}" ]; then
                print_akmodtemplate
        fi