tests: cfg2cmd: add a few q35 related tests

[qemu-server.git] / test / run_config2command_tests.pl

diff --git a/test/run_config2command_tests.pl b/test/run_config2command_tests.pl
index c75be5385b0da5b0efe5628e40207ee4dd4d30cd..04df9d93e3e22dae228a69336e5d9c1ab26bf4b4 100755 (executable)
--- a/test/run_config2command_tests.pl
+++ b/test/run_config2command_tests.pl
@@ -17,6 +17,7 @@ use PVE::QemuConfig;
 use PVE::QemuServer;
 use PVE::QemuServer::Monitor;
 use PVE::QemuServer::Machine;
+use PVE::QemuServer::CPUConfig;
 
 my $base_env = {
     storage_config => {
@@ -29,6 +30,13 @@ my $base_env = {
                type => 'dir',
                shared => 0,
            },
+           'btrfs-store' => {
+               content => {
+                   images => 1,
+               },
+               path => '/butter/bread',
+               type => 'btrfs',
+           },
            'cifs-store' => {
                shared => 1,
                path => '/mnt/pve/cifs-store',
@@ -83,6 +91,8 @@ my $current_test; # = {
 #   description => 'Test description', # if available
 #   qemu_version => '2.12',
 #   host_arch => 'HOST_ARCH',
+#   expected_error => 'error message',
+#   expected_warning => 'warning message',
 #   config => { config hash },
 #   expected => [ expected outcome cmd line array ],
 # };
@@ -91,6 +101,7 @@ my $current_test; # = {
 #   TEST: A single line describing the test, gets outputted
 #   QEMU_VERSION: \d+\.\d+(\.\d+)? (defaults to current version)
 #   HOST_ARCH: x86_64 | aarch64 (default to x86_64, to make tests stable)
+#   EXPECT_ERROR: <error message> For negative tests
 # all fields are optional
 sub parse_test($) {
     my ($config_fn) = @_;
@@ -117,8 +128,19 @@ sub parse_test($) {
            $current_test->{qemu_version} = "$1";
        } elsif ($line =~ /^HOST_ARCH:\s*(.*)\s*$/) {
            $current_test->{host_arch} = "$1";
+       } elsif ($line =~ /^EXPECT_ERROR:\s*(.*)\s*$/) {
+           $current_test->{expect_error} = "$1";
+       } elsif ($line =~ /^EXPECT_WARN(?:ING)?:\s*(.*)\s*$/) {
+           $current_test->{expect_warning} = "$1";
        }
     }
+
+    $config_fn =~ /([^\/]+)$/;
+    my $testname = "$1";
+    if (my $desc = $current_test->{description}) {
+       $testname = "'$testname' - $desc";
+    }
+    $current_test->{testname} = $testname;
 }
 
 sub get_test_qemu_version {
@@ -182,6 +204,37 @@ $pve_common_tools->mock(
     },
 );
 
+my $pve_cpuconfig;
+$pve_cpuconfig = Test::MockModule->new('PVE::QemuServer::CPUConfig');
+$pve_cpuconfig->mock(
+    load_custom_model_conf => sub {
+       # mock custom CPU model config
+       return PVE::QemuServer::CPUConfig->parse_config("cpu-models.conf",
+<<EOF
+
+# "qemu64" is also a default CPU, used here to test that this doesn't matter
+cpu-model: qemu64
+    reported-model athlon
+    flags +aes;+avx;-kvm_pv_unhalt
+    hv-vendor-id testvend
+    phys-bits 40
+
+cpu-model: alldefault
+
+EOF
+       )
+    },
+);
+
+my $pve_common_network;
+$pve_common_network = Test::MockModule->new('PVE::Network');
+$pve_common_network->mock(
+    read_bridge_mtu => sub {
+       return 1500;
+    },
+);
+
+
 my $pve_common_inotify;
 $pve_common_inotify = Test::MockModule->new('PVE::INotify');
 $pve_common_inotify->mock(
@@ -242,7 +295,7 @@ sub diff($$) {
     my $ha = IO::Handle->new_from_fd($wa, 'w');
     my $hb = IO::Handle->new_from_fd($wb, 'w');
 
-    open my $diffproc, '-|', 'diff', '-up', "/proc/self/fd/$ra", "/proc/self/fd/$rb"
+    open my $diffproc, '-|', 'diff', '-up', "/proc/self/fd/$ra", "/proc/self/fd/$rb" ## no critic
        or die "failed to run program 'diff': $!";
     POSIX::close($ra);
     POSIX::close($rb);
@@ -265,6 +318,23 @@ sub diff($$) {
     die "files differ:\n$diff";
 }
 
+$SIG{__WARN__} = sub {
+    my $warning = shift;
+    chomp $warning;
+    if (my $warn_expect = $current_test->{expect_warning}) {
+       if ($warn_expect ne $warning) {
+           fail($current_test->{testname});
+           note("warning does not match expected error: '$warning' != '$warn_expect'");
+       } else {
+           note("got expected warning '$warning'");
+           return;
+       }
+    }
+
+    fail($current_test->{testname});
+    note("got unexpected warning '$warning'");
+};
+
 sub do_test($) {
     my ($config_fn) = @_;
 
@@ -272,15 +342,32 @@ sub do_test($) {
 
     parse_test $config_fn;
 
-    $config_fn =~ /([^\/]+)$/;
-    my $testname = "$1";
-    if (my $desc = $current_test->{description}) {
-       $testname = "'$testname' - $desc";
-    }
+    my $testname = $current_test->{testname};
 
     my ($vmid, $storecfg) = $base_env->@{qw(vmid storage_config)};
 
-    my $cmdline = PVE::QemuServer::vm_commandline($storecfg, $vmid);
+    my $cmdline = eval { PVE::QemuServer::vm_commandline($storecfg, $vmid) };
+    my $err = $@;
+
+    if (my $err_expect = $current_test->{expect_error}) {
+       if (!$err) {
+           fail("$testname");
+           note("did NOT get any error, but expected error: $err_expect");
+           return;
+       }
+       chomp $err;
+       if ($err ne $err_expect) {
+           fail("$testname");
+           note("error does not match expected error: '$err' !~ '$err_expect'");
+       } else {
+           pass("$testname");
+       }
+       return;
+    } elsif ($err) {
+       fail("$testname");
+       note("got unexpected error: $err");
+       return;
+    }
 
     # check if QEMU version set correctly and test version_cmp
     (my $qemu_major = get_test_qemu_version()) =~ s/\..*$//;
@@ -321,7 +408,7 @@ print "testing config to command stabillity\n";
 if (my $file = shift) {
     do_test $file;
 } else {
-    foreach my $file (<cfg2cmd/*.conf>) {
+    while (my $file = <cfg2cmd/*.conf>) {
        do_test $file;
     }
 }