onlineHelp: 'pve_ceph_pools',
subject: 'Ceph Pool',
+
+ defaultSize: undefined,
+ defaultMinSize: undefined,
+
column1: [
{
xtype: 'pmxDisplayEditField',
cbind: {
editable: '{isCreate}',
value: '{pool_name}',
- disabled: '{!isCreate}',
},
name: 'name',
allowBlank: false,
},
{
- xtype: 'proxmoxintegerfield',
+ xtype: 'pmxDisplayEditField',
+ cbind: {
+ editable: '{!isErasure}',
+ },
fieldLabel: gettext('Size'),
name: 'size',
- value: 3,
- minValue: 2,
- maxValue: 7,
- allowBlank: false,
- listeners: {
- change: function(field, val) {
- let size = Math.round((val + 1) / 2);
- if (size > 1) {
- field.up('inputpanel').down('field[name=min_size]').setValue(size);
- }
+ editConfig: {
+ xtype: 'proxmoxintegerfield',
+ cbind: {
+ value: (get) => get('defaultSize'),
+ },
+ minValue: 2,
+ maxValue: 7,
+ allowBlank: false,
+ listeners: {
+ change: function(field, val) {
+ let size = Math.round(val / 2);
+ if (size > 1) {
+ field.up('inputpanel').down('field[name=min_size]').setValue(size);
+ }
+ },
},
},
},
['on', 'on'],
['off', 'off'],
],
- value: 'warn',
+ value: 'on', // FIXME: check ceph version and only default to on on octopus and newer
allowBlank: false,
autoSelect: false,
labelWidth: 140,
xtype: 'proxmoxintegerfield',
fieldLabel: gettext('Min. Size'),
name: 'min_size',
- value: 2,
cbind: {
- minValue: (get) => get('isCreate') ? 2 : 1,
+ value: (get) => get('defaultMinSize'),
+ minValue: (get) => {
+ if (Number(get('defaultMinSize')) === 1) {
+ return 1;
+ } else {
+ return get('isCreate') ? 2 : 1;
+ }
+ },
},
maxValue: 7,
allowBlank: false,
let panel = field.up('inputpanel');
let size = panel.down('field[name=size]').getValue();
- let showWarning = minSize <= size / 2 && minSize !== size;
+ let showWarning = minSize < (size / 2) && minSize !== size;
let fieldLabel = gettext('Min. Size');
if (showWarning) {
xtype: 'displayfield',
name: 'min_size-warning',
userCls: 'pmx-hint',
- value: gettext('min_size <= size/2 can lead to data loss, incomplete PGs or unfound objects.'),
+ value: gettext('min_size < size/2 can lead to data loss, incomplete PGs or unfound objects.'),
hidden: true,
},
{
- xtype: 'pveCephRuleSelector',
+ xtype: 'pmxDisplayEditField',
+ cbind: {
+ editable: '{!isErasure}',
+ nodename: '{nodename}',
+ isCreate: '{isCreate}',
+ },
fieldLabel: 'Crush Rule', // do not localize
- cbind: { nodename: '{nodename}' },
name: 'crush_rule',
- allowBlank: false,
+ editConfig: {
+ xtype: 'pveCephRuleSelector',
+ allowBlank: false,
+ },
},
{
xtype: 'proxmoxintegerfield',
minValue: 0,
decimalPrecision: 3,
allowBlank: true,
- allowZero: true,
emptyText: '0.0',
autoEl: {
tag: 'div',
allowBlank: true,
allowZero: true,
emptyText: '0',
+ emptyValue: 0,
autoEl: {
tag: 'div',
'data-qtip': gettext('The amount of data eventually stored in this pool. Used for auto-scaling.'),
},
});
-Ext.define('PVE.CephPoolEdit', {
+Ext.define('PVE.Ceph.PoolEdit', {
extend: 'Proxmox.window.Edit',
alias: 'widget.pveCephPoolEdit',
- xtype: 'pveCephPoolEdit',
mixins: ['Proxmox.Mixin.CBind'],
cbindData: {
pool_name: '',
isCreate: (cfg) => !cfg.pool_name,
+ defaultSize: undefined,
+ defaultMinSize: undefined,
},
cbind: {
autoLoad: get => !get('isCreate'),
url: get => get('isCreate')
- ? `/nodes/${get('nodename')}/ceph/pools`
- : `/nodes/${get('nodename')}/ceph/pools/${get('pool_name')}`,
+ ? `/nodes/${get('nodename')}/ceph/pool`
+ : `/nodes/${get('nodename')}/ceph/pool/${get('pool_name')}`,
+ loadUrl: get => `/nodes/${get('nodename')}/ceph/pool/${get('pool_name')}/status`,
method: get => get('isCreate') ? 'POST' : 'PUT',
},
cbind: {
nodename: '{nodename}',
pool_name: '{pool_name}',
+ isErasure: '{isErasure}',
isCreate: '{isCreate}',
+ defaultSize: '{defaultSize}',
+ defaultMinSize: '{defaultMinSize}',
},
}],
});
-Ext.define('PVE.node.CephPoolList', {
+Ext.define('PVE.node.Ceph.PoolList', {
extend: 'Ext.grid.GridPanel',
alias: 'widget.pveNodeCephPoolList',
features: [{ ftype: 'summary' }],
columns: [
+ {
+ text: gettext('Pool #'),
+ minWidth: 70,
+ flex: 1,
+ align: 'right',
+ sortable: true,
+ dataIndex: 'pool',
+ },
{
text: gettext('Name'),
minWidth: 120,
sortable: true,
dataIndex: 'pool_name',
},
+ {
+ text: gettext('Type'),
+ minWidth: 100,
+ flex: 1,
+ dataIndex: 'type',
+ hidden: true,
+ },
{
text: gettext('Size') + '/min',
minWidth: 100,
flex: 1,
align: 'right',
- renderer: function(v, meta, rec) {
- return v + '/' + rec.data.min_size;
- },
+ renderer: (v, meta, rec) => `${v}/${rec.data.min_size}`,
dataIndex: 'size',
},
{
dataIndex: 'target_size',
hidden: true,
renderer: function(v, metaData, rec) {
- let value = PVE.Utils.render_size(v);
+ let value = Proxmox.Utils.render_size(v);
if (rec.data.target_size_ratio > 0) {
value = '<i class="fa fa-info-circle faded"></i> ' + value;
metaData.tdAttr = 'data-qtip="Target Size Ratio takes precedence over Target Size."';
align: 'right',
dataIndex: 'bytes_used',
summaryType: 'sum',
- summaryRenderer: PVE.Utils.render_size,
+ summaryRenderer: Proxmox.Utils.render_size,
renderer: function(v, meta, rec) {
let percentage = Ext.util.Format.percent(rec.data.percent_used, '0.00');
- let used = PVE.Utils.render_size(v);
- return used + ' (' + percentage + ')';
+ let used = Proxmox.Utils.render_size(v);
+ return `${used} (${percentage})`;
},
},
],
storeid: 'ceph-pool-list' + nodename,
model: 'ceph-pool-list',
proxy: {
- type: 'proxmox',
- url: "/api2/json/nodes/" + nodename + "/ceph/pools",
+ type: 'proxmox',
+ url: `/api2/json/nodes/${nodename}/ceph/pool`,
},
});
let store = Ext.create('Proxmox.data.DiffStore', { rstore: rstore });
- PVE.Utils.handleStoreErrorOrMask(
- me,
- rstore,
- /not (installed|initialized)/i,
- (_, error) => {
- rstore.stopUpdate();
- PVE.Utils.showCephInstallOrMask(me, error.statusText, nodename, win => {
- me.mon(win, 'cephInstallWindowClosed', () => rstore.startUpdate());
- });
- },
- );
+ // manages the "install ceph?" overlay
+ PVE.Utils.monitor_ceph_installed(me, rstore, nodename);
var run_editor = function() {
let rec = sm.getSelection()[0];
if (!rec || !rec.data.pool_name) {
return;
}
- Ext.create('PVE.CephPoolEdit', {
+ Ext.create('PVE.Ceph.PoolEdit', {
title: gettext('Edit') + ': Ceph Pool',
nodename: nodename,
pool_name: rec.data.pool_name,
+ isErasure: rec.data.type === 'erasure',
autoShow: true,
listeners: {
destroy: () => rstore.load(),
{
text: gettext('Create'),
handler: function() {
- Ext.create('PVE.CephPoolEdit', {
- title: gettext('Create') + ': Ceph Pool',
- isCreate: true,
- nodename: nodename,
- autoShow: true,
- listeners: {
- destroy: () => rstore.load(),
+ let keys = [
+ 'global:osd-pool-default-min-size',
+ 'global:osd-pool-default-size',
+ ];
+ let params = {
+ 'config-keys': keys.join(';'),
+ };
+
+ Proxmox.Utils.API2Request({
+ url: '/nodes/localhost/ceph/cfg/value',
+ method: 'GET',
+ params,
+ waitMsgTarget: me.getView(),
+ failure: response => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
+ success: function({ result: { data } }) {
+ let global = data.global;
+ let defaultSize = global?.['osd-pool-default-size'] ?? 3;
+ let defaultMinSize = global?.['osd-pool-default-min-size'] ?? 2;
+
+ Ext.create('PVE.Ceph.PoolEdit', {
+ title: gettext('Create') + ': Ceph Pool',
+ isCreate: true,
+ isErasure: false,
+ defaultSize,
+ defaultMinSize,
+ nodename: nodename,
+ autoShow: true,
+ listeners: {
+ destroy: () => rstore.load(),
+ },
+ });
},
});
},
let poolName = rec.data.pool_name;
Ext.create('Proxmox.window.SafeDestroy', {
showProgress: true,
- url: `/nodes/${nodename}/ceph/pools/${poolName}`,
+ url: `/nodes/${nodename}/ceph/pool/${poolName}`,
params: {
remove_storages: 1,
},
queryMode: 'local',
initComponent: function() {
- var me = this;
+ let me = this;
if (!me.nodename) {
throw "no nodename given";
}
- var store = Ext.create('Ext.data.Store', {
- fields: ['name'],
- sorters: 'name',
- proxy: {
- type: 'proxmox',
- url: `/api2/json/nodes/${me.nodename}/ceph/rules`,
- },
- });
+ me.originalAllowBlank = me.allowBlank;
+ me.allowBlank = true;
Ext.apply(me, {
- store: store,
- });
-
- me.callParent();
+ store: {
+ fields: ['name'],
+ sorters: 'name',
+ proxy: {
+ type: 'proxmox',
+ url: `/api2/json/nodes/${me.nodename}/ceph/rules`,
+ },
+ autoLoad: {
+ callback: (records, op, success) => {
+ if (me.isCreate && success && records.length > 0) {
+ me.select(records[0]);
+ }
- store.load({
- callback: function(rec, op, success) {
- if (success && rec.length > 0) {
- me.select(rec[0]);
- }
+ me.allowBlank = me.originalAllowBlank;
+ delete me.originalAllowBlank;
+ me.validate();
+ },
+ },
},
});
+
+ me.callParent();
},
});