]> git.proxmox.com Git - pve-manager.git/blobdiff - www/manager6/dc/Backup.js
ui: ldap: add 'Check connection' checkbox as advanced option
[pve-manager.git] / www / manager6 / dc / Backup.js
index ff52e382276b47ea4e57632434f38b4a5a026b33..03a026513a3ef9de94c25e2241f994a9f41dcb45 100644 (file)
@@ -2,819 +2,424 @@ Ext.define('PVE.dc.BackupEdit', {
     extend: 'Proxmox.window.Edit',
     alias: ['widget.pveDcBackupEdit'],
 
+    mixins: ['Proxmox.Mixin.CBind'],
+
     defaultFocus: undefined,
 
-    initComponent: function() {
-       let me = this;
+    subject: gettext("Backup Job"),
+    bodyPadding: 0,
 
-       me.isCreate = !me.jobid;
+    url: '/api2/extjs/cluster/backup',
+    method: 'POST',
+    isCreate: true,
 
-       let url, method;
-       if (me.isCreate) {
-           url = '/api2/extjs/cluster/backup';
-           method = 'POST';
-       } else {
-           url = '/api2/extjs/cluster/backup/' + me.jobid;
-           method = 'PUT';
+    cbindData: function() {
+       let me = this;
+       if (me.jobid) {
+           me.isCreate = false;
+           me.method = 'PUT';
+           me.url += `/${me.jobid}`;
        }
+       return {};
+    },
 
-       let vmidField = Ext.create('Ext.form.field.Hidden', {
-           name: 'vmid',
-       });
+    controller: {
+       xclass: 'Ext.app.ViewController',
 
-       // 'value' can be assigned a string or an array
-       let selModeField = Ext.create('Proxmox.form.KVComboBox', {
-           xtype: 'proxmoxKVComboBox',
-           comboItems: [
-               ['include', gettext('Include selected VMs')],
-               ['all', gettext('All')],
-               ['exclude', gettext('Exclude selected VMs')],
-               ['pool', gettext('Pool based')],
-           ],
-           fieldLabel: gettext('Selection mode'),
-           name: 'selMode',
-           value: '',
-       });
+       onGetValues: function(values) {
+           let me = this;
+           let isCreate = me.getView().isCreate;
+           if (!values.node) {
+               if (!isCreate) {
+                   Proxmox.Utils.assemble_field_data(values, { 'delete': 'node' });
+               }
+               delete values.node;
+           }
 
-       let sm = Ext.create('Ext.selection.CheckboxModel', {
-           mode: 'SIMPLE',
-           listeners: {
-               selectionchange: function(model, selected) {
-                   var sel = [];
-                   Ext.Array.each(selected, function(record) {
-                       sel.push(record.data.vmid);
-                   });
+           if (!values.id && isCreate) {
+               values.id = 'backup-' + Ext.data.identifier.Uuid.Global.generate().slice(0, 13);
+           }
 
-                   // to avoid endless recursion suspend the vmidField change
-                   // event temporary as it calls us again
-                   vmidField.suspendEvent('change');
-                   vmidField.setValue(sel);
-                   vmidField.resumeEvent('change');
-               },
-           },
-       });
+           let selMode = values.selMode;
+           delete values.selMode;
+
+           if (selMode === 'all') {
+               values.all = 1;
+               values.exclude = '';
+               delete values.vmid;
+           } else if (selMode === 'exclude') {
+               values.all = 1;
+               values.exclude = values.vmid;
+               delete values.vmid;
+           } else if (selMode === 'pool') {
+               delete values.vmid;
+           }
 
-       let storagesel = Ext.create('PVE.form.StorageSelector', {
-           fieldLabel: gettext('Storage'),
-           nodename: 'localhost',
-           storageContent: 'backup',
-           allowBlank: false,
-           name: 'storage',
-           listeners: {
-               change: function(f, v) {
-                   let store = f.getStore();
-                   let rec = store.findRecord('storage', v, 0, false, true, true);
-                   let compressionSelector = me.down('pveCompressionSelector');
+           if (selMode !== 'pool') {
+               delete values.pool;
+           }
+           return values;
+       },
 
-                   if (rec && rec.data && rec.data.type === 'pbs') {
-                       compressionSelector.setValue('zstd');
-                       compressionSelector.setDisabled(true);
-                   } else if (!compressionSelector.getEditable()) {
-                       compressionSelector.setDisabled(false);
-                   }
-               },
-           },
-       });
+       nodeChange: function(f, value) {
+           let me = this;
+           me.lookup('storageSelector').setNodename(value);
+           let vmgrid = me.lookup('vmgrid');
+           let store = vmgrid.getStore();
 
-       let store = new Ext.data.Store({
-           model: 'PVEResources',
-           sorters: {
-               property: 'vmid',
-               order: 'ASC',
-           },
-       });
+           store.clearFilter();
+           store.filterBy(function(rec) {
+               return !value || rec.get('node') === value;
+           });
 
-       let vmgrid = Ext.createWidget('grid', {
-           store: store,
-           border: true,
-           height: 300,
-           selModel: sm,
-           disabled: true,
-           columns: [
-               {
-                   header: 'ID',
-                   dataIndex: 'vmid',
-                   width: 60,
-               },
-               {
-                   header: gettext('Node'),
-                   dataIndex: 'node',
-               },
-               {
-                   header: gettext('Status'),
-                   dataIndex: 'uptime',
-                   renderer: function(value) {
-                       if (value) {
-                           return Proxmox.Utils.runningText;
-                       } else {
-                           return Proxmox.Utils.stoppedText;
-                       }
-                   },
-               },
-               {
-                   header: gettext('Name'),
-                   dataIndex: 'name',
-                   flex: 1,
-               },
-               {
-                   header: gettext('Type'),
-                   dataIndex: 'type',
-               },
-           ],
-       });
+           let mode = me.lookup('modeSelector').getValue();
+           if (mode === 'all') {
+               vmgrid.selModel.selectAll(true);
+           }
+           if (mode === 'pool') {
+               me.selectPoolMembers();
+           }
+       },
+
+       storageChange: function(f, v) {
+           let me = this;
+           let rec = f.getStore().findRecord('storage', v, 0, false, true, true);
+           let compressionSelector = me.lookup('compressionSelector');
+
+           if (rec?.data?.type === 'pbs') {
+               compressionSelector.setValue('zstd');
+               compressionSelector.setDisabled(true);
+           } else if (!compressionSelector.getEditable()) {
+               compressionSelector.setDisabled(false);
+           }
+       },
 
-       let selectPoolMembers = function(poolid) {
+       selectPoolMembers: function() {
+           let me = this;
+           let mode = me.lookup('modeSelector').getValue();
+
+           if (mode !== 'pool') {
+               return;
+           }
+
+           let vmgrid = me.lookup('vmgrid');
+           let poolid = me.lookup('poolSelector').getValue();
+
+           vmgrid.getSelectionModel().deselectAll(true);
            if (!poolid) {
                return;
            }
-           sm.deselectAll(true);
-           store.filter([
+           vmgrid.getStore().filter([
                {
                    id: 'poolFilter',
                    property: 'pool',
                    value: poolid,
                },
            ]);
-           sm.selectAll(true);
-       };
-
-       let selPool = Ext.create('PVE.form.PoolSelector', {
-           fieldLabel: gettext('Pool to backup'),
-           hidden: true,
-           allowBlank: true,
-           name: 'pool',
-           listeners: {
-               change: function(selpool, newValue, oldValue) {
-                   selectPoolMembers(newValue);
-               },
-           },
-       });
-
-       let nodesel = Ext.create('PVE.form.NodeSelector', {
-           name: 'node',
-           fieldLabel: gettext('Node'),
-           allowBlank: true,
-           editable: true,
-           autoSelect: false,
-           emptyText: '-- ' + gettext('All') + ' --',
-           listeners: {
-               change: function(f, value) {
-                   storagesel.setNodename(value || 'localhost');
-                   let mode = selModeField.getValue();
-                   store.clearFilter();
-                   store.filterBy(function(rec) {
-                       return !value || rec.get('node') === value;
-                   });
-                   if (mode === 'all') {
-                       sm.selectAll(true);
-                   }
-                   if (mode === 'pool') {
-                       selectPoolMembers(selPool.value);
-                   }
-               },
-           },
-       });
-
-       let column1 = [
-           nodesel,
-           storagesel,
-           {
-               xtype: 'pveDayOfWeekSelector',
-               name: 'dow',
-               fieldLabel: gettext('Day of week'),
-               multiSelect: true,
-               value: ['sat'],
-               allowBlank: false,
-           },
-           {
-               xtype: 'timefield',
-               fieldLabel: gettext('Start Time'),
-               name: 'starttime',
-               format: 'H:i',
-               formatText: 'HH:MM',
-               value: '00:00',
-               allowBlank: false,
-           },
-           selModeField,
-           selPool,
-       ];
-
-       let column2 = [
-           {
-               xtype: 'textfield',
-               fieldLabel: gettext('Send email to'),
-               name: 'mailto',
-           },
-           {
-               xtype: 'pveEmailNotificationSelector',
-               fieldLabel: gettext('Email notification'),
-               name: 'mailnotification',
-               deleteEmpty: !me.isCreate,
-               value: me.isCreate ? 'always' : '',
-           },
-           {
-               xtype: 'pveCompressionSelector',
-               fieldLabel: gettext('Compression'),
-               name: 'compress',
-               deleteEmpty: !me.isCreate,
-               value: 'zstd',
-           },
-           {
-               xtype: 'pveBackupModeSelector',
-               fieldLabel: gettext('Mode'),
-               value: 'snapshot',
-               name: 'mode',
-           },
-           {
-               xtype: 'proxmoxcheckbox',
-               fieldLabel: gettext('Enable'),
-               name: 'enabled',
-               uncheckedValue: 0,
-               defaultValue: 1,
-               checked: true,
-           },
-           vmidField,
-       ];
-
-       let ipanel = Ext.create('Proxmox.panel.InputPanel', {
-           onlineHelp: 'chapter_vzdump',
-           column1: column1,
-           column2: column2,
-           onGetValues: function(values) {
-               if (!values.node) {
-                   if (!me.isCreate) {
-                       Proxmox.Utils.assemble_field_data(values, { 'delete': 'node' });
-                   }
-                   delete values.node;
-               }
-
-               let selMode = values.selMode;
-               delete values.selMode;
-
-               if (selMode === 'all') {
-                   values.all = 1;
-                   values.exclude = '';
-                   delete values.vmid;
-               } else if (selMode === 'exclude') {
-                   values.all = 1;
-                   values.exclude = values.vmid;
-                   delete values.vmid;
-               } else if (selMode === 'pool') {
-                   delete values.vmid;
-               }
-
-               if (selMode !== 'pool') {
-                   delete values.pool;
-               }
-               return values;
-           },
-       });
-
-       let update_vmid_selection = function(list, mode) {
-           if (mode !== 'all' && mode !== 'pool') {
-               sm.deselectAll(true);
-               if (list) {
-                   Ext.Array.each(list.split(','), function(vmid) {
-                       var rec = store.findRecord('vmid', vmid, 0, false, true, true);
-                       if (rec) {
-                           sm.select(rec, true);
-                       }
-                   });
-               }
-           }
-       };
-
-       vmidField.on('change', function(f, value) {
-           let mode = selModeField.getValue();
-           update_vmid_selection(value, mode);
-       });
+           vmgrid.selModel.selectAll(true);
+       },
 
-       selModeField.on('change', function(f, value, oldValue) {
-           if (oldValue === 'pool') {
-               store.removeFilter('poolFilter');
-           }
+       modeChange: function(f, value, oldValue) {
+           let me = this;
+           let vmgrid = me.lookup('vmgrid');
+           vmgrid.getStore().removeFilter('poolFilter');
 
-           if (oldValue === 'all') {
-               sm.deselectAll(true);
-               vmidField.setValue('');
+           if (oldValue === 'all' && value !== 'all') {
+               vmgrid.getSelectionModel().deselectAll(true);
            }
 
            if (value === 'all') {
-               sm.selectAll(true);
-               vmgrid.setDisabled(true);
-           } else {
-               vmgrid.setDisabled(false);
+               vmgrid.getSelectionModel().selectAll(true);
            }
 
            if (value === 'pool') {
-               vmgrid.setDisabled(true);
-               vmidField.setValue('');
-               selPool.setVisible(true);
-               selPool.allowBlank = false;
-               selectPoolMembers(selPool.value);
-           } else {
-               selPool.setVisible(false);
-               selPool.allowBlank = true;
+               me.selectPoolMembers();
            }
-           let list = vmidField.getValue();
-           update_vmid_selection(list, value);
-       });
-
-       let reload = function() {
-           store.load({
-               params: {
-                   type: 'vm',
-               },
-               callback: function() {
-                   let node = nodesel.getValue();
-                   store.clearFilter();
-                   store.filterBy(rec => !node || node.length === 0 || rec.get('node') === node);
-                   let list = vmidField.getValue();
-                   let mode = selModeField.getValue();
-                   if (mode === 'all') {
-                       sm.selectAll(true);
-                   } else if (mode === 'pool') {
-                       selectPoolMembers(selPool.value);
-                   } else {
-                       update_vmid_selection(list, mode);
-                   }
-               },
-           });
-       };
-
-       Ext.applyIf(me, {
-           subject: gettext("Backup Job"),
-           url: url,
-           method: method,
-           bodyPadding: 0,
-           items: [
-               {
-                   xtype: 'tabpanel',
-                   region: 'center',
-                   layout: 'fit',
-                   bodyPadding: 10,
-                   items: [
-                       {
-                           xtype: 'container',
-                           title: gettext('General'),
-                           region: 'center',
-                           layout: {
-                               type: 'vbox',
-                               align: 'stretch',
-                           },
-                           items: [
-                               ipanel,
-                               vmgrid,
-                           ],
-                       },
-                       {
-                           xtype: 'pveEditPruneInputPanel',
-                           title: gettext('Retention'),
-                           isCreate: me.isCreate,
-                           keepAllDefaultForCreate: false,
-                           showPBSHint: false,
-                           fallbackHintHtml: gettext('Without any keep option, the storage\'s configuration or node\'s vzdump.conf is used as fallback'),
-                       },
-                   ],
-               },
-           ],
-
-       });
-
-       me.callParent();
-
-       if (me.isCreate) {
-           selModeField.setValue('include');
-       } else {
-            me.load({
-               success: function(response, options) {
-                   let data = response.result.data;
+       },
 
-                   data.dow = data.dow.split(',');
+       init: function(view) {
+           let me = this;
+           if (view.isCreate) {
+               me.lookup('modeSelector').setValue('include');
+           } else {
+               view.load({
+                   success: function(response, _options) {
+                       let data = response.result.data;
 
-                   if (data.all || data.exclude) {
                        if (data.exclude) {
                            data.vmid = data.exclude;
                            data.selMode = 'exclude';
-                       } else {
+                       } else if (data.all) {
                            data.vmid = '';
                            data.selMode = 'all';
-                       }
-                   } else if (data.pool) {
-                       data.selMode = 'pool';
-                       data.selPool = data.pool;
-                   } else {
-                       data.selMode = 'include';
-                   }
-
-                   if (data['prune-backups']) {
-                       Object.assign(data, data['prune-backups']);
-                       delete data['prune-backups'];
-                   } else if (data.maxfiles !== undefined) {
-                       if (data.maxfiles > 0) {
-                           data['keep-last'] = data.maxfiles;
+                       } else if (data.pool) {
+                           data.selMode = 'pool';
+                           data.selPool = data.pool;
                        } else {
-                           data['keep-all'] = 1;
+                           data.selMode = 'include';
                        }
-                       delete data.maxfiles;
-                   }
-
-                   me.setValues(data);
-               },
-           });
-       }
 
-       reload();
-    },
-});
-
-
-Ext.define('PVE.dc.BackupDiskTree', {
-    extend: 'Ext.tree.Panel',
-    alias: 'widget.pveBackupDiskTree',
+                       me.getViewModel().set('selMode', data.selMode);
+
+                       if (data['prune-backups']) {
+                           Object.assign(data, data['prune-backups']);
+                           delete data['prune-backups'];
+                       } else if (data.maxfiles !== undefined) {
+                           if (data.maxfiles > 0) {
+                               data['keep-last'] = data.maxfiles;
+                           } else {
+                               data['keep-all'] = 1;
+                           }
+                           delete data.maxfiles;
+                       }
 
-    folderSort: true,
-    rootVisible: false,
+                       if (data['notes-template']) {
+                           data['notes-template'] =
+                               PVE.Utils.unEscapeNotesTemplate(data['notes-template']);
+                       }
 
-    store: {
-       sorters: 'id',
-       data: {},
+                       view.setValues(data);
+                   },
+               });
+           }
+       },
     },
 
-    tools: [
-       {
-           type: 'expand',
-           tooltip: gettext('Expand All'),
-           callback: panel => panel.expandAll(),
-       },
-       {
-           type: 'collapse',
-           tooltip: gettext('Collapse All'),
-           callback: panel => panel.collapseAll(),
+    viewModel: {
+       data: {
+           selMode: 'include',
        },
-    ],
 
-    columns: [
-       {
-           xtype: 'treecolumn',
-           text: gettext('Guest Image'),
-           renderer: function(value, meta, record) {
-               if (record.data.type) {
-                   // guest level
-                   let ret = value;
-                   if (record.data.name) {
-                       ret += " (" + record.data.name + ")";
-                   }
-                   return ret;
-               } else {
-                   // extJS needs unique IDs but we only want to show the volumes key from "vmid:key"
-                   return value.split(':')[1] + " - " + record.data.name;
-               }
-           },
-           dataIndex: 'id',
-           flex: 6,
+       formulas: {
+           poolMode: (get) => get('selMode') === 'pool',
+           disableVMSelection: (get) => get('selMode') !== 'include' && get('selMode') !== 'exclude',
        },
-       {
-           text: gettext('Type'),
-           dataIndex: 'type',
-           flex: 1,
-       },
-       {
-           text: gettext('Backup Job'),
-           renderer: PVE.Utils.render_backup_status,
-           dataIndex: 'included',
-           flex: 3,
-       },
-    ],
-
-    reload: function() {
-       let me = this;
-       let sm = me.getSelectionModel();
-
-       Proxmox.Utils.API2Request({
-           url: `/cluster/backup/${me.jobid}/included_volumes`,
-           waitMsgTarget: me,
-           method: 'GET',
-           failure: function(response, opts) {
-               Proxmox.Utils.setErrorMask(me, response.htmlStatus);
-           },
-           success: function(response, opts) {
-               sm.deselectAll();
-               me.setRootNode(response.result.data);
-               me.expandAll();
-           },
-       });
     },
 
-    initComponent: function() {
-       var me = this;
-
-       if (!me.jobid) {
-           throw "no job id specified";
-       }
-
-       var sm = Ext.create('Ext.selection.TreeModel', {});
-
-       Ext.apply(me, {
-           selModel: sm,
-           fields: ['id', 'type',
+    items: [
+       {
+           xtype: 'tabpanel',
+           region: 'center',
+           layout: 'fit',
+           bodyPadding: 10,
+           items: [
                {
-                   type: 'string',
-                   name: 'iconCls',
-                   calculate: function(data) {
-                       var txt = 'fa x-fa-tree fa-';
-                       if (data.leaf && !data.type) {
-                           return txt + 'hdd-o';
-                       } else if (data.type === 'qemu') {
-                           return txt + 'desktop';
-                       } else if (data.type === 'lxc') {
-                           return txt + 'cube';
-                       } else {
-                           return txt + 'question-circle';
-                       }
+                   xtype: 'container',
+                   title: gettext('General'),
+                   region: 'center',
+                   layout: {
+                       type: 'vbox',
+                       align: 'stretch',
                    },
-               },
-           ],
-           header: {
-               items: [{
-                   xtype: 'textfield',
-                   fieldLabel: gettext('Search'),
-                   labelWidth: 50,
-                   emptyText: 'Name, VMID, Type',
-                   width: 200,
-                   padding: '0 5 0 0',
-                   enableKeyEvents: true,
-                   listeners: {
-                       buffer: 500,
-                       keyup: function(field) {
-                           let searchValue = field.getValue().toLowerCase();
-                           me.store.clearFilter(true);
-                           me.store.filterBy(function(record) {
-                               let data = {};
-                               if (record.data.depth === 0) {
-                                   return true;
-                               } else if (record.data.depth === 1) {
-                                   data = record.data;
-                               } else if (record.data.depth === 2) {
-                                   data = record.parentNode.data;
-                               }
-
-                               for (const property of ['name', 'id', 'type']) {
-                                   if (!data[property]) {
-                                       continue;
-                                   }
-                                   let v = data[property].toString();
-                                   if (v !== undefined) {
-                                       v = v.toLowerCase();
-                                       if (v.includes(searchValue)) {
-                                           return true;
-                                       }
-                                   }
-                               }
-                               return false;
-                           });
+                   items: [
+                       {
+                           xtype: 'inputpanel',
+                           onlineHelp: 'chapter_vzdump',
+                           column1: [
+                               {
+                                   xtype: 'pveNodeSelector',
+                                   name: 'node',
+                                   fieldLabel: gettext('Node'),
+                                   allowBlank: true,
+                                   editable: true,
+                                   autoSelect: false,
+                                   emptyText: '-- ' + gettext('All') + ' --',
+                                   listeners: {
+                                       change: 'nodeChange',
+                                   },
+                               },
+                               {
+                                   xtype: 'pveStorageSelector',
+                                   reference: 'storageSelector',
+                                   fieldLabel: gettext('Storage'),
+                                   clusterView: true,
+                                   storageContent: 'backup',
+                                   allowBlank: false,
+                                   name: 'storage',
+                                   listeners: {
+                                       change: 'storageChange',
+                                   },
+                               },
+                               {
+                                   xtype: 'pveCalendarEvent',
+                                   fieldLabel: gettext('Schedule'),
+                                   allowBlank: false,
+                                   name: 'schedule',
+                               },
+                               {
+                                   xtype: 'proxmoxKVComboBox',
+                                   reference: 'modeSelector',
+                                   comboItems: [
+                                       ['include', gettext('Include selected VMs')],
+                                       ['all', gettext('All')],
+                                       ['exclude', gettext('Exclude selected VMs')],
+                                       ['pool', gettext('Pool based')],
+                                   ],
+                                   fieldLabel: gettext('Selection mode'),
+                                   name: 'selMode',
+                                   value: '',
+                                   bind: {
+                                       value: '{selMode}',
+                                   },
+                                   listeners: {
+                                       change: 'modeChange',
+                                   },
+                               },
+                               {
+                                   xtype: 'pvePoolSelector',
+                                   reference: 'poolSelector',
+                                   fieldLabel: gettext('Pool to backup'),
+                                   hidden: true,
+                                   allowBlank: false,
+                                   name: 'pool',
+                                   listeners: {
+                                       change: 'selectPoolMembers',
+                                   },
+                                   bind: {
+                                       hidden: '{!poolMode}',
+                                       disabled: '{!poolMode}',
+                                   },
+                               },
+                           ],
+                           column2: [
+                               {
+                                   xtype: 'textfield',
+                                   fieldLabel: gettext('Send email to'),
+                                   name: 'mailto',
+                               },
+                               {
+                                   xtype: 'pveEmailNotificationSelector',
+                                   fieldLabel: gettext('Email'),
+                                   name: 'mailnotification',
+                                   cbind: {
+                                       value: (get) => get('isCreate') ? 'always' : '',
+                                       deleteEmpty: '{!isCreate}',
+                                   },
+                               },
+                               {
+                                   xtype: 'pveCompressionSelector',
+                                   reference: 'compressionSelector',
+                                   fieldLabel: gettext('Compression'),
+                                   name: 'compress',
+                                   cbind: {
+                                       deleteEmpty: '{!isCreate}',
+                                   },
+                                   value: 'zstd',
+                               },
+                               {
+                                   xtype: 'pveBackupModeSelector',
+                                   fieldLabel: gettext('Mode'),
+                                   value: 'snapshot',
+                                   name: 'mode',
+                               },
+                               {
+                                   xtype: 'proxmoxcheckbox',
+                                   fieldLabel: gettext('Enable'),
+                                   name: 'enabled',
+                                   uncheckedValue: 0,
+                                   defaultValue: 1,
+                                   checked: true,
+                               },
+                           ],
+                           columnB: [
+                               {
+                                   xtype: 'proxmoxtextfield',
+                                   name: 'comment',
+                                   fieldLabel: gettext('Job Comment'),
+                                   cbind: {
+                                       deleteEmpty: '{!isCreate}',
+                                   },
+                                   autoEl: {
+                                       tag: 'div',
+                                       'data-qtip': gettext('Description of the job'),
+                                   },
+                               },
+                               {
+                                   xtype: 'vmselector',
+                                   reference: 'vmgrid',
+                                   height: 300,
+                                   name: 'vmid',
+                                   disabled: true,
+                                   allowBlank: false,
+                                   columnSelection: ['vmid', 'node', 'status', 'name', 'type'],
+                                   bind: {
+                                       disabled: '{disableVMSelection}',
+                                   },
+                               },
+                           ],
+                           advancedColumn1: [
+                               {
+                                   xtype: 'proxmoxcheckbox',
+                                   fieldLabel: gettext('Repeat missed'),
+                                   name: 'repeat-missed',
+                                   uncheckedValue: 0,
+                                   defaultValue: 0,
+                                   cbind: {
+                                       deleteDefaultValue: '{!isCreate}',
+                                   },
+                               },
+                           ],
+                           onGetValues: function(values) {
+                               return this.up('window').getController().onGetValues(values);
+                           },
                        },
+                   ],
+               },
+               {
+                   xtype: 'pveBackupJobPrunePanel',
+                   title: gettext('Retention'),
+                   cbind: {
+                       isCreate: '{isCreate}',
                    },
-               }],
-           },
-       });
-
-       me.callParent();
-
-       me.reload();
-    },
-});
-
-Ext.define('PVE.dc.BackupInfo', {
-    extend: 'Proxmox.panel.InputPanel',
-    alias: 'widget.pveBackupInfo',
-
-    padding: '5 0 5 10',
-
-    column1: [
-       {
-           name: 'node',
-           fieldLabel: gettext('Node'),
-           xtype: 'displayfield',
-           renderer: function(value) {
-               if (!value) {
-                   return '-- ' + gettext('All') + ' --';
-               } else {
-                   return value;
-               }
-           },
-       },
-       {
-           name: 'storage',
-           fieldLabel: gettext('Storage'),
-           xtype: 'displayfield',
-       },
-       {
-           name: 'dow',
-           fieldLabel: gettext('Day of week'),
-           xtype: 'displayfield',
-           renderer: PVE.Utils.render_backup_days_of_week,
-       },
-       {
-           name: 'starttime',
-           fieldLabel: gettext('Start Time'),
-           xtype: 'displayfield',
-       },
-       {
-           name: 'selMode',
-           fieldLabel: gettext('Selection mode'),
-           xtype: 'displayfield',
-       },
-       {
-           name: 'pool',
-           fieldLabel: gettext('Pool to backup'),
-           xtype: 'displayfield',
-       },
-    ],
-    column2: [
-       {
-           name: 'mailto',
-           fieldLabel: gettext('Send email to'),
-           xtype: 'displayfield',
-       },
-       {
-           name: 'mailnotification',
-           fieldLabel: gettext('Email notification'),
-           xtype: 'displayfield',
-           renderer: function(value) {
-               let msg;
-               switch (value) {
-                   case 'always':
-                       msg = gettext('Always');
-                       break;
-                   case 'failure':
-                       msg = gettext('On failure only');
-                       break;
-               }
-               return msg;
-           },
-       },
-       {
-           name: 'compress',
-           fieldLabel: gettext('Compression'),
-           xtype: 'displayfield',
-       },
-       {
-           name: 'mode',
-           fieldLabel: gettext('Mode'),
-           xtype: 'displayfield',
-           renderer: function(value) {
-               let msg;
-               switch (value) {
-                   case 'snapshot':
-                       msg = gettext('Snapshot');
-                       break;
-                   case 'suspend':
-                       msg = gettext('Suspend');
-                       break;
-                   case 'stop':
-                       msg = gettext('Stop');
-                       break;
-               }
-               return msg;
-           },
-       },
-       {
-           name: 'enabled',
-           fieldLabel: gettext('Enabled'),
-           xtype: 'displayfield',
-           renderer: function(value) {
-               if (PVE.Parser.parseBoolean(value.toString())) {
-                   return gettext('Yes');
-               } else {
-                   return gettext('No');
-               }
-           },
-       },
-    ],
-
-    setValues: function(values) {
-       var me = this;
-
-        Ext.iterate(values, function(fieldId, val) {
-           let field = me.query('[isFormField][name=' + fieldId + ']')[0];
-           if (field) {
-               field.setValue(val);
-            }
-       });
-
-       // selection Mode depends on the presence/absence of several keys
-       let selModeField = me.query('[isFormField][name=selMode]')[0];
-       let selMode = 'none';
-       if (values.vmid) {
-           selMode = gettext('Include selected VMs');
-       }
-       if (values.all) {
-           selMode = gettext('All');
-       }
-       if (values.exclude) {
-            selMode = gettext('Exclude selected VMs');
-       }
-       if (values.pool) {
-           selMode = gettext('Pool based');
-       }
-       selModeField.setValue(selMode);
-
-       if (!values.pool) {
-           let poolField = me.query('[isFormField][name=pool]')[0];
-           poolField.setVisible(0);
-       }
-    },
-
-    initComponent: function() {
-       var me = this;
-
-       if (!me.record) {
-           throw "no data provided";
-       }
-       me.callParent();
-
-       me.setValues(me.record);
-    },
-});
-
-
-Ext.define('PVE.dc.BackedGuests', {
-    extend: 'Ext.grid.GridPanel',
-    alias: 'widget.pveBackedGuests',
-
-    textfilter: '',
-
-    columns: [
-       {
-           header: gettext('Type'),
-           dataIndex: "type",
-           renderer: PVE.Utils.render_resource_type,
-           flex: 1,
-           sortable: true,
-       },
-       {
-           header: gettext('VMID'),
-           dataIndex: 'vmid',
-           flex: 1,
-           sortable: true,
-       },
-       {
-           header: gettext('Name'),
-           dataIndex: 'name',
-           flex: 2,
-           sortable: true,
-       },
-    ],
-
-    initComponent: function() {
-       let me = this;
-
-       me.store.clearFilter(true);
-
-       Ext.apply(me, {
-           stateful: true,
-           stateId: 'grid-dc-backed-guests',
-           tbar: [
-               '->',
-               gettext('Search') + ':', ' ',
+                   keepAllDefaultForCreate: false,
+                   showPBSHint: false,
+                   fallbackHintHtml: gettext('Without any keep option, the storage\'s configuration or node\'s vzdump.conf is used as fallback'),
+               },
                {
-                   xtype: 'textfield',
-                   width: 200,
-                   emptyText: 'Name, VMID, Type',
-                   enableKeyEvents: true,
-                   listeners: {
-                       buffer: 500,
-                       keyup: function(field) {
-                           let searchValue = field.getValue().toLowerCase();
-                           me.store.clearFilter(true);
-                           me.store.filterBy(function(record) {
-                               let data = record.data;
-                               for (const property in ['name', 'id', 'type']) {
-                                   if (data[property] === null) {
-                                       continue;
-                                   }
-                                   let v = data[property].toString();
-                                   if (v !== undefined) {
-                                       v = v.toLowerCase();
-                                       if (v.includes(searchValue)) {
-                                           return true;
-                                       }
-                                   }
-                               }
-                               return false;
-                           });
-                       },
+                   xtype: 'inputpanel',
+                   title: gettext('Note Template'),
+                   region: 'center',
+                   layout: {
+                       type: 'vbox',
+                       align: 'stretch',
+                   },
+                   onGetValues: function(values) {
+                       if (values['notes-template']) {
+                           values['notes-template'] =
+                               PVE.Utils.escapeNotesTemplate(values['notes-template']);
+                       }
+                       return values;
                    },
+                   items: [
+                       {
+                           xtype: 'textarea',
+                           name: 'notes-template',
+                           fieldLabel: gettext('Backup Notes'),
+                           height: 100,
+                           maxLength: 512,
+                           cbind: {
+                               deleteEmpty: '{!isCreate}',
+                               value: (get) => get('isCreate') ? '{{guestname}}' : undefined,
+                           },
+                       },
+                       {
+                           xtype: 'box',
+                           style: {
+                               margin: '8px 0px',
+                               'line-height': '1.5em',
+                           },
+                           html: gettext('The notes are added to each backup created by this job.')
+                               + '<br>'
+                               + Ext.String.format(
+                                   gettext('Possible template variables are: {0}'),
+                                   PVE.Utils.notesTemplateVars.map(v => `<code>{{${v}}}</code>`).join(', '),
+                               ),
+                       },
+                   ],
                },
            ],
-           viewConfig: {
-               stripeRows: true,
-               trackOver: false,
-            },
-       });
-       me.callParent();
-    },
+       },
+    ],
 });
 
 Ext.define('PVE.dc.BackupView', {
@@ -845,14 +450,11 @@ Ext.define('PVE.dc.BackupView', {
            },
        });
 
-       let noBackupJobWarning, noBackupJobInfoButton;
+       let noBackupJobInfoButton;
        let reload = function() {
            store.load();
            not_backed_store.load({
-               callback: function(records, operation, success) {
-                   noBackupJobWarning.setVisible(records.length > 0);
-                   noBackupJobInfoButton.setVisible(records.length > 0);
-               },
+               callback: records => noBackupJobInfoButton.setVisible(records.length > 0),
            });
        };
 
@@ -879,9 +481,7 @@ Ext.define('PVE.dc.BackupView', {
            Ext.create('Ext.window.Window', {
                modal: true,
                width: 800,
-               height: 600,
-               stateful: true,
-               stateId: 'backup-detail-view',
+               height: Ext.getBody().getViewSize().height > 1000 ? 800 : 600, // factor out as common infra?
                resizable: true,
                layout: 'fit',
                title: gettext('Backup Details'),
@@ -921,12 +521,19 @@ Ext.define('PVE.dc.BackupView', {
            delete job.starttime;
            delete job.dow;
            delete job.id;
+           delete job.schedule;
+           delete job.type;
            delete job.node;
+           delete job.comment;
+           delete job['next-run'];
+           delete job['repeat-missed'];
            job.all = job.all === true ? 1 : 0;
 
-           if (job['prune-backups']) {
-               job['prune-backups'] = PVE.Parser.printPropertyString(job['prune-backups']);
-           }
+           ['performance', 'prune-backups'].forEach(key => {
+               if (job[key]) {
+                   job[key] = PVE.Parser.printPropertyString(job[key]);
+               }
+           });
 
            let allNodes = PVE.data.ResourceStore.getNodes();
            let nodes = allNodes.filter(node => node.status === 'online').map(node => node.node);
@@ -975,35 +582,6 @@ Ext.define('PVE.dc.BackupView', {
            }));
        };
 
-       let run_show_not_backed = function() {
-           Ext.create('Ext.window.Window', {
-               modal: true,
-               width: 600,
-               height: 500,
-               resizable: true,
-               layout: 'fit',
-               title: gettext('Guests without backup job'),
-               items: [
-                   {
-                       xtype: 'panel',
-                       region: 'center',
-                       layout: {
-                           type: 'vbox',
-                           align: 'stretch',
-                       },
-                       items: [
-                           {
-                               xtype: 'pveBackedGuests',
-                               flex: 1,
-                               layout: 'fit',
-                               store: not_backed_store,
-                           },
-                       ],
-                   },
-               ],
-           }).show();
-       };
-
        var edit_btn = new Proxmox.button.Button({
            text: gettext('Edit'),
            disabled: true,
@@ -1052,15 +630,40 @@ Ext.define('PVE.dc.BackupView', {
            handler: run_detail,
        });
 
-       noBackupJobWarning = Ext.create('Ext.toolbar.TextItem', {
-           html: '<i class="fa fa-fw fa-exclamation-circle"></i>' + gettext('Some guests are not covered by any backup job.'),
-           hidden: true,
-       });
-
        noBackupJobInfoButton = new Proxmox.button.Button({
-           text: gettext('Show'),
+           text: `${gettext('Show')}: ${gettext('Guests Without Backup Job')}`,
+           tooltip: gettext('Some guests are not covered by any backup job.'),
+           iconCls: 'fa fa-fw fa-exclamation-circle',
            hidden: true,
-           handler: run_show_not_backed,
+           handler: () => {
+               Ext.create('Ext.window.Window', {
+                   autoShow: true,
+                   modal: true,
+                   width: 600,
+                   height: 500,
+                   resizable: true,
+                   layout: 'fit',
+                   title: gettext('Guests Without Backup Job'),
+                   items: [
+                       {
+                           xtype: 'panel',
+                           region: 'center',
+                           layout: {
+                               type: 'vbox',
+                               align: 'stretch',
+                           },
+                           items: [
+                               {
+                                   xtype: 'pveBackedGuests',
+                                   flex: 1,
+                                   layout: 'fit',
+                                   store: not_backed_store,
+                               },
+                           ],
+                       },
+                   ],
+               });
+           },
        });
 
        Proxmox.Utils.monStoreErrors(me, store);
@@ -1073,35 +676,60 @@ Ext.define('PVE.dc.BackupView', {
            viewConfig: {
                trackOver: false,
            },
-           tbar: [
-               {
-                   text: gettext('Add'),
-                   handler: function() {
-                       var win = Ext.create('PVE.dc.BackupEdit', {});
-                       win.on('destroy', reload);
-                       win.show();
+           dockedItems: [{
+               xtype: 'toolbar',
+               overflowHandler: 'scroller',
+               dock: 'top',
+               items: [
+                   {
+                       text: gettext('Add'),
+                       handler: function() {
+                           var win = Ext.create('PVE.dc.BackupEdit', {});
+                           win.on('destroy', reload);
+                           win.show();
+                       },
                    },
-               },
-               '-',
-               remove_btn,
-               edit_btn,
-               detail_btn,
-               '-',
-               run_btn,
-               '->',
-               noBackupJobWarning,
-               noBackupJobInfoButton,
-           ],
+                   '-',
+                   remove_btn,
+                   edit_btn,
+                   detail_btn,
+                   '-',
+                   run_btn,
+                   '->',
+                   noBackupJobInfoButton,
+                   '-',
+                   {
+                       xtype: 'proxmoxButton',
+                       selModel: null,
+                       text: gettext('Schedule Simulator'),
+                       handler: () => {
+                           let record = sm.getSelection()[0];
+                           let schedule;
+                           if (record) {
+                               schedule = record.data.schedule;
+                           }
+                           Ext.create('PVE.window.ScheduleSimulator', {
+                               autoShow: true,
+                               schedule,
+                           });
+                       },
+                   },
+               ],
+           }],
            columns: [
                {
                    header: gettext('Enabled'),
                    width: 80,
                    dataIndex: 'enabled',
-                   xtype: 'checkcolumn',
+                   align: 'center',
+                   // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
+                   renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
                    sortable: true,
-                   disabled: true,
-                   disabledCls: 'x-item-enabled',
-                   stopSelection: false,
+               },
+               {
+                   header: gettext('ID'),
+                   dataIndex: 'id',
+                   hidden: true,
                },
                {
                    header: gettext('Node'),
@@ -1116,17 +744,15 @@ Ext.define('PVE.dc.BackupView', {
                    },
                },
                {
-                   header: gettext('Day of week'),
-                   width: 200,
-                   sortable: false,
-                   dataIndex: 'dow',
-                   renderer: PVE.Utils.render_backup_days_of_week,
+                   header: gettext('Schedule'),
+                   width: 150,
+                   dataIndex: 'schedule',
                },
                {
-                   header: gettext('Start Time'),
-                   width: 60,
-                   sortable: true,
-                   dataIndex: 'starttime',
+                   text: gettext('Next Run'),
+                   dataIndex: 'next-run',
+                   width: 150,
+                   renderer: PVE.Utils.render_next_event,
                },
                {
                    header: gettext('Storage'),
@@ -1135,8 +761,21 @@ Ext.define('PVE.dc.BackupView', {
                    dataIndex: 'storage',
                },
                {
-                   header: gettext('Selection'),
+                   header: gettext('Comment'),
+                   dataIndex: 'comment',
+                   renderer: Ext.htmlEncode,
+                   sorter: (a, b) => (a.data.comment || '').localeCompare(b.data.comment || ''),
                    flex: 1,
+               },
+               {
+                   header: gettext('Retention'),
+                   dataIndex: 'prune-backups',
+                   renderer: v => v ? PVE.Parser.printPropertyString(v) : gettext('Fallback from storage config'),
+                   flex: 2,
+               },
+               {
+                   header: gettext('Selection'),
+                   flex: 4,
                    sortable: false,
                    dataIndex: 'vmid',
                    renderer: PVE.Utils.render_backup_selection,
@@ -1162,6 +801,7 @@ Ext.define('PVE.dc.BackupView', {
            'mode',
            'node',
            'pool',
+           'prune-backups',
            'starttime',
            'storage',
            'vmid',