]> git.proxmox.com Git - pve-manager.git/blobdiff - www/manager6/dc/BackupJobDetail.js
ui: ldap: add 'Check connection' checkbox as advanced option
[pve-manager.git] / www / manager6 / dc / BackupJobDetail.js
index a1e10614d7be0329e63632e27873eea294f7d59c..880784a2321fbb650662f50717a49e42ab3b8917 100644 (file)
@@ -198,11 +198,6 @@ Ext.define('PVE.dc.BackupInfo', {
            name: 'selMode',
            fieldLabel: gettext('Selection mode'),
        },
-       {
-           xtype: 'displayfield',
-           name: 'pool',
-           fieldLabel: gettext('Pool to backup'),
-       },
     ],
     column2: [
        {
@@ -242,6 +237,11 @@ Ext.define('PVE.dc.BackupInfo', {
            fieldLabel: gettext('Enabled'),
            renderer: v => PVE.Parser.parseBoolean(v.toString()) ? gettext('Yes') : gettext('No'),
        },
+       {
+           xtype: 'displayfield',
+           name: 'pool',
+           fieldLabel: gettext('Pool to backup'),
+       },
     ],
 
     columnB: [
@@ -249,23 +249,21 @@ Ext.define('PVE.dc.BackupInfo', {
            xtype: 'displayfield',
            name: 'comment',
            fieldLabel: gettext('Comment'),
+           renderer: Ext.String.htmlEncode,
        },
        {
-           xtype: 'label',
-           name: 'pruneLabel',
-           text: gettext('Retention Configuration') + ':',
-           bind: {
-               hidden: '{!hasRetention}',
-           },
-       },
-       {
+           xtype: 'fieldset',
+           title: gettext('Retention Configuration'),
            layout: 'hbox',
-           border: false,
+           collapsible: true,
            defaults: {
                border: false,
                layout: 'anchor',
                flex: 1,
            },
+           bind: {
+               hidden: '{!hasRetention}',
+           },
            items: [
                {
                    padding: '0 10 0 0',
@@ -463,7 +461,7 @@ Ext.define('PVE.dc.BackedGuests', {
                            me.store.clearFilter(true);
                            me.store.filterBy(function(record) {
                                let data = record.data;
-                               for (const property in ['name', 'id', 'type']) {
+                               for (const property of ['name', 'vmid', 'type']) {
                                    if (data[property] === null) {
                                        continue;
                                    }