ui: firewall: refactor privilege checks and prevent double click

[pve-manager.git] / www / manager6 / grid / FirewallRules.js

diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
index 6b3abb1ba14a23edd1605b54213a34fcc3c3884d..18075eaa60ae53e607c740030d68f1f13e510ed8 100644 (file)
--- a/www/manager6/grid/FirewallRules.js
+++ b/www/manager6/grid/FirewallRules.js
@@ -569,7 +569,7 @@ Ext.define('PVE.FirewallRules', {
            }
            me.store.removeAll();
        } else {
-           if (me.caps.vms['VM.Config.Network'] || me.caps.dc['Sys.Modify'] || me.caps.nodes['Sys.Modify']) {
+           if (me.canEdit) {
                me.addBtn.setDisabled(false);
                if (me.groupBtn) {
                    me.groupBtn.setDisabled(false);
@@ -653,10 +653,11 @@ Ext.define('PVE.FirewallRules', {
        var sm = Ext.create('Ext.selection.RowModel', {});
 
        me.caps = Ext.state.Manager.get('GuiCap');
+       me.canEdit = !!me.caps.vms['VM.Config.Network'] || !!me.caps.dc['Sys.Modify'] || !!me.caps.nodes['Sys.Modify'];
 
        var run_editor = function() {
            var rec = sm.getSelection()[0];
-           if (!rec) {
+           if (!rec || !me.canEdit) {
                return;
            }
            var type = rec.data.type;
@@ -685,7 +686,7 @@ Ext.define('PVE.FirewallRules', {
        me.editBtn = Ext.create('Proxmox.button.Button', {
            text: gettext('Edit'),
            disabled: true,
-           enableFn: rec => !!me.caps.vms['VM.Config.Network'] || !!me.caps.dc['Sys.Modify'] || !!me.caps.nodes['Sys.Modify'],
+           enableFn: rec => me.canEdit,
            selModel: sm,
            handler: run_editor,
        });
@@ -727,7 +728,7 @@ Ext.define('PVE.FirewallRules', {
        me.copyBtn = Ext.create('Proxmox.button.Button', {
            text: gettext('Copy'),
            selModel: sm,
-           enableFn: ({ data }) => (data.type === 'in' || data.type === 'out') && (!!me.caps.vms['VM.Config.Network'] || !!me.caps.dc['Sys.Modify'] || !!me.caps.nodes['Sys.Modify']),
+           enableFn: ({ data }) => (data.type === 'in' || data.type === 'out') && me.canEdit,
            disabled: true,
            handler: run_copy_editor,
        });
@@ -749,7 +750,7 @@ Ext.define('PVE.FirewallRules', {
        }
 
        me.removeBtn = Ext.create('Proxmox.button.StdRemoveButton', {
-           enableFn: rec => !!me.caps.vms['VM.Config.Network'] || !!me.caps.dc['Sys.Modify'] || !!me.caps.nodes['Sys.Modify'],
+           enableFn: rec => me.canEdit,
            selModel: sm,
            baseurl: me.base_url + '/',
            confirmMsg: false,