ui: qemu/HardwareView: eslint: enforce "no-shadow" rule

[pve-manager.git] / www / manager6 / qemu / HardwareView.js

diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
index 5440a04974341fd829ee2e85560cbe2ea9a6513d..134983de96685cf48ef87ac549dc1296b5b46240 100644 (file)
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu/HardwareView.js
@@ -10,7 +10,7 @@ Ext.define('PVE.qemu.HardwareView', {
        var rowdef = rows[key] || {};
        var iconCls = rowdef.iconCls;
        var icon = '';
-       var txt = (rowdef.header || key);
+       var txt = rowdef.header || key;
 
        metaData.tdAttr = "valign=middle";
 
@@ -45,7 +45,6 @@ Ext.define('PVE.qemu.HardwareView', {
 
     initComponent: function() {
        var me = this;
-       var i, confid;
 
        var nodename = me.pveSelNode.data.node;
        if (!nodename) {
@@ -93,7 +92,7 @@ Ext.define('PVE.qemu.HardwareView', {
            sockets: {
                header: gettext('Processors'),
                never_delete: true,
-               editor: (caps.vms['VM.Config.CPU'] || caps.vms['VM.Config.HWType'])
+               editor: caps.vms['VM.Config.CPU'] || caps.vms['VM.Config.HWType']
                    ? 'PVE.qemu.ProcessorEdit' : undefined,
                tdCls: 'pve-itype-icon-processor',
                group: 3,
@@ -167,7 +166,7 @@ Ext.define('PVE.qemu.HardwareView', {
                            ['__default__', PVE.Utils.render_qemu_machine('')],
                            ['q35', 'q35'],
                        ],
-                   }]
+                   }],
 } : undefined,
                iconCls: 'cogs',
                never_delete: true,
@@ -220,7 +219,7 @@ Ext.define('PVE.qemu.HardwareView', {
        };
 
        PVE.Utils.forEachBus(undefined, function(type, id) {
-           var confid = type + id;
+           let confid = type + id;
            rows[confid] = {
                group: 10,
                iconCls: 'hdd-o',
@@ -232,8 +231,8 @@ Ext.define('PVE.qemu.HardwareView', {
                cloudheader: gettext('CloudInit Drive') + ' (' + confid + ')',
            };
        });
-       for (i = 0; i < PVE.Utils.hardware_counts.net; i++) {
-           confid = "net" + i.toString();
+       for (let i = 0; i < PVE.Utils.hardware_counts.net; i++) {
+           let confid = "net" + i.toString();
            rows[confid] = {
                group: 15,
                order: i,
@@ -250,8 +249,8 @@ Ext.define('PVE.qemu.HardwareView', {
            never_delete: !caps.vms['VM.Config.Disk'],
            header: gettext('EFI Disk'),
        };
-       for (i = 0; i < PVE.Utils.hardware_counts.usb; i++) {
-           confid = "usb" + i.toString();
+       for (let i = 0; i < PVE.Utils.hardware_counts.usb; i++) {
+           let confid = "usb" + i.toString();
            rows[confid] = {
                group: 25,
                order: i,
@@ -261,8 +260,8 @@ Ext.define('PVE.qemu.HardwareView', {
                header: gettext('USB Device') + ' (' + confid + ')',
            };
        }
-       for (i = 0; i < PVE.Utils.hardware_counts.hostpci; i++) {
-           confid = "hostpci" + i.toString();
+       for (let i = 0; i < PVE.Utils.hardware_counts.hostpci; i++) {
+           let confid = "hostpci" + i.toString();
            rows[confid] = {
                group: 30,
                order: i,
@@ -272,8 +271,8 @@ Ext.define('PVE.qemu.HardwareView', {
                header: gettext('PCI Device') + ' (' + confid + ')',
            };
        }
-       for (i = 0; i < PVE.Utils.hardware_counts.serial; i++) {
-           confid = "serial" + i.toString();
+       for (let i = 0; i < PVE.Utils.hardware_counts.serial; i++) {
+           let confid = "serial" + i.toString();
            rows[confid] = {
                group: 35,
                order: i,
@@ -289,7 +288,7 @@ Ext.define('PVE.qemu.HardwareView', {
            never_delete: !caps.vms['VM.Config.HWType'],
            header: gettext('Audio Device'),
        };
-       for (i = 0; i < 256; i++) {
+       for (let i = 0; i < 256; i++) {
            rows["unused" + i.toString()] = {
                group: 99,
                order: i,
@@ -315,11 +314,11 @@ Ext.define('PVE.qemu.HardwareView', {
            var order1 = rows[v1].order || 0;
            var order2 = rows[v2].order || 0;
 
-           if ((g1 - g2) !== 0) {
+           if (g1 - g2 !== 0) {
                return g1 - g2;
            }
 
-           if ((order1 - order2) !== 0) {
+           if (order1 - order2 !== 0) {
                return order1 - order2;
            }
 
@@ -528,11 +527,11 @@ Ext.define('PVE.qemu.HardwareView', {
        });
 
        let counts = {};
-       let isAtLimit = (type) => (counts[type] >= PVE.Utils.hardware_counts[type]);
+       let isAtLimit = (type) => counts[type] >= PVE.Utils.hardware_counts[type];
 
        var set_button_status = function() {
-           var sm = me.getSelectionModel();
-           var rec = sm.getSelection()[0];
+           var selection_model = me.getSelectionModel();
+           var rec = selection_model.getSelection()[0];
 
            // en/disable hardwarebuttons
            counts = {};
@@ -558,9 +557,10 @@ Ext.define('PVE.qemu.HardwareView', {
            });
 
            // heuristic only for disabling some stuff, the backend has the final word.
-           var noSysConsolePerm = !caps.nodes['Sys.Console'];
-           var noVMConfigHWTypePerm = !caps.vms['VM.Config.HWType'];
-           var noVMConfigNetPerm = !caps.vms['VM.Config.Network'];
+           const noSysConsolePerm = !caps.nodes['Sys.Console'];
+           const noVMConfigHWTypePerm = !caps.vms['VM.Config.HWType'];
+           const noVMConfigNetPerm = !caps.vms['VM.Config.Network'];
+           const noVMConfigDiskPerm = !caps.vms['VM.Config.Disk'];
 
 
            me.down('#addusb').setDisabled(noSysConsolePerm || isAtLimit('usb'));
@@ -569,7 +569,7 @@ Ext.define('PVE.qemu.HardwareView', {
            me.down('#addserial').setDisabled(noVMConfigHWTypePerm || isAtLimit('serial'));
            me.down('#addnet').setDisabled(noVMConfigNetPerm || isAtLimit('net'));
            me.down('#addrng').setDisabled(noSysConsolePerm || isAtLimit('rng'));
-           efidisk_menuitem.setDisabled(isAtLimit('efidisk'));
+           efidisk_menuitem.setDisabled(noVMConfigDiskPerm || isAtLimit('efidisk'));
            me.down('#addci').setDisabled(noSysConsolePerm || hasCloudInit);
 
            if (!rec) {
@@ -584,20 +584,22 @@ Ext.define('PVE.qemu.HardwareView', {
            var value = rec.data.value;
            var rowdef = rows[key];
 
-           var pending = rec.data['delete'] || me.hasPendingChanges(key);
-           var isCDRom = (value && !!value.toString().match(/media=cdrom/));
+           var pending = rec.data.delete || me.hasPendingChanges(key);
+           var isCDRom = value && !!value.toString().match(/media=cdrom/);
            var isUnusedDisk = key.match(/^unused\d+/);
            var isUsedDisk = !isUnusedDisk && rowdef.isOnStorageBus && !isCDRom;
 
-           var isCloudInit = (value && value.toString().match(/vm-.*-cloudinit/));
+           var isCloudInit = value && value.toString().match(/vm-.*-cloudinit/);
 
-           var isEfi = (key === 'efidisk0');
+           var isEfi = key === 'efidisk0';
 
-           remove_btn.setDisabled(rec.data['delete'] || (rowdef.never_delete === true) || (isUnusedDisk && !diskCap));
-           remove_btn.setText((isUsedDisk && !isCloudInit) ? remove_btn.altText : remove_btn.defaultText);
+           remove_btn.setDisabled(
+               rec.data.delete || rowdef.never_delete === true || (isUnusedDisk && !diskCap),
+           );
+           remove_btn.setText(isUsedDisk && !isCloudInit ? remove_btn.altText : remove_btn.defaultText);
            remove_btn.RESTMethod = isUnusedDisk ? 'POST':'PUT';
 
-           edit_btn.setDisabled(rec.data['delete'] || !rowdef.editor || isCloudInit || (!isCDRom && !diskCap));
+           edit_btn.setDisabled(rec.data.delete || !rowdef.editor || isCloudInit || (!isCDRom && !diskCap));
 
            resize_btn.setDisabled(pending || !isUsedDisk || !diskCap);
 
@@ -607,7 +609,7 @@ Ext.define('PVE.qemu.HardwareView', {
        };
 
        Ext.apply(me, {
-           url: '/api2/json/' + 'nodes/' + nodename + '/qemu/' + vmid + '/pending',
+           url: `/api2/json/nodes/${nodename}/qemu/${vmid}/pending`,
            interval: 5000,
            selModel: sm,
            run_editor: run_editor,