ui: eslint: enforce "no-unneeded-ternary" rule

[pve-manager.git] / www / manager6 / storage / IScsiEdit.js

diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js
index b673bc3ab6df003f95f8703d4d3931dd39c1b57a..4cb6bec57c81b723722a2e6e59c15c677aa284c7 100644 (file)
--- a/www/manager6/storage/IScsiEdit.js
+++ b/www/manager6/storage/IScsiEdit.js
@@ -8,7 +8,7 @@ Ext.define('PVE.storage.IScsiScan', {
     matchFieldWidth: false,
     listConfig: {
        loadingText: gettext('Scanning...'),
-       width: 350
+       width: 350,
     },
     doRawQuery: function() {
     },
@@ -31,7 +31,7 @@ Ext.define('PVE.storage.IScsiScan', {
        me.portal = portal;
     },
 
-    initComponent : function() {
+    initComponent: function() {
        var me = this;
 
        if (!me.nodename) {
@@ -39,57 +39,46 @@ Ext.define('PVE.storage.IScsiScan', {
        }
 
        var store = Ext.create('Ext.data.Store', {
-           fields: [ 'target', 'portal' ],
+           fields: ['target', 'portal'],
            proxy: {
                type: 'proxmox',
-               url: '/api2/json/nodes/' + me.nodename + '/scan/iscsi'
-           }
+               url: '/api2/json/nodes/' + me.nodename + '/scan/iscsi',
+           },
        });
 
        store.sort('target', 'ASC');
 
        Ext.apply(me, {
-           store: store
+           store: store,
        });
 
        me.callParent();
-    }
+    },
 });
 
 Ext.define('PVE.storage.IScsiInputPanel', {
-    extend: 'Proxmox.panel.InputPanel',
+    extend: 'PVE.panel.StorageBase',
+
+    onlineHelp: 'storage_open_iscsi',
 
     onGetValues: function(values) {
        var me = this;
 
-       if (me.isCreate) {
-           values.type = 'iscsi';
-       } else {
-           delete values.storage;
-       }
-
        values.content = values.luns ? 'images' : 'none';
        delete values.luns;
 
-       values.disable = values.enable ? 0 : 1;
-       delete values.enable;
+       return me.callParent([values]);
+    },
 
-       return values;
+    setValues: function(values) {
+       values.luns = (values.content.indexOf('images') !== -1);
+       this.callParent([values]);
     },
 
-    initComponent : function() {
+    initComponent: function() {
        var me = this;
 
-
        me.column1 = [
-           {
-               xtype: me.isCreate ? 'textfield' : 'displayfield',
-               name: 'storage',
-               value: me.storageId || '',
-               fieldLabel: 'ID',
-               vtype: 'StorageId',
-               allowBlank: false
-           },
            {
                xtype: me.isCreate ? 'textfield' : 'displayfield',
                name: 'portal',
@@ -103,8 +92,8 @@ Ext.define('PVE.storage.IScsiInputPanel', {
                            exportField.setPortal(value);
                            exportField.setValue('');
                        }
-                   }
-               }
+                   },
+               },
            },
            {
                readOnly: !me.isCreate,
@@ -112,86 +101,19 @@ Ext.define('PVE.storage.IScsiInputPanel', {
                name: 'target',
                value: '',
                fieldLabel: 'Target',
-               allowBlank: false
-           }
+               allowBlank: false,
+           },
        ];
 
        me.column2 = [
-           {
-               xtype: 'pveNodeSelector',
-               name: 'nodes',
-               fieldLabel: gettext('Nodes'),
-               emptyText: gettext('All') + ' (' +
-                   gettext('No restrictions') +')',
-               multiSelect: true,
-               autoSelect: false
-           },
-           {
-               xtype: 'proxmoxcheckbox',
-               name: 'enable',
-               checked: true,
-               uncheckedValue: 0,
-               fieldLabel: gettext('Enable')
-           },
            {
                xtype: 'checkbox',
                name: 'luns',
                checked: true,
-               fieldLabel: gettext('Use LUNs directly')
-           }
+               fieldLabel: gettext('Use LUNs directly'),
+           },
        ];
 
        me.callParent();
-    }
-});
-
-Ext.define('PVE.storage.IScsiEdit', {
-    extend: 'Proxmox.window.Edit',
-
-    initComponent : function() {
-       var me = this;
-
-       me.isCreate = !me.storageId;
-
-       if (me.isCreate) {
-            me.url = '/api2/extjs/storage';
-            me.method = 'POST';
-        } else {
-            me.url = '/api2/extjs/storage/' + me.storageId;
-            me.method = 'PUT';
-        }
-
-       var ipanel = Ext.create('PVE.storage.IScsiInputPanel', {
-           isCreate: me.isCreate,
-           storageId: me.storageId
-       });
-
-       Ext.apply(me, {
-            subject: PVE.Utils.format_storage_type('iscsi'),
-           isAdd: true,
-           items: [ ipanel ]
-       });
-
-       me.callParent();
-
-       if (!me.isCreate) {
-           me.load({
-               success:  function(response, options) {
-                   var values = response.result.data;
-                   var ctypes = values.content || '';
-
-                   if (values.storage === 'local') {
-                       values.content = ctypes.split(',');
-                   }
-                   if (values.nodes) {
-                       values.nodes = values.nodes.split(',');
-                   }
-                   values.enable = values.disable ? 0 : 1;
-                   values.luns = (values.content === 'images') ? true : false;
-
-                   ipanel.setValues(values);
-               }
-           });
-       }
-    }
+    },
 });