ui: backup restore: rework to leverage more viewcontroller and cleanup

[pve-manager.git] / www / manager6 / window / FirewallLograteEdit.js

diff --git a/www/manager6/window/FirewallLograteEdit.js b/www/manager6/window/FirewallLograteEdit.js
index 1c4507316ac4deda610e54a969fe412b9f18f279..12fcc3f1fa2b9766863464c03ba33a5fc5ca060c 100644 (file)
--- a/www/manager6/window/FirewallLograteEdit.js
+++ b/www/manager6/window/FirewallLograteEdit.js
@@ -1,4 +1,3 @@
-/*jslint confusion: true*/
 Ext.define('PVE.FirewallLograteInputPanel', {
     extend: 'Proxmox.panel.InputPanel',
     xtype: 'pveFirewallLograteInputPanel',
@@ -11,7 +10,7 @@ Ext.define('PVE.FirewallLograteInputPanel', {
            name: 'enable',
            reference: 'enable',
            fieldLabel: gettext('Enable'),
-           value: false
+           value: true,
        },
        {
            layout: 'hbox',
@@ -25,22 +24,26 @@ Ext.define('PVE.FirewallLograteInputPanel', {
                    maxValue: 99,
                    allowBlank: false,
                    flex: 2,
-                   value: 1
+                   value: 1,
                },
                {
                    xtype: 'box',
-                   html: '<div style="margin: auto; padding: 2.5px;"><b>/</b></div>'
+                   html: '<div style="margin: auto; padding: 2.5px;"><b>/</b></div>',
                },
                {
                    xtype: 'proxmoxKVComboBox',
                    name: 'unit',
-                   comboItems: [['second', 'second'], ['minute', 'minute'],
-                       ['hour', 'hour'], ['day', 'day']],
+                   comboItems: [
+                       ['second', 'second'],
+                       ['minute', 'minute'],
+                       ['hour', 'hour'],
+                       ['day', 'day'],
+                   ],
                    allowBlank: false,
                    flex: 1,
-                   value: 'second'
-               }
-           ]
+                   value: 'second',
+               },
+           ],
        },
        {
            xtype: 'numberfield',
@@ -48,38 +51,41 @@ Ext.define('PVE.FirewallLograteInputPanel', {
            fieldLabel: gettext('Log burst limit'),
            minValue: 1,
            maxValue: 99,
-           value: 5
-       }
+           value: 5,
+       },
     ],
 
     onGetValues: function(values) {
-       var me = this;
+       let me = this;
 
-       var vals = {};
-       vals.enable = values.enable !== undefined ? 1 : 0;
-       vals.rate = values.rate + '/' + values.unit;
-       vals.burst = values.burst;
-       var properties = PVE.Parser.printPropertyString(vals, undefined);
-       if (properties == '') {
+       let cfg = {
+           enable: values.enable !== undefined ? 1 : 0,
+           rate: values.rate + '/' + values.unit,
+           burst: values.burst,
+       };
+       let properties = PVE.Parser.printPropertyString(cfg, undefined);
+       if (properties === '') {
            return { 'delete': 'log_ratelimit' };
        }
        return { log_ratelimit: properties };
     },
 
     setValues: function(values) {
-       var me = this;
+       let me = this;
 
-       var properties = {};
+       let properties = {};
        if (values.log_ratelimit !== undefined) {
-           properties = PVE.Parser.parsePropertyString(values.log_ratelimit);
-           var matches = properties.rate.match(/^(\d+)\/(second|minute|hour|day)$/);
-           if (matches) {
-               properties.rate = matches[1];
-               properties.unit = matches[2];
+           properties = PVE.Parser.parsePropertyString(values.log_ratelimit, 'enable');
+           if (properties.rate) {
+               var matches = properties.rate.match(/^(\d+)\/(second|minute|hour|day)$/);
+               if (matches) {
+                   properties.rate = matches[1];
+                   properties.unit = matches[2];
+               }
            }
        }
        me.callParent([properties]);
-    }
+    },
 });
 
 Ext.define('PVE.FirewallLograteEdit', {
@@ -89,7 +95,7 @@ Ext.define('PVE.FirewallLograteEdit', {
     subject: gettext('Log rate limit'),
 
     items: [{
-       xtype: 'pveFirewallLograteInputPanel'
+       xtype: 'pveFirewallLograteInputPanel',
     }],
-    autoLoad: true
+    autoLoad: true,
 });