]> git.proxmox.com Git - mirror_edk2.git/commitdiff
SecurityPkg: Apply uncrustify changes
authorMichael Kubacki <michael.kubacki@microsoft.com>
Sun, 5 Dec 2021 22:54:12 +0000 (14:54 -0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Tue, 7 Dec 2021 17:24:28 +0000 (17:24 +0000)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737

Apply uncrustify changes to .c/.h files in the SecurityPkg package

Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
185 files changed:
SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.c
SecurityPkg/FvReportPei/FvReportPei.c
SecurityPkg/FvReportPei/FvReportPei.h
SecurityPkg/Hash2DxeCrypto/Driver.c
SecurityPkg/Hash2DxeCrypto/Driver.h
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
SecurityPkg/HddPassword/HddPasswordCommon.h
SecurityPkg/HddPassword/HddPasswordDxe.c
SecurityPkg/HddPassword/HddPasswordDxe.h
SecurityPkg/HddPassword/HddPasswordHiiDataStruc.h
SecurityPkg/HddPassword/HddPasswordPei.c
SecurityPkg/HddPassword/HddPasswordPei.h
SecurityPkg/Include/Guid/AuthenticatedVariableFormat.h
SecurityPkg/Include/Guid/MeasuredFvHob.h
SecurityPkg/Include/Guid/PhysicalPresenceData.h
SecurityPkg/Include/Guid/PwdCredentialProviderHii.h
SecurityPkg/Include/Guid/SecureBootConfigHii.h
SecurityPkg/Include/Guid/SecurityPkgTokenSpace.h
SecurityPkg/Include/Guid/Tcg2ConfigHii.h
SecurityPkg/Include/Guid/Tcg2PhysicalPresenceData.h
SecurityPkg/Include/Guid/TcgConfigHii.h
SecurityPkg/Include/Guid/TcgEventHob.h
SecurityPkg/Include/Guid/TpmInstance.h
SecurityPkg/Include/Guid/TpmNvsMm.h
SecurityPkg/Include/Library/HashLib.h
SecurityPkg/Include/Library/PlatformSecureLib.h
SecurityPkg/Include/Library/RpmcLib.h
SecurityPkg/Include/Library/SecureBootVariableLib.h
SecurityPkg/Include/Library/SecureBootVariableProvisionLib.h
SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
SecurityPkg/Include/Library/Tcg2PpVendorLib.h
SecurityPkg/Include/Library/TcgEventLogRecordLib.h
SecurityPkg/Include/Library/TcgPhysicalPresenceLib.h
SecurityPkg/Include/Library/TcgPpVendorLib.h
SecurityPkg/Include/Library/TcgStorageCoreLib.h
SecurityPkg/Include/Library/TcgStorageOpalLib.h
SecurityPkg/Include/Library/Tpm12CommandLib.h
SecurityPkg/Include/Library/Tpm12DeviceLib.h
SecurityPkg/Include/Library/Tpm2CommandLib.h
SecurityPkg/Include/Library/Tpm2DeviceLib.h
SecurityPkg/Include/Library/TpmCommLib.h
SecurityPkg/Include/Library/VariableKeyLib.h
SecurityPkg/Include/Ppi/FirmwareVolumeInfoMeasurementExcluded.h
SecurityPkg/Include/Ppi/FirmwareVolumeInfoPrehashedFV.h
SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h
SecurityPkg/Include/Ppi/LockPhysicalPresence.h
SecurityPkg/Include/Ppi/Tcg.h
SecurityPkg/Include/Ppi/TpmInitialized.h
SecurityPkg/Library/AuthVariableLib/AuthService.c
SecurityPkg/Library/AuthVariableLib/AuthServiceInternal.h
SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c
SecurityPkg/Library/DxeImageAuthenticationStatusLib/DxeImageAuthenticationStatusLib.c
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.h
SecurityPkg/Library/DxeImageVerificationLib/Measurement.c
SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa2048Sha256GuidedSectionExtractLib.c
SecurityPkg/Library/DxeTcg2PhysicalPresenceLib/DxeTcg2PhysicalPresenceLib.c
SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.c
SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.c
SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.c
SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.c
SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.c
SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.c
SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.c
SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCommon.c
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCommon.h
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
SecurityPkg/Library/HashLibTpm2/HashLibTpm2.c
SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c
SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa2048Sha256GuidedSectionExtractLib.c
SecurityPkg/Library/PeiTcg2PhysicalPresenceLib/PeiTcg2PhysicalPresenceLib.c
SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.c
SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c
SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.c
SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.c
SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLibCommon.c
SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.c
SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.c
SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.c
SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalLibInternal.h
SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
SecurityPkg/Library/Tpm12CommandLib/Tpm12GetCapability.c
SecurityPkg/Library/Tpm12CommandLib/Tpm12NvStorage.c
SecurityPkg/Library/Tpm12CommandLib/Tpm12Ownership.c
SecurityPkg/Library/Tpm12CommandLib/Tpm12Pcr.c
SecurityPkg/Library/Tpm12CommandLib/Tpm12PhysicalPresence.c
SecurityPkg/Library/Tpm12CommandLib/Tpm12SelfTest.c
SecurityPkg/Library/Tpm12CommandLib/Tpm12Startup.c
SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
SecurityPkg/Library/Tpm12DeviceLibTcg/Tpm12DeviceLibTcg.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Context.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2DictionaryAttack.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2EnhancedAuthorization.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Hierarchy.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Integrity.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2NVStorage.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Object.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Sequences.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Session.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Startup.c
SecurityPkg/Library/Tpm2CommandLib/Tpm2Test.c
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.h
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpmBase.c
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpmStandaloneMm.c
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.c
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c
SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c
SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c
SecurityPkg/Library/TpmCommLib/TisPc.c
SecurityPkg/Library/TpmCommLib/TpmComm.c
SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c
SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/AesCore.c
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/AesCore.h
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RdRand.c
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RdRand.h
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h
SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.h
SecurityPkg/Tcg/MemoryOverwriteRequestControlLock/TcgMorLock.c
SecurityPkg/Tcg/MemoryOverwriteRequestControlLock/TcgMorLock.h
SecurityPkg/Tcg/MemoryOverwriteRequestControlLock/TcgMorLockSmm.c
SecurityPkg/Tcg/Opal/OpalPassword/ComponentName.c
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.h
SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h
SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiCallbacks.c
SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormValues.h
SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordCommon.h
SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.h
SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c
SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.h
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigNvData.h
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c
SecurityPkg/Tcg/Tcg2Config/Tcg2Internal.h
SecurityPkg/Tcg/Tcg2Config/TpmDetection.c
SecurityPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
SecurityPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.c
SecurityPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.c
SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.h
SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c
SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c
SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c
SecurityPkg/Tcg/TcgConfigDxe/TcgConfigImpl.c
SecurityPkg/Tcg/TcgConfigDxe/TcgConfigImpl.h
SecurityPkg/Tcg/TcgConfigDxe/TcgConfigNvData.h
SecurityPkg/Tcg/TcgDxe/TcgDxe.c
SecurityPkg/Tcg/TcgPei/TcgPei.c
SecurityPkg/Tcg/TcgSmm/TcgSmm.c
SecurityPkg/Tcg/TcgSmm/TcgSmm.h
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDevicePath.c
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDriver.c
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigMisc.c
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigNvData.h
SecurityPkg/VariableAuthenticated/SecureBootDefaultKeysDxe/SecureBootDefaultKeysDxe.c

index 0e4b06551abf8332c7837acb290e16fd9efbe121..cb7095b269b1281da780f8c054cbb03610187012 100644 (file)
@@ -37,8 +37,8 @@ UefiMain (
   IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS Status;\r
-  UINT8      SetupMode;\r
+  EFI_STATUS  Status;\r
+  UINT8       SetupMode;\r
 \r
   Status = GetSetupMode (&SetupMode);\r
   if (EFI_ERROR (Status)) {\r
@@ -92,6 +92,7 @@ UefiMain (
       "Please do it manually, otherwise system can be easily compromised\n"\r
       );\r
   }\r
+\r
   return 0;\r
 \r
 clearKEK:\r
index 6dce3298e3a23046414ae5f604ada8553c582af9..846605cda1e416c55575130242a0f82da2af13bb 100644 (file)
@@ -8,10 +8,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "FvReportPei.h"\r
 \r
-STATIC CONST HASH_ALG_INFO mHashAlgInfo[] = {\r
-  {TPM_ALG_SHA256, SHA256_DIGEST_SIZE, Sha256Init, Sha256Update, Sha256Final, Sha256HashAll}, // 000B\r
-  {TPM_ALG_SHA384, SHA384_DIGEST_SIZE, Sha384Init, Sha384Update, Sha384Final, Sha384HashAll}, // 000C\r
-  {TPM_ALG_SHA512, SHA512_DIGEST_SIZE, Sha512Init, Sha512Update, Sha512Final, Sha512HashAll}, // 000D\r
+STATIC CONST HASH_ALG_INFO  mHashAlgInfo[] = {\r
+  { TPM_ALG_SHA256, SHA256_DIGEST_SIZE, Sha256Init, Sha256Update, Sha256Final, Sha256HashAll }, // 000B\r
+  { TPM_ALG_SHA384, SHA384_DIGEST_SIZE, Sha384Init, Sha384Update, Sha384Final, Sha384HashAll }, // 000C\r
+  { TPM_ALG_SHA512, SHA512_DIGEST_SIZE, Sha512Init, Sha512Update, Sha512Final, Sha512HashAll }, // 000D\r
 };\r
 \r
 /**\r
@@ -26,10 +26,10 @@ STATIC
 CONST\r
 HASH_ALG_INFO *\r
 FindHashAlgInfo (\r
-  IN UINT16         HashAlgId\r
+  IN UINT16  HashAlgId\r
   )\r
 {\r
-  UINTN             Index;\r
+  UINTN  Index;\r
 \r
   for (Index = 0; Index < ARRAY_SIZE (mHashAlgInfo); ++Index) {\r
     if (mHashAlgInfo[Index].HashAlgId == HashAlgId) {\r
@@ -53,18 +53,18 @@ FindHashAlgInfo (
 STATIC\r
 VOID\r
 InstallPreHashFvPpi (\r
-  IN VOID           *FvBuffer,\r
-  IN UINTN          FvLength,\r
-  IN UINT16         HashAlgoId,\r
-  IN UINT16         HashSize,\r
-  IN UINT8          *HashValue\r
+  IN VOID    *FvBuffer,\r
+  IN UINTN   FvLength,\r
+  IN UINT16  HashAlgoId,\r
+  IN UINT16  HashSize,\r
+  IN UINT8   *HashValue\r
   )\r
 {\r
-  EFI_STATUS                                        Status;\r
-  EFI_PEI_PPI_DESCRIPTOR                            *FvInfoPpiDescriptor;\r
-  EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI   *PreHashedFvPpi;\r
-  UINTN                                             PpiSize;\r
-  HASH_INFO                                         *HashInfo;\r
+  EFI_STATUS                                       Status;\r
+  EFI_PEI_PPI_DESCRIPTOR                           *FvInfoPpiDescriptor;\r
+  EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI  *PreHashedFvPpi;\r
+  UINTN                                            PpiSize;\r
+  HASH_INFO                                        *HashInfo;\r
 \r
   PpiSize = sizeof (EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI)\r
             + sizeof (HASH_INFO)\r
@@ -73,13 +73,13 @@ InstallPreHashFvPpi (
   PreHashedFvPpi = AllocatePool (PpiSize);\r
   ASSERT (PreHashedFvPpi != NULL);\r
 \r
-  PreHashedFvPpi->FvBase    = (UINT32)(UINTN)FvBuffer;\r
-  PreHashedFvPpi->FvLength  = (UINT32)FvLength;\r
-  PreHashedFvPpi->Count     = 1;\r
+  PreHashedFvPpi->FvBase   = (UINT32)(UINTN)FvBuffer;\r
+  PreHashedFvPpi->FvLength = (UINT32)FvLength;\r
+  PreHashedFvPpi->Count    = 1;\r
 \r
-  HashInfo = HASH_INFO_PTR (PreHashedFvPpi);\r
+  HashInfo             = HASH_INFO_PTR (PreHashedFvPpi);\r
   HashInfo->HashAlgoId = HashAlgoId;\r
-  HashInfo->HashSize = HashSize;\r
+  HashInfo->HashSize   = HashSize;\r
   CopyMem (HASH_VALUE_PTR (HashInfo), HashValue, HashSize);\r
 \r
   FvInfoPpiDescriptor = AllocatePool (sizeof (EFI_PEI_PPI_DESCRIPTOR));\r
@@ -87,7 +87,7 @@ InstallPreHashFvPpi (
 \r
   FvInfoPpiDescriptor->Guid  = &gEdkiiPeiFirmwareVolumeInfoPrehashedFvPpiGuid;\r
   FvInfoPpiDescriptor->Flags = EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST;\r
-  FvInfoPpiDescriptor->Ppi   = (VOID *) PreHashedFvPpi;\r
+  FvInfoPpiDescriptor->Ppi   = (VOID *)PreHashedFvPpi;\r
 \r
   Status = PeiServicesInstallPpi (FvInfoPpiDescriptor);\r
   ASSERT_EFI_ERROR (Status);\r
@@ -108,30 +108,35 @@ InstallPreHashFvPpi (
 STATIC\r
 EFI_STATUS\r
 VerifyHashedFv (\r
-  IN FV_HASH_INFO         *HashInfo,\r
-  IN HASHED_FV_INFO       *FvInfo,\r
-  IN UINTN                FvNumber,\r
-  IN EFI_BOOT_MODE        BootMode\r
+  IN FV_HASH_INFO    *HashInfo,\r
+  IN HASHED_FV_INFO  *FvInfo,\r
+  IN UINTN           FvNumber,\r
+  IN EFI_BOOT_MODE   BootMode\r
   )\r
 {\r
-  UINTN                 FvIndex;\r
-  CONST HASH_ALG_INFO   *AlgInfo;\r
-  UINT8                 *HashValue;\r
-  UINT8                 *FvHashValue;\r
-  VOID                  *FvBuffer;\r
-  EFI_STATUS            Status;\r
-\r
-  if (HashInfo == NULL ||\r
-      HashInfo->HashSize == 0 ||\r
-      HashInfo->HashAlgoId == TPM_ALG_NULL) {\r
+  UINTN                FvIndex;\r
+  CONST HASH_ALG_INFO  *AlgInfo;\r
+  UINT8                *HashValue;\r
+  UINT8                *FvHashValue;\r
+  VOID                 *FvBuffer;\r
+  EFI_STATUS           Status;\r
+\r
+  if ((HashInfo == NULL) ||\r
+      (HashInfo->HashSize == 0) ||\r
+      (HashInfo->HashAlgoId == TPM_ALG_NULL))\r
+  {\r
     DEBUG ((DEBUG_INFO, "Bypass FV hash verification\r\n"));\r
     return EFI_SUCCESS;\r
   }\r
 \r
   AlgInfo = FindHashAlgInfo (HashInfo->HashAlgoId);\r
-  if (AlgInfo == NULL || AlgInfo->HashSize != HashInfo->HashSize) {\r
-    DEBUG ((DEBUG_ERROR, "Unsupported or wrong hash algorithm: %04X (size=%d)\r\n",\r
-            HashInfo->HashAlgoId, HashInfo->HashSize));\r
+  if ((AlgInfo == NULL) || (AlgInfo->HashSize != HashInfo->HashSize)) {\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "Unsupported or wrong hash algorithm: %04X (size=%d)\r\n",\r
+      HashInfo->HashAlgoId,\r
+      HashInfo->HashSize\r
+      ));\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
@@ -152,8 +157,9 @@ VerifyHashedFv (
     //\r
     // Not meant for verified boot and/or measured boot?\r
     //\r
-    if ((FvInfo[FvIndex].Flag & HASHED_FV_FLAG_VERIFIED_BOOT) == 0 &&\r
-          (FvInfo[FvIndex].Flag & HASHED_FV_FLAG_MEASURED_BOOT) == 0) {\r
+    if (((FvInfo[FvIndex].Flag & HASHED_FV_FLAG_VERIFIED_BOOT) == 0) &&\r
+        ((FvInfo[FvIndex].Flag & HASHED_FV_FLAG_MEASURED_BOOT) == 0))\r
+    {\r
       continue;\r
     }\r
 \r
@@ -161,8 +167,12 @@ VerifyHashedFv (
     // Skip any FV not meant for current boot mode.\r
     //\r
     if ((FvInfo[FvIndex].Flag & HASHED_FV_FLAG_SKIP_BOOT_MODE (BootMode)) != 0) {\r
-      DEBUG ((DEBUG_INFO, "Skip FV[%016lX] for boot mode[%d]\r\n",\r
-              FvInfo[FvIndex].Base, BootMode));\r
+      DEBUG ((\r
+        DEBUG_INFO,\r
+        "Skip FV[%016lX] for boot mode[%d]\r\n",\r
+        FvInfo[FvIndex].Base,\r
+        BootMode\r
+        ));\r
       continue;\r
     }\r
 \r
@@ -180,7 +190,7 @@ VerifyHashedFv (
     //\r
     // Copy FV to permanent memory to avoid potential TOC/TOU.\r
     //\r
-    FvBuffer = AllocatePages (EFI_SIZE_TO_PAGES((UINTN)FvInfo[FvIndex].Length));\r
+    FvBuffer = AllocatePages (EFI_SIZE_TO_PAGES ((UINTN)FvInfo[FvIndex].Length));\r
     ASSERT (FvBuffer != NULL);\r
     CopyMem (FvBuffer, (CONST VOID *)(UINTN)FvInfo[FvIndex].Base, (UINTN)FvInfo[FvIndex].Length);\r
 \r
@@ -218,9 +228,10 @@ VerifyHashedFv (
   //\r
   // Check final hash for all FVs.\r
   //\r
-  if (FvHashValue == HashValue ||\r
+  if ((FvHashValue == HashValue) ||\r
       (AlgInfo->HashAll (HashValue, FvHashValue - HashValue, FvHashValue) &&\r
-       CompareMem (HashInfo->Hash, FvHashValue, AlgInfo->HashSize) == 0)) {\r
+       (CompareMem (HashInfo->Hash, FvHashValue, AlgInfo->HashSize) == 0)))\r
+  {\r
     Status = EFI_SUCCESS;\r
   } else {\r
     Status = EFI_VOLUME_CORRUPTED;\r
@@ -240,10 +251,10 @@ Done:
 STATIC\r
 VOID\r
 ReportHashedFv (\r
-  IN HASHED_FV_INFO       *FvInfo\r
+  IN HASHED_FV_INFO  *FvInfo\r
   )\r
 {\r
-  CONST EFI_GUID    *FvFormat;\r
+  CONST EFI_GUID  *FvFormat;\r
 \r
   if ((FvInfo->Flag & HASHED_FV_FLAG_REPORT_FV_HOB) != 0) {\r
     //\r
@@ -293,7 +304,7 @@ GetHashInfo (
   IN EFI_BOOT_MODE                                      BootMode\r
   )\r
 {\r
-  FV_HASH_INFO            *HashInfo;\r
+  FV_HASH_INFO  *HashInfo;\r
 \r
   if ((StoredHashFvPpi->HashInfo.HashFlag & FV_HASH_FLAG_BOOT_MODE (BootMode)) != 0) {\r
     HashInfo = &StoredHashFvPpi->HashInfo;\r
@@ -320,32 +331,34 @@ GetHashInfo (
 STATIC\r
 EFI_STATUS\r
 CheckStoredHashFv (\r
-  IN CONST EFI_PEI_SERVICES           **PeiServices,\r
-  IN EFI_BOOT_MODE                    BootMode\r
+  IN CONST EFI_PEI_SERVICES  **PeiServices,\r
+  IN EFI_BOOT_MODE           BootMode\r
   )\r
 {\r
-  EFI_STATUS                                            Status;\r
-  EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI     *StoredHashFvPpi;\r
-  FV_HASH_INFO                                          *HashInfo;\r
-  UINTN                                                 FvIndex;\r
+  EFI_STATUS                                         Status;\r
+  EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI  *StoredHashFvPpi;\r
+  FV_HASH_INFO                                       *HashInfo;\r
+  UINTN                                              FvIndex;\r
 \r
   //\r
   // Check pre-hashed FV list\r
   //\r
   StoredHashFvPpi = NULL;\r
-  Status = PeiServicesLocatePpi (\r
-             &gEdkiiPeiFirmwareVolumeInfoStoredHashFvPpiGuid,\r
-             0,\r
-             NULL,\r
-             (VOID**)&StoredHashFvPpi\r
-             );\r
-  if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi->FvNumber > 0) {\r
-\r
+  Status          = PeiServicesLocatePpi (\r
+                      &gEdkiiPeiFirmwareVolumeInfoStoredHashFvPpiGuid,\r
+                      0,\r
+                      NULL,\r
+                      (VOID **)&StoredHashFvPpi\r
+                      );\r
+  if (!EFI_ERROR (Status) && (StoredHashFvPpi != NULL) && (StoredHashFvPpi->FvNumber > 0)) {\r
     HashInfo = GetHashInfo (StoredHashFvPpi, BootMode);\r
-    Status = VerifyHashedFv (HashInfo, StoredHashFvPpi->FvInfo,\r
-                             StoredHashFvPpi->FvNumber, BootMode);\r
+    Status   = VerifyHashedFv (\r
+                 HashInfo,\r
+                 StoredHashFvPpi->FvInfo,\r
+                 StoredHashFvPpi->FvNumber,\r
+                 BootMode\r
+                 );\r
     if (!EFI_ERROR (Status)) {\r
-\r
       DEBUG ((DEBUG_INFO, "OBB verification passed (%r)\r\n", Status));\r
 \r
       //\r
@@ -353,7 +366,8 @@ CheckStoredHashFv (
       //\r
       for (FvIndex = 0; FvIndex < StoredHashFvPpi->FvNumber; ++FvIndex) {\r
         if ((StoredHashFvPpi->FvInfo[FvIndex].Flag\r
-             & HASHED_FV_FLAG_SKIP_BOOT_MODE (BootMode)) == 0) {\r
+             & HASHED_FV_FLAG_SKIP_BOOT_MODE (BootMode)) == 0)\r
+        {\r
           ReportHashedFv (&StoredHashFvPpi->FvInfo[FvIndex]);\r
         }\r
       }\r
@@ -362,9 +376,7 @@ CheckStoredHashFv (
         EFI_PROGRESS_CODE,\r
         PcdGet32 (PcdStatusCodeFvVerificationPass)\r
         );\r
-\r
     } else {\r
-\r
       DEBUG ((DEBUG_ERROR, "ERROR: Failed to verify OBB FVs (%r)\r\n", Status));\r
 \r
       REPORT_STATUS_CODE_EX (\r
@@ -378,11 +390,8 @@ CheckStoredHashFv (
         );\r
 \r
       ASSERT_EFI_ERROR (Status);\r
-\r
     }\r
-\r
   } else {\r
-\r
     DEBUG ((DEBUG_ERROR, "ERROR: No/invalid StoredHashFvPpi located\r\n"));\r
 \r
     ASSERT_EFI_ERROR (Status);\r
@@ -410,8 +419,8 @@ FvReportEntryPoint (
   IN CONST EFI_PEI_SERVICES     **PeiServices\r
   )\r
 {\r
-  EFI_STATUS           Status;\r
-  EFI_BOOT_MODE        BootMode;\r
+  EFI_STATUS     Status;\r
+  EFI_BOOT_MODE  BootMode;\r
 \r
   Status = PeiServicesGetBootMode (&BootMode);\r
   ASSERT_EFI_ERROR (Status);\r
index aa35d2d4f10368f866851b01d0d32ccb7aa6ff5d..92504a3c51e18228c46860941e8c8bfb3fc26eb4 100644 (file)
@@ -48,7 +48,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 typedef\r
 BOOLEAN\r
-(EFIAPI *HASH_ALL_METHOD) (\r
+(EFIAPI *HASH_ALL_METHOD)(\r
   IN   CONST VOID  *Data,\r
   IN   UINTN       DataSize,\r
   OUT  UINT8       *HashValue\r
@@ -66,7 +66,7 @@ BOOLEAN
 **/\r
 typedef\r
 BOOLEAN\r
-(EFIAPI *HASH_INIT_METHOD) (\r
+(EFIAPI *HASH_INIT_METHOD)(\r
   OUT  VOID  *HashContext\r
   );\r
 \r
@@ -84,7 +84,7 @@ BOOLEAN
 **/\r
 typedef\r
 BOOLEAN\r
-(EFIAPI *HASH_UPDATE_METHOD) (\r
+(EFIAPI *HASH_UPDATE_METHOD)(\r
   IN OUT  VOID        *HashContext,\r
   IN      CONST VOID  *Data,\r
   IN      UINTN       DataSize\r
@@ -104,19 +104,18 @@ BOOLEAN
 **/\r
 typedef\r
 BOOLEAN\r
-(EFIAPI *HASH_FINAL_METHOD) (\r
+(EFIAPI *HASH_FINAL_METHOD)(\r
   IN OUT  VOID   *HashContext,\r
   OUT     UINT8  *HashValue\r
   );\r
 \r
 typedef struct {\r
-  UINT16              HashAlgId;\r
-  UINTN               HashSize;\r
-  HASH_INIT_METHOD    HashInit;\r
-  HASH_UPDATE_METHOD  HashUpdate;\r
-  HASH_FINAL_METHOD   HashFinal;\r
-  HASH_ALL_METHOD     HashAll;\r
+  UINT16                HashAlgId;\r
+  UINTN                 HashSize;\r
+  HASH_INIT_METHOD      HashInit;\r
+  HASH_UPDATE_METHOD    HashUpdate;\r
+  HASH_FINAL_METHOD     HashFinal;\r
+  HASH_ALL_METHOD       HashAll;\r
 } HASH_ALG_INFO;\r
 \r
 #endif //__FV_REPORT_PEI_H__\r
-\r
index 0d123b2a2f5c5ed9d8244cdff815a8231033826a..dc194ced5b66645d260e9f4a39a0cf9a6505b9c1 100644 (file)
@@ -8,7 +8,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "Driver.h"\r
 \r
-EFI_SERVICE_BINDING_PROTOCOL    mHash2ServiceBindingProtocol = {\r
+EFI_SERVICE_BINDING_PROTOCOL  mHash2ServiceBindingProtocol = {\r
   Hash2ServiceBindingCreateChild,\r
   Hash2ServiceBindingDestroyChild\r
 };\r
@@ -32,14 +32,14 @@ EFI_SERVICE_BINDING_PROTOCOL    mHash2ServiceBindingProtocol = {
 EFI_STATUS\r
 EFIAPI\r
 Hash2ServiceBindingCreateChild (\r
-  IN     EFI_SERVICE_BINDING_PROTOCOL    *This,\r
-  IN OUT EFI_HANDLE                      *ChildHandle\r
+  IN     EFI_SERVICE_BINDING_PROTOCOL  *This,\r
+  IN OUT EFI_HANDLE                    *ChildHandle\r
   )\r
 {\r
-  EFI_STATUS          Status;\r
-  HASH2_SERVICE_DATA  *Hash2ServiceData;\r
-  HASH2_INSTANCE_DATA *Instance;\r
-  EFI_TPL             OldTpl;\r
+  EFI_STATUS           Status;\r
+  HASH2_SERVICE_DATA   *Hash2ServiceData;\r
+  HASH2_INSTANCE_DATA  *Instance;\r
+  EFI_TPL              OldTpl;\r
 \r
   if ((This == NULL) || (ChildHandle == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -87,7 +87,6 @@ Hash2ServiceBindingCreateChild (
   return Status;\r
 }\r
 \r
-\r
 /**\r
   Destroys a child handle with a set of I/O services.\r
 \r
@@ -112,16 +111,16 @@ Hash2ServiceBindingCreateChild (
 EFI_STATUS\r
 EFIAPI\r
 Hash2ServiceBindingDestroyChild (\r
-  IN EFI_SERVICE_BINDING_PROTOCOL    *This,\r
-  IN EFI_HANDLE                      ChildHandle\r
+  IN EFI_SERVICE_BINDING_PROTOCOL  *This,\r
+  IN EFI_HANDLE                    ChildHandle\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  HASH2_SERVICE_DATA             *Hash2ServiceData;\r
-  EFI_HASH2_PROTOCOL             *Hash2Protocol;\r
-  HASH2_INSTANCE_DATA            *Instance;\r
-  EFI_TPL                        OldTpl;\r
-  LIST_ENTRY                     *Entry;\r
+  EFI_STATUS           Status;\r
+  HASH2_SERVICE_DATA   *Hash2ServiceData;\r
+  EFI_HASH2_PROTOCOL   *Hash2Protocol;\r
+  HASH2_INSTANCE_DATA  *Instance;\r
+  EFI_TPL              OldTpl;\r
+  LIST_ENTRY           *Entry;\r
 \r
   if ((This == NULL) || (ChildHandle == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -133,7 +132,7 @@ Hash2ServiceBindingDestroyChild (
   // Check if this ChildHandle is valid\r
   //\r
   Instance = NULL;\r
-  for(Entry = (&Hash2ServiceData->ChildrenList)->ForwardLink; Entry != (&Hash2ServiceData->ChildrenList); Entry = Entry->ForwardLink) {\r
+  for (Entry = (&Hash2ServiceData->ChildrenList)->ForwardLink; Entry != (&Hash2ServiceData->ChildrenList); Entry = Entry->ForwardLink) {\r
     Instance = HASH2_INSTANCE_DATA_FROM_LINK (Entry);\r
     if (Instance->Handle == ChildHandle) {\r
       break;\r
@@ -141,6 +140,7 @@ Hash2ServiceBindingDestroyChild (
       Instance = NULL;\r
     }\r
   }\r
+\r
   if (Instance == NULL) {\r
     DEBUG ((DEBUG_ERROR, "Hash2ServiceBindingDestroyChild - Invalid handle\n"));\r
     return EFI_UNSUPPORTED;\r
@@ -200,12 +200,12 @@ Hash2ServiceBindingDestroyChild (
 EFI_STATUS\r
 EFIAPI\r
 Hash2DriverEntryPoint (\r
-  IN EFI_HANDLE          ImageHandle,\r
-  IN EFI_SYSTEM_TABLE    *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS         Status;\r
-  HASH2_SERVICE_DATA *Hash2ServiceData;\r
+  EFI_STATUS          Status;\r
+  HASH2_SERVICE_DATA  *Hash2ServiceData;\r
 \r
   //\r
   // Initialize the Hash Service Data.\r
@@ -215,7 +215,7 @@ Hash2DriverEntryPoint (
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  Hash2ServiceData->Signature     = HASH2_SERVICE_DATA_SIGNATURE;\r
+  Hash2ServiceData->Signature = HASH2_SERVICE_DATA_SIGNATURE;\r
   CopyMem (&Hash2ServiceData->ServiceBinding, &mHash2ServiceBindingProtocol, sizeof (EFI_SERVICE_BINDING_PROTOCOL));\r
   InitializeListHead (&Hash2ServiceData->ChildrenList);\r
 \r
index 7b8996912a08bc37e2e21ffba00b3ebfea187f7c..338e05ea1a2277e468691fe02187a9d462bfb1c2 100644 (file)
@@ -26,11 +26,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define HASH2_SERVICE_DATA_SIGNATURE  SIGNATURE_32 ('H', 'S', '2', 'S')\r
 \r
 typedef struct {\r
-  UINT32                        Signature;\r
-  EFI_HANDLE                    ServiceHandle;\r
-  EFI_SERVICE_BINDING_PROTOCOL  ServiceBinding;\r
+  UINT32                          Signature;\r
+  EFI_HANDLE                      ServiceHandle;\r
+  EFI_SERVICE_BINDING_PROTOCOL    ServiceBinding;\r
 \r
-  LIST_ENTRY                    ChildrenList;\r
+  LIST_ENTRY                      ChildrenList;\r
 } HASH2_SERVICE_DATA;\r
 \r
 #define HASH2_SERVICE_DATA_FROM_THIS(a) \\r
@@ -41,17 +41,17 @@ typedef struct {
   HASH2_SERVICE_DATA_SIGNATURE \\r
   )\r
 \r
-#define HASH2_INSTANCE_DATA_SIGNATURE   SIGNATURE_32 ('H', 's', '2', 'I')\r
+#define HASH2_INSTANCE_DATA_SIGNATURE  SIGNATURE_32 ('H', 's', '2', 'I')\r
 \r
 typedef struct {\r
-  UINT32                           Signature;\r
-  HASH2_SERVICE_DATA               *Hash2ServiceData;\r
-  EFI_HANDLE                       Handle;\r
-  LIST_ENTRY                       InstEntry;\r
-  EFI_HASH2_PROTOCOL               Hash2Protocol;\r
-  VOID                             *HashContext;\r
-  VOID                             *HashInfoContext;\r
-  BOOLEAN                          Updated;\r
+  UINT32                Signature;\r
+  HASH2_SERVICE_DATA    *Hash2ServiceData;\r
+  EFI_HANDLE            Handle;\r
+  LIST_ENTRY            InstEntry;\r
+  EFI_HASH2_PROTOCOL    Hash2Protocol;\r
+  VOID                  *HashContext;\r
+  VOID                  *HashInfoContext;\r
+  BOOLEAN               Updated;\r
 } HASH2_INSTANCE_DATA;\r
 \r
 #define HASH2_INSTANCE_DATA_FROM_THIS(a) \\r
@@ -89,8 +89,8 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Hash2ServiceBindingCreateChild (\r
-  IN     EFI_SERVICE_BINDING_PROTOCOL    *This,\r
-  IN OUT EFI_HANDLE                      *ChildHandle\r
+  IN     EFI_SERVICE_BINDING_PROTOCOL  *This,\r
+  IN OUT EFI_HANDLE                    *ChildHandle\r
   );\r
 \r
 /**\r
@@ -117,10 +117,10 @@ Hash2ServiceBindingCreateChild (
 EFI_STATUS\r
 EFIAPI\r
 Hash2ServiceBindingDestroyChild (\r
-  IN EFI_SERVICE_BINDING_PROTOCOL    *This,\r
-  IN EFI_HANDLE                      ChildHandle\r
+  IN EFI_SERVICE_BINDING_PROTOCOL  *This,\r
+  IN EFI_HANDLE                    ChildHandle\r
   );\r
 \r
-extern EFI_HASH2_PROTOCOL mHash2Protocol;\r
+extern EFI_HASH2_PROTOCOL  mHash2Protocol;\r
 \r
 #endif\r
index c1c0470be9939134a9d5197faec591d95c40bd75..1498d5e9eb2986e592b1167d34a6852d5d28342f 100644 (file)
@@ -29,7 +29,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 typedef\r
 UINTN\r
-(EFIAPI *EFI_HASH_GET_CONTEXT_SIZE) (\r
+(EFIAPI *EFI_HASH_GET_CONTEXT_SIZE)(\r
   VOID\r
   );\r
 \r
@@ -49,7 +49,7 @@ UINTN
 **/\r
 typedef\r
 BOOLEAN\r
-(EFIAPI *EFI_HASH_INIT) (\r
+(EFIAPI *EFI_HASH_INIT)(\r
   OUT  VOID  *HashContext\r
   );\r
 \r
@@ -75,7 +75,7 @@ BOOLEAN
 **/\r
 typedef\r
 BOOLEAN\r
-(EFIAPI *EFI_HASH_UPDATE) (\r
+(EFIAPI *EFI_HASH_UPDATE)(\r
   IN OUT  VOID        *HashContext,\r
   IN      CONST VOID  *Data,\r
   IN      UINTN       DataSize\r
@@ -105,24 +105,24 @@ BOOLEAN
 **/\r
 typedef\r
 BOOLEAN\r
-(EFIAPI *EFI_HASH_FINAL) (\r
+(EFIAPI *EFI_HASH_FINAL)(\r
   IN OUT  VOID   *HashContext,\r
   OUT     UINT8  *HashValue\r
   );\r
 \r
 typedef struct {\r
-  EFI_GUID                   *Guid;\r
-  UINT32                     HashSize;\r
-  EFI_HASH_GET_CONTEXT_SIZE  GetContextSize;\r
-  EFI_HASH_INIT              Init;\r
-  EFI_HASH_UPDATE            Update;\r
-  EFI_HASH_FINAL             Final;\r
+  EFI_GUID                     *Guid;\r
+  UINT32                       HashSize;\r
+  EFI_HASH_GET_CONTEXT_SIZE    GetContextSize;\r
+  EFI_HASH_INIT                Init;\r
+  EFI_HASH_UPDATE              Update;\r
+  EFI_HASH_FINAL               Final;\r
 } EFI_HASH_INFO;\r
 \r
 EFI_HASH_INFO  mHashInfo[] = {\r
-  {&gEfiHashAlgorithmSha256Guid,  sizeof(EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },\r
-  {&gEfiHashAlgorithmSha384Guid,  sizeof(EFI_SHA384_HASH2), Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final },\r
-  {&gEfiHashAlgorithmSha512Guid,  sizeof(EFI_SHA512_HASH2), Sha512GetContextSize, Sha512Init, Sha512Update, Sha512Final },\r
+  { &gEfiHashAlgorithmSha256Guid, sizeof (EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },\r
+  { &gEfiHashAlgorithmSha384Guid, sizeof (EFI_SHA384_HASH2), Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final },\r
+  { &gEfiHashAlgorithmSha512Guid, sizeof (EFI_SHA512_HASH2), Sha512GetContextSize, Sha512Init, Sha512Update, Sha512Final },\r
 };\r
 \r
 /**\r
@@ -141,9 +141,9 @@ EFI_HASH_INFO  mHashInfo[] = {
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2GetHashSize (\r
-  IN  CONST EFI_HASH2_PROTOCOL     *This,\r
-  IN  CONST EFI_GUID               *HashAlgorithm,\r
-  OUT UINTN                        *HashSize\r
+  IN  CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN  CONST EFI_GUID            *HashAlgorithm,\r
+  OUT UINTN                     *HashSize\r
   );\r
 \r
 /**\r
@@ -169,11 +169,11 @@ BaseCrypto2GetHashSize (
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2Hash (\r
-  IN CONST EFI_HASH2_PROTOCOL      *This,\r
-  IN CONST EFI_GUID                *HashAlgorithm,\r
-  IN CONST UINT8                   *Message,\r
-  IN UINTN                         MessageSize,\r
-  IN OUT EFI_HASH2_OUTPUT          *Hash\r
+  IN CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN CONST EFI_GUID            *HashAlgorithm,\r
+  IN CONST UINT8               *Message,\r
+  IN UINTN                     MessageSize,\r
+  IN OUT EFI_HASH2_OUTPUT      *Hash\r
   );\r
 \r
 /**\r
@@ -195,8 +195,8 @@ BaseCrypto2Hash (
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2HashInit (\r
-  IN CONST EFI_HASH2_PROTOCOL      *This,\r
-  IN CONST EFI_GUID                *HashAlgorithm\r
+  IN CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN CONST EFI_GUID            *HashAlgorithm\r
   );\r
 \r
 /**\r
@@ -217,9 +217,9 @@ BaseCrypto2HashInit (
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2HashUpdate (\r
-  IN CONST EFI_HASH2_PROTOCOL      *This,\r
-  IN CONST UINT8                   *Message,\r
-  IN UINTN                         MessageSize\r
+  IN CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN CONST UINT8               *Message,\r
+  IN UINTN                     MessageSize\r
   );\r
 \r
 /**\r
@@ -241,11 +241,11 @@ BaseCrypto2HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2HashFinal (\r
-  IN CONST EFI_HASH2_PROTOCOL      *This,\r
-  IN OUT EFI_HASH2_OUTPUT          *Hash\r
+  IN CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN OUT EFI_HASH2_OUTPUT      *Hash\r
   );\r
 \r
-EFI_HASH2_PROTOCOL mHash2Protocol = {\r
+EFI_HASH2_PROTOCOL  mHash2Protocol = {\r
   BaseCrypto2GetHashSize,\r
   BaseCrypto2Hash,\r
   BaseCrypto2HashInit,\r
@@ -262,16 +262,17 @@ EFI_HASH2_PROTOCOL mHash2Protocol = {
 **/\r
 EFI_HASH_INFO *\r
 GetHashInfo (\r
-  IN CONST EFI_GUID              *HashAlgorithm\r
+  IN CONST EFI_GUID  *HashAlgorithm\r
   )\r
 {\r
-  UINTN      Index;\r
+  UINTN  Index;\r
 \r
-  for (Index = 0; Index < sizeof(mHashInfo)/sizeof(mHashInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mHashInfo)/sizeof (mHashInfo[0]); Index++) {\r
     if (CompareGuid (HashAlgorithm, mHashInfo[Index].Guid)) {\r
       return &mHashInfo[Index];\r
     }\r
   }\r
+\r
   return NULL;\r
 }\r
 \r
@@ -291,12 +292,12 @@ GetHashInfo (
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2GetHashSize (\r
-  IN  CONST EFI_HASH2_PROTOCOL     *This,\r
-  IN  CONST EFI_GUID              *HashAlgorithm,\r
-  OUT UINTN                       *HashSize\r
+  IN  CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN  CONST EFI_GUID            *HashAlgorithm,\r
+  OUT UINTN                     *HashSize\r
   )\r
 {\r
-  EFI_HASH_INFO *HashInfo;\r
+  EFI_HASH_INFO  *HashInfo;\r
 \r
   if ((This == NULL) || (HashSize == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -338,19 +339,19 @@ BaseCrypto2GetHashSize (
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2Hash (\r
-  IN CONST EFI_HASH2_PROTOCOL      *This,\r
-  IN CONST EFI_GUID                *HashAlgorithm,\r
-  IN CONST UINT8                   *Message,\r
-  IN UINTN                         MessageSize,\r
-  IN OUT EFI_HASH2_OUTPUT          *Hash\r
+  IN CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN CONST EFI_GUID            *HashAlgorithm,\r
+  IN CONST UINT8               *Message,\r
+  IN UINTN                     MessageSize,\r
+  IN OUT EFI_HASH2_OUTPUT      *Hash\r
   )\r
 {\r
-  EFI_HASH_INFO            *HashInfo;\r
-  VOID                     *HashCtx;\r
-  UINTN                    CtxSize;\r
-  BOOLEAN                  Ret;\r
-  EFI_STATUS               Status;\r
-  HASH2_INSTANCE_DATA      *Instance;\r
+  EFI_HASH_INFO        *HashInfo;\r
+  VOID                 *HashCtx;\r
+  UINTN                CtxSize;\r
+  BOOLEAN              Ret;\r
+  EFI_STATUS           Status;\r
+  HASH2_INSTANCE_DATA  *Instance;\r
 \r
   Status = EFI_SUCCESS;\r
 \r
@@ -367,12 +368,13 @@ BaseCrypto2Hash (
     return EFI_UNSUPPORTED;\r
   }\r
 \r
-  Instance = HASH2_INSTANCE_DATA_FROM_THIS(This);\r
+  Instance = HASH2_INSTANCE_DATA_FROM_THIS (This);\r
   if (Instance->HashContext != NULL) {\r
     FreePool (Instance->HashContext);\r
   }\r
+\r
   Instance->HashInfoContext = NULL;\r
-  Instance->HashContext = NULL;\r
+  Instance->HashContext     = NULL;\r
 \r
   //\r
   // Start hash sequence\r
@@ -381,6 +383,7 @@ BaseCrypto2Hash (
   if (CtxSize == 0) {\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   HashCtx = AllocatePool (CtxSize);\r
   if (HashCtx == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
@@ -395,7 +398,7 @@ BaseCrypto2Hash (
   //\r
   // Setup the context\r
   //\r
-  Instance->HashContext = HashCtx;\r
+  Instance->HashContext     = HashCtx;\r
   Instance->HashInfoContext = HashInfo;\r
 \r
   Ret = HashInfo->Update (HashCtx, Message, MessageSize);\r
@@ -409,13 +412,14 @@ BaseCrypto2Hash (
     Status = EFI_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
+\r
 Done:\r
   //\r
   // Cleanup the context\r
   //\r
   FreePool (HashCtx);\r
   Instance->HashInfoContext = NULL;\r
-  Instance->HashContext = NULL;\r
+  Instance->HashContext     = NULL;\r
   return Status;\r
 }\r
 \r
@@ -438,15 +442,15 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2HashInit (\r
-  IN CONST EFI_HASH2_PROTOCOL      *This,\r
-  IN CONST EFI_GUID                *HashAlgorithm\r
+  IN CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN CONST EFI_GUID            *HashAlgorithm\r
   )\r
 {\r
-  EFI_HASH_INFO            *HashInfo;\r
-  VOID                     *HashCtx;\r
-  UINTN                    CtxSize;\r
-  BOOLEAN                  Ret;\r
-  HASH2_INSTANCE_DATA      *Instance;\r
+  EFI_HASH_INFO        *HashInfo;\r
+  VOID                 *HashCtx;\r
+  UINTN                CtxSize;\r
+  BOOLEAN              Ret;\r
+  HASH2_INSTANCE_DATA  *Instance;\r
 \r
   if (This == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -464,7 +468,7 @@ BaseCrypto2HashInit (
   //\r
   // Consistency Check\r
   //\r
-  Instance = HASH2_INSTANCE_DATA_FROM_THIS(This);\r
+  Instance = HASH2_INSTANCE_DATA_FROM_THIS (This);\r
   if ((Instance->HashContext != NULL) || (Instance->HashInfoContext != NULL)) {\r
     return EFI_ALREADY_STARTED;\r
   }\r
@@ -476,6 +480,7 @@ BaseCrypto2HashInit (
   if (CtxSize == 0) {\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   HashCtx = AllocatePool (CtxSize);\r
   if (HashCtx == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
@@ -490,9 +495,9 @@ BaseCrypto2HashInit (
   //\r
   // Setup the context\r
   //\r
-  Instance->HashContext = HashCtx;\r
+  Instance->HashContext     = HashCtx;\r
   Instance->HashInfoContext = HashInfo;\r
-  Instance->Updated = FALSE;\r
+  Instance->Updated         = FALSE;\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -515,15 +520,15 @@ BaseCrypto2HashInit (
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2HashUpdate (\r
-  IN CONST EFI_HASH2_PROTOCOL      *This,\r
-  IN CONST UINT8                   *Message,\r
-  IN UINTN                         MessageSize\r
+  IN CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN CONST UINT8               *Message,\r
+  IN UINTN                     MessageSize\r
   )\r
 {\r
-  EFI_HASH_INFO            *HashInfo;\r
-  VOID                     *HashCtx;\r
-  BOOLEAN                  Ret;\r
-  HASH2_INSTANCE_DATA      *Instance;\r
+  EFI_HASH_INFO        *HashInfo;\r
+  VOID                 *HashCtx;\r
+  BOOLEAN              Ret;\r
+  HASH2_INSTANCE_DATA  *Instance;\r
 \r
   if (This == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -532,10 +537,11 @@ BaseCrypto2HashUpdate (
   //\r
   // Consistency Check\r
   //\r
-  Instance = HASH2_INSTANCE_DATA_FROM_THIS(This);\r
+  Instance = HASH2_INSTANCE_DATA_FROM_THIS (This);\r
   if ((Instance->HashContext == NULL) || (Instance->HashInfoContext == NULL)) {\r
     return EFI_NOT_READY;\r
   }\r
+\r
   HashInfo = Instance->HashInfoContext;\r
   HashCtx  = Instance->HashContext;\r
 \r
@@ -568,14 +574,14 @@ BaseCrypto2HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 BaseCrypto2HashFinal (\r
-  IN CONST EFI_HASH2_PROTOCOL      *This,\r
-  IN OUT EFI_HASH2_OUTPUT          *Hash\r
+  IN CONST EFI_HASH2_PROTOCOL  *This,\r
+  IN OUT EFI_HASH2_OUTPUT      *Hash\r
   )\r
 {\r
-  EFI_HASH_INFO            *HashInfo;\r
-  VOID                     *HashCtx;\r
-  BOOLEAN                  Ret;\r
-  HASH2_INSTANCE_DATA      *Instance;\r
+  EFI_HASH_INFO        *HashInfo;\r
+  VOID                 *HashCtx;\r
+  BOOLEAN              Ret;\r
+  HASH2_INSTANCE_DATA  *Instance;\r
 \r
   if ((This == NULL) || (Hash == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -584,11 +590,13 @@ BaseCrypto2HashFinal (
   //\r
   // Consistency Check\r
   //\r
-  Instance = HASH2_INSTANCE_DATA_FROM_THIS(This);\r
+  Instance = HASH2_INSTANCE_DATA_FROM_THIS (This);\r
   if ((Instance->HashContext == NULL) || (Instance->HashInfoContext == NULL) ||\r
-      (!Instance->Updated)) {\r
+      (!Instance->Updated))\r
+  {\r
     return EFI_NOT_READY;\r
   }\r
+\r
   HashInfo = Instance->HashInfoContext;\r
   HashCtx  = Instance->HashContext;\r
 \r
@@ -599,8 +607,8 @@ BaseCrypto2HashFinal (
   //\r
   FreePool (HashCtx);\r
   Instance->HashInfoContext = NULL;\r
-  Instance->HashContext = NULL;\r
-  Instance->Updated = FALSE;\r
+  Instance->HashContext     = NULL;\r
+  Instance->Updated         = FALSE;\r
 \r
   if (!Ret) {\r
     return EFI_OUT_OF_RESOURCES;\r
index e0f42d34e324bf5b4cb246d416d4144b91006316..d1d5cd2b8c99138765c719333393e5e9604da33a 100644 (file)
 //\r
 // The payload length of HDD related ATA commands\r
 //\r
-#define HDD_PAYLOAD                     512\r
+#define HDD_PAYLOAD  512\r
 \r
-#define ATA_SECURITY_SET_PASSWORD_CMD   0xF1\r
-#define ATA_SECURITY_UNLOCK_CMD         0xF2\r
-#define ATA_SECURITY_FREEZE_LOCK_CMD    0xF5\r
-#define ATA_SECURITY_DIS_PASSWORD_CMD   0xF6\r
+#define ATA_SECURITY_SET_PASSWORD_CMD  0xF1\r
+#define ATA_SECURITY_UNLOCK_CMD        0xF2\r
+#define ATA_SECURITY_FREEZE_LOCK_CMD   0xF5\r
+#define ATA_SECURITY_DIS_PASSWORD_CMD  0xF6\r
 \r
 //\r
 // The max retry count specified in ATA 8 spec.\r
 //\r
-#define MAX_HDD_PASSWORD_RETRY_COUNT    5\r
+#define MAX_HDD_PASSWORD_RETRY_COUNT  5\r
 \r
 //\r
 // According to ATA spec, the max length of hdd password is 32 bytes\r
 //\r
-#define HDD_PASSWORD_MAX_LENGTH         32\r
+#define HDD_PASSWORD_MAX_LENGTH  32\r
 \r
-#define HDD_PASSWORD_DEVICE_INFO_GUID { 0x96d877ad, 0x48af, 0x4b39, { 0x9b, 0x27, 0x4d, 0x97, 0x43, 0x9, 0xae, 0x47 } }\r
+#define HDD_PASSWORD_DEVICE_INFO_GUID  { 0x96d877ad, 0x48af, 0x4b39, { 0x9b, 0x27, 0x4d, 0x97, 0x43, 0x9, 0xae, 0x47 } }\r
 \r
 typedef struct {\r
-  UINT8             Bus;\r
-  UINT8             Device;\r
-  UINT8             Function;\r
-  UINT8             Reserved;\r
-  UINT16            Port;\r
-  UINT16            PortMultiplierPort;\r
+  UINT8     Bus;\r
+  UINT8     Device;\r
+  UINT8     Function;\r
+  UINT8     Reserved;\r
+  UINT16    Port;\r
+  UINT16    PortMultiplierPort;\r
 } HDD_PASSWORD_DEVICE;\r
 \r
 //\r
index 32b55a6a8b7249a2698d935d7803964a0718bd14..a1a63b67a494b985d1e31b68f12ada0c70d93e02 100644 (file)
 \r
 #include "HddPasswordDxe.h"\r
 \r
-EFI_GUID   mHddPasswordVendorGuid          = HDD_PASSWORD_CONFIG_GUID;\r
-CHAR16     mHddPasswordVendorStorageName[] = L"HDD_PASSWORD_CONFIG";\r
-LIST_ENTRY mHddPasswordConfigFormList;\r
-UINT32     mNumberOfHddDevices = 0;\r
+EFI_GUID    mHddPasswordVendorGuid          = HDD_PASSWORD_CONFIG_GUID;\r
+CHAR16      mHddPasswordVendorStorageName[] = L"HDD_PASSWORD_CONFIG";\r
+LIST_ENTRY  mHddPasswordConfigFormList;\r
+UINT32      mNumberOfHddDevices = 0;\r
 \r
-EFI_GUID mHddPasswordDeviceInfoGuid = HDD_PASSWORD_DEVICE_INFO_GUID;\r
-BOOLEAN                         mHddPasswordEndOfDxe = FALSE;\r
-HDD_PASSWORD_REQUEST_VARIABLE   *mHddPasswordRequestVariable = NULL;\r
-UINTN                           mHddPasswordRequestVariableSize = 0;\r
+EFI_GUID                       mHddPasswordDeviceInfoGuid      = HDD_PASSWORD_DEVICE_INFO_GUID;\r
+BOOLEAN                        mHddPasswordEndOfDxe            = FALSE;\r
+HDD_PASSWORD_REQUEST_VARIABLE  *mHddPasswordRequestVariable    = NULL;\r
+UINTN                          mHddPasswordRequestVariableSize = 0;\r
 \r
-HII_VENDOR_DEVICE_PATH          mHddPasswordHiiVendorDevicePath = {\r
+HII_VENDOR_DEVICE_PATH  mHddPasswordHiiVendorDevicePath = {\r
   {\r
     {\r
       HARDWARE_DEVICE_PATH,\r
       HW_VENDOR_DP,\r
       {\r
-        (UINT8) (sizeof (VENDOR_DEVICE_PATH)),\r
-        (UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
+        (UINT8)(sizeof (VENDOR_DEVICE_PATH)),\r
+        (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
       }\r
     },\r
     HDD_PASSWORD_CONFIG_GUID\r
@@ -36,13 +36,12 @@ HII_VENDOR_DEVICE_PATH          mHddPasswordHiiVendorDevicePath = {
     END_DEVICE_PATH_TYPE,\r
     END_ENTIRE_DEVICE_PATH_SUBTYPE,\r
     {\r
-      (UINT8) (END_DEVICE_PATH_LENGTH),\r
-      (UINT8) ((END_DEVICE_PATH_LENGTH) >> 8)\r
+      (UINT8)(END_DEVICE_PATH_LENGTH),\r
+      (UINT8)((END_DEVICE_PATH_LENGTH) >> 8)\r
     }\r
   }\r
 };\r
 \r
-\r
 /**\r
   Check if the password is full zero.\r
 \r
@@ -54,10 +53,10 @@ HII_VENDOR_DEVICE_PATH          mHddPasswordHiiVendorDevicePath = {
 **/\r
 BOOLEAN\r
 PasswordIsFullZero (\r
-  IN CHAR8                    *Password\r
+  IN CHAR8  *Password\r
   )\r
 {\r
-  UINTN                       Index;\r
+  UINTN  Index;\r
 \r
   for (Index = 0; Index < HDD_PASSWORD_MAX_LENGTH; Index++) {\r
     if (Password[Index] != 0) {\r
@@ -77,17 +76,17 @@ PasswordIsFullZero (
 **/\r
 VOID\r
 SaveDeviceInfo (\r
-  IN     HDD_PASSWORD_CONFIG_FORM_ENTRY    *ConfigFormEntry,\r
-  IN OUT HDD_PASSWORD_DEVICE_INFO          *TempDevInfo\r
+  IN     HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry,\r
+  IN OUT HDD_PASSWORD_DEVICE_INFO        *TempDevInfo\r
   )\r
 {\r
-  TempDevInfo->Device.Bus                = (UINT8) ConfigFormEntry->Bus;\r
-  TempDevInfo->Device.Device             = (UINT8) ConfigFormEntry->Device;\r
-  TempDevInfo->Device.Function           = (UINT8) ConfigFormEntry->Function;\r
+  TempDevInfo->Device.Bus                = (UINT8)ConfigFormEntry->Bus;\r
+  TempDevInfo->Device.Device             = (UINT8)ConfigFormEntry->Device;\r
+  TempDevInfo->Device.Function           = (UINT8)ConfigFormEntry->Function;\r
   TempDevInfo->Device.Port               = ConfigFormEntry->Port;\r
   TempDevInfo->Device.PortMultiplierPort = ConfigFormEntry->PortMultiplierPort;\r
   CopyMem (TempDevInfo->Password, ConfigFormEntry->Password, HDD_PASSWORD_MAX_LENGTH);\r
-  TempDevInfo->DevicePathLength          = (UINT32) GetDevicePathSize (ConfigFormEntry->DevicePath);\r
+  TempDevInfo->DevicePathLength = (UINT32)GetDevicePathSize (ConfigFormEntry->DevicePath);\r
   CopyMem (TempDevInfo->DevicePath, ConfigFormEntry->DevicePath, TempDevInfo->DevicePathLength);\r
 }\r
 \r
@@ -100,17 +99,17 @@ BuildHddPasswordDeviceInfo (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  LIST_ENTRY                        *Entry;\r
-  HDD_PASSWORD_CONFIG_FORM_ENTRY    *ConfigFormEntry;\r
-  HDD_PASSWORD_DEVICE_INFO          *DevInfo;\r
-  HDD_PASSWORD_DEVICE_INFO          *TempDevInfo;\r
-  UINTN                             DevInfoLength;\r
-  UINT8                             DummyData;\r
-  BOOLEAN                           S3InitDevicesExist;\r
-  UINTN                             S3InitDevicesLength;\r
-  EFI_DEVICE_PATH_PROTOCOL          *S3InitDevices;\r
-  EFI_DEVICE_PATH_PROTOCOL          *S3InitDevicesBak;\r
+  EFI_STATUS                      Status;\r
+  LIST_ENTRY                      *Entry;\r
+  HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry;\r
+  HDD_PASSWORD_DEVICE_INFO        *DevInfo;\r
+  HDD_PASSWORD_DEVICE_INFO        *TempDevInfo;\r
+  UINTN                           DevInfoLength;\r
+  UINT8                           DummyData;\r
+  BOOLEAN                         S3InitDevicesExist;\r
+  UINTN                           S3InitDevicesLength;\r
+  EFI_DEVICE_PATH_PROTOCOL        *S3InitDevices;\r
+  EFI_DEVICE_PATH_PROTOCOL        *S3InitDevicesBak;\r
 \r
   //\r
   // Build HDD password device info and save them to LockBox.\r
@@ -126,7 +125,8 @@ BuildHddPasswordDeviceInfo (
     //\r
     if ((!PasswordIsFullZero (ConfigFormEntry->Password)) ||\r
         ((ConfigFormEntry->IfrData.SecurityStatus.Supported != 0) &&\r
-         (ConfigFormEntry->IfrData.SecurityStatus.Enabled == 0))) {\r
+         (ConfigFormEntry->IfrData.SecurityStatus.Enabled == 0)))\r
+    {\r
       DevInfoLength += sizeof (HDD_PASSWORD_DEVICE_INFO) +\r
                        GetDevicePathSize (ConfigFormEntry->DevicePath);\r
     }\r
@@ -137,11 +137,11 @@ BuildHddPasswordDeviceInfo (
   }\r
 \r
   S3InitDevicesLength = sizeof (DummyData);\r
-  Status = RestoreLockBox (\r
-             &gS3StorageDeviceInitListGuid,\r
-             &DummyData,\r
-             &S3InitDevicesLength\r
-             );\r
+  Status              = RestoreLockBox (\r
+                          &gS3StorageDeviceInitListGuid,\r
+                          &DummyData,\r
+                          &S3InitDevicesLength\r
+                          );\r
   ASSERT ((Status == EFI_NOT_FOUND) || (Status == EFI_BUFFER_TOO_SMALL));\r
   if (Status == EFI_NOT_FOUND) {\r
     S3InitDevices      = NULL;\r
@@ -170,7 +170,8 @@ BuildHddPasswordDeviceInfo (
 \r
     if ((!PasswordIsFullZero (ConfigFormEntry->Password)) ||\r
         ((ConfigFormEntry->IfrData.SecurityStatus.Supported != 0) &&\r
-         (ConfigFormEntry->IfrData.SecurityStatus.Enabled == 0))) {\r
+         (ConfigFormEntry->IfrData.SecurityStatus.Enabled == 0)))\r
+    {\r
       SaveDeviceInfo (ConfigFormEntry, TempDevInfo);\r
 \r
       S3InitDevicesBak = S3InitDevices;\r
@@ -181,11 +182,12 @@ BuildHddPasswordDeviceInfo (
       if (S3InitDevicesBak != NULL) {\r
         FreePool (S3InitDevicesBak);\r
       }\r
+\r
       ASSERT (S3InitDevices != NULL);\r
 \r
-      TempDevInfo = (HDD_PASSWORD_DEVICE_INFO *) ((UINTN)TempDevInfo +\r
-                                                  sizeof (HDD_PASSWORD_DEVICE_INFO) +\r
-                                                  TempDevInfo->DevicePathLength);\r
+      TempDevInfo = (HDD_PASSWORD_DEVICE_INFO *)((UINTN)TempDevInfo +\r
+                                                 sizeof (HDD_PASSWORD_DEVICE_INFO) +\r
+                                                 TempDevInfo->DevicePathLength);\r
     }\r
   }\r
 \r
@@ -247,9 +249,9 @@ BuildHddPasswordDeviceInfo (
 **/\r
 EFI_STATUS\r
 FreezeLockDevice (\r
-  IN EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort\r
+  IN EFI_ATA_PASS_THRU_PROTOCOL  *AtaPassThru,\r
+  IN UINT16                      Port,\r
+  IN UINT16                      PortMultiplierPort\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -284,7 +286,7 @@ FreezeLockDevice (
   ZeroMem (&Acb, sizeof (Acb));\r
   ZeroMem (Asb, sizeof (EFI_ATA_STATUS_BLOCK));\r
   Acb.AtaCommand    = ATA_SECURITY_FREEZE_LOCK_CMD;\r
-  Acb.AtaDeviceHead = (UINT8) (PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
+  Acb.AtaDeviceHead = (UINT8)(PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
 \r
   //\r
   // Prepare for ATA pass through packet.\r
@@ -305,7 +307,8 @@ FreezeLockDevice (
                           );\r
   if (!EFI_ERROR (Status) &&\r
       ((Asb->AtaStatus & ATA_STSREG_ERR) != 0) &&\r
-      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0)) {\r
+      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0))\r
+  {\r
     Status = EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -332,10 +335,10 @@ FreezeLockDevice (
 **/\r
 EFI_STATUS\r
 GetHddDeviceIdentifyData (\r
-  IN  EFI_ATA_PASS_THRU_PROTOCOL    *AtaPassThru,\r
-  IN  UINT16                        Port,\r
-  IN  UINT16                        PortMultiplierPort,\r
-  IN  ATA_IDENTIFY_DATA             *IdentifyData\r
+  IN  EFI_ATA_PASS_THRU_PROTOCOL  *AtaPassThru,\r
+  IN  UINT16                      Port,\r
+  IN  UINT16                      PortMultiplierPort,\r
+  IN  ATA_IDENTIFY_DATA           *IdentifyData\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -370,16 +373,16 @@ GetHddDeviceIdentifyData (
   ZeroMem (&Acb, sizeof (Acb));\r
   ZeroMem (Asb, sizeof (EFI_ATA_STATUS_BLOCK));\r
   Acb.AtaCommand    = ATA_CMD_IDENTIFY_DRIVE;\r
-  Acb.AtaDeviceHead = (UINT8) (BIT7 | BIT6 | BIT5 | (PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4)));\r
+  Acb.AtaDeviceHead = (UINT8)(BIT7 | BIT6 | BIT5 | (PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4)));\r
 \r
   //\r
   // Prepare for ATA pass through packet.\r
   //\r
   ZeroMem (&Packet, sizeof (Packet));\r
-  Packet.Protocol = EFI_ATA_PASS_THRU_PROTOCOL_PIO_DATA_IN;\r
-  Packet.Length   = EFI_ATA_PASS_THRU_LENGTH_BYTES | EFI_ATA_PASS_THRU_LENGTH_SECTOR_COUNT;\r
-  Packet.Asb      = Asb;\r
-  Packet.Acb      = &Acb;\r
+  Packet.Protocol         = EFI_ATA_PASS_THRU_PROTOCOL_PIO_DATA_IN;\r
+  Packet.Length           = EFI_ATA_PASS_THRU_LENGTH_BYTES | EFI_ATA_PASS_THRU_LENGTH_SECTOR_COUNT;\r
+  Packet.Asb              = Asb;\r
+  Packet.Acb              = &Acb;\r
   Packet.InDataBuffer     = IdentifyData;\r
   Packet.InTransferLength = sizeof (ATA_IDENTIFY_DATA);\r
   Packet.Timeout          = ATA_TIMEOUT;\r
@@ -410,10 +413,10 @@ GetHddPasswordSecurityStatus (
   IN OUT HDD_PASSWORD_CONFIG  *IfrData\r
   )\r
 {\r
-  IfrData->SecurityStatus.Supported = (IdentifyData->command_set_supported_82 & BIT1) ? 1 : 0;\r
-  IfrData->SecurityStatus.Enabled   = (IdentifyData->security_status & BIT1) ? 1 : 0;\r
-  IfrData->SecurityStatus.Locked    = (IdentifyData->security_status & BIT2) ? 1 : 0;\r
-  IfrData->SecurityStatus.Frozen    = (IdentifyData->security_status & BIT3) ? 1 : 0;\r
+  IfrData->SecurityStatus.Supported            = (IdentifyData->command_set_supported_82 & BIT1) ? 1 : 0;\r
+  IfrData->SecurityStatus.Enabled              = (IdentifyData->security_status & BIT1) ? 1 : 0;\r
+  IfrData->SecurityStatus.Locked               = (IdentifyData->security_status & BIT2) ? 1 : 0;\r
+  IfrData->SecurityStatus.Frozen               = (IdentifyData->security_status & BIT3) ? 1 : 0;\r
   IfrData->SecurityStatus.UserPasswordStatus   = IfrData->SecurityStatus.Enabled;\r
   IfrData->SecurityStatus.MasterPasswordStatus = IfrData->SecurityStatus.Supported;\r
 \r
@@ -437,14 +440,14 @@ GetHddPasswordSecurityStatus (
 VOID\r
 EFIAPI\r
 HddPasswordEndOfDxeEventNotify (\r
-  EFI_EVENT                               Event,\r
-  VOID                                    *Context\r
+  EFI_EVENT  Event,\r
+  VOID       *Context\r
   )\r
 {\r
-  LIST_ENTRY                        *Entry;\r
-  HDD_PASSWORD_CONFIG_FORM_ENTRY    *ConfigFormEntry;\r
-  EFI_STATUS                        Status;\r
-  ATA_IDENTIFY_DATA                 IdentifyData;\r
+  LIST_ENTRY                      *Entry;\r
+  HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry;\r
+  EFI_STATUS                      Status;\r
+  ATA_IDENTIFY_DATA               IdentifyData;\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
@@ -456,7 +459,7 @@ HddPasswordEndOfDxeEventNotify (
     // as the HDD password requests should have been processed.\r
     //\r
     FreePool (mHddPasswordRequestVariable);\r
-    mHddPasswordRequestVariable = NULL;\r
+    mHddPasswordRequestVariable     = NULL;\r
     mHddPasswordRequestVariableSize = 0;\r
   }\r
 \r
@@ -486,7 +489,8 @@ HddPasswordEndOfDxeEventNotify (
     //\r
     if ((ConfigFormEntry->IfrData.SecurityStatus.Supported != 0) &&\r
         (ConfigFormEntry->IfrData.SecurityStatus.Locked == 0) &&\r
-        (ConfigFormEntry->IfrData.SecurityStatus.Frozen == 0)) {\r
+        (ConfigFormEntry->IfrData.SecurityStatus.Frozen == 0))\r
+    {\r
       Status = FreezeLockDevice (ConfigFormEntry->AtaPassThru, ConfigFormEntry->Port, ConfigFormEntry->PortMultiplierPort);\r
       DEBUG ((DEBUG_INFO, "FreezeLockDevice return %r!\n", Status));\r
       Status = GetHddDeviceIdentifyData (\r
@@ -533,20 +537,20 @@ GenSalt (
 **/\r
 BOOLEAN\r
 GenerateCredential (\r
-  IN      UINT8               *Buffer,\r
-  IN      UINTN               BufferSize,\r
-  IN      UINT8               *SaltValue,\r
-     OUT  UINT8               *Credential\r
+  IN      UINT8  *Buffer,\r
+  IN      UINTN  BufferSize,\r
+  IN      UINT8  *SaltValue,\r
+  OUT  UINT8     *Credential\r
   )\r
 {\r
-  BOOLEAN                     Status;\r
-  UINTN                       HashSize;\r
-  VOID                        *Hash;\r
-  VOID                        *HashData;\r
+  BOOLEAN  Status;\r
+  UINTN    HashSize;\r
+  VOID     *Hash;\r
+  VOID     *HashData;\r
 \r
-  Hash      = NULL;\r
-  HashData  = NULL;\r
-  Status    = FALSE;\r
+  Hash     = NULL;\r
+  HashData = NULL;\r
+  Status   = FALSE;\r
 \r
   HashSize = Sha256GetContextSize ();\r
   Hash     = AllocateZeroPool (HashSize);\r
@@ -567,7 +571,7 @@ GenerateCredential (
   }\r
 \r
   CopyMem (HashData, SaltValue, PASSWORD_SALT_SIZE);\r
-  CopyMem ((UINT8 *) HashData + PASSWORD_SALT_SIZE, Buffer, BufferSize);\r
+  CopyMem ((UINT8 *)HashData + PASSWORD_SALT_SIZE, Buffer, BufferSize);\r
 \r
   Status = Sha256Update (Hash, HashData, PASSWORD_SALT_SIZE + BufferSize);\r
   if (!Status) {\r
@@ -580,10 +584,12 @@ Done:
   if (Hash != NULL) {\r
     FreePool (Hash);\r
   }\r
+\r
   if (HashData != NULL) {\r
     ZeroMem (HashData, PASSWORD_SALT_SIZE + BufferSize);\r
     FreePool (HashData);\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -597,22 +603,22 @@ Done:
 **/\r
 VOID\r
 SaveHddPasswordVariable (\r
-  IN HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry,\r
-  IN CHAR8                          *Password\r
+  IN HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry,\r
+  IN CHAR8                           *Password\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  HDD_PASSWORD_VARIABLE             *TempVariable;\r
-  UINTN                             TempVariableSize;\r
-  HDD_PASSWORD_VARIABLE             *NextNode;\r
-  HDD_PASSWORD_VARIABLE             *Variable;\r
-  UINTN                             VariableSize;\r
-  HDD_PASSWORD_VARIABLE             *NewVariable;\r
-  UINTN                             NewVariableSize;\r
-  BOOLEAN                           Delete;\r
-  BOOLEAN                           HashOk;\r
-  UINT8                             HashData[SHA256_DIGEST_SIZE];\r
-  UINT8                             SaltData[PASSWORD_SALT_SIZE];\r
+  EFI_STATUS             Status;\r
+  HDD_PASSWORD_VARIABLE  *TempVariable;\r
+  UINTN                  TempVariableSize;\r
+  HDD_PASSWORD_VARIABLE  *NextNode;\r
+  HDD_PASSWORD_VARIABLE  *Variable;\r
+  UINTN                  VariableSize;\r
+  HDD_PASSWORD_VARIABLE  *NewVariable;\r
+  UINTN                  NewVariableSize;\r
+  BOOLEAN                Delete;\r
+  BOOLEAN                HashOk;\r
+  UINT8                  HashData[SHA256_DIGEST_SIZE];\r
+  UINT8                  SaltData[PASSWORD_SALT_SIZE];\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
@@ -624,7 +630,7 @@ SaveHddPasswordVariable (
     ZeroMem (HashData, sizeof (HashData));\r
     ZeroMem (SaltData, sizeof (SaltData));\r
     GenSalt (SaltData);\r
-    HashOk = GenerateCredential ((UINT8 *) Password, HDD_PASSWORD_MAX_LENGTH, SaltData, HashData);\r
+    HashOk = GenerateCredential ((UINT8 *)Password, HDD_PASSWORD_MAX_LENGTH, SaltData, HashData);\r
     if (!HashOk) {\r
       DEBUG ((DEBUG_INFO, "GenerateCredential failed\n"));\r
       return;\r
@@ -637,40 +643,43 @@ SaveHddPasswordVariable (
     Delete = TRUE;\r
   }\r
 \r
-  Variable = NULL;\r
-  VariableSize = 0;\r
-  NewVariable = NULL;\r
+  Variable        = NULL;\r
+  VariableSize    = 0;\r
+  NewVariable     = NULL;\r
   NewVariableSize = 0;\r
 \r
   Status = GetVariable2 (\r
              HDD_PASSWORD_VARIABLE_NAME,\r
              &mHddPasswordVendorGuid,\r
-             (VOID **) &Variable,\r
+             (VOID **)&Variable,\r
              &VariableSize\r
              );\r
   if (Delete) {\r
     if (!EFI_ERROR (Status) && (Variable != NULL)) {\r
-      TempVariable = Variable;\r
+      TempVariable     = Variable;\r
       TempVariableSize = VariableSize;\r
       while (TempVariableSize >= sizeof (HDD_PASSWORD_VARIABLE)) {\r
         if ((TempVariable->Device.Bus                == ConfigFormEntry->Bus) &&\r
             (TempVariable->Device.Device             == ConfigFormEntry->Device) &&\r
             (TempVariable->Device.Function           == ConfigFormEntry->Function) &&\r
             (TempVariable->Device.Port               == ConfigFormEntry->Port) &&\r
-            (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort)) {\r
+            (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort))\r
+        {\r
           //\r
           // Found the node for the HDD password device.\r
           // Delete the node.\r
           //\r
           NextNode = TempVariable + 1;\r
-          CopyMem (TempVariable, NextNode, (UINTN) Variable + VariableSize - (UINTN) NextNode);\r
-          NewVariable = Variable;\r
+          CopyMem (TempVariable, NextNode, (UINTN)Variable + VariableSize - (UINTN)NextNode);\r
+          NewVariable     = Variable;\r
           NewVariableSize = VariableSize - sizeof (HDD_PASSWORD_VARIABLE);\r
           break;\r
         }\r
+\r
         TempVariableSize -= sizeof (HDD_PASSWORD_VARIABLE);\r
-        TempVariable += 1;\r
+        TempVariable     += 1;\r
       }\r
+\r
       if (NewVariable == NULL) {\r
         DEBUG ((DEBUG_INFO, "The variable node for the HDD password device is not found\n"));\r
       }\r
@@ -679,40 +688,43 @@ SaveHddPasswordVariable (
     }\r
   } else {\r
     if (!EFI_ERROR (Status) && (Variable != NULL)) {\r
-      TempVariable = Variable;\r
+      TempVariable     = Variable;\r
       TempVariableSize = VariableSize;\r
       while (TempVariableSize >= sizeof (HDD_PASSWORD_VARIABLE)) {\r
         if ((TempVariable->Device.Bus                == ConfigFormEntry->Bus) &&\r
             (TempVariable->Device.Device             == ConfigFormEntry->Device) &&\r
             (TempVariable->Device.Function           == ConfigFormEntry->Function) &&\r
             (TempVariable->Device.Port               == ConfigFormEntry->Port) &&\r
-            (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort)) {\r
+            (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort))\r
+        {\r
           //\r
           // Found the node for the HDD password device.\r
           // Update the node.\r
           //\r
           CopyMem (TempVariable->PasswordHash, HashData, sizeof (HashData));\r
           CopyMem (TempVariable->PasswordSalt, SaltData, sizeof (SaltData));\r
-          NewVariable = Variable;\r
+          NewVariable     = Variable;\r
           NewVariableSize = VariableSize;\r
           break;\r
         }\r
+\r
         TempVariableSize -= sizeof (HDD_PASSWORD_VARIABLE);\r
-        TempVariable += 1;\r
+        TempVariable     += 1;\r
       }\r
+\r
       if (NewVariable == NULL) {\r
         //\r
         // The node for the HDD password device is not found.\r
         // Create node for the HDD password device.\r
         //\r
         NewVariableSize = VariableSize + sizeof (HDD_PASSWORD_VARIABLE);\r
-        NewVariable = AllocateZeroPool (NewVariableSize);\r
+        NewVariable     = AllocateZeroPool (NewVariableSize);\r
         ASSERT (NewVariable != NULL);\r
         CopyMem (NewVariable, Variable, VariableSize);\r
-        TempVariable = (HDD_PASSWORD_VARIABLE *) ((UINTN) NewVariable + VariableSize);\r
-        TempVariable->Device.Bus                = (UINT8) ConfigFormEntry->Bus;\r
-        TempVariable->Device.Device             = (UINT8) ConfigFormEntry->Device;\r
-        TempVariable->Device.Function           = (UINT8) ConfigFormEntry->Function;\r
+        TempVariable                            = (HDD_PASSWORD_VARIABLE *)((UINTN)NewVariable + VariableSize);\r
+        TempVariable->Device.Bus                = (UINT8)ConfigFormEntry->Bus;\r
+        TempVariable->Device.Device             = (UINT8)ConfigFormEntry->Device;\r
+        TempVariable->Device.Function           = (UINT8)ConfigFormEntry->Function;\r
         TempVariable->Device.Port               = ConfigFormEntry->Port;\r
         TempVariable->Device.PortMultiplierPort = ConfigFormEntry->PortMultiplierPort;\r
         CopyMem (TempVariable->PasswordHash, HashData, sizeof (HashData));\r
@@ -720,11 +732,11 @@ SaveHddPasswordVariable (
       }\r
     } else {\r
       NewVariableSize = sizeof (HDD_PASSWORD_VARIABLE);\r
-      NewVariable = AllocateZeroPool (NewVariableSize);\r
+      NewVariable     = AllocateZeroPool (NewVariableSize);\r
       ASSERT (NewVariable != NULL);\r
-      NewVariable->Device.Bus                = (UINT8) ConfigFormEntry->Bus;\r
-      NewVariable->Device.Device             = (UINT8) ConfigFormEntry->Device;\r
-      NewVariable->Device.Function           = (UINT8) ConfigFormEntry->Function;\r
+      NewVariable->Device.Bus                = (UINT8)ConfigFormEntry->Bus;\r
+      NewVariable->Device.Device             = (UINT8)ConfigFormEntry->Device;\r
+      NewVariable->Device.Function           = (UINT8)ConfigFormEntry->Function;\r
       NewVariable->Device.Port               = ConfigFormEntry->Port;\r
       NewVariable->Device.PortMultiplierPort = ConfigFormEntry->PortMultiplierPort;\r
       CopyMem (NewVariable->PasswordHash, HashData, sizeof (HashData));\r
@@ -748,6 +760,7 @@ SaveHddPasswordVariable (
   if (NewVariable != Variable) {\r
     FreePool (NewVariable);\r
   }\r
+\r
   if (Variable != NULL) {\r
     FreePool (Variable);\r
   }\r
@@ -768,25 +781,25 @@ SaveHddPasswordVariable (
 **/\r
 BOOLEAN\r
 GetSavedHddPasswordVariable (\r
-  IN  HDD_PASSWORD_CONFIG_FORM_ENTRY    *ConfigFormEntry,\r
-  OUT HDD_PASSWORD_VARIABLE             *HddPasswordVariable\r
+  IN  HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry,\r
+  OUT HDD_PASSWORD_VARIABLE           *HddPasswordVariable\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  HDD_PASSWORD_VARIABLE             *TempVariable;\r
-  HDD_PASSWORD_VARIABLE             *Variable;\r
-  UINTN                             VariableSize;\r
-  BOOLEAN                           Found;\r
+  EFI_STATUS             Status;\r
+  HDD_PASSWORD_VARIABLE  *TempVariable;\r
+  HDD_PASSWORD_VARIABLE  *Variable;\r
+  UINTN                  VariableSize;\r
+  BOOLEAN                Found;\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
-  Variable = NULL;\r
+  Variable     = NULL;\r
   VariableSize = 0;\r
 \r
   Status = GetVariable2 (\r
              HDD_PASSWORD_VARIABLE_NAME,\r
              &mHddPasswordVendorGuid,\r
-             (VOID **) &Variable,\r
+             (VOID **)&Variable,\r
              &VariableSize\r
              );\r
   if (EFI_ERROR (Status) || (Variable == NULL)) {\r
@@ -794,14 +807,15 @@ GetSavedHddPasswordVariable (
     return FALSE;\r
   }\r
 \r
-  Found = FALSE;\r
+  Found        = FALSE;\r
   TempVariable = Variable;\r
   while (VariableSize >= sizeof (HDD_PASSWORD_VARIABLE)) {\r
     if ((TempVariable->Device.Bus                == ConfigFormEntry->Bus) &&\r
         (TempVariable->Device.Device             == ConfigFormEntry->Device) &&\r
         (TempVariable->Device.Function           == ConfigFormEntry->Function) &&\r
         (TempVariable->Device.Port               == ConfigFormEntry->Port) &&\r
-        (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort)) {\r
+        (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort))\r
+    {\r
       //\r
       // Found the node for the HDD password device.\r
       // Get the node.\r
@@ -810,6 +824,7 @@ GetSavedHddPasswordVariable (
       Found = TRUE;\r
       break;\r
     }\r
+\r
     VariableSize -= sizeof (HDD_PASSWORD_VARIABLE);\r
     TempVariable += 1;\r
   }\r
@@ -840,14 +855,14 @@ GetSavedHddPasswordVariable (
 **/\r
 EFI_STATUS\r
 ValidateHddPassword (\r
-  IN HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry,\r
-  IN CHAR8                          *Password\r
+  IN HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry,\r
+  IN CHAR8                           *Password\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  HDD_PASSWORD_VARIABLE             HddPasswordVariable;\r
-  BOOLEAN                           HashOk;\r
-  UINT8                             HashData[SHA256_DIGEST_SIZE];\r
+  EFI_STATUS             Status;\r
+  HDD_PASSWORD_VARIABLE  HddPasswordVariable;\r
+  BOOLEAN                HashOk;\r
+  UINT8                  HashData[SHA256_DIGEST_SIZE];\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
@@ -857,7 +872,7 @@ ValidateHddPassword (
   }\r
 \r
   ZeroMem (HashData, sizeof (HashData));\r
-  HashOk = GenerateCredential ((UINT8 *) Password, HDD_PASSWORD_MAX_LENGTH, HddPasswordVariable.PasswordSalt, HashData);\r
+  HashOk = GenerateCredential ((UINT8 *)Password, HDD_PASSWORD_MAX_LENGTH, HddPasswordVariable.PasswordSalt, HashData);\r
   if (!HashOk) {\r
     DEBUG ((DEBUG_INFO, "GenerateCredential failed\n"));\r
     return EFI_DEVICE_ERROR;\r
@@ -891,11 +906,11 @@ ValidateHddPassword (
 **/\r
 EFI_STATUS\r
 UnlockHddPassword (\r
-  IN EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort,\r
-  IN CHAR8                          Identifier,\r
-  IN CHAR8                          *Password\r
+  IN EFI_ATA_PASS_THRU_PROTOCOL  *AtaPassThru,\r
+  IN UINT16                      Port,\r
+  IN UINT16                      PortMultiplierPort,\r
+  IN CHAR8                       Identifier,\r
+  IN CHAR8                       *Password\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -931,7 +946,7 @@ UnlockHddPassword (
   ZeroMem (&Acb, sizeof (Acb));\r
   ZeroMem (Asb, sizeof (EFI_ATA_STATUS_BLOCK));\r
   Acb.AtaCommand    = ATA_SECURITY_UNLOCK_CMD;\r
-  Acb.AtaDeviceHead = (UINT8) (PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
+  Acb.AtaDeviceHead = (UINT8)(PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
 \r
   //\r
   // Prepare for ATA pass through packet.\r
@@ -942,8 +957,8 @@ UnlockHddPassword (
   Packet.Asb      = Asb;\r
   Packet.Acb      = &Acb;\r
 \r
-  ((CHAR16 *) Buffer)[0] = Identifier & BIT0;\r
-  CopyMem (&((CHAR16 *) Buffer)[1], Password, HDD_PASSWORD_MAX_LENGTH);\r
+  ((CHAR16 *)Buffer)[0] = Identifier & BIT0;\r
+  CopyMem (&((CHAR16 *)Buffer)[1], Password, HDD_PASSWORD_MAX_LENGTH);\r
 \r
   Packet.OutDataBuffer     = Buffer;\r
   Packet.OutTransferLength = sizeof (Buffer);\r
@@ -958,7 +973,8 @@ UnlockHddPassword (
                           );\r
   if (!EFI_ERROR (Status) &&\r
       ((Asb->AtaStatus & ATA_STSREG_ERR) != 0) &&\r
-      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0)) {\r
+      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0))\r
+  {\r
     Status = EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -988,11 +1004,11 @@ UnlockHddPassword (
 **/\r
 EFI_STATUS\r
 DisableHddPassword (\r
-  IN EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort,\r
-  IN CHAR8                          Identifier,\r
-  IN CHAR8                          *Password\r
+  IN EFI_ATA_PASS_THRU_PROTOCOL  *AtaPassThru,\r
+  IN UINT16                      Port,\r
+  IN UINT16                      PortMultiplierPort,\r
+  IN CHAR8                       Identifier,\r
+  IN CHAR8                       *Password\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -1028,7 +1044,7 @@ DisableHddPassword (
   ZeroMem (&Acb, sizeof (Acb));\r
   ZeroMem (Asb, sizeof (EFI_ATA_STATUS_BLOCK));\r
   Acb.AtaCommand    = ATA_SECURITY_DIS_PASSWORD_CMD;\r
-  Acb.AtaDeviceHead = (UINT8) (PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
+  Acb.AtaDeviceHead = (UINT8)(PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
 \r
   //\r
   // Prepare for ATA pass through packet.\r
@@ -1039,8 +1055,8 @@ DisableHddPassword (
   Packet.Asb      = Asb;\r
   Packet.Acb      = &Acb;\r
 \r
-  ((CHAR16 *) Buffer)[0] = Identifier & BIT0;\r
-  CopyMem (&((CHAR16 *) Buffer)[1], Password, HDD_PASSWORD_MAX_LENGTH);\r
+  ((CHAR16 *)Buffer)[0] = Identifier & BIT0;\r
+  CopyMem (&((CHAR16 *)Buffer)[1], Password, HDD_PASSWORD_MAX_LENGTH);\r
 \r
   Packet.OutDataBuffer     = Buffer;\r
   Packet.OutTransferLength = sizeof (Buffer);\r
@@ -1055,7 +1071,8 @@ DisableHddPassword (
                           );\r
   if (!EFI_ERROR (Status) &&\r
       ((Asb->AtaStatus & ATA_STSREG_ERR) != 0) &&\r
-      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0)) {\r
+      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0))\r
+  {\r
     Status = EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -1087,13 +1104,13 @@ DisableHddPassword (
 **/\r
 EFI_STATUS\r
 SetHddPassword (\r
-  IN EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort,\r
-  IN CHAR8                          Identifier,\r
-  IN CHAR8                          SecurityLevel,\r
-  IN CHAR16                         MasterPasswordIdentifier,\r
-  IN CHAR8                          *Password\r
+  IN EFI_ATA_PASS_THRU_PROTOCOL  *AtaPassThru,\r
+  IN UINT16                      Port,\r
+  IN UINT16                      PortMultiplierPort,\r
+  IN CHAR8                       Identifier,\r
+  IN CHAR8                       SecurityLevel,\r
+  IN CHAR16                      MasterPasswordIdentifier,\r
+  IN CHAR8                       *Password\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -1129,7 +1146,7 @@ SetHddPassword (
   ZeroMem (&Acb, sizeof (Acb));\r
   ZeroMem (Asb, sizeof (EFI_ATA_STATUS_BLOCK));\r
   Acb.AtaCommand    = ATA_SECURITY_SET_PASSWORD_CMD;\r
-  Acb.AtaDeviceHead = (UINT8) (PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
+  Acb.AtaDeviceHead = (UINT8)(PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
 \r
   //\r
   // Prepare for ATA pass through packet.\r
@@ -1140,10 +1157,10 @@ SetHddPassword (
   Packet.Asb      = Asb;\r
   Packet.Acb      = &Acb;\r
 \r
-  ((CHAR16 *) Buffer)[0] = (Identifier | (UINT16)(SecurityLevel << 8)) & (BIT0 | BIT8);\r
-  CopyMem (&((CHAR16 *) Buffer)[1], Password, HDD_PASSWORD_MAX_LENGTH);\r
+  ((CHAR16 *)Buffer)[0] = (Identifier | (UINT16)(SecurityLevel << 8)) & (BIT0 | BIT8);\r
+  CopyMem (&((CHAR16 *)Buffer)[1], Password, HDD_PASSWORD_MAX_LENGTH);\r
   if ((Identifier & BIT0) != 0) {\r
-    ((CHAR16 *) Buffer)[17] = MasterPasswordIdentifier;\r
+    ((CHAR16 *)Buffer)[17] = MasterPasswordIdentifier;\r
   }\r
 \r
   Packet.OutDataBuffer     = Buffer;\r
@@ -1159,7 +1176,8 @@ SetHddPassword (
                           );\r
   if (!EFI_ERROR (Status) &&\r
       ((Asb->AtaStatus & ATA_STSREG_ERR) != 0) &&\r
-      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0)) {\r
+      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0))\r
+  {\r
     Status = EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -1180,19 +1198,19 @@ SetHddPassword (
 **/\r
 VOID\r
 GetHddDeviceModelNumber (\r
-  IN ATA_IDENTIFY_DATA             *IdentifyData,\r
-  IN OUT CHAR16                    *String\r
+  IN ATA_IDENTIFY_DATA  *IdentifyData,\r
+  IN OUT CHAR16         *String\r
   )\r
 {\r
-  UINTN             Index;\r
+  UINTN  Index;\r
 \r
   //\r
   // Swap the byte order in the original module name.\r
   // From Ata spec, the maximum length is 40 bytes.\r
   //\r
   for (Index = 0; Index < 40; Index += 2) {\r
-    String[Index]      = IdentifyData->ModelName[Index + 1];\r
-    String[Index + 1]  = IdentifyData->ModelName[Index];\r
+    String[Index]     = IdentifyData->ModelName[Index + 1];\r
+    String[Index + 1] = IdentifyData->ModelName[Index];\r
   }\r
 \r
   //\r
@@ -1200,7 +1218,7 @@ GetHddDeviceModelNumber (
   //\r
   String[20] = L'\0';\r
 \r
-  return ;\r
+  return;\r
 }\r
 \r
 /**\r
@@ -1216,22 +1234,22 @@ GetHddDeviceModelNumber (
 **/\r
 EFI_STATUS\r
 PopupHddPasswordInputWindows (\r
-  IN CHAR16         *PopUpString1,\r
-  IN CHAR16         *PopUpString2,\r
-  IN OUT CHAR8      *Password\r
+  IN CHAR16     *PopUpString1,\r
+  IN CHAR16     *PopUpString2,\r
+  IN OUT CHAR8  *Password\r
   )\r
 {\r
-  EFI_INPUT_KEY Key;\r
-  UINTN         Length;\r
-  CHAR16        Mask[HDD_PASSWORD_MAX_LENGTH + 1];\r
-  CHAR16        Unicode[HDD_PASSWORD_MAX_LENGTH + 1];\r
-  CHAR8         Ascii[HDD_PASSWORD_MAX_LENGTH + 1];\r
+  EFI_INPUT_KEY  Key;\r
+  UINTN          Length;\r
+  CHAR16         Mask[HDD_PASSWORD_MAX_LENGTH + 1];\r
+  CHAR16         Unicode[HDD_PASSWORD_MAX_LENGTH + 1];\r
+  CHAR8          Ascii[HDD_PASSWORD_MAX_LENGTH + 1];\r
 \r
   ZeroMem (Unicode, sizeof (Unicode));\r
   ZeroMem (Ascii, sizeof (Ascii));\r
   ZeroMem (Mask, sizeof (Mask));\r
 \r
-  gST->ConOut->ClearScreen(gST->ConOut);\r
+  gST->ConOut->ClearScreen (gST->ConOut);\r
 \r
   Length = 0;\r
   while (TRUE) {\r
@@ -1244,7 +1262,7 @@ PopupHddPasswordInputWindows (
         L"---------------------",\r
         Mask,\r
         NULL\r
-      );\r
+        );\r
     } else {\r
       CreatePopUp (\r
         EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
@@ -1254,8 +1272,9 @@ PopupHddPasswordInputWindows (
         L"---------------------",\r
         Mask,\r
         NULL\r
-      );\r
+        );\r
     }\r
+\r
     //\r
     // Check key.\r
     //\r
@@ -1269,25 +1288,26 @@ PopupHddPasswordInputWindows (
       } else if ((Key.UnicodeChar == CHAR_NULL) ||\r
                  (Key.UnicodeChar == CHAR_TAB) ||\r
                  (Key.UnicodeChar == CHAR_LINEFEED)\r
-                 ) {\r
+                 )\r
+      {\r
         continue;\r
       } else {\r
         if (Key.UnicodeChar == CHAR_BACKSPACE) {\r
           if (Length > 0) {\r
             Unicode[Length] = 0;\r
-            Mask[Length] = 0;\r
+            Mask[Length]    = 0;\r
             Length--;\r
           }\r
         } else {\r
           Unicode[Length] = Key.UnicodeChar;\r
-          Mask[Length] = L'*';\r
+          Mask[Length]    = L'*';\r
           Length++;\r
           if (Length == HDD_PASSWORD_MAX_LENGTH) {\r
             //\r
             // Add the null terminator.\r
             //\r
             Unicode[Length] = 0;\r
-            Mask[Length] = 0;\r
+            Mask[Length]    = 0;\r
             break;\r
           }\r
         }\r
@@ -1297,7 +1317,7 @@ PopupHddPasswordInputWindows (
     if (Key.ScanCode == SCAN_ESC) {\r
       ZeroMem (Unicode, sizeof (Unicode));\r
       ZeroMem (Ascii, sizeof (Ascii));\r
-      gST->ConOut->ClearScreen(gST->ConOut);\r
+      gST->ConOut->ClearScreen (gST->ConOut);\r
       return EFI_ABORTED;\r
     }\r
   }\r
@@ -1307,7 +1327,7 @@ PopupHddPasswordInputWindows (
   ZeroMem (Unicode, sizeof (Unicode));\r
   ZeroMem (Ascii, sizeof (Ascii));\r
 \r
-  gST->ConOut->ClearScreen(gST->ConOut);\r
+  gST->ConOut->ClearScreen (gST->ConOut);\r
   return EFI_SUCCESS;\r
 }\r
 \r
@@ -1322,18 +1342,18 @@ PopupHddPasswordInputWindows (
 **/\r
 VOID\r
 HddPasswordRequestPassword (\r
-  IN EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort,\r
-  IN HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry\r
+  IN EFI_ATA_PASS_THRU_PROTOCOL      *AtaPassThru,\r
+  IN UINT16                          Port,\r
+  IN UINT16                          PortMultiplierPort,\r
+  IN HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  CHAR16                            PopUpString[100];\r
-  ATA_IDENTIFY_DATA                 IdentifyData;\r
-  EFI_INPUT_KEY                     Key;\r
-  UINT16                            RetryCount;\r
-  CHAR8                             Password[HDD_PASSWORD_MAX_LENGTH];\r
+  EFI_STATUS         Status;\r
+  CHAR16             PopUpString[100];\r
+  ATA_IDENTIFY_DATA  IdentifyData;\r
+  EFI_INPUT_KEY      Key;\r
+  UINT16             RetryCount;\r
+  CHAR8              Password[HDD_PASSWORD_MAX_LENGTH];\r
 \r
   RetryCount = 0;\r
 \r
@@ -1345,23 +1365,24 @@ HddPasswordRequestPassword (
   // Check the device security status.\r
   //\r
   if ((ConfigFormEntry->IfrData.SecurityStatus.Supported) &&\r
-      (ConfigFormEntry->IfrData.SecurityStatus.Enabled)) {\r
-\r
-     //\r
-     // Add PcdSkipHddPasswordPrompt to determin whether to skip password prompt.\r
-     // Due to board design, device may not power off during system warm boot, which result in\r
-     // security status remain unlocked status, hence we add device security status check here.\r
-     //\r
-     // If device is in the locked status, device keeps locked and system continues booting.\r
-     // If device is in the unlocked status, system is forced shutdown for security concern.\r
-     //\r
-     if (PcdGetBool (PcdSkipHddPasswordPrompt)) {\r
-       if (ConfigFormEntry->IfrData.SecurityStatus.Locked) {\r
-         return;\r
-       } else {\r
-         gRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL);\r
-       }\r
+      (ConfigFormEntry->IfrData.SecurityStatus.Enabled))\r
+  {\r
+    //\r
+    // Add PcdSkipHddPasswordPrompt to determin whether to skip password prompt.\r
+    // Due to board design, device may not power off during system warm boot, which result in\r
+    // security status remain unlocked status, hence we add device security status check here.\r
+    //\r
+    // If device is in the locked status, device keeps locked and system continues booting.\r
+    // If device is in the unlocked status, system is forced shutdown for security concern.\r
+    //\r
+    if (PcdGetBool (PcdSkipHddPasswordPrompt)) {\r
+      if (ConfigFormEntry->IfrData.SecurityStatus.Locked) {\r
+        return;\r
+      } else {\r
+        gRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL);\r
+      }\r
     }\r
+\r
     //\r
     // As soon as the HDD password is in enabled state, we pop up a window to unlock hdd\r
     // no matter it's really in locked or unlocked state.\r
@@ -1386,11 +1407,13 @@ HddPasswordRequestPassword (
         } else {\r
           Status = EFI_INVALID_PARAMETER;\r
         }\r
+\r
         if (!EFI_ERROR (Status)) {\r
           CopyMem (ConfigFormEntry->Password, Password, HDD_PASSWORD_MAX_LENGTH);\r
           if (!ConfigFormEntry->IfrData.SecurityStatus.Frozen) {\r
             SaveHddPasswordVariable (ConfigFormEntry, Password);\r
           }\r
+\r
           ZeroMem (Password, HDD_PASSWORD_MAX_LENGTH);\r
           Status = GetHddDeviceIdentifyData (AtaPassThru, Port, PortMultiplierPort, &IdentifyData);\r
           ASSERT_EFI_ERROR (Status);\r
@@ -1405,7 +1428,7 @@ HddPasswordRequestPassword (
         ZeroMem (Password, HDD_PASSWORD_MAX_LENGTH);\r
 \r
         if (EFI_ERROR (Status)) {\r
-          RetryCount ++;\r
+          RetryCount++;\r
           if (RetryCount < MAX_HDD_PASSWORD_RETRY_COUNT) {\r
             do {\r
               CreatePopUp (\r
@@ -1416,6 +1439,7 @@ HddPasswordRequestPassword (
                 NULL\r
                 );\r
             } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
+\r
             continue;\r
           } else {\r
             do {\r
@@ -1427,6 +1451,7 @@ HddPasswordRequestPassword (
                 NULL\r
                 );\r
             } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
+\r
             gRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL);\r
             break;\r
           }\r
@@ -1449,7 +1474,7 @@ HddPasswordRequestPassword (
           } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
           if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-            gST->ConOut->ClearScreen(gST->ConOut);\r
+            gST->ConOut->ClearScreen (gST->ConOut);\r
             //\r
             // Keep lock and continue boot.\r
             //\r
@@ -1500,19 +1525,19 @@ HddPasswordRequestPassword (
 **/\r
 VOID\r
 ProcessHddPasswordRequestSetUserPwd (\r
-  IN EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort,\r
-  IN HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry\r
+  IN EFI_ATA_PASS_THRU_PROTOCOL      *AtaPassThru,\r
+  IN UINT16                          Port,\r
+  IN UINT16                          PortMultiplierPort,\r
+  IN HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  CHAR16                            PopUpString[100];\r
-  ATA_IDENTIFY_DATA                 IdentifyData;\r
-  EFI_INPUT_KEY                     Key;\r
-  UINT16                            RetryCount;\r
-  CHAR8                             Password[HDD_PASSWORD_MAX_LENGTH];\r
-  CHAR8                             PasswordConfirm[HDD_PASSWORD_MAX_LENGTH];\r
+  EFI_STATUS         Status;\r
+  CHAR16             PopUpString[100];\r
+  ATA_IDENTIFY_DATA  IdentifyData;\r
+  EFI_INPUT_KEY      Key;\r
+  UINT16             RetryCount;\r
+  CHAR8              Password[HDD_PASSWORD_MAX_LENGTH];\r
+  CHAR8              PasswordConfirm[HDD_PASSWORD_MAX_LENGTH];\r
 \r
   RetryCount = 0;\r
 \r
@@ -1549,6 +1574,7 @@ ProcessHddPasswordRequestSetUserPwd (
                 Status = EFI_INVALID_PARAMETER;\r
               }\r
             }\r
+\r
             if (!EFI_ERROR (Status)) {\r
               CopyMem (ConfigFormEntry->Password, Password, HDD_PASSWORD_MAX_LENGTH);\r
               SaveHddPasswordVariable (ConfigFormEntry, Password);\r
@@ -1583,6 +1609,7 @@ ProcessHddPasswordRequestSetUserPwd (
                 NULL\r
                 );\r
             } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
+\r
             Status = EFI_INVALID_PARAMETER;\r
           }\r
         }\r
@@ -1591,7 +1618,7 @@ ProcessHddPasswordRequestSetUserPwd (
         ZeroMem (PasswordConfirm, HDD_PASSWORD_MAX_LENGTH);\r
 \r
         if (EFI_ERROR (Status)) {\r
-          RetryCount ++;\r
+          RetryCount++;\r
           if (RetryCount >= MAX_HDD_PASSWORD_RETRY_COUNT) {\r
             do {\r
               CreatePopUp (\r
@@ -1602,7 +1629,8 @@ ProcessHddPasswordRequestSetUserPwd (
                 NULL\r
                 );\r
             } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-            gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+            gST->ConOut->ClearScreen (gST->ConOut);\r
             return;\r
           }\r
         }\r
@@ -1618,7 +1646,7 @@ ProcessHddPasswordRequestSetUserPwd (
         } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
         if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
+          gST->ConOut->ClearScreen (gST->ConOut);\r
           return;\r
         } else {\r
           //\r
@@ -1642,18 +1670,18 @@ ProcessHddPasswordRequestSetUserPwd (
 **/\r
 VOID\r
 ProcessHddPasswordRequestSetMasterPwd (\r
-  IN EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort,\r
-  IN HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry\r
+  IN EFI_ATA_PASS_THRU_PROTOCOL      *AtaPassThru,\r
+  IN UINT16                          Port,\r
+  IN UINT16                          PortMultiplierPort,\r
+  IN HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  CHAR16                            PopUpString[100];\r
-  EFI_INPUT_KEY                     Key;\r
-  UINT16                            RetryCount;\r
-  CHAR8                             Password[HDD_PASSWORD_MAX_LENGTH];\r
-  CHAR8                             PasswordConfirm[HDD_PASSWORD_MAX_LENGTH];\r
+  EFI_STATUS     Status;\r
+  CHAR16         PopUpString[100];\r
+  EFI_INPUT_KEY  Key;\r
+  UINT16         RetryCount;\r
+  CHAR8          Password[HDD_PASSWORD_MAX_LENGTH];\r
+  CHAR8          PasswordConfirm[HDD_PASSWORD_MAX_LENGTH];\r
 \r
   RetryCount = 0;\r
 \r
@@ -1686,6 +1714,7 @@ ProcessHddPasswordRequestSetMasterPwd (
             } else {\r
               Status = EFI_INVALID_PARAMETER;\r
             }\r
+\r
             if (!EFI_ERROR (Status)) {\r
               ZeroMem (Password, HDD_PASSWORD_MAX_LENGTH);\r
               ZeroMem (PasswordConfirm, HDD_PASSWORD_MAX_LENGTH);\r
@@ -1711,6 +1740,7 @@ ProcessHddPasswordRequestSetMasterPwd (
                 NULL\r
                 );\r
             } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
+\r
             Status = EFI_INVALID_PARAMETER;\r
           }\r
         }\r
@@ -1719,7 +1749,7 @@ ProcessHddPasswordRequestSetMasterPwd (
         ZeroMem (PasswordConfirm, HDD_PASSWORD_MAX_LENGTH);\r
 \r
         if (EFI_ERROR (Status)) {\r
-          RetryCount ++;\r
+          RetryCount++;\r
           if (RetryCount >= MAX_HDD_PASSWORD_RETRY_COUNT) {\r
             do {\r
               CreatePopUp (\r
@@ -1730,7 +1760,8 @@ ProcessHddPasswordRequestSetMasterPwd (
                 NULL\r
                 );\r
             } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-            gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+            gST->ConOut->ClearScreen (gST->ConOut);\r
             return;\r
           }\r
         }\r
@@ -1746,7 +1777,7 @@ ProcessHddPasswordRequestSetMasterPwd (
         } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
         if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
+          gST->ConOut->ClearScreen (gST->ConOut);\r
           return;\r
         } else {\r
           //\r
@@ -1770,16 +1801,16 @@ ProcessHddPasswordRequestSetMasterPwd (
 **/\r
 VOID\r
 ProcessHddPasswordRequest (\r
-  IN EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort,\r
-  IN HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry\r
+  IN EFI_ATA_PASS_THRU_PROTOCOL      *AtaPassThru,\r
+  IN UINT16                          Port,\r
+  IN UINT16                          PortMultiplierPort,\r
+  IN HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  HDD_PASSWORD_REQUEST_VARIABLE     *TempVariable;\r
-  HDD_PASSWORD_REQUEST_VARIABLE     *Variable;\r
-  UINTN                             VariableSize;\r
+  EFI_STATUS                     Status;\r
+  HDD_PASSWORD_REQUEST_VARIABLE  *TempVariable;\r
+  HDD_PASSWORD_REQUEST_VARIABLE  *Variable;\r
+  UINTN                          VariableSize;\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
@@ -1787,13 +1818,14 @@ ProcessHddPasswordRequest (
     Status = GetVariable2 (\r
                HDD_PASSWORD_REQUEST_VARIABLE_NAME,\r
                &mHddPasswordVendorGuid,\r
-               (VOID **) &Variable,\r
+               (VOID **)&Variable,\r
                &VariableSize\r
                );\r
     if (EFI_ERROR (Status) || (Variable == NULL)) {\r
       return;\r
     }\r
-    mHddPasswordRequestVariable = Variable;\r
+\r
+    mHddPasswordRequestVariable     = Variable;\r
     mHddPasswordRequestVariableSize = VariableSize;\r
 \r
     //\r
@@ -1808,7 +1840,7 @@ ProcessHddPasswordRequest (
                     );\r
     ASSERT_EFI_ERROR (Status);\r
   } else {\r
-    Variable = mHddPasswordRequestVariable;\r
+    Variable     = mHddPasswordRequestVariable;\r
     VariableSize = mHddPasswordRequestVariableSize;\r
   }\r
 \r
@@ -1821,13 +1853,15 @@ ProcessHddPasswordRequest (
         (TempVariable->Device.Device             == ConfigFormEntry->Device) &&\r
         (TempVariable->Device.Function           == ConfigFormEntry->Function) &&\r
         (TempVariable->Device.Port               == ConfigFormEntry->Port) &&\r
-        (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort)) {\r
+        (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort))\r
+    {\r
       //\r
       // Found the node for the HDD password device.\r
       //\r
       if (TempVariable->Request.UserPassword != 0) {\r
         ProcessHddPasswordRequestSetUserPwd (AtaPassThru, Port, PortMultiplierPort, ConfigFormEntry);\r
       }\r
+\r
       if (TempVariable->Request.MasterPassword != 0) {\r
         ProcessHddPasswordRequestSetMasterPwd (AtaPassThru, Port, PortMultiplierPort, ConfigFormEntry);\r
       }\r
@@ -1850,23 +1884,23 @@ ProcessHddPasswordRequest (
 **/\r
 VOID\r
 GetSavedHddPasswordRequest (\r
-  IN OUT HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry\r
+  IN OUT HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  HDD_PASSWORD_REQUEST_VARIABLE     *TempVariable;\r
-  HDD_PASSWORD_REQUEST_VARIABLE     *Variable;\r
-  UINTN                             VariableSize;\r
+  EFI_STATUS                     Status;\r
+  HDD_PASSWORD_REQUEST_VARIABLE  *TempVariable;\r
+  HDD_PASSWORD_REQUEST_VARIABLE  *Variable;\r
+  UINTN                          VariableSize;\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
-  Variable = NULL;\r
+  Variable     = NULL;\r
   VariableSize = 0;\r
 \r
   Status = GetVariable2 (\r
              HDD_PASSWORD_REQUEST_VARIABLE_NAME,\r
              &mHddPasswordVendorGuid,\r
-             (VOID **) &Variable,\r
+             (VOID **)&Variable,\r
              &VariableSize\r
              );\r
   if (EFI_ERROR (Status) || (Variable == NULL)) {\r
@@ -1879,7 +1913,8 @@ GetSavedHddPasswordRequest (
         (TempVariable->Device.Device             == ConfigFormEntry->Device) &&\r
         (TempVariable->Device.Function           == ConfigFormEntry->Function) &&\r
         (TempVariable->Device.Port               == ConfigFormEntry->Port) &&\r
-        (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort)) {\r
+        (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort))\r
+    {\r
       //\r
       // Found the node for the HDD password device.\r
       // Get the HDD password request.\r
@@ -1892,6 +1927,7 @@ GetSavedHddPasswordRequest (
         ));\r
       break;\r
     }\r
+\r
     VariableSize -= sizeof (HDD_PASSWORD_REQUEST_VARIABLE);\r
     TempVariable += 1;\r
   }\r
@@ -1909,16 +1945,16 @@ GetSavedHddPasswordRequest (
 **/\r
 VOID\r
 SaveHddPasswordRequest (\r
-  IN HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry\r
+  IN HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  HDD_PASSWORD_REQUEST_VARIABLE     *TempVariable;\r
-  UINTN                             TempVariableSize;\r
-  HDD_PASSWORD_REQUEST_VARIABLE     *Variable;\r
-  UINTN                             VariableSize;\r
-  HDD_PASSWORD_REQUEST_VARIABLE     *NewVariable;\r
-  UINTN                             NewVariableSize;\r
+  EFI_STATUS                     Status;\r
+  HDD_PASSWORD_REQUEST_VARIABLE  *TempVariable;\r
+  UINTN                          TempVariableSize;\r
+  HDD_PASSWORD_REQUEST_VARIABLE  *Variable;\r
+  UINTN                          VariableSize;\r
+  HDD_PASSWORD_REQUEST_VARIABLE  *NewVariable;\r
+  UINTN                          NewVariableSize;\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
@@ -1928,66 +1964,70 @@ SaveHddPasswordRequest (
     ConfigFormEntry->IfrData.Request\r
     ));\r
 \r
-  Variable = NULL;\r
-  VariableSize = 0;\r
-  NewVariable = NULL;\r
+  Variable        = NULL;\r
+  VariableSize    = 0;\r
+  NewVariable     = NULL;\r
   NewVariableSize = 0;\r
 \r
   Status = GetVariable2 (\r
              HDD_PASSWORD_REQUEST_VARIABLE_NAME,\r
              &mHddPasswordVendorGuid,\r
-             (VOID **) &Variable,\r
+             (VOID **)&Variable,\r
              &VariableSize\r
              );\r
   if (!EFI_ERROR (Status) && (Variable != NULL)) {\r
-    TempVariable = Variable;\r
+    TempVariable     = Variable;\r
     TempVariableSize = VariableSize;\r
     while (TempVariableSize >= sizeof (HDD_PASSWORD_REQUEST_VARIABLE)) {\r
       if ((TempVariable->Device.Bus                == ConfigFormEntry->Bus) &&\r
           (TempVariable->Device.Device             == ConfigFormEntry->Device) &&\r
           (TempVariable->Device.Function           == ConfigFormEntry->Function) &&\r
           (TempVariable->Device.Port               == ConfigFormEntry->Port) &&\r
-          (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort)) {\r
+          (TempVariable->Device.PortMultiplierPort == ConfigFormEntry->PortMultiplierPort))\r
+      {\r
         //\r
         // Found the node for the HDD password device.\r
         // Update the HDD password request.\r
         //\r
         CopyMem (&TempVariable->Request, &ConfigFormEntry->IfrData.Request, sizeof (HDD_PASSWORD_REQUEST));\r
-        NewVariable = Variable;\r
+        NewVariable     = Variable;\r
         NewVariableSize = VariableSize;\r
         break;\r
       }\r
+\r
       TempVariableSize -= sizeof (HDD_PASSWORD_REQUEST_VARIABLE);\r
-      TempVariable += 1;\r
+      TempVariable     += 1;\r
     }\r
+\r
     if (NewVariable == NULL) {\r
       //\r
       // The node for the HDD password device is not found.\r
       // Create node for the HDD password device.\r
       //\r
       NewVariableSize = VariableSize + sizeof (HDD_PASSWORD_REQUEST_VARIABLE);\r
-      NewVariable = AllocateZeroPool (NewVariableSize);\r
+      NewVariable     = AllocateZeroPool (NewVariableSize);\r
       ASSERT (NewVariable != NULL);\r
       CopyMem (NewVariable, Variable, VariableSize);\r
-      TempVariable = (HDD_PASSWORD_REQUEST_VARIABLE *) ((UINTN) NewVariable + VariableSize);\r
-      TempVariable->Device.Bus                = (UINT8) ConfigFormEntry->Bus;\r
-      TempVariable->Device.Device             = (UINT8) ConfigFormEntry->Device;\r
-      TempVariable->Device.Function           = (UINT8) ConfigFormEntry->Function;\r
+      TempVariable                            = (HDD_PASSWORD_REQUEST_VARIABLE *)((UINTN)NewVariable + VariableSize);\r
+      TempVariable->Device.Bus                = (UINT8)ConfigFormEntry->Bus;\r
+      TempVariable->Device.Device             = (UINT8)ConfigFormEntry->Device;\r
+      TempVariable->Device.Function           = (UINT8)ConfigFormEntry->Function;\r
       TempVariable->Device.Port               = ConfigFormEntry->Port;\r
       TempVariable->Device.PortMultiplierPort = ConfigFormEntry->PortMultiplierPort;\r
       CopyMem (&TempVariable->Request, &ConfigFormEntry->IfrData.Request, sizeof (HDD_PASSWORD_REQUEST));\r
     }\r
   } else {\r
     NewVariableSize = sizeof (HDD_PASSWORD_REQUEST_VARIABLE);\r
-    NewVariable = AllocateZeroPool (NewVariableSize);\r
+    NewVariable     = AllocateZeroPool (NewVariableSize);\r
     ASSERT (NewVariable != NULL);\r
-    NewVariable->Device.Bus                = (UINT8) ConfigFormEntry->Bus;\r
-    NewVariable->Device.Device             = (UINT8) ConfigFormEntry->Device;\r
-    NewVariable->Device.Function           = (UINT8) ConfigFormEntry->Function;\r
+    NewVariable->Device.Bus                = (UINT8)ConfigFormEntry->Bus;\r
+    NewVariable->Device.Device             = (UINT8)ConfigFormEntry->Device;\r
+    NewVariable->Device.Function           = (UINT8)ConfigFormEntry->Function;\r
     NewVariable->Device.Port               = ConfigFormEntry->Port;\r
     NewVariable->Device.PortMultiplierPort = ConfigFormEntry->PortMultiplierPort;\r
     CopyMem (&NewVariable->Request, &ConfigFormEntry->IfrData.Request, sizeof (HDD_PASSWORD_REQUEST));\r
   }\r
+\r
   Status = gRT->SetVariable (\r
                   HDD_PASSWORD_REQUEST_VARIABLE_NAME,\r
                   &mHddPasswordVendorGuid,\r
@@ -1998,9 +2038,11 @@ SaveHddPasswordRequest (
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_INFO, "HddPasswordRequest variable set failed (%r)\n", Status));\r
   }\r
+\r
   if (NewVariable != Variable) {\r
     FreePool (NewVariable);\r
   }\r
+\r
   if (Variable != NULL) {\r
     FreePool (Variable);\r
   }\r
@@ -2017,12 +2059,12 @@ SaveHddPasswordRequest (
 **/\r
 HDD_PASSWORD_CONFIG_FORM_ENTRY *\r
 HddPasswordGetConfigFormEntryByIndex (\r
-  IN UINT32 Index\r
+  IN UINT32  Index\r
   )\r
 {\r
-  LIST_ENTRY                     *Entry;\r
-  UINT32                         CurrentIndex;\r
-  HDD_PASSWORD_CONFIG_FORM_ENTRY *ConfigFormEntry;\r
+  LIST_ENTRY                      *Entry;\r
+  UINT32                          CurrentIndex;\r
+  HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry;\r
 \r
   CurrentIndex    = 0;\r
   ConfigFormEntry = NULL;\r
@@ -2104,22 +2146,22 @@ HddPasswordGetConfigFormEntryByIndex (
 EFI_STATUS\r
 EFIAPI\r
 HddPasswordFormExtractConfig (\r
-  IN  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL   *This,\r
-  IN  CONST EFI_STRING                       Request,\r
-  OUT EFI_STRING                             *Progress,\r
-  OUT EFI_STRING                             *Results\r
+  IN  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN  CONST EFI_STRING                      Request,\r
+  OUT EFI_STRING                            *Progress,\r
+  OUT EFI_STRING                            *Results\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
-  UINTN                            BufferSize;\r
-  HDD_PASSWORD_CONFIG              *IfrData;\r
-  HDD_PASSWORD_DXE_PRIVATE_DATA    *Private;\r
-  EFI_STRING                       ConfigRequestHdr;\r
-  EFI_STRING                       ConfigRequest;\r
-  BOOLEAN                          AllocatedRequest;\r
-  UINTN                            Size;\r
-\r
-  if (Progress == NULL || Results == NULL) {\r
+  EFI_STATUS                     Status;\r
+  UINTN                          BufferSize;\r
+  HDD_PASSWORD_CONFIG            *IfrData;\r
+  HDD_PASSWORD_DXE_PRIVATE_DATA  *Private;\r
+  EFI_STRING                     ConfigRequestHdr;\r
+  EFI_STRING                     ConfigRequest;\r
+  BOOLEAN                        AllocatedRequest;\r
+  UINTN                          Size;\r
+\r
+  if ((Progress == NULL) || (Results == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -2143,7 +2185,7 @@ HddPasswordFormExtractConfig (
   //\r
   // Convert buffer data to <ConfigResp> by helper function BlockToConfig()\r
   //\r
-  BufferSize = sizeof (HDD_PASSWORD_CONFIG);\r
+  BufferSize    = sizeof (HDD_PASSWORD_CONFIG);\r
   ConfigRequest = Request;\r
   if ((Request == NULL) || (StrStr (Request, L"OFFSET") == NULL)) {\r
     //\r
@@ -2152,17 +2194,18 @@ HddPasswordFormExtractConfig (
     // followed by "&OFFSET=0&WIDTH=WWWWWWWWWWWWWWWW" followed by a Null-terminator\r
     //\r
     ConfigRequestHdr = HiiConstructConfigHdr (&mHddPasswordVendorGuid, mHddPasswordVendorStorageName, Private->DriverHandle);\r
-    Size = (StrLen (ConfigRequestHdr) + 32 + 1) * sizeof (CHAR16);\r
-    ConfigRequest = AllocateZeroPool (Size);\r
+    Size             = (StrLen (ConfigRequestHdr) + 32 + 1) * sizeof (CHAR16);\r
+    ConfigRequest    = AllocateZeroPool (Size);\r
     ASSERT (ConfigRequest != NULL);\r
     AllocatedRequest = TRUE;\r
     UnicodeSPrint (ConfigRequest, Size, L"%s&OFFSET=0&WIDTH=%016LX", ConfigRequestHdr, (UINT64)BufferSize);\r
     FreePool (ConfigRequestHdr);\r
   }\r
+\r
   Status = gHiiConfigRouting->BlockToConfig (\r
                                 gHiiConfigRouting,\r
                                 ConfigRequest,\r
-                                (UINT8 *) IfrData,\r
+                                (UINT8 *)IfrData,\r
                                 BufferSize,\r
                                 Results,\r
                                 Progress\r
@@ -2224,12 +2267,12 @@ HddPasswordFormExtractConfig (
 EFI_STATUS\r
 EFIAPI\r
 HddPasswordFormRouteConfig (\r
-  IN  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL   *This,\r
-  IN  CONST EFI_STRING                       Configuration,\r
-  OUT EFI_STRING                             *Progress\r
+  IN  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN  CONST EFI_STRING                      Configuration,\r
+  OUT EFI_STRING                            *Progress\r
   )\r
 {\r
-  if (Configuration == NULL || Progress == NULL) {\r
+  if ((Configuration == NULL) || (Progress == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -2275,18 +2318,18 @@ HddPasswordFormRouteConfig (
 EFI_STATUS\r
 EFIAPI\r
 HddPasswordFormCallback (\r
-  IN  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL   *This,\r
-  IN  EFI_BROWSER_ACTION                     Action,\r
-  IN  EFI_QUESTION_ID                        QuestionId,\r
-  IN  UINT8                                  Type,\r
-  IN  EFI_IFR_TYPE_VALUE                     *Value,\r
-  OUT EFI_BROWSER_ACTION_REQUEST             *ActionRequest\r
+  IN  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN  EFI_BROWSER_ACTION                    Action,\r
+  IN  EFI_QUESTION_ID                       QuestionId,\r
+  IN  UINT8                                 Type,\r
+  IN  EFI_IFR_TYPE_VALUE                    *Value,\r
+  OUT EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
   )\r
 {\r
   HDD_PASSWORD_DXE_PRIVATE_DATA   *Private;\r
-  EFI_STRING_ID                    DeviceFormTitleToken;\r
-  HDD_PASSWORD_CONFIG              *IfrData;\r
-  HDD_PASSWORD_CONFIG_FORM_ENTRY   *ConfigFormEntry;\r
+  EFI_STRING_ID                   DeviceFormTitleToken;\r
+  HDD_PASSWORD_CONFIG             *IfrData;\r
+  HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry;\r
 \r
   if (ActionRequest != NULL) {\r
     *ActionRequest = EFI_BROWSER_ACTION_REQUEST_NONE;\r
@@ -2308,55 +2351,57 @@ HddPasswordFormCallback (
   //\r
   IfrData = AllocateZeroPool (sizeof (HDD_PASSWORD_CONFIG));\r
   ASSERT (IfrData != NULL);\r
-  if (!HiiGetBrowserData (&mHddPasswordVendorGuid, mHddPasswordVendorStorageName, sizeof (HDD_PASSWORD_CONFIG), (UINT8 *) IfrData)) {\r
+  if (!HiiGetBrowserData (&mHddPasswordVendorGuid, mHddPasswordVendorStorageName, sizeof (HDD_PASSWORD_CONFIG), (UINT8 *)IfrData)) {\r
     FreePool (IfrData);\r
     return EFI_NOT_FOUND;\r
   }\r
 \r
   switch (QuestionId) {\r
-  case KEY_HDD_USER_PASSWORD:\r
-    if (Action == EFI_BROWSER_ACTION_CHANGED) {\r
-      DEBUG ((DEBUG_INFO, "KEY_HDD_USER_PASSWORD\n"));\r
-      ConfigFormEntry = Private->Current;\r
-      ConfigFormEntry->IfrData.Request.UserPassword = Value->b;\r
-      SaveHddPasswordRequest (ConfigFormEntry);\r
-      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
-    }\r
-    break;\r
-  case KEY_HDD_MASTER_PASSWORD:\r
-    if (Action == EFI_BROWSER_ACTION_CHANGED) {\r
-      DEBUG ((DEBUG_INFO, "KEY_HDD_MASTER_PASSWORD\n"));\r
-      ConfigFormEntry = Private->Current;\r
-      ConfigFormEntry->IfrData.Request.MasterPassword = Value->b;\r
-      SaveHddPasswordRequest (ConfigFormEntry);\r
-      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
-    }\r
-    break;\r
+    case KEY_HDD_USER_PASSWORD:\r
+      if (Action == EFI_BROWSER_ACTION_CHANGED) {\r
+        DEBUG ((DEBUG_INFO, "KEY_HDD_USER_PASSWORD\n"));\r
+        ConfigFormEntry                               = Private->Current;\r
+        ConfigFormEntry->IfrData.Request.UserPassword = Value->b;\r
+        SaveHddPasswordRequest (ConfigFormEntry);\r
+        *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
+      }\r
 \r
-  default:\r
-    if ((QuestionId >= KEY_HDD_DEVICE_ENTRY_BASE) && (QuestionId < (mNumberOfHddDevices + KEY_HDD_DEVICE_ENTRY_BASE))) {\r
-      if (Action == EFI_BROWSER_ACTION_CHANGING) {\r
-        //\r
-        // In case goto the device configuration form, update the device form title.\r
-        //\r
-        ConfigFormEntry = HddPasswordGetConfigFormEntryByIndex ((UINT32) (QuestionId - KEY_HDD_DEVICE_ENTRY_BASE));\r
-        ASSERT (ConfigFormEntry != NULL);\r
+      break;\r
+    case KEY_HDD_MASTER_PASSWORD:\r
+      if (Action == EFI_BROWSER_ACTION_CHANGED) {\r
+        DEBUG ((DEBUG_INFO, "KEY_HDD_MASTER_PASSWORD\n"));\r
+        ConfigFormEntry                                 = Private->Current;\r
+        ConfigFormEntry->IfrData.Request.MasterPassword = Value->b;\r
+        SaveHddPasswordRequest (ConfigFormEntry);\r
+        *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
+      }\r
 \r
-        DeviceFormTitleToken = (EFI_STRING_ID) STR_HDD_SECURITY_HD;\r
-        HiiSetString (Private->HiiHandle, DeviceFormTitleToken, ConfigFormEntry->HddString, NULL);\r
+      break;\r
+\r
+    default:\r
+      if ((QuestionId >= KEY_HDD_DEVICE_ENTRY_BASE) && (QuestionId < (mNumberOfHddDevices + KEY_HDD_DEVICE_ENTRY_BASE))) {\r
+        if (Action == EFI_BROWSER_ACTION_CHANGING) {\r
+          //\r
+          // In case goto the device configuration form, update the device form title.\r
+          //\r
+          ConfigFormEntry = HddPasswordGetConfigFormEntryByIndex ((UINT32)(QuestionId - KEY_HDD_DEVICE_ENTRY_BASE));\r
+          ASSERT (ConfigFormEntry != NULL);\r
 \r
-        Private->Current = ConfigFormEntry;\r
-        CopyMem (IfrData, &ConfigFormEntry->IfrData, sizeof (HDD_PASSWORD_CONFIG));\r
+          DeviceFormTitleToken = (EFI_STRING_ID)STR_HDD_SECURITY_HD;\r
+          HiiSetString (Private->HiiHandle, DeviceFormTitleToken, ConfigFormEntry->HddString, NULL);\r
+\r
+          Private->Current = ConfigFormEntry;\r
+          CopyMem (IfrData, &ConfigFormEntry->IfrData, sizeof (HDD_PASSWORD_CONFIG));\r
+        }\r
       }\r
-    }\r
 \r
-    break;\r
+      break;\r
   }\r
 \r
   //\r
   // Pass changed uncommitted data back to Form Browser\r
   //\r
-  HiiSetBrowserData (&mHddPasswordVendorGuid, mHddPasswordVendorStorageName, sizeof (HDD_PASSWORD_CONFIG), (UINT8 *) IfrData, NULL);\r
+  HiiSetBrowserData (&mHddPasswordVendorGuid, mHddPasswordVendorStorageName, sizeof (HDD_PASSWORD_CONFIG), (UINT8 *)IfrData, NULL);\r
 \r
   FreePool (IfrData);\r
   return EFI_SUCCESS;\r
@@ -2394,17 +2439,17 @@ HddPasswordConfigUpdateForm (
   IN UINT16                      PortMultiplierPort\r
   )\r
 {\r
-  LIST_ENTRY                       *Entry;\r
-  HDD_PASSWORD_CONFIG_FORM_ENTRY   *ConfigFormEntry;\r
-  BOOLEAN                          EntryExisted;\r
-  EFI_STATUS                       Status;\r
-  VOID                             *StartOpCodeHandle;\r
-  VOID                             *EndOpCodeHandle;\r
-  EFI_IFR_GUID_LABEL               *StartLabel;\r
-  EFI_IFR_GUID_LABEL               *EndLabel;\r
-  CHAR16                           HddString[40];\r
-  ATA_IDENTIFY_DATA                IdentifyData;\r
-  EFI_DEVICE_PATH_PROTOCOL         *AtaDeviceNode;\r
+  LIST_ENTRY                      *Entry;\r
+  HDD_PASSWORD_CONFIG_FORM_ENTRY  *ConfigFormEntry;\r
+  BOOLEAN                         EntryExisted;\r
+  EFI_STATUS                      Status;\r
+  VOID                            *StartOpCodeHandle;\r
+  VOID                            *EndOpCodeHandle;\r
+  EFI_IFR_GUID_LABEL              *StartLabel;\r
+  EFI_IFR_GUID_LABEL              *EndLabel;\r
+  CHAR16                          HddString[40];\r
+  ATA_IDENTIFY_DATA               IdentifyData;\r
+  EFI_DEVICE_PATH_PROTOCOL        *AtaDeviceNode;\r
 \r
   ConfigFormEntry = NULL;\r
   EntryExisted    = FALSE;\r
@@ -2416,7 +2461,8 @@ HddPasswordConfigUpdateForm (
         (ConfigFormEntry->Device == Device) &&\r
         (ConfigFormEntry->Function == Function) &&\r
         (ConfigFormEntry->Port == Port) &&\r
-        (ConfigFormEntry->PortMultiplierPort == PortMultiplierPort)) {\r
+        (ConfigFormEntry->PortMultiplierPort == PortMultiplierPort))\r
+    {\r
       EntryExisted = TRUE;\r
       break;\r
     }\r
@@ -2454,6 +2500,7 @@ HddPasswordConfigUpdateForm (
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
+\r
     ConfigFormEntry->DevicePath = AppendDevicePathNode (DevicePathFromHandle (Controller), AtaDeviceNode);\r
     FreePool (AtaDeviceNode);\r
     if (ConfigFormEntry->DevicePath == NULL) {\r
@@ -2468,6 +2515,7 @@ HddPasswordConfigUpdateForm (
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
+\r
     GetHddDeviceModelNumber (&IdentifyData, HddString);\r
     //\r
     // Compose the HDD title string and help string of this port and create a new EFI_STRING_ID.\r
@@ -2492,14 +2540,14 @@ HddPasswordConfigUpdateForm (
     //\r
     // Create Hii Extend Label OpCode as the start opcode\r
     //\r
-    StartLabel = (EFI_IFR_GUID_LABEL *) HiiCreateGuidOpCode (StartOpCodeHandle, &gEfiIfrTianoGuid, NULL, sizeof (EFI_IFR_GUID_LABEL));\r
+    StartLabel               = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (StartOpCodeHandle, &gEfiIfrTianoGuid, NULL, sizeof (EFI_IFR_GUID_LABEL));\r
     StartLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
     StartLabel->Number       = HDD_DEVICE_ENTRY_LABEL;\r
 \r
     //\r
     // Create Hii Extend Label OpCode as the end opcode\r
     //\r
-    EndLabel = (EFI_IFR_GUID_LABEL *) HiiCreateGuidOpCode (EndOpCodeHandle, &gEfiIfrTianoGuid, NULL, sizeof (EFI_IFR_GUID_LABEL));\r
+    EndLabel               = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (EndOpCodeHandle, &gEfiIfrTianoGuid, NULL, sizeof (EFI_IFR_GUID_LABEL));\r
     EndLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
     EndLabel->Number       = HDD_DEVICE_LABEL_END;\r
 \r
@@ -2508,12 +2556,12 @@ HddPasswordConfigUpdateForm (
       ConfigFormEntry = BASE_CR (Entry, HDD_PASSWORD_CONFIG_FORM_ENTRY, Link);\r
 \r
       HiiCreateGotoOpCode (\r
-        StartOpCodeHandle,                                // Container for dynamic created opcodes\r
-        FORMID_HDD_DEVICE_FORM,                           // Target Form ID\r
-        ConfigFormEntry->TitleToken,                      // Prompt text\r
-        ConfigFormEntry->TitleHelpToken,                  // Help text\r
-        EFI_IFR_FLAG_CALLBACK,                            // Question flag\r
-        (UINT16) (KEY_HDD_DEVICE_ENTRY_BASE + mNumberOfHddDevices)   // Question ID\r
+        StartOpCodeHandle,                                        // Container for dynamic created opcodes\r
+        FORMID_HDD_DEVICE_FORM,                                   // Target Form ID\r
+        ConfigFormEntry->TitleToken,                              // Prompt text\r
+        ConfigFormEntry->TitleHelpToken,                          // Help text\r
+        EFI_IFR_FLAG_CALLBACK,                                    // Question flag\r
+        (UINT16)(KEY_HDD_DEVICE_ENTRY_BASE + mNumberOfHddDevices) // Question ID\r
         );\r
 \r
       mNumberOfHddDevices++;\r
@@ -2557,24 +2605,24 @@ HddPasswordConfigUpdateForm (
 VOID\r
 EFIAPI\r
 HddPasswordNotificationEvent (\r
-  IN  EFI_EVENT       Event,\r
-  IN  VOID            *Context\r
+  IN  EFI_EVENT  Event,\r
+  IN  VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  HDD_PASSWORD_DXE_PRIVATE_DATA     *Private;\r
-  EFI_ATA_PASS_THRU_PROTOCOL        *AtaPassThru;\r
-  UINT16                            Port;\r
-  UINT16                            PortMultiplierPort;\r
-  EFI_HANDLE                        Controller;\r
-  EFI_HANDLE                        *HandleBuffer;\r
-  UINTN                             HandleCount;\r
-  UINTN                             Index;\r
-  EFI_PCI_IO_PROTOCOL               *PciIo;\r
-  UINTN                             SegNum;\r
-  UINTN                             BusNum;\r
-  UINTN                             DevNum;\r
-  UINTN                             FuncNum;\r
+  EFI_STATUS                     Status;\r
+  HDD_PASSWORD_DXE_PRIVATE_DATA  *Private;\r
+  EFI_ATA_PASS_THRU_PROTOCOL     *AtaPassThru;\r
+  UINT16                         Port;\r
+  UINT16                         PortMultiplierPort;\r
+  EFI_HANDLE                     Controller;\r
+  EFI_HANDLE                     *HandleBuffer;\r
+  UINTN                          HandleCount;\r
+  UINTN                          Index;\r
+  EFI_PCI_IO_PROTOCOL            *PciIo;\r
+  UINTN                          SegNum;\r
+  UINTN                          BusNum;\r
+  UINTN                          DevNum;\r
+  UINTN                          FuncNum;\r
 \r
   if (mHddPasswordEndOfDxe) {\r
     gBS->CloseEvent (Event);\r
@@ -2594,7 +2642,7 @@ HddPasswordNotificationEvent (
                   &HandleBuffer\r
                   );\r
   if (EFI_ERROR (Status)) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   //\r
@@ -2602,11 +2650,11 @@ HddPasswordNotificationEvent (
   //\r
   for (Index = 0; Index < HandleCount; Index += 1) {\r
     Controller = HandleBuffer[Index];\r
-    Status = gBS->HandleProtocol (\r
-                    Controller,\r
-                    &gEfiAtaPassThruProtocolGuid,\r
-                    (VOID **) &AtaPassThru\r
-                    );\r
+    Status     = gBS->HandleProtocol (\r
+                        Controller,\r
+                        &gEfiAtaPassThruProtocolGuid,\r
+                        (VOID **)&AtaPassThru\r
+                        );\r
     if (EFI_ERROR (Status)) {\r
       break;\r
     }\r
@@ -2621,7 +2669,7 @@ HddPasswordNotificationEvent (
     Status = gBS->HandleProtocol (\r
                     Controller,\r
                     &gEfiPciIoProtocolGuid,\r
-                    (VOID **) &PciIo\r
+                    (VOID **)&PciIo\r
                     );\r
     ASSERT_EFI_ERROR (Status);\r
     if (EFI_ERROR (Status)) {\r
@@ -2669,6 +2717,7 @@ HddPasswordNotificationEvent (
           //\r
           break;\r
         }\r
+\r
         //\r
         // Find out the attached harddisk devices.\r
         // Try to add a HDD Password configuration page for the attached devices.\r
@@ -2684,7 +2733,7 @@ HddPasswordNotificationEvent (
   }\r
 \r
   FreePool (HandleBuffer);\r
-  return ;\r
+  return;\r
 }\r
 \r
 /**\r
@@ -2698,11 +2747,11 @@ HddPasswordNotificationEvent (
 **/\r
 EFI_STATUS\r
 HddPasswordConfigFormInit (\r
-  OUT HDD_PASSWORD_DXE_PRIVATE_DATA    **Instance\r
+  OUT HDD_PASSWORD_DXE_PRIVATE_DATA  **Instance\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
-  HDD_PASSWORD_DXE_PRIVATE_DATA    *Private;\r
+  EFI_STATUS                     Status;\r
+  HDD_PASSWORD_DXE_PRIVATE_DATA  *Private;\r
 \r
   InitializeListHead (&mHddPasswordConfigFormList);\r
 \r
@@ -2711,7 +2760,7 @@ HddPasswordConfigFormInit (
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  Private->Signature   = HDD_PASSWORD_DXE_PRIVATE_SIGNATURE;\r
+  Private->Signature = HDD_PASSWORD_DXE_PRIVATE_SIGNATURE;\r
 \r
   Private->ConfigAccess.ExtractConfig = HddPasswordFormExtractConfig;\r
   Private->ConfigAccess.RouteConfig   = HddPasswordFormRouteConfig;\r
@@ -2730,7 +2779,7 @@ HddPasswordConfigFormInit (
                   );\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
-    FreePool(Private);\r
+    FreePool (Private);\r
     return Status;\r
   }\r
 \r
@@ -2745,7 +2794,7 @@ HddPasswordConfigFormInit (
                          NULL\r
                          );\r
   if (Private->HiiHandle == NULL) {\r
-    FreePool(Private);\r
+    FreePool (Private);\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
@@ -2765,8 +2814,8 @@ HddPasswordConfigFormInit (
 EFI_STATUS\r
 EFIAPI\r
 HddPasswordDxeInit (\r
-  IN EFI_HANDLE                   ImageHandle,\r
-  IN EFI_SYSTEM_TABLE             *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   EFI_STATUS                     Status;\r
@@ -2809,7 +2858,7 @@ HddPasswordDxeInit (
   //\r
   // Make HDD_PASSWORD_VARIABLE_NAME variable read-only.\r
   //\r
-  Status = gBS->LocateProtocol (&gEdkiiVariableLockProtocolGuid, NULL, (VOID **) &VariableLock);\r
+  Status = gBS->LocateProtocol (&gEdkiiVariableLockProtocolGuid, NULL, (VOID **)&VariableLock);\r
   if (!EFI_ERROR (Status)) {\r
     Status = VariableLock->RequestToLock (\r
                              VariableLock,\r
index a6c87169dc5925664386421bfd141a67de5b6005..231533e737a95ffd63906f5ef8372b83911be353 100644 (file)
@@ -58,7 +58,7 @@ extern UINT8  HddPasswordBin[];
 //\r
 extern UINT8  HddPasswordDxeStrings[];\r
 \r
-#define HDD_PASSWORD_DXE_PRIVATE_SIGNATURE SIGNATURE_32 ('H', 'D', 'D', 'P')\r
+#define HDD_PASSWORD_DXE_PRIVATE_SIGNATURE  SIGNATURE_32 ('H', 'D', 'D', 'P')\r
 \r
 typedef struct _HDD_PASSWORD_CONFIG_FORM_ENTRY {\r
   LIST_ENTRY                    Link;\r
@@ -79,46 +79,46 @@ typedef struct _HDD_PASSWORD_CONFIG_FORM_ENTRY {
 } HDD_PASSWORD_CONFIG_FORM_ENTRY;\r
 \r
 typedef struct _HDD_PASSWORD_DXE_PRIVATE_DATA {\r
-  UINTN                            Signature;\r
-  EFI_HANDLE                       DriverHandle;\r
-  EFI_HII_HANDLE                   HiiHandle;\r
-  EFI_HII_CONFIG_ACCESS_PROTOCOL   ConfigAccess;\r
-  HDD_PASSWORD_CONFIG_FORM_ENTRY   *Current;\r
+  UINTN                             Signature;\r
+  EFI_HANDLE                        DriverHandle;\r
+  EFI_HII_HANDLE                    HiiHandle;\r
+  EFI_HII_CONFIG_ACCESS_PROTOCOL    ConfigAccess;\r
+  HDD_PASSWORD_CONFIG_FORM_ENTRY    *Current;\r
 } HDD_PASSWORD_DXE_PRIVATE_DATA;\r
 \r
 #define HDD_PASSWORD_DXE_PRIVATE_FROM_THIS(a)  CR (a, HDD_PASSWORD_DXE_PRIVATE_DATA, ConfigAccess, HDD_PASSWORD_DXE_PRIVATE_SIGNATURE)\r
 \r
-#define PASSWORD_SALT_SIZE                  32\r
+#define PASSWORD_SALT_SIZE  32\r
 \r
 #define HDD_PASSWORD_REQUEST_VARIABLE_NAME  L"HddPasswordRequest"\r
 \r
 //\r
 // It needs to be locked before EndOfDxe.\r
 //\r
-#define HDD_PASSWORD_VARIABLE_NAME          L"HddPassword"\r
+#define HDD_PASSWORD_VARIABLE_NAME  L"HddPassword"\r
 \r
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  HDD_PASSWORD_DEVICE   Device;\r
-  HDD_PASSWORD_REQUEST  Request;\r
+  HDD_PASSWORD_DEVICE     Device;\r
+  HDD_PASSWORD_REQUEST    Request;\r
 } HDD_PASSWORD_REQUEST_VARIABLE;\r
 \r
 //\r
 // It will be used to validate HDD password when the device is at frozen state.\r
 //\r
 typedef struct {\r
-  HDD_PASSWORD_DEVICE   Device;\r
-  UINT8                 PasswordHash[SHA256_DIGEST_SIZE];\r
-  UINT8                 PasswordSalt[PASSWORD_SALT_SIZE];\r
+  HDD_PASSWORD_DEVICE    Device;\r
+  UINT8                  PasswordHash[SHA256_DIGEST_SIZE];\r
+  UINT8                  PasswordSalt[PASSWORD_SALT_SIZE];\r
 } HDD_PASSWORD_VARIABLE;\r
 \r
 ///\r
 /// HII specific Vendor Device Path definition.\r
 ///\r
 typedef struct {\r
-  VENDOR_DEVICE_PATH           VendorDevicePath;\r
-  EFI_DEVICE_PATH_PROTOCOL     End;\r
+  VENDOR_DEVICE_PATH          VendorDevicePath;\r
+  EFI_DEVICE_PATH_PROTOCOL    End;\r
 } HII_VENDOR_DEVICE_PATH;\r
 \r
 #pragma pack()\r
@@ -126,11 +126,11 @@ typedef struct {
 //\r
 // Time out value for ATA pass through protocol\r
 //\r
-#define ATA_TIMEOUT        EFI_TIMER_PERIOD_SECONDS (3)\r
+#define ATA_TIMEOUT  EFI_TIMER_PERIOD_SECONDS (3)\r
 \r
 typedef struct {\r
-  UINT32                   Address;\r
-  S3_BOOT_SCRIPT_LIB_WIDTH Width;\r
+  UINT32                      Address;\r
+  S3_BOOT_SCRIPT_LIB_WIDTH    Width;\r
 } HDD_HC_PCI_REGISTER_SAVE;\r
 \r
 #endif\r
index 80df81f3cf1c3f77a7587fde59e2e8b07a4e63ae..29c52389fe27476c206f8b54264dbe242998f879 100644 (file)
     0x737cded7, 0x448b, 0x4801, { 0xb5, 0x7d, 0xb1, 0x94, 0x83, 0xec, 0x60, 0x6f } \\r
   }\r
 \r
-#define FORMID_HDD_MAIN_FORM          1\r
-#define FORMID_HDD_DEVICE_FORM        2\r
+#define FORMID_HDD_MAIN_FORM    1\r
+#define FORMID_HDD_DEVICE_FORM  2\r
 \r
-#define HDD_DEVICE_ENTRY_LABEL        0x1234\r
-#define HDD_DEVICE_LABEL_END          0xffff\r
+#define HDD_DEVICE_ENTRY_LABEL  0x1234\r
+#define HDD_DEVICE_LABEL_END    0xffff\r
 \r
-#define KEY_HDD_DEVICE_ENTRY_BASE     0x1000\r
+#define KEY_HDD_DEVICE_ENTRY_BASE  0x1000\r
 \r
-#define KEY_HDD_USER_PASSWORD         0x101\r
-#define KEY_HDD_MASTER_PASSWORD       0x102\r
+#define KEY_HDD_USER_PASSWORD    0x101\r
+#define KEY_HDD_MASTER_PASSWORD  0x102\r
 \r
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  UINT8     Supported:1;\r
-  UINT8     Enabled:1;\r
-  UINT8     Locked:1;\r
-  UINT8     Frozen:1;\r
-  UINT8     UserPasswordStatus:1;\r
-  UINT8     MasterPasswordStatus:1;\r
-  UINT8     Reserved:2;\r
+  UINT8    Supported            : 1;\r
+  UINT8    Enabled              : 1;\r
+  UINT8    Locked               : 1;\r
+  UINT8    Frozen               : 1;\r
+  UINT8    UserPasswordStatus   : 1;\r
+  UINT8    MasterPasswordStatus : 1;\r
+  UINT8    Reserved             : 2;\r
 } HDD_PASSWORD_SECURITY_STATUS;\r
 \r
 typedef struct {\r
-  UINT8     UserPassword:1;\r
-  UINT8     MasterPassword:1;\r
-  UINT8     Reserved:6;\r
+  UINT8    UserPassword   : 1;\r
+  UINT8    MasterPassword : 1;\r
+  UINT8    Reserved       : 6;\r
 } HDD_PASSWORD_REQUEST;\r
 \r
 typedef struct _HDD_PASSWORD_CONFIG {\r
-  HDD_PASSWORD_SECURITY_STATUS  SecurityStatus;\r
-  HDD_PASSWORD_REQUEST          Request;\r
+  HDD_PASSWORD_SECURITY_STATUS    SecurityStatus;\r
+  HDD_PASSWORD_REQUEST            Request;\r
 } HDD_PASSWORD_CONFIG;\r
 \r
 #pragma pack()\r
index 8d3d3cb6e307fc6bc75da7158e4e08efde65f0eb..a1c881599fa0a81997209aade4670af76652bacb 100644 (file)
@@ -9,8 +9,7 @@
 \r
 #include "HddPasswordPei.h"\r
 \r
-EFI_GUID mHddPasswordDeviceInfoGuid = HDD_PASSWORD_DEVICE_INFO_GUID;\r
-\r
+EFI_GUID  mHddPasswordDeviceInfoGuid = HDD_PASSWORD_DEVICE_INFO_GUID;\r
 \r
 /**\r
   Send unlock hdd password cmd through ATA PassThru PPI.\r
@@ -29,18 +28,18 @@ EFI_GUID mHddPasswordDeviceInfoGuid = HDD_PASSWORD_DEVICE_INFO_GUID;
 **/\r
 EFI_STATUS\r
 UnlockDevice (\r
-  IN EDKII_PEI_ATA_PASS_THRU_PPI    *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort,\r
-  IN CHAR8                          Identifier,\r
-  IN CHAR8                          *Password\r
+  IN EDKII_PEI_ATA_PASS_THRU_PPI  *AtaPassThru,\r
+  IN UINT16                       Port,\r
+  IN UINT16                       PortMultiplierPort,\r
+  IN CHAR8                        Identifier,\r
+  IN CHAR8                        *Password\r
   )\r
 {\r
-  EFI_STATUS                          Status;\r
-  EFI_ATA_COMMAND_BLOCK               Acb;\r
-  EFI_ATA_STATUS_BLOCK                *Asb;\r
-  EFI_ATA_PASS_THRU_COMMAND_PACKET    Packet;\r
-  UINT8                               Buffer[HDD_PAYLOAD];\r
+  EFI_STATUS                        Status;\r
+  EFI_ATA_COMMAND_BLOCK             Acb;\r
+  EFI_ATA_STATUS_BLOCK              *Asb;\r
+  EFI_ATA_PASS_THRU_COMMAND_PACKET  Packet;\r
+  UINT8                             Buffer[HDD_PAYLOAD];\r
 \r
   if ((AtaPassThru == NULL) || (Password == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -69,7 +68,7 @@ UnlockDevice (
   ZeroMem (&Acb, sizeof (Acb));\r
   ZeroMem (Asb, sizeof (EFI_ATA_STATUS_BLOCK));\r
   Acb.AtaCommand    = ATA_SECURITY_UNLOCK_CMD;\r
-  Acb.AtaDeviceHead = (UINT8) (PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
+  Acb.AtaDeviceHead = (UINT8)(PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
 \r
   //\r
   // Prepare for ATA pass through packet.\r
@@ -80,8 +79,8 @@ UnlockDevice (
   Packet.Asb      = Asb;\r
   Packet.Acb      = &Acb;\r
 \r
-  ((CHAR16 *) Buffer)[0] = Identifier & BIT0;\r
-  CopyMem (&((CHAR16 *) Buffer)[1], Password, HDD_PASSWORD_MAX_LENGTH);\r
+  ((CHAR16 *)Buffer)[0] = Identifier & BIT0;\r
+  CopyMem (&((CHAR16 *)Buffer)[1], Password, HDD_PASSWORD_MAX_LENGTH);\r
 \r
   Packet.OutDataBuffer     = Buffer;\r
   Packet.OutTransferLength = sizeof (Buffer);\r
@@ -95,7 +94,8 @@ UnlockDevice (
                           );\r
   if (!EFI_ERROR (Status) &&\r
       ((Asb->AtaStatus & ATA_STSREG_ERR) != 0) &&\r
-      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0)) {\r
+      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0))\r
+  {\r
     Status = EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -122,15 +122,15 @@ UnlockDevice (
 **/\r
 EFI_STATUS\r
 FreezeLockDevice (\r
-  IN EDKII_PEI_ATA_PASS_THRU_PPI    *AtaPassThru,\r
-  IN UINT16                         Port,\r
-  IN UINT16                         PortMultiplierPort\r
+  IN EDKII_PEI_ATA_PASS_THRU_PPI  *AtaPassThru,\r
+  IN UINT16                       Port,\r
+  IN UINT16                       PortMultiplierPort\r
   )\r
 {\r
-  EFI_STATUS                          Status;\r
-  EFI_ATA_COMMAND_BLOCK               Acb;\r
-  EFI_ATA_STATUS_BLOCK                *Asb;\r
-  EFI_ATA_PASS_THRU_COMMAND_PACKET    Packet;\r
+  EFI_STATUS                        Status;\r
+  EFI_ATA_COMMAND_BLOCK             Acb;\r
+  EFI_ATA_STATUS_BLOCK              *Asb;\r
+  EFI_ATA_PASS_THRU_COMMAND_PACKET  Packet;\r
 \r
   if (AtaPassThru == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -159,7 +159,7 @@ FreezeLockDevice (
   ZeroMem (&Acb, sizeof (Acb));\r
   ZeroMem (Asb, sizeof (EFI_ATA_STATUS_BLOCK));\r
   Acb.AtaCommand    = ATA_SECURITY_FREEZE_LOCK_CMD;\r
-  Acb.AtaDeviceHead = (UINT8) (PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
+  Acb.AtaDeviceHead = (UINT8)(PortMultiplierPort == 0xFFFF ? 0 : (PortMultiplierPort << 4));\r
 \r
   //\r
   // Prepare for ATA pass through packet.\r
@@ -179,7 +179,8 @@ FreezeLockDevice (
                           );\r
   if (!EFI_ERROR (Status) &&\r
       ((Asb->AtaStatus & ATA_STSREG_ERR) != 0) &&\r
-      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0)) {\r
+      ((Asb->AtaError & ATA_ERRREG_ABRT) != 0))\r
+  {\r
     Status = EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -197,23 +198,23 @@ FreezeLockDevice (
 **/\r
 VOID\r
 UnlockHddPassword (\r
-  IN EDKII_PEI_ATA_PASS_THRU_PPI    *AtaPassThruPpi\r
+  IN EDKII_PEI_ATA_PASS_THRU_PPI  *AtaPassThruPpi\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  VOID                           *Buffer;\r
-  UINTN                          Length;\r
-  UINT8                          DummyData;\r
-  HDD_PASSWORD_DEVICE_INFO       *DevInfo;\r
-  UINT16                         Port;\r
-  UINT16                         PortMultiplierPort;\r
-  EFI_DEVICE_PATH_PROTOCOL       *DevicePath;\r
-  UINTN                          DevicePathLength;\r
+  EFI_STATUS                Status;\r
+  VOID                      *Buffer;\r
+  UINTN                     Length;\r
+  UINT8                     DummyData;\r
+  HDD_PASSWORD_DEVICE_INFO  *DevInfo;\r
+  UINT16                    Port;\r
+  UINT16                    PortMultiplierPort;\r
+  EFI_DEVICE_PATH_PROTOCOL  *DevicePath;\r
+  UINTN                     DevicePathLength;\r
 \r
   //\r
   // Get HDD password device info from LockBox.\r
   //\r
-  Buffer = (VOID *) &DummyData;\r
+  Buffer = (VOID *)&DummyData;\r
   Length = sizeof (DummyData);\r
   Status = RestoreLockBox (&mHddPasswordDeviceInfoGuid, Buffer, &Length);\r
   if (Status == EFI_BUFFER_TOO_SMALL) {\r
@@ -222,7 +223,8 @@ UnlockHddPassword (
       Status = RestoreLockBox (&mHddPasswordDeviceInfoGuid, Buffer, &Length);\r
     }\r
   }\r
-  if ((Buffer == NULL) || (Buffer == (VOID *) &DummyData)) {\r
+\r
+  if ((Buffer == NULL) || (Buffer == (VOID *)&DummyData)) {\r
     return;\r
   } else if (EFI_ERROR (Status)) {\r
     FreePages (Buffer, EFI_SIZE_TO_PAGES (Length));\r
@@ -261,8 +263,8 @@ UnlockHddPassword (
       //\r
       // Search the device in the restored LockBox.\r
       //\r
-      DevInfo = (HDD_PASSWORD_DEVICE_INFO *) Buffer;\r
-      while ((UINTN) DevInfo < ((UINTN) Buffer + Length)) {\r
+      DevInfo = (HDD_PASSWORD_DEVICE_INFO *)Buffer;\r
+      while ((UINTN)DevInfo < ((UINTN)Buffer + Length)) {\r
         //\r
         // Find the matching device.\r
         //\r
@@ -270,15 +272,18 @@ UnlockHddPassword (
             (DevInfo->Device.PortMultiplierPort == PortMultiplierPort) &&\r
             (DevInfo->DevicePathLength >= DevicePathLength) &&\r
             (CompareMem (\r
-              DevInfo->DevicePath,\r
-              DevicePath,\r
-              DevicePathLength - sizeof (EFI_DEVICE_PATH_PROTOCOL)) == 0)) {\r
+               DevInfo->DevicePath,\r
+               DevicePath,\r
+               DevicePathLength - sizeof (EFI_DEVICE_PATH_PROTOCOL)\r
+               ) == 0))\r
+        {\r
           //\r
           // If device locked, unlock first.\r
           //\r
           if (!IsZeroBuffer (DevInfo->Password, HDD_PASSWORD_MAX_LENGTH)) {\r
             UnlockDevice (AtaPassThruPpi, Port, PortMultiplierPort, 0, DevInfo->Password);\r
           }\r
+\r
           //\r
           // Freeze lock the device.\r
           //\r
@@ -287,7 +292,7 @@ UnlockHddPassword (
         }\r
 \r
         DevInfo = (HDD_PASSWORD_DEVICE_INFO *)\r
-                  ((UINTN) DevInfo + sizeof (HDD_PASSWORD_DEVICE_INFO) + DevInfo->DevicePathLength);\r
+                  ((UINTN)DevInfo + sizeof (HDD_PASSWORD_DEVICE_INFO) + DevInfo->DevicePathLength);\r
       }\r
     }\r
   }\r
@@ -295,7 +300,6 @@ UnlockHddPassword (
 Exit:\r
   ZeroMem (Buffer, Length);\r
   FreePages (Buffer, EFI_SIZE_TO_PAGES (Length));\r
-\r
 }\r
 \r
 /**\r
@@ -312,28 +316,26 @@ Exit:
 EFI_STATUS\r
 EFIAPI\r
 HddPasswordAtaPassThruNotify (\r
-  IN EFI_PEI_SERVICES          **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDesc,\r
-  IN VOID                      *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDesc,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
   DEBUG ((DEBUG_INFO, "%a() - enter at S3 resume\n", __FUNCTION__));\r
 \r
-  UnlockHddPassword ((EDKII_PEI_ATA_PASS_THRU_PPI *) Ppi);\r
+  UnlockHddPassword ((EDKII_PEI_ATA_PASS_THRU_PPI *)Ppi);\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - exit at S3 resume\n", __FUNCTION__));\r
 \r
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
-EFI_PEI_NOTIFY_DESCRIPTOR mHddPasswordAtaPassThruPpiNotifyDesc = {\r
+EFI_PEI_NOTIFY_DESCRIPTOR  mHddPasswordAtaPassThruPpiNotifyDesc = {\r
   (EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST),\r
   &gEdkiiPeiAtaPassThruPpiGuid,\r
   HddPasswordAtaPassThruNotify\r
 };\r
 \r
-\r
 /**\r
   Main entry for this module.\r
 \r
@@ -346,12 +348,12 @@ EFI_PEI_NOTIFY_DESCRIPTOR mHddPasswordAtaPassThruPpiNotifyDesc = {
 EFI_STATUS\r
 EFIAPI\r
 HddPasswordPeiInit (\r
-  IN EFI_PEI_FILE_HANDLE        FileHandle,\r
-  IN CONST EFI_PEI_SERVICES     **PeiServices\r
+  IN EFI_PEI_FILE_HANDLE     FileHandle,\r
+  IN CONST EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                              Status;\r
-  EFI_BOOT_MODE                           BootMode;\r
+  EFI_STATUS     Status;\r
+  EFI_BOOT_MODE  BootMode;\r
 \r
   Status = PeiServicesGetBootMode (&BootMode);\r
   if ((EFI_ERROR (Status)) || (BootMode != BOOT_ON_S3_RESUME)) {\r
@@ -364,4 +366,3 @@ HddPasswordPeiInit (
   ASSERT_EFI_ERROR (Status);\r
   return Status;\r
 }\r
-\r
index b97b457c66cb9bcc4f92932be2f724e0ac0b44b3..1cdb12be027cb88e874c0bcad9231ab6218aead0 100644 (file)
 \r
 #include "HddPasswordCommon.h"\r
 \r
-\r
 //\r
 // Time out value for ATA PassThru PPI\r
 //\r
-#define ATA_TIMEOUT                          30000000\r
+#define ATA_TIMEOUT  30000000\r
 \r
 #endif\r
index 44ceebc488509e71ab821ecc036b096718058ad8..9d58ad5272f61f2b65ce48e10f725a44915bc202 100644 (file)
@@ -18,10 +18,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define EFI_SECURE_BOOT_ENABLE_DISABLE \\r
   { 0xf0a30bc7, 0xaf08, 0x4556, { 0x99, 0xc4, 0x0, 0x10, 0x9, 0xc9, 0x3a, 0x44 } }\r
 \r
-extern EFI_GUID gEfiSecureBootEnableDisableGuid;\r
-extern EFI_GUID gEfiCertDbGuid;\r
-extern EFI_GUID gEfiCustomModeEnableGuid;\r
-extern EFI_GUID gEfiVendorKeysNvGuid;\r
+extern EFI_GUID  gEfiSecureBootEnableDisableGuid;\r
+extern EFI_GUID  gEfiCertDbGuid;\r
+extern EFI_GUID  gEfiCustomModeEnableGuid;\r
+extern EFI_GUID  gEfiVendorKeysNvGuid;\r
 \r
 ///\r
 /// "SecureBootEnable" variable for the Secure Boot feature enable/disable.\r
@@ -32,9 +32,9 @@ extern EFI_GUID gEfiVendorKeysNvGuid;
 ///\r
 /// Format: UINT8\r
 ///\r
-#define EFI_SECURE_BOOT_ENABLE_NAME      L"SecureBootEnable"\r
-#define SECURE_BOOT_ENABLE               1\r
-#define SECURE_BOOT_DISABLE              0\r
+#define EFI_SECURE_BOOT_ENABLE_NAME  L"SecureBootEnable"\r
+#define SECURE_BOOT_ENABLE           1\r
+#define SECURE_BOOT_DISABLE          0\r
 \r
 ///\r
 ///  "CustomMode" variable for two Secure Boot modes feature: "Custom" and "Standard".\r
@@ -48,9 +48,9 @@ extern EFI_GUID gEfiVendorKeysNvGuid;
 ///\r
 /// Format: UINT8\r
 ///\r
-#define EFI_CUSTOM_MODE_NAME          L"CustomMode"\r
-#define CUSTOM_SECURE_BOOT_MODE       1\r
-#define STANDARD_SECURE_BOOT_MODE     0\r
+#define EFI_CUSTOM_MODE_NAME       L"CustomMode"\r
+#define CUSTOM_SECURE_BOOT_MODE    1\r
+#define STANDARD_SECURE_BOOT_MODE  0\r
 \r
 ///\r
 ///  "VendorKeysNv" variable to record the out of band secure boot keys modification.\r
@@ -62,8 +62,8 @@ extern EFI_GUID gEfiVendorKeysNvGuid;
 ///\r
 /// Format: UINT8\r
 ///\r
-#define EFI_VENDOR_KEYS_NV_VARIABLE_NAME       L"VendorKeysNv"\r
-#define VENDOR_KEYS_VALID             1\r
-#define VENDOR_KEYS_MODIFIED          0\r
+#define EFI_VENDOR_KEYS_NV_VARIABLE_NAME  L"VendorKeysNv"\r
+#define VENDOR_KEYS_VALID                 1\r
+#define VENDOR_KEYS_MODIFIED              0\r
 \r
 #endif // __AUTHENTICATED_VARIABLE_FORMAT_H__\r
index 2c542db5554fbe377c0df4bda1de9768d914e356..3a3bc445676faa283ba89ef5127241fc19aa0b61 100644 (file)
@@ -20,11 +20,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0xb2360b42, 0x7173, 0x420a, { 0x86, 0x96, 0x46, 0xca, 0x6b, 0xab, 0x10, 0x60 } \\r
   }\r
 \r
-extern EFI_GUID gMeasuredFvHobGuid;\r
+extern EFI_GUID  gMeasuredFvHobGuid;\r
 \r
 typedef struct {\r
-  UINT32                     Num;\r
-  EFI_PLATFORM_FIRMWARE_BLOB MeasuredFvBuf[1];\r
+  UINT32                        Num;\r
+  EFI_PLATFORM_FIRMWARE_BLOB    MeasuredFvBuf[1];\r
 } MEASURED_HOB_DATA;\r
 \r
 #endif\r
index 3dcb4dd6b80a53a21d9a063681c668ad28cacb49..93b68eb7bafdf1c9bc7b45d1275100d268635678 100644 (file)
@@ -20,37 +20,37 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define PHYSICAL_PRESENCE_VARIABLE  L"PhysicalPresence"\r
 \r
 typedef struct {\r
-  UINT8   PPRequest;      ///< Physical Presence request command.\r
-  UINT8   LastPPRequest;\r
-  UINT32  PPResponse;\r
+  UINT8     PPRequest;    ///< Physical Presence request command.\r
+  UINT8     LastPPRequest;\r
+  UINT32    PPResponse;\r
 } EFI_PHYSICAL_PRESENCE;\r
 \r
 //\r
 // The definition of physical presence operation actions\r
 //\r
-#define PHYSICAL_PRESENCE_NO_ACTION                               0\r
-#define PHYSICAL_PRESENCE_ENABLE                                  1\r
-#define PHYSICAL_PRESENCE_DISABLE                                 2\r
-#define PHYSICAL_PRESENCE_ACTIVATE                                3\r
-#define PHYSICAL_PRESENCE_DEACTIVATE                              4\r
-#define PHYSICAL_PRESENCE_CLEAR                                   5\r
-#define PHYSICAL_PRESENCE_ENABLE_ACTIVATE                         6\r
-#define PHYSICAL_PRESENCE_DEACTIVATE_DISABLE                      7\r
-#define PHYSICAL_PRESENCE_SET_OWNER_INSTALL_TRUE                  8\r
-#define PHYSICAL_PRESENCE_SET_OWNER_INSTALL_FALSE                 9\r
-#define PHYSICAL_PRESENCE_ENABLE_ACTIVATE_OWNER_TRUE              10\r
-#define PHYSICAL_PRESENCE_DEACTIVATE_DISABLE_OWNER_FALSE          11\r
-#define PHYSICAL_PRESENCE_DEFERRED_PP_UNOWNERED_FIELD_UPGRADE     12\r
-#define PHYSICAL_PRESENCE_SET_OPERATOR_AUTH                       13\r
-#define PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE                   14\r
-#define PHYSICAL_PRESENCE_SET_NO_PPI_PROVISION_FALSE              15\r
-#define PHYSICAL_PRESENCE_SET_NO_PPI_PROVISION_TRUE               16\r
-#define PHYSICAL_PRESENCE_SET_NO_PPI_CLEAR_FALSE                  17\r
-#define PHYSICAL_PRESENCE_SET_NO_PPI_CLEAR_TRUE                   18\r
-#define PHYSICAL_PRESENCE_SET_NO_PPI_MAINTENANCE_FALSE            19\r
-#define PHYSICAL_PRESENCE_SET_NO_PPI_MAINTENANCE_TRUE             20\r
-#define PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR                   21\r
-#define PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE   22\r
+#define PHYSICAL_PRESENCE_NO_ACTION                              0\r
+#define PHYSICAL_PRESENCE_ENABLE                                 1\r
+#define PHYSICAL_PRESENCE_DISABLE                                2\r
+#define PHYSICAL_PRESENCE_ACTIVATE                               3\r
+#define PHYSICAL_PRESENCE_DEACTIVATE                             4\r
+#define PHYSICAL_PRESENCE_CLEAR                                  5\r
+#define PHYSICAL_PRESENCE_ENABLE_ACTIVATE                        6\r
+#define PHYSICAL_PRESENCE_DEACTIVATE_DISABLE                     7\r
+#define PHYSICAL_PRESENCE_SET_OWNER_INSTALL_TRUE                 8\r
+#define PHYSICAL_PRESENCE_SET_OWNER_INSTALL_FALSE                9\r
+#define PHYSICAL_PRESENCE_ENABLE_ACTIVATE_OWNER_TRUE             10\r
+#define PHYSICAL_PRESENCE_DEACTIVATE_DISABLE_OWNER_FALSE         11\r
+#define PHYSICAL_PRESENCE_DEFERRED_PP_UNOWNERED_FIELD_UPGRADE    12\r
+#define PHYSICAL_PRESENCE_SET_OPERATOR_AUTH                      13\r
+#define PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE                  14\r
+#define PHYSICAL_PRESENCE_SET_NO_PPI_PROVISION_FALSE             15\r
+#define PHYSICAL_PRESENCE_SET_NO_PPI_PROVISION_TRUE              16\r
+#define PHYSICAL_PRESENCE_SET_NO_PPI_CLEAR_FALSE                 17\r
+#define PHYSICAL_PRESENCE_SET_NO_PPI_CLEAR_TRUE                  18\r
+#define PHYSICAL_PRESENCE_SET_NO_PPI_MAINTENANCE_FALSE           19\r
+#define PHYSICAL_PRESENCE_SET_NO_PPI_MAINTENANCE_TRUE            20\r
+#define PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR                  21\r
+#define PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE  22\r
 \r
 //\r
 // This variable is used to save TPM Management Flags and corresponding operations.\r
@@ -58,18 +58,17 @@ typedef struct {
 //\r
 #define PHYSICAL_PRESENCE_FLAGS_VARIABLE  L"PhysicalPresenceFlags"\r
 typedef struct {\r
-  UINT8   PPFlags;\r
+  UINT8    PPFlags;\r
 } EFI_PHYSICAL_PRESENCE_FLAGS;\r
 \r
 //\r
 // The definition bit of the TPM Management Flags\r
 //\r
-#define FLAG_NO_PPI_PROVISION                    BIT0\r
-#define FLAG_NO_PPI_CLEAR                        BIT1\r
-#define FLAG_NO_PPI_MAINTENANCE                  BIT2\r
-#define FLAG_RESET_TRACK                         BIT3\r
+#define FLAG_NO_PPI_PROVISION    BIT0\r
+#define FLAG_NO_PPI_CLEAR        BIT1\r
+#define FLAG_NO_PPI_MAINTENANCE  BIT2\r
+#define FLAG_RESET_TRACK         BIT3\r
 \r
 extern EFI_GUID  gEfiPhysicalPresenceGuid;\r
 \r
 #endif\r
-\r
index 556b88b64cd377e6ee3d1481423c1062d6e61ffc..ca96f91abecb96d0b03034bee3440ed94b00dc6e 100644 (file)
@@ -18,6 +18,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0x78b9ec8b, 0xc000, 0x46c5, { 0xac, 0x93, 0x24, 0xa0, 0xc1, 0xbb, 0x0, 0xce } \\r
   }\r
 \r
-extern EFI_GUID gPwdCredentialProviderGuid;\r
+extern EFI_GUID  gPwdCredentialProviderGuid;\r
 \r
 #endif\r
index d84368f74b255fdff1c0e678c847e9edafa23f99..07311d56c482e6c623a9dcb6d2be528f35552b77 100644 (file)
@@ -14,7 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0x5daf50a5, 0xea81, 0x4de2, {0x8f, 0x9b, 0xca, 0xbd, 0xa9, 0xcf, 0x5c, 0x14} \\r
   }\r
 \r
-\r
-extern EFI_GUID gSecureBootConfigFormSetGuid;\r
+extern EFI_GUID  gSecureBootConfigFormSetGuid;\r
 \r
 #endif\r
index fabfba0ad5895052024f5eaf26f30b0041dafb1a..bd9f2c4fc29a3405e274d27ab172fdce78acfdd3 100644 (file)
@@ -14,6 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0xd3fb176, 0x9569, 0x4d51, { 0xa3, 0xef, 0x7d, 0x61, 0xc6, 0x4f, 0xea, 0xba } \\r
   }\r
 \r
-extern EFI_GUID gEfiSecurityPkgTokenSpaceGuid;\r
+extern EFI_GUID  gEfiSecurityPkgTokenSpaceGuid;\r
 \r
 #endif\r
index b472ab19b30aa3217c167a759d5e9215f948c894..51e58b3fa2f62cb2efff0309ba961a2533eec1e7 100644 (file)
@@ -14,6 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0x6339d487, 0x26ba, 0x424b, { 0x9a, 0x5d, 0x68, 0x7e, 0x25, 0xd7, 0x40, 0xbc } \\r
   }\r
 \r
-extern EFI_GUID gTcg2ConfigFormSetGuid;\r
+extern EFI_GUID  gTcg2ConfigFormSetGuid;\r
 \r
 #endif\r
index 382b487649eff9f69f52a56e222cb336f1a4ad60..23c5cfe19ea4bec192e39a36e50bd46b710522b9 100644 (file)
@@ -20,10 +20,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define TCG2_PHYSICAL_PRESENCE_VARIABLE  L"Tcg2PhysicalPresence"\r
 \r
 typedef struct {\r
-  UINT8   PPRequest;      ///< Physical Presence request command.\r
-  UINT32  PPRequestParameter; ///< Physical Presence request Parameter.\r
-  UINT8   LastPPRequest;\r
-  UINT32  PPResponse;\r
+  UINT8     PPRequest;          ///< Physical Presence request command.\r
+  UINT32    PPRequestParameter; ///< Physical Presence request Parameter.\r
+  UINT8     LastPPRequest;\r
+  UINT32    PPResponse;\r
 } EFI_TCG2_PHYSICAL_PRESENCE;\r
 \r
 //\r
@@ -32,10 +32,9 @@ typedef struct {
 //\r
 #define TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE  L"Tcg2PhysicalPresenceFlags"\r
 typedef struct {\r
-  UINT32  PPFlags;\r
+  UINT32    PPFlags;\r
 } EFI_TCG2_PHYSICAL_PRESENCE_FLAGS;\r
 \r
 extern EFI_GUID  gEfiTcg2PhysicalPresenceGuid;\r
 \r
 #endif\r
-\r
index 4eecb57963aac11946efa157da16b0b22d6f2f15..ee87abf025eef7c2a1763fa494b95e90d2923ffc 100644 (file)
@@ -14,6 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0xb0f901e4, 0xc424, 0x45de, {0x90, 0x81, 0x95, 0xe2, 0xb, 0xde, 0x6f, 0xb5 } \\r
   }\r
 \r
-extern EFI_GUID gTcgConfigFormSetGuid;\r
+extern EFI_GUID  gTcgConfigFormSetGuid;\r
 \r
 #endif\r
index 97e40b47d0b1284cc4d83b80ab15b96a2d5833c3..7a7b606d96fc10894dcc66047135c6c0f91e824e 100644 (file)
@@ -19,14 +19,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0x2b9ffb52, 0x1b13, 0x416f, { 0xa8, 0x7b, 0xbc, 0x93, 0xd, 0xef, 0x92, 0xa8 } \\r
   }\r
 \r
-extern EFI_GUID gTcgEventEntryHobGuid;\r
+extern EFI_GUID  gTcgEventEntryHobGuid;\r
 \r
 #define EFI_TCG_EVENT2_HOB_GUID \\r
   { \\r
     0xd26c221e, 0x2430, 0x4c8a, { 0x91, 0x70, 0x3f, 0xcb, 0x45, 0x0, 0x41, 0x3f } \\r
   }\r
 \r
-extern EFI_GUID gTcgEvent2EntryHobGuid;\r
+extern EFI_GUID  gTcgEvent2EntryHobGuid;\r
 \r
 ///\r
 /// The Global ID of a GUIDed HOB used to record TPM device error.\r
@@ -36,7 +36,7 @@ extern EFI_GUID gTcgEvent2EntryHobGuid;
     0xef598499, 0xb25e, 0x473a, { 0xbf, 0xaf, 0xe7, 0xe5, 0x7d, 0xce, 0x82, 0xc4 } \\r
   }\r
 \r
-extern EFI_GUID gTpmErrorHobGuid;\r
+extern EFI_GUID  gTpmErrorHobGuid;\r
 \r
 ///\r
 /// The Global ID of a GUIDed HOB used to record TPM2 Startup Locality.\r
@@ -47,7 +47,7 @@ extern EFI_GUID gTpmErrorHobGuid;
     0xef598499, 0xb25e, 0x473a, { 0xbf, 0xaf, 0xe7, 0xe5, 0x7d, 0xce, 0x82, 0xc4 } \\r
   }\r
 \r
-extern EFI_GUID gTpm2StartupLocalityHobGuid;\r
+extern EFI_GUID  gTpm2StartupLocalityHobGuid;\r
 \r
 ///\r
 /// The Global ID of a GUIDed HOB used to record TCG 800-155 PlatformId Event.\r
@@ -58,6 +58,6 @@ extern EFI_GUID gTpm2StartupLocalityHobGuid;
     0xe2c3bc69, 0x615c, 0x4b5b, { 0x8e, 0x5c, 0xa0, 0x33, 0xa9, 0xc2, 0x5e, 0xd6 } \\r
   }\r
 \r
-extern EFI_GUID gTcg800155PlatformIdEventHobGuid;\r
+extern EFI_GUID  gTcg800155PlatformIdEventHobGuid;\r
 \r
 #endif\r
index d5c97515ede6c9c0ee6519f32df586d78ba3ceed..c9bcc67f80dd027fb7c99fec19e6e9d5ec9f76f7 100644 (file)
@@ -22,11 +22,9 @@ extern EFI_GUID  gEfiTpmDeviceInstanceNoneGuid;
 extern EFI_GUID  gEfiTpmDeviceInstanceTpm12Guid;\r
 extern EFI_GUID  gEfiTpmDeviceInstanceTpm20DtpmGuid;\r
 \r
-\r
 #define TPM_DEVICE_SELECTED_GUID  \\r
   { 0x7f4158d3, 0x74d, 0x456d, { 0x8c, 0xb2, 0x1, 0xf9, 0xc8, 0xf7, 0x9d, 0xaa } }\r
 \r
 extern EFI_GUID  gEfiTpmDeviceSelectedGuid;\r
 \r
 #endif\r
-\r
index 64c0f5c346fad928a7bd481a710709b1b116f402..1dfb568bb410792a866b7d9906a16700ebe557ca 100644 (file)
@@ -14,50 +14,50 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define MM_TPM_NVS_HOB_GUID \\r
   { 0xc96c76eb, 0xbc78, 0x429c, { 0x9f, 0x4b, 0xda, 0x51, 0x78, 0xc2, 0x84, 0x57 }}\r
 \r
-extern EFI_GUID gTpmNvsMmGuid;\r
+extern EFI_GUID  gTpmNvsMmGuid;\r
 \r
 #pragma pack(1)\r
 typedef struct {\r
-  UINT8                  SoftwareSmi;\r
-  UINT32                 Parameter;\r
-  UINT32                 Response;\r
-  UINT32                 Request;\r
-  UINT32                 RequestParameter;\r
-  UINT32                 LastRequest;\r
-  UINT32                 ReturnCode;\r
+  UINT8     SoftwareSmi;\r
+  UINT32    Parameter;\r
+  UINT32    Response;\r
+  UINT32    Request;\r
+  UINT32    RequestParameter;\r
+  UINT32    LastRequest;\r
+  UINT32    ReturnCode;\r
 } PHYSICAL_PRESENCE_NVS;\r
 \r
 typedef struct {\r
-  UINT8                  SoftwareSmi;\r
-  UINT32                 Parameter;\r
-  UINT32                 Request;\r
-  UINT32                 ReturnCode;\r
+  UINT8     SoftwareSmi;\r
+  UINT32    Parameter;\r
+  UINT32    Request;\r
+  UINT32    ReturnCode;\r
 } MEMORY_CLEAR_NVS;\r
 \r
 typedef struct {\r
-  PHYSICAL_PRESENCE_NVS  PhysicalPresence;\r
-  MEMORY_CLEAR_NVS       MemoryClear;\r
-  UINT32                 PPRequestUserConfirm;\r
-  UINT32                 TpmIrqNum;\r
-  BOOLEAN                IsShortFormPkgLength;\r
+  PHYSICAL_PRESENCE_NVS    PhysicalPresence;\r
+  MEMORY_CLEAR_NVS         MemoryClear;\r
+  UINT32                   PPRequestUserConfirm;\r
+  UINT32                   TpmIrqNum;\r
+  BOOLEAN                  IsShortFormPkgLength;\r
 } TCG_NVS;\r
 \r
 typedef struct {\r
-  UINT8                  OpRegionOp;\r
-  UINT32                 NameString;\r
-  UINT8                  RegionSpace;\r
-  UINT8                  DWordPrefix;\r
-  UINT32                 RegionOffset;\r
-  UINT8                  BytePrefix;\r
-  UINT8                  RegionLen;\r
+  UINT8     OpRegionOp;\r
+  UINT32    NameString;\r
+  UINT8     RegionSpace;\r
+  UINT8     DWordPrefix;\r
+  UINT32    RegionOffset;\r
+  UINT8     BytePrefix;\r
+  UINT8     RegionLen;\r
 } AML_OP_REGION_32_8;\r
 \r
 typedef struct {\r
-  UINT64                Function;\r
-  UINT64                ReturnStatus;\r
-  EFI_PHYSICAL_ADDRESS  TargetAddress;\r
-  UINT64                RegisteredPpSwiValue;\r
-  UINT64                RegisteredMcSwiValue;\r
+  UINT64                  Function;\r
+  UINT64                  ReturnStatus;\r
+  EFI_PHYSICAL_ADDRESS    TargetAddress;\r
+  UINT64                  RegisteredPpSwiValue;\r
+  UINT64                  RegisteredMcSwiValue;\r
 } TPM_NVS_MM_COMM_BUFFER;\r
 #pragma pack()\r
 \r
@@ -65,4 +65,4 @@ typedef enum {
   TpmNvsMmExchangeInfo,\r
 } TPM_NVS_MM_FUNCTION;\r
 \r
-#endif  // TCG2_NVS_MM_H_\r
+#endif // TCG2_NVS_MM_H_\r
index 6ad960ad70ee9dd8e1138ad31b5c13eff4062b22..d5ee87012fa1b01ea1aa783fa83871d220739454 100644 (file)
@@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Uefi.h>\r
 #include <Protocol/Hash.h>\r
 #include <IndustryStandard/Tpm20.h>\r
-typedef UINTN  HASH_HANDLE;\r
+typedef UINTN HASH_HANDLE;\r
 \r
 /**\r
   Start hash sequence.\r
@@ -27,7 +27,7 @@ typedef UINTN  HASH_HANDLE;
 EFI_STATUS\r
 EFIAPI\r
 HashStart (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   );\r
 \r
 /**\r
@@ -42,9 +42,9 @@ HashStart (
 EFI_STATUS\r
 EFIAPI\r
 HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   );\r
 \r
 /**\r
@@ -61,11 +61,11 @@ HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 HashCompleteAndExtend (\r
-  IN HASH_HANDLE         HashHandle,\r
-  IN TPMI_DH_PCR         PcrIndex,\r
-  IN VOID                *DataToHash,\r
-  IN UINTN               DataToHashLen,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  IN TPMI_DH_PCR          PcrIndex,\r
+  IN VOID                 *DataToHash,\r
+  IN UINTN                DataToHashLen,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   );\r
 \r
 /**\r
@@ -81,10 +81,10 @@ HashCompleteAndExtend (
 EFI_STATUS\r
 EFIAPI\r
 HashAndExtend (\r
-  IN TPMI_DH_PCR                    PcrIndex,\r
-  IN VOID                           *DataToHash,\r
-  IN UINTN                          DataToHashLen,\r
-  OUT TPML_DIGEST_VALUES            *DigestList\r
+  IN TPMI_DH_PCR          PcrIndex,\r
+  IN VOID                 *DataToHash,\r
+  IN UINTN                DataToHashLen,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   );\r
 \r
 /**\r
@@ -97,7 +97,7 @@ HashAndExtend (
 **/\r
 typedef\r
 EFI_STATUS\r
-(EFIAPI *HASH_INIT) (\r
+(EFIAPI *HASH_INIT)(\r
   OUT HASH_HANDLE    *HashHandle\r
   );\r
 \r
@@ -112,7 +112,7 @@ EFI_STATUS
 **/\r
 typedef\r
 EFI_STATUS\r
-(EFIAPI *HASH_UPDATE) (\r
+(EFIAPI *HASH_UPDATE)(\r
   IN HASH_HANDLE    HashHandle,\r
   IN VOID           *DataToHash,\r
   IN UINTN          DataToHashLen\r
@@ -128,7 +128,7 @@ EFI_STATUS
 **/\r
 typedef\r
 EFI_STATUS\r
-(EFIAPI *HASH_FINAL) (\r
+(EFIAPI *HASH_FINAL)(\r
   IN HASH_HANDLE         HashHandle,\r
   OUT TPML_DIGEST_VALUES *DigestList\r
   );\r
@@ -143,10 +143,10 @@ EFI_STATUS
   }\r
 \r
 typedef struct {\r
-  EFI_GUID                           HashGuid;\r
-  HASH_INIT                          HashInit;\r
-  HASH_UPDATE                        HashUpdate;\r
-  HASH_FINAL                         HashFinal;\r
+  EFI_GUID       HashGuid;\r
+  HASH_INIT      HashInit;\r
+  HASH_UPDATE    HashUpdate;\r
+  HASH_FINAL     HashFinal;\r
 } HASH_INTERFACE;\r
 \r
 /**\r
@@ -161,7 +161,7 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 RegisterHashInterfaceLib (\r
-  IN HASH_INTERFACE   *HashInterface\r
+  IN HASH_INTERFACE  *HashInterface\r
   );\r
 \r
 #endif\r
index c166b7af76b8ab3ce209302d9d9255c1574b6de3..420751aff041e13e83d14c92acf6d7f181ac15c3 100644 (file)
@@ -9,7 +9,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #ifndef __PLATFORM_SECURE_LIB_H__\r
 #define __PLATFORM_SECURE_LIB_H__\r
 \r
-\r
 /**\r
 \r
   This function provides a platform-specific method to detect whether the platform\r
index 5882bfae2f2475d24874ea97f64da5c0d93f57cf..df4ba34ba8cf45facbbf6ac4bbad4b07dce1fa87 100644 (file)
@@ -40,4 +40,3 @@ IncrementMonotonicCounter (
   );\r
 \r
 #endif\r
-\r
index 6e6d624071241ed9b1d80fdb2f2e905eef91ff7f..7b7afd9cde7c75efee6c89eec7404aee8dcea231 100644 (file)
@@ -26,7 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 SetSecureBootMode (\r
   IN  UINT8  SecureBootMode\r
-);\r
+  );\r
 \r
 /**\r
   Fetches the value of SetupMode variable.\r
@@ -38,8 +38,8 @@ SetSecureBootMode (
 EFI_STATUS\r
 EFIAPI\r
 GetSetupMode (\r
-  OUT UINT8 *SetupMode\r
-);\r
+  OUT UINT8  *SetupMode\r
+  );\r
 \r
 /**\r
   Create a EFI Signature List with data fetched from section specified as a argument.\r
@@ -57,10 +57,10 @@ GetSetupMode (
 --*/\r
 EFI_STATUS\r
 SecureBootFetchData (\r
-    IN  EFI_GUID           *KeyFileGuid,\r
-    OUT UINTN              *SigListsSize,\r
-    OUT EFI_SIGNATURE_LIST **SigListOut\r
-);\r
+  IN  EFI_GUID            *KeyFileGuid,\r
+  OUT UINTN               *SigListsSize,\r
+  OUT EFI_SIGNATURE_LIST  **SigListOut\r
+  );\r
 \r
 /**\r
   Create a time based data payload by concatenating the EFI_VARIABLE_AUTHENTICATION_2\r
@@ -82,9 +82,9 @@ SecureBootFetchData (
 --*/\r
 EFI_STATUS\r
 CreateTimeBasedPayload (\r
-  IN OUT UINTN            *DataSize,\r
-  IN OUT UINT8            **Data\r
-);\r
+  IN OUT UINTN  *DataSize,\r
+  IN OUT UINT8  **Data\r
+  );\r
 \r
 /**\r
   Clears the content of the 'db' variable.\r
@@ -97,7 +97,7 @@ EFI_STATUS
 EFIAPI\r
 DeleteDb (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Clears the content of the 'dbx' variable.\r
@@ -110,7 +110,7 @@ EFI_STATUS
 EFIAPI\r
 DeleteDbx (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Clears the content of the 'dbt' variable.\r
@@ -123,7 +123,7 @@ EFI_STATUS
 EFIAPI\r
 DeleteDbt (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Clears the content of the 'KEK' variable.\r
@@ -136,7 +136,7 @@ EFI_STATUS
 EFIAPI\r
 DeleteKEK (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Clears the content of the 'PK' variable.\r
@@ -149,5 +149,6 @@ EFI_STATUS
 EFIAPI\r
 DeletePlatformKey (\r
   VOID\r
-);\r
+  );\r
+\r
 #endif\r
index ba8009b5cdfc76bb5ca80f8989f1c39a31942902..3dc1c3762ca67025e484f4c575a115d86ae96958 100644 (file)
@@ -23,7 +23,7 @@ EFI_STATUS
 EFIAPI\r
 EnrollDbFromDefault (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Sets the content of the 'dbx' variable based on 'dbxDefault' variable content.\r
@@ -36,7 +36,7 @@ EFI_STATUS
 EFIAPI\r
 EnrollDbxFromDefault (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Sets the content of the 'dbt' variable based on 'dbtDefault' variable content.\r
@@ -49,7 +49,7 @@ EFI_STATUS
 EFIAPI\r
 EnrollDbtFromDefault (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Sets the content of the 'KEK' variable based on 'KEKDefault' variable content.\r
@@ -62,7 +62,7 @@ EFI_STATUS
 EFIAPI\r
 EnrollKEKFromDefault (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Sets the content of the 'PK' variable based on 'PKDefault' variable content.\r
@@ -75,7 +75,7 @@ EFI_STATUS
 EFIAPI\r
 EnrollPKFromDefault (\r
   VOID\r
-);\r
+  );\r
 \r
 /**\r
   Initializes PKDefault variable with data from FFS section.\r
@@ -131,4 +131,5 @@ EFI_STATUS
 SecureBootInitDbxDefault (\r
   IN VOID\r
   );\r
+\r
 #endif\r
index e5ff3b1e5eecc2826c2b7d60553bdfa87aec5969..daa0a8da30f4f0fe615798255b04d1f5c54d2263 100644 (file)
@@ -18,13 +18,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // UEFI TCG2 library definition bit of the BIOS TPM Management Flags\r
 //\r
 // BIT0 is reserved\r
-#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CLEAR               BIT1\r
+#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CLEAR  BIT1\r
 // BIT2 is reserved\r
-#define TCG2_LIB_PP_FLAG_RESET_TRACK                                      BIT3\r
-#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_TURN_ON             BIT4\r
-#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_TURN_OFF            BIT5\r
-#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CHANGE_EPS          BIT6\r
-#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CHANGE_PCRS         BIT7\r
+#define TCG2_LIB_PP_FLAG_RESET_TRACK                               BIT3\r
+#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_TURN_ON      BIT4\r
+#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_TURN_OFF     BIT5\r
+#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CHANGE_EPS   BIT6\r
+#define TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CHANGE_PCRS  BIT7\r
 \r
 //\r
 // UEFI TCG2 library definition bit of the BIOS Information Flags\r
@@ -55,7 +55,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 VOID\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibProcessRequest (\r
-  IN      TPM2B_AUTH                     *PlatformAuth  OPTIONAL\r
+  IN      TPM2B_AUTH  *PlatformAuth  OPTIONAL\r
   );\r
 \r
 /**\r
@@ -99,8 +99,8 @@ Tcg2PhysicalPresenceLibGetManagementFlags (
 UINT32\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (\r
-  OUT UINT32                *MostRecentRequest,\r
-  OUT UINT32                *Response\r
+  OUT UINT32  *MostRecentRequest,\r
+  OUT UINT32  *Response\r
   );\r
 \r
 /**\r
@@ -120,8 +120,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
   **/\r
 UINT32\r
 Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx (\r
-  IN OUT UINT32               *OperationRequest,\r
-  IN OUT UINT32               *RequestParameter\r
+  IN OUT UINT32  *OperationRequest,\r
+  IN OUT UINT32  *RequestParameter\r
   );\r
 \r
 /**\r
@@ -142,8 +142,8 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx (
 UINT32\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 RequestParameter\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  RequestParameter\r
   );\r
 \r
 /**\r
@@ -161,7 +161,7 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (
 UINT32\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (\r
-  IN UINT32                 OperationRequest\r
+  IN UINT32  OperationRequest\r
   );\r
 \r
 #endif\r
index 914517f0340a8cfedd83453934c564d0b2d19c93..e5e781a05e41b735923260360a024063f7a0fcc9 100644 (file)
@@ -40,10 +40,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 UINT32\r
 EFIAPI\r
 Tcg2PpVendorLibExecutePendingRequest (\r
-  IN TPM2B_AUTH             *PlatformAuth   OPTIONAL,\r
-  IN UINT32                 OperationRequest,\r
-  IN OUT UINT32             *ManagementFlags,\r
-  OUT BOOLEAN               *ResetRequired\r
+  IN TPM2B_AUTH  *PlatformAuth   OPTIONAL,\r
+  IN UINT32      OperationRequest,\r
+  IN OUT UINT32  *ManagementFlags,\r
+  OUT BOOLEAN    *ResetRequired\r
   );\r
 \r
 /**\r
@@ -67,9 +67,9 @@ Tcg2PpVendorLibExecutePendingRequest (
 BOOLEAN\r
 EFIAPI\r
 Tcg2PpVendorLibHasValidRequest (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags,\r
-  OUT BOOLEAN               *RequestConfirmed\r
+  IN UINT32    OperationRequest,\r
+  IN UINT32    ManagementFlags,\r
+  OUT BOOLEAN  *RequestConfirmed\r
   );\r
 \r
 /**\r
@@ -93,9 +93,9 @@ Tcg2PpVendorLibHasValidRequest (
 UINT32\r
 EFIAPI\r
 Tcg2PpVendorLibSubmitRequestToPreOSFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags,\r
-  IN UINT32                 RequestParameter\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  ManagementFlags,\r
+  IN UINT32  RequestParameter\r
   );\r
 \r
 /**\r
@@ -116,8 +116,8 @@ Tcg2PpVendorLibSubmitRequestToPreOSFunction (
 UINT32\r
 EFIAPI\r
 Tcg2PpVendorLibGetUserConfirmationStatusFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  ManagementFlags\r
   );\r
 \r
 #endif\r
index 99d634c34e60e0b5959a1e2b951d5d87c9b992f8..c6b55202f27916ae7be95710f72ee95f6226509c 100644 (file)
@@ -13,20 +13,20 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #pragma pack (1)\r
 \r
-#define PLATFORM_FIRMWARE_BLOB_DESC "Fv(XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX)"\r
+#define PLATFORM_FIRMWARE_BLOB_DESC  "Fv(XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX)"\r
 typedef struct {\r
-  UINT8                             BlobDescriptionSize;\r
-  UINT8                             BlobDescription[sizeof(PLATFORM_FIRMWARE_BLOB_DESC)];\r
-  EFI_PHYSICAL_ADDRESS              BlobBase;\r
-  UINT64                            BlobLength;\r
+  UINT8                   BlobDescriptionSize;\r
+  UINT8                   BlobDescription[sizeof (PLATFORM_FIRMWARE_BLOB_DESC)];\r
+  EFI_PHYSICAL_ADDRESS    BlobBase;\r
+  UINT64                  BlobLength;\r
 } PLATFORM_FIRMWARE_BLOB2_STRUCT;\r
 \r
 #define HANDOFF_TABLE_POINTER_DESC  "1234567890ABCDEF"\r
 typedef struct {\r
-  UINT8                             TableDescriptionSize;\r
-  UINT8                             TableDescription[sizeof(HANDOFF_TABLE_POINTER_DESC)];\r
-  UINT64                            NumberOfTables;\r
-  EFI_CONFIGURATION_TABLE           TableEntry[1];\r
+  UINT8                      TableDescriptionSize;\r
+  UINT8                      TableDescription[sizeof (HANDOFF_TABLE_POINTER_DESC)];\r
+  UINT64                     NumberOfTables;\r
+  EFI_CONFIGURATION_TABLE    TableEntry[1];\r
 } HANDOFF_TABLE_POINTERS2_STRUCT;\r
 \r
 #pragma pack ()\r
@@ -44,8 +44,8 @@ typedef struct {
 **/\r
 VOID *\r
 TpmMeasurementGetFvName (\r
-  IN EFI_PHYSICAL_ADDRESS           FvBase,\r
-  IN UINT64                         FvLength\r
+  IN EFI_PHYSICAL_ADDRESS  FvBase,\r
+  IN UINT64                FvLength\r
   );\r
 \r
 /**\r
@@ -64,10 +64,10 @@ TpmMeasurementGetFvName (
 EFI_STATUS\r
 EFIAPI\r
 MeasureFirmwareBlob (\r
-  IN UINT32                         PcrIndex,\r
-  IN CHAR8                          *Description OPTIONAL,\r
-  IN EFI_PHYSICAL_ADDRESS           FirmwareBlobBase,\r
-  IN UINT64                         FirmwareBlobLength\r
+  IN UINT32                PcrIndex,\r
+  IN CHAR8                 *Description OPTIONAL,\r
+  IN EFI_PHYSICAL_ADDRESS  FirmwareBlobBase,\r
+  IN UINT64                FirmwareBlobLength\r
   );\r
 \r
 /**\r
@@ -87,11 +87,11 @@ MeasureFirmwareBlob (
 EFI_STATUS\r
 EFIAPI\r
 MeasureHandoffTable (\r
-  IN UINT32                         PcrIndex,\r
-  IN CHAR8                          *Description OPTIONAL,\r
-  IN EFI_GUID                       *TableGuid,\r
-  IN VOID                           *TableAddress,\r
-  IN UINTN                          TableLength\r
+  IN UINT32    PcrIndex,\r
+  IN CHAR8     *Description OPTIONAL,\r
+  IN EFI_GUID  *TableGuid,\r
+  IN VOID      *TableAddress,\r
+  IN UINTN     TableLength\r
   );\r
 \r
 #endif\r
index 9826a797427cf824c1dfed9484c0bc2171103f07..db9645b15df6daae747d020886d25d6020f5a482 100644 (file)
@@ -41,7 +41,7 @@ TcgPhysicalPresenceLibProcessRequest (
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgPhysicalPresenceLibNeedUserConfirm(\r
+TcgPhysicalPresenceLibNeedUserConfirm (\r
   VOID\r
   );\r
 \r
index b6c573ef178783ee2792ef7b10a59fdade37d129..2e2a150c1989b1d5af7700ba8750055d2c276d5d 100644 (file)
@@ -18,40 +18,40 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // The definition of physical presence operation actions\r
 //\r
-#define TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION                         128\r
+#define TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION  128\r
 \r
 //\r
 // The definition bit of the BIOS TPM Management Flags\r
 //\r
-#define TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION                    BIT0\r
-#define TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR                        BIT1\r
-#define TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_MAINTENANCE                  BIT2\r
-#define TCG_VENDOR_LIB_FLAG_RESET_TRACK                                  BIT3\r
+#define TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION    BIT0\r
+#define TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR        BIT1\r
+#define TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_MAINTENANCE  BIT2\r
+#define TCG_VENDOR_LIB_FLAG_RESET_TRACK                  BIT3\r
 \r
 //\r
 // The definition for TPM Operation Response to OS Environment\r
 //\r
-#define TCG_PP_OPERATION_RESPONSE_SUCCESS              0x0\r
-#define TCG_PP_OPERATION_RESPONSE_USER_ABORT           0xFFFFFFF0\r
-#define TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE         0xFFFFFFF1\r
+#define TCG_PP_OPERATION_RESPONSE_SUCCESS       0x0\r
+#define TCG_PP_OPERATION_RESPONSE_USER_ABORT    0xFFFFFFF0\r
+#define TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE  0xFFFFFFF1\r
 \r
 //\r
 // The return code for Submit TPM Request to Pre-OS Environment\r
 // and Submit TPM Request to Pre-OS Environment 2\r
 //\r
-#define TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS                                  0\r
-#define TCG_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED                          1\r
-#define TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE                          2\r
-#define TCG_PP_SUBMIT_REQUEST_TO_PREOS_BLOCKED_BY_BIOS_SETTINGS                 3\r
+#define TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS                   0\r
+#define TCG_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED           1\r
+#define TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE           2\r
+#define TCG_PP_SUBMIT_REQUEST_TO_PREOS_BLOCKED_BY_BIOS_SETTINGS  3\r
 \r
 //\r
 // The return code for Get User Confirmation Status for Operation\r
 //\r
-#define TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED                                 0\r
-#define TCG_PP_GET_USER_CONFIRMATION_BIOS_ONLY                                       1\r
-#define TCG_PP_GET_USER_CONFIRMATION_BLOCKED_BY_BIOS_CONFIGURATION                   2\r
-#define TCG_PP_GET_USER_CONFIRMATION_ALLOWED_AND_PPUSER_REQUIRED                     3\r
-#define TCG_PP_GET_USER_CONFIRMATION_ALLOWED_AND_PPUSER_NOT_REQUIRED                 4\r
+#define TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED                  0\r
+#define TCG_PP_GET_USER_CONFIRMATION_BIOS_ONLY                        1\r
+#define TCG_PP_GET_USER_CONFIRMATION_BLOCKED_BY_BIOS_CONFIGURATION    2\r
+#define TCG_PP_GET_USER_CONFIRMATION_ALLOWED_AND_PPUSER_REQUIRED      3\r
+#define TCG_PP_GET_USER_CONFIRMATION_ALLOWED_AND_PPUSER_NOT_REQUIRED  4\r
 \r
 /**\r
   Check and execute the requested physical presence command.\r
@@ -73,9 +73,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 UINT32\r
 EFIAPI\r
 TcgPpVendorLibExecutePendingRequest (\r
-  IN UINT32                 OperationRequest,\r
-  IN OUT UINT32             *ManagementFlags,\r
-  OUT BOOLEAN               *ResetRequired\r
+  IN UINT32      OperationRequest,\r
+  IN OUT UINT32  *ManagementFlags,\r
+  OUT BOOLEAN    *ResetRequired\r
   );\r
 \r
 /**\r
@@ -99,9 +99,9 @@ TcgPpVendorLibExecutePendingRequest (
 BOOLEAN\r
 EFIAPI\r
 TcgPpVendorLibHasValidRequest (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags,\r
-  OUT BOOLEAN               *RequestConfirmed\r
+  IN UINT32    OperationRequest,\r
+  IN UINT32    ManagementFlags,\r
+  OUT BOOLEAN  *RequestConfirmed\r
   );\r
 \r
 /**\r
@@ -124,8 +124,8 @@ TcgPpVendorLibHasValidRequest (
 UINT32\r
 EFIAPI\r
 TcgPpVendorLibSubmitRequestToPreOSFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  ManagementFlags\r
   );\r
 \r
 /**\r
@@ -146,8 +146,8 @@ TcgPpVendorLibSubmitRequestToPreOSFunction (
 UINT32\r
 EFIAPI\r
 TcgPpVendorLibGetUserConfirmationStatusFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  ManagementFlags\r
   );\r
 \r
 #endif\r
index a426251d69782d99b2a0a7a680fca9e11a8c5940..ff610d1bd494cc074a3bf086853d20f6b23a9094 100644 (file)
@@ -115,7 +115,7 @@ typedef struct {
   UINT32            BufferSize;\r
 \r
   //\r
-  //Pointer to the start of the Tcg ComPacket.  It should point to a location within Buffer.\r
+  // Pointer to the start of the Tcg ComPacket.  It should point to a location within Buffer.\r
   //\r
   TCG_COM_PACKET    *ComPacket;\r
 \r
@@ -136,7 +136,7 @@ typedef struct {
   // Then the client can allocate the required Buffer Size and re-run the tcg calls.\r
   // THIS MAY NOT BE IMPLEMENTED... REQUIRES MORE THOUGHT BECAUSE YOU CANNOT SOLVE ISSUE FOR RECEIVE\r
   //\r
-  BOOLEAN          DryRun;\r
+  BOOLEAN    DryRun;\r
 } TCG_CREATE_STRUCT;\r
 \r
 //\r
@@ -155,34 +155,33 @@ typedef struct  {
   // Buffer allocated and freed by the client of the Tcg library.\r
   // This is the Buffer that contains the Tcg response to decode/parse.\r
   //\r
-  const VOID*         Buffer;\r
+  const VOID        *Buffer;\r
 \r
   //\r
-  //Size of the Buffer provided.\r
+  // Size of the Buffer provided.\r
   //\r
-  UINT32              BufferSize;\r
+  UINT32            BufferSize;\r
 \r
   //\r
   // Pointer to the start of the Tcg ComPacket.  It should point to a location within Buffer.\r
   //\r
-  TCG_COM_PACKET      *ComPacket;\r
+  TCG_COM_PACKET    *ComPacket;\r
 \r
   //\r
   // Current Tcg Packet that is being created.  It should point to a location within Buffer.\r
   //\r
-  TCG_PACKET          *CurPacket;\r
+  TCG_PACKET        *CurPacket;\r
 \r
   //\r
   // Current Tcg SubPacket that is being created.  It should point to a location within Buffer.\r
   //\r
-  TCG_SUB_PACKET      *CurSubPacket;\r
+  TCG_SUB_PACKET    *CurSubPacket;\r
 \r
   //\r
   // Current pointer within the current subpacket payload.\r
   //\r
-  UINT8               *CurPtr;\r
-} TCG_PARSE_STRUCT ;\r
-\r
+  UINT8             *CurPtr;\r
+} TCG_PARSE_STRUCT;\r
 \r
 //\r
 // Structure that is used to represent a Tcg Token that is retrieved by Tcg parse functions.\r
@@ -197,7 +196,7 @@ typedef struct {
   // Pointer to the beginning of the Header of the Tcg token\r
   //\r
   UINT8             *HdrStart;\r
-} TCG_TOKEN ;\r
+} TCG_TOKEN;\r
 \r
 /**\r
 \r
@@ -211,13 +210,12 @@ typedef struct {
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgInitTcgCreateStruct(\r
-  TCG_CREATE_STRUCT      *CreateStruct,\r
-  VOID                   *Buffer,\r
-  UINT32                 BufferSize\r
+TcgInitTcgCreateStruct (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  VOID               *Buffer,\r
+  UINT32             BufferSize\r
   );\r
 \r
-\r
 /**\r
 \r
   Encodes the ComPacket header to the data structure.\r
@@ -229,13 +227,12 @@ TcgInitTcgCreateStruct(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartComPacket(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT16              ComId,\r
-  UINT16              ComIdExtension\r
+TcgStartComPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension\r
   );\r
 \r
-\r
 /**\r
 \r
   Starts a new ComPacket in the Data structure.\r
@@ -250,13 +247,13 @@ TcgStartComPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartPacket(\r
-  TCG_CREATE_STRUCT       *CreateStruct,\r
-  UINT32                  Tsn,\r
-  UINT32                  Hsn,\r
-  UINT32                  SeqNumber,\r
-  UINT16                  AckType,\r
-  UINT32                  Ack\r
+TcgStartPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             Tsn,\r
+  UINT32             Hsn,\r
+  UINT32             SeqNumber,\r
+  UINT16             AckType,\r
+  UINT32             Ack\r
   );\r
 \r
 /**\r
@@ -269,12 +266,11 @@ TcgStartPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartSubPacket(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT16              Kind\r
+TcgStartSubPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT16             Kind\r
   );\r
 \r
-\r
 /**\r
 \r
   Ends the current SubPacket in the Data structure.  This function will also perform the 4-byte padding\r
@@ -285,11 +281,10 @@ TcgStartSubPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndSubPacket(\r
-  TCG_CREATE_STRUCT   *CreateStruct\r
+TcgEndSubPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
 \r
   Ends the current Packet in the Data structure.\r
@@ -299,11 +294,10 @@ TcgEndSubPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndPacket(\r
-  TCG_CREATE_STRUCT     *CreateStruct\r
+TcgEndPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
 \r
   Ends the ComPacket in the Data structure and ret\r
@@ -314,9 +308,9 @@ TcgEndPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndComPacket(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT32              *Size\r
+TcgEndComPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size\r
   );\r
 \r
 /**\r
@@ -328,12 +322,11 @@ TcgEndComPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddRawByte(\r
+TcgAddRawByte (\r
   TCG_CREATE_STRUCT  *CreateStruct,\r
   UINT8              Byte\r
   );\r
 \r
-\r
 /**\r
 \r
   Adds the Data parameter as a byte sequence to the Data structure.\r
@@ -347,14 +340,13 @@ TcgAddRawByte(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddByteSequence(\r
-  TCG_CREATE_STRUCT     *CreateStruct,\r
-  const VOID            *Data,\r
-  UINT32                DataSize,\r
-  BOOLEAN               Continued\r
+TcgAddByteSequence (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  const VOID         *Data,\r
+  UINT32             DataSize,\r
+  BOOLEAN            Continued\r
   );\r
 \r
-\r
 /**\r
 \r
   Adds an arbitrary-Length integer to the Data structure.\r
@@ -369,14 +361,13 @@ TcgAddByteSequence(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddInteger(\r
+TcgAddInteger (\r
   TCG_CREATE_STRUCT  *CreateStruct,\r
   const VOID         *Data,\r
   UINT32             DataSize,\r
   BOOLEAN            SignedInteger\r
   );\r
 \r
-\r
 /**\r
   Adds an 8-bit unsigned integer to the Data structure.\r
 \r
@@ -386,9 +377,9 @@ TcgAddInteger(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddUINT8(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT8               Value\r
+TcgAddUINT8 (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT8              Value\r
   );\r
 \r
 /**\r
@@ -402,8 +393,8 @@ TcgAddUINT8(
 TCG_RESULT\r
 EFIAPI\r
 TcgAddUINT16 (\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT16              Value\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT16             Value\r
   );\r
 \r
 /**\r
@@ -416,12 +407,11 @@ TcgAddUINT16 (
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddUINT32(\r
-  TCG_CREATE_STRUCT    *CreateStruct,\r
-  UINT32               Value\r
+TcgAddUINT32 (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             Value\r
   );\r
 \r
-\r
 /**\r
 \r
   Adds a 64-bit unsigned integer to the Data structure.\r
@@ -432,9 +422,9 @@ TcgAddUINT32(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddUINT64(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT64              Value\r
+TcgAddUINT64 (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT64             Value\r
   );\r
 \r
 /**\r
@@ -446,9 +436,9 @@ TcgAddUINT64(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddBOOLEAN(\r
-  TCG_CREATE_STRUCT    *CreateStruct,\r
-  BOOLEAN              Value\r
+TcgAddBOOLEAN (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  BOOLEAN            Value\r
   );\r
 \r
 /**\r
@@ -462,9 +452,9 @@ TcgAddBOOLEAN(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddTcgUid(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  TCG_UID             Uid\r
+TcgAddTcgUid (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  TCG_UID            Uid\r
   );\r
 \r
 /**\r
@@ -475,11 +465,10 @@ TcgAddTcgUid(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddStartList(\r
-  TCG_CREATE_STRUCT    *CreateStruct\r
+TcgAddStartList (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
 \r
  Adds an End List token to the Data structure.\r
@@ -489,11 +478,10 @@ TcgAddStartList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndList(\r
-  TCG_CREATE_STRUCT     *CreateStruct\r
+TcgAddEndList (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
  Adds a Start Name token to the Data structure.\r
 \r
@@ -502,11 +490,10 @@ TcgAddEndList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddStartName(\r
-  TCG_CREATE_STRUCT      *CreateStruct\r
+TcgAddStartName (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
 \r
  Adds an End Name token to the Data structure.\r
@@ -516,11 +503,10 @@ TcgAddStartName(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndName(\r
-  TCG_CREATE_STRUCT            *CreateStruct\r
+TcgAddEndName (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
  Adds a Call token to the Data structure.\r
 \r
@@ -529,11 +515,10 @@ TcgAddEndName(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddCall(\r
-  TCG_CREATE_STRUCT            *CreateStruct\r
+TcgAddCall (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
 \r
 Adds an End of Data token to the Data structure.\r
@@ -543,11 +528,10 @@ Adds an End of Data token to the Data structure.
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndOfData(\r
-  TCG_CREATE_STRUCT            *CreateStruct\r
+TcgAddEndOfData (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
 \r
 Adds an End of Session token to the Data structure.\r
@@ -557,11 +541,10 @@ Adds an End of Session token to the Data structure.
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndOfSession(\r
-  TCG_CREATE_STRUCT             *CreateStruct\r
+TcgAddEndOfSession (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
  Adds a Start Transaction token to the Data structure.\r
 \r
@@ -570,11 +553,10 @@ TcgAddEndOfSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddStartTransaction(\r
-  TCG_CREATE_STRUCT              *CreateStruct\r
+TcgAddStartTransaction (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
-\r
 /**\r
  Adds an End Transaction token to the Data structure.\r
 \r
@@ -583,8 +565,8 @@ TcgAddStartTransaction(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndTransaction(\r
-  TCG_CREATE_STRUCT             *CreateStruct\r
+TcgAddEndTransaction (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
 /**\r
@@ -599,10 +581,10 @@ TcgAddEndTransaction(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgInitTcgParseStruct(\r
-  TCG_PARSE_STRUCT          *ParseStruct,\r
-  const VOID                *Buffer,\r
-  UINT32                    BufferSize\r
+TcgInitTcgParseStruct (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  const VOID        *Buffer,\r
+  UINT32            BufferSize\r
   );\r
 \r
 /**\r
@@ -616,9 +598,9 @@ TcgInitTcgParseStruct(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextToken(\r
-  TCG_PARSE_STRUCT      *ParseStruct,\r
-  TCG_TOKEN             *TcgToken\r
+TcgGetNextToken (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  TCG_TOKEN         *TcgToken\r
   );\r
 \r
 /**\r
@@ -632,9 +614,9 @@ TcgGetNextToken(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextTokenType(\r
-  TCG_PARSE_STRUCT        *ParseStruct,\r
-  TCG_TOKEN_TYPE          Type\r
+TcgGetNextTokenType (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  TCG_TOKEN_TYPE    Type\r
   );\r
 \r
 /**\r
@@ -651,12 +633,12 @@ TcgGetNextTokenType(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetAtomInfo(\r
-  const TCG_TOKEN      *TcgToken,\r
-  UINT32               *HeaderLength,\r
-  UINT32               *DataLength,\r
-  UINT8                *ByteOrInt,\r
-  UINT8                *SignOrCont\r
+TcgGetAtomInfo (\r
+  const TCG_TOKEN  *TcgToken,\r
+  UINT32           *HeaderLength,\r
+  UINT32           *DataLength,\r
+  UINT8            *ByteOrInt,\r
+  UINT8            *SignOrCont\r
   );\r
 \r
 /**\r
@@ -668,11 +650,11 @@ TcgGetAtomInfo(
   @retval   Return the value data.\r
 \r
 **/\r
-UINT8*\r
+UINT8 *\r
 EFIAPI\r
-TcgGetTokenByteSequence(\r
-  const TCG_TOKEN     *TcgToken,\r
-  UINT32              *Length\r
+TcgGetTokenByteSequence (\r
+  const TCG_TOKEN  *TcgToken,\r
+  UINT32           *Length\r
   );\r
 \r
 /**\r
@@ -686,12 +668,11 @@ TcgGetTokenByteSequence(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetTokenUINT64(\r
-  const TCG_TOKEN      *TcgToken,\r
-  UINT64               *Value\r
+TcgGetTokenUINT64 (\r
+  const TCG_TOKEN  *TcgToken,\r
+  UINT64           *Value\r
   );\r
 \r
-\r
 /**\r
   Get next specify value.\r
 \r
@@ -703,12 +684,11 @@ TcgGetTokenUINT64(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextUINT8(\r
-  TCG_PARSE_STRUCT      *ParseStruct,\r
-  UINT8                 *Value\r
+TcgGetNextUINT8 (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT8             *Value\r
   );\r
 \r
-\r
 /**\r
   Get next specify value.\r
 \r
@@ -720,9 +700,9 @@ TcgGetNextUINT8(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextUINT16(\r
-  TCG_PARSE_STRUCT     *ParseStruct,\r
-  UINT16               *Value\r
+TcgGetNextUINT16 (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT16            *Value\r
   );\r
 \r
 /**\r
@@ -736,9 +716,9 @@ TcgGetNextUINT16(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextUINT32(\r
-  TCG_PARSE_STRUCT          *ParseStruct,\r
-  UINT32                    *Value\r
+TcgGetNextUINT32 (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT32            *Value\r
   );\r
 \r
 /**\r
@@ -752,9 +732,9 @@ TcgGetNextUINT32(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextUINT64(\r
-  TCG_PARSE_STRUCT           *ParseStruct,\r
-  UINT64                     *Value\r
+TcgGetNextUINT64 (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT64            *Value\r
   );\r
 \r
 /**\r
@@ -768,9 +748,9 @@ TcgGetNextUINT64(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextBOOLEAN(\r
-  TCG_PARSE_STRUCT        *ParseStruct,\r
-  BOOLEAN                 *Value\r
+TcgGetNextBOOLEAN (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  BOOLEAN           *Value\r
   );\r
 \r
 /**\r
@@ -784,9 +764,9 @@ TcgGetNextBOOLEAN(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextTcgUid(\r
-  TCG_PARSE_STRUCT         *ParseStruct,\r
-  TCG_UID                  *Uid\r
+TcgGetNextTcgUid (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  TCG_UID           *Uid\r
   );\r
 \r
 /**\r
@@ -801,10 +781,10 @@ TcgGetNextTcgUid(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextByteSequence(\r
-  TCG_PARSE_STRUCT      *ParseStruct,\r
-  const VOID            **Data,\r
-  UINT32                *Length\r
+TcgGetNextByteSequence (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  const VOID        **Data,\r
+  UINT32            *Length\r
   );\r
 \r
 /**\r
@@ -817,8 +797,8 @@ TcgGetNextByteSequence(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextStartList(\r
-  TCG_PARSE_STRUCT          *ParseStruct\r
+TcgGetNextStartList (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 /**\r
@@ -831,8 +811,8 @@ TcgGetNextStartList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndList(\r
-  TCG_PARSE_STRUCT             *ParseStruct\r
+TcgGetNextEndList (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 /**\r
@@ -845,8 +825,8 @@ TcgGetNextEndList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextStartName(\r
-  TCG_PARSE_STRUCT              *ParseStruct\r
+TcgGetNextStartName (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 /**\r
@@ -859,8 +839,8 @@ TcgGetNextStartName(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndName(\r
-  TCG_PARSE_STRUCT               *ParseStruct\r
+TcgGetNextEndName (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 /**\r
@@ -873,8 +853,8 @@ TcgGetNextEndName(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextCall(\r
-  TCG_PARSE_STRUCT                   *ParseStruct\r
+TcgGetNextCall (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 /**\r
@@ -887,8 +867,8 @@ TcgGetNextCall(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndOfData(\r
-  TCG_PARSE_STRUCT                    *ParseStruct\r
+TcgGetNextEndOfData (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 /**\r
@@ -901,8 +881,8 @@ TcgGetNextEndOfData(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndOfSession(\r
-  TCG_PARSE_STRUCT                      *ParseStruct\r
+TcgGetNextEndOfSession (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 /**\r
@@ -915,8 +895,8 @@ TcgGetNextEndOfSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextStartTransaction(\r
-  TCG_PARSE_STRUCT                        *ParseStruct\r
+TcgGetNextStartTransaction (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 /**\r
@@ -929,21 +909,20 @@ TcgGetNextStartTransaction(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndTransaction(\r
-  TCG_PARSE_STRUCT                  *ParseStruct\r
+TcgGetNextEndTransaction (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   );\r
 \r
 // end of parse functions\r
 \r
-\r
 typedef\r
 BOOLEAN\r
-(EFIAPI* TCG_LEVEL0_ENUM_CALLBACK) (\r
+(EFIAPI *TCG_LEVEL0_ENUM_CALLBACK)(\r
   const TCG_LEVEL0_DISCOVERY_HEADER      *DiscoveryHeader,\r
   TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER   *Feature,\r
   UINTN                                  FeatureSize, // includes header\r
   VOID                                   *Context\r
-);\r
+  );\r
 \r
 /**\r
   Adds call token and method Header (invoking id, and method id).\r
@@ -955,10 +934,10 @@ BOOLEAN
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartMethodCall(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  TCG_UID             InvokingId,\r
-  TCG_UID             MethodId\r
+TcgStartMethodCall (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  TCG_UID            InvokingId,\r
+  TCG_UID            MethodId\r
   );\r
 \r
 /**\r
@@ -969,8 +948,8 @@ TcgStartMethodCall(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartParameters(\r
-  TCG_CREATE_STRUCT           *CreateStruct\r
+TcgStartParameters (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
 /**\r
@@ -981,8 +960,8 @@ TcgStartParameters(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndParameters(\r
-  TCG_CREATE_STRUCT   *CreateStruct\r
+TcgEndParameters (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
 /**\r
@@ -993,8 +972,8 @@ TcgEndParameters(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndMethodCall(\r
-  TCG_CREATE_STRUCT      *CreateStruct\r
+TcgEndMethodCall (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   );\r
 \r
 /**\r
@@ -1016,17 +995,17 @@ TcgEndMethodCall(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCreateStartSession(\r
-  TCG_CREATE_STRUCT     *CreateStruct,\r
-  UINT32                *Size,\r
-  UINT16                ComId,\r
-  UINT16                ComIdExtension,\r
-  UINT32                HostSessionId,\r
-  TCG_UID               SpId,\r
-  BOOLEAN               Write,\r
-  UINT32                HostChallengeLength,\r
-  const VOID            *HostChallenge,\r
-  TCG_UID               HostSigningAuthority\r
+TcgCreateStartSession (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             HostSessionId,\r
+  TCG_UID            SpId,\r
+  BOOLEAN            Write,\r
+  UINT32             HostChallengeLength,\r
+  const VOID         *HostChallenge,\r
+  TCG_UID            HostSigningAuthority\r
   );\r
 \r
 /**\r
@@ -1046,16 +1025,16 @@ TcgCreateStartSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCreateSetCPin(\r
-  TCG_CREATE_STRUCT       *CreateStruct,\r
-  UINT32                  *Size,\r
-  UINT16                  ComId,\r
-  UINT16                  ComIdExtension,\r
-  UINT32                  TperSession,\r
-  UINT32                  HostSession,\r
-  TCG_UID                 SidRow,\r
-  const VOID              *Password,\r
-  UINT32                  PasswordSize\r
+TcgCreateSetCPin (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             TperSession,\r
+  UINT32             HostSession,\r
+  TCG_UID            SidRow,\r
+  const VOID         *Password,\r
+  UINT32             PasswordSize\r
   );\r
 \r
 /**\r
@@ -1074,15 +1053,15 @@ TcgCreateSetCPin(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgSetAuthorityEnabled(\r
-  TCG_CREATE_STRUCT           *CreateStruct,\r
-  UINT32                      *Size,\r
-  UINT16                      ComId,\r
-  UINT16                      ComIdExtension,\r
-  UINT32                      TperSession,\r
-  UINT32                      HostSession,\r
-  TCG_UID                     AuthorityUid,\r
-  BOOLEAN                     Enabled\r
+TcgSetAuthorityEnabled (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             TperSession,\r
+  UINT32             HostSession,\r
+  TCG_UID            AuthorityUid,\r
+  BOOLEAN            Enabled\r
   );\r
 \r
 /**\r
@@ -1100,16 +1079,15 @@ TcgSetAuthorityEnabled(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCreateEndSession(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT32              *Size,\r
-  UINT16              ComId,\r
-  UINT16              ComIdExtension,\r
-  UINT32              HostSessionId,\r
-  UINT32              TpSessionId\r
+TcgCreateEndSession (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             HostSessionId,\r
+  UINT32             TpSessionId\r
   );\r
 \r
-\r
 /**\r
 \r
  Retrieves human-readable token type name.\r
@@ -1117,9 +1095,9 @@ TcgCreateEndSession(
  @param[in]   Type  Token type to retrieve\r
 \r
 **/\r
-CHAR8*\r
+CHAR8 *\r
 EFIAPI\r
-TcgTokenTypeString(\r
+TcgTokenTypeString (\r
   TCG_TOKEN_TYPE  Type\r
   );\r
 \r
@@ -1133,9 +1111,9 @@ TcgTokenTypeString(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetMethodStatus(\r
-  const TCG_PARSE_STRUCT            *ParseStruct,\r
-  UINT8                             *MethodStatus\r
+TcgGetMethodStatus (\r
+  const TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT8                   *MethodStatus\r
   );\r
 \r
 /**\r
@@ -1146,13 +1124,12 @@ TcgGetMethodStatus(
 \r
   @retval   return the string info.\r
 **/\r
-CHAR8*\r
+CHAR8 *\r
 EFIAPI\r
-TcgMethodStatusString(\r
-  UINT8 MethodStatus\r
+TcgMethodStatusString (\r
+  UINT8  MethodStatus\r
   );\r
 \r
-\r
 /**\r
   Retrieves the comID and Extended comID of the ComPacket in the Tcg response.\r
   It is intended to be used to confirm the received Tcg response is intended for user that received it.\r
@@ -1164,10 +1141,10 @@ TcgMethodStatusString(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetComIds(\r
-  const TCG_PARSE_STRUCT     *ParseStruct,\r
-  UINT16                     *ComId,\r
-  UINT16                     *ComIdExtension\r
+TcgGetComIds (\r
+  const TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT16                  *ComId,\r
+  UINT16                  *ComIdExtension\r
   );\r
 \r
 /**\r
@@ -1180,10 +1157,10 @@ TcgGetComIds(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCheckComIds(\r
-  const TCG_PARSE_STRUCT     *ParseStruct,\r
-  UINT16                     ExpectedComId,\r
-  UINT16                     ExpectedComIdExtension\r
+TcgCheckComIds (\r
+  const TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT16                  ExpectedComId,\r
+  UINT16                  ExpectedComIdExtension\r
   );\r
 \r
 /**\r
@@ -1199,7 +1176,7 @@ TcgCheckComIds(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgParseSyncSession(\r
+TcgParseSyncSession (\r
   const TCG_PARSE_STRUCT  *ParseStruct,\r
   UINT16                  ComId,\r
   UINT16                  ComIdExtension,\r
@@ -1226,17 +1203,17 @@ TcgParseSyncSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCreateSetAce(\r
-  TCG_CREATE_STRUCT        *CreateStruct,\r
-  UINT32                   *Size,\r
-  UINT16                   ComId,\r
-  UINT16                   ComIdExtension,\r
-  UINT32                   TperSession,\r
-  UINT32                   HostSession,\r
-  TCG_UID                  AceRow,\r
-  TCG_UID                  Authority1,\r
-  BOOLEAN                  LogicalOperator,\r
-  TCG_UID                  Authority2\r
+TcgCreateSetAce (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             TperSession,\r
+  UINT32             HostSession,\r
+  TCG_UID            AceRow,\r
+  TCG_UID            Authority1,\r
+  BOOLEAN            LogicalOperator,\r
+  TCG_UID            Authority2\r
   );\r
 \r
 /**\r
@@ -1251,7 +1228,7 @@ TcgCreateSetAce(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgEnumLevel0Discovery(\r
+TcgEnumLevel0Discovery (\r
   const TCG_LEVEL0_DISCOVERY_HEADER  *DiscoveryHeader,\r
   TCG_LEVEL0_ENUM_CALLBACK           Callback,\r
   VOID                               *Context\r
@@ -1266,9 +1243,9 @@ TcgEnumLevel0Discovery(
 \r
   @retval    return the Feature code data.\r
 **/\r
-TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER*\r
+TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER *\r
 EFIAPI\r
-TcgGetFeature(\r
+TcgGetFeature (\r
   const TCG_LEVEL0_DISCOVERY_HEADER  *DiscoveryHeader,\r
   UINT16                             FeatureCode,\r
   UINTN                              *FeatureSize\r
@@ -1284,9 +1261,9 @@ TcgGetFeature(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgIsProtocolSupported(\r
-  const TCG_SUPPORTED_SECURITY_PROTOCOLS   *ProtocolList,\r
-  UINT16                                   Protocol\r
+TcgIsProtocolSupported (\r
+  const TCG_SUPPORTED_SECURITY_PROTOCOLS  *ProtocolList,\r
+  UINT16                                  Protocol\r
   );\r
 \r
 /**\r
@@ -1299,11 +1276,10 @@ TcgIsProtocolSupported(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgIsLocked(\r
-  const TCG_LEVEL0_DISCOVERY_HEADER      *Discovery\r
+TcgIsLocked (\r
+  const TCG_LEVEL0_DISCOVERY_HEADER  *Discovery\r
   );\r
 \r
 #pragma pack()\r
 \r
-\r
 #endif // _TCG_CORE_H_\r
index a28cebe738ac0151862c7e3e92a97c145bd3200d..9ce8fe4f3c9e565851235ee80425f2c8b88dbf26 100644 (file)
@@ -37,74 +37,74 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-    //\r
-    // Opal SSC 1 support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 OpalSsc1 : 1;\r
-\r
-    //\r
-    // Opal SSC 2support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 OpalSsc2 : 1;\r
-\r
-    //\r
-    // Opal SSC Lite support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 OpalSscLite : 1;\r
-\r
-    //\r
-    // Pyrite SSC support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 PyriteSsc : 1;\r
-\r
-    //\r
-    // Security protocol 1 support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 Sp1 : 1;\r
-\r
-    //\r
-    // Security protocol 2 support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 Sp2 : 1;\r
-\r
-    //\r
-    // Security protocol IEEE1667 support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 SpIeee1667 : 1;\r
-\r
-    //\r
-    // Media encryption supported (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 MediaEncryption : 1;\r
-\r
-    //\r
-    // Initial C_PIN_SID PIN Indicator\r
-    //  0 - The initial C_PIN_SID PIN value is NOT equal to the C_PIN_MSID PIN value\r
-    //  1 - The initial C_PIN_SID PIN value is equal to the C_PIN_MSID PIN value\r
-    //\r
-    UINT32 InitCpinIndicator : 1;\r
-\r
-    //\r
-    // Behavior of C_PIN_SID PIN upon TPer Revert\r
-    //  0 - The initial C_PIN_SID PIN value is NOT equal to the C_PIN_MSID PIN value\r
-    //  1 - The initial C_PIN_SID PIN value is equal to the C_PIN_MSID PIN value\r
-    //\r
-    UINT32 CpinUponRevert : 1;\r
-\r
-    //\r
-    // Media encryption supported (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 BlockSid : 1;\r
-\r
-    //\r
-    // Pyrite SSC V2 support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 PyriteSscV2 : 1;\r
-\r
-    //\r
-    // Supported Data Removal Mechanism support  (0 - not supported, 1 - supported)\r
-    //\r
-    UINT32 DataRemoval : 1;\r
+  //\r
+  // Opal SSC 1 support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    OpalSsc1          : 1;\r
+\r
+  //\r
+  // Opal SSC 2support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    OpalSsc2          : 1;\r
+\r
+  //\r
+  // Opal SSC Lite support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    OpalSscLite       : 1;\r
+\r
+  //\r
+  // Pyrite SSC support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    PyriteSsc         : 1;\r
+\r
+  //\r
+  // Security protocol 1 support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    Sp1               : 1;\r
+\r
+  //\r
+  // Security protocol 2 support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    Sp2               : 1;\r
+\r
+  //\r
+  // Security protocol IEEE1667 support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    SpIeee1667        : 1;\r
+\r
+  //\r
+  // Media encryption supported (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    MediaEncryption   : 1;\r
+\r
+  //\r
+  // Initial C_PIN_SID PIN Indicator\r
+  //  0 - The initial C_PIN_SID PIN value is NOT equal to the C_PIN_MSID PIN value\r
+  //  1 - The initial C_PIN_SID PIN value is equal to the C_PIN_MSID PIN value\r
+  //\r
+  UINT32    InitCpinIndicator : 1;\r
+\r
+  //\r
+  // Behavior of C_PIN_SID PIN upon TPer Revert\r
+  //  0 - The initial C_PIN_SID PIN value is NOT equal to the C_PIN_MSID PIN value\r
+  //  1 - The initial C_PIN_SID PIN value is equal to the C_PIN_MSID PIN value\r
+  //\r
+  UINT32    CpinUponRevert    : 1;\r
+\r
+  //\r
+  // Media encryption supported (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    BlockSid          : 1;\r
+\r
+  //\r
+  // Pyrite SSC V2 support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    PyriteSscV2       : 1;\r
+\r
+  //\r
+  // Supported Data Removal Mechanism support  (0 - not supported, 1 - supported)\r
+  //\r
+  UINT32    DataRemoval       : 1;\r
 } OPAL_DISK_SUPPORT_ATTRIBUTE;\r
 \r
 //\r
@@ -112,16 +112,16 @@ typedef struct {
 // The type indicates who was the determined owner of the device.\r
 //\r
 typedef enum {\r
-    //\r
-    // Represents the device ownership is unknown because starting a session as the SID authority with the ADMIN SP\r
-    //was unsuccessful with the provided PIN\r
-    //\r
-    OpalOwnershipUnknown,\r
-\r
-    //\r
-    // Represents that the ADMIN SP SID authority contains the same PIN as the MSID PIN\r
-    //\r
-    OpalOwnershipNobody,\r
+  //\r
+  // Represents the device ownership is unknown because starting a session as the SID authority with the ADMIN SP\r
+  // was unsuccessful with the provided PIN\r
+  //\r
+  OpalOwnershipUnknown,\r
+\r
+  //\r
+  // Represents that the ADMIN SP SID authority contains the same PIN as the MSID PIN\r
+  //\r
+  OpalOwnershipNobody,\r
 } OPAL_OWNER_SHIP;\r
 \r
 //\r
@@ -132,14 +132,14 @@ typedef enum {
 //\r
 //\r
 typedef struct  {\r
-    UINT32                                 HostSessionId;\r
-    UINT32                                 TperSessionId;\r
-    UINT16                                 ComIdExtension;\r
+  UINT32                                   HostSessionId;\r
+  UINT32                                   TperSessionId;\r
+  UINT16                                   ComIdExtension;\r
 \r
-    UINT16                                 OpalBaseComId;\r
+  UINT16                                   OpalBaseComId;\r
 \r
-    EFI_STORAGE_SECURITY_COMMAND_PROTOCOL  *Sscp;\r
-    UINT32                                 MediaId;\r
+  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL    *Sscp;\r
+  UINT32                                   MediaId;\r
 } OPAL_SESSION;\r
 #pragma pack()\r
 \r
@@ -155,10 +155,10 @@ typedef struct  {
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalRetrieveSupportedProtocolList(\r
-  OPAL_SESSION     *Session,\r
-  UINTN            BufferSize,\r
-  VOID             *BuffAddress\r
+OpalRetrieveSupportedProtocolList (\r
+  OPAL_SESSION  *Session,\r
+  UINTN         BufferSize,\r
+  VOID          *BuffAddress\r
   );\r
 \r
 /**\r
@@ -173,10 +173,10 @@ OpalRetrieveSupportedProtocolList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalRetrieveLevel0DiscoveryHeader(\r
-  OPAL_SESSION     *Session,\r
-  UINTN            BufferSize,\r
-  VOID             *BuffAddress\r
+OpalRetrieveLevel0DiscoveryHeader (\r
+  OPAL_SESSION  *Session,\r
+  UINTN         BufferSize,\r
+  VOID          *BuffAddress\r
   );\r
 \r
 /**\r
@@ -199,14 +199,14 @@ OpalRetrieveLevel0DiscoveryHeader(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalStartSession(\r
-  OPAL_SESSION     *Session,\r
-  TCG_UID          SpId,\r
-  BOOLEAN          Write,\r
-  UINT32           HostChallengeLength,\r
-  const VOID       *HostChallenge,\r
-  TCG_UID          HostSigningAuthority,\r
-  UINT8            *MethodStatus\r
+OpalStartSession (\r
+  OPAL_SESSION  *Session,\r
+  TCG_UID       SpId,\r
+  BOOLEAN       Write,\r
+  UINT32        HostChallengeLength,\r
+  const VOID    *HostChallenge,\r
+  TCG_UID       HostSigningAuthority,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
 /**\r
@@ -217,8 +217,8 @@ OpalStartSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalEndSession(\r
-  OPAL_SESSION     *Session\r
+OpalEndSession (\r
+  OPAL_SESSION  *Session\r
   );\r
 \r
 /**\r
@@ -230,11 +230,10 @@ OpalEndSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalPsidRevert(\r
-  OPAL_SESSION              *AdminSpSession\r
+OpalPsidRevert (\r
+  OPAL_SESSION  *AdminSpSession\r
   );\r
 \r
-\r
 /**\r
 \r
   The function retrieves the MSID from the device specified\r
@@ -247,11 +246,11 @@ OpalPsidRevert(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGetMsid(\r
-  OPAL_SESSION    *AdminSpSession,\r
-  UINT32          MsidBufferSize,\r
-  UINT8           *Msid,\r
-  UINT32          *MsidLength\r
+OpalGetMsid (\r
+  OPAL_SESSION  *AdminSpSession,\r
+  UINT32        MsidBufferSize,\r
+  UINT8         *Msid,\r
+  UINT32        *MsidLength\r
   );\r
 \r
 /**\r
@@ -266,12 +265,11 @@ OpalGetMsid(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalActivateLockingSp(\r
-  OPAL_SESSION           *AdminSpSession,\r
-  UINT8                  *MethodStatus\r
+OpalActivateLockingSp (\r
+  OPAL_SESSION  *AdminSpSession,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
-\r
 /**\r
 \r
   The function sets the PIN column of the specified cpinRowUid (authority) with the newPin value.\r
@@ -285,12 +283,12 @@ OpalActivateLockingSp(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalSetPassword(\r
-  OPAL_SESSION   *Session,\r
-  TCG_UID        CpinRowUid,\r
-  const VOID     *NewPin,\r
-  UINT32         NewPinLength,\r
-  UINT8          *MethodStatus\r
+OpalSetPassword (\r
+  OPAL_SESSION  *Session,\r
+  TCG_UID       CpinRowUid,\r
+  const VOID    *NewPin,\r
+  UINT32        NewPinLength,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
 /**\r
@@ -304,12 +302,11 @@ OpalSetPassword(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGlobalLockingRangeGenKey(\r
-  OPAL_SESSION   *LockingSpSession,\r
-  UINT8          *MethodStatus\r
+OpalGlobalLockingRangeGenKey (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
-\r
 /**\r
 \r
   The function updates the ReadLocked and WriteLocked columns of the Global Locking Range.\r
@@ -324,14 +321,13 @@ OpalGlobalLockingRangeGenKey(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUpdateGlobalLockingRange(\r
-  OPAL_SESSION             *LockingSpSession,\r
-  BOOLEAN                  ReadLocked,\r
-  BOOLEAN                  WriteLocked,\r
-  UINT8                    *MethodStatus\r
+OpalUpdateGlobalLockingRange (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  BOOLEAN       ReadLocked,\r
+  BOOLEAN       WriteLocked,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
-\r
 /**\r
 \r
   The function updates the RangeStart, RangeLength, ReadLockedEnabled, WriteLockedEnabled, ReadLocked and WriteLocked columns\r
@@ -350,16 +346,16 @@ OpalUpdateGlobalLockingRange(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalSetLockingRange(\r
-  OPAL_SESSION     *LockingSpSession,\r
-  TCG_UID          LockingRangeUid,\r
-  UINT64           RangeStart,\r
-  UINT64           RangeLength,\r
-  BOOLEAN          ReadLockEnabled,\r
-  BOOLEAN          WriteLockEnabled,\r
-  BOOLEAN          ReadLocked,\r
-  BOOLEAN          WriteLocked,\r
-  UINT8            *MethodStatus\r
+OpalSetLockingRange (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  TCG_UID       LockingRangeUid,\r
+  UINT64        RangeStart,\r
+  UINT64        RangeLength,\r
+  BOOLEAN       ReadLockEnabled,\r
+  BOOLEAN       WriteLockEnabled,\r
+  BOOLEAN       ReadLocked,\r
+  BOOLEAN       WriteLocked,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
 /**\r
@@ -377,16 +373,15 @@ OpalSetLockingRange(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalSetLockingSpAuthorityEnabledAndPin(\r
-  OPAL_SESSION    *LockingSpSession,\r
-  TCG_UID         CpinRowUid,\r
-  TCG_UID         AuthorityUid,\r
-  const VOID      *NewPin,\r
-  UINT32          NewPinLength,\r
-  UINT8           *MethodStatus\r
+OpalSetLockingSpAuthorityEnabledAndPin (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  TCG_UID       CpinRowUid,\r
+  TCG_UID       AuthorityUid,\r
+  const VOID    *NewPin,\r
+  UINT32        NewPinLength,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
-\r
 /**\r
 \r
   The function sets the Enabled column to FALSE for the USER1 authority.\r
@@ -397,12 +392,11 @@ OpalSetLockingSpAuthorityEnabledAndPin(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalDisableUser(\r
-  OPAL_SESSION     *LockingSpSession,\r
-  UINT8            *MethodStatus\r
+OpalDisableUser (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
-\r
 /**\r
 \r
   The function calls the Admin SP RevertSP method on the Locking SP.  If KeepUserData is True, then the optional parameter\r
@@ -415,13 +409,12 @@ OpalDisableUser(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalAdminRevert(\r
-  OPAL_SESSION    *LockingSpSession,\r
-  BOOLEAN         KeepUserData,\r
-  UINT8           *MethodStatus\r
+OpalAdminRevert (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  BOOLEAN       KeepUserData,\r
+  UINT8         *MethodStatus\r
   );\r
 \r
-\r
 /**\r
 \r
   The function retrieves the TryLimit column for the specified rowUid (authority).\r
@@ -433,13 +426,12 @@ OpalAdminRevert(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGetTryLimit(\r
-  OPAL_SESSION   *LockingSpSession,\r
-  TCG_UID        RowUid,\r
-  UINT32         *TryLimit\r
+OpalGetTryLimit (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  TCG_UID       RowUid,\r
+  UINT32        *TryLimit\r
   );\r
 \r
-\r
 /**\r
 \r
   The function populates the CreateStruct with a payload that will retrieve the global locking range active key.\r
@@ -453,13 +445,12 @@ OpalGetTryLimit(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalCreateRetrieveGlobalLockingRangeActiveKey(\r
-  const OPAL_SESSION    *Session,\r
-  TCG_CREATE_STRUCT     *CreateStruct,\r
-  UINT32                *Size\r
+OpalCreateRetrieveGlobalLockingRangeActiveKey (\r
+  const OPAL_SESSION  *Session,\r
+  TCG_CREATE_STRUCT   *CreateStruct,\r
+  UINT32              *Size\r
   );\r
 \r
-\r
 /**\r
 \r
   The function acquires the activeKey specified for the Global Locking Range from the parseStruct.\r
@@ -470,7 +461,7 @@ OpalCreateRetrieveGlobalLockingRangeActiveKey(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalParseRetrieveGlobalLockingRangeActiveKey(\r
+OpalParseRetrieveGlobalLockingRangeActiveKey (\r
   TCG_PARSE_STRUCT  *ParseStruct,\r
   TCG_UID           *ActiveKey\r
   );\r
@@ -485,9 +476,9 @@ OpalParseRetrieveGlobalLockingRangeActiveKey(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGetLockingInfo(\r
-  OPAL_SESSION                     *Session,\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature\r
+OpalGetLockingInfo (\r
+  OPAL_SESSION                    *Session,\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature\r
   );\r
 \r
 /**\r
@@ -500,8 +491,8 @@ OpalGetLockingInfo(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-OpalFeatureSupported(\r
-  OPAL_DISK_SUPPORT_ATTRIBUTE      *SupportedAttributes\r
+OpalFeatureSupported (\r
+  OPAL_DISK_SUPPORT_ATTRIBUTE  *SupportedAttributes\r
   );\r
 \r
 /**\r
@@ -517,9 +508,9 @@ OpalFeatureSupported(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-OpalFeatureEnabled(\r
-  OPAL_DISK_SUPPORT_ATTRIBUTE      *SupportedAttributes,\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature\r
+OpalFeatureEnabled (\r
+  OPAL_DISK_SUPPORT_ATTRIBUTE     *SupportedAttributes,\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature\r
   );\r
 \r
 /**\r
@@ -533,9 +524,9 @@ OpalFeatureEnabled(
 \r
 **/\r
 BOOLEAN\r
-OpalDeviceLocked(\r
-  OPAL_DISK_SUPPORT_ATTRIBUTE      *SupportedAttributes,\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature\r
+OpalDeviceLocked (\r
+  OPAL_DISK_SUPPORT_ATTRIBUTE     *SupportedAttributes,\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature\r
   );\r
 \r
 /**\r
@@ -547,9 +538,9 @@ OpalDeviceLocked(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalBlockSid(\r
-  OPAL_SESSION                           *Session,\r
-  BOOLEAN                                HardwareReset\r
+OpalBlockSid (\r
+  OPAL_SESSION  *Session,\r
+  BOOLEAN       HardwareReset\r
   );\r
 \r
 /**\r
@@ -563,7 +554,7 @@ OpalBlockSid(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGetSupportedAttributesInfo(\r
+OpalGetSupportedAttributesInfo (\r
   OPAL_SESSION                 *Session,\r
   OPAL_DISK_SUPPORT_ATTRIBUTE  *SupportedAttributes,\r
   UINT16                       *OpalBaseComId\r
@@ -579,10 +570,10 @@ OpalGetSupportedAttributesInfo(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilPsidRevert(\r
-  OPAL_SESSION   *AdminSpSession,\r
-  const VOID     *Psid,\r
-  UINT32         PsidLength\r
+OpalUtilPsidRevert (\r
+  OPAL_SESSION  *AdminSpSession,\r
+  const VOID    *Psid,\r
+  UINT32        PsidLength\r
   );\r
 \r
 /**\r
@@ -599,12 +590,12 @@ OpalUtilPsidRevert(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSetAdminPasswordAsSid(\r
-  OPAL_SESSION      *AdminSpSession,\r
-  const VOID        *GeneratedSid,\r
-  UINT32            SidLength,\r
-  const VOID        *Password,\r
-  UINT32            PassLength\r
+OpalUtilSetAdminPasswordAsSid (\r
+  OPAL_SESSION  *AdminSpSession,\r
+  const VOID    *GeneratedSid,\r
+  UINT32        SidLength,\r
+  const VOID    *Password,\r
+  UINT32        PassLength\r
   );\r
 \r
 /**\r
@@ -626,17 +617,17 @@ OpalUtilSetAdminPasswordAsSid(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSetOpalLockingRange(\r
-  OPAL_SESSION   *LockingSpSession,\r
-  const VOID     *Password,\r
-  UINT32         PassLength,\r
-  TCG_UID        LockingRangeUid,\r
-  UINT64         RangeStart,\r
-  UINT64         RangeLength,\r
-  BOOLEAN        ReadLockEnabled,\r
-  BOOLEAN        WriteLockEnabled,\r
-  BOOLEAN        ReadLocked,\r
-  BOOLEAN        WriteLocked\r
+OpalUtilSetOpalLockingRange (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  const VOID    *Password,\r
+  UINT32        PassLength,\r
+  TCG_UID       LockingRangeUid,\r
+  UINT64        RangeStart,\r
+  UINT64        RangeLength,\r
+  BOOLEAN       ReadLockEnabled,\r
+  BOOLEAN       WriteLockEnabled,\r
+  BOOLEAN       ReadLocked,\r
+  BOOLEAN       WriteLocked\r
   );\r
 \r
 /**\r
@@ -653,7 +644,7 @@ OpalUtilSetOpalLockingRange(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSetAdminPassword(\r
+OpalUtilSetAdminPassword (\r
   OPAL_SESSION  *AdminSpSession,\r
   const VOID    *OldPassword,\r
   UINT32        OldPasswordLength,\r
@@ -674,12 +665,12 @@ OpalUtilSetAdminPassword(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSetUserPassword(\r
-  OPAL_SESSION    *LockingSpSession,\r
-  const VOID      *OldPassword,\r
-  UINT32          OldPasswordLength,\r
-  const VOID      *NewPassword,\r
-  UINT32          NewPasswordLength\r
+OpalUtilSetUserPassword (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  const VOID    *OldPassword,\r
+  UINT32        OldPasswordLength,\r
+  const VOID    *NewPassword,\r
+  UINT32        NewPasswordLength\r
   );\r
 \r
 /**\r
@@ -694,10 +685,10 @@ OpalUtilSetUserPassword(
 TCG_RESULT\r
 EFIAPI\r
 OpalUtilVerifyPassword (\r
-  OPAL_SESSION   *LockingSpSession,\r
-  const VOID     *Password,\r
-  UINT32         PasswordLength,\r
-  TCG_UID        HostSigningAuthority\r
+  OPAL_SESSION  *LockingSpSession,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  TCG_UID       HostSigningAuthority\r
   );\r
 \r
 /**\r
@@ -712,11 +703,11 @@ OpalUtilVerifyPassword (
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSecureErase(\r
-  OPAL_SESSION     *LockingSpSession,\r
-  const VOID       *Password,\r
-  UINT32           PasswordLength,\r
-  BOOLEAN          *PasswordFailed\r
+OpalUtilSecureErase (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  BOOLEAN       *PasswordFailed\r
   );\r
 \r
 /**\r
@@ -730,11 +721,11 @@ OpalUtilSecureErase(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilDisableUser(\r
-  OPAL_SESSION   *LockingSpSession,\r
-  const VOID     *Password,\r
-  UINT32         PasswordLength,\r
-  BOOLEAN        *PasswordFailed\r
+OpalUtilDisableUser (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  BOOLEAN       *PasswordFailed\r
   );\r
 \r
 /**\r
@@ -751,14 +742,14 @@ OpalUtilDisableUser(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilRevert(\r
-  OPAL_SESSION     *LockingSpSession,\r
-  BOOLEAN          KeepUserData,\r
-  const VOID       *Password,\r
-  UINT32           PasswordLength,\r
-  BOOLEAN          *PasswordFailed,\r
-  UINT8            *Msid,\r
-  UINT32           MsidLength\r
+OpalUtilRevert (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  BOOLEAN       KeepUserData,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  BOOLEAN       *PasswordFailed,\r
+  UINT8         *Msid,\r
+  UINT32        MsidLength\r
   );\r
 \r
 /**\r
@@ -774,11 +765,11 @@ OpalUtilRevert(
 TCG_RESULT\r
 EFIAPI\r
 OpalUtilSetSIDtoMSID (\r
-  OPAL_SESSION     *AdminSpSession,\r
-  const VOID       *Password,\r
-  UINT32           PasswordLength,\r
-  UINT8            *Msid,\r
-  UINT32           MsidLength\r
+  OPAL_SESSION  *AdminSpSession,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  UINT8         *Msid,\r
+  UINT32        MsidLength\r
   );\r
 \r
 /**\r
@@ -793,12 +784,12 @@ OpalUtilSetSIDtoMSID (
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilUpdateGlobalLockingRange(\r
-  OPAL_SESSION    *LockingSpSession,\r
-  const VOID      *Password,\r
-  UINT32          PasswordLength,\r
-  BOOLEAN         ReadLocked,\r
-  BOOLEAN         WriteLocked\r
+OpalUtilUpdateGlobalLockingRange (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  BOOLEAN       ReadLocked,\r
+  BOOLEAN       WriteLocked\r
   );\r
 \r
 /**\r
@@ -812,11 +803,11 @@ OpalUtilUpdateGlobalLockingRange(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilGetMsid(\r
-  OPAL_SESSION    *Session,\r
-  UINT8           *Msid,\r
-  UINT32          MsidBufferLength,\r
-  UINT32          *MsidLength\r
+OpalUtilGetMsid (\r
+  OPAL_SESSION  *Session,\r
+  UINT8         *Msid,\r
+  UINT32        MsidBufferLength,\r
+  UINT32        *MsidLength\r
   );\r
 \r
 /**\r
@@ -833,10 +824,10 @@ OpalUtilGetMsid(
 **/\r
 OPAL_OWNER_SHIP\r
 EFIAPI\r
-OpalUtilDetermineOwnership(\r
-  OPAL_SESSION       *Session,\r
-  UINT8              *Msid,\r
-  UINT32             MsidLength\r
+OpalUtilDetermineOwnership (\r
+  OPAL_SESSION  *Session,\r
+  UINT8         *Msid,\r
+  UINT32        MsidLength\r
   );\r
 \r
 /**\r
@@ -852,9 +843,9 @@ OpalUtilDetermineOwnership(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-OpalUtilAdminPasswordExists(\r
-  IN  UINT16                           OwnerShip,\r
-  IN  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature\r
+OpalUtilAdminPasswordExists (\r
+  IN  UINT16                          OwnerShip,\r
+  IN  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature\r
   );\r
 \r
 /**\r
@@ -869,10 +860,10 @@ OpalUtilAdminPasswordExists(
 TCG_RESULT\r
 EFIAPI\r
 OpalUtilGetActiveDataRemovalMechanism (\r
-  OPAL_SESSION      *Session,\r
-  const VOID        *GeneratedSid,\r
-  UINT32            SidLength,\r
-  UINT8             *ActiveDataRemovalMechanism\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *GeneratedSid,\r
+  UINT32        SidLength,\r
+  UINT8         *ActiveDataRemovalMechanism\r
   );\r
 \r
 /**\r
@@ -885,8 +876,8 @@ OpalUtilGetActiveDataRemovalMechanism (
 TCG_RESULT\r
 EFIAPI\r
 OpalUtilGetDataRemovalMechanismLists (\r
-  IN  OPAL_SESSION      *Session,\r
-  OUT UINT32            *RemovalMechanismLists\r
+  IN  OPAL_SESSION  *Session,\r
+  OUT UINT32        *RemovalMechanismLists\r
   );\r
 \r
 #endif // _OPAL_CORE_H_\r
index e8f93c51f8028ed80598bbc5c259fc8f5fd1266f..13fefbb3a934d42ee3187e5dddd9a15bb14012d9 100644 (file)
@@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 Tpm12Startup (\r
-  IN TPM_STARTUP_TYPE          TpmSt\r
+  IN TPM_STARTUP_TYPE  TpmSt\r
   );\r
 \r
 /**\r
@@ -52,26 +52,26 @@ Tpm12ForceClear (
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  UINT16                            sizeOfSelect;\r
-  UINT8                             pcrSelect[3];\r
+  UINT16    sizeOfSelect;\r
+  UINT8     pcrSelect[3];\r
 } TPM12_PCR_SELECTION;\r
 \r
 typedef struct {\r
-  TPM12_PCR_SELECTION               pcrSelection;\r
-  TPM_LOCALITY_SELECTION            localityAtRelease;\r
-  TPM_COMPOSITE_HASH                digestAtRelease;\r
+  TPM12_PCR_SELECTION       pcrSelection;\r
+  TPM_LOCALITY_SELECTION    localityAtRelease;\r
+  TPM_COMPOSITE_HASH        digestAtRelease;\r
 } TPM12_PCR_INFO_SHORT;\r
 \r
 typedef struct {\r
-  TPM_STRUCTURE_TAG               tag;\r
-  TPM_NV_INDEX                    nvIndex;\r
-  TPM12_PCR_INFO_SHORT            pcrInfoRead;\r
-  TPM12_PCR_INFO_SHORT            pcrInfoWrite;\r
-  TPM_NV_ATTRIBUTES               permission;\r
-  BOOLEAN                         bReadSTClear;\r
-  BOOLEAN                         bWriteSTClear;\r
-  BOOLEAN                         bWriteDefine;\r
-  UINT32                          dataSize;\r
+  TPM_STRUCTURE_TAG       tag;\r
+  TPM_NV_INDEX            nvIndex;\r
+  TPM12_PCR_INFO_SHORT    pcrInfoRead;\r
+  TPM12_PCR_INFO_SHORT    pcrInfoWrite;\r
+  TPM_NV_ATTRIBUTES       permission;\r
+  BOOLEAN                 bReadSTClear;\r
+  BOOLEAN                 bWriteSTClear;\r
+  BOOLEAN                 bWriteDefine;\r
+  UINT32                  dataSize;\r
 } TPM12_NV_DATA_PUBLIC;\r
 \r
 #pragma pack()\r
@@ -106,10 +106,10 @@ Tpm12NvDefineSpace (
 EFI_STATUS\r
 EFIAPI\r
 Tpm12NvReadValue (\r
-  IN TPM_NV_INDEX   NvIndex,\r
-  IN UINT32         Offset,\r
-  IN OUT UINT32     *DataSize,\r
-  OUT UINT8         *Data\r
+  IN TPM_NV_INDEX  NvIndex,\r
+  IN UINT32        Offset,\r
+  IN OUT UINT32    *DataSize,\r
+  OUT UINT8        *Data\r
   );\r
 \r
 /**\r
@@ -126,10 +126,10 @@ Tpm12NvReadValue (
 EFI_STATUS\r
 EFIAPI\r
 Tpm12NvWriteValue (\r
-  IN TPM_NV_INDEX   NvIndex,\r
-  IN UINT32         Offset,\r
-  IN UINT32         DataSize,\r
-  IN UINT8          *Data\r
+  IN TPM_NV_INDEX  NvIndex,\r
+  IN UINT32        Offset,\r
+  IN UINT32        DataSize,\r
+  IN UINT8         *Data\r
   );\r
 \r
 /**\r
@@ -167,7 +167,7 @@ Send TSC_PhysicalPresence command to TPM.
 EFI_STATUS\r
 EFIAPI\r
 Tpm12PhysicalPresence (\r
-  IN      TPM_PHYSICAL_PRESENCE     PhysicalPresence\r
+  IN      TPM_PHYSICAL_PRESENCE  PhysicalPresence\r
   );\r
 \r
 /**\r
@@ -214,6 +214,7 @@ Get TPM capability volatile flags.
 EFI_STATUS\r
 EFIAPI\r
 Tpm12GetCapabilityFlagVolatile (\r
-  OUT TPM_STCLEAR_FLAGS                 *VolatileFlags\r
+  OUT TPM_STCLEAR_FLAGS  *VolatileFlags\r
   );\r
+\r
 #endif\r
index eac7885ca3d849b6e1b0628f96eac31dc019e3a0..f7c08dd1bbf31ae92325f3618c4831aaa82cac5b 100644 (file)
@@ -26,10 +26,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 Tpm12SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   );\r
 \r
 /**\r
index ad3b982d484392cc7a59bc591e8318cfdb6ec3bb..2e83a2f4743cc7436360e774c4095f5694142486 100644 (file)
@@ -26,8 +26,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 Tpm2HashSequenceStart (\r
-  IN TPMI_ALG_HASH   HashAlg,\r
-  OUT TPMI_DH_OBJECT *SequenceHandle\r
+  IN TPMI_ALG_HASH    HashAlg,\r
+  OUT TPMI_DH_OBJECT  *SequenceHandle\r
   );\r
 \r
 /**\r
@@ -44,8 +44,8 @@ Tpm2HashSequenceStart (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SequenceUpdate (\r
-  IN TPMI_DH_OBJECT   SequenceHandle,\r
-  IN TPM2B_MAX_BUFFER *Buffer\r
+  IN TPMI_DH_OBJECT    SequenceHandle,\r
+  IN TPM2B_MAX_BUFFER  *Buffer\r
   );\r
 \r
 /**\r
@@ -65,10 +65,10 @@ Tpm2SequenceUpdate (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2EventSequenceComplete (\r
-  IN TPMI_DH_PCR         PcrHandle,\r
-  IN TPMI_DH_OBJECT      SequenceHandle,\r
-  IN TPM2B_MAX_BUFFER    *Buffer,\r
-  OUT TPML_DIGEST_VALUES *Results\r
+  IN TPMI_DH_PCR          PcrHandle,\r
+  IN TPMI_DH_OBJECT       SequenceHandle,\r
+  IN TPM2B_MAX_BUFFER     *Buffer,\r
+  OUT TPML_DIGEST_VALUES  *Results\r
   );\r
 \r
 /**\r
@@ -84,9 +84,9 @@ Tpm2EventSequenceComplete (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SequenceComplete (\r
-  IN TPMI_DH_OBJECT      SequenceHandle,\r
-  IN TPM2B_MAX_BUFFER    *Buffer,\r
-  OUT TPM2B_DIGEST       *Result\r
+  IN TPMI_DH_OBJECT    SequenceHandle,\r
+  IN TPM2B_MAX_BUFFER  *Buffer,\r
+  OUT TPM2B_DIGEST     *Result\r
   );\r
 \r
 /**\r
@@ -100,7 +100,7 @@ Tpm2SequenceComplete (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2Startup (\r
-  IN      TPM_SU             StartupType\r
+  IN      TPM_SU  StartupType\r
   );\r
 \r
 /**\r
@@ -114,7 +114,7 @@ Tpm2Startup (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2Shutdown (\r
-  IN      TPM_SU             ShutdownType\r
+  IN      TPM_SU  ShutdownType\r
   );\r
 \r
 /**\r
@@ -131,7 +131,7 @@ Tpm2Shutdown (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SelfTest (\r
-  IN TPMI_YES_NO          FullTest\r
+  IN TPMI_YES_NO  FullTest\r
   );\r
 \r
 /**\r
@@ -149,10 +149,10 @@ Tpm2SelfTest (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SetPrimaryPolicy (\r
-  IN  TPMI_RH_HIERARCHY_AUTH    AuthHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN  TPM2B_DIGEST              *AuthPolicy,\r
-  IN  TPMI_ALG_HASH             HashAlg\r
+  IN  TPMI_RH_HIERARCHY_AUTH  AuthHandle,\r
+  IN  TPMS_AUTH_COMMAND       *AuthSession,\r
+  IN  TPM2B_DIGEST            *AuthPolicy,\r
+  IN  TPMI_ALG_HASH           HashAlg\r
   );\r
 \r
 /**\r
@@ -167,8 +167,8 @@ Tpm2SetPrimaryPolicy (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2Clear (\r
-  IN TPMI_RH_CLEAR             AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN TPMI_RH_CLEAR      AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   );\r
 \r
 /**\r
@@ -185,9 +185,9 @@ Tpm2Clear (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2ClearControl (\r
-  IN TPMI_RH_CLEAR             AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN TPMI_YES_NO               Disable\r
+  IN TPMI_RH_CLEAR      AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN TPMI_YES_NO        Disable\r
   );\r
 \r
 /**\r
@@ -204,9 +204,9 @@ Tpm2ClearControl (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2HierarchyChangeAuth (\r
-  IN TPMI_RH_HIERARCHY_AUTH    AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN TPM2B_AUTH                *NewAuth\r
+  IN TPMI_RH_HIERARCHY_AUTH  AuthHandle,\r
+  IN TPMS_AUTH_COMMAND       *AuthSession,\r
+  IN TPM2B_AUTH              *NewAuth\r
   );\r
 \r
 /**\r
@@ -222,8 +222,8 @@ Tpm2HierarchyChangeAuth (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2ChangeEPS (\r
-  IN TPMI_RH_PLATFORM          AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession\r
+  IN TPMI_RH_PLATFORM   AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession\r
   );\r
 \r
 /**\r
@@ -239,8 +239,8 @@ Tpm2ChangeEPS (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2ChangePPS (\r
-  IN TPMI_RH_PLATFORM          AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession\r
+  IN TPMI_RH_PLATFORM   AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession\r
   );\r
 \r
 /**\r
@@ -258,10 +258,10 @@ Tpm2ChangePPS (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2HierarchyControl (\r
-  IN TPMI_RH_HIERARCHY         AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN TPMI_RH_HIERARCHY         Hierarchy,\r
-  IN TPMI_YES_NO               State\r
+  IN TPMI_RH_HIERARCHY  AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession,\r
+  IN TPMI_RH_HIERARCHY  Hierarchy,\r
+  IN TPMI_YES_NO        State\r
   );\r
 \r
 /**\r
@@ -277,8 +277,8 @@ Tpm2HierarchyControl (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2DictionaryAttackLockReset (\r
-  IN  TPMI_RH_LOCKOUT           LockHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession\r
+  IN  TPMI_RH_LOCKOUT    LockHandle,\r
+  IN  TPMS_AUTH_COMMAND  *AuthSession\r
   );\r
 \r
 /**\r
@@ -297,11 +297,11 @@ Tpm2DictionaryAttackLockReset (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2DictionaryAttackParameters (\r
-  IN  TPMI_RH_LOCKOUT           LockHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN  UINT32                    NewMaxTries,\r
-  IN  UINT32                    NewRecoveryTime,\r
-  IN  UINT32                    LockoutRecovery\r
+  IN  TPMI_RH_LOCKOUT    LockHandle,\r
+  IN  TPMS_AUTH_COMMAND  *AuthSession,\r
+  IN  UINT32             NewMaxTries,\r
+  IN  UINT32             NewRecoveryTime,\r
+  IN  UINT32             LockoutRecovery\r
   );\r
 \r
 /**\r
@@ -317,9 +317,9 @@ Tpm2DictionaryAttackParameters (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvReadPublic (\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  OUT     TPM2B_NV_PUBLIC           *NvPublic,\r
-  OUT     TPM2B_NAME                *NvName\r
+  IN      TPMI_RH_NV_INDEX  NvIndex,\r
+  OUT     TPM2B_NV_PUBLIC   *NvPublic,\r
+  OUT     TPM2B_NAME        *NvName\r
   );\r
 \r
 /**\r
@@ -339,10 +339,10 @@ Tpm2NvReadPublic (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvDefineSpace (\r
-  IN      TPMI_RH_PROVISION         AuthHandle,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN      TPM2B_AUTH                *Auth,\r
-  IN      TPM2B_NV_PUBLIC           *NvPublic\r
+  IN      TPMI_RH_PROVISION  AuthHandle,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN      TPM2B_AUTH         *Auth,\r
+  IN      TPM2B_NV_PUBLIC    *NvPublic\r
   );\r
 \r
 /**\r
@@ -359,9 +359,9 @@ Tpm2NvDefineSpace (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvUndefineSpace (\r
-  IN      TPMI_RH_PROVISION         AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN      TPMI_RH_PROVISION  AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   );\r
 \r
 /**\r
@@ -381,12 +381,12 @@ Tpm2NvUndefineSpace (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvRead (\r
-  IN      TPMI_RH_NV_AUTH           AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN      UINT16                    Size,\r
-  IN      UINT16                    Offset,\r
-  IN OUT  TPM2B_MAX_BUFFER          *OutData\r
+  IN      TPMI_RH_NV_AUTH    AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN      UINT16             Size,\r
+  IN      UINT16             Offset,\r
+  IN OUT  TPM2B_MAX_BUFFER   *OutData\r
   );\r
 \r
 /**\r
@@ -405,11 +405,11 @@ Tpm2NvRead (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvWrite (\r
-  IN      TPMI_RH_NV_AUTH           AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN      TPM2B_MAX_BUFFER          *InData,\r
-  IN      UINT16                    Offset\r
+  IN      TPMI_RH_NV_AUTH    AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN      TPM2B_MAX_BUFFER   *InData,\r
+  IN      UINT16             Offset\r
   );\r
 \r
 /**\r
@@ -426,9 +426,9 @@ Tpm2NvWrite (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvReadLock (\r
-  IN      TPMI_RH_NV_AUTH           AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN      TPMI_RH_NV_AUTH    AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   );\r
 \r
 /**\r
@@ -445,9 +445,9 @@ Tpm2NvReadLock (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvWriteLock (\r
-  IN      TPMI_RH_NV_AUTH           AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN      TPMI_RH_NV_AUTH    AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   );\r
 \r
 /**\r
@@ -463,8 +463,8 @@ Tpm2NvWriteLock (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvGlobalWriteLock (\r
-  IN      TPMI_RH_PROVISION         AuthHandle,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN      TPMI_RH_PROVISION  AuthHandle,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   );\r
 \r
 /**\r
@@ -481,8 +481,8 @@ Tpm2NvGlobalWriteLock (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrExtend (\r
-  IN      TPMI_DH_PCR               PcrHandle,\r
-  IN      TPML_DIGEST_VALUES        *Digests\r
+  IN      TPMI_DH_PCR         PcrHandle,\r
+  IN      TPML_DIGEST_VALUES  *Digests\r
   );\r
 \r
 /**\r
@@ -503,9 +503,9 @@ Tpm2PcrExtend (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrEvent (\r
-  IN      TPMI_DH_PCR               PcrHandle,\r
-  IN      TPM2B_EVENT               *EventData,\r
-     OUT  TPML_DIGEST_VALUES        *Digests\r
+  IN      TPMI_DH_PCR      PcrHandle,\r
+  IN      TPM2B_EVENT      *EventData,\r
+  OUT  TPML_DIGEST_VALUES  *Digests\r
   );\r
 \r
 /**\r
@@ -522,10 +522,10 @@ Tpm2PcrEvent (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrRead (\r
-  IN      TPML_PCR_SELECTION        *PcrSelectionIn,\r
-     OUT  UINT32                    *PcrUpdateCounter,\r
-     OUT  TPML_PCR_SELECTION        *PcrSelectionOut,\r
-     OUT  TPML_DIGEST               *PcrValues\r
+  IN      TPML_PCR_SELECTION  *PcrSelectionIn,\r
+  OUT  UINT32                 *PcrUpdateCounter,\r
+  OUT  TPML_PCR_SELECTION     *PcrSelectionOut,\r
+  OUT  TPML_DIGEST            *PcrValues\r
   );\r
 \r
 /**\r
@@ -545,13 +545,13 @@ Tpm2PcrRead (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrAllocate (\r
-  IN  TPMI_RH_PLATFORM          AuthHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN  TPML_PCR_SELECTION        *PcrAllocation,\r
-  OUT TPMI_YES_NO               *AllocationSuccess,\r
-  OUT UINT32                    *MaxPCR,\r
-  OUT UINT32                    *SizeNeeded,\r
-  OUT UINT32                    *SizeAvailable\r
+  IN  TPMI_RH_PLATFORM    AuthHandle,\r
+  IN  TPMS_AUTH_COMMAND   *AuthSession,\r
+  IN  TPML_PCR_SELECTION  *PcrAllocation,\r
+  OUT TPMI_YES_NO         *AllocationSuccess,\r
+  OUT UINT32              *MaxPCR,\r
+  OUT UINT32              *SizeNeeded,\r
+  OUT UINT32              *SizeAvailable\r
   );\r
 \r
 /**\r
@@ -566,9 +566,9 @@ Tpm2PcrAllocate (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrAllocateBanks (\r
-  IN TPM2B_AUTH                *PlatformAuth   OPTIONAL,\r
-  IN UINT32                    SupportedPCRBanks,\r
-  IN UINT32                    PCRBanks\r
+  IN TPM2B_AUTH  *PlatformAuth   OPTIONAL,\r
+  IN UINT32      SupportedPCRBanks,\r
+  IN UINT32      PCRBanks\r
   );\r
 \r
 /**\r
@@ -599,11 +599,11 @@ Tpm2PcrAllocateBanks (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapability (\r
-  IN      TPM_CAP                   Capability,\r
-  IN      UINT32                    Property,\r
-  IN      UINT32                    PropertyCount,\r
-  OUT     TPMI_YES_NO               *MoreData,\r
-  OUT     TPMS_CAPABILITY_DATA      *CapabilityData\r
+  IN      TPM_CAP               Capability,\r
+  IN      UINT32                Property,\r
+  IN      UINT32                PropertyCount,\r
+  OUT     TPMI_YES_NO           *MoreData,\r
+  OUT     TPMS_CAPABILITY_DATA  *CapabilityData\r
   );\r
 \r
 /**\r
@@ -619,7 +619,7 @@ Tpm2GetCapability (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityFamily (\r
-  OUT     CHAR8                     *Family\r
+  OUT     CHAR8  *Family\r
   );\r
 \r
 /**\r
@@ -635,7 +635,7 @@ Tpm2GetCapabilityFamily (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityManufactureID (\r
-  OUT     UINT32                    *ManufactureId\r
+  OUT     UINT32  *ManufactureId\r
   );\r
 \r
 /**\r
@@ -652,8 +652,8 @@ Tpm2GetCapabilityManufactureID (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityFirmwareVersion (\r
-  OUT     UINT32                    *FirmwareVersion1,\r
-  OUT     UINT32                    *FirmwareVersion2\r
+  OUT     UINT32  *FirmwareVersion1,\r
+  OUT     UINT32  *FirmwareVersion2\r
   );\r
 \r
 /**\r
@@ -670,8 +670,8 @@ Tpm2GetCapabilityFirmwareVersion (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityMaxCommandResponseSize (\r
-  OUT UINT32                    *MaxCommandSize,\r
-  OUT UINT32                    *MaxResponseSize\r
+  OUT UINT32  *MaxCommandSize,\r
+  OUT UINT32  *MaxResponseSize\r
   );\r
 \r
 /**\r
@@ -688,7 +688,7 @@ Tpm2GetCapabilityMaxCommandResponseSize (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilitySupportedAlg (\r
-  OUT TPML_ALG_PROPERTY      *AlgList\r
+  OUT TPML_ALG_PROPERTY  *AlgList\r
   );\r
 \r
 /**\r
@@ -704,7 +704,7 @@ Tpm2GetCapabilitySupportedAlg (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityLockoutCounter (\r
-  OUT     UINT32                    *LockoutCounter\r
+  OUT     UINT32  *LockoutCounter\r
   );\r
 \r
 /**\r
@@ -720,7 +720,7 @@ Tpm2GetCapabilityLockoutCounter (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityLockoutInterval (\r
-  OUT     UINT32                    *LockoutInterval\r
+  OUT     UINT32  *LockoutInterval\r
   );\r
 \r
 /**\r
@@ -737,7 +737,7 @@ Tpm2GetCapabilityLockoutInterval (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityInputBufferSize (\r
-  OUT     UINT32                    *InputBufferSize\r
+  OUT     UINT32  *InputBufferSize\r
   );\r
 \r
 /**\r
@@ -753,7 +753,7 @@ Tpm2GetCapabilityInputBufferSize (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityPcrs (\r
-  OUT TPML_PCR_SELECTION      *Pcrs\r
+  OUT TPML_PCR_SELECTION  *Pcrs\r
   );\r
 \r
 /**\r
@@ -769,9 +769,9 @@ Tpm2GetCapabilityPcrs (
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-Tpm2GetCapabilitySupportedAndActivePcrs(\r
-  OUT UINT32                            *TpmHashAlgorithmBitmap,\r
-  OUT UINT32                            *ActivePcrBanks\r
+Tpm2GetCapabilitySupportedAndActivePcrs (\r
+  OUT UINT32  *TpmHashAlgorithmBitmap,\r
+  OUT UINT32  *ActivePcrBanks\r
   );\r
 \r
 /**\r
@@ -787,7 +787,7 @@ Tpm2GetCapabilitySupportedAndActivePcrs(
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityAlgorithmSet (\r
-  OUT     UINT32      *AlgorithmSet\r
+  OUT     UINT32  *AlgorithmSet\r
   );\r
 \r
 /**\r
@@ -802,8 +802,8 @@ Tpm2GetCapabilityAlgorithmSet (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityIsCommandImplemented (\r
-  IN      TPM_CC      Command,\r
-  OUT     BOOLEAN     *IsCmdImpl\r
+  IN      TPM_CC   Command,\r
+  OUT     BOOLEAN  *IsCmdImpl\r
   );\r
 \r
 /**\r
@@ -817,7 +817,7 @@ Tpm2GetCapabilityIsCommandImplemented (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2TestParms (\r
-  IN  TPMT_PUBLIC_PARMS           *Parameters\r
+  IN  TPMT_PUBLIC_PARMS  *Parameters\r
   );\r
 \r
 /**\r
@@ -835,9 +835,9 @@ Tpm2TestParms (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SetAlgorithmSet (\r
-  IN  TPMI_RH_PLATFORM          AuthHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN  UINT32                    AlgorithmSet\r
+  IN  TPMI_RH_PLATFORM   AuthHandle,\r
+  IN  TPMS_AUTH_COMMAND  *AuthSession,\r
+  IN  UINT32             AlgorithmSet\r
   );\r
 \r
 /**\r
@@ -860,15 +860,15 @@ Tpm2SetAlgorithmSet (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2StartAuthSession (\r
-  IN      TPMI_DH_OBJECT            TpmKey,\r
-  IN      TPMI_DH_ENTITY            Bind,\r
-  IN      TPM2B_NONCE               *NonceCaller,\r
-  IN      TPM2B_ENCRYPTED_SECRET    *Salt,\r
-  IN      TPM_SE                    SessionType,\r
-  IN      TPMT_SYM_DEF              *Symmetric,\r
-  IN      TPMI_ALG_HASH             AuthHash,\r
-     OUT  TPMI_SH_AUTH_SESSION      *SessionHandle,\r
-     OUT  TPM2B_NONCE               *NonceTPM\r
+  IN      TPMI_DH_OBJECT          TpmKey,\r
+  IN      TPMI_DH_ENTITY          Bind,\r
+  IN      TPM2B_NONCE             *NonceCaller,\r
+  IN      TPM2B_ENCRYPTED_SECRET  *Salt,\r
+  IN      TPM_SE                  SessionType,\r
+  IN      TPMT_SYM_DEF            *Symmetric,\r
+  IN      TPMI_ALG_HASH           AuthHash,\r
+  OUT  TPMI_SH_AUTH_SESSION       *SessionHandle,\r
+  OUT  TPM2B_NONCE                *NonceTPM\r
   );\r
 \r
 /**\r
@@ -882,7 +882,7 @@ Tpm2StartAuthSession (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2FlushContext (\r
-  IN      TPMI_DH_CONTEXT           FlushHandle\r
+  IN      TPMI_DH_CONTEXT  FlushHandle\r
   );\r
 \r
 /**\r
@@ -906,15 +906,15 @@ Tpm2FlushContext (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PolicySecret (\r
-  IN      TPMI_DH_ENTITY            AuthHandle,\r
-  IN      TPMI_SH_POLICY            PolicySession,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN      TPM2B_NONCE               *NonceTPM,\r
-  IN      TPM2B_DIGEST              *CpHashA,\r
-  IN      TPM2B_NONCE               *PolicyRef,\r
-  IN      INT32                     Expiration,\r
-  OUT     TPM2B_TIMEOUT             *Timeout,\r
-  OUT     TPMT_TK_AUTH              *PolicyTicket\r
+  IN      TPMI_DH_ENTITY     AuthHandle,\r
+  IN      TPMI_SH_POLICY     PolicySession,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN      TPM2B_NONCE        *NonceTPM,\r
+  IN      TPM2B_DIGEST       *CpHashA,\r
+  IN      TPM2B_NONCE        *PolicyRef,\r
+  IN      INT32              Expiration,\r
+  OUT     TPM2B_TIMEOUT      *Timeout,\r
+  OUT     TPMT_TK_AUTH       *PolicyTicket\r
   );\r
 \r
 /**\r
@@ -932,8 +932,8 @@ Tpm2PolicySecret (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PolicyOR (\r
-  IN TPMI_SH_POLICY           PolicySession,\r
-  IN TPML_DIGEST              *HashList\r
+  IN TPMI_SH_POLICY  PolicySession,\r
+  IN TPML_DIGEST     *HashList\r
   );\r
 \r
 /**\r
@@ -948,8 +948,8 @@ Tpm2PolicyOR (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PolicyCommandCode (\r
-  IN      TPMI_SH_POLICY            PolicySession,\r
-  IN      TPM_CC                    Code\r
+  IN      TPMI_SH_POLICY  PolicySession,\r
+  IN      TPM_CC          Code\r
   );\r
 \r
 /**\r
@@ -965,8 +965,8 @@ Tpm2PolicyCommandCode (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PolicyGetDigest (\r
-  IN      TPMI_SH_POLICY            PolicySession,\r
-     OUT  TPM2B_DIGEST              *PolicyHash\r
+  IN      TPMI_SH_POLICY  PolicySession,\r
+  OUT  TPM2B_DIGEST       *PolicyHash\r
   );\r
 \r
 /**\r
@@ -983,10 +983,10 @@ Tpm2PolicyGetDigest (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2ReadPublic (\r
-  IN  TPMI_DH_OBJECT            ObjectHandle,\r
-  OUT TPM2B_PUBLIC              *OutPublic,\r
-  OUT TPM2B_NAME                *Name,\r
-  OUT TPM2B_NAME                *QualifiedName\r
+  IN  TPMI_DH_OBJECT  ObjectHandle,\r
+  OUT TPM2B_PUBLIC    *OutPublic,\r
+  OUT TPM2B_NAME      *Name,\r
+  OUT TPM2B_NAME      *QualifiedName\r
   );\r
 \r
 //\r
@@ -1004,8 +1004,8 @@ Tpm2ReadPublic (
 UINT32\r
 EFIAPI\r
 CopyAuthSessionCommand (\r
-  IN      TPMS_AUTH_COMMAND         *AuthSessionIn  OPTIONAL,\r
-  OUT     UINT8                     *AuthSessionOut\r
+  IN      TPMS_AUTH_COMMAND  *AuthSessionIn  OPTIONAL,\r
+  OUT     UINT8              *AuthSessionOut\r
   );\r
 \r
 /**\r
@@ -1019,8 +1019,8 @@ CopyAuthSessionCommand (
 UINT32\r
 EFIAPI\r
 CopyAuthSessionResponse (\r
-  IN      UINT8                      *AuthSessionIn,\r
-  OUT     TPMS_AUTH_RESPONSE         *AuthSessionOut OPTIONAL\r
+  IN      UINT8               *AuthSessionIn,\r
+  OUT     TPMS_AUTH_RESPONSE  *AuthSessionOut OPTIONAL\r
   );\r
 \r
 /**\r
@@ -1033,7 +1033,7 @@ CopyAuthSessionResponse (
 UINT16\r
 EFIAPI\r
 GetHashSizeFromAlgo (\r
-  IN TPMI_ALG_HASH    HashAlgo\r
+  IN TPMI_ALG_HASH  HashAlgo\r
   );\r
 \r
 /**\r
@@ -1046,7 +1046,7 @@ GetHashSizeFromAlgo (
 UINT32\r
 EFIAPI\r
 GetHashMaskFromAlgo (\r
-  IN TPMI_ALG_HASH     HashAlgo\r
+  IN TPMI_ALG_HASH  HashAlgo\r
   );\r
 \r
 /**\r
@@ -1060,7 +1060,7 @@ GetHashMaskFromAlgo (
 **/\r
 BOOLEAN\r
 EFIAPI\r
-IsHashAlgSupportedInHashAlgorithmMask(\r
+IsHashAlgSupportedInHashAlgorithmMask (\r
   IN TPMI_ALG_HASH  HashAlg,\r
   IN UINT32         HashAlgorithmMask\r
   );\r
@@ -1076,10 +1076,10 @@ IsHashAlgSupportedInHashAlgorithmMask(
 **/\r
 VOID *\r
 EFIAPI\r
-CopyDigestListToBuffer(\r
-  IN OUT VOID                       *Buffer,\r
-  IN TPML_DIGEST_VALUES             *DigestList,\r
-  IN UINT32                         HashAlgorithmMask\r
+CopyDigestListToBuffer (\r
+  IN OUT VOID            *Buffer,\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  IN UINT32              HashAlgorithmMask\r
   );\r
 \r
 /**\r
@@ -1091,8 +1091,8 @@ CopyDigestListToBuffer(
 **/\r
 UINT32\r
 EFIAPI\r
-GetDigestListSize(\r
-  IN TPML_DIGEST_VALUES             *DigestList\r
+GetDigestListSize (\r
+  IN TPML_DIGEST_VALUES  *DigestList\r
   );\r
 \r
 /**\r
@@ -1107,10 +1107,10 @@ GetDigestListSize(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-GetDigestFromDigestList(\r
-  IN TPMI_ALG_HASH      HashAlg,\r
-  IN TPML_DIGEST_VALUES *DigestList,\r
-  OUT VOID              *Digest\r
+GetDigestFromDigestList (\r
+  IN TPMI_ALG_HASH       HashAlg,\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  OUT VOID               *Digest\r
   );\r
 \r
 #endif\r
index 24fdb5b514a121c78b0e5d969ec8778b00d2245b..783bfa5333947bcd843f458c1bd07cd61cb782af 100644 (file)
@@ -36,10 +36,10 @@ typedef enum {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   );\r
 \r
 /**\r
@@ -69,7 +69,7 @@ Tpm2RequestUseTpm (
 **/\r
 typedef\r
 EFI_STATUS\r
-(EFIAPI *TPM2_SUBMIT_COMMAND) (\r
+(EFIAPI *TPM2_SUBMIT_COMMAND)(\r
   IN UINT32            InputParameterBlockSize,\r
   IN UINT8             *InputParameterBlock,\r
   IN OUT UINT32        *OutputParameterBlockSize,\r
@@ -85,14 +85,14 @@ EFI_STATUS
 **/\r
 typedef\r
 EFI_STATUS\r
-(EFIAPI *TPM2_REQUEST_USE_TPM) (\r
+(EFIAPI *TPM2_REQUEST_USE_TPM)(\r
   VOID\r
   );\r
 \r
 typedef struct {\r
-  EFI_GUID                           ProviderGuid;\r
-  TPM2_SUBMIT_COMMAND                Tpm2SubmitCommand;\r
-  TPM2_REQUEST_USE_TPM               Tpm2RequestUseTpm;\r
+  EFI_GUID                ProviderGuid;\r
+  TPM2_SUBMIT_COMMAND     Tpm2SubmitCommand;\r
+  TPM2_REQUEST_USE_TPM    Tpm2RequestUseTpm;\r
 } TPM2_DEVICE_INTERFACE;\r
 \r
 /**\r
@@ -107,7 +107,7 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2RegisterTpm2DeviceLib (\r
-  IN TPM2_DEVICE_INTERFACE   *Tpm2Device\r
+  IN TPM2_DEVICE_INTERFACE  *Tpm2Device\r
   );\r
 \r
 #endif\r
index 1d18f8d837dbcb69c21d80529f8ddeb5b3877313..4810ce4b2e1317500b27ab9f9f99da960501f3f7 100644 (file)
@@ -12,12 +12,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include <IndustryStandard/Tpm12.h>\r
 \r
-typedef EFI_HANDLE  TIS_TPM_HANDLE;\r
+typedef EFI_HANDLE TIS_TPM_HANDLE;\r
 \r
 ///\r
 /// TPM register base address.\r
 ///\r
-#define TPM_BASE_ADDRESS            0xfed40000\r
+#define TPM_BASE_ADDRESS  0xfed40000\r
 \r
 //\r
 // Set structure alignment to 1-byte\r
@@ -31,75 +31,75 @@ typedef struct {
   ///\r
   /// Used to gain ownership for this particular port.\r
   ///\r
-  UINT8                             Access;             // 0\r
-  UINT8                             Reserved1[7];       // 1\r
+  UINT8     Access;                                     // 0\r
+  UINT8     Reserved1[7];                               // 1\r
   ///\r
   /// Controls interrupts.\r
   ///\r
-  UINT32                            IntEnable;          // 8\r
+  UINT32    IntEnable;                                  // 8\r
   ///\r
   /// SIRQ vector to be used by the TPM.\r
   ///\r
-  UINT8                             IntVector;          // 0ch\r
-  UINT8                             Reserved2[3];       // 0dh\r
+  UINT8     IntVector;                                  // 0ch\r
+  UINT8     Reserved2[3];                               // 0dh\r
   ///\r
   /// What caused interrupt.\r
   ///\r
-  UINT32                            IntSts;             // 10h\r
+  UINT32    IntSts;                                     // 10h\r
   ///\r
   /// Shows which interrupts are supported by that particular TPM.\r
   ///\r
-  UINT32                            IntfCapability;     // 14h\r
+  UINT32    IntfCapability;                             // 14h\r
   ///\r
   /// Status Register. Provides status of the TPM.\r
   ///\r
-  UINT8                             Status;             // 18h\r
+  UINT8     Status;                                     // 18h\r
   ///\r
   /// Number of consecutive writes that can be done to the TPM.\r
   ///\r
-  UINT16                            BurstCount;         // 19h\r
-  UINT8                             Reserved3[9];\r
+  UINT16    BurstCount;                                 // 19h\r
+  UINT8     Reserved3[9];\r
   ///\r
   /// Read or write FIFO, depending on transaction.\r
   ///\r
-  UINT32                            DataFifo;           // 24\r
-  UINT8                             Reserved4[0xed8];   // 28h\r
+  UINT32    DataFifo;                                   // 24\r
+  UINT8     Reserved4[0xed8];                           // 28h\r
   ///\r
   /// Vendor ID\r
   ///\r
-  UINT16                            Vid;                // 0f00h\r
+  UINT16    Vid;                                        // 0f00h\r
   ///\r
   /// Device ID\r
   ///\r
-  UINT16                            Did;                // 0f02h\r
+  UINT16    Did;                                        // 0f02h\r
   ///\r
   /// Revision ID\r
   ///\r
-  UINT8                             Rid;                // 0f04h\r
+  UINT8     Rid;                                        // 0f04h\r
   ///\r
   /// TCG defined configuration registers.\r
   ///\r
-  UINT8                             TcgDefined[0x7b];   // 0f05h\r
+  UINT8     TcgDefined[0x7b];                           // 0f05h\r
   ///\r
   /// Alias to I/O legacy space.\r
   ///\r
-  UINT32                            LegacyAddress1;     // 0f80h\r
+  UINT32    LegacyAddress1;                             // 0f80h\r
   ///\r
   /// Additional 8 bits for I/O legacy space extension.\r
   ///\r
-  UINT32                            LegacyAddress1Ex;   // 0f84h\r
+  UINT32    LegacyAddress1Ex;                           // 0f84h\r
   ///\r
   /// Alias to second I/O legacy space.\r
   ///\r
-  UINT32                            LegacyAddress2;     // 0f88h\r
+  UINT32    LegacyAddress2;                             // 0f88h\r
   ///\r
   /// Additional 8 bits for second I/O legacy space extension.\r
   ///\r
-  UINT32                            LegacyAddress2Ex;   // 0f8ch\r
+  UINT32    LegacyAddress2Ex;                           // 0f8ch\r
   ///\r
   /// Vendor-defined configuration registers.\r
   ///\r
-  UINT8                             VendorDefined[0x70];// 0f90h\r
+  UINT8     VendorDefined[0x70];                        // 0f90h\r
 } TIS_PC_REGISTERS;\r
 \r
 //\r
@@ -110,13 +110,13 @@ typedef struct {
 //\r
 // Define pointer types used to access TIS registers on PC\r
 //\r
-typedef TIS_PC_REGISTERS  *TIS_PC_REGISTERS_PTR;\r
+typedef TIS_PC_REGISTERS *TIS_PC_REGISTERS_PTR;\r
 \r
 //\r
 // TCG Platform Type based on TCG ACPI Specification Version 1.00\r
 //\r
-#define TCG_PLATFORM_TYPE_CLIENT   0\r
-#define TCG_PLATFORM_TYPE_SERVER   1\r
+#define TCG_PLATFORM_TYPE_CLIENT  0\r
+#define TCG_PLATFORM_TYPE_SERVER  1\r
 \r
 //\r
 // Define bits of ACCESS and STATUS registers\r
@@ -125,69 +125,69 @@ typedef TIS_PC_REGISTERS  *TIS_PC_REGISTERS_PTR;
 ///\r
 /// This bit is a 1 to indicate that the other bits in this register are valid.\r
 ///\r
-#define TIS_PC_VALID                BIT7\r
+#define TIS_PC_VALID  BIT7\r
 ///\r
 /// Indicate that this locality is active.\r
 ///\r
-#define TIS_PC_ACC_ACTIVE           BIT5\r
+#define TIS_PC_ACC_ACTIVE  BIT5\r
 ///\r
 /// Set to 1 to indicate that this locality had the TPM taken away while\r
 /// this locality had the TIS_PC_ACC_ACTIVE bit set.\r
 ///\r
-#define TIS_PC_ACC_SEIZED           BIT4\r
+#define TIS_PC_ACC_SEIZED  BIT4\r
 ///\r
 /// Set to 1 to indicate that TPM MUST reset the\r
 /// TIS_PC_ACC_ACTIVE bit and remove ownership for localities less than the\r
 /// locality that is writing this bit.\r
 ///\r
-#define TIS_PC_ACC_SEIZE            BIT3\r
+#define TIS_PC_ACC_SEIZE  BIT3\r
 ///\r
 /// When this bit is 1, another locality is requesting usage of the TPM.\r
 ///\r
-#define TIS_PC_ACC_PENDIND          BIT2\r
+#define TIS_PC_ACC_PENDIND  BIT2\r
 ///\r
 /// Set to 1 to indicate that this locality is requesting to use TPM.\r
 ///\r
-#define TIS_PC_ACC_RQUUSE           BIT1\r
+#define TIS_PC_ACC_RQUUSE  BIT1\r
 ///\r
 /// A value of 1 indicates that a T/OS has not been established on the platform\r
 ///\r
-#define TIS_PC_ACC_ESTABLISH        BIT0\r
+#define TIS_PC_ACC_ESTABLISH  BIT0\r
 \r
 ///\r
 /// When this bit is 1, TPM is in the Ready state,\r
 /// indicating it is ready to receive a new command.\r
 ///\r
-#define TIS_PC_STS_READY            BIT6\r
+#define TIS_PC_STS_READY  BIT6\r
 ///\r
 /// Write a 1 to this bit to cause the TPM to execute that command.\r
 ///\r
-#define TIS_PC_STS_GO               BIT5\r
+#define TIS_PC_STS_GO  BIT5\r
 ///\r
 /// This bit indicates that the TPM has data available as a response.\r
 ///\r
-#define TIS_PC_STS_DATA             BIT4\r
+#define TIS_PC_STS_DATA  BIT4\r
 ///\r
 /// The TPM sets this bit to a value of 1 when it expects another byte of data for a command.\r
 ///\r
-#define TIS_PC_STS_EXPECT           BIT3\r
+#define TIS_PC_STS_EXPECT  BIT3\r
 ///\r
 /// Writes a 1 to this bit to force the TPM to re-send the response.\r
 ///\r
-#define TIS_PC_STS_RETRY            BIT1\r
+#define TIS_PC_STS_RETRY  BIT1\r
 \r
 //\r
 // Default TimeOut value\r
 //\r
-#define TIS_TIMEOUT_A               750 * 1000   // 750ms\r
-#define TIS_TIMEOUT_B               2000 * 1000  // 2s\r
-#define TIS_TIMEOUT_C               750 * 1000   // 750ms\r
-#define TIS_TIMEOUT_D               750 * 1000   // 750ms\r
+#define TIS_TIMEOUT_A  750 * 1000                // 750ms\r
+#define TIS_TIMEOUT_B  2000 * 1000               // 2s\r
+#define TIS_TIMEOUT_C  750 * 1000                // 750ms\r
+#define TIS_TIMEOUT_D  750 * 1000                // 750ms\r
 \r
 //\r
 // Max TPM command/response length\r
 //\r
-#define TPMCMDBUFLENGTH             1024\r
+#define TPMCMDBUFLENGTH  1024\r
 \r
 /**\r
   Check whether the value of a TPM chip register satisfies the input BIT setting.\r
index c805e2de00bb0feedda2209ff6c1fe531894c67e..561ebad09da2d9f64b445567f5c73fad9d3f7aa2 100644 (file)
@@ -25,8 +25,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 GetVariableKey (\r
-      OUT VOID    **VariableKey,\r
-  IN  OUT UINTN   *VariableKeySize\r
+  OUT VOID       **VariableKey,\r
+  IN  OUT UINTN  *VariableKeySize\r
   );\r
 \r
 /**\r
@@ -57,4 +57,3 @@ LockVariableKeyInterface (
   );\r
 \r
 #endif\r
-\r
index 18095b597044635a5b0a8bc8eaed5072a88dad06..5f4f719e01d2451f711579aa5a9cbc701e48c692 100644 (file)
@@ -13,19 +13,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
  { 0x6e056ff9, 0xc695, 0x4364, { 0x9e, 0x2c, 0x61, 0x26, 0xf5, 0xce, 0xea, 0xae } }\r
 \r
 typedef struct {\r
-  EFI_PHYSICAL_ADDRESS              FvBase;\r
-  UINT64                            FvLength;\r
+  EFI_PHYSICAL_ADDRESS    FvBase;\r
+  UINT64                  FvLength;\r
 } EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_FV;\r
 \r
 //\r
 // This PPI means a FV does not need to be extended to PCR by TCG modules.\r
 //\r
 typedef struct {\r
-  UINT32                                                Count;\r
-  EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_FV  Fv[1];\r
+  UINT32                                                  Count;\r
+  EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_FV    Fv[1];\r
 } EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI;\r
 \r
-extern EFI_GUID gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid;\r
+extern EFI_GUID  gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid;\r
 \r
 #endif\r
-\r
index 1b7320e91614c284d314f157d9fc8d89664ce903..71f2be33a6d43e4be3b5de5eddb782515985a613 100644 (file)
@@ -18,9 +18,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // HashAlgoId is TPM_ALG_ID in Tpm20.h\r
 //\r
 typedef struct _HASH_INFO {\r
-  UINT16                                     HashAlgoId;\r
-  UINT16                                     HashSize;\r
-  //UINT8                                    Hash[];\r
+  UINT16    HashAlgoId;\r
+  UINT16    HashSize;\r
+  // UINT8                                    Hash[];\r
 } HASH_INFO;\r
 \r
 //\r
@@ -32,13 +32,12 @@ typedef struct _HASH_INFO {
 //     else, drops PPI data and calculate all hash again\r
 //\r
 typedef struct {\r
-  UINT32                                     FvBase;\r
-  UINT32                                     FvLength;\r
-  UINT32                                     Count;\r
-  //HASH_INFO                                HashInfo[];\r
+  UINT32    FvBase;\r
+  UINT32    FvLength;\r
+  UINT32    Count;\r
+  // HASH_INFO                                HashInfo[];\r
 } EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI;\r
 \r
-extern EFI_GUID gEdkiiPeiFirmwareVolumeInfoPrehashedFvPpiGuid;\r
+extern EFI_GUID  gEdkiiPeiFirmwareVolumeInfoPrehashedFvPpiGuid;\r
 \r
 #endif\r
-\r
index 42f2748f92b5b092f9db8082caf58ca411fd9f1c..68eee92145ecc9f05fcf8905d9bb45429f2afe93 100644 (file)
@@ -18,32 +18,32 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Hashed FV flags.\r
 //\r
-#define HASHED_FV_FLAG_REPORT_FV_INFO_PPI     0x0000000000000001\r
-#define HASHED_FV_FLAG_REPORT_FV_HOB          0x0000000000000002\r
-#define HASHED_FV_FLAG_VERIFIED_BOOT          0x0000000000000010\r
-#define HASHED_FV_FLAG_MEASURED_BOOT          0x0000000000000020\r
-#define HASHED_FV_FLAG_SKIP_ALL               0xFFFFFFFFFFFFFF00\r
-#define HASHED_FV_FLAG_SKIP_BOOT_MODE(Mode)   LShiftU64 (0x100, (Mode))\r
+#define HASHED_FV_FLAG_REPORT_FV_INFO_PPI  0x0000000000000001\r
+#define HASHED_FV_FLAG_REPORT_FV_HOB       0x0000000000000002\r
+#define HASHED_FV_FLAG_VERIFIED_BOOT       0x0000000000000010\r
+#define HASHED_FV_FLAG_MEASURED_BOOT       0x0000000000000020\r
+#define HASHED_FV_FLAG_SKIP_ALL            0xFFFFFFFFFFFFFF00\r
+#define HASHED_FV_FLAG_SKIP_BOOT_MODE(Mode)  LShiftU64 (0x100, (Mode))\r
 \r
 //\r
 // FV hash flags\r
 //\r
-#define FV_HASH_FLAG_BOOT_MODE(Mode)          LShiftU64 (0x100, (Mode))\r
+#define FV_HASH_FLAG_BOOT_MODE(Mode)  LShiftU64 (0x100, (Mode))\r
 \r
 typedef struct _EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI\r
                 EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI;\r
 \r
 typedef struct _HASHED_FV_INFO {\r
-  UINT64                  Base;\r
-  UINT64                  Length;\r
-  UINT64                  Flag;\r
+  UINT64    Base;\r
+  UINT64    Length;\r
+  UINT64    Flag;\r
 } HASHED_FV_INFO;\r
 \r
 typedef struct _FV_HASH_INFO {\r
-  UINT64                  HashFlag;\r
-  UINT16                  HashAlgoId;\r
-  UINT16                  HashSize;\r
-  UINT8                   Hash[64];\r
+  UINT64    HashFlag;\r
+  UINT16    HashAlgoId;\r
+  UINT16    HashSize;\r
+  UINT8     Hash[64];\r
 } FV_HASH_INFO;\r
 \r
 //\r
@@ -51,12 +51,11 @@ typedef struct _FV_HASH_INFO {
 // instance of this PPI is allowed in the platform.\r
 //\r
 struct _EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI {\r
-  FV_HASH_INFO            HashInfo;\r
-  UINTN                   FvNumber;\r
-  HASHED_FV_INFO          FvInfo[1];\r
+  FV_HASH_INFO      HashInfo;\r
+  UINTN             FvNumber;\r
+  HASHED_FV_INFO    FvInfo[1];\r
 };\r
 \r
-extern EFI_GUID gEdkiiPeiFirmwareVolumeInfoStoredHashFvPpiGuid;\r
+extern EFI_GUID  gEdkiiPeiFirmwareVolumeInfoStoredHashFvPpiGuid;\r
 \r
 #endif\r
-\r
index 90253140317714bc18d5ad392dd877813c23c4ec..648cbe3bc7b621326d2422431196df8adddbe272 100644 (file)
@@ -37,7 +37,7 @@ typedef
 BOOLEAN\r
 (EFIAPI *PEI_LOCK_PHYSICAL_PRESENCE)(\r
   IN CONST  EFI_PEI_SERVICES                    **PeiServices\r
-);\r
+  );\r
 \r
 ///\r
 /// This service abstracts TPM physical presence lock interface. It is necessary for\r
@@ -46,9 +46,9 @@ BOOLEAN
 /// PEIM and consumed by the TPM PEIM.\r
 ///\r
 struct _PEI_LOCK_PHYSICAL_PRESENCE_PPI {\r
-  PEI_LOCK_PHYSICAL_PRESENCE  LockPhysicalPresence;\r
+  PEI_LOCK_PHYSICAL_PRESENCE    LockPhysicalPresence;\r
 };\r
 \r
 extern EFI_GUID  gPeiLockPhysicalPresencePpiGuid;\r
 \r
-#endif  //  __PEI_LOCK_PHYSICAL_PRESENCE_H__\r
+#endif //  __PEI_LOCK_PHYSICAL_PRESENCE_H__\r
index 22f47f9817ddec95cc5898dc05dcefff4adfebf3..258ba78fc36b19fb2bccd2eb3f664fe647b17edb 100644 (file)
@@ -57,9 +57,9 @@ EFI_STATUS
 /// The EFI_TCG Protocol abstracts TCG activity.\r
 ///\r
 struct _EDKII_TCG_PPI {\r
-  EDKII_TCG_HASH_LOG_EXTEND_EVENT     HashLogExtendEvent;\r
+  EDKII_TCG_HASH_LOG_EXTEND_EVENT    HashLogExtendEvent;\r
 };\r
 \r
-extern EFI_GUID gEdkiiTcgPpiGuid;\r
+extern EFI_GUID  gEdkiiTcgPpiGuid;\r
 \r
 #endif\r
index b7a47b00c38e36276940cf8da39365964346b77b..86ee3fc8d71be4b61d2d79d0e79b442370fcfd00 100644 (file)
@@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0xe9db0d58, 0xd48d, 0x47f6, 0x9c, 0x6e, 0x6f, 0x40, 0xe8, 0x6c, 0x7b, 0x41 \\r
   }\r
 \r
-extern EFI_GUID gPeiTpmInitializedPpiGuid;\r
+extern EFI_GUID  gPeiTpmInitializedPpiGuid;\r
 \r
 ///\r
 /// Global ID for the PEI_TPM_INITIALIZATION_DONE_PPI which always uses a NULL interface.\r
@@ -29,6 +29,6 @@ extern EFI_GUID gPeiTpmInitializedPpiGuid;
     0xa030d115, 0x54dd, 0x447b, { 0x90, 0x64, 0xf2, 0x6, 0x88, 0x3d, 0x7c, 0xcc \\r
   }\r
 \r
-extern EFI_GUID gPeiTpmInitializationDonePpiGuid;\r
+extern EFI_GUID  gPeiTpmInitializationDonePpiGuid;\r
 \r
 #endif\r
index 3059e5d25669709a822047cab6ba3cb7f8767373..054ee4d1d9886a0f05a3cac43dd2a87728c6f47a 100644 (file)
@@ -32,28 +32,28 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Public Exponent of RSA Key.\r
 //\r
-CONST UINT8 mRsaE[] = { 0x01, 0x00, 0x01 };\r
+CONST UINT8  mRsaE[] = { 0x01, 0x00, 0x01 };\r
 \r
-CONST UINT8 mSha256OidValue[] = { 0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x01 };\r
+CONST UINT8  mSha256OidValue[] = { 0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x01 };\r
 \r
 //\r
 // Requirement for different signature type which have been defined in UEFI spec.\r
 // These data are used to perform SignatureList format check while setting PK/KEK variable.\r
 //\r
-EFI_SIGNATURE_ITEM mSupportSigItem[] = {\r
-//{SigType,                       SigHeaderSize,   SigDataSize  }\r
-  {EFI_CERT_SHA256_GUID,          0,               32           },\r
-  {EFI_CERT_RSA2048_GUID,         0,               256          },\r
-  {EFI_CERT_RSA2048_SHA256_GUID,  0,               256          },\r
-  {EFI_CERT_SHA1_GUID,            0,               20           },\r
-  {EFI_CERT_RSA2048_SHA1_GUID,    0,               256          },\r
-  {EFI_CERT_X509_GUID,            0,               ((UINT32) ~0)},\r
-  {EFI_CERT_SHA224_GUID,          0,               28           },\r
-  {EFI_CERT_SHA384_GUID,          0,               48           },\r
-  {EFI_CERT_SHA512_GUID,          0,               64           },\r
-  {EFI_CERT_X509_SHA256_GUID,     0,               48           },\r
-  {EFI_CERT_X509_SHA384_GUID,     0,               64           },\r
-  {EFI_CERT_X509_SHA512_GUID,     0,               80           }\r
+EFI_SIGNATURE_ITEM  mSupportSigItem[] = {\r
+  // {SigType,                       SigHeaderSize,   SigDataSize  }\r
+  { EFI_CERT_SHA256_GUID,         0, 32            },\r
+  { EFI_CERT_RSA2048_GUID,        0, 256           },\r
+  { EFI_CERT_RSA2048_SHA256_GUID, 0, 256           },\r
+  { EFI_CERT_SHA1_GUID,           0, 20            },\r
+  { EFI_CERT_RSA2048_SHA1_GUID,   0, 256           },\r
+  { EFI_CERT_X509_GUID,           0, ((UINT32) ~0) },\r
+  { EFI_CERT_SHA224_GUID,         0, 28            },\r
+  { EFI_CERT_SHA384_GUID,         0, 48            },\r
+  { EFI_CERT_SHA512_GUID,         0, 64            },\r
+  { EFI_CERT_X509_SHA256_GUID,    0, 48            },\r
+  { EFI_CERT_X509_SHA384_GUID,    0, 64            },\r
+  { EFI_CERT_X509_SHA512_GUID,    0, 80            }\r
 };\r
 \r
 /**\r
@@ -76,22 +76,22 @@ EFI_SIGNATURE_ITEM mSupportSigItem[] = {
 **/\r
 EFI_STATUS\r
 AuthServiceInternalFindVariable (\r
-  IN  CHAR16            *VariableName,\r
-  IN  EFI_GUID          *VendorGuid,\r
-  OUT VOID              **Data,\r
-  OUT UINTN             *DataSize\r
+  IN  CHAR16    *VariableName,\r
+  IN  EFI_GUID  *VendorGuid,\r
+  OUT VOID      **Data,\r
+  OUT UINTN     *DataSize\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  AUTH_VARIABLE_INFO    AuthVariableInfo;\r
+  EFI_STATUS          Status;\r
+  AUTH_VARIABLE_INFO  AuthVariableInfo;\r
 \r
   ZeroMem (&AuthVariableInfo, sizeof (AuthVariableInfo));\r
   Status = mAuthVarLibContextIn->FindVariable (\r
-           VariableName,\r
-           VendorGuid,\r
-           &AuthVariableInfo\r
-           );\r
-  *Data = AuthVariableInfo.Data;\r
+                                   VariableName,\r
+                                   VendorGuid,\r
+                                   &AuthVariableInfo\r
+                                   );\r
+  *Data     = AuthVariableInfo.Data;\r
   *DataSize = AuthVariableInfo.DataSize;\r
   return Status;\r
 }\r
@@ -113,25 +113,25 @@ AuthServiceInternalFindVariable (
 **/\r
 EFI_STATUS\r
 AuthServiceInternalUpdateVariable (\r
-  IN CHAR16             *VariableName,\r
-  IN EFI_GUID           *VendorGuid,\r
-  IN VOID               *Data,\r
-  IN UINTN              DataSize,\r
-  IN UINT32             Attributes\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN VOID      *Data,\r
+  IN UINTN     DataSize,\r
+  IN UINT32    Attributes\r
   )\r
 {\r
-  AUTH_VARIABLE_INFO    AuthVariableInfo;\r
+  AUTH_VARIABLE_INFO  AuthVariableInfo;\r
 \r
   ZeroMem (&AuthVariableInfo, sizeof (AuthVariableInfo));\r
   AuthVariableInfo.VariableName = VariableName;\r
-  AuthVariableInfo.VendorGuid = VendorGuid;\r
-  AuthVariableInfo.Data = Data;\r
-  AuthVariableInfo.DataSize = DataSize;\r
-  AuthVariableInfo.Attributes = Attributes;\r
+  AuthVariableInfo.VendorGuid   = VendorGuid;\r
+  AuthVariableInfo.Data         = Data;\r
+  AuthVariableInfo.DataSize     = DataSize;\r
+  AuthVariableInfo.Attributes   = Attributes;\r
 \r
   return mAuthVarLibContextIn->UpdateVariable (\r
-           &AuthVariableInfo\r
-           );\r
+                                 &AuthVariableInfo\r
+                                 );\r
 }\r
 \r
 /**\r
@@ -152,18 +152,18 @@ AuthServiceInternalUpdateVariable (
 **/\r
 EFI_STATUS\r
 AuthServiceInternalUpdateVariableWithTimeStamp (\r
-  IN CHAR16             *VariableName,\r
-  IN EFI_GUID           *VendorGuid,\r
-  IN VOID               *Data,\r
-  IN UINTN              DataSize,\r
-  IN UINT32             Attributes,\r
-  IN EFI_TIME           *TimeStamp\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN VOID      *Data,\r
+  IN UINTN     DataSize,\r
+  IN UINT32    Attributes,\r
+  IN EFI_TIME  *TimeStamp\r
   )\r
 {\r
-  EFI_STATUS            FindStatus;\r
-  VOID                  *OrgData;\r
-  UINTN                 OrgDataSize;\r
-  AUTH_VARIABLE_INFO    AuthVariableInfo;\r
+  EFI_STATUS          FindStatus;\r
+  VOID                *OrgData;\r
+  UINTN               OrgDataSize;\r
+  AUTH_VARIABLE_INFO  AuthVariableInfo;\r
 \r
   FindStatus = AuthServiceInternalFindVariable (\r
                  VariableName,\r
@@ -177,9 +177,10 @@ AuthServiceInternalUpdateVariableWithTimeStamp (
   //\r
   if (!EFI_ERROR (FindStatus) && ((Attributes & EFI_VARIABLE_APPEND_WRITE) != 0)) {\r
     if ((CompareGuid (VendorGuid, &gEfiImageSecurityDatabaseGuid) &&\r
-        ((StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE) == 0) || (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE1) == 0) ||\r
-        (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE2) == 0))) ||\r
-        (CompareGuid (VendorGuid, &gEfiGlobalVariableGuid) && (StrCmp (VariableName, EFI_KEY_EXCHANGE_KEY_NAME) == 0))) {\r
+         ((StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE) == 0) || (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE1) == 0) ||\r
+          (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE2) == 0))) ||\r
+        (CompareGuid (VendorGuid, &gEfiGlobalVariableGuid) && (StrCmp (VariableName, EFI_KEY_EXCHANGE_KEY_NAME) == 0)))\r
+    {\r
       //\r
       // For variables with formatted as EFI_SIGNATURE_LIST, the driver shall not perform an append of\r
       // EFI_SIGNATURE_DATA values that are already part of the existing variable value.\r
@@ -195,14 +196,14 @@ AuthServiceInternalUpdateVariableWithTimeStamp (
 \r
   ZeroMem (&AuthVariableInfo, sizeof (AuthVariableInfo));\r
   AuthVariableInfo.VariableName = VariableName;\r
-  AuthVariableInfo.VendorGuid = VendorGuid;\r
-  AuthVariableInfo.Data = Data;\r
-  AuthVariableInfo.DataSize = DataSize;\r
-  AuthVariableInfo.Attributes = Attributes;\r
-  AuthVariableInfo.TimeStamp = TimeStamp;\r
+  AuthVariableInfo.VendorGuid   = VendorGuid;\r
+  AuthVariableInfo.Data         = Data;\r
+  AuthVariableInfo.DataSize     = DataSize;\r
+  AuthVariableInfo.Attributes   = Attributes;\r
+  AuthVariableInfo.TimeStamp    = TimeStamp;\r
   return mAuthVarLibContextIn->UpdateVariable (\r
-           &AuthVariableInfo\r
-           );\r
+                                 &AuthVariableInfo\r
+                                 );\r
 }\r
 \r
 /**\r
@@ -216,15 +217,16 @@ AuthServiceInternalUpdateVariableWithTimeStamp (
 \r
 **/\r
 BOOLEAN\r
-NeedPhysicallyPresent(\r
-  IN     CHAR16         *VariableName,\r
-  IN     EFI_GUID       *VendorGuid\r
+NeedPhysicallyPresent (\r
+  IN     CHAR16    *VariableName,\r
+  IN     EFI_GUID  *VendorGuid\r
   )\r
 {\r
   // If the VariablePolicy engine is disabled, allow deletion of any authenticated variables.\r
-  if (IsVariablePolicyEnabled()) {\r
-    if ((CompareGuid (VendorGuid, &gEfiSecureBootEnableDisableGuid) && (StrCmp (VariableName, EFI_SECURE_BOOT_ENABLE_NAME) == 0))\r
-      || (CompareGuid (VendorGuid, &gEfiCustomModeEnableGuid) && (StrCmp (VariableName, EFI_CUSTOM_MODE_NAME) == 0))) {\r
+  if (IsVariablePolicyEnabled ()) {\r
+    if (  (CompareGuid (VendorGuid, &gEfiSecureBootEnableDisableGuid) && (StrCmp (VariableName, EFI_SECURE_BOOT_ENABLE_NAME) == 0))\r
+       || (CompareGuid (VendorGuid, &gEfiCustomModeEnableGuid) && (StrCmp (VariableName, EFI_CUSTOM_MODE_NAME) == 0)))\r
+    {\r
       return TRUE;\r
     }\r
   }\r
@@ -244,12 +246,12 @@ InCustomMode (
   VOID\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
-  VOID          *Data;\r
-  UINTN         DataSize;\r
+  EFI_STATUS  Status;\r
+  VOID        *Data;\r
+  UINTN       DataSize;\r
 \r
   Status = AuthServiceInternalFindVariable (EFI_CUSTOM_MODE_NAME, &gEfiCustomModeEnableGuid, &Data, &DataSize);\r
-  if (!EFI_ERROR (Status) && (*(UINT8 *) Data == CUSTOM_SECURE_BOOT_MODE)) {\r
+  if (!EFI_ERROR (Status) && (*(UINT8 *)Data == CUSTOM_SECURE_BOOT_MODE)) {\r
     return TRUE;\r
   }\r
 \r
@@ -267,15 +269,15 @@ InCustomMode (
 **/\r
 EFI_STATUS\r
 UpdatePlatformMode (\r
-  IN  UINT32                    Mode\r
+  IN  UINT32  Mode\r
   )\r
 {\r
-  EFI_STATUS              Status;\r
-  VOID                    *Data;\r
-  UINTN                   DataSize;\r
-  UINT8                   SecureBootMode;\r
-  UINT8                   SecureBootEnable;\r
-  UINTN                   VariableDataSize;\r
+  EFI_STATUS  Status;\r
+  VOID        *Data;\r
+  UINTN       DataSize;\r
+  UINT8       SecureBootMode;\r
+  UINT8       SecureBootEnable;\r
+  UINTN       VariableDataSize;\r
 \r
   Status = AuthServiceInternalFindVariable (\r
              EFI_SETUP_MODE_NAME,\r
@@ -291,8 +293,8 @@ UpdatePlatformMode (
   // Update the value of SetupMode variable by a simple mem copy, this could avoid possible\r
   // variable storage reclaim at runtime.\r
   //\r
-  mPlatformMode = (UINT8) Mode;\r
-  CopyMem (Data, &mPlatformMode, sizeof(UINT8));\r
+  mPlatformMode = (UINT8)Mode;\r
+  CopyMem (Data, &mPlatformMode, sizeof (UINT8));\r
 \r
   if (mAuthVarLibContextIn->AtRuntime ()) {\r
     //\r
@@ -331,13 +333,13 @@ UpdatePlatformMode (
     }\r
   }\r
 \r
-  Status  = AuthServiceInternalUpdateVariable (\r
-              EFI_SECURE_BOOT_MODE_NAME,\r
-              &gEfiGlobalVariableGuid,\r
-              &SecureBootMode,\r
-              sizeof(UINT8),\r
-              EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS\r
-              );\r
+  Status = AuthServiceInternalUpdateVariable (\r
+             EFI_SECURE_BOOT_MODE_NAME,\r
+             &gEfiGlobalVariableGuid,\r
+             &SecureBootMode,\r
+             sizeof (UINT8),\r
+             EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS\r
+             );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -366,6 +368,7 @@ UpdatePlatformMode (
     if (EFI_ERROR (Status)) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     SecureBootEnable = SECURE_BOOT_DISABLE;\r
     VariableDataSize = 0;\r
   }\r
@@ -393,21 +396,21 @@ UpdatePlatformMode (
 \r
 **/\r
 EFI_STATUS\r
-CheckSignatureListFormat(\r
-  IN  CHAR16                    *VariableName,\r
-  IN  EFI_GUID                  *VendorGuid,\r
-  IN  VOID                      *Data,\r
-  IN  UINTN                     DataSize\r
+CheckSignatureListFormat (\r
+  IN  CHAR16    *VariableName,\r
+  IN  EFI_GUID  *VendorGuid,\r
+  IN  VOID      *Data,\r
+  IN  UINTN     DataSize\r
   )\r
 {\r
-  EFI_SIGNATURE_LIST     *SigList;\r
-  UINTN                  SigDataSize;\r
-  UINT32                 Index;\r
-  UINT32                 SigCount;\r
-  BOOLEAN                IsPk;\r
-  VOID                   *RsaContext;\r
-  EFI_SIGNATURE_DATA     *CertData;\r
-  UINTN                  CertLen;\r
+  EFI_SIGNATURE_LIST  *SigList;\r
+  UINTN               SigDataSize;\r
+  UINT32              Index;\r
+  UINT32              SigCount;\r
+  BOOLEAN             IsPk;\r
+  VOID                *RsaContext;\r
+  EFI_SIGNATURE_DATA  *CertData;\r
+  UINTN               CertLen;\r
 \r
   if (DataSize == 0) {\r
     return EFI_SUCCESS;\r
@@ -415,21 +418,22 @@ CheckSignatureListFormat(
 \r
   ASSERT (VariableName != NULL && VendorGuid != NULL && Data != NULL);\r
 \r
-  if (CompareGuid (VendorGuid, &gEfiGlobalVariableGuid) && (StrCmp (VariableName, EFI_PLATFORM_KEY_NAME) == 0)){\r
+  if (CompareGuid (VendorGuid, &gEfiGlobalVariableGuid) && (StrCmp (VariableName, EFI_PLATFORM_KEY_NAME) == 0)) {\r
     IsPk = TRUE;\r
   } else if ((CompareGuid (VendorGuid, &gEfiGlobalVariableGuid) && (StrCmp (VariableName, EFI_KEY_EXCHANGE_KEY_NAME) == 0)) ||\r
              (CompareGuid (VendorGuid, &gEfiImageSecurityDatabaseGuid) &&\r
-             ((StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE) == 0) || (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE1) == 0) ||\r
-              (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE2) == 0)))) {\r
+              ((StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE) == 0) || (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE1) == 0) ||\r
+               (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE2) == 0))))\r
+  {\r
     IsPk = FALSE;\r
   } else {\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  SigCount = 0;\r
-  SigList  = (EFI_SIGNATURE_LIST *) Data;\r
-  SigDataSize  = DataSize;\r
-  RsaContext = NULL;\r
+  SigCount    = 0;\r
+  SigList     = (EFI_SIGNATURE_LIST *)Data;\r
+  SigDataSize = DataSize;\r
+  RsaContext  = NULL;\r
 \r
   //\r
   // Walk through the input signature list and check the data format.\r
@@ -442,14 +446,18 @@ CheckSignatureListFormat(
         // The value of SignatureSize should always be 16 (size of SignatureOwner\r
         // component) add the data length according to signature type.\r
         //\r
-        if (mSupportSigItem[Index].SigDataSize != ((UINT32) ~0) &&\r
-          (SigList->SignatureSize - sizeof (EFI_GUID)) != mSupportSigItem[Index].SigDataSize) {\r
+        if ((mSupportSigItem[Index].SigDataSize != ((UINT32) ~0)) &&\r
+            ((SigList->SignatureSize - sizeof (EFI_GUID)) != mSupportSigItem[Index].SigDataSize))\r
+        {\r
           return EFI_INVALID_PARAMETER;\r
         }\r
-        if (mSupportSigItem[Index].SigHeaderSize != ((UINT32) ~0) &&\r
-          SigList->SignatureHeaderSize != mSupportSigItem[Index].SigHeaderSize) {\r
+\r
+        if ((mSupportSigItem[Index].SigHeaderSize != ((UINT32) ~0)) &&\r
+            (SigList->SignatureHeaderSize != mSupportSigItem[Index].SigHeaderSize))\r
+        {\r
           return EFI_INVALID_PARAMETER;\r
         }\r
+\r
         break;\r
       }\r
     }\r
@@ -470,29 +478,32 @@ CheckSignatureListFormat(
       if (RsaContext == NULL) {\r
         return EFI_INVALID_PARAMETER;\r
       }\r
-      CertData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) + SigList->SignatureHeaderSize);\r
-      CertLen = SigList->SignatureSize - sizeof (EFI_GUID);\r
+\r
+      CertData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) + SigList->SignatureHeaderSize);\r
+      CertLen  = SigList->SignatureSize - sizeof (EFI_GUID);\r
       if (!RsaGetPublicKeyFromX509 (CertData->SignatureData, CertLen, &RsaContext)) {\r
         RsaFree (RsaContext);\r
         return EFI_INVALID_PARAMETER;\r
       }\r
+\r
       RsaFree (RsaContext);\r
     }\r
 \r
     if ((SigList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - SigList->SignatureHeaderSize) % SigList->SignatureSize != 0) {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
+\r
     SigCount += (SigList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - SigList->SignatureHeaderSize) / SigList->SignatureSize;\r
 \r
     SigDataSize -= SigList->SignatureListSize;\r
-    SigList = (EFI_SIGNATURE_LIST *) ((UINT8 *) SigList + SigList->SignatureListSize);\r
+    SigList      = (EFI_SIGNATURE_LIST *)((UINT8 *)SigList + SigList->SignatureListSize);\r
   }\r
 \r
-  if (((UINTN) SigList - (UINTN) Data) != DataSize) {\r
+  if (((UINTN)SigList - (UINTN)Data) != DataSize) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  if (IsPk && SigCount > 1) {\r
+  if (IsPk && (SigCount > 1)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -511,11 +522,12 @@ VendorKeyIsModified (
   VOID\r
   )\r
 {\r
-  EFI_STATUS              Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (mVendorKeyState == VENDOR_KEYS_MODIFIED) {\r
     return EFI_SUCCESS;\r
   }\r
+\r
   mVendorKeyState = VENDOR_KEYS_MODIFIED;\r
 \r
   Status = AuthServiceInternalUpdateVariable (\r
@@ -564,21 +576,22 @@ VendorKeyIsModified (
 **/\r
 EFI_STATUS\r
 ProcessVarWithPk (\r
-  IN  CHAR16                    *VariableName,\r
-  IN  EFI_GUID                  *VendorGuid,\r
-  IN  VOID                      *Data,\r
-  IN  UINTN                     DataSize,\r
-  IN  UINT32                    Attributes OPTIONAL,\r
-  IN  BOOLEAN                   IsPk\r
+  IN  CHAR16    *VariableName,\r
+  IN  EFI_GUID  *VendorGuid,\r
+  IN  VOID      *Data,\r
+  IN  UINTN     DataSize,\r
+  IN  UINT32    Attributes OPTIONAL,\r
+  IN  BOOLEAN   IsPk\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  BOOLEAN                     Del;\r
-  UINT8                       *Payload;\r
-  UINTN                       PayloadSize;\r
+  EFI_STATUS  Status;\r
+  BOOLEAN     Del;\r
+  UINT8       *Payload;\r
+  UINTN       PayloadSize;\r
 \r
-  if ((Attributes & EFI_VARIABLE_NON_VOLATILE) == 0 ||\r
-      (Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) == 0) {\r
+  if (((Attributes & EFI_VARIABLE_NON_VOLATILE) == 0) ||\r
+      ((Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) == 0))\r
+  {\r
     //\r
     // PK, KEK and db/dbx/dbt should set EFI_VARIABLE_NON_VOLATILE attribute and should be a time-based\r
     // authenticated variable.\r
@@ -590,14 +603,14 @@ ProcessVarWithPk (
   // Init state of Del. State may change due to secure check\r
   //\r
   Del = FALSE;\r
-  if ((InCustomMode() && UserPhysicalPresent()) || (mPlatformMode == SETUP_MODE && !IsPk)) {\r
-    Payload = (UINT8 *) Data + AUTHINFO2_SIZE (Data);\r
+  if ((InCustomMode () && UserPhysicalPresent ()) || ((mPlatformMode == SETUP_MODE) && !IsPk)) {\r
+    Payload     = (UINT8 *)Data + AUTHINFO2_SIZE (Data);\r
     PayloadSize = DataSize - AUTHINFO2_SIZE (Data);\r
     if (PayloadSize == 0) {\r
       Del = TRUE;\r
     }\r
 \r
-    Status = CheckSignatureListFormat(VariableName, VendorGuid, Payload, PayloadSize);\r
+    Status = CheckSignatureListFormat (VariableName, VendorGuid, Payload, PayloadSize);\r
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
@@ -608,9 +621,9 @@ ProcessVarWithPk (
                Payload,\r
                PayloadSize,\r
                Attributes,\r
-               &((EFI_VARIABLE_AUTHENTICATION_2 *) Data)->TimeStamp\r
+               &((EFI_VARIABLE_AUTHENTICATION_2 *)Data)->TimeStamp\r
                );\r
-    if (EFI_ERROR(Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
 \r
@@ -645,13 +658,13 @@ ProcessVarWithPk (
                );\r
   }\r
 \r
-  if (!EFI_ERROR(Status) && IsPk) {\r
-    if (mPlatformMode == SETUP_MODE && !Del) {\r
+  if (!EFI_ERROR (Status) && IsPk) {\r
+    if ((mPlatformMode == SETUP_MODE) && !Del) {\r
       //\r
       // If enroll PK in setup mode, need change to user mode.\r
       //\r
       Status = UpdatePlatformMode (USER_MODE);\r
-    } else if (mPlatformMode == USER_MODE && Del){\r
+    } else if ((mPlatformMode == USER_MODE) && Del) {\r
       //\r
       // If delete PK in user mode, need change to setup mode.\r
       //\r
@@ -687,19 +700,20 @@ ProcessVarWithPk (
 **/\r
 EFI_STATUS\r
 ProcessVarWithKek (\r
-  IN  CHAR16                               *VariableName,\r
-  IN  EFI_GUID                             *VendorGuid,\r
-  IN  VOID                                 *Data,\r
-  IN  UINTN                                DataSize,\r
-  IN  UINT32                               Attributes OPTIONAL\r
+  IN  CHAR16    *VariableName,\r
+  IN  EFI_GUID  *VendorGuid,\r
+  IN  VOID      *Data,\r
+  IN  UINTN     DataSize,\r
+  IN  UINT32    Attributes OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                      Status;\r
-  UINT8                           *Payload;\r
-  UINTN                           PayloadSize;\r
+  EFI_STATUS  Status;\r
+  UINT8       *Payload;\r
+  UINTN       PayloadSize;\r
 \r
-  if ((Attributes & EFI_VARIABLE_NON_VOLATILE) == 0 ||\r
-      (Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) == 0) {\r
+  if (((Attributes & EFI_VARIABLE_NON_VOLATILE) == 0) ||\r
+      ((Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) == 0))\r
+  {\r
     //\r
     // DB, DBX and DBT should set EFI_VARIABLE_NON_VOLATILE attribute and should be a time-based\r
     // authenticated variable.\r
@@ -708,7 +722,7 @@ ProcessVarWithKek (
   }\r
 \r
   Status = EFI_SUCCESS;\r
-  if (mPlatformMode == USER_MODE && !(InCustomMode() && UserPhysicalPresent())) {\r
+  if ((mPlatformMode == USER_MODE) && !(InCustomMode () && UserPhysicalPresent ())) {\r
     //\r
     // Time-based, verify against X509 Cert KEK.\r
     //\r
@@ -725,10 +739,10 @@ ProcessVarWithKek (
     //\r
     // If in setup mode or custom secure boot mode, no authentication needed.\r
     //\r
-    Payload = (UINT8 *) Data + AUTHINFO2_SIZE (Data);\r
+    Payload     = (UINT8 *)Data + AUTHINFO2_SIZE (Data);\r
     PayloadSize = DataSize - AUTHINFO2_SIZE (Data);\r
 \r
-    Status = CheckSignatureListFormat(VariableName, VendorGuid, Payload, PayloadSize);\r
+    Status = CheckSignatureListFormat (VariableName, VendorGuid, Payload, PayloadSize);\r
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
@@ -739,7 +753,7 @@ ProcessVarWithKek (
                Payload,\r
                PayloadSize,\r
                Attributes,\r
-               &((EFI_VARIABLE_AUTHENTICATION_2 *) Data)->TimeStamp\r
+               &((EFI_VARIABLE_AUTHENTICATION_2 *)Data)->TimeStamp\r
                );\r
     if (EFI_ERROR (Status)) {\r
       return Status;\r
@@ -767,14 +781,14 @@ ProcessVarWithKek (
 **/\r
 BOOLEAN\r
 IsDeleteAuthVariable (\r
-  IN  UINT32                    OrgAttributes,\r
-  IN  VOID                      *Data,\r
-  IN  UINTN                     DataSize,\r
-  IN  UINT32                    Attributes\r
+  IN  UINT32  OrgAttributes,\r
+  IN  VOID    *Data,\r
+  IN  UINTN   DataSize,\r
+  IN  UINT32  Attributes\r
   )\r
 {\r
-  BOOLEAN                       Del;\r
-  UINTN                         PayloadSize;\r
+  BOOLEAN  Del;\r
+  UINTN    PayloadSize;\r
 \r
   Del = FALSE;\r
 \r
@@ -785,7 +799,8 @@ IsDeleteAuthVariable (
   // and the DataSize set to the size of the AuthInfo descriptor.\r
   //\r
   if ((Attributes == OrgAttributes) &&\r
-      ((Attributes & (EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS)) != 0)) {\r
+      ((Attributes & (EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS)) != 0))\r
+  {\r
     if ((Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) != 0) {\r
       PayloadSize = DataSize - AUTHINFO2_SIZE (Data);\r
       if (PayloadSize == 0) {\r
@@ -830,37 +845,37 @@ IsDeleteAuthVariable (
 **/\r
 EFI_STATUS\r
 ProcessVariable (\r
-  IN     CHAR16                             *VariableName,\r
-  IN     EFI_GUID                           *VendorGuid,\r
-  IN     VOID                               *Data,\r
-  IN     UINTN                              DataSize,\r
-  IN     UINT32                             Attributes\r
+  IN     CHAR16    *VariableName,\r
+  IN     EFI_GUID  *VendorGuid,\r
+  IN     VOID      *Data,\r
+  IN     UINTN     DataSize,\r
+  IN     UINT32    Attributes\r
   )\r
 {\r
-  EFI_STATUS                      Status;\r
-  AUTH_VARIABLE_INFO              OrgVariableInfo;\r
+  EFI_STATUS          Status;\r
+  AUTH_VARIABLE_INFO  OrgVariableInfo;\r
 \r
-  Status      = EFI_SUCCESS;\r
+  Status = EFI_SUCCESS;\r
 \r
   ZeroMem (&OrgVariableInfo, sizeof (OrgVariableInfo));\r
   Status = mAuthVarLibContextIn->FindVariable (\r
-             VariableName,\r
-             VendorGuid,\r
-             &OrgVariableInfo\r
-             );\r
+                                   VariableName,\r
+                                   VendorGuid,\r
+                                   &OrgVariableInfo\r
+                                   );\r
 \r
   // If the VariablePolicy engine is disabled, allow deletion of any authenticated variables.\r
-  if ((!EFI_ERROR (Status)) && IsDeleteAuthVariable (OrgVariableInfo.Attributes, Data, DataSize, Attributes) && (UserPhysicalPresent() || !IsVariablePolicyEnabled())) {\r
+  if ((!EFI_ERROR (Status)) && IsDeleteAuthVariable (OrgVariableInfo.Attributes, Data, DataSize, Attributes) && (UserPhysicalPresent () || !IsVariablePolicyEnabled ())) {\r
     //\r
     // Allow the delete operation of common authenticated variable(AT or AW) at user physical presence.\r
     //\r
     Status = AuthServiceInternalUpdateVariable (\r
-              VariableName,\r
-              VendorGuid,\r
-              NULL,\r
-              0,\r
-              0\r
-              );\r
+               VariableName,\r
+               VendorGuid,\r
+               NULL,\r
+               0,\r
+               0\r
+               );\r
     if (!EFI_ERROR (Status) && ((Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) != 0)) {\r
       Status = DeleteCertsFromDb (VariableName, VendorGuid, Attributes);\r
     }\r
@@ -868,7 +883,7 @@ ProcessVariable (
     return Status;\r
   }\r
 \r
-  if (NeedPhysicallyPresent (VariableName, VendorGuid) && !UserPhysicalPresent()) {\r
+  if (NeedPhysicallyPresent (VariableName, VendorGuid) && !UserPhysicalPresent ()) {\r
     //\r
     // This variable is protected, only physical present user could modify its value.\r
     //\r
@@ -897,7 +912,8 @@ ProcessVariable (
   }\r
 \r
   if ((OrgVariableInfo.Data != NULL) &&\r
-     ((OrgVariableInfo.Attributes & (EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS)) != 0)) {\r
+      ((OrgVariableInfo.Attributes & (EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS)) != 0))\r
+  {\r
     //\r
     // If the variable is already write-protected, it always needs authentication before update.\r
     //\r
@@ -909,7 +925,6 @@ ProcessVariable (
   //\r
   Status = AuthServiceInternalUpdateVariable (VariableName, VendorGuid, Data, DataSize, Attributes);\r
   return Status;\r
-\r
 }\r
 \r
 /**\r
@@ -923,56 +938,57 @@ ProcessVariable (
 **/\r
 EFI_STATUS\r
 FilterSignatureList (\r
-  IN     VOID       *Data,\r
-  IN     UINTN      DataSize,\r
-  IN OUT VOID       *NewData,\r
-  IN OUT UINTN      *NewDataSize\r
+  IN     VOID   *Data,\r
+  IN     UINTN  DataSize,\r
+  IN OUT VOID   *NewData,\r
+  IN OUT UINTN  *NewDataSize\r
   )\r
 {\r
-  EFI_SIGNATURE_LIST    *CertList;\r
-  EFI_SIGNATURE_DATA    *Cert;\r
-  UINTN                 CertCount;\r
-  EFI_SIGNATURE_LIST    *NewCertList;\r
-  EFI_SIGNATURE_DATA    *NewCert;\r
-  UINTN                 NewCertCount;\r
-  UINTN                 Index;\r
-  UINTN                 Index2;\r
-  UINTN                 Size;\r
-  UINT8                 *Tail;\r
-  UINTN                 CopiedCount;\r
-  UINTN                 SignatureListSize;\r
-  BOOLEAN               IsNewCert;\r
-  UINT8                 *TempData;\r
-  UINTN                 TempDataSize;\r
-  EFI_STATUS            Status;\r
+  EFI_SIGNATURE_LIST  *CertList;\r
+  EFI_SIGNATURE_DATA  *Cert;\r
+  UINTN               CertCount;\r
+  EFI_SIGNATURE_LIST  *NewCertList;\r
+  EFI_SIGNATURE_DATA  *NewCert;\r
+  UINTN               NewCertCount;\r
+  UINTN               Index;\r
+  UINTN               Index2;\r
+  UINTN               Size;\r
+  UINT8               *Tail;\r
+  UINTN               CopiedCount;\r
+  UINTN               SignatureListSize;\r
+  BOOLEAN             IsNewCert;\r
+  UINT8               *TempData;\r
+  UINTN               TempDataSize;\r
+  EFI_STATUS          Status;\r
 \r
   if (*NewDataSize == 0) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
   TempDataSize = *NewDataSize;\r
-  Status = mAuthVarLibContextIn->GetScratchBuffer (&TempDataSize, (VOID **) &TempData);\r
+  Status       = mAuthVarLibContextIn->GetScratchBuffer (&TempDataSize, (VOID **)&TempData);\r
   if (EFI_ERROR (Status)) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
   Tail = TempData;\r
 \r
-  NewCertList = (EFI_SIGNATURE_LIST *) NewData;\r
+  NewCertList = (EFI_SIGNATURE_LIST *)NewData;\r
   while ((*NewDataSize > 0) && (*NewDataSize >= NewCertList->SignatureListSize)) {\r
-    NewCert      = (EFI_SIGNATURE_DATA *) ((UINT8 *) NewCertList + sizeof (EFI_SIGNATURE_LIST) + NewCertList->SignatureHeaderSize);\r
+    NewCert      = (EFI_SIGNATURE_DATA *)((UINT8 *)NewCertList + sizeof (EFI_SIGNATURE_LIST) + NewCertList->SignatureHeaderSize);\r
     NewCertCount = (NewCertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - NewCertList->SignatureHeaderSize) / NewCertList->SignatureSize;\r
 \r
     CopiedCount = 0;\r
     for (Index = 0; Index < NewCertCount; Index++) {\r
       IsNewCert = TRUE;\r
 \r
-      Size = DataSize;\r
-      CertList = (EFI_SIGNATURE_LIST *) Data;\r
+      Size     = DataSize;\r
+      CertList = (EFI_SIGNATURE_LIST *)Data;\r
       while ((Size > 0) && (Size >= CertList->SignatureListSize)) {\r
         if (CompareGuid (&CertList->SignatureType, &NewCertList->SignatureType) &&\r
-           (CertList->SignatureSize == NewCertList->SignatureSize)) {\r
-          Cert      = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+            (CertList->SignatureSize == NewCertList->SignatureSize))\r
+        {\r
+          Cert      = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
           CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
           for (Index2 = 0; Index2 < CertCount; Index2++) {\r
             //\r
@@ -982,15 +998,17 @@ FilterSignatureList (
               IsNewCert = FALSE;\r
               break;\r
             }\r
-            Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) Cert + CertList->SignatureSize);\r
+\r
+            Cert = (EFI_SIGNATURE_DATA *)((UINT8 *)Cert + CertList->SignatureSize);\r
           }\r
         }\r
 \r
         if (!IsNewCert) {\r
           break;\r
         }\r
-        Size -= CertList->SignatureListSize;\r
-        CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+\r
+        Size    -= CertList->SignatureListSize;\r
+        CertList = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
       }\r
 \r
       if (IsNewCert) {\r
@@ -1010,23 +1028,23 @@ FilterSignatureList (
         CopiedCount++;\r
       }\r
 \r
-      NewCert = (EFI_SIGNATURE_DATA *) ((UINT8 *) NewCert + NewCertList->SignatureSize);\r
+      NewCert = (EFI_SIGNATURE_DATA *)((UINT8 *)NewCert + NewCertList->SignatureSize);\r
     }\r
 \r
     //\r
     // Update SignatureListSize in the kept EFI_SIGNATURE_LIST.\r
     //\r
     if (CopiedCount != 0) {\r
-      SignatureListSize = sizeof (EFI_SIGNATURE_LIST) + NewCertList->SignatureHeaderSize + (CopiedCount * NewCertList->SignatureSize);\r
-      CertList = (EFI_SIGNATURE_LIST *) (Tail - SignatureListSize);\r
-      CertList->SignatureListSize = (UINT32) SignatureListSize;\r
+      SignatureListSize           = sizeof (EFI_SIGNATURE_LIST) + NewCertList->SignatureHeaderSize + (CopiedCount * NewCertList->SignatureSize);\r
+      CertList                    = (EFI_SIGNATURE_LIST *)(Tail - SignatureListSize);\r
+      CertList->SignatureListSize = (UINT32)SignatureListSize;\r
     }\r
 \r
     *NewDataSize -= NewCertList->SignatureListSize;\r
-    NewCertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) NewCertList + NewCertList->SignatureListSize);\r
+    NewCertList   = (EFI_SIGNATURE_LIST *)((UINT8 *)NewCertList + NewCertList->SignatureListSize);\r
   }\r
 \r
-  TempDataSize = (Tail - (UINT8 *) TempData);\r
+  TempDataSize = (Tail - (UINT8 *)TempData);\r
 \r
   CopyMem (NewData, TempData, TempDataSize);\r
   *NewDataSize = TempDataSize;\r
@@ -1047,23 +1065,23 @@ FilterSignatureList (
 **/\r
 BOOLEAN\r
 AuthServiceInternalCompareTimeStamp (\r
-  IN EFI_TIME               *FirstTime,\r
-  IN EFI_TIME               *SecondTime\r
+  IN EFI_TIME  *FirstTime,\r
+  IN EFI_TIME  *SecondTime\r
   )\r
 {\r
   if (FirstTime->Year != SecondTime->Year) {\r
-    return (BOOLEAN) (FirstTime->Year < SecondTime->Year);\r
+    return (BOOLEAN)(FirstTime->Year < SecondTime->Year);\r
   } else if (FirstTime->Month != SecondTime->Month) {\r
-    return (BOOLEAN) (FirstTime->Month < SecondTime->Month);\r
+    return (BOOLEAN)(FirstTime->Month < SecondTime->Month);\r
   } else if (FirstTime->Day != SecondTime->Day) {\r
-    return (BOOLEAN) (FirstTime->Day < SecondTime->Day);\r
+    return (BOOLEAN)(FirstTime->Day < SecondTime->Day);\r
   } else if (FirstTime->Hour != SecondTime->Hour) {\r
-    return (BOOLEAN) (FirstTime->Hour < SecondTime->Hour);\r
+    return (BOOLEAN)(FirstTime->Hour < SecondTime->Hour);\r
   } else if (FirstTime->Minute != SecondTime->Minute) {\r
-    return (BOOLEAN) (FirstTime->Minute < SecondTime->Minute);\r
+    return (BOOLEAN)(FirstTime->Minute < SecondTime->Minute);\r
   }\r
 \r
-  return (BOOLEAN) (FirstTime->Second <= SecondTime->Second);\r
+  return (BOOLEAN)(FirstTime->Second <= SecondTime->Second);\r
 }\r
 \r
 /**\r
@@ -1081,37 +1099,37 @@ AuthServiceInternalCompareTimeStamp (
 \r
 **/\r
 EFI_STATUS\r
-CalculatePrivAuthVarSignChainSHA256Digest(\r
-  IN     UINT8            *SignerCert,\r
-  IN     UINTN            SignerCertSize,\r
-  IN     UINT8            *TopLevelCert,\r
-  IN     UINTN            TopLevelCertSize,\r
-  OUT    UINT8            *Sha256Digest\r
+CalculatePrivAuthVarSignChainSHA256Digest (\r
+  IN     UINT8  *SignerCert,\r
+  IN     UINTN  SignerCertSize,\r
+  IN     UINT8  *TopLevelCert,\r
+  IN     UINTN  TopLevelCertSize,\r
+  OUT    UINT8  *Sha256Digest\r
   )\r
 {\r
-  UINT8                   *TbsCert;\r
-  UINTN                   TbsCertSize;\r
-  CHAR8                   CertCommonName[128];\r
-  UINTN                   CertCommonNameSize;\r
-  BOOLEAN                 CryptoStatus;\r
-  EFI_STATUS              Status;\r
+  UINT8       *TbsCert;\r
+  UINTN       TbsCertSize;\r
+  CHAR8       CertCommonName[128];\r
+  UINTN       CertCommonNameSize;\r
+  BOOLEAN     CryptoStatus;\r
+  EFI_STATUS  Status;\r
 \r
-  CertCommonNameSize = sizeof(CertCommonName);\r
+  CertCommonNameSize = sizeof (CertCommonName);\r
 \r
   //\r
   // Get SignerCert CommonName\r
   //\r
-  Status = X509GetCommonName(SignerCert, SignerCertSize, CertCommonName, &CertCommonNameSize);\r
-  if (EFI_ERROR(Status)) {\r
-    DEBUG((DEBUG_INFO, "%a Get SignerCert CommonName failed with status %x\n", __FUNCTION__, Status));\r
+  Status = X509GetCommonName (SignerCert, SignerCertSize, CertCommonName, &CertCommonNameSize);\r
+  if (EFI_ERROR (Status)) {\r
+    DEBUG ((DEBUG_INFO, "%a Get SignerCert CommonName failed with status %x\n", __FUNCTION__, Status));\r
     return EFI_ABORTED;\r
   }\r
 \r
   //\r
   // Get TopLevelCert tbsCertificate\r
   //\r
-  if (!X509GetTBSCert(TopLevelCert, TopLevelCertSize, &TbsCert, &TbsCertSize)) {\r
-    DEBUG((DEBUG_INFO, "%a Get Top-level Cert tbsCertificate failed!\n", __FUNCTION__));\r
+  if (!X509GetTBSCert (TopLevelCert, TopLevelCertSize, &TbsCert, &TbsCertSize)) {\r
+    DEBUG ((DEBUG_INFO, "%a Get Top-level Cert tbsCertificate failed!\n", __FUNCTION__));\r
     return EFI_ABORTED;\r
   }\r
 \r
@@ -1141,7 +1159,7 @@ CalculatePrivAuthVarSignChainSHA256Digest(
     return EFI_ABORTED;\r
   }\r
 \r
-  CryptoStatus  = Sha256Final (mHashCtx, Sha256Digest);\r
+  CryptoStatus = Sha256Final (mHashCtx, Sha256Digest);\r
   if (!CryptoStatus) {\r
     return EFI_ABORTED;\r
   }\r
@@ -1179,22 +1197,22 @@ CalculatePrivAuthVarSignChainSHA256Digest(
 **/\r
 EFI_STATUS\r
 FindCertsFromDb (\r
-  IN     CHAR16           *VariableName,\r
-  IN     EFI_GUID         *VendorGuid,\r
-  IN     UINT8            *Data,\r
-  IN     UINTN            DataSize,\r
-  OUT    UINT32           *CertOffset     OPTIONAL,\r
-  OUT    UINT32           *CertDataSize   OPTIONAL,\r
-  OUT    UINT32           *CertNodeOffset OPTIONAL,\r
-  OUT    UINT32           *CertNodeSize   OPTIONAL\r
+  IN     CHAR16    *VariableName,\r
+  IN     EFI_GUID  *VendorGuid,\r
+  IN     UINT8     *Data,\r
+  IN     UINTN     DataSize,\r
+  OUT    UINT32    *CertOffset     OPTIONAL,\r
+  OUT    UINT32    *CertDataSize   OPTIONAL,\r
+  OUT    UINT32    *CertNodeOffset OPTIONAL,\r
+  OUT    UINT32    *CertNodeSize   OPTIONAL\r
   )\r
 {\r
-  UINT32                  Offset;\r
-  AUTH_CERT_DB_DATA       *Ptr;\r
-  UINT32                  CertSize;\r
-  UINT32                  NameSize;\r
-  UINT32                  NodeSize;\r
-  UINT32                  CertDbListSize;\r
+  UINT32             Offset;\r
+  AUTH_CERT_DB_DATA  *Ptr;\r
+  UINT32             CertSize;\r
+  UINT32             NameSize;\r
+  UINT32             NodeSize;\r
+  UINT32             CertDbListSize;\r
 \r
   if ((VariableName == NULL) || (VendorGuid == NULL) || (Data == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -1207,9 +1225,9 @@ FindCertsFromDb (
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  CertDbListSize = ReadUnaligned32 ((UINT32 *) Data);\r
+  CertDbListSize = ReadUnaligned32 ((UINT32 *)Data);\r
 \r
-  if (CertDbListSize != (UINT32) DataSize) {\r
+  if (CertDbListSize != (UINT32)DataSize) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -1218,8 +1236,8 @@ FindCertsFromDb (
   //\r
   // Get corresponding certificates by VendorGuid and VariableName.\r
   //\r
-  while (Offset < (UINT32) DataSize) {\r
-    Ptr = (AUTH_CERT_DB_DATA *) (Data + Offset);\r
+  while (Offset < (UINT32)DataSize) {\r
+    Ptr = (AUTH_CERT_DB_DATA *)(Data + Offset);\r
     //\r
     // Check whether VendorGuid matches.\r
     //\r
@@ -1229,7 +1247,8 @@ FindCertsFromDb (
       CertSize = ReadUnaligned32 (&Ptr->CertDataSize);\r
 \r
       if (NodeSize != sizeof (EFI_GUID) + sizeof (UINT32) * 3 + CertSize +\r
-          sizeof (CHAR16) * NameSize) {\r
+          sizeof (CHAR16) * NameSize)\r
+      {\r
         return EFI_INVALID_PARAMETER;\r
       }\r
 \r
@@ -1238,7 +1257,8 @@ FindCertsFromDb (
       // Check whether VariableName matches.\r
       //\r
       if ((NameSize == StrLen (VariableName)) &&\r
-          (CompareMem (Data + Offset, VariableName, NameSize * sizeof (CHAR16)) == 0)) {\r
+          (CompareMem (Data + Offset, VariableName, NameSize * sizeof (CHAR16)) == 0))\r
+      {\r
         Offset = Offset + NameSize * sizeof (CHAR16);\r
 \r
         if (CertOffset != NULL) {\r
@@ -1250,7 +1270,7 @@ FindCertsFromDb (
         }\r
 \r
         if (CertNodeOffset != NULL) {\r
-          *CertNodeOffset = (UINT32) ((UINT8 *) Ptr - Data);\r
+          *CertNodeOffset = (UINT32)((UINT8 *)Ptr - Data);\r
         }\r
 \r
         if (CertNodeSize != NULL) {\r
@@ -1288,24 +1308,23 @@ FindCertsFromDb (
 **/\r
 EFI_STATUS\r
 GetCertsFromDb (\r
-  IN     CHAR16           *VariableName,\r
-  IN     EFI_GUID         *VendorGuid,\r
-  IN     UINT32           Attributes,\r
-  OUT    UINT8            **CertData,\r
-  OUT    UINT32           *CertDataSize\r
+  IN     CHAR16    *VariableName,\r
+  IN     EFI_GUID  *VendorGuid,\r
+  IN     UINT32    Attributes,\r
+  OUT    UINT8     **CertData,\r
+  OUT    UINT32    *CertDataSize\r
   )\r
 {\r
-  EFI_STATUS              Status;\r
-  UINT8                   *Data;\r
-  UINTN                   DataSize;\r
-  UINT32                  CertOffset;\r
-  CHAR16                  *DbName;\r
+  EFI_STATUS  Status;\r
+  UINT8       *Data;\r
+  UINTN       DataSize;\r
+  UINT32      CertOffset;\r
+  CHAR16      *DbName;\r
 \r
   if ((VariableName == NULL) || (VendorGuid == NULL) || (CertData == NULL) || (CertDataSize == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-\r
   if ((Attributes & EFI_VARIABLE_NON_VOLATILE) != 0) {\r
     //\r
     // Get variable "certdb".\r
@@ -1324,7 +1343,7 @@ GetCertsFromDb (
   Status = AuthServiceInternalFindVariable (\r
              DbName,\r
              &gEfiCertDbGuid,\r
-             (VOID **) &Data,\r
+             (VOID **)&Data,\r
              &DataSize\r
              );\r
   if (EFI_ERROR (Status)) {\r
@@ -1372,20 +1391,20 @@ GetCertsFromDb (
 **/\r
 EFI_STATUS\r
 DeleteCertsFromDb (\r
-  IN     CHAR16           *VariableName,\r
-  IN     EFI_GUID         *VendorGuid,\r
-  IN     UINT32           Attributes\r
+  IN     CHAR16    *VariableName,\r
+  IN     EFI_GUID  *VendorGuid,\r
+  IN     UINT32    Attributes\r
   )\r
 {\r
-  EFI_STATUS              Status;\r
-  UINT8                   *Data;\r
-  UINTN                   DataSize;\r
-  UINT32                  VarAttr;\r
-  UINT32                  CertNodeOffset;\r
-  UINT32                  CertNodeSize;\r
-  UINT8                   *NewCertDb;\r
-  UINT32                  NewCertDbSize;\r
-  CHAR16                  *DbName;\r
+  EFI_STATUS  Status;\r
+  UINT8       *Data;\r
+  UINTN       DataSize;\r
+  UINT32      VarAttr;\r
+  UINT32      CertNodeOffset;\r
+  UINT32      CertNodeSize;\r
+  UINT8       *NewCertDb;\r
+  UINT32      NewCertDbSize;\r
+  CHAR16      *DbName;\r
 \r
   if ((VariableName == NULL) || (VendorGuid == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -1395,20 +1414,20 @@ DeleteCertsFromDb (
     //\r
     // Get variable "certdb".\r
     //\r
-    DbName = EFI_CERT_DB_NAME;\r
-    VarAttr  = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
+    DbName  = EFI_CERT_DB_NAME;\r
+    VarAttr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
   } else {\r
     //\r
     // Get variable "certdbv".\r
     //\r
-    DbName = EFI_CERT_DB_VOLATILE_NAME;\r
+    DbName  = EFI_CERT_DB_VOLATILE_NAME;\r
     VarAttr = EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
   }\r
 \r
   Status = AuthServiceInternalFindVariable (\r
              DbName,\r
              &gEfiCertDbGuid,\r
-             (VOID **) &Data,\r
+             (VOID **)&Data,\r
              &DataSize\r
              );\r
 \r
@@ -1453,8 +1472,8 @@ DeleteCertsFromDb (
   //\r
   // Construct new data content of variable "certdb" or "certdbv".\r
   //\r
-  NewCertDbSize = (UINT32) DataSize - CertNodeSize;\r
-  NewCertDb     = (UINT8*) mCertDbStore;\r
+  NewCertDbSize = (UINT32)DataSize - CertNodeSize;\r
+  NewCertDb     = (UINT8 *)mCertDbStore;\r
 \r
   //\r
   // Copy the DB entries before deleting node.\r
@@ -1478,13 +1497,13 @@ DeleteCertsFromDb (
   //\r
   // Set "certdb" or "certdbv".\r
   //\r
-  Status   = AuthServiceInternalUpdateVariable (\r
-               DbName,\r
-               &gEfiCertDbGuid,\r
-               NewCertDb,\r
-               NewCertDbSize,\r
-               VarAttr\r
-               );\r
+  Status = AuthServiceInternalUpdateVariable (\r
+             DbName,\r
+             &gEfiCertDbGuid,\r
+             NewCertDb,\r
+             NewCertDbSize,\r
+             VarAttr\r
+             );\r
 \r
   return Status;\r
 }\r
@@ -1512,29 +1531,29 @@ DeleteCertsFromDb (
 **/\r
 EFI_STATUS\r
 InsertCertsToDb (\r
-  IN     CHAR16           *VariableName,\r
-  IN     EFI_GUID         *VendorGuid,\r
-  IN     UINT32           Attributes,\r
-  IN     UINT8            *SignerCert,\r
-  IN     UINTN            SignerCertSize,\r
-  IN     UINT8            *TopLevelCert,\r
-  IN     UINTN            TopLevelCertSize\r
+  IN     CHAR16    *VariableName,\r
+  IN     EFI_GUID  *VendorGuid,\r
+  IN     UINT32    Attributes,\r
+  IN     UINT8     *SignerCert,\r
+  IN     UINTN     SignerCertSize,\r
+  IN     UINT8     *TopLevelCert,\r
+  IN     UINTN     TopLevelCertSize\r
   )\r
 {\r
-  EFI_STATUS              Status;\r
-  UINT8                   *Data;\r
-  UINTN                   DataSize;\r
-  UINT32                  VarAttr;\r
-  UINT8                   *NewCertDb;\r
-  UINT32                  NewCertDbSize;\r
-  UINT32                  CertNodeSize;\r
-  UINT32                  NameSize;\r
-  UINT32                  CertDataSize;\r
-  AUTH_CERT_DB_DATA       *Ptr;\r
-  CHAR16                  *DbName;\r
-  UINT8                   Sha256Digest[SHA256_DIGEST_SIZE];\r
-\r
-  if ((VariableName == NULL) || (VendorGuid == NULL) || (SignerCert == NULL) ||(TopLevelCert == NULL)) {\r
+  EFI_STATUS         Status;\r
+  UINT8              *Data;\r
+  UINTN              DataSize;\r
+  UINT32             VarAttr;\r
+  UINT8              *NewCertDb;\r
+  UINT32             NewCertDbSize;\r
+  UINT32             CertNodeSize;\r
+  UINT32             NameSize;\r
+  UINT32             CertDataSize;\r
+  AUTH_CERT_DB_DATA  *Ptr;\r
+  CHAR16             *DbName;\r
+  UINT8              Sha256Digest[SHA256_DIGEST_SIZE];\r
+\r
+  if ((VariableName == NULL) || (VendorGuid == NULL) || (SignerCert == NULL) || (TopLevelCert == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -1542,13 +1561,13 @@ InsertCertsToDb (
     //\r
     // Get variable "certdb".\r
     //\r
-    DbName = EFI_CERT_DB_NAME;\r
-    VarAttr  = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
+    DbName  = EFI_CERT_DB_NAME;\r
+    VarAttr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
   } else {\r
     //\r
     // Get variable "certdbv".\r
     //\r
-    DbName = EFI_CERT_DB_VOLATILE_NAME;\r
+    DbName  = EFI_CERT_DB_VOLATILE_NAME;\r
     VarAttr = EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
   }\r
 \r
@@ -1558,7 +1577,7 @@ InsertCertsToDb (
   Status = AuthServiceInternalFindVariable (\r
              DbName,\r
              &gEfiCertDbGuid,\r
-             (VOID **) &Data,\r
+             (VOID **)&Data,\r
              &DataSize\r
              );\r
   if (EFI_ERROR (Status)) {\r
@@ -1593,15 +1612,15 @@ InsertCertsToDb (
   //\r
   // Construct new data content of variable "certdb" or "certdbv".\r
   //\r
-  NameSize      = (UINT32) StrLen (VariableName);\r
-  CertDataSize  = sizeof(Sha256Digest);\r
-  CertNodeSize  = sizeof (AUTH_CERT_DB_DATA) + (UINT32) CertDataSize + NameSize * sizeof (CHAR16);\r
-  NewCertDbSize = (UINT32) DataSize + CertNodeSize;\r
+  NameSize      = (UINT32)StrLen (VariableName);\r
+  CertDataSize  = sizeof (Sha256Digest);\r
+  CertNodeSize  = sizeof (AUTH_CERT_DB_DATA) + (UINT32)CertDataSize + NameSize * sizeof (CHAR16);\r
+  NewCertDbSize = (UINT32)DataSize + CertNodeSize;\r
   if (NewCertDbSize > mMaxCertDbSize) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  Status = CalculatePrivAuthVarSignChainSHA256Digest(\r
+  Status = CalculatePrivAuthVarSignChainSHA256Digest (\r
              SignerCert,\r
              SignerCertSize,\r
              TopLevelCert,\r
@@ -1612,7 +1631,7 @@ InsertCertsToDb (
     return Status;\r
   }\r
 \r
-  NewCertDb     = (UINT8*) mCertDbStore;\r
+  NewCertDb = (UINT8 *)mCertDbStore;\r
 \r
   //\r
   // Copy the DB entries before inserting node.\r
@@ -1625,20 +1644,20 @@ InsertCertsToDb (
   //\r
   // Construct new cert node.\r
   //\r
-  Ptr = (AUTH_CERT_DB_DATA *) (NewCertDb + DataSize);\r
+  Ptr = (AUTH_CERT_DB_DATA *)(NewCertDb + DataSize);\r
   CopyGuid (&Ptr->VendorGuid, VendorGuid);\r
   CopyMem (&Ptr->CertNodeSize, &CertNodeSize, sizeof (UINT32));\r
   CopyMem (&Ptr->NameSize, &NameSize, sizeof (UINT32));\r
   CopyMem (&Ptr->CertDataSize, &CertDataSize, sizeof (UINT32));\r
 \r
   CopyMem (\r
-    (UINT8 *) Ptr + sizeof (AUTH_CERT_DB_DATA),\r
+    (UINT8 *)Ptr + sizeof (AUTH_CERT_DB_DATA),\r
     VariableName,\r
     NameSize * sizeof (CHAR16)\r
     );\r
 \r
   CopyMem (\r
-    (UINT8 *) Ptr +  sizeof (AUTH_CERT_DB_DATA) + NameSize * sizeof (CHAR16),\r
+    (UINT8 *)Ptr +  sizeof (AUTH_CERT_DB_DATA) + NameSize * sizeof (CHAR16),\r
     Sha256Digest,\r
     CertDataSize\r
     );\r
@@ -1646,13 +1665,13 @@ InsertCertsToDb (
   //\r
   // Set "certdb" or "certdbv".\r
   //\r
-  Status   = AuthServiceInternalUpdateVariable (\r
-               DbName,\r
-               &gEfiCertDbGuid,\r
-               NewCertDb,\r
-               NewCertDbSize,\r
-               VarAttr\r
-               );\r
+  Status = AuthServiceInternalUpdateVariable (\r
+             DbName,\r
+             &gEfiCertDbGuid,\r
+             NewCertDb,\r
+             NewCertDbSize,\r
+             VarAttr\r
+             );\r
 \r
   return Status;\r
 }\r
@@ -1674,17 +1693,17 @@ CleanCertsFromDb (
   VOID\r
   )\r
 {\r
-  UINT32                  Offset;\r
-  AUTH_CERT_DB_DATA       *Ptr;\r
-  UINT32                  NameSize;\r
-  UINT32                  NodeSize;\r
-  CHAR16                  *VariableName;\r
-  EFI_STATUS              Status;\r
-  BOOLEAN                 CertCleaned;\r
-  UINT8                   *Data;\r
-  UINTN                   DataSize;\r
-  EFI_GUID                AuthVarGuid;\r
-  AUTH_VARIABLE_INFO      AuthVariableInfo;\r
+  UINT32              Offset;\r
+  AUTH_CERT_DB_DATA   *Ptr;\r
+  UINT32              NameSize;\r
+  UINT32              NodeSize;\r
+  CHAR16              *VariableName;\r
+  EFI_STATUS          Status;\r
+  BOOLEAN             CertCleaned;\r
+  UINT8               *Data;\r
+  UINTN               DataSize;\r
+  EFI_GUID            AuthVarGuid;\r
+  AUTH_VARIABLE_INFO  AuthVariableInfo;\r
 \r
   Status = EFI_SUCCESS;\r
 \r
@@ -1700,7 +1719,7 @@ CleanCertsFromDb (
     Status = AuthServiceInternalFindVariable (\r
                EFI_CERT_DB_NAME,\r
                &gEfiCertDbGuid,\r
-               (VOID **) &Data,\r
+               (VOID **)&Data,\r
                &DataSize\r
                );\r
     if (EFI_ERROR (Status)) {\r
@@ -1714,23 +1733,24 @@ CleanCertsFromDb (
 \r
     Offset = sizeof (UINT32);\r
 \r
-    while (Offset < (UINT32) DataSize) {\r
-      Ptr = (AUTH_CERT_DB_DATA *) (Data + Offset);\r
+    while (Offset < (UINT32)DataSize) {\r
+      Ptr      = (AUTH_CERT_DB_DATA *)(Data + Offset);\r
       NodeSize = ReadUnaligned32 (&Ptr->CertNodeSize);\r
       NameSize = ReadUnaligned32 (&Ptr->NameSize);\r
 \r
       //\r
       // Get VarName tailed with '\0'\r
       //\r
-      VariableName = AllocateZeroPool((NameSize + 1) * sizeof(CHAR16));\r
+      VariableName = AllocateZeroPool ((NameSize + 1) * sizeof (CHAR16));\r
       if (VariableName == NULL) {\r
         return EFI_OUT_OF_RESOURCES;\r
       }\r
-      CopyMem (VariableName, (UINT8 *) Ptr + sizeof (AUTH_CERT_DB_DATA), NameSize * sizeof(CHAR16));\r
+\r
+      CopyMem (VariableName, (UINT8 *)Ptr + sizeof (AUTH_CERT_DB_DATA), NameSize * sizeof (CHAR16));\r
       //\r
       // Keep VarGuid  aligned\r
       //\r
-      CopyMem (&AuthVarGuid, &Ptr->VendorGuid, sizeof(EFI_GUID));\r
+      CopyMem (&AuthVarGuid, &Ptr->VendorGuid, sizeof (EFI_GUID));\r
 \r
       //\r
       // Find corresponding time auth variable\r
@@ -1742,22 +1762,22 @@ CleanCertsFromDb (
                                        &AuthVariableInfo\r
                                        );\r
 \r
-      if (EFI_ERROR(Status) || (AuthVariableInfo.Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) == 0) {\r
+      if (EFI_ERROR (Status) || ((AuthVariableInfo.Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) == 0)) {\r
         //\r
         // While cleaning certdb, always delete the variable in certdb regardless of it attributes.\r
         //\r
-        Status      = DeleteCertsFromDb(\r
-                        VariableName,\r
-                        &AuthVarGuid,\r
-                        AuthVariableInfo.Attributes | EFI_VARIABLE_NON_VOLATILE\r
-                        );\r
+        Status = DeleteCertsFromDb (\r
+                   VariableName,\r
+                   &AuthVarGuid,\r
+                   AuthVariableInfo.Attributes | EFI_VARIABLE_NON_VOLATILE\r
+                   );\r
         CertCleaned = TRUE;\r
-        DEBUG((DEBUG_INFO, "Recovery!! Cert for Auth Variable %s Guid %g is removed for consistency\n", VariableName, &AuthVarGuid));\r
-        FreePool(VariableName);\r
+        DEBUG ((DEBUG_INFO, "Recovery!! Cert for Auth Variable %s Guid %g is removed for consistency\n", VariableName, &AuthVarGuid));\r
+        FreePool (VariableName);\r
         break;\r
       }\r
 \r
-      FreePool(VariableName);\r
+      FreePool (VariableName);\r
       Offset = Offset + NodeSize;\r
     }\r
   } while (CertCleaned);\r
@@ -1796,58 +1816,58 @@ CleanCertsFromDb (
 **/\r
 EFI_STATUS\r
 VerifyTimeBasedPayload (\r
-  IN     CHAR16                             *VariableName,\r
-  IN     EFI_GUID                           *VendorGuid,\r
-  IN     VOID                               *Data,\r
-  IN     UINTN                              DataSize,\r
-  IN     UINT32                             Attributes,\r
-  IN     AUTHVAR_TYPE                       AuthVarType,\r
-  IN     EFI_TIME                           *OrgTimeStamp,\r
-  OUT    UINT8                              **VarPayloadPtr,\r
-  OUT    UINTN                              *VarPayloadSize\r
+  IN     CHAR16        *VariableName,\r
+  IN     EFI_GUID      *VendorGuid,\r
+  IN     VOID          *Data,\r
+  IN     UINTN         DataSize,\r
+  IN     UINT32        Attributes,\r
+  IN     AUTHVAR_TYPE  AuthVarType,\r
+  IN     EFI_TIME      *OrgTimeStamp,\r
+  OUT    UINT8         **VarPayloadPtr,\r
+  OUT    UINTN         *VarPayloadSize\r
   )\r
 {\r
-  EFI_VARIABLE_AUTHENTICATION_2    *CertData;\r
-  UINT8                            *SigData;\r
-  UINT32                           SigDataSize;\r
-  UINT8                            *PayloadPtr;\r
-  UINTN                            PayloadSize;\r
-  UINT32                           Attr;\r
-  BOOLEAN                          VerifyStatus;\r
-  EFI_STATUS                       Status;\r
-  EFI_SIGNATURE_LIST               *CertList;\r
-  EFI_SIGNATURE_DATA               *Cert;\r
-  UINTN                            Index;\r
-  UINTN                            CertCount;\r
-  UINT32                           KekDataSize;\r
-  UINT8                            *NewData;\r
-  UINTN                            NewDataSize;\r
-  UINT8                            *Buffer;\r
-  UINTN                            Length;\r
-  UINT8                            *TopLevelCert;\r
-  UINTN                            TopLevelCertSize;\r
-  UINT8                            *TrustedCert;\r
-  UINTN                            TrustedCertSize;\r
-  UINT8                            *SignerCerts;\r
-  UINTN                            CertStackSize;\r
-  UINT8                            *CertsInCertDb;\r
-  UINT32                           CertsSizeinDb;\r
-  UINT8                            Sha256Digest[SHA256_DIGEST_SIZE];\r
-  EFI_CERT_DATA                    *CertDataPtr;\r
+  EFI_VARIABLE_AUTHENTICATION_2  *CertData;\r
+  UINT8                          *SigData;\r
+  UINT32                         SigDataSize;\r
+  UINT8                          *PayloadPtr;\r
+  UINTN                          PayloadSize;\r
+  UINT32                         Attr;\r
+  BOOLEAN                        VerifyStatus;\r
+  EFI_STATUS                     Status;\r
+  EFI_SIGNATURE_LIST             *CertList;\r
+  EFI_SIGNATURE_DATA             *Cert;\r
+  UINTN                          Index;\r
+  UINTN                          CertCount;\r
+  UINT32                         KekDataSize;\r
+  UINT8                          *NewData;\r
+  UINTN                          NewDataSize;\r
+  UINT8                          *Buffer;\r
+  UINTN                          Length;\r
+  UINT8                          *TopLevelCert;\r
+  UINTN                          TopLevelCertSize;\r
+  UINT8                          *TrustedCert;\r
+  UINTN                          TrustedCertSize;\r
+  UINT8                          *SignerCerts;\r
+  UINTN                          CertStackSize;\r
+  UINT8                          *CertsInCertDb;\r
+  UINT32                         CertsSizeinDb;\r
+  UINT8                          Sha256Digest[SHA256_DIGEST_SIZE];\r
+  EFI_CERT_DATA                  *CertDataPtr;\r
 \r
   //\r
   // 1. TopLevelCert is the top-level issuer certificate in signature Signer Cert Chain\r
   // 2. TrustedCert is the certificate which firmware trusts. It could be saved in protected\r
   //     storage or PK payload on PK init\r
   //\r
-  VerifyStatus           = FALSE;\r
-  CertData               = NULL;\r
-  NewData                = NULL;\r
-  Attr                   = Attributes;\r
-  SignerCerts            = NULL;\r
-  TopLevelCert           = NULL;\r
-  CertsInCertDb          = NULL;\r
-  CertDataPtr            = NULL;\r
+  VerifyStatus  = FALSE;\r
+  CertData      = NULL;\r
+  NewData       = NULL;\r
+  Attr          = Attributes;\r
+  SignerCerts   = NULL;\r
+  TopLevelCert  = NULL;\r
+  CertsInCertDb = NULL;\r
+  CertDataPtr   = NULL;\r
 \r
   //\r
   // When the attribute EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS is\r
@@ -1857,7 +1877,7 @@ VerifyTimeBasedPayload (
   // variable value. The authentication descriptor is not part of the variable data and is not\r
   // returned by subsequent calls to GetVariable().\r
   //\r
-  CertData = (EFI_VARIABLE_AUTHENTICATION_2 *) Data;\r
+  CertData = (EFI_VARIABLE_AUTHENTICATION_2 *)Data;\r
 \r
   //\r
   // Verify that Pad1, Nanosecond, TimeZone, Daylight and Pad2 components of the\r
@@ -1867,7 +1887,8 @@ VerifyTimeBasedPayload (
       (CertData->TimeStamp.Nanosecond != 0) ||\r
       (CertData->TimeStamp.TimeZone != 0) ||\r
       (CertData->TimeStamp.Daylight != 0) ||\r
-      (CertData->TimeStamp.Pad2 != 0)) {\r
+      (CertData->TimeStamp.Pad2 != 0))\r
+  {\r
     return EFI_SECURITY_VIOLATION;\r
   }\r
 \r
@@ -1885,7 +1906,8 @@ VerifyTimeBasedPayload (
   // Cert type should be EFI_CERT_TYPE_PKCS7_GUID.\r
   //\r
   if ((CertData->AuthInfo.Hdr.wCertificateType != WIN_CERT_TYPE_EFI_GUID) ||\r
-      !CompareGuid (&CertData->AuthInfo.CertType, &gEfiCertPkcs7Guid)) {\r
+      !CompareGuid (&CertData->AuthInfo.CertType, &gEfiCertPkcs7Guid))\r
+  {\r
     //\r
     // Invalid AuthInfo type, return EFI_SECURITY_VIOLATION.\r
     //\r
@@ -1896,8 +1918,8 @@ VerifyTimeBasedPayload (
   // Find out Pkcs7 SignedData which follows the EFI_VARIABLE_AUTHENTICATION_2 descriptor.\r
   // AuthInfo.Hdr.dwLength is the length of the entire certificate, including the length of the header.\r
   //\r
-  SigData = CertData->AuthInfo.CertData;\r
-  SigDataSize = CertData->AuthInfo.Hdr.dwLength - (UINT32) (OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData));\r
+  SigData     = CertData->AuthInfo.CertData;\r
+  SigDataSize = CertData->AuthInfo.Hdr.dwLength - (UINT32)(OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData));\r
 \r
   //\r
   // SignedData.digestAlgorithms shall contain the digest algorithm used when preparing the\r
@@ -1916,20 +1938,21 @@ VerifyTimeBasedPayload (
   if ((Attributes & EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) != 0) {\r
     if (SigDataSize >= (13 + sizeof (mSha256OidValue))) {\r
       if (((*(SigData + 1) & TWO_BYTE_ENCODE) != TWO_BYTE_ENCODE) ||\r
-           (CompareMem (SigData + 13, &mSha256OidValue, sizeof (mSha256OidValue)) != 0)) {\r
-          return EFI_SECURITY_VIOLATION;\r
-        }\r
+          (CompareMem (SigData + 13, &mSha256OidValue, sizeof (mSha256OidValue)) != 0))\r
+      {\r
+        return EFI_SECURITY_VIOLATION;\r
+      }\r
     }\r
   }\r
 \r
   //\r
   // Find out the new data payload which follows Pkcs7 SignedData directly.\r
   //\r
-  PayloadPtr = SigData + SigDataSize;\r
-  PayloadSize = DataSize - OFFSET_OF_AUTHINFO2_CERT_DATA - (UINTN) SigDataSize;\r
+  PayloadPtr  = SigData + SigDataSize;\r
+  PayloadSize = DataSize - OFFSET_OF_AUTHINFO2_CERT_DATA - (UINTN)SigDataSize;\r
 \r
   // If the VariablePolicy engine is disabled, allow deletion of any authenticated variables.\r
-  if (PayloadSize == 0 && (Attributes & EFI_VARIABLE_APPEND_WRITE) == 0 && !IsVariablePolicyEnabled()) {\r
+  if ((PayloadSize == 0) && ((Attributes & EFI_VARIABLE_APPEND_WRITE) == 0) && !IsVariablePolicyEnabled ()) {\r
     VerifyStatus = TRUE;\r
     goto Exit;\r
   }\r
@@ -1950,7 +1973,7 @@ VerifyTimeBasedPayload (
   // because it is only used at here to do verification temporarily first\r
   // and then used in UpdateVariable() for a time based auth variable set.\r
   //\r
-  Status = mAuthVarLibContextIn->GetScratchBuffer (&NewDataSize, (VOID **) &NewData);\r
+  Status = mAuthVarLibContextIn->GetScratchBuffer (&NewDataSize, (VOID **)&NewData);\r
   if (EFI_ERROR (Status)) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
@@ -2005,10 +2028,12 @@ VerifyTimeBasedPayload (
       VerifyStatus = FALSE;\r
       goto Exit;\r
     }\r
-    CertList = (EFI_SIGNATURE_LIST *) Data;\r
-    Cert     = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+\r
+    CertList = (EFI_SIGNATURE_LIST *)Data;\r
+    Cert     = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
     if ((TopLevelCertSize != (CertList->SignatureSize - (sizeof (EFI_SIGNATURE_DATA) - 1))) ||\r
-        (CompareMem (Cert->SignatureData, TopLevelCert, TopLevelCertSize) != 0)) {\r
+        (CompareMem (Cert->SignatureData, TopLevelCert, TopLevelCertSize) != 0))\r
+    {\r
       VerifyStatus = FALSE;\r
       goto Exit;\r
     }\r
@@ -2024,9 +2049,7 @@ VerifyTimeBasedPayload (
                      NewData,\r
                      NewDataSize\r
                      );\r
-\r
   } else if (AuthVarType == AuthVarTypeKek) {\r
-\r
     //\r
     // Get KEK database from variable.\r
     //\r
@@ -2043,18 +2066,18 @@ VerifyTimeBasedPayload (
     //\r
     // Ready to verify Pkcs7 SignedData. Go through KEK Signature Database to find out X.509 CertList.\r
     //\r
-    KekDataSize      = (UINT32) DataSize;\r
-    CertList         = (EFI_SIGNATURE_LIST *) Data;\r
+    KekDataSize = (UINT32)DataSize;\r
+    CertList    = (EFI_SIGNATURE_LIST *)Data;\r
     while ((KekDataSize > 0) && (KekDataSize >= CertList->SignatureListSize)) {\r
       if (CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid)) {\r
-        Cert       = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
-        CertCount  = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
+        Cert      = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+        CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
         for (Index = 0; Index < CertCount; Index++) {\r
           //\r
           // Iterate each Signature Data Node within this CertList for a verify\r
           //\r
-          TrustedCert      = Cert->SignatureData;\r
-          TrustedCertSize  = CertList->SignatureSize - (sizeof (EFI_SIGNATURE_DATA) - 1);\r
+          TrustedCert     = Cert->SignatureData;\r
+          TrustedCertSize = CertList->SignatureSize - (sizeof (EFI_SIGNATURE_DATA) - 1);\r
 \r
           //\r
           // Verify Pkcs7 SignedData via Pkcs7Verify library.\r
@@ -2070,14 +2093,15 @@ VerifyTimeBasedPayload (
           if (VerifyStatus) {\r
             goto Exit;\r
           }\r
-          Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) Cert + CertList->SignatureSize);\r
+\r
+          Cert = (EFI_SIGNATURE_DATA *)((UINT8 *)Cert + CertList->SignatureSize);\r
         }\r
       }\r
+\r
       KekDataSize -= CertList->SignatureListSize;\r
-      CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+      CertList     = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
     }\r
   } else if (AuthVarType == AuthVarTypePriv) {\r
-\r
     //\r
     // Process common authenticated variable except PK/KEK/DB/DBX/DBT.\r
     // Get signer's certificates from SignedData.\r
@@ -2112,24 +2136,25 @@ VerifyTimeBasedPayload (
         // Check hash of signer cert CommonName + Top-level issuer tbsCertificate against data in CertDb\r
         //\r
         CertDataPtr = (EFI_CERT_DATA *)(SignerCerts + 1);\r
-        Status = CalculatePrivAuthVarSignChainSHA256Digest(\r
-                   CertDataPtr->CertDataBuffer,\r
-                   ReadUnaligned32 ((UINT32 *)&(CertDataPtr->CertDataLength)),\r
-                   TopLevelCert,\r
-                   TopLevelCertSize,\r
-                   Sha256Digest\r
-                   );\r
-        if (EFI_ERROR(Status) || CompareMem (Sha256Digest, CertsInCertDb, CertsSizeinDb) != 0){\r
+        Status      = CalculatePrivAuthVarSignChainSHA256Digest (\r
+                        CertDataPtr->CertDataBuffer,\r
+                        ReadUnaligned32 ((UINT32 *)&(CertDataPtr->CertDataLength)),\r
+                        TopLevelCert,\r
+                        TopLevelCertSize,\r
+                        Sha256Digest\r
+                        );\r
+        if (EFI_ERROR (Status) || (CompareMem (Sha256Digest, CertsInCertDb, CertsSizeinDb) != 0)) {\r
           goto Exit;\r
         }\r
       } else {\r
-         //\r
-         // Keep backward compatible with previous solution which saves whole signer certs stack in CertDb\r
-         //\r
-         if ((CertStackSize != CertsSizeinDb) ||\r
-             (CompareMem (SignerCerts, CertsInCertDb, CertsSizeinDb) != 0)) {\r
-              goto Exit;\r
-         }\r
+        //\r
+        // Keep backward compatible with previous solution which saves whole signer certs stack in CertDb\r
+        //\r
+        if ((CertStackSize != CertsSizeinDb) ||\r
+            (CompareMem (SignerCerts, CertsInCertDb, CertsSizeinDb) != 0))\r
+        {\r
+          goto Exit;\r
+        }\r
       }\r
     }\r
 \r
@@ -2150,23 +2175,23 @@ VerifyTimeBasedPayload (
       // When adding a new common authenticated variable, always save Hash of cn of signer cert + tbsCertificate of Top-level issuer\r
       //\r
       CertDataPtr = (EFI_CERT_DATA *)(SignerCerts + 1);\r
-      Status = InsertCertsToDb (\r
-                 VariableName,\r
-                 VendorGuid,\r
-                 Attributes,\r
-                 CertDataPtr->CertDataBuffer,\r
-                 ReadUnaligned32 ((UINT32 *)&(CertDataPtr->CertDataLength)),\r
-                 TopLevelCert,\r
-                 TopLevelCertSize\r
-                 );\r
+      Status      = InsertCertsToDb (\r
+                      VariableName,\r
+                      VendorGuid,\r
+                      Attributes,\r
+                      CertDataPtr->CertDataBuffer,\r
+                      ReadUnaligned32 ((UINT32 *)&(CertDataPtr->CertDataLength)),\r
+                      TopLevelCert,\r
+                      TopLevelCertSize\r
+                      );\r
       if (EFI_ERROR (Status)) {\r
         VerifyStatus = FALSE;\r
         goto Exit;\r
       }\r
     }\r
   } else if (AuthVarType == AuthVarTypePayload) {\r
-    CertList = (EFI_SIGNATURE_LIST *) PayloadPtr;\r
-    Cert     = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+    CertList        = (EFI_SIGNATURE_LIST *)PayloadPtr;\r
+    Cert            = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
     TrustedCert     = Cert->SignatureData;\r
     TrustedCertSize = CertList->SignatureSize - (sizeof (EFI_SIGNATURE_DATA) - 1);\r
     //\r
@@ -2186,12 +2211,13 @@ VerifyTimeBasedPayload (
 \r
 Exit:\r
 \r
-  if (AuthVarType == AuthVarTypePk || AuthVarType == AuthVarTypePriv) {\r
+  if ((AuthVarType == AuthVarTypePk) || (AuthVarType == AuthVarTypePriv)) {\r
     if (TopLevelCert != NULL) {\r
-        Pkcs7FreeSigners (TopLevelCert);\r
+      Pkcs7FreeSigners (TopLevelCert);\r
     }\r
+\r
     if (SignerCerts != NULL) {\r
-        Pkcs7FreeSigners (SignerCerts);\r
+      Pkcs7FreeSigners (SignerCerts);\r
     }\r
   }\r
 \r
@@ -2199,12 +2225,12 @@ Exit:
     return EFI_SECURITY_VIOLATION;\r
   }\r
 \r
-  Status = CheckSignatureListFormat(VariableName, VendorGuid, PayloadPtr, PayloadSize);\r
+  Status = CheckSignatureListFormat (VariableName, VendorGuid, PayloadPtr, PayloadSize);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  *VarPayloadPtr = PayloadPtr;\r
+  *VarPayloadPtr  = PayloadPtr;\r
   *VarPayloadSize = PayloadSize;\r
 \r
   return EFI_SUCCESS;\r
@@ -2238,29 +2264,29 @@ Exit:
 **/\r
 EFI_STATUS\r
 VerifyTimeBasedPayloadAndUpdate (\r
-  IN     CHAR16                             *VariableName,\r
-  IN     EFI_GUID                           *VendorGuid,\r
-  IN     VOID                               *Data,\r
-  IN     UINTN                              DataSize,\r
-  IN     UINT32                             Attributes,\r
-  IN     AUTHVAR_TYPE                       AuthVarType,\r
-  OUT    BOOLEAN                            *VarDel\r
+  IN     CHAR16        *VariableName,\r
+  IN     EFI_GUID      *VendorGuid,\r
+  IN     VOID          *Data,\r
+  IN     UINTN         DataSize,\r
+  IN     UINT32        Attributes,\r
+  IN     AUTHVAR_TYPE  AuthVarType,\r
+  OUT    BOOLEAN       *VarDel\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
-  EFI_STATUS                       FindStatus;\r
-  UINT8                            *PayloadPtr;\r
-  UINTN                            PayloadSize;\r
-  EFI_VARIABLE_AUTHENTICATION_2    *CertData;\r
-  AUTH_VARIABLE_INFO               OrgVariableInfo;\r
-  BOOLEAN                          IsDel;\r
+  EFI_STATUS                     Status;\r
+  EFI_STATUS                     FindStatus;\r
+  UINT8                          *PayloadPtr;\r
+  UINTN                          PayloadSize;\r
+  EFI_VARIABLE_AUTHENTICATION_2  *CertData;\r
+  AUTH_VARIABLE_INFO             OrgVariableInfo;\r
+  BOOLEAN                        IsDel;\r
 \r
   ZeroMem (&OrgVariableInfo, sizeof (OrgVariableInfo));\r
   FindStatus = mAuthVarLibContextIn->FindVariable (\r
-             VariableName,\r
-             VendorGuid,\r
-             &OrgVariableInfo\r
-             );\r
+                                       VariableName,\r
+                                       VendorGuid,\r
+                                       &OrgVariableInfo\r
+                                       );\r
 \r
   Status = VerifyTimeBasedPayload (\r
              VariableName,\r
@@ -2277,15 +2303,16 @@ VerifyTimeBasedPayloadAndUpdate (
     return Status;\r
   }\r
 \r
-  if (!EFI_ERROR(FindStatus)\r
-   && (PayloadSize == 0)\r
-   && ((Attributes & EFI_VARIABLE_APPEND_WRITE) == 0)) {\r
+  if (  !EFI_ERROR (FindStatus)\r
+     && (PayloadSize == 0)\r
+     && ((Attributes & EFI_VARIABLE_APPEND_WRITE) == 0))\r
+  {\r
     IsDel = TRUE;\r
   } else {\r
     IsDel = FALSE;\r
   }\r
 \r
-  CertData = (EFI_VARIABLE_AUTHENTICATION_2 *) Data;\r
+  CertData = (EFI_VARIABLE_AUTHENTICATION_2 *)Data;\r
 \r
   //\r
   // Final step: Update/Append Variable if it pass Pkcs7Verify\r
@@ -2302,12 +2329,12 @@ VerifyTimeBasedPayloadAndUpdate (
   //\r
   // Delete signer's certificates when delete the common authenticated variable.\r
   //\r
-  if (IsDel && AuthVarType == AuthVarTypePriv && !EFI_ERROR(Status) ) {\r
+  if (IsDel && (AuthVarType == AuthVarTypePriv) && !EFI_ERROR (Status)) {\r
     Status = DeleteCertsFromDb (VariableName, VendorGuid, Attributes);\r
   }\r
 \r
   if (VarDel != NULL) {\r
-    if (IsDel && !EFI_ERROR(Status)) {\r
+    if (IsDel && !EFI_ERROR (Status)) {\r
       *VarDel = TRUE;\r
     } else {\r
       *VarDel = FALSE;\r
index 2bec637f75bd712a4844ac2a0410cf46d0ba3fee..b202e613bc6779f41a1d289897e2295312d308f9 100644 (file)
@@ -31,7 +31,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Guid/AuthenticatedVariableFormat.h>\r
 #include <Guid/ImageAuthentication.h>\r
 \r
-#define TWO_BYTE_ENCODE       0x82\r
+#define TWO_BYTE_ENCODE  0x82\r
 \r
 ///\r
 /// Struct to record signature requirement defined by UEFI spec.\r
@@ -73,8 +73,8 @@ typedef enum {
 /// | AUTH_CERT_DB_DATA          | <-- Last CERT\r
 /// +----------------------------+\r
 ///\r
-#define EFI_CERT_DB_NAME                 L"certdb"\r
-#define EFI_CERT_DB_VOLATILE_NAME        L"certdbv"\r
+#define EFI_CERT_DB_NAME           L"certdb"\r
+#define EFI_CERT_DB_VOLATILE_NAME  L"certdbv"\r
 \r
 #pragma pack(1)\r
 typedef struct {\r
@@ -87,15 +87,14 @@ typedef struct {
 } AUTH_CERT_DB_DATA;\r
 #pragma pack()\r
 \r
-extern UINT8    *mCertDbStore;\r
-extern UINT32   mMaxCertDbSize;\r
-extern UINT32   mPlatformMode;\r
-extern UINT8    mVendorKeyState;\r
+extern UINT8   *mCertDbStore;\r
+extern UINT32  mMaxCertDbSize;\r
+extern UINT32  mPlatformMode;\r
+extern UINT8   mVendorKeyState;\r
 \r
-extern VOID     *mHashCtx;\r
-\r
-extern AUTH_VAR_LIB_CONTEXT_IN *mAuthVarLibContextIn;\r
+extern VOID  *mHashCtx;\r
 \r
+extern AUTH_VAR_LIB_CONTEXT_IN  *mAuthVarLibContextIn;\r
 \r
 /**\r
   Process variable with EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS set\r
@@ -125,13 +124,13 @@ extern AUTH_VAR_LIB_CONTEXT_IN *mAuthVarLibContextIn;
 **/\r
 EFI_STATUS\r
 VerifyTimeBasedPayloadAndUpdate (\r
-  IN     CHAR16                             *VariableName,\r
-  IN     EFI_GUID                           *VendorGuid,\r
-  IN     VOID                               *Data,\r
-  IN     UINTN                              DataSize,\r
-  IN     UINT32                             Attributes,\r
-  IN     AUTHVAR_TYPE                       AuthVarType,\r
-  OUT    BOOLEAN                            *VarDel\r
+  IN     CHAR16        *VariableName,\r
+  IN     EFI_GUID      *VendorGuid,\r
+  IN     VOID          *Data,\r
+  IN     UINTN         DataSize,\r
+  IN     UINT32        Attributes,\r
+  IN     AUTHVAR_TYPE  AuthVarType,\r
+  OUT    BOOLEAN       *VarDel\r
   );\r
 \r
 /**\r
@@ -151,9 +150,9 @@ VerifyTimeBasedPayloadAndUpdate (
 **/\r
 EFI_STATUS\r
 DeleteCertsFromDb (\r
-  IN     CHAR16           *VariableName,\r
-  IN     EFI_GUID         *VendorGuid,\r
-  IN     UINT32           Attributes\r
+  IN     CHAR16    *VariableName,\r
+  IN     EFI_GUID  *VendorGuid,\r
+  IN     UINT32    Attributes\r
   );\r
 \r
 /**\r
@@ -183,10 +182,10 @@ CleanCertsFromDb (
 **/\r
 EFI_STATUS\r
 FilterSignatureList (\r
-  IN     VOID       *Data,\r
-  IN     UINTN      DataSize,\r
-  IN OUT VOID       *NewData,\r
-  IN OUT UINTN      *NewDataSize\r
+  IN     VOID   *Data,\r
+  IN     UINTN  DataSize,\r
+  IN OUT VOID   *NewData,\r
+  IN OUT UINTN  *NewDataSize\r
   );\r
 \r
 /**\r
@@ -215,12 +214,12 @@ FilterSignatureList (
 **/\r
 EFI_STATUS\r
 ProcessVarWithPk (\r
-  IN  CHAR16                    *VariableName,\r
-  IN  EFI_GUID                  *VendorGuid,\r
-  IN  VOID                      *Data,\r
-  IN  UINTN                     DataSize,\r
-  IN  UINT32                    Attributes OPTIONAL,\r
-  IN  BOOLEAN                   IsPk\r
+  IN  CHAR16    *VariableName,\r
+  IN  EFI_GUID  *VendorGuid,\r
+  IN  VOID      *Data,\r
+  IN  UINTN     DataSize,\r
+  IN  UINT32    Attributes OPTIONAL,\r
+  IN  BOOLEAN   IsPk\r
   );\r
 \r
 /**\r
@@ -248,11 +247,11 @@ ProcessVarWithPk (
 **/\r
 EFI_STATUS\r
 ProcessVarWithKek (\r
-  IN  CHAR16                               *VariableName,\r
-  IN  EFI_GUID                             *VendorGuid,\r
-  IN  VOID                                 *Data,\r
-  IN  UINTN                                DataSize,\r
-  IN  UINT32                               Attributes OPTIONAL\r
+  IN  CHAR16    *VariableName,\r
+  IN  EFI_GUID  *VendorGuid,\r
+  IN  VOID      *Data,\r
+  IN  UINTN     DataSize,\r
+  IN  UINT32    Attributes OPTIONAL\r
   );\r
 \r
 /**\r
@@ -283,11 +282,11 @@ ProcessVarWithKek (
 **/\r
 EFI_STATUS\r
 ProcessVariable (\r
-  IN     CHAR16                             *VariableName,\r
-  IN     EFI_GUID                           *VendorGuid,\r
-  IN     VOID                               *Data,\r
-  IN     UINTN                              DataSize,\r
-  IN     UINT32                             Attributes\r
+  IN     CHAR16    *VariableName,\r
+  IN     EFI_GUID  *VendorGuid,\r
+  IN     VOID      *Data,\r
+  IN     UINTN     DataSize,\r
+  IN     UINT32    Attributes\r
   );\r
 \r
 /**\r
@@ -310,10 +309,10 @@ ProcessVariable (
 **/\r
 EFI_STATUS\r
 AuthServiceInternalFindVariable (\r
-  IN  CHAR16        *VariableName,\r
-  IN  EFI_GUID      *VendorGuid,\r
-  OUT VOID          **Data,\r
-  OUT UINTN         *DataSize\r
+  IN  CHAR16    *VariableName,\r
+  IN  EFI_GUID  *VendorGuid,\r
+  OUT VOID      **Data,\r
+  OUT UINTN     *DataSize\r
   );\r
 \r
 /**\r
@@ -333,11 +332,11 @@ AuthServiceInternalFindVariable (
 **/\r
 EFI_STATUS\r
 AuthServiceInternalUpdateVariable (\r
-  IN CHAR16         *VariableName,\r
-  IN EFI_GUID       *VendorGuid,\r
-  IN VOID           *Data,\r
-  IN UINTN          DataSize,\r
-  IN UINT32         Attributes\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN VOID      *Data,\r
+  IN UINTN     DataSize,\r
+  IN UINT32    Attributes\r
   );\r
 \r
 /**\r
@@ -358,12 +357,12 @@ AuthServiceInternalUpdateVariable (
 **/\r
 EFI_STATUS\r
 AuthServiceInternalUpdateVariableWithTimeStamp (\r
-  IN CHAR16         *VariableName,\r
-  IN EFI_GUID       *VendorGuid,\r
-  IN VOID           *Data,\r
-  IN UINTN          DataSize,\r
-  IN UINT32         Attributes,\r
-  IN EFI_TIME       *TimeStamp\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN VOID      *Data,\r
+  IN UINTN     DataSize,\r
+  IN UINT32    Attributes,\r
+  IN EFI_TIME  *TimeStamp\r
   );\r
 \r
 #endif\r
index 7f31458edbd3f9bc42a31966565970ce49692f58..dc61ae840c3d21a42abe180613d3b928b2224fb1 100644 (file)
@@ -21,19 +21,19 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 ///\r
 /// Global database array for scratch\r
 ///\r
-UINT8    *mCertDbStore;\r
-UINT32   mMaxCertDbSize;\r
-UINT32   mPlatformMode;\r
-UINT8    mVendorKeyState;\r
+UINT8   *mCertDbStore;\r
+UINT32  mMaxCertDbSize;\r
+UINT32  mPlatformMode;\r
+UINT8   mVendorKeyState;\r
 \r
-EFI_GUID mSignatureSupport[] = {EFI_CERT_SHA1_GUID, EFI_CERT_SHA256_GUID, EFI_CERT_RSA2048_GUID, EFI_CERT_X509_GUID};\r
+EFI_GUID  mSignatureSupport[] = { EFI_CERT_SHA1_GUID, EFI_CERT_SHA256_GUID, EFI_CERT_RSA2048_GUID, EFI_CERT_X509_GUID };\r
 \r
 //\r
 // Hash context pointer\r
 //\r
 VOID  *mHashCtx = NULL;\r
 \r
-VARIABLE_ENTRY_PROPERTY mAuthVarEntry[] = {\r
+VARIABLE_ENTRY_PROPERTY  mAuthVarEntry[] = {\r
   {\r
     &gEfiSecureBootEnableDisableGuid,\r
     EFI_SECURE_BOOT_ENABLE_NAME,\r
@@ -91,9 +91,9 @@ VARIABLE_ENTRY_PROPERTY mAuthVarEntry[] = {
   },\r
 };\r
 \r
-VOID **mAuthVarAddressPointer[9];\r
+VOID  **mAuthVarAddressPointer[9];\r
 \r
-AUTH_VAR_LIB_CONTEXT_IN *mAuthVarLibContextIn = NULL;\r
+AUTH_VAR_LIB_CONTEXT_IN  *mAuthVarLibContextIn = NULL;\r
 \r
 /**\r
   Initialization for authenticated variable services.\r
@@ -116,15 +116,15 @@ AuthVariableLibInitialize (
   OUT AUTH_VAR_LIB_CONTEXT_OUT  *AuthVarLibContextOut\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  UINT32                VarAttr;\r
-  UINT8                 *Data;\r
-  UINTN                 DataSize;\r
-  UINTN                 CtxSize;\r
-  UINT8                 SecureBootMode;\r
-  UINT8                 SecureBootEnable;\r
-  UINT8                 CustomMode;\r
-  UINT32                ListSize;\r
+  EFI_STATUS  Status;\r
+  UINT32      VarAttr;\r
+  UINT8       *Data;\r
+  UINTN       DataSize;\r
+  UINTN       CtxSize;\r
+  UINT8       SecureBootMode;\r
+  UINT8       SecureBootEnable;\r
+  UINT8       CustomMode;\r
+  UINT32      ListSize;\r
 \r
   if ((AuthVarLibContextIn == NULL) || (AuthVarLibContextOut == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -135,8 +135,8 @@ AuthVariableLibInitialize (
   //\r
   // Initialize hash context.\r
   //\r
-  CtxSize   = Sha256GetContextSize ();\r
-  mHashCtx  = AllocateRuntimePool (CtxSize);\r
+  CtxSize  = Sha256GetContextSize ();\r
+  mHashCtx = AllocateRuntimePool (CtxSize);\r
   if (mHashCtx == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
@@ -145,13 +145,13 @@ AuthVariableLibInitialize (
   // Reserve runtime buffer for certificate database. The size excludes variable header and name size.\r
   // Use EFI_CERT_DB_VOLATILE_NAME size since it is longer.\r
   //\r
-  mMaxCertDbSize = (UINT32) (mAuthVarLibContextIn->MaxAuthVariableSize - sizeof (EFI_CERT_DB_VOLATILE_NAME));\r
+  mMaxCertDbSize = (UINT32)(mAuthVarLibContextIn->MaxAuthVariableSize - sizeof (EFI_CERT_DB_VOLATILE_NAME));\r
   mCertDbStore   = AllocateRuntimePool (mMaxCertDbSize);\r
   if (mCertDbStore == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  Status = AuthServiceInternalFindVariable (EFI_PLATFORM_KEY_NAME, &gEfiGlobalVariableGuid, (VOID **) &Data, &DataSize);\r
+  Status = AuthServiceInternalFindVariable (EFI_PLATFORM_KEY_NAME, &gEfiGlobalVariableGuid, (VOID **)&Data, &DataSize);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_INFO, "Variable %s does not exist.\n", EFI_PLATFORM_KEY_NAME));\r
   } else {\r
@@ -166,11 +166,12 @@ AuthVariableLibInitialize (
   } else {\r
     mPlatformMode = USER_MODE;\r
   }\r
+\r
   Status = AuthServiceInternalUpdateVariable (\r
              EFI_SETUP_MODE_NAME,\r
              &gEfiGlobalVariableGuid,\r
              &mPlatformMode,\r
-             sizeof(UINT8),\r
+             sizeof (UINT8),\r
              EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS\r
              );\r
   if (EFI_ERROR (Status)) {\r
@@ -180,13 +181,13 @@ AuthVariableLibInitialize (
   //\r
   // Create "SignatureSupport" variable with BS+RT attribute set.\r
   //\r
-  Status  = AuthServiceInternalUpdateVariable (\r
-              EFI_SIGNATURE_SUPPORT_NAME,\r
-              &gEfiGlobalVariableGuid,\r
-              mSignatureSupport,\r
-              sizeof(mSignatureSupport),\r
-              EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS\r
-              );\r
+  Status = AuthServiceInternalUpdateVariable (\r
+             EFI_SIGNATURE_SUPPORT_NAME,\r
+             &gEfiGlobalVariableGuid,\r
+             mSignatureSupport,\r
+             sizeof (mSignatureSupport),\r
+             EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS\r
+             );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -197,23 +198,23 @@ AuthVariableLibInitialize (
   // If "SecureBootEnable" variable is SECURE_BOOT_DISABLE, Set "SecureBoot" variable to SECURE_BOOT_MODE_DISABLE.\r
   //\r
   SecureBootEnable = SECURE_BOOT_DISABLE;\r
-  Status = AuthServiceInternalFindVariable (EFI_SECURE_BOOT_ENABLE_NAME, &gEfiSecureBootEnableDisableGuid, (VOID **) &Data, &DataSize);\r
+  Status           = AuthServiceInternalFindVariable (EFI_SECURE_BOOT_ENABLE_NAME, &gEfiSecureBootEnableDisableGuid, (VOID **)&Data, &DataSize);\r
   if (!EFI_ERROR (Status)) {\r
-    if (mPlatformMode == USER_MODE){\r
-      SecureBootEnable = *(UINT8 *) Data;\r
+    if (mPlatformMode == USER_MODE) {\r
+      SecureBootEnable = *(UINT8 *)Data;\r
     }\r
   } else if (mPlatformMode == USER_MODE) {\r
     //\r
     // "SecureBootEnable" not exist, initialize it in USER_MODE.\r
     //\r
     SecureBootEnable = SECURE_BOOT_ENABLE;\r
-    Status = AuthServiceInternalUpdateVariable (\r
-               EFI_SECURE_BOOT_ENABLE_NAME,\r
-               &gEfiSecureBootEnableDisableGuid,\r
-               &SecureBootEnable,\r
-               sizeof (UINT8),\r
-               EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS\r
-               );\r
+    Status           = AuthServiceInternalUpdateVariable (\r
+                         EFI_SECURE_BOOT_ENABLE_NAME,\r
+                         &gEfiSecureBootEnableDisableGuid,\r
+                         &SecureBootEnable,\r
+                         sizeof (UINT8),\r
+                         EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS\r
+                         );\r
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
@@ -222,11 +223,12 @@ AuthVariableLibInitialize (
   //\r
   // Create "SecureBoot" variable with BS+RT attribute set.\r
   //\r
-  if (SecureBootEnable == SECURE_BOOT_ENABLE && mPlatformMode == USER_MODE) {\r
+  if ((SecureBootEnable == SECURE_BOOT_ENABLE) && (mPlatformMode == USER_MODE)) {\r
     SecureBootMode = SECURE_BOOT_MODE_ENABLE;\r
   } else {\r
     SecureBootMode = SECURE_BOOT_MODE_DISABLE;\r
   }\r
+\r
   Status = AuthServiceInternalUpdateVariable (\r
              EFI_SECURE_BOOT_MODE_NAME,\r
              &gEfiGlobalVariableGuid,\r
@@ -246,13 +248,13 @@ AuthVariableLibInitialize (
   // Initialize "CustomMode" in STANDARD_SECURE_BOOT_MODE state.\r
   //\r
   CustomMode = STANDARD_SECURE_BOOT_MODE;\r
-  Status = AuthServiceInternalUpdateVariable (\r
-             EFI_CUSTOM_MODE_NAME,\r
-             &gEfiCustomModeEnableGuid,\r
-             &CustomMode,\r
-             sizeof (UINT8),\r
-             EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS\r
-             );\r
+  Status     = AuthServiceInternalUpdateVariable (\r
+                 EFI_CUSTOM_MODE_NAME,\r
+                 &gEfiCustomModeEnableGuid,\r
+                 &CustomMode,\r
+                 sizeof (UINT8),\r
+                 EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS\r
+                 );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -267,7 +269,7 @@ AuthVariableLibInitialize (
   Status = AuthServiceInternalFindVariable (\r
              EFI_CERT_DB_NAME,\r
              &gEfiCertDbGuid,\r
-             (VOID **) &Data,\r
+             (VOID **)&Data,\r
              &DataSize\r
              );\r
   if (EFI_ERROR (Status)) {\r
@@ -287,7 +289,7 @@ AuthVariableLibInitialize (
     //\r
     // Clean up Certs to make certDB & Time based auth variable consistent\r
     //\r
-    Status = CleanCertsFromDb();\r
+    Status = CleanCertsFromDb ();\r
     if (EFI_ERROR (Status)) {\r
       DEBUG ((DEBUG_ERROR, "Clean up CertDB fail! Status %x\n", Status));\r
       return Status;\r
@@ -313,7 +315,7 @@ AuthVariableLibInitialize (
   //\r
   // Check "VendorKeysNv" variable's existence and create "VendorKeys" variable accordingly.\r
   //\r
-  Status = AuthServiceInternalFindVariable (EFI_VENDOR_KEYS_NV_VARIABLE_NAME, &gEfiVendorKeysNvGuid, (VOID **) &Data, &DataSize);\r
+  Status = AuthServiceInternalFindVariable (EFI_VENDOR_KEYS_NV_VARIABLE_NAME, &gEfiVendorKeysNvGuid, (VOID **)&Data, &DataSize);\r
   if (!EFI_ERROR (Status)) {\r
     mVendorKeyState = *(UINT8 *)Data;\r
   } else {\r
@@ -321,13 +323,13 @@ AuthVariableLibInitialize (
     // "VendorKeysNv" not exist, initialize it in VENDOR_KEYS_VALID state.\r
     //\r
     mVendorKeyState = VENDOR_KEYS_VALID;\r
-    Status = AuthServiceInternalUpdateVariable (\r
-               EFI_VENDOR_KEYS_NV_VARIABLE_NAME,\r
-               &gEfiVendorKeysNvGuid,\r
-               &mVendorKeyState,\r
-               sizeof (UINT8),\r
-               EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS\r
-               );\r
+    Status          = AuthServiceInternalUpdateVariable (\r
+                        EFI_VENDOR_KEYS_NV_VARIABLE_NAME,\r
+                        &gEfiVendorKeysNvGuid,\r
+                        &mVendorKeyState,\r
+                        sizeof (UINT8),\r
+                        EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS\r
+                        );\r
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
@@ -349,20 +351,20 @@ AuthVariableLibInitialize (
 \r
   DEBUG ((DEBUG_INFO, "Variable %s is %x\n", EFI_VENDOR_KEYS_VARIABLE_NAME, mVendorKeyState));\r
 \r
-  AuthVarLibContextOut->StructVersion = AUTH_VAR_LIB_CONTEXT_OUT_STRUCT_VERSION;\r
-  AuthVarLibContextOut->StructSize = sizeof (AUTH_VAR_LIB_CONTEXT_OUT);\r
-  AuthVarLibContextOut->AuthVarEntry = mAuthVarEntry;\r
-  AuthVarLibContextOut->AuthVarEntryCount = ARRAY_SIZE (mAuthVarEntry);\r
-  mAuthVarAddressPointer[0] = (VOID **) &mCertDbStore;\r
-  mAuthVarAddressPointer[1] = (VOID **) &mHashCtx;\r
-  mAuthVarAddressPointer[2] = (VOID **) &mAuthVarLibContextIn;\r
-  mAuthVarAddressPointer[3] = (VOID **) &(mAuthVarLibContextIn->FindVariable),\r
-  mAuthVarAddressPointer[4] = (VOID **) &(mAuthVarLibContextIn->FindNextVariable),\r
-  mAuthVarAddressPointer[5] = (VOID **) &(mAuthVarLibContextIn->UpdateVariable),\r
-  mAuthVarAddressPointer[6] = (VOID **) &(mAuthVarLibContextIn->GetScratchBuffer),\r
-  mAuthVarAddressPointer[7] = (VOID **) &(mAuthVarLibContextIn->CheckRemainingSpaceForConsistency),\r
-  mAuthVarAddressPointer[8] = (VOID **) &(mAuthVarLibContextIn->AtRuntime),\r
-  AuthVarLibContextOut->AddressPointer = mAuthVarAddressPointer;\r
+  AuthVarLibContextOut->StructVersion       = AUTH_VAR_LIB_CONTEXT_OUT_STRUCT_VERSION;\r
+  AuthVarLibContextOut->StructSize          = sizeof (AUTH_VAR_LIB_CONTEXT_OUT);\r
+  AuthVarLibContextOut->AuthVarEntry        = mAuthVarEntry;\r
+  AuthVarLibContextOut->AuthVarEntryCount   = ARRAY_SIZE (mAuthVarEntry);\r
+  mAuthVarAddressPointer[0]                 = (VOID **)&mCertDbStore;\r
+  mAuthVarAddressPointer[1]                 = (VOID **)&mHashCtx;\r
+  mAuthVarAddressPointer[2]                 = (VOID **)&mAuthVarLibContextIn;\r
+  mAuthVarAddressPointer[3]                 = (VOID **)&(mAuthVarLibContextIn->FindVariable),\r
+  mAuthVarAddressPointer[4]                 = (VOID **)&(mAuthVarLibContextIn->FindNextVariable),\r
+  mAuthVarAddressPointer[5]                 = (VOID **)&(mAuthVarLibContextIn->UpdateVariable),\r
+  mAuthVarAddressPointer[6]                 = (VOID **)&(mAuthVarLibContextIn->GetScratchBuffer),\r
+  mAuthVarAddressPointer[7]                 = (VOID **)&(mAuthVarLibContextIn->CheckRemainingSpaceForConsistency),\r
+  mAuthVarAddressPointer[8]                 = (VOID **)&(mAuthVarLibContextIn->AtRuntime),\r
+  AuthVarLibContextOut->AddressPointer      = mAuthVarAddressPointer;\r
   AuthVarLibContextOut->AddressPointerCount = ARRAY_SIZE (mAuthVarAddressPointer);\r
 \r
   return Status;\r
@@ -391,16 +393,16 @@ AuthVariableLibInitialize (
 EFI_STATUS\r
 EFIAPI\r
 AuthVariableLibProcessVariable (\r
-  IN CHAR16         *VariableName,\r
-  IN EFI_GUID       *VendorGuid,\r
-  IN VOID           *Data,\r
-  IN UINTN          DataSize,\r
-  IN UINT32         Attributes\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN VOID      *Data,\r
+  IN UINTN     DataSize,\r
+  IN UINT32    Attributes\r
   )\r
 {\r
-  EFI_STATUS        Status;\r
+  EFI_STATUS  Status;\r
 \r
-  if (CompareGuid (VendorGuid, &gEfiGlobalVariableGuid) && (StrCmp (VariableName, EFI_PLATFORM_KEY_NAME) == 0)){\r
+  if (CompareGuid (VendorGuid, &gEfiGlobalVariableGuid) && (StrCmp (VariableName, EFI_PLATFORM_KEY_NAME) == 0)) {\r
     Status = ProcessVarWithPk (VariableName, VendorGuid, Data, DataSize, Attributes, TRUE);\r
   } else if (CompareGuid (VendorGuid, &gEfiGlobalVariableGuid) && (StrCmp (VariableName, EFI_KEY_EXCHANGE_KEY_NAME) == 0)) {\r
     Status = ProcessVarWithPk (VariableName, VendorGuid, Data, DataSize, Attributes, FALSE);\r
@@ -408,7 +410,8 @@ AuthVariableLibProcessVariable (
              ((StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE)  == 0) ||\r
               (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE1) == 0) ||\r
               (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE2) == 0)\r
-             )) {\r
+             ))\r
+  {\r
     Status = ProcessVarWithPk (VariableName, VendorGuid, Data, DataSize, Attributes, FALSE);\r
     if (EFI_ERROR (Status)) {\r
       Status = ProcessVarWithKek (VariableName, VendorGuid, Data, DataSize, Attributes);\r
index 9acff2ae7d5d011636040f22037855f41978aec6..7d1993ec87438de5f3e3d7c07d81bf540825f40d 100644 (file)
@@ -9,7 +9,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <PiDxe.h>\r
 #include <Library/SecurityManagementLib.h>\r
 \r
-\r
 /**\r
   Check image authentication status returned from Section Extraction Protocol\r
 \r
@@ -31,11 +30,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 DxeImageAuthenticationStatusHandler (\r
-  IN  UINT32                           AuthenticationStatus,\r
-  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File  OPTIONAL,\r
-  IN  VOID                             *FileBuffer,\r
-  IN  UINTN                            FileSize,\r
-  IN  BOOLEAN                          BootPolicy\r
+  IN  UINT32                          AuthenticationStatus,\r
+  IN  CONST EFI_DEVICE_PATH_PROTOCOL  *File  OPTIONAL,\r
+  IN  VOID                            *FileBuffer,\r
+  IN  UINTN                           FileSize,\r
+  IN  BOOLEAN                         BootPolicy\r
   )\r
 {\r
   if ((AuthenticationStatus & EFI_AUTH_STATUS_IMAGE_SIGNED) != 0) {\r
@@ -47,7 +46,6 @@ DxeImageAuthenticationStatusHandler (
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Register image authentication status check handler.\r
 \r
index 77b0e764a5aa668286a436668c84cf74244b27a9..66e2f5eaa3c0380c88aa397aa150c8950e99c583 100644 (file)
@@ -24,17 +24,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Caution: This is used by a function which may receive untrusted input.\r
 // These global variables hold PE/COFF image data, and they should be validated before use.\r
 //\r
-EFI_IMAGE_OPTIONAL_HEADER_PTR_UNION mNtHeader;\r
-UINT32                              mPeCoffHeaderOffset;\r
-EFI_GUID                            mCertType;\r
+EFI_IMAGE_OPTIONAL_HEADER_PTR_UNION  mNtHeader;\r
+UINT32                               mPeCoffHeaderOffset;\r
+EFI_GUID                             mCertType;\r
 \r
 //\r
 // Information on current PE/COFF image\r
 //\r
-UINTN                               mImageSize;\r
-UINT8                               *mImageBase       = NULL;\r
-UINT8                               mImageDigest[MAX_DIGEST_SIZE];\r
-UINTN                               mImageDigestSize;\r
+UINTN  mImageSize;\r
+UINT8  *mImageBase = NULL;\r
+UINT8  mImageDigest[MAX_DIGEST_SIZE];\r
+UINTN  mImageDigestSize;\r
 \r
 //\r
 // Notify string for authorization UI.\r
@@ -44,33 +44,32 @@ CHAR16  mNotifyString2[MAX_NOTIFY_STRING_LEN] = L"Launch this image anyway? (Yes
 //\r
 // Public Exponent of RSA Key.\r
 //\r
-CONST UINT8 mRsaE[] = { 0x01, 0x00, 0x01 };\r
-\r
+CONST UINT8  mRsaE[] = { 0x01, 0x00, 0x01 };\r
 \r
 //\r
 // OID ASN.1 Value for Hash Algorithms\r
 //\r
-UINT8 mHashOidValue[] = {\r
-  0x2B, 0x0E, 0x03, 0x02, 0x1A,                           // OBJ_sha1\r
-  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x04,   // OBJ_sha224\r
-  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x01,   // OBJ_sha256\r
-  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x02,   // OBJ_sha384\r
-  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x03,   // OBJ_sha512\r
-  };\r
-\r
-HASH_TABLE mHash[] = {\r
-#ifndef DISABLE_SHA1_DEPRECATED_INTERFACES\r
-  { L"SHA1",   20, &mHashOidValue[0],  5, Sha1GetContextSize,   Sha1Init,   Sha1Update,   Sha1Final  },\r
-#else\r
-  { L"SHA1",   20, &mHashOidValue[0],  5, NULL,                 NULL,       NULL,         NULL       },\r
-#endif\r
-  { L"SHA224", 28, &mHashOidValue[5],  9, NULL,                 NULL,       NULL,         NULL       },\r
-  { L"SHA256", 32, &mHashOidValue[14], 9, Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final},\r
-  { L"SHA384", 48, &mHashOidValue[23], 9, Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final},\r
-  { L"SHA512", 64, &mHashOidValue[32], 9, Sha512GetContextSize, Sha512Init, Sha512Update, Sha512Final}\r
+UINT8  mHashOidValue[] = {\r
+  0x2B, 0x0E, 0x03, 0x02, 0x1A,                         // OBJ_sha1\r
+  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x04, // OBJ_sha224\r
+  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x01, // OBJ_sha256\r
+  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x02, // OBJ_sha384\r
+  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x03, // OBJ_sha512\r
+};\r
+\r
+HASH_TABLE  mHash[] = {\r
+ #ifndef DISABLE_SHA1_DEPRECATED_INTERFACES\r
+  { L"SHA1",   20, &mHashOidValue[0],  5, Sha1GetContextSize,   Sha1Init,   Sha1Update,   Sha1Final   },\r
+ #else\r
+  { L"SHA1",   20, &mHashOidValue[0],  5, NULL,                 NULL,       NULL,         NULL        },\r
+ #endif\r
+  { L"SHA224", 28, &mHashOidValue[5],  9, NULL,                 NULL,       NULL,         NULL        },\r
+  { L"SHA256", 32, &mHashOidValue[14], 9, Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },\r
+  { L"SHA384", 48, &mHashOidValue[23], 9, Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final },\r
+  { L"SHA512", 64, &mHashOidValue[32], 9, Sha512GetContextSize, Sha512Init, Sha512Update, Sha512Final }\r
 };\r
 \r
-EFI_STRING mHashTypeStr;\r
+EFI_STRING  mHashTypeStr;\r
 \r
 /**\r
   SecureBoot Hook for processing image verification.\r
@@ -85,10 +84,10 @@ EFI_STRING mHashTypeStr;
 VOID\r
 EFIAPI\r
 SecureBootHook (\r
-  IN CHAR16                                 *VariableName,\r
-  IN EFI_GUID                               *VendorGuid,\r
-  IN UINTN                                  DataSize,\r
-  IN VOID                                   *Data\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN UINTN     DataSize,\r
+  IN VOID      *Data\r
   );\r
 \r
 /**\r
@@ -109,15 +108,15 @@ SecureBootHook (
 EFI_STATUS\r
 EFIAPI\r
 DxeImageVerificationLibImageRead (\r
-  IN     VOID    *FileHandle,\r
-  IN     UINTN   FileOffset,\r
-  IN OUT UINTN   *ReadSize,\r
-  OUT    VOID    *Buffer\r
+  IN     VOID   *FileHandle,\r
+  IN     UINTN  FileOffset,\r
+  IN OUT UINTN  *ReadSize,\r
+  OUT    VOID   *Buffer\r
   )\r
 {\r
-  UINTN               EndPosition;\r
+  UINTN  EndPosition;\r
 \r
-  if (FileHandle == NULL || ReadSize == NULL || Buffer == NULL) {\r
+  if ((FileHandle == NULL) || (ReadSize == NULL) || (Buffer == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -134,12 +133,11 @@ DxeImageVerificationLibImageRead (
     *ReadSize = 0;\r
   }\r
 \r
-  CopyMem (Buffer, (UINT8 *)((UINTN) FileHandle + FileOffset), *ReadSize);\r
+  CopyMem (Buffer, (UINT8 *)((UINTN)FileHandle + FileOffset), *ReadSize);\r
 \r
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Get the image type.\r
 \r
@@ -151,13 +149,13 @@ DxeImageVerificationLibImageRead (
 **/\r
 UINT32\r
 GetImageType (\r
-  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File\r
+  IN  CONST EFI_DEVICE_PATH_PROTOCOL  *File\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_HANDLE                        DeviceHandle;\r
-  EFI_DEVICE_PATH_PROTOCOL          *TempDevicePath;\r
-  EFI_BLOCK_IO_PROTOCOL             *BlockIo;\r
+  EFI_STATUS                Status;\r
+  EFI_HANDLE                DeviceHandle;\r
+  EFI_DEVICE_PATH_PROTOCOL  *TempDevicePath;\r
+  EFI_BLOCK_IO_PROTOCOL     *BlockIo;\r
 \r
   if (File == NULL) {\r
     return IMAGE_UNKNOWN;\r
@@ -166,13 +164,13 @@ GetImageType (
   //\r
   // First check to see if File is from a Firmware Volume\r
   //\r
-  DeviceHandle      = NULL;\r
-  TempDevicePath = (EFI_DEVICE_PATH_PROTOCOL *) File;\r
-  Status = gBS->LocateDevicePath (\r
-                  &gEfiFirmwareVolume2ProtocolGuid,\r
-                  &TempDevicePath,\r
-                  &DeviceHandle\r
-                  );\r
+  DeviceHandle   = NULL;\r
+  TempDevicePath = (EFI_DEVICE_PATH_PROTOCOL *)File;\r
+  Status         = gBS->LocateDevicePath (\r
+                          &gEfiFirmwareVolume2ProtocolGuid,\r
+                          &TempDevicePath,\r
+                          &DeviceHandle\r
+                          );\r
   if (!EFI_ERROR (Status)) {\r
     Status = gBS->OpenProtocol (\r
                     DeviceHandle,\r
@@ -191,23 +189,23 @@ GetImageType (
   // Next check to see if File is from a Block I/O device\r
   //\r
   DeviceHandle   = NULL;\r
-  TempDevicePath = (EFI_DEVICE_PATH_PROTOCOL *) File;\r
-  Status = gBS->LocateDevicePath (\r
-                  &gEfiBlockIoProtocolGuid,\r
-                  &TempDevicePath,\r
-                  &DeviceHandle\r
-                  );\r
+  TempDevicePath = (EFI_DEVICE_PATH_PROTOCOL *)File;\r
+  Status         = gBS->LocateDevicePath (\r
+                          &gEfiBlockIoProtocolGuid,\r
+                          &TempDevicePath,\r
+                          &DeviceHandle\r
+                          );\r
   if (!EFI_ERROR (Status)) {\r
     BlockIo = NULL;\r
-    Status = gBS->OpenProtocol (\r
-                    DeviceHandle,\r
-                    &gEfiBlockIoProtocolGuid,\r
-                    (VOID **) &BlockIo,\r
-                    NULL,\r
-                    NULL,\r
-                    EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
-                    );\r
-    if (!EFI_ERROR (Status) && BlockIo != NULL) {\r
+    Status  = gBS->OpenProtocol (\r
+                     DeviceHandle,\r
+                     &gEfiBlockIoProtocolGuid,\r
+                     (VOID **)&BlockIo,\r
+                     NULL,\r
+                     NULL,\r
+                     EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
+                     );\r
+    if (!EFI_ERROR (Status) && (BlockIo != NULL)) {\r
       if (BlockIo->Media != NULL) {\r
         if (BlockIo->Media->RemovableMedia) {\r
           //\r
@@ -229,12 +227,12 @@ GetImageType (
   // the device path supports the Simple File System Protocol.\r
   //\r
   DeviceHandle   = NULL;\r
-  TempDevicePath = (EFI_DEVICE_PATH_PROTOCOL *) File;\r
-  Status = gBS->LocateDevicePath (\r
-                  &gEfiSimpleFileSystemProtocolGuid,\r
-                  &TempDevicePath,\r
-                  &DeviceHandle\r
-                  );\r
+  TempDevicePath = (EFI_DEVICE_PATH_PROTOCOL *)File;\r
+  Status         = gBS->LocateDevicePath (\r
+                          &gEfiSimpleFileSystemProtocolGuid,\r
+                          &TempDevicePath,\r
+                          &DeviceHandle\r
+                          );\r
   if (!EFI_ERROR (Status)) {\r
     //\r
     // Simple File System is present without Block I/O, so assume media is fixed.\r
@@ -246,27 +244,30 @@ GetImageType (
   // File is not from an FV, Block I/O or Simple File System, so the only options\r
   // left are a PCI Option ROM and a Load File Protocol such as a PXE Boot from a NIC.\r
   //\r
-  TempDevicePath = (EFI_DEVICE_PATH_PROTOCOL *) File;\r
+  TempDevicePath = (EFI_DEVICE_PATH_PROTOCOL *)File;\r
   while (!IsDevicePathEndType (TempDevicePath)) {\r
     switch (DevicePathType (TempDevicePath)) {\r
+      case MEDIA_DEVICE_PATH:\r
+        if (DevicePathSubType (TempDevicePath) == MEDIA_RELATIVE_OFFSET_RANGE_DP) {\r
+          return IMAGE_FROM_OPTION_ROM;\r
+        }\r
 \r
-    case MEDIA_DEVICE_PATH:\r
-      if (DevicePathSubType (TempDevicePath) == MEDIA_RELATIVE_OFFSET_RANGE_DP) {\r
-        return IMAGE_FROM_OPTION_ROM;\r
-      }\r
-      break;\r
+        break;\r
 \r
-    case MESSAGING_DEVICE_PATH:\r
-      if (DevicePathSubType(TempDevicePath) == MSG_MAC_ADDR_DP) {\r
-        return IMAGE_FROM_REMOVABLE_MEDIA;\r
-      }\r
-      break;\r
+      case MESSAGING_DEVICE_PATH:\r
+        if (DevicePathSubType (TempDevicePath) == MSG_MAC_ADDR_DP) {\r
+          return IMAGE_FROM_REMOVABLE_MEDIA;\r
+        }\r
 \r
-    default:\r
-      break;\r
+        break;\r
+\r
+      default:\r
+        break;\r
     }\r
+\r
     TempDevicePath = NextDevicePathNode (TempDevicePath);\r
   }\r
+\r
   return IMAGE_UNKNOWN;\r
 }\r
 \r
@@ -289,7 +290,7 @@ GetImageType (
 **/\r
 BOOLEAN\r
 HashPeImage (\r
-  IN  UINT32              HashAlg\r
+  IN  UINT32  HashAlg\r
   )\r
 {\r
   BOOLEAN                   Status;\r
@@ -319,34 +320,34 @@ HashPeImage (
   ZeroMem (mImageDigest, MAX_DIGEST_SIZE);\r
 \r
   switch (HashAlg) {\r
-#ifndef DISABLE_SHA1_DEPRECATED_INTERFACES\r
-  case HASHALG_SHA1:\r
-    mImageDigestSize = SHA1_DIGEST_SIZE;\r
-    mCertType        = gEfiCertSha1Guid;\r
-    break;\r
-#endif\r
-\r
-  case HASHALG_SHA256:\r
-    mImageDigestSize = SHA256_DIGEST_SIZE;\r
-    mCertType        = gEfiCertSha256Guid;\r
-    break;\r
-\r
-  case HASHALG_SHA384:\r
-    mImageDigestSize = SHA384_DIGEST_SIZE;\r
-    mCertType        = gEfiCertSha384Guid;\r
-    break;\r
-\r
-  case HASHALG_SHA512:\r
-    mImageDigestSize = SHA512_DIGEST_SIZE;\r
-    mCertType        = gEfiCertSha512Guid;\r
-    break;\r
-\r
-  default:\r
-    return FALSE;\r
+ #ifndef DISABLE_SHA1_DEPRECATED_INTERFACES\r
+    case HASHALG_SHA1:\r
+      mImageDigestSize = SHA1_DIGEST_SIZE;\r
+      mCertType        = gEfiCertSha1Guid;\r
+      break;\r
+ #endif\r
+\r
+    case HASHALG_SHA256:\r
+      mImageDigestSize = SHA256_DIGEST_SIZE;\r
+      mCertType        = gEfiCertSha256Guid;\r
+      break;\r
+\r
+    case HASHALG_SHA384:\r
+      mImageDigestSize = SHA384_DIGEST_SIZE;\r
+      mCertType        = gEfiCertSha384Guid;\r
+      break;\r
+\r
+    case HASHALG_SHA512:\r
+      mImageDigestSize = SHA512_DIGEST_SIZE;\r
+      mCertType        = gEfiCertSha512Guid;\r
+      break;\r
+\r
+    default:\r
+      return FALSE;\r
   }\r
 \r
   mHashTypeStr = mHash[HashAlg].Name;\r
-  CtxSize   = mHash[HashAlg].GetContextSize();\r
+  CtxSize      = mHash[HashAlg].GetContextSize ();\r
 \r
   HashCtx = AllocatePool (CtxSize);\r
   if (HashCtx == NULL) {\r
@@ -356,7 +357,7 @@ HashPeImage (
   // 1.  Load the image header into memory.\r
 \r
   // 2.  Initialize a SHA hash context.\r
-  Status = mHash[HashAlg].HashInit(HashCtx);\r
+  Status = mHash[HashAlg].HashInit (HashCtx);\r
 \r
   if (!Status) {\r
     goto Done;\r
@@ -376,13 +377,13 @@ HashPeImage (
     //\r
     // Use PE32 offset.\r
     //\r
-    HashSize = (UINTN) (&mNtHeader.Pe32->OptionalHeader.CheckSum) - (UINTN) HashBase;\r
+    HashSize            = (UINTN)(&mNtHeader.Pe32->OptionalHeader.CheckSum) - (UINTN)HashBase;\r
     NumberOfRvaAndSizes = mNtHeader.Pe32->OptionalHeader.NumberOfRvaAndSizes;\r
   } else if (mNtHeader.Pe32->OptionalHeader.Magic == EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC) {\r
     //\r
     // Use PE32+ offset.\r
     //\r
-    HashSize = (UINTN) (&mNtHeader.Pe32Plus->OptionalHeader.CheckSum) - (UINTN) HashBase;\r
+    HashSize            = (UINTN)(&mNtHeader.Pe32Plus->OptionalHeader.CheckSum) - (UINTN)HashBase;\r
     NumberOfRvaAndSizes = mNtHeader.Pe32Plus->OptionalHeader.NumberOfRvaAndSizes;\r
   } else {\r
     //\r
@@ -392,7 +393,7 @@ HashPeImage (
     goto Done;\r
   }\r
 \r
-  Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+  Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
   if (!Status) {\r
     goto Done;\r
   }\r
@@ -409,18 +410,18 @@ HashPeImage (
       //\r
       // Use PE32 offset.\r
       //\r
-      HashBase = (UINT8 *) &mNtHeader.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = mNtHeader.Pe32->OptionalHeader.SizeOfHeaders - ((UINTN) HashBase - (UINTN) mImageBase);\r
+      HashBase = (UINT8 *)&mNtHeader.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = mNtHeader.Pe32->OptionalHeader.SizeOfHeaders - ((UINTN)HashBase - (UINTN)mImageBase);\r
     } else {\r
       //\r
       // Use PE32+ offset.\r
       //\r
-      HashBase = (UINT8 *) &mNtHeader.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = mNtHeader.Pe32Plus->OptionalHeader.SizeOfHeaders - ((UINTN) HashBase - (UINTN) mImageBase);\r
+      HashBase = (UINT8 *)&mNtHeader.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = mNtHeader.Pe32Plus->OptionalHeader.SizeOfHeaders - ((UINTN)HashBase - (UINTN)mImageBase);\r
     }\r
 \r
     if (HashSize != 0) {\r
-      Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+      Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
       if (!Status) {\r
         goto Done;\r
       }\r
@@ -433,18 +434,18 @@ HashPeImage (
       //\r
       // Use PE32 offset.\r
       //\r
-      HashBase = (UINT8 *) &mNtHeader.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = (UINTN) (&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN) HashBase;\r
+      HashBase = (UINT8 *)&mNtHeader.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = (UINTN)(&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN)HashBase;\r
     } else {\r
       //\r
       // Use PE32+ offset.\r
       //\r
-      HashBase = (UINT8 *) &mNtHeader.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = (UINTN) (&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN) HashBase;\r
+      HashBase = (UINT8 *)&mNtHeader.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = (UINTN)(&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN)HashBase;\r
     }\r
 \r
     if (HashSize != 0) {\r
-      Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+      Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
       if (!Status) {\r
         goto Done;\r
       }\r
@@ -458,18 +459,18 @@ HashPeImage (
       //\r
       // Use PE32 offset\r
       //\r
-      HashBase = (UINT8 *) &mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
-      HashSize = mNtHeader.Pe32->OptionalHeader.SizeOfHeaders - ((UINTN) HashBase - (UINTN) mImageBase);\r
+      HashBase = (UINT8 *)&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
+      HashSize = mNtHeader.Pe32->OptionalHeader.SizeOfHeaders - ((UINTN)HashBase - (UINTN)mImageBase);\r
     } else {\r
       //\r
       // Use PE32+ offset.\r
       //\r
-      HashBase = (UINT8 *) &mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
-      HashSize = mNtHeader.Pe32Plus->OptionalHeader.SizeOfHeaders - ((UINTN) HashBase - (UINTN) mImageBase);\r
+      HashBase = (UINT8 *)&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
+      HashSize = mNtHeader.Pe32Plus->OptionalHeader.SizeOfHeaders - ((UINTN)HashBase - (UINTN)mImageBase);\r
     }\r
 \r
     if (HashSize != 0) {\r
-      Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+      Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
       if (!Status) {\r
         goto Done;\r
       }\r
@@ -491,14 +492,13 @@ HashPeImage (
     SumOfBytesHashed = mNtHeader.Pe32Plus->OptionalHeader.SizeOfHeaders;\r
   }\r
 \r
-\r
-  Section = (EFI_IMAGE_SECTION_HEADER *) (\r
-               mImageBase +\r
-               mPeCoffHeaderOffset +\r
-               sizeof (UINT32) +\r
-               sizeof (EFI_IMAGE_FILE_HEADER) +\r
-               mNtHeader.Pe32->FileHeader.SizeOfOptionalHeader\r
-               );\r
+  Section = (EFI_IMAGE_SECTION_HEADER *)(\r
+                                         mImageBase +\r
+                                         mPeCoffHeaderOffset +\r
+                                         sizeof (UINT32) +\r
+                                         sizeof (EFI_IMAGE_FILE_HEADER) +\r
+                                         mNtHeader.Pe32->FileHeader.SizeOfOptionalHeader\r
+                                         );\r
 \r
   //\r
   // 11. Build a temporary table of pointers to all the IMAGE_SECTION_HEADER\r
@@ -506,11 +506,12 @@ HashPeImage (
   //     header indicates how big the table should be. Do not include any\r
   //     IMAGE_SECTION_HEADERs in the table whose 'SizeOfRawData' field is zero.\r
   //\r
-  SectionHeader = (EFI_IMAGE_SECTION_HEADER *) AllocateZeroPool (sizeof (EFI_IMAGE_SECTION_HEADER) * mNtHeader.Pe32->FileHeader.NumberOfSections);\r
+  SectionHeader = (EFI_IMAGE_SECTION_HEADER *)AllocateZeroPool (sizeof (EFI_IMAGE_SECTION_HEADER) * mNtHeader.Pe32->FileHeader.NumberOfSections);\r
   if (SectionHeader == NULL) {\r
     Status = FALSE;\r
     goto Done;\r
   }\r
+\r
   //\r
   // 12.  Using the 'PointerToRawData' in the referenced section headers as\r
   //      a key, arrange the elements in the table in ascending order. In other\r
@@ -523,6 +524,7 @@ HashPeImage (
       CopyMem (&SectionHeader[Pos], &SectionHeader[Pos - 1], sizeof (EFI_IMAGE_SECTION_HEADER));\r
       Pos--;\r
     }\r
+\r
     CopyMem (&SectionHeader[Pos], Section, sizeof (EFI_IMAGE_SECTION_HEADER));\r
     Section += 1;\r
   }\r
@@ -539,10 +541,11 @@ HashPeImage (
     if (Section->SizeOfRawData == 0) {\r
       continue;\r
     }\r
-    HashBase  = mImageBase + Section->PointerToRawData;\r
-    HashSize  = (UINTN) Section->SizeOfRawData;\r
 \r
-    Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+    HashBase = mImageBase + Section->PointerToRawData;\r
+    HashSize = (UINTN)Section->SizeOfRawData;\r
+\r
+    Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
     if (!Status) {\r
       goto Done;\r
     }\r
@@ -576,9 +579,9 @@ HashPeImage (
     }\r
 \r
     if (mImageSize > CertSize + SumOfBytesHashed) {\r
-      HashSize = (UINTN) (mImageSize - CertSize - SumOfBytesHashed);\r
+      HashSize = (UINTN)(mImageSize - CertSize - SumOfBytesHashed);\r
 \r
-      Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+      Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
       if (!Status) {\r
         goto Done;\r
       }\r
@@ -588,15 +591,17 @@ HashPeImage (
     }\r
   }\r
 \r
-  Status  = mHash[HashAlg].HashFinal(HashCtx, mImageDigest);\r
+  Status = mHash[HashAlg].HashFinal (HashCtx, mImageDigest);\r
 \r
 Done:\r
   if (HashCtx != NULL) {\r
     FreePool (HashCtx);\r
   }\r
+\r
   if (SectionHeader != NULL) {\r
     FreePool (SectionHeader);\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -618,11 +623,11 @@ Done:
 **/\r
 EFI_STATUS\r
 HashPeImageByType (\r
-  IN UINT8              *AuthData,\r
-  IN UINTN              AuthDataSize\r
+  IN UINT8  *AuthData,\r
+  IN UINTN  AuthDataSize\r
   )\r
 {\r
-  UINT8                     Index;\r
+  UINT8  Index;\r
 \r
   for (Index = 0; Index < HASHALG_MAX; Index++) {\r
     //\r
@@ -660,14 +665,13 @@ HashPeImageByType (
   //\r
   // HASH PE Image based on Hash algorithm in PE/COFF Authenticode.\r
   //\r
-  if (!HashPeImage(Index)) {\r
+  if (!HashPeImage (Index)) {\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Returns the size of a given image execution info table in bytes.\r
 \r
@@ -682,7 +686,7 @@ HashPeImageByType (
 **/\r
 UINTN\r
 GetImageExeInfoTableSize (\r
-  EFI_IMAGE_EXECUTION_INFO_TABLE        *ImageExeInfoTable\r
+  EFI_IMAGE_EXECUTION_INFO_TABLE  *ImageExeInfoTable\r
   )\r
 {\r
   UINTN                     Index;\r
@@ -693,11 +697,11 @@ GetImageExeInfoTableSize (
     return 0;\r
   }\r
 \r
-  ImageExeInfoItem  = (EFI_IMAGE_EXECUTION_INFO *) ((UINT8 *) ImageExeInfoTable + sizeof (EFI_IMAGE_EXECUTION_INFO_TABLE));\r
-  TotalSize         = sizeof (EFI_IMAGE_EXECUTION_INFO_TABLE);\r
+  ImageExeInfoItem = (EFI_IMAGE_EXECUTION_INFO *)((UINT8 *)ImageExeInfoTable + sizeof (EFI_IMAGE_EXECUTION_INFO_TABLE));\r
+  TotalSize        = sizeof (EFI_IMAGE_EXECUTION_INFO_TABLE);\r
   for (Index = 0; Index < ImageExeInfoTable->NumberOfImages; Index++) {\r
-    TotalSize += ReadUnaligned32 ((UINT32 *) &ImageExeInfoItem->InfoSize);\r
-    ImageExeInfoItem = (EFI_IMAGE_EXECUTION_INFO *) ((UINT8 *) ImageExeInfoItem + ReadUnaligned32 ((UINT32 *) &ImageExeInfoItem->InfoSize));\r
+    TotalSize       += ReadUnaligned32 ((UINT32 *)&ImageExeInfoItem->InfoSize);\r
+    ImageExeInfoItem = (EFI_IMAGE_EXECUTION_INFO *)((UINT8 *)ImageExeInfoItem + ReadUnaligned32 ((UINT32 *)&ImageExeInfoItem->InfoSize));\r
   }\r
 \r
   return TotalSize;\r
@@ -715,11 +719,11 @@ GetImageExeInfoTableSize (
 **/\r
 VOID\r
 AddImageExeInfo (\r
-  IN       EFI_IMAGE_EXECUTION_ACTION       Action,\r
-  IN       CHAR16                           *Name OPTIONAL,\r
-  IN CONST EFI_DEVICE_PATH_PROTOCOL         *DevicePath,\r
-  IN       EFI_SIGNATURE_LIST               *Signature OPTIONAL,\r
-  IN       UINTN                            SignatureSize\r
+  IN       EFI_IMAGE_EXECUTION_ACTION  Action,\r
+  IN       CHAR16                      *Name OPTIONAL,\r
+  IN CONST EFI_DEVICE_PATH_PROTOCOL    *DevicePath,\r
+  IN       EFI_SIGNATURE_LIST          *Signature OPTIONAL,\r
+  IN       UINTN                       SignatureSize\r
   )\r
 {\r
   EFI_IMAGE_EXECUTION_INFO_TABLE  *ImageExeInfoTable;\r
@@ -731,14 +735,14 @@ AddImageExeInfo (
   UINTN                           DevicePathSize;\r
   CHAR16                          *NameStr;\r
 \r
-  ImageExeInfoTable     = NULL;\r
-  NewImageExeInfoTable  = NULL;\r
-  ImageExeInfoEntry     = NULL;\r
-  NameStringLen         = 0;\r
-  NameStr               = NULL;\r
+  ImageExeInfoTable    = NULL;\r
+  NewImageExeInfoTable = NULL;\r
+  ImageExeInfoEntry    = NULL;\r
+  NameStringLen        = 0;\r
+  NameStr              = NULL;\r
 \r
   if (DevicePath == NULL) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   if (Name != NULL) {\r
@@ -747,7 +751,7 @@ AddImageExeInfo (
     NameStringLen = sizeof (CHAR16);\r
   }\r
 \r
-  EfiGetSystemConfigurationTable (&gEfiImageSecurityDatabaseGuid, (VOID **) &ImageExeInfoTable);\r
+  EfiGetSystemConfigurationTable (&gEfiImageSecurityDatabaseGuid, (VOID **)&ImageExeInfoTable);\r
   if (ImageExeInfoTable != NULL) {\r
     //\r
     // The table has been found!\r
@@ -762,7 +766,7 @@ AddImageExeInfo (
     ImageExeInfoTableSize = sizeof (EFI_IMAGE_EXECUTION_INFO_TABLE);\r
   }\r
 \r
-  DevicePathSize            = GetDevicePathSize (DevicePath);\r
+  DevicePathSize = GetDevicePathSize (DevicePath);\r
 \r
   //\r
   // Signature size can be odd. Pad after signature to ensure next EXECUTION_INFO entry align\r
@@ -770,9 +774,9 @@ AddImageExeInfo (
   ASSERT (Signature != NULL || SignatureSize == 0);\r
   NewImageExeInfoEntrySize = sizeof (EFI_IMAGE_EXECUTION_INFO) + NameStringLen + DevicePathSize + SignatureSize;\r
 \r
-  NewImageExeInfoTable      = (EFI_IMAGE_EXECUTION_INFO_TABLE *) AllocateRuntimePool (ImageExeInfoTableSize + NewImageExeInfoEntrySize);\r
+  NewImageExeInfoTable = (EFI_IMAGE_EXECUTION_INFO_TABLE *)AllocateRuntimePool (ImageExeInfoTableSize + NewImageExeInfoEntrySize);\r
   if (NewImageExeInfoTable == NULL) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   if (ImageExeInfoTable != NULL) {\r
@@ -780,37 +784,39 @@ AddImageExeInfo (
   } else {\r
     NewImageExeInfoTable->NumberOfImages = 0;\r
   }\r
+\r
   NewImageExeInfoTable->NumberOfImages++;\r
-  ImageExeInfoEntry = (EFI_IMAGE_EXECUTION_INFO *) ((UINT8 *) NewImageExeInfoTable + ImageExeInfoTableSize);\r
+  ImageExeInfoEntry = (EFI_IMAGE_EXECUTION_INFO *)((UINT8 *)NewImageExeInfoTable + ImageExeInfoTableSize);\r
   //\r
   // Update new item's information.\r
   //\r
-  WriteUnaligned32 ((UINT32 *) ImageExeInfoEntry, Action);\r
-  WriteUnaligned32 ((UINT32 *) ((UINT8 *) ImageExeInfoEntry + sizeof (EFI_IMAGE_EXECUTION_ACTION)), (UINT32) NewImageExeInfoEntrySize);\r
+  WriteUnaligned32 ((UINT32 *)ImageExeInfoEntry, Action);\r
+  WriteUnaligned32 ((UINT32 *)((UINT8 *)ImageExeInfoEntry + sizeof (EFI_IMAGE_EXECUTION_ACTION)), (UINT32)NewImageExeInfoEntrySize);\r
 \r
   NameStr = (CHAR16 *)(ImageExeInfoEntry + 1);\r
   if (Name != NULL) {\r
-    CopyMem ((UINT8 *) NameStr, Name, NameStringLen);\r
+    CopyMem ((UINT8 *)NameStr, Name, NameStringLen);\r
   } else {\r
-    ZeroMem ((UINT8 *) NameStr, sizeof (CHAR16));\r
+    ZeroMem ((UINT8 *)NameStr, sizeof (CHAR16));\r
   }\r
 \r
   CopyMem (\r
-    (UINT8 *) NameStr + NameStringLen,\r
+    (UINT8 *)NameStr + NameStringLen,\r
     DevicePath,\r
     DevicePathSize\r
     );\r
   if (Signature != NULL) {\r
     CopyMem (\r
-      (UINT8 *) NameStr + NameStringLen + DevicePathSize,\r
+      (UINT8 *)NameStr + NameStringLen + DevicePathSize,\r
       Signature,\r
       SignatureSize\r
       );\r
   }\r
+\r
   //\r
   // Update/replace the image execution table.\r
   //\r
-  gBS->InstallConfigurationTable (&gEfiImageSecurityDatabaseGuid, (VOID *) NewImageExeInfoTable);\r
+  gBS->InstallConfigurationTable (&gEfiImageSecurityDatabaseGuid, (VOID *)NewImageExeInfoTable);\r
 \r
   //\r
   // Free Old table data!\r
@@ -888,7 +894,7 @@ IsCertHashFoundInDbx (
       HashAlg = HASHALG_SHA512;\r
     } else {\r
       DbxSize -= DbxList->SignatureListSize;\r
-      DbxList  = (EFI_SIGNATURE_LIST *) ((UINT8 *) DbxList + DbxList->SignatureListSize);\r
+      DbxList  = (EFI_SIGNATURE_LIST *)((UINT8 *)DbxList + DbxList->SignatureListSize);\r
       continue;\r
     }\r
 \r
@@ -898,17 +904,21 @@ IsCertHashFoundInDbx (
     if (mHash[HashAlg].GetContextSize == NULL) {\r
       goto Done;\r
     }\r
+\r
     ZeroMem (CertDigest, MAX_DIGEST_SIZE);\r
     HashCtx = AllocatePool (mHash[HashAlg].GetContextSize ());\r
     if (HashCtx == NULL) {\r
       goto Done;\r
     }\r
+\r
     if (!mHash[HashAlg].HashInit (HashCtx)) {\r
       goto Done;\r
     }\r
+\r
     if (!mHash[HashAlg].HashUpdate (HashCtx, TBSCert, TBSCertSize)) {\r
       goto Done;\r
     }\r
+\r
     if (!mHash[HashAlg].HashFinal (HashCtx, CertDigest)) {\r
       goto Done;\r
     }\r
@@ -917,7 +927,7 @@ IsCertHashFoundInDbx (
     HashCtx = NULL;\r
 \r
     SiglistHeaderSize = sizeof (EFI_SIGNATURE_LIST) + DbxList->SignatureHeaderSize;\r
-    CertHash          = (EFI_SIGNATURE_DATA *) ((UINT8 *) DbxList + SiglistHeaderSize);\r
+    CertHash          = (EFI_SIGNATURE_DATA *)((UINT8 *)DbxList + SiglistHeaderSize);\r
     CertHashCount     = (DbxList->SignatureListSize - SiglistHeaderSize) / DbxList->SignatureSize;\r
     for (Index = 0; Index < CertHashCount; Index++) {\r
       //\r
@@ -937,11 +947,12 @@ IsCertHashFoundInDbx (
         CopyMem (RevocationTime, (EFI_TIME *)(DbxCertHash + mHash[HashAlg].DigestLength), sizeof (EFI_TIME));\r
         goto Done;\r
       }\r
-      CertHash = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertHash + DbxList->SignatureSize);\r
+\r
+      CertHash = (EFI_SIGNATURE_DATA *)((UINT8 *)CertHash + DbxList->SignatureSize);\r
     }\r
 \r
     DbxSize -= DbxList->SignatureListSize;\r
-    DbxList  = (EFI_SIGNATURE_LIST *) ((UINT8 *) DbxList + DbxList->SignatureListSize);\r
+    DbxList  = (EFI_SIGNATURE_LIST *)((UINT8 *)DbxList + DbxList->SignatureListSize);\r
   }\r
 \r
   Status = EFI_SUCCESS;\r
@@ -969,11 +980,11 @@ Done:
 **/\r
 EFI_STATUS\r
 IsSignatureFoundInDatabase (\r
-  IN  CHAR16            *VariableName,\r
-  IN  UINT8             *Signature,\r
-  IN  EFI_GUID          *CertType,\r
-  IN  UINTN             SignatureSize,\r
-  OUT BOOLEAN           *IsFound\r
+  IN  CHAR16    *VariableName,\r
+  IN  UINT8     *Signature,\r
+  IN  EFI_GUID  *CertType,\r
+  IN  UINTN     SignatureSize,\r
+  OUT BOOLEAN   *IsFound\r
   )\r
 {\r
   EFI_STATUS          Status;\r
@@ -987,10 +998,10 @@ IsSignatureFoundInDatabase (
   //\r
   // Read signature database variable.\r
   //\r
-  *IsFound  = FALSE;\r
-  Data      = NULL;\r
-  DataSize  = 0;\r
-  Status    = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, NULL);\r
+  *IsFound = FALSE;\r
+  Data     = NULL;\r
+  DataSize = 0;\r
+  Status   = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, NULL);\r
   if (Status != EFI_BUFFER_TOO_SMALL) {\r
     if (Status == EFI_NOT_FOUND) {\r
       //\r
@@ -1002,7 +1013,7 @@ IsSignatureFoundInDatabase (
     return Status;\r
   }\r
 \r
-  Data = (UINT8 *) AllocateZeroPool (DataSize);\r
+  Data = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (Data == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
@@ -1011,14 +1022,15 @@ IsSignatureFoundInDatabase (
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
+\r
   //\r
   // Enumerate all signature data in SigDB to check if signature exists for executable.\r
   //\r
-  CertList = (EFI_SIGNATURE_LIST *) Data;\r
+  CertList = (EFI_SIGNATURE_LIST *)Data;\r
   while ((DataSize > 0) && (DataSize >= CertList->SignatureListSize)) {\r
     CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
-    Cert      = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
-    if ((CertList->SignatureSize == sizeof(EFI_SIGNATURE_DATA) - 1 + SignatureSize) && (CompareGuid(&CertList->SignatureType, CertType))) {\r
+    Cert      = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+    if ((CertList->SignatureSize == sizeof (EFI_SIGNATURE_DATA) - 1 + SignatureSize) && (CompareGuid (&CertList->SignatureType, CertType))) {\r
       for (Index = 0; Index < CertCount; Index++) {\r
         if (CompareMem (Cert->SignatureData, Signature, SignatureSize) == 0) {\r
           //\r
@@ -1028,13 +1040,14 @@ IsSignatureFoundInDatabase (
           //\r
           // Entries in UEFI_IMAGE_SECURITY_DATABASE that are used to validate image should be measured\r
           //\r
-          if (StrCmp(VariableName, EFI_IMAGE_SECURITY_DATABASE) == 0) {\r
+          if (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE) == 0) {\r
             SecureBootHook (VariableName, &gEfiImageSecurityDatabaseGuid, CertList->SignatureSize, Cert);\r
           }\r
+\r
           break;\r
         }\r
 \r
-        Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) Cert + CertList->SignatureSize);\r
+        Cert = (EFI_SIGNATURE_DATA *)((UINT8 *)Cert + CertList->SignatureSize);\r
       }\r
 \r
       if (*IsFound) {\r
@@ -1043,7 +1056,7 @@ IsSignatureFoundInDatabase (
     }\r
 \r
     DataSize -= CertList->SignatureListSize;\r
-    CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList  = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
 Done:\r
@@ -1066,23 +1079,23 @@ Done:
 **/\r
 BOOLEAN\r
 IsValidSignatureByTimestamp (\r
-  IN EFI_TIME               *SigningTime,\r
-  IN EFI_TIME               *RevocationTime\r
+  IN EFI_TIME  *SigningTime,\r
+  IN EFI_TIME  *RevocationTime\r
   )\r
 {\r
   if (SigningTime->Year != RevocationTime->Year) {\r
-    return (BOOLEAN) (SigningTime->Year < RevocationTime->Year);\r
+    return (BOOLEAN)(SigningTime->Year < RevocationTime->Year);\r
   } else if (SigningTime->Month != RevocationTime->Month) {\r
-    return (BOOLEAN) (SigningTime->Month < RevocationTime->Month);\r
+    return (BOOLEAN)(SigningTime->Month < RevocationTime->Month);\r
   } else if (SigningTime->Day != RevocationTime->Day) {\r
-    return (BOOLEAN) (SigningTime->Day < RevocationTime->Day);\r
+    return (BOOLEAN)(SigningTime->Day < RevocationTime->Day);\r
   } else if (SigningTime->Hour != RevocationTime->Hour) {\r
-    return (BOOLEAN) (SigningTime->Hour < RevocationTime->Hour);\r
+    return (BOOLEAN)(SigningTime->Hour < RevocationTime->Hour);\r
   } else if (SigningTime->Minute != RevocationTime->Minute) {\r
-    return (BOOLEAN) (SigningTime->Minute < RevocationTime->Minute);\r
+    return (BOOLEAN)(SigningTime->Minute < RevocationTime->Minute);\r
   }\r
 \r
-  return (BOOLEAN) (SigningTime->Second <= RevocationTime->Second);\r
+  return (BOOLEAN)(SigningTime->Second <= RevocationTime->Second);\r
 }\r
 \r
 /**\r
@@ -1096,11 +1109,12 @@ IsValidSignatureByTimestamp (
 **/\r
 BOOLEAN\r
 IsTimeZero (\r
-  IN EFI_TIME               *Time\r
+  IN EFI_TIME  *Time\r
   )\r
 {\r
   if ((Time->Year == 0) && (Time->Month == 0) &&  (Time->Day == 0) &&\r
-      (Time->Hour == 0) && (Time->Minute == 0) && (Time->Second == 0)) {\r
+      (Time->Hour == 0) && (Time->Minute == 0) && (Time->Second == 0))\r
+  {\r
     return TRUE;\r
   }\r
 \r
@@ -1123,32 +1137,32 @@ IsTimeZero (
 **/\r
 BOOLEAN\r
 PassTimestampCheck (\r
-  IN UINT8                  *AuthData,\r
-  IN UINTN                  AuthDataSize,\r
-  IN EFI_TIME               *RevocationTime\r
+  IN UINT8     *AuthData,\r
+  IN UINTN     AuthDataSize,\r
+  IN EFI_TIME  *RevocationTime\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  BOOLEAN                   VerifyStatus;\r
-  EFI_SIGNATURE_LIST        *CertList;\r
-  EFI_SIGNATURE_DATA        *Cert;\r
-  UINT8                     *DbtData;\r
-  UINTN                     DbtDataSize;\r
-  UINT8                     *RootCert;\r
-  UINTN                     RootCertSize;\r
-  UINTN                     Index;\r
-  UINTN                     CertCount;\r
-  EFI_TIME                  SigningTime;\r
+  EFI_STATUS          Status;\r
+  BOOLEAN             VerifyStatus;\r
+  EFI_SIGNATURE_LIST  *CertList;\r
+  EFI_SIGNATURE_DATA  *Cert;\r
+  UINT8               *DbtData;\r
+  UINTN               DbtDataSize;\r
+  UINT8               *RootCert;\r
+  UINTN               RootCertSize;\r
+  UINTN               Index;\r
+  UINTN               CertCount;\r
+  EFI_TIME            SigningTime;\r
 \r
   //\r
   // Variable Initialization\r
   //\r
-  VerifyStatus      = FALSE;\r
-  DbtData           = NULL;\r
-  CertList          = NULL;\r
-  Cert              = NULL;\r
-  RootCert          = NULL;\r
-  RootCertSize      = 0;\r
+  VerifyStatus = FALSE;\r
+  DbtData      = NULL;\r
+  CertList     = NULL;\r
+  Cert         = NULL;\r
+  RootCert     = NULL;\r
+  RootCertSize = 0;\r
 \r
   //\r
   // If RevocationTime is zero, the certificate shall be considered to always be revoked.\r
@@ -1162,23 +1176,25 @@ PassTimestampCheck (
   // Using the dbt to get the trusted TSA certificates.\r
   //\r
   DbtDataSize = 0;\r
-  Status   = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE2, &gEfiImageSecurityDatabaseGuid, NULL, &DbtDataSize, NULL);\r
+  Status      = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE2, &gEfiImageSecurityDatabaseGuid, NULL, &DbtDataSize, NULL);\r
   if (Status != EFI_BUFFER_TOO_SMALL) {\r
     goto Done;\r
   }\r
-  DbtData = (UINT8 *) AllocateZeroPool (DbtDataSize);\r
+\r
+  DbtData = (UINT8 *)AllocateZeroPool (DbtDataSize);\r
   if (DbtData == NULL) {\r
     goto Done;\r
   }\r
-  Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE2, &gEfiImageSecurityDatabaseGuid, NULL, &DbtDataSize, (VOID *) DbtData);\r
+\r
+  Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE2, &gEfiImageSecurityDatabaseGuid, NULL, &DbtDataSize, (VOID *)DbtData);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
 \r
-  CertList = (EFI_SIGNATURE_LIST *) DbtData;\r
+  CertList = (EFI_SIGNATURE_LIST *)DbtData;\r
   while ((DbtDataSize > 0) && (DbtDataSize >= CertList->SignatureListSize)) {\r
     if (CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid)) {\r
-      Cert      = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+      Cert      = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
       CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
       for (Index = 0; Index < CertCount; Index++) {\r
         //\r
@@ -1198,11 +1214,13 @@ PassTimestampCheck (
             goto Done;\r
           }\r
         }\r
-        Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) Cert + CertList->SignatureSize);\r
+\r
+        Cert = (EFI_SIGNATURE_DATA *)((UINT8 *)Cert + CertList->SignatureSize);\r
       }\r
     }\r
+\r
     DbtDataSize -= CertList->SignatureListSize;\r
-    CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList     = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
 Done:\r
@@ -1226,31 +1244,32 @@ Done:
 **/\r
 BOOLEAN\r
 IsForbiddenByDbx (\r
-  IN UINT8                  *AuthData,\r
-  IN UINTN                  AuthDataSize\r
+  IN UINT8  *AuthData,\r
+  IN UINTN  AuthDataSize\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  BOOLEAN                   IsForbidden;\r
-  BOOLEAN                   IsFound;\r
-  UINT8                     *Data;\r
-  UINTN                     DataSize;\r
-  EFI_SIGNATURE_LIST        *CertList;\r
-  UINTN                     CertListSize;\r
-  EFI_SIGNATURE_DATA        *CertData;\r
-  UINT8                     *RootCert;\r
-  UINTN                     RootCertSize;\r
-  UINTN                     CertCount;\r
-  UINTN                     Index;\r
-  UINT8                     *CertBuffer;\r
-  UINTN                     BufferLength;\r
-  UINT8                     *TrustedCert;\r
-  UINTN                     TrustedCertLength;\r
-  UINT8                     CertNumber;\r
-  UINT8                     *CertPtr;\r
-  UINT8                     *Cert;\r
-  UINTN                     CertSize;\r
-  EFI_TIME                  RevocationTime;\r
+  EFI_STATUS          Status;\r
+  BOOLEAN             IsForbidden;\r
+  BOOLEAN             IsFound;\r
+  UINT8               *Data;\r
+  UINTN               DataSize;\r
+  EFI_SIGNATURE_LIST  *CertList;\r
+  UINTN               CertListSize;\r
+  EFI_SIGNATURE_DATA  *CertData;\r
+  UINT8               *RootCert;\r
+  UINTN               RootCertSize;\r
+  UINTN               CertCount;\r
+  UINTN               Index;\r
+  UINT8               *CertBuffer;\r
+  UINTN               BufferLength;\r
+  UINT8               *TrustedCert;\r
+  UINTN               TrustedCertLength;\r
+  UINT8               CertNumber;\r
+  UINT8               *CertPtr;\r
+  UINT8               *Cert;\r
+  UINTN               CertSize;\r
+  EFI_TIME            RevocationTime;\r
+\r
   //\r
   // Variable Initialization\r
   //\r
@@ -1279,14 +1298,16 @@ IsForbiddenByDbx (
       //\r
       IsForbidden = FALSE;\r
     }\r
+\r
     return IsForbidden;\r
   }\r
-  Data = (UINT8 *) AllocateZeroPool (DataSize);\r
+\r
+  Data = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (Data == NULL) {\r
     return IsForbidden;\r
   }\r
 \r
-  Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, (VOID *) Data);\r
+  Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, (VOID *)Data);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -1295,11 +1316,11 @@ IsForbiddenByDbx (
   // Verify image signature with RAW X509 certificates in DBX database.\r
   // If passed, the image will be forbidden.\r
   //\r
-  CertList     = (EFI_SIGNATURE_LIST *) Data;\r
+  CertList     = (EFI_SIGNATURE_LIST *)Data;\r
   CertListSize = DataSize;\r
   while ((CertListSize > 0) && (CertListSize >= CertList->SignatureListSize)) {\r
     if (CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid)) {\r
-      CertData  = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+      CertData  = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
       CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
 \r
       for (Index = 0; Index < CertCount; Index++) {\r
@@ -1325,12 +1346,12 @@ IsForbiddenByDbx (
           goto Done;\r
         }\r
 \r
-        CertData = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertData + CertList->SignatureSize);\r
+        CertData = (EFI_SIGNATURE_DATA *)((UINT8 *)CertData + CertList->SignatureSize);\r
       }\r
     }\r
 \r
     CertListSize -= CertList->SignatureListSize;\r
-    CertList      = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList      = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
   //\r
@@ -1350,7 +1371,7 @@ IsForbiddenByDbx (
   //       UINT8  Certn[];\r
   //\r
   Pkcs7GetSigners (AuthData, AuthDataSize, &CertBuffer, &BufferLength, &TrustedCert, &TrustedCertLength);\r
-  if ((BufferLength == 0) || (CertBuffer == NULL) || (*CertBuffer) == 0) {\r
+  if ((BufferLength == 0) || (CertBuffer == NULL) || ((*CertBuffer) == 0)) {\r
     IsForbidden = TRUE;\r
     goto Done;\r
   }\r
@@ -1358,10 +1379,10 @@ IsForbiddenByDbx (
   //\r
   // Check if any hash of certificates embedded in AuthData is in the forbidden database.\r
   //\r
-  CertNumber = (UINT8) (*CertBuffer);\r
+  CertNumber = (UINT8)(*CertBuffer);\r
   CertPtr    = CertBuffer + 1;\r
   for (Index = 0; Index < CertNumber; Index++) {\r
-    CertSize = (UINTN) ReadUnaligned32 ((UINT32 *)CertPtr);\r
+    CertSize = (UINTN)ReadUnaligned32 ((UINT32 *)CertPtr);\r
     Cert     = (UINT8 *)CertPtr + sizeof (UINT32);\r
     //\r
     // Advance CertPtr to the next cert in image signer's cert list\r
@@ -1392,7 +1413,6 @@ IsForbiddenByDbx (
         goto Done;\r
       }\r
     }\r
-\r
   }\r
 \r
   IsForbidden = FALSE;\r
@@ -1408,7 +1428,6 @@ Done:
   return IsForbidden;\r
 }\r
 \r
-\r
 /**\r
   Check whether the image signature can be verified by the trusted certificates in DB database.\r
 \r
@@ -1421,32 +1440,32 @@ Done:
 **/\r
 BOOLEAN\r
 IsAllowedByDb (\r
-  IN UINT8              *AuthData,\r
-  IN UINTN              AuthDataSize\r
+  IN UINT8  *AuthData,\r
+  IN UINTN  AuthDataSize\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  BOOLEAN                   VerifyStatus;\r
-  BOOLEAN                   IsFound;\r
-  EFI_SIGNATURE_LIST        *CertList;\r
-  EFI_SIGNATURE_DATA        *CertData;\r
-  UINTN                     DataSize;\r
-  UINT8                     *Data;\r
-  UINT8                     *RootCert;\r
-  UINTN                     RootCertSize;\r
-  UINTN                     Index;\r
-  UINTN                     CertCount;\r
-  UINTN                     DbxDataSize;\r
-  UINT8                     *DbxData;\r
-  EFI_TIME                  RevocationTime;\r
+  EFI_STATUS          Status;\r
+  BOOLEAN             VerifyStatus;\r
+  BOOLEAN             IsFound;\r
+  EFI_SIGNATURE_LIST  *CertList;\r
+  EFI_SIGNATURE_DATA  *CertData;\r
+  UINTN               DataSize;\r
+  UINT8               *Data;\r
+  UINT8               *RootCert;\r
+  UINTN               RootCertSize;\r
+  UINTN               Index;\r
+  UINTN               CertCount;\r
+  UINTN               DbxDataSize;\r
+  UINT8               *DbxData;\r
+  EFI_TIME            RevocationTime;\r
 \r
-  Data              = NULL;\r
-  CertList          = NULL;\r
-  CertData          = NULL;\r
-  RootCert          = NULL;\r
-  DbxData           = NULL;\r
-  RootCertSize      = 0;\r
-  VerifyStatus      = FALSE;\r
+  Data         = NULL;\r
+  CertList     = NULL;\r
+  CertData     = NULL;\r
+  RootCert     = NULL;\r
+  DbxData      = NULL;\r
+  RootCertSize = 0;\r
+  VerifyStatus = FALSE;\r
 \r
   //\r
   // Fetch 'db' content. If 'db' doesn't exist or encounters problem to get the\r
@@ -1459,12 +1478,12 @@ IsAllowedByDb (
     return VerifyStatus;\r
   }\r
 \r
-  Data = (UINT8 *) AllocateZeroPool (DataSize);\r
+  Data = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (Data == NULL) {\r
     return VerifyStatus;\r
   }\r
 \r
-  Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, (VOID *) Data);\r
+  Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, (VOID *)Data);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -1481,6 +1500,7 @@ IsAllowedByDb (
     if (Status != EFI_NOT_FOUND) {\r
       goto Done;\r
     }\r
+\r
     //\r
     // 'dbx' does not exist. Continue to check 'db'.\r
     //\r
@@ -1488,12 +1508,12 @@ IsAllowedByDb (
     //\r
     // 'dbx' exists. Get its content.\r
     //\r
-    DbxData = (UINT8 *) AllocateZeroPool (DbxDataSize);\r
+    DbxData = (UINT8 *)AllocateZeroPool (DbxDataSize);\r
     if (DbxData == NULL) {\r
       goto Done;\r
     }\r
 \r
-    Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid, NULL, &DbxDataSize, (VOID *) DbxData);\r
+    Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid, NULL, &DbxDataSize, (VOID *)DbxData);\r
     if (EFI_ERROR (Status)) {\r
       goto Done;\r
     }\r
@@ -1502,10 +1522,10 @@ IsAllowedByDb (
   //\r
   // Find X509 certificate in Signature List to verify the signature in pkcs7 signed data.\r
   //\r
-  CertList = (EFI_SIGNATURE_LIST *) Data;\r
+  CertList = (EFI_SIGNATURE_LIST *)Data;\r
   while ((DataSize > 0) && (DataSize >= CertList->SignatureListSize)) {\r
     if (CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid)) {\r
-      CertData  = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+      CertData  = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
       CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
 \r
       for (Index = 0; Index < CertCount; Index++) {\r
@@ -1561,12 +1581,12 @@ IsAllowedByDb (
           goto Done;\r
         }\r
 \r
-        CertData = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertData + CertList->SignatureSize);\r
+        CertData = (EFI_SIGNATURE_DATA *)((UINT8 *)CertData + CertList->SignatureSize);\r
       }\r
     }\r
 \r
     DataSize -= CertList->SignatureListSize;\r
-    CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList  = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
 Done:\r
@@ -1578,6 +1598,7 @@ Done:
   if (Data != NULL) {\r
     FreePool (Data);\r
   }\r
+\r
   if (DbxData != NULL) {\r
     FreePool (DbxData);\r
   }\r
@@ -1635,37 +1656,37 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 DxeImageVerificationHandler (\r
-  IN  UINT32                           AuthenticationStatus,\r
-  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File  OPTIONAL,\r
-  IN  VOID                             *FileBuffer,\r
-  IN  UINTN                            FileSize,\r
-  IN  BOOLEAN                          BootPolicy\r
+  IN  UINT32                          AuthenticationStatus,\r
+  IN  CONST EFI_DEVICE_PATH_PROTOCOL  *File  OPTIONAL,\r
+  IN  VOID                            *FileBuffer,\r
+  IN  UINTN                           FileSize,\r
+  IN  BOOLEAN                         BootPolicy\r
   )\r
 {\r
-  EFI_IMAGE_DOS_HEADER                 *DosHdr;\r
-  BOOLEAN                              IsVerified;\r
-  EFI_SIGNATURE_LIST                   *SignatureList;\r
-  UINTN                                SignatureListSize;\r
-  EFI_SIGNATURE_DATA                   *Signature;\r
-  EFI_IMAGE_EXECUTION_ACTION           Action;\r
-  WIN_CERTIFICATE                      *WinCertificate;\r
-  UINT32                               Policy;\r
-  UINT8                                *SecureBoot;\r
-  PE_COFF_LOADER_IMAGE_CONTEXT         ImageContext;\r
-  UINT32                               NumberOfRvaAndSizes;\r
-  WIN_CERTIFICATE_EFI_PKCS             *PkcsCertData;\r
-  WIN_CERTIFICATE_UEFI_GUID            *WinCertUefiGuid;\r
-  UINT8                                *AuthData;\r
-  UINTN                                AuthDataSize;\r
-  EFI_IMAGE_DATA_DIRECTORY             *SecDataDir;\r
-  UINT32                               SecDataDirEnd;\r
-  UINT32                               SecDataDirLeft;\r
-  UINT32                               OffSet;\r
-  CHAR16                               *NameStr;\r
-  RETURN_STATUS                        PeCoffStatus;\r
-  EFI_STATUS                           HashStatus;\r
-  EFI_STATUS                           DbStatus;\r
-  BOOLEAN                              IsFound;\r
+  EFI_IMAGE_DOS_HEADER          *DosHdr;\r
+  BOOLEAN                       IsVerified;\r
+  EFI_SIGNATURE_LIST            *SignatureList;\r
+  UINTN                         SignatureListSize;\r
+  EFI_SIGNATURE_DATA            *Signature;\r
+  EFI_IMAGE_EXECUTION_ACTION    Action;\r
+  WIN_CERTIFICATE               *WinCertificate;\r
+  UINT32                        Policy;\r
+  UINT8                         *SecureBoot;\r
+  PE_COFF_LOADER_IMAGE_CONTEXT  ImageContext;\r
+  UINT32                        NumberOfRvaAndSizes;\r
+  WIN_CERTIFICATE_EFI_PKCS      *PkcsCertData;\r
+  WIN_CERTIFICATE_UEFI_GUID     *WinCertUefiGuid;\r
+  UINT8                         *AuthData;\r
+  UINTN                         AuthDataSize;\r
+  EFI_IMAGE_DATA_DIRECTORY      *SecDataDir;\r
+  UINT32                        SecDataDirEnd;\r
+  UINT32                        SecDataDirLeft;\r
+  UINT32                        OffSet;\r
+  CHAR16                        *NameStr;\r
+  RETURN_STATUS                 PeCoffStatus;\r
+  EFI_STATUS                    HashStatus;\r
+  EFI_STATUS                    DbStatus;\r
+  BOOLEAN                       IsFound;\r
 \r
   SignatureList     = NULL;\r
   SignatureListSize = 0;\r
@@ -1680,33 +1701,34 @@ DxeImageVerificationHandler (
   // Check the image type and get policy setting.\r
   //\r
   switch (GetImageType (File)) {\r
+    case IMAGE_FROM_FV:\r
+      Policy = ALWAYS_EXECUTE;\r
+      break;\r
 \r
-  case IMAGE_FROM_FV:\r
-    Policy = ALWAYS_EXECUTE;\r
-    break;\r
-\r
-  case IMAGE_FROM_OPTION_ROM:\r
-    Policy = PcdGet32 (PcdOptionRomImageVerificationPolicy);\r
-    break;\r
+    case IMAGE_FROM_OPTION_ROM:\r
+      Policy = PcdGet32 (PcdOptionRomImageVerificationPolicy);\r
+      break;\r
 \r
-  case IMAGE_FROM_REMOVABLE_MEDIA:\r
-    Policy = PcdGet32 (PcdRemovableMediaImageVerificationPolicy);\r
-    break;\r
+    case IMAGE_FROM_REMOVABLE_MEDIA:\r
+      Policy = PcdGet32 (PcdRemovableMediaImageVerificationPolicy);\r
+      break;\r
 \r
-  case IMAGE_FROM_FIXED_MEDIA:\r
-    Policy = PcdGet32 (PcdFixedMediaImageVerificationPolicy);\r
-    break;\r
+    case IMAGE_FROM_FIXED_MEDIA:\r
+      Policy = PcdGet32 (PcdFixedMediaImageVerificationPolicy);\r
+      break;\r
 \r
-  default:\r
-    Policy = DENY_EXECUTE_ON_SECURITY_VIOLATION;\r
-    break;\r
+    default:\r
+      Policy = DENY_EXECUTE_ON_SECURITY_VIOLATION;\r
+      break;\r
   }\r
+\r
   //\r
   // If policy is always/never execute, return directly.\r
   //\r
   if (Policy == ALWAYS_EXECUTE) {\r
     return EFI_SUCCESS;\r
   }\r
+\r
   if (Policy == NEVER_EXECUTE) {\r
     return EFI_ACCESS_DENIED;\r
   }\r
@@ -1716,11 +1738,11 @@ DxeImageVerificationHandler (
   // violates the UEFI spec and has been removed.\r
   //\r
   ASSERT (Policy != QUERY_USER_ON_SECURITY_VIOLATION && Policy != ALLOW_EXECUTE_ON_SECURITY_VIOLATION);\r
-  if (Policy == QUERY_USER_ON_SECURITY_VIOLATION || Policy == ALLOW_EXECUTE_ON_SECURITY_VIOLATION) {\r
+  if ((Policy == QUERY_USER_ON_SECURITY_VIOLATION) || (Policy == ALLOW_EXECUTE_ON_SECURITY_VIOLATION)) {\r
     CpuDeadLoop ();\r
   }\r
 \r
-  GetEfiGlobalVariable2 (EFI_SECURE_BOOT_MODE_NAME, (VOID**)&SecureBoot, NULL);\r
+  GetEfiGlobalVariable2 (EFI_SECURE_BOOT_MODE_NAME, (VOID **)&SecureBoot, NULL);\r
   //\r
   // Skip verification if SecureBoot variable doesn't exist.\r
   //\r
@@ -1735,6 +1757,7 @@ DxeImageVerificationHandler (
     FreePool (SecureBoot);\r
     return EFI_SUCCESS;\r
   }\r
+\r
   FreePool (SecureBoot);\r
 \r
   //\r
@@ -1744,12 +1767,12 @@ DxeImageVerificationHandler (
     return EFI_ACCESS_DENIED;\r
   }\r
 \r
-  mImageBase  = (UINT8 *) FileBuffer;\r
-  mImageSize  = FileSize;\r
+  mImageBase = (UINT8 *)FileBuffer;\r
+  mImageSize = FileSize;\r
 \r
   ZeroMem (&ImageContext, sizeof (ImageContext));\r
-  ImageContext.Handle    = (VOID *) FileBuffer;\r
-  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE) DxeImageVerificationLibImageRead;\r
+  ImageContext.Handle    = (VOID *)FileBuffer;\r
+  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE)DxeImageVerificationLibImageRead;\r
 \r
   //\r
   // Get information about the image being loaded\r
@@ -1763,7 +1786,7 @@ DxeImageVerificationHandler (
     goto Failed;\r
   }\r
 \r
-  DosHdr = (EFI_IMAGE_DOS_HEADER *) mImageBase;\r
+  DosHdr = (EFI_IMAGE_DOS_HEADER *)mImageBase;\r
   if (DosHdr->e_magic == EFI_IMAGE_DOS_SIGNATURE) {\r
     //\r
     // DOS image header is present,\r
@@ -1773,10 +1796,11 @@ DxeImageVerificationHandler (
   } else {\r
     mPeCoffHeaderOffset = 0;\r
   }\r
+\r
   //\r
   // Check PE/COFF image.\r
   //\r
-  mNtHeader.Pe32 = (EFI_IMAGE_NT_HEADERS32 *) (mImageBase + mPeCoffHeaderOffset);\r
+  mNtHeader.Pe32 = (EFI_IMAGE_NT_HEADERS32 *)(mImageBase + mPeCoffHeaderOffset);\r
   if (mNtHeader.Pe32->Signature != EFI_IMAGE_NT_SIGNATURE) {\r
     //\r
     // It is not a valid Pe/Coff file.\r
@@ -1791,7 +1815,7 @@ DxeImageVerificationHandler (
     //\r
     NumberOfRvaAndSizes = mNtHeader.Pe32->OptionalHeader.NumberOfRvaAndSizes;\r
     if (NumberOfRvaAndSizes > EFI_IMAGE_DIRECTORY_ENTRY_SECURITY) {\r
-      SecDataDir = (EFI_IMAGE_DATA_DIRECTORY *) &mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY];\r
+      SecDataDir = (EFI_IMAGE_DATA_DIRECTORY *)&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY];\r
     }\r
   } else {\r
     //\r
@@ -1799,14 +1823,14 @@ DxeImageVerificationHandler (
     //\r
     NumberOfRvaAndSizes = mNtHeader.Pe32Plus->OptionalHeader.NumberOfRvaAndSizes;\r
     if (NumberOfRvaAndSizes > EFI_IMAGE_DIRECTORY_ENTRY_SECURITY) {\r
-      SecDataDir = (EFI_IMAGE_DATA_DIRECTORY *) &mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY];\r
+      SecDataDir = (EFI_IMAGE_DATA_DIRECTORY *)&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY];\r
     }\r
   }\r
 \r
   //\r
   // Start Image Validation.\r
   //\r
-  if (SecDataDir == NULL || SecDataDir->Size == 0) {\r
+  if ((SecDataDir == NULL) || (SecDataDir->Size == 0)) {\r
     //\r
     // This image is not signed. The SHA256 hash value of the image must match a record in the security database "db",\r
     // and not be reflected in the security data base "dbx".\r
@@ -1860,15 +1884,18 @@ DxeImageVerificationHandler (
   SecDataDirEnd = SecDataDir->VirtualAddress + SecDataDir->Size;\r
   for (OffSet = SecDataDir->VirtualAddress;\r
        OffSet < SecDataDirEnd;\r
-       OffSet += (WinCertificate->dwLength + ALIGN_SIZE (WinCertificate->dwLength))) {\r
+       OffSet += (WinCertificate->dwLength + ALIGN_SIZE (WinCertificate->dwLength)))\r
+  {\r
     SecDataDirLeft = SecDataDirEnd - OffSet;\r
     if (SecDataDirLeft <= sizeof (WIN_CERTIFICATE)) {\r
       break;\r
     }\r
-    WinCertificate = (WIN_CERTIFICATE *) (mImageBase + OffSet);\r
-    if (SecDataDirLeft < WinCertificate->dwLength ||\r
+\r
+    WinCertificate = (WIN_CERTIFICATE *)(mImageBase + OffSet);\r
+    if ((SecDataDirLeft < WinCertificate->dwLength) ||\r
         (SecDataDirLeft - WinCertificate->dwLength <\r
-         ALIGN_SIZE (WinCertificate->dwLength))) {\r
+         ALIGN_SIZE (WinCertificate->dwLength)))\r
+    {\r
       break;\r
     }\r
 \r
@@ -1880,29 +1907,33 @@ DxeImageVerificationHandler (
       // The certificate is formatted as WIN_CERTIFICATE_EFI_PKCS which is described in the\r
       // Authenticode specification.\r
       //\r
-      PkcsCertData = (WIN_CERTIFICATE_EFI_PKCS *) WinCertificate;\r
+      PkcsCertData = (WIN_CERTIFICATE_EFI_PKCS *)WinCertificate;\r
       if (PkcsCertData->Hdr.dwLength <= sizeof (PkcsCertData->Hdr)) {\r
         break;\r
       }\r
-      AuthData   = PkcsCertData->CertData;\r
-      AuthDataSize = PkcsCertData->Hdr.dwLength - sizeof(PkcsCertData->Hdr);\r
+\r
+      AuthData     = PkcsCertData->CertData;\r
+      AuthDataSize = PkcsCertData->Hdr.dwLength - sizeof (PkcsCertData->Hdr);\r
     } else if (WinCertificate->wCertificateType == WIN_CERT_TYPE_EFI_GUID) {\r
       //\r
       // The certificate is formatted as WIN_CERTIFICATE_UEFI_GUID which is described in UEFI Spec.\r
       //\r
-      WinCertUefiGuid = (WIN_CERTIFICATE_UEFI_GUID *) WinCertificate;\r
-      if (WinCertUefiGuid->Hdr.dwLength <= OFFSET_OF(WIN_CERTIFICATE_UEFI_GUID, CertData)) {\r
+      WinCertUefiGuid = (WIN_CERTIFICATE_UEFI_GUID *)WinCertificate;\r
+      if (WinCertUefiGuid->Hdr.dwLength <= OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData)) {\r
         break;\r
       }\r
+\r
       if (!CompareGuid (&WinCertUefiGuid->CertType, &gEfiCertPkcs7Guid)) {\r
         continue;\r
       }\r
-      AuthData = WinCertUefiGuid->CertData;\r
-      AuthDataSize = WinCertUefiGuid->Hdr.dwLength - OFFSET_OF(WIN_CERTIFICATE_UEFI_GUID, CertData);\r
+\r
+      AuthData     = WinCertUefiGuid->CertData;\r
+      AuthDataSize = WinCertUefiGuid->Hdr.dwLength - OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData);\r
     } else {\r
       if (WinCertificate->dwLength < sizeof (WIN_CERTIFICATE)) {\r
         break;\r
       }\r
+\r
       continue;\r
     }\r
 \r
@@ -1915,7 +1946,7 @@ DxeImageVerificationHandler (
     // Check the digital signature against the revoked certificate in forbidden database (dbx).\r
     //\r
     if (IsForbiddenByDbx (AuthData, AuthDataSize)) {\r
-      Action = EFI_IMAGE_EXECUTION_AUTH_SIG_FAILED;\r
+      Action     = EFI_IMAGE_EXECUTION_AUTH_SIG_FAILED;\r
       IsVerified = FALSE;\r
       break;\r
     }\r
@@ -1972,21 +2003,23 @@ DxeImageVerificationHandler (
   if (IsVerified) {\r
     return EFI_SUCCESS;\r
   }\r
-  if (Action == EFI_IMAGE_EXECUTION_AUTH_SIG_FAILED || Action == EFI_IMAGE_EXECUTION_AUTH_SIG_FOUND) {\r
+\r
+  if ((Action == EFI_IMAGE_EXECUTION_AUTH_SIG_FAILED) || (Action == EFI_IMAGE_EXECUTION_AUTH_SIG_FOUND)) {\r
     //\r
     // Get image hash value as signature of executable.\r
     //\r
     SignatureListSize = sizeof (EFI_SIGNATURE_LIST) + sizeof (EFI_SIGNATURE_DATA) - 1 + mImageDigestSize;\r
-    SignatureList     = (EFI_SIGNATURE_LIST *) AllocateZeroPool (SignatureListSize);\r
+    SignatureList     = (EFI_SIGNATURE_LIST *)AllocateZeroPool (SignatureListSize);\r
     if (SignatureList == NULL) {\r
       SignatureListSize = 0;\r
       goto Failed;\r
     }\r
-    SignatureList->SignatureHeaderSize  = 0;\r
-    SignatureList->SignatureListSize    = (UINT32) SignatureListSize;\r
-    SignatureList->SignatureSize        = (UINT32) (sizeof (EFI_SIGNATURE_DATA) - 1 + mImageDigestSize);\r
+\r
+    SignatureList->SignatureHeaderSize = 0;\r
+    SignatureList->SignatureListSize   = (UINT32)SignatureListSize;\r
+    SignatureList->SignatureSize       = (UINT32)(sizeof (EFI_SIGNATURE_DATA) - 1 + mImageDigestSize);\r
     CopyMem (&SignatureList->SignatureType, &mCertType, sizeof (EFI_GUID));\r
-    Signature = (EFI_SIGNATURE_DATA *) ((UINT8 *) SignatureList + sizeof (EFI_SIGNATURE_LIST));\r
+    Signature = (EFI_SIGNATURE_DATA *)((UINT8 *)SignatureList + sizeof (EFI_SIGNATURE_LIST));\r
     CopyMem (Signature->SignatureData, mImageDigest, mImageDigestSize);\r
   }\r
 \r
@@ -1999,7 +2032,7 @@ Failed:
   AddImageExeInfo (Action, NameStr, File, SignatureList, SignatureListSize);\r
   if (NameStr != NULL) {\r
     DEBUG ((DEBUG_INFO, "The image doesn't pass verification: %s\n", NameStr));\r
-    FreePool(NameStr);\r
+    FreePool (NameStr);\r
   }\r
 \r
   if (SignatureList != NULL) {\r
@@ -2009,6 +2042,7 @@ Failed:
   if (Policy == DEFER_EXECUTE_ON_SECURITY_VIOLATION) {\r
     return EFI_SECURITY_VIOLATION;\r
   }\r
+\r
   return EFI_ACCESS_DENIED;\r
 }\r
 \r
@@ -2024,27 +2058,26 @@ Failed:
 VOID\r
 EFIAPI\r
 OnReadyToBoot (\r
-  IN      EFI_EVENT               Event,\r
-  IN      VOID                    *Context\r
+  IN      EFI_EVENT  Event,\r
+  IN      VOID       *Context\r
   )\r
 {\r
   EFI_IMAGE_EXECUTION_INFO_TABLE  *ImageExeInfoTable;\r
   UINTN                           ImageExeInfoTableSize;\r
 \r
-  EfiGetSystemConfigurationTable (&gEfiImageSecurityDatabaseGuid, (VOID **) &ImageExeInfoTable);\r
+  EfiGetSystemConfigurationTable (&gEfiImageSecurityDatabaseGuid, (VOID **)&ImageExeInfoTable);\r
   if (ImageExeInfoTable != NULL) {\r
     return;\r
   }\r
 \r
   ImageExeInfoTableSize = sizeof (EFI_IMAGE_EXECUTION_INFO_TABLE);\r
-  ImageExeInfoTable     = (EFI_IMAGE_EXECUTION_INFO_TABLE *) AllocateRuntimePool (ImageExeInfoTableSize);\r
+  ImageExeInfoTable     = (EFI_IMAGE_EXECUTION_INFO_TABLE *)AllocateRuntimePool (ImageExeInfoTableSize);\r
   if (ImageExeInfoTable == NULL) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   ImageExeInfoTable->NumberOfImages = 0;\r
-  gBS->InstallConfigurationTable (&gEfiImageSecurityDatabaseGuid, (VOID *) ImageExeInfoTable);\r
-\r
+  gBS->InstallConfigurationTable (&gEfiImageSecurityDatabaseGuid, (VOID *)ImageExeInfoTable);\r
 }\r
 \r
 /**\r
@@ -2062,7 +2095,7 @@ DxeImageVerificationLibConstructor (
   IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_EVENT            Event;\r
+  EFI_EVENT  Event;\r
 \r
   //\r
   // Register the event to publish the image execution table.\r
@@ -2075,7 +2108,7 @@ DxeImageVerificationLibConstructor (
     );\r
 \r
   return RegisterSecurity2Handler (\r
-          DxeImageVerificationHandler,\r
-          EFI_AUTH_OPERATION_VERIFY_IMAGE | EFI_AUTH_OPERATION_IMAGE_REQUIRED\r
-          );\r
+           DxeImageVerificationHandler,\r
+           EFI_AUTH_OPERATION_VERIFY_IMAGE | EFI_AUTH_OPERATION_IMAGE_REQUIRED\r
+           );\r
 }\r
index 17955ff9774c823f84cc33e3c880ce22062c5adb..53fe34358c22e92382d020c3f794e9c884ba135e 100644 (file)
@@ -32,57 +32,56 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Guid/AuthenticatedVariableFormat.h>\r
 #include <IndustryStandard/PeImage.h>\r
 \r
-#define EFI_CERT_TYPE_RSA2048_SHA256_SIZE 256\r
-#define EFI_CERT_TYPE_RSA2048_SIZE        256\r
-#define MAX_NOTIFY_STRING_LEN             64\r
-#define TWO_BYTE_ENCODE                   0x82\r
+#define EFI_CERT_TYPE_RSA2048_SHA256_SIZE  256\r
+#define EFI_CERT_TYPE_RSA2048_SIZE         256\r
+#define MAX_NOTIFY_STRING_LEN              64\r
+#define TWO_BYTE_ENCODE                    0x82\r
 \r
-#define ALIGNMENT_SIZE                    8\r
-#define ALIGN_SIZE(a) (((a) % ALIGNMENT_SIZE) ? ALIGNMENT_SIZE - ((a) % ALIGNMENT_SIZE) : 0)\r
+#define ALIGNMENT_SIZE  8\r
+#define ALIGN_SIZE(a)  (((a) % ALIGNMENT_SIZE) ? ALIGNMENT_SIZE - ((a) % ALIGNMENT_SIZE) : 0)\r
 \r
 //\r
 // Image type definitions\r
 //\r
-#define IMAGE_UNKNOWN                         0x00000000\r
-#define IMAGE_FROM_FV                         0x00000001\r
-#define IMAGE_FROM_OPTION_ROM                 0x00000002\r
-#define IMAGE_FROM_REMOVABLE_MEDIA            0x00000003\r
-#define IMAGE_FROM_FIXED_MEDIA                0x00000004\r
+#define IMAGE_UNKNOWN               0x00000000\r
+#define IMAGE_FROM_FV               0x00000001\r
+#define IMAGE_FROM_OPTION_ROM       0x00000002\r
+#define IMAGE_FROM_REMOVABLE_MEDIA  0x00000003\r
+#define IMAGE_FROM_FIXED_MEDIA      0x00000004\r
 \r
 //\r
 // Authorization policy bit definition\r
 //\r
-#define ALWAYS_EXECUTE                         0x00000000\r
-#define NEVER_EXECUTE                          0x00000001\r
-#define ALLOW_EXECUTE_ON_SECURITY_VIOLATION    0x00000002\r
-#define DEFER_EXECUTE_ON_SECURITY_VIOLATION    0x00000003\r
-#define DENY_EXECUTE_ON_SECURITY_VIOLATION     0x00000004\r
-#define QUERY_USER_ON_SECURITY_VIOLATION       0x00000005\r
+#define ALWAYS_EXECUTE                       0x00000000\r
+#define NEVER_EXECUTE                        0x00000001\r
+#define ALLOW_EXECUTE_ON_SECURITY_VIOLATION  0x00000002\r
+#define DEFER_EXECUTE_ON_SECURITY_VIOLATION  0x00000003\r
+#define DENY_EXECUTE_ON_SECURITY_VIOLATION   0x00000004\r
+#define QUERY_USER_ON_SECURITY_VIOLATION     0x00000005\r
 \r
 //\r
 // Support hash types\r
 //\r
-#define HASHALG_SHA1                           0x00000000\r
-#define HASHALG_SHA224                         0x00000001\r
-#define HASHALG_SHA256                         0x00000002\r
-#define HASHALG_SHA384                         0x00000003\r
-#define HASHALG_SHA512                         0x00000004\r
-#define HASHALG_MAX                            0x00000005\r
+#define HASHALG_SHA1    0x00000000\r
+#define HASHALG_SHA224  0x00000001\r
+#define HASHALG_SHA256  0x00000002\r
+#define HASHALG_SHA384  0x00000003\r
+#define HASHALG_SHA512  0x00000004\r
+#define HASHALG_MAX     0x00000005\r
 \r
 //\r
 // Set max digest size as SHA512 Output (64 bytes) by far\r
 //\r
-#define MAX_DIGEST_SIZE    SHA512_DIGEST_SIZE\r
+#define MAX_DIGEST_SIZE  SHA512_DIGEST_SIZE\r
 //\r
 //\r
 // PKCS7 Certificate definition\r
 //\r
 typedef struct {\r
-  WIN_CERTIFICATE Hdr;\r
-  UINT8           CertData[1];\r
+  WIN_CERTIFICATE    Hdr;\r
+  UINT8              CertData[1];\r
 } WIN_CERTIFICATE_EFI_PKCS;\r
 \r
-\r
 /**\r
   Retrieves the size, in bytes, of the context buffer required for hash operations.\r
 \r
@@ -113,7 +112,6 @@ BOOLEAN
   IN OUT  VOID  *HashContext\r
   );\r
 \r
-\r
 /**\r
   Performs digest on a data buffer of the specified length. This function can\r
   be called multiple times to compute the digest of long or discontinuous data streams.\r
@@ -159,7 +157,6 @@ BOOLEAN
   OUT     UINT8  *HashValue\r
   );\r
 \r
-\r
 //\r
 // Hash Algorithm Table\r
 //\r
index 351107785dd6ddab97bbd8722737b7f639283569..805b1d7872c10fd9ee3b7b12787f407d6adfa26e 100644 (file)
@@ -19,15 +19,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/TpmMeasurementLib.h>\r
 \r
 typedef struct {\r
-  CHAR16                                 *VariableName;\r
-  EFI_GUID                               *VendorGuid;\r
+  CHAR16      *VariableName;\r
+  EFI_GUID    *VendorGuid;\r
 } VARIABLE_TYPE;\r
 \r
 typedef struct {\r
-  CHAR16                                 *VariableName;\r
-  EFI_GUID                               *VendorGuid;\r
-  VOID                                   *Data;\r
-  UINTN                                  Size;\r
+  CHAR16      *VariableName;\r
+  EFI_GUID    *VendorGuid;\r
+  VOID        *Data;\r
+  UINTN       Size;\r
 } VARIABLE_RECORD;\r
 \r
 #define  MEASURED_AUTHORITY_COUNT_MAX  0x100\r
@@ -37,7 +37,7 @@ UINTN            mMeasuredAuthorityCountMax = 0;
 VARIABLE_RECORD  *mMeasuredAuthorityList    = NULL;\r
 \r
 VARIABLE_TYPE  mVariableType[] = {\r
-  {EFI_IMAGE_SECURITY_DATABASE,  &gEfiImageSecurityDatabaseGuid},\r
+  { EFI_IMAGE_SECURITY_DATABASE, &gEfiImageSecurityDatabaseGuid },\r
 };\r
 \r
 /**\r
@@ -49,12 +49,12 @@ VARIABLE_TYPE  mVariableType[] = {
 **/\r
 CHAR16 *\r
 AssignVarName (\r
-  IN      CHAR16                    *VarName\r
+  IN      CHAR16  *VarName\r
   )\r
 {\r
   UINTN  Index;\r
 \r
-  for (Index = 0; Index < sizeof(mVariableType)/sizeof(mVariableType[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mVariableType)/sizeof (mVariableType[0]); Index++) {\r
     if (StrCmp (VarName, mVariableType[Index].VariableName) == 0) {\r
       return mVariableType[Index].VariableName;\r
     }\r
@@ -72,12 +72,12 @@ AssignVarName (
 **/\r
 EFI_GUID *\r
 AssignVendorGuid (\r
-  IN      EFI_GUID                  *VendorGuid\r
+  IN      EFI_GUID  *VendorGuid\r
   )\r
 {\r
   UINTN  Index;\r
 \r
-  for (Index = 0; Index < sizeof(mVariableType)/sizeof(mVariableType[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mVariableType)/sizeof (mVariableType[0]); Index++) {\r
     if (CompareGuid (VendorGuid, mVariableType[Index].VendorGuid)) {\r
       return mVariableType[Index].VendorGuid;\r
     }\r
@@ -99,10 +99,10 @@ AssignVendorGuid (
 **/\r
 EFI_STATUS\r
 AddDataMeasured (\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  IN      VOID                      *Data,\r
-  IN      UINTN                     Size\r
+  IN      CHAR16    *VarName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  IN      VOID      *Data,\r
+  IN      UINTN     Size\r
   )\r
 {\r
   VARIABLE_RECORD  *NewMeasuredAuthorityList;\r
@@ -112,15 +112,17 @@ AddDataMeasured (
     //\r
     // Need enlarge\r
     //\r
-    NewMeasuredAuthorityList = AllocateZeroPool (sizeof(VARIABLE_RECORD) * (mMeasuredAuthorityCountMax + MEASURED_AUTHORITY_COUNT_MAX));\r
+    NewMeasuredAuthorityList = AllocateZeroPool (sizeof (VARIABLE_RECORD) * (mMeasuredAuthorityCountMax + MEASURED_AUTHORITY_COUNT_MAX));\r
     if (NewMeasuredAuthorityList == NULL) {\r
       return EFI_OUT_OF_RESOURCES;\r
     }\r
+\r
     if (mMeasuredAuthorityList != NULL) {\r
-      CopyMem (NewMeasuredAuthorityList, mMeasuredAuthorityList, sizeof(VARIABLE_RECORD) * mMeasuredAuthorityCount);\r
+      CopyMem (NewMeasuredAuthorityList, mMeasuredAuthorityList, sizeof (VARIABLE_RECORD) * mMeasuredAuthorityCount);\r
       FreePool (mMeasuredAuthorityList);\r
     }\r
-    mMeasuredAuthorityList     = NewMeasuredAuthorityList;\r
+\r
+    mMeasuredAuthorityList      = NewMeasuredAuthorityList;\r
     mMeasuredAuthorityCountMax += MEASURED_AUTHORITY_COUNT_MAX;\r
   }\r
 \r
@@ -134,6 +136,7 @@ AddDataMeasured (
   if (mMeasuredAuthorityList[mMeasuredAuthorityCount].Data == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
+\r
   CopyMem (mMeasuredAuthorityList[mMeasuredAuthorityCount].Data, Data, Size);\r
   mMeasuredAuthorityCount++;\r
 \r
@@ -153,10 +156,10 @@ AddDataMeasured (
 **/\r
 BOOLEAN\r
 IsDataMeasured (\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  IN      VOID                      *Data,\r
-  IN      UINTN                     Size\r
+  IN      CHAR16    *VarName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  IN      VOID      *Data,\r
+  IN      UINTN     Size\r
   )\r
 {\r
   UINTN  Index;\r
@@ -165,7 +168,8 @@ IsDataMeasured (
     if ((StrCmp (VarName, mMeasuredAuthorityList[Index].VariableName) == 0) &&\r
         (CompareGuid (VendorGuid, mMeasuredAuthorityList[Index].VendorGuid)) &&\r
         (CompareMem (Data, mMeasuredAuthorityList[Index].Data, Size) == 0) &&\r
-        (Size == mMeasuredAuthorityList[Index].Size)) {\r
+        (Size == mMeasuredAuthorityList[Index].Size))\r
+    {\r
       return TRUE;\r
     }\r
   }\r
@@ -184,18 +188,20 @@ IsDataMeasured (
 **/\r
 BOOLEAN\r
 IsSecureAuthorityVariable (\r
-  IN CHAR16                                 *VariableName,\r
-  IN EFI_GUID                               *VendorGuid\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid\r
   )\r
 {\r
-  UINTN   Index;\r
+  UINTN  Index;\r
 \r
-  for (Index = 0; Index < sizeof(mVariableType)/sizeof(mVariableType[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mVariableType)/sizeof (mVariableType[0]); Index++) {\r
     if ((StrCmp (VariableName, mVariableType[Index].VariableName) == 0) &&\r
-        (CompareGuid (VendorGuid, mVariableType[Index].VendorGuid))) {\r
+        (CompareGuid (VendorGuid, mVariableType[Index].VendorGuid)))\r
+    {\r
       return TRUE;\r
     }\r
   }\r
+\r
   return FALSE;\r
 }\r
 \r
@@ -215,43 +221,43 @@ IsSecureAuthorityVariable (
 EFI_STATUS\r
 EFIAPI\r
 MeasureVariable (\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  IN      VOID                      *VarData,\r
-  IN      UINTN                     VarSize\r
+  IN      CHAR16    *VarName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  IN      VOID      *VarData,\r
+  IN      UINTN     VarSize\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINTN                             VarNameLength;\r
-  UEFI_VARIABLE_DATA                *VarLog;\r
-  UINT32                            VarLogSize;\r
+  EFI_STATUS          Status;\r
+  UINTN               VarNameLength;\r
+  UEFI_VARIABLE_DATA  *VarLog;\r
+  UINT32              VarLogSize;\r
 \r
   //\r
   // The UEFI_VARIABLE_DATA.VariableData value shall be the EFI_SIGNATURE_DATA value\r
   // from the EFI_SIGNATURE_LIST that contained the authority that was used to validate the image\r
   //\r
-  VarNameLength      = StrLen (VarName);\r
-  VarLogSize = (UINT32)(sizeof (*VarLog) + VarNameLength * sizeof (*VarName) + VarSize\r
-                        - sizeof (VarLog->UnicodeName) - sizeof (VarLog->VariableData));\r
+  VarNameLength = StrLen (VarName);\r
+  VarLogSize    = (UINT32)(sizeof (*VarLog) + VarNameLength * sizeof (*VarName) + VarSize\r
+                           - sizeof (VarLog->UnicodeName) - sizeof (VarLog->VariableData));\r
 \r
-  VarLog = (UEFI_VARIABLE_DATA *) AllocateZeroPool (VarLogSize);\r
+  VarLog = (UEFI_VARIABLE_DATA *)AllocateZeroPool (VarLogSize);\r
   if (VarLog == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  CopyMem (&VarLog->VariableName, VendorGuid, sizeof(VarLog->VariableName));\r
+  CopyMem (&VarLog->VariableName, VendorGuid, sizeof (VarLog->VariableName));\r
   VarLog->UnicodeNameLength  = VarNameLength;\r
   VarLog->VariableDataLength = VarSize;\r
   CopyMem (\r
-     VarLog->UnicodeName,\r
-     VarName,\r
-     VarNameLength * sizeof (*VarName)\r
-     );\r
+    VarLog->UnicodeName,\r
+    VarName,\r
+    VarNameLength * sizeof (*VarName)\r
+    );\r
   CopyMem (\r
-     (CHAR16 *)VarLog->UnicodeName + VarNameLength,\r
-     VarData,\r
-     VarSize\r
-     );\r
+    (CHAR16 *)VarLog->UnicodeName + VarNameLength,\r
+    VarData,\r
+    VarSize\r
+    );\r
 \r
   DEBUG ((DEBUG_INFO, "DxeImageVerification: MeasureVariable (Pcr - %x, EventType - %x, ", (UINTN)7, (UINTN)EV_EFI_VARIABLE_AUTHORITY));\r
   DEBUG ((DEBUG_INFO, "VariableName - %s, VendorGuid - %g)\n", VarName, VendorGuid));\r
@@ -282,21 +288,21 @@ MeasureVariable (
 VOID\r
 EFIAPI\r
 SecureBootHook (\r
-  IN CHAR16                                 *VariableName,\r
-  IN EFI_GUID                               *VendorGuid,\r
-  IN UINTN                                  DataSize,\r
-  IN VOID                                   *Data\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN UINTN     DataSize,\r
+  IN VOID      *Data\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (!IsSecureAuthorityVariable (VariableName, VendorGuid)) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   if (IsDataMeasured (VariableName, VendorGuid, Data, DataSize)) {\r
     DEBUG ((DEBUG_ERROR, "MeasureSecureAuthorityVariable - IsDataMeasured\n"));\r
-    return ;\r
+    return;\r
   }\r
 \r
   Status = MeasureVariable (\r
@@ -311,5 +317,5 @@ SecureBootHook (
     AddDataMeasured (VariableName, VendorGuid, Data, DataSize);\r
   }\r
 \r
-  return ;\r
+  return;\r
 }\r
index 5124b884c9eaea661a94da6f7451465f87151bfb..ad95fc1ffd669ae64aff1f38cfe5f9710753a6b3 100644 (file)
@@ -27,19 +27,19 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 /// RSA 2048 SHA 256 Guided Section header\r
 ///\r
 typedef struct {\r
-  EFI_GUID_DEFINED_SECTION        GuidedSectionHeader;     ///< EFI guided section header\r
-  EFI_CERT_BLOCK_RSA_2048_SHA256  CertBlockRsa2048Sha256;  ///< RSA 2048-bit Signature\r
+  EFI_GUID_DEFINED_SECTION          GuidedSectionHeader;    ///< EFI guided section header\r
+  EFI_CERT_BLOCK_RSA_2048_SHA256    CertBlockRsa2048Sha256; ///< RSA 2048-bit Signature\r
 } RSA_2048_SHA_256_SECTION_HEADER;\r
 \r
 typedef struct {\r
-  EFI_GUID_DEFINED_SECTION2       GuidedSectionHeader;     ///< EFI guided section header\r
-  EFI_CERT_BLOCK_RSA_2048_SHA256  CertBlockRsa2048Sha256;  ///< RSA 2048-bit Signature\r
+  EFI_GUID_DEFINED_SECTION2         GuidedSectionHeader;    ///< EFI guided section header\r
+  EFI_CERT_BLOCK_RSA_2048_SHA256    CertBlockRsa2048Sha256; ///< RSA 2048-bit Signature\r
 } RSA_2048_SHA_256_SECTION2_HEADER;\r
 \r
 ///\r
 /// Public Exponent of RSA Key.\r
 ///\r
-CONST UINT8 mRsaE[] = { 0x01, 0x00, 0x01 };\r
+CONST UINT8  mRsaE[] = { 0x01, 0x00, 0x01 };\r
 \r
 /**\r
 \r
@@ -71,31 +71,37 @@ Rsa2048Sha256GuidedSectionGetInfo (
     // Check whether the input guid section is recognized.\r
     //\r
     if (!CompareGuid (\r
-        &gEfiCertTypeRsa2048Sha256Guid,\r
-        &(((EFI_GUID_DEFINED_SECTION2 *) InputSection)->SectionDefinitionGuid))) {\r
+           &gEfiCertTypeRsa2048Sha256Guid,\r
+           &(((EFI_GUID_DEFINED_SECTION2 *)InputSection)->SectionDefinitionGuid)\r
+           ))\r
+    {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
+\r
     //\r
     // Retrieve the size and attribute of the input section data.\r
     //\r
-    *SectionAttribute  = ((EFI_GUID_DEFINED_SECTION2 *) InputSection)->Attributes;\r
+    *SectionAttribute  = ((EFI_GUID_DEFINED_SECTION2 *)InputSection)->Attributes;\r
     *ScratchBufferSize = 0;\r
-    *OutputBufferSize  = SECTION2_SIZE (InputSection) - sizeof(RSA_2048_SHA_256_SECTION2_HEADER);\r
+    *OutputBufferSize  = SECTION2_SIZE (InputSection) - sizeof (RSA_2048_SHA_256_SECTION2_HEADER);\r
   } else {\r
     //\r
     // Check whether the input guid section is recognized.\r
     //\r
     if (!CompareGuid (\r
-        &gEfiCertTypeRsa2048Sha256Guid,\r
-        &(((EFI_GUID_DEFINED_SECTION *) InputSection)->SectionDefinitionGuid))) {\r
+           &gEfiCertTypeRsa2048Sha256Guid,\r
+           &(((EFI_GUID_DEFINED_SECTION *)InputSection)->SectionDefinitionGuid)\r
+           ))\r
+    {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
+\r
     //\r
     // Retrieve the size and attribute of the input section data.\r
     //\r
-    *SectionAttribute  = ((EFI_GUID_DEFINED_SECTION *) InputSection)->Attributes;\r
+    *SectionAttribute  = ((EFI_GUID_DEFINED_SECTION *)InputSection)->Attributes;\r
     *ScratchBufferSize = 0;\r
-    *OutputBufferSize  = SECTION_SIZE (InputSection) - sizeof(RSA_2048_SHA_256_SECTION_HEADER);\r
+    *OutputBufferSize  = SECTION_SIZE (InputSection) - sizeof (RSA_2048_SHA_256_SECTION_HEADER);\r
   }\r
 \r
   return EFI_SUCCESS;\r
@@ -146,15 +152,17 @@ Rsa2048Sha256GuidedSectionHandler (
     // Check whether the input guid section is recognized.\r
     //\r
     if (!CompareGuid (\r
-        &gEfiCertTypeRsa2048Sha256Guid,\r
-        &(((EFI_GUID_DEFINED_SECTION2 *)InputSection)->SectionDefinitionGuid))) {\r
+           &gEfiCertTypeRsa2048Sha256Guid,\r
+           &(((EFI_GUID_DEFINED_SECTION2 *)InputSection)->SectionDefinitionGuid)\r
+           ))\r
+    {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
 \r
     //\r
     // Get the RSA 2048 SHA 256 information.\r
     //\r
-    CertBlockRsa2048Sha256 = &((RSA_2048_SHA_256_SECTION2_HEADER *) InputSection)->CertBlockRsa2048Sha256;\r
+    CertBlockRsa2048Sha256 = &((RSA_2048_SHA_256_SECTION2_HEADER *)InputSection)->CertBlockRsa2048Sha256;\r
     OutputBufferSize       = SECTION2_SIZE (InputSection) - sizeof (RSA_2048_SHA_256_SECTION2_HEADER);\r
     if ((((EFI_GUID_DEFINED_SECTION *)InputSection)->Attributes & EFI_GUIDED_SECTION_PROCESSING_REQUIRED) != 0) {\r
       PERF_INMODULE_BEGIN ("DxeRsaCopy");\r
@@ -174,8 +182,10 @@ Rsa2048Sha256GuidedSectionHandler (
     // Check whether the input guid section is recognized.\r
     //\r
     if (!CompareGuid (\r
-        &gEfiCertTypeRsa2048Sha256Guid,\r
-        &(((EFI_GUID_DEFINED_SECTION *)InputSection)->SectionDefinitionGuid))) {\r
+           &gEfiCertTypeRsa2048Sha256Guid,\r
+           &(((EFI_GUID_DEFINED_SECTION *)InputSection)->SectionDefinitionGuid)\r
+           ))\r
+    {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
 \r
@@ -195,7 +205,7 @@ Rsa2048Sha256GuidedSectionHandler (
     //\r
     // Implicitly RSA 2048 SHA 256 GUIDed section should have STATUS_VALID bit set\r
     //\r
-    ASSERT ((((EFI_GUID_DEFINED_SECTION *) InputSection)->Attributes & EFI_GUIDED_SECTION_AUTH_STATUS_VALID) != 0);\r
+    ASSERT ((((EFI_GUID_DEFINED_SECTION *)InputSection)->Attributes & EFI_GUIDED_SECTION_AUTH_STATUS_VALID) != 0);\r
     *AuthenticationStatus = EFI_AUTH_STATUS_IMAGE_SIGNED;\r
   }\r
 \r
@@ -246,13 +256,15 @@ Rsa2048Sha256GuidedSectionHandler (
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
-  CryptoStatus = Sha256Update (HashContext, &CertBlockRsa2048Sha256->PublicKey, sizeof(CertBlockRsa2048Sha256->PublicKey));\r
+\r
+  CryptoStatus = Sha256Update (HashContext, &CertBlockRsa2048Sha256->PublicKey, sizeof (CertBlockRsa2048Sha256->PublicKey));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "DxeRsa2048Sha256: Sha256Update() failed\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
-  CryptoStatus  = Sha256Final (HashContext, Digest);\r
+\r
+  CryptoStatus = Sha256Final (HashContext, Digest);\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "DxeRsa2048Sha256: Sha256Final() failed\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
@@ -275,9 +287,11 @@ Rsa2048Sha256GuidedSectionHandler (
       CryptoStatus = TRUE;\r
       break;\r
     }\r
-    PublicKey = PublicKey + SHA256_DIGEST_SIZE;\r
+\r
+    PublicKey           = PublicKey + SHA256_DIGEST_SIZE;\r
     PublicKeyBufferSize = PublicKeyBufferSize - SHA256_DIGEST_SIZE;\r
   }\r
+\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "DxeRsa2048Sha256: Public key in section is not supported\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
@@ -298,12 +312,13 @@ Rsa2048Sha256GuidedSectionHandler (
   // Set RSA Key Components.\r
   // NOTE: Only N and E are needed to be set as RSA public key for signature verification.\r
   //\r
-  CryptoStatus = RsaSetKey (Rsa, RsaKeyN, CertBlockRsa2048Sha256->PublicKey, sizeof(CertBlockRsa2048Sha256->PublicKey));\r
+  CryptoStatus = RsaSetKey (Rsa, RsaKeyN, CertBlockRsa2048Sha256->PublicKey, sizeof (CertBlockRsa2048Sha256->PublicKey));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "DxeRsa2048Sha256: RsaSetKey(RsaKeyN) failed\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
+\r
   CryptoStatus = RsaSetKey (Rsa, RsaKeyE, mRsaE, sizeof (mRsaE));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "DxeRsa2048Sha256: RsaSetKey(RsaKeyE) failed\n"));\r
@@ -321,6 +336,7 @@ Rsa2048Sha256GuidedSectionHandler (
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
+\r
   PERF_INMODULE_BEGIN ("DxeRsaShaData");\r
   CryptoStatus = Sha256Update (HashContext, *OutputBuffer, OutputBufferSize);\r
   PERF_INMODULE_END ("DxeRsaShaData");\r
@@ -329,7 +345,8 @@ Rsa2048Sha256GuidedSectionHandler (
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
-  CryptoStatus  = Sha256Final (HashContext, Digest);\r
+\r
+  CryptoStatus = Sha256Final (HashContext, Digest);\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "DxeRsa2048Sha256: Sha256Final() failed\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
@@ -363,6 +380,7 @@ Done:
   if (Rsa != NULL) {\r
     RsaFree (Rsa);\r
   }\r
+\r
   if (HashContext != NULL) {\r
     FreePool (HashContext);\r
   }\r
index d92658f80d7fef8bf4f56a1095fdbe25f812dd6e..de4f5e583d51ea2654f0bbeb711f48d3c831f6a3 100644 (file)
@@ -32,9 +32,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/Tcg2PhysicalPresenceLib.h>\r
 #include <Library/Tcg2PpVendorLib.h>\r
 \r
-#define CONFIRM_BUFFER_SIZE         4096\r
+#define CONFIRM_BUFFER_SIZE  4096\r
 \r
-EFI_HII_HANDLE mTcg2PpStringPackHandle;\r
+EFI_HII_HANDLE  mTcg2PpStringPackHandle;\r
 \r
 /**\r
   Get string by string id from HII Interface.\r
@@ -47,7 +47,7 @@ EFI_HII_HANDLE mTcg2PpStringPackHandle;
 **/\r
 CHAR16 *\r
 Tcg2PhysicalPresenceGetStringById (\r
-  IN  EFI_STRING_ID   Id\r
+  IN  EFI_STRING_ID  Id\r
   )\r
 {\r
   return HiiGetString (mTcg2PpStringPackHandle, Id, NULL);\r
@@ -67,20 +67,20 @@ Tcg2PhysicalPresenceGetStringById (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2CommandClear (\r
-  IN TPM2B_AUTH                *PlatformAuth  OPTIONAL\r
+  IN TPM2B_AUTH  *PlatformAuth  OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  TPMS_AUTH_COMMAND         *AuthSession;\r
-  TPMS_AUTH_COMMAND         LocalAuthSession;\r
+  EFI_STATUS         Status;\r
+  TPMS_AUTH_COMMAND  *AuthSession;\r
+  TPMS_AUTH_COMMAND  LocalAuthSession;\r
 \r
   if (PlatformAuth == NULL) {\r
     AuthSession = NULL;\r
   } else {\r
     AuthSession = &LocalAuthSession;\r
-    ZeroMem (&LocalAuthSession, sizeof(LocalAuthSession));\r
+    ZeroMem (&LocalAuthSession, sizeof (LocalAuthSession));\r
     LocalAuthSession.sessionHandle = TPM_RS_PW;\r
-    LocalAuthSession.hmac.size = PlatformAuth->size;\r
+    LocalAuthSession.hmac.size     = PlatformAuth->size;\r
     CopyMem (LocalAuthSession.hmac.buffer, PlatformAuth->buffer, PlatformAuth->size);\r
   }\r
 \r
@@ -90,12 +90,13 @@ Tpm2CommandClear (
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "Tpm2Clear ... \n"));\r
   Status = Tpm2Clear (TPM_RH_PLATFORM, AuthSession);\r
   DEBUG ((DEBUG_INFO, "Tpm2Clear - %r\n", Status));\r
 \r
 Done:\r
-  ZeroMem (&LocalAuthSession.hmac, sizeof(LocalAuthSession.hmac));\r
+  ZeroMem (&LocalAuthSession.hmac, sizeof (LocalAuthSession.hmac));\r
   return Status;\r
 }\r
 \r
@@ -108,27 +109,27 @@ Done:
 **/\r
 EFI_STATUS\r
 Tpm2CommandChangeEps (\r
-  IN TPM2B_AUTH                *PlatformAuth  OPTIONAL\r
+  IN TPM2B_AUTH  *PlatformAuth  OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  TPMS_AUTH_COMMAND         *AuthSession;\r
-  TPMS_AUTH_COMMAND         LocalAuthSession;\r
+  EFI_STATUS         Status;\r
+  TPMS_AUTH_COMMAND  *AuthSession;\r
+  TPMS_AUTH_COMMAND  LocalAuthSession;\r
 \r
   if (PlatformAuth == NULL) {\r
     AuthSession = NULL;\r
   } else {\r
     AuthSession = &LocalAuthSession;\r
-    ZeroMem (&LocalAuthSession, sizeof(LocalAuthSession));\r
+    ZeroMem (&LocalAuthSession, sizeof (LocalAuthSession));\r
     LocalAuthSession.sessionHandle = TPM_RS_PW;\r
-    LocalAuthSession.hmac.size = PlatformAuth->size;\r
+    LocalAuthSession.hmac.size     = PlatformAuth->size;\r
     CopyMem (LocalAuthSession.hmac.buffer, PlatformAuth->buffer, PlatformAuth->size);\r
   }\r
 \r
   Status = Tpm2ChangeEPS (TPM_RH_PLATFORM, AuthSession);\r
   DEBUG ((DEBUG_INFO, "Tpm2ChangeEPS - %r\n", Status));\r
 \r
-  ZeroMem(&LocalAuthSession.hmac, sizeof(LocalAuthSession.hmac));\r
+  ZeroMem (&LocalAuthSession.hmac, sizeof (LocalAuthSession.hmac));\r
   return Status;\r
 }\r
 \r
@@ -147,15 +148,15 @@ Tpm2CommandChangeEps (
 **/\r
 UINT32\r
 Tcg2ExecutePhysicalPresence (\r
-  IN      TPM2B_AUTH                       *PlatformAuth   OPTIONAL,\r
-  IN      UINT32                           CommandCode,\r
-  IN      UINT32                           CommandParameter,\r
-  IN OUT  EFI_TCG2_PHYSICAL_PRESENCE_FLAGS *PpiFlags\r
+  IN      TPM2B_AUTH                        *PlatformAuth   OPTIONAL,\r
+  IN      UINT32                            CommandCode,\r
+  IN      UINT32                            CommandParameter,\r
+  IN OUT  EFI_TCG2_PHYSICAL_PRESENCE_FLAGS  *PpiFlags\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_TCG2_EVENT_ALGORITHM_BITMAP   TpmHashAlgorithmBitmap;\r
-  UINT32                            ActivePcrBanks;\r
+  EFI_STATUS                       Status;\r
+  EFI_TCG2_EVENT_ALGORITHM_BITMAP  TpmHashAlgorithmBitmap;\r
+  UINT32                           ActivePcrBanks;\r
 \r
   switch (CommandCode) {\r
     case TCG2_PHYSICAL_PRESENCE_CLEAR:\r
@@ -187,8 +188,8 @@ Tcg2ExecutePhysicalPresence (
       //    Firmware has to ensure that at least one PCR banks is active.\r
       // If not, an error is returned and no action is taken.\r
       //\r
-      if (CommandParameter == 0 || (CommandParameter & (~TpmHashAlgorithmBitmap)) != 0) {\r
-        DEBUG((DEBUG_ERROR, "PCR banks %x to allocate are not supported by TPM. Skip operation\n", CommandParameter));\r
+      if ((CommandParameter == 0) || ((CommandParameter & (~TpmHashAlgorithmBitmap)) != 0)) {\r
+        DEBUG ((DEBUG_ERROR, "PCR banks %x to allocate are not supported by TPM. Skip operation\n", CommandParameter));\r
         return TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE;\r
       }\r
 \r
@@ -250,7 +251,6 @@ Tcg2ExecutePhysicalPresence (
   }\r
 }\r
 \r
-\r
 /**\r
   Read the specified key for user confirmation.\r
 \r
@@ -262,12 +262,12 @@ Tcg2ExecutePhysicalPresence (
 **/\r
 BOOLEAN\r
 Tcg2ReadUserKey (\r
-  IN     BOOLEAN                    CautionKey\r
+  IN     BOOLEAN  CautionKey\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_INPUT_KEY                     Key;\r
-  UINT16                            InputKey;\r
+  EFI_STATUS     Status;\r
+  EFI_INPUT_KEY  Key;\r
+  UINT16         InputKey;\r
 \r
   InputKey = 0;\r
   do {\r
@@ -277,9 +277,11 @@ Tcg2ReadUserKey (
       if (Key.ScanCode == SCAN_ESC) {\r
         InputKey = Key.ScanCode;\r
       }\r
+\r
       if ((Key.ScanCode == SCAN_F10) && !CautionKey) {\r
         InputKey = Key.ScanCode;\r
       }\r
+\r
       if ((Key.ScanCode == SCAN_F12) && CautionKey) {\r
         InputKey = Key.ScanCode;\r
       }\r
@@ -313,30 +315,39 @@ Tcg2FillBufferWithBootHashAlg (
     if (Buffer[0] != 0) {\r
       StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L", ", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
     }\r
+\r
     StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA1", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
   }\r
+\r
   if ((BootHashAlg & EFI_TCG2_BOOT_HASH_ALG_SHA256) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L", ", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
     }\r
+\r
     StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA256", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
   }\r
+\r
   if ((BootHashAlg & EFI_TCG2_BOOT_HASH_ALG_SHA384) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L", ", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
     }\r
+\r
     StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA384", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
   }\r
+\r
   if ((BootHashAlg & EFI_TCG2_BOOT_HASH_ALG_SHA512) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L", ", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
     }\r
+\r
     StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA512", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
   }\r
+\r
   if ((BootHashAlg & EFI_TCG2_BOOT_HASH_ALG_SM3_256) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L", ", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
     }\r
+\r
     StrnCatS (Buffer, BufferSize / sizeof (CHAR16), L"SM3_256", (BufferSize / sizeof (CHAR16)) - StrLen (Buffer) - 1);\r
   }\r
 }\r
@@ -352,8 +363,8 @@ Tcg2FillBufferWithBootHashAlg (
 **/\r
 BOOLEAN\r
 Tcg2UserConfirm (\r
-  IN      UINT32                    TpmPpCommand,\r
-  IN      UINT32                    TpmPpCommandParameter\r
+  IN      UINT32  TpmPpCommand,\r
+  IN      UINT32  TpmPpCommandParameter\r
   )\r
 {\r
   CHAR16                            *ConfirmText;\r
@@ -382,13 +393,12 @@ Tcg2UserConfirm (
   ASSERT (mTcg2PpStringPackHandle != NULL);\r
 \r
   switch (TpmPpCommand) {\r
-\r
     case TCG2_PHYSICAL_PRESENCE_CLEAR:\r
     case TCG2_PHYSICAL_PRESENCE_ENABLE_CLEAR:\r
     case TCG2_PHYSICAL_PRESENCE_ENABLE_CLEAR_2:\r
     case TCG2_PHYSICAL_PRESENCE_ENABLE_CLEAR_3:\r
       CautionKey = TRUE;\r
-      TmpStr2 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR));\r
+      TmpStr2    = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR));\r
 \r
       TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -404,7 +414,7 @@ Tcg2UserConfirm (
     case TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_CLEAR_FALSE:\r
       CautionKey = TRUE;\r
       NoPpiInfo  = TRUE;\r
-      TmpStr2 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR));\r
+      TmpStr2    = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR));\r
 \r
       TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_PPI_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -422,14 +432,14 @@ Tcg2UserConfirm (
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_SET_PCR_BANKS:\r
-      Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **) &Tcg2Protocol);\r
+      Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **)&Tcg2Protocol);\r
       ASSERT_EFI_ERROR (Status);\r
 \r
-      ProtocolCapability.Size = sizeof(ProtocolCapability);\r
-      Status = Tcg2Protocol->GetCapability (\r
-                               Tcg2Protocol,\r
-                               &ProtocolCapability\r
-                               );\r
+      ProtocolCapability.Size = sizeof (ProtocolCapability);\r
+      Status                  = Tcg2Protocol->GetCapability (\r
+                                                Tcg2Protocol,\r
+                                                &ProtocolCapability\r
+                                                );\r
       ASSERT_EFI_ERROR (Status);\r
 \r
       Status = Tcg2Protocol->GetActivePcrBanks (\r
@@ -439,7 +449,7 @@ Tcg2UserConfirm (
       ASSERT_EFI_ERROR (Status);\r
 \r
       CautionKey = TRUE;\r
-      TmpStr2 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_SET_PCR_BANKS));\r
+      TmpStr2    = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_SET_PCR_BANKS));\r
 \r
       TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -453,8 +463,8 @@ Tcg2UserConfirm (
       StrnCatS (ConfirmText, BufSize / sizeof (CHAR16), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen (ConfirmText) - 1);\r
       FreePool (TmpStr1);\r
 \r
-      Tcg2FillBufferWithBootHashAlg (TempBuffer, sizeof(TempBuffer), TpmPpCommandParameter);\r
-      Tcg2FillBufferWithBootHashAlg (TempBuffer2, sizeof(TempBuffer2), CurrentPCRBanks);\r
+      Tcg2FillBufferWithBootHashAlg (TempBuffer, sizeof (TempBuffer), TpmPpCommandParameter);\r
+      Tcg2FillBufferWithBootHashAlg (TempBuffer2, sizeof (TempBuffer2), CurrentPCRBanks);\r
 \r
       TmpStr1 = AllocateZeroPool (BufSize);\r
       ASSERT (TmpStr1 != NULL);\r
@@ -468,7 +478,7 @@ Tcg2UserConfirm (
 \r
     case TCG2_PHYSICAL_PRESENCE_CHANGE_EPS:\r
       CautionKey = TRUE;\r
-      TmpStr2 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CHANGE_EPS));\r
+      TmpStr2    = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CHANGE_EPS));\r
 \r
       TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -501,8 +511,8 @@ Tcg2UserConfirm (
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_ENABLE_BLOCK_SID_FUNC_FALSE:\r
-      NoPpiInfo  = TRUE;\r
-      TmpStr2 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TCG_STORAGE_PP_ENABLE_BLOCK_SID));\r
+      NoPpiInfo = TRUE;\r
+      TmpStr2   = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TCG_STORAGE_PP_ENABLE_BLOCK_SID));\r
 \r
       TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TCG_STORAGE_PPI_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -510,8 +520,8 @@ Tcg2UserConfirm (
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_DISABLE_BLOCK_SID_FUNC_FALSE:\r
-      NoPpiInfo  = TRUE;\r
-      TmpStr2 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TCG_STORAGE_PP_DISABLE_BLOCK_SID));\r
+      NoPpiInfo = TRUE;\r
+      TmpStr2   = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TCG_STORAGE_PP_DISABLE_BLOCK_SID));\r
 \r
       TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TCG_STORAGE_PPI_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -533,6 +543,7 @@ Tcg2UserConfirm (
     } else {\r
       TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ACCEPT_KEY));\r
     }\r
+\r
     StrnCatS (ConfirmText, BufSize / sizeof (CHAR16), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen (ConfirmText) - 1);\r
     FreePool (TmpStr1);\r
 \r
@@ -549,6 +560,7 @@ Tcg2UserConfirm (
     } else {\r
       TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TCG_STORAGE_ACCEPT_KEY));\r
     }\r
+\r
     StrnCatS (ConfirmText, BufSize / sizeof (CHAR16), TmpStr1, (BufSize / sizeof (CHAR16)) - StrLen (ConfirmText) - 1);\r
     FreePool (TmpStr1);\r
 \r
@@ -560,6 +572,7 @@ Tcg2UserConfirm (
 \r
     TmpStr1 = Tcg2PhysicalPresenceGetStringById (STRING_TOKEN (TCG_STORAGE_REJECT_KEY));\r
   }\r
+\r
   BufSize -= StrSize (ConfirmText);\r
   UnicodeSPrint (ConfirmText + StrLen (ConfirmText), BufSize, TmpStr1, TmpStr2);\r
 \r
@@ -598,14 +611,14 @@ Tcg2UserConfirm (
 **/\r
 BOOLEAN\r
 Tcg2HaveValidTpmRequest  (\r
-  IN      EFI_TCG2_PHYSICAL_PRESENCE       *TcgPpData,\r
-  IN      EFI_TCG2_PHYSICAL_PRESENCE_FLAGS Flags,\r
-  OUT     BOOLEAN                          *RequestConfirmed\r
+  IN      EFI_TCG2_PHYSICAL_PRESENCE        *TcgPpData,\r
+  IN      EFI_TCG2_PHYSICAL_PRESENCE_FLAGS  Flags,\r
+  OUT     BOOLEAN                           *RequestConfirmed\r
   )\r
 {\r
-  EFI_TCG2_PROTOCOL                 *Tcg2Protocol;\r
-  EFI_STATUS                        Status;\r
-  BOOLEAN                           IsRequestValid;\r
+  EFI_TCG2_PROTOCOL  *Tcg2Protocol;\r
+  EFI_STATUS         Status;\r
+  BOOLEAN            IsRequestValid;\r
 \r
   *RequestConfirmed = FALSE;\r
 \r
@@ -613,7 +626,7 @@ Tcg2HaveValidTpmRequest  (
     //\r
     // Need TCG2 protocol.\r
     //\r
-    Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **) &Tcg2Protocol);\r
+    Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **)&Tcg2Protocol);\r
     if (EFI_ERROR (Status)) {\r
       return FALSE;\r
     }\r
@@ -631,6 +644,7 @@ Tcg2HaveValidTpmRequest  (
       if ((Flags.PPFlags & TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CLEAR) == 0) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_CLEAR_TRUE:\r
@@ -644,12 +658,14 @@ Tcg2HaveValidTpmRequest  (
       if ((Flags.PPFlags & TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CHANGE_PCRS) == 0) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_CHANGE_EPS:\r
       if ((Flags.PPFlags & TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CHANGE_EPS) == 0) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_LOG_ALL_DIGESTS:\r
@@ -660,12 +676,14 @@ Tcg2HaveValidTpmRequest  (
       if ((Flags.PPFlags & TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE_BLOCK_SID) == 0) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_DISABLE_BLOCK_SID:\r
       if ((Flags.PPFlags & TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BLOCK_SID) == 0) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_ENABLE_BLOCK_SID_FUNC_TRUE:\r
@@ -706,7 +724,6 @@ Tcg2HaveValidTpmRequest  (
   return TRUE;\r
 }\r
 \r
-\r
 /**\r
   Check and execute the requested physical presence command.\r
 \r
@@ -720,9 +737,9 @@ Tcg2HaveValidTpmRequest  (
 **/\r
 VOID\r
 Tcg2ExecutePendingTpmRequest (\r
-  IN      TPM2B_AUTH                       *PlatformAuth   OPTIONAL,\r
-  IN OUT  EFI_TCG2_PHYSICAL_PRESENCE       *TcgPpData,\r
-  IN OUT  EFI_TCG2_PHYSICAL_PRESENCE_FLAGS *Flags\r
+  IN      TPM2B_AUTH                        *PlatformAuth   OPTIONAL,\r
+  IN OUT  EFI_TCG2_PHYSICAL_PRESENCE        *TcgPpData,\r
+  IN OUT  EFI_TCG2_PHYSICAL_PRESENCE_FLAGS  *Flags\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -739,7 +756,7 @@ Tcg2ExecutePendingTpmRequest (
     return;\r
   }\r
 \r
-  if (!Tcg2HaveValidTpmRequest(TcgPpData, *Flags, &RequestConfirmed)) {\r
+  if (!Tcg2HaveValidTpmRequest (TcgPpData, *Flags, &RequestConfirmed)) {\r
     //\r
     // Invalid operation request.\r
     //\r
@@ -748,27 +765,28 @@ Tcg2ExecutePendingTpmRequest (
     } else {\r
       TcgPpData->PPResponse = TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE;\r
     }\r
-    TcgPpData->LastPPRequest = TcgPpData->PPRequest;\r
-    TcgPpData->PPRequest = TCG2_PHYSICAL_PRESENCE_NO_ACTION;\r
+\r
+    TcgPpData->LastPPRequest      = TcgPpData->PPRequest;\r
+    TcgPpData->PPRequest          = TCG2_PHYSICAL_PRESENCE_NO_ACTION;\r
     TcgPpData->PPRequestParameter = 0;\r
 \r
     DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-    Status = gRT->SetVariable (\r
-                    TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                    &gEfiTcg2PhysicalPresenceGuid,\r
-                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                    DataSize,\r
-                    TcgPpData\r
-                    );\r
+    Status   = gRT->SetVariable (\r
+                      TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                      &gEfiTcg2PhysicalPresenceGuid,\r
+                      EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                      DataSize,\r
+                      TcgPpData\r
+                      );\r
     return;\r
   }\r
 \r
   ResetRequired = FALSE;\r
   if (TcgPpData->PPRequest >= TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
-    NewFlags = *Flags;\r
-    NewPPFlags = NewFlags.PPFlags;\r
+    NewFlags              = *Flags;\r
+    NewPPFlags            = NewFlags.PPFlags;\r
     TcgPpData->PPResponse = Tcg2PpVendorLibExecutePendingRequest (PlatformAuth, TcgPpData->PPRequest, &NewPPFlags, &ResetRequired);\r
-    NewFlags.PPFlags = NewPPFlags;\r
+    NewFlags.PPFlags      = NewPPFlags;\r
   } else {\r
     if (!RequestConfirmed) {\r
       //\r
@@ -781,7 +799,7 @@ Tcg2ExecutePendingTpmRequest (
     // Execute requested physical presence command\r
     //\r
     TcgPpData->PPResponse = TCG_PP_OPERATION_RESPONSE_USER_ABORT;\r
-    NewFlags = *Flags;\r
+    NewFlags              = *Flags;\r
     if (RequestConfirmed) {\r
       TcgPpData->PPResponse = Tcg2ExecutePhysicalPresence (\r
                                 PlatformAuth,\r
@@ -795,23 +813,23 @@ Tcg2ExecutePendingTpmRequest (
   //\r
   // Save the flags if it is updated.\r
   //\r
-  if (CompareMem (Flags, &NewFlags, sizeof(EFI_TCG2_PHYSICAL_PRESENCE_FLAGS)) != 0) {\r
+  if (CompareMem (Flags, &NewFlags, sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS)) != 0) {\r
     *Flags = NewFlags;\r
-    Status   = gRT->SetVariable (\r
-                      TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                      &gEfiTcg2PhysicalPresenceGuid,\r
-                      EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                      sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS),\r
-                      &NewFlags\r
-                      );\r
+    Status = gRT->SetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                    sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS),\r
+                    &NewFlags\r
+                    );\r
   }\r
 \r
   //\r
   // Clear request\r
   //\r
   if ((NewFlags.PPFlags & TCG2_LIB_PP_FLAG_RESET_TRACK) == 0) {\r
-    TcgPpData->LastPPRequest = TcgPpData->PPRequest;\r
-    TcgPpData->PPRequest = TCG2_PHYSICAL_PRESENCE_NO_ACTION;\r
+    TcgPpData->LastPPRequest      = TcgPpData->PPRequest;\r
+    TcgPpData->PPRequest          = TCG2_PHYSICAL_PRESENCE_NO_ACTION;\r
     TcgPpData->PPRequestParameter = 0;\r
   }\r
 \r
@@ -819,13 +837,13 @@ Tcg2ExecutePendingTpmRequest (
   // Save changes\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-  Status = gRT->SetVariable (\r
-                  TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiTcg2PhysicalPresenceGuid,\r
-                  EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                  DataSize,\r
-                  TcgPpData\r
-                  );\r
+  Status   = gRT->SetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                    DataSize,\r
+                    TcgPpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     return;\r
   }\r
@@ -862,12 +880,14 @@ Tcg2ExecutePendingTpmRequest (
         if (ResetRequired) {\r
           break;\r
         } else {\r
-          return ;\r
+          return;\r
         }\r
       }\r
+\r
       if (TcgPpData->PPRequest != TCG2_PHYSICAL_PRESENCE_NO_ACTION) {\r
         break;\r
       }\r
+\r
       return;\r
   }\r
 \r
@@ -892,7 +912,7 @@ Tcg2ExecutePendingTpmRequest (
 VOID\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibProcessRequest (\r
-  IN      TPM2B_AUTH                     *PlatformAuth  OPTIONAL\r
+  IN      TPM2B_AUTH  *PlatformAuth  OPTIONAL\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -923,49 +943,50 @@ Tcg2PhysicalPresenceLibProcessRequest (
   //\r
   if (GetBootModeHob () == BOOT_ON_S4_RESUME) {\r
     DEBUG ((DEBUG_INFO, "S4 Resume, Skip TPM PP process!\n"));\r
-    return ;\r
+    return;\r
   }\r
 \r
   //\r
   // Initialize physical presence flags.\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                  &gEfiTcg2PhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &PpiFlags\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &PpiFlags\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
-    PpiFlags.PPFlags = PcdGet32(PcdTcg2PhysicalPresenceFlags);\r
-    Status   = gRT->SetVariable (\r
-                      TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                      &gEfiTcg2PhysicalPresenceGuid,\r
-                      EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                      sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS),\r
-                      &PpiFlags\r
-                      );\r
+    PpiFlags.PPFlags = PcdGet32 (PcdTcg2PhysicalPresenceFlags);\r
+    Status           = gRT->SetVariable (\r
+                              TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                              &gEfiTcg2PhysicalPresenceGuid,\r
+                              EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                              sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS),\r
+                              &PpiFlags\r
+                              );\r
     if (EFI_ERROR (Status)) {\r
       DEBUG ((DEBUG_ERROR, "[TPM2] Set physical presence flag failed, Status = %r\n", Status));\r
-      return ;\r
+      return;\r
     }\r
-    DEBUG((DEBUG_INFO, "[TPM2] Initial physical presence flags value is 0x%x\n", PpiFlags.PPFlags));\r
+\r
+    DEBUG ((DEBUG_INFO, "[TPM2] Initial physical presence flags value is 0x%x\n", PpiFlags.PPFlags));\r
   }\r
 \r
   //\r
   // Initialize physical presence variable.\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiTcg2PhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &TcgPpData\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &TcgPpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
-    ZeroMem ((VOID*)&TcgPpData, sizeof (TcgPpData));\r
+    ZeroMem ((VOID *)&TcgPpData, sizeof (TcgPpData));\r
     DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
     Status   = gRT->SetVariable (\r
                       TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
@@ -976,7 +997,7 @@ Tcg2PhysicalPresenceLibProcessRequest (
                       );\r
     if (EFI_ERROR (Status)) {\r
       DEBUG ((DEBUG_ERROR, "[TPM2] Set physical presence variable failed, Status = %r\n", Status));\r
-      return ;\r
+      return;\r
     }\r
   }\r
 \r
@@ -987,7 +1008,6 @@ Tcg2PhysicalPresenceLibProcessRequest (
   //\r
   Tcg2ExecutePendingTpmRequest (PlatformAuth, &TcgPpData, &PpiFlags);\r
   DEBUG ((DEBUG_INFO, "[TPM2] PPResponse = %x (LastPPRequest=%x, Flags=%x)\n", TcgPpData.PPResponse, TcgPpData.LastPPRequest, PpiFlags.PPFlags));\r
-\r
 }\r
 \r
 /**\r
@@ -1002,7 +1022,7 @@ Tcg2PhysicalPresenceLibProcessRequest (
 **/\r
 BOOLEAN\r
 EFIAPI\r
-Tcg2PhysicalPresenceLibNeedUserConfirm(\r
+Tcg2PhysicalPresenceLibNeedUserConfirm (\r
   VOID\r
   )\r
 {\r
@@ -1024,25 +1044,25 @@ Tcg2PhysicalPresenceLibNeedUserConfirm(
   // Check Tpm requests\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiTcg2PhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &TcgPpData\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &TcgPpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     return FALSE;\r
   }\r
 \r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                  &gEfiTcg2PhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &PpiFlags\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &PpiFlags\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     return FALSE;\r
   }\r
@@ -1054,7 +1074,7 @@ Tcg2PhysicalPresenceLibNeedUserConfirm(
     return FALSE;\r
   }\r
 \r
-  if (!Tcg2HaveValidTpmRequest(&TcgPpData, PpiFlags, &RequestConfirmed)) {\r
+  if (!Tcg2HaveValidTpmRequest (&TcgPpData, PpiFlags, &RequestConfirmed)) {\r
     //\r
     // Invalid operation request.\r
     //\r
@@ -1071,7 +1091,6 @@ Tcg2PhysicalPresenceLibNeedUserConfirm(
   return FALSE;\r
 }\r
 \r
-\r
 /**\r
   The handler for TPM physical presence function:\r
   Return TPM Operation Response to OS Environment.\r
@@ -1084,13 +1103,13 @@ Tcg2PhysicalPresenceLibNeedUserConfirm(
 UINT32\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (\r
-  OUT UINT32                *MostRecentRequest,\r
-  OUT UINT32                *Response\r
+  OUT UINT32  *MostRecentRequest,\r
+  OUT UINT32  *Response\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINTN                             DataSize;\r
-  EFI_TCG2_PHYSICAL_PRESENCE        PpData;\r
+  EFI_STATUS                  Status;\r
+  UINTN                       DataSize;\r
+  EFI_TCG2_PHYSICAL_PRESENCE  PpData;\r
 \r
   DEBUG ((DEBUG_INFO, "[TPM2] ReturnOperationResponseToOsFunction\n"));\r
 \r
@@ -1098,13 +1117,13 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
   // Get the Physical Presence variable\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiTcg2PhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &PpData\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &PpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     *MostRecentRequest = 0;\r
     *Response          = 0;\r
@@ -1134,8 +1153,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
 UINT32\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 RequestParameter\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  RequestParameter\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -1149,35 +1168,37 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (
   // Get the Physical Presence variable\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiTcg2PhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &PpData\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &PpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "[TPM2] Get PP variable failure! Status = %r\n", Status));\r
     return TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE;\r
   }\r
 \r
   if ((OperationRequest > TCG2_PHYSICAL_PRESENCE_NO_ACTION_MAX) &&\r
-      (OperationRequest < TCG2_PHYSICAL_PRESENCE_STORAGE_MANAGEMENT_BEGIN) ) {\r
+      (OperationRequest < TCG2_PHYSICAL_PRESENCE_STORAGE_MANAGEMENT_BEGIN))\r
+  {\r
     return TCG_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED;\r
   }\r
 \r
   if ((PpData.PPRequest != OperationRequest) ||\r
-      (PpData.PPRequestParameter != RequestParameter)) {\r
-    PpData.PPRequest = (UINT8)OperationRequest;\r
+      (PpData.PPRequestParameter != RequestParameter))\r
+  {\r
+    PpData.PPRequest          = (UINT8)OperationRequest;\r
     PpData.PPRequestParameter = RequestParameter;\r
-    DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-    Status = gRT->SetVariable (\r
-                    TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                    &gEfiTcg2PhysicalPresenceGuid,\r
-                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                    DataSize,\r
-                    &PpData\r
-                    );\r
+    DataSize                  = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
+    Status                    = gRT->SetVariable (\r
+                                       TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                                       &gEfiTcg2PhysicalPresenceGuid,\r
+                                       EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                                       DataSize,\r
+                                       &PpData\r
+                                       );\r
     if (EFI_ERROR (Status)) {\r
       DEBUG ((DEBUG_ERROR, "[TPM2] Set PP variable failure! Status = %r\n", Status));\r
       return TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE;\r
@@ -1186,16 +1207,17 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (
 \r
   if (OperationRequest >= TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
     DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS);\r
-    Status = gRT->GetVariable (\r
-                    TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                    &gEfiTcg2PhysicalPresenceGuid,\r
-                    NULL,\r
-                    &DataSize,\r
-                    &Flags\r
-                    );\r
+    Status   = gRT->GetVariable (\r
+                      TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                      &gEfiTcg2PhysicalPresenceGuid,\r
+                      NULL,\r
+                      &DataSize,\r
+                      &Flags\r
+                      );\r
     if (EFI_ERROR (Status)) {\r
-      Flags.PPFlags = PcdGet32(PcdTcg2PhysicalPresenceFlags);\r
+      Flags.PPFlags = PcdGet32 (PcdTcg2PhysicalPresenceFlags);\r
     }\r
+\r
     return Tcg2PpVendorLibSubmitRequestToPreOSFunction (OperationRequest, Flags.PPFlags, RequestParameter);\r
   }\r
 \r
@@ -1220,15 +1242,16 @@ Tcg2PhysicalPresenceLibGetManagementFlags (
   DEBUG ((DEBUG_INFO, "[TPM2] GetManagementFlags\n"));\r
 \r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                  &gEfiTcg2PhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &PpiFlags\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                    &gEfiTcg2PhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &PpiFlags\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
-    PpiFlags.PPFlags = PcdGet32(PcdTcg2PhysicalPresenceFlags);\r
+    PpiFlags.PPFlags = PcdGet32 (PcdTcg2PhysicalPresenceFlags);\r
   }\r
+\r
   return PpiFlags.PPFlags;\r
 }\r
index ab7f664c7a05df06c1fdb843c73d47c2665e34a3..597ce77b4b49280f8f005ee4537279720b72685e 100644 (file)
@@ -30,9 +30,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Guid/PhysicalPresenceData.h>\r
 #include <Library/TcgPpVendorLib.h>\r
 \r
-#define CONFIRM_BUFFER_SIZE         4096\r
+#define CONFIRM_BUFFER_SIZE  4096\r
 \r
-EFI_HII_HANDLE mPpStringPackHandle;\r
+EFI_HII_HANDLE  mPpStringPackHandle;\r
 \r
 /**\r
   Get string by string id from HII Interface.\r
@@ -45,7 +45,7 @@ EFI_HII_HANDLE mPpStringPackHandle;
 **/\r
 CHAR16 *\r
 PhysicalPresenceGetStringById (\r
-  IN  EFI_STRING_ID   Id\r
+  IN  EFI_STRING_ID  Id\r
   )\r
 {\r
   return HiiGetString (mPpStringPackHandle, Id, NULL);\r
@@ -64,24 +64,24 @@ PhysicalPresenceGetStringById (
 **/\r
 EFI_STATUS\r
 GetTpmCapability (\r
-  IN   EFI_TCG_PROTOCOL             *TcgProtocol,\r
-  OUT  BOOLEAN                      *LifetimeLock,\r
-  OUT  BOOLEAN                      *CmdEnable\r
+  IN   EFI_TCG_PROTOCOL  *TcgProtocol,\r
+  OUT  BOOLEAN           *LifetimeLock,\r
+  OUT  BOOLEAN           *CmdEnable\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM_RQU_COMMAND_HDR               *TpmRqu;\r
-  TPM_RSP_COMMAND_HDR               *TpmRsp;\r
-  UINT32                            *SendBufPtr;\r
-  UINT8                             SendBuffer[sizeof (*TpmRqu) + sizeof (UINT32) * 3];\r
-  TPM_PERMANENT_FLAGS               *TpmPermanentFlags;\r
-  UINT8                             RecvBuffer[40];\r
+  EFI_STATUS           Status;\r
+  TPM_RQU_COMMAND_HDR  *TpmRqu;\r
+  TPM_RSP_COMMAND_HDR  *TpmRsp;\r
+  UINT32               *SendBufPtr;\r
+  UINT8                SendBuffer[sizeof (*TpmRqu) + sizeof (UINT32) * 3];\r
+  TPM_PERMANENT_FLAGS  *TpmPermanentFlags;\r
+  UINT8                RecvBuffer[40];\r
 \r
   //\r
   // Fill request header\r
   //\r
-  TpmRsp = (TPM_RSP_COMMAND_HDR*)RecvBuffer;\r
-  TpmRqu = (TPM_RQU_COMMAND_HDR*)SendBuffer;\r
+  TpmRsp = (TPM_RSP_COMMAND_HDR *)RecvBuffer;\r
+  TpmRqu = (TPM_RQU_COMMAND_HDR *)SendBuffer;\r
 \r
   TpmRqu->tag       = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
   TpmRqu->paramSize = SwapBytes32 (sizeof (SendBuffer));\r
@@ -90,7 +90,7 @@ GetTpmCapability (
   //\r
   // Set request parameter\r
   //\r
-  SendBufPtr      = (UINT32*)(TpmRqu + 1);\r
+  SendBufPtr = (UINT32 *)(TpmRqu + 1);\r
   WriteUnaligned32 (SendBufPtr++, SwapBytes32 (TPM_CAP_FLAG));\r
   WriteUnaligned32 (SendBufPtr++, SwapBytes32 (sizeof (TPM_CAP_FLAG_PERMANENT)));\r
   WriteUnaligned32 (SendBufPtr, SwapBytes32 (TPM_CAP_FLAG_PERMANENT));\r
@@ -98,9 +98,9 @@ GetTpmCapability (
   Status = TcgProtocol->PassThroughToTpm (\r
                           TcgProtocol,\r
                           sizeof (SendBuffer),\r
-                          (UINT8*)TpmRqu,\r
+                          (UINT8 *)TpmRqu,\r
                           sizeof (RecvBuffer),\r
-                          (UINT8*)&RecvBuffer\r
+                          (UINT8 *)&RecvBuffer\r
                           );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
@@ -136,30 +136,30 @@ GetTpmCapability (
 **/\r
 EFI_STATUS\r
 TpmPhysicalPresence (\r
-  IN      EFI_TCG_PROTOCOL          *TcgProtocol,\r
-  IN      TPM_PHYSICAL_PRESENCE     PhysicalPresence\r
+  IN      EFI_TCG_PROTOCOL       *TcgProtocol,\r
+  IN      TPM_PHYSICAL_PRESENCE  PhysicalPresence\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM_RQU_COMMAND_HDR               *TpmRqu;\r
-  TPM_PHYSICAL_PRESENCE             *TpmPp;\r
-  TPM_RSP_COMMAND_HDR               TpmRsp;\r
-  UINT8                             Buffer[sizeof (*TpmRqu) + sizeof (*TpmPp)];\r
+  EFI_STATUS             Status;\r
+  TPM_RQU_COMMAND_HDR    *TpmRqu;\r
+  TPM_PHYSICAL_PRESENCE  *TpmPp;\r
+  TPM_RSP_COMMAND_HDR    TpmRsp;\r
+  UINT8                  Buffer[sizeof (*TpmRqu) + sizeof (*TpmPp)];\r
 \r
-  TpmRqu = (TPM_RQU_COMMAND_HDR*)Buffer;\r
-  TpmPp = (TPM_PHYSICAL_PRESENCE*)(TpmRqu + 1);\r
+  TpmRqu = (TPM_RQU_COMMAND_HDR *)Buffer;\r
+  TpmPp  = (TPM_PHYSICAL_PRESENCE *)(TpmRqu + 1);\r
 \r
   TpmRqu->tag       = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
   TpmRqu->paramSize = SwapBytes32 (sizeof (Buffer));\r
   TpmRqu->ordinal   = SwapBytes32 (TSC_ORD_PhysicalPresence);\r
-  WriteUnaligned16 (TpmPp, (TPM_PHYSICAL_PRESENCE) SwapBytes16 (PhysicalPresence));\r
+  WriteUnaligned16 (TpmPp, (TPM_PHYSICAL_PRESENCE)SwapBytes16 (PhysicalPresence));\r
 \r
   Status = TcgProtocol->PassThroughToTpm (\r
                           TcgProtocol,\r
                           sizeof (Buffer),\r
-                          (UINT8*)TpmRqu,\r
+                          (UINT8 *)TpmRqu,\r
                           sizeof (TpmRsp),\r
-                          (UINT8*)&TpmRsp\r
+                          (UINT8 *)&TpmRsp\r
                           );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
@@ -194,18 +194,18 @@ TpmPhysicalPresence (
 **/\r
 UINT32\r
 TpmCommandNoReturnData (\r
-  IN      EFI_TCG_PROTOCOL          *TcgProtocol,\r
-  IN      TPM_COMMAND_CODE          Ordinal,\r
-  IN      UINTN                     AdditionalParameterSize,\r
-  IN      VOID                      *AdditionalParameters\r
+  IN      EFI_TCG_PROTOCOL  *TcgProtocol,\r
+  IN      TPM_COMMAND_CODE  Ordinal,\r
+  IN      UINTN             AdditionalParameterSize,\r
+  IN      VOID              *AdditionalParameters\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM_RQU_COMMAND_HDR               *TpmRqu;\r
-  TPM_RSP_COMMAND_HDR               TpmRsp;\r
-  UINT32                            Size;\r
+  EFI_STATUS           Status;\r
+  TPM_RQU_COMMAND_HDR  *TpmRqu;\r
+  TPM_RSP_COMMAND_HDR  TpmRsp;\r
+  UINT32               Size;\r
 \r
-  TpmRqu = (TPM_RQU_COMMAND_HDR*) AllocatePool (sizeof (*TpmRqu) + AdditionalParameterSize);\r
+  TpmRqu = (TPM_RQU_COMMAND_HDR *)AllocatePool (sizeof (*TpmRqu) + AdditionalParameterSize);\r
   if (TpmRqu == NULL) {\r
     return TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE;\r
   }\r
@@ -219,14 +219,15 @@ TpmCommandNoReturnData (
   Status = TcgProtocol->PassThroughToTpm (\r
                           TcgProtocol,\r
                           Size,\r
-                          (UINT8*)TpmRqu,\r
+                          (UINT8 *)TpmRqu,\r
                           (UINT32)sizeof (TpmRsp),\r
-                          (UINT8*)&TpmRsp\r
+                          (UINT8 *)&TpmRsp\r
                           );\r
   FreePool (TpmRqu);\r
   if (EFI_ERROR (Status) || (TpmRsp.tag != SwapBytes16 (TPM_TAG_RSP_COMMAND))) {\r
     return TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE;\r
   }\r
+\r
   return SwapBytes32 (TpmRsp.returnCode);\r
 }\r
 \r
@@ -245,14 +246,14 @@ TpmCommandNoReturnData (
 **/\r
 UINT32\r
 ExecutePhysicalPresence (\r
-  IN      EFI_TCG_PROTOCOL            *TcgProtocol,\r
-  IN      UINT32                      CommandCode,\r
-  IN OUT  EFI_PHYSICAL_PRESENCE_FLAGS *PpiFlags\r
+  IN      EFI_TCG_PROTOCOL             *TcgProtocol,\r
+  IN      UINT32                       CommandCode,\r
+  IN OUT  EFI_PHYSICAL_PRESENCE_FLAGS  *PpiFlags\r
   )\r
 {\r
-  BOOLEAN                           BoolVal;\r
-  UINT32                            TpmResponse;\r
-  UINT32                            InData[5];\r
+  BOOLEAN  BoolVal;\r
+  UINT32   TpmResponse;\r
+  UINT32   InData[5];\r
 \r
   switch (CommandCode) {\r
     case PHYSICAL_PRESENCE_ENABLE:\r
@@ -302,6 +303,7 @@ ExecutePhysicalPresence (
       if (TpmResponse == 0) {\r
         TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_ACTIVATE, PpiFlags);\r
       }\r
+\r
       return TpmResponse;\r
 \r
     case PHYSICAL_PRESENCE_DEACTIVATE_DISABLE:\r
@@ -309,6 +311,7 @@ ExecutePhysicalPresence (
       if (TpmResponse == 0) {\r
         TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_DISABLE, PpiFlags);\r
       }\r
+\r
       return TpmResponse;\r
 \r
     case PHYSICAL_PRESENCE_SET_OWNER_INSTALL_TRUE:\r
@@ -335,12 +338,13 @@ ExecutePhysicalPresence (
       // PHYSICAL_PRESENCE_SET_OWNER_INSTALL_TRUE will be executed after reboot\r
       //\r
       if ((PpiFlags->PPFlags & TCG_VENDOR_LIB_FLAG_RESET_TRACK) == 0) {\r
-        TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_ENABLE_ACTIVATE, PpiFlags);\r
+        TpmResponse        = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_ENABLE_ACTIVATE, PpiFlags);\r
         PpiFlags->PPFlags |= TCG_VENDOR_LIB_FLAG_RESET_TRACK;\r
       } else {\r
-        TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_SET_OWNER_INSTALL_TRUE, PpiFlags);\r
+        TpmResponse        = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_SET_OWNER_INSTALL_TRUE, PpiFlags);\r
         PpiFlags->PPFlags &= ~TCG_VENDOR_LIB_FLAG_RESET_TRACK;\r
       }\r
+\r
       return TpmResponse;\r
 \r
     case PHYSICAL_PRESENCE_DEACTIVATE_DISABLE_OWNER_FALSE:\r
@@ -348,13 +352,14 @@ ExecutePhysicalPresence (
       if (TpmResponse == 0) {\r
         TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_DEACTIVATE_DISABLE, PpiFlags);\r
       }\r
+\r
       return TpmResponse;\r
 \r
     case PHYSICAL_PRESENCE_DEFERRED_PP_UNOWNERED_FIELD_UPGRADE:\r
       InData[0] = SwapBytes32 (TPM_SET_STCLEAR_DATA);            // CapabilityArea\r
-      InData[1] = SwapBytes32 (sizeof(UINT32));                  // SubCapSize\r
+      InData[1] = SwapBytes32 (sizeof (UINT32));                 // SubCapSize\r
       InData[2] = SwapBytes32 (TPM_SD_DEFERREDPHYSICALPRESENCE); // SubCap\r
-      InData[3] = SwapBytes32 (sizeof(UINT32));                  // SetValueSize\r
+      InData[3] = SwapBytes32 (sizeof (UINT32));                 // SetValueSize\r
       InData[4] = SwapBytes32 (1);                               // UnownedFieldUpgrade; bit0\r
       return TpmCommandNoReturnData (\r
                TcgProtocol,\r
@@ -376,6 +381,7 @@ ExecutePhysicalPresence (
       if (TpmResponse == 0) {\r
         TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_ENABLE_ACTIVATE, PpiFlags);\r
       }\r
+\r
       return TpmResponse;\r
 \r
     case PHYSICAL_PRESENCE_SET_NO_PPI_PROVISION_FALSE:\r
@@ -408,12 +414,13 @@ ExecutePhysicalPresence (
       // PHYSICAL_PRESENCE_CLEAR will be executed after reboot.\r
       //\r
       if ((PpiFlags->PPFlags & TCG_VENDOR_LIB_FLAG_RESET_TRACK) == 0) {\r
-        TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_ENABLE_ACTIVATE, PpiFlags);\r
+        TpmResponse        = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_ENABLE_ACTIVATE, PpiFlags);\r
         PpiFlags->PPFlags |= TCG_VENDOR_LIB_FLAG_RESET_TRACK;\r
       } else {\r
-        TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_CLEAR, PpiFlags);\r
+        TpmResponse        = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_CLEAR, PpiFlags);\r
         PpiFlags->PPFlags &= ~TCG_VENDOR_LIB_FLAG_RESET_TRACK;\r
       }\r
+\r
       return TpmResponse;\r
 \r
     case PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE:\r
@@ -422,21 +429,22 @@ ExecutePhysicalPresence (
       // PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE will be executed after reboot.\r
       //\r
       if ((PpiFlags->PPFlags & TCG_VENDOR_LIB_FLAG_RESET_TRACK) == 0) {\r
-        TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_ENABLE_ACTIVATE, PpiFlags);\r
+        TpmResponse        = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_ENABLE_ACTIVATE, PpiFlags);\r
         PpiFlags->PPFlags |= TCG_VENDOR_LIB_FLAG_RESET_TRACK;\r
       } else {\r
-        TpmResponse = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE, PpiFlags);\r
+        TpmResponse        = ExecutePhysicalPresence (TcgProtocol, PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE, PpiFlags);\r
         PpiFlags->PPFlags &= ~TCG_VENDOR_LIB_FLAG_RESET_TRACK;\r
       }\r
+\r
       return TpmResponse;\r
 \r
     default:\r
       ;\r
   }\r
+\r
   return TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE;\r
 }\r
 \r
-\r
 /**\r
   Read the specified key for user confirmation.\r
 \r
@@ -449,13 +457,13 @@ ExecutePhysicalPresence (
 **/\r
 BOOLEAN\r
 ReadUserKey (\r
-  IN     BOOLEAN                    CautionKey\r
+  IN     BOOLEAN  CautionKey\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_INPUT_KEY                     Key;\r
-  UINT16                            InputKey;\r
-  UINTN                             Index;\r
+  EFI_STATUS     Status;\r
+  EFI_INPUT_KEY  Key;\r
+  UINT16         InputKey;\r
+  UINTN          Index;\r
 \r
   InputKey = 0;\r
   do {\r
@@ -472,9 +480,11 @@ ReadUserKey (
     if (Key.ScanCode == SCAN_ESC) {\r
       InputKey = Key.ScanCode;\r
     }\r
+\r
     if ((Key.ScanCode == SCAN_F10) && !CautionKey) {\r
       InputKey = Key.ScanCode;\r
     }\r
+\r
     if ((Key.ScanCode == SCAN_F12) && CautionKey) {\r
       InputKey = Key.ScanCode;\r
     }\r
@@ -522,16 +532,16 @@ TcgPhysicalPresenceLibConstructor (
 **/\r
 BOOLEAN\r
 UserConfirm (\r
-  IN      UINT32                    TpmPpCommand\r
+  IN      UINT32  TpmPpCommand\r
   )\r
 {\r
-  CHAR16                            *ConfirmText;\r
-  CHAR16                            *TmpStr1;\r
-  CHAR16                            *TmpStr2;\r
-  UINTN                             BufSize;\r
-  BOOLEAN                           CautionKey;\r
-  UINT16                            Index;\r
-  CHAR16                            DstStr[81];\r
+  CHAR16   *ConfirmText;\r
+  CHAR16   *TmpStr1;\r
+  CHAR16   *TmpStr2;\r
+  UINTN    BufSize;\r
+  BOOLEAN  CautionKey;\r
+  UINT16   Index;\r
+  CHAR16   DstStr[81];\r
 \r
   TmpStr2     = NULL;\r
   CautionKey  = FALSE;\r
@@ -598,7 +608,7 @@ UserConfirm (
 \r
     case PHYSICAL_PRESENCE_CLEAR:\r
       CautionKey = TRUE;\r
-      TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR));\r
+      TmpStr2    = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR));\r
 \r
       TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -712,7 +722,7 @@ UserConfirm (
 \r
     case PHYSICAL_PRESENCE_DEFERRED_PP_UNOWNERED_FIELD_UPGRADE:\r
       CautionKey = TRUE;\r
-      TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_UNOWNED_FIELD_UPGRADE));\r
+      TmpStr2    = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_UNOWNED_FIELD_UPGRADE));\r
 \r
       TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_UPGRADE_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -737,7 +747,7 @@ UserConfirm (
 \r
     case PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE:\r
       CautionKey = TRUE;\r
-      TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR_TURN_ON));\r
+      TmpStr2    = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR_TURN_ON));\r
 \r
       TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -778,7 +788,7 @@ UserConfirm (
 \r
     case PHYSICAL_PRESENCE_SET_NO_PPI_CLEAR_TRUE:\r
       CautionKey = TRUE;\r
-      TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR));\r
+      TmpStr2    = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_CLEAR));\r
 \r
       TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_PPI_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -804,7 +814,7 @@ UserConfirm (
 \r
     case PHYSICAL_PRESENCE_SET_NO_PPI_MAINTENANCE_TRUE:\r
       CautionKey = TRUE;\r
-      TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_NO_PPI_MAINTAIN));\r
+      TmpStr2    = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_NO_PPI_MAINTAIN));\r
 \r
       TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_PPI_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -825,7 +835,7 @@ UserConfirm (
 \r
     case PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR:\r
       CautionKey = TRUE;\r
-      TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ENABLE_ACTIVATE_CLEAR));\r
+      TmpStr2    = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ENABLE_ACTIVATE_CLEAR));\r
 \r
       TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -843,7 +853,7 @@ UserConfirm (
 \r
     case PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE:\r
       CautionKey = TRUE;\r
-      TmpStr2 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE));\r
+      TmpStr2    = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE));\r
 \r
       TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_HEAD_STR));\r
       UnicodeSPrint (ConfirmText, BufSize, TmpStr1, TmpStr2);\r
@@ -875,13 +885,13 @@ UserConfirm (
     return FALSE;\r
   }\r
 \r
-  TmpStr1 = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_REJECT_KEY));\r
+  TmpStr1  = PhysicalPresenceGetStringById (STRING_TOKEN (TPM_REJECT_KEY));\r
   BufSize -= StrSize (ConfirmText);\r
   UnicodeSPrint (ConfirmText + StrLen (ConfirmText), BufSize, TmpStr1, TmpStr2);\r
 \r
   DstStr[80] = L'\0';\r
   for (Index = 0; Index < StrLen (ConfirmText); Index += 80) {\r
-    StrnCpyS(DstStr, sizeof (DstStr) / sizeof (CHAR16), ConfirmText + Index, sizeof (DstStr) / sizeof (CHAR16) - 1);\r
+    StrnCpyS (DstStr, sizeof (DstStr) / sizeof (CHAR16), ConfirmText + Index, sizeof (DstStr) / sizeof (CHAR16) - 1);\r
     Print (DstStr);\r
   }\r
 \r
@@ -913,9 +923,9 @@ UserConfirm (
 **/\r
 BOOLEAN\r
 HaveValidTpmRequest  (\r
-  IN      EFI_PHYSICAL_PRESENCE       *TcgPpData,\r
-  IN      EFI_PHYSICAL_PRESENCE_FLAGS Flags,\r
-  OUT     BOOLEAN                     *RequestConfirmed\r
+  IN      EFI_PHYSICAL_PRESENCE        *TcgPpData,\r
+  IN      EFI_PHYSICAL_PRESENCE_FLAGS  Flags,\r
+  OUT     BOOLEAN                      *RequestConfirmed\r
   )\r
 {\r
   BOOLEAN  IsRequestValid;\r
@@ -940,6 +950,7 @@ HaveValidTpmRequest  (
       if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case PHYSICAL_PRESENCE_CLEAR:\r
@@ -947,19 +958,22 @@ HaveValidTpmRequest  (
       if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case PHYSICAL_PRESENCE_DEFERRED_PP_UNOWNERED_FIELD_UPGRADE:\r
       if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_MAINTENANCE) != 0) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE:\r
     case PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE:\r
-      if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0 && (Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0) {\r
+      if (((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0) && ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0)) {\r
         *RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case PHYSICAL_PRESENCE_SET_NO_PPI_PROVISION_FALSE:\r
@@ -1002,7 +1016,6 @@ HaveValidTpmRequest  (
   return TRUE;\r
 }\r
 \r
-\r
 /**\r
   Check and execute the requested physical presence command.\r
 \r
@@ -1017,42 +1030,42 @@ HaveValidTpmRequest  (
 **/\r
 VOID\r
 ExecutePendingTpmRequest (\r
-  IN      EFI_TCG_PROTOCOL            *TcgProtocol,\r
-  IN      EFI_PHYSICAL_PRESENCE       *TcgPpData,\r
-  IN      EFI_PHYSICAL_PRESENCE_FLAGS Flags\r
+  IN      EFI_TCG_PROTOCOL             *TcgProtocol,\r
+  IN      EFI_PHYSICAL_PRESENCE        *TcgPpData,\r
+  IN      EFI_PHYSICAL_PRESENCE_FLAGS  Flags\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINTN                             DataSize;\r
-  BOOLEAN                           RequestConfirmed;\r
-  EFI_PHYSICAL_PRESENCE_FLAGS       NewFlags;\r
-  BOOLEAN                           ResetRequired;\r
-  UINT32                            NewPPFlags;\r
-\r
-  if (!HaveValidTpmRequest(TcgPpData, Flags, &RequestConfirmed)) {\r
+  EFI_STATUS                   Status;\r
+  UINTN                        DataSize;\r
+  BOOLEAN                      RequestConfirmed;\r
+  EFI_PHYSICAL_PRESENCE_FLAGS  NewFlags;\r
+  BOOLEAN                      ResetRequired;\r
+  UINT32                       NewPPFlags;\r
+\r
+  if (!HaveValidTpmRequest (TcgPpData, Flags, &RequestConfirmed)) {\r
     //\r
     // Invalid operation request.\r
     //\r
-    TcgPpData->PPResponse = TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE;\r
+    TcgPpData->PPResponse    = TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE;\r
     TcgPpData->LastPPRequest = TcgPpData->PPRequest;\r
-    TcgPpData->PPRequest = PHYSICAL_PRESENCE_NO_ACTION;\r
-    DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-    Status = gRT->SetVariable (\r
-                    PHYSICAL_PRESENCE_VARIABLE,\r
-                    &gEfiPhysicalPresenceGuid,\r
-                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                    DataSize,\r
-                    TcgPpData\r
-                    );\r
+    TcgPpData->PPRequest     = PHYSICAL_PRESENCE_NO_ACTION;\r
+    DataSize                 = sizeof (EFI_PHYSICAL_PRESENCE);\r
+    Status                   = gRT->SetVariable (\r
+                                      PHYSICAL_PRESENCE_VARIABLE,\r
+                                      &gEfiPhysicalPresenceGuid,\r
+                                      EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                                      DataSize,\r
+                                      TcgPpData\r
+                                      );\r
     return;\r
   }\r
 \r
   ResetRequired = FALSE;\r
   if (TcgPpData->PPRequest >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
-    NewFlags = Flags;\r
-    NewPPFlags = NewFlags.PPFlags;\r
+    NewFlags              = Flags;\r
+    NewPPFlags            = NewFlags.PPFlags;\r
     TcgPpData->PPResponse = TcgPpVendorLibExecutePendingRequest (TcgPpData->PPRequest, &NewPPFlags, &ResetRequired);\r
-    NewFlags.PPFlags = (UINT8)NewPPFlags;\r
+    NewFlags.PPFlags      = (UINT8)NewPPFlags;\r
   } else {\r
     if (!RequestConfirmed) {\r
       //\r
@@ -1065,7 +1078,7 @@ ExecutePendingTpmRequest (
     // Execute requested physical presence command\r
     //\r
     TcgPpData->PPResponse = TCG_PP_OPERATION_RESPONSE_USER_ABORT;\r
-    NewFlags = Flags;\r
+    NewFlags              = Flags;\r
     if (RequestConfirmed) {\r
       TcgPpData->PPResponse = ExecutePhysicalPresence (TcgProtocol, TcgPpData->PPRequest, &NewFlags);\r
     }\r
@@ -1074,14 +1087,14 @@ ExecutePendingTpmRequest (
   //\r
   // Save the flags if it is updated.\r
   //\r
-  if (CompareMem (&Flags, &NewFlags, sizeof(EFI_PHYSICAL_PRESENCE_FLAGS)) != 0) {\r
-    Status   = gRT->SetVariable (\r
-                      PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                      &gEfiPhysicalPresenceGuid,\r
-                      EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                      sizeof (EFI_PHYSICAL_PRESENCE_FLAGS),\r
-                      &NewFlags\r
-                      );\r
+  if (CompareMem (&Flags, &NewFlags, sizeof (EFI_PHYSICAL_PRESENCE_FLAGS)) != 0) {\r
+    Status = gRT->SetVariable (\r
+                    PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                    &gEfiPhysicalPresenceGuid,\r
+                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                    sizeof (EFI_PHYSICAL_PRESENCE_FLAGS),\r
+                    &NewFlags\r
+                    );\r
     if (EFI_ERROR (Status)) {\r
       return;\r
     }\r
@@ -1092,20 +1105,20 @@ ExecutePendingTpmRequest (
   //\r
   if ((NewFlags.PPFlags & TCG_VENDOR_LIB_FLAG_RESET_TRACK) == 0) {\r
     TcgPpData->LastPPRequest = TcgPpData->PPRequest;\r
-    TcgPpData->PPRequest = PHYSICAL_PRESENCE_NO_ACTION;\r
+    TcgPpData->PPRequest     = PHYSICAL_PRESENCE_NO_ACTION;\r
   }\r
 \r
   //\r
   // Save changes\r
   //\r
   DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-  Status = gRT->SetVariable (\r
-                  PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiPhysicalPresenceGuid,\r
-                  EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                  DataSize,\r
-                  TcgPpData\r
-                  );\r
+  Status   = gRT->SetVariable (\r
+                    PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiPhysicalPresenceGuid,\r
+                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                    DataSize,\r
+                    TcgPpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     return;\r
   }\r
@@ -1135,12 +1148,14 @@ ExecutePendingTpmRequest (
         if (ResetRequired) {\r
           break;\r
         } else {\r
-          return ;\r
+          return;\r
         }\r
       }\r
+\r
       if (TcgPpData->PPRequest != PHYSICAL_PRESENCE_NO_ACTION) {\r
         break;\r
       }\r
+\r
       return;\r
   }\r
 \r
@@ -1168,45 +1183,46 @@ TcgPhysicalPresenceLibProcessRequest (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  BOOLEAN                           LifetimeLock;\r
-  BOOLEAN                           CmdEnable;\r
-  UINTN                             DataSize;\r
-  EFI_PHYSICAL_PRESENCE             TcgPpData;\r
-  EFI_TCG_PROTOCOL                  *TcgProtocol;\r
-  EDKII_VARIABLE_LOCK_PROTOCOL      *VariableLockProtocol;\r
-  EFI_PHYSICAL_PRESENCE_FLAGS       PpiFlags;\r
+  EFI_STATUS                    Status;\r
+  BOOLEAN                       LifetimeLock;\r
+  BOOLEAN                       CmdEnable;\r
+  UINTN                         DataSize;\r
+  EFI_PHYSICAL_PRESENCE         TcgPpData;\r
+  EFI_TCG_PROTOCOL              *TcgProtocol;\r
+  EDKII_VARIABLE_LOCK_PROTOCOL  *VariableLockProtocol;\r
+  EFI_PHYSICAL_PRESENCE_FLAGS   PpiFlags;\r
 \r
   Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **)&TcgProtocol);\r
   if (EFI_ERROR (Status)) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   //\r
   // Initialize physical presence flags.\r
   //\r
   DataSize = sizeof (EFI_PHYSICAL_PRESENCE_FLAGS);\r
-  Status = gRT->GetVariable (\r
-                  PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                  &gEfiPhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &PpiFlags\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                    &gEfiPhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &PpiFlags\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     PpiFlags.PPFlags = TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION;\r
-    Status   = gRT->SetVariable (\r
-                      PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                      &gEfiPhysicalPresenceGuid,\r
-                      EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                      sizeof (EFI_PHYSICAL_PRESENCE_FLAGS),\r
-                      &PpiFlags\r
-                      );\r
+    Status           = gRT->SetVariable (\r
+                              PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                              &gEfiPhysicalPresenceGuid,\r
+                              EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                              sizeof (EFI_PHYSICAL_PRESENCE_FLAGS),\r
+                              &PpiFlags\r
+                              );\r
     if (EFI_ERROR (Status)) {\r
       DEBUG ((DEBUG_ERROR, "[TPM] Set physical presence flag failed, Status = %r\n", Status));\r
-      return ;\r
+      return;\r
     }\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "[TPM] PpiFlags = %x\n", PpiFlags.PPFlags));\r
 \r
   //\r
@@ -1230,15 +1246,15 @@ TcgPhysicalPresenceLibProcessRequest (
   // Initialize physical presence variable.\r
   //\r
   DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-  Status = gRT->GetVariable (\r
-                  PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiPhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &TcgPpData\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiPhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &TcgPpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
-    ZeroMem ((VOID*)&TcgPpData, sizeof (TcgPpData));\r
+    ZeroMem ((VOID *)&TcgPpData, sizeof (TcgPpData));\r
     DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
     Status   = gRT->SetVariable (\r
                       PHYSICAL_PRESENCE_VARIABLE,\r
@@ -1264,7 +1280,7 @@ TcgPhysicalPresenceLibProcessRequest (
 \r
   Status = GetTpmCapability (TcgProtocol, &LifetimeLock, &CmdEnable);\r
   if (EFI_ERROR (Status)) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   if (!CmdEnable) {\r
@@ -1272,11 +1288,12 @@ TcgPhysicalPresenceLibProcessRequest (
       //\r
       // physicalPresenceCMDEnable is locked, can't execute physical presence command.\r
       //\r
-      return ;\r
+      return;\r
     }\r
+\r
     Status = TpmPhysicalPresence (TcgProtocol, TPM_PHYSICAL_PRESENCE_CMD_ENABLE);\r
     if (EFI_ERROR (Status)) {\r
-      return ;\r
+      return;\r
     }\r
   }\r
 \r
@@ -1312,7 +1329,7 @@ TcgPhysicalPresenceLibProcessRequest (
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgPhysicalPresenceLibNeedUserConfirm(\r
+TcgPhysicalPresenceLibNeedUserConfirm (\r
   VOID\r
   )\r
 {\r
@@ -1334,25 +1351,25 @@ TcgPhysicalPresenceLibNeedUserConfirm(
   // Check Tpm requests\r
   //\r
   DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-  Status = gRT->GetVariable (\r
-                  PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiPhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &TcgPpData\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiPhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &TcgPpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     return FALSE;\r
   }\r
 \r
   DataSize = sizeof (EFI_PHYSICAL_PRESENCE_FLAGS);\r
-  Status = gRT->GetVariable (\r
-                  PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                  &gEfiPhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &PpiFlags\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                    &gEfiPhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &PpiFlags\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     return FALSE;\r
   }\r
@@ -1364,7 +1381,7 @@ TcgPhysicalPresenceLibNeedUserConfirm(
     return FALSE;\r
   }\r
 \r
-  if (!HaveValidTpmRequest(&TcgPpData, PpiFlags, &RequestConfirmed)) {\r
+  if (!HaveValidTpmRequest (&TcgPpData, PpiFlags, &RequestConfirmed)) {\r
     //\r
     // Invalid operation request.\r
     //\r
index 95682ac5675b84d991e45550cd910d629acfa2c1..f73b43aa602092a93e7aa6c92f1f398b078a0c12 100644 (file)
@@ -45,15 +45,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Flag to check GPT partition. It only need be measured once.\r
 //\r
-BOOLEAN                           mTcg2MeasureGptTableFlag = FALSE;\r
-UINTN                             mTcg2MeasureGptCount = 0;\r
-VOID                              *mTcg2FileBuffer;\r
-UINTN                             mTcg2ImageSize;\r
+BOOLEAN  mTcg2MeasureGptTableFlag = FALSE;\r
+UINTN    mTcg2MeasureGptCount     = 0;\r
+VOID     *mTcg2FileBuffer;\r
+UINTN    mTcg2ImageSize;\r
 //\r
 // Measured FV handle cache\r
 //\r
-EFI_HANDLE                        mTcg2CacheMeasuredHandle  = NULL;\r
-MEASURED_HOB_DATA                 *mTcg2MeasuredHobData     = NULL;\r
+EFI_HANDLE         mTcg2CacheMeasuredHandle = NULL;\r
+MEASURED_HOB_DATA  *mTcg2MeasuredHobData    = NULL;\r
 \r
 /**\r
   Reads contents of a PE/COFF image in memory buffer.\r
@@ -73,15 +73,15 @@ MEASURED_HOB_DATA                 *mTcg2MeasuredHobData     = NULL;
 EFI_STATUS\r
 EFIAPI\r
 DxeTpm2MeasureBootLibImageRead (\r
-  IN     VOID    *FileHandle,\r
-  IN     UINTN   FileOffset,\r
-  IN OUT UINTN   *ReadSize,\r
-  OUT    VOID    *Buffer\r
+  IN     VOID   *FileHandle,\r
+  IN     UINTN  FileOffset,\r
+  IN OUT UINTN  *ReadSize,\r
+  OUT    VOID   *Buffer\r
   )\r
 {\r
-  UINTN               EndPosition;\r
+  UINTN  EndPosition;\r
 \r
-  if (FileHandle == NULL || ReadSize == NULL || Buffer == NULL) {\r
+  if ((FileHandle == NULL) || (ReadSize == NULL) || (Buffer == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -98,7 +98,7 @@ DxeTpm2MeasureBootLibImageRead (
     *ReadSize = 0;\r
   }\r
 \r
-  CopyMem (Buffer, (UINT8 *)((UINTN) FileHandle + FileOffset), *ReadSize);\r
+  CopyMem (Buffer, (UINT8 *)((UINTN)FileHandle + FileOffset), *ReadSize);\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -125,37 +125,40 @@ Tcg2MeasureGptTable (
   IN  EFI_HANDLE         GptHandle\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_BLOCK_IO_PROTOCOL             *BlockIo;\r
-  EFI_DISK_IO_PROTOCOL              *DiskIo;\r
-  EFI_PARTITION_TABLE_HEADER        *PrimaryHeader;\r
-  EFI_PARTITION_ENTRY               *PartitionEntry;\r
-  UINT8                             *EntryPtr;\r
-  UINTN                             NumberOfPartition;\r
-  UINT32                            Index;\r
-  EFI_TCG2_EVENT                    *Tcg2Event;\r
-  EFI_GPT_DATA                      *GptData;\r
-  UINT32                            EventSize;\r
+  EFI_STATUS                  Status;\r
+  EFI_BLOCK_IO_PROTOCOL       *BlockIo;\r
+  EFI_DISK_IO_PROTOCOL        *DiskIo;\r
+  EFI_PARTITION_TABLE_HEADER  *PrimaryHeader;\r
+  EFI_PARTITION_ENTRY         *PartitionEntry;\r
+  UINT8                       *EntryPtr;\r
+  UINTN                       NumberOfPartition;\r
+  UINT32                      Index;\r
+  EFI_TCG2_EVENT              *Tcg2Event;\r
+  EFI_GPT_DATA                *GptData;\r
+  UINT32                      EventSize;\r
 \r
   if (mTcg2MeasureGptCount > 0) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  Status = gBS->HandleProtocol (GptHandle, &gEfiBlockIoProtocolGuid, (VOID**)&BlockIo);\r
+  Status = gBS->HandleProtocol (GptHandle, &gEfiBlockIoProtocolGuid, (VOID **)&BlockIo);\r
   if (EFI_ERROR (Status)) {\r
     return EFI_UNSUPPORTED;\r
   }\r
-  Status = gBS->HandleProtocol (GptHandle, &gEfiDiskIoProtocolGuid, (VOID**)&DiskIo);\r
+\r
+  Status = gBS->HandleProtocol (GptHandle, &gEfiDiskIoProtocolGuid, (VOID **)&DiskIo);\r
   if (EFI_ERROR (Status)) {\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   //\r
   // Read the EFI Partition Table Header\r
   //\r
-  PrimaryHeader = (EFI_PARTITION_TABLE_HEADER *) AllocatePool (BlockIo->Media->BlockSize);\r
+  PrimaryHeader = (EFI_PARTITION_TABLE_HEADER *)AllocatePool (BlockIo->Media->BlockSize);\r
   if (PrimaryHeader == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
+\r
   Status = DiskIo->ReadDisk (\r
                      DiskIo,\r
                      BlockIo->Media->MediaId,\r
@@ -168,6 +171,7 @@ Tcg2MeasureGptTable (
     FreePool (PrimaryHeader);\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   //\r
   // Read the partition entry.\r
   //\r
@@ -176,10 +180,11 @@ Tcg2MeasureGptTable (
     FreePool (PrimaryHeader);\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
+\r
   Status = DiskIo->ReadDisk (\r
                      DiskIo,\r
                      BlockIo->Media->MediaId,\r
-                     MultU64x32(PrimaryHeader->PartitionEntryLBA, BlockIo->Media->BlockSize),\r
+                     MultU64x32 (PrimaryHeader->PartitionEntryLBA, BlockIo->Media->BlockSize),\r
                      PrimaryHeader->NumberOfPartitionEntries * PrimaryHeader->SizeOfPartitionEntry,\r
                      EntryPtr\r
                      );\r
@@ -198,6 +203,7 @@ Tcg2MeasureGptTable (
     if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) {\r
       NumberOfPartition++;\r
     }\r
+\r
     PartitionEntry = (EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry);\r
   }\r
 \r
@@ -205,30 +211,30 @@ Tcg2MeasureGptTable (
   // Prepare Data for Measurement\r
   //\r
   EventSize = (UINT32)(sizeof (EFI_GPT_DATA) - sizeof (GptData->Partitions)\r
-                        + NumberOfPartition * PrimaryHeader->SizeOfPartitionEntry);\r
-  Tcg2Event = (EFI_TCG2_EVENT *) AllocateZeroPool (EventSize + sizeof (EFI_TCG2_EVENT) - sizeof(Tcg2Event->Event));\r
+                       + NumberOfPartition * PrimaryHeader->SizeOfPartitionEntry);\r
+  Tcg2Event = (EFI_TCG2_EVENT *)AllocateZeroPool (EventSize + sizeof (EFI_TCG2_EVENT) - sizeof (Tcg2Event->Event));\r
   if (Tcg2Event == NULL) {\r
     FreePool (PrimaryHeader);\r
     FreePool (EntryPtr);\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  Tcg2Event->Size = EventSize + sizeof (EFI_TCG2_EVENT) - sizeof(Tcg2Event->Event);\r
-  Tcg2Event->Header.HeaderSize    = sizeof(EFI_TCG2_EVENT_HEADER);\r
+  Tcg2Event->Size                 = EventSize + sizeof (EFI_TCG2_EVENT) - sizeof (Tcg2Event->Event);\r
+  Tcg2Event->Header.HeaderSize    = sizeof (EFI_TCG2_EVENT_HEADER);\r
   Tcg2Event->Header.HeaderVersion = EFI_TCG2_EVENT_HEADER_VERSION;\r
   Tcg2Event->Header.PCRIndex      = 5;\r
   Tcg2Event->Header.EventType     = EV_EFI_GPT_EVENT;\r
-  GptData = (EFI_GPT_DATA *) Tcg2Event->Event;\r
+  GptData                         = (EFI_GPT_DATA *)Tcg2Event->Event;\r
 \r
   //\r
   // Copy the EFI_PARTITION_TABLE_HEADER and NumberOfPartition\r
   //\r
-  CopyMem ((UINT8 *)GptData, (UINT8*)PrimaryHeader, sizeof (EFI_PARTITION_TABLE_HEADER));\r
+  CopyMem ((UINT8 *)GptData, (UINT8 *)PrimaryHeader, sizeof (EFI_PARTITION_TABLE_HEADER));\r
   GptData->NumberOfPartitions = NumberOfPartition;\r
   //\r
   // Copy the valid partition entry\r
   //\r
-  PartitionEntry    = (EFI_PARTITION_ENTRY*)EntryPtr;\r
+  PartitionEntry    = (EFI_PARTITION_ENTRY *)EntryPtr;\r
   NumberOfPartition = 0;\r
   for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) {\r
     if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) {\r
@@ -239,19 +245,20 @@ Tcg2MeasureGptTable (
         );\r
       NumberOfPartition++;\r
     }\r
-    PartitionEntry =(EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry);\r
+\r
+    PartitionEntry = (EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry);\r
   }\r
 \r
   //\r
   // Measure the GPT data\r
   //\r
   Status = Tcg2Protocol->HashLogExtendEvent (\r
-             Tcg2Protocol,\r
-             0,\r
-             (EFI_PHYSICAL_ADDRESS) (UINTN) (VOID *) GptData,\r
-             (UINT64) EventSize,\r
-             Tcg2Event\r
-             );\r
+                           Tcg2Protocol,\r
+                           0,\r
+                           (EFI_PHYSICAL_ADDRESS)(UINTN)(VOID *)GptData,\r
+                           (UINT64)EventSize,\r
+                           Tcg2Event\r
+                           );\r
   if (!EFI_ERROR (Status)) {\r
     mTcg2MeasureGptCount++;\r
   }\r
@@ -295,29 +302,29 @@ Tcg2MeasurePeImage (
   IN  EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_TCG2_EVENT                    *Tcg2Event;\r
-  EFI_IMAGE_LOAD_EVENT              *ImageLoad;\r
-  UINT32                            FilePathSize;\r
-  UINT32                            EventSize;\r
+  EFI_STATUS            Status;\r
+  EFI_TCG2_EVENT        *Tcg2Event;\r
+  EFI_IMAGE_LOAD_EVENT  *ImageLoad;\r
+  UINT32                FilePathSize;\r
+  UINT32                EventSize;\r
 \r
-  Status        = EFI_UNSUPPORTED;\r
-  ImageLoad     = NULL;\r
-  FilePathSize  = (UINT32) GetDevicePathSize (FilePath);\r
+  Status       = EFI_UNSUPPORTED;\r
+  ImageLoad    = NULL;\r
+  FilePathSize = (UINT32)GetDevicePathSize (FilePath);\r
 \r
   //\r
   // Determine destination PCR by BootPolicy\r
   //\r
   EventSize = sizeof (*ImageLoad) - sizeof (ImageLoad->DevicePath) + FilePathSize;\r
-  Tcg2Event = AllocateZeroPool (EventSize + sizeof (EFI_TCG2_EVENT) - sizeof(Tcg2Event->Event));\r
+  Tcg2Event = AllocateZeroPool (EventSize + sizeof (EFI_TCG2_EVENT) - sizeof (Tcg2Event->Event));\r
   if (Tcg2Event == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  Tcg2Event->Size = EventSize + sizeof (EFI_TCG2_EVENT) - sizeof(Tcg2Event->Event);\r
-  Tcg2Event->Header.HeaderSize    = sizeof(EFI_TCG2_EVENT_HEADER);\r
+  Tcg2Event->Size                 = EventSize + sizeof (EFI_TCG2_EVENT) - sizeof (Tcg2Event->Event);\r
+  Tcg2Event->Header.HeaderSize    = sizeof (EFI_TCG2_EVENT_HEADER);\r
   Tcg2Event->Header.HeaderVersion = EFI_TCG2_EVENT_HEADER_VERSION;\r
-  ImageLoad           = (EFI_IMAGE_LOAD_EVENT *) Tcg2Event->Event;\r
+  ImageLoad                       = (EFI_IMAGE_LOAD_EVENT *)Tcg2Event->Event;\r
 \r
   switch (ImageType) {\r
     case EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION:\r
@@ -353,12 +360,12 @@ Tcg2MeasurePeImage (
   // Log the PE data\r
   //\r
   Status = Tcg2Protocol->HashLogExtendEvent (\r
-             Tcg2Protocol,\r
-             PE_COFF_IMAGE,\r
-             ImageAddress,\r
-             ImageSize,\r
-             Tcg2Event\r
-             );\r
+                           Tcg2Protocol,\r
+                           PE_COFF_IMAGE,\r
+                           ImageAddress,\r
+                           ImageSize,\r
+                           Tcg2Event\r
+                           );\r
   if (Status == EFI_VOLUME_FULL) {\r
     //\r
     // Volume full here means the image is hashed and its result is extended to PCR.\r
@@ -415,11 +422,11 @@ Finish:
 EFI_STATUS\r
 EFIAPI\r
 DxeTpm2MeasureBootHandler (\r
-  IN  UINT32                           AuthenticationStatus,\r
-  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File  OPTIONAL,\r
-  IN  VOID                             *FileBuffer,\r
-  IN  UINTN                            FileSize,\r
-  IN  BOOLEAN                          BootPolicy\r
+  IN  UINT32                          AuthenticationStatus,\r
+  IN  CONST EFI_DEVICE_PATH_PROTOCOL  *File  OPTIONAL,\r
+  IN  VOID                            *FileBuffer,\r
+  IN  UINTN                           FileSize,\r
+  IN  BOOLEAN                         BootPolicy\r
   )\r
 {\r
   EFI_TCG2_PROTOCOL                   *Tcg2Protocol;\r
@@ -435,7 +442,7 @@ DxeTpm2MeasureBootHandler (
   EFI_PHYSICAL_ADDRESS                FvAddress;\r
   UINT32                              Index;\r
 \r
-  Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **) &Tcg2Protocol);\r
+  Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **)&Tcg2Protocol);\r
   if (EFI_ERROR (Status)) {\r
     //\r
     // Tcg2 protocol is not installed. So, TPM2 is not present.\r
@@ -445,11 +452,11 @@ DxeTpm2MeasureBootHandler (
     return EFI_SUCCESS;\r
   }\r
 \r
-  ProtocolCapability.Size = (UINT8) sizeof (ProtocolCapability);\r
-  Status = Tcg2Protocol->GetCapability (\r
-                           Tcg2Protocol,\r
-                           &ProtocolCapability\r
-                           );\r
+  ProtocolCapability.Size = (UINT8)sizeof (ProtocolCapability);\r
+  Status                  = Tcg2Protocol->GetCapability (\r
+                                            Tcg2Protocol,\r
+                                            &ProtocolCapability\r
+                                            );\r
   if (EFI_ERROR (Status) || (!ProtocolCapability.TPMPresentFlag)) {\r
     //\r
     // TPM device doesn't work or activate.\r
@@ -468,7 +475,7 @@ DxeTpm2MeasureBootHandler (
   // Is so, this device path may be a GPT device path.\r
   //\r
   DevicePathNode = OrigDevicePathNode;\r
-  Status = gBS->LocateDevicePath (&gEfiBlockIoProtocolGuid, &DevicePathNode, &Handle);\r
+  Status         = gBS->LocateDevicePath (&gEfiBlockIoProtocolGuid, &DevicePathNode, &Handle);\r
   if (!EFI_ERROR (Status) && !mTcg2MeasureGptTableFlag) {\r
     //\r
     // Find the gpt partition on the given devicepath\r
@@ -479,25 +486,26 @@ DxeTpm2MeasureBootHandler (
       //\r
       // Find the Gpt partition\r
       //\r
-      if (DevicePathType (DevicePathNode) == MEDIA_DEVICE_PATH &&\r
-            DevicePathSubType (DevicePathNode) == MEDIA_HARDDRIVE_DP) {\r
+      if ((DevicePathType (DevicePathNode) == MEDIA_DEVICE_PATH) &&\r
+          (DevicePathSubType (DevicePathNode) == MEDIA_HARDDRIVE_DP))\r
+      {\r
         //\r
         // Check whether it is a gpt partition or not\r
         //\r
-        if (((HARDDRIVE_DEVICE_PATH *) DevicePathNode)->MBRType == MBR_TYPE_EFI_PARTITION_TABLE_HEADER &&\r
-            ((HARDDRIVE_DEVICE_PATH *) DevicePathNode)->SignatureType == SIGNATURE_TYPE_GUID) {\r
-\r
+        if ((((HARDDRIVE_DEVICE_PATH *)DevicePathNode)->MBRType == MBR_TYPE_EFI_PARTITION_TABLE_HEADER) &&\r
+            (((HARDDRIVE_DEVICE_PATH *)DevicePathNode)->SignatureType == SIGNATURE_TYPE_GUID))\r
+        {\r
           //\r
           // Change the partition device path to its parent device path (disk) and get the handle.\r
           //\r
           DevicePathNode->Type    = END_DEVICE_PATH_TYPE;\r
           DevicePathNode->SubType = END_ENTIRE_DEVICE_PATH_SUBTYPE;\r
           DevicePathNode          = OrigDevicePathNode;\r
-          Status = gBS->LocateDevicePath (\r
-                         &gEfiDiskIoProtocolGuid,\r
-                         &DevicePathNode,\r
-                         &Handle\r
-                         );\r
+          Status                  = gBS->LocateDevicePath (\r
+                                           &gEfiDiskIoProtocolGuid,\r
+                                           &DevicePathNode,\r
+                                           &Handle\r
+                                           );\r
           if (!EFI_ERROR (Status)) {\r
             //\r
             // Measure GPT disk.\r
@@ -511,13 +519,15 @@ DxeTpm2MeasureBootHandler (
               mTcg2MeasureGptTableFlag = TRUE;\r
             }\r
           }\r
+\r
           FreePool (OrigDevicePathNode);\r
           OrigDevicePathNode = DuplicateDevicePath (File);\r
           ASSERT (OrigDevicePathNode != NULL);\r
           break;\r
         }\r
       }\r
-      DevicePathNode    = NextDevicePathNode (DevicePathNode);\r
+\r
+      DevicePathNode = NextDevicePathNode (DevicePathNode);\r
     }\r
   }\r
 \r
@@ -530,7 +540,7 @@ DxeTpm2MeasureBootHandler (
   // Check whether this device path support FVB protocol.\r
   //\r
   DevicePathNode = OrigDevicePathNode;\r
-  Status = gBS->LocateDevicePath (&gEfiFirmwareVolumeBlockProtocolGuid, &DevicePathNode, &Handle);\r
+  Status         = gBS->LocateDevicePath (&gEfiFirmwareVolumeBlockProtocolGuid, &DevicePathNode, &Handle);\r
   if (!EFI_ERROR (Status)) {\r
     //\r
     // Don't check FV image, and directly return EFI_SUCCESS.\r
@@ -539,6 +549,7 @@ DxeTpm2MeasureBootHandler (
     if (IsDevicePathEnd (DevicePathNode)) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     //\r
     // The PE image from unmeasured Firmware volume need be measured\r
     // The PE image from measured Firmware volume will be measured according to policy below.\r
@@ -547,37 +558,37 @@ DxeTpm2MeasureBootHandler (
     //\r
     ApplicationRequired = TRUE;\r
 \r
-    if (mTcg2CacheMeasuredHandle != Handle && mTcg2MeasuredHobData != NULL) {\r
+    if ((mTcg2CacheMeasuredHandle != Handle) && (mTcg2MeasuredHobData != NULL)) {\r
       //\r
       // Search for Root FV of this PE image\r
       //\r
       TempHandle = Handle;\r
       do {\r
-        Status = gBS->HandleProtocol(\r
+        Status = gBS->HandleProtocol (\r
                         TempHandle,\r
                         &gEfiFirmwareVolumeBlockProtocolGuid,\r
-                        (VOID**)&FvbProtocol\r
+                        (VOID **)&FvbProtocol\r
                         );\r
         TempHandle = FvbProtocol->ParentHandle;\r
-      } while (!EFI_ERROR(Status) && FvbProtocol->ParentHandle != NULL);\r
+      } while (!EFI_ERROR (Status) && FvbProtocol->ParentHandle != NULL);\r
 \r
       //\r
       // Search in measured FV Hob\r
       //\r
-      Status = FvbProtocol->GetPhysicalAddress(FvbProtocol, &FvAddress);\r
-      if (EFI_ERROR(Status)){\r
+      Status = FvbProtocol->GetPhysicalAddress (FvbProtocol, &FvAddress);\r
+      if (EFI_ERROR (Status)) {\r
         return Status;\r
       }\r
 \r
       ApplicationRequired = FALSE;\r
 \r
       for (Index = 0; Index < mTcg2MeasuredHobData->Num; Index++) {\r
-        if(mTcg2MeasuredHobData->MeasuredFvBuf[Index].BlobBase == FvAddress) {\r
+        if (mTcg2MeasuredHobData->MeasuredFvBuf[Index].BlobBase == FvAddress) {\r
           //\r
           // Cache measured FV for next measurement\r
           //\r
           mTcg2CacheMeasuredHandle = Handle;\r
-          ApplicationRequired  = TRUE;\r
+          ApplicationRequired      = TRUE;\r
           break;\r
         }\r
       }\r
@@ -600,8 +611,8 @@ DxeTpm2MeasureBootHandler (
   //\r
   DevicePathNode = OrigDevicePathNode;\r
   ZeroMem (&ImageContext, sizeof (ImageContext));\r
-  ImageContext.Handle    = (VOID *) FileBuffer;\r
-  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE) DxeTpm2MeasureBootLibImageRead;\r
+  ImageContext.Handle    = (VOID *)FileBuffer;\r
+  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE)DxeTpm2MeasureBootLibImageRead;\r
 \r
   //\r
   // Get information about the image being loaded\r
@@ -626,21 +637,23 @@ DxeTpm2MeasureBootHandler (
   // Measure drivers and applications if Application flag is not set\r
   //\r
   if ((!ApplicationRequired) ||\r
-        (ApplicationRequired && ImageContext.ImageType == EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION)) {\r
+      (ApplicationRequired && (ImageContext.ImageType == EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION)))\r
+  {\r
     //\r
     // Print the image path to be measured.\r
     //\r
     DEBUG_CODE_BEGIN ();\r
-      CHAR16                            *ToText;\r
-      ToText = ConvertDevicePathToText (\r
-                 DevicePathNode,\r
-                 FALSE,\r
-                 TRUE\r
-                 );\r
-      if (ToText != NULL) {\r
-        DEBUG ((DEBUG_INFO, "The measured image path is %s.\n", ToText));\r
-        FreePool (ToText);\r
-      }\r
+    CHAR16  *ToText;\r
+    ToText = ConvertDevicePathToText (\r
+               DevicePathNode,\r
+               FALSE,\r
+               TRUE\r
+               );\r
+    if (ToText != NULL) {\r
+      DEBUG ((DEBUG_INFO, "The measured image path is %s.\n", ToText));\r
+      FreePool (ToText);\r
+    }\r
+\r
     DEBUG_CODE_END ();\r
 \r
     //\r
@@ -648,9 +661,9 @@ DxeTpm2MeasureBootHandler (
     //\r
     Status = Tcg2MeasurePeImage (\r
                Tcg2Protocol,\r
-               (EFI_PHYSICAL_ADDRESS) (UINTN) FileBuffer,\r
+               (EFI_PHYSICAL_ADDRESS)(UINTN)FileBuffer,\r
                FileSize,\r
-               (UINTN) ImageContext.ImageAddress,\r
+               (UINTN)ImageContext.ImageAddress,\r
                ImageContext.ImageType,\r
                DevicePathNode\r
                );\r
@@ -697,7 +710,7 @@ DxeTpm2MeasureBootLibConstructor (
   }\r
 \r
   return RegisterSecurity2Handler (\r
-          DxeTpm2MeasureBootHandler,\r
-          EFI_AUTH_OPERATION_MEASURE_IMAGE | EFI_AUTH_OPERATION_IMAGE_REQUIRED\r
-          );\r
+           DxeTpm2MeasureBootHandler,\r
+           EFI_AUTH_OPERATION_MEASURE_IMAGE | EFI_AUTH_OPERATION_IMAGE_REQUIRED\r
+           );\r
 }\r
index 27c0ea48cab975e4013bef48f53c4f0a2dda93bc..220393dd2beb6270da17d29b726ef725be7dd0e4 100644 (file)
@@ -43,15 +43,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Flag to check GPT partition. It only need be measured once.\r
 //\r
-BOOLEAN                           mMeasureGptTableFlag = FALSE;\r
-UINTN                             mMeasureGptCount = 0;\r
-VOID                              *mFileBuffer;\r
-UINTN                             mTpmImageSize;\r
+BOOLEAN  mMeasureGptTableFlag = FALSE;\r
+UINTN    mMeasureGptCount     = 0;\r
+VOID     *mFileBuffer;\r
+UINTN    mTpmImageSize;\r
 //\r
 // Measured FV handle cache\r
 //\r
-EFI_HANDLE                        mCacheMeasuredHandle  = NULL;\r
-MEASURED_HOB_DATA                 *mMeasuredHobData     = NULL;\r
+EFI_HANDLE         mCacheMeasuredHandle = NULL;\r
+MEASURED_HOB_DATA  *mMeasuredHobData    = NULL;\r
 \r
 /**\r
   Reads contents of a PE/COFF image in memory buffer.\r
@@ -71,15 +71,15 @@ MEASURED_HOB_DATA                 *mMeasuredHobData     = NULL;
 EFI_STATUS\r
 EFIAPI\r
 DxeTpmMeasureBootLibImageRead (\r
-  IN     VOID    *FileHandle,\r
-  IN     UINTN   FileOffset,\r
-  IN OUT UINTN   *ReadSize,\r
-  OUT    VOID    *Buffer\r
+  IN     VOID   *FileHandle,\r
+  IN     UINTN  FileOffset,\r
+  IN OUT UINTN  *ReadSize,\r
+  OUT    VOID   *Buffer\r
   )\r
 {\r
-  UINTN               EndPosition;\r
+  UINTN  EndPosition;\r
 \r
-  if (FileHandle == NULL || ReadSize == NULL || Buffer == NULL) {\r
+  if ((FileHandle == NULL) || (ReadSize == NULL) || (Buffer == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -96,7 +96,7 @@ DxeTpmMeasureBootLibImageRead (
     *ReadSize = 0;\r
   }\r
 \r
-  CopyMem (Buffer, (UINT8 *)((UINTN) FileHandle + FileOffset), *ReadSize);\r
+  CopyMem (Buffer, (UINT8 *)((UINTN)FileHandle + FileOffset), *ReadSize);\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -119,43 +119,46 @@ DxeTpmMeasureBootLibImageRead (
 EFI_STATUS\r
 EFIAPI\r
 TcgMeasureGptTable (\r
-  IN  EFI_TCG_PROTOCOL   *TcgProtocol,\r
-  IN  EFI_HANDLE         GptHandle\r
+  IN  EFI_TCG_PROTOCOL  *TcgProtocol,\r
+  IN  EFI_HANDLE        GptHandle\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_BLOCK_IO_PROTOCOL             *BlockIo;\r
-  EFI_DISK_IO_PROTOCOL              *DiskIo;\r
-  EFI_PARTITION_TABLE_HEADER        *PrimaryHeader;\r
-  EFI_PARTITION_ENTRY               *PartitionEntry;\r
-  UINT8                             *EntryPtr;\r
-  UINTN                             NumberOfPartition;\r
-  UINT32                            Index;\r
-  TCG_PCR_EVENT                     *TcgEvent;\r
-  EFI_GPT_DATA                      *GptData;\r
-  UINT32                            EventSize;\r
-  UINT32                            EventNumber;\r
-  EFI_PHYSICAL_ADDRESS              EventLogLastEntry;\r
+  EFI_STATUS                  Status;\r
+  EFI_BLOCK_IO_PROTOCOL       *BlockIo;\r
+  EFI_DISK_IO_PROTOCOL        *DiskIo;\r
+  EFI_PARTITION_TABLE_HEADER  *PrimaryHeader;\r
+  EFI_PARTITION_ENTRY         *PartitionEntry;\r
+  UINT8                       *EntryPtr;\r
+  UINTN                       NumberOfPartition;\r
+  UINT32                      Index;\r
+  TCG_PCR_EVENT               *TcgEvent;\r
+  EFI_GPT_DATA                *GptData;\r
+  UINT32                      EventSize;\r
+  UINT32                      EventNumber;\r
+  EFI_PHYSICAL_ADDRESS        EventLogLastEntry;\r
 \r
   if (mMeasureGptCount > 0) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  Status = gBS->HandleProtocol (GptHandle, &gEfiBlockIoProtocolGuid, (VOID**)&BlockIo);\r
+  Status = gBS->HandleProtocol (GptHandle, &gEfiBlockIoProtocolGuid, (VOID **)&BlockIo);\r
   if (EFI_ERROR (Status)) {\r
     return EFI_UNSUPPORTED;\r
   }\r
-  Status = gBS->HandleProtocol (GptHandle, &gEfiDiskIoProtocolGuid, (VOID**)&DiskIo);\r
+\r
+  Status = gBS->HandleProtocol (GptHandle, &gEfiDiskIoProtocolGuid, (VOID **)&DiskIo);\r
   if (EFI_ERROR (Status)) {\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   //\r
   // Read the EFI Partition Table Header\r
   //\r
-  PrimaryHeader = (EFI_PARTITION_TABLE_HEADER *) AllocatePool (BlockIo->Media->BlockSize);\r
+  PrimaryHeader = (EFI_PARTITION_TABLE_HEADER *)AllocatePool (BlockIo->Media->BlockSize);\r
   if (PrimaryHeader == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
+\r
   Status = DiskIo->ReadDisk (\r
                      DiskIo,\r
                      BlockIo->Media->MediaId,\r
@@ -168,6 +171,7 @@ TcgMeasureGptTable (
     FreePool (PrimaryHeader);\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   //\r
   // Read the partition entry.\r
   //\r
@@ -176,10 +180,11 @@ TcgMeasureGptTable (
     FreePool (PrimaryHeader);\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
+\r
   Status = DiskIo->ReadDisk (\r
                      DiskIo,\r
                      BlockIo->Media->MediaId,\r
-                     MultU64x32(PrimaryHeader->PartitionEntryLBA, BlockIo->Media->BlockSize),\r
+                     MultU64x32 (PrimaryHeader->PartitionEntryLBA, BlockIo->Media->BlockSize),\r
                      PrimaryHeader->NumberOfPartitionEntries * PrimaryHeader->SizeOfPartitionEntry,\r
                      EntryPtr\r
                      );\r
@@ -198,6 +203,7 @@ TcgMeasureGptTable (
     if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) {\r
       NumberOfPartition++;\r
     }\r
+\r
     PartitionEntry = (EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry);\r
   }\r
 \r
@@ -205,28 +211,28 @@ TcgMeasureGptTable (
   // Prepare Data for Measurement\r
   //\r
   EventSize = (UINT32)(sizeof (EFI_GPT_DATA) - sizeof (GptData->Partitions)\r
-                        + NumberOfPartition * PrimaryHeader->SizeOfPartitionEntry);\r
-  TcgEvent = (TCG_PCR_EVENT *) AllocateZeroPool (EventSize + sizeof (TCG_PCR_EVENT_HDR));\r
+                       + NumberOfPartition * PrimaryHeader->SizeOfPartitionEntry);\r
+  TcgEvent = (TCG_PCR_EVENT *)AllocateZeroPool (EventSize + sizeof (TCG_PCR_EVENT_HDR));\r
   if (TcgEvent == NULL) {\r
     FreePool (PrimaryHeader);\r
     FreePool (EntryPtr);\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  TcgEvent->PCRIndex   = 5;\r
-  TcgEvent->EventType  = EV_EFI_GPT_EVENT;\r
-  TcgEvent->EventSize  = EventSize;\r
-  GptData = (EFI_GPT_DATA *) TcgEvent->Event;\r
+  TcgEvent->PCRIndex  = 5;\r
+  TcgEvent->EventType = EV_EFI_GPT_EVENT;\r
+  TcgEvent->EventSize = EventSize;\r
+  GptData             = (EFI_GPT_DATA *)TcgEvent->Event;\r
 \r
   //\r
   // Copy the EFI_PARTITION_TABLE_HEADER and NumberOfPartition\r
   //\r
-  CopyMem ((UINT8 *)GptData, (UINT8*)PrimaryHeader, sizeof (EFI_PARTITION_TABLE_HEADER));\r
+  CopyMem ((UINT8 *)GptData, (UINT8 *)PrimaryHeader, sizeof (EFI_PARTITION_TABLE_HEADER));\r
   GptData->NumberOfPartitions = NumberOfPartition;\r
   //\r
   // Copy the valid partition entry\r
   //\r
-  PartitionEntry    = (EFI_PARTITION_ENTRY*)EntryPtr;\r
+  PartitionEntry    = (EFI_PARTITION_ENTRY *)EntryPtr;\r
   NumberOfPartition = 0;\r
   for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) {\r
     if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) {\r
@@ -237,22 +243,23 @@ TcgMeasureGptTable (
         );\r
       NumberOfPartition++;\r
     }\r
-    PartitionEntry =(EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry);\r
+\r
+    PartitionEntry = (EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry);\r
   }\r
 \r
   //\r
   // Measure the GPT data\r
   //\r
   EventNumber = 1;\r
-  Status = TcgProtocol->HashLogExtendEvent (\r
-             TcgProtocol,\r
-             (EFI_PHYSICAL_ADDRESS) (UINTN) (VOID *) GptData,\r
-             (UINT64) TcgEvent->EventSize,\r
-             TPM_ALG_SHA,\r
-             TcgEvent,\r
-             &EventNumber,\r
-             &EventLogLastEntry\r
-             );\r
+  Status      = TcgProtocol->HashLogExtendEvent (\r
+                               TcgProtocol,\r
+                               (EFI_PHYSICAL_ADDRESS)(UINTN)(VOID *)GptData,\r
+                               (UINT64)TcgEvent->EventSize,\r
+                               TPM_ALG_SHA,\r
+                               TcgEvent,\r
+                               &EventNumber,\r
+                               &EventLogLastEntry\r
+                               );\r
   if (!EFI_ERROR (Status)) {\r
     mMeasureGptCount++;\r
   }\r
@@ -326,19 +333,19 @@ TcgMeasurePeImage (
   ImageLoad     = NULL;\r
   SectionHeader = NULL;\r
   Sha1Ctx       = NULL;\r
-  FilePathSize  = (UINT32) GetDevicePathSize (FilePath);\r
+  FilePathSize  = (UINT32)GetDevicePathSize (FilePath);\r
 \r
   //\r
   // Determine destination PCR by BootPolicy\r
   //\r
   EventSize = sizeof (*ImageLoad) - sizeof (ImageLoad->DevicePath) + FilePathSize;\r
-  TcgEvent = AllocateZeroPool (EventSize + sizeof (TCG_PCR_EVENT));\r
+  TcgEvent  = AllocateZeroPool (EventSize + sizeof (TCG_PCR_EVENT));\r
   if (TcgEvent == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
   TcgEvent->EventSize = EventSize;\r
-  ImageLoad           = (EFI_IMAGE_LOAD_EVENT *) TcgEvent->Event;\r
+  ImageLoad           = (EFI_IMAGE_LOAD_EVENT *)TcgEvent->Event;\r
 \r
   switch (ImageType) {\r
     case EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION:\r
@@ -373,13 +380,13 @@ TcgMeasurePeImage (
   //\r
   // Check PE/COFF image\r
   //\r
-  DosHdr = (EFI_IMAGE_DOS_HEADER *) (UINTN) ImageAddress;\r
+  DosHdr             = (EFI_IMAGE_DOS_HEADER *)(UINTN)ImageAddress;\r
   PeCoffHeaderOffset = 0;\r
   if (DosHdr->e_magic == EFI_IMAGE_DOS_SIGNATURE) {\r
     PeCoffHeaderOffset = DosHdr->e_lfanew;\r
   }\r
 \r
-  Hdr.Pe32 = (EFI_IMAGE_NT_HEADERS32 *)((UINT8 *) (UINTN) ImageAddress + PeCoffHeaderOffset);\r
+  Hdr.Pe32 = (EFI_IMAGE_NT_HEADERS32 *)((UINT8 *)(UINTN)ImageAddress + PeCoffHeaderOffset);\r
   if (Hdr.Pe32->Signature != EFI_IMAGE_NT_SIGNATURE) {\r
     goto Finish;\r
   }\r
@@ -416,19 +423,19 @@ TcgMeasurePeImage (
   // 3.  Calculate the distance from the base of the image header to the image checksum address.\r
   // 4.  Hash the image header from its base to beginning of the image checksum.\r
   //\r
-  HashBase = (UINT8 *) (UINTN) ImageAddress;\r
+  HashBase = (UINT8 *)(UINTN)ImageAddress;\r
   if (Hdr.Pe32->OptionalHeader.Magic == EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC) {\r
     //\r
     // Use PE32 offset\r
     //\r
     NumberOfRvaAndSizes = Hdr.Pe32->OptionalHeader.NumberOfRvaAndSizes;\r
-    HashSize = (UINTN) (&Hdr.Pe32->OptionalHeader.CheckSum) - (UINTN) HashBase;\r
+    HashSize            = (UINTN)(&Hdr.Pe32->OptionalHeader.CheckSum) - (UINTN)HashBase;\r
   } else {\r
     //\r
     // Use PE32+ offset\r
     //\r
     NumberOfRvaAndSizes = Hdr.Pe32Plus->OptionalHeader.NumberOfRvaAndSizes;\r
-    HashSize = (UINTN) (&Hdr.Pe32Plus->OptionalHeader.CheckSum) - (UINTN) HashBase;\r
+    HashSize            = (UINTN)(&Hdr.Pe32Plus->OptionalHeader.CheckSum) - (UINTN)HashBase;\r
   }\r
 \r
   HashStatus = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
@@ -448,18 +455,18 @@ TcgMeasurePeImage (
       //\r
       // Use PE32 offset.\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = Hdr.Pe32->OptionalHeader.SizeOfHeaders - (UINTN) (HashBase - ImageAddress);\r
+      HashBase = (UINT8 *)&Hdr.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = Hdr.Pe32->OptionalHeader.SizeOfHeaders - (UINTN)(HashBase - ImageAddress);\r
     } else {\r
       //\r
       // Use PE32+ offset.\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = Hdr.Pe32Plus->OptionalHeader.SizeOfHeaders - (UINTN) (HashBase - ImageAddress);\r
+      HashBase = (UINT8 *)&Hdr.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = Hdr.Pe32Plus->OptionalHeader.SizeOfHeaders - (UINTN)(HashBase - ImageAddress);\r
     }\r
 \r
     if (HashSize != 0) {\r
-      HashStatus  = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
+      HashStatus = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
       if (!HashStatus) {\r
         goto Finish;\r
       }\r
@@ -472,18 +479,18 @@ TcgMeasurePeImage (
       //\r
       // Use PE32 offset\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = (UINTN) (&Hdr.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN) HashBase;\r
+      HashBase = (UINT8 *)&Hdr.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = (UINTN)(&Hdr.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN)HashBase;\r
     } else {\r
       //\r
       // Use PE32+ offset\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = (UINTN) (&Hdr.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN) HashBase;\r
+      HashBase = (UINT8 *)&Hdr.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = (UINTN)(&Hdr.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN)HashBase;\r
     }\r
 \r
     if (HashSize != 0) {\r
-      HashStatus  = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
+      HashStatus = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
       if (!HashStatus) {\r
         goto Finish;\r
       }\r
@@ -497,18 +504,18 @@ TcgMeasurePeImage (
       //\r
       // Use PE32 offset\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
-      HashSize = Hdr.Pe32->OptionalHeader.SizeOfHeaders - (UINTN) (HashBase - ImageAddress);\r
+      HashBase = (UINT8 *)&Hdr.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
+      HashSize = Hdr.Pe32->OptionalHeader.SizeOfHeaders - (UINTN)(HashBase - ImageAddress);\r
     } else {\r
       //\r
       // Use PE32+ offset\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
-      HashSize = Hdr.Pe32Plus->OptionalHeader.SizeOfHeaders - (UINTN) (HashBase - ImageAddress);\r
+      HashBase = (UINT8 *)&Hdr.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
+      HashSize = Hdr.Pe32Plus->OptionalHeader.SizeOfHeaders - (UINTN)(HashBase - ImageAddress);\r
     }\r
 \r
     if (HashSize != 0) {\r
-      HashStatus  = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
+      HashStatus = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
       if (!HashStatus) {\r
         goto Finish;\r
       }\r
@@ -536,7 +543,7 @@ TcgMeasurePeImage (
   //     header indicates how big the table should be. Do not include any\r
   //     IMAGE_SECTION_HEADERs in the table whose 'SizeOfRawData' field is zero.\r
   //\r
-  SectionHeader = (EFI_IMAGE_SECTION_HEADER *) AllocateZeroPool (sizeof (EFI_IMAGE_SECTION_HEADER) * Hdr.Pe32->FileHeader.NumberOfSections);\r
+  SectionHeader = (EFI_IMAGE_SECTION_HEADER *)AllocateZeroPool (sizeof (EFI_IMAGE_SECTION_HEADER) * Hdr.Pe32->FileHeader.NumberOfSections);\r
   if (SectionHeader == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto Finish;\r
@@ -548,20 +555,21 @@ TcgMeasurePeImage (
   //      words, sort the section headers according to the disk-file offset of\r
   //      the section.\r
   //\r
-  Section = (EFI_IMAGE_SECTION_HEADER *) (\r
-               (UINT8 *) (UINTN) ImageAddress +\r
-               PeCoffHeaderOffset +\r
-               sizeof(UINT32) +\r
-               sizeof(EFI_IMAGE_FILE_HEADER) +\r
-               Hdr.Pe32->FileHeader.SizeOfOptionalHeader\r
-               );\r
+  Section = (EFI_IMAGE_SECTION_HEADER *)(\r
+                                         (UINT8 *)(UINTN)ImageAddress +\r
+                                         PeCoffHeaderOffset +\r
+                                         sizeof (UINT32) +\r
+                                         sizeof (EFI_IMAGE_FILE_HEADER) +\r
+                                         Hdr.Pe32->FileHeader.SizeOfOptionalHeader\r
+                                         );\r
   for (Index = 0; Index < Hdr.Pe32->FileHeader.NumberOfSections; Index++) {\r
     Pos = Index;\r
     while ((Pos > 0) && (Section->PointerToRawData < SectionHeader[Pos - 1].PointerToRawData)) {\r
-      CopyMem (&SectionHeader[Pos], &SectionHeader[Pos - 1], sizeof(EFI_IMAGE_SECTION_HEADER));\r
+      CopyMem (&SectionHeader[Pos], &SectionHeader[Pos - 1], sizeof (EFI_IMAGE_SECTION_HEADER));\r
       Pos--;\r
     }\r
-    CopyMem (&SectionHeader[Pos], Section, sizeof(EFI_IMAGE_SECTION_HEADER));\r
+\r
+    CopyMem (&SectionHeader[Pos], Section, sizeof (EFI_IMAGE_SECTION_HEADER));\r
     Section += 1;\r
   }\r
 \r
@@ -573,12 +581,13 @@ TcgMeasurePeImage (
   // 15.  Repeat steps 13 and 14 for all the sections in the sorted table.\r
   //\r
   for (Index = 0; Index < Hdr.Pe32->FileHeader.NumberOfSections; Index++) {\r
-    Section  = (EFI_IMAGE_SECTION_HEADER *) &SectionHeader[Index];\r
+    Section = (EFI_IMAGE_SECTION_HEADER *)&SectionHeader[Index];\r
     if (Section->SizeOfRawData == 0) {\r
       continue;\r
     }\r
-    HashBase = (UINT8 *) (UINTN) ImageAddress + Section->PointerToRawData;\r
-    HashSize = (UINTN) Section->SizeOfRawData;\r
+\r
+    HashBase = (UINT8 *)(UINTN)ImageAddress + Section->PointerToRawData;\r
+    HashSize = (UINTN)Section->SizeOfRawData;\r
 \r
     HashStatus = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
     if (!HashStatus) {\r
@@ -595,7 +604,7 @@ TcgMeasurePeImage (
   //             FileSize  -  (CertDirectory->Size)\r
   //\r
   if (ImageSize > SumOfBytesHashed) {\r
-    HashBase = (UINT8 *) (UINTN) ImageAddress + SumOfBytesHashed;\r
+    HashBase = (UINT8 *)(UINTN)ImageAddress + SumOfBytesHashed;\r
 \r
     if (NumberOfRvaAndSizes <= EFI_IMAGE_DIRECTORY_ENTRY_SECURITY) {\r
       CertSize = 0;\r
@@ -614,7 +623,7 @@ TcgMeasurePeImage (
     }\r
 \r
     if (ImageSize > CertSize + SumOfBytesHashed) {\r
-      HashSize = (UINTN) (ImageSize - CertSize - SumOfBytesHashed);\r
+      HashSize = (UINTN)(ImageSize - CertSize - SumOfBytesHashed);\r
 \r
       HashStatus = Sha1Update (Sha1Ctx, HashBase, HashSize);\r
       if (!HashStatus) {\r
@@ -628,7 +637,7 @@ TcgMeasurePeImage (
   //\r
   // 17.  Finalize the SHA hash.\r
   //\r
-  HashStatus = Sha1Final (Sha1Ctx, (UINT8 *) &TcgEvent->Digest);\r
+  HashStatus = Sha1Final (Sha1Ctx, (UINT8 *)&TcgEvent->Digest);\r
   if (!HashStatus) {\r
     goto Finish;\r
   }\r
@@ -637,15 +646,15 @@ TcgMeasurePeImage (
   // Log the PE data\r
   //\r
   EventNumber = 1;\r
-  Status = TcgProtocol->HashLogExtendEvent (\r
-             TcgProtocol,\r
-             (EFI_PHYSICAL_ADDRESS) (UINTN) (VOID *) NULL,\r
-             0,\r
-             TPM_ALG_SHA,\r
-             TcgEvent,\r
-             &EventNumber,\r
-             &EventLogLastEntry\r
-             );\r
+  Status      = TcgProtocol->HashLogExtendEvent (\r
+                               TcgProtocol,\r
+                               (EFI_PHYSICAL_ADDRESS)(UINTN)(VOID *)NULL,\r
+                               0,\r
+                               TPM_ALG_SHA,\r
+                               TcgEvent,\r
+                               &EventNumber,\r
+                               &EventLogLastEntry\r
+                               );\r
   if (Status == EFI_OUT_OF_RESOURCES) {\r
     //\r
     // Out of resource here means the image is hashed and its result is extended to PCR.\r
@@ -665,6 +674,7 @@ Finish:
   if (Sha1Ctx != NULL ) {\r
     FreePool (Sha1Ctx);\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -709,11 +719,11 @@ Finish:
 EFI_STATUS\r
 EFIAPI\r
 DxeTpmMeasureBootHandler (\r
-  IN  UINT32                           AuthenticationStatus,\r
-  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File  OPTIONAL,\r
-  IN  VOID                             *FileBuffer,\r
-  IN  UINTN                            FileSize,\r
-  IN  BOOLEAN                          BootPolicy\r
+  IN  UINT32                          AuthenticationStatus,\r
+  IN  CONST EFI_DEVICE_PATH_PROTOCOL  *File  OPTIONAL,\r
+  IN  VOID                            *FileBuffer,\r
+  IN  UINTN                           FileSize,\r
+  IN  BOOLEAN                         BootPolicy\r
   )\r
 {\r
   EFI_TCG_PROTOCOL                    *TcgProtocol;\r
@@ -732,7 +742,7 @@ DxeTpmMeasureBootHandler (
   EFI_PHYSICAL_ADDRESS                FvAddress;\r
   UINT32                              Index;\r
 \r
-  Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **) &TcgProtocol);\r
+  Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **)&TcgProtocol);\r
   if (EFI_ERROR (Status)) {\r
     //\r
     // TCG protocol is not installed. So, TPM is not present.\r
@@ -741,14 +751,14 @@ DxeTpmMeasureBootHandler (
     return EFI_SUCCESS;\r
   }\r
 \r
-  ProtocolCapability.Size = (UINT8) sizeof (ProtocolCapability);\r
-  Status = TcgProtocol->StatusCheck (\r
-             TcgProtocol,\r
-             &ProtocolCapability,\r
-             &TCGFeatureFlags,\r
-             &EventLogLocation,\r
-             &EventLogLastEntry\r
-           );\r
+  ProtocolCapability.Size = (UINT8)sizeof (ProtocolCapability);\r
+  Status                  = TcgProtocol->StatusCheck (\r
+                                           TcgProtocol,\r
+                                           &ProtocolCapability,\r
+                                           &TCGFeatureFlags,\r
+                                           &EventLogLocation,\r
+                                           &EventLogLastEntry\r
+                                           );\r
   if (EFI_ERROR (Status) || ProtocolCapability.TPMDeactivatedFlag || (!ProtocolCapability.TPMPresentFlag)) {\r
     //\r
     // TPM device doesn't work or activate.\r
@@ -766,7 +776,7 @@ DxeTpmMeasureBootHandler (
   // Is so, this device path may be a GPT device path.\r
   //\r
   DevicePathNode = OrigDevicePathNode;\r
-  Status = gBS->LocateDevicePath (&gEfiBlockIoProtocolGuid, &DevicePathNode, &Handle);\r
+  Status         = gBS->LocateDevicePath (&gEfiBlockIoProtocolGuid, &DevicePathNode, &Handle);\r
   if (!EFI_ERROR (Status) && !mMeasureGptTableFlag) {\r
     //\r
     // Find the gpt partition on the given devicepath\r
@@ -777,25 +787,26 @@ DxeTpmMeasureBootHandler (
       //\r
       // Find the Gpt partition\r
       //\r
-      if (DevicePathType (DevicePathNode) == MEDIA_DEVICE_PATH &&\r
-            DevicePathSubType (DevicePathNode) == MEDIA_HARDDRIVE_DP) {\r
+      if ((DevicePathType (DevicePathNode) == MEDIA_DEVICE_PATH) &&\r
+          (DevicePathSubType (DevicePathNode) == MEDIA_HARDDRIVE_DP))\r
+      {\r
         //\r
         // Check whether it is a gpt partition or not\r
         //\r
-        if (((HARDDRIVE_DEVICE_PATH *) DevicePathNode)->MBRType == MBR_TYPE_EFI_PARTITION_TABLE_HEADER &&\r
-            ((HARDDRIVE_DEVICE_PATH *) DevicePathNode)->SignatureType == SIGNATURE_TYPE_GUID) {\r
-\r
+        if ((((HARDDRIVE_DEVICE_PATH *)DevicePathNode)->MBRType == MBR_TYPE_EFI_PARTITION_TABLE_HEADER) &&\r
+            (((HARDDRIVE_DEVICE_PATH *)DevicePathNode)->SignatureType == SIGNATURE_TYPE_GUID))\r
+        {\r
           //\r
           // Change the partition device path to its parent device path (disk) and get the handle.\r
           //\r
           DevicePathNode->Type    = END_DEVICE_PATH_TYPE;\r
           DevicePathNode->SubType = END_ENTIRE_DEVICE_PATH_SUBTYPE;\r
           DevicePathNode          = OrigDevicePathNode;\r
-          Status = gBS->LocateDevicePath (\r
-                         &gEfiDiskIoProtocolGuid,\r
-                         &DevicePathNode,\r
-                         &Handle\r
-                         );\r
+          Status                  = gBS->LocateDevicePath (\r
+                                           &gEfiDiskIoProtocolGuid,\r
+                                           &DevicePathNode,\r
+                                           &Handle\r
+                                           );\r
           if (!EFI_ERROR (Status)) {\r
             //\r
             // Measure GPT disk.\r
@@ -808,13 +819,15 @@ DxeTpmMeasureBootHandler (
               mMeasureGptTableFlag = TRUE;\r
             }\r
           }\r
+\r
           FreePool (OrigDevicePathNode);\r
           OrigDevicePathNode = DuplicateDevicePath (File);\r
           ASSERT (OrigDevicePathNode != NULL);\r
           break;\r
         }\r
       }\r
-      DevicePathNode    = NextDevicePathNode (DevicePathNode);\r
+\r
+      DevicePathNode = NextDevicePathNode (DevicePathNode);\r
     }\r
   }\r
 \r
@@ -827,7 +840,7 @@ DxeTpmMeasureBootHandler (
   // Check whether this device path support FVB protocol.\r
   //\r
   DevicePathNode = OrigDevicePathNode;\r
-  Status = gBS->LocateDevicePath (&gEfiFirmwareVolumeBlockProtocolGuid, &DevicePathNode, &Handle);\r
+  Status         = gBS->LocateDevicePath (&gEfiFirmwareVolumeBlockProtocolGuid, &DevicePathNode, &Handle);\r
   if (!EFI_ERROR (Status)) {\r
     //\r
     // Don't check FV image, and directly return EFI_SUCCESS.\r
@@ -836,6 +849,7 @@ DxeTpmMeasureBootHandler (
     if (IsDevicePathEnd (DevicePathNode)) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     //\r
     // The PE image from unmeasured Firmware volume need be measured\r
     // The PE image from measured Firmware volume will be measured according to policy below.\r
@@ -844,32 +858,32 @@ DxeTpmMeasureBootHandler (
     //\r
     ApplicationRequired = TRUE;\r
 \r
-    if (mCacheMeasuredHandle != Handle && mMeasuredHobData != NULL) {\r
+    if ((mCacheMeasuredHandle != Handle) && (mMeasuredHobData != NULL)) {\r
       //\r
       // Search for Root FV of this PE image\r
       //\r
       TempHandle = Handle;\r
       do {\r
-        Status = gBS->HandleProtocol(\r
+        Status = gBS->HandleProtocol (\r
                         TempHandle,\r
                         &gEfiFirmwareVolumeBlockProtocolGuid,\r
-                        (VOID**)&FvbProtocol\r
+                        (VOID **)&FvbProtocol\r
                         );\r
         TempHandle = FvbProtocol->ParentHandle;\r
-      } while (!EFI_ERROR(Status) && FvbProtocol->ParentHandle != NULL);\r
+      } while (!EFI_ERROR (Status) && FvbProtocol->ParentHandle != NULL);\r
 \r
       //\r
       // Search in measured FV Hob\r
       //\r
-      Status = FvbProtocol->GetPhysicalAddress(FvbProtocol, &FvAddress);\r
-      if (EFI_ERROR(Status)){\r
+      Status = FvbProtocol->GetPhysicalAddress (FvbProtocol, &FvAddress);\r
+      if (EFI_ERROR (Status)) {\r
         return Status;\r
       }\r
 \r
       ApplicationRequired = FALSE;\r
 \r
       for (Index = 0; Index < mMeasuredHobData->Num; Index++) {\r
-        if(mMeasuredHobData->MeasuredFvBuf[Index].BlobBase == FvAddress) {\r
+        if (mMeasuredHobData->MeasuredFvBuf[Index].BlobBase == FvAddress) {\r
           //\r
           // Cache measured FV for next measurement\r
           //\r
@@ -889,16 +903,16 @@ DxeTpmMeasureBootHandler (
     goto Finish;\r
   }\r
 \r
-  mTpmImageSize  = FileSize;\r
-  mFileBuffer = FileBuffer;\r
+  mTpmImageSize = FileSize;\r
+  mFileBuffer   = FileBuffer;\r
 \r
   //\r
   // Measure PE Image\r
   //\r
   DevicePathNode = OrigDevicePathNode;\r
   ZeroMem (&ImageContext, sizeof (ImageContext));\r
-  ImageContext.Handle    = (VOID *) FileBuffer;\r
-  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE) DxeTpmMeasureBootLibImageRead;\r
+  ImageContext.Handle    = (VOID *)FileBuffer;\r
+  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE)DxeTpmMeasureBootLibImageRead;\r
 \r
   //\r
   // Get information about the image being loaded\r
@@ -923,21 +937,23 @@ DxeTpmMeasureBootHandler (
   // Measure drivers and applications if Application flag is not set\r
   //\r
   if ((!ApplicationRequired) ||\r
-        (ApplicationRequired && ImageContext.ImageType == EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION)) {\r
+      (ApplicationRequired && (ImageContext.ImageType == EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION)))\r
+  {\r
     //\r
     // Print the image path to be measured.\r
     //\r
     DEBUG_CODE_BEGIN ();\r
-      CHAR16                            *ToText;\r
-      ToText = ConvertDevicePathToText (\r
-                 DevicePathNode,\r
-                 FALSE,\r
-                 TRUE\r
-                 );\r
-      if (ToText != NULL) {\r
-        DEBUG ((DEBUG_INFO, "The measured image path is %s.\n", ToText));\r
-        FreePool (ToText);\r
-      }\r
+    CHAR16  *ToText;\r
+    ToText = ConvertDevicePathToText (\r
+               DevicePathNode,\r
+               FALSE,\r
+               TRUE\r
+               );\r
+    if (ToText != NULL) {\r
+      DEBUG ((DEBUG_INFO, "The measured image path is %s.\n", ToText));\r
+      FreePool (ToText);\r
+    }\r
+\r
     DEBUG_CODE_END ();\r
 \r
     //\r
@@ -945,9 +961,9 @@ DxeTpmMeasureBootHandler (
     //\r
     Status = TcgMeasurePeImage (\r
                TcgProtocol,\r
-               (EFI_PHYSICAL_ADDRESS) (UINTN) FileBuffer,\r
+               (EFI_PHYSICAL_ADDRESS)(UINTN)FileBuffer,\r
                FileSize,\r
-               (UINTN) ImageContext.ImageAddress,\r
+               (UINTN)ImageContext.ImageAddress,\r
                ImageContext.ImageType,\r
                DevicePathNode\r
                );\r
@@ -991,7 +1007,7 @@ DxeTpmMeasureBootLibConstructor (
   }\r
 \r
   return RegisterSecurity2Handler (\r
-          DxeTpmMeasureBootHandler,\r
-          EFI_AUTH_OPERATION_MEASURE_IMAGE | EFI_AUTH_OPERATION_IMAGE_REQUIRED\r
-          );\r
+           DxeTpmMeasureBootHandler,\r
+           EFI_AUTH_OPERATION_MEASURE_IMAGE | EFI_AUTH_OPERATION_IMAGE_REQUIRED\r
+           );\r
 }\r
index 061136ee786075592dd2b634e54b57122941049f..d014ea4aec081392deabbb4e665867ed75ac84ad 100644 (file)
@@ -20,8 +20,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Guid/Acpi.h>\r
 #include <IndustryStandard/Acpi.h>\r
 \r
-\r
-\r
 /**\r
   Tpm12 measure and log data, and extend the measurement result into a specific PCR.\r
 \r
@@ -39,32 +37,32 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 EFI_STATUS\r
 Tpm12MeasureAndLogData (\r
-  IN UINT32             PcrIndex,\r
-  IN UINT32             EventType,\r
-  IN VOID               *EventLog,\r
-  IN UINT32             LogLen,\r
-  IN VOID               *HashData,\r
-  IN UINT64             HashDataLen\r
+  IN UINT32  PcrIndex,\r
+  IN UINT32  EventType,\r
+  IN VOID    *EventLog,\r
+  IN UINT32  LogLen,\r
+  IN VOID    *HashData,\r
+  IN UINT64  HashDataLen\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  EFI_TCG_PROTOCOL          *TcgProtocol;\r
-  TCG_PCR_EVENT             *TcgEvent;\r
-  EFI_PHYSICAL_ADDRESS      EventLogLastEntry;\r
-  UINT32                    EventNumber;\r
+  EFI_STATUS            Status;\r
+  EFI_TCG_PROTOCOL      *TcgProtocol;\r
+  TCG_PCR_EVENT         *TcgEvent;\r
+  EFI_PHYSICAL_ADDRESS  EventLogLastEntry;\r
+  UINT32                EventNumber;\r
 \r
   TcgEvent = NULL;\r
 \r
   //\r
   // Tpm activation state is checked in HashLogExtendEvent\r
   //\r
-  Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **) &TcgProtocol);\r
-  if (EFI_ERROR(Status)){\r
+  Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **)&TcgProtocol);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
   TcgEvent = (TCG_PCR_EVENT *)AllocateZeroPool (sizeof (TCG_PCR_EVENT_HDR) + LogLen);\r
-  if(TcgEvent == NULL) {\r
+  if (TcgEvent == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
@@ -73,15 +71,15 @@ Tpm12MeasureAndLogData (
   TcgEvent->EventSize = LogLen;\r
   CopyMem (&TcgEvent->Event[0], EventLog, LogLen);\r
   EventNumber = 1;\r
-  Status = TcgProtocol->HashLogExtendEvent (\r
-                          TcgProtocol,\r
-                          (EFI_PHYSICAL_ADDRESS)(UINTN)HashData,\r
-                          HashDataLen,\r
-                          TPM_ALG_SHA,\r
-                          TcgEvent,\r
-                          &EventNumber,\r
-                          &EventLogLastEntry\r
-                          );\r
+  Status      = TcgProtocol->HashLogExtendEvent (\r
+                               TcgProtocol,\r
+                               (EFI_PHYSICAL_ADDRESS)(UINTN)HashData,\r
+                               HashDataLen,\r
+                               TPM_ALG_SHA,\r
+                               TcgEvent,\r
+                               &EventNumber,\r
+                               &EventLogLastEntry\r
+                               );\r
 \r
   FreePool (TcgEvent);\r
 \r
@@ -105,33 +103,33 @@ Tpm12MeasureAndLogData (
 **/\r
 EFI_STATUS\r
 Tpm20MeasureAndLogData (\r
-  IN UINT32             PcrIndex,\r
-  IN UINT32             EventType,\r
-  IN VOID               *EventLog,\r
-  IN UINT32             LogLen,\r
-  IN VOID               *HashData,\r
-  IN UINT64             HashDataLen\r
+  IN UINT32  PcrIndex,\r
+  IN UINT32  EventType,\r
+  IN VOID    *EventLog,\r
+  IN UINT32  LogLen,\r
+  IN VOID    *HashData,\r
+  IN UINT64  HashDataLen\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  EFI_TCG2_PROTOCOL         *Tcg2Protocol;\r
-  EFI_TCG2_EVENT            *Tcg2Event;\r
+  EFI_STATUS         Status;\r
+  EFI_TCG2_PROTOCOL  *Tcg2Protocol;\r
+  EFI_TCG2_EVENT     *Tcg2Event;\r
 \r
   //\r
   // TPMPresentFlag is checked in HashLogExtendEvent\r
   //\r
-  Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **) &Tcg2Protocol);\r
+  Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **)&Tcg2Protocol);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  Tcg2Event = (EFI_TCG2_EVENT *) AllocateZeroPool (LogLen + sizeof (EFI_TCG2_EVENT));\r
-  if(Tcg2Event == NULL) {\r
+  Tcg2Event = (EFI_TCG2_EVENT *)AllocateZeroPool (LogLen + sizeof (EFI_TCG2_EVENT));\r
+  if (Tcg2Event == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  Tcg2Event->Size = (UINT32)LogLen + sizeof (EFI_TCG2_EVENT) - sizeof(Tcg2Event->Event);\r
-  Tcg2Event->Header.HeaderSize    = sizeof(EFI_TCG2_EVENT_HEADER);\r
+  Tcg2Event->Size                 = (UINT32)LogLen + sizeof (EFI_TCG2_EVENT) - sizeof (Tcg2Event->Event);\r
+  Tcg2Event->Header.HeaderSize    = sizeof (EFI_TCG2_EVENT_HEADER);\r
   Tcg2Event->Header.HeaderVersion = EFI_TCG2_EVENT_HEADER_VERSION;\r
   Tcg2Event->Header.PCRIndex      = PcrIndex;\r
   Tcg2Event->Header.EventType     = EventType;\r
@@ -167,12 +165,12 @@ Tpm20MeasureAndLogData (
 EFI_STATUS\r
 EFIAPI\r
 TpmMeasureAndLogData (\r
-  IN UINT32             PcrIndex,\r
-  IN UINT32             EventType,\r
-  IN VOID               *EventLog,\r
-  IN UINT32             LogLen,\r
-  IN VOID               *HashData,\r
-  IN UINT64             HashDataLen\r
+  IN UINT32  PcrIndex,\r
+  IN UINT32  EventType,\r
+  IN VOID    *EventLog,\r
+  IN UINT32  LogLen,\r
+  IN VOID    *HashData,\r
+  IN UINT64  HashDataLen\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -180,7 +178,7 @@ TpmMeasureAndLogData (
   //\r
   // Try to measure using Tpm20 protocol\r
   //\r
-  Status = Tpm20MeasureAndLogData(\r
+  Status = Tpm20MeasureAndLogData (\r
              PcrIndex,\r
              EventType,\r
              EventLog,\r
@@ -193,7 +191,7 @@ TpmMeasureAndLogData (
     //\r
     // Try to measure using Tpm1.2 protocol\r
     //\r
-    Status = Tpm12MeasureAndLogData(\r
+    Status = Tpm12MeasureAndLogData (\r
                PcrIndex,\r
                EventType,\r
                EventLog,\r
index effe165885d7cd74607ddebccdc4457021b5e59f..9179f000faefac2ff51150b45c6e922548ac3dde 100644 (file)
@@ -62,36 +62,36 @@ FmpAuthenticatedHandlerPkcs7 (
   IN UINTN                              PublicKeyDataLength\r
   )\r
 {\r
-  RETURN_STATUS                             Status;\r
-  BOOLEAN                                   CryptoStatus;\r
-  VOID                                      *P7Data;\r
-  UINTN                                     P7Length;\r
-  VOID                                      *TempBuffer;\r
+  RETURN_STATUS  Status;\r
+  BOOLEAN        CryptoStatus;\r
+  VOID           *P7Data;\r
+  UINTN          P7Length;\r
+  VOID           *TempBuffer;\r
 \r
-  DEBUG((DEBUG_INFO, "FmpAuthenticatedHandlerPkcs7 - Image: 0x%08x - 0x%08x\n", (UINTN)Image, (UINTN)ImageSize));\r
+  DEBUG ((DEBUG_INFO, "FmpAuthenticatedHandlerPkcs7 - Image: 0x%08x - 0x%08x\n", (UINTN)Image, (UINTN)ImageSize));\r
 \r
-  P7Length = Image->AuthInfo.Hdr.dwLength - (OFFSET_OF(WIN_CERTIFICATE_UEFI_GUID, CertData));\r
-  P7Data = Image->AuthInfo.CertData;\r
+  P7Length = Image->AuthInfo.Hdr.dwLength - (OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData));\r
+  P7Data   = Image->AuthInfo.CertData;\r
 \r
   // It is a signature across the variable data and the Monotonic Count value.\r
-  TempBuffer = AllocatePool(ImageSize - Image->AuthInfo.Hdr.dwLength);\r
+  TempBuffer = AllocatePool (ImageSize - Image->AuthInfo.Hdr.dwLength);\r
   if (TempBuffer == NULL) {\r
-    DEBUG((DEBUG_ERROR, "FmpAuthenticatedHandlerPkcs7: TempBuffer == NULL\n"));\r
+    DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerPkcs7: TempBuffer == NULL\n"));\r
     Status = RETURN_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
 \r
-  CopyMem(\r
+  CopyMem (\r
     TempBuffer,\r
-    (UINT8 *)Image + sizeof(Image->MonotonicCount) + Image->AuthInfo.Hdr.dwLength,\r
-    ImageSize - sizeof(Image->MonotonicCount) - Image->AuthInfo.Hdr.dwLength\r
+    (UINT8 *)Image + sizeof (Image->MonotonicCount) + Image->AuthInfo.Hdr.dwLength,\r
+    ImageSize - sizeof (Image->MonotonicCount) - Image->AuthInfo.Hdr.dwLength\r
     );\r
-  CopyMem(\r
-    (UINT8 *)TempBuffer + ImageSize - sizeof(Image->MonotonicCount) - Image->AuthInfo.Hdr.dwLength,\r
+  CopyMem (\r
+    (UINT8 *)TempBuffer + ImageSize - sizeof (Image->MonotonicCount) - Image->AuthInfo.Hdr.dwLength,\r
     &Image->MonotonicCount,\r
-    sizeof(Image->MonotonicCount)\r
+    sizeof (Image->MonotonicCount)\r
     );\r
-  CryptoStatus = Pkcs7Verify(\r
+  CryptoStatus = Pkcs7Verify (\r
                    P7Data,\r
                    P7Length,\r
                    PublicKeyData,\r
@@ -99,16 +99,17 @@ FmpAuthenticatedHandlerPkcs7 (
                    (UINT8 *)TempBuffer,\r
                    ImageSize - Image->AuthInfo.Hdr.dwLength\r
                    );\r
-  FreePool(TempBuffer);\r
+  FreePool (TempBuffer);\r
   if (!CryptoStatus) {\r
     //\r
     // If PKCS7 signature verification fails, AUTH tested failed bit is set.\r
     //\r
-    DEBUG((DEBUG_ERROR, "FmpAuthenticatedHandlerPkcs7: Pkcs7Verify() failed\n"));\r
+    DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerPkcs7: Pkcs7Verify() failed\n"));\r
     Status = RETURN_SECURITY_VIOLATION;\r
     goto Done;\r
   }\r
-  DEBUG((DEBUG_INFO, "FmpAuthenticatedHandlerPkcs7: PASS verification\n"));\r
+\r
+  DEBUG ((DEBUG_INFO, "FmpAuthenticatedHandlerPkcs7: PASS verification\n"));\r
 \r
   Status = RETURN_SUCCESS;\r
 \r
@@ -160,40 +161,45 @@ AuthenticateFmpImage (
   IN UINTN                              PublicKeyDataLength\r
   )\r
 {\r
-  GUID                                      *CertType;\r
-  EFI_STATUS                                Status;\r
+  GUID        *CertType;\r
+  EFI_STATUS  Status;\r
 \r
   if ((Image == NULL) || (ImageSize == 0)) {\r
     return RETURN_UNSUPPORTED;\r
   }\r
 \r
-  if (ImageSize < sizeof(EFI_FIRMWARE_IMAGE_AUTHENTICATION)) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too small\n"));\r
+  if (ImageSize < sizeof (EFI_FIRMWARE_IMAGE_AUTHENTICATION)) {\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too small\n"));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
-  if (Image->AuthInfo.Hdr.dwLength <= OFFSET_OF(WIN_CERTIFICATE_UEFI_GUID, CertData)) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - dwLength too small\n"));\r
+\r
+  if (Image->AuthInfo.Hdr.dwLength <= OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData)) {\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - dwLength too small\n"));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
-  if ((UINTN) Image->AuthInfo.Hdr.dwLength > MAX_UINTN - sizeof(UINT64)) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - dwLength too big\n"));\r
+\r
+  if ((UINTN)Image->AuthInfo.Hdr.dwLength > MAX_UINTN - sizeof (UINT64)) {\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - dwLength too big\n"));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
-  if (ImageSize <= sizeof(Image->MonotonicCount) + Image->AuthInfo.Hdr.dwLength) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too small\n"));\r
+\r
+  if (ImageSize <= sizeof (Image->MonotonicCount) + Image->AuthInfo.Hdr.dwLength) {\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too small\n"));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
+\r
   if (Image->AuthInfo.Hdr.wRevision != 0x0200) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - wRevision: 0x%02x, expect - 0x%02x\n", (UINTN)Image->AuthInfo.Hdr.wRevision, (UINTN)0x0200));\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - wRevision: 0x%02x, expect - 0x%02x\n", (UINTN)Image->AuthInfo.Hdr.wRevision, (UINTN)0x0200));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
+\r
   if (Image->AuthInfo.Hdr.wCertificateType != WIN_CERT_TYPE_EFI_GUID) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - wCertificateType: 0x%02x, expect - 0x%02x\n", (UINTN)Image->AuthInfo.Hdr.wCertificateType, (UINTN)WIN_CERT_TYPE_EFI_GUID));\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - wCertificateType: 0x%02x, expect - 0x%02x\n", (UINTN)Image->AuthInfo.Hdr.wCertificateType, (UINTN)WIN_CERT_TYPE_EFI_GUID));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
 \r
   CertType = &Image->AuthInfo.CertType;\r
-  DEBUG((DEBUG_INFO, "AuthenticateFmpImage - CertType: %g\n", CertType));\r
+  DEBUG ((DEBUG_INFO, "AuthenticateFmpImage - CertType: %g\n", CertType));\r
 \r
   if (CompareGuid (&gEfiCertPkcs7Guid, CertType)) {\r
     //\r
@@ -213,4 +219,3 @@ AuthenticateFmpImage (
   //\r
   return RETURN_UNSUPPORTED;\r
 }\r
-\r
index 41fb67efaf2b18c3cf5c6fcbed89b39dfeac924b..248b1841ab2c1b90587c817f030acc56b91cda61 100644 (file)
@@ -34,7 +34,7 @@
 ///\r
 /// Public Exponent of RSA Key.\r
 ///\r
-STATIC CONST UINT8 mRsaE[] = { 0x01, 0x00, 0x01 };\r
+STATIC CONST UINT8  mRsaE[] = { 0x01, 0x00, 0x01 };\r
 \r
 /**\r
   The handler is used to do the authentication for FMP capsule based upon\r
@@ -67,30 +67,30 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
   IN UINTN                              PublicKeyDataLength\r
   )\r
 {\r
-  RETURN_STATUS                             Status;\r
-  EFI_CERT_BLOCK_RSA_2048_SHA256            *CertBlockRsa2048Sha256;\r
-  BOOLEAN                                   CryptoStatus;\r
-  UINT8                                     Digest[SHA256_DIGEST_SIZE];\r
-  UINT8                                     *PublicKey;\r
-  UINTN                                     PublicKeyBufferSize;\r
-  VOID                                      *HashContext;\r
-  VOID                                      *Rsa;\r
+  RETURN_STATUS                   Status;\r
+  EFI_CERT_BLOCK_RSA_2048_SHA256  *CertBlockRsa2048Sha256;\r
+  BOOLEAN                         CryptoStatus;\r
+  UINT8                           Digest[SHA256_DIGEST_SIZE];\r
+  UINT8                           *PublicKey;\r
+  UINTN                           PublicKeyBufferSize;\r
+  VOID                            *HashContext;\r
+  VOID                            *Rsa;\r
 \r
   DEBUG ((DEBUG_INFO, "FmpAuthenticatedHandlerRsa2048Sha256 - Image: 0x%08x - 0x%08x\n", (UINTN)Image, (UINTN)ImageSize));\r
 \r
-  if (Image->AuthInfo.Hdr.dwLength != OFFSET_OF(WIN_CERTIFICATE_UEFI_GUID, CertData) + sizeof(EFI_CERT_BLOCK_RSA_2048_SHA256)) {\r
-    DEBUG((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256 - dwLength: 0x%04x, dwLength - 0x%04x\n", (UINTN)Image->AuthInfo.Hdr.dwLength, (UINTN)OFFSET_OF(WIN_CERTIFICATE_UEFI_GUID, CertData) + sizeof(EFI_CERT_BLOCK_RSA_2048_SHA256)));\r
+  if (Image->AuthInfo.Hdr.dwLength != OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData) + sizeof (EFI_CERT_BLOCK_RSA_2048_SHA256)) {\r
+    DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256 - dwLength: 0x%04x, dwLength - 0x%04x\n", (UINTN)Image->AuthInfo.Hdr.dwLength, (UINTN)OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData) + sizeof (EFI_CERT_BLOCK_RSA_2048_SHA256)));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
 \r
   CertBlockRsa2048Sha256 = (EFI_CERT_BLOCK_RSA_2048_SHA256 *)Image->AuthInfo.CertData;\r
-  if (!CompareGuid(&CertBlockRsa2048Sha256->HashType, &gEfiHashAlgorithmSha256Guid)) {\r
-    DEBUG((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256 - HashType: %g, expect - %g\n", &CertBlockRsa2048Sha256->HashType, &gEfiHashAlgorithmSha256Guid));\r
+  if (!CompareGuid (&CertBlockRsa2048Sha256->HashType, &gEfiHashAlgorithmSha256Guid)) {\r
+    DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256 - HashType: %g, expect - %g\n", &CertBlockRsa2048Sha256->HashType, &gEfiHashAlgorithmSha256Guid));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
 \r
   HashContext = NULL;\r
-  Rsa = NULL;\r
+  Rsa         = NULL;\r
 \r
   //\r
   // Allocate hash context buffer required for SHA 256\r
@@ -113,13 +113,15 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
     Status = RETURN_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
-  CryptoStatus = Sha256Update (HashContext, &CertBlockRsa2048Sha256->PublicKey, sizeof(CertBlockRsa2048Sha256->PublicKey));\r
+\r
+  CryptoStatus = Sha256Update (HashContext, &CertBlockRsa2048Sha256->PublicKey, sizeof (CertBlockRsa2048Sha256->PublicKey));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: Sha256Update() failed\n"));\r
     Status = RETURN_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
-  CryptoStatus  = Sha256Final (HashContext, Digest);\r
+\r
+  CryptoStatus = Sha256Final (HashContext, Digest);\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: Sha256Final() failed\n"));\r
     Status = RETURN_OUT_OF_RESOURCES;\r
@@ -129,17 +131,19 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
   //\r
   // Fail if the PublicKey is not one of the public keys in the input PublicKeyData.\r
   //\r
-  PublicKey = (VOID *)PublicKeyData;\r
+  PublicKey           = (VOID *)PublicKeyData;\r
   PublicKeyBufferSize = PublicKeyDataLength;\r
-  CryptoStatus = FALSE;\r
+  CryptoStatus        = FALSE;\r
   while (PublicKeyBufferSize != 0) {\r
     if (CompareMem (Digest, PublicKey, SHA256_DIGEST_SIZE) == 0) {\r
       CryptoStatus = TRUE;\r
       break;\r
     }\r
-    PublicKey = PublicKey + SHA256_DIGEST_SIZE;\r
+\r
+    PublicKey           = PublicKey + SHA256_DIGEST_SIZE;\r
     PublicKeyBufferSize = PublicKeyBufferSize - SHA256_DIGEST_SIZE;\r
   }\r
+\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: Public key in section is not supported\n"));\r
     Status = RETURN_SECURITY_VIOLATION;\r
@@ -161,12 +165,13 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
   // Set RSA Key Components.\r
   // NOTE: Only N and E are needed to be set as RSA public key for signature verification.\r
   //\r
-  CryptoStatus = RsaSetKey (Rsa, RsaKeyN, CertBlockRsa2048Sha256->PublicKey, sizeof(CertBlockRsa2048Sha256->PublicKey));\r
+  CryptoStatus = RsaSetKey (Rsa, RsaKeyN, CertBlockRsa2048Sha256->PublicKey, sizeof (CertBlockRsa2048Sha256->PublicKey));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: RsaSetKey(RsaKeyN) failed\n"));\r
     Status = RETURN_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
+\r
   CryptoStatus = RsaSetKey (Rsa, RsaKeyE, mRsaE, sizeof (mRsaE));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: RsaSetKey(RsaKeyE) failed\n"));\r
@@ -188,25 +193,27 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
   // It is a signature across the variable data and the Monotonic Count value.\r
   CryptoStatus = Sha256Update (\r
                    HashContext,\r
-                   (UINT8 *)Image + sizeof(Image->MonotonicCount) + Image->AuthInfo.Hdr.dwLength,\r
-                   ImageSize - sizeof(Image->MonotonicCount) - Image->AuthInfo.Hdr.dwLength\r
+                   (UINT8 *)Image + sizeof (Image->MonotonicCount) + Image->AuthInfo.Hdr.dwLength,\r
+                   ImageSize - sizeof (Image->MonotonicCount) - Image->AuthInfo.Hdr.dwLength\r
                    );\r
   if (!CryptoStatus) {\r
-    DEBUG((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: Sha256Update() failed\n"));\r
+    DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: Sha256Update() failed\n"));\r
     Status = RETURN_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
+\r
   CryptoStatus = Sha256Update (\r
                    HashContext,\r
                    (UINT8 *)&Image->MonotonicCount,\r
-                   sizeof(Image->MonotonicCount)\r
+                   sizeof (Image->MonotonicCount)\r
                    );\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: Sha256Update() failed\n"));\r
     Status = RETURN_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
-  CryptoStatus  = Sha256Final (HashContext, Digest);\r
+\r
+  CryptoStatus = Sha256Final (HashContext, Digest);\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "FmpAuthenticatedHandlerRsa2048Sha256: Sha256Final() failed\n"));\r
     Status = RETURN_OUT_OF_RESOURCES;\r
@@ -231,6 +238,7 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
     Status = RETURN_SECURITY_VIOLATION;\r
     goto Done;\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "FmpAuthenticatedHandlerRsa2048Sha256: PASS verification\n"));\r
 \r
   Status = RETURN_SUCCESS;\r
@@ -242,6 +250,7 @@ Done:
   if (Rsa != NULL) {\r
     RsaFree (Rsa);\r
   }\r
+\r
   if (HashContext != NULL) {\r
     FreePool (HashContext);\r
   }\r
@@ -293,8 +302,8 @@ AuthenticateFmpImage (
   IN UINTN                              PublicKeyDataLength\r
   )\r
 {\r
-  GUID                                      *CertType;\r
-  EFI_STATUS                                Status;\r
+  GUID        *CertType;\r
+  EFI_STATUS  Status;\r
 \r
   if ((Image == NULL) || (ImageSize == 0)) {\r
     return RETURN_UNSUPPORTED;\r
@@ -305,33 +314,38 @@ AuthenticateFmpImage (
     return RETURN_UNSUPPORTED;\r
   }\r
 \r
-  if (ImageSize < sizeof(EFI_FIRMWARE_IMAGE_AUTHENTICATION)) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too small\n"));\r
+  if (ImageSize < sizeof (EFI_FIRMWARE_IMAGE_AUTHENTICATION)) {\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too small\n"));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
-  if (Image->AuthInfo.Hdr.dwLength <= OFFSET_OF(WIN_CERTIFICATE_UEFI_GUID, CertData)) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - dwLength too small\n"));\r
+\r
+  if (Image->AuthInfo.Hdr.dwLength <= OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData)) {\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - dwLength too small\n"));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
-  if ((UINTN) Image->AuthInfo.Hdr.dwLength > MAX_UINTN - sizeof(UINT64)) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - dwLength too big\n"));\r
+\r
+  if ((UINTN)Image->AuthInfo.Hdr.dwLength > MAX_UINTN - sizeof (UINT64)) {\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - dwLength too big\n"));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
-  if (ImageSize <= sizeof(Image->MonotonicCount) + Image->AuthInfo.Hdr.dwLength) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too small\n"));\r
+\r
+  if (ImageSize <= sizeof (Image->MonotonicCount) + Image->AuthInfo.Hdr.dwLength) {\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too small\n"));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
+\r
   if (Image->AuthInfo.Hdr.wRevision != 0x0200) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - wRevision: 0x%02x, expect - 0x%02x\n", (UINTN)Image->AuthInfo.Hdr.wRevision, (UINTN)0x0200));\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - wRevision: 0x%02x, expect - 0x%02x\n", (UINTN)Image->AuthInfo.Hdr.wRevision, (UINTN)0x0200));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
+\r
   if (Image->AuthInfo.Hdr.wCertificateType != WIN_CERT_TYPE_EFI_GUID) {\r
-    DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - wCertificateType: 0x%02x, expect - 0x%02x\n", (UINTN)Image->AuthInfo.Hdr.wCertificateType, (UINTN)WIN_CERT_TYPE_EFI_GUID));\r
+    DEBUG ((DEBUG_ERROR, "AuthenticateFmpImage - wCertificateType: 0x%02x, expect - 0x%02x\n", (UINTN)Image->AuthInfo.Hdr.wCertificateType, (UINTN)WIN_CERT_TYPE_EFI_GUID));\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
 \r
   CertType = &Image->AuthInfo.CertType;\r
-  DEBUG((DEBUG_INFO, "AuthenticateFmpImage - CertType: %g\n", CertType));\r
+  DEBUG ((DEBUG_INFO, "AuthenticateFmpImage - CertType: %g\n", CertType));\r
 \r
   if (CompareGuid (&gEfiCertTypeRsa2048Sha256Guid, CertType)) {\r
     //\r
@@ -351,4 +365,3 @@ AuthenticateFmpImage (
   //\r
   return RETURN_UNSUPPORTED;\r
 }\r
-\r
index 52521b6444258ce6deca93ba2438b52ef339445d..c786c2189c4f727d20f4bc0037ea65492db7e03a 100644 (file)
@@ -24,11 +24,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 VOID\r
 Tpm2SetSha1ToDigestList (\r
-  IN TPML_DIGEST_VALUES *DigestList,\r
-  IN UINT8              *Sha1Digest\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  IN UINT8               *Sha1Digest\r
   )\r
 {\r
-  DigestList->count = 1;\r
+  DigestList->count              = 1;\r
   DigestList->digests[0].hashAlg = TPM_ALG_SHA1;\r
   CopyMem (\r
     DigestList->digests[0].digest.sha1,\r
@@ -48,11 +48,11 @@ Tpm2SetSha1ToDigestList (
 EFI_STATUS\r
 EFIAPI\r
 Sha1HashInit (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   )\r
 {\r
-  VOID     *Sha1Ctx;\r
-  UINTN    CtxSize;\r
+  VOID   *Sha1Ctx;\r
+  UINTN  CtxSize;\r
 \r
   CtxSize = Sha1GetContextSize ();\r
   Sha1Ctx = AllocatePool (CtxSize);\r
@@ -77,12 +77,12 @@ Sha1HashInit (
 EFI_STATUS\r
 EFIAPI\r
 Sha1HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   )\r
 {\r
-  VOID     *Sha1Ctx;\r
+  VOID  *Sha1Ctx;\r
 \r
   Sha1Ctx = (VOID *)HashHandle;\r
   Sha1Update (Sha1Ctx, DataToHash, DataToHashLen);\r
@@ -101,12 +101,12 @@ Sha1HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 Sha1HashFinal (\r
-  IN HASH_HANDLE         HashHandle,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  UINT8         Digest[SHA1_DIGEST_SIZE];\r
-  VOID          *Sha1Ctx;\r
+  UINT8  Digest[SHA1_DIGEST_SIZE];\r
+  VOID   *Sha1Ctx;\r
 \r
   Sha1Ctx = (VOID *)HashHandle;\r
   Sha1Final (Sha1Ctx, Digest);\r
@@ -145,5 +145,6 @@ HashInstanceLibSha1Constructor (
     //\r
     return EFI_SUCCESS;\r
   }\r
+\r
   return Status;\r
 }\r
index 760e20bae0002ca754917e1c3a69a7f2a3be2058..43877400011adccc2138dc2db6615242842c3a0b 100644 (file)
@@ -24,11 +24,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 VOID\r
 Tpm2SetSha256ToDigestList (\r
-  IN TPML_DIGEST_VALUES *DigestList,\r
-  IN UINT8              *Sha256Digest\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  IN UINT8               *Sha256Digest\r
   )\r
 {\r
-  DigestList->count = 1;\r
+  DigestList->count              = 1;\r
   DigestList->digests[0].hashAlg = TPM_ALG_SHA256;\r
   CopyMem (\r
     DigestList->digests[0].digest.sha256,\r
@@ -48,13 +48,13 @@ Tpm2SetSha256ToDigestList (
 EFI_STATUS\r
 EFIAPI\r
 Sha256HashInit (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   )\r
 {\r
-  VOID     *Sha256Ctx;\r
-  UINTN    CtxSize;\r
+  VOID   *Sha256Ctx;\r
+  UINTN  CtxSize;\r
 \r
-  CtxSize = Sha256GetContextSize ();\r
+  CtxSize   = Sha256GetContextSize ();\r
   Sha256Ctx = AllocatePool (CtxSize);\r
   ASSERT (Sha256Ctx != NULL);\r
 \r
@@ -77,12 +77,12 @@ Sha256HashInit (
 EFI_STATUS\r
 EFIAPI\r
 Sha256HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   )\r
 {\r
-  VOID     *Sha256Ctx;\r
+  VOID  *Sha256Ctx;\r
 \r
   Sha256Ctx = (VOID *)HashHandle;\r
   Sha256Update (Sha256Ctx, DataToHash, DataToHashLen);\r
@@ -101,12 +101,12 @@ Sha256HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 Sha256HashFinal (\r
-  IN HASH_HANDLE         HashHandle,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  UINT8         Digest[SHA256_DIGEST_SIZE];\r
-  VOID          *Sha256Ctx;\r
+  UINT8  Digest[SHA256_DIGEST_SIZE];\r
+  VOID   *Sha256Ctx;\r
 \r
   Sha256Ctx = (VOID *)HashHandle;\r
   Sha256Final (Sha256Ctx, Digest);\r
@@ -145,5 +145,6 @@ HashInstanceLibSha256Constructor (
     //\r
     return EFI_SUCCESS;\r
   }\r
+\r
   return Status;\r
 }\r
index 99e2416a8eceb11e896e6d46699f98b940950234..1f21483e1642eada780dfe002f711772037fa642 100644 (file)
@@ -24,11 +24,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 VOID\r
 Tpm2SetSha384ToDigestList (\r
-  IN TPML_DIGEST_VALUES *DigestList,\r
-  IN UINT8              *Sha384Digest\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  IN UINT8               *Sha384Digest\r
   )\r
 {\r
-  DigestList->count = 1;\r
+  DigestList->count              = 1;\r
   DigestList->digests[0].hashAlg = TPM_ALG_SHA384;\r
   CopyMem (\r
     DigestList->digests[0].digest.sha384,\r
@@ -48,13 +48,13 @@ Tpm2SetSha384ToDigestList (
 EFI_STATUS\r
 EFIAPI\r
 Sha384HashInit (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   )\r
 {\r
-  VOID     *Sha384Ctx;\r
-  UINTN    CtxSize;\r
+  VOID   *Sha384Ctx;\r
+  UINTN  CtxSize;\r
 \r
-  CtxSize = Sha384GetContextSize ();\r
+  CtxSize   = Sha384GetContextSize ();\r
   Sha384Ctx = AllocatePool (CtxSize);\r
   ASSERT (Sha384Ctx != NULL);\r
 \r
@@ -77,12 +77,12 @@ Sha384HashInit (
 EFI_STATUS\r
 EFIAPI\r
 Sha384HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   )\r
 {\r
-  VOID     *Sha384Ctx;\r
+  VOID  *Sha384Ctx;\r
 \r
   Sha384Ctx = (VOID *)HashHandle;\r
   Sha384Update (Sha384Ctx, DataToHash, DataToHashLen);\r
@@ -101,12 +101,12 @@ Sha384HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 Sha384HashFinal (\r
-  IN HASH_HANDLE         HashHandle,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  UINT8         Digest[SHA384_DIGEST_SIZE];\r
-  VOID          *Sha384Ctx;\r
+  UINT8  Digest[SHA384_DIGEST_SIZE];\r
+  VOID   *Sha384Ctx;\r
 \r
   Sha384Ctx = (VOID *)HashHandle;\r
   Sha384Final (Sha384Ctx, Digest);\r
@@ -145,5 +145,6 @@ HashInstanceLibSha384Constructor (
     //\r
     return EFI_SUCCESS;\r
   }\r
+\r
   return Status;\r
 }\r
index b047791e028fddd7f0572f0dec36dbd7d7f9c3b4..e25ecb9ed6f9586c9399c763a4f66375aeb288cc 100644 (file)
@@ -23,11 +23,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 VOID\r
 Tpm2SetSha512ToDigestList (\r
-  IN TPML_DIGEST_VALUES *DigestList,\r
-  IN UINT8              *Sha512Digest\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  IN UINT8               *Sha512Digest\r
   )\r
 {\r
-  DigestList->count = 1;\r
+  DigestList->count              = 1;\r
   DigestList->digests[0].hashAlg = TPM_ALG_SHA512;\r
   CopyMem (\r
     DigestList->digests[0].digest.sha512,\r
@@ -47,13 +47,13 @@ Tpm2SetSha512ToDigestList (
 EFI_STATUS\r
 EFIAPI\r
 Sha512HashInit (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   )\r
 {\r
-  VOID     *Sha512Ctx;\r
-  UINTN    CtxSize;\r
+  VOID   *Sha512Ctx;\r
+  UINTN  CtxSize;\r
 \r
-  CtxSize = Sha512GetContextSize ();\r
+  CtxSize   = Sha512GetContextSize ();\r
   Sha512Ctx = AllocatePool (CtxSize);\r
   ASSERT (Sha512Ctx != NULL);\r
 \r
@@ -76,12 +76,12 @@ Sha512HashInit (
 EFI_STATUS\r
 EFIAPI\r
 Sha512HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   )\r
 {\r
-  VOID     *Sha512Ctx;\r
+  VOID  *Sha512Ctx;\r
 \r
   Sha512Ctx = (VOID *)HashHandle;\r
   Sha512Update (Sha512Ctx, DataToHash, DataToHashLen);\r
@@ -100,12 +100,12 @@ Sha512HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 Sha512HashFinal (\r
-  IN HASH_HANDLE         HashHandle,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  UINT8         Digest[SHA512_DIGEST_SIZE];\r
-  VOID          *Sha512Ctx;\r
+  UINT8  Digest[SHA512_DIGEST_SIZE];\r
+  VOID   *Sha512Ctx;\r
 \r
   Sha512Ctx = (VOID *)HashHandle;\r
   Sha512Final (Sha512Ctx, Digest);\r
@@ -144,5 +144,6 @@ HashInstanceLibSha512Constructor (
     //\r
     return EFI_SUCCESS;\r
   }\r
+\r
   return Status;\r
 }\r
index 8fd95162118aea01a7211efd3a05bab4c45d2598..635ca1ebfbc88d4a15b77004c7c0156f430249ee 100644 (file)
 **/\r
 VOID\r
 Tpm2SetSm3ToDigestList (\r
-  IN TPML_DIGEST_VALUES *DigestList,\r
-  IN UINT8              *Sm3Digest\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  IN UINT8               *Sm3Digest\r
   )\r
 {\r
-  DigestList->count = 1;\r
+  DigestList->count              = 1;\r
   DigestList->digests[0].hashAlg = TPM_ALG_SM3_256;\r
   CopyMem (\r
     DigestList->digests[0].digest.sm3_256,\r
@@ -47,14 +47,14 @@ Tpm2SetSm3ToDigestList (
 EFI_STATUS\r
 EFIAPI\r
 Sm3HashInit (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   )\r
 {\r
-  VOID     *Sm3Ctx;\r
-  UINTN    CtxSize;\r
+  VOID   *Sm3Ctx;\r
+  UINTN  CtxSize;\r
 \r
   CtxSize = Sm3GetContextSize ();\r
-  Sm3Ctx = AllocatePool (CtxSize);\r
+  Sm3Ctx  = AllocatePool (CtxSize);\r
   if (Sm3Ctx == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
@@ -78,12 +78,12 @@ Sm3HashInit (
 EFI_STATUS\r
 EFIAPI\r
 Sm3HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   )\r
 {\r
-  VOID     *Sm3Ctx;\r
+  VOID  *Sm3Ctx;\r
 \r
   Sm3Ctx = (VOID *)HashHandle;\r
   Sm3Update (Sm3Ctx, DataToHash, DataToHashLen);\r
@@ -102,12 +102,12 @@ Sm3HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 Sm3HashFinal (\r
-  IN HASH_HANDLE         HashHandle,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  UINT8         Digest[SM3_256_DIGEST_SIZE];\r
-  VOID          *Sm3Ctx;\r
+  UINT8  Digest[SM3_256_DIGEST_SIZE];\r
+  VOID   *Sm3Ctx;\r
 \r
   Sm3Ctx = (VOID *)HashHandle;\r
   Sm3Final (Sm3Ctx, Digest);\r
@@ -146,5 +146,6 @@ HashInstanceLibSm3Constructor (
     //\r
     return EFI_SUCCESS;\r
   }\r
+\r
   return Status;\r
 }\r
index aec874a9e07212fb847e45e6050fed9f4c95fa0b..10133808447c85d9b73075b77a166e9b95262bd4 100644 (file)
@@ -16,16 +16,16 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Protocol/Tcg2Protocol.h>\r
 \r
 typedef struct {\r
-  EFI_GUID  Guid;\r
-  UINT32    Mask;\r
+  EFI_GUID    Guid;\r
+  UINT32      Mask;\r
 } TPM2_HASH_MASK;\r
 \r
-TPM2_HASH_MASK mTpm2HashMask[] = {\r
-  {HASH_ALGORITHM_SHA1_GUID,         HASH_ALG_SHA1},\r
-  {HASH_ALGORITHM_SHA256_GUID,       HASH_ALG_SHA256},\r
-  {HASH_ALGORITHM_SHA384_GUID,       HASH_ALG_SHA384},\r
-  {HASH_ALGORITHM_SHA512_GUID,       HASH_ALG_SHA512},\r
-  {HASH_ALGORITHM_SM3_256_GUID,      HASH_ALG_SM3_256},\r
+TPM2_HASH_MASK  mTpm2HashMask[] = {\r
+  { HASH_ALGORITHM_SHA1_GUID,    HASH_ALG_SHA1    },\r
+  { HASH_ALGORITHM_SHA256_GUID,  HASH_ALG_SHA256  },\r
+  { HASH_ALGORITHM_SHA384_GUID,  HASH_ALG_SHA384  },\r
+  { HASH_ALGORITHM_SHA512_GUID,  HASH_ALG_SHA512  },\r
+  { HASH_ALGORITHM_SM3_256_GUID, HASH_ALG_SM3_256 },\r
 };\r
 \r
 /**\r
@@ -42,11 +42,13 @@ Tpm2GetHashMaskFromAlgo (
   )\r
 {\r
   UINTN  Index;\r
-  for (Index = 0; Index < sizeof(mTpm2HashMask)/sizeof(mTpm2HashMask[0]); Index++) {\r
+\r
+  for (Index = 0; Index < sizeof (mTpm2HashMask)/sizeof (mTpm2HashMask[0]); Index++) {\r
     if (CompareGuid (HashGuid, &mTpm2HashMask[Index].Guid)) {\r
       return mTpm2HashMask[Index].Mask;\r
     }\r
   }\r
+\r
   return 0;\r
 }\r
 \r
@@ -59,14 +61,14 @@ Tpm2GetHashMaskFromAlgo (
 VOID\r
 EFIAPI\r
 Tpm2SetHashToDigestList (\r
-  IN OUT TPML_DIGEST_VALUES *DigestList,\r
-  IN TPML_DIGEST_VALUES     *Digest\r
+  IN OUT TPML_DIGEST_VALUES  *DigestList,\r
+  IN TPML_DIGEST_VALUES      *Digest\r
   )\r
 {\r
   CopyMem (\r
     &DigestList->digests[DigestList->count],\r
     &Digest->digests[0],\r
-    sizeof(Digest->digests[0])\r
+    sizeof (Digest->digests[0])\r
     );\r
-  DigestList->count ++;\r
+  DigestList->count++;\r
 }\r
index 0736358da8c97c4d1a2d0d5e25b29520f2d16473..987d794028dfe675c9c1731f964f47cac4b4862b 100644 (file)
@@ -31,8 +31,8 @@ Tpm2GetHashMaskFromAlgo (
 VOID\r
 EFIAPI\r
 Tpm2SetHashToDigestList (\r
-  IN OUT TPML_DIGEST_VALUES *DigestList,\r
-  IN TPML_DIGEST_VALUES     *Digest\r
+  IN OUT TPML_DIGEST_VALUES  *DigestList,\r
+  IN TPML_DIGEST_VALUES      *Digest\r
   );\r
 \r
 #endif\r
index 7a0f61efbb8c665b5cfeead504349dcdc782be41..59639d053858d85fd72852888c556e764f09dd29 100644 (file)
@@ -19,11 +19,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "HashLibBaseCryptoRouterCommon.h"\r
 \r
-HASH_INTERFACE   mHashInterface[HASH_COUNT] = {{{0}, NULL, NULL, NULL}};\r
-UINTN            mHashInterfaceCount = 0;\r
+HASH_INTERFACE  mHashInterface[HASH_COUNT] = {\r
+  {\r
+    { 0 }, NULL, NULL, NULL\r
+  }\r
+};\r
+UINTN           mHashInterfaceCount = 0;\r
 \r
-UINT32           mSupportedHashMaskLast = 0;\r
-UINT32           mSupportedHashMaskCurrent = 0;\r
+UINT32  mSupportedHashMaskLast    = 0;\r
+UINT32  mSupportedHashMaskCurrent = 0;\r
 \r
 /**\r
   Check mismatch of supported HashMask between modules\r
@@ -57,7 +61,7 @@ CheckSupportedHashMaskMismatch (
 EFI_STATUS\r
 EFIAPI\r
 HashStart (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   )\r
 {\r
   HASH_HANDLE  *HashCtx;\r
@@ -70,7 +74,7 @@ HashStart (
 \r
   CheckSupportedHashMaskMismatch ();\r
 \r
-  HashCtx = AllocatePool (sizeof(*HashCtx) * mHashInterfaceCount);\r
+  HashCtx = AllocatePool (sizeof (*HashCtx) * mHashInterfaceCount);\r
   ASSERT (HashCtx != NULL);\r
 \r
   for (Index = 0; Index < mHashInterfaceCount; Index++) {\r
@@ -97,9 +101,9 @@ HashStart (
 EFI_STATUS\r
 EFIAPI\r
 HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   )\r
 {\r
   HASH_HANDLE  *HashCtx;\r
@@ -138,18 +142,18 @@ HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 HashCompleteAndExtend (\r
-  IN HASH_HANDLE         HashHandle,\r
-  IN TPMI_DH_PCR         PcrIndex,\r
-  IN VOID                *DataToHash,\r
-  IN UINTN               DataToHashLen,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  IN TPMI_DH_PCR          PcrIndex,\r
+  IN VOID                 *DataToHash,\r
+  IN UINTN                DataToHashLen,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  TPML_DIGEST_VALUES Digest;\r
-  HASH_HANDLE        *HashCtx;\r
-  UINTN              Index;\r
-  EFI_STATUS         Status;\r
-  UINT32             HashMask;\r
+  TPML_DIGEST_VALUES  Digest;\r
+  HASH_HANDLE         *HashCtx;\r
+  UINTN               Index;\r
+  EFI_STATUS          Status;\r
+  UINT32              HashMask;\r
 \r
   if (mHashInterfaceCount == 0) {\r
     return EFI_UNSUPPORTED;\r
@@ -158,7 +162,7 @@ HashCompleteAndExtend (
   CheckSupportedHashMaskMismatch ();\r
 \r
   HashCtx = (HASH_HANDLE *)HashHandle;\r
-  ZeroMem (DigestList, sizeof(*DigestList));\r
+  ZeroMem (DigestList, sizeof (*DigestList));\r
 \r
   for (Index = 0; Index < mHashInterfaceCount; Index++) {\r
     HashMask = Tpm2GetHashMaskFromAlgo (&mHashInterface[Index].HashGuid);\r
@@ -191,14 +195,14 @@ HashCompleteAndExtend (
 EFI_STATUS\r
 EFIAPI\r
 HashAndExtend (\r
-  IN TPMI_DH_PCR                    PcrIndex,\r
-  IN VOID                           *DataToHash,\r
-  IN UINTN                          DataToHashLen,\r
-  OUT TPML_DIGEST_VALUES            *DigestList\r
+  IN TPMI_DH_PCR          PcrIndex,\r
+  IN VOID                 *DataToHash,\r
+  IN UINTN                DataToHashLen,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  HASH_HANDLE    HashHandle;\r
-  EFI_STATUS     Status;\r
+  HASH_HANDLE  HashHandle;\r
+  EFI_STATUS   Status;\r
 \r
   if (mHashInterfaceCount == 0) {\r
     return EFI_UNSUPPORTED;\r
@@ -225,12 +229,12 @@ HashAndExtend (
 EFI_STATUS\r
 EFIAPI\r
 RegisterHashInterfaceLib (\r
-  IN HASH_INTERFACE   *HashInterface\r
+  IN HASH_INTERFACE  *HashInterface\r
   )\r
 {\r
-  UINTN              Index;\r
-  UINT32             HashMask;\r
-  EFI_STATUS         Status;\r
+  UINTN       Index;\r
+  UINT32      HashMask;\r
+  EFI_STATUS  Status;\r
 \r
   //\r
   // Check allow\r
@@ -240,7 +244,7 @@ RegisterHashInterfaceLib (
     return EFI_UNSUPPORTED;\r
   }\r
 \r
-  if (mHashInterfaceCount >= sizeof(mHashInterface)/sizeof(mHashInterface[0])) {\r
+  if (mHashInterfaceCount >= sizeof (mHashInterface)/sizeof (mHashInterface[0])) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
@@ -258,11 +262,11 @@ RegisterHashInterfaceLib (
   // Record hash algorithm bitmap of CURRENT module which consumes HashLib.\r
   //\r
   mSupportedHashMaskCurrent = PcdGet32 (PcdTcg2HashAlgorithmBitmap) | HashMask;\r
-  Status = PcdSet32S (PcdTcg2HashAlgorithmBitmap, mSupportedHashMaskCurrent);\r
+  Status                    = PcdSet32S (PcdTcg2HashAlgorithmBitmap, mSupportedHashMaskCurrent);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  CopyMem (&mHashInterface[mHashInterfaceCount], HashInterface, sizeof(*HashInterface));\r
-  mHashInterfaceCount ++;\r
+  CopyMem (&mHashInterface[mHashInterfaceCount], HashInterface, sizeof (*HashInterface));\r
+  mHashInterfaceCount++;\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -283,7 +287,7 @@ HashLibBaseCryptoRouterDxeConstructor (
   IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   //\r
   // Record hash algorithm bitmap of LAST module which also consumes HashLib.\r
index 42cb562f67d333df728db2d9d324f77bfad20b62..e21103d3711bd8c691962ad8d86a074c88dae9bd 100644 (file)
@@ -24,7 +24,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define HASH_LIB_PEI_ROUTER_GUID \\r
   { 0x84681c08, 0x6873, 0x46f3, { 0x8b, 0xb7, 0xab, 0x66, 0x18, 0x95, 0xa1, 0xb3 } }\r
 \r
-EFI_GUID mHashLibPeiRouterGuid = HASH_LIB_PEI_ROUTER_GUID;\r
+EFI_GUID  mHashLibPeiRouterGuid = HASH_LIB_PEI_ROUTER_GUID;\r
 \r
 typedef struct {\r
   //\r
@@ -34,10 +34,10 @@ typedef struct {
   // If gEfiCallerIdGuid, HashInterfaceCount, HashInterface and SupportedHashMask\r
   //   are the hash interface information of CURRENT module which consumes HashLib.\r
   //\r
-  EFI_GUID         Identifier;\r
-  UINTN            HashInterfaceCount;\r
-  HASH_INTERFACE   HashInterface[HASH_COUNT];\r
-  UINT32           SupportedHashMask;\r
+  EFI_GUID          Identifier;\r
+  UINTN             HashInterfaceCount;\r
+  HASH_INTERFACE    HashInterface[HASH_COUNT];\r
+  UINT32            SupportedHashMask;\r
 } HASH_INTERFACE_HOB;\r
 \r
 /**\r
@@ -49,7 +49,7 @@ typedef struct {
 **/\r
 HASH_INTERFACE_HOB *\r
 InternalGetHashInterfaceHob (\r
-  EFI_GUID      *Identifier\r
+  EFI_GUID  *Identifier\r
   )\r
 {\r
   EFI_PEI_HOB_POINTERS  Hob;\r
@@ -64,9 +64,11 @@ InternalGetHashInterfaceHob (
       //\r
       return HashInterfaceHob;\r
     }\r
+\r
     Hob.Raw = GET_NEXT_HOB (Hob);\r
     Hob.Raw = GetNextGuidHob (&mHashLibPeiRouterGuid, Hob.Raw);\r
   }\r
+\r
   return NULL;\r
 }\r
 \r
@@ -79,14 +81,14 @@ InternalGetHashInterfaceHob (
 **/\r
 HASH_INTERFACE_HOB *\r
 InternalCreateHashInterfaceHob (\r
-  EFI_GUID      *Identifier\r
+  EFI_GUID  *Identifier\r
   )\r
 {\r
-  HASH_INTERFACE_HOB LocalHashInterfaceHob;\r
+  HASH_INTERFACE_HOB  LocalHashInterfaceHob;\r
 \r
-  ZeroMem (&LocalHashInterfaceHob, sizeof(LocalHashInterfaceHob));\r
+  ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob));\r
   CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier);\r
-  return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, sizeof(LocalHashInterfaceHob));\r
+  return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob));\r
 }\r
 \r
 /**\r
@@ -98,16 +100,17 @@ InternalCreateHashInterfaceHob (
 **/\r
 VOID\r
 CheckSupportedHashMaskMismatch (\r
-  IN HASH_INTERFACE_HOB *HashInterfaceHobCurrent\r
+  IN HASH_INTERFACE_HOB  *HashInterfaceHobCurrent\r
   )\r
 {\r
-  HASH_INTERFACE_HOB    *HashInterfaceHobLast;\r
+  HASH_INTERFACE_HOB  *HashInterfaceHobLast;\r
 \r
   HashInterfaceHobLast = InternalGetHashInterfaceHob (&gZeroGuid);\r
   ASSERT (HashInterfaceHobLast != NULL);\r
 \r
   if ((HashInterfaceHobLast->SupportedHashMask != 0) &&\r
-      (HashInterfaceHobCurrent->SupportedHashMask != HashInterfaceHobLast->SupportedHashMask)) {\r
+      (HashInterfaceHobCurrent->SupportedHashMask != HashInterfaceHobLast->SupportedHashMask))\r
+  {\r
     DEBUG ((\r
       DEBUG_WARN,\r
       "WARNING: There is mismatch of supported HashMask (0x%x - 0x%x) between modules\n",\r
@@ -129,13 +132,13 @@ CheckSupportedHashMaskMismatch (
 EFI_STATUS\r
 EFIAPI\r
 HashStart (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   )\r
 {\r
-  HASH_INTERFACE_HOB *HashInterfaceHob;\r
-  HASH_HANDLE        *HashCtx;\r
-  UINTN              Index;\r
-  UINT32             HashMask;\r
+  HASH_INTERFACE_HOB  *HashInterfaceHob;\r
+  HASH_HANDLE         *HashCtx;\r
+  UINTN               Index;\r
+  UINT32              HashMask;\r
 \r
   HashInterfaceHob = InternalGetHashInterfaceHob (&gEfiCallerIdGuid);\r
   if (HashInterfaceHob == NULL) {\r
@@ -148,7 +151,7 @@ HashStart (
 \r
   CheckSupportedHashMaskMismatch (HashInterfaceHob);\r
 \r
-  HashCtx = AllocatePool (sizeof(*HashCtx) * HashInterfaceHob->HashInterfaceCount);\r
+  HashCtx = AllocatePool (sizeof (*HashCtx) * HashInterfaceHob->HashInterfaceCount);\r
   ASSERT (HashCtx != NULL);\r
 \r
   for (Index = 0; Index < HashInterfaceHob->HashInterfaceCount; Index++) {\r
@@ -175,15 +178,15 @@ HashStart (
 EFI_STATUS\r
 EFIAPI\r
 HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   )\r
 {\r
-  HASH_INTERFACE_HOB *HashInterfaceHob;\r
-  HASH_HANDLE        *HashCtx;\r
-  UINTN              Index;\r
-  UINT32             HashMask;\r
+  HASH_INTERFACE_HOB  *HashInterfaceHob;\r
+  HASH_HANDLE         *HashCtx;\r
+  UINTN               Index;\r
+  UINT32              HashMask;\r
 \r
   HashInterfaceHob = InternalGetHashInterfaceHob (&gEfiCallerIdGuid);\r
   if (HashInterfaceHob == NULL) {\r
@@ -222,19 +225,19 @@ HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 HashCompleteAndExtend (\r
-  IN HASH_HANDLE         HashHandle,\r
-  IN TPMI_DH_PCR         PcrIndex,\r
-  IN VOID                *DataToHash,\r
-  IN UINTN               DataToHashLen,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  IN TPMI_DH_PCR          PcrIndex,\r
+  IN VOID                 *DataToHash,\r
+  IN UINTN                DataToHashLen,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  TPML_DIGEST_VALUES Digest;\r
-  HASH_INTERFACE_HOB *HashInterfaceHob;\r
-  HASH_HANDLE        *HashCtx;\r
-  UINTN              Index;\r
-  EFI_STATUS         Status;\r
-  UINT32             HashMask;\r
+  TPML_DIGEST_VALUES  Digest;\r
+  HASH_INTERFACE_HOB  *HashInterfaceHob;\r
+  HASH_HANDLE         *HashCtx;\r
+  UINTN               Index;\r
+  EFI_STATUS          Status;\r
+  UINT32              HashMask;\r
 \r
   HashInterfaceHob = InternalGetHashInterfaceHob (&gEfiCallerIdGuid);\r
   if (HashInterfaceHob == NULL) {\r
@@ -248,7 +251,7 @@ HashCompleteAndExtend (
   CheckSupportedHashMaskMismatch (HashInterfaceHob);\r
 \r
   HashCtx = (HASH_HANDLE *)HashHandle;\r
-  ZeroMem (DigestList, sizeof(*DigestList));\r
+  ZeroMem (DigestList, sizeof (*DigestList));\r
 \r
   for (Index = 0; Index < HashInterfaceHob->HashInterfaceCount; Index++) {\r
     HashMask = Tpm2GetHashMaskFromAlgo (&HashInterfaceHob->HashInterface[Index].HashGuid);\r
@@ -281,15 +284,15 @@ HashCompleteAndExtend (
 EFI_STATUS\r
 EFIAPI\r
 HashAndExtend (\r
-  IN TPMI_DH_PCR                    PcrIndex,\r
-  IN VOID                           *DataToHash,\r
-  IN UINTN                          DataToHashLen,\r
-  OUT TPML_DIGEST_VALUES            *DigestList\r
+  IN TPMI_DH_PCR          PcrIndex,\r
+  IN VOID                 *DataToHash,\r
+  IN UINTN                DataToHashLen,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  HASH_INTERFACE_HOB *HashInterfaceHob;\r
-  HASH_HANDLE        HashHandle;\r
-  EFI_STATUS         Status;\r
+  HASH_INTERFACE_HOB  *HashInterfaceHob;\r
+  HASH_HANDLE         HashHandle;\r
+  EFI_STATUS          Status;\r
 \r
   HashInterfaceHob = InternalGetHashInterfaceHob (&gEfiCallerIdGuid);\r
   if (HashInterfaceHob == NULL) {\r
@@ -321,13 +324,13 @@ HashAndExtend (
 EFI_STATUS\r
 EFIAPI\r
 RegisterHashInterfaceLib (\r
-  IN HASH_INTERFACE   *HashInterface\r
+  IN HASH_INTERFACE  *HashInterface\r
   )\r
 {\r
-  UINTN              Index;\r
-  HASH_INTERFACE_HOB *HashInterfaceHob;\r
-  UINT32             HashMask;\r
-  EFI_STATUS         Status;\r
+  UINTN               Index;\r
+  HASH_INTERFACE_HOB  *HashInterfaceHob;\r
+  UINT32              HashMask;\r
+  EFI_STATUS          Status;\r
 \r
   //\r
   // Check allow\r
@@ -363,11 +366,11 @@ RegisterHashInterfaceLib (
   // Record hash algorithm bitmap of CURRENT module which consumes HashLib.\r
   //\r
   HashInterfaceHob->SupportedHashMask = PcdGet32 (PcdTcg2HashAlgorithmBitmap) | HashMask;\r
-  Status = PcdSet32S (PcdTcg2HashAlgorithmBitmap, HashInterfaceHob->SupportedHashMask);\r
+  Status                              = PcdSet32S (PcdTcg2HashAlgorithmBitmap, HashInterfaceHob->SupportedHashMask);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  CopyMem (&HashInterfaceHob->HashInterface[HashInterfaceHob->HashInterfaceCount], HashInterface, sizeof(*HashInterface));\r
-  HashInterfaceHob->HashInterfaceCount ++;\r
+  CopyMem (&HashInterfaceHob->HashInterface[HashInterfaceHob->HashInterfaceCount], HashInterface, sizeof (*HashInterface));\r
+  HashInterfaceHob->HashInterfaceCount++;\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -385,12 +388,12 @@ RegisterHashInterfaceLib (
 EFI_STATUS\r
 EFIAPI\r
 HashLibBaseCryptoRouterPeiConstructor (\r
-  IN EFI_PEI_FILE_HANDLE        FileHandle,\r
-  IN CONST EFI_PEI_SERVICES     **PeiServices\r
+  IN EFI_PEI_FILE_HANDLE     FileHandle,\r
+  IN CONST EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  HASH_INTERFACE_HOB    *HashInterfaceHob;\r
+  EFI_STATUS          Status;\r
+  HASH_INTERFACE_HOB  *HashInterfaceHob;\r
 \r
   HashInterfaceHob = InternalGetHashInterfaceHob (&gZeroGuid);\r
   if (HashInterfaceHob == NULL) {\r
@@ -420,7 +423,7 @@ HashLibBaseCryptoRouterPeiConstructor (
     //\r
     ZeroMem (&HashInterfaceHob->HashInterface, sizeof (HashInterfaceHob->HashInterface));\r
     HashInterfaceHob->HashInterfaceCount = 0;\r
-    HashInterfaceHob->SupportedHashMask = 0;\r
+    HashInterfaceHob->SupportedHashMask  = 0;\r
   }\r
 \r
   //\r
index 876b15fad4d3ee2d67547e5704fe71f6f5c510d5..00ba80b884e859e5755e3ed801ee0956afdc9d79 100644 (file)
@@ -17,15 +17,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/PcdLib.h>\r
 \r
 typedef struct {\r
-  TPM_ALG_ID AlgoId;\r
-  UINT32     Mask;\r
+  TPM_ALG_ID    AlgoId;\r
+  UINT32        Mask;\r
 } TPM2_HASH_MASK;\r
 \r
-TPM2_HASH_MASK mTpm2HashMask[] = {\r
-  {TPM_ALG_SHA1,         HASH_ALG_SHA1},\r
-  {TPM_ALG_SHA256,       HASH_ALG_SHA256},\r
-  {TPM_ALG_SHA384,       HASH_ALG_SHA384},\r
-  {TPM_ALG_SHA512,       HASH_ALG_SHA512},\r
+TPM2_HASH_MASK  mTpm2HashMask[] = {\r
+  { TPM_ALG_SHA1,   HASH_ALG_SHA1   },\r
+  { TPM_ALG_SHA256, HASH_ALG_SHA256 },\r
+  { TPM_ALG_SHA384, HASH_ALG_SHA384 },\r
+  { TPM_ALG_SHA512, HASH_ALG_SHA512 },\r
 };\r
 \r
 /**\r
@@ -38,11 +38,11 @@ Tpm2GetAlgoFromHashMask (
   VOID\r
   )\r
 {\r
-  UINT32 HashMask;\r
-  UINTN  Index;\r
+  UINT32  HashMask;\r
+  UINTN   Index;\r
 \r
   HashMask = PcdGet32 (PcdTpm2HashMask);\r
-  for (Index = 0; Index < sizeof(mTpm2HashMask)/sizeof(mTpm2HashMask[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTpm2HashMask)/sizeof (mTpm2HashMask[0]); Index++) {\r
     if (mTpm2HashMask[Index].Mask == HashMask) {\r
       return mTpm2HashMask[Index].AlgoId;\r
     }\r
@@ -62,12 +62,12 @@ Tpm2GetAlgoFromHashMask (
 EFI_STATUS\r
 EFIAPI\r
 HashStart (\r
-  OUT HASH_HANDLE    *HashHandle\r
+  OUT HASH_HANDLE  *HashHandle\r
   )\r
 {\r
-  TPMI_DH_OBJECT        SequenceHandle;\r
-  EFI_STATUS            Status;\r
-  TPM_ALG_ID            AlgoId;\r
+  TPMI_DH_OBJECT  SequenceHandle;\r
+  EFI_STATUS      Status;\r
+  TPM_ALG_ID      AlgoId;\r
 \r
   AlgoId = Tpm2GetAlgoFromHashMask ();\r
 \r
@@ -75,6 +75,7 @@ HashStart (
   if (!EFI_ERROR (Status)) {\r
     *HashHandle = (HASH_HANDLE)SequenceHandle;\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -90,25 +91,24 @@ HashStart (
 EFI_STATUS\r
 EFIAPI\r
 HashUpdate (\r
-  IN HASH_HANDLE    HashHandle,\r
-  IN VOID           *DataToHash,\r
-  IN UINTN          DataToHashLen\r
+  IN HASH_HANDLE  HashHandle,\r
+  IN VOID         *DataToHash,\r
+  IN UINTN        DataToHashLen\r
   )\r
 {\r
-  UINT8            *Buffer;\r
-  UINT64           HashLen;\r
-  TPM2B_MAX_BUFFER HashBuffer;\r
-  EFI_STATUS       Status;\r
+  UINT8             *Buffer;\r
+  UINT64            HashLen;\r
+  TPM2B_MAX_BUFFER  HashBuffer;\r
+  EFI_STATUS        Status;\r
 \r
   Buffer = (UINT8 *)(UINTN)DataToHash;\r
-  for (HashLen = DataToHashLen; HashLen > sizeof(HashBuffer.buffer); HashLen -= sizeof(HashBuffer.buffer)) {\r
-\r
-    HashBuffer.size = sizeof(HashBuffer.buffer);\r
-    CopyMem(HashBuffer.buffer, Buffer, sizeof(HashBuffer.buffer));\r
-    Buffer += sizeof(HashBuffer.buffer);\r
+  for (HashLen = DataToHashLen; HashLen > sizeof (HashBuffer.buffer); HashLen -= sizeof (HashBuffer.buffer)) {\r
+    HashBuffer.size = sizeof (HashBuffer.buffer);\r
+    CopyMem (HashBuffer.buffer, Buffer, sizeof (HashBuffer.buffer));\r
+    Buffer += sizeof (HashBuffer.buffer);\r
 \r
-    Status = Tpm2SequenceUpdate((TPMI_DH_OBJECT)HashHandle, &HashBuffer);\r
-    if (EFI_ERROR(Status)) {\r
+    Status = Tpm2SequenceUpdate ((TPMI_DH_OBJECT)HashHandle, &HashBuffer);\r
+    if (EFI_ERROR (Status)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
   }\r
@@ -117,9 +117,9 @@ HashUpdate (
   // Last one\r
   //\r
   HashBuffer.size = (UINT16)HashLen;\r
-  CopyMem(HashBuffer.buffer, Buffer, (UINTN)HashLen);\r
-  Status = Tpm2SequenceUpdate((TPMI_DH_OBJECT)HashHandle, &HashBuffer);\r
-  if (EFI_ERROR(Status)) {\r
+  CopyMem (HashBuffer.buffer, Buffer, (UINTN)HashLen);\r
+  Status = Tpm2SequenceUpdate ((TPMI_DH_OBJECT)HashHandle, &HashBuffer);\r
+  if (EFI_ERROR (Status)) {\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -140,31 +140,30 @@ HashUpdate (
 EFI_STATUS\r
 EFIAPI\r
 HashCompleteAndExtend (\r
-  IN HASH_HANDLE         HashHandle,\r
-  IN TPMI_DH_PCR         PcrIndex,\r
-  IN VOID                *DataToHash,\r
-  IN UINTN               DataToHashLen,\r
-  OUT TPML_DIGEST_VALUES *DigestList\r
+  IN HASH_HANDLE          HashHandle,\r
+  IN TPMI_DH_PCR          PcrIndex,\r
+  IN VOID                 *DataToHash,\r
+  IN UINTN                DataToHashLen,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  UINT8            *Buffer;\r
-  UINT64           HashLen;\r
-  TPM2B_MAX_BUFFER HashBuffer;\r
-  EFI_STATUS       Status;\r
-  TPM_ALG_ID       AlgoId;\r
-  TPM2B_DIGEST     Result;\r
+  UINT8             *Buffer;\r
+  UINT64            HashLen;\r
+  TPM2B_MAX_BUFFER  HashBuffer;\r
+  EFI_STATUS        Status;\r
+  TPM_ALG_ID        AlgoId;\r
+  TPM2B_DIGEST      Result;\r
 \r
   AlgoId = Tpm2GetAlgoFromHashMask ();\r
 \r
   Buffer = (UINT8 *)(UINTN)DataToHash;\r
-  for (HashLen = DataToHashLen; HashLen > sizeof(HashBuffer.buffer); HashLen -= sizeof(HashBuffer.buffer)) {\r
+  for (HashLen = DataToHashLen; HashLen > sizeof (HashBuffer.buffer); HashLen -= sizeof (HashBuffer.buffer)) {\r
+    HashBuffer.size = sizeof (HashBuffer.buffer);\r
+    CopyMem (HashBuffer.buffer, Buffer, sizeof (HashBuffer.buffer));\r
+    Buffer += sizeof (HashBuffer.buffer);\r
 \r
-    HashBuffer.size = sizeof(HashBuffer.buffer);\r
-    CopyMem(HashBuffer.buffer, Buffer, sizeof(HashBuffer.buffer));\r
-    Buffer += sizeof(HashBuffer.buffer);\r
-\r
-    Status = Tpm2SequenceUpdate((TPMI_DH_OBJECT)HashHandle, &HashBuffer);\r
-    if (EFI_ERROR(Status)) {\r
+    Status = Tpm2SequenceUpdate ((TPMI_DH_OBJECT)HashHandle, &HashBuffer);\r
+    if (EFI_ERROR (Status)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
   }\r
@@ -173,9 +172,9 @@ HashCompleteAndExtend (
   // Last one\r
   //\r
   HashBuffer.size = (UINT16)HashLen;\r
-  CopyMem(HashBuffer.buffer, Buffer, (UINTN)HashLen);\r
+  CopyMem (HashBuffer.buffer, Buffer, (UINTN)HashLen);\r
 \r
-  ZeroMem(DigestList, sizeof(*DigestList));\r
+  ZeroMem (DigestList, sizeof (*DigestList));\r
   DigestList->count = HASH_COUNT;\r
 \r
   if (AlgoId == TPM_ALG_NULL) {\r
@@ -191,11 +190,11 @@ HashCompleteAndExtend (
                &HashBuffer,\r
                &Result\r
                );\r
-    if (EFI_ERROR(Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
 \r
-    DigestList->count = 1;\r
+    DigestList->count              = 1;\r
     DigestList->digests[0].hashAlg = AlgoId;\r
     CopyMem (&DigestList->digests[0].digest, Result.buffer, Result.size);\r
     Status = Tpm2PcrExtend (\r
@@ -203,9 +202,11 @@ HashCompleteAndExtend (
                DigestList\r
                );\r
   }\r
-  if (EFI_ERROR(Status)) {\r
+\r
+  if (EFI_ERROR (Status)) {\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   return EFI_SUCCESS;\r
 }\r
 \r
@@ -222,61 +223,63 @@ HashCompleteAndExtend (
 EFI_STATUS\r
 EFIAPI\r
 HashAndExtend (\r
-  IN TPMI_DH_PCR                    PcrIndex,\r
-  IN VOID                           *DataToHash,\r
-  IN UINTN                          DataToHashLen,\r
-  OUT TPML_DIGEST_VALUES            *DigestList\r
+  IN TPMI_DH_PCR          PcrIndex,\r
+  IN VOID                 *DataToHash,\r
+  IN UINTN                DataToHashLen,\r
+  OUT TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  EFI_STATUS         Status;\r
-  UINT8              *Buffer;\r
-  UINT64             HashLen;\r
-  TPMI_DH_OBJECT     SequenceHandle;\r
-  TPM2B_MAX_BUFFER   HashBuffer;\r
-  TPM_ALG_ID         AlgoId;\r
-  TPM2B_EVENT        EventData;\r
-  TPM2B_DIGEST       Result;\r
+  EFI_STATUS        Status;\r
+  UINT8             *Buffer;\r
+  UINT64            HashLen;\r
+  TPMI_DH_OBJECT    SequenceHandle;\r
+  TPM2B_MAX_BUFFER  HashBuffer;\r
+  TPM_ALG_ID        AlgoId;\r
+  TPM2B_EVENT       EventData;\r
+  TPM2B_DIGEST      Result;\r
 \r
-  DEBUG((DEBUG_VERBOSE, "\n HashAndExtend Entry \n"));\r
+  DEBUG ((DEBUG_VERBOSE, "\n HashAndExtend Entry \n"));\r
 \r
   SequenceHandle = 0xFFFFFFFF; // Know bad value\r
 \r
   AlgoId = Tpm2GetAlgoFromHashMask ();\r
 \r
-  if ((AlgoId == TPM_ALG_NULL) && (DataToHashLen <= sizeof(EventData.buffer))) {\r
+  if ((AlgoId == TPM_ALG_NULL) && (DataToHashLen <= sizeof (EventData.buffer))) {\r
     EventData.size = (UINT16)DataToHashLen;\r
     CopyMem (EventData.buffer, DataToHash, DataToHashLen);\r
     Status = Tpm2PcrEvent (PcrIndex, &EventData, DigestList);\r
-    if (EFI_ERROR(Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
+\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  Status = Tpm2HashSequenceStart(AlgoId, &SequenceHandle);\r
-  if (EFI_ERROR(Status)) {\r
+  Status = Tpm2HashSequenceStart (AlgoId, &SequenceHandle);\r
+  if (EFI_ERROR (Status)) {\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  DEBUG((DEBUG_VERBOSE, "\n Tpm2HashSequenceStart Success \n"));\r
 \r
-  Buffer = (UINT8 *)(UINTN)DataToHash;\r
-  for (HashLen = DataToHashLen; HashLen > sizeof(HashBuffer.buffer); HashLen -= sizeof(HashBuffer.buffer)) {\r
+  DEBUG ((DEBUG_VERBOSE, "\n Tpm2HashSequenceStart Success \n"));\r
 \r
-    HashBuffer.size = sizeof(HashBuffer.buffer);\r
-    CopyMem(HashBuffer.buffer, Buffer, sizeof(HashBuffer.buffer));\r
-    Buffer += sizeof(HashBuffer.buffer);\r
+  Buffer = (UINT8 *)(UINTN)DataToHash;\r
+  for (HashLen = DataToHashLen; HashLen > sizeof (HashBuffer.buffer); HashLen -= sizeof (HashBuffer.buffer)) {\r
+    HashBuffer.size = sizeof (HashBuffer.buffer);\r
+    CopyMem (HashBuffer.buffer, Buffer, sizeof (HashBuffer.buffer));\r
+    Buffer += sizeof (HashBuffer.buffer);\r
 \r
-    Status = Tpm2SequenceUpdate(SequenceHandle, &HashBuffer);\r
-    if (EFI_ERROR(Status)) {\r
+    Status = Tpm2SequenceUpdate (SequenceHandle, &HashBuffer);\r
+    if (EFI_ERROR (Status)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
   }\r
-  DEBUG((DEBUG_VERBOSE, "\n Tpm2SequenceUpdate Success \n"));\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n Tpm2SequenceUpdate Success \n"));\r
 \r
   HashBuffer.size = (UINT16)HashLen;\r
-  CopyMem(HashBuffer.buffer, Buffer, (UINTN)HashLen);\r
+  CopyMem (HashBuffer.buffer, Buffer, (UINTN)HashLen);\r
 \r
-  ZeroMem(DigestList, sizeof(*DigestList));\r
+  ZeroMem (DigestList, sizeof (*DigestList));\r
   DigestList->count = HASH_COUNT;\r
 \r
   if (AlgoId == TPM_ALG_NULL) {\r
@@ -286,32 +289,35 @@ HashAndExtend (
                &HashBuffer,\r
                DigestList\r
                );\r
-    if (EFI_ERROR(Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
-    DEBUG((DEBUG_VERBOSE, "\n Tpm2EventSequenceComplete Success \n"));\r
+\r
+    DEBUG ((DEBUG_VERBOSE, "\n Tpm2EventSequenceComplete Success \n"));\r
   } else {\r
     Status = Tpm2SequenceComplete (\r
                SequenceHandle,\r
                &HashBuffer,\r
                &Result\r
                );\r
-    if (EFI_ERROR(Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
-    DEBUG((DEBUG_VERBOSE, "\n Tpm2SequenceComplete Success \n"));\r
 \r
-    DigestList->count = 1;\r
+    DEBUG ((DEBUG_VERBOSE, "\n Tpm2SequenceComplete Success \n"));\r
+\r
+    DigestList->count              = 1;\r
     DigestList->digests[0].hashAlg = AlgoId;\r
     CopyMem (&DigestList->digests[0].digest, Result.buffer, Result.size);\r
     Status = Tpm2PcrExtend (\r
                PcrIndex,\r
                DigestList\r
                );\r
-    if (EFI_ERROR(Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
-    DEBUG((DEBUG_VERBOSE, "\n Tpm2PcrExtend Success \n"));\r
+\r
+    DEBUG ((DEBUG_VERBOSE, "\n Tpm2PcrExtend Success \n"));\r
   }\r
 \r
   return EFI_SUCCESS;\r
@@ -329,7 +335,7 @@ HashAndExtend (
 EFI_STATUS\r
 EFIAPI\r
 RegisterHashInterfaceLib (\r
-  IN HASH_INTERFACE   *HashInterface\r
+  IN HASH_INTERFACE  *HashInterface\r
   )\r
 {\r
   return EFI_UNSUPPORTED;\r
index 0bb04a20fc4acd381a54fbbe3fccc27e29056139..b8838766bc4522049d434442e147bec4222465c0 100644 (file)
@@ -27,7 +27,7 @@
 //   algorithm used for context integrity.\r
 //\r
 \r
-UINT16       mAuthSize;\r
+UINT16  mAuthSize;\r
 \r
 /**\r
   Generate high-quality entropy source through RDRAND.\r
@@ -42,8 +42,8 @@ UINT16       mAuthSize;
 EFI_STATUS\r
 EFIAPI\r
 RdRandGenerateEntropy (\r
-  IN UINTN         Length,\r
-  OUT UINT8        *Entropy\r
+  IN UINTN   Length,\r
+  OUT UINT8  *Entropy\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -51,9 +51,9 @@ RdRandGenerateEntropy (
   UINT64      Seed[2];\r
   UINT8       *Ptr;\r
 \r
-  Status = EFI_NOT_READY;\r
-  BlockCount = Length / sizeof(Seed);\r
-  Ptr = (UINT8 *)Entropy;\r
+  Status     = EFI_NOT_READY;\r
+  BlockCount = Length / sizeof (Seed);\r
+  Ptr        = (UINT8 *)Entropy;\r
 \r
   //\r
   // Generate high-quality seed for DRBG Entropy\r
@@ -63,10 +63,11 @@ RdRandGenerateEntropy (
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
-    CopyMem (Ptr, Seed, sizeof(Seed));\r
+\r
+    CopyMem (Ptr, Seed, sizeof (Seed));\r
 \r
     BlockCount--;\r
-    Ptr = Ptr + sizeof(Seed);\r
+    Ptr = Ptr + sizeof (Seed);\r
   }\r
 \r
   //\r
@@ -76,7 +77,8 @@ RdRandGenerateEntropy (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
-  CopyMem (Ptr, Seed, (Length % sizeof(Seed)));\r
+\r
+  CopyMem (Ptr, Seed, (Length % sizeof (Seed)));\r
 \r
   return Status;\r
 }\r
@@ -94,18 +96,17 @@ RdRandGenerateEntropy (
 EFI_STATUS\r
 EFIAPI\r
 GetAuthSize (\r
-  OUT UINT16            *AuthSize\r
+  OUT UINT16  *AuthSize\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  TPML_PCR_SELECTION    Pcrs;\r
-  UINTN                 Index;\r
-  UINT16                DigestSize;\r
+  EFI_STATUS          Status;\r
+  TPML_PCR_SELECTION  Pcrs;\r
+  UINTN               Index;\r
+  UINT16              DigestSize;\r
 \r
   Status = EFI_SUCCESS;\r
 \r
   while (mAuthSize == 0) {\r
-\r
     mAuthSize = SHA1_DIGEST_SIZE;\r
     ZeroMem (&Pcrs, sizeof (TPML_PCR_SELECTION));\r
     Status = Tpm2GetCapabilityPcrs (&Pcrs);\r
@@ -121,30 +122,31 @@ GetAuthSize (
       DEBUG ((DEBUG_ERROR, "alg - %x\n", Pcrs.pcrSelections[Index].hash));\r
 \r
       switch (Pcrs.pcrSelections[Index].hash) {\r
-      case TPM_ALG_SHA1:\r
-        DigestSize = SHA1_DIGEST_SIZE;\r
-        break;\r
-      case TPM_ALG_SHA256:\r
-        DigestSize = SHA256_DIGEST_SIZE;\r
-        break;\r
-      case TPM_ALG_SHA384:\r
-        DigestSize = SHA384_DIGEST_SIZE;\r
-        break;\r
-      case TPM_ALG_SHA512:\r
-        DigestSize = SHA512_DIGEST_SIZE;\r
-        break;\r
-      case TPM_ALG_SM3_256:\r
-        DigestSize = SM3_256_DIGEST_SIZE;\r
-        break;\r
-      default:\r
-        DigestSize = SHA1_DIGEST_SIZE;\r
-        break;\r
+        case TPM_ALG_SHA1:\r
+          DigestSize = SHA1_DIGEST_SIZE;\r
+          break;\r
+        case TPM_ALG_SHA256:\r
+          DigestSize = SHA256_DIGEST_SIZE;\r
+          break;\r
+        case TPM_ALG_SHA384:\r
+          DigestSize = SHA384_DIGEST_SIZE;\r
+          break;\r
+        case TPM_ALG_SHA512:\r
+          DigestSize = SHA512_DIGEST_SIZE;\r
+          break;\r
+        case TPM_ALG_SM3_256:\r
+          DigestSize = SM3_256_DIGEST_SIZE;\r
+          break;\r
+        default:\r
+          DigestSize = SHA1_DIGEST_SIZE;\r
+          break;\r
       }\r
 \r
       if (DigestSize > mAuthSize) {\r
         mAuthSize = DigestSize;\r
       }\r
     }\r
+\r
     break;\r
   }\r
 \r
@@ -160,9 +162,9 @@ RandomizePlatformAuth (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINT16                            AuthSize;\r
-  TPM2B_AUTH                        NewPlatformAuth;\r
+  EFI_STATUS  Status;\r
+  UINT16      AuthSize;\r
+  TPM2B_AUTH  NewPlatformAuth;\r
 \r
   //\r
   // Send Tpm2HierarchyChange Auth with random value to avoid PlatformAuth being null\r
index 96638e26aa74197194fceb12dc060508cb9c6879..f7ecc9afd867a5e2d993ef46bd197b54e1b0bcc3 100644 (file)
@@ -25,19 +25,19 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 /// RSA 2048 SHA 256 Guided Section header\r
 ///\r
 typedef struct {\r
-  EFI_GUID_DEFINED_SECTION        GuidedSectionHeader;     ///< EFI guided section header\r
-  EFI_CERT_BLOCK_RSA_2048_SHA256  CertBlockRsa2048Sha256;  ///< RSA 2048-bit Signature\r
+  EFI_GUID_DEFINED_SECTION          GuidedSectionHeader;    ///< EFI guided section header\r
+  EFI_CERT_BLOCK_RSA_2048_SHA256    CertBlockRsa2048Sha256; ///< RSA 2048-bit Signature\r
 } RSA_2048_SHA_256_SECTION_HEADER;\r
 \r
 typedef struct {\r
-  EFI_GUID_DEFINED_SECTION2       GuidedSectionHeader;     ///< EFI guided section header\r
-  EFI_CERT_BLOCK_RSA_2048_SHA256  CertBlockRsa2048Sha256;  ///< RSA 2048-bit Signature\r
+  EFI_GUID_DEFINED_SECTION2         GuidedSectionHeader;    ///< EFI guided section header\r
+  EFI_CERT_BLOCK_RSA_2048_SHA256    CertBlockRsa2048Sha256; ///< RSA 2048-bit Signature\r
 } RSA_2048_SHA_256_SECTION2_HEADER;\r
 \r
 ///\r
 /// Public Exponent of RSA Key.\r
 ///\r
-CONST UINT8 mRsaE[] = { 0x01, 0x00, 0x01 };\r
+CONST UINT8  mRsaE[] = { 0x01, 0x00, 0x01 };\r
 \r
 /**\r
 \r
@@ -69,31 +69,37 @@ Rsa2048Sha256GuidedSectionGetInfo (
     // Check whether the input guid section is recognized.\r
     //\r
     if (!CompareGuid (\r
-        &gEfiCertTypeRsa2048Sha256Guid,\r
-        &(((EFI_GUID_DEFINED_SECTION2 *) InputSection)->SectionDefinitionGuid))) {\r
+           &gEfiCertTypeRsa2048Sha256Guid,\r
+           &(((EFI_GUID_DEFINED_SECTION2 *)InputSection)->SectionDefinitionGuid)\r
+           ))\r
+    {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
+\r
     //\r
     // Retrieve the size and attribute of the input section data.\r
     //\r
-    *SectionAttribute  = ((EFI_GUID_DEFINED_SECTION2 *) InputSection)->Attributes;\r
+    *SectionAttribute  = ((EFI_GUID_DEFINED_SECTION2 *)InputSection)->Attributes;\r
     *ScratchBufferSize = 0;\r
-    *OutputBufferSize  = SECTION2_SIZE (InputSection) - sizeof(RSA_2048_SHA_256_SECTION2_HEADER);\r
+    *OutputBufferSize  = SECTION2_SIZE (InputSection) - sizeof (RSA_2048_SHA_256_SECTION2_HEADER);\r
   } else {\r
     //\r
     // Check whether the input guid section is recognized.\r
     //\r
     if (!CompareGuid (\r
-        &gEfiCertTypeRsa2048Sha256Guid,\r
-        &(((EFI_GUID_DEFINED_SECTION *) InputSection)->SectionDefinitionGuid))) {\r
+           &gEfiCertTypeRsa2048Sha256Guid,\r
+           &(((EFI_GUID_DEFINED_SECTION *)InputSection)->SectionDefinitionGuid)\r
+           ))\r
+    {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
+\r
     //\r
     // Retrieve the size and attribute of the input section data.\r
     //\r
-    *SectionAttribute  = ((EFI_GUID_DEFINED_SECTION *) InputSection)->Attributes;\r
+    *SectionAttribute  = ((EFI_GUID_DEFINED_SECTION *)InputSection)->Attributes;\r
     *ScratchBufferSize = 0;\r
-    *OutputBufferSize  = SECTION_SIZE (InputSection) - sizeof(RSA_2048_SHA_256_SECTION_HEADER);\r
+    *OutputBufferSize  = SECTION_SIZE (InputSection) - sizeof (RSA_2048_SHA_256_SECTION_HEADER);\r
   }\r
 \r
   return EFI_SUCCESS;\r
@@ -143,15 +149,17 @@ Rsa2048Sha256GuidedSectionHandler (
     // Check whether the input guid section is recognized.\r
     //\r
     if (!CompareGuid (\r
-        &gEfiCertTypeRsa2048Sha256Guid,\r
-        &(((EFI_GUID_DEFINED_SECTION2 *)InputSection)->SectionDefinitionGuid))) {\r
+           &gEfiCertTypeRsa2048Sha256Guid,\r
+           &(((EFI_GUID_DEFINED_SECTION2 *)InputSection)->SectionDefinitionGuid)\r
+           ))\r
+    {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
 \r
     //\r
     // Get the RSA 2048 SHA 256 information.\r
     //\r
-    CertBlockRsa2048Sha256 = &((RSA_2048_SHA_256_SECTION2_HEADER *) InputSection)->CertBlockRsa2048Sha256;\r
+    CertBlockRsa2048Sha256 = &((RSA_2048_SHA_256_SECTION2_HEADER *)InputSection)->CertBlockRsa2048Sha256;\r
     OutputBufferSize       = SECTION2_SIZE (InputSection) - sizeof (RSA_2048_SHA_256_SECTION2_HEADER);\r
     if ((((EFI_GUID_DEFINED_SECTION *)InputSection)->Attributes & EFI_GUIDED_SECTION_PROCESSING_REQUIRED) != 0) {\r
       PERF_INMODULE_BEGIN ("PeiRsaCopy");\r
@@ -171,8 +179,10 @@ Rsa2048Sha256GuidedSectionHandler (
     // Check whether the input guid section is recognized.\r
     //\r
     if (!CompareGuid (\r
-        &gEfiCertTypeRsa2048Sha256Guid,\r
-        &(((EFI_GUID_DEFINED_SECTION *)InputSection)->SectionDefinitionGuid))) {\r
+           &gEfiCertTypeRsa2048Sha256Guid,\r
+           &(((EFI_GUID_DEFINED_SECTION *)InputSection)->SectionDefinitionGuid)\r
+           ))\r
+    {\r
       return EFI_INVALID_PARAMETER;\r
     }\r
 \r
@@ -192,7 +202,7 @@ Rsa2048Sha256GuidedSectionHandler (
     //\r
     // Implicitly RSA 2048 SHA 256 GUIDed section should have STATUS_VALID bit set\r
     //\r
-    ASSERT ((((EFI_GUID_DEFINED_SECTION *) InputSection)->Attributes & EFI_GUIDED_SECTION_AUTH_STATUS_VALID) != 0);\r
+    ASSERT ((((EFI_GUID_DEFINED_SECTION *)InputSection)->Attributes & EFI_GUIDED_SECTION_AUTH_STATUS_VALID) != 0);\r
     *AuthenticationStatus = EFI_AUTH_STATUS_IMAGE_SIGNED;\r
   }\r
 \r
@@ -230,13 +240,15 @@ Rsa2048Sha256GuidedSectionHandler (
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
-  CryptoStatus = Sha256Update (HashContext, &CertBlockRsa2048Sha256->PublicKey, sizeof(CertBlockRsa2048Sha256->PublicKey));\r
+\r
+  CryptoStatus = Sha256Update (HashContext, &CertBlockRsa2048Sha256->PublicKey, sizeof (CertBlockRsa2048Sha256->PublicKey));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "PeiRsa2048Sha256: Sha256Update() failed\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
-  CryptoStatus  = Sha256Final (HashContext, Digest);\r
+\r
+  CryptoStatus = Sha256Final (HashContext, Digest);\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "PeiRsa2048Sha256: Sha256Final() failed\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
@@ -259,9 +271,11 @@ Rsa2048Sha256GuidedSectionHandler (
       CryptoStatus = TRUE;\r
       break;\r
     }\r
-    PublicKey = PublicKey + SHA256_DIGEST_SIZE;\r
+\r
+    PublicKey           = PublicKey + SHA256_DIGEST_SIZE;\r
     PublicKeyBufferSize = PublicKeyBufferSize - SHA256_DIGEST_SIZE;\r
   }\r
+\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "PeiRsa2048Sha256: Public key in section is not supported\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
@@ -282,12 +296,13 @@ Rsa2048Sha256GuidedSectionHandler (
   // Set RSA Key Components.\r
   // NOTE: Only N and E are needed to be set as RSA public key for signature verification.\r
   //\r
-  CryptoStatus = RsaSetKey (Rsa, RsaKeyN, CertBlockRsa2048Sha256->PublicKey, sizeof(CertBlockRsa2048Sha256->PublicKey));\r
+  CryptoStatus = RsaSetKey (Rsa, RsaKeyN, CertBlockRsa2048Sha256->PublicKey, sizeof (CertBlockRsa2048Sha256->PublicKey));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "PeiRsa2048Sha256: RsaSetKey(RsaKeyN) failed\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
+\r
   CryptoStatus = RsaSetKey (Rsa, RsaKeyE, mRsaE, sizeof (mRsaE));\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "PeiRsa2048Sha256: RsaSetKey(RsaKeyE) failed\n"));\r
@@ -305,6 +320,7 @@ Rsa2048Sha256GuidedSectionHandler (
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
+\r
   PERF_INMODULE_BEGIN ("PeiRsaShaData");\r
   CryptoStatus = Sha256Update (HashContext, *OutputBuffer, OutputBufferSize);\r
   PERF_INMODULE_END ("PeiRsaShaData");\r
@@ -313,7 +329,8 @@ Rsa2048Sha256GuidedSectionHandler (
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
     goto Done;\r
   }\r
-  CryptoStatus  = Sha256Final (HashContext, Digest);\r
+\r
+  CryptoStatus = Sha256Final (HashContext, Digest);\r
   if (!CryptoStatus) {\r
     DEBUG ((DEBUG_ERROR, "PeiRsa2048Sha256: Sha256Final() failed\n"));\r
     *AuthenticationStatus |= EFI_AUTH_STATUS_TEST_FAILED;\r
@@ -347,6 +364,7 @@ Done:
   if (Rsa != NULL) {\r
     RsaFree (Rsa);\r
   }\r
+\r
   if (HashContext != NULL) {\r
     FreePool (HashContext);\r
   }\r
@@ -369,8 +387,8 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 PeiRsa2048Sha256GuidedSectionExtractLibConstructor (\r
-  IN EFI_PEI_FILE_HANDLE        FileHandle,\r
-  IN CONST EFI_PEI_SERVICES     **PeiServices\r
+  IN EFI_PEI_FILE_HANDLE     FileHandle,\r
+  IN CONST EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
   return ExtractGuidedSectionRegisterHandlers (\r
index b80129bf7ff41c93b650a5d2290179cf25386de3..7977382f75132cb7c5cf291ba93099c5e4c2e9b0 100644 (file)
@@ -34,20 +34,21 @@ Tcg2PhysicalPresenceLibGetManagementFlags (
   EFI_TCG2_PHYSICAL_PRESENCE_FLAGS  PpiFlags;\r
   UINTN                             DataSize;\r
 \r
-  Status = PeiServicesLocatePpi (&gEfiPeiReadOnlyVariable2PpiGuid, 0, NULL, (VOID **) &VariablePpi);\r
+  Status = PeiServicesLocatePpi (&gEfiPeiReadOnlyVariable2PpiGuid, 0, NULL, (VOID **)&VariablePpi);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS);\r
-  Status = VariablePpi->GetVariable (\r
-                          VariablePpi,\r
-                          TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                          &gEfiTcg2PhysicalPresenceGuid,\r
-                          NULL,\r
-                          &DataSize,\r
-                          &PpiFlags\r
-                          );\r
+  Status   = VariablePpi->GetVariable (\r
+                            VariablePpi,\r
+                            TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                            &gEfiTcg2PhysicalPresenceGuid,\r
+                            NULL,\r
+                            &DataSize,\r
+                            &PpiFlags\r
+                            );\r
   if (EFI_ERROR (Status)) {\r
-    PpiFlags.PPFlags = PcdGet32(PcdTcg2PhysicalPresenceFlags);\r
+    PpiFlags.PPFlags = PcdGet32 (PcdTcg2PhysicalPresenceFlags);\r
   }\r
+\r
   return PpiFlags.PPFlags;\r
 }\r
index 200e15a2947edbdeeec124fc63fa21dd95aad7bc..0e84fd661ab6147e372a0c31572d7fdabb155342 100644 (file)
@@ -36,25 +36,25 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 TpmMeasureAndLogData (\r
-  IN UINT32             PcrIndex,\r
-  IN UINT32             EventType,\r
-  IN VOID               *EventLog,\r
-  IN UINT32             LogLen,\r
-  IN VOID               *HashData,\r
-  IN UINT64             HashDataLen\r
+  IN UINT32  PcrIndex,\r
+  IN UINT32  EventType,\r
+  IN VOID    *EventLog,\r
+  IN UINT32  LogLen,\r
+  IN VOID    *HashData,\r
+  IN UINT64  HashDataLen\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  EDKII_TCG_PPI             *TcgPpi;\r
-  TCG_PCR_EVENT_HDR         TcgEventHdr;\r
+  EFI_STATUS         Status;\r
+  EDKII_TCG_PPI      *TcgPpi;\r
+  TCG_PCR_EVENT_HDR  TcgEventHdr;\r
 \r
   Status = PeiServicesLocatePpi (\r
              &gEdkiiTcgPpiGuid,\r
              0,\r
              NULL,\r
-             (VOID**)&TcgPpi\r
+             (VOID **)&TcgPpi\r
              );\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
index c5a9d676c44a1676872bcc4f9c7a08e409235ba2..b350b04ebd90c010cb5f3e183c6422b0308e0313 100644 (file)
@@ -11,7 +11,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include <Uefi/UefiBaseType.h>\r
 \r
-BOOLEAN       mUserPhysicalPresence      = FALSE;\r
+BOOLEAN  mUserPhysicalPresence = FALSE;\r
 \r
 /**\r
 \r
@@ -39,7 +39,6 @@ UserPhysicalPresent (
   return mUserPhysicalPresence;\r
 }\r
 \r
-\r
 /**\r
   Save user physical presence state from a PCD to mUserPhysicalPresence.\r
 \r
@@ -52,8 +51,7 @@ PlatformSecureLibNullConstructor (
   VOID\r
   )\r
 {\r
-\r
-  mUserPhysicalPresence = PcdGetBool(PcdUserPhysicalPresence);\r
+  mUserPhysicalPresence = PcdGetBool (PcdUserPhysicalPresence);\r
 \r
   return RETURN_SUCCESS;\r
 }\r
index e1dd09eb10a0075682babd78b86e13bd873cd363..792e48250e5dc8e63d6323adef6aa644cb1dd3e2 100644 (file)
@@ -44,4 +44,3 @@ IncrementMonotonicCounter (
   ASSERT (FALSE);\r
   return EFI_UNSUPPORTED;\r
 }\r
-\r
index ff65184713fd839c0d95f713073ef1ba442fca56..e0d137666e0e157e34f859bbe40666f7cc2e2c66 100644 (file)
 STATIC\r
 EFI_STATUS\r
 CreateSigList (\r
-  IN VOID                *Data,\r
-  IN UINTN               Size,\r
-  OUT EFI_SIGNATURE_LIST **SigList\r
+  IN VOID                 *Data,\r
+  IN UINTN                Size,\r
+  OUT EFI_SIGNATURE_LIST  **SigList\r
   )\r
 {\r
-  UINTN                  SigListSize;\r
-  EFI_SIGNATURE_LIST     *TmpSigList;\r
-  EFI_SIGNATURE_DATA     *SigData;\r
+  UINTN               SigListSize;\r
+  EFI_SIGNATURE_LIST  *TmpSigList;\r
+  EFI_SIGNATURE_DATA  *SigData;\r
 \r
   //\r
   // Allocate data for Signature Database\r
   //\r
   SigListSize = sizeof (EFI_SIGNATURE_LIST) + sizeof (EFI_SIGNATURE_DATA) - 1 + Size;\r
-  TmpSigList = (EFI_SIGNATURE_LIST *) AllocateZeroPool (SigListSize);\r
+  TmpSigList  = (EFI_SIGNATURE_LIST *)AllocateZeroPool (SigListSize);\r
   if (TmpSigList == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
@@ -54,15 +54,15 @@ CreateSigList (
   //\r
   // Only gEfiCertX509Guid type is supported\r
   //\r
-  TmpSigList->SignatureListSize = (UINT32)SigListSize;\r
-  TmpSigList->SignatureSize = (UINT32) (sizeof (EFI_SIGNATURE_DATA) - 1 + Size);\r
+  TmpSigList->SignatureListSize   = (UINT32)SigListSize;\r
+  TmpSigList->SignatureSize       = (UINT32)(sizeof (EFI_SIGNATURE_DATA) - 1 + Size);\r
   TmpSigList->SignatureHeaderSize = 0;\r
   CopyGuid (&TmpSigList->SignatureType, &gEfiCertX509Guid);\r
 \r
   //\r
   // Copy key data\r
   //\r
-  SigData = (EFI_SIGNATURE_DATA *) (TmpSigList + 1);\r
+  SigData = (EFI_SIGNATURE_DATA *)(TmpSigList + 1);\r
   CopyGuid (&SigData->SignatureOwner, &gEfiGlobalVariableGuid);\r
   CopyMem (&SigData->SignatureData[0], Data, Size);\r
 \r
@@ -84,31 +84,31 @@ CreateSigList (
 STATIC\r
 EFI_STATUS\r
 ConcatenateSigList (\r
-  IN  EFI_SIGNATURE_LIST *SigLists,\r
-  IN  EFI_SIGNATURE_LIST *SigListAppend,\r
-  OUT EFI_SIGNATURE_LIST **SigListOut,\r
-  IN OUT UINTN           *SigListsSize\r
-)\r
+  IN  EFI_SIGNATURE_LIST  *SigLists,\r
+  IN  EFI_SIGNATURE_LIST  *SigListAppend,\r
+  OUT EFI_SIGNATURE_LIST  **SigListOut,\r
+  IN OUT UINTN            *SigListsSize\r
+  )\r
 {\r
-  EFI_SIGNATURE_LIST *TmpSigList;\r
-  UINT8              *Offset;\r
-  UINTN              NewSigListsSize;\r
+  EFI_SIGNATURE_LIST  *TmpSigList;\r
+  UINT8               *Offset;\r
+  UINTN               NewSigListsSize;\r
 \r
   NewSigListsSize = *SigListsSize + SigListAppend->SignatureListSize;\r
 \r
-  TmpSigList = (EFI_SIGNATURE_LIST *) AllocateZeroPool (NewSigListsSize);\r
+  TmpSigList = (EFI_SIGNATURE_LIST *)AllocateZeroPool (NewSigListsSize);\r
   if (TmpSigList == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
   CopyMem (TmpSigList, SigLists, *SigListsSize);\r
 \r
-  Offset = (UINT8 *)TmpSigList;\r
+  Offset  = (UINT8 *)TmpSigList;\r
   Offset += *SigListsSize;\r
   CopyMem ((VOID *)Offset, SigListAppend, SigListAppend->SignatureListSize);\r
 \r
   *SigListsSize = NewSigListsSize;\r
-  *SigListOut = TmpSigList;\r
+  *SigListOut   = TmpSigList;\r
   return EFI_SUCCESS;\r
 }\r
 \r
@@ -128,23 +128,22 @@ ConcatenateSigList (
 **/\r
 EFI_STATUS\r
 SecureBootFetchData (\r
-    IN  EFI_GUID           *KeyFileGuid,\r
-    OUT UINTN              *SigListsSize,\r
-    OUT EFI_SIGNATURE_LIST **SigListOut\r
-)\r
+  IN  EFI_GUID            *KeyFileGuid,\r
+  OUT UINTN               *SigListsSize,\r
+  OUT EFI_SIGNATURE_LIST  **SigListOut\r
+  )\r
 {\r
-  EFI_SIGNATURE_LIST *EfiSig;\r
-  EFI_SIGNATURE_LIST *TmpEfiSig;\r
-  EFI_SIGNATURE_LIST *TmpEfiSig2;\r
-  EFI_STATUS         Status;\r
-  VOID               *Buffer;\r
-  VOID               *RsaPubKey;\r
+  EFI_SIGNATURE_LIST  *EfiSig;\r
+  EFI_SIGNATURE_LIST  *TmpEfiSig;\r
+  EFI_SIGNATURE_LIST  *TmpEfiSig2;\r
+  EFI_STATUS          Status;\r
+  VOID                *Buffer;\r
+  VOID                *RsaPubKey;\r
   UINTN               Size;\r
   UINTN               KeyIndex;\r
 \r
-\r
-  KeyIndex = 0;\r
-  EfiSig = NULL;\r
+  KeyIndex      = 0;\r
+  EfiSig        = NULL;\r
   *SigListsSize = 0;\r
   while (1) {\r
     Status = GetSectionFromAnyFv (\r
@@ -160,9 +159,10 @@ SecureBootFetchData (
       if (RsaGetPublicKeyFromX509 (Buffer, Size, &RsaPubKey) == FALSE) {\r
         DEBUG ((DEBUG_ERROR, "%a: Invalid key format: %d\n", __FUNCTION__, KeyIndex));\r
         if (EfiSig != NULL) {\r
-          FreePool(EfiSig);\r
+          FreePool (EfiSig);\r
         }\r
-        FreePool(Buffer);\r
+\r
+        FreePool (Buffer);\r
         return EFI_INVALID_PARAMETER;\r
       }\r
 \r
@@ -172,7 +172,7 @@ SecureBootFetchData (
       // Concatenate lists if more than one section found\r
       //\r
       if (KeyIndex == 0) {\r
-        EfiSig = TmpEfiSig;\r
+        EfiSig        = TmpEfiSig;\r
         *SigListsSize = TmpEfiSig->SignatureListSize;\r
       } else {\r
         ConcatenateSigList (EfiSig, TmpEfiSig, &TmpEfiSig2, SigListsSize);\r
@@ -183,10 +183,12 @@ SecureBootFetchData (
 \r
       KeyIndex++;\r
       FreePool (Buffer);\r
-    } if (Status == EFI_NOT_FOUND) {\r
+    }\r
+\r
+    if (Status == EFI_NOT_FOUND) {\r
       break;\r
     }\r
-  };\r
+  }\r
 \r
   if (KeyIndex == 0) {\r
     return EFI_NOT_FOUND;\r
@@ -217,19 +219,19 @@ SecureBootFetchData (
 **/\r
 EFI_STATUS\r
 CreateTimeBasedPayload (\r
-  IN OUT UINTN            *DataSize,\r
-  IN OUT UINT8            **Data\r
+  IN OUT UINTN  *DataSize,\r
+  IN OUT UINT8  **Data\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
-  UINT8                            *NewData;\r
-  UINT8                            *Payload;\r
-  UINTN                            PayloadSize;\r
-  EFI_VARIABLE_AUTHENTICATION_2    *DescriptorData;\r
-  UINTN                            DescriptorSize;\r
-  EFI_TIME                         Time;\r
-\r
-  if (Data == NULL || DataSize == NULL) {\r
+  EFI_STATUS                     Status;\r
+  UINT8                          *NewData;\r
+  UINT8                          *Payload;\r
+  UINTN                          PayloadSize;\r
+  EFI_VARIABLE_AUTHENTICATION_2  *DescriptorData;\r
+  UINTN                          DescriptorSize;\r
+  EFI_TIME                       Time;\r
+\r
+  if ((Data == NULL) || (DataSize == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -242,8 +244,8 @@ CreateTimeBasedPayload (
   Payload     = *Data;\r
   PayloadSize = *DataSize;\r
 \r
-  DescriptorSize    = OFFSET_OF (EFI_VARIABLE_AUTHENTICATION_2, AuthInfo) + OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData);\r
-  NewData = (UINT8*) AllocateZeroPool (DescriptorSize + PayloadSize);\r
+  DescriptorSize = OFFSET_OF (EFI_VARIABLE_AUTHENTICATION_2, AuthInfo) + OFFSET_OF (WIN_CERTIFICATE_UEFI_GUID, CertData);\r
+  NewData        = (UINT8 *)AllocateZeroPool (DescriptorSize + PayloadSize);\r
   if (NewData == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
@@ -252,14 +254,15 @@ CreateTimeBasedPayload (
     CopyMem (NewData + DescriptorSize, Payload, PayloadSize);\r
   }\r
 \r
-  DescriptorData = (EFI_VARIABLE_AUTHENTICATION_2 *) (NewData);\r
+  DescriptorData = (EFI_VARIABLE_AUTHENTICATION_2 *)(NewData);\r
 \r
   ZeroMem (&Time, sizeof (EFI_TIME));\r
   Status = gRT->GetTime (&Time, NULL);\r
   if (EFI_ERROR (Status)) {\r
-    FreePool(NewData);\r
+    FreePool (NewData);\r
     return Status;\r
   }\r
+\r
   Time.Pad1       = 0;\r
   Time.Nanosecond = 0;\r
   Time.TimeZone   = 0;\r
@@ -273,7 +276,7 @@ CreateTimeBasedPayload (
   CopyGuid (&DescriptorData->AuthInfo.CertType, &gEfiCertPkcs7Guid);\r
 \r
   if (Payload != NULL) {\r
-    FreePool(Payload);\r
+    FreePool (Payload);\r
   }\r
 \r
   *DataSize = DescriptorSize + PayloadSize;\r
@@ -294,20 +297,21 @@ CreateTimeBasedPayload (
 **/\r
 EFI_STATUS\r
 DeleteVariable (\r
-  IN  CHAR16                    *VariableName,\r
-  IN  EFI_GUID                  *VendorGuid\r
+  IN  CHAR16    *VariableName,\r
+  IN  EFI_GUID  *VendorGuid\r
   )\r
 {\r
-  EFI_STATUS              Status;\r
-  VOID*                   Variable;\r
-  UINT8                   *Data;\r
-  UINTN                   DataSize;\r
-  UINT32                  Attr;\r
+  EFI_STATUS  Status;\r
+  VOID        *Variable;\r
+  UINT8       *Data;\r
+  UINTN       DataSize;\r
+  UINT32      Attr;\r
 \r
   GetVariable2 (VariableName, VendorGuid, &Variable, NULL);\r
   if (Variable == NULL) {\r
     return EFI_SUCCESS;\r
   }\r
+\r
   FreePool (Variable);\r
 \r
   Data     = NULL;\r
@@ -331,6 +335,7 @@ DeleteVariable (
   if (Data != NULL) {\r
     FreePool (Data);\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -369,13 +374,13 @@ SetSecureBootMode (
 EFI_STATUS\r
 EFIAPI\r
 GetSetupMode (\r
-    OUT UINT8 *SetupMode\r
-)\r
+  OUT UINT8  *SetupMode\r
+  )\r
 {\r
-  UINTN      Size;\r
-  EFI_STATUS Status;\r
+  UINTN       Size;\r
+  EFI_STATUS  Status;\r
 \r
-  Size = sizeof (*SetupMode);\r
+  Size   = sizeof (*SetupMode);\r
   Status = gRT->GetVariable (\r
                   EFI_SETUP_MODE_NAME,\r
                   &gEfiGlobalVariableGuid,\r
@@ -401,9 +406,9 @@ EFI_STATUS
 EFIAPI\r
 DeleteDb (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = DeleteVariable (\r
              EFI_IMAGE_SECURITY_DATABASE,\r
@@ -424,9 +429,9 @@ EFI_STATUS
 EFIAPI\r
 DeleteDbx (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = DeleteVariable (\r
              EFI_IMAGE_SECURITY_DATABASE1,\r
@@ -447,9 +452,9 @@ EFI_STATUS
 EFIAPI\r
 DeleteDbt (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = DeleteVariable (\r
              EFI_IMAGE_SECURITY_DATABASE2,\r
@@ -470,9 +475,9 @@ EFI_STATUS
 EFIAPI\r
 DeleteKEK (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = DeleteVariable (\r
              EFI_KEY_EXCHANGE_KEY_NAME,\r
@@ -493,11 +498,11 @@ EFI_STATUS
 EFIAPI\r
 DeletePlatformKey (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
-  Status = SetSecureBootMode(CUSTOM_SECURE_BOOT_MODE);\r
+  Status = SetSecureBootMode (CUSTOM_SECURE_BOOT_MODE);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
index 848f7ce929bfe0e9b4a8bbc3db9900033040b9ab..536b0f3699071bff49663d76f7a3ecb6d9cfa1d1 100644 (file)
 STATIC\r
 EFI_STATUS\r
 EnrollFromDefault (\r
-  IN CHAR16   *VariableName,\r
-  IN CHAR16   *DefaultName,\r
-  IN EFI_GUID *VendorGuid\r
+  IN CHAR16    *VariableName,\r
+  IN CHAR16    *DefaultName,\r
+  IN EFI_GUID  *VendorGuid\r
   )\r
 {\r
-  VOID       *Data;\r
+  VOID        *Data;\r
   UINTN       DataSize;\r
   EFI_STATUS  Status;\r
 \r
   Status = EFI_SUCCESS;\r
 \r
   DataSize = 0;\r
-  Status = GetVariable2 (DefaultName, &gEfiGlobalVariableGuid, &Data, &DataSize);\r
+  Status   = GetVariable2 (DefaultName, &gEfiGlobalVariableGuid, &Data, &DataSize);\r
   if (EFI_ERROR (Status)) {\r
-      DEBUG ((DEBUG_ERROR, "error: GetVariable (\"%s): %r\n", DefaultName, Status));\r
-      return Status;\r
+    DEBUG ((DEBUG_ERROR, "error: GetVariable (\"%s): %r\n", DefaultName, Status));\r
+    return Status;\r
   }\r
 \r
   CreateTimeBasedPayload (&DataSize, (UINT8 **)&Data);\r
@@ -73,8 +73,14 @@ EnrollFromDefault (
                   );\r
 \r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "error: %a (\"%s\", %g): %r\n", __FUNCTION__, VariableName,\r
-      VendorGuid, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "error: %a (\"%s\", %g): %r\n",\r
+      __FUNCTION__,\r
+      VariableName,\r
+      VendorGuid,\r
+      Status\r
+      ));\r
   }\r
 \r
   if (Data != NULL) {\r
@@ -94,7 +100,7 @@ SecureBootInitPKDefault (
   IN VOID\r
   )\r
 {\r
-  EFI_SIGNATURE_LIST *EfiSig;\r
+  EFI_SIGNATURE_LIST  *EfiSig;\r
   UINTN               SigListsSize;\r
   EFI_STATUS          Status;\r
   UINT8               *Data;\r
@@ -103,7 +109,7 @@ SecureBootInitPKDefault (
   //\r
   // Check if variable exists, if so do not change it\r
   //\r
-  Status = GetVariable2 (EFI_PK_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **) &Data, &DataSize);\r
+  Status = GetVariable2 (EFI_PK_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **)&Data, &DataSize);\r
   if (Status == EFI_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Variable %s exists. Old value is preserved\n", EFI_PK_DEFAULT_VARIABLE_NAME));\r
     FreePool (Data);\r
@@ -151,16 +157,16 @@ SecureBootInitKEKDefault (
   IN VOID\r
   )\r
 {\r
-  EFI_SIGNATURE_LIST *EfiSig;\r
+  EFI_SIGNATURE_LIST  *EfiSig;\r
   UINTN               SigListsSize;\r
   EFI_STATUS          Status;\r
-  UINT8              *Data;\r
+  UINT8               *Data;\r
   UINTN               DataSize;\r
 \r
   //\r
   // Check if variable exists, if so do not change it\r
   //\r
-  Status = GetVariable2 (EFI_KEK_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **) &Data, &DataSize);\r
+  Status = GetVariable2 (EFI_KEK_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **)&Data, &DataSize);\r
   if (Status == EFI_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Variable %s exists. Old value is preserved\n", EFI_KEK_DEFAULT_VARIABLE_NAME));\r
     FreePool (Data);\r
@@ -182,7 +188,6 @@ SecureBootInitKEKDefault (
     return Status;\r
   }\r
 \r
-\r
   Status = gRT->SetVariable (\r
                   EFI_KEK_DEFAULT_VARIABLE_NAME,\r
                   &gEfiGlobalVariableGuid,\r
@@ -209,13 +214,13 @@ SecureBootInitDbDefault (
   IN VOID\r
   )\r
 {\r
-  EFI_SIGNATURE_LIST *EfiSig;\r
+  EFI_SIGNATURE_LIST  *EfiSig;\r
   UINTN               SigListsSize;\r
   EFI_STATUS          Status;\r
-  UINT8              *Data;\r
+  UINT8               *Data;\r
   UINTN               DataSize;\r
 \r
-  Status = GetVariable2 (EFI_DB_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **) &Data, &DataSize);\r
+  Status = GetVariable2 (EFI_DB_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **)&Data, &DataSize);\r
   if (Status == EFI_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Variable %s exists. Old value is preserved\n", EFI_DB_DEFAULT_VARIABLE_NAME));\r
     FreePool (Data);\r
@@ -230,7 +235,7 @@ SecureBootInitDbDefault (
 \r
   Status = SecureBootFetchData (&gDefaultdbFileGuid, &SigListsSize, &EfiSig);\r
   if (EFI_ERROR (Status)) {\r
-      return Status;\r
+    return Status;\r
   }\r
 \r
   Status = gRT->SetVariable (\r
@@ -241,7 +246,7 @@ SecureBootInitDbDefault (
                   (VOID *)EfiSig\r
                   );\r
   if (EFI_ERROR (Status)) {\r
-      DEBUG ((DEBUG_INFO, "Failed to set %s\n", EFI_DB_DEFAULT_VARIABLE_NAME));\r
+    DEBUG ((DEBUG_INFO, "Failed to set %s\n", EFI_DB_DEFAULT_VARIABLE_NAME));\r
   }\r
 \r
   FreePool (EfiSig);\r
@@ -259,16 +264,16 @@ SecureBootInitDbxDefault (
   IN VOID\r
   )\r
 {\r
-  EFI_SIGNATURE_LIST *EfiSig;\r
+  EFI_SIGNATURE_LIST  *EfiSig;\r
   UINTN               SigListsSize;\r
   EFI_STATUS          Status;\r
-  UINT8              *Data;\r
+  UINT8               *Data;\r
   UINTN               DataSize;\r
 \r
   //\r
   // Check if variable exists, if so do not change it\r
   //\r
-  Status = GetVariable2 (EFI_DBX_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **) &Data, &DataSize);\r
+  Status = GetVariable2 (EFI_DBX_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **)&Data, &DataSize);\r
   if (Status == EFI_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Variable %s exists. Old value is preserved\n", EFI_DBX_DEFAULT_VARIABLE_NAME));\r
     FreePool (Data);\r
@@ -316,16 +321,16 @@ SecureBootInitDbtDefault (
   IN VOID\r
   )\r
 {\r
-  EFI_SIGNATURE_LIST *EfiSig;\r
+  EFI_SIGNATURE_LIST  *EfiSig;\r
   UINTN               SigListsSize;\r
   EFI_STATUS          Status;\r
-  UINT8              *Data;\r
+  UINT8               *Data;\r
   UINTN               DataSize;\r
 \r
   //\r
   // Check if variable exists, if so do not change it\r
   //\r
-  Status = GetVariable2 (EFI_DBT_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **) &Data, &DataSize);\r
+  Status = GetVariable2 (EFI_DBT_DEFAULT_VARIABLE_NAME, &gEfiGlobalVariableGuid, (VOID **)&Data, &DataSize);\r
   if (Status == EFI_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Variable %s exists. Old value is preserved\n", EFI_DBT_DEFAULT_VARIABLE_NAME));\r
     FreePool (Data);\r
@@ -343,7 +348,7 @@ SecureBootInitDbtDefault (
 \r
   Status = SecureBootFetchData (&gDefaultdbtFileGuid, &SigListsSize, &EfiSig);\r
   if (EFI_ERROR (Status)) {\r
-      return Status;\r
+    return Status;\r
   }\r
 \r
   Status = gRT->SetVariable (\r
@@ -373,9 +378,9 @@ EFI_STATUS
 EFIAPI\r
 EnrollDbFromDefault (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = EnrollFromDefault (\r
              EFI_IMAGE_SECURITY_DATABASE,\r
@@ -397,9 +402,9 @@ EFI_STATUS
 EFIAPI\r
 EnrollDbxFromDefault (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = EnrollFromDefault (\r
              EFI_IMAGE_SECURITY_DATABASE1,\r
@@ -421,14 +426,15 @@ EFI_STATUS
 EFIAPI\r
 EnrollDbtFromDefault (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = EnrollFromDefault (\r
              EFI_IMAGE_SECURITY_DATABASE2,\r
              EFI_DBT_DEFAULT_VARIABLE_NAME,\r
-             &gEfiImageSecurityDatabaseGuid);\r
+             &gEfiImageSecurityDatabaseGuid\r
+             );\r
 \r
   return Status;\r
 }\r
@@ -444,9 +450,9 @@ EFI_STATUS
 EFIAPI\r
 EnrollKEKFromDefault (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = EnrollFromDefault (\r
              EFI_KEY_EXCHANGE_KEY_NAME,\r
@@ -468,9 +474,9 @@ EFI_STATUS
 EFIAPI\r
 EnrollPKFromDefault (\r
   VOID\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = EnrollFromDefault (\r
              EFI_PLATFORM_KEY_NAME,\r
index 3788537db3180d35835d944c31ae9f47de462334..1fbfc00547cdef32f49024a044839d83e57f6c62 100644 (file)
@@ -27,7 +27,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/Tcg2PpVendorLib.h>\r
 #include <Library/MmServicesTableLib.h>\r
 \r
-#define     PP_INF_VERSION_1_2    "1.2"\r
+#define     PP_INF_VERSION_1_2  "1.2"\r
 \r
 EFI_SMM_VARIABLE_PROTOCOL  *mTcg2PpSmmVariable;\r
 BOOLEAN                    mIsTcg2PPVerLowerThan_1_3 = FALSE;\r
@@ -47,13 +47,13 @@ UINT32                     mTcg2PhysicalPresenceFlags;
 UINT32\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (\r
-  OUT UINT32                *MostRecentRequest,\r
-  OUT UINT32                *Response\r
+  OUT UINT32  *MostRecentRequest,\r
+  OUT UINT32  *Response\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINTN                             DataSize;\r
-  EFI_TCG2_PHYSICAL_PRESENCE        PpData;\r
+  EFI_STATUS                  Status;\r
+  UINTN                       DataSize;\r
+  EFI_TCG2_PHYSICAL_PRESENCE  PpData;\r
 \r
   DEBUG ((DEBUG_INFO, "[TPM2] ReturnOperationResponseToOsFunction\n"));\r
 \r
@@ -61,13 +61,13 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
   // Get the Physical Presence variable\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-  Status = mTcg2PpSmmVariable->SmmGetVariable (\r
-                                 TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                                 &gEfiTcg2PhysicalPresenceGuid,\r
-                                 NULL,\r
-                                 &DataSize,\r
-                                 &PpData\r
-                                 );\r
+  Status   = mTcg2PpSmmVariable->SmmGetVariable (\r
+                                   TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                                   &gEfiTcg2PhysicalPresenceGuid,\r
+                                   NULL,\r
+                                   &DataSize,\r
+                                   &PpData\r
+                                   );\r
   if (EFI_ERROR (Status)) {\r
     *MostRecentRequest = 0;\r
     *Response          = 0;\r
@@ -98,8 +98,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
   **/\r
 UINT32\r
 Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx (\r
-  IN OUT UINT32               *OperationRequest,\r
-  IN OUT UINT32               *RequestParameter\r
+  IN OUT UINT32  *OperationRequest,\r
+  IN OUT UINT32  *RequestParameter\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -115,13 +115,13 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx (
   // Get the Physical Presence variable\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-  Status = mTcg2PpSmmVariable->SmmGetVariable (\r
-                                 TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                                 &gEfiTcg2PhysicalPresenceGuid,\r
-                                 NULL,\r
-                                 &DataSize,\r
-                                 &PpData\r
-                                 );\r
+  Status   = mTcg2PpSmmVariable->SmmGetVariable (\r
+                                   TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                                   &gEfiTcg2PhysicalPresenceGuid,\r
+                                   NULL,\r
+                                   &DataSize,\r
+                                   &PpData\r
+                                   );\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "[TPM2] Get PP variable failure! Status = %r\n", Status));\r
     ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE;\r
@@ -129,23 +129,25 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx (
   }\r
 \r
   if ((*OperationRequest > TCG2_PHYSICAL_PRESENCE_NO_ACTION_MAX) &&\r
-      (*OperationRequest < TCG2_PHYSICAL_PRESENCE_STORAGE_MANAGEMENT_BEGIN) ) {\r
+      (*OperationRequest < TCG2_PHYSICAL_PRESENCE_STORAGE_MANAGEMENT_BEGIN))\r
+  {\r
     ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED;\r
     goto EXIT;\r
   }\r
 \r
   if ((PpData.PPRequest != *OperationRequest) ||\r
-      (PpData.PPRequestParameter != *RequestParameter)) {\r
-    PpData.PPRequest = (UINT8)*OperationRequest;\r
+      (PpData.PPRequestParameter != *RequestParameter))\r
+  {\r
+    PpData.PPRequest          = (UINT8)*OperationRequest;\r
     PpData.PPRequestParameter = *RequestParameter;\r
-    DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-    Status = mTcg2PpSmmVariable->SmmSetVariable (\r
-                                   TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                                   &gEfiTcg2PhysicalPresenceGuid,\r
-                                   EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                                   DataSize,\r
-                                   &PpData\r
-                                   );\r
+    DataSize                  = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
+    Status                    = mTcg2PpSmmVariable->SmmSetVariable (\r
+                                                      TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                                                      &gEfiTcg2PhysicalPresenceGuid,\r
+                                                      EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                                                      DataSize,\r
+                                                      &PpData\r
+                                                      );\r
     if (EFI_ERROR (Status)) {\r
       DEBUG ((DEBUG_ERROR, "[TPM2] Set PP variable failure! Status = %r\n", Status));\r
       ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE;\r
@@ -155,16 +157,17 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx (
 \r
   if (*OperationRequest >= TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
     DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS);\r
-    Status = mTcg2PpSmmVariable->SmmGetVariable (\r
-                                   TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                                   &gEfiTcg2PhysicalPresenceGuid,\r
-                                   NULL,\r
-                                   &DataSize,\r
-                                   &Flags\r
-                                   );\r
+    Status   = mTcg2PpSmmVariable->SmmGetVariable (\r
+                                     TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                                     &gEfiTcg2PhysicalPresenceGuid,\r
+                                     NULL,\r
+                                     &DataSize,\r
+                                     &Flags\r
+                                     );\r
     if (EFI_ERROR (Status)) {\r
       Flags.PPFlags = mTcg2PhysicalPresenceFlags;\r
     }\r
+\r
     ReturnCode = Tcg2PpVendorLibSubmitRequestToPreOSFunction (*OperationRequest, Flags.PPFlags, *RequestParameter);\r
   }\r
 \r
@@ -175,7 +178,7 @@ EXIT:
   if (ReturnCode != TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) {\r
     DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync PPRQ/PPRM with PP variable.\n", Status));\r
     DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-    ZeroMem(&PpData, DataSize);\r
+    ZeroMem (&PpData, DataSize);\r
     Status = mTcg2PpSmmVariable->SmmGetVariable (\r
                                    TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
                                    &gEfiTcg2PhysicalPresenceGuid,\r
@@ -208,17 +211,17 @@ EXIT:
 UINT32\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 RequestParameter\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  RequestParameter\r
   )\r
 {\r
-  UINT32                 TempOperationRequest;\r
-  UINT32                 TempRequestParameter;\r
+  UINT32  TempOperationRequest;\r
+  UINT32  TempRequestParameter;\r
 \r
   TempOperationRequest = OperationRequest;\r
   TempRequestParameter = RequestParameter;\r
 \r
-  return Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx(&TempOperationRequest, &TempRequestParameter);\r
+  return Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx (&TempOperationRequest, &TempRequestParameter);\r
 }\r
 \r
 /**\r
@@ -236,7 +239,7 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (
 UINT32\r
 EFIAPI\r
 Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (\r
-  IN UINT32                 OperationRequest\r
+  IN UINT32  OperationRequest\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -251,28 +254,29 @@ Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
   // Get the Physical Presence variable\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE);\r
-  Status = mTcg2PpSmmVariable->SmmGetVariable (\r
-                                 TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
-                                 &gEfiTcg2PhysicalPresenceGuid,\r
-                                 NULL,\r
-                                 &DataSize,\r
-                                 &PpData\r
-                                 );\r
+  Status   = mTcg2PpSmmVariable->SmmGetVariable (\r
+                                   TCG2_PHYSICAL_PRESENCE_VARIABLE,\r
+                                   &gEfiTcg2PhysicalPresenceGuid,\r
+                                   NULL,\r
+                                   &DataSize,\r
+                                   &PpData\r
+                                   );\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "[TPM2] Get PP variable failure! Status = %r\n", Status));\r
     return TCG_PP_GET_USER_CONFIRMATION_BLOCKED_BY_BIOS_CONFIGURATION;\r
   }\r
+\r
   //\r
   // Get the Physical Presence flags\r
   //\r
   DataSize = sizeof (EFI_TCG2_PHYSICAL_PRESENCE_FLAGS);\r
-  Status = mTcg2PpSmmVariable->SmmGetVariable (\r
-                                 TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                                 &gEfiTcg2PhysicalPresenceGuid,\r
-                                 NULL,\r
-                                 &DataSize,\r
-                                 &Flags\r
-                                 );\r
+  Status   = mTcg2PpSmmVariable->SmmGetVariable (\r
+                                   TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                                   &gEfiTcg2PhysicalPresenceGuid,\r
+                                   NULL,\r
+                                   &DataSize,\r
+                                   &Flags\r
+                                   );\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "[TPM2] Get PP flags failure! Status = %r\n", Status));\r
     return TCG_PP_GET_USER_CONFIRMATION_BLOCKED_BY_BIOS_CONFIGURATION;\r
@@ -288,6 +292,7 @@ Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
       if ((Flags.PPFlags & TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CLEAR) == 0) {\r
         RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_NO_ACTION:\r
@@ -302,12 +307,14 @@ Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
       if ((Flags.PPFlags & TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CHANGE_PCRS) == 0) {\r
         RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_CHANGE_EPS:\r
       if ((Flags.PPFlags & TCG2_BIOS_TPM_MANAGEMENT_FLAG_PP_REQUIRED_FOR_CHANGE_EPS) == 0) {\r
         RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_LOG_ALL_DIGESTS:\r
@@ -318,12 +325,14 @@ Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
       if ((Flags.PPFlags & TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE_BLOCK_SID) == 0) {\r
         RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_DISABLE_BLOCK_SID:\r
       if ((Flags.PPFlags & TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BLOCK_SID) == 0) {\r
         RequestConfirmed = TRUE;\r
       }\r
+\r
       break;\r
 \r
     case TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_ENABLE_BLOCK_SID_FUNC_TRUE:\r
@@ -344,15 +353,16 @@ Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
           return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED;\r
         }\r
       } else {\r
-       //\r
-       // TCG PP lower than 1.3. (1.0, 1.1, 1.2)\r
-       //\r
-       if (OperationRequest <= TCG2_PHYSICAL_PRESENCE_NO_ACTION_MAX) {\r
-         RequestConfirmed = TRUE;\r
-       } else if (OperationRequest < TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
-         return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED;\r
-       }\r
+        //\r
+        // TCG PP lower than 1.3. (1.0, 1.1, 1.2)\r
+        //\r
+        if (OperationRequest <= TCG2_PHYSICAL_PRESENCE_NO_ACTION_MAX) {\r
+          RequestConfirmed = TRUE;\r
+        } else if (OperationRequest < TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
+          return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED;\r
+        }\r
       }\r
+\r
       break;\r
   }\r
 \r
@@ -382,17 +392,17 @@ Tcg2PhysicalPresenceLibCommonConstructor (
 {\r
   EFI_STATUS  Status;\r
 \r
-  if (AsciiStrnCmp(PP_INF_VERSION_1_2, (CHAR8 *)PcdGetPtr(PcdTcgPhysicalPresenceInterfaceVer), sizeof(PP_INF_VERSION_1_2) - 1) >= 0) {\r
+  if (AsciiStrnCmp (PP_INF_VERSION_1_2, (CHAR8 *)PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer), sizeof (PP_INF_VERSION_1_2) - 1) >= 0) {\r
     mIsTcg2PPVerLowerThan_1_3 = TRUE;\r
   }\r
 \r
   //\r
   // Locate SmmVariableProtocol.\r
   //\r
-  Status = gMmst->MmLocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID**)&mTcg2PpSmmVariable);\r
+  Status = gMmst->MmLocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID **)&mTcg2PpSmmVariable);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  mTcg2PhysicalPresenceFlags = PcdGet32(PcdTcg2PhysicalPresenceFlags);\r
+  mTcg2PhysicalPresenceFlags = PcdGet32 (PcdTcg2PhysicalPresenceFlags);\r
 \r
   return EFI_SUCCESS;\r
 }\r
index aa3dcb6beb63933dc8554707dcd53a11b1b30560..89ef26e2fd47a01fdc14dd9943c2c403ddead4c9 100644 (file)
@@ -30,10 +30,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 UINT32\r
 EFIAPI\r
 Tcg2PpVendorLibExecutePendingRequest (\r
-  IN TPM2B_AUTH             *PlatformAuth   OPTIONAL,\r
-  IN UINT32                 OperationRequest,\r
-  IN OUT UINT32             *ManagementFlags,\r
-  OUT BOOLEAN               *ResetRequired\r
+  IN TPM2B_AUTH  *PlatformAuth   OPTIONAL,\r
+  IN UINT32      OperationRequest,\r
+  IN OUT UINT32  *ManagementFlags,\r
+  OUT BOOLEAN    *ResetRequired\r
   )\r
 {\r
   ASSERT (OperationRequest >= TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION);\r
@@ -61,9 +61,9 @@ Tcg2PpVendorLibExecutePendingRequest (
 BOOLEAN\r
 EFIAPI\r
 Tcg2PpVendorLibHasValidRequest (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags,\r
-  OUT BOOLEAN               *RequestConfirmed\r
+  IN UINT32    OperationRequest,\r
+  IN UINT32    ManagementFlags,\r
+  OUT BOOLEAN  *RequestConfirmed\r
   )\r
 {\r
   ASSERT (OperationRequest >= TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION);\r
@@ -91,9 +91,9 @@ Tcg2PpVendorLibHasValidRequest (
 UINT32\r
 EFIAPI\r
 Tcg2PpVendorLibSubmitRequestToPreOSFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags,\r
-  IN UINT32                 RequestParameter\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  ManagementFlags,\r
+  IN UINT32  RequestParameter\r
   )\r
 {\r
   ASSERT (OperationRequest >= TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION);\r
@@ -118,8 +118,8 @@ Tcg2PpVendorLibSubmitRequestToPreOSFunction (
 UINT32\r
 EFIAPI\r
 Tcg2PpVendorLibGetUserConfirmationStatusFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  ManagementFlags\r
   )\r
 {\r
   ASSERT (OperationRequest >= TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION);\r
index e8a53fca0dc76cb268c872a532993e2eae1533c5..e1e0f990d313fb03ab2df000f93eb4cb4e3f7078 100644 (file)
@@ -32,8 +32,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 VOID *\r
 TpmMeasurementGetFvName (\r
-  IN EFI_PHYSICAL_ADDRESS           FvBase,\r
-  IN UINT64                         FvLength\r
+  IN EFI_PHYSICAL_ADDRESS  FvBase,\r
+  IN UINT64                FvLength\r
   )\r
 {\r
   EFI_FIRMWARE_VOLUME_HEADER      *FvHeader;\r
@@ -42,10 +42,12 @@ TpmMeasurementGetFvName (
   if (FvBase >= MAX_ADDRESS) {\r
     return NULL;\r
   }\r
+\r
   if (FvLength >= MAX_ADDRESS - FvBase) {\r
     return NULL;\r
   }\r
-  if (FvLength < sizeof(EFI_FIRMWARE_VOLUME_HEADER)) {\r
+\r
+  if (FvLength < sizeof (EFI_FIRMWARE_VOLUME_HEADER)) {\r
     return NULL;\r
   }\r
 \r
@@ -53,12 +55,15 @@ TpmMeasurementGetFvName (
   if (FvHeader->Signature != EFI_FVH_SIGNATURE) {\r
     return NULL;\r
   }\r
-  if (FvHeader->ExtHeaderOffset < sizeof(EFI_FIRMWARE_VOLUME_HEADER)) {\r
+\r
+  if (FvHeader->ExtHeaderOffset < sizeof (EFI_FIRMWARE_VOLUME_HEADER)) {\r
     return NULL;\r
   }\r
-  if (FvHeader->ExtHeaderOffset + sizeof(EFI_FIRMWARE_VOLUME_EXT_HEADER) > FvLength) {\r
+\r
+  if (FvHeader->ExtHeaderOffset + sizeof (EFI_FIRMWARE_VOLUME_EXT_HEADER) > FvLength) {\r
     return NULL;\r
   }\r
+\r
   FvExtHeader = (EFI_FIRMWARE_VOLUME_EXT_HEADER *)(UINTN)(FvBase + FvHeader->ExtHeaderOffset);\r
 \r
   return &FvExtHeader->FvName;\r
@@ -80,44 +85,45 @@ TpmMeasurementGetFvName (
 EFI_STATUS\r
 EFIAPI\r
 MeasureFirmwareBlob (\r
-  IN UINT32                         PcrIndex,\r
-  IN CHAR8                          *Description OPTIONAL,\r
-  IN EFI_PHYSICAL_ADDRESS           FirmwareBlobBase,\r
-  IN UINT64                         FirmwareBlobLength\r
+  IN UINT32                PcrIndex,\r
+  IN CHAR8                 *Description OPTIONAL,\r
+  IN EFI_PHYSICAL_ADDRESS  FirmwareBlobBase,\r
+  IN UINT64                FirmwareBlobLength\r
   )\r
 {\r
-  EFI_PLATFORM_FIRMWARE_BLOB        FvBlob;\r
-  PLATFORM_FIRMWARE_BLOB2_STRUCT    FvBlob2;\r
-  VOID                              *FvName;\r
-  UINT32                            EventType;\r
-  VOID                              *EventLog;\r
-  UINT32                            EventLogSize;\r
-  EFI_STATUS                        Status;\r
+  EFI_PLATFORM_FIRMWARE_BLOB      FvBlob;\r
+  PLATFORM_FIRMWARE_BLOB2_STRUCT  FvBlob2;\r
+  VOID                            *FvName;\r
+  UINT32                          EventType;\r
+  VOID                            *EventLog;\r
+  UINT32                          EventLogSize;\r
+  EFI_STATUS                      Status;\r
 \r
   FvName = TpmMeasurementGetFvName (FirmwareBlobBase, FirmwareBlobLength);\r
 \r
   if (((Description != NULL) || (FvName != NULL)) &&\r
-      (PcdGet32(PcdTcgPfpMeasurementRevision) >= TCG_EfiSpecIDEventStruct_SPEC_ERRATA_TPM2_REV_105)) {\r
+      (PcdGet32 (PcdTcgPfpMeasurementRevision) >= TCG_EfiSpecIDEventStruct_SPEC_ERRATA_TPM2_REV_105))\r
+  {\r
     if (Description != NULL) {\r
-      AsciiSPrint((CHAR8*)FvBlob2.BlobDescription, sizeof(FvBlob2.BlobDescription), "%a", Description);\r
+      AsciiSPrint ((CHAR8 *)FvBlob2.BlobDescription, sizeof (FvBlob2.BlobDescription), "%a", Description);\r
     } else {\r
-      AsciiSPrint((CHAR8*)FvBlob2.BlobDescription, sizeof(FvBlob2.BlobDescription), "Fv(%g)", FvName);\r
+      AsciiSPrint ((CHAR8 *)FvBlob2.BlobDescription, sizeof (FvBlob2.BlobDescription), "Fv(%g)", FvName);\r
     }\r
 \r
-    FvBlob2.BlobDescriptionSize = sizeof(FvBlob2.BlobDescription);\r
-    FvBlob2.BlobBase = FirmwareBlobBase;\r
-    FvBlob2.BlobLength = FirmwareBlobLength;\r
+    FvBlob2.BlobDescriptionSize = sizeof (FvBlob2.BlobDescription);\r
+    FvBlob2.BlobBase            = FirmwareBlobBase;\r
+    FvBlob2.BlobLength          = FirmwareBlobLength;\r
 \r
-    EventType = EV_EFI_PLATFORM_FIRMWARE_BLOB2;\r
-    EventLog = &FvBlob2;\r
-    EventLogSize = sizeof(FvBlob2);\r
+    EventType    = EV_EFI_PLATFORM_FIRMWARE_BLOB2;\r
+    EventLog     = &FvBlob2;\r
+    EventLogSize = sizeof (FvBlob2);\r
   } else {\r
-    FvBlob.BlobBase = FirmwareBlobBase;\r
+    FvBlob.BlobBase   = FirmwareBlobBase;\r
     FvBlob.BlobLength = FirmwareBlobLength;\r
 \r
-    EventType = EV_EFI_PLATFORM_FIRMWARE_BLOB;\r
-    EventLog = &FvBlob;\r
-    EventLogSize = sizeof(FvBlob);\r
+    EventType    = EV_EFI_PLATFORM_FIRMWARE_BLOB;\r
+    EventLog     = &FvBlob;\r
+    EventLogSize = sizeof (FvBlob);\r
   }\r
 \r
   Status = TpmMeasureAndLogData (\r
@@ -125,7 +131,7 @@ MeasureFirmwareBlob (
              EventType,\r
              EventLog,\r
              EventLogSize,\r
-             (VOID*)(UINTN)FirmwareBlobBase,\r
+             (VOID *)(UINTN)FirmwareBlobBase,\r
              FirmwareBlobLength\r
              );\r
 \r
@@ -149,40 +155,41 @@ MeasureFirmwareBlob (
 EFI_STATUS\r
 EFIAPI\r
 MeasureHandoffTable (\r
-  IN UINT32                         PcrIndex,\r
-  IN CHAR8                          *Description OPTIONAL,\r
-  IN EFI_GUID                       *TableGuid,\r
-  IN VOID                           *TableAddress,\r
-  IN UINTN                          TableLength\r
+  IN UINT32    PcrIndex,\r
+  IN CHAR8     *Description OPTIONAL,\r
+  IN EFI_GUID  *TableGuid,\r
+  IN VOID      *TableAddress,\r
+  IN UINTN     TableLength\r
   )\r
 {\r
-  EFI_HANDOFF_TABLE_POINTERS        HandoffTables;\r
-  HANDOFF_TABLE_POINTERS2_STRUCT    HandoffTables2;\r
-  UINT32                            EventType;\r
-  VOID                              *EventLog;\r
-  UINT32                            EventLogSize;\r
-  EFI_STATUS                        Status;\r
+  EFI_HANDOFF_TABLE_POINTERS      HandoffTables;\r
+  HANDOFF_TABLE_POINTERS2_STRUCT  HandoffTables2;\r
+  UINT32                          EventType;\r
+  VOID                            *EventLog;\r
+  UINT32                          EventLogSize;\r
+  EFI_STATUS                      Status;\r
 \r
   if ((Description != NULL) &&\r
-      (PcdGet32(PcdTcgPfpMeasurementRevision) >= TCG_EfiSpecIDEventStruct_SPEC_ERRATA_TPM2_REV_105)) {\r
-    AsciiSPrint((CHAR8*)HandoffTables2.TableDescription, sizeof(HandoffTables2.TableDescription), "%a", Description);\r
+      (PcdGet32 (PcdTcgPfpMeasurementRevision) >= TCG_EfiSpecIDEventStruct_SPEC_ERRATA_TPM2_REV_105))\r
+  {\r
+    AsciiSPrint ((CHAR8 *)HandoffTables2.TableDescription, sizeof (HandoffTables2.TableDescription), "%a", Description);\r
 \r
-    HandoffTables2.TableDescriptionSize = sizeof(HandoffTables2.TableDescription);\r
-    HandoffTables2.NumberOfTables = 1;\r
+    HandoffTables2.TableDescriptionSize = sizeof (HandoffTables2.TableDescription);\r
+    HandoffTables2.NumberOfTables       = 1;\r
     CopyGuid (&(HandoffTables2.TableEntry[0].VendorGuid), TableGuid);\r
     HandoffTables2.TableEntry[0].VendorTable = TableAddress;\r
 \r
-    EventType = EV_EFI_HANDOFF_TABLES2;\r
-    EventLog = &HandoffTables2;\r
-    EventLogSize = sizeof(HandoffTables2);\r
+    EventType    = EV_EFI_HANDOFF_TABLES2;\r
+    EventLog     = &HandoffTables2;\r
+    EventLogSize = sizeof (HandoffTables2);\r
   } else {\r
     HandoffTables.NumberOfTables = 1;\r
     CopyGuid (&(HandoffTables.TableEntry[0].VendorGuid), TableGuid);\r
     HandoffTables.TableEntry[0].VendorTable = TableAddress;\r
 \r
-    EventType = EV_EFI_HANDOFF_TABLES;\r
-    EventLog = &HandoffTables;\r
-    EventLogSize = sizeof(HandoffTables);\r
+    EventType    = EV_EFI_HANDOFF_TABLES;\r
+    EventLog     = &HandoffTables;\r
+    EventLogSize = sizeof (HandoffTables);\r
   }\r
 \r
   Status = TpmMeasureAndLogData (\r
index c07d1c483377b918f58a0e69c361ccbfb57b4527..a73e975186661983b22fa2ddfb36f231ffa5744f 100644 (file)
@@ -29,9 +29,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 UINT32\r
 EFIAPI\r
 TcgPpVendorLibExecutePendingRequest (\r
-  IN UINT32                 OperationRequest,\r
-  IN OUT UINT32             *ManagementFlags,\r
-  OUT BOOLEAN               *ResetRequired\r
+  IN UINT32      OperationRequest,\r
+  IN OUT UINT32  *ManagementFlags,\r
+  OUT BOOLEAN    *ResetRequired\r
   )\r
 {\r
   ASSERT (OperationRequest >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION);\r
@@ -59,9 +59,9 @@ TcgPpVendorLibExecutePendingRequest (
 BOOLEAN\r
 EFIAPI\r
 TcgPpVendorLibHasValidRequest (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags,\r
-  OUT BOOLEAN               *RequestConfirmed\r
+  IN UINT32    OperationRequest,\r
+  IN UINT32    ManagementFlags,\r
+  OUT BOOLEAN  *RequestConfirmed\r
   )\r
 {\r
   ASSERT (OperationRequest >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION);\r
@@ -88,8 +88,8 @@ TcgPpVendorLibHasValidRequest (
 UINT32\r
 EFIAPI\r
 TcgPpVendorLibSubmitRequestToPreOSFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  ManagementFlags\r
   )\r
 {\r
   ASSERT (OperationRequest >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION);\r
@@ -114,8 +114,8 @@ TcgPpVendorLibSubmitRequestToPreOSFunction (
 UINT32\r
 EFIAPI\r
 TcgPpVendorLibGetUserConfirmationStatusFunction (\r
-  IN UINT32                 OperationRequest,\r
-  IN UINT32                 ManagementFlags\r
+  IN UINT32  OperationRequest,\r
+  IN UINT32  ManagementFlags\r
   )\r
 {\r
   ASSERT (OperationRequest >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION);\r
index 660f79effd53c0f90fd8c5e5658734847760f252..a9946c76f4de0bd6137a341c27dffac5fd39a995 100644 (file)
@@ -11,7 +11,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/BaseLib.h>\r
 #include <Library/BaseMemoryLib.h>\r
 #include <Library/DebugLib.h>\r
-//#include <Library/PrintLib.h>\r
+// #include <Library/PrintLib.h>\r
 \r
 /**\r
   Required to be called before calling any other Tcg functions with the TCG_CREATE_STRUCT.\r
@@ -25,25 +25,25 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgInitTcgCreateStruct(\r
-  TCG_CREATE_STRUCT      *CreateStruct,\r
-  VOID                   *Buffer,\r
-  UINT32                 BufferSize\r
+TcgInitTcgCreateStruct (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  VOID               *Buffer,\r
+  UINT32             BufferSize\r
   )\r
 {\r
-  NULL_CHECK(CreateStruct);\r
-  NULL_CHECK(Buffer);\r
+  NULL_CHECK (CreateStruct);\r
+  NULL_CHECK (Buffer);\r
 \r
   if (BufferSize == 0) {\r
     DEBUG ((DEBUG_INFO, "BufferSize=0\n"));\r
     return (TcgResultFailureZeroSize);\r
   }\r
 \r
-  ZeroMem(Buffer, BufferSize);\r
-  CreateStruct->BufferSize = BufferSize;\r
-  CreateStruct->Buffer = Buffer;\r
-  CreateStruct->ComPacket = NULL;\r
-  CreateStruct->CurPacket = NULL;\r
+  ZeroMem (Buffer, BufferSize);\r
+  CreateStruct->BufferSize   = BufferSize;\r
+  CreateStruct->Buffer       = Buffer;\r
+  CreateStruct->ComPacket    = NULL;\r
+  CreateStruct->CurPacket    = NULL;\r
   CreateStruct->CurSubPacket = NULL;\r
 \r
   return (TcgResultSuccess);\r
@@ -60,31 +60,37 @@ TcgInitTcgCreateStruct(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartComPacket(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT16              ComId,\r
-  UINT16              ComIdExtension\r
+TcgStartComPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension\r
   )\r
 {\r
-  NULL_CHECK(CreateStruct);\r
-\r
-  if (CreateStruct->ComPacket != NULL ||\r
-      CreateStruct->CurPacket != NULL ||\r
-      CreateStruct->CurSubPacket != NULL\r
-     ) {\r
-    DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket,\r
-    CreateStruct->CurSubPacket));\r
+  NULL_CHECK (CreateStruct);\r
+\r
+  if ((CreateStruct->ComPacket != NULL) ||\r
+      (CreateStruct->CurPacket != NULL) ||\r
+      (CreateStruct->CurSubPacket != NULL)\r
+      )\r
+  {\r
+    DEBUG ((\r
+      DEBUG_INFO,\r
+      "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n",\r
+      CreateStruct->ComPacket,\r
+      CreateStruct->CurPacket,\r
+      CreateStruct->CurSubPacket\r
+      ));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
-  if (sizeof(TCG_COM_PACKET) > CreateStruct->BufferSize) {\r
+  if (sizeof (TCG_COM_PACKET) > CreateStruct->BufferSize) {\r
     DEBUG ((DEBUG_INFO, "BufferSize=0x%X\n", CreateStruct->BufferSize));\r
     return (TcgResultFailureBufferTooSmall);\r
   }\r
 \r
-  CreateStruct->ComPacket = (TCG_COM_PACKET*)CreateStruct->Buffer;\r
-  CreateStruct->ComPacket->ComIDBE = SwapBytes16(ComId);\r
-  CreateStruct->ComPacket->ComIDExtensionBE = SwapBytes16(ComIdExtension);\r
+  CreateStruct->ComPacket                   = (TCG_COM_PACKET *)CreateStruct->Buffer;\r
+  CreateStruct->ComPacket->ComIDBE          = SwapBytes16 (ComId);\r
+  CreateStruct->ComPacket->ComIDExtensionBE = SwapBytes16 (ComIdExtension);\r
 \r
   return (TcgResultSuccess);\r
 }\r
@@ -103,48 +109,50 @@ TcgStartComPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartPacket(\r
-  TCG_CREATE_STRUCT    *CreateStruct,\r
-  UINT32               Tsn,\r
-  UINT32               Hsn,\r
-  UINT32               SeqNumber,\r
-  UINT16               AckType,\r
-  UINT32               Ack\r
+TcgStartPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             Tsn,\r
+  UINT32             Hsn,\r
+  UINT32             SeqNumber,\r
+  UINT16             AckType,\r
+  UINT32             Ack\r
   )\r
 {\r
-  UINT32 AddedSize;\r
-  NULL_CHECK(CreateStruct);\r
+  UINT32  AddedSize;\r
+\r
+  NULL_CHECK (CreateStruct);\r
 \r
   AddedSize = 0;\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket != NULL ||\r
-      CreateStruct->CurSubPacket != NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket != NULL) ||\r
+      (CreateStruct->CurSubPacket != NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
   // update TCG_COM_PACKET and packet lengths\r
-  AddedSize = sizeof(TCG_PACKET);\r
+  AddedSize = sizeof (TCG_PACKET);\r
 \r
-  if ((SwapBytes32(CreateStruct->ComPacket->LengthBE) + AddedSize) > CreateStruct->BufferSize) {\r
+  if ((SwapBytes32 (CreateStruct->ComPacket->LengthBE) + AddedSize) > CreateStruct->BufferSize) {\r
     DEBUG ((DEBUG_INFO, "BufferSize=0x%X\n", CreateStruct->BufferSize));\r
     return (TcgResultFailureBufferTooSmall);\r
   }\r
 \r
-  CreateStruct->CurPacket = (TCG_PACKET*)(CreateStruct->ComPacket->Payload + SwapBytes32(CreateStruct->ComPacket->LengthBE));\r
+  CreateStruct->CurPacket = (TCG_PACKET *)(CreateStruct->ComPacket->Payload + SwapBytes32 (CreateStruct->ComPacket->LengthBE));\r
 \r
-  CreateStruct->CurPacket->TperSessionNumberBE = SwapBytes32( Tsn );\r
-  CreateStruct->CurPacket->HostSessionNumberBE = SwapBytes32( Hsn );\r
-  CreateStruct->CurPacket->SequenceNumberBE = SwapBytes32( SeqNumber );\r
-  CreateStruct->CurPacket->AckTypeBE = SwapBytes16( AckType );\r
-  CreateStruct->CurPacket->AcknowledgementBE = SwapBytes32( Ack );\r
+  CreateStruct->CurPacket->TperSessionNumberBE = SwapBytes32 (Tsn);\r
+  CreateStruct->CurPacket->HostSessionNumberBE = SwapBytes32 (Hsn);\r
+  CreateStruct->CurPacket->SequenceNumberBE    = SwapBytes32 (SeqNumber);\r
+  CreateStruct->CurPacket->AckTypeBE           = SwapBytes16 (AckType);\r
+  CreateStruct->CurPacket->AcknowledgementBE   = SwapBytes32 (Ack);\r
 \r
   CreateStruct->CurPacket->LengthBE = 0;\r
 \r
   // update TCG_COM_PACKET Length for next pointer\r
-  CreateStruct->ComPacket->LengthBE = SwapBytes32( SwapBytes32(CreateStruct->ComPacket->LengthBE) + AddedSize );\r
+  CreateStruct->ComPacket->LengthBE = SwapBytes32 (SwapBytes32 (CreateStruct->ComPacket->LengthBE) + AddedSize);\r
 \r
   return (TcgResultSuccess);\r
 }\r
@@ -159,41 +167,42 @@ TcgStartPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartSubPacket(\r
-  TCG_CREATE_STRUCT    *CreateStruct,\r
-  UINT16               Kind\r
+TcgStartSubPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT16             Kind\r
   )\r
 {\r
-  UINT32 AddedSize;\r
+  UINT32  AddedSize;\r
 \r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
   AddedSize = 0;\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket == NULL ||\r
-      CreateStruct->CurSubPacket != NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket == NULL) ||\r
+      (CreateStruct->CurSubPacket != NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
-  AddedSize = sizeof(TCG_SUB_PACKET);\r
+  AddedSize = sizeof (TCG_SUB_PACKET);\r
 \r
-  if ((SwapBytes32(CreateStruct->ComPacket->LengthBE) + AddedSize) > CreateStruct->BufferSize) {\r
+  if ((SwapBytes32 (CreateStruct->ComPacket->LengthBE) + AddedSize) > CreateStruct->BufferSize) {\r
     DEBUG ((DEBUG_INFO, "BufferSize=0x%X\n", CreateStruct->BufferSize));\r
     return (TcgResultFailureBufferTooSmall);\r
   }\r
 \r
-  CreateStruct->CurSubPacket = (TCG_SUB_PACKET*)(CreateStruct->CurPacket->Payload + SwapBytes32(CreateStruct->CurPacket->LengthBE));\r
-  CreateStruct->CurSubPacket->KindBE = SwapBytes16(Kind);\r
+  CreateStruct->CurSubPacket         = (TCG_SUB_PACKET *)(CreateStruct->CurPacket->Payload + SwapBytes32 (CreateStruct->CurPacket->LengthBE));\r
+  CreateStruct->CurSubPacket->KindBE = SwapBytes16 (Kind);\r
 \r
   // update lengths\r
   CreateStruct->CurSubPacket->LengthBE = 0;\r
 \r
   // update TCG_COM_PACKET and packet lengths\r
-  CreateStruct->ComPacket->LengthBE = SwapBytes32(SwapBytes32(CreateStruct->ComPacket->LengthBE) + AddedSize);\r
-  CreateStruct->CurPacket->LengthBE = SwapBytes32(SwapBytes32(CreateStruct->CurPacket->LengthBE) + AddedSize);\r
+  CreateStruct->ComPacket->LengthBE = SwapBytes32 (SwapBytes32 (CreateStruct->ComPacket->LengthBE) + AddedSize);\r
+  CreateStruct->CurPacket->LengthBE = SwapBytes32 (SwapBytes32 (CreateStruct->CurPacket->LengthBE) + AddedSize);\r
 \r
   return (TcgResultSuccess);\r
 }\r
@@ -208,39 +217,40 @@ TcgStartSubPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndSubPacket(\r
-  TCG_CREATE_STRUCT   *CreateStruct\r
+TcgEndSubPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  UINT32 PadSize;\r
+  UINT32  PadSize;\r
 \r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
   PadSize = 0;\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket == NULL  ||\r
-      CreateStruct->CurSubPacket == NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket == NULL) ||\r
+      (CreateStruct->CurSubPacket == NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
   // align to 4-byte boundaries, so shift padding\r
   // pad Size does not apply to subpacket Length\r
-  PadSize = TCG_SUBPACKET_ALIGNMENT - (SwapBytes32(CreateStruct->CurSubPacket->LengthBE) & (TCG_SUBPACKET_ALIGNMENT - 1));\r
+  PadSize = TCG_SUBPACKET_ALIGNMENT - (SwapBytes32 (CreateStruct->CurSubPacket->LengthBE) & (TCG_SUBPACKET_ALIGNMENT - 1));\r
 \r
   if (PadSize == TCG_SUBPACKET_ALIGNMENT) {\r
     PadSize = 0;\r
   }\r
 \r
-  if ((SwapBytes32(CreateStruct->ComPacket->LengthBE) + PadSize) > CreateStruct->BufferSize) {\r
+  if ((SwapBytes32 (CreateStruct->ComPacket->LengthBE) + PadSize) > CreateStruct->BufferSize) {\r
     DEBUG ((DEBUG_INFO, "BufferSize=0x%X\n", CreateStruct->BufferSize));\r
     return (TcgResultFailureBufferTooSmall);\r
   }\r
 \r
-  CreateStruct->CurPacket->LengthBE = SwapBytes32(SwapBytes32(CreateStruct->CurPacket->LengthBE) + PadSize);\r
-  CreateStruct->ComPacket->LengthBE = SwapBytes32(SwapBytes32(CreateStruct->ComPacket->LengthBE) + PadSize);\r
+  CreateStruct->CurPacket->LengthBE = SwapBytes32 (SwapBytes32 (CreateStruct->CurPacket->LengthBE) + PadSize);\r
+  CreateStruct->ComPacket->LengthBE = SwapBytes32 (SwapBytes32 (CreateStruct->ComPacket->LengthBE) + PadSize);\r
 \r
   CreateStruct->CurSubPacket = NULL;\r
 \r
@@ -256,16 +266,17 @@ TcgEndSubPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndPacket(\r
-  TCG_CREATE_STRUCT     *CreateStruct\r
+TcgEndPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket == NULL ||\r
-      CreateStruct->CurSubPacket != NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket == NULL) ||\r
+      (CreateStruct->CurSubPacket != NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
@@ -285,23 +296,24 @@ TcgEndPacket(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndComPacket(\r
-  TCG_CREATE_STRUCT      *CreateStruct,\r
-  UINT32                 *Size\r
+TcgEndComPacket (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size\r
   )\r
 {\r
-  NULL_CHECK(CreateStruct);\r
-  NULL_CHECK(Size);\r
-\r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket != NULL ||\r
-      CreateStruct->CurSubPacket != NULL\r
-     ) {\r
+  NULL_CHECK (CreateStruct);\r
+  NULL_CHECK (Size);\r
+\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket != NULL) ||\r
+      (CreateStruct->CurSubPacket != NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
-  *Size = SwapBytes32(CreateStruct->ComPacket->LengthBE) + sizeof(*CreateStruct->ComPacket);\r
+  *Size                   = SwapBytes32 (CreateStruct->ComPacket->LengthBE) + sizeof (*CreateStruct->ComPacket);\r
   CreateStruct->ComPacket = NULL;\r
 \r
   return (TcgResultSuccess);\r
@@ -319,55 +331,57 @@ TcgEndComPacket(
 \r
 **/\r
 TCG_RESULT\r
-TcgAddRawTokenData(\r
-  TCG_CREATE_STRUCT      *CreateStruct,\r
-  const VOID             *Header,\r
-  UINT8                  HeaderSize,\r
-  const VOID             *Data,\r
-  UINT32                 DataSize,\r
-  BOOLEAN                ByteSwapData\r
+TcgAddRawTokenData (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  const VOID         *Header,\r
+  UINT8              HeaderSize,\r
+  const VOID         *Data,\r
+  UINT32             DataSize,\r
+  BOOLEAN            ByteSwapData\r
   )\r
 {\r
-  UINT32 AddedSize;\r
-  UINT8Dest;\r
-  const UINT8DataBytes;\r
-  UINT32 Index;\r
+  UINT32       AddedSize;\r
+  UINT8        *Dest;\r
+  const UINT8  *DataBytes;\r
+  UINT32       Index;\r
 \r
   AddedSize = 0;\r
-  Index = 0;\r
-  Dest = NULL;\r
+  Index     = 0;\r
+  Dest      = NULL;\r
 \r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
-  if ((HeaderSize != 0 && Header == NULL) ||\r
-      (DataSize != 0 && Data == NULL)\r
-     ) {\r
+  if (((HeaderSize != 0) && (Header == NULL)) ||\r
+      ((DataSize != 0) && (Data == NULL))\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "HeaderSize=0x%X Header=%p DataSize=0x%X Data=%p\n", HeaderSize, Header, DataSize, Data));\r
     return (TcgResultFailureNullPointer);\r
   }\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket == NULL ||\r
-      CreateStruct->CurSubPacket == NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket == NULL) ||\r
+      (CreateStruct->CurSubPacket == NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
   // verify there is enough Buffer Size\r
   AddedSize = HeaderSize + DataSize;\r
-  if ((SwapBytes32(CreateStruct->ComPacket->LengthBE) + AddedSize) > CreateStruct->BufferSize) {\r
+  if ((SwapBytes32 (CreateStruct->ComPacket->LengthBE) + AddedSize) > CreateStruct->BufferSize) {\r
     return (TcgResultFailureBufferTooSmall);\r
   }\r
 \r
   // Get a pointer to where the new bytes should go\r
-  Dest = CreateStruct->ComPacket->Payload + SwapBytes32(CreateStruct->ComPacket->LengthBE);\r
+  Dest = CreateStruct->ComPacket->Payload + SwapBytes32 (CreateStruct->ComPacket->LengthBE);\r
 \r
   switch (HeaderSize) {\r
-    case sizeof(TCG_SIMPLE_TOKEN_SHORT_ATOM):\r
-    case sizeof(TCG_SIMPLE_TOKEN_MEDIUM_ATOM):\r
-    case sizeof(TCG_SIMPLE_TOKEN_LONG_ATOM):\r
-      CopyMem(Dest, Header, HeaderSize);\r
+    case sizeof (TCG_SIMPLE_TOKEN_SHORT_ATOM):\r
+    case sizeof (TCG_SIMPLE_TOKEN_MEDIUM_ATOM):\r
+    case sizeof (TCG_SIMPLE_TOKEN_LONG_ATOM):\r
+      CopyMem (Dest, Header, HeaderSize);\r
       Dest += HeaderSize;\r
     case 0: // no Header is valid\r
       break;\r
@@ -379,18 +393,18 @@ TcgAddRawTokenData(
 \r
   // copy the Data bytes\r
   if (ByteSwapData) {\r
-    DataBytes = (const UINT8*)Data;\r
+    DataBytes = (const UINT8 *)Data;\r
     for (Index = 0; Index < DataSize; Index++) {\r
       Dest[Index] = DataBytes[DataSize - 1 - Index];\r
     }\r
   } else {\r
-    CopyMem(Dest, Data, DataSize);\r
+    CopyMem (Dest, Data, DataSize);\r
   }\r
 \r
   // Update all the packet sizes\r
-  CreateStruct->ComPacket->LengthBE = SwapBytes32(SwapBytes32(CreateStruct->ComPacket->LengthBE) + AddedSize);\r
-  CreateStruct->CurPacket->LengthBE = SwapBytes32(SwapBytes32(CreateStruct->CurPacket->LengthBE) + AddedSize);\r
-  CreateStruct->CurSubPacket->LengthBE = SwapBytes32(SwapBytes32(CreateStruct->CurSubPacket->LengthBE) + AddedSize);\r
+  CreateStruct->ComPacket->LengthBE    = SwapBytes32 (SwapBytes32 (CreateStruct->ComPacket->LengthBE) + AddedSize);\r
+  CreateStruct->CurPacket->LengthBE    = SwapBytes32 (SwapBytes32 (CreateStruct->CurPacket->LengthBE) + AddedSize);\r
+  CreateStruct->CurSubPacket->LengthBE = SwapBytes32 (SwapBytes32 (CreateStruct->CurSubPacket->LengthBE) + AddedSize);\r
 \r
   return (TcgResultSuccess);\r
 }\r
@@ -405,15 +419,14 @@ TcgAddRawTokenData(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddRawByte(\r
-  TCG_CREATE_STRUCT     *CreateStruct,\r
-  UINT8                 Byte\r
+TcgAddRawByte (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT8              Byte\r
   )\r
 {\r
-  return TcgAddRawTokenData(CreateStruct, NULL, 0, &Byte, 1, FALSE);\r
+  return TcgAddRawTokenData (CreateStruct, NULL, 0, &Byte, 1, FALSE);\r
 }\r
 \r
-\r
 /**\r
    simple tokens - atoms: tiny, short, medium, long and empty atoms.\r
    tiny atom can be a signed or unsigned integer.\r
@@ -428,21 +441,21 @@ TcgAddRawByte(
 \r
 **/\r
 TCG_RESULT\r
-TcgAddAtom(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  const VOID          *Data,\r
-  UINT32              DataSize,\r
-  UINT8               ByteOrInt,\r
-  UINT8               SignOrCont\r
+TcgAddAtom (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  const VOID         *Data,\r
+  UINT32             DataSize,\r
+  UINT8              ByteOrInt,\r
+  UINT8              SignOrCont\r
   )\r
 {\r
-  const UINT8DataBytes;\r
-  TCG_SIMPLE_TOKEN_TINY_ATOM TinyAtom;\r
-  TCG_SIMPLE_TOKEN_SHORT_ATOM ShortAtom;\r
-  TCG_SIMPLE_TOKEN_MEDIUM_ATOM MediumAtom;\r
-  TCG_SIMPLE_TOKEN_LONG_ATOM LongAtom;\r
+  const UINT8                   *DataBytes;\r
+  TCG_SIMPLE_TOKEN_TINY_ATOM    TinyAtom;\r
+  TCG_SIMPLE_TOKEN_SHORT_ATOM   ShortAtom;\r
+  TCG_SIMPLE_TOKEN_MEDIUM_ATOM  MediumAtom;\r
+  TCG_SIMPLE_TOKEN_LONG_ATOM    LongAtom;\r
 \r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
   if (DataSize == 0) {\r
     if (ByteOrInt == TCG_ATOM_TYPE_INTEGER) {\r
@@ -451,52 +464,53 @@ TcgAddAtom(
     }\r
   } else {\r
     // if DataSize != 0, Data must be valid\r
-    NULL_CHECK(Data);\r
+    NULL_CHECK (Data);\r
   }\r
 \r
   // encode Data using the shortest possible atom\r
-  DataBytes = (const UINT8*)Data;\r
+  DataBytes = (const UINT8 *)Data;\r
   if ((DataSize == 1) &&\r
       (ByteOrInt == TCG_ATOM_TYPE_INTEGER) &&\r
-      ((SignOrCont != 0 && ((TCG_TOKEN_TINYATOM_SIGNED_MIN_VALUE <= *(INT8*)Data) && (*(INT8*)Data <= TCG_TOKEN_TINYATOM_SIGNED_MAX_VALUE))) ||\r
-       (SignOrCont == 0 && ((*DataBytes <= TCG_TOKEN_TINYATOM_UNSIGNED_MAX_VALUE))))\r
-     ) {\r
+      (((SignOrCont != 0) && ((TCG_TOKEN_TINYATOM_SIGNED_MIN_VALUE <= *(INT8 *)Data) && (*(INT8 *)Data <= TCG_TOKEN_TINYATOM_SIGNED_MAX_VALUE))) ||\r
+       ((SignOrCont == 0) && ((*DataBytes <= TCG_TOKEN_TINYATOM_UNSIGNED_MAX_VALUE))))\r
+      )\r
+  {\r
     TinyAtom.TinyAtomBits.IsZero = 0;\r
-    TinyAtom.TinyAtomBits.Sign = SignOrCont;\r
-    TinyAtom.TinyAtomBits.Data = *DataBytes & TCG_TOKEN_TINYATOM_UNSIGNED_MAX_VALUE;\r
-    return TcgAddRawTokenData(CreateStruct, NULL, 0, (UINT8*)&TinyAtom, sizeof(TCG_SIMPLE_TOKEN_TINY_ATOM), FALSE);\r
+    TinyAtom.TinyAtomBits.Sign   = SignOrCont;\r
+    TinyAtom.TinyAtomBits.Data   = *DataBytes & TCG_TOKEN_TINYATOM_UNSIGNED_MAX_VALUE;\r
+    return TcgAddRawTokenData (CreateStruct, NULL, 0, (UINT8 *)&TinyAtom, sizeof (TCG_SIMPLE_TOKEN_TINY_ATOM), FALSE);\r
   }\r
 \r
   if (DataSize <= TCG_TOKEN_SHORTATOM_MAX_BYTE_SIZE) {\r
-    ShortAtom.ShortAtomBits.IsOne = 1;\r
-    ShortAtom.ShortAtomBits.IsZero = 0;\r
-    ShortAtom.ShortAtomBits.ByteOrInt = ByteOrInt;\r
+    ShortAtom.ShortAtomBits.IsOne      = 1;\r
+    ShortAtom.ShortAtomBits.IsZero     = 0;\r
+    ShortAtom.ShortAtomBits.ByteOrInt  = ByteOrInt;\r
     ShortAtom.ShortAtomBits.SignOrCont = SignOrCont;\r
-    ShortAtom.ShortAtomBits.Length = DataSize & 0x0F;\r
-    return TcgAddRawTokenData(CreateStruct, &ShortAtom, sizeof(TCG_SIMPLE_TOKEN_SHORT_ATOM), Data, DataSize, ByteOrInt == TCG_ATOM_TYPE_INTEGER);\r
+    ShortAtom.ShortAtomBits.Length     = DataSize & 0x0F;\r
+    return TcgAddRawTokenData (CreateStruct, &ShortAtom, sizeof (TCG_SIMPLE_TOKEN_SHORT_ATOM), Data, DataSize, ByteOrInt == TCG_ATOM_TYPE_INTEGER);\r
   }\r
 \r
   if (DataSize <= TCG_TOKEN_MEDIUMATOM_MAX_BYTE_SIZE) {\r
-    MediumAtom.MediumAtomBits.IsOne1 = 1;\r
-    MediumAtom.MediumAtomBits.IsOne2 = 1;\r
-    MediumAtom.MediumAtomBits.IsZero = 0;\r
-    MediumAtom.MediumAtomBits.ByteOrInt = ByteOrInt;\r
+    MediumAtom.MediumAtomBits.IsOne1     = 1;\r
+    MediumAtom.MediumAtomBits.IsOne2     = 1;\r
+    MediumAtom.MediumAtomBits.IsZero     = 0;\r
+    MediumAtom.MediumAtomBits.ByteOrInt  = ByteOrInt;\r
     MediumAtom.MediumAtomBits.SignOrCont = SignOrCont;\r
-    MediumAtom.MediumAtomBits.LengthLow = DataSize & 0xFF;\r
+    MediumAtom.MediumAtomBits.LengthLow  = DataSize & 0xFF;\r
     MediumAtom.MediumAtomBits.LengthHigh = (DataSize >> TCG_MEDIUM_ATOM_LENGTH_HIGH_SHIFT) & TCG_MEDIUM_ATOM_LENGTH_HIGH_MASK;\r
-    return TcgAddRawTokenData(CreateStruct, &MediumAtom, sizeof(TCG_SIMPLE_TOKEN_MEDIUM_ATOM), Data, DataSize, ByteOrInt == TCG_ATOM_TYPE_INTEGER);\r
+    return TcgAddRawTokenData (CreateStruct, &MediumAtom, sizeof (TCG_SIMPLE_TOKEN_MEDIUM_ATOM), Data, DataSize, ByteOrInt == TCG_ATOM_TYPE_INTEGER);\r
   }\r
 \r
-  LongAtom.LongAtomBits.IsOne1 = 1;\r
-  LongAtom.LongAtomBits.IsOne2 = 1;\r
-  LongAtom.LongAtomBits.IsOne3 = 1;\r
-  LongAtom.LongAtomBits.IsZero = 0;\r
-  LongAtom.LongAtomBits.ByteOrInt = ByteOrInt;\r
+  LongAtom.LongAtomBits.IsOne1     = 1;\r
+  LongAtom.LongAtomBits.IsOne2     = 1;\r
+  LongAtom.LongAtomBits.IsOne3     = 1;\r
+  LongAtom.LongAtomBits.IsZero     = 0;\r
+  LongAtom.LongAtomBits.ByteOrInt  = ByteOrInt;\r
   LongAtom.LongAtomBits.SignOrCont = SignOrCont;\r
-  LongAtom.LongAtomBits.LengthLow = DataSize & 0xFF;\r
-  LongAtom.LongAtomBits.LengthMid = (DataSize >> TCG_LONG_ATOM_LENGTH_MID_SHIFT) & 0xFF;\r
+  LongAtom.LongAtomBits.LengthLow  = DataSize & 0xFF;\r
+  LongAtom.LongAtomBits.LengthMid  = (DataSize >> TCG_LONG_ATOM_LENGTH_MID_SHIFT) & 0xFF;\r
   LongAtom.LongAtomBits.LengthHigh = (DataSize >> TCG_LONG_ATOM_LENGTH_HIGH_SHIFT) & 0xFF;\r
-  return TcgAddRawTokenData(CreateStruct, &LongAtom, sizeof(TCG_SIMPLE_TOKEN_LONG_ATOM), Data, DataSize, ByteOrInt == TCG_ATOM_TYPE_INTEGER);\r
+  return TcgAddRawTokenData (CreateStruct, &LongAtom, sizeof (TCG_SIMPLE_TOKEN_LONG_ATOM), Data, DataSize, ByteOrInt == TCG_ATOM_TYPE_INTEGER);\r
 }\r
 \r
 /**\r
@@ -512,14 +526,14 @@ TcgAddAtom(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddByteSequence(\r
-  TCG_CREATE_STRUCT     *CreateStruct,\r
-  const VOID            *Data,\r
-  UINT32                DataSize,\r
-  BOOLEAN               Continued\r
+TcgAddByteSequence (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  const VOID         *Data,\r
+  UINT32             DataSize,\r
+  BOOLEAN            Continued\r
   )\r
 {\r
-  return TcgAddAtom(CreateStruct, Data, DataSize, TCG_ATOM_TYPE_BYTE, Continued ? 1 : 0);\r
+  return TcgAddAtom (CreateStruct, Data, DataSize, TCG_ATOM_TYPE_BYTE, Continued ? 1 : 0);\r
 }\r
 \r
 /**\r
@@ -535,30 +549,30 @@ TcgAddByteSequence(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddInteger(\r
+TcgAddInteger (\r
   TCG_CREATE_STRUCT  *CreateStruct,\r
   const VOID         *Data,\r
   UINT32             DataSize,\r
   BOOLEAN            SignedInteger\r
   )\r
 {\r
-  const UINT8DataBytes;\r
-  UINT32 ActualDataSize;\r
-  BOOLEAN ValueIsNegative;\r
+  const UINT8  *DataBytes;\r
+  UINT32       ActualDataSize;\r
+  BOOLEAN      ValueIsNegative;\r
 \r
-  NULL_CHECK(CreateStruct);\r
-  NULL_CHECK(Data);\r
+  NULL_CHECK (CreateStruct);\r
+  NULL_CHECK (Data);\r
 \r
   if (DataSize == 0) {\r
     DEBUG ((DEBUG_INFO, "invalid DataSize=0\n"));\r
     return TcgResultFailure;\r
   }\r
 \r
-  DataBytes = (const UINT8*)Data;\r
+  DataBytes = (const UINT8 *)Data;\r
 \r
   // integer should be represented by smallest atom possible\r
   // so calculate real Data Size\r
-  ValueIsNegative = SignedInteger && DataBytes[ DataSize - 1 ] & 0x80;\r
+  ValueIsNegative = SignedInteger && DataBytes[DataSize - 1] & 0x80;\r
 \r
   // assumes native Data is little endian\r
   // shorten Data to smallest byte representation\r
@@ -572,7 +586,7 @@ TcgAddInteger(
     }\r
   }\r
 \r
-  return TcgAddAtom(CreateStruct, Data, ActualDataSize, TCG_ATOM_TYPE_INTEGER, SignedInteger ? 1 : 0);\r
+  return TcgAddAtom (CreateStruct, Data, ActualDataSize, TCG_ATOM_TYPE_INTEGER, SignedInteger ? 1 : 0);\r
 }\r
 \r
 /**\r
@@ -584,12 +598,12 @@ TcgAddInteger(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddUINT8(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT8               Value\r
+TcgAddUINT8 (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT8              Value\r
   )\r
 {\r
-  return TcgAddInteger(CreateStruct, &Value, sizeof(Value), FALSE);\r
+  return TcgAddInteger (CreateStruct, &Value, sizeof (Value), FALSE);\r
 }\r
 \r
 /**\r
@@ -603,11 +617,11 @@ TcgAddUINT8(
 TCG_RESULT\r
 EFIAPI\r
 TcgAddUINT16 (\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT16              Value\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT16             Value\r
   )\r
 {\r
-  return TcgAddInteger(CreateStruct, &Value, sizeof(Value), FALSE);\r
+  return TcgAddInteger (CreateStruct, &Value, sizeof (Value), FALSE);\r
 }\r
 \r
 /**\r
@@ -620,15 +634,14 @@ TcgAddUINT16 (
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddUINT32(\r
-  TCG_CREATE_STRUCT    *CreateStruct,\r
-  UINT32               Value\r
+TcgAddUINT32 (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             Value\r
   )\r
 {\r
-  return TcgAddInteger(CreateStruct, &Value, sizeof(Value), FALSE);\r
+  return TcgAddInteger (CreateStruct, &Value, sizeof (Value), FALSE);\r
 }\r
 \r
-\r
 /**\r
 \r
   Adds a 64-bit unsigned integer to the Data structure.\r
@@ -639,12 +652,12 @@ TcgAddUINT32(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddUINT64(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT64              Value\r
+TcgAddUINT64 (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT64             Value\r
   )\r
 {\r
-  return TcgAddInteger(CreateStruct, &Value, sizeof(Value), FALSE);\r
+  return TcgAddInteger (CreateStruct, &Value, sizeof (Value), FALSE);\r
 }\r
 \r
 /**\r
@@ -656,12 +669,12 @@ TcgAddUINT64(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddBOOLEAN(\r
-  TCG_CREATE_STRUCT    *CreateStruct,\r
-  BOOLEAN              Value\r
+TcgAddBOOLEAN (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  BOOLEAN            Value\r
   )\r
 {\r
-  return TcgAddInteger(CreateStruct, &Value, sizeof(Value), FALSE);\r
+  return TcgAddInteger (CreateStruct, &Value, sizeof (Value), FALSE);\r
 }\r
 \r
 /**\r
@@ -675,12 +688,12 @@ TcgAddBOOLEAN(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddTcgUid(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  TCG_UID             Uid\r
+TcgAddTcgUid (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  TCG_UID            Uid\r
   )\r
 {\r
-  return TcgAddByteSequence(CreateStruct, &Uid, sizeof(TCG_UID), FALSE);\r
+  return TcgAddByteSequence (CreateStruct, &Uid, sizeof (TCG_UID), FALSE);\r
 }\r
 \r
 /**\r
@@ -693,11 +706,11 @@ TcgAddTcgUid(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddStartList(\r
-  TCG_CREATE_STRUCT          *CreateStruct\r
+TcgAddStartList (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_STARTLIST);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_STARTLIST);\r
 }\r
 \r
 /**\r
@@ -710,11 +723,11 @@ TcgAddStartList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndList(\r
-  TCG_CREATE_STRUCT       *CreateStruct\r
+TcgAddEndList (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_ENDLIST);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_ENDLIST);\r
 }\r
 \r
 /**\r
@@ -727,11 +740,11 @@ TcgAddEndList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddStartName(\r
-  TCG_CREATE_STRUCT          *CreateStruct\r
+TcgAddStartName (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_STARTNAME);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_STARTNAME);\r
 }\r
 \r
 /**\r
@@ -744,11 +757,11 @@ TcgAddStartName(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndName(\r
-  TCG_CREATE_STRUCT          *CreateStruct\r
+TcgAddEndName (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_ENDNAME);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_ENDNAME);\r
 }\r
 \r
 /**\r
@@ -761,11 +774,11 @@ TcgAddEndName(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddCall(\r
-  TCG_CREATE_STRUCT      *CreateStruct\r
+TcgAddCall (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_CALL);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_CALL);\r
 }\r
 \r
 /**\r
@@ -778,11 +791,11 @@ TcgAddCall(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndOfData(\r
-  TCG_CREATE_STRUCT          *CreateStruct\r
+TcgAddEndOfData (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_ENDDATA);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_ENDDATA);\r
 }\r
 \r
 /**\r
@@ -795,11 +808,11 @@ TcgAddEndOfData(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndOfSession(\r
-  TCG_CREATE_STRUCT              *CreateStruct\r
+TcgAddEndOfSession (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_ENDSESSION);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_ENDSESSION);\r
 }\r
 \r
 /**\r
@@ -812,11 +825,11 @@ TcgAddEndOfSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddStartTransaction(\r
-  TCG_CREATE_STRUCT             *CreateStruct\r
+TcgAddStartTransaction (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_STARTTRANSACTION);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_STARTTRANSACTION);\r
 }\r
 \r
 /**\r
@@ -829,11 +842,11 @@ TcgAddStartTransaction(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgAddEndTransaction(\r
-  TCG_CREATE_STRUCT           *CreateStruct\r
+TcgAddEndTransaction (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  return TcgAddRawByte(CreateStruct, TCG_TOKEN_ENDTRANSACTION);\r
+  return TcgAddRawByte (CreateStruct, TCG_TOKEN_ENDTRANSACTION);\r
 }\r
 \r
 /**\r
@@ -848,59 +861,60 @@ TcgAddEndTransaction(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgInitTcgParseStruct(\r
-  TCG_PARSE_STRUCT          *ParseStruct,\r
-  const VOID                *Buffer,\r
-  UINT32                    BufferSize\r
+TcgInitTcgParseStruct (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  const VOID        *Buffer,\r
+  UINT32            BufferSize\r
   )\r
 {\r
-  UINT32 ComPacketLength;\r
-  UINT32 PacketLength;\r
+  UINT32  ComPacketLength;\r
+  UINT32  PacketLength;\r
 \r
-  NULL_CHECK(ParseStruct);\r
-  NULL_CHECK(Buffer);\r
+  NULL_CHECK (ParseStruct);\r
+  NULL_CHECK (Buffer);\r
 \r
-  if (BufferSize < sizeof(TCG_COM_PACKET)) {\r
+  if (BufferSize < sizeof (TCG_COM_PACKET)) {\r
     return (TcgResultFailureBufferTooSmall);\r
   }\r
 \r
-  ParseStruct->ComPacket = (TCG_COM_PACKET*)Buffer;\r
+  ParseStruct->ComPacket = (TCG_COM_PACKET *)Buffer;\r
 \r
-  ComPacketLength = SwapBytes32(ParseStruct->ComPacket->LengthBE);\r
+  ComPacketLength = SwapBytes32 (ParseStruct->ComPacket->LengthBE);\r
 \r
-  if ((BufferSize - sizeof(TCG_COM_PACKET)) < ComPacketLength) {\r
+  if ((BufferSize - sizeof (TCG_COM_PACKET)) < ComPacketLength) {\r
     DEBUG ((DEBUG_INFO, "Buffer %u too small for ComPacket %u\n", BufferSize, ComPacketLength));\r
     return (TcgResultFailureBufferTooSmall);\r
   }\r
 \r
   ParseStruct->BufferSize = BufferSize;\r
-  ParseStruct->Buffer = Buffer;\r
+  ParseStruct->Buffer     = Buffer;\r
 \r
-  ParseStruct->CurPacket = NULL;\r
+  ParseStruct->CurPacket    = NULL;\r
   ParseStruct->CurSubPacket = NULL;\r
-  ParseStruct->CurPtr = NULL;\r
+  ParseStruct->CurPtr       = NULL;\r
 \r
   // if payload > 0, then must have a packet\r
   if (ComPacketLength != 0) {\r
-    if (ComPacketLength < sizeof(TCG_PACKET)) {\r
+    if (ComPacketLength < sizeof (TCG_PACKET)) {\r
       DEBUG ((DEBUG_INFO, "ComPacket too small for Packet\n"));\r
       return (TcgResultFailureBufferTooSmall);\r
     }\r
-    ParseStruct->CurPacket = (TCG_PACKET*)ParseStruct->ComPacket->Payload;\r
 \r
-    PacketLength = SwapBytes32(ParseStruct->CurPacket->LengthBE);\r
+    ParseStruct->CurPacket = (TCG_PACKET *)ParseStruct->ComPacket->Payload;\r
+\r
+    PacketLength = SwapBytes32 (ParseStruct->CurPacket->LengthBE);\r
 \r
     if (PacketLength > 0) {\r
-      if (PacketLength < sizeof(TCG_SUB_PACKET)) {\r
-          DEBUG ((DEBUG_INFO, "Packet too small for SubPacket\n"));\r
-          return (TcgResultFailureBufferTooSmall);\r
+      if (PacketLength < sizeof (TCG_SUB_PACKET)) {\r
+        DEBUG ((DEBUG_INFO, "Packet too small for SubPacket\n"));\r
+        return (TcgResultFailureBufferTooSmall);\r
       }\r
 \r
-      ParseStruct->CurSubPacket = (TCG_SUB_PACKET*)ParseStruct->CurPacket->Payload;\r
+      ParseStruct->CurSubPacket = (TCG_SUB_PACKET *)ParseStruct->CurPacket->Payload;\r
     }\r
   }\r
 \r
-  //TODO should check for method status list at this point?\r
+  // TODO should check for method status list at this point?\r
 \r
   return (TcgResultSuccess);\r
 }\r
@@ -916,25 +930,26 @@ TcgInitTcgParseStruct(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextToken(\r
-  TCG_PARSE_STRUCT      *ParseStruct,\r
-  TCG_TOKEN             *TcgToken\r
+TcgGetNextToken (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  TCG_TOKEN         *TcgToken\r
   )\r
 {\r
-  const UINT8* EndOfSubPacket;\r
-  UINT8* TokenEnd;\r
-  UINT8 Hdr;\r
-  TCG_SIMPLE_TOKEN_SHORT_ATOM* TmpShort;\r
-  const TCG_SIMPLE_TOKEN_MEDIUM_ATOM* TmpMed;\r
-  const TCG_SIMPLE_TOKEN_LONG_ATOM* TmpLong;\r
-\r
-  NULL_CHECK(ParseStruct);\r
-  NULL_CHECK(TcgToken);\r
-\r
-  if (ParseStruct->ComPacket == NULL ||\r
-      ParseStruct->CurPacket == NULL ||\r
-      ParseStruct->CurSubPacket == NULL\r
-     ) {\r
+  const UINT8                         *EndOfSubPacket;\r
+  UINT8                               *TokenEnd;\r
+  UINT8                               Hdr;\r
+  TCG_SIMPLE_TOKEN_SHORT_ATOM         *TmpShort;\r
+  const TCG_SIMPLE_TOKEN_MEDIUM_ATOM  *TmpMed;\r
+  const TCG_SIMPLE_TOKEN_LONG_ATOM    *TmpLong;\r
+\r
+  NULL_CHECK (ParseStruct);\r
+  NULL_CHECK (TcgToken);\r
+\r
+  if ((ParseStruct->ComPacket == NULL) ||\r
+      (ParseStruct->CurPacket == NULL) ||\r
+      (ParseStruct->CurSubPacket == NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", ParseStruct->ComPacket, ParseStruct->CurPacket, ParseStruct->CurSubPacket));\r
     return TcgResultFailureInvalidAction;\r
   }\r
@@ -944,8 +959,8 @@ TcgGetNextToken(
     ParseStruct->CurPtr = ParseStruct->CurSubPacket->Payload;\r
   }\r
 \r
-  EndOfSubPacket = ParseStruct->CurSubPacket->Payload + SwapBytes32(ParseStruct->CurSubPacket->LengthBE);\r
-  TokenEnd = NULL;\r
+  EndOfSubPacket = ParseStruct->CurSubPacket->Payload + SwapBytes32 (ParseStruct->CurSubPacket->LengthBE);\r
+  TokenEnd       = NULL;\r
 \r
   // confirmed that subpacket Length falls within end of Buffer and TCG_COM_PACKET,\r
   // so simply need to verify the loop stays within current subpacket\r
@@ -954,7 +969,7 @@ TcgGetNextToken(
     return (TcgResultFailureEndBuffer);\r
   }\r
 \r
-  Hdr = *ParseStruct->CurPtr;\r
+  Hdr                = *ParseStruct->CurPtr;\r
   TcgToken->HdrStart = ParseStruct->CurPtr;\r
 \r
   // Tiny Atom range\r
@@ -962,7 +977,7 @@ TcgGetNextToken(
     // tiny atom Header is only 1 byte, so don't need to verify Size before cast and access\r
     TcgToken->Type = TcgTokenTypeTinyAtom;\r
 \r
-    TokenEnd = TcgToken->HdrStart + sizeof(TCG_SIMPLE_TOKEN_TINY_ATOM);\r
+    TokenEnd = TcgToken->HdrStart + sizeof (TCG_SIMPLE_TOKEN_TINY_ATOM);\r
 \r
     // verify caller will have enough Size to reference token\r
     if (TokenEnd >= EndOfSubPacket) {\r
@@ -971,12 +986,12 @@ TcgGetNextToken(
     }\r
   }\r
   // Short Atom Range\r
-  else if (0x80 <= Hdr && Hdr <= 0xBF) {\r
+  else if ((0x80 <= Hdr) && (Hdr <= 0xBF)) {\r
     // short atom Header is only 1 byte, so don't need to verify Size before cast and access\r
-    TmpShort = (TCG_SIMPLE_TOKEN_SHORT_ATOM*)(ParseStruct->CurPtr);\r
+    TmpShort       = (TCG_SIMPLE_TOKEN_SHORT_ATOM *)(ParseStruct->CurPtr);\r
     TcgToken->Type = TcgTokenTypeShortAtom;\r
 \r
-    TokenEnd = (TcgToken->HdrStart + sizeof(TCG_SIMPLE_TOKEN_SHORT_ATOM) + TmpShort->ShortAtomBits.Length);\r
+    TokenEnd = (TcgToken->HdrStart + sizeof (TCG_SIMPLE_TOKEN_SHORT_ATOM) + TmpShort->ShortAtomBits.Length);\r
 \r
     // verify caller will have enough Size to reference token\r
     if (TokenEnd >= EndOfSubPacket) {\r
@@ -985,15 +1000,16 @@ TcgGetNextToken(
     }\r
   }\r
   // Medium Atom Range\r
-  else if (0xC0 <= Hdr && Hdr <= 0xDF) {\r
-    if (TcgToken->HdrStart + sizeof(TCG_SIMPLE_TOKEN_MEDIUM_ATOM) >= EndOfSubPacket) {\r
+  else if ((0xC0 <= Hdr) && (Hdr <= 0xDF)) {\r
+    if (TcgToken->HdrStart + sizeof (TCG_SIMPLE_TOKEN_MEDIUM_ATOM) >= EndOfSubPacket) {\r
       return (TcgResultFailureEndBuffer);\r
     }\r
-    TmpMed = (const TCG_SIMPLE_TOKEN_MEDIUM_ATOM*)ParseStruct->CurPtr;\r
+\r
+    TmpMed         = (const TCG_SIMPLE_TOKEN_MEDIUM_ATOM *)ParseStruct->CurPtr;\r
     TcgToken->Type = TcgTokenTypeMediumAtom;\r
-    TokenEnd = TcgToken->HdrStart + sizeof(TCG_SIMPLE_TOKEN_MEDIUM_ATOM) +\r
-               ((TmpMed->MediumAtomBits.LengthHigh << TCG_MEDIUM_ATOM_LENGTH_HIGH_SHIFT) |\r
-                TmpMed->MediumAtomBits.LengthLow);\r
+    TokenEnd       = TcgToken->HdrStart + sizeof (TCG_SIMPLE_TOKEN_MEDIUM_ATOM) +\r
+                     ((TmpMed->MediumAtomBits.LengthHigh << TCG_MEDIUM_ATOM_LENGTH_HIGH_SHIFT) |\r
+                      TmpMed->MediumAtomBits.LengthLow);\r
 \r
     // verify caller will have enough Size to reference token\r
     if (TokenEnd >= EndOfSubPacket) {\r
@@ -1002,14 +1018,15 @@ TcgGetNextToken(
     }\r
   }\r
   // Long Atom Range\r
-  else if (0xE0 <= Hdr && Hdr <= 0xE3) {\r
-    if (TcgToken->HdrStart + sizeof(TCG_SIMPLE_TOKEN_LONG_ATOM) >= EndOfSubPacket) {\r
+  else if ((0xE0 <= Hdr) && (Hdr <= 0xE3)) {\r
+    if (TcgToken->HdrStart + sizeof (TCG_SIMPLE_TOKEN_LONG_ATOM) >= EndOfSubPacket) {\r
       return (TcgResultFailureEndBuffer);\r
     }\r
-    TmpLong = (const TCG_SIMPLE_TOKEN_LONG_ATOM*)ParseStruct->CurPtr;\r
+\r
+    TmpLong        = (const TCG_SIMPLE_TOKEN_LONG_ATOM *)ParseStruct->CurPtr;\r
     TcgToken->Type = TcgTokenTypeLongAtom;\r
 \r
-    TokenEnd = TcgToken->HdrStart + sizeof(TCG_SIMPLE_TOKEN_LONG_ATOM) +\r
+    TokenEnd = TcgToken->HdrStart + sizeof (TCG_SIMPLE_TOKEN_LONG_ATOM) +\r
                ((TmpLong->LongAtomBits.LengthHigh << TCG_LONG_ATOM_LENGTH_HIGH_SHIFT) |\r
                 (TmpLong->LongAtomBits.LengthMid << TCG_LONG_ATOM_LENGTH_MID_SHIFT)   |\r
                 TmpLong->LongAtomBits.LengthLow);\r
@@ -1023,40 +1040,41 @@ TcgGetNextToken(
     // single byte tokens\r
     switch (Hdr) {\r
       case TCG_TOKEN_STARTLIST:\r
-          TcgToken->Type = TcgTokenTypeStartList;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeStartList;\r
+        break;\r
       case TCG_TOKEN_ENDLIST:\r
-          TcgToken->Type = TcgTokenTypeEndList;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeEndList;\r
+        break;\r
       case TCG_TOKEN_STARTNAME:\r
-          TcgToken->Type = TcgTokenTypeStartName;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeStartName;\r
+        break;\r
       case TCG_TOKEN_ENDNAME:\r
-          TcgToken->Type = TcgTokenTypeEndName;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeEndName;\r
+        break;\r
       case TCG_TOKEN_CALL:\r
-          TcgToken->Type = TcgTokenTypeCall;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeCall;\r
+        break;\r
       case TCG_TOKEN_ENDDATA:\r
-          TcgToken->Type = TcgTokenTypeEndOfData;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeEndOfData;\r
+        break;\r
       case TCG_TOKEN_ENDSESSION:\r
-          TcgToken->Type = TcgTokenTypeEndOfSession;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeEndOfSession;\r
+        break;\r
       case TCG_TOKEN_STARTTRANSACTION:\r
-          TcgToken->Type = TcgTokenTypeStartTransaction;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeStartTransaction;\r
+        break;\r
       case TCG_TOKEN_ENDTRANSACTION:\r
-          TcgToken->Type = TcgTokenTypeEndTransaction;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeEndTransaction;\r
+        break;\r
       case TCG_TOKEN_EMPTY:\r
-          TcgToken->Type = TcgTokenTypeEmptyAtom;\r
-          break;\r
+        TcgToken->Type = TcgTokenTypeEmptyAtom;\r
+        break;\r
       default:\r
-          DEBUG ((DEBUG_INFO, "WARNING: reserved token Type 0x%02X\n", Hdr));\r
-          TcgToken->Type = TcgTokenTypeReserved;\r
-          break;\r
+        DEBUG ((DEBUG_INFO, "WARNING: reserved token Type 0x%02X\n", Hdr));\r
+        TcgToken->Type = TcgTokenTypeReserved;\r
+        break;\r
     }\r
+\r
     ParseStruct->CurPtr++;\r
     TokenEnd = TcgToken->HdrStart + 1;\r
   }\r
@@ -1080,61 +1098,65 @@ TcgGetNextToken(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetAtomInfo(\r
-  const TCG_TOKEN      *TcgToken,\r
-  UINT32               *HeaderLength,\r
-  UINT32               *DataLength,\r
-  UINT8                *ByteOrInt,\r
-  UINT8                *SignOrCont\r
+TcgGetAtomInfo (\r
+  const TCG_TOKEN  *TcgToken,\r
+  UINT32           *HeaderLength,\r
+  UINT32           *DataLength,\r
+  UINT8            *ByteOrInt,\r
+  UINT8            *SignOrCont\r
   )\r
 {\r
-  TCG_SIMPLE_TOKEN_TINY_ATOMTinyAtom;\r
-  TCG_SIMPLE_TOKEN_SHORT_ATOMShortAtom;\r
-  TCG_SIMPLE_TOKEN_MEDIUM_ATOMMediumAtom;\r
-  TCG_SIMPLE_TOKEN_LONG_ATOMLongAtom;\r
+  TCG_SIMPLE_TOKEN_TINY_ATOM    *TinyAtom;\r
+  TCG_SIMPLE_TOKEN_SHORT_ATOM   *ShortAtom;\r
+  TCG_SIMPLE_TOKEN_MEDIUM_ATOM  *MediumAtom;\r
+  TCG_SIMPLE_TOKEN_LONG_ATOM    *LongAtom;\r
 \r
-  NULL_CHECK(TcgToken);\r
-  NULL_CHECK(HeaderLength);\r
-  NULL_CHECK(DataLength);\r
-  NULL_CHECK(ByteOrInt);\r
-  NULL_CHECK(SignOrCont);\r
+  NULL_CHECK (TcgToken);\r
+  NULL_CHECK (HeaderLength);\r
+  NULL_CHECK (DataLength);\r
+  NULL_CHECK (ByteOrInt);\r
+  NULL_CHECK (SignOrCont);\r
 \r
   switch (TcgToken->Type) {\r
-    case TcgTokenTypeTinyAtom: {\r
-      TinyAtom = (TCG_SIMPLE_TOKEN_TINY_ATOM*)TcgToken->HdrStart;\r
-      *ByteOrInt      = TCG_ATOM_TYPE_INTEGER;\r
-      *SignOrCont     = TinyAtom->TinyAtomBits.Sign;\r
-      *HeaderLength   = 0;\r
-      *DataLength     = 0; // tiny atom must be handled as a special case - Header and Data in the same byte\r
+    case TcgTokenTypeTinyAtom:\r
+    {\r
+      TinyAtom      = (TCG_SIMPLE_TOKEN_TINY_ATOM *)TcgToken->HdrStart;\r
+      *ByteOrInt    = TCG_ATOM_TYPE_INTEGER;\r
+      *SignOrCont   = TinyAtom->TinyAtomBits.Sign;\r
+      *HeaderLength = 0;\r
+      *DataLength   = 0;   // tiny atom must be handled as a special case - Header and Data in the same byte\r
       return TcgResultSuccess;\r
     }\r
 \r
-    case TcgTokenTypeShortAtom: {\r
-      ShortAtom = (TCG_SIMPLE_TOKEN_SHORT_ATOM*)TcgToken->HdrStart;\r
-      *ByteOrInt      = ShortAtom->ShortAtomBits.ByteOrInt;\r
-      *SignOrCont     = ShortAtom->ShortAtomBits.SignOrCont;\r
-      *HeaderLength   = sizeof(TCG_SIMPLE_TOKEN_SHORT_ATOM);\r
-      *DataLength     = ShortAtom->ShortAtomBits.Length;\r
+    case TcgTokenTypeShortAtom:\r
+    {\r
+      ShortAtom     = (TCG_SIMPLE_TOKEN_SHORT_ATOM *)TcgToken->HdrStart;\r
+      *ByteOrInt    = ShortAtom->ShortAtomBits.ByteOrInt;\r
+      *SignOrCont   = ShortAtom->ShortAtomBits.SignOrCont;\r
+      *HeaderLength = sizeof (TCG_SIMPLE_TOKEN_SHORT_ATOM);\r
+      *DataLength   = ShortAtom->ShortAtomBits.Length;\r
       return TcgResultSuccess;\r
     }\r
 \r
-    case TcgTokenTypeMediumAtom: {\r
-      MediumAtom = (TCG_SIMPLE_TOKEN_MEDIUM_ATOM*)TcgToken->HdrStart;\r
-      *ByteOrInt      = MediumAtom->MediumAtomBits.ByteOrInt;\r
-      *SignOrCont     = MediumAtom->MediumAtomBits.SignOrCont;\r
-      *HeaderLength   = sizeof(TCG_SIMPLE_TOKEN_MEDIUM_ATOM);\r
-      *DataLength     = (MediumAtom->MediumAtomBits.LengthHigh << TCG_MEDIUM_ATOM_LENGTH_HIGH_SHIFT) | MediumAtom->MediumAtomBits.LengthLow;\r
+    case TcgTokenTypeMediumAtom:\r
+    {\r
+      MediumAtom    = (TCG_SIMPLE_TOKEN_MEDIUM_ATOM *)TcgToken->HdrStart;\r
+      *ByteOrInt    = MediumAtom->MediumAtomBits.ByteOrInt;\r
+      *SignOrCont   = MediumAtom->MediumAtomBits.SignOrCont;\r
+      *HeaderLength = sizeof (TCG_SIMPLE_TOKEN_MEDIUM_ATOM);\r
+      *DataLength   = (MediumAtom->MediumAtomBits.LengthHigh << TCG_MEDIUM_ATOM_LENGTH_HIGH_SHIFT) | MediumAtom->MediumAtomBits.LengthLow;\r
       return TcgResultSuccess;\r
     }\r
 \r
-    case TcgTokenTypeLongAtom: {\r
-      LongAtom = (TCG_SIMPLE_TOKEN_LONG_ATOM*)TcgToken->HdrStart;\r
-      *ByteOrInt      = LongAtom->LongAtomBits.ByteOrInt;\r
-      *SignOrCont     = LongAtom->LongAtomBits.SignOrCont;\r
-      *HeaderLength   = sizeof(TCG_SIMPLE_TOKEN_LONG_ATOM);\r
-      *DataLength     = (LongAtom->LongAtomBits.LengthHigh << TCG_LONG_ATOM_LENGTH_HIGH_SHIFT) |\r
-                        (LongAtom->LongAtomBits.LengthMid << TCG_LONG_ATOM_LENGTH_MID_SHIFT) |\r
-                        LongAtom->LongAtomBits.LengthLow;\r
+    case TcgTokenTypeLongAtom:\r
+    {\r
+      LongAtom      = (TCG_SIMPLE_TOKEN_LONG_ATOM *)TcgToken->HdrStart;\r
+      *ByteOrInt    = LongAtom->LongAtomBits.ByteOrInt;\r
+      *SignOrCont   = LongAtom->LongAtomBits.SignOrCont;\r
+      *HeaderLength = sizeof (TCG_SIMPLE_TOKEN_LONG_ATOM);\r
+      *DataLength   = (LongAtom->LongAtomBits.LengthHigh << TCG_LONG_ATOM_LENGTH_HIGH_SHIFT) |\r
+                      (LongAtom->LongAtomBits.LengthMid << TCG_LONG_ATOM_LENGTH_MID_SHIFT) |\r
+                      LongAtom->LongAtomBits.LengthLow;\r
       return TcgResultSuccess;\r
     }\r
 \r
@@ -1155,25 +1177,25 @@ TcgGetAtomInfo(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetTokenUINT64(\r
-  const TCG_TOKEN      *TcgToken,\r
-  UINT64               *Value\r
+TcgGetTokenUINT64 (\r
+  const TCG_TOKEN  *TcgToken,\r
+  UINT64           *Value\r
   )\r
 {\r
-  UINT32 HdrLength;\r
-  UINT32 DataLength;\r
-  UINT8 ByteOrInt;\r
-  UINT8 IsSigned;\r
-  TCG_SIMPLE_TOKEN_TINY_ATOMTmpTiny;\r
-  const UINT8Data;\r
-  UINT32 Index;\r
-\r
-  NULL_CHECK(TcgToken);\r
-  NULL_CHECK(Value);\r
-\r
-  Index = 0;\r
+  UINT32                      HdrLength;\r
+  UINT32                      DataLength;\r
+  UINT8                       ByteOrInt;\r
+  UINT8                       IsSigned;\r
+  TCG_SIMPLE_TOKEN_TINY_ATOM  *TmpTiny;\r
+  const UINT8                 *Data;\r
+  UINT32                      Index;\r
+\r
+  NULL_CHECK (TcgToken);\r
+  NULL_CHECK (Value);\r
+\r
+  Index  = 0;\r
   *Value = 0;\r
-  ERROR_CHECK(TcgGetAtomInfo(TcgToken, &HdrLength, &DataLength, &ByteOrInt, &IsSigned));\r
+  ERROR_CHECK (TcgGetAtomInfo (TcgToken, &HdrLength, &DataLength, &ByteOrInt, &IsSigned));\r
 \r
   if (ByteOrInt != TCG_ATOM_TYPE_INTEGER) {\r
     DEBUG ((DEBUG_INFO, "Invalid Type, expected integer not byte sequence\n"));\r
@@ -1188,12 +1210,12 @@ TcgGetTokenUINT64(
   // special case for tiny atom\r
   // Header and Data are in one byte, so extract only the Data bitfield\r
   if (TcgToken->Type == TcgTokenTypeTinyAtom) {\r
-    TmpTiny = (TCG_SIMPLE_TOKEN_TINY_ATOM*)TcgToken->HdrStart;\r
-    *Value = TmpTiny->TinyAtomBits.Data;\r
+    TmpTiny = (TCG_SIMPLE_TOKEN_TINY_ATOM *)TcgToken->HdrStart;\r
+    *Value  = TmpTiny->TinyAtomBits.Data;\r
     return TcgResultSuccess;\r
   }\r
 \r
-  if (DataLength > sizeof(UINT64)) {\r
+  if (DataLength > sizeof (UINT64)) {\r
     DEBUG ((DEBUG_INFO, "Length %d is greater than Size of UINT64\n", DataLength));\r
     return TcgResultFailureBufferTooSmall;\r
   }\r
@@ -1201,7 +1223,7 @@ TcgGetTokenUINT64(
   // read big-endian integer\r
   Data = TcgToken->HdrStart + HdrLength;\r
   for (Index = 0; Index < DataLength; Index++) {\r
-    *Value = LShiftU64(*Value, 8) | Data[Index];\r
+    *Value = LShiftU64 (*Value, 8) | Data[Index];\r
   }\r
 \r
   return TcgResultSuccess;\r
@@ -1216,23 +1238,23 @@ TcgGetTokenUINT64(
   @retval   Return the value data.\r
 \r
 **/\r
-UINT8*\r
+UINT8 *\r
 EFIAPI\r
-TcgGetTokenByteSequence(\r
-  const TCG_TOKEN     *TcgToken,\r
-  UINT32              *Length\r
+TcgGetTokenByteSequence (\r
+  const TCG_TOKEN  *TcgToken,\r
+  UINT32           *Length\r
   )\r
 {\r
-  UINT32 HdrLength;\r
-  UINT8 ByteOrInt;\r
-  UINT8 SignOrCont;\r
+  UINT32  HdrLength;\r
+  UINT8   ByteOrInt;\r
+  UINT8   SignOrCont;\r
 \r
-  if (TcgToken == NULL || Length == NULL) {\r
+  if ((TcgToken == NULL) || (Length == NULL)) {\r
     return NULL;\r
   }\r
 \r
   *Length = 0;\r
-  if (TcgGetAtomInfo(TcgToken, &HdrLength, Length, &ByteOrInt, &SignOrCont) != TcgResultSuccess) {\r
+  if (TcgGetAtomInfo (TcgToken, &HdrLength, Length, &ByteOrInt, &SignOrCont) != TcgResultSuccess) {\r
     DEBUG ((DEBUG_INFO, "Failed to get simple token info\n"));\r
     return NULL;\r
   }\r
@@ -1256,18 +1278,18 @@ TcgGetTokenByteSequence(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextUINT8(\r
-  TCG_PARSE_STRUCT      *ParseStruct,\r
-  UINT8                 *Value\r
+TcgGetNextUINT8 (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT8             *Value\r
   )\r
 {\r
-  UINT64 Value64;\r
-  TCG_TOKEN Tok;\r
+  UINT64     Value64;\r
+  TCG_TOKEN  Tok;\r
 \r
-  NULL_CHECK(Value);\r
+  NULL_CHECK (Value);\r
 \r
-  ERROR_CHECK(TcgGetNextToken(ParseStruct, &Tok));\r
-  ERROR_CHECK(TcgGetTokenUINT64(&Tok, &Value64));\r
+  ERROR_CHECK (TcgGetNextToken (ParseStruct, &Tok));\r
+  ERROR_CHECK (TcgGetTokenUINT64 (&Tok, &Value64));\r
 \r
   if (Value64 > MAX_UINT8) {\r
     return TcgResultFailure;\r
@@ -1289,18 +1311,18 @@ TcgGetNextUINT8(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextUINT16(\r
-  TCG_PARSE_STRUCT     *ParseStruct,\r
-  UINT16               *Value\r
+TcgGetNextUINT16 (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT16            *Value\r
   )\r
 {\r
-  UINT64 Value64;\r
-  TCG_TOKEN Tok;\r
+  UINT64     Value64;\r
+  TCG_TOKEN  Tok;\r
 \r
-  NULL_CHECK(Value);\r
+  NULL_CHECK (Value);\r
 \r
-  ERROR_CHECK(TcgGetNextToken(ParseStruct, &Tok));\r
-  ERROR_CHECK(TcgGetTokenUINT64(&Tok, &Value64));\r
+  ERROR_CHECK (TcgGetNextToken (ParseStruct, &Tok));\r
+  ERROR_CHECK (TcgGetTokenUINT64 (&Tok, &Value64));\r
 \r
   if (Value64 > MAX_UINT16) {\r
     return TcgResultFailure;\r
@@ -1322,18 +1344,18 @@ TcgGetNextUINT16(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextUINT32(\r
-  TCG_PARSE_STRUCT          *ParseStruct,\r
-  UINT32                    *Value\r
+TcgGetNextUINT32 (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT32            *Value\r
   )\r
 {\r
-  UINT64 Value64;\r
-  TCG_TOKEN Tok;\r
+  UINT64     Value64;\r
+  TCG_TOKEN  Tok;\r
 \r
-  NULL_CHECK(Value);\r
+  NULL_CHECK (Value);\r
 \r
-  ERROR_CHECK(TcgGetNextToken(ParseStruct, &Tok));\r
-  ERROR_CHECK(TcgGetTokenUINT64(&Tok, &Value64));\r
+  ERROR_CHECK (TcgGetNextToken (ParseStruct, &Tok));\r
+  ERROR_CHECK (TcgGetTokenUINT64 (&Tok, &Value64));\r
 \r
   if (Value64 > MAX_UINT32) {\r
     return TcgResultFailure;\r
@@ -1355,14 +1377,15 @@ TcgGetNextUINT32(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextUINT64(\r
-  TCG_PARSE_STRUCT           *ParseStruct,\r
-  UINT64                     *Value\r
+TcgGetNextUINT64 (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT64            *Value\r
   )\r
 {\r
-  TCG_TOKEN Tok;\r
-  ERROR_CHECK(TcgGetNextToken(ParseStruct, &Tok));\r
-  ERROR_CHECK(TcgGetTokenUINT64(&Tok, Value));\r
+  TCG_TOKEN  Tok;\r
+\r
+  ERROR_CHECK (TcgGetNextToken (ParseStruct, &Tok));\r
+  ERROR_CHECK (TcgGetTokenUINT64 (&Tok, Value));\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -1377,18 +1400,18 @@ TcgGetNextUINT64(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextBOOLEAN(\r
-  TCG_PARSE_STRUCT        *ParseStruct,\r
-  BOOLEAN                 *Value\r
+TcgGetNextBOOLEAN (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  BOOLEAN           *Value\r
   )\r
 {\r
-  UINT64 Value64;\r
-  TCG_TOKEN Tok;\r
+  UINT64     Value64;\r
+  TCG_TOKEN  Tok;\r
 \r
-  NULL_CHECK(Value);\r
+  NULL_CHECK (Value);\r
 \r
-  ERROR_CHECK(TcgGetNextToken(ParseStruct, &Tok));\r
-  ERROR_CHECK(TcgGetTokenUINT64(&Tok, &Value64));\r
+  ERROR_CHECK (TcgGetNextToken (ParseStruct, &Tok));\r
+  ERROR_CHECK (TcgGetTokenUINT64 (&Tok, &Value64));\r
 \r
   if (Value64 > 1) {\r
     return TcgResultFailure;\r
@@ -1410,28 +1433,28 @@ TcgGetNextBOOLEAN(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextTcgUid(\r
-  TCG_PARSE_STRUCT         *ParseStruct,\r
-  TCG_UID                  *Uid\r
+TcgGetNextTcgUid (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  TCG_UID           *Uid\r
   )\r
 {\r
-  TCG_TOKEN Tok;\r
-  UINT32 Length;\r
-  const UINT8ByteSeq;\r
+  TCG_TOKEN    Tok;\r
+  UINT32       Length;\r
+  const UINT8  *ByteSeq;\r
 \r
-  NULL_CHECK(Uid);\r
+  NULL_CHECK (Uid);\r
 \r
-  ERROR_CHECK(TcgGetNextToken(ParseStruct, &Tok));\r
-  ByteSeq = TcgGetTokenByteSequence(&Tok, &Length);\r
+  ERROR_CHECK (TcgGetNextToken (ParseStruct, &Tok));\r
+  ByteSeq = TcgGetTokenByteSequence (&Tok, &Length);\r
 \r
-  if (Length != sizeof(TCG_UID)) {\r
-    DEBUG ((DEBUG_INFO, "Token Length %u != TCG_UID Size %u\n", Length, (UINT32)sizeof(TCG_UID)));\r
+  if (Length != sizeof (TCG_UID)) {\r
+    DEBUG ((DEBUG_INFO, "Token Length %u != TCG_UID Size %u\n", Length, (UINT32)sizeof (TCG_UID)));\r
     return TcgResultFailure;\r
   }\r
 \r
   ASSERT (ByteSeq != NULL);\r
 \r
-  CopyMem(Uid, ByteSeq, sizeof(TCG_UID));\r
+  CopyMem (Uid, ByteSeq, sizeof (TCG_UID));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -1448,21 +1471,22 @@ TcgGetNextTcgUid(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextByteSequence(\r
-  TCG_PARSE_STRUCT      *ParseStruct,\r
-  const VOID            **Data,\r
-  UINT32                *Length\r
+TcgGetNextByteSequence (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  const VOID        **Data,\r
+  UINT32            *Length\r
   )\r
 {\r
-  TCG_TOKEN Tok;\r
-  const UINT8Bs;\r
+  TCG_TOKEN    Tok;\r
+  const UINT8  *Bs;\r
 \r
-  ERROR_CHECK(TcgGetNextToken(ParseStruct, &Tok));\r
-  Bs = TcgGetTokenByteSequence(&Tok, Length);\r
+  ERROR_CHECK (TcgGetNextToken (ParseStruct, &Tok));\r
+  Bs = TcgGetTokenByteSequence (&Tok, Length);\r
 \r
   if (Bs == NULL) {\r
     return TcgResultFailure;\r
   }\r
+\r
   *Data = Bs;\r
   return TcgResultSuccess;\r
 }\r
@@ -1478,17 +1502,19 @@ TcgGetNextByteSequence(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextTokenType(\r
-  TCG_PARSE_STRUCT        *ParseStruct,\r
-  TCG_TOKEN_TYPE          Type\r
+TcgGetNextTokenType (\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  TCG_TOKEN_TYPE    Type\r
   )\r
 {\r
-  TCG_TOKEN Tok;\r
-  ERROR_CHECK(TcgGetNextToken(ParseStruct, &Tok));\r
+  TCG_TOKEN  Tok;\r
+\r
+  ERROR_CHECK (TcgGetNextToken (ParseStruct, &Tok));\r
   if (Tok.Type != Type) {\r
     DEBUG ((DEBUG_INFO, "expected Type %u, got Type %u\n", Type, Tok.Type));\r
     return TcgResultFailure;\r
   }\r
+\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -1502,11 +1528,11 @@ TcgGetNextTokenType(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextStartList(\r
-  TCG_PARSE_STRUCT          *ParseStruct\r
+TcgGetNextStartList (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeStartList);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeStartList);\r
 }\r
 \r
 /**\r
@@ -1519,11 +1545,11 @@ TcgGetNextStartList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndList(\r
-  TCG_PARSE_STRUCT             *ParseStruct\r
+TcgGetNextEndList (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeEndList);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeEndList);\r
 }\r
 \r
 /**\r
@@ -1536,11 +1562,11 @@ TcgGetNextEndList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextStartName(\r
-  TCG_PARSE_STRUCT              *ParseStruct\r
+TcgGetNextStartName (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeStartName);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeStartName);\r
 }\r
 \r
 /**\r
@@ -1553,11 +1579,11 @@ TcgGetNextStartName(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndName(\r
-  TCG_PARSE_STRUCT               *ParseStruct\r
+TcgGetNextEndName (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeEndName);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeEndName);\r
 }\r
 \r
 /**\r
@@ -1570,11 +1596,11 @@ TcgGetNextEndName(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextCall(\r
-  TCG_PARSE_STRUCT                   *ParseStruct\r
+TcgGetNextCall (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeCall);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeCall);\r
 }\r
 \r
 /**\r
@@ -1587,11 +1613,11 @@ TcgGetNextCall(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndOfData(\r
-  TCG_PARSE_STRUCT                    *ParseStruct\r
+TcgGetNextEndOfData (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeEndOfData);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeEndOfData);\r
 }\r
 \r
 /**\r
@@ -1604,11 +1630,11 @@ TcgGetNextEndOfData(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndOfSession(\r
-  TCG_PARSE_STRUCT                      *ParseStruct\r
+TcgGetNextEndOfSession (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeEndOfSession);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeEndOfSession);\r
 }\r
 \r
 /**\r
@@ -1621,11 +1647,11 @@ TcgGetNextEndOfSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextStartTransaction(\r
-  TCG_PARSE_STRUCT                        *ParseStruct\r
+TcgGetNextStartTransaction (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeStartTransaction);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeStartTransaction);\r
 }\r
 \r
 /**\r
@@ -1638,9 +1664,9 @@ TcgGetNextStartTransaction(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetNextEndTransaction(\r
-  TCG_PARSE_STRUCT                  *ParseStruct\r
+TcgGetNextEndTransaction (\r
+  TCG_PARSE_STRUCT  *ParseStruct\r
   )\r
 {\r
-  return TcgGetNextTokenType(ParseStruct, TcgTokenTypeEndTransaction);\r
+  return TcgGetNextTokenType (ParseStruct, TcgTokenTypeEndTransaction);\r
 }\r
index ff331bfc8ad9f6e4462c93bb336151c7c14ca82d..48f1e6e7bd090ae1c2c91dca9f5253eae5902049 100644 (file)
@@ -13,9 +13,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/DebugLib.h>\r
 \r
 typedef struct {\r
-    UINT16                                FeatureCode;\r
-    TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER  *Feature;\r
-    UINTN                                 FeatureSize;\r
+  UINT16                                  FeatureCode;\r
+  TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER    *Feature;\r
+  UINTN                                   FeatureSize;\r
 } TCG_FIND_FEATURE_CTX;\r
 \r
 /**\r
@@ -26,39 +26,39 @@ typedef struct {
 \r
   @retval   return the string info.\r
 **/\r
-CHAR8*\r
+CHAR8 *\r
 EFIAPI\r
-TcgMethodStatusString(\r
-  UINT8 MethodStatus\r
+TcgMethodStatusString (\r
+  UINT8  MethodStatus\r
   )\r
 {\r
   switch (MethodStatus) {\r
-    #define C(status) case TCG_METHOD_STATUS_CODE_ ## status: return #status\r
-            C(SUCCESS);\r
-            C(NOT_AUTHORIZED);\r
-            C(OBSOLETE);\r
-            C(SP_BUSY);\r
-            C(SP_FAILED);\r
-            C(SP_DISABLED);\r
-            C(SP_FROZEN);\r
-            C(NO_SESSIONS_AVAILABLE);\r
-            C(UNIQUENESS_CONFLICT);\r
-            C(INSUFFICIENT_SPACE);\r
-            C(INSUFFICIENT_ROWS);\r
-            C(INVALID_PARAMETER);\r
-            C(OBSOLETE2);\r
-            C(OBSOLETE3);\r
-            C(TPER_MALFUNCTION);\r
-            C(TRANSACTION_FAILURE);\r
-            C(RESPONSE_OVERFLOW);\r
-            C(AUTHORITY_LOCKED_OUT);\r
-            C(FAIL);\r
+    #define C(status)  case TCG_METHOD_STATUS_CODE_ ## status: return #status\r
+    (SUCCESS);\r
+    (NOT_AUTHORIZED);\r
+    (OBSOLETE);\r
+    (SP_BUSY);\r
+    (SP_FAILED);\r
+    (SP_DISABLED);\r
+    (SP_FROZEN);\r
+    (NO_SESSIONS_AVAILABLE);\r
+    (UNIQUENESS_CONFLICT);\r
+    (INSUFFICIENT_SPACE);\r
+    (INSUFFICIENT_ROWS);\r
+    (INVALID_PARAMETER);\r
+    (OBSOLETE2);\r
+    (OBSOLETE3);\r
+    (TPER_MALFUNCTION);\r
+    (TRANSACTION_FAILURE);\r
+    (RESPONSE_OVERFLOW);\r
+    (AUTHORITY_LOCKED_OUT);\r
+    (FAIL);\r
     #undef C\r
   }\r
+\r
   return "unknown";\r
 }\r
 \r
-\r
 /**\r
   adds call token and method Header (invoking id, and method id).\r
 \r
@@ -69,25 +69,26 @@ TcgMethodStatusString(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartMethodCall(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  TCG_UID             InvokingId,\r
-  TCG_UID             MethodId\r
+TcgStartMethodCall (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  TCG_UID            InvokingId,\r
+  TCG_UID            MethodId\r
   )\r
 {\r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket == NULL ||\r
-      CreateStruct->CurSubPacket == NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket == NULL) ||\r
+      (CreateStruct->CurSubPacket == NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
-  ERROR_CHECK(TcgAddCall(CreateStruct));\r
-  ERROR_CHECK(TcgAddTcgUid(CreateStruct, InvokingId));\r
-  ERROR_CHECK(TcgAddTcgUid(CreateStruct, MethodId));\r
+  ERROR_CHECK (TcgAddCall (CreateStruct));\r
+  ERROR_CHECK (TcgAddTcgUid (CreateStruct, InvokingId));\r
+  ERROR_CHECK (TcgAddTcgUid (CreateStruct, MethodId));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -100,21 +101,22 @@ TcgStartMethodCall(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartParameters(\r
-  TCG_CREATE_STRUCT           *CreateStruct\r
+TcgStartParameters (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket == NULL ||\r
-      CreateStruct->CurSubPacket == NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket == NULL) ||\r
+      (CreateStruct->CurSubPacket == NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
-  return TcgAddStartList(CreateStruct);\r
+  return TcgAddStartList (CreateStruct);\r
 }\r
 \r
 /**\r
@@ -125,21 +127,22 @@ TcgStartParameters(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndParameters(\r
-  TCG_CREATE_STRUCT   *CreateStruct\r
+TcgEndParameters (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket == NULL ||\r
-      CreateStruct->CurSubPacket == NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket == NULL) ||\r
+      (CreateStruct->CurSubPacket == NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
-  return TcgAddEndList(CreateStruct);\r
+  return TcgAddEndList (CreateStruct);\r
 }\r
 \r
 /**\r
@@ -150,27 +153,28 @@ TcgEndParameters(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndMethodCall(\r
-  TCG_CREATE_STRUCT      *CreateStruct\r
+TcgEndMethodCall (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  NULL_CHECK(CreateStruct);\r
+  NULL_CHECK (CreateStruct);\r
 \r
-  if (CreateStruct->ComPacket == NULL ||\r
-      CreateStruct->CurPacket == NULL ||\r
-      CreateStruct->CurSubPacket == NULL\r
-     ) {\r
+  if ((CreateStruct->ComPacket == NULL) ||\r
+      (CreateStruct->CurPacket == NULL) ||\r
+      (CreateStruct->CurSubPacket == NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", CreateStruct->ComPacket, CreateStruct->CurPacket, CreateStruct->CurSubPacket));\r
     return (TcgResultFailureInvalidAction);\r
   }\r
 \r
-  ERROR_CHECK(TcgAddEndOfData(CreateStruct));\r
+  ERROR_CHECK (TcgAddEndOfData (CreateStruct));\r
 \r
-  ERROR_CHECK(TcgAddStartList(CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(CreateStruct, 0x00));   // expected to complete properly\r
-  ERROR_CHECK(TcgAddUINT8(CreateStruct, 0x00));   // reserved\r
-  ERROR_CHECK(TcgAddUINT8(CreateStruct, 0x00));   // reserved\r
-  ERROR_CHECK(TcgAddEndList(CreateStruct));\r
+  ERROR_CHECK (TcgAddStartList (CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (CreateStruct, 0x00));   // expected to complete properly\r
+  ERROR_CHECK (TcgAddUINT8 (CreateStruct, 0x00));   // reserved\r
+  ERROR_CHECK (TcgAddUINT8 (CreateStruct, 0x00));   // reserved\r
+  ERROR_CHECK (TcgAddEndList (CreateStruct));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -186,23 +190,23 @@ TcgEndMethodCall(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetComIds(\r
-  const TCG_PARSE_STRUCT     *ParseStruct,\r
-  UINT16                     *ComId,\r
-  UINT16                     *ComIdExtension\r
+TcgGetComIds (\r
+  const TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT16                  *ComId,\r
+  UINT16                  *ComIdExtension\r
   )\r
 {\r
-  NULL_CHECK(ParseStruct);\r
-  NULL_CHECK(ComId);\r
-  NULL_CHECK(ComIdExtension);\r
+  NULL_CHECK (ParseStruct);\r
+  NULL_CHECK (ComId);\r
+  NULL_CHECK (ComIdExtension);\r
 \r
   if (ParseStruct->ComPacket == NULL) {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p\n", ParseStruct->ComPacket));\r
     return TcgResultFailureInvalidAction;\r
   }\r
 \r
-  *ComId = SwapBytes16(ParseStruct->ComPacket->ComIDBE);\r
-  *ComIdExtension = SwapBytes16(ParseStruct->ComPacket->ComIDExtensionBE);\r
+  *ComId          = SwapBytes16 (ParseStruct->ComPacket->ComIDBE);\r
+  *ComIdExtension = SwapBytes16 (ParseStruct->ComPacket->ComIDExtensionBE);\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -217,21 +221,22 @@ TcgGetComIds(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCheckComIds(\r
-  const TCG_PARSE_STRUCT     *ParseStruct,\r
-  UINT16                     ExpectedComId,\r
-  UINT16                     ExpectedComIdExtension\r
+TcgCheckComIds (\r
+  const TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT16                  ExpectedComId,\r
+  UINT16                  ExpectedComIdExtension\r
   )\r
 {\r
-  UINT16 ParseComId;\r
-  UINT16 ParseComIdExtension;\r
+  UINT16  ParseComId;\r
+  UINT16  ParseComIdExtension;\r
 \r
-  ERROR_CHECK(TcgGetComIds(ParseStruct, &ParseComId, &ParseComIdExtension));\r
-  if (ParseComId != ExpectedComId || ParseComIdExtension != ExpectedComIdExtension) {\r
+  ERROR_CHECK (TcgGetComIds (ParseStruct, &ParseComId, &ParseComIdExtension));\r
+  if ((ParseComId != ExpectedComId) || (ParseComIdExtension != ExpectedComIdExtension)) {\r
     DEBUG ((DEBUG_INFO, "Com ID: Actual 0x%02X Expected 0x%02X\n", ParseComId, ExpectedComId));\r
     DEBUG ((DEBUG_INFO, "Extended Com ID: 0x%02X Expected 0x%02X\n", ParseComIdExtension, ExpectedComIdExtension));\r
     return TcgResultFailure;\r
   }\r
+\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -245,42 +250,43 @@ TcgCheckComIds(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgGetMethodStatus(\r
-  const TCG_PARSE_STRUCT            *ParseStruct,\r
-  UINT8                             *MethodStatus\r
+TcgGetMethodStatus (\r
+  const TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT8                   *MethodStatus\r
   )\r
 {\r
-  TCG_PARSE_STRUCT TmpParseStruct;\r
-  TCG_TOKEN TcgToken;\r
-  UINT8 Reserved1, Reserved2;\r
-\r
-  NULL_CHECK(ParseStruct);\r
-  NULL_CHECK(MethodStatus);\r
-\r
-  if (ParseStruct->ComPacket == NULL ||\r
-      ParseStruct->CurPacket == NULL ||\r
-      ParseStruct->CurSubPacket == NULL\r
-     ) {\r
+  TCG_PARSE_STRUCT  TmpParseStruct;\r
+  TCG_TOKEN         TcgToken;\r
+  UINT8             Reserved1, Reserved2;\r
+\r
+  NULL_CHECK (ParseStruct);\r
+  NULL_CHECK (MethodStatus);\r
+\r
+  if ((ParseStruct->ComPacket == NULL) ||\r
+      (ParseStruct->CurPacket == NULL) ||\r
+      (ParseStruct->CurSubPacket == NULL)\r
+      )\r
+  {\r
     DEBUG ((DEBUG_INFO, "unexpected state: ComPacket=%p CurPacket=%p CurSubPacket=%p\n", ParseStruct->ComPacket, ParseStruct->CurPacket, ParseStruct->CurSubPacket));\r
     return TcgResultFailureInvalidAction;\r
   }\r
 \r
   // duplicate ParseStruct, then don't need to "reset" location cur ptr\r
-  CopyMem (&TmpParseStruct, ParseStruct, sizeof(TCG_PARSE_STRUCT));\r
+  CopyMem (&TmpParseStruct, ParseStruct, sizeof (TCG_PARSE_STRUCT));\r
 \r
   // method status list exists after the end method call in the subpacket\r
   // skip tokens until ENDDATA is found\r
   do {\r
-    ERROR_CHECK(TcgGetNextToken(&TmpParseStruct, &TcgToken));\r
+    ERROR_CHECK (TcgGetNextToken (&TmpParseStruct, &TcgToken));\r
   } while (TcgToken.Type != TcgTokenTypeEndOfData);\r
 \r
   // only reach here if enddata is found\r
   // at this point, the curptr is pointing at method status list beginning\r
-  ERROR_CHECK(TcgGetNextStartList(&TmpParseStruct));\r
-  ERROR_CHECK(TcgGetNextUINT8(&TmpParseStruct, MethodStatus));\r
-  ERROR_CHECK(TcgGetNextUINT8(&TmpParseStruct, &Reserved1));\r
-  ERROR_CHECK(TcgGetNextUINT8(&TmpParseStruct, &Reserved2));\r
-  ERROR_CHECK(TcgGetNextEndList(&TmpParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartList (&TmpParseStruct));\r
+  ERROR_CHECK (TcgGetNextUINT8 (&TmpParseStruct, MethodStatus));\r
+  ERROR_CHECK (TcgGetNextUINT8 (&TmpParseStruct, &Reserved1));\r
+  ERROR_CHECK (TcgGetNextUINT8 (&TmpParseStruct, &Reserved2));\r
+  ERROR_CHECK (TcgGetNextEndList (&TmpParseStruct));\r
 \r
   if (Reserved1 != 0) {\r
     DEBUG ((DEBUG_INFO, "Method status reserved1 = 0x%02X (expected 0)\n", Reserved1));\r
@@ -303,9 +309,9 @@ TcgGetMethodStatus(
   @retval   Return the string for this type.\r
 \r
 **/\r
-CHAR8*\r
+CHAR8 *\r
 EFIAPI\r
-TcgTokenTypeString(\r
+TcgTokenTypeString (\r
   TCG_TOKEN_TYPE  Type\r
   )\r
 {\r
@@ -326,10 +332,10 @@ TcgTokenTypeString(
     case TcgTokenTypeEndTransaction: return "End Transaction";\r
     case TcgTokenTypeEmptyAtom: return "Empty atom";\r
   }\r
+\r
   return "Unknown";\r
 }\r
 \r
-\r
 /**\r
 \r
   Adds Start Session call to the data structure.  This creates the entire ComPacket structure and\r
@@ -349,48 +355,49 @@ TcgTokenTypeString(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCreateStartSession(\r
-  TCG_CREATE_STRUCT     *CreateStruct,\r
-  UINT32                *Size,\r
-  UINT16                ComId,\r
-  UINT16                ComIdExtension,\r
-  UINT32                HostSessionId,\r
-  TCG_UID               SpId,\r
-  BOOLEAN               Write,\r
-  UINT32                HostChallengeLength,\r
-  const VOID            *HostChallenge,\r
-  TCG_UID               HostSigningAuthority\r
+TcgCreateStartSession (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             HostSessionId,\r
+  TCG_UID            SpId,\r
+  BOOLEAN            Write,\r
+  UINT32             HostChallengeLength,\r
+  const VOID         *HostChallenge,\r
+  TCG_UID            HostSigningAuthority\r
   )\r
 {\r
-  ERROR_CHECK(TcgStartComPacket(CreateStruct, ComId, ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(CreateStruct, 0x0, 0x0, 0x0, 0x0, 0x0)) ;\r
-  ERROR_CHECK(TcgStartSubPacket(CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(CreateStruct, TCG_UID_SMUID, TCG_UID_SM_START_SESSION));\r
-  ERROR_CHECK(TcgStartParameters(CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT32(CreateStruct, HostSessionId));\r
-  ERROR_CHECK(TcgAddTcgUid(CreateStruct, SpId));\r
-  ERROR_CHECK(TcgAddBOOLEAN(CreateStruct, Write));\r
+  ERROR_CHECK (TcgStartComPacket (CreateStruct, ComId, ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (CreateStruct, 0x0, 0x0, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (CreateStruct, TCG_UID_SMUID, TCG_UID_SM_START_SESSION));\r
+  ERROR_CHECK (TcgStartParameters (CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT32 (CreateStruct, HostSessionId));\r
+  ERROR_CHECK (TcgAddTcgUid (CreateStruct, SpId));\r
+  ERROR_CHECK (TcgAddBOOLEAN (CreateStruct, Write));\r
 \r
   // optional parameters\r
-  if (HostChallenge != NULL && HostChallengeLength != 0) {\r
-    ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-    ERROR_CHECK(TcgAddUINT8(CreateStruct, 0x00));   //TODO Create Enum for Method Optional Parameters?\r
-    ERROR_CHECK(TcgAddByteSequence(CreateStruct, HostChallenge, HostChallengeLength, FALSE));\r
-    ERROR_CHECK(TcgAddEndName(CreateStruct));\r
+  if ((HostChallenge != NULL) && (HostChallengeLength != 0)) {\r
+    ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+    ERROR_CHECK (TcgAddUINT8 (CreateStruct, 0x00));   // TODO Create Enum for Method Optional Parameters?\r
+    ERROR_CHECK (TcgAddByteSequence (CreateStruct, HostChallenge, HostChallengeLength, FALSE));\r
+    ERROR_CHECK (TcgAddEndName (CreateStruct));\r
   }\r
+\r
   // optional parameters\r
   if (HostSigningAuthority != 0) {\r
-    ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-    ERROR_CHECK(TcgAddUINT8(CreateStruct, 0x03));   //TODO Create Enum for Method Optional Parameters?\r
-    ERROR_CHECK(TcgAddTcgUid(CreateStruct, HostSigningAuthority));\r
-    ERROR_CHECK(TcgAddEndName(CreateStruct));\r
+    ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+    ERROR_CHECK (TcgAddUINT8 (CreateStruct, 0x03));   // TODO Create Enum for Method Optional Parameters?\r
+    ERROR_CHECK (TcgAddTcgUid (CreateStruct, HostSigningAuthority));\r
+    ERROR_CHECK (TcgAddEndName (CreateStruct));\r
   }\r
 \r
-  ERROR_CHECK(TcgEndParameters(CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(CreateStruct, Size));\r
+  ERROR_CHECK (TcgEndParameters (CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (CreateStruct, Size));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -408,7 +415,7 @@ TcgCreateStartSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgParseSyncSession(\r
+TcgParseSyncSession (\r
   const TCG_PARSE_STRUCT  *ParseStruct,\r
   UINT16                  ComId,\r
   UINT16                  ComIdExtension,\r
@@ -416,38 +423,39 @@ TcgParseSyncSession(
   UINT32                  *TperSessionId\r
   )\r
 {\r
-  UINT8 MethodStatus;\r
-  TCG_PARSE_STRUCT TmpParseStruct;\r
-  UINT16 ParseComId;\r
-  UINT16 ParseExtComId;\r
-  TCG_UID InvokingUID;\r
-  TCG_UID MethodUID;\r
-  UINT32 RecvHostSessionId;\r
+  UINT8             MethodStatus;\r
+  TCG_PARSE_STRUCT  TmpParseStruct;\r
+  UINT16            ParseComId;\r
+  UINT16            ParseExtComId;\r
+  TCG_UID           InvokingUID;\r
+  TCG_UID           MethodUID;\r
+  UINT32            RecvHostSessionId;\r
 \r
-  NULL_CHECK(ParseStruct);\r
-  NULL_CHECK(TperSessionId);\r
+  NULL_CHECK (ParseStruct);\r
+  NULL_CHECK (TperSessionId);\r
 \r
-  CopyMem (&TmpParseStruct, ParseStruct, sizeof(TCG_PARSE_STRUCT));\r
+  CopyMem (&TmpParseStruct, ParseStruct, sizeof (TCG_PARSE_STRUCT));\r
 \r
   // verify method status is good\r
-  ERROR_CHECK(TcgGetMethodStatus(&TmpParseStruct, &MethodStatus));\r
+  ERROR_CHECK (TcgGetMethodStatus (&TmpParseStruct, &MethodStatus));\r
   METHOD_STATUS_ERROR_CHECK (MethodStatus, TcgResultFailure);\r
 \r
   // verify comids\r
-  ERROR_CHECK(TcgGetComIds(&TmpParseStruct, &ParseComId, &ParseExtComId));\r
+  ERROR_CHECK (TcgGetComIds (&TmpParseStruct, &ParseComId, &ParseExtComId));\r
 \r
   if ((ComId != ParseComId) || (ComIdExtension != ParseExtComId)) {\r
     DEBUG ((DEBUG_INFO, "unmatched comid (exp: 0x%X recv: 0x%X) or comid extension (exp: 0x%X recv: 0x%X)\n", ComId, ParseComId, ComIdExtension, ParseExtComId));\r
     return TcgResultFailure;\r
   }\r
-  ERROR_CHECK(TcgGetNextCall(&TmpParseStruct));\r
-  ERROR_CHECK(TcgGetNextTcgUid(&TmpParseStruct, &InvokingUID));\r
-  ERROR_CHECK(TcgGetNextTcgUid(&TmpParseStruct, &MethodUID));\r
-  ERROR_CHECK(TcgGetNextStartList(&TmpParseStruct));\r
-  ERROR_CHECK(TcgGetNextUINT32(&TmpParseStruct, &RecvHostSessionId));\r
-  ERROR_CHECK(TcgGetNextUINT32(&TmpParseStruct, TperSessionId));\r
-  ERROR_CHECK(TcgGetNextEndList(&TmpParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndOfData(&TmpParseStruct));\r
+\r
+  ERROR_CHECK (TcgGetNextCall (&TmpParseStruct));\r
+  ERROR_CHECK (TcgGetNextTcgUid (&TmpParseStruct, &InvokingUID));\r
+  ERROR_CHECK (TcgGetNextTcgUid (&TmpParseStruct, &MethodUID));\r
+  ERROR_CHECK (TcgGetNextStartList (&TmpParseStruct));\r
+  ERROR_CHECK (TcgGetNextUINT32 (&TmpParseStruct, &RecvHostSessionId));\r
+  ERROR_CHECK (TcgGetNextUINT32 (&TmpParseStruct, TperSessionId));\r
+  ERROR_CHECK (TcgGetNextEndList (&TmpParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndOfData (&TmpParseStruct));\r
 \r
   if (InvokingUID != TCG_UID_SMUID) {\r
     DEBUG ((DEBUG_INFO, "Invoking UID did not match UID_SMUID\n"));\r
@@ -482,22 +490,22 @@ TcgParseSyncSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCreateEndSession(\r
-  TCG_CREATE_STRUCT   *CreateStruct,\r
-  UINT32              *Size,\r
-  UINT16              ComId,\r
-  UINT16              ComIdExtension,\r
-  UINT32              HostSessionId,\r
-  UINT32              TpSessionId\r
+TcgCreateEndSession (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             HostSessionId,\r
+  UINT32             TpSessionId\r
   )\r
 {\r
-  ERROR_CHECK(TcgStartComPacket(CreateStruct, ComId, ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(CreateStruct, TpSessionId, HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgAddEndOfSession(CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(CreateStruct, Size));\r
+  ERROR_CHECK (TcgStartComPacket (CreateStruct, ComId, ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (CreateStruct, TpSessionId, HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgAddEndOfSession (CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (CreateStruct, Size));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -512,19 +520,19 @@ TcgCreateEndSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgStartMethodSet(\r
-  TCG_CREATE_STRUCT        *CreateStruct,\r
-  TCG_UID                  Row,\r
-  UINT32                   ColumnNumber\r
+TcgStartMethodSet (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  TCG_UID            Row,\r
+  UINT32             ColumnNumber\r
   )\r
 {\r
-  ERROR_CHECK(TcgStartMethodCall(CreateStruct, Row, TCG_UID_METHOD_SET));\r
-  ERROR_CHECK(TcgStartParameters(CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(CreateStruct, 0x01)); // "Values"\r
-  ERROR_CHECK(TcgAddStartList(CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT32(CreateStruct, ColumnNumber));\r
+  ERROR_CHECK (TcgStartMethodCall (CreateStruct, Row, TCG_UID_METHOD_SET));\r
+  ERROR_CHECK (TcgStartParameters (CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (CreateStruct, 0x01)); // "Values"\r
+  ERROR_CHECK (TcgAddStartList (CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT32 (CreateStruct, ColumnNumber));\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -536,15 +544,15 @@ TcgStartMethodSet(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgEndMethodSet(\r
-  TCG_CREATE_STRUCT        *CreateStruct\r
+TcgEndMethodSet (\r
+  TCG_CREATE_STRUCT  *CreateStruct\r
   )\r
 {\r
-  ERROR_CHECK(TcgAddEndName(CreateStruct));\r
-  ERROR_CHECK(TcgAddEndList(CreateStruct));\r
-  ERROR_CHECK(TcgAddEndName(CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(CreateStruct));\r
+  ERROR_CHECK (TcgAddEndName (CreateStruct));\r
+  ERROR_CHECK (TcgAddEndList (CreateStruct));\r
+  ERROR_CHECK (TcgAddEndName (CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (CreateStruct));\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -565,28 +573,28 @@ TcgEndMethodSet(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCreateSetCPin(\r
-  TCG_CREATE_STRUCT       *CreateStruct,\r
-  UINT32                  *Size,\r
-  UINT16                  ComId,\r
-  UINT16                  ComIdExtension,\r
-  UINT32                  TperSession,\r
-  UINT32                  HostSession,\r
-  TCG_UID                 SidRow,\r
-  const VOID              *Password,\r
-  UINT32                  PasswordSize\r
+TcgCreateSetCPin (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             TperSession,\r
+  UINT32             HostSession,\r
+  TCG_UID            SidRow,\r
+  const VOID         *Password,\r
+  UINT32             PasswordSize\r
   )\r
 {\r
   // set new SID Password\r
-  ERROR_CHECK(TcgStartComPacket(CreateStruct, ComId, ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(CreateStruct, TperSession, HostSession, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodSet(CreateStruct, SidRow, 0x03)); // "PIN"\r
-  ERROR_CHECK(TcgAddByteSequence(CreateStruct, Password, PasswordSize, FALSE));\r
-  ERROR_CHECK(TcgEndMethodSet(CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(CreateStruct, Size));\r
+  ERROR_CHECK (TcgStartComPacket (CreateStruct, ComId, ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (CreateStruct, TperSession, HostSession, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodSet (CreateStruct, SidRow, 0x03)); // "PIN"\r
+  ERROR_CHECK (TcgAddByteSequence (CreateStruct, Password, PasswordSize, FALSE));\r
+  ERROR_CHECK (TcgEndMethodSet (CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (CreateStruct, Size));\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -606,26 +614,26 @@ TcgCreateSetCPin(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgSetAuthorityEnabled(\r
-  TCG_CREATE_STRUCT           *CreateStruct,\r
-  UINT32                      *Size,\r
-  UINT16                      ComId,\r
-  UINT16                      ComIdExtension,\r
-  UINT32                      TperSession,\r
-  UINT32                      HostSession,\r
-  TCG_UID                     AuthorityUid,\r
-  BOOLEAN                     Enabled\r
+TcgSetAuthorityEnabled (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             TperSession,\r
+  UINT32             HostSession,\r
+  TCG_UID            AuthorityUid,\r
+  BOOLEAN            Enabled\r
   )\r
 {\r
-  ERROR_CHECK(TcgStartComPacket(CreateStruct, ComId, ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(CreateStruct, TperSession, HostSession, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodSet(CreateStruct, AuthorityUid, 0x05)); // "Enabled"\r
-  ERROR_CHECK(TcgAddBOOLEAN(CreateStruct, Enabled));\r
-  ERROR_CHECK(TcgEndMethodSet(CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(CreateStruct, Size));\r
+  ERROR_CHECK (TcgStartComPacket (CreateStruct, ComId, ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (CreateStruct, TperSession, HostSession, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodSet (CreateStruct, AuthorityUid, 0x05)); // "Enabled"\r
+  ERROR_CHECK (TcgAddBOOLEAN (CreateStruct, Enabled));\r
+  ERROR_CHECK (TcgEndMethodSet (CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (CreateStruct, Size));\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -648,21 +656,21 @@ TcgSetAuthorityEnabled(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-TcgCreateSetAce(\r
-  TCG_CREATE_STRUCT        *CreateStruct,\r
-  UINT32                   *Size,\r
-  UINT16                   ComId,\r
-  UINT16                   ComIdExtension,\r
-  UINT32                   TperSession,\r
-  UINT32                   HostSession,\r
-  TCG_UID                  AceRow,\r
-  TCG_UID                  Authority1,\r
-  BOOLEAN                  LogicalOperator,\r
-  TCG_UID                  Authority2\r
+TcgCreateSetAce (\r
+  TCG_CREATE_STRUCT  *CreateStruct,\r
+  UINT32             *Size,\r
+  UINT16             ComId,\r
+  UINT16             ComIdExtension,\r
+  UINT32             TperSession,\r
+  UINT32             HostSession,\r
+  TCG_UID            AceRow,\r
+  TCG_UID            Authority1,\r
+  BOOLEAN            LogicalOperator,\r
+  TCG_UID            Authority2\r
   )\r
 {\r
-  UINT8 HalfUidAuthorityObjectRef[4];\r
-  UINT8 HalfUidBooleanAce[4];\r
+  UINT8  HalfUidAuthorityObjectRef[4];\r
+  UINT8  HalfUidBooleanAce[4];\r
 \r
   HalfUidAuthorityObjectRef[0] = 0x0;\r
   HalfUidAuthorityObjectRef[1] = 0x0;\r
@@ -674,29 +682,29 @@ TcgCreateSetAce(
   HalfUidBooleanAce[2] = 0x4;\r
   HalfUidBooleanAce[3] = 0xE;\r
 \r
-  ERROR_CHECK(TcgStartComPacket(CreateStruct, ComId, ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(CreateStruct, TperSession, HostSession, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodSet(CreateStruct, AceRow, 0x03));     // "BooleanExpr"\r
-  ERROR_CHECK(TcgAddStartList(CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-  ERROR_CHECK(TcgAddByteSequence(CreateStruct, HalfUidAuthorityObjectRef, sizeof(HalfUidAuthorityObjectRef), FALSE));\r
-  ERROR_CHECK(TcgAddTcgUid(CreateStruct, Authority1));\r
-  ERROR_CHECK(TcgAddEndName(CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-  ERROR_CHECK(TcgAddByteSequence(CreateStruct, HalfUidAuthorityObjectRef, sizeof(HalfUidAuthorityObjectRef), FALSE));\r
-  ERROR_CHECK(TcgAddTcgUid(CreateStruct, Authority2));\r
-  ERROR_CHECK(TcgAddEndName(CreateStruct));\r
-\r
-  ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-  ERROR_CHECK(TcgAddByteSequence(CreateStruct, HalfUidBooleanAce, sizeof(HalfUidBooleanAce), FALSE));\r
-  ERROR_CHECK(TcgAddBOOLEAN(CreateStruct, LogicalOperator));\r
-  ERROR_CHECK(TcgAddEndName(CreateStruct));\r
-  ERROR_CHECK(TcgAddEndList(CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodSet(CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(CreateStruct, Size));\r
+  ERROR_CHECK (TcgStartComPacket (CreateStruct, ComId, ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (CreateStruct, TperSession, HostSession, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodSet (CreateStruct, AceRow, 0x03));     // "BooleanExpr"\r
+  ERROR_CHECK (TcgAddStartList (CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+  ERROR_CHECK (TcgAddByteSequence (CreateStruct, HalfUidAuthorityObjectRef, sizeof (HalfUidAuthorityObjectRef), FALSE));\r
+  ERROR_CHECK (TcgAddTcgUid (CreateStruct, Authority1));\r
+  ERROR_CHECK (TcgAddEndName (CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+  ERROR_CHECK (TcgAddByteSequence (CreateStruct, HalfUidAuthorityObjectRef, sizeof (HalfUidAuthorityObjectRef), FALSE));\r
+  ERROR_CHECK (TcgAddTcgUid (CreateStruct, Authority2));\r
+  ERROR_CHECK (TcgAddEndName (CreateStruct));\r
+\r
+  ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+  ERROR_CHECK (TcgAddByteSequence (CreateStruct, HalfUidBooleanAce, sizeof (HalfUidBooleanAce), FALSE));\r
+  ERROR_CHECK (TcgAddBOOLEAN (CreateStruct, LogicalOperator));\r
+  ERROR_CHECK (TcgAddEndName (CreateStruct));\r
+  ERROR_CHECK (TcgAddEndList (CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodSet (CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (CreateStruct, Size));\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -712,21 +720,21 @@ TcgCreateSetAce(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgEnumLevel0Discovery(\r
+TcgEnumLevel0Discovery (\r
   const TCG_LEVEL0_DISCOVERY_HEADER  *DiscoveryHeader,\r
   TCG_LEVEL0_ENUM_CALLBACK           Callback,\r
   VOID                               *Context\r
   )\r
 {\r
-  UINT32                                  BytesLeft;\r
-  const UINT8                             *DiscoveryBufferPtr;\r
-  UINT32                                  FeatLength;\r
-  TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER    *Feat;\r
+  UINT32                                BytesLeft;\r
+  const UINT8                           *DiscoveryBufferPtr;\r
+  UINT32                                FeatLength;\r
+  TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER  *Feat;\r
 \r
   //\r
   // Total bytes including descriptors but not including the Length field\r
   //\r
-  BytesLeft = SwapBytes32(DiscoveryHeader->LengthBE);\r
+  BytesLeft = SwapBytes32 (DiscoveryHeader->LengthBE);\r
 \r
   //\r
   // If discovery Header is not valid, exit\r
@@ -738,20 +746,20 @@ TcgEnumLevel0Discovery(
   //\r
   // Subtract the Length of the Header, except the Length field, which is not included\r
   //\r
-  BytesLeft -= (sizeof(TCG_LEVEL0_DISCOVERY_HEADER) - sizeof(DiscoveryHeader->LengthBE));\r
+  BytesLeft -= (sizeof (TCG_LEVEL0_DISCOVERY_HEADER) - sizeof (DiscoveryHeader->LengthBE));\r
 \r
   //\r
   // Move ptr to first descriptor\r
   //\r
-  DiscoveryBufferPtr = (const UINT8*)DiscoveryHeader + sizeof(TCG_LEVEL0_DISCOVERY_HEADER);\r
+  DiscoveryBufferPtr = (const UINT8 *)DiscoveryHeader + sizeof (TCG_LEVEL0_DISCOVERY_HEADER);\r
 \r
-  while (BytesLeft > sizeof(TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER)) {\r
+  while (BytesLeft > sizeof (TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER)) {\r
     //\r
     // Pointer to beginning of descriptor (including common Header)\r
     //\r
-    Feat = (TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER*)DiscoveryBufferPtr;\r
+    Feat = (TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER *)DiscoveryBufferPtr;\r
 \r
-    FeatLength = Feat->Length + sizeof(TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER);\r
+    FeatLength = Feat->Length + sizeof (TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER);\r
 \r
     //\r
     // Not enough bytes left for Feature descriptor\r
@@ -763,14 +771,14 @@ TcgEnumLevel0Discovery(
     //\r
     // Report the Feature to the callback\r
     //\r
-    if (Callback(DiscoveryHeader, Feat, FeatLength, Context)) {\r
+    if (Callback (DiscoveryHeader, Feat, FeatLength, Context)) {\r
       return TRUE;\r
     }\r
 \r
     //\r
     // Descriptor Length only describes Data after common Header\r
     //\r
-    BytesLeft -= FeatLength;\r
+    BytesLeft          -= FeatLength;\r
     DiscoveryBufferPtr += FeatLength;\r
   }\r
 \r
@@ -788,21 +796,22 @@ TcgEnumLevel0Discovery(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgFindFeatureCallback(\r
-  const TCG_LEVEL0_DISCOVERY_HEADER           *DiscoveryHeader,\r
-  TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER        *Feature,\r
-  UINTN                                       FeatureSize,\r
-  VOID                                        *Context\r
+TcgFindFeatureCallback (\r
+  const TCG_LEVEL0_DISCOVERY_HEADER     *DiscoveryHeader,\r
+  TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER  *Feature,\r
+  UINTN                                 FeatureSize,\r
+  VOID                                  *Context\r
   )\r
 {\r
-  TCG_FIND_FEATURE_CTXFindCtx;\r
+  TCG_FIND_FEATURE_CTX  *FindCtx;\r
 \r
-  FindCtx = (TCG_FIND_FEATURE_CTX*)Context;\r
-  if ( SwapBytes16( Feature->FeatureCode_BE ) == FindCtx->FeatureCode ) {\r
-    FindCtx->Feature = Feature;\r
+  FindCtx = (TCG_FIND_FEATURE_CTX *)Context;\r
+  if ( SwapBytes16 (Feature->FeatureCode_BE) == FindCtx->FeatureCode ) {\r
+    FindCtx->Feature     = Feature;\r
     FindCtx->FeatureSize = FeatureSize;\r
     return TRUE; // done enumerating features\r
   }\r
+\r
   return FALSE; // continue enumerating\r
 }\r
 \r
@@ -815,24 +824,25 @@ TcgFindFeatureCallback(
 \r
   @retval    return the Feature code data.\r
 **/\r
-TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER*\r
+TCG_LEVEL0_FEATURE_DESCRIPTOR_HEADER *\r
 EFIAPI\r
-TcgGetFeature(\r
+TcgGetFeature (\r
   const TCG_LEVEL0_DISCOVERY_HEADER  *DiscoveryHeader,\r
   UINT16                             FeatureCode,\r
   UINTN                              *FeatureSize\r
   )\r
 {\r
-  TCG_FIND_FEATURE_CTX FindCtx;\r
+  TCG_FIND_FEATURE_CTX  FindCtx;\r
 \r
   FindCtx.FeatureCode = FeatureCode;\r
-  FindCtx.Feature = NULL;\r
+  FindCtx.Feature     = NULL;\r
   FindCtx.FeatureSize = 0;\r
 \r
-  TcgEnumLevel0Discovery(DiscoveryHeader, TcgFindFeatureCallback, &FindCtx);\r
+  TcgEnumLevel0Discovery (DiscoveryHeader, TcgFindFeatureCallback, &FindCtx);\r
   if (FeatureSize != NULL) {\r
     *FeatureSize = FindCtx.FeatureSize;\r
   }\r
+\r
   return FindCtx.Feature;\r
 }\r
 \r
@@ -846,19 +856,19 @@ TcgGetFeature(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgIsProtocolSupported(\r
-  const TCG_SUPPORTED_SECURITY_PROTOCOLS   *ProtocolList,\r
-  UINT16                                   Protocol\r
+TcgIsProtocolSupported (\r
+  const TCG_SUPPORTED_SECURITY_PROTOCOLS  *ProtocolList,\r
+  UINT16                                  Protocol\r
   )\r
 {\r
-  UINT16 Index;\r
-  UINT16 ListLength;\r
+  UINT16  Index;\r
+  UINT16  ListLength;\r
 \r
-  ListLength = SwapBytes16(ProtocolList->ListLength_BE);\r
+  ListLength = SwapBytes16 (ProtocolList->ListLength_BE);\r
 \r
-  if (ListLength > sizeof(ProtocolList->List)) {\r
+  if (ListLength > sizeof (ProtocolList->List)) {\r
     DEBUG ((DEBUG_INFO, "WARNING: list Length is larger than max allowed Value; truncating\n"));\r
-    ListLength = sizeof(ProtocolList->List);\r
+    ListLength = sizeof (ProtocolList->List);\r
   }\r
 \r
   for (Index = 0; Index < ListLength; Index++) {\r
@@ -879,17 +889,17 @@ TcgIsProtocolSupported(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-TcgIsLocked(\r
-  const TCG_LEVEL0_DISCOVERY_HEADER         *Discovery\r
+TcgIsLocked (\r
+  const TCG_LEVEL0_DISCOVERY_HEADER  *Discovery\r
   )\r
 {\r
-  UINTN Size;\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR     *LockDescriptor;\r
+  UINTN                           Size;\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockDescriptor;\r
 \r
-  Size = 0;\r
-  LockDescriptor =(TCG_LOCKING_FEATURE_DESCRIPTOR*) TcgGetFeature (Discovery, TCG_FEATURE_LOCKING, &Size);\r
+  Size           = 0;\r
+  LockDescriptor = (TCG_LOCKING_FEATURE_DESCRIPTOR *)TcgGetFeature (Discovery, TCG_FEATURE_LOCKING, &Size);\r
 \r
-  if (LockDescriptor != NULL && Size >= sizeof(*LockDescriptor)) {\r
+  if ((LockDescriptor != NULL) && (Size >= sizeof (*LockDescriptor))) {\r
     DEBUG ((DEBUG_INFO, "locked: %d\n", LockDescriptor->Locked));\r
     return LockDescriptor->Locked;\r
   }\r
index c840590e8e3e3caae5fa9af3b1fce6a14f694cb7..e59438c99374c005a4b89bbd3a072d4a61193b14 100644 (file)
@@ -17,13 +17,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #pragma pack(1)\r
 typedef struct {\r
-    UINT8 HardwareReset : 1;\r
-    UINT8 Reserved : 7;\r
+  UINT8    HardwareReset : 1;\r
+  UINT8    Reserved      : 7;\r
 } TCG_BLOCK_SID_CLEAR_EVENTS;\r
 #pragma pack()\r
 \r
-#define TRUSTED_COMMAND_TIMEOUT_NS      ((UINT64) 5 * ((UINT64)(1000000)) * 1000) // 5 seconds\r
-#define BUFFER_SIZE                      512\r
+#define TRUSTED_COMMAND_TIMEOUT_NS  ((UINT64) 5 * ((UINT64)(1000000)) * 1000)     // 5 seconds\r
+#define BUFFER_SIZE                 512\r
 \r
 /**\r
   The function performs a Trusted Send of a Buffer containing a TCG_COM_PACKET.\r
@@ -38,7 +38,7 @@ typedef struct {
 \r
 **/\r
 TCG_RESULT\r
-OpalTrustedSend(\r
+OpalTrustedSend (\r
   EFI_STORAGE_SECURITY_COMMAND_PROTOCOL  *Sscp,\r
   UINT32                                 MediaId,\r
   UINT8                                  SecurityProtocol,\r
@@ -60,17 +60,17 @@ OpalTrustedSend(
     return TcgResultFailureBufferTooSmall;\r
   }\r
 \r
-  ZeroMem((UINT8*)Buffer + TransferLength, TransferLength512 - TransferLength);\r
+  ZeroMem ((UINT8 *)Buffer + TransferLength, TransferLength512 - TransferLength);\r
 \r
-  Status = Sscp->SendData(\r
-               Sscp,\r
-               MediaId,\r
-               TRUSTED_COMMAND_TIMEOUT_NS,\r
-               SecurityProtocol,\r
-               SwapBytes16(SpSpecific),\r
-               TransferLength512,\r
-               Buffer\r
-               );\r
+  Status = Sscp->SendData (\r
+                   Sscp,\r
+                   MediaId,\r
+                   TRUSTED_COMMAND_TIMEOUT_NS,\r
+                   SecurityProtocol,\r
+                   SwapBytes16 (SpSpecific),\r
+                   TransferLength512,\r
+                   Buffer\r
+                   );\r
 \r
   return Status == EFI_SUCCESS ? TcgResultSuccess : TcgResultFailure;\r
 }\r
@@ -89,7 +89,7 @@ OpalTrustedSend(
 \r
 **/\r
 TCG_RESULT\r
-OpalTrustedRecv(\r
+OpalTrustedRecv (\r
   EFI_STORAGE_SECURITY_COMMAND_PROTOCOL  *Sscp,\r
   UINT32                                 MediaId,\r
   UINT8                                  SecurityProtocol,\r
@@ -111,12 +111,12 @@ OpalTrustedRecv(
   // Round Buffer Size down to a 512-byte multiple\r
   //\r
   TransferLength512 = BufferSize & ~(UINTN)511;\r
-  Tries = 0;\r
-  ComPacket = NULL;\r
-  Length = 0;\r
-  OutstandingData = 0;\r
+  Tries             = 0;\r
+  ComPacket         = NULL;\r
+  Length            = 0;\r
+  OutstandingData   = 0;\r
 \r
-  if (TransferLength512 < sizeof(TCG_COM_PACKET)) {\r
+  if (TransferLength512 < sizeof (TCG_COM_PACKET)) {\r
     DEBUG ((DEBUG_INFO, "transferLength %u too small for ComPacket\n", TransferLength512));\r
     return TcgResultFailureBufferTooSmall;\r
   }\r
@@ -135,25 +135,26 @@ OpalTrustedRecv(
   } else {\r
     Tries = 5000;\r
   }\r
+\r
   while ((Tries--) > 0) {\r
-    ZeroMem( Buffer, BufferSize );\r
+    ZeroMem (Buffer, BufferSize);\r
     TransferSize = 0;\r
 \r
-    Status = Sscp->ReceiveData(\r
-                 Sscp,\r
-                 MediaId,\r
-                 TRUSTED_COMMAND_TIMEOUT_NS,\r
-                 SecurityProtocol,\r
-                 SwapBytes16(SpSpecific),\r
-                 TransferLength512,\r
-                 Buffer,\r
-                 &TransferSize\r
-             );\r
+    Status = Sscp->ReceiveData (\r
+                     Sscp,\r
+                     MediaId,\r
+                     TRUSTED_COMMAND_TIMEOUT_NS,\r
+                     SecurityProtocol,\r
+                     SwapBytes16 (SpSpecific),\r
+                     TransferLength512,\r
+                     Buffer,\r
+                     &TransferSize\r
+                     );\r
     if (EFI_ERROR (Status)) {\r
       return TcgResultFailure;\r
     }\r
 \r
-    if (SecurityProtocol != TCG_OPAL_SECURITY_PROTOCOL_1 && SecurityProtocol != TCG_OPAL_SECURITY_PROTOCOL_2) {\r
+    if ((SecurityProtocol != TCG_OPAL_SECURITY_PROTOCOL_1) && (SecurityProtocol != TCG_OPAL_SECURITY_PROTOCOL_2)) {\r
       return TcgResultSuccess;\r
     }\r
 \r
@@ -161,11 +162,11 @@ OpalTrustedRecv(
       return TcgResultSuccess;\r
     }\r
 \r
-    ComPacket = (TCG_COM_PACKET*) Buffer;\r
-    Length = SwapBytes32(ComPacket->LengthBE);\r
-    OutstandingData = SwapBytes32( ComPacket->OutstandingDataBE );\r
+    ComPacket       = (TCG_COM_PACKET *)Buffer;\r
+    Length          = SwapBytes32 (ComPacket->LengthBE);\r
+    OutstandingData = SwapBytes32 (ComPacket->OutstandingDataBE);\r
 \r
-    if (Length != 0 && OutstandingData == 0) {\r
+    if ((Length != 0) && (OutstandingData == 0)) {\r
       return TcgResultSuccess;\r
     }\r
 \r
@@ -192,41 +193,45 @@ OpalTrustedRecv(
 TCG_RESULT\r
 EFIAPI\r
 OpalPerformMethod (\r
-  OPAL_SESSION     *Session,\r
-  UINT32           SendSize,\r
-  VOID             *Buffer,\r
-  UINT32           BufferSize,\r
-  TCG_PARSE_STRUCT *ParseStruct,\r
-  UINT8            *MethodStatus,\r
-  UINT32           EstimateTimeCost\r
+  OPAL_SESSION      *Session,\r
+  UINT32            SendSize,\r
+  VOID              *Buffer,\r
+  UINT32            BufferSize,\r
+  TCG_PARSE_STRUCT  *ParseStruct,\r
+  UINT8             *MethodStatus,\r
+  UINT32            EstimateTimeCost\r
   )\r
 {\r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(MethodStatus);\r
-\r
-  ERROR_CHECK(OpalTrustedSend(\r
-                  Session->Sscp,\r
-                  Session->MediaId,\r
-                  TCG_OPAL_SECURITY_PROTOCOL_1,\r
-                  Session->OpalBaseComId,\r
-                  SendSize,\r
-                  Buffer,\r
-                  BufferSize\r
-              ));\r
-\r
-  ERROR_CHECK(OpalTrustedRecv(\r
-                  Session->Sscp,\r
-                  Session->MediaId,\r
-                  TCG_OPAL_SECURITY_PROTOCOL_1,\r
-                  Session->OpalBaseComId,\r
-                  Buffer,\r
-                  BufferSize,\r
-                  EstimateTimeCost\r
-              ));\r
-\r
-  ERROR_CHECK(TcgInitTcgParseStruct(ParseStruct, Buffer, BufferSize));\r
-  ERROR_CHECK(TcgCheckComIds(ParseStruct, Session->OpalBaseComId, Session->ComIdExtension));\r
-  ERROR_CHECK(TcgGetMethodStatus(ParseStruct, MethodStatus));\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (MethodStatus);\r
+\r
+  ERROR_CHECK (\r
+    OpalTrustedSend (\r
+      Session->Sscp,\r
+      Session->MediaId,\r
+      TCG_OPAL_SECURITY_PROTOCOL_1,\r
+      Session->OpalBaseComId,\r
+      SendSize,\r
+      Buffer,\r
+      BufferSize\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (\r
+    OpalTrustedRecv (\r
+      Session->Sscp,\r
+      Session->MediaId,\r
+      TCG_OPAL_SECURITY_PROTOCOL_1,\r
+      Session->OpalBaseComId,\r
+      Buffer,\r
+      BufferSize,\r
+      EstimateTimeCost\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (TcgInitTcgParseStruct (ParseStruct, Buffer, BufferSize));\r
+  ERROR_CHECK (TcgCheckComIds (ParseStruct, Session->OpalBaseComId, Session->ComIdExtension));\r
+  ERROR_CHECK (TcgGetMethodStatus (ParseStruct, MethodStatus));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -240,33 +245,33 @@ OpalPerformMethod (
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalBlockSid(\r
-  OPAL_SESSION                           *Session,\r
-  BOOLEAN                                HardwareReset\r
+OpalBlockSid (\r
+  OPAL_SESSION  *Session,\r
+  BOOLEAN       HardwareReset\r
   )\r
 {\r
-  UINT8                      Buffer[BUFFER_SIZE];\r
-  TCG_BLOCK_SID_CLEAR_EVENTS *ClearEvents;\r
+  UINT8                       Buffer[BUFFER_SIZE];\r
+  TCG_BLOCK_SID_CLEAR_EVENTS  *ClearEvents;\r
 \r
-  NULL_CHECK(Session);\r
+  NULL_CHECK (Session);\r
 \r
   //\r
   // Set Hardware Reset bit\r
   //\r
-  ClearEvents = (TCG_BLOCK_SID_CLEAR_EVENTS *) &Buffer[0];\r
+  ClearEvents = (TCG_BLOCK_SID_CLEAR_EVENTS *)&Buffer[0];\r
 \r
-  ClearEvents->Reserved = 0;\r
+  ClearEvents->Reserved      = 0;\r
   ClearEvents->HardwareReset = HardwareReset;\r
 \r
-  return(OpalTrustedSend(\r
-                  Session->Sscp,\r
-                  Session->MediaId,\r
-                  TCG_OPAL_SECURITY_PROTOCOL_2,\r
-                  TCG_BLOCKSID_COMID,   // hardcode ComID 0x0005\r
-                  1,\r
-                  Buffer,\r
-                  BUFFER_SIZE\r
-              ));\r
+  return (OpalTrustedSend (\r
+            Session->Sscp,\r
+            Session->MediaId,\r
+            TCG_OPAL_SECURITY_PROTOCOL_2,\r
+            TCG_BLOCKSID_COMID,         // hardcode ComID 0x0005\r
+            1,\r
+            Buffer,\r
+            BUFFER_SIZE\r
+            ));\r
 }\r
 \r
 /**\r
@@ -278,8 +283,8 @@ OpalBlockSid(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalPsidRevert(\r
-  OPAL_SESSION              *AdminSpSession\r
+OpalPsidRevert (\r
+  OPAL_SESSION  *AdminSpSession\r
   )\r
 {\r
   //\r
@@ -293,28 +298,28 @@ OpalPsidRevert(
   UINT8              Buffer[BUFFER_SIZE];\r
   UINT8              MethodStatus;\r
 \r
-  NULL_CHECK(AdminSpSession);\r
+  NULL_CHECK (AdminSpSession);\r
 \r
   //\r
   // Send Revert action on Admin SP\r
   //\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buffer, BUFFER_SIZE));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, OPAL_UID_ADMIN_SP, OPAL_ADMIN_SP_REVERT_METHOD));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buffer, BUFFER_SIZE));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, OPAL_UID_ADMIN_SP, OPAL_ADMIN_SP_REVERT_METHOD));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
 \r
   //\r
   // Send Revert Method Call\r
   //\r
-  ERROR_CHECK(OpalPerformMethod(AdminSpSession, Size, Buffer, BUFFER_SIZE, &ParseStruct, &MethodStatus, 0));\r
-  METHOD_STATUS_ERROR_CHECK(MethodStatus, TcgResultFailure);\r
+  ERROR_CHECK (OpalPerformMethod (AdminSpSession, Size, Buffer, BUFFER_SIZE, &ParseStruct, &MethodStatus, 0));\r
+  METHOD_STATUS_ERROR_CHECK (MethodStatus, TcgResultFailure);\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -328,9 +333,9 @@ OpalPsidRevert(
 \r
 **/\r
 TCG_RESULT\r
-OpalPyrite2PsidRevert(\r
-  OPAL_SESSION              *AdminSpSession,\r
-  UINT32                    EstimateTimeCost\r
+OpalPyrite2PsidRevert (\r
+  OPAL_SESSION  *AdminSpSession,\r
+  UINT32        EstimateTimeCost\r
   )\r
 {\r
   //\r
@@ -344,29 +349,28 @@ OpalPyrite2PsidRevert(
   UINT8              Buffer[BUFFER_SIZE];\r
   UINT8              MethodStatus;\r
 \r
-\r
-  NULL_CHECK(AdminSpSession);\r
+  NULL_CHECK (AdminSpSession);\r
 \r
   //\r
   // Send Revert action on Admin SP\r
   //\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buffer, BUFFER_SIZE));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, OPAL_UID_ADMIN_SP, OPAL_ADMIN_SP_REVERT_METHOD));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buffer, BUFFER_SIZE));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, OPAL_UID_ADMIN_SP, OPAL_ADMIN_SP_REVERT_METHOD));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
 \r
   //\r
   // Send Revert Method Call\r
   //\r
-  ERROR_CHECK(OpalPerformMethod(AdminSpSession, Size, Buffer, BUFFER_SIZE, &ParseStruct, &MethodStatus, EstimateTimeCost));\r
-  METHOD_STATUS_ERROR_CHECK(MethodStatus, TcgResultFailure);\r
+  ERROR_CHECK (OpalPerformMethod (AdminSpSession, Size, Buffer, BUFFER_SIZE, &ParseStruct, &MethodStatus, EstimateTimeCost));\r
+  METHOD_STATUS_ERROR_CHECK (MethodStatus, TcgResultFailure);\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -383,20 +387,20 @@ OpalPyrite2PsidRevert(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalRetrieveLevel0DiscoveryHeader(\r
-  OPAL_SESSION     *Session,\r
-  UINTN            BufferSize,\r
-  VOID             *BuffAddress\r
+OpalRetrieveLevel0DiscoveryHeader (\r
+  OPAL_SESSION  *Session,\r
+  UINTN         BufferSize,\r
+  VOID          *BuffAddress\r
   )\r
 {\r
-  return (OpalTrustedRecv(\r
-              Session->Sscp,\r
-              Session->MediaId,\r
-              TCG_OPAL_SECURITY_PROTOCOL_1,   // SP\r
-              TCG_SP_SPECIFIC_PROTOCOL_LEVEL0_DISCOVERY, // SP_Specific\r
-              BuffAddress,\r
-              BufferSize,\r
-              0\r
+  return (OpalTrustedRecv (\r
+            Session->Sscp,\r
+            Session->MediaId,\r
+            TCG_OPAL_SECURITY_PROTOCOL_1,              // SP\r
+            TCG_SP_SPECIFIC_PROTOCOL_LEVEL0_DISCOVERY, // SP_Specific\r
+            BuffAddress,\r
+            BufferSize,\r
+            0\r
             ));\r
 }\r
 \r
@@ -412,21 +416,21 @@ OpalRetrieveLevel0DiscoveryHeader(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalRetrieveSupportedProtocolList(\r
-  OPAL_SESSION     *Session,\r
-  UINTN            BufferSize,\r
-  VOID             *BuffAddress\r
+OpalRetrieveSupportedProtocolList (\r
+  OPAL_SESSION  *Session,\r
+  UINTN         BufferSize,\r
+  VOID          *BuffAddress\r
   )\r
 {\r
-  return (OpalTrustedRecv(\r
-              Session->Sscp,\r
-              Session->MediaId,\r
-              TCG_SECURITY_PROTOCOL_INFO, // SP\r
-              TCG_SP_SPECIFIC_PROTOCOL_LIST, // SP_Specific\r
-              BuffAddress,\r
-              BufferSize,\r
-              0\r
-          ));\r
+  return (OpalTrustedRecv (\r
+            Session->Sscp,\r
+            Session->MediaId,\r
+            TCG_SECURITY_PROTOCOL_INFO,    // SP\r
+            TCG_SP_SPECIFIC_PROTOCOL_LIST, // SP_Specific\r
+            BuffAddress,\r
+            BufferSize,\r
+            0\r
+            ));\r
 }\r
 \r
 /**\r
@@ -449,52 +453,54 @@ OpalRetrieveSupportedProtocolList(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalStartSession(\r
-  OPAL_SESSION     *Session,\r
-  TCG_UID          SpId,\r
-  BOOLEAN          Write,\r
-  UINT32           HostChallengeLength,\r
-  const VOID       *HostChallenge,\r
-  TCG_UID          HostSigningAuthority,\r
-  UINT8            *MethodStatus\r
+OpalStartSession (\r
+  OPAL_SESSION  *Session,\r
+  TCG_UID       SpId,\r
+  BOOLEAN       Write,\r
+  UINT32        HostChallengeLength,\r
+  const VOID    *HostChallenge,\r
+  TCG_UID       HostSigningAuthority,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  UINT16            ComIdExtension;\r
-  UINT32            HostSessionId;\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  UINT16             ComIdExtension;\r
+  UINT32             HostSessionId;\r
 \r
   ComIdExtension = 0;\r
   HostSessionId  = 1;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(MethodStatus);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (MethodStatus);\r
 \r
   Session->ComIdExtension = ComIdExtension;\r
-  Session->HostSessionId = HostSessionId;\r
-\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgCreateStartSession(\r
-                    &CreateStruct,\r
-                    &Size,\r
-                    Session->OpalBaseComId,\r
-                    ComIdExtension,\r
-                    HostSessionId,\r
-                    SpId,\r
-                    Write,\r
-                    HostChallengeLength,\r
-                    HostChallenge,\r
-                    HostSigningAuthority\r
-                ));\r
-  ERROR_CHECK(OpalPerformMethod(Session, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  Session->HostSessionId  = HostSessionId;\r
+\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (\r
+    TcgCreateStartSession (\r
+      &CreateStruct,\r
+      &Size,\r
+      Session->OpalBaseComId,\r
+      ComIdExtension,\r
+      HostSessionId,\r
+      SpId,\r
+      Write,\r
+      HostChallengeLength,\r
+      HostChallenge,\r
+      HostSigningAuthority\r
+      )\r
+    );\r
+  ERROR_CHECK (OpalPerformMethod (Session, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
   if (*MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     return TcgResultSuccess; // return early if method failed - user must check MethodStatus\r
   }\r
 \r
-  if (TcgParseSyncSession(&ParseStruct, Session->OpalBaseComId, ComIdExtension, HostSessionId, &Session->TperSessionId) != TcgResultSuccess) {\r
-    OpalEndSession(Session);\r
+  if (TcgParseSyncSession (&ParseStruct, Session->OpalBaseComId, ComIdExtension, HostSessionId, &Session->TperSessionId) != TcgResultSuccess) {\r
+    OpalEndSession (Session);\r
     return TcgResultFailure;\r
   }\r
 \r
@@ -509,50 +515,56 @@ OpalStartSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalEndSession(\r
-  OPAL_SESSION     *Session\r
+OpalEndSession (\r
+  OPAL_SESSION  *Session\r
   )\r
 {\r
-  UINT8             Buffer[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  UINT32            Size;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-\r
-  NULL_CHECK(Session);\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buffer, sizeof(Buffer)));\r
-  ERROR_CHECK(TcgCreateEndSession(\r
-                  &CreateStruct,\r
-                  &Size,\r
-                  Session->OpalBaseComId,\r
-                  Session->ComIdExtension,\r
-                  Session->HostSessionId,\r
-                  Session->TperSessionId\r
-                ));\r
-\r
-  ERROR_CHECK(OpalTrustedSend(\r
-                  Session->Sscp,\r
-                  Session->MediaId,\r
-                  TCG_OPAL_SECURITY_PROTOCOL_1,\r
-                  Session->OpalBaseComId,\r
-                  Size,\r
-                  Buffer,\r
-                  sizeof(Buffer)\r
-              ));\r
-\r
-  ERROR_CHECK(OpalTrustedRecv(\r
-                  Session->Sscp,\r
-                  Session->MediaId,\r
-                  TCG_OPAL_SECURITY_PROTOCOL_1,\r
-                  Session->OpalBaseComId,\r
-                  Buffer,\r
-                  sizeof(Buffer),\r
-                  0\r
-              ));\r
-\r
-  ERROR_CHECK(TcgInitTcgParseStruct(&ParseStruct, Buffer, sizeof(Buffer)));\r
-  ERROR_CHECK(TcgCheckComIds(&ParseStruct, Session->OpalBaseComId, Session->ComIdExtension));\r
-\r
-  ERROR_CHECK(TcgGetNextEndOfSession(&ParseStruct));\r
+  UINT8              Buffer[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  UINT32             Size;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+\r
+  NULL_CHECK (Session);\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buffer, sizeof (Buffer)));\r
+  ERROR_CHECK (\r
+    TcgCreateEndSession (\r
+      &CreateStruct,\r
+      &Size,\r
+      Session->OpalBaseComId,\r
+      Session->ComIdExtension,\r
+      Session->HostSessionId,\r
+      Session->TperSessionId\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (\r
+    OpalTrustedSend (\r
+      Session->Sscp,\r
+      Session->MediaId,\r
+      TCG_OPAL_SECURITY_PROTOCOL_1,\r
+      Session->OpalBaseComId,\r
+      Size,\r
+      Buffer,\r
+      sizeof (Buffer)\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (\r
+    OpalTrustedRecv (\r
+      Session->Sscp,\r
+      Session->MediaId,\r
+      TCG_OPAL_SECURITY_PROTOCOL_1,\r
+      Session->OpalBaseComId,\r
+      Buffer,\r
+      sizeof (Buffer),\r
+      0\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (TcgInitTcgParseStruct (&ParseStruct, Buffer, sizeof (Buffer)));\r
+  ERROR_CHECK (TcgCheckComIds (&ParseStruct, Session->OpalBaseComId, Session->ComIdExtension));\r
+\r
+  ERROR_CHECK (TcgGetNextEndOfSession (&ParseStruct));\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -568,11 +580,11 @@ OpalEndSession(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGetMsid(\r
-  OPAL_SESSION    *AdminSpSession,\r
-  UINT32          MsidBufferSize,\r
-  UINT8           *Msid,\r
-  UINT32          *MsidLength\r
+OpalGetMsid (\r
+  OPAL_SESSION  *AdminSpSession,\r
+  UINT32        MsidBufferSize,\r
+  UINT8         *Msid,\r
+  UINT32        *MsidLength\r
   )\r
 {\r
   //\r
@@ -580,55 +592,55 @@ OpalGetMsid(
   // we'll attempt to start Session as PSID authority\r
   // verify PSID Authority is defined in ADMIN SP authority table... is this possible?\r
   //\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
-  UINT8             MethodStatus;\r
-  UINT32            Col;\r
-  const VOID        *RecvMsid;\r
-  UINT8             Buffer[BUFFER_SIZE];\r
-\r
-  NULL_CHECK(AdminSpSession);\r
-  NULL_CHECK(Msid);\r
-  NULL_CHECK(MsidLength);\r
-\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buffer, BUFFER_SIZE));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, OPAL_UID_ADMIN_SP_C_PIN_MSID, TCG_UID_METHOD_GET));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartList(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, TCG_CELL_BLOCK_START_COLUMN_NAME));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, OPAL_ADMIN_SP_PIN_COL));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, TCG_CELL_BLOCK_END_COLUMN_NAME));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, OPAL_ADMIN_SP_PIN_COL));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddEndList(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
+  UINT8              MethodStatus;\r
+  UINT32             Col;\r
+  const VOID         *RecvMsid;\r
+  UINT8              Buffer[BUFFER_SIZE];\r
+\r
+  NULL_CHECK (AdminSpSession);\r
+  NULL_CHECK (Msid);\r
+  NULL_CHECK (MsidLength);\r
+\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buffer, BUFFER_SIZE));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, OPAL_UID_ADMIN_SP_C_PIN_MSID, TCG_UID_METHOD_GET));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartList (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, TCG_CELL_BLOCK_START_COLUMN_NAME));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, OPAL_ADMIN_SP_PIN_COL));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, TCG_CELL_BLOCK_END_COLUMN_NAME));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, OPAL_ADMIN_SP_PIN_COL));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddEndList (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
 \r
   //\r
   // Send MSID Method Call\r
   //\r
-  ERROR_CHECK(OpalPerformMethod(AdminSpSession, Size, Buffer, BUFFER_SIZE, &ParseStruct, &MethodStatus, 0));\r
-  METHOD_STATUS_ERROR_CHECK(MethodStatus, TcgResultFailure);\r
+  ERROR_CHECK (OpalPerformMethod (AdminSpSession, Size, Buffer, BUFFER_SIZE, &ParseStruct, &MethodStatus, 0));\r
+  METHOD_STATUS_ERROR_CHECK (MethodStatus, TcgResultFailure);\r
 \r
-  ERROR_CHECK(TcgGetNextStartList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextStartList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextStartName(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextUINT32(&ParseStruct, &Col));\r
-  ERROR_CHECK(TcgGetNextByteSequence(&ParseStruct, &RecvMsid, MsidLength));\r
-  ERROR_CHECK(TcgGetNextEndName(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndOfData(&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartName (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextUINT32 (&ParseStruct, &Col));\r
+  ERROR_CHECK (TcgGetNextByteSequence (&ParseStruct, &RecvMsid, MsidLength));\r
+  ERROR_CHECK (TcgGetNextEndName (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndOfData (&ParseStruct));\r
 \r
   if (Col != OPAL_ADMIN_SP_PIN_COL) {\r
     DEBUG ((DEBUG_INFO, "ERROR: got col %u, expected %u\n", Col, OPAL_ADMIN_SP_PIN_COL));\r
@@ -647,7 +659,7 @@ OpalGetMsid(
   //\r
   // copy msid into Buffer\r
   //\r
-  CopyMem(Msid, RecvMsid, *MsidLength);\r
+  CopyMem (Msid, RecvMsid, *MsidLength);\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -661,58 +673,58 @@ OpalGetMsid(
 **/\r
 TCG_RESULT\r
 OpalPyrite2GetActiveDataRemovalMechanism (\r
-  IN  OPAL_SESSION    *AdminSpSession,\r
-  OUT UINT8           *ActiveDataRemovalMechanism\r
+  IN  OPAL_SESSION  *AdminSpSession,\r
+  OUT UINT8         *ActiveDataRemovalMechanism\r
   )\r
 {\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
-  UINT8             MethodStatus;\r
-  UINT32            Col;\r
-  UINT8             RecvActiveDataRemovalMechanism;\r
-  UINT8             Buffer[BUFFER_SIZE];\r
-\r
-  NULL_CHECK(AdminSpSession);\r
-  NULL_CHECK(ActiveDataRemovalMechanism);\r
-\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buffer, BUFFER_SIZE));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, OPAL_UID_ADMIN_SP_DATA_REMOVAL_MECHANISM, TCG_UID_METHOD_GET));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartList(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, TCG_CELL_BLOCK_START_COLUMN_NAME));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, OPAL_ADMIN_SP_ACTIVE_DATA_REMOVAL_MECHANISM_COL));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, TCG_CELL_BLOCK_END_COLUMN_NAME));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, OPAL_ADMIN_SP_ACTIVE_DATA_REMOVAL_MECHANISM_COL));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddEndList(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
+  UINT8              MethodStatus;\r
+  UINT32             Col;\r
+  UINT8              RecvActiveDataRemovalMechanism;\r
+  UINT8              Buffer[BUFFER_SIZE];\r
+\r
+  NULL_CHECK (AdminSpSession);\r
+  NULL_CHECK (ActiveDataRemovalMechanism);\r
+\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buffer, BUFFER_SIZE));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, OPAL_UID_ADMIN_SP_DATA_REMOVAL_MECHANISM, TCG_UID_METHOD_GET));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartList (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, TCG_CELL_BLOCK_START_COLUMN_NAME));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, OPAL_ADMIN_SP_ACTIVE_DATA_REMOVAL_MECHANISM_COL));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, TCG_CELL_BLOCK_END_COLUMN_NAME));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, OPAL_ADMIN_SP_ACTIVE_DATA_REMOVAL_MECHANISM_COL));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddEndList (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
 \r
   //\r
   // Send Get Active Data Removal Mechanism Method Call\r
   //\r
-  ERROR_CHECK(OpalPerformMethod(AdminSpSession, Size, Buffer, BUFFER_SIZE, &ParseStruct, &MethodStatus, 0));\r
-  METHOD_STATUS_ERROR_CHECK(MethodStatus, TcgResultFailure);\r
+  ERROR_CHECK (OpalPerformMethod (AdminSpSession, Size, Buffer, BUFFER_SIZE, &ParseStruct, &MethodStatus, 0));\r
+  METHOD_STATUS_ERROR_CHECK (MethodStatus, TcgResultFailure);\r
 \r
-  ERROR_CHECK(TcgGetNextStartList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextStartList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextStartName(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextUINT32(&ParseStruct, &Col));\r
-  ERROR_CHECK(TcgGetNextUINT8(&ParseStruct, &RecvActiveDataRemovalMechanism));\r
-  ERROR_CHECK(TcgGetNextEndName(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndOfData(&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartName (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextUINT32 (&ParseStruct, &Col));\r
+  ERROR_CHECK (TcgGetNextUINT8 (&ParseStruct, &RecvActiveDataRemovalMechanism));\r
+  ERROR_CHECK (TcgGetNextEndName (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndOfData (&ParseStruct));\r
 \r
   if (Col != OPAL_ADMIN_SP_ACTIVE_DATA_REMOVAL_MECHANISM_COL) {\r
     DEBUG ((DEBUG_INFO, "ERROR: got col %u, expected %u\n", Col, OPAL_ADMIN_SP_ACTIVE_DATA_REMOVAL_MECHANISM_COL));\r
@@ -726,7 +738,7 @@ OpalPyrite2GetActiveDataRemovalMechanism (
   //\r
   // Copy active data removal mechanism into Buffer\r
   //\r
-  CopyMem(ActiveDataRemovalMechanism, &RecvActiveDataRemovalMechanism, sizeof(RecvActiveDataRemovalMechanism));\r
+  CopyMem (ActiveDataRemovalMechanism, &RecvActiveDataRemovalMechanism, sizeof (RecvActiveDataRemovalMechanism));\r
   return TcgResultSuccess;\r
 }\r
 \r
@@ -742,20 +754,20 @@ OpalPyrite2GetActiveDataRemovalMechanism (
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalAdminRevert(\r
-  OPAL_SESSION    *LockingSpSession,\r
-  BOOLEAN         KeepUserData,\r
-  UINT8           *MethodStatus\r
+OpalAdminRevert (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  BOOLEAN       KeepUserData,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  UINT32            Size;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  TCG_RESULT        Ret;\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  UINT32             Size;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  TCG_RESULT         Ret;\r
 \r
-  NULL_CHECK(LockingSpSession);\r
-  NULL_CHECK(MethodStatus);\r
+  NULL_CHECK (LockingSpSession);\r
+  NULL_CHECK (MethodStatus);\r
 \r
   //\r
   // ReadLocked or WriteLocked must be False (per Opal spec) to guarantee revertSP can keep user Data\r
@@ -764,13 +776,14 @@ OpalAdminRevert(
     //\r
     // set readlocked and writelocked to false\r
     //\r
-    Ret = OpalUpdateGlobalLockingRange(\r
-                        LockingSpSession,\r
-                        FALSE,\r
-                        FALSE,\r
-                        MethodStatus);\r
-\r
-    if (Ret != TcgResultSuccess || *MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+    Ret = OpalUpdateGlobalLockingRange (\r
+            LockingSpSession,\r
+            FALSE,\r
+            FALSE,\r
+            MethodStatus\r
+            );\r
+\r
+    if ((Ret != TcgResultSuccess) || (*MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
       //\r
       // bail out\r
       //\r
@@ -778,33 +791,33 @@ OpalAdminRevert(
     }\r
   }\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, TCG_UID_THIS_SP, OPAL_LOCKING_SP_REVERTSP_METHOD));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, TCG_UID_THIS_SP, OPAL_LOCKING_SP_REVERTSP_METHOD));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
 \r
   if (KeepUserData) {\r
     //\r
     // optional parameter to keep Data after revert\r
     //\r
-    ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-    ERROR_CHECK(TcgAddUINT32(&CreateStruct, 0x060000));      // weird Value but that's what spec says\r
-    ERROR_CHECK(TcgAddBOOLEAN(&CreateStruct, KeepUserData));\r
-    ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
+    ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+    ERROR_CHECK (TcgAddUINT32 (&CreateStruct, 0x060000));      // weird Value but that's what spec says\r
+    ERROR_CHECK (TcgAddBOOLEAN (&CreateStruct, KeepUserData));\r
+    ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
   }\r
 \r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
 \r
   //\r
   // Send RevertSP method call\r
   //\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   //\r
   // Session is immediately ended by device after successful revertsp, so no need to end Session\r
@@ -818,13 +831,12 @@ OpalAdminRevert(
     //\r
     // End Session\r
     //\r
-    METHOD_STATUS_ERROR_CHECK(*MethodStatus, TcgResultSuccess);     // exit with success on method failure - user must inspect MethodStatus\r
+    METHOD_STATUS_ERROR_CHECK (*MethodStatus, TcgResultSuccess);     // exit with success on method failure - user must inspect MethodStatus\r
   }\r
 \r
   return TcgResultSuccess;\r
 }\r
 \r
-\r
 /**\r
 \r
   The function calls the Admin SP RevertSP method on the Locking SP.  If KeepUserData is True, then the optional parameter\r
@@ -837,21 +849,21 @@ OpalAdminRevert(
 \r
 **/\r
 TCG_RESULT\r
-OpalPyrite2AdminRevert(\r
-  OPAL_SESSION    *LockingSpSession,\r
-  BOOLEAN         KeepUserData,\r
-  UINT8           *MethodStatus,\r
-  UINT32          EstimateTimeCost\r
+OpalPyrite2AdminRevert (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  BOOLEAN       KeepUserData,\r
+  UINT8         *MethodStatus,\r
+  UINT32        EstimateTimeCost\r
   )\r
 {\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  UINT32            Size;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  TCG_RESULT        Ret;\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  UINT32             Size;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  TCG_RESULT         Ret;\r
 \r
-  NULL_CHECK(LockingSpSession);\r
-  NULL_CHECK(MethodStatus);\r
+  NULL_CHECK (LockingSpSession);\r
+  NULL_CHECK (MethodStatus);\r
 \r
   //\r
   // ReadLocked or WriteLocked must be False (per Opal spec) to guarantee revertSP can keep user Data\r
@@ -860,13 +872,14 @@ OpalPyrite2AdminRevert(
     //\r
     // set readlocked and writelocked to false\r
     //\r
-    Ret = OpalUpdateGlobalLockingRange(\r
-                        LockingSpSession,\r
-                        FALSE,\r
-                        FALSE,\r
-                        MethodStatus);\r
-\r
-    if (Ret != TcgResultSuccess || *MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+    Ret = OpalUpdateGlobalLockingRange (\r
+            LockingSpSession,\r
+            FALSE,\r
+            FALSE,\r
+            MethodStatus\r
+            );\r
+\r
+    if ((Ret != TcgResultSuccess) || (*MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
       //\r
       // bail out\r
       //\r
@@ -874,33 +887,33 @@ OpalPyrite2AdminRevert(
     }\r
   }\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, TCG_UID_THIS_SP, OPAL_LOCKING_SP_REVERTSP_METHOD));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, TCG_UID_THIS_SP, OPAL_LOCKING_SP_REVERTSP_METHOD));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
 \r
   if (KeepUserData) {\r
     //\r
     // optional parameter to keep Data after revert\r
     //\r
-    ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-    ERROR_CHECK(TcgAddUINT32(&CreateStruct, 0x060000));      // weird Value but that's what spec says\r
-    ERROR_CHECK(TcgAddBOOLEAN(&CreateStruct, KeepUserData));\r
-    ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
+    ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+    ERROR_CHECK (TcgAddUINT32 (&CreateStruct, 0x060000));      // weird Value but that's what spec says\r
+    ERROR_CHECK (TcgAddBOOLEAN (&CreateStruct, KeepUserData));\r
+    ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
   }\r
 \r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
 \r
   //\r
   // Send RevertSP method call\r
   //\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, EstimateTimeCost));\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, EstimateTimeCost));\r
 \r
   //\r
   // Session is immediately ended by device after successful revertsp, so no need to end Session\r
@@ -914,7 +927,7 @@ OpalPyrite2AdminRevert(
     //\r
     // End Session\r
     //\r
-    METHOD_STATUS_ERROR_CHECK(*MethodStatus, TcgResultSuccess);     // exit with success on method failure - user must inspect MethodStatus\r
+    METHOD_STATUS_ERROR_CHECK (*MethodStatus, TcgResultSuccess);     // exit with success on method failure - user must inspect MethodStatus\r
   }\r
 \r
   return TcgResultSuccess;\r
@@ -932,39 +945,39 @@ OpalPyrite2AdminRevert(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalActivateLockingSp(\r
-  OPAL_SESSION           *AdminSpSession,\r
-  UINT8                  *MethodStatus\r
+OpalActivateLockingSp (\r
+  OPAL_SESSION  *AdminSpSession,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  UINT32            Size;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  UINT32             Size;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
 \r
-  NULL_CHECK(AdminSpSession);\r
-  NULL_CHECK(MethodStatus);\r
+  NULL_CHECK (AdminSpSession);\r
+  NULL_CHECK (MethodStatus);\r
 \r
   //\r
   // Call Activate method on Locking SP\r
   //\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, OPAL_UID_LOCKING_SP, OPAL_ADMIN_SP_ACTIVATE_METHOD));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, AdminSpSession->OpalBaseComId, AdminSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, AdminSpSession->TperSessionId, AdminSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, OPAL_UID_LOCKING_SP, OPAL_ADMIN_SP_ACTIVATE_METHOD));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
 \r
   //\r
   // Send Activate method call\r
   //\r
-  ERROR_CHECK(OpalPerformMethod(AdminSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
-  METHOD_STATUS_ERROR_CHECK(*MethodStatus, TcgResultSuccess); // exit with success on method failure - user must inspect MethodStatus\r
+  ERROR_CHECK (OpalPerformMethod (AdminSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
+  METHOD_STATUS_ERROR_CHECK (*MethodStatus, TcgResultSuccess); // exit with success on method failure - user must inspect MethodStatus\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -982,39 +995,41 @@ OpalActivateLockingSp(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalSetPassword(\r
-  OPAL_SESSION   *Session,\r
-  TCG_UID        CpinRowUid,\r
-  const VOID     *NewPin,\r
-  UINT32         NewPinLength,\r
-  UINT8          *MethodStatus\r
+OpalSetPassword (\r
+  OPAL_SESSION  *Session,\r
+  TCG_UID       CpinRowUid,\r
+  const VOID    *NewPin,\r
+  UINT32        NewPinLength,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
-\r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(NewPin);\r
-  NULL_CHECK(MethodStatus);\r
-\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgCreateSetCPin(\r
-                         &CreateStruct,\r
-                         &Size,\r
-                         Session->OpalBaseComId,\r
-                         Session->ComIdExtension,\r
-                         Session->TperSessionId,\r
-                         Session->HostSessionId,\r
-                         CpinRowUid,\r
-                         NewPin,\r
-                         NewPinLength\r
-                         ));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(Session, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
+\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (NewPin);\r
+  NULL_CHECK (MethodStatus);\r
+\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (\r
+    TcgCreateSetCPin (\r
+      &CreateStruct,\r
+      &Size,\r
+      Session->OpalBaseComId,\r
+      Session->ComIdExtension,\r
+      Session->TperSessionId,\r
+      Session->HostSessionId,\r
+      CpinRowUid,\r
+      NewPin,\r
+      NewPinLength\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (OpalPerformMethod (Session, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
   // exit with success on method failure - user must inspect MethodStatus\r
-  METHOD_STATUS_ERROR_CHECK(*MethodStatus, TcgResultSuccess);\r
+  METHOD_STATUS_ERROR_CHECK (*MethodStatus, TcgResultSuccess);\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -1034,129 +1049,141 @@ OpalSetPassword(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalSetLockingSpAuthorityEnabledAndPin(\r
-  OPAL_SESSION    *LockingSpSession,\r
-  TCG_UID         CpinRowUid,\r
-  TCG_UID         AuthorityUid,\r
-  const VOID      *NewPin,\r
-  UINT32          NewPinLength,\r
-  UINT8           *MethodStatus\r
+OpalSetLockingSpAuthorityEnabledAndPin (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  TCG_UID       CpinRowUid,\r
+  TCG_UID       AuthorityUid,\r
+  const VOID    *NewPin,\r
+  UINT32        NewPinLength,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
-  TCG_UID           ActiveKey;\r
-  TCG_RESULT        Ret;\r
-\r
-  NULL_CHECK(LockingSpSession);\r
-  NULL_CHECK(NewPin);\r
-  NULL_CHECK(MethodStatus);\r
-\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgSetAuthorityEnabled(\r
-                  &CreateStruct,\r
-                  &Size,\r
-                  LockingSpSession->OpalBaseComId,\r
-                  LockingSpSession->ComIdExtension,\r
-                  LockingSpSession->TperSessionId,\r
-                  LockingSpSession->HostSessionId,\r
-                  AuthorityUid,\r
-                  TRUE));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
+  TCG_UID            ActiveKey;\r
+  TCG_RESULT         Ret;\r
+\r
+  NULL_CHECK (LockingSpSession);\r
+  NULL_CHECK (NewPin);\r
+  NULL_CHECK (MethodStatus);\r
+\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (\r
+    TcgSetAuthorityEnabled (\r
+      &CreateStruct,\r
+      &Size,\r
+      LockingSpSession->OpalBaseComId,\r
+      LockingSpSession->ComIdExtension,\r
+      LockingSpSession->TperSessionId,\r
+      LockingSpSession->HostSessionId,\r
+      AuthorityUid,\r
+      TRUE\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   if (*MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Send Set Authority error\n"));\r
     return TcgResultFailure;\r
   }\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
 \r
-  ERROR_CHECK(TcgCreateSetCPin(\r
-                  &CreateStruct,\r
-                  &Size,\r
-                  LockingSpSession->OpalBaseComId,\r
-                  LockingSpSession->ComIdExtension,\r
-                  LockingSpSession->TperSessionId,\r
-                  LockingSpSession->HostSessionId,\r
-                  CpinRowUid,\r
-                  NewPin,\r
-                  NewPinLength));\r
+  ERROR_CHECK (\r
+    TcgCreateSetCPin (\r
+      &CreateStruct,\r
+      &Size,\r
+      LockingSpSession->OpalBaseComId,\r
+      LockingSpSession->ComIdExtension,\r
+      LockingSpSession->TperSessionId,\r
+      LockingSpSession->HostSessionId,\r
+      CpinRowUid,\r
+      NewPin,\r
+      NewPinLength\r
+      )\r
+    );\r
 \r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   //\r
   // allow user1 to set global range to unlocked/locked by modifying ACE_Locking_GlobalRange_SetRdLocked/SetWrLocked\r
   //\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgCreateSetAce(\r
-                  &CreateStruct,\r
-                  &Size,\r
-                  LockingSpSession->OpalBaseComId,\r
-                  LockingSpSession->ComIdExtension,\r
-                  LockingSpSession->TperSessionId,\r
-                  LockingSpSession->HostSessionId,\r
-                  OPAL_LOCKING_SP_ACE_LOCKING_GLOBALRANGE_SET_RDLOCKED,\r
-                  OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                  TCG_ACE_EXPRESSION_OR,\r
-                  OPAL_LOCKING_SP_ADMINS_AUTHORITY\r
-              ));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (\r
+    TcgCreateSetAce (\r
+      &CreateStruct,\r
+      &Size,\r
+      LockingSpSession->OpalBaseComId,\r
+      LockingSpSession->ComIdExtension,\r
+      LockingSpSession->TperSessionId,\r
+      LockingSpSession->HostSessionId,\r
+      OPAL_LOCKING_SP_ACE_LOCKING_GLOBALRANGE_SET_RDLOCKED,\r
+      OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+      TCG_ACE_EXPRESSION_OR,\r
+      OPAL_LOCKING_SP_ADMINS_AUTHORITY\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   if (*MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Update ACE for RDLOCKED failed\n"));\r
     return TcgResultFailure;\r
   }\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgCreateSetAce(\r
-                  &CreateStruct,\r
-                  &Size,\r
-                  LockingSpSession->OpalBaseComId,\r
-                  LockingSpSession->ComIdExtension,\r
-                  LockingSpSession->TperSessionId,\r
-                  LockingSpSession->HostSessionId,\r
-                  OPAL_LOCKING_SP_ACE_LOCKING_GLOBALRANGE_SET_WRLOCKED,\r
-                  OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                  TCG_ACE_EXPRESSION_OR,\r
-                  OPAL_LOCKING_SP_ADMINS_AUTHORITY\r
-              ));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (\r
+    TcgCreateSetAce (\r
+      &CreateStruct,\r
+      &Size,\r
+      LockingSpSession->OpalBaseComId,\r
+      LockingSpSession->ComIdExtension,\r
+      LockingSpSession->TperSessionId,\r
+      LockingSpSession->HostSessionId,\r
+      OPAL_LOCKING_SP_ACE_LOCKING_GLOBALRANGE_SET_WRLOCKED,\r
+      OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+      TCG_ACE_EXPRESSION_OR,\r
+      OPAL_LOCKING_SP_ADMINS_AUTHORITY\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   if (*MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Update ACE for WRLOCKED failed\n"));\r
     return TcgResultFailure;\r
   }\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(OpalCreateRetrieveGlobalLockingRangeActiveKey(LockingSpSession, &CreateStruct, &Size));\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (OpalCreateRetrieveGlobalLockingRangeActiveKey (LockingSpSession, &CreateStruct, &Size));\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   //\r
   // For Pyrite type SSC, it not supports Active Key.\r
   // So here add check logic before enable it.\r
   //\r
-  Ret = OpalParseRetrieveGlobalLockingRangeActiveKey(&ParseStruct, &ActiveKey);\r
+  Ret = OpalParseRetrieveGlobalLockingRangeActiveKey (&ParseStruct, &ActiveKey);\r
   if (Ret == TcgResultSuccess) {\r
-    ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-    ERROR_CHECK(TcgCreateSetAce(\r
-                    &CreateStruct,\r
-                    &Size,\r
-                    LockingSpSession->OpalBaseComId,\r
-                    LockingSpSession->ComIdExtension,\r
-                    LockingSpSession->TperSessionId,\r
-                    LockingSpSession->HostSessionId,\r
-                    (ActiveKey == OPAL_LOCKING_SP_K_AES_256_GLOBALRANGE_KEY) ? OPAL_LOCKING_SP_ACE_K_AES_256_GLOBALRANGE_GENKEY : OPAL_LOCKING_SP_ACE_K_AES_128_GLOBALRANGE_GENKEY,\r
-                    OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                    TCG_ACE_EXPRESSION_OR,\r
-                    OPAL_LOCKING_SP_ADMINS_AUTHORITY\r
-                ));\r
-\r
-    ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+    ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+    ERROR_CHECK (\r
+      TcgCreateSetAce (\r
+        &CreateStruct,\r
+        &Size,\r
+        LockingSpSession->OpalBaseComId,\r
+        LockingSpSession->ComIdExtension,\r
+        LockingSpSession->TperSessionId,\r
+        LockingSpSession->HostSessionId,\r
+        (ActiveKey == OPAL_LOCKING_SP_K_AES_256_GLOBALRANGE_KEY) ? OPAL_LOCKING_SP_ACE_K_AES_256_GLOBALRANGE_GENKEY : OPAL_LOCKING_SP_ACE_K_AES_128_GLOBALRANGE_GENKEY,\r
+        OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+        TCG_ACE_EXPRESSION_OR,\r
+        OPAL_LOCKING_SP_ADMINS_AUTHORITY\r
+        )\r
+      );\r
+\r
+    ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
     if (*MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
       DEBUG ((DEBUG_INFO, "Update ACE for GLOBALRANGE_GENKEY failed\n"));\r
@@ -1167,21 +1194,23 @@ OpalSetLockingSpAuthorityEnabledAndPin(
     }\r
   }\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgCreateSetAce(\r
-                  &CreateStruct,\r
-                  &Size,\r
-                  LockingSpSession->OpalBaseComId,\r
-                  LockingSpSession->ComIdExtension,\r
-                  LockingSpSession->TperSessionId,\r
-                  LockingSpSession->HostSessionId,\r
-                  OPAL_LOCKING_SP_ACE_LOCKING_GLOBALRANGE_GET_ALL,\r
-                  OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                  TCG_ACE_EXPRESSION_OR,\r
-                  OPAL_LOCKING_SP_ADMINS_AUTHORITY\r
-              ));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (\r
+    TcgCreateSetAce (\r
+      &CreateStruct,\r
+      &Size,\r
+      LockingSpSession->OpalBaseComId,\r
+      LockingSpSession->ComIdExtension,\r
+      LockingSpSession->TperSessionId,\r
+      LockingSpSession->HostSessionId,\r
+      OPAL_LOCKING_SP_ACE_LOCKING_GLOBALRANGE_GET_ALL,\r
+      OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+      TCG_ACE_EXPRESSION_OR,\r
+      OPAL_LOCKING_SP_ADMINS_AUTHORITY\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   if (*MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     DEBUG ((DEBUG_INFO, "Update ACE for OPAL_LOCKING_SP_ACE_LOCKING_GLOBALRANGE_GET_ALL failed\n"));\r
@@ -1201,31 +1230,34 @@ OpalSetLockingSpAuthorityEnabledAndPin(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalDisableUser(\r
-  OPAL_SESSION     *LockingSpSession,\r
-  UINT8            *MethodStatus\r
+OpalDisableUser (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
-\r
-  NULL_CHECK(LockingSpSession);\r
-  NULL_CHECK(MethodStatus);\r
-\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgSetAuthorityEnabled(\r
-                  &CreateStruct,\r
-                  &Size,\r
-                  LockingSpSession->OpalBaseComId,\r
-                  LockingSpSession->ComIdExtension,\r
-                  LockingSpSession->TperSessionId,\r
-                  LockingSpSession->HostSessionId,\r
-                  OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                  FALSE));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
+\r
+  NULL_CHECK (LockingSpSession);\r
+  NULL_CHECK (MethodStatus);\r
+\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (\r
+    TcgSetAuthorityEnabled (\r
+      &CreateStruct,\r
+      &Size,\r
+      LockingSpSession->OpalBaseComId,\r
+      LockingSpSession->ComIdExtension,\r
+      LockingSpSession->TperSessionId,\r
+      LockingSpSession->HostSessionId,\r
+      OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+      FALSE\r
+      )\r
+    );\r
+\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -1241,47 +1273,47 @@ OpalDisableUser(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGlobalLockingRangeGenKey(\r
-  OPAL_SESSION   *LockingSpSession,\r
-  UINT8          *MethodStatus\r
+OpalGlobalLockingRangeGenKey (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
-  TCG_UID           ActiveKey;\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
+  TCG_UID            ActiveKey;\r
 \r
-  NULL_CHECK(LockingSpSession);\r
-  NULL_CHECK(MethodStatus);\r
+  NULL_CHECK (LockingSpSession);\r
+  NULL_CHECK (MethodStatus);\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
   //\r
   // retrieve the activekey in order to know which globalrange key to generate\r
   //\r
-  ERROR_CHECK(OpalCreateRetrieveGlobalLockingRangeActiveKey(LockingSpSession, &CreateStruct, &Size));\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (OpalCreateRetrieveGlobalLockingRangeActiveKey (LockingSpSession, &CreateStruct, &Size));\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
-  METHOD_STATUS_ERROR_CHECK(*MethodStatus, TcgResultSuccess);\r
+  METHOD_STATUS_ERROR_CHECK (*MethodStatus, TcgResultSuccess);\r
 \r
-  ERROR_CHECK(OpalParseRetrieveGlobalLockingRangeActiveKey(&ParseStruct, &ActiveKey));\r
+  ERROR_CHECK (OpalParseRetrieveGlobalLockingRangeActiveKey (&ParseStruct, &ActiveKey));\r
 \r
   //\r
   // call genkey on ActiveKey UID\r
   //\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, ActiveKey, TCG_UID_METHOD_GEN_KEY));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, ActiveKey, TCG_UID_METHOD_GEN_KEY));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
 \r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -1300,55 +1332,55 @@ OpalGlobalLockingRangeGenKey(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUpdateGlobalLockingRange(\r
-  OPAL_SESSION             *LockingSpSession,\r
-  BOOLEAN                  ReadLocked,\r
-  BOOLEAN                  WriteLocked,\r
-  UINT8                    *MethodStatus\r
+OpalUpdateGlobalLockingRange (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  BOOLEAN       ReadLocked,\r
+  BOOLEAN       WriteLocked,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
 \r
-  NULL_CHECK(LockingSpSession);\r
-  NULL_CHECK(MethodStatus);\r
+  NULL_CHECK (LockingSpSession);\r
+  NULL_CHECK (MethodStatus);\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
 \r
   //\r
   // set global locking range values\r
   //\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, OPAL_LOCKING_SP_LOCKING_GLOBALRANGE, TCG_UID_METHOD_SET));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x01));                       // "Values"\r
-  ERROR_CHECK(TcgAddStartList(&CreateStruct));\r
-\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x07));                       // "ReadLocked"\r
-  ERROR_CHECK(TcgAddBOOLEAN(&CreateStruct, ReadLocked));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x08));                       // "WriteLocked"\r
-  ERROR_CHECK(TcgAddBOOLEAN(&CreateStruct, WriteLocked));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-\r
-  ERROR_CHECK(TcgAddEndList(&CreateStruct));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
-  METHOD_STATUS_ERROR_CHECK(*MethodStatus, TcgResultSuccess);\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, OPAL_LOCKING_SP_LOCKING_GLOBALRANGE, TCG_UID_METHOD_SET));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x01));                       // "Values"\r
+  ERROR_CHECK (TcgAddStartList (&CreateStruct));\r
+\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x07));                       // "ReadLocked"\r
+  ERROR_CHECK (TcgAddBOOLEAN (&CreateStruct, ReadLocked));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x08));                       // "WriteLocked"\r
+  ERROR_CHECK (TcgAddBOOLEAN (&CreateStruct, WriteLocked));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+\r
+  ERROR_CHECK (TcgAddEndList (&CreateStruct));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
+\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
+  METHOD_STATUS_ERROR_CHECK (*MethodStatus, TcgResultSuccess);\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -1371,86 +1403,86 @@ OpalUpdateGlobalLockingRange(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalSetLockingRange(\r
-  OPAL_SESSION      *LockingSpSession,\r
-  TCG_UID           LockingRangeUid,\r
-  UINT64            RangeStart,\r
-  UINT64            RangeLength,\r
-  BOOLEAN           ReadLockEnabled,\r
-  BOOLEAN           WriteLockEnabled,\r
-  BOOLEAN           ReadLocked,\r
-  BOOLEAN           WriteLocked,\r
-  UINT8             *MethodStatus\r
+OpalSetLockingRange (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  TCG_UID       LockingRangeUid,\r
+  UINT64        RangeStart,\r
+  UINT64        RangeLength,\r
+  BOOLEAN       ReadLockEnabled,\r
+  BOOLEAN       WriteLockEnabled,\r
+  BOOLEAN       ReadLocked,\r
+  BOOLEAN       WriteLocked,\r
+  UINT8         *MethodStatus\r
   )\r
 {\r
-  UINT8           Buf[BUFFER_SIZE];\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32          Size;\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
 \r
-  NULL_CHECK(LockingSpSession);\r
-  NULL_CHECK(MethodStatus);\r
+  NULL_CHECK (LockingSpSession);\r
+  NULL_CHECK (MethodStatus);\r
 \r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
 \r
   //\r
   // set locking range values\r
   //\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, LockingRangeUid, TCG_UID_METHOD_SET));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x01));                        // "Values"\r
-  ERROR_CHECK(TcgAddStartList(&CreateStruct));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, LockingRangeUid, TCG_UID_METHOD_SET));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x01));                        // "Values"\r
+  ERROR_CHECK (TcgAddStartList (&CreateStruct));\r
 \r
   //\r
   // range start and range Length only apply to non-global locking ranges\r
   //\r
   if (LockingRangeUid != OPAL_LOCKING_SP_LOCKING_GLOBALRANGE) {\r
-    ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-    ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x03));                       // "RangeStart"\r
-    ERROR_CHECK(TcgAddUINT64(&CreateStruct, RangeStart));\r
-    ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-\r
-    ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-    ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x04));                       // "RangeLength"\r
-    ERROR_CHECK(TcgAddUINT64(&CreateStruct, RangeLength));\r
-    ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
+    ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+    ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x03));                       // "RangeStart"\r
+    ERROR_CHECK (TcgAddUINT64 (&CreateStruct, RangeStart));\r
+    ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+\r
+    ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+    ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x04));                       // "RangeLength"\r
+    ERROR_CHECK (TcgAddUINT64 (&CreateStruct, RangeLength));\r
+    ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
   }\r
 \r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x05));                       // "ReadLockEnabled"\r
-  ERROR_CHECK(TcgAddBOOLEAN(&CreateStruct, ReadLockEnabled));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x06));                       // "WriteLockEnabled"\r
-  ERROR_CHECK(TcgAddBOOLEAN(&CreateStruct, WriteLockEnabled));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x07));                       // "ReadLocked"\r
-  ERROR_CHECK(TcgAddBOOLEAN(&CreateStruct, ReadLocked));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, 0x08));                       // "WriteLocked"\r
-  ERROR_CHECK(TcgAddBOOLEAN(&CreateStruct, WriteLocked));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-\r
-  ERROR_CHECK(TcgAddEndList(&CreateStruct));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, MethodStatus, 0));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x05));                       // "ReadLockEnabled"\r
+  ERROR_CHECK (TcgAddBOOLEAN (&CreateStruct, ReadLockEnabled));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x06));                       // "WriteLockEnabled"\r
+  ERROR_CHECK (TcgAddBOOLEAN (&CreateStruct, WriteLockEnabled));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x07));                       // "ReadLocked"\r
+  ERROR_CHECK (TcgAddBOOLEAN (&CreateStruct, ReadLocked));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, 0x08));                       // "WriteLocked"\r
+  ERROR_CHECK (TcgAddBOOLEAN (&CreateStruct, WriteLocked));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+\r
+  ERROR_CHECK (TcgAddEndList (&CreateStruct));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
+\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, MethodStatus, 0));\r
   // Exit with success on method failure - user must inspect MethodStatus\r
-  METHOD_STATUS_ERROR_CHECK(*MethodStatus, TcgResultSuccess);\r
+  METHOD_STATUS_ERROR_CHECK (*MethodStatus, TcgResultSuccess);\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -1468,37 +1500,37 @@ OpalSetLockingRange(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalCreateRetrieveGlobalLockingRangeActiveKey(\r
-  const OPAL_SESSION    *Session,\r
-  TCG_CREATE_STRUCT     *CreateStruct,\r
-  UINT32                *Size\r
+OpalCreateRetrieveGlobalLockingRangeActiveKey (\r
+  const OPAL_SESSION  *Session,\r
+  TCG_CREATE_STRUCT   *CreateStruct,\r
+  UINT32              *Size\r
   )\r
 {\r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(CreateStruct);\r
-  NULL_CHECK(Size);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (CreateStruct);\r
+  NULL_CHECK (Size);\r
 \r
   // Retrieve the activekey in order to know which globalrange key to generate\r
-  ERROR_CHECK(TcgStartComPacket(CreateStruct, Session->OpalBaseComId, Session->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(CreateStruct, Session->TperSessionId, Session->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(CreateStruct, OPAL_LOCKING_SP_LOCKING_GLOBALRANGE, TCG_UID_METHOD_GET));\r
-  ERROR_CHECK(TcgStartParameters(CreateStruct));\r
-  ERROR_CHECK(TcgAddStartList(CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(CreateStruct, TCG_CELL_BLOCK_START_COLUMN_NAME));\r
-  ERROR_CHECK(TcgAddUINT8(CreateStruct, 0x0A));         // ActiveKey\r
-  ERROR_CHECK(TcgAddEndName(CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(CreateStruct, TCG_CELL_BLOCK_END_COLUMN_NAME));\r
-  ERROR_CHECK(TcgAddUINT8(CreateStruct, 0x0A));\r
-  ERROR_CHECK(TcgAddEndName(CreateStruct));\r
-  ERROR_CHECK(TcgAddEndList(CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(CreateStruct, Size));\r
+  ERROR_CHECK (TcgStartComPacket (CreateStruct, Session->OpalBaseComId, Session->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (CreateStruct, Session->TperSessionId, Session->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (CreateStruct, OPAL_LOCKING_SP_LOCKING_GLOBALRANGE, TCG_UID_METHOD_GET));\r
+  ERROR_CHECK (TcgStartParameters (CreateStruct));\r
+  ERROR_CHECK (TcgAddStartList (CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (CreateStruct, TCG_CELL_BLOCK_START_COLUMN_NAME));\r
+  ERROR_CHECK (TcgAddUINT8 (CreateStruct, 0x0A));         // ActiveKey\r
+  ERROR_CHECK (TcgAddEndName (CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (CreateStruct, TCG_CELL_BLOCK_END_COLUMN_NAME));\r
+  ERROR_CHECK (TcgAddUINT8 (CreateStruct, 0x0A));\r
+  ERROR_CHECK (TcgAddEndName (CreateStruct));\r
+  ERROR_CHECK (TcgAddEndList (CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (CreateStruct, Size));\r
 \r
   return TcgResultSuccess;\r
 }\r
@@ -1513,33 +1545,33 @@ OpalCreateRetrieveGlobalLockingRangeActiveKey(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalParseRetrieveGlobalLockingRangeActiveKey(\r
+OpalParseRetrieveGlobalLockingRangeActiveKey (\r
   TCG_PARSE_STRUCT  *ParseStruct,\r
   TCG_UID           *ActiveKey\r
   )\r
 {\r
-  UINT32 ColumnName;\r
+  UINT32  ColumnName;\r
 \r
-  NULL_CHECK(ParseStruct);\r
-  NULL_CHECK(ActiveKey);\r
+  NULL_CHECK (ParseStruct);\r
+  NULL_CHECK (ActiveKey);\r
 \r
   // parse response\r
-  ERROR_CHECK(TcgGetNextStartList(ParseStruct));\r
-  ERROR_CHECK(TcgGetNextStartList(ParseStruct));\r
-  ERROR_CHECK(TcgGetNextStartName(ParseStruct));\r
-  ERROR_CHECK(TcgGetNextUINT32(ParseStruct, &ColumnName));\r
-  ERROR_CHECK(TcgGetNextTcgUid(ParseStruct, ActiveKey));\r
-  ERROR_CHECK(TcgGetNextEndName(ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndList(ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndList(ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndOfData(ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartList (ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartList (ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartName (ParseStruct));\r
+  ERROR_CHECK (TcgGetNextUINT32 (ParseStruct, &ColumnName));\r
+  ERROR_CHECK (TcgGetNextTcgUid (ParseStruct, ActiveKey));\r
+  ERROR_CHECK (TcgGetNextEndName (ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndList (ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndList (ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndOfData (ParseStruct));\r
 \r
   if (ColumnName != 0x0A) {\r
     DEBUG ((DEBUG_INFO, "Unexpected column name %u (exp 0x0A)\n", ColumnName));\r
     return TcgResultFailure;\r
   }\r
 \r
-  if (*ActiveKey != OPAL_LOCKING_SP_K_AES_256_GLOBALRANGE_KEY && *ActiveKey != OPAL_LOCKING_SP_K_AES_128_GLOBALRANGE_KEY) {\r
+  if ((*ActiveKey != OPAL_LOCKING_SP_K_AES_256_GLOBALRANGE_KEY) && (*ActiveKey != OPAL_LOCKING_SP_K_AES_128_GLOBALRANGE_KEY)) {\r
     DEBUG ((DEBUG_INFO, "Unexpected gen key %u (exp %u or %u)\n", *ActiveKey, OPAL_LOCKING_SP_K_AES_256_GLOBALRANGE_KEY, OPAL_LOCKING_SP_K_AES_128_GLOBALRANGE_KEY));\r
     return TcgResultFailure;\r
   }\r
@@ -1558,56 +1590,56 @@ OpalParseRetrieveGlobalLockingRangeActiveKey(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGetTryLimit(\r
-  OPAL_SESSION   *LockingSpSession,\r
-  TCG_UID        RowUid,\r
-  UINT32         *TryLimit\r
+OpalGetTryLimit (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  TCG_UID       RowUid,\r
+  UINT32        *TryLimit\r
   )\r
 {\r
-  TCG_CREATE_STRUCT CreateStruct;\r
-  TCG_PARSE_STRUCT  ParseStruct;\r
-  UINT32            Size;\r
-  UINT8             MethodStatus;\r
-  UINT8             Buf[BUFFER_SIZE];\r
-  UINT32            Col;\r
-\r
-  NULL_CHECK(LockingSpSession);\r
-  NULL_CHECK(TryLimit);\r
-\r
-  ERROR_CHECK(TcgInitTcgCreateStruct(&CreateStruct, Buf, sizeof(Buf)));\r
-  ERROR_CHECK(TcgStartComPacket(&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
-  ERROR_CHECK(TcgStartPacket(&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
-  ERROR_CHECK(TcgStartSubPacket(&CreateStruct, 0x0));\r
-  ERROR_CHECK(TcgStartMethodCall(&CreateStruct, RowUid, TCG_UID_METHOD_GET));\r
-  ERROR_CHECK(TcgStartParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartList(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, TCG_CELL_BLOCK_START_COLUMN_NAME));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, OPAL_LOCKING_SP_C_PIN_TRYLIMIT_COL));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddStartName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, TCG_CELL_BLOCK_END_COLUMN_NAME));\r
-  ERROR_CHECK(TcgAddUINT8(&CreateStruct, OPAL_LOCKING_SP_C_PIN_TRYLIMIT_COL));\r
-  ERROR_CHECK(TcgAddEndName(&CreateStruct));\r
-  ERROR_CHECK(TcgAddEndList(&CreateStruct));\r
-  ERROR_CHECK(TcgEndParameters(&CreateStruct));\r
-  ERROR_CHECK(TcgEndMethodCall(&CreateStruct));\r
-  ERROR_CHECK(TcgEndSubPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndPacket(&CreateStruct));\r
-  ERROR_CHECK(TcgEndComPacket(&CreateStruct, &Size));\r
-\r
-  ERROR_CHECK(OpalPerformMethod(LockingSpSession, Size, Buf, sizeof(Buf), &ParseStruct, &MethodStatus, 0));\r
-  METHOD_STATUS_ERROR_CHECK(MethodStatus, TcgResultFailure);\r
-\r
-  ERROR_CHECK(TcgGetNextStartList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextStartList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextStartName(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextUINT32(&ParseStruct, &Col));\r
-  ERROR_CHECK(TcgGetNextUINT32(&ParseStruct, TryLimit));\r
-  ERROR_CHECK(TcgGetNextEndName(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndList(&ParseStruct));\r
-  ERROR_CHECK(TcgGetNextEndOfData(&ParseStruct));\r
+  TCG_CREATE_STRUCT  CreateStruct;\r
+  TCG_PARSE_STRUCT   ParseStruct;\r
+  UINT32             Size;\r
+  UINT8              MethodStatus;\r
+  UINT8              Buf[BUFFER_SIZE];\r
+  UINT32             Col;\r
+\r
+  NULL_CHECK (LockingSpSession);\r
+  NULL_CHECK (TryLimit);\r
+\r
+  ERROR_CHECK (TcgInitTcgCreateStruct (&CreateStruct, Buf, sizeof (Buf)));\r
+  ERROR_CHECK (TcgStartComPacket (&CreateStruct, LockingSpSession->OpalBaseComId, LockingSpSession->ComIdExtension));\r
+  ERROR_CHECK (TcgStartPacket (&CreateStruct, LockingSpSession->TperSessionId, LockingSpSession->HostSessionId, 0x0, 0x0, 0x0));\r
+  ERROR_CHECK (TcgStartSubPacket (&CreateStruct, 0x0));\r
+  ERROR_CHECK (TcgStartMethodCall (&CreateStruct, RowUid, TCG_UID_METHOD_GET));\r
+  ERROR_CHECK (TcgStartParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartList (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, TCG_CELL_BLOCK_START_COLUMN_NAME));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, OPAL_LOCKING_SP_C_PIN_TRYLIMIT_COL));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddStartName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, TCG_CELL_BLOCK_END_COLUMN_NAME));\r
+  ERROR_CHECK (TcgAddUINT8 (&CreateStruct, OPAL_LOCKING_SP_C_PIN_TRYLIMIT_COL));\r
+  ERROR_CHECK (TcgAddEndName (&CreateStruct));\r
+  ERROR_CHECK (TcgAddEndList (&CreateStruct));\r
+  ERROR_CHECK (TcgEndParameters (&CreateStruct));\r
+  ERROR_CHECK (TcgEndMethodCall (&CreateStruct));\r
+  ERROR_CHECK (TcgEndSubPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndPacket (&CreateStruct));\r
+  ERROR_CHECK (TcgEndComPacket (&CreateStruct, &Size));\r
+\r
+  ERROR_CHECK (OpalPerformMethod (LockingSpSession, Size, Buf, sizeof (Buf), &ParseStruct, &MethodStatus, 0));\r
+  METHOD_STATUS_ERROR_CHECK (MethodStatus, TcgResultFailure);\r
+\r
+  ERROR_CHECK (TcgGetNextStartList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextStartName (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextUINT32 (&ParseStruct, &Col));\r
+  ERROR_CHECK (TcgGetNextUINT32 (&ParseStruct, TryLimit));\r
+  ERROR_CHECK (TcgGetNextEndName (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndList (&ParseStruct));\r
+  ERROR_CHECK (TcgGetNextEndOfData (&ParseStruct));\r
 \r
   if (Col != OPAL_LOCKING_SP_C_PIN_TRYLIMIT_COL) {\r
     DEBUG ((DEBUG_INFO, "ERROR: got col %u, expected %u\n", Col, OPAL_LOCKING_SP_C_PIN_TRYLIMIT_COL));\r
@@ -1628,50 +1660,52 @@ OpalGetTryLimit(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGetSupportedAttributesInfo(\r
+OpalGetSupportedAttributesInfo (\r
   IN  OPAL_SESSION                 *Session,\r
   OUT OPAL_DISK_SUPPORT_ATTRIBUTE  *SupportedAttributes,\r
   OUT UINT16                       *OpalBaseComId\r
   )\r
 {\r
-  UINT8                              Buffer[BUFFER_SIZE];\r
-  TCG_SUPPORTED_SECURITY_PROTOCOLS   *SupportedProtocols;\r
-  TCG_LEVEL0_DISCOVERY_HEADER        *DiscoveryHeader;\r
-  OPAL_LEVEL0_FEATURE_DESCRIPTOR     *Feat;\r
-  OPAL_LEVEL0_FEATURE_DESCRIPTOR     *Feat2;\r
-  UINTN                              Size;\r
-  UINTN                              Size2;\r
+  UINT8                             Buffer[BUFFER_SIZE];\r
+  TCG_SUPPORTED_SECURITY_PROTOCOLS  *SupportedProtocols;\r
+  TCG_LEVEL0_DISCOVERY_HEADER       *DiscoveryHeader;\r
+  OPAL_LEVEL0_FEATURE_DESCRIPTOR    *Feat;\r
+  OPAL_LEVEL0_FEATURE_DESCRIPTOR    *Feat2;\r
+  UINTN                             Size;\r
+  UINTN                             Size2;\r
+\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (SupportedAttributes);\r
+  NULL_CHECK (OpalBaseComId);\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(SupportedAttributes);\r
-  NULL_CHECK(OpalBaseComId);\r
-\r
-  ZeroMem(Buffer, BUFFER_SIZE);\r
-  ZeroMem(SupportedAttributes, sizeof(OPAL_DISK_SUPPORT_ATTRIBUTE));\r
-  ASSERT(sizeof(Buffer) >= sizeof(TCG_SUPPORTED_SECURITY_PROTOCOLS));\r
+  ZeroMem (Buffer, BUFFER_SIZE);\r
+  ZeroMem (SupportedAttributes, sizeof (OPAL_DISK_SUPPORT_ATTRIBUTE));\r
+  ASSERT (sizeof (Buffer) >= sizeof (TCG_SUPPORTED_SECURITY_PROTOCOLS));\r
 \r
   //\r
   // Retrieve supported protocols verify security protocol 1 is supported\r
   //\r
-  SupportedProtocols = (TCG_SUPPORTED_SECURITY_PROTOCOLS*) Buffer;\r
+  SupportedProtocols = (TCG_SUPPORTED_SECURITY_PROTOCOLS *)Buffer;\r
 \r
   //\r
   // Get list of supported protocols\r
   //\r
-  if (OpalRetrieveSupportedProtocolList (Session, sizeof(TCG_SUPPORTED_SECURITY_PROTOCOLS), SupportedProtocols) == TcgResultFailure) {\r
+  if (OpalRetrieveSupportedProtocolList (Session, sizeof (TCG_SUPPORTED_SECURITY_PROTOCOLS), SupportedProtocols) == TcgResultFailure) {\r
     DEBUG ((DEBUG_INFO, "OpalRetrieveSupportedProtocolList failed\n"));\r
     return TcgResultFailure;\r
   }\r
 \r
-  SupportedAttributes->Sp1 = TcgIsProtocolSupported (SupportedProtocols, TCG_OPAL_SECURITY_PROTOCOL_1);\r
-  SupportedAttributes->Sp2 = TcgIsProtocolSupported (SupportedProtocols, TCG_OPAL_SECURITY_PROTOCOL_2);\r
+  SupportedAttributes->Sp1        = TcgIsProtocolSupported (SupportedProtocols, TCG_OPAL_SECURITY_PROTOCOL_1);\r
+  SupportedAttributes->Sp2        = TcgIsProtocolSupported (SupportedProtocols, TCG_OPAL_SECURITY_PROTOCOL_2);\r
   SupportedAttributes->SpIeee1667 = TcgIsProtocolSupported (SupportedProtocols, TCG_SECURITY_PROTOCOL_IEEE_1667);\r
 \r
-  DEBUG ((DEBUG_INFO, "Supported Protocols: Sp1 %d Sp2: %d SpIeee1667 %d \n",\r
-              SupportedAttributes->Sp1,\r
-              SupportedAttributes->Sp2,\r
-              SupportedAttributes->SpIeee1667\r
-              ));\r
+  DEBUG ((\r
+    DEBUG_INFO,\r
+    "Supported Protocols: Sp1 %d Sp2: %d SpIeee1667 %d \n",\r
+    SupportedAttributes->Sp1,\r
+    SupportedAttributes->Sp2,\r
+    SupportedAttributes->SpIeee1667\r
+    ));\r
 \r
   //\r
   // Perform level 0 discovery and assign desired feature info to Opal Disk structure\r
@@ -1685,10 +1719,10 @@ OpalGetSupportedAttributesInfo(
   //\r
   // Check for required feature descriptors\r
   //\r
-  DiscoveryHeader = (TCG_LEVEL0_DISCOVERY_HEADER*) Buffer;\r
+  DiscoveryHeader = (TCG_LEVEL0_DISCOVERY_HEADER *)Buffer;\r
 \r
-  Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_OPAL_SSC_V2_0_0, &Size);\r
+  Size                          = 0;\r
+  Feat                          = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_OPAL_SSC_V2_0_0, &Size);\r
   SupportedAttributes->OpalSsc2 = (Feat != NULL);\r
 \r
   *OpalBaseComId = TCG_RESERVED_COMID;\r
@@ -1696,35 +1730,39 @@ OpalGetSupportedAttributesInfo(
   //\r
   // Check Opal SCC V2 has valid settings for SID C_PIN on revert\r
   //\r
-  if (SupportedAttributes->OpalSsc2 && Size >= sizeof (OPAL_SSCV2_FEATURE_DESCRIPTOR)) {\r
+  if (SupportedAttributes->OpalSsc2 && (Size >= sizeof (OPAL_SSCV2_FEATURE_DESCRIPTOR))) {\r
     //\r
     // Want opposite polarity b/c Value is greater than a bit, but we only care about non-zero vs zero\r
     //\r
     SupportedAttributes->InitCpinIndicator = (Feat->OpalSscV2.InitialCPINSIDPIN == 0);\r
-    SupportedAttributes->CpinUponRevert = (Feat->OpalSscV2.CPINSIDPINRevertBehavior == 0);\r
-    DEBUG ((DEBUG_INFO, "Opal SSC V2 InitCpinIndicator %d  CpinUponRevert %d \n",\r
-             SupportedAttributes->InitCpinIndicator,\r
-             SupportedAttributes->CpinUponRevert\r
-            ));\r
+    SupportedAttributes->CpinUponRevert    = (Feat->OpalSscV2.CPINSIDPINRevertBehavior == 0);\r
+    DEBUG ((\r
+      DEBUG_INFO,\r
+      "Opal SSC V2 InitCpinIndicator %d  CpinUponRevert %d \n",\r
+      SupportedAttributes->InitCpinIndicator,\r
+      SupportedAttributes->CpinUponRevert\r
+      ));\r
     *OpalBaseComId = SwapBytes16 (Feat->OpalSscV2.BaseComdIdBE);\r
   }\r
 \r
-  Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_OPAL_SSC_LITE, &Size);\r
+  Size                             = 0;\r
+  Feat                             = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_OPAL_SSC_LITE, &Size);\r
   SupportedAttributes->OpalSscLite = (Feat != NULL);\r
 \r
-  if (Feat != NULL && Size >= sizeof (OPAL_SSCLITE_FEATURE_DESCRIPTOR)) {\r
+  if ((Feat != NULL) && (Size >= sizeof (OPAL_SSCLITE_FEATURE_DESCRIPTOR))) {\r
     if (*OpalBaseComId == TCG_RESERVED_COMID) {\r
       //\r
       // Pin values used always match up with ComId used\r
       //\r
-      *OpalBaseComId = SwapBytes16 (Feat->OpalSscLite.BaseComdIdBE);\r
+      *OpalBaseComId                         = SwapBytes16 (Feat->OpalSscLite.BaseComdIdBE);\r
       SupportedAttributes->InitCpinIndicator = (Feat->OpalSscV2.InitialCPINSIDPIN == 0);\r
-      SupportedAttributes->CpinUponRevert = (Feat->OpalSscV2.CPINSIDPINRevertBehavior == 0);\r
-      DEBUG ((DEBUG_INFO, "Opal SSC Lite InitCpinIndicator %d  CpinUponRevert %d \n",\r
-               SupportedAttributes->InitCpinIndicator,\r
-               SupportedAttributes->CpinUponRevert\r
-              ));\r
+      SupportedAttributes->CpinUponRevert    = (Feat->OpalSscV2.CPINSIDPINRevertBehavior == 0);\r
+      DEBUG ((\r
+        DEBUG_INFO,\r
+        "Opal SSC Lite InitCpinIndicator %d  CpinUponRevert %d \n",\r
+        SupportedAttributes->InitCpinIndicator,\r
+        SupportedAttributes->CpinUponRevert\r
+        ));\r
     }\r
   }\r
 \r
@@ -1732,55 +1770,59 @@ OpalGetSupportedAttributesInfo(
   // For some pyrite 2.0 device, it contains both pyrite 1.0 and 2.0 feature data.\r
   // so here try to get data from pyrite 2.0 feature data first.\r
   //\r
-  Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_PYRITE_SSC, &Size);\r
+  Size  = 0;\r
+  Feat  = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_PYRITE_SSC, &Size);\r
   Size2 = 0;\r
-  Feat2 = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_PYRITE_SSC_V2_0_0, &Size2);\r
-  if (Feat2 != NULL && Size2 >= sizeof (PYRITE_SSCV2_FEATURE_DESCRIPTOR)) {\r
+  Feat2 = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_PYRITE_SSC_V2_0_0, &Size2);\r
+  if ((Feat2 != NULL) && (Size2 >= sizeof (PYRITE_SSCV2_FEATURE_DESCRIPTOR))) {\r
     SupportedAttributes->PyriteSscV2 = TRUE;\r
     if (*OpalBaseComId == TCG_RESERVED_COMID) {\r
-      *OpalBaseComId = SwapBytes16 (Feat2->PyriteSscV2.BaseComdIdBE);\r
+      *OpalBaseComId                         = SwapBytes16 (Feat2->PyriteSscV2.BaseComdIdBE);\r
       SupportedAttributes->InitCpinIndicator = (Feat2->PyriteSscV2.InitialCPINSIDPIN == 0);\r
-      SupportedAttributes->CpinUponRevert = (Feat2->PyriteSscV2.CPINSIDPINRevertBehavior == 0);\r
-      DEBUG ((DEBUG_INFO, "Pyrite SSC V2 InitCpinIndicator %d  CpinUponRevert %d \n",\r
-               SupportedAttributes->InitCpinIndicator,\r
-               SupportedAttributes->CpinUponRevert\r
-              ));\r
+      SupportedAttributes->CpinUponRevert    = (Feat2->PyriteSscV2.CPINSIDPINRevertBehavior == 0);\r
+      DEBUG ((\r
+        DEBUG_INFO,\r
+        "Pyrite SSC V2 InitCpinIndicator %d  CpinUponRevert %d \n",\r
+        SupportedAttributes->InitCpinIndicator,\r
+        SupportedAttributes->CpinUponRevert\r
+        ));\r
     }\r
   } else {\r
     SupportedAttributes->PyriteSsc = (Feat != NULL);\r
-    if (Feat != NULL && Size >= sizeof (PYRITE_SSC_FEATURE_DESCRIPTOR)) {\r
+    if ((Feat != NULL) && (Size >= sizeof (PYRITE_SSC_FEATURE_DESCRIPTOR))) {\r
       if (*OpalBaseComId == TCG_RESERVED_COMID) {\r
-        *OpalBaseComId = SwapBytes16 (Feat->PyriteSsc.BaseComdIdBE);\r
+        *OpalBaseComId                         = SwapBytes16 (Feat->PyriteSsc.BaseComdIdBE);\r
         SupportedAttributes->InitCpinIndicator = (Feat->PyriteSsc.InitialCPINSIDPIN == 0);\r
-        SupportedAttributes->CpinUponRevert = (Feat->PyriteSsc.CPINSIDPINRevertBehavior == 0);\r
-        DEBUG ((DEBUG_INFO, "Pyrite SSC InitCpinIndicator %d  CpinUponRevert %d \n",\r
-                 SupportedAttributes->InitCpinIndicator,\r
-                 SupportedAttributes->CpinUponRevert\r
-                ));\r
+        SupportedAttributes->CpinUponRevert    = (Feat->PyriteSsc.CPINSIDPINRevertBehavior == 0);\r
+        DEBUG ((\r
+          DEBUG_INFO,\r
+          "Pyrite SSC InitCpinIndicator %d  CpinUponRevert %d \n",\r
+          SupportedAttributes->InitCpinIndicator,\r
+          SupportedAttributes->CpinUponRevert\r
+          ));\r
       }\r
     }\r
   }\r
 \r
-  Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_OPAL_SSC_V1_0_0, &Size);\r
+  Size                          = 0;\r
+  Feat                          = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_OPAL_SSC_V1_0_0, &Size);\r
   SupportedAttributes->OpalSsc1 = (Feat != NULL);\r
-  if (Feat != NULL && Size >= sizeof (OPAL_SSCV1_FEATURE_DESCRIPTOR)) {\r
+  if ((Feat != NULL) && (Size >= sizeof (OPAL_SSCV1_FEATURE_DESCRIPTOR))) {\r
     if (*OpalBaseComId == TCG_RESERVED_COMID) {\r
       *OpalBaseComId = SwapBytes16 (Feat->OpalSscV1.BaseComdIdBE);\r
     }\r
   }\r
 \r
   Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_LOCKING, &Size);\r
-  if (Feat != NULL && Size >= sizeof (TCG_LOCKING_FEATURE_DESCRIPTOR)) {\r
+  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_LOCKING, &Size);\r
+  if ((Feat != NULL) && (Size >= sizeof (TCG_LOCKING_FEATURE_DESCRIPTOR))) {\r
     SupportedAttributes->MediaEncryption = Feat->Locking.MediaEncryption;\r
     DEBUG ((DEBUG_INFO, "SupportedAttributes->MediaEncryption 0x%X \n", SupportedAttributes->MediaEncryption));\r
   }\r
 \r
   Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_BLOCK_SID, &Size);\r
-  if (Feat != NULL && Size >= sizeof (TCG_BLOCK_SID_FEATURE_DESCRIPTOR)) {\r
+  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_BLOCK_SID, &Size);\r
+  if ((Feat != NULL) && (Size >= sizeof (TCG_BLOCK_SID_FEATURE_DESCRIPTOR))) {\r
     SupportedAttributes->BlockSid = TRUE;\r
     DEBUG ((DEBUG_INFO, "BlockSid Supported!!! Current Status is 0x%X \n", Feat->BlockSid.SIDBlockedState));\r
   } else {\r
@@ -1788,8 +1830,8 @@ OpalGetSupportedAttributesInfo(
   }\r
 \r
   Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_DATA_REMOVAL, &Size);\r
-  if (Feat != NULL && Size >= sizeof (DATA_REMOVAL_FEATURE_DESCRIPTOR)) {\r
+  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_DATA_REMOVAL, &Size);\r
+  if ((Feat != NULL) && (Size >= sizeof (DATA_REMOVAL_FEATURE_DESCRIPTOR))) {\r
     SupportedAttributes->DataRemoval = TRUE;\r
     DEBUG ((DEBUG_INFO, "DataRemoval Feature Supported!\n"));\r
     DEBUG ((DEBUG_INFO, "Operation Processing = 0x%x\n", Feat->DataRemoval.OperationProcessing));\r
@@ -1816,31 +1858,32 @@ OpalGetSupportedAttributesInfo(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalGetLockingInfo(\r
-  OPAL_SESSION                     *Session,\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature\r
+OpalGetLockingInfo (\r
+  OPAL_SESSION                    *Session,\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature\r
   )\r
 {\r
-  UINT8                              Buffer[BUFFER_SIZE];\r
-  TCG_LEVEL0_DISCOVERY_HEADER        *DiscoveryHeader;\r
-  OPAL_LEVEL0_FEATURE_DESCRIPTOR     *Feat;\r
-  UINTN                              Size;\r
+  UINT8                           Buffer[BUFFER_SIZE];\r
+  TCG_LEVEL0_DISCOVERY_HEADER     *DiscoveryHeader;\r
+  OPAL_LEVEL0_FEATURE_DESCRIPTOR  *Feat;\r
+  UINTN                           Size;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(LockingFeature);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (LockingFeature);\r
 \r
-  ZeroMem(Buffer, BUFFER_SIZE);\r
-  ASSERT(sizeof(Buffer) >= sizeof(TCG_SUPPORTED_SECURITY_PROTOCOLS));\r
+  ZeroMem (Buffer, BUFFER_SIZE);\r
+  ASSERT (sizeof (Buffer) >= sizeof (TCG_SUPPORTED_SECURITY_PROTOCOLS));\r
 \r
   if (OpalRetrieveLevel0DiscoveryHeader (Session, BUFFER_SIZE, Buffer) == TcgResultFailure) {\r
     DEBUG ((DEBUG_INFO, "OpalRetrieveLevel0DiscoveryHeader failed\n"));\r
     return TcgResultFailure;\r
   }\r
-  DiscoveryHeader = (TCG_LEVEL0_DISCOVERY_HEADER*) Buffer;\r
+\r
+  DiscoveryHeader = (TCG_LEVEL0_DISCOVERY_HEADER *)Buffer;\r
 \r
   Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, TCG_FEATURE_LOCKING, &Size);\r
-  if (Feat != NULL && Size >= sizeof (TCG_LOCKING_FEATURE_DESCRIPTOR)) {\r
+  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, TCG_FEATURE_LOCKING, &Size);\r
+  if ((Feat != NULL) && (Size >= sizeof (TCG_LOCKING_FEATURE_DESCRIPTOR))) {\r
     CopyMem (LockingFeature, &Feat->Locking, sizeof (TCG_LOCKING_FEATURE_DESCRIPTOR));\r
   }\r
 \r
@@ -1859,32 +1902,33 @@ OpalGetLockingInfo(
 **/\r
 TCG_RESULT\r
 OpalGetFeatureDescriptor (\r
-  IN     OPAL_SESSION              *Session,\r
-  IN     UINT16                    FeatureCode,\r
-  IN OUT UINTN                     *DataSize,\r
-  OUT    VOID                      *Data\r
+  IN     OPAL_SESSION  *Session,\r
+  IN     UINT16        FeatureCode,\r
+  IN OUT UINTN         *DataSize,\r
+  OUT    VOID          *Data\r
   )\r
 {\r
-  UINT8                              Buffer[BUFFER_SIZE];\r
-  TCG_LEVEL0_DISCOVERY_HEADER        *DiscoveryHeader;\r
-  OPAL_LEVEL0_FEATURE_DESCRIPTOR     *Feat;\r
-  UINTN                              Size;\r
+  UINT8                           Buffer[BUFFER_SIZE];\r
+  TCG_LEVEL0_DISCOVERY_HEADER     *DiscoveryHeader;\r
+  OPAL_LEVEL0_FEATURE_DESCRIPTOR  *Feat;\r
+  UINTN                           Size;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(DataSize);\r
-  NULL_CHECK(Data);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (DataSize);\r
+  NULL_CHECK (Data);\r
 \r
-  ZeroMem(Buffer, BUFFER_SIZE);\r
-  ASSERT(sizeof(Buffer) >= sizeof(TCG_SUPPORTED_SECURITY_PROTOCOLS));\r
+  ZeroMem (Buffer, BUFFER_SIZE);\r
+  ASSERT (sizeof (Buffer) >= sizeof (TCG_SUPPORTED_SECURITY_PROTOCOLS));\r
 \r
   if (OpalRetrieveLevel0DiscoveryHeader (Session, BUFFER_SIZE, Buffer) == TcgResultFailure) {\r
     DEBUG ((DEBUG_INFO, "OpalRetrieveLevel0DiscoveryHeader failed\n"));\r
     return TcgResultFailure;\r
   }\r
-  DiscoveryHeader = (TCG_LEVEL0_DISCOVERY_HEADER*) Buffer;\r
+\r
+  DiscoveryHeader = (TCG_LEVEL0_DISCOVERY_HEADER *)Buffer;\r
 \r
   Size = 0;\r
-  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR*) TcgGetFeature (DiscoveryHeader, FeatureCode, &Size);\r
+  Feat = (OPAL_LEVEL0_FEATURE_DESCRIPTOR *)TcgGetFeature (DiscoveryHeader, FeatureCode, &Size);\r
   if (Feat != NULL) {\r
     if (Size > *DataSize) {\r
       *DataSize = Size;\r
@@ -1908,22 +1952,23 @@ OpalGetFeatureDescriptor (
 **/\r
 BOOLEAN\r
 EFIAPI\r
-OpalFeatureSupported(\r
-  OPAL_DISK_SUPPORT_ATTRIBUTE      *SupportedAttributes\r
+OpalFeatureSupported (\r
+  OPAL_DISK_SUPPORT_ATTRIBUTE  *SupportedAttributes\r
   )\r
 {\r
-  NULL_CHECK(SupportedAttributes);\r
+  NULL_CHECK (SupportedAttributes);\r
 \r
   if (SupportedAttributes->Sp1 == 0) {\r
     return FALSE;\r
   }\r
 \r
-  if (SupportedAttributes->OpalSscLite == 0 &&\r
-      SupportedAttributes->OpalSsc1 == 0 &&\r
-      SupportedAttributes->OpalSsc2 == 0 &&\r
-      SupportedAttributes->PyriteSsc == 0 &&\r
-      SupportedAttributes->PyriteSscV2 == 0\r
-     ) {\r
+  if ((SupportedAttributes->OpalSscLite == 0) &&\r
+      (SupportedAttributes->OpalSsc1 == 0) &&\r
+      (SupportedAttributes->OpalSsc2 == 0) &&\r
+      (SupportedAttributes->PyriteSsc == 0) &&\r
+      (SupportedAttributes->PyriteSscV2 == 0)\r
+      )\r
+  {\r
     return FALSE;\r
   }\r
 \r
@@ -1943,13 +1988,13 @@ OpalFeatureSupported(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-OpalFeatureEnabled(\r
-  OPAL_DISK_SUPPORT_ATTRIBUTE      *SupportedAttributes,\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature\r
+OpalFeatureEnabled (\r
+  OPAL_DISK_SUPPORT_ATTRIBUTE     *SupportedAttributes,\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature\r
   )\r
 {\r
-  NULL_CHECK(SupportedAttributes);\r
-  NULL_CHECK(LockingFeature);\r
+  NULL_CHECK (SupportedAttributes);\r
+  NULL_CHECK (LockingFeature);\r
 \r
   if (!OpalFeatureSupported (SupportedAttributes)) {\r
     return FALSE;\r
@@ -1973,13 +2018,13 @@ OpalFeatureEnabled(
 \r
 **/\r
 BOOLEAN\r
-OpalDeviceLocked(\r
-  OPAL_DISK_SUPPORT_ATTRIBUTE      *SupportedAttributes,\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature\r
+OpalDeviceLocked (\r
+  OPAL_DISK_SUPPORT_ATTRIBUTE     *SupportedAttributes,\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature\r
   )\r
 {\r
-  NULL_CHECK(SupportedAttributes);\r
-  NULL_CHECK(LockingFeature);\r
+  NULL_CHECK (SupportedAttributes);\r
+  NULL_CHECK (LockingFeature);\r
 \r
   if (!OpalFeatureEnabled (SupportedAttributes, LockingFeature)) {\r
     return FALSE;\r
@@ -1987,4 +2032,3 @@ OpalDeviceLocked(
 \r
   return LockingFeature->Locked;\r
 }\r
-\r
index 4f83364852693edefc891275e20f8dd06d05949f..4c5b1ab0f15cdde34cb18976a5de9006bfbb4f9b 100644 (file)
@@ -11,7 +11,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include <Library/TcgStorageOpalLib.h>\r
 \r
-\r
 /**\r
 \r
   The function retrieves the MSID from the device specified\r
@@ -22,8 +21,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 TCG_RESULT\r
 OpalPyrite2GetActiveDataRemovalMechanism (\r
-  OPAL_SESSION    *AdminSpSession,\r
-  UINT8           *ActiveDataRemovalMechanism\r
+  OPAL_SESSION  *AdminSpSession,\r
+  UINT8         *ActiveDataRemovalMechanism\r
   );\r
 \r
 /**\r
@@ -38,10 +37,10 @@ OpalPyrite2GetActiveDataRemovalMechanism (
 **/\r
 TCG_RESULT\r
 OpalGetFeatureDescriptor (\r
-  IN     OPAL_SESSION              *Session,\r
-  IN     UINT16                    FeatureCode,\r
-  IN OUT UINTN                     *DataSize,\r
-  OUT    VOID                      *Data\r
+  IN     OPAL_SESSION  *Session,\r
+  IN     UINT16        FeatureCode,\r
+  IN OUT UINTN         *DataSize,\r
+  OUT    VOID          *Data\r
   );\r
 \r
 /**\r
@@ -52,7 +51,7 @@ OpalGetFeatureDescriptor (
 **/\r
 UINT32\r
 GetRevertTimeOut (\r
-  IN OPAL_SESSION                *Session\r
+  IN OPAL_SESSION  *Session\r
   );\r
 \r
 /**\r
@@ -64,9 +63,9 @@ GetRevertTimeOut (
 \r
 **/\r
 TCG_RESULT\r
-OpalPyrite2PsidRevert(\r
-  OPAL_SESSION              *AdminSpSession,\r
-  UINT32                    EstimateTimeCost\r
+OpalPyrite2PsidRevert (\r
+  OPAL_SESSION  *AdminSpSession,\r
+  UINT32        EstimateTimeCost\r
   );\r
 \r
 /**\r
@@ -81,11 +80,11 @@ OpalPyrite2PsidRevert(
 \r
 **/\r
 TCG_RESULT\r
-OpalPyrite2AdminRevert(\r
-  OPAL_SESSION    *LockingSpSession,\r
-  BOOLEAN         KeepUserData,\r
-  UINT8           *MethodStatus,\r
-  UINT32          EstimateTimeCost\r
+OpalPyrite2AdminRevert (\r
+  OPAL_SESSION  *LockingSpSession,\r
+  BOOLEAN       KeepUserData,\r
+  UINT8         *MethodStatus,\r
+  UINT32        EstimateTimeCost\r
   );\r
 \r
 #endif // _OPAL_CORE_H_\r
index b4927a0872a2c4cb12e7c6efe45d06b1f397b155..19edcb5d8dea8fa532ac9d54aa1437828ede92c2 100644 (file)
@@ -11,7 +11,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/TcgStorageOpalLib.h>\r
 #include "TcgStorageOpalLibInternal.h"\r
 \r
-#define OPAL_MSID_LENGTH        128\r
+#define OPAL_MSID_LENGTH  128\r
 \r
 /**\r
   Creates a session with OPAL_UID_ADMIN_SP as OPAL_ADMIN_SP_PSID_AUTHORITY, then reverts device using Admin SP Revert method.\r
@@ -23,37 +23,38 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilPsidRevert(\r
-  OPAL_SESSION   *Session,\r
-  const VOID     *Psid,\r
-  UINT32         PsidLength\r
+OpalUtilPsidRevert (\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *Psid,\r
+  UINT32        PsidLength\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
-  UINT32       RemovalTimeOut;\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
+  UINT32      RemovalTimeOut;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Psid);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Psid);\r
 \r
   RemovalTimeOut = GetRevertTimeOut (Session);\r
   DEBUG ((DEBUG_INFO, "OpalUtilPsidRevert: Timeout value = %d\n", RemovalTimeOut));\r
 \r
-  Ret = OpalStartSession(\r
-                      Session,\r
-                      OPAL_UID_ADMIN_SP,\r
-                      TRUE,\r
-                      PsidLength,\r
-                      Psid,\r
-                      OPAL_ADMIN_SP_PSID_AUTHORITY,\r
-                      &MethodStatus);\r
-  if (Ret == TcgResultSuccess && MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) {\r
-    Ret = OpalPyrite2PsidRevert(Session, RemovalTimeOut);\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_ADMIN_SP,\r
+          TRUE,\r
+          PsidLength,\r
+          Psid,\r
+          OPAL_ADMIN_SP_PSID_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
+    Ret = OpalPyrite2PsidRevert (Session, RemovalTimeOut);\r
     if (Ret != TcgResultSuccess) {\r
       //\r
       // If revert was successful, session was already ended by TPer, so only end session on failure\r
       //\r
-      OpalEndSession(Session);\r
+      OpalEndSession (Session);\r
     }\r
   }\r
 \r
@@ -78,31 +79,31 @@ OpalUtilPsidRevert(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSetAdminPasswordAsSid(\r
-  OPAL_SESSION      *Session,\r
-  const VOID        *GeneratedSid,\r
-  UINT32            SidLength,\r
-  const VOID        *Password,\r
-  UINT32            PassLength\r
+OpalUtilSetAdminPasswordAsSid (\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *GeneratedSid,\r
+  UINT32        SidLength,\r
+  const VOID    *Password,\r
+  UINT32        PassLength\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
-\r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(GeneratedSid);\r
-  NULL_CHECK(Password);\r
-\r
-  Ret = OpalStartSession(\r
-                    Session,\r
-                    OPAL_UID_ADMIN_SP,\r
-                    TRUE,\r
-                    SidLength,\r
-                    GeneratedSid,\r
-                    OPAL_ADMIN_SP_SID_AUTHORITY,\r
-                    &MethodStatus\r
-                    );\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
+\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (GeneratedSid);\r
+  NULL_CHECK (Password);\r
+\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_ADMIN_SP,\r
+          TRUE,\r
+          SidLength,\r
+          GeneratedSid,\r
+          OPAL_ADMIN_SP_SID_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "start session with admin SP as SID authority failed: Ret=%d MethodStatus=%u\n", Ret, MethodStatus));\r
     goto done;\r
   }\r
@@ -110,16 +111,16 @@ OpalUtilSetAdminPasswordAsSid(
   //\r
   // 1. Update SID = new Password\r
   //\r
-  Ret = OpalSetPassword(\r
-                    Session,\r
-                    OPAL_UID_ADMIN_SP_C_PIN_SID,\r
-                    Password,\r
-                    PassLength,\r
-                    &MethodStatus\r
-                    );\r
-\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
-    OpalEndSession(Session);\r
+  Ret = OpalSetPassword (\r
+          Session,\r
+          OPAL_UID_ADMIN_SP_C_PIN_SID,\r
+          Password,\r
+          PassLength,\r
+          &MethodStatus\r
+          );\r
+\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
+    OpalEndSession (Session);\r
     DEBUG ((DEBUG_INFO, "set Password failed: Ret=%d MethodStatus=%u\n", Ret, MethodStatus));\r
     goto done;\r
   }\r
@@ -127,9 +128,9 @@ OpalUtilSetAdminPasswordAsSid(
   //\r
   // 2. Activate locking SP\r
   //\r
-  Ret = OpalActivateLockingSp(Session, &MethodStatus);\r
-  OpalEndSession(Session);\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalActivateLockingSp (Session, &MethodStatus);\r
+  OpalEndSession (Session);\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "activate locking SP failed: Ret=%d MethodStatus=%u\n", Ret, MethodStatus));\r
     goto done;\r
   }\r
@@ -138,6 +139,7 @@ done:
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     Ret = TcgResultFailure;\r
   }\r
+\r
   return Ret;\r
 }\r
 \r
@@ -160,36 +162,37 @@ done:
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSetOpalLockingRange(\r
-  OPAL_SESSION   *Session,\r
-  const VOID     *Password,\r
-  UINT32         PassLength,\r
-  TCG_UID        LockingRangeUid,\r
-  UINT64         RangeStart,\r
-  UINT64         RangeLength,\r
-  BOOLEAN        ReadLockEnabled,\r
-  BOOLEAN        WriteLockEnabled,\r
-  BOOLEAN        ReadLocked,\r
-  BOOLEAN        WriteLocked\r
+OpalUtilSetOpalLockingRange (\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *Password,\r
+  UINT32        PassLength,\r
+  TCG_UID       LockingRangeUid,\r
+  UINT64        RangeStart,\r
+  UINT64        RangeLength,\r
+  BOOLEAN       ReadLockEnabled,\r
+  BOOLEAN       WriteLockEnabled,\r
+  BOOLEAN       ReadLocked,\r
+  BOOLEAN       WriteLocked\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Password);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Password);\r
 \r
   //\r
   // Start session with Locking SP using current admin Password\r
   //\r
-  Ret = OpalStartSession(\r
-                      Session,\r
-                      OPAL_UID_LOCKING_SP,\r
-                      TRUE,\r
-                      PassLength,\r
-                      Password,\r
-                      OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
-                      &MethodStatus);\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          PassLength,\r
+          Password,\r
+          OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
   if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "start session with locking SP failed: Ret=%d MethodStatus=%u\n", Ret, MethodStatus));\r
     goto done;\r
@@ -198,19 +201,20 @@ OpalUtilSetOpalLockingRange(
   //\r
   // Enable locking range\r
   //\r
-  Ret = OpalSetLockingRange(\r
-            Session,\r
-            LockingRangeUid,\r
-            RangeStart,\r
-            RangeLength,\r
-            ReadLockEnabled,\r
-            WriteLockEnabled,\r
-            ReadLocked,\r
-            WriteLocked,\r
-            &MethodStatus);\r
-\r
-  OpalEndSession(Session);\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalSetLockingRange (\r
+          Session,\r
+          LockingRangeUid,\r
+          RangeStart,\r
+          RangeLength,\r
+          ReadLockEnabled,\r
+          WriteLockEnabled,\r
+          ReadLocked,\r
+          WriteLocked,\r
+          &MethodStatus\r
+          );\r
+\r
+  OpalEndSession (Session);\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "set locking range failed: Ret=%d MethodStatus=0x%x\n", Ret, MethodStatus));\r
   }\r
 \r
@@ -218,6 +222,7 @@ done:
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     Ret = TcgResultFailure;\r
   }\r
+\r
   return Ret;\r
 }\r
 \r
@@ -235,7 +240,7 @@ done:
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSetAdminPassword(\r
+OpalUtilSetAdminPassword (\r
   OPAL_SESSION  *Session,\r
   const VOID    *OldPassword,\r
   UINT32        OldPasswordLength,\r
@@ -243,26 +248,26 @@ OpalUtilSetAdminPassword(
   UINT32        NewPasswordLength\r
   )\r
 {\r
-  TCG_RESULT   Ret;\r
-  UINT8        MethodStatus;\r
+  TCG_RESULT  Ret;\r
+  UINT8       MethodStatus;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(OldPassword);\r
-  NULL_CHECK(NewPassword);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (OldPassword);\r
+  NULL_CHECK (NewPassword);\r
 \r
   //\r
   // Unknown ownership\r
   //\r
-  Ret = OpalStartSession(\r
-                  Session,\r
-                  OPAL_UID_ADMIN_SP,\r
-                  TRUE,\r
-                  OldPasswordLength,\r
-                  OldPassword,\r
-                  OPAL_ADMIN_SP_SID_AUTHORITY,\r
-                  &MethodStatus\r
-                  );\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_ADMIN_SP,\r
+          TRUE,\r
+          OldPasswordLength,\r
+          OldPassword,\r
+          OPAL_ADMIN_SP_SID_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "start session with admin SP using old Password failed\n"));\r
     goto done;\r
   }\r
@@ -270,23 +275,23 @@ OpalUtilSetAdminPassword(
   //\r
   // Update SID = new pw\r
   //\r
-  Ret = OpalSetPassword(Session, OPAL_UID_ADMIN_SP_C_PIN_SID, NewPassword, NewPasswordLength, &MethodStatus);\r
-  OpalEndSession(Session);\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalSetPassword (Session, OPAL_UID_ADMIN_SP_C_PIN_SID, NewPassword, NewPasswordLength, &MethodStatus);\r
+  OpalEndSession (Session);\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "set new admin SP Password failed\n"));\r
     goto done;\r
   }\r
 \r
-  Ret = OpalStartSession(\r
-                  Session,\r
-                  OPAL_UID_LOCKING_SP,\r
-                  TRUE,\r
-                  OldPasswordLength,\r
-                  OldPassword,\r
-                  OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
-                  &MethodStatus\r
-                  );\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          OldPasswordLength,\r
+          OldPassword,\r
+          OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "start session with locking SP using old Password failed\n"));\r
     goto done;\r
   }\r
@@ -294,9 +299,9 @@ OpalUtilSetAdminPassword(
   //\r
   // Update admin locking SP to new pw\r
   //\r
-  Ret = OpalSetPassword(Session, OPAL_LOCKING_SP_C_PIN_ADMIN1, NewPassword, NewPasswordLength, &MethodStatus);\r
-  OpalEndSession(Session);\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalSetPassword (Session, OPAL_LOCKING_SP_C_PIN_ADMIN1, NewPassword, NewPasswordLength, &MethodStatus);\r
+  OpalEndSession (Session);\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "set new locking SP Password failed\n"));\r
     goto done;\r
   }\r
@@ -305,6 +310,7 @@ done:
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     Ret = TcgResultFailure;\r
   }\r
+\r
   return Ret;\r
 }\r
 \r
@@ -321,43 +327,43 @@ done:
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSetUserPassword(\r
-  OPAL_SESSION    *Session,\r
-  const VOID      *OldPassword,\r
-  UINT32          OldPasswordLength,\r
-  const VOID      *NewPassword,\r
-  UINT32          NewPasswordLength\r
+OpalUtilSetUserPassword (\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *OldPassword,\r
+  UINT32        OldPasswordLength,\r
+  const VOID    *NewPassword,\r
+  UINT32        NewPasswordLength\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(OldPassword);\r
-  NULL_CHECK(NewPassword);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (OldPassword);\r
+  NULL_CHECK (NewPassword);\r
 \r
   //\r
   // See if updating user1 authority\r
   //\r
-  Ret = OpalStartSession(\r
-                    Session,\r
-                    OPAL_UID_LOCKING_SP,\r
-                    TRUE,\r
-                    OldPasswordLength,\r
-                    OldPassword,\r
-                    OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                    &MethodStatus\r
-                    );\r
-  if (Ret == TcgResultSuccess && MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) {\r
-    Ret = OpalSetPassword(\r
-                      Session,\r
-                      OPAL_LOCKING_SP_C_PIN_USER1,\r
-                      NewPassword,\r
-                      NewPasswordLength,\r
-                      &MethodStatus\r
-                      );\r
-    OpalEndSession(Session);\r
-    if (Ret == TcgResultSuccess && MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          OldPasswordLength,\r
+          OldPassword,\r
+          OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
+    Ret = OpalSetPassword (\r
+            Session,\r
+            OPAL_LOCKING_SP_C_PIN_USER1,\r
+            NewPassword,\r
+            NewPasswordLength,\r
+            &MethodStatus\r
+            );\r
+    OpalEndSession (Session);\r
+    if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
       return Ret;\r
     }\r
   }\r
@@ -369,16 +375,16 @@ OpalUtilSetUserPassword(
   //\r
   // Start session with Locking SP using current admin Password\r
   //\r
-  Ret = OpalStartSession(\r
-                    Session,\r
-                    OPAL_UID_LOCKING_SP,\r
-                    TRUE,\r
-                    OldPasswordLength,\r
-                    OldPassword,\r
-                    OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
-                    &MethodStatus\r
-                    );\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          OldPasswordLength,\r
+          OldPassword,\r
+          OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "StartSession with locking SP as admin1 authority failed\n"));\r
     goto done;\r
   }\r
@@ -386,16 +392,16 @@ OpalUtilSetUserPassword(
   //\r
   // Enable User1 and set its PIN\r
   //\r
-  Ret = OpalSetLockingSpAuthorityEnabledAndPin(\r
-                                          Session,\r
-                                          OPAL_LOCKING_SP_C_PIN_USER1,\r
-                                          OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                                          NewPassword,\r
-                                          NewPasswordLength,\r
-                                          &MethodStatus\r
-                                          );\r
-  OpalEndSession(Session);\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalSetLockingSpAuthorityEnabledAndPin (\r
+          Session,\r
+          OPAL_LOCKING_SP_C_PIN_USER1,\r
+          OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+          NewPassword,\r
+          NewPasswordLength,\r
+          &MethodStatus\r
+          );\r
+  OpalEndSession (Session);\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "OpalSetLockingSpAuthorityEnabledAndPin failed\n"));\r
     goto done;\r
   }\r
@@ -404,6 +410,7 @@ done:
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     Ret = TcgResultFailure;\r
   }\r
+\r
   return Ret;\r
 }\r
 \r
@@ -419,28 +426,29 @@ done:
 TCG_RESULT\r
 EFIAPI\r
 OpalUtilVerifyPassword (\r
-  OPAL_SESSION   *Session,\r
-  const VOID     *Password,\r
-  UINT32         PasswordLength,\r
-  TCG_UID        HostSigningAuthority\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  TCG_UID       HostSigningAuthority\r
   )\r
 {\r
-  TCG_RESULT                    Ret;\r
-  UINT8                         MethodStatus;\r
-\r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Password);\r
-\r
-  Ret = OpalStartSession(\r
-            Session,\r
-            OPAL_UID_LOCKING_SP,\r
-            TRUE,\r
-            PasswordLength,\r
-            Password,\r
-            HostSigningAuthority,\r
-            &MethodStatus);\r
-  if (Ret == TcgResultSuccess && MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) {\r
-    OpalEndSession(Session);\r
+  TCG_RESULT  Ret;\r
+  UINT8       MethodStatus;\r
+\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Password);\r
+\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          PasswordLength,\r
+          Password,\r
+          HostSigningAuthority,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
+    OpalEndSession (Session);\r
     return TcgResultSuccess;\r
   }\r
 \r
@@ -459,55 +467,55 @@ OpalUtilVerifyPassword (
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilSecureErase(\r
-  OPAL_SESSION     *Session,\r
-  const VOID       *Password,\r
-  UINT32           PasswordLength,\r
-  BOOLEAN          *PasswordFailed\r
+OpalUtilSecureErase (\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  BOOLEAN       *PasswordFailed\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Password);\r
-  NULL_CHECK(PasswordFailed);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Password);\r
+  NULL_CHECK (PasswordFailed);\r
 \r
   //\r
   // Try to generate a new key with admin1\r
   //\r
-  Ret = OpalStartSession(\r
-                      Session,\r
-                      OPAL_UID_LOCKING_SP,\r
-                      TRUE,\r
-                      PasswordLength,\r
-                      Password,\r
-                      OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
-                      &MethodStatus\r
-                      );\r
-\r
-  if (Ret == TcgResultSuccess && MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) {\r
-    Ret = OpalGlobalLockingRangeGenKey(Session, &MethodStatus);\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          PasswordLength,\r
+          Password,\r
+          OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+\r
+  if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
+    Ret             = OpalGlobalLockingRangeGenKey (Session, &MethodStatus);\r
     *PasswordFailed = FALSE;\r
-    OpalEndSession(Session);\r
+    OpalEndSession (Session);\r
   } else {\r
     //\r
     // Try to generate a new key with user1\r
     //\r
-    Ret = OpalStartSession(\r
-                      Session,\r
-                      OPAL_UID_LOCKING_SP,\r
-                      TRUE,\r
-                      PasswordLength,\r
-                      Password,\r
-                      OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                      &MethodStatus\r
-                      );\r
-\r
-    if (Ret == TcgResultSuccess && MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) {\r
-      Ret = OpalGlobalLockingRangeGenKey(Session, &MethodStatus);\r
+    Ret = OpalStartSession (\r
+            Session,\r
+            OPAL_UID_LOCKING_SP,\r
+            TRUE,\r
+            PasswordLength,\r
+            Password,\r
+            OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+            &MethodStatus\r
+            );\r
+\r
+    if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
+      Ret             = OpalGlobalLockingRangeGenKey (Session, &MethodStatus);\r
       *PasswordFailed = FALSE;\r
-      OpalEndSession(Session);\r
+      OpalEndSession (Session);\r
     } else {\r
       *PasswordFailed = TRUE;\r
     }\r
@@ -516,6 +524,7 @@ OpalUtilSecureErase(
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     Ret = TcgResultFailure;\r
   }\r
+\r
   return Ret;\r
 }\r
 \r
@@ -530,46 +539,47 @@ OpalUtilSecureErase(
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilDisableUser(\r
-  OPAL_SESSION   *Session,\r
-  const VOID     *Password,\r
-  UINT32         PasswordLength,\r
-  BOOLEAN        *PasswordFailed\r
+OpalUtilDisableUser (\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  BOOLEAN       *PasswordFailed\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Password);\r
-  NULL_CHECK(PasswordFailed);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Password);\r
+  NULL_CHECK (PasswordFailed);\r
 \r
   //\r
   // Start session with Locking SP using current admin Password\r
   //\r
-  Ret = OpalStartSession(\r
-                    Session,\r
-                    OPAL_UID_LOCKING_SP,\r
-                    TRUE,\r
-                    PasswordLength,\r
-                    Password,\r
-                    OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
-                    &MethodStatus\r
-                    );\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          PasswordLength,\r
+          Password,\r
+          OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "StartSession with Locking SP as Admin1 failed\n"));\r
     *PasswordFailed = TRUE;\r
     goto done;\r
   }\r
 \r
   *PasswordFailed = FALSE;\r
-  Ret = OpalDisableUser(Session, &MethodStatus);\r
-  OpalEndSession(Session);\r
+  Ret             = OpalDisableUser (Session, &MethodStatus);\r
+  OpalEndSession (Session);\r
 \r
 done:\r
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     Ret = TcgResultFailure;\r
   }\r
+\r
   return Ret;\r
 }\r
 \r
@@ -587,39 +597,39 @@ done:
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilRevert(\r
-  OPAL_SESSION     *Session,\r
-  BOOLEAN          KeepUserData,\r
-  const VOID       *Password,\r
-  UINT32           PasswordLength,\r
-  BOOLEAN          *PasswordFailed,\r
-  UINT8            *Msid,\r
-  UINT32           MsidLength\r
+OpalUtilRevert (\r
+  OPAL_SESSION  *Session,\r
+  BOOLEAN       KeepUserData,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  BOOLEAN       *PasswordFailed,\r
+  UINT8         *Msid,\r
+  UINT32        MsidLength\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
-  UINT32       RemovalTimeOut;\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
+  UINT32      RemovalTimeOut;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Msid);\r
-  NULL_CHECK(Password);\r
-  NULL_CHECK(PasswordFailed);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Msid);\r
+  NULL_CHECK (Password);\r
+  NULL_CHECK (PasswordFailed);\r
 \r
   RemovalTimeOut = GetRevertTimeOut (Session);\r
   DEBUG ((DEBUG_INFO, "OpalUtilRevert: Timeout value = %d\n", RemovalTimeOut));\r
 \r
-  Ret = OpalStartSession(\r
-                   Session,\r
-                   OPAL_UID_LOCKING_SP,\r
-                   TRUE,\r
-                   PasswordLength,\r
-                   Password,\r
-                   OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
-                   &MethodStatus\r
-                   );\r
-\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          PasswordLength,\r
+          Password,\r
+          OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "error starting session: Ret=%d, MethodStatus=%u\n", Ret, MethodStatus));\r
     *PasswordFailed = TRUE;\r
     goto done;\r
@@ -629,13 +639,13 @@ OpalUtilRevert(
   //\r
   // Try to revert with admin1\r
   //\r
-  Ret = OpalPyrite2AdminRevert(Session, KeepUserData, &MethodStatus, RemovalTimeOut);\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalPyrite2AdminRevert (Session, KeepUserData, &MethodStatus, RemovalTimeOut);\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     //\r
     // Device ends the session on successful revert, so only call OpalEndSession when fail.\r
     //\r
     DEBUG ((DEBUG_INFO, "OpalAdminRevert as admin failed\n"));\r
-    OpalEndSession(Session);\r
+    OpalEndSession (Session);\r
   }\r
 \r
   Ret = OpalUtilSetSIDtoMSID (Session, Password, PasswordLength, Msid, MsidLength);\r
@@ -644,6 +654,7 @@ done:
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
     Ret = TcgResultFailure;\r
   }\r
+\r
   return Ret;\r
 }\r
 \r
@@ -660,41 +671,41 @@ done:
 TCG_RESULT\r
 EFIAPI\r
 OpalUtilSetSIDtoMSID (\r
-  OPAL_SESSION     *Session,\r
-  const VOID       *Password,\r
-  UINT32           PasswordLength,\r
-  UINT8            *Msid,\r
-  UINT32           MsidLength\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  UINT8         *Msid,\r
+  UINT32        MsidLength\r
   )\r
 {\r
-  TCG_RESULT                   Ret;\r
-  UINT8                        MethodStatus;\r
+  TCG_RESULT  Ret;\r
+  UINT8       MethodStatus;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Msid);\r
-  NULL_CHECK(Password);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Msid);\r
+  NULL_CHECK (Password);\r
 \r
   //\r
   // Start session with admin sp to update SID to MSID\r
   //\r
-  Ret = OpalStartSession(\r
-            Session,\r
-            OPAL_UID_ADMIN_SP,\r
-            TRUE,\r
-            PasswordLength,\r
-            Password,\r
-            OPAL_ADMIN_SP_SID_AUTHORITY,\r
-            &MethodStatus\r
-            );\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_ADMIN_SP,\r
+          TRUE,\r
+          PasswordLength,\r
+          Password,\r
+          OPAL_ADMIN_SP_SID_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     goto done;\r
   }\r
 \r
   //\r
   // Update SID pin\r
   //\r
-  Ret = OpalSetPassword(Session, OPAL_UID_ADMIN_SP_C_PIN_SID, Msid, MsidLength, &MethodStatus);\r
-  OpalEndSession(Session);\r
+  Ret = OpalSetPassword (Session, OPAL_UID_ADMIN_SP_C_PIN_SID, Msid, MsidLength, &MethodStatus);\r
+  OpalEndSession (Session);\r
 \r
 done:\r
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
@@ -716,41 +727,41 @@ done:
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilUpdateGlobalLockingRange(\r
-  OPAL_SESSION    *Session,\r
-  const VOID      *Password,\r
-  UINT32          PasswordLength,\r
-  BOOLEAN         ReadLocked,\r
-  BOOLEAN         WriteLocked\r
+OpalUtilUpdateGlobalLockingRange (\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *Password,\r
+  UINT32        PasswordLength,\r
+  BOOLEAN       ReadLocked,\r
+  BOOLEAN       WriteLocked\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Password);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Password);\r
 \r
   //\r
   // Try to start session with Locking SP as admin1 authority\r
   //\r
-  Ret = OpalStartSession(\r
-                    Session,\r
-                    OPAL_UID_LOCKING_SP,\r
-                    TRUE,\r
-                    PasswordLength,\r
-                    Password,\r
-                    OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
-                    &MethodStatus\r
-                    );\r
-  if (Ret == TcgResultSuccess && MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) {\r
-    Ret = OpalUpdateGlobalLockingRange(\r
-                                Session,\r
-                                ReadLocked,\r
-                                WriteLocked,\r
-                                &MethodStatus\r
-                                );\r
-    OpalEndSession(Session);\r
-    if (Ret == TcgResultSuccess && MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          PasswordLength,\r
+          Password,\r
+          OPAL_LOCKING_SP_ADMIN1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
+    Ret = OpalUpdateGlobalLockingRange (\r
+            Session,\r
+            ReadLocked,\r
+            WriteLocked,\r
+            &MethodStatus\r
+            );\r
+    OpalEndSession (Session);\r
+    if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
       goto done;\r
     }\r
   }\r
@@ -762,22 +773,22 @@ OpalUtilUpdateGlobalLockingRange(
   //\r
   // Try user1 authority\r
   //\r
-  Ret = OpalStartSession(\r
-                    Session,\r
-                    OPAL_UID_LOCKING_SP,\r
-                    TRUE,\r
-                    PasswordLength,\r
-                    Password,\r
-                    OPAL_LOCKING_SP_USER1_AUTHORITY,\r
-                    &MethodStatus\r
-                    );\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_LOCKING_SP,\r
+          TRUE,\r
+          PasswordLength,\r
+          Password,\r
+          OPAL_LOCKING_SP_USER1_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "StartSession with Locking SP as User1 failed\n"));\r
     goto done;\r
   }\r
 \r
-  Ret = OpalUpdateGlobalLockingRange(Session, ReadLocked, WriteLocked, &MethodStatus);\r
-  OpalEndSession(Session);\r
+  Ret = OpalUpdateGlobalLockingRange (Session, ReadLocked, WriteLocked, &MethodStatus);\r
+  OpalEndSession (Session);\r
 \r
 done:\r
   if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
@@ -791,6 +802,7 @@ done:
       Ret = TcgResultFailure;\r
     }\r
   }\r
+\r
   return Ret;\r
 }\r
 \r
@@ -805,29 +817,29 @@ done:
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalUtilGetMsid(\r
-  OPAL_SESSION    *Session,\r
-  UINT8           *Msid,\r
-  UINT32          MsidBufferLength,\r
-  UINT32          *MsidLength\r
+OpalUtilGetMsid (\r
+  OPAL_SESSION  *Session,\r
+  UINT8         *Msid,\r
+  UINT32        MsidBufferLength,\r
+  UINT32        *MsidLength\r
   )\r
 {\r
-  UINT8        MethodStatus;\r
-  TCG_RESULT   Ret;\r
-\r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Msid);\r
-  NULL_CHECK(MsidLength);\r
-\r
-  Ret = OpalStartSession(\r
-                   Session,\r
-                   OPAL_UID_ADMIN_SP,\r
-                   TRUE,\r
-                   0,\r
-                   NULL,\r
-                   TCG_UID_NULL,\r
-                   &MethodStatus\r
-                   );\r
+  UINT8       MethodStatus;\r
+  TCG_RESULT  Ret;\r
+\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Msid);\r
+  NULL_CHECK (MsidLength);\r
+\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_ADMIN_SP,\r
+          TRUE,\r
+          0,\r
+          NULL,\r
+          TCG_UID_NULL,\r
+          &MethodStatus\r
+          );\r
   if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     Ret = OpalGetMsid (Session, MsidBufferLength, Msid, MsidLength);\r
     OpalEndSession (Session);\r
@@ -854,10 +866,10 @@ OpalUtilGetMsid(
 **/\r
 OPAL_OWNER_SHIP\r
 EFIAPI\r
-OpalUtilDetermineOwnership(\r
-  OPAL_SESSION       *Session,\r
-  UINT8              *Msid,\r
-  UINT32             MsidLength\r
+OpalUtilDetermineOwnership (\r
+  OPAL_SESSION  *Session,\r
+  UINT8         *Msid,\r
+  UINT32        MsidLength\r
   )\r
 {\r
   UINT8            MethodStatus;\r
@@ -872,21 +884,22 @@ OpalUtilDetermineOwnership(
   //\r
   // Start Session as SID_UID with ADMIN_SP using MSID PIN\r
   //\r
-  Ret = OpalStartSession(\r
-                    Session,\r
-                    OPAL_UID_ADMIN_SP,\r
-                    TRUE,\r
-                    MsidLength,\r
-                    Msid,\r
-                    OPAL_ADMIN_SP_SID_AUTHORITY,\r
-                    &MethodStatus);\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_ADMIN_SP,\r
+          TRUE,\r
+          MsidLength,\r
+          Msid,\r
+          OPAL_ADMIN_SP_SID_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
   if ((Ret == TcgResultSuccess) && (MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     //\r
     // now we know that SID PIN == MSID PIN\r
     //\r
     Owner = OpalOwnershipNobody;\r
 \r
-    OpalEndSession(Session);\r
+    OpalEndSession (Session);\r
   }\r
 \r
   return Owner;\r
@@ -905,12 +918,12 @@ OpalUtilDetermineOwnership(
 **/\r
 BOOLEAN\r
 EFIAPI\r
-OpalUtilAdminPasswordExists(\r
-  IN  UINT16                           OwnerShip,\r
-  IN  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature\r
+OpalUtilAdminPasswordExists (\r
+  IN  UINT16                          OwnerShip,\r
+  IN  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature\r
   )\r
 {\r
-  NULL_CHECK(LockingFeature);\r
+  NULL_CHECK (LockingFeature);\r
 \r
   // if it is Unknown who owns the device\r
   // then someone has set password previously through our UI\r
@@ -935,46 +948,47 @@ OpalUtilAdminPasswordExists(
 TCG_RESULT\r
 EFIAPI\r
 OpalUtilGetActiveDataRemovalMechanism (\r
-  OPAL_SESSION      *Session,\r
-  const VOID        *GeneratedSid,\r
-  UINT32            SidLength,\r
-  UINT8             *ActiveDataRemovalMechanism\r
+  OPAL_SESSION  *Session,\r
+  const VOID    *GeneratedSid,\r
+  UINT32        SidLength,\r
+  UINT8         *ActiveDataRemovalMechanism\r
   )\r
 {\r
-  TCG_RESULT   Ret;\r
-  UINT8        MethodStatus;\r
-\r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(GeneratedSid);\r
-  NULL_CHECK(ActiveDataRemovalMechanism);\r
-\r
-  Ret = OpalStartSession(\r
-                    Session,\r
-                    OPAL_UID_ADMIN_SP,\r
-                    TRUE,\r
-                    SidLength,\r
-                    GeneratedSid,\r
-                    OPAL_ADMIN_SP_ANYBODY_AUTHORITY,\r
-                    &MethodStatus\r
-                    );\r
-  if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
+  TCG_RESULT  Ret;\r
+  UINT8       MethodStatus;\r
+\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (GeneratedSid);\r
+  NULL_CHECK (ActiveDataRemovalMechanism);\r
+\r
+  Ret = OpalStartSession (\r
+          Session,\r
+          OPAL_UID_ADMIN_SP,\r
+          TRUE,\r
+          SidLength,\r
+          GeneratedSid,\r
+          OPAL_ADMIN_SP_ANYBODY_AUTHORITY,\r
+          &MethodStatus\r
+          );\r
+  if ((Ret != TcgResultSuccess) || (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS)) {\r
     DEBUG ((DEBUG_INFO, "Start session with admin SP as SID authority failed: Ret=%d MethodStatus=%u\n", Ret, MethodStatus));\r
     if (MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) {\r
       Ret = TcgResultFailure;\r
     }\r
+\r
     return Ret;\r
   }\r
 \r
   Ret = OpalPyrite2GetActiveDataRemovalMechanism (\r
-                    Session,\r
-                    ActiveDataRemovalMechanism\r
-                    );\r
+          Session,\r
+          ActiveDataRemovalMechanism\r
+          );\r
 \r
   if (Ret != TcgResultSuccess) {\r
     DEBUG ((DEBUG_INFO, "Pyrite2 Get Active Data Removal Mechanism failed: Ret=%d\n", Ret));\r
   }\r
 \r
-  OpalEndSession(Session);\r
+  OpalEndSession (Session);\r
 \r
   return Ret;\r
 }\r
@@ -988,8 +1002,8 @@ OpalUtilGetActiveDataRemovalMechanism (
 **/\r
 UINT32\r
 CalculateDataRemovalTime (\r
-  IN BOOLEAN               IsMinute,\r
-  IN UINT16                Time\r
+  IN BOOLEAN  IsMinute,\r
+  IN UINT16   Time\r
   )\r
 {\r
   if (IsMinute) {\r
@@ -1013,26 +1027,26 @@ GetDataRemovalTime (
   )\r
 {\r
   switch (Index) {\r
-  case OverwriteDataErase:\r
-    return CalculateDataRemovalTime (Descriptor->FormatBit0, SwapBytes16 (Descriptor->TimeBit0));\r
+    case OverwriteDataErase:\r
+      return CalculateDataRemovalTime (Descriptor->FormatBit0, SwapBytes16 (Descriptor->TimeBit0));\r
 \r
-  case BlockErase:\r
-    return CalculateDataRemovalTime (Descriptor->FormatBit1, SwapBytes16 (Descriptor->TimeBit1));\r
+    case BlockErase:\r
+      return CalculateDataRemovalTime (Descriptor->FormatBit1, SwapBytes16 (Descriptor->TimeBit1));\r
 \r
-  case CryptoErase:\r
-    return CalculateDataRemovalTime (Descriptor->FormatBit2, SwapBytes16 (Descriptor->TimeBit2));\r
+    case CryptoErase:\r
+      return CalculateDataRemovalTime (Descriptor->FormatBit2, SwapBytes16 (Descriptor->TimeBit2));\r
 \r
-  case Unmap:\r
-    return CalculateDataRemovalTime (Descriptor->FormatBit3, SwapBytes16 (Descriptor->TimeBit3));\r
+    case Unmap:\r
+      return CalculateDataRemovalTime (Descriptor->FormatBit3, SwapBytes16 (Descriptor->TimeBit3));\r
 \r
-  case ResetWritePointers:\r
-    return CalculateDataRemovalTime (Descriptor->FormatBit4, SwapBytes16 (Descriptor->TimeBit4));\r
+    case ResetWritePointers:\r
+      return CalculateDataRemovalTime (Descriptor->FormatBit4, SwapBytes16 (Descriptor->TimeBit4));\r
 \r
-  case VendorSpecificErase:\r
-    return CalculateDataRemovalTime (Descriptor->FormatBit5, SwapBytes16 (Descriptor->TimeBit5));\r
+    case VendorSpecificErase:\r
+      return CalculateDataRemovalTime (Descriptor->FormatBit5, SwapBytes16 (Descriptor->TimeBit5));\r
 \r
-  default:\r
-    return 0;\r
+    default:\r
+      return 0;\r
   }\r
 }\r
 \r
@@ -1046,8 +1060,8 @@ GetDataRemovalTime (
 TCG_RESULT\r
 EFIAPI\r
 OpalUtilGetDataRemovalMechanismLists (\r
-  IN  OPAL_SESSION      *Session,\r
-  OUT UINT32            *RemovalMechanismLists\r
+  IN  OPAL_SESSION  *Session,\r
+  OUT UINT32        *RemovalMechanismLists\r
   )\r
 {\r
   TCG_RESULT                       Ret;\r
@@ -1056,19 +1070,19 @@ OpalUtilGetDataRemovalMechanismLists (
   UINT8                            Index;\r
   UINT8                            BitValue;\r
 \r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(RemovalMechanismLists);\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (RemovalMechanismLists);\r
 \r
   DataSize = sizeof (Descriptor);\r
-  Ret = OpalGetFeatureDescriptor (Session, TCG_FEATURE_DATA_REMOVAL, &DataSize, &Descriptor);\r
+  Ret      = OpalGetFeatureDescriptor (Session, TCG_FEATURE_DATA_REMOVAL, &DataSize, &Descriptor);\r
   if (Ret != TcgResultSuccess) {\r
     return TcgResultFailure;\r
   }\r
 \r
   ASSERT (Descriptor.RemovalMechanism != 0);\r
 \r
-  for (Index = 0; Index < ResearvedMechanism; Index ++) {\r
-    BitValue = (BOOLEAN) BitFieldRead8 (Descriptor.RemovalMechanism, Index, Index);\r
+  for (Index = 0; Index < ResearvedMechanism; Index++) {\r
+    BitValue = (BOOLEAN)BitFieldRead8 (Descriptor.RemovalMechanism, Index, Index);\r
 \r
     if (BitValue == 0) {\r
       RemovalMechanismLists[Index] = 0;\r
@@ -1088,7 +1102,7 @@ OpalUtilGetDataRemovalMechanismLists (
 **/\r
 UINT32\r
 GetRevertTimeOut (\r
-  IN OPAL_SESSION                *Session\r
+  IN OPAL_SESSION  *Session\r
   )\r
 {\r
   TCG_RESULT                   TcgResult;\r
@@ -1100,7 +1114,7 @@ GetRevertTimeOut (
   UINT8                        ActiveDataRemovalMechanism;\r
 \r
   TcgResult = OpalGetSupportedAttributesInfo (Session, &SupportedAttributes, &BaseComId);\r
-  if (TcgResult != TcgResultSuccess || SupportedAttributes.DataRemoval == 0) {\r
+  if ((TcgResult != TcgResultSuccess) || (SupportedAttributes.DataRemoval == 0)) {\r
     return 0;\r
   }\r
 \r
index 8a10d999080f94020816ed6a026b9adf82909c68..0c9e2d01f34c37f733a54e51f2a7ac557d21ee17 100644 (file)
@@ -16,22 +16,22 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM_RQU_COMMAND_HDR  Hdr;\r
-  UINT32               Capability;\r
-  UINT32               CapabilityFlagSize;\r
-  UINT32               CapabilityFlag;\r
+  TPM_RQU_COMMAND_HDR    Hdr;\r
+  UINT32                 Capability;\r
+  UINT32                 CapabilityFlagSize;\r
+  UINT32                 CapabilityFlag;\r
 } TPM_CMD_GET_CAPABILITY;\r
 \r
 typedef struct {\r
-  TPM_RSP_COMMAND_HDR  Hdr;\r
-  UINT32               ResponseSize;\r
-  TPM_PERMANENT_FLAGS  Flags;\r
+  TPM_RSP_COMMAND_HDR    Hdr;\r
+  UINT32                 ResponseSize;\r
+  TPM_PERMANENT_FLAGS    Flags;\r
 } TPM_RSP_GET_CAPABILITY_PERMANENT_FLAGS;\r
 \r
 typedef struct {\r
-  TPM_RSP_COMMAND_HDR  Hdr;\r
-  UINT32               ResponseSize;\r
-  TPM_STCLEAR_FLAGS    Flags;\r
+  TPM_RSP_COMMAND_HDR    Hdr;\r
+  UINT32                 ResponseSize;\r
+  TPM_STCLEAR_FLAGS      Flags;\r
 } TPM_RSP_GET_CAPABILITY_STCLEAR_FLAGS;\r
 \r
 #pragma pack()\r
@@ -67,8 +67,8 @@ Tpm12GetCapabilityFlagPermanent (
   Command.Capability         = SwapBytes32 (TPM_CAP_FLAG);\r
   Command.CapabilityFlagSize = SwapBytes32 (sizeof (TPM_CAP_FLAG_PERMANENT));\r
   Command.CapabilityFlag     = SwapBytes32 (TPM_CAP_FLAG_PERMANENT);\r
-  Length = sizeof (Response);\r
-  Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
+  Length                     = sizeof (Response);\r
+  Status                     = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -79,7 +79,7 @@ Tpm12GetCapabilityFlagPermanent (
   }\r
 \r
   ZeroMem (TpmPermanentFlags, sizeof (*TpmPermanentFlags));\r
-  CopyMem (TpmPermanentFlags, &Response.Flags, MIN (sizeof (*TpmPermanentFlags), SwapBytes32(Response.ResponseSize)));\r
+  CopyMem (TpmPermanentFlags, &Response.Flags, MIN (sizeof (*TpmPermanentFlags), SwapBytes32 (Response.ResponseSize)));\r
 \r
   return Status;\r
 }\r
@@ -113,8 +113,8 @@ Tpm12GetCapabilityFlagVolatile (
   Command.Capability         = SwapBytes32 (TPM_CAP_FLAG);\r
   Command.CapabilityFlagSize = SwapBytes32 (sizeof (TPM_CAP_FLAG_VOLATILE));\r
   Command.CapabilityFlag     = SwapBytes32 (TPM_CAP_FLAG_VOLATILE);\r
-  Length = sizeof (Response);\r
-  Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
+  Length                     = sizeof (Response);\r
+  Status                     = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -125,7 +125,7 @@ Tpm12GetCapabilityFlagVolatile (
   }\r
 \r
   ZeroMem (VolatileFlags, sizeof (*VolatileFlags));\r
-  CopyMem (VolatileFlags, &Response.Flags, MIN (sizeof (*VolatileFlags), SwapBytes32(Response.ResponseSize)));\r
+  CopyMem (VolatileFlags, &Response.Flags, MIN (sizeof (*VolatileFlags), SwapBytes32 (Response.ResponseSize)));\r
 \r
   return Status;\r
 }\r
index 8295a1d2675872027105aa21b505b24d6db58c46..02feb375e1f3d90093d2e82b3c0102b2ba688121 100644 (file)
@@ -22,30 +22,30 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM_RQU_COMMAND_HDR   Hdr;\r
-  TPM12_NV_DATA_PUBLIC  PubInfo;\r
-  TPM_ENCAUTH           EncAuth;\r
+  TPM_RQU_COMMAND_HDR     Hdr;\r
+  TPM12_NV_DATA_PUBLIC    PubInfo;\r
+  TPM_ENCAUTH             EncAuth;\r
 } TPM_CMD_NV_DEFINE_SPACE;\r
 \r
 typedef struct {\r
-  TPM_RQU_COMMAND_HDR   Hdr;\r
-  TPM_NV_INDEX          NvIndex;\r
-  UINT32                Offset;\r
-  UINT32                DataSize;\r
+  TPM_RQU_COMMAND_HDR    Hdr;\r
+  TPM_NV_INDEX           NvIndex;\r
+  UINT32                 Offset;\r
+  UINT32                 DataSize;\r
 } TPM_CMD_NV_READ_VALUE;\r
 \r
 typedef struct {\r
-  TPM_RSP_COMMAND_HDR   Hdr;\r
-  UINT32                DataSize;\r
-  UINT8                 Data[TPMNVVALUELENGTH];\r
+  TPM_RSP_COMMAND_HDR    Hdr;\r
+  UINT32                 DataSize;\r
+  UINT8                  Data[TPMNVVALUELENGTH];\r
 } TPM_RSP_NV_READ_VALUE;\r
 \r
 typedef struct {\r
-  TPM_RQU_COMMAND_HDR   Hdr;\r
-  TPM_NV_INDEX          NvIndex;\r
-  UINT32                Offset;\r
-  UINT32                DataSize;\r
-  UINT8                 Data[TPMNVVALUELENGTH];\r
+  TPM_RQU_COMMAND_HDR    Hdr;\r
+  TPM_NV_INDEX           NvIndex;\r
+  UINT32                 Offset;\r
+  UINT32                 DataSize;\r
+  UINT8                  Data[TPMNVVALUELENGTH];\r
 } TPM_CMD_NV_WRITE_VALUE;\r
 \r
 #pragma pack()\r
@@ -74,41 +74,42 @@ Tpm12NvDefineSpace (
   //\r
   // send Tpm command TPM_ORD_NV_DefineSpace\r
   //\r
-  Command.Hdr.tag         = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
-  Command.Hdr.paramSize   = SwapBytes32 (sizeof (Command));\r
-  Command.Hdr.ordinal     = SwapBytes32 (TPM_ORD_NV_DefineSpace);\r
-  Command.PubInfo.tag     = SwapBytes16 (PubInfo->tag);\r
-  Command.PubInfo.nvIndex = SwapBytes32 (PubInfo->nvIndex);\r
-  Command.PubInfo.pcrInfoRead.pcrSelection.sizeOfSelect  = SwapBytes16 (PubInfo->pcrInfoRead.pcrSelection.sizeOfSelect);\r
-  Command.PubInfo.pcrInfoRead.pcrSelection.pcrSelect[0]  = PubInfo->pcrInfoRead.pcrSelection.pcrSelect[0];\r
-  Command.PubInfo.pcrInfoRead.pcrSelection.pcrSelect[1]  = PubInfo->pcrInfoRead.pcrSelection.pcrSelect[1];\r
-  Command.PubInfo.pcrInfoRead.pcrSelection.pcrSelect[2]  = PubInfo->pcrInfoRead.pcrSelection.pcrSelect[2];\r
-  Command.PubInfo.pcrInfoRead.localityAtRelease          = PubInfo->pcrInfoRead.localityAtRelease;\r
-  CopyMem (&Command.PubInfo.pcrInfoRead.digestAtRelease, &PubInfo->pcrInfoRead.digestAtRelease, sizeof(PubInfo->pcrInfoRead.digestAtRelease));\r
+  Command.Hdr.tag                                       = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
+  Command.Hdr.paramSize                                 = SwapBytes32 (sizeof (Command));\r
+  Command.Hdr.ordinal                                   = SwapBytes32 (TPM_ORD_NV_DefineSpace);\r
+  Command.PubInfo.tag                                   = SwapBytes16 (PubInfo->tag);\r
+  Command.PubInfo.nvIndex                               = SwapBytes32 (PubInfo->nvIndex);\r
+  Command.PubInfo.pcrInfoRead.pcrSelection.sizeOfSelect = SwapBytes16 (PubInfo->pcrInfoRead.pcrSelection.sizeOfSelect);\r
+  Command.PubInfo.pcrInfoRead.pcrSelection.pcrSelect[0] = PubInfo->pcrInfoRead.pcrSelection.pcrSelect[0];\r
+  Command.PubInfo.pcrInfoRead.pcrSelection.pcrSelect[1] = PubInfo->pcrInfoRead.pcrSelection.pcrSelect[1];\r
+  Command.PubInfo.pcrInfoRead.pcrSelection.pcrSelect[2] = PubInfo->pcrInfoRead.pcrSelection.pcrSelect[2];\r
+  Command.PubInfo.pcrInfoRead.localityAtRelease         = PubInfo->pcrInfoRead.localityAtRelease;\r
+  CopyMem (&Command.PubInfo.pcrInfoRead.digestAtRelease, &PubInfo->pcrInfoRead.digestAtRelease, sizeof (PubInfo->pcrInfoRead.digestAtRelease));\r
   Command.PubInfo.pcrInfoWrite.pcrSelection.sizeOfSelect = SwapBytes16 (PubInfo->pcrInfoWrite.pcrSelection.sizeOfSelect);\r
   Command.PubInfo.pcrInfoWrite.pcrSelection.pcrSelect[0] = PubInfo->pcrInfoWrite.pcrSelection.pcrSelect[0];\r
   Command.PubInfo.pcrInfoWrite.pcrSelection.pcrSelect[1] = PubInfo->pcrInfoWrite.pcrSelection.pcrSelect[1];\r
   Command.PubInfo.pcrInfoWrite.pcrSelection.pcrSelect[2] = PubInfo->pcrInfoWrite.pcrSelection.pcrSelect[2];\r
   Command.PubInfo.pcrInfoWrite.localityAtRelease         = PubInfo->pcrInfoWrite.localityAtRelease;\r
-  CopyMem (&Command.PubInfo.pcrInfoWrite.digestAtRelease, &PubInfo->pcrInfoWrite.digestAtRelease, sizeof(PubInfo->pcrInfoWrite.digestAtRelease));\r
+  CopyMem (&Command.PubInfo.pcrInfoWrite.digestAtRelease, &PubInfo->pcrInfoWrite.digestAtRelease, sizeof (PubInfo->pcrInfoWrite.digestAtRelease));\r
   Command.PubInfo.permission.tag        = SwapBytes16 (PubInfo->permission.tag);\r
   Command.PubInfo.permission.attributes = SwapBytes32 (PubInfo->permission.attributes);\r
   Command.PubInfo.bReadSTClear          = PubInfo->bReadSTClear;\r
   Command.PubInfo.bWriteSTClear         = PubInfo->bWriteSTClear;\r
   Command.PubInfo.bWriteDefine          = PubInfo->bWriteDefine;\r
   Command.PubInfo.dataSize              = SwapBytes32 (PubInfo->dataSize);\r
-  CopyMem (&Command.EncAuth, EncAuth, sizeof(*EncAuth));\r
+  CopyMem (&Command.EncAuth, EncAuth, sizeof (*EncAuth));\r
   Length = sizeof (Response);\r
   Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "Tpm12NvDefineSpace - ReturnCode = %x\n", SwapBytes32 (Response.returnCode)));\r
   switch (SwapBytes32 (Response.returnCode)) {\r
-  case TPM_SUCCESS:\r
-    return EFI_SUCCESS;\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+    case TPM_SUCCESS:\r
+      return EFI_SUCCESS;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 }\r
 \r
@@ -146,17 +147,18 @@ Tpm12NvReadValue (
   Command.NvIndex       = SwapBytes32 (NvIndex);\r
   Command.Offset        = SwapBytes32 (Offset);\r
   Command.DataSize      = SwapBytes32 (*DataSize);\r
-  Length = sizeof (Response);\r
-  Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
+  Length                = sizeof (Response);\r
+  Status                = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "Tpm12NvReadValue - ReturnCode = %x\n", SwapBytes32 (Response.Hdr.returnCode)));\r
   switch (SwapBytes32 (Response.Hdr.returnCode)) {\r
-  case TPM_SUCCESS:\r
-    break;\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+    case TPM_SUCCESS:\r
+      break;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 \r
   //\r
@@ -165,6 +167,7 @@ Tpm12NvReadValue (
   if (SwapBytes32 (Response.DataSize) > *DataSize) {\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
+\r
   *DataSize = SwapBytes32 (Response.DataSize);\r
   ZeroMem (Data, *DataSize);\r
   CopyMem (Data, &Response.Data, *DataSize);\r
@@ -206,7 +209,7 @@ Tpm12NvWriteValue (
   // send Tpm command TPM_ORD_NV_WriteValue\r
   //\r
   Command.Hdr.tag       = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
-  CommandLength = sizeof (Command) - sizeof(Command.Data) + DataSize;\r
+  CommandLength         = sizeof (Command) - sizeof (Command.Data) + DataSize;\r
   Command.Hdr.paramSize = SwapBytes32 (CommandLength);\r
   Command.Hdr.ordinal   = SwapBytes32 (TPM_ORD_NV_WriteValue);\r
   Command.NvIndex       = SwapBytes32 (NvIndex);\r
@@ -214,15 +217,16 @@ Tpm12NvWriteValue (
   Command.DataSize      = SwapBytes32 (DataSize);\r
   CopyMem (Command.Data, Data, DataSize);\r
   ResponseLength = sizeof (Response);\r
-  Status = Tpm12SubmitCommand (CommandLength, (UINT8 *)&Command, &ResponseLength, (UINT8 *)&Response);\r
+  Status         = Tpm12SubmitCommand (CommandLength, (UINT8 *)&Command, &ResponseLength, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "Tpm12NvWriteValue - ReturnCode = %x\n", SwapBytes32 (Response.returnCode)));\r
   switch (SwapBytes32 (Response.returnCode)) {\r
-  case TPM_SUCCESS:\r
-    return EFI_SUCCESS;\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+    case TPM_SUCCESS:\r
+      return EFI_SUCCESS;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 }\r
index 382f059fb66d68761945b308f5d76ce043e8d73f..1dae03d17a12e272c4574dbc3a84e5920d6c01c8 100644 (file)
@@ -31,19 +31,20 @@ Tpm12ForceClear (
   //\r
   // send Tpm command TPM_ORD_ForceClear\r
   //\r
-  Command.tag        = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
-  Command.paramSize  = SwapBytes32 (sizeof (Command));\r
-  Command.ordinal    = SwapBytes32 (TPM_ORD_ForceClear);\r
-  Length = sizeof (Response);\r
+  Command.tag       = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
+  Command.paramSize = SwapBytes32 (sizeof (Command));\r
+  Command.ordinal   = SwapBytes32 (TPM_ORD_ForceClear);\r
+  Length            = sizeof (Response);\r
 \r
   Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   switch (SwapBytes32 (Response.returnCode)) {\r
-  case TPM_SUCCESS:\r
-    return EFI_SUCCESS;\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+    case TPM_SUCCESS:\r
+      return EFI_SUCCESS;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 }\r
index 4fbcb3617c08f0431b2f3ffdf09ce5bcc67a7b0c..542c6aed05ace011696218deb5e6265ef21c3692 100644 (file)
@@ -16,14 +16,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM_RQU_COMMAND_HDR   Hdr;\r
-  TPM_PCRINDEX          PcrIndex;\r
-  TPM_DIGEST            TpmDigest;\r
+  TPM_RQU_COMMAND_HDR    Hdr;\r
+  TPM_PCRINDEX           PcrIndex;\r
+  TPM_DIGEST             TpmDigest;\r
 } TPM_CMD_EXTEND;\r
 \r
 typedef struct {\r
-  TPM_RSP_COMMAND_HDR   Hdr;\r
-  TPM_DIGEST            TpmDigest;\r
+  TPM_RSP_COMMAND_HDR    Hdr;\r
+  TPM_DIGEST             TpmDigest;\r
 } TPM_RSP_EXTEND;\r
 \r
 #pragma pack()\r
@@ -68,8 +68,8 @@ Tpm12Extend (
     return Status;\r
   }\r
 \r
-  if (SwapBytes32(Response.Hdr.returnCode) != TPM_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm12Extend: Response Code error! 0x%08x\r\n", SwapBytes32(Response.Hdr.returnCode)));\r
+  if (SwapBytes32 (Response.Hdr.returnCode) != TPM_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm12Extend: Response Code error! 0x%08x\r\n", SwapBytes32 (Response.Hdr.returnCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
index 6714d17d8eeec48c800b1896c860961216945ca9..034a15cf14ab16d0da728acfde52096f658beab2 100644 (file)
@@ -15,8 +15,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM_RQU_COMMAND_HDR   Hdr;\r
-  TPM_PHYSICAL_PRESENCE PhysicalPresence;\r
+  TPM_RQU_COMMAND_HDR      Hdr;\r
+  TPM_PHYSICAL_PRESENCE    PhysicalPresence;\r
 } TPM_CMD_PHYSICAL_PRESENCE;\r
 \r
 #pragma pack()\r
@@ -50,15 +50,15 @@ Tpm12PhysicalPresence (
   Command.Hdr.paramSize    = SwapBytes32 (sizeof (Command));\r
   Command.Hdr.ordinal      = SwapBytes32 (TSC_ORD_PhysicalPresence);\r
   Command.PhysicalPresence = SwapBytes16 (PhysicalPresence);\r
-  Length = sizeof (Response);\r
+  Length                   = sizeof (Response);\r
 \r
   Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (SwapBytes32(Response.returnCode) != TPM_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm12PhysicalPresence: Response Code error! 0x%08x\r\n", SwapBytes32(Response.returnCode)));\r
+  if (SwapBytes32 (Response.returnCode) != TPM_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm12PhysicalPresence: Response Code error! 0x%08x\r\n", SwapBytes32 (Response.returnCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
index be389a51066ff44a3e2d17fe0027b868ed090e36..61a2225861d065c5cea5df3ccf24db56b091df15 100644 (file)
@@ -39,8 +39,8 @@ Tpm12ContinueSelfTest (
   Command.tag       = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
   Command.paramSize = SwapBytes32 (sizeof (Command));\r
   Command.ordinal   = SwapBytes32 (TPM_ORD_ContinueSelfTest);\r
-  Length = sizeof (Response);\r
-  Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
+  Length            = sizeof (Response);\r
+  Status            = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
index 49e6a1e3043afec1f63f7b0d81eb927545d6e292..7811c3f0fbd68bab481bd6770bea02ac631e9f2a 100644 (file)
@@ -16,8 +16,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM_RQU_COMMAND_HDR   Hdr;\r
-  TPM_STARTUP_TYPE      TpmSt;\r
+  TPM_RQU_COMMAND_HDR    Hdr;\r
+  TPM_STARTUP_TYPE       TpmSt;\r
 } TPM_CMD_START_UP;\r
 \r
 #pragma pack()\r
@@ -48,21 +48,22 @@ Tpm12Startup (
   Command.Hdr.paramSize = SwapBytes32 (sizeof (Command));\r
   Command.Hdr.ordinal   = SwapBytes32 (TPM_ORD_Startup);\r
   Command.TpmSt         = SwapBytes16 (TpmSt);\r
-  Length = sizeof (Response);\r
-  Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
+  Length                = sizeof (Response);\r
+  Status                = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
-  switch (SwapBytes32(Response.returnCode)) {\r
-  case TPM_SUCCESS:\r
-    DEBUG ((DEBUG_INFO, "TPM12Startup: TPM_SUCCESS\n"));\r
-    return EFI_SUCCESS;\r
-  case TPM_INVALID_POSTINIT:\r
-    // In warm reset, TPM may response TPM_INVALID_POSTINIT\r
-    DEBUG ((DEBUG_INFO, "TPM12Startup: TPM_INVALID_POSTINIT\n"));\r
-    return EFI_SUCCESS;\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+\r
+  switch (SwapBytes32 (Response.returnCode)) {\r
+    case TPM_SUCCESS:\r
+      DEBUG ((DEBUG_INFO, "TPM12Startup: TPM_SUCCESS\n"));\r
+      return EFI_SUCCESS;\r
+    case TPM_INVALID_POSTINIT:\r
+      // In warm reset, TPM may response TPM_INVALID_POSTINIT\r
+      DEBUG ((DEBUG_INFO, "TPM12Startup: TPM_INVALID_POSTINIT\n"));\r
+      return EFI_SUCCESS;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 }\r
 \r
@@ -86,18 +87,19 @@ Tpm12SaveState (
   //\r
   // send Tpm command TPM_ORD_SaveState\r
   //\r
-  Command.tag        = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
-  Command.paramSize  = SwapBytes32 (sizeof (Command));\r
-  Command.ordinal    = SwapBytes32 (TPM_ORD_SaveState);\r
-  Length = sizeof (Response);\r
-  Status = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
+  Command.tag       = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
+  Command.paramSize = SwapBytes32 (sizeof (Command));\r
+  Command.ordinal   = SwapBytes32 (TPM_ORD_SaveState);\r
+  Length            = sizeof (Response);\r
+  Status            = Tpm12SubmitCommand (sizeof (Command), (UINT8 *)&Command, &Length, (UINT8 *)&Response);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   switch (SwapBytes32 (Response.returnCode)) {\r
-  case TPM_SUCCESS:\r
-    return EFI_SUCCESS;\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+    case TPM_SUCCESS:\r
+      return EFI_SUCCESS;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 }\r
index d9e1ce86ee72eab910023e0342359fcb1d695dca..51f43591287af64a27b39490492d2c4b56e722e2 100644 (file)
@@ -30,7 +30,7 @@ typedef enum {
 //\r
 // Max TPM command/response length\r
 //\r
-#define TPMCMDBUFLENGTH             1024\r
+#define TPMCMDBUFLENGTH  1024\r
 \r
 /**\r
   Check whether TPM chip exist.\r
@@ -42,10 +42,10 @@ typedef enum {
 **/\r
 BOOLEAN\r
 Tpm12TisPcPresenceCheck (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  UINT8                             RegRead;\r
+  UINT8  RegRead;\r
 \r
   RegRead = MmioRead8 ((UINTN)&TisReg->Access);\r
   return (BOOLEAN)(RegRead != (UINT8)-1);\r
@@ -60,32 +60,37 @@ Tpm12TisPcPresenceCheck (
 **/\r
 PTP_INTERFACE_TYPE\r
 Tpm12GetPtpInterface (\r
-  IN VOID *Register\r
+  IN VOID  *Register\r
   )\r
 {\r
-  PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;\r
-  PTP_FIFO_INTERFACE_CAPABILITY InterfaceCapability;\r
+  PTP_CRB_INTERFACE_IDENTIFIER   InterfaceId;\r
+  PTP_FIFO_INTERFACE_CAPABILITY  InterfaceCapability;\r
 \r
   if (!Tpm12TisPcPresenceCheck (Register)) {\r
     return PtpInterfaceMax;\r
   }\r
+\r
   //\r
   // Check interface id\r
   //\r
-  InterfaceId.Uint32 = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);\r
+  InterfaceId.Uint32         = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);\r
   InterfaceCapability.Uint32 = MmioRead32 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->InterfaceCapability);\r
 \r
   if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_CRB) &&\r
       (InterfaceId.Bits.InterfaceVersion == PTP_INTERFACE_IDENTIFIER_INTERFACE_VERSION_CRB) &&\r
-      (InterfaceId.Bits.CapCRB != 0)) {\r
+      (InterfaceId.Bits.CapCRB != 0))\r
+  {\r
     return PtpInterfaceCrb;\r
   }\r
+\r
   if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_FIFO) &&\r
       (InterfaceId.Bits.InterfaceVersion == PTP_INTERFACE_IDENTIFIER_INTERFACE_VERSION_FIFO) &&\r
       (InterfaceId.Bits.CapFIFO != 0) &&\r
-      (InterfaceCapability.Bits.InterfaceVersion == INTERFACE_CAPABILITY_INTERFACE_VERSION_PTP)) {\r
+      (InterfaceCapability.Bits.InterfaceVersion == INTERFACE_CAPABILITY_INTERFACE_VERSION_PTP))\r
+  {\r
     return PtpInterfaceFifo;\r
   }\r
+\r
   return PtpInterfaceTis;\r
 }\r
 \r
@@ -102,21 +107,24 @@ Tpm12GetPtpInterface (
 **/\r
 EFI_STATUS\r
 Tpm12TisPcWaitRegisterBits (\r
-  IN      UINT8                     *Register,\r
-  IN      UINT8                     BitSet,\r
-  IN      UINT8                     BitClear,\r
-  IN      UINT32                    TimeOut\r
+  IN      UINT8   *Register,\r
+  IN      UINT8   BitSet,\r
+  IN      UINT8   BitClear,\r
+  IN      UINT32  TimeOut\r
   )\r
 {\r
-  UINT8                             RegRead;\r
-  UINT32                            WaitTime;\r
+  UINT8   RegRead;\r
+  UINT32  WaitTime;\r
 \r
-  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30){\r
+  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30) {\r
     RegRead = MmioRead8 ((UINTN)Register);\r
-    if ((RegRead & BitSet) == BitSet && (RegRead & BitClear) == 0)\r
+    if (((RegRead & BitSet) == BitSet) && ((RegRead & BitClear) == 0)) {\r
       return EFI_SUCCESS;\r
+    }\r
+\r
     MicroSecondDelay (30);\r
   }\r
+\r
   return EFI_TIMEOUT;\r
 }\r
 \r
@@ -133,15 +141,15 @@ Tpm12TisPcWaitRegisterBits (
 **/\r
 EFI_STATUS\r
 Tpm12TisPcReadBurstCount (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg,\r
-     OUT  UINT16                    *BurstCount\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg,\r
+  OUT  UINT16                   *BurstCount\r
   )\r
 {\r
-  UINT32                            WaitTime;\r
-  UINT8                             DataByte0;\r
-  UINT8                             DataByte1;\r
+  UINT32  WaitTime;\r
+  UINT8   DataByte0;\r
+  UINT8   DataByte1;\r
 \r
-  if (BurstCount == NULL || TisReg == NULL) {\r
+  if ((BurstCount == NULL) || (TisReg == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -157,6 +165,7 @@ Tpm12TisPcReadBurstCount (
     if (*BurstCount != 0) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     MicroSecondDelay (30);\r
     WaitTime += 30;\r
   } while (WaitTime < TIS_TIMEOUT_D);\r
@@ -176,16 +185,16 @@ Tpm12TisPcReadBurstCount (
 **/\r
 EFI_STATUS\r
 Tpm12TisPcPrepareCommand (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (TisReg == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  MmioWrite8((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
+  MmioWrite8 ((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
   Status = Tpm12TisPcWaitRegisterBits (\r
              &TisReg->Status,\r
              TIS_PC_STS_READY,\r
@@ -208,10 +217,10 @@ Tpm12TisPcPrepareCommand (
 **/\r
 EFI_STATUS\r
 Tpm12TisPcRequestUseTpm (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (TisReg == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -221,7 +230,7 @@ Tpm12TisPcRequestUseTpm (
     return EFI_NOT_FOUND;\r
   }\r
 \r
-  MmioWrite8((UINTN)&TisReg->Access, TIS_PC_ACC_RQUUSE);\r
+  MmioWrite8 ((UINTN)&TisReg->Access, TIS_PC_ACC_RQUUSE);\r
   Status = Tpm12TisPcWaitRegisterBits (\r
              &TisReg->Access,\r
              (UINT8)(TIS_PC_ACC_ACTIVE |TIS_PC_VALID),\r
@@ -248,48 +257,52 @@ Tpm12TisPcRequestUseTpm (
 **/\r
 EFI_STATUS\r
 Tpm12TisTpmCommand (\r
-  IN     TIS_PC_REGISTERS_PTR       TisReg,\r
-  IN     UINT8                      *BufferIn,\r
-  IN     UINT32                     SizeIn,\r
-  IN OUT UINT8                      *BufferOut,\r
-  IN OUT UINT32                     *SizeOut\r
+  IN     TIS_PC_REGISTERS_PTR  TisReg,\r
+  IN     UINT8                 *BufferIn,\r
+  IN     UINT32                SizeIn,\r
+  IN OUT UINT8                 *BufferOut,\r
+  IN OUT UINT32                *SizeOut\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINT16                            BurstCount;\r
-  UINT32                            Index;\r
-  UINT32                            TpmOutSize;\r
-  UINT16                            Data16;\r
-  UINT32                            Data32;\r
-  UINT16                            RspTag;\r
+  EFI_STATUS  Status;\r
+  UINT16      BurstCount;\r
+  UINT32      Index;\r
+  UINT32      TpmOutSize;\r
+  UINT16      Data16;\r
+  UINT32      Data32;\r
+  UINT16      RspTag;\r
 \r
   DEBUG_CODE_BEGIN ();\r
-    UINTN  DebugSize;\r
+  UINTN  DebugSize;\r
 \r
-    DEBUG ((DEBUG_VERBOSE, "Tpm12TisTpmCommand Send - "));\r
-    if (SizeIn > 0x100) {\r
-      DebugSize = 0x40;\r
-    } else {\r
-      DebugSize = SizeIn;\r
-    }\r
-    for (Index = 0; Index < DebugSize; Index++) {\r
+  DEBUG ((DEBUG_VERBOSE, "Tpm12TisTpmCommand Send - "));\r
+  if (SizeIn > 0x100) {\r
+    DebugSize = 0x40;\r
+  } else {\r
+    DebugSize = SizeIn;\r
+  }\r
+\r
+  for (Index = 0; Index < DebugSize; Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
+  }\r
+\r
+  if (DebugSize != SizeIn) {\r
+    DEBUG ((DEBUG_VERBOSE, "...... "));\r
+    for (Index = SizeIn - 0x20; Index < SizeIn; Index++) {\r
       DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
     }\r
-    if (DebugSize != SizeIn) {\r
-      DEBUG ((DEBUG_VERBOSE, "...... "));\r
-      for (Index = SizeIn - 0x20; Index < SizeIn; Index++) {\r
-        DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
-      }\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
   TpmOutSize = 0;\r
 \r
   Status = Tpm12TisPcPrepareCommand (TisReg);\r
-  if (EFI_ERROR (Status)){\r
+  if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm12 is not ready for command!\n"));\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   //\r
   // Send the command data to Tpm\r
   //\r
@@ -300,17 +313,19 @@ Tpm12TisTpmCommand (
       Status = EFI_DEVICE_ERROR;\r
       goto Exit;\r
     }\r
-    for (; BurstCount > 0 && Index < SizeIn; BurstCount--) {\r
-      MmioWrite8((UINTN)&TisReg->DataFifo, *(BufferIn + Index));\r
+\r
+    for ( ; BurstCount > 0 && Index < SizeIn; BurstCount--) {\r
+      MmioWrite8 ((UINTN)&TisReg->DataFifo, *(BufferIn + Index));\r
       Index++;\r
     }\r
   }\r
+\r
   //\r
   // Check the Tpm status STS_EXPECT change from 1 to 0\r
   //\r
   Status = Tpm12TisPcWaitRegisterBits (\r
              &TisReg->Status,\r
-             (UINT8) TIS_PC_VALID,\r
+             (UINT8)TIS_PC_VALID,\r
              TIS_PC_STS_EXPECT,\r
              TIS_TIMEOUT_C\r
              );\r
@@ -319,13 +334,14 @@ Tpm12TisTpmCommand (
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Exit;\r
   }\r
+\r
   //\r
   // Executed the TPM command and waiting for the response data ready\r
   //\r
-  MmioWrite8((UINTN)&TisReg->Status, TIS_PC_STS_GO);\r
+  MmioWrite8 ((UINTN)&TisReg->Status, TIS_PC_STS_GO);\r
   Status = Tpm12TisPcWaitRegisterBits (\r
              &TisReg->Status,\r
-             (UINT8) (TIS_PC_VALID | TIS_PC_STS_DATA),\r
+             (UINT8)(TIS_PC_VALID | TIS_PC_STS_DATA),\r
              0,\r
              TIS_TIMEOUT_B\r
              );\r
@@ -334,10 +350,11 @@ Tpm12TisTpmCommand (
     Status = EFI_DEVICE_ERROR;\r
     goto Exit;\r
   }\r
+\r
   //\r
   // Get response data header\r
   //\r
-  Index = 0;\r
+  Index      = 0;\r
   BurstCount = 0;\r
   while (Index < sizeof (TPM_RSP_COMMAND_HDR)) {\r
     Status = Tpm12TisPcReadBurstCount (TisReg, &BurstCount);\r
@@ -345,42 +362,48 @@ Tpm12TisTpmCommand (
       Status = EFI_DEVICE_ERROR;\r
       goto Exit;\r
     }\r
-    for (; BurstCount > 0; BurstCount--) {\r
+\r
+    for ( ; BurstCount > 0; BurstCount--) {\r
       *(BufferOut + Index) = MmioRead8 ((UINTN)&TisReg->DataFifo);\r
       Index++;\r
-      if (Index == sizeof (TPM_RSP_COMMAND_HDR)) break;\r
+      if (Index == sizeof (TPM_RSP_COMMAND_HDR)) {\r
+        break;\r
+      }\r
     }\r
   }\r
+\r
   DEBUG_CODE_BEGIN ();\r
-    DEBUG ((DEBUG_VERBOSE, "Tpm12TisTpmCommand ReceiveHeader - "));\r
-    for (Index = 0; Index < sizeof (TPM_RSP_COMMAND_HDR); Index++) {\r
-      DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  DEBUG ((DEBUG_VERBOSE, "Tpm12TisTpmCommand ReceiveHeader - "));\r
+  for (Index = 0; Index < sizeof (TPM_RSP_COMMAND_HDR); Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
   //\r
   // Check the response data header (tag, parasize and returncode)\r
   //\r
   CopyMem (&Data16, BufferOut, sizeof (UINT16));\r
   RspTag = SwapBytes16 (Data16);\r
-  if (RspTag != TPM_TAG_RSP_COMMAND && RspTag != TPM_TAG_RSP_AUTH1_COMMAND && RspTag != TPM_TAG_RSP_AUTH2_COMMAND) {\r
+  if ((RspTag != TPM_TAG_RSP_COMMAND) && (RspTag != TPM_TAG_RSP_AUTH1_COMMAND) && (RspTag != TPM_TAG_RSP_AUTH2_COMMAND)) {\r
     DEBUG ((DEBUG_ERROR, "TPM12: Response tag error - current tag value is %x\n", RspTag));\r
     Status = EFI_UNSUPPORTED;\r
     goto Exit;\r
   }\r
 \r
   CopyMem (&Data32, (BufferOut + 2), sizeof (UINT32));\r
-  TpmOutSize  = SwapBytes32 (Data32);\r
+  TpmOutSize = SwapBytes32 (Data32);\r
   if (*SizeOut < TpmOutSize) {\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Exit;\r
   }\r
+\r
   *SizeOut = TpmOutSize;\r
   //\r
   // Continue reading the remaining data\r
   //\r
   while ( Index < TpmOutSize ) {\r
-    for (; BurstCount > 0; BurstCount--) {\r
+    for ( ; BurstCount > 0; BurstCount--) {\r
       *(BufferOut + Index) = MmioRead8 ((UINTN)&TisReg->DataFifo);\r
       Index++;\r
       if (Index == TpmOutSize) {\r
@@ -388,21 +411,24 @@ Tpm12TisTpmCommand (
         goto Exit;\r
       }\r
     }\r
+\r
     Status = Tpm12TisPcReadBurstCount (TisReg, &BurstCount);\r
     if (EFI_ERROR (Status)) {\r
       Status = EFI_DEVICE_ERROR;\r
       goto Exit;\r
     }\r
   }\r
+\r
 Exit:\r
   DEBUG_CODE_BEGIN ();\r
-    DEBUG ((DEBUG_VERBOSE, "Tpm12TisTpmCommand Receive - "));\r
-    for (Index = 0; Index < TpmOutSize; Index++) {\r
-      DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  DEBUG ((DEBUG_VERBOSE, "Tpm12TisTpmCommand Receive - "));\r
+  for (Index = 0; Index < TpmOutSize; Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
-  MmioWrite8((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
+  MmioWrite8 ((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
   return Status;\r
 }\r
 \r
@@ -421,10 +447,10 @@ Exit:
 EFI_STATUS\r
 EFIAPI\r
 Tpm12SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   )\r
 {\r
   PTP_INTERFACE_TYPE  PtpInterface;\r
@@ -432,25 +458,24 @@ Tpm12SubmitCommand (
   //\r
   // Special handle for TPM1.2 to check PTP too, because PTP/TIS share same register address.\r
   //\r
-  PtpInterface = Tpm12GetPtpInterface ((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
+  PtpInterface = Tpm12GetPtpInterface ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
   switch (PtpInterface) {\r
-  case PtpInterfaceFifo:\r
-  case PtpInterfaceTis:\r
-    return Tpm12TisTpmCommand (\r
-             (TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress),\r
-             InputParameterBlock,\r
-             InputParameterBlockSize,\r
-             OutputParameterBlock,\r
-             OutputParameterBlockSize\r
-             );\r
-  case PtpInterfaceCrb:\r
+    case PtpInterfaceFifo:\r
+    case PtpInterfaceTis:\r
+      return Tpm12TisTpmCommand (\r
+               (TIS_PC_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress),\r
+               InputParameterBlock,\r
+               InputParameterBlockSize,\r
+               OutputParameterBlock,\r
+               OutputParameterBlockSize\r
+               );\r
+    case PtpInterfaceCrb:\r
     //\r
     // No need to support CRB because it is only accept TPM2 command.\r
     //\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
-\r
 }\r
 \r
 /**\r
@@ -466,22 +491,24 @@ Tpm12SubmitCommand (
 **/\r
 EFI_STATUS\r
 Tpm12PtpCrbWaitRegisterBits (\r
-  IN      UINT32                    *Register,\r
-  IN      UINT32                    BitSet,\r
-  IN      UINT32                    BitClear,\r
-  IN      UINT32                    TimeOut\r
+  IN      UINT32  *Register,\r
+  IN      UINT32  BitSet,\r
+  IN      UINT32  BitClear,\r
+  IN      UINT32  TimeOut\r
   )\r
 {\r
-  UINT32                            RegRead;\r
-  UINT32                            WaitTime;\r
+  UINT32  RegRead;\r
+  UINT32  WaitTime;\r
 \r
-  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30){\r
+  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30) {\r
     RegRead = MmioRead32 ((UINTN)Register);\r
-    if ((RegRead & BitSet) == BitSet && (RegRead & BitClear) == 0) {\r
+    if (((RegRead & BitSet) == BitSet) && ((RegRead & BitClear) == 0)) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     MicroSecondDelay (30);\r
   }\r
+\r
   return EFI_TIMEOUT;\r
 }\r
 \r
@@ -497,12 +524,12 @@ Tpm12PtpCrbWaitRegisterBits (
 **/\r
 EFI_STATUS\r
 Tpm12PtpCrbRequestUseTpm (\r
-  IN      PTP_CRB_REGISTERS_PTR      CrbReg\r
+  IN      PTP_CRB_REGISTERS_PTR  CrbReg\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
-  MmioWrite32((UINTN)&CrbReg->LocalityControl, PTP_CRB_LOCALITY_CONTROL_REQUEST_ACCESS);\r
+  MmioWrite32 ((UINTN)&CrbReg->LocalityControl, PTP_CRB_LOCALITY_CONTROL_REQUEST_ACCESS);\r
   Status = Tpm12PtpCrbWaitRegisterBits (\r
              &CrbReg->LocalityStatus,\r
              PTP_CRB_LOCALITY_STATUS_GRANTED,\r
@@ -531,14 +558,14 @@ Tpm12RequestUseTpm (
   // Special handle for TPM1.2 to check PTP too, because PTP/TIS share same register address.\r
   // Some other program might leverage this function to check the existence of TPM chip.\r
   //\r
-  PtpInterface = Tpm12GetPtpInterface ((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
+  PtpInterface = Tpm12GetPtpInterface ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
   switch (PtpInterface) {\r
-  case PtpInterfaceCrb:\r
-    return Tpm12PtpCrbRequestUseTpm ((PTP_CRB_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
-  case PtpInterfaceFifo:\r
-  case PtpInterfaceTis:\r
-    return Tpm12TisPcRequestUseTpm ((TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
-  default:\r
-    return EFI_NOT_FOUND;\r
+    case PtpInterfaceCrb:\r
+      return Tpm12PtpCrbRequestUseTpm ((PTP_CRB_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
+    case PtpInterfaceFifo:\r
+    case PtpInterfaceTis:\r
+      return Tpm12TisPcRequestUseTpm ((TIS_PC_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
+    default:\r
+      return EFI_NOT_FOUND;\r
   }\r
 }\r
index 2869f9ec834c394afa3afa43403210bc50b22b0b..9de607719486ad309ff0ec0e56f4c5a2228cf42a 100644 (file)
@@ -32,17 +32,17 @@ EFI_TCG_PROTOCOL  *mTcgProtocol = NULL;
 EFI_STATUS\r
 EFIAPI\r
 Tpm12SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  TPM_RSP_COMMAND_HDR       *Header;\r
+  EFI_STATUS           Status;\r
+  TPM_RSP_COMMAND_HDR  *Header;\r
 \r
   if (mTcgProtocol == NULL) {\r
-    Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **) &mTcgProtocol);\r
+    Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **)&mTcgProtocol);\r
     if (EFI_ERROR (Status)) {\r
       //\r
       // TCG protocol is not installed. So, TPM12 is not present.\r
@@ -51,6 +51,7 @@ Tpm12SubmitCommand (
       return EFI_NOT_FOUND;\r
     }\r
   }\r
+\r
   //\r
   // Assume when TCG Protocol is ready, RequestUseTpm already done.\r
   //\r
@@ -64,7 +65,8 @@ Tpm12SubmitCommand (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
-  Header = (TPM_RSP_COMMAND_HDR *)OutputParameterBlock;\r
+\r
+  Header                    = (TPM_RSP_COMMAND_HDR *)OutputParameterBlock;\r
   *OutputParameterBlockSize = SwapBytes32 (Header->paramSize);\r
 \r
   return EFI_SUCCESS;\r
@@ -83,10 +85,10 @@ Tpm12RequestUseTpm (
   VOID\r
   )\r
 {\r
-  EFI_STATUS   Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (mTcgProtocol == NULL) {\r
-    Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **) &mTcgProtocol);\r
+    Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **)&mTcgProtocol);\r
     if (EFI_ERROR (Status)) {\r
       //\r
       // TCG protocol is not installed. So, TPM12 is not present.\r
@@ -95,6 +97,7 @@ Tpm12RequestUseTpm (
       return EFI_NOT_FOUND;\r
     }\r
   }\r
+\r
   //\r
   // Assume when TCG Protocol is ready, RequestUseTpm already done.\r
   //\r
index dcbdf72cac6f09b61898d8b606a6f28b7f9008e6..9db301ec9a90eafba7c93b037559129b6ccb1a16 100644 (file)
@@ -16,25 +16,25 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPM_CAP                   Capability;\r
-  UINT32                    Property;\r
-  UINT32                    PropertyCount;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPM_CAP                Capability;\r
+  UINT32                 Property;\r
+  UINT32                 PropertyCount;\r
 } TPM2_GET_CAPABILITY_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
-  TPMI_YES_NO               MoreData;\r
-  TPMS_CAPABILITY_DATA      CapabilityData;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  TPMI_YES_NO             MoreData;\r
+  TPMS_CAPABILITY_DATA    CapabilityData;\r
 } TPM2_GET_CAPABILITY_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMT_PUBLIC_PARMS         Parameters;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMT_PUBLIC_PARMS      Parameters;\r
 } TPM2_TEST_PARMS_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
+  TPM2_RESPONSE_HEADER    Header;\r
 } TPM2_TEST_PARMS_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -69,37 +69,37 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapability (\r
-  IN      TPM_CAP                   Capability,\r
-  IN      UINT32                    Property,\r
-  IN      UINT32                    PropertyCount,\r
-  OUT     TPMI_YES_NO               *MoreData,\r
-  OUT     TPMS_CAPABILITY_DATA      *CapabilityData\r
+  IN      TPM_CAP               Capability,\r
+  IN      UINT32                Property,\r
+  IN      UINT32                PropertyCount,\r
+  OUT     TPMI_YES_NO           *MoreData,\r
+  OUT     TPMS_CAPABILITY_DATA  *CapabilityData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_GET_CAPABILITY_COMMAND       SendBuffer;\r
-  TPM2_GET_CAPABILITY_RESPONSE      RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
+  EFI_STATUS                    Status;\r
+  TPM2_GET_CAPABILITY_COMMAND   SendBuffer;\r
+  TPM2_GET_CAPABILITY_RESPONSE  RecvBuffer;\r
+  UINT32                        SendBufferSize;\r
+  UINT32                        RecvBufferSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_GetCapability);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_GetCapability);\r
 \r
-  SendBuffer.Capability = SwapBytes32 (Capability);\r
-  SendBuffer.Property = SwapBytes32 (Property);\r
+  SendBuffer.Capability    = SwapBytes32 (Capability);\r
+  SendBuffer.Property      = SwapBytes32 (Property);\r
   SendBuffer.PropertyCount = SwapBytes32 (PropertyCount);\r
 \r
-  SendBufferSize = (UINT32) sizeof (SendBuffer);\r
+  SendBufferSize              = (UINT32)sizeof (SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer );\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -111,8 +111,8 @@ Tpm2GetCapability (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2GetCapability: Response Code error! 0x%08x\r\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2GetCapability: Response Code error! 0x%08x\r\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -141,12 +141,12 @@ Tpm2GetCapability (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityFamily (\r
-  OUT     CHAR8                     *Family\r
+  OUT     CHAR8  *Family\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_TPM_PROPERTIES,\r
@@ -158,6 +158,7 @@ Tpm2GetCapabilityFamily (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   CopyMem (Family, &TpmCap.data.tpmProperties.tpmProperty->value, 4);\r
 \r
   return EFI_SUCCESS;\r
@@ -176,12 +177,12 @@ Tpm2GetCapabilityFamily (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityManufactureID (\r
-  OUT     UINT32                    *ManufactureId\r
+  OUT     UINT32  *ManufactureId\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_TPM_PROPERTIES,\r
@@ -193,6 +194,7 @@ Tpm2GetCapabilityManufactureID (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   *ManufactureId = TpmCap.data.tpmProperties.tpmProperty->value;\r
 \r
   return EFI_SUCCESS;\r
@@ -212,13 +214,13 @@ Tpm2GetCapabilityManufactureID (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityFirmwareVersion (\r
-  OUT     UINT32                    *FirmwareVersion1,\r
-  OUT     UINT32                    *FirmwareVersion2\r
+  OUT     UINT32  *FirmwareVersion1,\r
+  OUT     UINT32  *FirmwareVersion2\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_TPM_PROPERTIES,\r
@@ -230,6 +232,7 @@ Tpm2GetCapabilityFirmwareVersion (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   *FirmwareVersion1 = SwapBytes32 (TpmCap.data.tpmProperties.tpmProperty->value);\r
 \r
   Status = Tpm2GetCapability (\r
@@ -242,6 +245,7 @@ Tpm2GetCapabilityFirmwareVersion (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   *FirmwareVersion2 = SwapBytes32 (TpmCap.data.tpmProperties.tpmProperty->value);\r
 \r
   return EFI_SUCCESS;\r
@@ -261,13 +265,13 @@ Tpm2GetCapabilityFirmwareVersion (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityMaxCommandResponseSize (\r
-  OUT UINT32                    *MaxCommandSize,\r
-  OUT UINT32                    *MaxResponseSize\r
+  OUT UINT32  *MaxCommandSize,\r
+  OUT UINT32  *MaxResponseSize\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_TPM_PROPERTIES,\r
@@ -311,13 +315,13 @@ Tpm2GetCapabilityMaxCommandResponseSize (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilitySupportedAlg (\r
-  OUT TPML_ALG_PROPERTY      *AlgList\r
+  OUT TPML_ALG_PROPERTY  *AlgList\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  UINTN                   Index;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  UINTN                 Index;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_ALGS,\r
@@ -359,12 +363,12 @@ Tpm2GetCapabilitySupportedAlg (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityLockoutCounter (\r
-  OUT     UINT32                    *LockoutCounter\r
+  OUT     UINT32  *LockoutCounter\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_TPM_PROPERTIES,\r
@@ -376,6 +380,7 @@ Tpm2GetCapabilityLockoutCounter (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   *LockoutCounter = SwapBytes32 (TpmCap.data.tpmProperties.tpmProperty->value);\r
 \r
   return EFI_SUCCESS;\r
@@ -394,12 +399,12 @@ Tpm2GetCapabilityLockoutCounter (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityLockoutInterval (\r
-  OUT     UINT32                    *LockoutInterval\r
+  OUT     UINT32  *LockoutInterval\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_TPM_PROPERTIES,\r
@@ -411,6 +416,7 @@ Tpm2GetCapabilityLockoutInterval (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   *LockoutInterval = SwapBytes32 (TpmCap.data.tpmProperties.tpmProperty->value);\r
 \r
   return EFI_SUCCESS;\r
@@ -430,12 +436,12 @@ Tpm2GetCapabilityLockoutInterval (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityInputBufferSize (\r
-  OUT     UINT32                    *InputBufferSize\r
+  OUT     UINT32  *InputBufferSize\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_TPM_PROPERTIES,\r
@@ -447,6 +453,7 @@ Tpm2GetCapabilityInputBufferSize (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   *InputBufferSize = SwapBytes32 (TpmCap.data.tpmProperties.tpmProperty->value);\r
 \r
   return EFI_SUCCESS;\r
@@ -465,13 +472,13 @@ Tpm2GetCapabilityInputBufferSize (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityPcrs (\r
-  OUT TPML_PCR_SELECTION      *Pcrs\r
+  OUT TPML_PCR_SELECTION  *Pcrs\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
-  UINTN                   Index;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
+  UINTN                 Index;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_PCRS,\r
@@ -491,12 +498,13 @@ Tpm2GetCapabilityPcrs (
   }\r
 \r
   for (Index = 0; Index < Pcrs->count; Index++) {\r
-    Pcrs->pcrSelections[Index].hash = SwapBytes16 (TpmCap.data.assignedPCR.pcrSelections[Index].hash);\r
+    Pcrs->pcrSelections[Index].hash         = SwapBytes16 (TpmCap.data.assignedPCR.pcrSelections[Index].hash);\r
     Pcrs->pcrSelections[Index].sizeofSelect = TpmCap.data.assignedPCR.pcrSelections[Index].sizeofSelect;\r
     if (Pcrs->pcrSelections[Index].sizeofSelect > PCR_SELECT_MAX) {\r
       DEBUG ((DEBUG_ERROR, "Tpm2GetCapabilityPcrs - sizeofSelect error %x\n", Pcrs->pcrSelections[Index].sizeofSelect));\r
       return EFI_DEVICE_ERROR;\r
     }\r
+\r
     CopyMem (Pcrs->pcrSelections[Index].pcrSelect, TpmCap.data.assignedPCR.pcrSelections[Index].pcrSelect, Pcrs->pcrSelections[Index].sizeofSelect);\r
   }\r
 \r
@@ -517,14 +525,14 @@ Tpm2GetCapabilityPcrs (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilitySupportedAndActivePcrs (\r
-  OUT UINT32                            *TpmHashAlgorithmBitmap,\r
-  OUT UINT32                            *ActivePcrBanks\r
+  OUT UINT32  *TpmHashAlgorithmBitmap,\r
+  OUT UINT32  *ActivePcrBanks\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  TPML_PCR_SELECTION    Pcrs;\r
-  UINTN                 Index;\r
-  UINT8                 ActivePcrBankCount;\r
+  EFI_STATUS          Status;\r
+  TPML_PCR_SELECTION  Pcrs;\r
+  UINTN               Index;\r
+  UINT8               ActivePcrBankCount;\r
 \r
   //\r
   // Get supported PCR\r
@@ -539,7 +547,7 @@ Tpm2GetCapabilitySupportedAndActivePcrs (
     DEBUG ((DEBUG_ERROR, "GetSupportedAndActivePcrs - Tpm2GetCapabilityPcrs fail!\n"));\r
     *TpmHashAlgorithmBitmap = HASH_ALG_SHA1;\r
     *ActivePcrBanks         = HASH_ALG_SHA1;\r
-    ActivePcrBankCount = 1;\r
+    ActivePcrBankCount      = 1;\r
   }\r
   //\r
   // Otherwise, process the return data to determine what algorithms are supported\r
@@ -550,55 +558,60 @@ Tpm2GetCapabilitySupportedAndActivePcrs (
     *ActivePcrBanks         = 0;\r
     for (Index = 0; Index < Pcrs.count; Index++) {\r
       switch (Pcrs.pcrSelections[Index].hash) {\r
-      case TPM_ALG_SHA1:\r
-        DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA1 present.\n"));\r
-        *TpmHashAlgorithmBitmap |= HASH_ALG_SHA1;\r
-        if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
-          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA1 active.\n"));\r
-          *ActivePcrBanks |= HASH_ALG_SHA1;\r
-          ActivePcrBankCount++;\r
-        }\r
-        break;\r
-      case TPM_ALG_SHA256:\r
-        DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA256 present.\n"));\r
-        *TpmHashAlgorithmBitmap |= HASH_ALG_SHA256;\r
-        if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
-          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA256 active.\n"));\r
-          *ActivePcrBanks |= HASH_ALG_SHA256;\r
-          ActivePcrBankCount++;\r
-        }\r
-        break;\r
-      case TPM_ALG_SHA384:\r
-        DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA384 present.\n"));\r
-        *TpmHashAlgorithmBitmap |= HASH_ALG_SHA384;\r
-        if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
-          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA384 active.\n"));\r
-          *ActivePcrBanks |= HASH_ALG_SHA384;\r
-          ActivePcrBankCount++;\r
-        }\r
-        break;\r
-      case TPM_ALG_SHA512:\r
-        DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA512 present.\n"));\r
-        *TpmHashAlgorithmBitmap |= HASH_ALG_SHA512;\r
-        if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
-          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA512 active.\n"));\r
-          *ActivePcrBanks |= HASH_ALG_SHA512;\r
-          ActivePcrBankCount++;\r
-        }\r
-        break;\r
-      case TPM_ALG_SM3_256:\r
-        DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SM3_256 present.\n"));\r
-        *TpmHashAlgorithmBitmap |= HASH_ALG_SM3_256;\r
-        if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
-          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SM3_256 active.\n"));\r
-          *ActivePcrBanks |= HASH_ALG_SM3_256;\r
-          ActivePcrBankCount++;\r
-        }\r
-        break;\r
-      default:\r
-        DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - Unsupported bank 0x%04x.\n", Pcrs.pcrSelections[Index].hash));\r
-        continue;\r
-        break;\r
+        case TPM_ALG_SHA1:\r
+          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA1 present.\n"));\r
+          *TpmHashAlgorithmBitmap |= HASH_ALG_SHA1;\r
+          if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
+            DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA1 active.\n"));\r
+            *ActivePcrBanks |= HASH_ALG_SHA1;\r
+            ActivePcrBankCount++;\r
+          }\r
+\r
+          break;\r
+        case TPM_ALG_SHA256:\r
+          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA256 present.\n"));\r
+          *TpmHashAlgorithmBitmap |= HASH_ALG_SHA256;\r
+          if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
+            DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA256 active.\n"));\r
+            *ActivePcrBanks |= HASH_ALG_SHA256;\r
+            ActivePcrBankCount++;\r
+          }\r
+\r
+          break;\r
+        case TPM_ALG_SHA384:\r
+          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA384 present.\n"));\r
+          *TpmHashAlgorithmBitmap |= HASH_ALG_SHA384;\r
+          if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
+            DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA384 active.\n"));\r
+            *ActivePcrBanks |= HASH_ALG_SHA384;\r
+            ActivePcrBankCount++;\r
+          }\r
+\r
+          break;\r
+        case TPM_ALG_SHA512:\r
+          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA512 present.\n"));\r
+          *TpmHashAlgorithmBitmap |= HASH_ALG_SHA512;\r
+          if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
+            DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA512 active.\n"));\r
+            *ActivePcrBanks |= HASH_ALG_SHA512;\r
+            ActivePcrBankCount++;\r
+          }\r
+\r
+          break;\r
+        case TPM_ALG_SM3_256:\r
+          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SM3_256 present.\n"));\r
+          *TpmHashAlgorithmBitmap |= HASH_ALG_SM3_256;\r
+          if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
+            DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SM3_256 active.\n"));\r
+            *ActivePcrBanks |= HASH_ALG_SM3_256;\r
+            ActivePcrBankCount++;\r
+          }\r
+\r
+          break;\r
+        default:\r
+          DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - Unsupported bank 0x%04x.\n", Pcrs.pcrSelections[Index].hash));\r
+          continue;\r
+          break;\r
       }\r
     }\r
   }\r
@@ -620,12 +633,12 @@ Tpm2GetCapabilitySupportedAndActivePcrs (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityAlgorithmSet (\r
-  OUT     UINT32      *AlgorithmSet\r
+  OUT     UINT32  *AlgorithmSet\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_TPM_PROPERTIES,\r
@@ -637,6 +650,7 @@ Tpm2GetCapabilityAlgorithmSet (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   *AlgorithmSet = SwapBytes32 (TpmCap.data.tpmProperties.tpmProperty->value);\r
 \r
   return EFI_SUCCESS;\r
@@ -654,14 +668,14 @@ Tpm2GetCapabilityAlgorithmSet (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2GetCapabilityIsCommandImplemented (\r
-  IN      TPM_CC      Command,\r
-  OUT     BOOLEAN     *IsCmdImpl\r
+  IN      TPM_CC   Command,\r
+  OUT     BOOLEAN  *IsCmdImpl\r
   )\r
 {\r
-  TPMS_CAPABILITY_DATA    TpmCap;\r
-  TPMI_YES_NO             MoreData;\r
-  EFI_STATUS              Status;\r
-  UINT32                  Attribute;\r
+  TPMS_CAPABILITY_DATA  TpmCap;\r
+  TPMI_YES_NO           MoreData;\r
+  EFI_STATUS            Status;\r
+  UINT32                Attribute;\r
 \r
   Status = Tpm2GetCapability (\r
              TPM_CAP_COMMANDS,\r
@@ -675,7 +689,7 @@ Tpm2GetCapabilityIsCommandImplemented (
   }\r
 \r
   CopyMem (&Attribute, &TpmCap.data.command.commandAttributes[0], sizeof (UINT32));\r
-  *IsCmdImpl = (Command == (SwapBytes32(Attribute) & TPMA_CC_COMMANDINDEX_MASK));\r
+  *IsCmdImpl = (Command == (SwapBytes32 (Attribute) & TPMA_CC_COMMANDINDEX_MASK));\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -691,199 +705,206 @@ Tpm2GetCapabilityIsCommandImplemented (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2TestParms (\r
-  IN  TPMT_PUBLIC_PARMS           *Parameters\r
+  IN  TPMT_PUBLIC_PARMS  *Parameters\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_TEST_PARMS_COMMAND           SendBuffer;\r
-  TPM2_TEST_PARMS_RESPONSE          RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT8                             *Buffer;\r
+  EFI_STATUS                Status;\r
+  TPM2_TEST_PARMS_COMMAND   SendBuffer;\r
+  TPM2_TEST_PARMS_RESPONSE  RecvBuffer;\r
+  UINT32                    SendBufferSize;\r
+  UINT32                    RecvBufferSize;\r
+  UINT8                     *Buffer;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_TestParms);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_TestParms);\r
 \r
   Buffer = (UINT8 *)&SendBuffer.Parameters;\r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->type));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   switch (Parameters->type) {\r
-  case TPM_ALG_KEYEDHASH:\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.keyedHashDetail.scheme.scheme));\r
-    Buffer += sizeof(UINT16);\r
-    switch (Parameters->parameters.keyedHashDetail.scheme.scheme) {\r
-    case TPM_ALG_HMAC:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.keyedHashDetail.scheme.details.hmac.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_XOR:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.keyedHashDetail.scheme.details.xor.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.keyedHashDetail.scheme.details.xor.kdf));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    default:\r
-      return EFI_INVALID_PARAMETER;\r
-    }\r
-  case TPM_ALG_SYMCIPHER:\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.algorithm));\r
-    Buffer += sizeof(UINT16);\r
-    switch (Parameters->parameters.symDetail.algorithm) {\r
-    case TPM_ALG_AES:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.keyBits.aes));\r
-      Buffer += sizeof(UINT16);\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.mode.aes));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_SM4:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.keyBits.SM4));\r
-      Buffer += sizeof(UINT16);\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.mode.SM4));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_XOR:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.keyBits.xor));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_INVALID_PARAMETER;\r
-    }\r
-    break;\r
-  case TPM_ALG_RSA:\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.algorithm));\r
-    Buffer += sizeof(UINT16);\r
-    switch (Parameters->parameters.rsaDetail.symmetric.algorithm) {\r
-    case TPM_ALG_AES:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.keyBits.aes));\r
-      Buffer += sizeof(UINT16);\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.mode.aes));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_SM4:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.keyBits.SM4));\r
-      Buffer += sizeof(UINT16);\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.mode.SM4));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_INVALID_PARAMETER;\r
-    }\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.scheme.scheme));\r
-    Buffer += sizeof(UINT16);\r
-    switch (Parameters->parameters.rsaDetail.scheme.scheme) {\r
-    case TPM_ALG_RSASSA:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.scheme.details.rsassa.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_RSAPSS:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.scheme.details.rsapss.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_RSAES:\r
-      break;\r
-    case TPM_ALG_OAEP:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.scheme.details.oaep.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_INVALID_PARAMETER;\r
-    }\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.keyBits));\r
-    Buffer += sizeof(UINT16);\r
-    WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (Parameters->parameters.rsaDetail.exponent));\r
-    Buffer += sizeof(UINT32);\r
-    break;\r
-  case TPM_ALG_ECC:\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.algorithm));\r
-    Buffer += sizeof(UINT16);\r
-    switch (Parameters->parameters.eccDetail.symmetric.algorithm) {\r
-    case TPM_ALG_AES:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.keyBits.aes));\r
-      Buffer += sizeof(UINT16);\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.mode.aes));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_SM4:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.keyBits.SM4));\r
-      Buffer += sizeof(UINT16);\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.mode.SM4));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_INVALID_PARAMETER;\r
-    }\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.scheme.scheme));\r
-    Buffer += sizeof(UINT16);\r
-    switch (Parameters->parameters.eccDetail.scheme.scheme) {\r
-    case TPM_ALG_ECDSA:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.scheme.details.ecdsa.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_ECDAA:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.scheme.details.ecdaa.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_ECSCHNORR:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.scheme.details.ecSchnorr.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_ECDH:\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_INVALID_PARAMETER;\r
-    }\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.curveID));\r
-    Buffer += sizeof(UINT16);\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.scheme));\r
-    Buffer += sizeof(UINT16);\r
-    switch (Parameters->parameters.eccDetail.kdf.scheme) {\r
-    case TPM_ALG_MGF1:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.details.mgf1.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_KDF1_SP800_108:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.details.kdf1_sp800_108.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_KDF1_SP800_56a:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.details.kdf1_SP800_56a.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
+    case TPM_ALG_KEYEDHASH:\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.keyedHashDetail.scheme.scheme));\r
+      Buffer += sizeof (UINT16);\r
+      switch (Parameters->parameters.keyedHashDetail.scheme.scheme) {\r
+        case TPM_ALG_HMAC:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.keyedHashDetail.scheme.details.hmac.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_XOR:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.keyedHashDetail.scheme.details.xor.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.keyedHashDetail.scheme.details.xor.kdf));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        default:\r
+          return EFI_INVALID_PARAMETER;\r
+      }\r
+\r
+    case TPM_ALG_SYMCIPHER:\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.algorithm));\r
+      Buffer += sizeof (UINT16);\r
+      switch (Parameters->parameters.symDetail.algorithm) {\r
+        case TPM_ALG_AES:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.keyBits.aes));\r
+          Buffer += sizeof (UINT16);\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.mode.aes));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_SM4:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.keyBits.SM4));\r
+          Buffer += sizeof (UINT16);\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.mode.SM4));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_XOR:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.keyBits.xor));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_INVALID_PARAMETER;\r
+      }\r
+\r
       break;\r
-    case TPM_ALG_KDF2:\r
-      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.details.kdf2.hashAlg));\r
-      Buffer += sizeof(UINT16);\r
+    case TPM_ALG_RSA:\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.algorithm));\r
+      Buffer += sizeof (UINT16);\r
+      switch (Parameters->parameters.rsaDetail.symmetric.algorithm) {\r
+        case TPM_ALG_AES:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.keyBits.aes));\r
+          Buffer += sizeof (UINT16);\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.mode.aes));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_SM4:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.keyBits.SM4));\r
+          Buffer += sizeof (UINT16);\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.symmetric.mode.SM4));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_INVALID_PARAMETER;\r
+      }\r
+\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.scheme.scheme));\r
+      Buffer += sizeof (UINT16);\r
+      switch (Parameters->parameters.rsaDetail.scheme.scheme) {\r
+        case TPM_ALG_RSASSA:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.scheme.details.rsassa.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_RSAPSS:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.scheme.details.rsapss.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_RSAES:\r
+          break;\r
+        case TPM_ALG_OAEP:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.scheme.details.oaep.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_INVALID_PARAMETER;\r
+      }\r
+\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.rsaDetail.keyBits));\r
+      Buffer += sizeof (UINT16);\r
+      WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (Parameters->parameters.rsaDetail.exponent));\r
+      Buffer += sizeof (UINT32);\r
       break;\r
-    case TPM_ALG_NULL:\r
+    case TPM_ALG_ECC:\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.algorithm));\r
+      Buffer += sizeof (UINT16);\r
+      switch (Parameters->parameters.eccDetail.symmetric.algorithm) {\r
+        case TPM_ALG_AES:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.keyBits.aes));\r
+          Buffer += sizeof (UINT16);\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.mode.aes));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_SM4:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.keyBits.SM4));\r
+          Buffer += sizeof (UINT16);\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.symmetric.mode.SM4));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_INVALID_PARAMETER;\r
+      }\r
+\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.scheme.scheme));\r
+      Buffer += sizeof (UINT16);\r
+      switch (Parameters->parameters.eccDetail.scheme.scheme) {\r
+        case TPM_ALG_ECDSA:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.scheme.details.ecdsa.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_ECDAA:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.scheme.details.ecdaa.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_ECSCHNORR:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.scheme.details.ecSchnorr.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_ECDH:\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_INVALID_PARAMETER;\r
+      }\r
+\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.curveID));\r
+      Buffer += sizeof (UINT16);\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.scheme));\r
+      Buffer += sizeof (UINT16);\r
+      switch (Parameters->parameters.eccDetail.kdf.scheme) {\r
+        case TPM_ALG_MGF1:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.details.mgf1.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_KDF1_SP800_108:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.details.kdf1_sp800_108.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_KDF1_SP800_56a:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.details.kdf1_SP800_56a.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_KDF2:\r
+          WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.eccDetail.kdf.details.kdf2.hashAlg));\r
+          Buffer += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_INVALID_PARAMETER;\r
+      }\r
+\r
       break;\r
     default:\r
       return EFI_INVALID_PARAMETER;\r
-    }\r
-    break;\r
-  default:\r
-    return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  SendBufferSize = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
+  SendBufferSize              = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -892,8 +913,9 @@ Tpm2TestParms (
     DEBUG ((DEBUG_ERROR, "Tpm2TestParms - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2TestParms - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2TestParms - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
index f284f8d21a717d629b3fcbbbfcec222a1707a1af..a961dd126d4f36f707284460d98089aad2c14283 100644 (file)
@@ -16,12 +16,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_DH_CONTEXT           FlushHandle;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_DH_CONTEXT        FlushHandle;\r
 } TPM2_FLUSH_CONTEXT_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
+  TPM2_RESPONSE_HEADER    Header;\r
 } TPM2_FLUSH_CONTEXT_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -37,31 +37,31 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2FlushContext (\r
-  IN      TPMI_DH_CONTEXT           FlushHandle\r
+  IN      TPMI_DH_CONTEXT  FlushHandle\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_FLUSH_CONTEXT_COMMAND        SendBuffer;\r
-  TPM2_FLUSH_CONTEXT_RESPONSE       RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
+  EFI_STATUS                   Status;\r
+  TPM2_FLUSH_CONTEXT_COMMAND   SendBuffer;\r
+  TPM2_FLUSH_CONTEXT_RESPONSE  RecvBuffer;\r
+  UINT32                       SendBufferSize;\r
+  UINT32                       RecvBufferSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_FlushContext);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_FlushContext);\r
 \r
   SendBuffer.FlushHandle = SwapBytes32 (FlushHandle);\r
 \r
-  SendBufferSize = (UINT32) sizeof (SendBuffer);\r
+  SendBufferSize              = (UINT32)sizeof (SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -70,8 +70,9 @@ Tpm2FlushContext (
     DEBUG ((DEBUG_ERROR, "Tpm2FlushContext - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2FlushContext - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2FlushContext - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
index 2f830e0aea4898cac173c0ef6a2789e36207696f..ac8183d9ea885f73ec0ae39a15b4d308567aceb3 100644 (file)
@@ -16,32 +16,32 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_LOCKOUT           LockHandle;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_LOCKOUT        LockHandle;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
 } TPM2_DICTIONARY_ATTACK_LOCK_RESET_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_DICTIONARY_ATTACK_LOCK_RESET_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_LOCKOUT           LockHandle;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
-  UINT32                    NewMaxTries;\r
-  UINT32                    NewRecoveryTime;\r
-  UINT32                    LockoutRecovery;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_LOCKOUT        LockHandle;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
+  UINT32                 NewMaxTries;\r
+  UINT32                 NewRecoveryTime;\r
+  UINT32                 LockoutRecovery;\r
 } TPM2_DICTIONARY_ATTACK_PARAMETERS_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_DICTIONARY_ATTACK_PARAMETERS_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -59,23 +59,23 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2DictionaryAttackLockReset (\r
-  IN  TPMI_RH_LOCKOUT           LockHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession\r
+  IN  TPMI_RH_LOCKOUT    LockHandle,\r
+  IN  TPMS_AUTH_COMMAND  *AuthSession\r
   )\r
 {\r
-  EFI_STATUS                                 Status;\r
-  TPM2_DICTIONARY_ATTACK_LOCK_RESET_COMMAND  SendBuffer;\r
-  TPM2_DICTIONARY_ATTACK_LOCK_RESET_RESPONSE RecvBuffer;\r
-  UINT32                                     SendBufferSize;\r
-  UINT32                                     RecvBufferSize;\r
-  UINT8                                      *Buffer;\r
-  UINT32                                     SessionInfoSize;\r
+  EFI_STATUS                                  Status;\r
+  TPM2_DICTIONARY_ATTACK_LOCK_RESET_COMMAND   SendBuffer;\r
+  TPM2_DICTIONARY_ATTACK_LOCK_RESET_RESPONSE  RecvBuffer;\r
+  UINT32                                      SendBufferSize;\r
+  UINT32                                      RecvBufferSize;\r
+  UINT8                                       *Buffer;\r
+  UINT32                                      SessionInfoSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_DictionaryAttackLockReset);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_DictionaryAttackLockReset);\r
 \r
   SendBuffer.LockHandle = SwapBytes32 (LockHandle);\r
 \r
@@ -85,18 +85,18 @@ Tpm2DictionaryAttackLockReset (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  SendBufferSize = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
+  SendBufferSize              = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -106,8 +106,9 @@ Tpm2DictionaryAttackLockReset (
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2DictionaryAttackLockReset - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2DictionaryAttackLockReset - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -116,8 +117,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -137,26 +138,26 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2DictionaryAttackParameters (\r
-  IN  TPMI_RH_LOCKOUT           LockHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN  UINT32                    NewMaxTries,\r
-  IN  UINT32                    NewRecoveryTime,\r
-  IN  UINT32                    LockoutRecovery\r
+  IN  TPMI_RH_LOCKOUT    LockHandle,\r
+  IN  TPMS_AUTH_COMMAND  *AuthSession,\r
+  IN  UINT32             NewMaxTries,\r
+  IN  UINT32             NewRecoveryTime,\r
+  IN  UINT32             LockoutRecovery\r
   )\r
 {\r
-  EFI_STATUS                                 Status;\r
-  TPM2_DICTIONARY_ATTACK_PARAMETERS_COMMAND  SendBuffer;\r
-  TPM2_DICTIONARY_ATTACK_PARAMETERS_RESPONSE RecvBuffer;\r
-  UINT32                                     SendBufferSize;\r
-  UINT32                                     RecvBufferSize;\r
-  UINT8                                      *Buffer;\r
-  UINT32                                     SessionInfoSize;\r
+  EFI_STATUS                                  Status;\r
+  TPM2_DICTIONARY_ATTACK_PARAMETERS_COMMAND   SendBuffer;\r
+  TPM2_DICTIONARY_ATTACK_PARAMETERS_RESPONSE  RecvBuffer;\r
+  UINT32                                      SendBufferSize;\r
+  UINT32                                      RecvBufferSize;\r
+  UINT8                                       *Buffer;\r
+  UINT32                                      SessionInfoSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_DictionaryAttackParameters);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_DictionaryAttackParameters);\r
 \r
   SendBuffer.LockHandle = SwapBytes32 (LockHandle);\r
 \r
@@ -166,28 +167,28 @@ Tpm2DictionaryAttackParameters (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
   //\r
   // Real data\r
   //\r
-  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(NewMaxTries));\r
-  Buffer += sizeof(UINT32);\r
-  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(NewRecoveryTime));\r
-  Buffer += sizeof(UINT32);\r
-  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(LockoutRecovery));\r
-  Buffer += sizeof(UINT32);\r
+  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (NewMaxTries));\r
+  Buffer += sizeof (UINT32);\r
+  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (NewRecoveryTime));\r
+  Buffer += sizeof (UINT32);\r
+  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (LockoutRecovery));\r
+  Buffer += sizeof (UINT32);\r
 \r
-  SendBufferSize = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
+  SendBufferSize              = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -197,8 +198,9 @@ Tpm2DictionaryAttackParameters (
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2DictionaryAttackParameters - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2DictionaryAttackParameters - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -207,7 +209,7 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBufferSize, sizeof(SendBufferSize));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBufferSize, sizeof (SendBufferSize));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
index 53983d745bf667933ad92448d3fe291cfde35592..c63db70336a7a7d20f38557f7a4eb40d96bc82f1 100644 (file)
@@ -16,53 +16,53 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_DH_ENTITY            AuthHandle;\r
-  TPMI_SH_POLICY            PolicySession;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
-  TPM2B_NONCE               NonceTPM;\r
-  TPM2B_DIGEST              CpHashA;\r
-  TPM2B_NONCE               PolicyRef;\r
-  INT32                     Expiration;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_DH_ENTITY         AuthHandle;\r
+  TPMI_SH_POLICY         PolicySession;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
+  TPM2B_NONCE            NonceTPM;\r
+  TPM2B_DIGEST           CpHashA;\r
+  TPM2B_NONCE            PolicyRef;\r
+  INT32                  Expiration;\r
 } TPM2_POLICY_SECRET_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
-  UINT32                    AuthSessionSize;\r
-  TPM2B_TIMEOUT             Timeout;\r
-  TPMT_TK_AUTH              PolicyTicket;\r
-  TPMS_AUTH_RESPONSE        AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPM2B_TIMEOUT           Timeout;\r
+  TPMT_TK_AUTH            PolicyTicket;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_POLICY_SECRET_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_SH_POLICY            PolicySession;\r
-  TPML_DIGEST               HashList;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_SH_POLICY         PolicySession;\r
+  TPML_DIGEST            HashList;\r
 } TPM2_POLICY_OR_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
+  TPM2_RESPONSE_HEADER    Header;\r
 } TPM2_POLICY_OR_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_SH_POLICY            PolicySession;\r
-  TPM_CC                    Code;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_SH_POLICY         PolicySession;\r
+  TPM_CC                 Code;\r
 } TPM2_POLICY_COMMAND_CODE_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
+  TPM2_RESPONSE_HEADER    Header;\r
 } TPM2_POLICY_COMMAND_CODE_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_SH_POLICY            PolicySession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_SH_POLICY         PolicySession;\r
 } TPM2_POLICY_GET_DIGEST_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
-  TPM2B_DIGEST              PolicyHash;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  TPM2B_DIGEST            PolicyHash;\r
 } TPM2_POLICY_GET_DIGEST_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -88,32 +88,32 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PolicySecret (\r
-  IN      TPMI_DH_ENTITY            AuthHandle,\r
-  IN      TPMI_SH_POLICY            PolicySession,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN      TPM2B_NONCE               *NonceTPM,\r
-  IN      TPM2B_DIGEST              *CpHashA,\r
-  IN      TPM2B_NONCE               *PolicyRef,\r
-  IN      INT32                     Expiration,\r
-  OUT     TPM2B_TIMEOUT             *Timeout,\r
-  OUT     TPMT_TK_AUTH              *PolicyTicket\r
+  IN      TPMI_DH_ENTITY     AuthHandle,\r
+  IN      TPMI_SH_POLICY     PolicySession,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN      TPM2B_NONCE        *NonceTPM,\r
+  IN      TPM2B_DIGEST       *CpHashA,\r
+  IN      TPM2B_NONCE        *PolicyRef,\r
+  IN      INT32              Expiration,\r
+  OUT     TPM2B_TIMEOUT      *Timeout,\r
+  OUT     TPMT_TK_AUTH       *PolicyTicket\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_POLICY_SECRET_COMMAND        SendBuffer;\r
-  TPM2_POLICY_SECRET_RESPONSE       RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
+  EFI_STATUS                   Status;\r
+  TPM2_POLICY_SECRET_COMMAND   SendBuffer;\r
+  TPM2_POLICY_SECRET_RESPONSE  RecvBuffer;\r
+  UINT32                       SendBufferSize;\r
+  UINT32                       RecvBufferSize;\r
+  UINT8                        *Buffer;\r
+  UINT32                       SessionInfoSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_PolicySecret);\r
-  SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
-  SendBuffer.PolicySession = SwapBytes32 (PolicySession);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_PolicySecret);\r
+  SendBuffer.AuthHandle         = SwapBytes32 (AuthHandle);\r
+  SendBuffer.PolicySession      = SwapBytes32 (PolicySession);\r
 \r
   //\r
   // Add in Auth session\r
@@ -121,39 +121,39 @@ Tpm2PolicySecret (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
   //\r
   // Real data\r
   //\r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(NonceTPM->size));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (NonceTPM->size));\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Buffer, NonceTPM->buffer, NonceTPM->size);\r
   Buffer += NonceTPM->size;\r
 \r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(CpHashA->size));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (CpHashA->size));\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Buffer, CpHashA->buffer, CpHashA->size);\r
   Buffer += CpHashA->size;\r
 \r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(PolicyRef->size));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (PolicyRef->size));\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Buffer, PolicyRef->buffer, PolicyRef->size);\r
   Buffer += PolicyRef->size;\r
 \r
-  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32((UINT32)Expiration));\r
-  Buffer += sizeof(UINT32);\r
+  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 ((UINT32)Expiration));\r
+  Buffer += sizeof (UINT32);\r
 \r
-  SendBufferSize = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
+  SendBufferSize              = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -163,8 +163,9 @@ Tpm2PolicySecret (
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2PolicySecret - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2PolicySecret - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -172,24 +173,24 @@ Tpm2PolicySecret (
   //\r
   // Return the response\r
   //\r
-  Buffer = (UINT8 *)&RecvBuffer.Timeout;\r
-  Timeout->size = SwapBytes16(ReadUnaligned16 ((UINT16 *)Buffer));\r
-  if (Timeout->size > sizeof(UINT64)) {\r
+  Buffer        = (UINT8 *)&RecvBuffer.Timeout;\r
+  Timeout->size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+  if (Timeout->size > sizeof (UINT64)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PolicySecret - Timeout->size error %x\n", Timeout->size));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
 \r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Timeout->buffer, Buffer, Timeout->size);\r
 \r
-  PolicyTicket->tag = SwapBytes16(ReadUnaligned16 ((UINT16 *)Buffer));\r
-  Buffer += sizeof(UINT16);\r
-  PolicyTicket->hierarchy = SwapBytes32(ReadUnaligned32 ((UINT32 *)Buffer));\r
-  Buffer += sizeof(UINT32);\r
-  PolicyTicket->digest.size = SwapBytes16(ReadUnaligned16 ((UINT16 *)Buffer));\r
-  Buffer += sizeof(UINT16);\r
-  if (PolicyTicket->digest.size > sizeof(TPMU_HA)) {\r
+  PolicyTicket->tag         = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+  Buffer                   += sizeof (UINT16);\r
+  PolicyTicket->hierarchy   = SwapBytes32 (ReadUnaligned32 ((UINT32 *)Buffer));\r
+  Buffer                   += sizeof (UINT32);\r
+  PolicyTicket->digest.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+  Buffer                   += sizeof (UINT16);\r
+  if (PolicyTicket->digest.size > sizeof (TPMU_HA)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PolicySecret - digest.size error %x\n", PolicyTicket->digest.size));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
@@ -201,8 +202,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -221,43 +222,43 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PolicyOR (\r
-  IN TPMI_SH_POLICY           PolicySession,\r
-  IN TPML_DIGEST              *HashList\r
+  IN TPMI_SH_POLICY  PolicySession,\r
+  IN TPML_DIGEST     *HashList\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_POLICY_OR_COMMAND            SendBuffer;\r
-  TPM2_POLICY_OR_RESPONSE           RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT8                             *Buffer;\r
-  UINTN                             Index;\r
+  EFI_STATUS               Status;\r
+  TPM2_POLICY_OR_COMMAND   SendBuffer;\r
+  TPM2_POLICY_OR_RESPONSE  RecvBuffer;\r
+  UINT32                   SendBufferSize;\r
+  UINT32                   RecvBufferSize;\r
+  UINT8                    *Buffer;\r
+  UINTN                    Index;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_PolicyOR);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_PolicyOR);\r
 \r
   SendBuffer.PolicySession = SwapBytes32 (PolicySession);\r
-  Buffer = (UINT8 *)&SendBuffer.HashList;\r
+  Buffer                   = (UINT8 *)&SendBuffer.HashList;\r
   WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (HashList->count));\r
-  Buffer += sizeof(UINT32);\r
+  Buffer += sizeof (UINT32);\r
   for (Index = 0; Index < HashList->count; Index++) {\r
     WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (HashList->digests[Index].size));\r
-    Buffer += sizeof(UINT16);\r
+    Buffer += sizeof (UINT16);\r
     CopyMem (Buffer, HashList->digests[Index].buffer, HashList->digests[Index].size);\r
     Buffer += HashList->digests[Index].size;\r
   }\r
 \r
-  SendBufferSize = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
+  SendBufferSize              = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -266,8 +267,9 @@ Tpm2PolicyOR (
     DEBUG ((DEBUG_ERROR, "Tpm2PolicyOR - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2PolicyOR - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2PolicyOR - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -286,33 +288,33 @@ Tpm2PolicyOR (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PolicyCommandCode (\r
-  IN      TPMI_SH_POLICY            PolicySession,\r
-  IN      TPM_CC                    Code\r
+  IN      TPMI_SH_POLICY  PolicySession,\r
+  IN      TPM_CC          Code\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_POLICY_COMMAND_CODE_COMMAND  SendBuffer;\r
-  TPM2_POLICY_COMMAND_CODE_RESPONSE RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
+  EFI_STATUS                         Status;\r
+  TPM2_POLICY_COMMAND_CODE_COMMAND   SendBuffer;\r
+  TPM2_POLICY_COMMAND_CODE_RESPONSE  RecvBuffer;\r
+  UINT32                             SendBufferSize;\r
+  UINT32                             RecvBufferSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_PolicyCommandCode);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_PolicyCommandCode);\r
 \r
   SendBuffer.PolicySession = SwapBytes32 (PolicySession);\r
-  SendBuffer.Code = SwapBytes32 (Code);\r
+  SendBuffer.Code          = SwapBytes32 (Code);\r
 \r
-  SendBufferSize = (UINT32) sizeof (SendBuffer);\r
+  SendBufferSize              = (UINT32)sizeof (SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -321,8 +323,9 @@ Tpm2PolicyCommandCode (
     DEBUG ((DEBUG_ERROR, "Tpm2PolicyCommandCode - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2PolicyCommandCode - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2PolicyCommandCode - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -342,32 +345,32 @@ Tpm2PolicyCommandCode (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PolicyGetDigest (\r
-  IN      TPMI_SH_POLICY            PolicySession,\r
-     OUT  TPM2B_DIGEST              *PolicyHash\r
+  IN      TPMI_SH_POLICY  PolicySession,\r
+  OUT  TPM2B_DIGEST       *PolicyHash\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_POLICY_GET_DIGEST_COMMAND    SendBuffer;\r
-  TPM2_POLICY_GET_DIGEST_RESPONSE   RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
+  EFI_STATUS                       Status;\r
+  TPM2_POLICY_GET_DIGEST_COMMAND   SendBuffer;\r
+  TPM2_POLICY_GET_DIGEST_RESPONSE  RecvBuffer;\r
+  UINT32                           SendBufferSize;\r
+  UINT32                           RecvBufferSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_PolicyGetDigest);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_PolicyGetDigest);\r
 \r
   SendBuffer.PolicySession = SwapBytes32 (PolicySession);\r
 \r
-  SendBufferSize = (UINT32) sizeof (SendBuffer);\r
+  SendBufferSize              = (UINT32)sizeof (SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -376,8 +379,9 @@ Tpm2PolicyGetDigest (
     DEBUG ((DEBUG_ERROR, "Tpm2PolicyGetDigest - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2PolicyGetDigest - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2PolicyGetDigest - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -385,7 +389,7 @@ Tpm2PolicyGetDigest (
   // Return the response\r
   //\r
   PolicyHash->size = SwapBytes16 (RecvBuffer.PolicyHash.size);\r
-  if (PolicyHash->size > sizeof(TPMU_HA)) {\r
+  if (PolicyHash->size > sizeof (TPMU_HA)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PolicyGetDigest - PolicyHash->size error %x\n", PolicyHash->size));\r
     return EFI_DEVICE_ERROR;\r
   }\r
index 44115cded311659ec3ab23b381ae8843c7f8f19e..e7f30b673f0e8a6f73327ad8c352cc6bd9c49ebb 100644 (file)
@@ -14,17 +14,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/DebugLib.h>\r
 \r
 typedef struct {\r
-  TPMI_ALG_HASH              HashAlgo;\r
-  UINT16                     HashSize;\r
-  UINT32                     HashMask;\r
+  TPMI_ALG_HASH    HashAlgo;\r
+  UINT16           HashSize;\r
+  UINT32           HashMask;\r
 } INTERNAL_HASH_INFO;\r
 \r
-STATIC INTERNAL_HASH_INFO mHashInfo[] = {\r
-  {TPM_ALG_SHA1,          SHA1_DIGEST_SIZE,     HASH_ALG_SHA1},\r
-  {TPM_ALG_SHA256,        SHA256_DIGEST_SIZE,   HASH_ALG_SHA256},\r
-  {TPM_ALG_SM3_256,       SM3_256_DIGEST_SIZE,  HASH_ALG_SM3_256},\r
-  {TPM_ALG_SHA384,        SHA384_DIGEST_SIZE,   HASH_ALG_SHA384},\r
-  {TPM_ALG_SHA512,        SHA512_DIGEST_SIZE,   HASH_ALG_SHA512},\r
+STATIC INTERNAL_HASH_INFO  mHashInfo[] = {\r
+  { TPM_ALG_SHA1,    SHA1_DIGEST_SIZE,    HASH_ALG_SHA1    },\r
+  { TPM_ALG_SHA256,  SHA256_DIGEST_SIZE,  HASH_ALG_SHA256  },\r
+  { TPM_ALG_SM3_256, SM3_256_DIGEST_SIZE, HASH_ALG_SM3_256 },\r
+  { TPM_ALG_SHA384,  SHA384_DIGEST_SIZE,  HASH_ALG_SHA384  },\r
+  { TPM_ALG_SHA512,  SHA512_DIGEST_SIZE,  HASH_ALG_SHA512  },\r
 };\r
 \r
 /**\r
@@ -37,16 +37,17 @@ STATIC INTERNAL_HASH_INFO mHashInfo[] = {
 UINT16\r
 EFIAPI\r
 GetHashSizeFromAlgo (\r
-  IN TPMI_ALG_HASH    HashAlgo\r
+  IN TPMI_ALG_HASH  HashAlgo\r
   )\r
 {\r
   UINTN  Index;\r
 \r
-  for (Index = 0; Index < sizeof(mHashInfo)/sizeof(mHashInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mHashInfo)/sizeof (mHashInfo[0]); Index++) {\r
     if (mHashInfo[Index].HashAlgo == HashAlgo) {\r
       return mHashInfo[Index].HashSize;\r
     }\r
   }\r
+\r
   return 0;\r
 }\r
 \r
@@ -60,16 +61,17 @@ GetHashSizeFromAlgo (
 UINT32\r
 EFIAPI\r
 GetHashMaskFromAlgo (\r
-  IN TPMI_ALG_HASH     HashAlgo\r
+  IN TPMI_ALG_HASH  HashAlgo\r
   )\r
 {\r
   UINTN  Index;\r
 \r
-  for (Index = 0; Index < sizeof(mHashInfo)/sizeof(mHashInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mHashInfo)/sizeof (mHashInfo[0]); Index++) {\r
     if (mHashInfo[Index].HashAlgo == HashAlgo) {\r
       return mHashInfo[Index].HashMask;\r
     }\r
   }\r
+\r
   return 0;\r
 }\r
 \r
@@ -84,8 +86,8 @@ GetHashMaskFromAlgo (
 UINT32\r
 EFIAPI\r
 CopyAuthSessionCommand (\r
-  IN      TPMS_AUTH_COMMAND         *AuthSessionIn  OPTIONAL,\r
-  OUT     UINT8                     *AuthSessionOut\r
+  IN      TPMS_AUTH_COMMAND  *AuthSessionIn  OPTIONAL,\r
+  OUT     UINT8              *AuthSessionOut\r
   )\r
 {\r
   UINT8  *Buffer;\r
@@ -97,12 +99,12 @@ CopyAuthSessionCommand (
   //\r
   if (AuthSessionIn != NULL) {\r
     //  sessionHandle\r
-    WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(AuthSessionIn->sessionHandle));\r
-    Buffer += sizeof(UINT32);\r
+    WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (AuthSessionIn->sessionHandle));\r
+    Buffer += sizeof (UINT32);\r
 \r
     // nonce\r
     WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (AuthSessionIn->nonce.size));\r
-    Buffer += sizeof(UINT16);\r
+    Buffer += sizeof (UINT16);\r
 \r
     CopyMem (Buffer, AuthSessionIn->nonce.buffer, AuthSessionIn->nonce.size);\r
     Buffer += AuthSessionIn->nonce.size;\r
@@ -113,26 +115,26 @@ CopyAuthSessionCommand (
 \r
     // hmac\r
     WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (AuthSessionIn->hmac.size));\r
-    Buffer += sizeof(UINT16);\r
+    Buffer += sizeof (UINT16);\r
 \r
     CopyMem (Buffer, AuthSessionIn->hmac.buffer, AuthSessionIn->hmac.size);\r
     Buffer += AuthSessionIn->hmac.size;\r
   } else {\r
     //  sessionHandle\r
-    WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(TPM_RS_PW));\r
-    Buffer += sizeof(UINT32);\r
+    WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (TPM_RS_PW));\r
+    Buffer += sizeof (UINT32);\r
 \r
     // nonce = nullNonce\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(0));\r
-    Buffer += sizeof(UINT16);\r
+    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (0));\r
+    Buffer += sizeof (UINT16);\r
 \r
     // sessionAttributes = 0\r
     *(UINT8 *)Buffer = 0x00;\r
     Buffer++;\r
 \r
     // hmac = nullAuth\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(0));\r
-    Buffer += sizeof(UINT16);\r
+    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (0));\r
+    Buffer += sizeof (UINT16);\r
   }\r
 \r
   return (UINT32)((UINTN)Buffer - (UINTN)AuthSessionOut);\r
@@ -150,12 +152,12 @@ CopyAuthSessionCommand (
 UINT32\r
 EFIAPI\r
 CopyAuthSessionResponse (\r
-  IN      UINT8                      *AuthSessionIn,\r
-  OUT     TPMS_AUTH_RESPONSE         *AuthSessionOut OPTIONAL\r
+  IN      UINT8               *AuthSessionIn,\r
+  OUT     TPMS_AUTH_RESPONSE  *AuthSessionOut OPTIONAL\r
   )\r
 {\r
-  UINT8                      *Buffer;\r
-  TPMS_AUTH_RESPONSE         LocalAuthSessionOut;\r
+  UINT8               *Buffer;\r
+  TPMS_AUTH_RESPONSE  LocalAuthSessionOut;\r
 \r
   if (AuthSessionOut == NULL) {\r
     AuthSessionOut = &LocalAuthSessionOut;\r
@@ -165,8 +167,8 @@ CopyAuthSessionResponse (
 \r
   // nonce\r
   AuthSessionOut->nonce.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-  Buffer += sizeof(UINT16);\r
-  if (AuthSessionOut->nonce.size > sizeof(TPMU_HA)) {\r
+  Buffer                    += sizeof (UINT16);\r
+  if (AuthSessionOut->nonce.size > sizeof (TPMU_HA)) {\r
     DEBUG ((DEBUG_ERROR, "CopyAuthSessionResponse - nonce.size error %x\n", AuthSessionOut->nonce.size));\r
     return 0;\r
   }\r
@@ -175,13 +177,13 @@ CopyAuthSessionResponse (
   Buffer += AuthSessionOut->nonce.size;\r
 \r
   // sessionAttributes\r
-  *(UINT8 *)&AuthSessionOut->sessionAttributes = *(UINT8 *)Buffer;\r
+  *(UINT8 *) &AuthSessionOut->sessionAttributes = *(UINT8 *)Buffer;\r
   Buffer++;\r
 \r
   // hmac\r
   AuthSessionOut->hmac.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-  Buffer += sizeof(UINT16);\r
-  if (AuthSessionOut->hmac.size > sizeof(TPMU_HA)) {\r
+  Buffer                   += sizeof (UINT16);\r
+  if (AuthSessionOut->hmac.size > sizeof (TPMU_HA)) {\r
     DEBUG ((DEBUG_ERROR, "CopyAuthSessionResponse - hmac.size error %x\n", AuthSessionOut->hmac.size));\r
     return 0;\r
   }\r
@@ -203,37 +205,42 @@ CopyAuthSessionResponse (
 **/\r
 BOOLEAN\r
 EFIAPI\r
-IsHashAlgSupportedInHashAlgorithmMask(\r
+IsHashAlgSupportedInHashAlgorithmMask (\r
   IN TPMI_ALG_HASH  HashAlg,\r
   IN UINT32         HashAlgorithmMask\r
   )\r
 {\r
   switch (HashAlg) {\r
-  case TPM_ALG_SHA1:\r
-    if ((HashAlgorithmMask & HASH_ALG_SHA1) != 0) {\r
-      return TRUE;\r
-    }\r
-    break;\r
-  case TPM_ALG_SHA256:\r
-    if ((HashAlgorithmMask & HASH_ALG_SHA256) != 0) {\r
-      return TRUE;\r
-    }\r
-    break;\r
-  case TPM_ALG_SHA384:\r
-    if ((HashAlgorithmMask & HASH_ALG_SHA384) != 0) {\r
-      return TRUE;\r
-    }\r
-    break;\r
-  case TPM_ALG_SHA512:\r
-    if ((HashAlgorithmMask & HASH_ALG_SHA512) != 0) {\r
-      return TRUE;\r
-    }\r
-    break;\r
-  case TPM_ALG_SM3_256:\r
-    if ((HashAlgorithmMask & HASH_ALG_SM3_256) != 0) {\r
-      return TRUE;\r
-    }\r
-    break;\r
+    case TPM_ALG_SHA1:\r
+      if ((HashAlgorithmMask & HASH_ALG_SHA1) != 0) {\r
+        return TRUE;\r
+      }\r
+\r
+      break;\r
+    case TPM_ALG_SHA256:\r
+      if ((HashAlgorithmMask & HASH_ALG_SHA256) != 0) {\r
+        return TRUE;\r
+      }\r
+\r
+      break;\r
+    case TPM_ALG_SHA384:\r
+      if ((HashAlgorithmMask & HASH_ALG_SHA384) != 0) {\r
+        return TRUE;\r
+      }\r
+\r
+      break;\r
+    case TPM_ALG_SHA512:\r
+      if ((HashAlgorithmMask & HASH_ALG_SHA512) != 0) {\r
+        return TRUE;\r
+      }\r
+\r
+      break;\r
+    case TPM_ALG_SM3_256:\r
+      if ((HashAlgorithmMask & HASH_ALG_SM3_256) != 0) {\r
+        return TRUE;\r
+      }\r
+\r
+      break;\r
   }\r
 \r
   return FALSE;\r
@@ -251,31 +258,33 @@ IsHashAlgSupportedInHashAlgorithmMask(
 VOID *\r
 EFIAPI\r
 CopyDigestListToBuffer (\r
-  IN OUT VOID                       *Buffer,\r
-  IN TPML_DIGEST_VALUES             *DigestList,\r
-  IN UINT32                         HashAlgorithmMask\r
+  IN OUT VOID            *Buffer,\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  IN UINT32              HashAlgorithmMask\r
   )\r
 {\r
-  UINTN  Index;\r
-  UINT16 DigestSize;\r
-  UINT32 DigestListCount;\r
-  UINT32 *DigestListCountPtr;\r
-\r
-  DigestListCountPtr = (UINT32 *) Buffer;\r
-  DigestListCount = 0;\r
-  Buffer = (UINT8 *)Buffer + sizeof(DigestList->count);\r
+  UINTN   Index;\r
+  UINT16  DigestSize;\r
+  UINT32  DigestListCount;\r
+  UINT32  *DigestListCountPtr;\r
+\r
+  DigestListCountPtr = (UINT32 *)Buffer;\r
+  DigestListCount    = 0;\r
+  Buffer             = (UINT8 *)Buffer + sizeof (DigestList->count);\r
   for (Index = 0; Index < DigestList->count; Index++) {\r
-    if (!IsHashAlgSupportedInHashAlgorithmMask(DigestList->digests[Index].hashAlg, HashAlgorithmMask)) {\r
+    if (!IsHashAlgSupportedInHashAlgorithmMask (DigestList->digests[Index].hashAlg, HashAlgorithmMask)) {\r
       DEBUG ((DEBUG_ERROR, "WARNING: TPM2 Event log has HashAlg unsupported by PCR bank (0x%x)\n", DigestList->digests[Index].hashAlg));\r
       continue;\r
     }\r
-    CopyMem (Buffer, &DigestList->digests[Index].hashAlg, sizeof(DigestList->digests[Index].hashAlg));\r
-    Buffer = (UINT8 *)Buffer + sizeof(DigestList->digests[Index].hashAlg);\r
+\r
+    CopyMem (Buffer, &DigestList->digests[Index].hashAlg, sizeof (DigestList->digests[Index].hashAlg));\r
+    Buffer     = (UINT8 *)Buffer + sizeof (DigestList->digests[Index].hashAlg);\r
     DigestSize = GetHashSizeFromAlgo (DigestList->digests[Index].hashAlg);\r
     CopyMem (Buffer, &DigestList->digests[Index].digest, DigestSize);\r
     Buffer = (UINT8 *)Buffer + DigestSize;\r
     DigestListCount++;\r
   }\r
+\r
   WriteUnaligned32 (DigestListCountPtr, DigestListCount);\r
 \r
   return Buffer;\r
@@ -291,17 +300,17 @@ CopyDigestListToBuffer (
 UINT32\r
 EFIAPI\r
 GetDigestListSize (\r
-  IN TPML_DIGEST_VALUES             *DigestList\r
+  IN TPML_DIGEST_VALUES  *DigestList\r
   )\r
 {\r
-  UINTN  Index;\r
-  UINT16 DigestSize;\r
-  UINT32 TotalSize;\r
+  UINTN   Index;\r
+  UINT16  DigestSize;\r
+  UINT32  TotalSize;\r
 \r
-  TotalSize = sizeof(DigestList->count);\r
+  TotalSize = sizeof (DigestList->count);\r
   for (Index = 0; Index < DigestList->count; Index++) {\r
     DigestSize = GetHashSizeFromAlgo (DigestList->digests[Index].hashAlg);\r
-    TotalSize += sizeof(DigestList->digests[Index].hashAlg) + DigestSize;\r
+    TotalSize += sizeof (DigestList->digests[Index].hashAlg) + DigestSize;\r
   }\r
 \r
   return TotalSize;\r
@@ -320,13 +329,13 @@ GetDigestListSize (
 EFI_STATUS\r
 EFIAPI\r
 GetDigestFromDigestList (\r
-  IN TPMI_ALG_HASH      HashAlg,\r
-  IN TPML_DIGEST_VALUES *DigestList,\r
-  OUT VOID              *Digest\r
+  IN TPMI_ALG_HASH       HashAlg,\r
+  IN TPML_DIGEST_VALUES  *DigestList,\r
+  OUT VOID               *Digest\r
   )\r
 {\r
-  UINTN  Index;\r
-  UINT16 DigestSize;\r
+  UINTN   Index;\r
+  UINT16  DigestSize;\r
 \r
   DigestSize = GetHashSizeFromAlgo (HashAlg);\r
   for (Index = 0; Index < DigestList->count; Index++) {\r
index 957d69443161834966ef61f383534c828958c4da..7144955be1a551a1542eb39cf633aadf8f622de1 100644 (file)
@@ -25,36 +25,36 @@ typedef struct {
 } TPM2_SET_PRIMARY_POLICY_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_SET_PRIMARY_POLICY_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_CLEAR             AuthHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_CLEAR          AuthHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
 } TPM2_CLEAR_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_CLEAR_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_CLEAR             AuthHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
-  TPMI_YES_NO               Disable;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_CLEAR          AuthHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
+  TPMI_YES_NO            Disable;\r
 } TPM2_CLEAR_CONTROL_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_CLEAR_CONTROL_RESPONSE;\r
 \r
 typedef struct {\r
@@ -66,50 +66,50 @@ typedef struct {
 } TPM2_HIERARCHY_CHANGE_AUTH_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_HIERARCHY_CHANGE_AUTH_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_PLATFORM          AuthHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_PLATFORM       AuthHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
 } TPM2_CHANGE_EPS_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_CHANGE_EPS_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_PLATFORM          AuthHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_PLATFORM       AuthHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
 } TPM2_CHANGE_PPS_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_CHANGE_PPS_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_HIERARCHY         AuthHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
-  TPMI_RH_HIERARCHY         Hierarchy;\r
-  TPMI_YES_NO               State;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_HIERARCHY      AuthHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
+  TPMI_RH_HIERARCHY      Hierarchy;\r
+  TPMI_YES_NO            State;\r
 } TPM2_HIERARCHY_CONTROL_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_HIERARCHY_CONTROL_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -129,25 +129,25 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SetPrimaryPolicy (\r
-  IN  TPMI_RH_HIERARCHY_AUTH    AuthHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN  TPM2B_DIGEST              *AuthPolicy,\r
-  IN  TPMI_ALG_HASH             HashAlg\r
+  IN  TPMI_RH_HIERARCHY_AUTH  AuthHandle,\r
+  IN  TPMS_AUTH_COMMAND       *AuthSession,\r
+  IN  TPM2B_DIGEST            *AuthPolicy,\r
+  IN  TPMI_ALG_HASH           HashAlg\r
   )\r
 {\r
-  EFI_STATUS                                 Status;\r
-  TPM2_SET_PRIMARY_POLICY_COMMAND            SendBuffer;\r
-  TPM2_SET_PRIMARY_POLICY_RESPONSE           RecvBuffer;\r
-  UINT32                                     SendBufferSize;\r
-  UINT32                                     RecvBufferSize;\r
-  UINT8                                      *Buffer;\r
-  UINT32                                     SessionInfoSize;\r
+  EFI_STATUS                        Status;\r
+  TPM2_SET_PRIMARY_POLICY_COMMAND   SendBuffer;\r
+  TPM2_SET_PRIMARY_POLICY_RESPONSE  RecvBuffer;\r
+  UINT32                            SendBufferSize;\r
+  UINT32                            RecvBufferSize;\r
+  UINT8                             *Buffer;\r
+  UINT32                            SessionInfoSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_SetPrimaryPolicy);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_SetPrimaryPolicy);\r
 \r
   SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
 \r
@@ -157,28 +157,28 @@ Tpm2SetPrimaryPolicy (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
   //\r
   // Real data\r
   //\r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(AuthPolicy->size));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (AuthPolicy->size));\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Buffer, AuthPolicy->buffer, AuthPolicy->size);\r
   Buffer += AuthPolicy->size;\r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(HashAlg));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (HashAlg));\r
+  Buffer += sizeof (UINT16);\r
 \r
-  SendBufferSize = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
+  SendBufferSize              = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -188,8 +188,9 @@ Tpm2SetPrimaryPolicy (
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2SetPrimaryPolicy - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2SetPrimaryPolicy - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -198,8 +199,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -215,22 +216,22 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2Clear (\r
-  IN TPMI_RH_CLEAR             AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN TPMI_RH_CLEAR      AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_CLEAR_COMMAND                Cmd;\r
-  TPM2_CLEAR_RESPONSE               Res;\r
-  UINT32                            ResultBufSize;\r
-  UINT32                            CmdSize;\r
-  UINT32                            RespSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
+  EFI_STATUS           Status;\r
+  TPM2_CLEAR_COMMAND   Cmd;\r
+  TPM2_CLEAR_RESPONSE  Res;\r
+  UINT32               ResultBufSize;\r
+  UINT32               CmdSize;\r
+  UINT32               RespSize;\r
+  UINT8                *Buffer;\r
+  UINT32               SessionInfoSize;\r
 \r
-  Cmd.Header.tag         = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_Clear);\r
-  Cmd.AuthHandle         = SwapBytes32(AuthHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_Clear);\r
+  Cmd.AuthHandle         = SwapBytes32 (AuthHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -238,20 +239,20 @@ Tpm2Clear (
   Buffer = (UINT8 *)&Cmd.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer               += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  CmdSize = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize   = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "Clear: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -260,8 +261,8 @@ Tpm2Clear (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "Clear: Response size too large! %d\r\n", RespSize));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -270,8 +271,8 @@ Tpm2Clear (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Clear: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Clear: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -285,8 +286,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&Cmd, sizeof(Cmd));\r
-  ZeroMem (&Res, sizeof(Res));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
+  ZeroMem (&Res, sizeof (Res));\r
   return Status;\r
 }\r
 \r
@@ -304,23 +305,23 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2ClearControl (\r
-  IN TPMI_RH_CLEAR             AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN TPMI_YES_NO               Disable\r
+  IN TPMI_RH_CLEAR      AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN TPMI_YES_NO        Disable\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_CLEAR_CONTROL_COMMAND        Cmd;\r
-  TPM2_CLEAR_CONTROL_RESPONSE       Res;\r
-  UINT32                            ResultBufSize;\r
-  UINT32                            CmdSize;\r
-  UINT32                            RespSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
+  EFI_STATUS                   Status;\r
+  TPM2_CLEAR_CONTROL_COMMAND   Cmd;\r
+  TPM2_CLEAR_CONTROL_RESPONSE  Res;\r
+  UINT32                       ResultBufSize;\r
+  UINT32                       CmdSize;\r
+  UINT32                       RespSize;\r
+  UINT8                        *Buffer;\r
+  UINT32                       SessionInfoSize;\r
 \r
-  Cmd.Header.tag         = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_ClearControl);\r
-  Cmd.AuthHandle         = SwapBytes32(AuthHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_ClearControl);\r
+  Cmd.AuthHandle         = SwapBytes32 (AuthHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -328,24 +329,24 @@ Tpm2ClearControl (
   Buffer = (UINT8 *)&Cmd.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer               += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
   // disable\r
   *(UINT8 *)Buffer = Disable;\r
   Buffer++;\r
 \r
-  CmdSize = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize   = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "ClearControl: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -354,8 +355,8 @@ Tpm2ClearControl (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "ClearControl: Response size too large! %d\r\n", RespSize));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -364,8 +365,8 @@ Tpm2ClearControl (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "ClearControl: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "ClearControl: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -379,8 +380,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&Cmd, sizeof(Cmd));\r
-  ZeroMem (&Res, sizeof(Res));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
+  ZeroMem (&Res, sizeof (Res));\r
   return Status;\r
 }\r
 \r
@@ -398,9 +399,9 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2HierarchyChangeAuth (\r
-  IN TPMI_RH_HIERARCHY_AUTH    AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN TPM2B_AUTH                *NewAuth\r
+  IN TPMI_RH_HIERARCHY_AUTH  AuthHandle,\r
+  IN TPMS_AUTH_COMMAND       *AuthSession,\r
+  IN TPM2B_AUTH              *NewAuth\r
   )\r
 {\r
   EFI_STATUS                           Status;\r
@@ -416,10 +417,10 @@ Tpm2HierarchyChangeAuth (
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag          = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.paramSize    = SwapBytes32(sizeof(Cmd));\r
-  Cmd.Header.commandCode  = SwapBytes32(TPM_CC_HierarchyChangeAuth);\r
-  Cmd.AuthHandle          = SwapBytes32(AuthHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.paramSize   = SwapBytes32 (sizeof (Cmd));\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_HierarchyChangeAuth);\r
+  Cmd.AuthHandle         = SwapBytes32 (AuthHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -427,23 +428,23 @@ Tpm2HierarchyChangeAuth (
   Buffer = (UINT8 *)&Cmd.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer               += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
   // New Authorization size\r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(NewAuth->size));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (NewAuth->size));\r
+  Buffer += sizeof (UINT16);\r
 \r
   // New Authorization\r
-  CopyMem(Buffer, NewAuth->buffer, NewAuth->size);\r
+  CopyMem (Buffer, NewAuth->buffer, NewAuth->size);\r
   Buffer += NewAuth->size;\r
 \r
-  CmdSize = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBuf     = (UINT8 *) &Res;\r
-  ResultBufSize = sizeof(Res);\r
+  ResultBuf     = (UINT8 *)&Res;\r
+  ResultBufSize = sizeof (Res);\r
 \r
   //\r
   // Call the TPM\r
@@ -454,11 +455,11 @@ Tpm2HierarchyChangeAuth (
              &ResultBufSize,\r
              ResultBuf\r
              );\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "HierarchyChangeAuth: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -467,8 +468,8 @@ Tpm2HierarchyChangeAuth (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "HierarchyChangeAuth: Response size too large! %d\r\n", RespSize));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -477,8 +478,8 @@ Tpm2HierarchyChangeAuth (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG((DEBUG_ERROR,"HierarchyChangeAuth: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "HierarchyChangeAuth: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -487,8 +488,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&Cmd, sizeof(Cmd));\r
-  ZeroMem (&Res, sizeof(Res));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
+  ZeroMem (&Res, sizeof (Res));\r
   return Status;\r
 }\r
 \r
@@ -505,8 +506,8 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2ChangeEPS (\r
-  IN TPMI_RH_PLATFORM          AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession\r
+  IN TPMI_RH_PLATFORM   AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession\r
   )\r
 {\r
   EFI_STATUS                Status;\r
@@ -522,10 +523,10 @@ Tpm2ChangeEPS (
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag          = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.paramSize    = SwapBytes32(sizeof(Cmd));\r
-  Cmd.Header.commandCode  = SwapBytes32(TPM_CC_ChangeEPS);\r
-  Cmd.AuthHandle          = SwapBytes32(AuthHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.paramSize   = SwapBytes32 (sizeof (Cmd));\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_ChangeEPS);\r
+  Cmd.AuthHandle         = SwapBytes32 (AuthHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -533,15 +534,15 @@ Tpm2ChangeEPS (
   Buffer = (UINT8 *)&Cmd.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer               += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  CmdSize = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBuf     = (UINT8 *) &Res;\r
-  ResultBufSize = sizeof(Res);\r
+  ResultBuf     = (UINT8 *)&Res;\r
+  ResultBufSize = sizeof (Res);\r
 \r
   //\r
   // Call the TPM\r
@@ -552,11 +553,11 @@ Tpm2ChangeEPS (
              &ResultBufSize,\r
              ResultBuf\r
              );\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "ChangeEPS: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -565,8 +566,8 @@ Tpm2ChangeEPS (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "ChangeEPS: Response size too large! %d\r\n", RespSize));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -575,8 +576,8 @@ Tpm2ChangeEPS (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG((DEBUG_ERROR,"ChangeEPS: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "ChangeEPS: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -585,8 +586,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&Cmd, sizeof(Cmd));\r
-  ZeroMem (&Res, sizeof(Res));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
+  ZeroMem (&Res, sizeof (Res));\r
   return Status;\r
 }\r
 \r
@@ -603,8 +604,8 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2ChangePPS (\r
-  IN TPMI_RH_PLATFORM          AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession\r
+  IN TPMI_RH_PLATFORM   AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession\r
   )\r
 {\r
   EFI_STATUS                Status;\r
@@ -620,10 +621,10 @@ Tpm2ChangePPS (
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag          = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.paramSize    = SwapBytes32(sizeof(Cmd));\r
-  Cmd.Header.commandCode  = SwapBytes32(TPM_CC_ChangePPS);\r
-  Cmd.AuthHandle          = SwapBytes32(AuthHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.paramSize   = SwapBytes32 (sizeof (Cmd));\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_ChangePPS);\r
+  Cmd.AuthHandle         = SwapBytes32 (AuthHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -631,15 +632,15 @@ Tpm2ChangePPS (
   Buffer = (UINT8 *)&Cmd.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer               += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  CmdSize = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBuf     = (UINT8 *) &Res;\r
-  ResultBufSize = sizeof(Res);\r
+  ResultBuf     = (UINT8 *)&Res;\r
+  ResultBufSize = sizeof (Res);\r
 \r
   //\r
   // Call the TPM\r
@@ -650,11 +651,11 @@ Tpm2ChangePPS (
              &ResultBufSize,\r
              ResultBuf\r
              );\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "ChangePPS: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -663,8 +664,8 @@ Tpm2ChangePPS (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "ChangePPS: Response size too large! %d\r\n", RespSize));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -673,8 +674,8 @@ Tpm2ChangePPS (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG((DEBUG_ERROR,"ChangePPS: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "ChangePPS: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -683,8 +684,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&Cmd, sizeof(Cmd));\r
-  ZeroMem (&Res, sizeof(Res));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
+  ZeroMem (&Res, sizeof (Res));\r
   return Status;\r
 }\r
 \r
@@ -703,10 +704,10 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2HierarchyControl (\r
-  IN TPMI_RH_HIERARCHY         AuthHandle,\r
-  IN TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN TPMI_RH_HIERARCHY         Hierarchy,\r
-  IN TPMI_YES_NO               State\r
+  IN TPMI_RH_HIERARCHY  AuthHandle,\r
+  IN TPMS_AUTH_COMMAND  *AuthSession,\r
+  IN TPMI_RH_HIERARCHY  Hierarchy,\r
+  IN TPMI_YES_NO        State\r
   )\r
 {\r
   EFI_STATUS                       Status;\r
@@ -722,10 +723,10 @@ Tpm2HierarchyControl (
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag          = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.paramSize    = SwapBytes32(sizeof(Cmd));\r
-  Cmd.Header.commandCode  = SwapBytes32(TPM_CC_HierarchyControl);\r
-  Cmd.AuthHandle          = SwapBytes32(AuthHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.paramSize   = SwapBytes32 (sizeof (Cmd));\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_HierarchyControl);\r
+  Cmd.AuthHandle         = SwapBytes32 (AuthHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -733,21 +734,21 @@ Tpm2HierarchyControl (
   Buffer = (UINT8 *)&Cmd.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer               += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(Hierarchy));\r
-  Buffer += sizeof(UINT32);\r
+  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (Hierarchy));\r
+  Buffer += sizeof (UINT32);\r
 \r
   *(UINT8 *)Buffer = State;\r
   Buffer++;\r
 \r
-  CmdSize = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBuf     = (UINT8 *) &Res;\r
-  ResultBufSize = sizeof(Res);\r
+  ResultBuf     = (UINT8 *)&Res;\r
+  ResultBufSize = sizeof (Res);\r
 \r
   //\r
   // Call the TPM\r
@@ -758,11 +759,11 @@ Tpm2HierarchyControl (
              &ResultBufSize,\r
              ResultBuf\r
              );\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "HierarchyControl: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -771,8 +772,8 @@ Tpm2HierarchyControl (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "HierarchyControl: Response size too large! %d\r\n", RespSize));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -781,8 +782,8 @@ Tpm2HierarchyControl (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG((DEBUG_ERROR,"HierarchyControl: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "HierarchyControl: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -791,7 +792,7 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&Cmd, sizeof(Cmd));\r
-  ZeroMem (&Res, sizeof(Res));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
+  ZeroMem (&Res, sizeof (Res));\r
   return Status;\r
 }\r
index d232fe725daac4cc849486da145d78d8e7516a7f..8dde5f34a27338fa6245f09d4f7799a237c5f4a3 100644 (file)
@@ -16,62 +16,62 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_DH_PCR               PcrHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSessionPcr;\r
-  TPML_DIGEST_VALUES        DigestValues;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_DH_PCR            PcrHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSessionPcr;\r
+  TPML_DIGEST_VALUES     DigestValues;\r
 } TPM2_PCR_EXTEND_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPMS_AUTH_RESPONSE         AuthSessionPcr;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPMS_AUTH_RESPONSE      AuthSessionPcr;\r
 } TPM2_PCR_EXTEND_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_DH_PCR               PcrHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSessionPcr;\r
-  TPM2B_EVENT               EventData;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_DH_PCR            PcrHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSessionPcr;\r
+  TPM2B_EVENT            EventData;\r
 } TPM2_PCR_EVENT_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPML_DIGEST_VALUES         Digests;\r
-  TPMS_AUTH_RESPONSE         AuthSessionPcr;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPML_DIGEST_VALUES      Digests;\r
+  TPMS_AUTH_RESPONSE      AuthSessionPcr;\r
 } TPM2_PCR_EVENT_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPML_PCR_SELECTION        PcrSelectionIn;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPML_PCR_SELECTION     PcrSelectionIn;\r
 } TPM2_PCR_READ_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
-  UINT32                    PcrUpdateCounter;\r
-  TPML_PCR_SELECTION        PcrSelectionOut;\r
-  TPML_DIGEST               PcrValues;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  PcrUpdateCounter;\r
+  TPML_PCR_SELECTION      PcrSelectionOut;\r
+  TPML_DIGEST             PcrValues;\r
 } TPM2_PCR_READ_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_PLATFORM          AuthHandle;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
-  TPML_PCR_SELECTION        PcrAllocation;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_PLATFORM       AuthHandle;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
+  TPML_PCR_SELECTION     PcrAllocation;\r
 } TPM2_PCR_ALLOCATE_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMI_YES_NO                AllocationSuccess;\r
-  UINT32                     MaxPCR;\r
-  UINT32                     SizeNeeded;\r
-  UINT32                     SizeAvailable;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMI_YES_NO             AllocationSuccess;\r
+  UINT32                  MaxPCR;\r
+  UINT32                  SizeNeeded;\r
+  UINT32                  SizeAvailable;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_PCR_ALLOCATE_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -90,25 +90,24 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrExtend (\r
-  IN      TPMI_DH_PCR               PcrHandle,\r
-  IN      TPML_DIGEST_VALUES        *Digests\r
+  IN      TPMI_DH_PCR         PcrHandle,\r
+  IN      TPML_DIGEST_VALUES  *Digests\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_PCR_EXTEND_COMMAND           Cmd;\r
-  TPM2_PCR_EXTEND_RESPONSE          Res;\r
-  UINT32                            CmdSize;\r
-  UINT32                            RespSize;\r
-  UINT32                            ResultBufSize;\r
-  UINT8                             *Buffer;\r
-  UINTN                             Index;\r
-  UINT32                            SessionInfoSize;\r
-  UINT16                            DigestSize;\r
-\r
-  Cmd.Header.tag         = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_PCR_Extend);\r
-  Cmd.PcrHandle          = SwapBytes32(PcrHandle);\r
+  EFI_STATUS                Status;\r
+  TPM2_PCR_EXTEND_COMMAND   Cmd;\r
+  TPM2_PCR_EXTEND_RESPONSE  Res;\r
+  UINT32                    CmdSize;\r
+  UINT32                    RespSize;\r
+  UINT32                    ResultBufSize;\r
+  UINT8                     *Buffer;\r
+  UINTN                     Index;\r
+  UINT32                    SessionInfoSize;\r
+  UINT16                    DigestSize;\r
 \r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_PCR_Extend);\r
+  Cmd.PcrHandle          = SwapBytes32 (PcrHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -116,24 +115,25 @@ Tpm2PcrExtend (
   Buffer = (UINT8 *)&Cmd.AuthSessionPcr;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (NULL, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (NULL, Buffer);\r
+  Buffer               += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  //Digest Count\r
-  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(Digests->count));\r
-  Buffer += sizeof(UINT32);\r
+  // Digest Count\r
+  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (Digests->count));\r
+  Buffer += sizeof (UINT32);\r
 \r
-  //Digest\r
+  // Digest\r
   for (Index = 0; Index < Digests->count; Index++) {\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(Digests->digests[Index].hashAlg));\r
-    Buffer += sizeof(UINT16);\r
+    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Digests->digests[Index].hashAlg));\r
+    Buffer    += sizeof (UINT16);\r
     DigestSize = GetHashSizeFromAlgo (Digests->digests[Index].hashAlg);\r
     if (DigestSize == 0) {\r
       DEBUG ((DEBUG_ERROR, "Unknown hash algorithm %d\r\n", Digests->digests[Index].hashAlg));\r
       return EFI_DEVICE_ERROR;\r
     }\r
-    CopyMem(\r
+\r
+    CopyMem (\r
       Buffer,\r
       &Digests->digests[Index].digest,\r
       DigestSize\r
@@ -142,15 +142,15 @@ Tpm2PcrExtend (
   }\r
 \r
   CmdSize              = (UINT32)((UINTN)Buffer - (UINTN)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrExtend: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -158,8 +158,8 @@ Tpm2PcrExtend (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrExtend: Response size too large! %d\r\n", RespSize));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -167,8 +167,8 @@ Tpm2PcrExtend (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2PcrExtend: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2PcrExtend: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -199,25 +199,25 @@ Tpm2PcrExtend (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrEvent (\r
-  IN      TPMI_DH_PCR               PcrHandle,\r
-  IN      TPM2B_EVENT               *EventData,\r
-     OUT  TPML_DIGEST_VALUES        *Digests\r
+  IN      TPMI_DH_PCR      PcrHandle,\r
+  IN      TPM2B_EVENT      *EventData,\r
+  OUT  TPML_DIGEST_VALUES  *Digests\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_PCR_EVENT_COMMAND            Cmd;\r
-  TPM2_PCR_EVENT_RESPONSE           Res;\r
-  UINT32                            CmdSize;\r
-  UINT32                            RespSize;\r
-  UINT32                            ResultBufSize;\r
-  UINT8                             *Buffer;\r
-  UINTN                             Index;\r
-  UINT32                            SessionInfoSize;\r
-  UINT16                            DigestSize;\r
-\r
-  Cmd.Header.tag         = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_PCR_Event);\r
-  Cmd.PcrHandle          = SwapBytes32(PcrHandle);\r
+  EFI_STATUS               Status;\r
+  TPM2_PCR_EVENT_COMMAND   Cmd;\r
+  TPM2_PCR_EVENT_RESPONSE  Res;\r
+  UINT32                   CmdSize;\r
+  UINT32                   RespSize;\r
+  UINT32                   ResultBufSize;\r
+  UINT8                    *Buffer;\r
+  UINTN                    Index;\r
+  UINT32                   SessionInfoSize;\r
+  UINT16                   DigestSize;\r
+\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_PCR_Event);\r
+  Cmd.PcrHandle          = SwapBytes32 (PcrHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -225,27 +225,27 @@ Tpm2PcrEvent (
   Buffer = (UINT8 *)&Cmd.AuthSessionPcr;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (NULL, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (NULL, Buffer);\r
+  Buffer               += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
   // Event\r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(EventData->size));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (EventData->size));\r
+  Buffer += sizeof (UINT16);\r
 \r
   CopyMem (Buffer, EventData->buffer, EventData->size);\r
   Buffer += EventData->size;\r
 \r
   CmdSize              = (UINT32)((UINTN)Buffer - (UINTN)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrEvent: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -253,8 +253,8 @@ Tpm2PcrEvent (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrEvent: Response size too large! %d\r\n", RespSize));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -262,8 +262,8 @@ Tpm2PcrEvent (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2PcrEvent: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2PcrEvent: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -278,16 +278,17 @@ Tpm2PcrEvent (
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  Buffer += sizeof(UINT32);\r
+  Buffer += sizeof (UINT32);\r
   for (Index = 0; Index < Digests->count; Index++) {\r
     Digests->digests[Index].hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    DigestSize = GetHashSizeFromAlgo (Digests->digests[Index].hashAlg);\r
+    Buffer                         += sizeof (UINT16);\r
+    DigestSize                      = GetHashSizeFromAlgo (Digests->digests[Index].hashAlg);\r
     if (DigestSize == 0) {\r
       DEBUG ((DEBUG_ERROR, "Unknown hash algorithm %d\r\n", Digests->digests[Index].hashAlg));\r
       return EFI_DEVICE_ERROR;\r
     }\r
-    CopyMem(\r
+\r
+    CopyMem (\r
       &Digests->digests[Index].digest,\r
       Buffer,\r
       DigestSize\r
@@ -312,42 +313,42 @@ Tpm2PcrEvent (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrRead (\r
-  IN      TPML_PCR_SELECTION        *PcrSelectionIn,\r
-     OUT  UINT32                    *PcrUpdateCounter,\r
-     OUT  TPML_PCR_SELECTION        *PcrSelectionOut,\r
-     OUT  TPML_DIGEST               *PcrValues\r
+  IN      TPML_PCR_SELECTION  *PcrSelectionIn,\r
+  OUT  UINT32                 *PcrUpdateCounter,\r
+  OUT  TPML_PCR_SELECTION     *PcrSelectionOut,\r
+  OUT  TPML_DIGEST            *PcrValues\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_PCR_READ_COMMAND             SendBuffer;\r
-  TPM2_PCR_READ_RESPONSE            RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINTN                             Index;\r
-  TPML_DIGEST                       *PcrValuesOut;\r
-  TPM2B_DIGEST                      *Digests;\r
+  EFI_STATUS              Status;\r
+  TPM2_PCR_READ_COMMAND   SendBuffer;\r
+  TPM2_PCR_READ_RESPONSE  RecvBuffer;\r
+  UINT32                  SendBufferSize;\r
+  UINT32                  RecvBufferSize;\r
+  UINTN                   Index;\r
+  TPML_DIGEST             *PcrValuesOut;\r
+  TPM2B_DIGEST            *Digests;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_PCR_Read);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_PCR_Read);\r
 \r
-  SendBuffer.PcrSelectionIn.count = SwapBytes32(PcrSelectionIn->count);\r
+  SendBuffer.PcrSelectionIn.count = SwapBytes32 (PcrSelectionIn->count);\r
   for (Index = 0; Index < PcrSelectionIn->count; Index++) {\r
-    SendBuffer.PcrSelectionIn.pcrSelections[Index].hash = SwapBytes16(PcrSelectionIn->pcrSelections[Index].hash);\r
+    SendBuffer.PcrSelectionIn.pcrSelections[Index].hash         = SwapBytes16 (PcrSelectionIn->pcrSelections[Index].hash);\r
     SendBuffer.PcrSelectionIn.pcrSelections[Index].sizeofSelect = PcrSelectionIn->pcrSelections[Index].sizeofSelect;\r
     CopyMem (&SendBuffer.PcrSelectionIn.pcrSelections[Index].pcrSelect, &PcrSelectionIn->pcrSelections[Index].pcrSelect, SendBuffer.PcrSelectionIn.pcrSelections[Index].sizeofSelect);\r
   }\r
 \r
-  SendBufferSize = sizeof(SendBuffer.Header) + sizeof(SendBuffer.PcrSelectionIn.count) + sizeof(SendBuffer.PcrSelectionIn.pcrSelections[0]) * PcrSelectionIn->count;\r
+  SendBufferSize              = sizeof (SendBuffer.Header) + sizeof (SendBuffer.PcrSelectionIn.count) + sizeof (SendBuffer.PcrSelectionIn.pcrSelections[0]) * PcrSelectionIn->count;\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -356,8 +357,9 @@ Tpm2PcrRead (
     DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     return EFI_NOT_FOUND;\r
   }\r
 \r
@@ -368,43 +370,47 @@ Tpm2PcrRead (
   //\r
   // PcrUpdateCounter\r
   //\r
-  if (RecvBufferSize < sizeof (TPM2_RESPONSE_HEADER) + sizeof(RecvBuffer.PcrUpdateCounter)) {\r
+  if (RecvBufferSize < sizeof (TPM2_RESPONSE_HEADER) + sizeof (RecvBuffer.PcrUpdateCounter)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  *PcrUpdateCounter = SwapBytes32(RecvBuffer.PcrUpdateCounter);\r
+\r
+  *PcrUpdateCounter = SwapBytes32 (RecvBuffer.PcrUpdateCounter);\r
 \r
   //\r
   // PcrSelectionOut\r
   //\r
-  if (RecvBufferSize < sizeof (TPM2_RESPONSE_HEADER) + sizeof(RecvBuffer.PcrUpdateCounter) + sizeof(RecvBuffer.PcrSelectionOut.count)) {\r
+  if (RecvBufferSize < sizeof (TPM2_RESPONSE_HEADER) + sizeof (RecvBuffer.PcrUpdateCounter) + sizeof (RecvBuffer.PcrSelectionOut.count)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  PcrSelectionOut->count = SwapBytes32(RecvBuffer.PcrSelectionOut.count);\r
+\r
+  PcrSelectionOut->count = SwapBytes32 (RecvBuffer.PcrSelectionOut.count);\r
   if (PcrSelectionOut->count > HASH_COUNT) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - PcrSelectionOut->count error %x\n", PcrSelectionOut->count));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  if (RecvBufferSize < sizeof (TPM2_RESPONSE_HEADER) + sizeof(RecvBuffer.PcrUpdateCounter) + sizeof(RecvBuffer.PcrSelectionOut.count) + sizeof(RecvBuffer.PcrSelectionOut.pcrSelections[0]) * PcrSelectionOut->count) {\r
+  if (RecvBufferSize < sizeof (TPM2_RESPONSE_HEADER) + sizeof (RecvBuffer.PcrUpdateCounter) + sizeof (RecvBuffer.PcrSelectionOut.count) + sizeof (RecvBuffer.PcrSelectionOut.pcrSelections[0]) * PcrSelectionOut->count) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   for (Index = 0; Index < PcrSelectionOut->count; Index++) {\r
-    PcrSelectionOut->pcrSelections[Index].hash = SwapBytes16(RecvBuffer.PcrSelectionOut.pcrSelections[Index].hash);\r
+    PcrSelectionOut->pcrSelections[Index].hash         = SwapBytes16 (RecvBuffer.PcrSelectionOut.pcrSelections[Index].hash);\r
     PcrSelectionOut->pcrSelections[Index].sizeofSelect = RecvBuffer.PcrSelectionOut.pcrSelections[Index].sizeofSelect;\r
     if (PcrSelectionOut->pcrSelections[Index].sizeofSelect > PCR_SELECT_MAX) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
+\r
     CopyMem (&PcrSelectionOut->pcrSelections[Index].pcrSelect, &RecvBuffer.PcrSelectionOut.pcrSelections[Index].pcrSelect, PcrSelectionOut->pcrSelections[Index].sizeofSelect);\r
   }\r
 \r
   //\r
   // PcrValues\r
   //\r
-  PcrValuesOut = (TPML_DIGEST *)((UINT8 *)&RecvBuffer + sizeof (TPM2_RESPONSE_HEADER) + sizeof(RecvBuffer.PcrUpdateCounter) + sizeof(RecvBuffer.PcrSelectionOut.count) + sizeof(RecvBuffer.PcrSelectionOut.pcrSelections[0]) * PcrSelectionOut->count);\r
-  PcrValues->count = SwapBytes32(PcrValuesOut->count);\r
+  PcrValuesOut     = (TPML_DIGEST *)((UINT8 *)&RecvBuffer + sizeof (TPM2_RESPONSE_HEADER) + sizeof (RecvBuffer.PcrUpdateCounter) + sizeof (RecvBuffer.PcrSelectionOut.count) + sizeof (RecvBuffer.PcrSelectionOut.pcrSelections[0]) * PcrSelectionOut->count);\r
+  PcrValues->count = SwapBytes32 (PcrValuesOut->count);\r
   //\r
   // The number of digests in list is not greater than 8 per TPML_DIGEST definition\r
   //\r
@@ -412,15 +418,17 @@ Tpm2PcrRead (
     DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - PcrValues->count error %x\n", PcrValues->count));\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   Digests = PcrValuesOut->digests;\r
   for (Index = 0; Index < PcrValues->count; Index++) {\r
-    PcrValues->digests[Index].size = SwapBytes16(Digests->size);\r
-    if (PcrValues->digests[Index].size > sizeof(TPMU_HA)) {\r
+    PcrValues->digests[Index].size = SwapBytes16 (Digests->size);\r
+    if (PcrValues->digests[Index].size > sizeof (TPMU_HA)) {\r
       DEBUG ((DEBUG_ERROR, "Tpm2PcrRead - Digest.size error %x\n", PcrValues->digests[Index].size));\r
       return EFI_DEVICE_ERROR;\r
     }\r
+\r
     CopyMem (&PcrValues->digests[Index].buffer, &Digests->buffer, PcrValues->digests[Index].size);\r
-    Digests = (TPM2B_DIGEST *)((UINT8 *)Digests + sizeof(Digests->size) + PcrValues->digests[Index].size);\r
+    Digests = (TPM2B_DIGEST *)((UINT8 *)Digests + sizeof (Digests->size) + PcrValues->digests[Index].size);\r
   }\r
 \r
   return EFI_SUCCESS;\r
@@ -443,13 +451,13 @@ Tpm2PcrRead (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrAllocate (\r
-  IN  TPMI_RH_PLATFORM          AuthHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN  TPML_PCR_SELECTION        *PcrAllocation,\r
-  OUT TPMI_YES_NO               *AllocationSuccess,\r
-  OUT UINT32                    *MaxPCR,\r
-  OUT UINT32                    *SizeNeeded,\r
-  OUT UINT32                    *SizeAvailable\r
+  IN  TPMI_RH_PLATFORM    AuthHandle,\r
+  IN  TPMS_AUTH_COMMAND   *AuthSession,\r
+  IN  TPML_PCR_SELECTION  *PcrAllocation,\r
+  OUT TPMI_YES_NO         *AllocationSuccess,\r
+  OUT UINT32              *MaxPCR,\r
+  OUT UINT32              *SizeNeeded,\r
+  OUT UINT32              *SizeAvailable\r
   )\r
 {\r
   EFI_STATUS                  Status;\r
@@ -466,10 +474,10 @@ Tpm2PcrAllocate (
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag          = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.paramSize    = SwapBytes32(sizeof(Cmd));\r
-  Cmd.Header.commandCode  = SwapBytes32(TPM_CC_PCR_Allocate);\r
-  Cmd.AuthHandle          = SwapBytes32(AuthHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.paramSize   = SwapBytes32 (sizeof (Cmd));\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_PCR_Allocate);\r
+  Cmd.AuthHandle         = SwapBytes32 (AuthHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -477,27 +485,27 @@ Tpm2PcrAllocate (
   Buffer = (UINT8 *)&Cmd.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  Cmd.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize     = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer             += SessionInfoSize;\r
+  Cmd.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
   // Count\r
-  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(PcrAllocation->count));\r
-  Buffer += sizeof(UINT32);\r
+  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (PcrAllocation->count));\r
+  Buffer += sizeof (UINT32);\r
   for (Index = 0; Index < PcrAllocation->count; Index++) {\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(PcrAllocation->pcrSelections[Index].hash));\r
-    Buffer += sizeof(UINT16);\r
+    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (PcrAllocation->pcrSelections[Index].hash));\r
+    Buffer          += sizeof (UINT16);\r
     *(UINT8 *)Buffer = PcrAllocation->pcrSelections[Index].sizeofSelect;\r
     Buffer++;\r
     CopyMem (Buffer, PcrAllocation->pcrSelections[Index].pcrSelect, PcrAllocation->pcrSelections[Index].sizeofSelect);\r
     Buffer += PcrAllocation->pcrSelections[Index].sizeofSelect;\r
   }\r
 \r
-  CmdSize = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
-  ResultBuf     = (UINT8 *) &Res;\r
-  ResultBufSize = sizeof(Res);\r
+  ResultBuf     = (UINT8 *)&Res;\r
+  ResultBufSize = sizeof (Res);\r
 \r
   //\r
   // Call the TPM\r
@@ -508,11 +516,11 @@ Tpm2PcrAllocate (
              &ResultBufSize,\r
              ResultBuf\r
              );\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrAllocate: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -521,8 +529,8 @@ Tpm2PcrAllocate (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2PcrAllocate: Response size too large! %d\r\n", RespSize));\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Done;\r
@@ -531,8 +539,8 @@ Tpm2PcrAllocate (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG((DEBUG_ERROR,"Tpm2PcrAllocate: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2PcrAllocate: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -541,16 +549,16 @@ Tpm2PcrAllocate (
   // Return the response\r
   //\r
   *AllocationSuccess = Res.AllocationSuccess;\r
-  *MaxPCR = SwapBytes32(Res.MaxPCR);\r
-  *SizeNeeded = SwapBytes32(Res.SizeNeeded);\r
-  *SizeAvailable = SwapBytes32(Res.SizeAvailable);\r
+  *MaxPCR            = SwapBytes32 (Res.MaxPCR);\r
+  *SizeNeeded        = SwapBytes32 (Res.SizeNeeded);\r
+  *SizeAvailable     = SwapBytes32 (Res.SizeAvailable);\r
 \r
 Done:\r
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&Cmd, sizeof(Cmd));\r
-  ZeroMem (&Res, sizeof(Res));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
+  ZeroMem (&Res, sizeof (Res));\r
   return Status;\r
 }\r
 \r
@@ -566,36 +574,36 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2PcrAllocateBanks (\r
-  IN TPM2B_AUTH                *PlatformAuth   OPTIONAL,\r
-  IN UINT32                    SupportedPCRBanks,\r
-  IN UINT32                    PCRBanks\r
+  IN TPM2B_AUTH  *PlatformAuth   OPTIONAL,\r
+  IN UINT32      SupportedPCRBanks,\r
+  IN UINT32      PCRBanks\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  TPMS_AUTH_COMMAND         *AuthSession;\r
-  TPMS_AUTH_COMMAND         LocalAuthSession;\r
-  TPML_PCR_SELECTION        PcrAllocation;\r
-  TPMI_YES_NO               AllocationSuccess;\r
-  UINT32                    MaxPCR;\r
-  UINT32                    SizeNeeded;\r
-  UINT32                    SizeAvailable;\r
+  EFI_STATUS          Status;\r
+  TPMS_AUTH_COMMAND   *AuthSession;\r
+  TPMS_AUTH_COMMAND   LocalAuthSession;\r
+  TPML_PCR_SELECTION  PcrAllocation;\r
+  TPMI_YES_NO         AllocationSuccess;\r
+  UINT32              MaxPCR;\r
+  UINT32              SizeNeeded;\r
+  UINT32              SizeAvailable;\r
 \r
   if (PlatformAuth == NULL) {\r
     AuthSession = NULL;\r
   } else {\r
     AuthSession = &LocalAuthSession;\r
-    ZeroMem (&LocalAuthSession, sizeof(LocalAuthSession));\r
+    ZeroMem (&LocalAuthSession, sizeof (LocalAuthSession));\r
     LocalAuthSession.sessionHandle = TPM_RS_PW;\r
-    LocalAuthSession.hmac.size = PlatformAuth->size;\r
+    LocalAuthSession.hmac.size     = PlatformAuth->size;\r
     CopyMem (LocalAuthSession.hmac.buffer, PlatformAuth->buffer, PlatformAuth->size);\r
   }\r
 \r
   //\r
   // Fill input\r
   //\r
-  ZeroMem (&PcrAllocation, sizeof(PcrAllocation));\r
+  ZeroMem (&PcrAllocation, sizeof (PcrAllocation));\r
   if ((HASH_ALG_SHA1 & SupportedPCRBanks) != 0) {\r
-    PcrAllocation.pcrSelections[PcrAllocation.count].hash = TPM_ALG_SHA1;\r
+    PcrAllocation.pcrSelections[PcrAllocation.count].hash         = TPM_ALG_SHA1;\r
     PcrAllocation.pcrSelections[PcrAllocation.count].sizeofSelect = PCR_SELECT_MAX;\r
     if ((HASH_ALG_SHA1 & PCRBanks) != 0) {\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[0] = 0xFF;\r
@@ -606,10 +614,12 @@ Tpm2PcrAllocateBanks (
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[1] = 0x00;\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[2] = 0x00;\r
     }\r
+\r
     PcrAllocation.count++;\r
   }\r
+\r
   if ((HASH_ALG_SHA256 & SupportedPCRBanks) != 0) {\r
-    PcrAllocation.pcrSelections[PcrAllocation.count].hash = TPM_ALG_SHA256;\r
+    PcrAllocation.pcrSelections[PcrAllocation.count].hash         = TPM_ALG_SHA256;\r
     PcrAllocation.pcrSelections[PcrAllocation.count].sizeofSelect = PCR_SELECT_MAX;\r
     if ((HASH_ALG_SHA256 & PCRBanks) != 0) {\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[0] = 0xFF;\r
@@ -620,10 +630,12 @@ Tpm2PcrAllocateBanks (
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[1] = 0x00;\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[2] = 0x00;\r
     }\r
+\r
     PcrAllocation.count++;\r
   }\r
+\r
   if ((HASH_ALG_SHA384 & SupportedPCRBanks) != 0) {\r
-    PcrAllocation.pcrSelections[PcrAllocation.count].hash = TPM_ALG_SHA384;\r
+    PcrAllocation.pcrSelections[PcrAllocation.count].hash         = TPM_ALG_SHA384;\r
     PcrAllocation.pcrSelections[PcrAllocation.count].sizeofSelect = PCR_SELECT_MAX;\r
     if ((HASH_ALG_SHA384 & PCRBanks) != 0) {\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[0] = 0xFF;\r
@@ -634,10 +646,12 @@ Tpm2PcrAllocateBanks (
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[1] = 0x00;\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[2] = 0x00;\r
     }\r
+\r
     PcrAllocation.count++;\r
   }\r
+\r
   if ((HASH_ALG_SHA512 & SupportedPCRBanks) != 0) {\r
-    PcrAllocation.pcrSelections[PcrAllocation.count].hash = TPM_ALG_SHA512;\r
+    PcrAllocation.pcrSelections[PcrAllocation.count].hash         = TPM_ALG_SHA512;\r
     PcrAllocation.pcrSelections[PcrAllocation.count].sizeofSelect = PCR_SELECT_MAX;\r
     if ((HASH_ALG_SHA512 & PCRBanks) != 0) {\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[0] = 0xFF;\r
@@ -648,10 +662,12 @@ Tpm2PcrAllocateBanks (
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[1] = 0x00;\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[2] = 0x00;\r
     }\r
+\r
     PcrAllocation.count++;\r
   }\r
+\r
   if ((HASH_ALG_SM3_256 & SupportedPCRBanks) != 0) {\r
-    PcrAllocation.pcrSelections[PcrAllocation.count].hash = TPM_ALG_SM3_256;\r
+    PcrAllocation.pcrSelections[PcrAllocation.count].hash         = TPM_ALG_SM3_256;\r
     PcrAllocation.pcrSelections[PcrAllocation.count].sizeofSelect = PCR_SELECT_MAX;\r
     if ((HASH_ALG_SM3_256 & PCRBanks) != 0) {\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[0] = 0xFF;\r
@@ -662,8 +678,10 @@ Tpm2PcrAllocateBanks (
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[1] = 0x00;\r
       PcrAllocation.pcrSelections[PcrAllocation.count].pcrSelect[2] = 0x00;\r
     }\r
+\r
     PcrAllocation.count++;\r
   }\r
+\r
   Status = Tpm2PcrAllocate (\r
              TPM_RH_PLATFORM,\r
              AuthSession,\r
@@ -684,6 +702,6 @@ Tpm2PcrAllocateBanks (
   DEBUG ((DEBUG_INFO, "SizeAvailable     - %08x\n", SizeAvailable));\r
 \r
 Done:\r
-  ZeroMem(&LocalAuthSession.hmac, sizeof(LocalAuthSession.hmac));\r
+  ZeroMem (&LocalAuthSession.hmac, sizeof (LocalAuthSession.hmac));\r
   return Status;\r
 }\r
index 1afc562998cc095f3d3fb5c66358bc0580bcf5b9..6f6ac1e2d075fff66fecd9342bae66c7e4bfb888 100644 (file)
@@ -24,9 +24,9 @@ typedef struct {
 } TPM2_SET_ALGORITHM_SET_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_SET_ALGORITHM_SET_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -46,24 +46,24 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SetAlgorithmSet (\r
-  IN  TPMI_RH_PLATFORM          AuthHandle,\r
-  IN  TPMS_AUTH_COMMAND         *AuthSession,\r
-  IN  UINT32                    AlgorithmSet\r
+  IN  TPMI_RH_PLATFORM   AuthHandle,\r
+  IN  TPMS_AUTH_COMMAND  *AuthSession,\r
+  IN  UINT32             AlgorithmSet\r
   )\r
 {\r
-  EFI_STATUS                                 Status;\r
-  TPM2_SET_ALGORITHM_SET_COMMAND             SendBuffer;\r
-  TPM2_SET_ALGORITHM_SET_RESPONSE            RecvBuffer;\r
-  UINT32                                     SendBufferSize;\r
-  UINT32                                     RecvBufferSize;\r
-  UINT8                                      *Buffer;\r
-  UINT32                                     SessionInfoSize;\r
+  EFI_STATUS                       Status;\r
+  TPM2_SET_ALGORITHM_SET_COMMAND   SendBuffer;\r
+  TPM2_SET_ALGORITHM_SET_RESPONSE  RecvBuffer;\r
+  UINT32                           SendBufferSize;\r
+  UINT32                           RecvBufferSize;\r
+  UINT8                            *Buffer;\r
+  UINT32                           SessionInfoSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_SetAlgorithmSet);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_SetAlgorithmSet);\r
 \r
   SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
 \r
@@ -73,24 +73,24 @@ Tpm2SetAlgorithmSet (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
   //\r
   // Real data\r
   //\r
-  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32(AlgorithmSet));\r
-  Buffer += sizeof(UINT32);\r
+  WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (AlgorithmSet));\r
+  Buffer += sizeof (UINT32);\r
 \r
-  SendBufferSize = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
+  SendBufferSize              = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -100,8 +100,9 @@ Tpm2SetAlgorithmSet (
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2SetAlgorithmSet - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2SetAlgorithmSet - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
@@ -110,7 +111,7 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
index d9171fb9a01803b0a26ca7812926b139883c580c..5077ace7c2c402a3b046882c51099598d7f536e1 100644 (file)
@@ -15,137 +15,137 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #pragma pack(1)\r
 \r
-#define RC_NV_ReadPublic_nvIndex            (TPM_RC_H + TPM_RC_1)\r
+#define RC_NV_ReadPublic_nvIndex  (TPM_RC_H + TPM_RC_1)\r
 \r
-#define RC_NV_DefineSpace_authHandle        (TPM_RC_H + TPM_RC_1)\r
-#define RC_NV_DefineSpace_auth              (TPM_RC_P + TPM_RC_1)\r
-#define RC_NV_DefineSpace_publicInfo        (TPM_RC_P + TPM_RC_2)\r
+#define RC_NV_DefineSpace_authHandle  (TPM_RC_H + TPM_RC_1)\r
+#define RC_NV_DefineSpace_auth        (TPM_RC_P + TPM_RC_1)\r
+#define RC_NV_DefineSpace_publicInfo  (TPM_RC_P + TPM_RC_2)\r
 \r
-#define RC_NV_UndefineSpace_authHandle      (TPM_RC_H + TPM_RC_1)\r
-#define RC_NV_UndefineSpace_nvIndex         (TPM_RC_H + TPM_RC_2)\r
+#define RC_NV_UndefineSpace_authHandle  (TPM_RC_H + TPM_RC_1)\r
+#define RC_NV_UndefineSpace_nvIndex     (TPM_RC_H + TPM_RC_2)\r
 \r
-#define RC_NV_Read_authHandle               (TPM_RC_H + TPM_RC_1)\r
-#define RC_NV_Read_nvIndex                  (TPM_RC_H + TPM_RC_2)\r
-#define RC_NV_Read_size                     (TPM_RC_P + TPM_RC_1)\r
-#define RC_NV_Read_offset                   (TPM_RC_P + TPM_RC_2)\r
+#define RC_NV_Read_authHandle  (TPM_RC_H + TPM_RC_1)\r
+#define RC_NV_Read_nvIndex     (TPM_RC_H + TPM_RC_2)\r
+#define RC_NV_Read_size        (TPM_RC_P + TPM_RC_1)\r
+#define RC_NV_Read_offset      (TPM_RC_P + TPM_RC_2)\r
 \r
-#define RC_NV_Write_authHandle              (TPM_RC_H + TPM_RC_1)\r
-#define RC_NV_Write_nvIndex                 (TPM_RC_H + TPM_RC_2)\r
-#define RC_NV_Write_data                    (TPM_RC_P + TPM_RC_1)\r
-#define RC_NV_Write_offset                  (TPM_RC_P + TPM_RC_2)\r
+#define RC_NV_Write_authHandle  (TPM_RC_H + TPM_RC_1)\r
+#define RC_NV_Write_nvIndex     (TPM_RC_H + TPM_RC_2)\r
+#define RC_NV_Write_data        (TPM_RC_P + TPM_RC_1)\r
+#define RC_NV_Write_offset      (TPM_RC_P + TPM_RC_2)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_NV_INDEX          NvIndex;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_NV_INDEX       NvIndex;\r
 } TPM2_NV_READPUBLIC_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
-  TPM2B_NV_PUBLIC           NvPublic;\r
-  TPM2B_NAME                NvName;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  TPM2B_NV_PUBLIC         NvPublic;\r
+  TPM2B_NAME              NvName;\r
 } TPM2_NV_READPUBLIC_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_PROVISION         AuthHandle;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
-  TPM2B_AUTH                Auth;\r
-  TPM2B_NV_PUBLIC           NvPublic;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_PROVISION      AuthHandle;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
+  TPM2B_AUTH             Auth;\r
+  TPM2B_NV_PUBLIC        NvPublic;\r
 } TPM2_NV_DEFINESPACE_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_NV_DEFINESPACE_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_PROVISION         AuthHandle;\r
-  TPMI_RH_NV_INDEX          NvIndex;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_PROVISION      AuthHandle;\r
+  TPMI_RH_NV_INDEX       NvIndex;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
 } TPM2_NV_UNDEFINESPACE_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_NV_UNDEFINESPACE_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_NV_AUTH           AuthHandle;\r
-  TPMI_RH_NV_INDEX          NvIndex;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
-  UINT16                    Size;\r
-  UINT16                    Offset;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_NV_AUTH        AuthHandle;\r
+  TPMI_RH_NV_INDEX       NvIndex;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
+  UINT16                 Size;\r
+  UINT16                 Offset;\r
 } TPM2_NV_READ_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPM2B_MAX_BUFFER           Data;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPM2B_MAX_BUFFER        Data;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_NV_READ_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_NV_AUTH           AuthHandle;\r
-  TPMI_RH_NV_INDEX          NvIndex;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
-  TPM2B_MAX_BUFFER          Data;\r
-  UINT16                    Offset;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_NV_AUTH        AuthHandle;\r
+  TPMI_RH_NV_INDEX       NvIndex;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
+  TPM2B_MAX_BUFFER       Data;\r
+  UINT16                 Offset;\r
 } TPM2_NV_WRITE_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_NV_WRITE_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_NV_AUTH           AuthHandle;\r
-  TPMI_RH_NV_INDEX          NvIndex;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_NV_AUTH        AuthHandle;\r
+  TPMI_RH_NV_INDEX       NvIndex;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
 } TPM2_NV_READLOCK_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_NV_READLOCK_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_NV_AUTH           AuthHandle;\r
-  TPMI_RH_NV_INDEX          NvIndex;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_NV_AUTH        AuthHandle;\r
+  TPMI_RH_NV_INDEX       NvIndex;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
 } TPM2_NV_WRITELOCK_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_NV_WRITELOCK_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_RH_PROVISION         AuthHandle;\r
-  UINT32                    AuthSessionSize;\r
-  TPMS_AUTH_COMMAND         AuthSession;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_RH_PROVISION      AuthHandle;\r
+  UINT32                 AuthSessionSize;\r
+  TPMS_AUTH_COMMAND      AuthSession;\r
 } TPM2_NV_GLOBALWRITELOCK_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     AuthSessionSize;\r
-  TPMS_AUTH_RESPONSE         AuthSession;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  AuthSessionSize;\r
+  TPMS_AUTH_RESPONSE      AuthSession;\r
 } TPM2_NV_GLOBALWRITELOCK_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -164,37 +164,37 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvReadPublic (\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  OUT     TPM2B_NV_PUBLIC           *NvPublic,\r
-  OUT     TPM2B_NAME                *NvName\r
+  IN      TPMI_RH_NV_INDEX  NvIndex,\r
+  OUT     TPM2B_NV_PUBLIC   *NvPublic,\r
+  OUT     TPM2B_NAME        *NvName\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_NV_READPUBLIC_COMMAND        SendBuffer;\r
-  TPM2_NV_READPUBLIC_RESPONSE       RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT16                            NvPublicSize;\r
-  UINT16                            NvNameSize;\r
-  UINT8                             *Buffer;\r
-  TPM_RC                            ResponseCode;\r
+  EFI_STATUS                   Status;\r
+  TPM2_NV_READPUBLIC_COMMAND   SendBuffer;\r
+  TPM2_NV_READPUBLIC_RESPONSE  RecvBuffer;\r
+  UINT32                       SendBufferSize;\r
+  UINT32                       RecvBufferSize;\r
+  UINT16                       NvPublicSize;\r
+  UINT16                       NvNameSize;\r
+  UINT8                        *Buffer;\r
+  TPM_RC                       ResponseCode;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_NV_ReadPublic);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_NV_ReadPublic);\r
 \r
   SendBuffer.NvIndex = SwapBytes32 (NvIndex);\r
 \r
-  SendBufferSize = (UINT32) sizeof (SendBuffer);\r
+  SendBufferSize              = (UINT32)sizeof (SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -203,23 +203,25 @@ Tpm2NvReadPublic (
     DEBUG ((DEBUG_ERROR, "Tpm2NvReadPublic - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2NvReadPublic - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+    DEBUG ((DEBUG_ERROR, "Tpm2NvReadPublic - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  case TPM_RC_HANDLE + RC_NV_ReadPublic_nvIndex: // TPM_RC_NV_DEFINED:\r
-    return EFI_NOT_FOUND;\r
-  case TPM_RC_VALUE + RC_NV_ReadPublic_nvIndex:\r
-    return EFI_INVALID_PARAMETER;\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    case TPM_RC_HANDLE + RC_NV_ReadPublic_nvIndex: // TPM_RC_NV_DEFINED:\r
+      return EFI_NOT_FOUND;\r
+    case TPM_RC_VALUE + RC_NV_ReadPublic_nvIndex:\r
+      return EFI_INVALID_PARAMETER;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  if (RecvBufferSize <= sizeof (TPM2_RESPONSE_HEADER) + sizeof (UINT16) + sizeof(UINT16)) {\r
+  if (RecvBufferSize <= sizeof (TPM2_RESPONSE_HEADER) + sizeof (UINT16) + sizeof (UINT16)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2NvReadPublic - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_NOT_FOUND;\r
   }\r
@@ -228,18 +230,18 @@ Tpm2NvReadPublic (
   // Basic check\r
   //\r
   NvPublicSize = SwapBytes16 (RecvBuffer.NvPublic.size);\r
-  if (NvPublicSize > sizeof(TPMS_NV_PUBLIC)) {\r
+  if (NvPublicSize > sizeof (TPMS_NV_PUBLIC)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2NvReadPublic - NvPublic.size error %x\n", NvPublicSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  NvNameSize = SwapBytes16 (ReadUnaligned16 ((UINT16 *)((UINT8 *)&RecvBuffer + sizeof(TPM2_RESPONSE_HEADER) + sizeof(UINT16) + NvPublicSize)));\r
-  if (NvNameSize > sizeof(TPMU_NAME)){\r
+  NvNameSize = SwapBytes16 (ReadUnaligned16 ((UINT16 *)((UINT8 *)&RecvBuffer + sizeof (TPM2_RESPONSE_HEADER) + sizeof (UINT16) + NvPublicSize)));\r
+  if (NvNameSize > sizeof (TPMU_NAME)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2NvReadPublic - NvNameSize error %x\n", NvNameSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  if (RecvBufferSize != sizeof(TPM2_RESPONSE_HEADER) + sizeof(UINT16) + NvPublicSize + sizeof(UINT16) + NvNameSize) {\r
+  if (RecvBufferSize != sizeof (TPM2_RESPONSE_HEADER) + sizeof (UINT16) + NvPublicSize + sizeof (UINT16) + NvNameSize) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2NvReadPublic - RecvBufferSize Error - NvPublicSize %x\n", RecvBufferSize));\r
     return EFI_NOT_FOUND;\r
   }\r
@@ -247,17 +249,17 @@ Tpm2NvReadPublic (
   //\r
   // Return the response\r
   //\r
-  CopyMem (NvPublic, &RecvBuffer.NvPublic, sizeof(UINT16) + NvPublicSize);\r
-  NvPublic->size = NvPublicSize;\r
+  CopyMem (NvPublic, &RecvBuffer.NvPublic, sizeof (UINT16) + NvPublicSize);\r
+  NvPublic->size             = NvPublicSize;\r
   NvPublic->nvPublic.nvIndex = SwapBytes32 (NvPublic->nvPublic.nvIndex);\r
   NvPublic->nvPublic.nameAlg = SwapBytes16 (NvPublic->nvPublic.nameAlg);\r
   WriteUnaligned32 ((UINT32 *)&NvPublic->nvPublic.attributes, SwapBytes32 (ReadUnaligned32 ((UINT32 *)&NvPublic->nvPublic.attributes)));\r
   NvPublic->nvPublic.authPolicy.size = SwapBytes16 (NvPublic->nvPublic.authPolicy.size);\r
-  Buffer = (UINT8 *)&RecvBuffer.NvPublic.nvPublic.authPolicy;\r
-  Buffer += sizeof(UINT16) + NvPublic->nvPublic.authPolicy.size;\r
-  NvPublic->nvPublic.dataSize = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+  Buffer                             = (UINT8 *)&RecvBuffer.NvPublic.nvPublic.authPolicy;\r
+  Buffer                            += sizeof (UINT16) + NvPublic->nvPublic.authPolicy.size;\r
+  NvPublic->nvPublic.dataSize        = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
 \r
-  CopyMem (NvName->name, (UINT8 *)&RecvBuffer + sizeof(TPM2_RESPONSE_HEADER) + sizeof(UINT16) + NvPublicSize + sizeof(UINT16), NvNameSize);\r
+  CopyMem (NvName->name, (UINT8 *)&RecvBuffer + sizeof (TPM2_RESPONSE_HEADER) + sizeof (UINT16) + NvPublicSize + sizeof (UINT16), NvNameSize);\r
   NvName->size = NvNameSize;\r
 \r
   return EFI_SUCCESS;\r
@@ -280,28 +282,28 @@ Tpm2NvReadPublic (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvDefineSpace (\r
-  IN      TPMI_RH_PROVISION         AuthHandle,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN      TPM2B_AUTH                *Auth,\r
-  IN      TPM2B_NV_PUBLIC           *NvPublic\r
+  IN      TPMI_RH_PROVISION  AuthHandle,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN      TPM2B_AUTH         *Auth,\r
+  IN      TPM2B_NV_PUBLIC    *NvPublic\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_NV_DEFINESPACE_COMMAND       SendBuffer;\r
-  TPM2_NV_DEFINESPACE_RESPONSE      RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT16                            NvPublicSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
-  TPM_RC                            ResponseCode;\r
+  EFI_STATUS                    Status;\r
+  TPM2_NV_DEFINESPACE_COMMAND   SendBuffer;\r
+  TPM2_NV_DEFINESPACE_RESPONSE  RecvBuffer;\r
+  UINT32                        SendBufferSize;\r
+  UINT32                        RecvBufferSize;\r
+  UINT16                        NvPublicSize;\r
+  UINT8                         *Buffer;\r
+  UINT32                        SessionInfoSize;\r
+  TPM_RC                        ResponseCode;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_NV_DefineSpace);\r
-  SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_NV_DefineSpace);\r
+  SendBuffer.AuthHandle         = SwapBytes32 (AuthHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -309,16 +311,16 @@ Tpm2NvDefineSpace (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
   //\r
   // IndexAuth\r
   //\r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(Auth->size));\r
-  Buffer += sizeof(UINT16);\r
-  CopyMem(Buffer, Auth->buffer, Auth->size);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Auth->size));\r
+  Buffer += sizeof (UINT16);\r
+  CopyMem (Buffer, Auth->buffer, Auth->size);\r
   Buffer += Auth->size;\r
 \r
   //\r
@@ -327,28 +329,28 @@ Tpm2NvDefineSpace (
   NvPublicSize = NvPublic->size;\r
 \r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (NvPublicSize));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (NvPublic->nvPublic.nvIndex));\r
-  Buffer += sizeof(UINT32);\r
+  Buffer += sizeof (UINT32);\r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (NvPublic->nvPublic.nameAlg));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   WriteUnaligned32 ((UINT32 *)Buffer, SwapBytes32 (ReadUnaligned32 ((UINT32 *)&NvPublic->nvPublic.attributes)));\r
-  Buffer += sizeof(UINT32);\r
+  Buffer += sizeof (UINT32);\r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (NvPublic->nvPublic.authPolicy.size));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Buffer, NvPublic->nvPublic.authPolicy.buffer, NvPublic->nvPublic.authPolicy.size);\r
   Buffer += NvPublic->nvPublic.authPolicy.size;\r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (NvPublic->nvPublic.dataSize));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
 \r
-  SendBufferSize = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
+  SendBufferSize              = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -359,46 +361,47 @@ Tpm2NvDefineSpace (
     goto Done;\r
   }\r
 \r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2NvDefineSpace - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+    DEBUG ((DEBUG_ERROR, "Tpm2NvDefineSpace - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  case TPM_RC_SIZE + RC_NV_DefineSpace_publicInfo:\r
-  case TPM_RC_SIZE + RC_NV_DefineSpace_auth:\r
-    Status = EFI_BAD_BUFFER_SIZE;\r
-    break;\r
-  case TPM_RC_ATTRIBUTES:\r
-  case TPM_RC_ATTRIBUTES + RC_NV_DefineSpace_publicInfo:\r
-    Status = EFI_UNSUPPORTED;\r
-    break;\r
-  case TPM_RC_ATTRIBUTES + RC_NV_DefineSpace_authHandle:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_NV_DEFINED:\r
-    Status = EFI_ALREADY_STARTED;\r
-    break;\r
-  case TPM_RC_VALUE + RC_NV_DefineSpace_publicInfo:\r
-  case TPM_RC_VALUE + RC_NV_DefineSpace_authHandle:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_NV_SPACE:\r
-    Status = EFI_OUT_OF_RESOURCES;\r
-    break;\r
-  default:\r
-    Status = EFI_DEVICE_ERROR;\r
-    break;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    case TPM_RC_SIZE + RC_NV_DefineSpace_publicInfo:\r
+    case TPM_RC_SIZE + RC_NV_DefineSpace_auth:\r
+      Status = EFI_BAD_BUFFER_SIZE;\r
+      break;\r
+    case TPM_RC_ATTRIBUTES:\r
+    case TPM_RC_ATTRIBUTES + RC_NV_DefineSpace_publicInfo:\r
+      Status = EFI_UNSUPPORTED;\r
+      break;\r
+    case TPM_RC_ATTRIBUTES + RC_NV_DefineSpace_authHandle:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_NV_DEFINED:\r
+      Status = EFI_ALREADY_STARTED;\r
+      break;\r
+    case TPM_RC_VALUE + RC_NV_DefineSpace_publicInfo:\r
+    case TPM_RC_VALUE + RC_NV_DefineSpace_authHandle:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_NV_SPACE:\r
+      Status = EFI_OUT_OF_RESOURCES;\r
+      break;\r
+    default:\r
+      Status = EFI_DEVICE_ERROR;\r
+      break;\r
   }\r
 \r
 Done:\r
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -416,28 +419,28 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvUndefineSpace (\r
-  IN      TPMI_RH_PROVISION         AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN      TPMI_RH_PROVISION  AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_NV_UNDEFINESPACE_COMMAND     SendBuffer;\r
-  TPM2_NV_UNDEFINESPACE_RESPONSE    RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
-  TPM_RC                            ResponseCode;\r
+  EFI_STATUS                      Status;\r
+  TPM2_NV_UNDEFINESPACE_COMMAND   SendBuffer;\r
+  TPM2_NV_UNDEFINESPACE_RESPONSE  RecvBuffer;\r
+  UINT32                          SendBufferSize;\r
+  UINT32                          RecvBufferSize;\r
+  UINT8                           *Buffer;\r
+  UINT32                          SessionInfoSize;\r
+  TPM_RC                          ResponseCode;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_NV_UndefineSpace);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_NV_UndefineSpace);\r
 \r
   SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
-  SendBuffer.NvIndex = SwapBytes32 (NvIndex);\r
+  SendBuffer.NvIndex    = SwapBytes32 (NvIndex);\r
 \r
   //\r
   // Add in Auth session\r
@@ -445,18 +448,18 @@ Tpm2NvUndefineSpace (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  SendBufferSize = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
+  SendBufferSize              = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -467,42 +470,43 @@ Tpm2NvUndefineSpace (
     goto Done;\r
   }\r
 \r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2NvUndefineSpace - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+    DEBUG ((DEBUG_ERROR, "Tpm2NvUndefineSpace - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  case TPM_RC_ATTRIBUTES:\r
-  case TPM_RC_ATTRIBUTES + RC_NV_UndefineSpace_nvIndex:\r
-    Status = EFI_UNSUPPORTED;\r
-    break;\r
-  case TPM_RC_NV_AUTHORIZATION:\r
-    Status = EFI_SECURITY_VIOLATION;\r
-    break;\r
-  case TPM_RC_HANDLE + RC_NV_UndefineSpace_nvIndex: // TPM_RC_NV_DEFINED:\r
-    Status = EFI_NOT_FOUND;\r
-    break;\r
-  case TPM_RC_HANDLE + RC_NV_UndefineSpace_authHandle: // TPM_RC_NV_DEFINED:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_VALUE + RC_NV_UndefineSpace_authHandle:\r
-  case TPM_RC_VALUE + RC_NV_UndefineSpace_nvIndex:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  default:\r
-    Status = EFI_DEVICE_ERROR;\r
-    break;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    case TPM_RC_ATTRIBUTES:\r
+    case TPM_RC_ATTRIBUTES + RC_NV_UndefineSpace_nvIndex:\r
+      Status = EFI_UNSUPPORTED;\r
+      break;\r
+    case TPM_RC_NV_AUTHORIZATION:\r
+      Status = EFI_SECURITY_VIOLATION;\r
+      break;\r
+    case TPM_RC_HANDLE + RC_NV_UndefineSpace_nvIndex: // TPM_RC_NV_DEFINED:\r
+      Status = EFI_NOT_FOUND;\r
+      break;\r
+    case TPM_RC_HANDLE + RC_NV_UndefineSpace_authHandle: // TPM_RC_NV_DEFINED:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_VALUE + RC_NV_UndefineSpace_authHandle:\r
+    case TPM_RC_VALUE + RC_NV_UndefineSpace_nvIndex:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    default:\r
+      Status = EFI_DEVICE_ERROR;\r
+      break;\r
   }\r
 \r
 Done:\r
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -523,31 +527,31 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvRead (\r
-  IN      TPMI_RH_NV_AUTH           AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN      UINT16                    Size,\r
-  IN      UINT16                    Offset,\r
-  IN OUT  TPM2B_MAX_BUFFER          *OutData\r
+  IN      TPMI_RH_NV_AUTH    AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN      UINT16             Size,\r
+  IN      UINT16             Offset,\r
+  IN OUT  TPM2B_MAX_BUFFER   *OutData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_NV_READ_COMMAND              SendBuffer;\r
-  TPM2_NV_READ_RESPONSE             RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
-  TPM_RC                            ResponseCode;\r
+  EFI_STATUS             Status;\r
+  TPM2_NV_READ_COMMAND   SendBuffer;\r
+  TPM2_NV_READ_RESPONSE  RecvBuffer;\r
+  UINT32                 SendBufferSize;\r
+  UINT32                 RecvBufferSize;\r
+  UINT8                  *Buffer;\r
+  UINT32                 SessionInfoSize;\r
+  TPM_RC                 ResponseCode;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_NV_Read);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_NV_Read);\r
 \r
   SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
-  SendBuffer.NvIndex = SwapBytes32 (NvIndex);\r
+  SendBuffer.NvIndex    = SwapBytes32 (NvIndex);\r
 \r
   //\r
   // Add in Auth session\r
@@ -555,23 +559,23 @@ Tpm2NvRead (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Size));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Offset));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
 \r
-  SendBufferSize = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
+  SendBufferSize              = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -581,52 +585,55 @@ Tpm2NvRead (
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2NvRead - responseCode - %x\n", ResponseCode));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  case TPM_RC_NV_AUTHORIZATION:\r
-    Status = EFI_SECURITY_VIOLATION;\r
-    break;\r
-  case TPM_RC_NV_LOCKED:\r
-    Status = EFI_ACCESS_DENIED;\r
-    break;\r
-  case TPM_RC_NV_RANGE:\r
-    Status = EFI_BAD_BUFFER_SIZE;\r
-    break;\r
-  case TPM_RC_NV_UNINITIALIZED:\r
-    Status = EFI_NOT_READY;\r
-    break;\r
-  case TPM_RC_HANDLE + RC_NV_Read_nvIndex: // TPM_RC_NV_DEFINED:\r
-    Status = EFI_NOT_FOUND;\r
-    break;\r
-  case TPM_RC_HANDLE + RC_NV_Read_authHandle: // TPM_RC_NV_DEFINED:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_VALUE + RC_NV_Read_nvIndex:\r
-  case TPM_RC_VALUE + RC_NV_Read_authHandle:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_BAD_AUTH + RC_NV_Read_authHandle + TPM_RC_S:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_AUTH_UNAVAILABLE:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_AUTH_FAIL + RC_NV_Read_authHandle + TPM_RC_S:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_ATTRIBUTES + RC_NV_Read_authHandle + TPM_RC_S:\r
-    Status = EFI_UNSUPPORTED;\r
-    break;\r
-  default:\r
-    Status = EFI_DEVICE_ERROR;\r
-    break;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    case TPM_RC_NV_AUTHORIZATION:\r
+      Status = EFI_SECURITY_VIOLATION;\r
+      break;\r
+    case TPM_RC_NV_LOCKED:\r
+      Status = EFI_ACCESS_DENIED;\r
+      break;\r
+    case TPM_RC_NV_RANGE:\r
+      Status = EFI_BAD_BUFFER_SIZE;\r
+      break;\r
+    case TPM_RC_NV_UNINITIALIZED:\r
+      Status = EFI_NOT_READY;\r
+      break;\r
+    case TPM_RC_HANDLE + RC_NV_Read_nvIndex: // TPM_RC_NV_DEFINED:\r
+      Status = EFI_NOT_FOUND;\r
+      break;\r
+    case TPM_RC_HANDLE + RC_NV_Read_authHandle: // TPM_RC_NV_DEFINED:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_VALUE + RC_NV_Read_nvIndex:\r
+    case TPM_RC_VALUE + RC_NV_Read_authHandle:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_BAD_AUTH + RC_NV_Read_authHandle + TPM_RC_S:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_AUTH_UNAVAILABLE:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_AUTH_FAIL + RC_NV_Read_authHandle + TPM_RC_S:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_ATTRIBUTES + RC_NV_Read_authHandle + TPM_RC_S:\r
+      Status = EFI_UNSUPPORTED;\r
+      break;\r
+    default:\r
+      Status = EFI_DEVICE_ERROR;\r
+      break;\r
   }\r
+\r
   if (Status != EFI_SUCCESS) {\r
     goto Done;\r
   }\r
@@ -647,8 +654,8 @@ Done:
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -668,30 +675,30 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvWrite (\r
-  IN      TPMI_RH_NV_AUTH           AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession  OPTIONAL,\r
-  IN      TPM2B_MAX_BUFFER          *InData,\r
-  IN      UINT16                    Offset\r
+  IN      TPMI_RH_NV_AUTH    AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession  OPTIONAL,\r
+  IN      TPM2B_MAX_BUFFER   *InData,\r
+  IN      UINT16             Offset\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_NV_WRITE_COMMAND             SendBuffer;\r
-  TPM2_NV_WRITE_RESPONSE            RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
-  TPM_RC                            ResponseCode;\r
+  EFI_STATUS              Status;\r
+  TPM2_NV_WRITE_COMMAND   SendBuffer;\r
+  TPM2_NV_WRITE_RESPONSE  RecvBuffer;\r
+  UINT32                  SendBufferSize;\r
+  UINT32                  RecvBufferSize;\r
+  UINT8                   *Buffer;\r
+  UINT32                  SessionInfoSize;\r
+  TPM_RC                  ResponseCode;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_NV_Write);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_NV_Write);\r
 \r
   SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
-  SendBuffer.NvIndex = SwapBytes32 (NvIndex);\r
+  SendBuffer.NvIndex    = SwapBytes32 (NvIndex);\r
 \r
   //\r
   // Add in Auth session\r
@@ -699,25 +706,25 @@ Tpm2NvWrite (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (InData->size));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Buffer, InData->buffer, InData->size);\r
   Buffer += InData->size;\r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Offset));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
 \r
-  SendBufferSize = (UINT32) (Buffer - (UINT8 *)&SendBuffer);\r
+  SendBufferSize              = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -727,59 +734,61 @@ Tpm2NvWrite (
     Status = EFI_DEVICE_ERROR;\r
     goto Done;\r
   }\r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2NvWrite - responseCode - %x\n", ResponseCode));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  case TPM_RC_ATTRIBUTES:\r
-    Status = EFI_UNSUPPORTED;\r
-    break;\r
-  case TPM_RC_NV_AUTHORIZATION:\r
-    Status = EFI_SECURITY_VIOLATION;\r
-    break;\r
-  case TPM_RC_NV_LOCKED:\r
-    Status = EFI_ACCESS_DENIED;\r
-    break;\r
-  case TPM_RC_NV_RANGE:\r
-    Status = EFI_BAD_BUFFER_SIZE;\r
-    break;\r
-  case TPM_RC_HANDLE + RC_NV_Write_nvIndex: // TPM_RC_NV_DEFINED:\r
-    Status = EFI_NOT_FOUND;\r
-    break;\r
-  case TPM_RC_HANDLE + RC_NV_Write_authHandle: // TPM_RC_NV_DEFINED:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_VALUE + RC_NV_Write_nvIndex:\r
-  case TPM_RC_VALUE + RC_NV_Write_authHandle:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_BAD_AUTH + RC_NV_Write_authHandle + TPM_RC_S:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_AUTH_UNAVAILABLE:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_AUTH_FAIL + RC_NV_Write_authHandle + TPM_RC_S:\r
-    Status = EFI_INVALID_PARAMETER;\r
-    break;\r
-  case TPM_RC_ATTRIBUTES + RC_NV_Write_authHandle + TPM_RC_S:\r
-    Status = EFI_UNSUPPORTED;\r
-    break;\r
-  default:\r
-    Status = EFI_DEVICE_ERROR;\r
-    break;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    case TPM_RC_ATTRIBUTES:\r
+      Status = EFI_UNSUPPORTED;\r
+      break;\r
+    case TPM_RC_NV_AUTHORIZATION:\r
+      Status = EFI_SECURITY_VIOLATION;\r
+      break;\r
+    case TPM_RC_NV_LOCKED:\r
+      Status = EFI_ACCESS_DENIED;\r
+      break;\r
+    case TPM_RC_NV_RANGE:\r
+      Status = EFI_BAD_BUFFER_SIZE;\r
+      break;\r
+    case TPM_RC_HANDLE + RC_NV_Write_nvIndex: // TPM_RC_NV_DEFINED:\r
+      Status = EFI_NOT_FOUND;\r
+      break;\r
+    case TPM_RC_HANDLE + RC_NV_Write_authHandle: // TPM_RC_NV_DEFINED:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_VALUE + RC_NV_Write_nvIndex:\r
+    case TPM_RC_VALUE + RC_NV_Write_authHandle:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_BAD_AUTH + RC_NV_Write_authHandle + TPM_RC_S:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_AUTH_UNAVAILABLE:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_AUTH_FAIL + RC_NV_Write_authHandle + TPM_RC_S:\r
+      Status = EFI_INVALID_PARAMETER;\r
+      break;\r
+    case TPM_RC_ATTRIBUTES + RC_NV_Write_authHandle + TPM_RC_S:\r
+      Status = EFI_UNSUPPORTED;\r
+      break;\r
+    default:\r
+      Status = EFI_DEVICE_ERROR;\r
+      break;\r
   }\r
 \r
 Done:\r
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -797,28 +806,28 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvReadLock (\r
-  IN      TPMI_RH_NV_AUTH           AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN      TPMI_RH_NV_AUTH    AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_NV_READLOCK_COMMAND          SendBuffer;\r
-  TPM2_NV_READLOCK_RESPONSE         RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
-  TPM_RC                            ResponseCode;\r
+  EFI_STATUS                 Status;\r
+  TPM2_NV_READLOCK_COMMAND   SendBuffer;\r
+  TPM2_NV_READLOCK_RESPONSE  RecvBuffer;\r
+  UINT32                     SendBufferSize;\r
+  UINT32                     RecvBufferSize;\r
+  UINT8                      *Buffer;\r
+  UINT32                     SessionInfoSize;\r
+  TPM_RC                     ResponseCode;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_NV_ReadLock);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_NV_ReadLock);\r
 \r
   SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
-  SendBuffer.NvIndex = SwapBytes32 (NvIndex);\r
+  SendBuffer.NvIndex    = SwapBytes32 (NvIndex);\r
 \r
   //\r
   // Add in Auth session\r
@@ -826,18 +835,18 @@ Tpm2NvReadLock (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  SendBufferSize = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
+  SendBufferSize              = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -848,25 +857,26 @@ Tpm2NvReadLock (
     goto Done;\r
   }\r
 \r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2NvReadLock - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+    DEBUG ((DEBUG_ERROR, "Tpm2NvReadLock - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  default:\r
-    Status = EFI_DEVICE_ERROR;\r
-    break;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    default:\r
+      Status = EFI_DEVICE_ERROR;\r
+      break;\r
   }\r
 \r
 Done:\r
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -884,28 +894,28 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvWriteLock (\r
-  IN      TPMI_RH_NV_AUTH           AuthHandle,\r
-  IN      TPMI_RH_NV_INDEX          NvIndex,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN      TPMI_RH_NV_AUTH    AuthHandle,\r
+  IN      TPMI_RH_NV_INDEX   NvIndex,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_NV_WRITELOCK_COMMAND         SendBuffer;\r
-  TPM2_NV_WRITELOCK_RESPONSE        RecvBuffer;\r
-  UINT32                            SendBufferSize;\r
-  UINT32                            RecvBufferSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            SessionInfoSize;\r
-  TPM_RC                            ResponseCode;\r
+  EFI_STATUS                  Status;\r
+  TPM2_NV_WRITELOCK_COMMAND   SendBuffer;\r
+  TPM2_NV_WRITELOCK_RESPONSE  RecvBuffer;\r
+  UINT32                      SendBufferSize;\r
+  UINT32                      RecvBufferSize;\r
+  UINT8                       *Buffer;\r
+  UINT32                      SessionInfoSize;\r
+  TPM_RC                      ResponseCode;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_NV_WriteLock);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_NV_WriteLock);\r
 \r
   SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
-  SendBuffer.NvIndex = SwapBytes32 (NvIndex);\r
+  SendBuffer.NvIndex    = SwapBytes32 (NvIndex);\r
 \r
   //\r
   // Add in Auth session\r
@@ -913,18 +923,18 @@ Tpm2NvWriteLock (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  SendBufferSize = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
+  SendBufferSize              = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -935,25 +945,26 @@ Tpm2NvWriteLock (
     goto Done;\r
   }\r
 \r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2NvWriteLock - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+    DEBUG ((DEBUG_ERROR, "Tpm2NvWriteLock - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  default:\r
-    Status = EFI_DEVICE_ERROR;\r
-    break;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    default:\r
+      Status = EFI_DEVICE_ERROR;\r
+      break;\r
   }\r
 \r
 Done:\r
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
 \r
@@ -970,8 +981,8 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 Tpm2NvGlobalWriteLock (\r
-  IN      TPMI_RH_PROVISION         AuthHandle,\r
-  IN      TPMS_AUTH_COMMAND         *AuthSession OPTIONAL\r
+  IN      TPMI_RH_PROVISION  AuthHandle,\r
+  IN      TPMS_AUTH_COMMAND  *AuthSession OPTIONAL\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -986,8 +997,8 @@ Tpm2NvGlobalWriteLock (
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_NV_GlobalWriteLock);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_NV_GlobalWriteLock);\r
 \r
   SendBuffer.AuthHandle = SwapBytes32 (AuthHandle);\r
 \r
@@ -997,18 +1008,18 @@ Tpm2NvGlobalWriteLock (
   Buffer = (UINT8 *)&SendBuffer.AuthSession;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (AuthSession, Buffer);\r
-  Buffer += SessionInfoSize;\r
-  SendBuffer.AuthSessionSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize            = CopyAuthSessionCommand (AuthSession, Buffer);\r
+  Buffer                    += SessionInfoSize;\r
+  SendBuffer.AuthSessionSize = SwapBytes32 (SessionInfoSize);\r
 \r
-  SendBufferSize = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
+  SendBufferSize              = (UINT32)(Buffer - (UINT8 *)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     goto Done;\r
   }\r
@@ -1019,24 +1030,25 @@ Tpm2NvGlobalWriteLock (
     goto Done;\r
   }\r
 \r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2NvGlobalWriteLock - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+    DEBUG ((DEBUG_ERROR, "Tpm2NvGlobalWriteLock - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  default:\r
-    Status = EFI_DEVICE_ERROR;\r
-    break;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    default:\r
+      Status = EFI_DEVICE_ERROR;\r
+      break;\r
   }\r
 \r
 Done:\r
   //\r
   // Clear AuthSession Content\r
   //\r
-  ZeroMem (&SendBuffer, sizeof(SendBuffer));\r
-  ZeroMem (&RecvBuffer, sizeof(RecvBuffer));\r
+  ZeroMem (&SendBuffer, sizeof (SendBuffer));\r
+  ZeroMem (&RecvBuffer, sizeof (RecvBuffer));\r
   return Status;\r
 }\r
index f5301f04d8c2d7d13ee1c977c861f1cff23c3489..335957d6cedcbf10daceb77013ce0e53ff1b932e 100644 (file)
@@ -16,15 +16,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_DH_OBJECT            ObjectHandle;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_DH_OBJECT         ObjectHandle;\r
 } TPM2_READ_PUBLIC_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  TPM2B_PUBLIC               OutPublic;\r
-  TPM2B_NAME                 Name;\r
-  TPM2B_NAME                 QualifiedName;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  TPM2B_PUBLIC            OutPublic;\r
+  TPM2B_NAME              Name;\r
+  TPM2B_NAME              QualifiedName;\r
 } TPM2_READ_PUBLIC_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -43,39 +43,39 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2ReadPublic (\r
-  IN  TPMI_DH_OBJECT            ObjectHandle,\r
-  OUT TPM2B_PUBLIC              *OutPublic,\r
-  OUT TPM2B_NAME                *Name,\r
-  OUT TPM2B_NAME                *QualifiedName\r
+  IN  TPMI_DH_OBJECT  ObjectHandle,\r
+  OUT TPM2B_PUBLIC    *OutPublic,\r
+  OUT TPM2B_NAME      *Name,\r
+  OUT TPM2B_NAME      *QualifiedName\r
   )\r
 {\r
-  EFI_STATUS                                 Status;\r
-  TPM2_READ_PUBLIC_COMMAND                   SendBuffer;\r
-  TPM2_READ_PUBLIC_RESPONSE                  RecvBuffer;\r
-  UINT32                                     SendBufferSize;\r
-  UINT32                                     RecvBufferSize;\r
-  TPM_RC                                     ResponseCode;\r
-  UINT8                                      *Buffer;\r
-  UINT16                                     OutPublicSize;\r
-  UINT16                                     NameSize;\r
-  UINT16                                     QualifiedNameSize;\r
+  EFI_STATUS                 Status;\r
+  TPM2_READ_PUBLIC_COMMAND   SendBuffer;\r
+  TPM2_READ_PUBLIC_RESPONSE  RecvBuffer;\r
+  UINT32                     SendBufferSize;\r
+  UINT32                     RecvBufferSize;\r
+  TPM_RC                     ResponseCode;\r
+  UINT8                      *Buffer;\r
+  UINT16                     OutPublicSize;\r
+  UINT16                     NameSize;\r
+  UINT16                     QualifiedNameSize;\r
 \r
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_ReadPublic);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_ReadPublic);\r
 \r
   SendBuffer.ObjectHandle = SwapBytes32 (ObjectHandle);\r
 \r
-  SendBufferSize = (UINT32) sizeof (SendBuffer);\r
+  SendBufferSize              = (UINT32)sizeof (SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -84,46 +84,56 @@ Tpm2ReadPublic (
     DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  ResponseCode = SwapBytes32(RecvBuffer.Header.responseCode);\r
+\r
+  ResponseCode = SwapBytes32 (RecvBuffer.Header.responseCode);\r
   if (ResponseCode != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+    DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
   }\r
+\r
   switch (ResponseCode) {\r
-  case TPM_RC_SUCCESS:\r
-    // return data\r
-    break;\r
-  case TPM_RC_SEQUENCE:\r
-    // objectHandle references a sequence object\r
-    return EFI_INVALID_PARAMETER;\r
-  default:\r
-    return EFI_DEVICE_ERROR;\r
+    case TPM_RC_SUCCESS:\r
+      // return data\r
+      break;\r
+    case TPM_RC_SEQUENCE:\r
+      // objectHandle references a sequence object\r
+      return EFI_INVALID_PARAMETER;\r
+    default:\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 \r
   //\r
   // Basic check\r
   //\r
   OutPublicSize = SwapBytes16 (RecvBuffer.OutPublic.size);\r
-  if (OutPublicSize > sizeof(TPMT_PUBLIC)) {\r
+  if (OutPublicSize > sizeof (TPMT_PUBLIC)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - OutPublicSize error %x\n", OutPublicSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  NameSize = SwapBytes16 (ReadUnaligned16 ((UINT16 *)((UINT8 *)&RecvBuffer + sizeof(TPM2_RESPONSE_HEADER) +\r
-                          sizeof(UINT16) + OutPublicSize)));\r
-  if (NameSize > sizeof(TPMU_NAME)) {\r
+  NameSize = SwapBytes16 (\r
+               ReadUnaligned16 (\r
+                 (UINT16 *)((UINT8 *)&RecvBuffer + sizeof (TPM2_RESPONSE_HEADER) +\r
+                            sizeof (UINT16) + OutPublicSize)\r
+                 )\r
+               );\r
+  if (NameSize > sizeof (TPMU_NAME)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - NameSize error %x\n", NameSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  QualifiedNameSize = SwapBytes16 (ReadUnaligned16 ((UINT16 *)((UINT8 *)&RecvBuffer + sizeof(TPM2_RESPONSE_HEADER) +\r
-                                   sizeof(UINT16) + OutPublicSize +\r
-                                   sizeof(UINT16) + NameSize)));\r
-  if (QualifiedNameSize > sizeof(TPMU_NAME)) {\r
+  QualifiedNameSize = SwapBytes16 (\r
+                        ReadUnaligned16 (\r
+                          (UINT16 *)((UINT8 *)&RecvBuffer + sizeof (TPM2_RESPONSE_HEADER) +\r
+                                     sizeof (UINT16) + OutPublicSize +\r
+                                     sizeof (UINT16) + NameSize)\r
+                          )\r
+                        );\r
+  if (QualifiedNameSize > sizeof (TPMU_NAME)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - QualifiedNameSize error %x\n", QualifiedNameSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  if (RecvBufferSize != sizeof(TPM2_RESPONSE_HEADER) + sizeof(UINT16) + OutPublicSize + sizeof(UINT16) + NameSize + sizeof(UINT16) + QualifiedNameSize) {\r
+  if (RecvBufferSize != sizeof (TPM2_RESPONSE_HEADER) + sizeof (UINT16) + OutPublicSize + sizeof (UINT16) + NameSize + sizeof (UINT16) + QualifiedNameSize) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - RecvBufferSize %x Error - OutPublicSize %x, NameSize %x, QualifiedNameSize %x\n", RecvBufferSize, OutPublicSize, NameSize, QualifiedNameSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
@@ -132,15 +142,15 @@ Tpm2ReadPublic (
   // Return the response\r
   //\r
   Buffer = (UINT8 *)&RecvBuffer.OutPublic;\r
-  CopyMem (OutPublic, &RecvBuffer.OutPublic, sizeof(UINT16) + OutPublicSize);\r
-  OutPublic->size = OutPublicSize;\r
-  OutPublic->publicArea.type = SwapBytes16 (OutPublic->publicArea.type);\r
+  CopyMem (OutPublic, &RecvBuffer.OutPublic, sizeof (UINT16) + OutPublicSize);\r
+  OutPublic->size               = OutPublicSize;\r
+  OutPublic->publicArea.type    = SwapBytes16 (OutPublic->publicArea.type);\r
   OutPublic->publicArea.nameAlg = SwapBytes16 (OutPublic->publicArea.nameAlg);\r
   WriteUnaligned32 ((UINT32 *)&OutPublic->publicArea.objectAttributes, SwapBytes32 (ReadUnaligned32 ((UINT32 *)&OutPublic->publicArea.objectAttributes)));\r
-  Buffer = (UINT8 *)&RecvBuffer.OutPublic.publicArea.authPolicy;\r
+  Buffer                                = (UINT8 *)&RecvBuffer.OutPublic.publicArea.authPolicy;\r
   OutPublic->publicArea.authPolicy.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-  Buffer += sizeof(UINT16);\r
-  if (OutPublic->publicArea.authPolicy.size > sizeof(TPMU_HA)) {\r
+  Buffer                               += sizeof (UINT16);\r
+  if (OutPublic->publicArea.authPolicy.size > sizeof (TPMU_HA)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - authPolicy.size error %x\n", OutPublic->publicArea.authPolicy.size));\r
     return EFI_DEVICE_ERROR;\r
   }\r
@@ -150,229 +160,241 @@ Tpm2ReadPublic (
 \r
   // TPMU_PUBLIC_PARMS\r
   switch (OutPublic->publicArea.type) {\r
-  case TPM_ALG_KEYEDHASH:\r
-    OutPublic->publicArea.parameters.keyedHashDetail.scheme.scheme = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    switch (OutPublic->publicArea.parameters.keyedHashDetail.scheme.scheme) {\r
-    case TPM_ALG_HMAC:\r
-      OutPublic->publicArea.parameters.keyedHashDetail.scheme.details.hmac.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_XOR:\r
-      OutPublic->publicArea.parameters.keyedHashDetail.scheme.details.xor.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      OutPublic->publicArea.parameters.keyedHashDetail.scheme.details.xor.kdf = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    default:\r
-      return EFI_UNSUPPORTED;\r
-    }\r
-  case TPM_ALG_SYMCIPHER:\r
-    OutPublic->publicArea.parameters.symDetail.algorithm = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    switch (OutPublic->publicArea.parameters.symDetail.algorithm) {\r
-    case TPM_ALG_AES:\r
-      OutPublic->publicArea.parameters.symDetail.keyBits.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      OutPublic->publicArea.parameters.symDetail.mode.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_SM4:\r
-      OutPublic->publicArea.parameters.symDetail.keyBits.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      OutPublic->publicArea.parameters.symDetail.mode.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_XOR:\r
-      OutPublic->publicArea.parameters.symDetail.keyBits.xor = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_UNSUPPORTED;\r
-    }\r
-    break;\r
-  case TPM_ALG_RSA:\r
-    OutPublic->publicArea.parameters.rsaDetail.symmetric.algorithm = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    switch (OutPublic->publicArea.parameters.rsaDetail.symmetric.algorithm) {\r
-    case TPM_ALG_AES:\r
-      OutPublic->publicArea.parameters.rsaDetail.symmetric.keyBits.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      OutPublic->publicArea.parameters.rsaDetail.symmetric.mode.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_SM4:\r
-      OutPublic->publicArea.parameters.rsaDetail.symmetric.keyBits.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      OutPublic->publicArea.parameters.rsaDetail.symmetric.mode.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_UNSUPPORTED;\r
-    }\r
-    OutPublic->publicArea.parameters.rsaDetail.scheme.scheme = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    switch (OutPublic->publicArea.parameters.rsaDetail.scheme.scheme) {\r
-    case TPM_ALG_RSASSA:\r
-      OutPublic->publicArea.parameters.rsaDetail.scheme.details.rsassa.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_RSAPSS:\r
-      OutPublic->publicArea.parameters.rsaDetail.scheme.details.rsapss.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_RSAES:\r
-      break;\r
-    case TPM_ALG_OAEP:\r
-      OutPublic->publicArea.parameters.rsaDetail.scheme.details.oaep.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_UNSUPPORTED;\r
-    }\r
-    OutPublic->publicArea.parameters.rsaDetail.keyBits = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    OutPublic->publicArea.parameters.rsaDetail.exponent = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT32);\r
-    break;\r
-  case TPM_ALG_ECC:\r
-    OutPublic->publicArea.parameters.eccDetail.symmetric.algorithm = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    switch (OutPublic->publicArea.parameters.eccDetail.symmetric.algorithm) {\r
-    case TPM_ALG_AES:\r
-      OutPublic->publicArea.parameters.eccDetail.symmetric.keyBits.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      OutPublic->publicArea.parameters.eccDetail.symmetric.mode.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_SM4:\r
-      OutPublic->publicArea.parameters.eccDetail.symmetric.keyBits.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      OutPublic->publicArea.parameters.eccDetail.symmetric.mode.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_NULL:\r
-      break;\r
-    default:\r
-      return EFI_UNSUPPORTED;\r
-    }\r
-    OutPublic->publicArea.parameters.eccDetail.scheme.scheme = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    switch (OutPublic->publicArea.parameters.eccDetail.scheme.scheme) {\r
-    case TPM_ALG_ECDSA:\r
-      OutPublic->publicArea.parameters.eccDetail.scheme.details.ecdsa.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_ECDAA:\r
-      OutPublic->publicArea.parameters.eccDetail.scheme.details.ecdaa.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_ECSCHNORR:\r
-      OutPublic->publicArea.parameters.eccDetail.scheme.details.ecSchnorr.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
+    case TPM_ALG_KEYEDHASH:\r
+      OutPublic->publicArea.parameters.keyedHashDetail.scheme.scheme = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                                        += sizeof (UINT16);\r
+      switch (OutPublic->publicArea.parameters.keyedHashDetail.scheme.scheme) {\r
+        case TPM_ALG_HMAC:\r
+          OutPublic->publicArea.parameters.keyedHashDetail.scheme.details.hmac.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                      += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_XOR:\r
+          OutPublic->publicArea.parameters.keyedHashDetail.scheme.details.xor.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                     += sizeof (UINT16);\r
+          OutPublic->publicArea.parameters.keyedHashDetail.scheme.details.xor.kdf     = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                     += sizeof (UINT16);\r
+          break;\r
+        default:\r
+          return EFI_UNSUPPORTED;\r
+      }\r
+\r
+    case TPM_ALG_SYMCIPHER:\r
+      OutPublic->publicArea.parameters.symDetail.algorithm = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                              += sizeof (UINT16);\r
+      switch (OutPublic->publicArea.parameters.symDetail.algorithm) {\r
+        case TPM_ALG_AES:\r
+          OutPublic->publicArea.parameters.symDetail.keyBits.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                += sizeof (UINT16);\r
+          OutPublic->publicArea.parameters.symDetail.mode.aes    = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_SM4:\r
+          OutPublic->publicArea.parameters.symDetail.keyBits.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                += sizeof (UINT16);\r
+          OutPublic->publicArea.parameters.symDetail.mode.SM4    = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_XOR:\r
+          OutPublic->publicArea.parameters.symDetail.keyBits.xor = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_UNSUPPORTED;\r
+      }\r
+\r
       break;\r
-    case TPM_ALG_ECDH:\r
+    case TPM_ALG_RSA:\r
+      OutPublic->publicArea.parameters.rsaDetail.symmetric.algorithm = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                                        += sizeof (UINT16);\r
+      switch (OutPublic->publicArea.parameters.rsaDetail.symmetric.algorithm) {\r
+        case TPM_ALG_AES:\r
+          OutPublic->publicArea.parameters.rsaDetail.symmetric.keyBits.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                          += sizeof (UINT16);\r
+          OutPublic->publicArea.parameters.rsaDetail.symmetric.mode.aes    = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                          += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_SM4:\r
+          OutPublic->publicArea.parameters.rsaDetail.symmetric.keyBits.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                          += sizeof (UINT16);\r
+          OutPublic->publicArea.parameters.rsaDetail.symmetric.mode.SM4    = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                          += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_UNSUPPORTED;\r
+      }\r
+\r
+      OutPublic->publicArea.parameters.rsaDetail.scheme.scheme = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                                  += sizeof (UINT16);\r
+      switch (OutPublic->publicArea.parameters.rsaDetail.scheme.scheme) {\r
+        case TPM_ALG_RSASSA:\r
+          OutPublic->publicArea.parameters.rsaDetail.scheme.details.rsassa.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                  += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_RSAPSS:\r
+          OutPublic->publicArea.parameters.rsaDetail.scheme.details.rsapss.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                  += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_RSAES:\r
+          break;\r
+        case TPM_ALG_OAEP:\r
+          OutPublic->publicArea.parameters.rsaDetail.scheme.details.oaep.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_UNSUPPORTED;\r
+      }\r
+\r
+      OutPublic->publicArea.parameters.rsaDetail.keyBits  = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                             += sizeof (UINT16);\r
+      OutPublic->publicArea.parameters.rsaDetail.exponent = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                             += sizeof (UINT32);\r
       break;\r
-    case TPM_ALG_NULL:\r
+    case TPM_ALG_ECC:\r
+      OutPublic->publicArea.parameters.eccDetail.symmetric.algorithm = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                                        += sizeof (UINT16);\r
+      switch (OutPublic->publicArea.parameters.eccDetail.symmetric.algorithm) {\r
+        case TPM_ALG_AES:\r
+          OutPublic->publicArea.parameters.eccDetail.symmetric.keyBits.aes = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                          += sizeof (UINT16);\r
+          OutPublic->publicArea.parameters.eccDetail.symmetric.mode.aes    = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                          += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_SM4:\r
+          OutPublic->publicArea.parameters.eccDetail.symmetric.keyBits.SM4 = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                          += sizeof (UINT16);\r
+          OutPublic->publicArea.parameters.eccDetail.symmetric.mode.SM4    = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                          += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_UNSUPPORTED;\r
+      }\r
+\r
+      OutPublic->publicArea.parameters.eccDetail.scheme.scheme = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                                  += sizeof (UINT16);\r
+      switch (OutPublic->publicArea.parameters.eccDetail.scheme.scheme) {\r
+        case TPM_ALG_ECDSA:\r
+          OutPublic->publicArea.parameters.eccDetail.scheme.details.ecdsa.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                 += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_ECDAA:\r
+          OutPublic->publicArea.parameters.eccDetail.scheme.details.ecdaa.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                 += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_ECSCHNORR:\r
+          OutPublic->publicArea.parameters.eccDetail.scheme.details.ecSchnorr.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                     += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_ECDH:\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_UNSUPPORTED;\r
+      }\r
+\r
+      OutPublic->publicArea.parameters.eccDetail.curveID    = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                               += sizeof (UINT16);\r
+      OutPublic->publicArea.parameters.eccDetail.kdf.scheme = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                               += sizeof (UINT16);\r
+      switch (OutPublic->publicArea.parameters.eccDetail.kdf.scheme) {\r
+        case TPM_ALG_MGF1:\r
+          OutPublic->publicArea.parameters.eccDetail.kdf.details.mgf1.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                             += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_KDF1_SP800_108:\r
+          OutPublic->publicArea.parameters.eccDetail.kdf.details.kdf1_sp800_108.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                       += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_KDF1_SP800_56a:\r
+          OutPublic->publicArea.parameters.eccDetail.kdf.details.kdf1_SP800_56a.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                                       += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_KDF2:\r
+          OutPublic->publicArea.parameters.eccDetail.kdf.details.kdf2.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+          Buffer                                                             += sizeof (UINT16);\r
+          break;\r
+        case TPM_ALG_NULL:\r
+          break;\r
+        default:\r
+          return EFI_UNSUPPORTED;\r
+      }\r
+\r
       break;\r
     default:\r
       return EFI_UNSUPPORTED;\r
-    }\r
-    OutPublic->publicArea.parameters.eccDetail.curveID = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    OutPublic->publicArea.parameters.eccDetail.kdf.scheme = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    switch (OutPublic->publicArea.parameters.eccDetail.kdf.scheme) {\r
-    case TPM_ALG_MGF1:\r
-      OutPublic->publicArea.parameters.eccDetail.kdf.details.mgf1.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
-      break;\r
-    case TPM_ALG_KDF1_SP800_108:\r
-      OutPublic->publicArea.parameters.eccDetail.kdf.details.kdf1_sp800_108.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
+  }\r
+\r
+  // TPMU_PUBLIC_ID\r
+  switch (OutPublic->publicArea.type) {\r
+    case TPM_ALG_KEYEDHASH:\r
+      OutPublic->publicArea.unique.keyedHash.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                     += sizeof (UINT16);\r
+      if (OutPublic->publicArea.unique.keyedHash.size > sizeof (TPMU_HA)) {\r
+        DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - keyedHash.size error %x\n", OutPublic->publicArea.unique.keyedHash.size));\r
+        return EFI_DEVICE_ERROR;\r
+      }\r
+\r
+      CopyMem (OutPublic->publicArea.unique.keyedHash.buffer, Buffer, OutPublic->publicArea.unique.keyedHash.size);\r
+      Buffer += OutPublic->publicArea.unique.keyedHash.size;\r
       break;\r
-    case TPM_ALG_KDF1_SP800_56a:\r
-      OutPublic->publicArea.parameters.eccDetail.kdf.details.kdf1_SP800_56a.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
+    case TPM_ALG_SYMCIPHER:\r
+      OutPublic->publicArea.unique.sym.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                               += sizeof (UINT16);\r
+      if (OutPublic->publicArea.unique.sym.size > sizeof (TPMU_HA)) {\r
+        DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - sym.size error %x\n", OutPublic->publicArea.unique.sym.size));\r
+        return EFI_DEVICE_ERROR;\r
+      }\r
+\r
+      CopyMem (OutPublic->publicArea.unique.sym.buffer, Buffer, OutPublic->publicArea.unique.sym.size);\r
+      Buffer += OutPublic->publicArea.unique.sym.size;\r
       break;\r
-    case TPM_ALG_KDF2:\r
-      OutPublic->publicArea.parameters.eccDetail.kdf.details.kdf2.hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-      Buffer += sizeof(UINT16);\r
+    case TPM_ALG_RSA:\r
+      OutPublic->publicArea.unique.rsa.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                               += sizeof (UINT16);\r
+      if (OutPublic->publicArea.unique.rsa.size > MAX_RSA_KEY_BYTES) {\r
+        DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - rsa.size error %x\n", OutPublic->publicArea.unique.rsa.size));\r
+        return EFI_DEVICE_ERROR;\r
+      }\r
+\r
+      CopyMem (OutPublic->publicArea.unique.rsa.buffer, Buffer, OutPublic->publicArea.unique.rsa.size);\r
+      Buffer += OutPublic->publicArea.unique.rsa.size;\r
       break;\r
-    case TPM_ALG_NULL:\r
+    case TPM_ALG_ECC:\r
+      OutPublic->publicArea.unique.ecc.x.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                 += sizeof (UINT16);\r
+      if (OutPublic->publicArea.unique.ecc.x.size > MAX_ECC_KEY_BYTES) {\r
+        DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - ecc.x.size error %x\n", OutPublic->publicArea.unique.ecc.x.size));\r
+        return EFI_DEVICE_ERROR;\r
+      }\r
+\r
+      CopyMem (OutPublic->publicArea.unique.ecc.x.buffer, Buffer, OutPublic->publicArea.unique.ecc.x.size);\r
+      Buffer                                 += OutPublic->publicArea.unique.ecc.x.size;\r
+      OutPublic->publicArea.unique.ecc.y.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
+      Buffer                                 += sizeof (UINT16);\r
+      if (OutPublic->publicArea.unique.ecc.y.size > MAX_ECC_KEY_BYTES) {\r
+        DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - ecc.y.size error %x\n", OutPublic->publicArea.unique.ecc.y.size));\r
+        return EFI_DEVICE_ERROR;\r
+      }\r
+\r
+      CopyMem (OutPublic->publicArea.unique.ecc.y.buffer, Buffer, OutPublic->publicArea.unique.ecc.y.size);\r
+      Buffer += OutPublic->publicArea.unique.ecc.y.size;\r
       break;\r
     default:\r
       return EFI_UNSUPPORTED;\r
-    }\r
-    break;\r
-  default:\r
-    return EFI_UNSUPPORTED;\r
-  }\r
-\r
-  // TPMU_PUBLIC_ID\r
-  switch (OutPublic->publicArea.type) {\r
-  case TPM_ALG_KEYEDHASH:\r
-    OutPublic->publicArea.unique.keyedHash.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    if(OutPublic->publicArea.unique.keyedHash.size > sizeof(TPMU_HA)) {\r
-      DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - keyedHash.size error %x\n", OutPublic->publicArea.unique.keyedHash.size));\r
-      return EFI_DEVICE_ERROR;\r
-    }\r
-    CopyMem (OutPublic->publicArea.unique.keyedHash.buffer, Buffer, OutPublic->publicArea.unique.keyedHash.size);\r
-    Buffer += OutPublic->publicArea.unique.keyedHash.size;\r
-    break;\r
-  case TPM_ALG_SYMCIPHER:\r
-    OutPublic->publicArea.unique.sym.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    if(OutPublic->publicArea.unique.sym.size > sizeof(TPMU_HA)) {\r
-      DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - sym.size error %x\n", OutPublic->publicArea.unique.sym.size));\r
-      return EFI_DEVICE_ERROR;\r
-    }\r
-    CopyMem (OutPublic->publicArea.unique.sym.buffer, Buffer, OutPublic->publicArea.unique.sym.size);\r
-    Buffer += OutPublic->publicArea.unique.sym.size;\r
-    break;\r
-  case TPM_ALG_RSA:\r
-    OutPublic->publicArea.unique.rsa.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    if(OutPublic->publicArea.unique.rsa.size > MAX_RSA_KEY_BYTES) {\r
-      DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - rsa.size error %x\n", OutPublic->publicArea.unique.rsa.size));\r
-      return EFI_DEVICE_ERROR;\r
-    }\r
-    CopyMem (OutPublic->publicArea.unique.rsa.buffer, Buffer, OutPublic->publicArea.unique.rsa.size);\r
-    Buffer += OutPublic->publicArea.unique.rsa.size;\r
-    break;\r
-  case TPM_ALG_ECC:\r
-    OutPublic->publicArea.unique.ecc.x.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    if (OutPublic->publicArea.unique.ecc.x.size > MAX_ECC_KEY_BYTES) {\r
-      DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - ecc.x.size error %x\n", OutPublic->publicArea.unique.ecc.x.size));\r
-      return EFI_DEVICE_ERROR;\r
-    }\r
-    CopyMem (OutPublic->publicArea.unique.ecc.x.buffer, Buffer, OutPublic->publicArea.unique.ecc.x.size);\r
-    Buffer += OutPublic->publicArea.unique.ecc.x.size;\r
-    OutPublic->publicArea.unique.ecc.y.size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)Buffer));\r
-    Buffer += sizeof(UINT16);\r
-    if (OutPublic->publicArea.unique.ecc.y.size > MAX_ECC_KEY_BYTES) {\r
-      DEBUG ((DEBUG_ERROR, "Tpm2ReadPublic - ecc.y.size error %x\n", OutPublic->publicArea.unique.ecc.y.size));\r
-      return EFI_DEVICE_ERROR;\r
-    }\r
-    CopyMem (OutPublic->publicArea.unique.ecc.y.buffer, Buffer, OutPublic->publicArea.unique.ecc.y.size);\r
-    Buffer += OutPublic->publicArea.unique.ecc.y.size;\r
-    break;\r
-  default:\r
-    return EFI_UNSUPPORTED;\r
   }\r
 \r
-  CopyMem (Name->name, (UINT8 *)&RecvBuffer + sizeof(TPM2_RESPONSE_HEADER) + sizeof(UINT16) + OutPublicSize + sizeof(UINT16), NameSize);\r
+  CopyMem (Name->name, (UINT8 *)&RecvBuffer + sizeof (TPM2_RESPONSE_HEADER) + sizeof (UINT16) + OutPublicSize + sizeof (UINT16), NameSize);\r
   Name->size = NameSize;\r
 \r
-  CopyMem (QualifiedName->name, (UINT8 *)&RecvBuffer + sizeof(TPM2_RESPONSE_HEADER) + sizeof(UINT16) + OutPublicSize + sizeof(UINT16) + NameSize + sizeof(UINT16), QualifiedNameSize);\r
+  CopyMem (QualifiedName->name, (UINT8 *)&RecvBuffer + sizeof (TPM2_RESPONSE_HEADER) + sizeof (UINT16) + OutPublicSize + sizeof (UINT16) + NameSize + sizeof (UINT16), QualifiedNameSize);\r
   QualifiedName->size = QualifiedNameSize;\r
 \r
   return EFI_SUCCESS;\r
index 3d99f0615c3554a2321d517b83ed7a76ff7cffcc..00ae39feb77b4b7aa83a0fd6a447062da569f1b6 100644 (file)
@@ -16,62 +16,62 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER  Header;\r
-  TPM2B_AUTH           Auth;\r
-  TPMI_ALG_HASH        HashAlg;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPM2B_AUTH             Auth;\r
+  TPMI_ALG_HASH          HashAlg;\r
 } TPM2_HASH_SEQUENCE_START_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER  Header;\r
-  TPMI_DH_OBJECT        SequenceHandle;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  TPMI_DH_OBJECT          SequenceHandle;\r
 } TPM2_HASH_SEQUENCE_START_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_DH_OBJECT            SequenceHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSessionSeq;\r
-  TPM2B_MAX_BUFFER          Buffer;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_DH_OBJECT         SequenceHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSessionSeq;\r
+  TPM2B_MAX_BUFFER       Buffer;\r
 } TPM2_SEQUENCE_UPDATE_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPMS_AUTH_RESPONSE         AuthSessionSeq;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPMS_AUTH_RESPONSE      AuthSessionSeq;\r
 } TPM2_SEQUENCE_UPDATE_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_DH_PCR               PcrHandle;\r
-  TPMI_DH_OBJECT            SequenceHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSessionPcr;\r
-  TPMS_AUTH_COMMAND         AuthSessionSeq;\r
-  TPM2B_MAX_BUFFER          Buffer;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_DH_PCR            PcrHandle;\r
+  TPMI_DH_OBJECT         SequenceHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSessionPcr;\r
+  TPMS_AUTH_COMMAND      AuthSessionSeq;\r
+  TPM2B_MAX_BUFFER       Buffer;\r
 } TPM2_EVENT_SEQUENCE_COMPLETE_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPML_DIGEST_VALUES         Results;\r
-  TPMS_AUTH_RESPONSE         AuthSessionPcr;\r
-  TPMS_AUTH_RESPONSE         AuthSessionSeq;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPML_DIGEST_VALUES      Results;\r
+  TPMS_AUTH_RESPONSE      AuthSessionPcr;\r
+  TPMS_AUTH_RESPONSE      AuthSessionSeq;\r
 } TPM2_EVENT_SEQUENCE_COMPLETE_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER       Header;\r
-  TPMI_DH_OBJECT            SequenceHandle;\r
-  UINT32                    AuthorizationSize;\r
-  TPMS_AUTH_COMMAND         AuthSessionSeq;\r
-  TPM2B_MAX_BUFFER          Buffer;\r
-  TPMI_RH_HIERARCHY         Hierarchy;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_DH_OBJECT         SequenceHandle;\r
+  UINT32                 AuthorizationSize;\r
+  TPMS_AUTH_COMMAND      AuthSessionSeq;\r
+  TPM2B_MAX_BUFFER       Buffer;\r
+  TPMI_RH_HIERARCHY      Hierarchy;\r
 } TPM2_SEQUENCE_COMPLETE_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER       Header;\r
-  UINT32                     ParameterSize;\r
-  TPM2B_DIGEST               Digest;\r
-  TPMS_AUTH_RESPONSE         AuthSessionSeq;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  UINT32                  ParameterSize;\r
+  TPM2B_DIGEST            Digest;\r
+  TPMS_AUTH_RESPONSE      AuthSessionSeq;\r
 } TPM2_SEQUENCE_COMPLETE_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -91,49 +91,49 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2HashSequenceStart (\r
-  IN TPMI_ALG_HASH   HashAlg,\r
-  OUT TPMI_DH_OBJECT *SequenceHandle\r
+  IN TPMI_ALG_HASH    HashAlg,\r
+  OUT TPMI_DH_OBJECT  *SequenceHandle\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_HASH_SEQUENCE_START_COMMAND  Cmd;\r
-  TPM2_HASH_SEQUENCE_START_RESPONSE Res;\r
-  UINT32                            CmdSize;\r
-  UINT32                            RespSize;\r
-  UINT8                             *Buffer;\r
-  UINT32                            ResultBufSize;\r
+  EFI_STATUS                         Status;\r
+  TPM2_HASH_SEQUENCE_START_COMMAND   Cmd;\r
+  TPM2_HASH_SEQUENCE_START_RESPONSE  Res;\r
+  UINT32                             CmdSize;\r
+  UINT32                             RespSize;\r
+  UINT8                              *Buffer;\r
+  UINT32                             ResultBufSize;\r
 \r
-  ZeroMem(&Cmd, sizeof(Cmd));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
 \r
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag         = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_HashSequenceStart);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_HashSequenceStart);\r
 \r
   Buffer = (UINT8 *)&Cmd.Auth;\r
 \r
   // auth = nullAuth\r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(0));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (0));\r
+  Buffer += sizeof (UINT16);\r
 \r
   // hashAlg\r
-  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16(HashAlg));\r
-  Buffer += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (HashAlg));\r
+  Buffer += sizeof (UINT16);\r
 \r
-  CmdSize = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(Buffer - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
   //\r
   // Call the TPM\r
   //\r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "HashSequenceStart: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -141,8 +141,8 @@ Tpm2HashSequenceStart (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "HashSequenceStart: Response size too large! %d\r\n", RespSize));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -150,8 +150,8 @@ Tpm2HashSequenceStart (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "HashSequenceStart: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "HashSequenceStart: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -160,7 +160,7 @@ Tpm2HashSequenceStart (
   //\r
 \r
   // sequenceHandle\r
-  *SequenceHandle = SwapBytes32(Res.SequenceHandle);\r
+  *SequenceHandle = SwapBytes32 (Res.SequenceHandle);\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -179,27 +179,27 @@ Tpm2HashSequenceStart (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SequenceUpdate (\r
-  IN TPMI_DH_OBJECT   SequenceHandle,\r
-  IN TPM2B_MAX_BUFFER *Buffer\r
+  IN TPMI_DH_OBJECT    SequenceHandle,\r
+  IN TPM2B_MAX_BUFFER  *Buffer\r
   )\r
 {\r
-  EFI_STATUS                    Status;\r
-  TPM2_SEQUENCE_UPDATE_COMMAND  Cmd;\r
-  TPM2_SEQUENCE_UPDATE_RESPONSE Res;\r
-  UINT32                        CmdSize;\r
-  UINT32                        RespSize;\r
-  UINT8                         *BufferPtr;\r
-  UINT32                        SessionInfoSize;\r
-  UINT32                        ResultBufSize;\r
+  EFI_STATUS                     Status;\r
+  TPM2_SEQUENCE_UPDATE_COMMAND   Cmd;\r
+  TPM2_SEQUENCE_UPDATE_RESPONSE  Res;\r
+  UINT32                         CmdSize;\r
+  UINT32                         RespSize;\r
+  UINT8                          *BufferPtr;\r
+  UINT32                         SessionInfoSize;\r
+  UINT32                         ResultBufSize;\r
 \r
-  ZeroMem(&Cmd, sizeof(Cmd));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
 \r
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_SequenceUpdate);\r
-  Cmd.SequenceHandle = SwapBytes32(SequenceHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_SequenceUpdate);\r
+  Cmd.SequenceHandle     = SwapBytes32 (SequenceHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -207,30 +207,30 @@ Tpm2SequenceUpdate (
   BufferPtr = (UINT8 *)&Cmd.AuthSessionSeq;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (NULL, BufferPtr);\r
-  BufferPtr += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (NULL, BufferPtr);\r
+  BufferPtr            += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
   // buffer.size\r
-  WriteUnaligned16 ((UINT16 *)BufferPtr, SwapBytes16(Buffer->size));\r
-  BufferPtr += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)BufferPtr, SwapBytes16 (Buffer->size));\r
+  BufferPtr += sizeof (UINT16);\r
 \r
-  CopyMem(BufferPtr, &Buffer->buffer, Buffer->size);\r
+  CopyMem (BufferPtr, &Buffer->buffer, Buffer->size);\r
   BufferPtr += Buffer->size;\r
 \r
-  CmdSize = (UINT32)(BufferPtr - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(BufferPtr - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
   //\r
   // Call the TPM\r
   //\r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd,&ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "SequenceUpdate: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -238,8 +238,8 @@ Tpm2SequenceUpdate (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "SequenceUpdate: Response size too large! %d\r\n", RespSize));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -247,8 +247,8 @@ Tpm2SequenceUpdate (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "SequenceUpdate: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "SequenceUpdate: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -278,33 +278,33 @@ Tpm2SequenceUpdate (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2EventSequenceComplete (\r
-  IN TPMI_DH_PCR         PcrHandle,\r
-  IN TPMI_DH_OBJECT      SequenceHandle,\r
-  IN TPM2B_MAX_BUFFER    *Buffer,\r
-  OUT TPML_DIGEST_VALUES *Results\r
+  IN TPMI_DH_PCR          PcrHandle,\r
+  IN TPMI_DH_OBJECT       SequenceHandle,\r
+  IN TPM2B_MAX_BUFFER     *Buffer,\r
+  OUT TPML_DIGEST_VALUES  *Results\r
   )\r
 {\r
-  EFI_STATUS                            Status;\r
-  TPM2_EVENT_SEQUENCE_COMPLETE_COMMAND  Cmd;\r
-  TPM2_EVENT_SEQUENCE_COMPLETE_RESPONSE Res;\r
-  UINT32                                CmdSize;\r
-  UINT32                                RespSize;\r
-  UINT8                                 *BufferPtr;\r
-  UINT32                                SessionInfoSize;\r
-  UINT32                                SessionInfoSize2;\r
-  UINT32                                Index;\r
-  UINT32                                ResultBufSize;\r
-  UINT16                                DigestSize;\r
+  EFI_STATUS                             Status;\r
+  TPM2_EVENT_SEQUENCE_COMPLETE_COMMAND   Cmd;\r
+  TPM2_EVENT_SEQUENCE_COMPLETE_RESPONSE  Res;\r
+  UINT32                                 CmdSize;\r
+  UINT32                                 RespSize;\r
+  UINT8                                  *BufferPtr;\r
+  UINT32                                 SessionInfoSize;\r
+  UINT32                                 SessionInfoSize2;\r
+  UINT32                                 Index;\r
+  UINT32                                 ResultBufSize;\r
+  UINT16                                 DigestSize;\r
 \r
-  ZeroMem(&Cmd, sizeof(Cmd));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
 \r
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_EventSequenceComplete);\r
-  Cmd.PcrHandle = SwapBytes32(PcrHandle);\r
-  Cmd.SequenceHandle = SwapBytes32(SequenceHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_EventSequenceComplete);\r
+  Cmd.PcrHandle          = SwapBytes32 (PcrHandle);\r
+  Cmd.SequenceHandle     = SwapBytes32 (SequenceHandle);\r
 \r
   //\r
   // Add in pcrHandle Auth session\r
@@ -313,33 +313,33 @@ Tpm2EventSequenceComplete (
 \r
   // sessionInfoSize\r
   SessionInfoSize = CopyAuthSessionCommand (NULL, BufferPtr);\r
-  BufferPtr += SessionInfoSize;\r
+  BufferPtr      += SessionInfoSize;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize2 = CopyAuthSessionCommand (NULL, BufferPtr);\r
-  BufferPtr += SessionInfoSize2;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize + SessionInfoSize2);\r
+  SessionInfoSize2      = CopyAuthSessionCommand (NULL, BufferPtr);\r
+  BufferPtr            += SessionInfoSize2;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize + SessionInfoSize2);\r
 \r
   // buffer.size\r
-  WriteUnaligned16 ((UINT16 *)BufferPtr, SwapBytes16(Buffer->size));\r
-  BufferPtr += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)BufferPtr, SwapBytes16 (Buffer->size));\r
+  BufferPtr += sizeof (UINT16);\r
 \r
-  CopyMem(BufferPtr, &Buffer->buffer[0], Buffer->size);\r
+  CopyMem (BufferPtr, &Buffer->buffer[0], Buffer->size);\r
   BufferPtr += Buffer->size;\r
 \r
-  CmdSize = (UINT32)(BufferPtr - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(BufferPtr - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
   //\r
   // Call the TPM\r
   //\r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "EventSequenceComplete: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -347,8 +347,8 @@ Tpm2EventSequenceComplete (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "EventSequenceComplete: Response size too large! %d\r\n", RespSize));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -356,8 +356,8 @@ Tpm2EventSequenceComplete (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "EventSequenceComplete: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "EventSequenceComplete: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -368,24 +368,25 @@ Tpm2EventSequenceComplete (
   BufferPtr = (UINT8 *)&Res.Results;\r
 \r
   // count\r
-  Results->count = SwapBytes32(ReadUnaligned32 ((UINT32 *)BufferPtr));\r
+  Results->count = SwapBytes32 (ReadUnaligned32 ((UINT32 *)BufferPtr));\r
   if (Results->count > HASH_COUNT) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2EventSequenceComplete - Results->count error %x\n", Results->count));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  BufferPtr += sizeof(UINT32);\r
+  BufferPtr += sizeof (UINT32);\r
 \r
   for (Index = 0; Index < Results->count; Index++) {\r
-    Results->digests[Index].hashAlg = SwapBytes16(ReadUnaligned16 ((UINT16 *)BufferPtr));\r
-    BufferPtr += sizeof(UINT16);\r
+    Results->digests[Index].hashAlg = SwapBytes16 (ReadUnaligned16 ((UINT16 *)BufferPtr));\r
+    BufferPtr                      += sizeof (UINT16);\r
 \r
     DigestSize = GetHashSizeFromAlgo (Results->digests[Index].hashAlg);\r
     if (DigestSize == 0) {\r
       DEBUG ((DEBUG_ERROR, "EventSequenceComplete: Unknown hash algorithm %d\r\n", Results->digests[Index].hashAlg));\r
       return EFI_DEVICE_ERROR;\r
     }\r
-    CopyMem(\r
+\r
+    CopyMem (\r
       &Results->digests[Index].digest,\r
       BufferPtr,\r
       DigestSize\r
@@ -409,28 +410,28 @@ Tpm2EventSequenceComplete (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SequenceComplete (\r
-  IN TPMI_DH_OBJECT      SequenceHandle,\r
-  IN TPM2B_MAX_BUFFER    *Buffer,\r
-  OUT TPM2B_DIGEST       *Result\r
+  IN TPMI_DH_OBJECT    SequenceHandle,\r
+  IN TPM2B_MAX_BUFFER  *Buffer,\r
+  OUT TPM2B_DIGEST     *Result\r
   )\r
 {\r
-  EFI_STATUS                            Status;\r
-  TPM2_SEQUENCE_COMPLETE_COMMAND        Cmd;\r
-  TPM2_SEQUENCE_COMPLETE_RESPONSE       Res;\r
-  UINT32                                CmdSize;\r
-  UINT32                                RespSize;\r
-  UINT8                                 *BufferPtr;\r
-  UINT32                                SessionInfoSize;\r
-  UINT32                                ResultBufSize;\r
+  EFI_STATUS                       Status;\r
+  TPM2_SEQUENCE_COMPLETE_COMMAND   Cmd;\r
+  TPM2_SEQUENCE_COMPLETE_RESPONSE  Res;\r
+  UINT32                           CmdSize;\r
+  UINT32                           RespSize;\r
+  UINT8                            *BufferPtr;\r
+  UINT32                           SessionInfoSize;\r
+  UINT32                           ResultBufSize;\r
 \r
-  ZeroMem(&Cmd, sizeof(Cmd));\r
+  ZeroMem (&Cmd, sizeof (Cmd));\r
 \r
   //\r
   // Construct command\r
   //\r
-  Cmd.Header.tag = SwapBytes16(TPM_ST_SESSIONS);\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_SequenceComplete);\r
-  Cmd.SequenceHandle = SwapBytes32(SequenceHandle);\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_SESSIONS);\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_SequenceComplete);\r
+  Cmd.SequenceHandle     = SwapBytes32 (SequenceHandle);\r
 \r
   //\r
   // Add in Auth session\r
@@ -438,34 +439,34 @@ Tpm2SequenceComplete (
   BufferPtr = (UINT8 *)&Cmd.AuthSessionSeq;\r
 \r
   // sessionInfoSize\r
-  SessionInfoSize = CopyAuthSessionCommand (NULL, BufferPtr);\r
-  BufferPtr += SessionInfoSize;\r
-  Cmd.AuthorizationSize = SwapBytes32(SessionInfoSize);\r
+  SessionInfoSize       = CopyAuthSessionCommand (NULL, BufferPtr);\r
+  BufferPtr            += SessionInfoSize;\r
+  Cmd.AuthorizationSize = SwapBytes32 (SessionInfoSize);\r
 \r
   // buffer.size\r
-  WriteUnaligned16 ((UINT16 *)BufferPtr, SwapBytes16(Buffer->size));\r
-  BufferPtr += sizeof(UINT16);\r
+  WriteUnaligned16 ((UINT16 *)BufferPtr, SwapBytes16 (Buffer->size));\r
+  BufferPtr += sizeof (UINT16);\r
 \r
-  CopyMem(BufferPtr, &Buffer->buffer[0], Buffer->size);\r
+  CopyMem (BufferPtr, &Buffer->buffer[0], Buffer->size);\r
   BufferPtr += Buffer->size;\r
 \r
   // Hierarchy\r
   WriteUnaligned32 ((UINT32 *)BufferPtr, SwapBytes32 (TPM_RH_NULL));\r
   BufferPtr += sizeof (UINT32);\r
 \r
-  CmdSize = (UINT32)(BufferPtr - (UINT8 *)&Cmd);\r
-  Cmd.Header.paramSize = SwapBytes32(CmdSize);\r
+  CmdSize              = (UINT32)(BufferPtr - (UINT8 *)&Cmd);\r
+  Cmd.Header.paramSize = SwapBytes32 (CmdSize);\r
 \r
   //\r
   // Call the TPM\r
   //\r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (CmdSize, (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (ResultBufSize > sizeof(Res)) {\r
+  if (ResultBufSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "SequenceComplete: Failed ExecuteCommand: Buffer Too Small\r\n"));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -473,8 +474,8 @@ Tpm2SequenceComplete (
   //\r
   // Validate response headers\r
   //\r
-  RespSize = SwapBytes32(Res.Header.paramSize);\r
-  if (RespSize > sizeof(Res)) {\r
+  RespSize = SwapBytes32 (Res.Header.paramSize);\r
+  if (RespSize > sizeof (Res)) {\r
     DEBUG ((DEBUG_ERROR, "SequenceComplete: Response size too large! %d\r\n", RespSize));\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -482,8 +483,8 @@ Tpm2SequenceComplete (
   //\r
   // Fail if command failed\r
   //\r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "SequenceComplete: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "SequenceComplete: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -494,15 +495,15 @@ Tpm2SequenceComplete (
   BufferPtr = (UINT8 *)&Res.Digest;\r
 \r
   // digestSize\r
-  Result->size = SwapBytes16(ReadUnaligned16 ((UINT16 *)BufferPtr));\r
-  if (Result->size > sizeof(TPMU_HA)){\r
+  Result->size = SwapBytes16 (ReadUnaligned16 ((UINT16 *)BufferPtr));\r
+  if (Result->size > sizeof (TPMU_HA)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2SequenceComplete - Result->size error %x\n", Result->size));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  BufferPtr += sizeof(UINT16);\r
+  BufferPtr += sizeof (UINT16);\r
 \r
-  CopyMem(\r
+  CopyMem (\r
     Result->buffer,\r
     BufferPtr,\r
     Result->size\r
index 4ca616188c2fa0a6330d0136bd89f5a2318d9b9f..7f247da301fe9a9d3f0ce6718a7dae39ab406396 100644 (file)
@@ -27,9 +27,9 @@ typedef struct {
 } TPM2_START_AUTH_SESSION_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER      Header;\r
-  TPMI_SH_AUTH_SESSION      SessionHandle;\r
-  TPM2B_NONCE               NonceTPM;\r
+  TPM2_RESPONSE_HEADER    Header;\r
+  TPMI_SH_AUTH_SESSION    SessionHandle;\r
+  TPM2B_NONCE             NonceTPM;\r
 } TPM2_START_AUTH_SESSION_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -54,15 +54,15 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2StartAuthSession (\r
-  IN      TPMI_DH_OBJECT            TpmKey,\r
-  IN      TPMI_DH_ENTITY            Bind,\r
-  IN      TPM2B_NONCE               *NonceCaller,\r
-  IN      TPM2B_ENCRYPTED_SECRET    *Salt,\r
-  IN      TPM_SE                    SessionType,\r
-  IN      TPMT_SYM_DEF              *Symmetric,\r
-  IN      TPMI_ALG_HASH             AuthHash,\r
-     OUT  TPMI_SH_AUTH_SESSION      *SessionHandle,\r
-     OUT  TPM2B_NONCE               *NonceTPM\r
+  IN      TPMI_DH_OBJECT          TpmKey,\r
+  IN      TPMI_DH_ENTITY          Bind,\r
+  IN      TPM2B_NONCE             *NonceCaller,\r
+  IN      TPM2B_ENCRYPTED_SECRET  *Salt,\r
+  IN      TPM_SE                  SessionType,\r
+  IN      TPMT_SYM_DEF            *Symmetric,\r
+  IN      TPMI_ALG_HASH           AuthHash,\r
+  OUT  TPMI_SH_AUTH_SESSION       *SessionHandle,\r
+  OUT  TPM2B_NONCE                *NonceTPM\r
   )\r
 {\r
   EFI_STATUS                        Status;\r
@@ -75,20 +75,20 @@ Tpm2StartAuthSession (
   //\r
   // Construct command\r
   //\r
-  SendBuffer.Header.tag = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  SendBuffer.Header.commandCode = SwapBytes32(TPM_CC_StartAuthSession);\r
+  SendBuffer.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  SendBuffer.Header.commandCode = SwapBytes32 (TPM_CC_StartAuthSession);\r
 \r
   SendBuffer.TpmKey = SwapBytes32 (TpmKey);\r
-  SendBuffer.Bind = SwapBytes32 (Bind);\r
-  Buffer = (UINT8 *)&SendBuffer.NonceCaller;\r
+  SendBuffer.Bind   = SwapBytes32 (Bind);\r
+  Buffer            = (UINT8 *)&SendBuffer.NonceCaller;\r
 \r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (NonceCaller->size));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Buffer, NonceCaller->buffer, NonceCaller->size);\r
   Buffer += NonceCaller->size;\r
 \r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Salt->size));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   CopyMem (Buffer, Salt->secret, Salt->size);\r
   Buffer += Salt->size;\r
 \r
@@ -96,49 +96,49 @@ Tpm2StartAuthSession (
   Buffer++;\r
 \r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->algorithm));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
   switch (Symmetric->algorithm) {\r
-  case TPM_ALG_NULL:\r
-    break;\r
-  case TPM_ALG_AES:\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->keyBits.aes));\r
-    Buffer += sizeof(UINT16);\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->mode.aes));\r
-    Buffer += sizeof(UINT16);\r
-    break;\r
-  case TPM_ALG_SM4:\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->keyBits.SM4));\r
-    Buffer += sizeof(UINT16);\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->mode.SM4));\r
-    Buffer += sizeof(UINT16);\r
-    break;\r
-  case TPM_ALG_SYMCIPHER:\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->keyBits.sym));\r
-    Buffer += sizeof(UINT16);\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->mode.sym));\r
-    Buffer += sizeof(UINT16);\r
-    break;\r
-  case TPM_ALG_XOR:\r
-    WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->keyBits.xor));\r
-    Buffer += sizeof(UINT16);\r
-    break;\r
-  default:\r
-    ASSERT (FALSE);\r
-    DEBUG ((DEBUG_ERROR, "Tpm2StartAuthSession - Symmetric->algorithm - %x\n", Symmetric->algorithm));\r
-    return EFI_UNSUPPORTED;\r
+    case TPM_ALG_NULL:\r
+      break;\r
+    case TPM_ALG_AES:\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->keyBits.aes));\r
+      Buffer += sizeof (UINT16);\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->mode.aes));\r
+      Buffer += sizeof (UINT16);\r
+      break;\r
+    case TPM_ALG_SM4:\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->keyBits.SM4));\r
+      Buffer += sizeof (UINT16);\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->mode.SM4));\r
+      Buffer += sizeof (UINT16);\r
+      break;\r
+    case TPM_ALG_SYMCIPHER:\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->keyBits.sym));\r
+      Buffer += sizeof (UINT16);\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->mode.sym));\r
+      Buffer += sizeof (UINT16);\r
+      break;\r
+    case TPM_ALG_XOR:\r
+      WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Symmetric->keyBits.xor));\r
+      Buffer += sizeof (UINT16);\r
+      break;\r
+    default:\r
+      ASSERT (FALSE);\r
+      DEBUG ((DEBUG_ERROR, "Tpm2StartAuthSession - Symmetric->algorithm - %x\n", Symmetric->algorithm));\r
+      return EFI_UNSUPPORTED;\r
   }\r
 \r
   WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (AuthHash));\r
-  Buffer += sizeof(UINT16);\r
+  Buffer += sizeof (UINT16);\r
 \r
-  SendBufferSize = (UINT32) ((UINTN)Buffer - (UINTN)&SendBuffer);\r
+  SendBufferSize              = (UINT32)((UINTN)Buffer - (UINTN)&SendBuffer);\r
   SendBuffer.Header.paramSize = SwapBytes32 (SendBufferSize);\r
 \r
   //\r
   // send Tpm command\r
   //\r
   RecvBufferSize = sizeof (RecvBuffer);\r
-  Status = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
+  Status         = Tpm2SubmitCommand (SendBufferSize, (UINT8 *)&SendBuffer, &RecvBufferSize, (UINT8 *)&RecvBuffer);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -147,8 +147,9 @@ Tpm2StartAuthSession (
     DEBUG ((DEBUG_ERROR, "Tpm2StartAuthSession - RecvBufferSize Error - %x\n", RecvBufferSize));\r
     return EFI_DEVICE_ERROR;\r
   }\r
-  if (SwapBytes32(RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2StartAuthSession - responseCode - %x\n", SwapBytes32(RecvBuffer.Header.responseCode)));\r
+\r
+  if (SwapBytes32 (RecvBuffer.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2StartAuthSession - responseCode - %x\n", SwapBytes32 (RecvBuffer.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
@@ -157,7 +158,7 @@ Tpm2StartAuthSession (
   //\r
   *SessionHandle = SwapBytes32 (RecvBuffer.SessionHandle);\r
   NonceTPM->size = SwapBytes16 (RecvBuffer.NonceTPM.size);\r
-  if (NonceTPM->size > sizeof(TPMU_HA)) {\r
+  if (NonceTPM->size > sizeof (TPMU_HA)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2StartAuthSession - NonceTPM->size error %x\n", NonceTPM->size));\r
     return EFI_DEVICE_ERROR;\r
   }\r
index 645ac49b87abd6f14ef89985244cd333b35cabdd..745c53bc2974b872f963c9f3275842c1754c6d73 100644 (file)
@@ -17,21 +17,21 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER  Header;\r
-  TPM_SU               StartupType;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPM_SU                 StartupType;\r
 } TPM2_STARTUP_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER Header;\r
+  TPM2_RESPONSE_HEADER    Header;\r
 } TPM2_STARTUP_RESPONSE;\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER  Header;\r
-  TPM_SU               ShutdownType;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPM_SU                 ShutdownType;\r
 } TPM2_SHUTDOWN_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER Header;\r
+  TPM2_RESPONSE_HEADER    Header;\r
 } TPM2_SHUTDOWN_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -47,38 +47,38 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2Startup (\r
-  IN      TPM_SU             StartupType\r
+  IN      TPM_SU  StartupType\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_STARTUP_COMMAND              Cmd;\r
-  TPM2_STARTUP_RESPONSE             Res;\r
-  UINT32                            ResultBufSize;\r
-  TPM_RC                            ResponseCode;\r
-\r
-  Cmd.Header.tag         = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  Cmd.Header.paramSize   = SwapBytes32(sizeof(Cmd));\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_Startup);\r
-  Cmd.StartupType        = SwapBytes16(StartupType);\r
-\r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (sizeof(Cmd), (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  EFI_STATUS             Status;\r
+  TPM2_STARTUP_COMMAND   Cmd;\r
+  TPM2_STARTUP_RESPONSE  Res;\r
+  UINT32                 ResultBufSize;\r
+  TPM_RC                 ResponseCode;\r
+\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  Cmd.Header.paramSize   = SwapBytes32 (sizeof (Cmd));\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_Startup);\r
+  Cmd.StartupType        = SwapBytes16 (StartupType);\r
+\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (sizeof (Cmd), (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  ResponseCode = SwapBytes32(Res.Header.responseCode);\r
-  switch (ResponseCode)  {\r
-  case TPM_RC_SUCCESS:\r
-    DEBUG ((DEBUG_INFO, "TPM2Startup: TPM_RC_SUCCESS\n"));\r
-    return EFI_SUCCESS;\r
-  case TPM_RC_INITIALIZE:\r
-    // TPM_RC_INITIALIZE can be returned if Tpm2Startup is not required.\r
-    DEBUG ((DEBUG_INFO, "TPM2Startup: TPM_RC_INITIALIZE\n"));\r
-    return EFI_SUCCESS;\r
-  default:\r
-    DEBUG ((DEBUG_ERROR, "Tpm2Startup: Response Code error! 0x%08x\r\n", ResponseCode));\r
-    return EFI_DEVICE_ERROR;\r
+  ResponseCode = SwapBytes32 (Res.Header.responseCode);\r
+  switch (ResponseCode) {\r
+    case TPM_RC_SUCCESS:\r
+      DEBUG ((DEBUG_INFO, "TPM2Startup: TPM_RC_SUCCESS\n"));\r
+      return EFI_SUCCESS;\r
+    case TPM_RC_INITIALIZE:\r
+      // TPM_RC_INITIALIZE can be returned if Tpm2Startup is not required.\r
+      DEBUG ((DEBUG_INFO, "TPM2Startup: TPM_RC_INITIALIZE\n"));\r
+      return EFI_SUCCESS;\r
+    default:\r
+      DEBUG ((DEBUG_ERROR, "Tpm2Startup: Response Code error! 0x%08x\r\n", ResponseCode));\r
+      return EFI_DEVICE_ERROR;\r
   }\r
 }\r
 \r
@@ -93,27 +93,27 @@ Tpm2Startup (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2Shutdown (\r
-  IN      TPM_SU             ShutdownType\r
+  IN      TPM_SU  ShutdownType\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_SHUTDOWN_COMMAND             Cmd;\r
-  TPM2_SHUTDOWN_RESPONSE            Res;\r
-  UINT32                            ResultBufSize;\r
-\r
-  Cmd.Header.tag         = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  Cmd.Header.paramSize   = SwapBytes32(sizeof(Cmd));\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_Shutdown);\r
-  Cmd.ShutdownType       = SwapBytes16(ShutdownType);\r
-\r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (sizeof(Cmd), (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
-  if (EFI_ERROR(Status)) {\r
+  EFI_STATUS              Status;\r
+  TPM2_SHUTDOWN_COMMAND   Cmd;\r
+  TPM2_SHUTDOWN_RESPONSE  Res;\r
+  UINT32                  ResultBufSize;\r
+\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  Cmd.Header.paramSize   = SwapBytes32 (sizeof (Cmd));\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_Shutdown);\r
+  Cmd.ShutdownType       = SwapBytes16 (ShutdownType);\r
+\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (sizeof (Cmd), (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (SwapBytes32(Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
-    DEBUG ((DEBUG_ERROR, "Tpm2Shutdown: Response Code error! 0x%08x\r\n", SwapBytes32(Res.Header.responseCode)));\r
+  if (SwapBytes32 (Res.Header.responseCode) != TPM_RC_SUCCESS) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2Shutdown: Response Code error! 0x%08x\r\n", SwapBytes32 (Res.Header.responseCode)));\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
index 78f8feba8197a757aeb684910c2de904af6cf500..070485a7ae7090501e870d634b82fe8e26b835d4 100644 (file)
@@ -16,12 +16,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  TPM2_COMMAND_HEADER  Header;\r
-  TPMI_YES_NO          FullTest;\r
+  TPM2_COMMAND_HEADER    Header;\r
+  TPMI_YES_NO            FullTest;\r
 } TPM2_SELF_TEST_COMMAND;\r
 \r
 typedef struct {\r
-  TPM2_RESPONSE_HEADER Header;\r
+  TPM2_RESPONSE_HEADER    Header;\r
 } TPM2_SELF_TEST_RESPONSE;\r
 \r
 #pragma pack()\r
@@ -40,21 +40,21 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SelfTest (\r
-  IN TPMI_YES_NO          FullTest\r
+  IN TPMI_YES_NO  FullTest\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM2_SELF_TEST_COMMAND            Cmd;\r
-  TPM2_SELF_TEST_RESPONSE           Res;\r
-  UINT32                            ResultBufSize;\r
-\r
-  Cmd.Header.tag         = SwapBytes16(TPM_ST_NO_SESSIONS);\r
-  Cmd.Header.paramSize   = SwapBytes32(sizeof(Cmd));\r
-  Cmd.Header.commandCode = SwapBytes32(TPM_CC_SelfTest);\r
+  EFI_STATUS               Status;\r
+  TPM2_SELF_TEST_COMMAND   Cmd;\r
+  TPM2_SELF_TEST_RESPONSE  Res;\r
+  UINT32                   ResultBufSize;\r
+\r
+  Cmd.Header.tag         = SwapBytes16 (TPM_ST_NO_SESSIONS);\r
+  Cmd.Header.paramSize   = SwapBytes32 (sizeof (Cmd));\r
+  Cmd.Header.commandCode = SwapBytes32 (TPM_CC_SelfTest);\r
   Cmd.FullTest           = FullTest;\r
 \r
-  ResultBufSize = sizeof(Res);\r
-  Status = Tpm2SubmitCommand (sizeof(Cmd), (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
+  ResultBufSize = sizeof (Res);\r
+  Status        = Tpm2SubmitCommand (sizeof (Cmd), (UINT8 *)&Cmd, &ResultBufSize, (UINT8 *)&Res);\r
 \r
   return Status;\r
 }\r
index 238389dbdb1b6df3b622495cd71a6f2b0f2d1e32..7cc55df4365b57242d66358e03d57a9f1cd28b96 100644 (file)
@@ -30,10 +30,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 DTpm2SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   );\r
 \r
 /**\r
@@ -64,10 +64,10 @@ DTpm2RequestUseTpm (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   )\r
 {\r
   return DTpm2SubmitCommand (\r
@@ -106,7 +106,7 @@ Tpm2RequestUseTpm (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2RegisterTpm2DeviceLib (\r
-  IN TPM2_DEVICE_INTERFACE   *Tpm2Device\r
+  IN TPM2_DEVICE_INTERFACE  *Tpm2Device\r
   )\r
 {\r
   return EFI_UNSUPPORTED;\r
index 9fff98952251005ab25b6e7f6d2485fbef4379d0..d703f15a2fbb943c5712f9ed130110c854c68568 100644 (file)
@@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 TPM2_PTP_INTERFACE_TYPE\r
 Tpm2GetPtpInterface (\r
-  IN VOID *Register\r
+  IN VOID  *Register\r
   );\r
 \r
 /**\r
@@ -31,7 +31,7 @@ Tpm2GetPtpInterface (
 **/\r
 UINT8\r
 Tpm2GetIdleByPass (\r
-  IN VOID *Register\r
+  IN VOID  *Register\r
   );\r
 \r
 /**\r
index bc35e257e105c322613c5ac4c591112556ad89b1..12079416954fd1e5cc2b313c17409c462aabde95 100644 (file)
@@ -22,7 +22,7 @@ GetCachedIdleByPass (
   VOID\r
   )\r
 {\r
-  return PcdGet8(PcdCRBIdleByPass);\r
+  return PcdGet8 (PcdCRBIdleByPass);\r
 }\r
 \r
 /**\r
@@ -35,7 +35,7 @@ GetCachedPtpInterface (
   VOID\r
   )\r
 {\r
-  return PcdGet8(PcdActiveTpmInterfaceType);\r
+  return PcdGet8 (PcdActiveTpmInterfaceType);\r
 }\r
 \r
 /**\r
@@ -54,14 +54,14 @@ InternalTpm2DeviceLibDTpmCommonConstructor (
   //\r
   // Cache current active TpmInterfaceType only when needed\r
   //\r
-  if (PcdGet8(PcdActiveTpmInterfaceType) == 0xFF) {\r
-    PtpInterface = Tpm2GetPtpInterface ((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
-    PcdSet8S(PcdActiveTpmInterfaceType, PtpInterface);\r
+  if (PcdGet8 (PcdActiveTpmInterfaceType) == 0xFF) {\r
+    PtpInterface = Tpm2GetPtpInterface ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
+    PcdSet8S (PcdActiveTpmInterfaceType, PtpInterface);\r
   }\r
 \r
-  if (PcdGet8(PcdActiveTpmInterfaceType) == Tpm2PtpInterfaceCrb && PcdGet8(PcdCRBIdleByPass) == 0xFF) {\r
-    IdleByPass = Tpm2GetIdleByPass((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
-    PcdSet8S(PcdCRBIdleByPass, IdleByPass);\r
+  if ((PcdGet8 (PcdActiveTpmInterfaceType) == Tpm2PtpInterfaceCrb) && (PcdGet8 (PcdCRBIdleByPass) == 0xFF)) {\r
+    IdleByPass = Tpm2GetIdleByPass ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
+    PcdSet8S (PcdCRBIdleByPass, IdleByPass);\r
   }\r
 \r
   return EFI_SUCCESS;\r
index eac866d2a77a6059e7c6c35aef2abb1093d6704a..f56edc8bafc27a08657271f3b98ee7375f4cc8b6 100644 (file)
@@ -51,15 +51,15 @@ InternalTpm2DeviceLibDTpmCommonConstructor (
   )\r
 {\r
   mActiveTpmInterfaceType = 0xFF;\r
-  mCRBIdleByPass = 0xFF;\r
+  mCRBIdleByPass          = 0xFF;\r
 \r
   //\r
   // Always cache current active TpmInterfaceType for StandaloneMm implementation\r
   //\r
-  mActiveTpmInterfaceType = Tpm2GetPtpInterface ((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
+  mActiveTpmInterfaceType = Tpm2GetPtpInterface ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
 \r
   if (mActiveTpmInterfaceType == Tpm2PtpInterfaceCrb) {\r
-    mCRBIdleByPass = Tpm2GetIdleByPass((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
+    mCRBIdleByPass = Tpm2GetIdleByPass ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
   }\r
 \r
   return EFI_SUCCESS;\r
index 053e597d2ee22e70ac4d5c7593cac66169e3b496..7d3e4bef86052a6d79363a50bff8ddc2b4e115f6 100644 (file)
@@ -25,7 +25,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 VOID\r
 DumpPtpInfo (\r
-  IN VOID *Register\r
+  IN VOID  *Register\r
   );\r
 \r
 /**\r
@@ -43,10 +43,10 @@ DumpPtpInfo (
 EFI_STATUS\r
 EFIAPI\r
 DTpm2SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   );\r
 \r
 /**\r
@@ -79,7 +79,7 @@ Tpm2InstanceLibDTpmConstructor (
   VOID\r
   )\r
 {\r
-  EFI_STATUS               Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = Tpm2RegisterTpm2DeviceLib (&mDTpm2InternalTpm2Device);\r
   if ((Status == EFI_SUCCESS) || (Status == EFI_UNSUPPORTED)) {\r
@@ -88,9 +88,11 @@ Tpm2InstanceLibDTpmConstructor (
     //\r
     if (Status == EFI_SUCCESS) {\r
       Status = InternalTpm2DeviceLibDTpmCommonConstructor ();\r
-      DumpPtpInfo ((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
+      DumpPtpInfo ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
     }\r
+\r
     return EFI_SUCCESS;\r
   }\r
+\r
   return Status;\r
 }\r
index 5ceb6c8466d59c24db64e2b61fbd0d7a7c609c71..40ab998004e255bcec27bf701d8c6e394d263f72 100644 (file)
@@ -26,12 +26,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Execution of the command may take from several seconds to minutes for certain\r
 // commands, such as key generation.\r
 //\r
-#define PTP_TIMEOUT_MAX             (90000 * 1000)  // 90s\r
+#define PTP_TIMEOUT_MAX  (90000 * 1000)             // 90s\r
 \r
 //\r
 // Max TPM command/response length\r
 //\r
-#define TPMCMDBUFLENGTH             0x500\r
+#define TPMCMDBUFLENGTH  0x500\r
 \r
 /**\r
   Check whether TPM PTP register exist.\r
@@ -43,10 +43,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 BOOLEAN\r
 Tpm2IsPtpPresence (\r
-  IN VOID *Reg\r
+  IN VOID  *Reg\r
   )\r
 {\r
-  UINT8                             RegRead;\r
+  UINT8  RegRead;\r
 \r
   RegRead = MmioRead8 ((UINTN)Reg);\r
   if (RegRead == 0xFF) {\r
@@ -55,6 +55,7 @@ Tpm2IsPtpPresence (
     //\r
     return FALSE;\r
   }\r
+\r
   return TRUE;\r
 }\r
 \r
@@ -71,22 +72,24 @@ Tpm2IsPtpPresence (
 **/\r
 EFI_STATUS\r
 PtpCrbWaitRegisterBits (\r
-  IN      UINT32                    *Register,\r
-  IN      UINT32                    BitSet,\r
-  IN      UINT32                    BitClear,\r
-  IN      UINT32                    TimeOut\r
+  IN      UINT32  *Register,\r
+  IN      UINT32  BitSet,\r
+  IN      UINT32  BitClear,\r
+  IN      UINT32  TimeOut\r
   )\r
 {\r
-  UINT32                            RegRead;\r
-  UINT32                            WaitTime;\r
+  UINT32  RegRead;\r
+  UINT32  WaitTime;\r
 \r
-  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30){\r
+  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30) {\r
     RegRead = MmioRead32 ((UINTN)Register);\r
-    if ((RegRead & BitSet) == BitSet && (RegRead & BitClear) == 0) {\r
+    if (((RegRead & BitSet) == BitSet) && ((RegRead & BitClear) == 0)) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     MicroSecondDelay (30);\r
   }\r
+\r
   return EFI_TIMEOUT;\r
 }\r
 \r
@@ -102,16 +105,16 @@ PtpCrbWaitRegisterBits (
 **/\r
 EFI_STATUS\r
 PtpCrbRequestUseTpm (\r
-  IN      PTP_CRB_REGISTERS_PTR      CrbReg\r
+  IN      PTP_CRB_REGISTERS_PTR  CrbReg\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (!Tpm2IsPtpPresence (CrbReg)) {\r
     return EFI_NOT_FOUND;\r
   }\r
 \r
-  MmioWrite32((UINTN)&CrbReg->LocalityControl, PTP_CRB_LOCALITY_CONTROL_REQUEST_ACCESS);\r
+  MmioWrite32 ((UINTN)&CrbReg->LocalityControl, PTP_CRB_LOCALITY_CONTROL_REQUEST_ACCESS);\r
   Status = PtpCrbWaitRegisterBits (\r
              &CrbReg->LocalityStatus,\r
              PTP_CRB_LOCALITY_STATUS_GRANTED,\r
@@ -138,52 +141,55 @@ PtpCrbRequestUseTpm (
 **/\r
 EFI_STATUS\r
 PtpCrbTpmCommand (\r
-  IN     PTP_CRB_REGISTERS_PTR      CrbReg,\r
-  IN     UINT8                      *BufferIn,\r
-  IN     UINT32                     SizeIn,\r
-  IN OUT UINT8                      *BufferOut,\r
-  IN OUT UINT32                     *SizeOut\r
+  IN     PTP_CRB_REGISTERS_PTR  CrbReg,\r
+  IN     UINT8                  *BufferIn,\r
+  IN     UINT32                 SizeIn,\r
+  IN OUT UINT8                  *BufferOut,\r
+  IN OUT UINT32                 *SizeOut\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINT32                            Index;\r
-  UINT32                            TpmOutSize;\r
-  UINT16                            Data16;\r
-  UINT32                            Data32;\r
+  EFI_STATUS  Status;\r
+  UINT32      Index;\r
+  UINT32      TpmOutSize;\r
+  UINT16      Data16;\r
+  UINT32      Data32;\r
 \r
   DEBUG_CODE_BEGIN ();\r
-    UINTN  DebugSize;\r
+  UINTN  DebugSize;\r
 \r
-    DEBUG ((DEBUG_VERBOSE, "PtpCrbTpmCommand Send - "));\r
-    if (SizeIn > 0x100) {\r
-      DebugSize = 0x40;\r
-    } else {\r
-      DebugSize = SizeIn;\r
-    }\r
-    for (Index = 0; Index < DebugSize; Index++) {\r
+  DEBUG ((DEBUG_VERBOSE, "PtpCrbTpmCommand Send - "));\r
+  if (SizeIn > 0x100) {\r
+    DebugSize = 0x40;\r
+  } else {\r
+    DebugSize = SizeIn;\r
+  }\r
+\r
+  for (Index = 0; Index < DebugSize; Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
+  }\r
+\r
+  if (DebugSize != SizeIn) {\r
+    DEBUG ((DEBUG_VERBOSE, "...... "));\r
+    for (Index = SizeIn - 0x20; Index < SizeIn; Index++) {\r
       DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
     }\r
-    if (DebugSize != SizeIn) {\r
-      DEBUG ((DEBUG_VERBOSE, "...... "));\r
-      for (Index = SizeIn - 0x20; Index < SizeIn; Index++) {\r
-        DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
-      }\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
-  TpmOutSize         = 0;\r
+  TpmOutSize = 0;\r
 \r
   //\r
   // STEP 0:\r
   // if CapCRbIdelByPass == 0, enforce Idle state before sending command\r
   //\r
-  if (GetCachedIdleByPass () == 0 && (MmioRead32((UINTN)&CrbReg->CrbControlStatus) & PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE) == 0){\r
+  if ((GetCachedIdleByPass () == 0) && ((MmioRead32 ((UINTN)&CrbReg->CrbControlStatus) & PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE) == 0)) {\r
     Status = PtpCrbWaitRegisterBits (\r
-              &CrbReg->CrbControlStatus,\r
-              PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE,\r
-              0,\r
-              PTP_TIMEOUT_C\r
-              );\r
+               &CrbReg->CrbControlStatus,\r
+               PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE,\r
+               0,\r
+               PTP_TIMEOUT_C\r
+               );\r
     if (EFI_ERROR (Status)) {\r
       //\r
       // Try to goIdle to recover TPM\r
@@ -199,7 +205,7 @@ PtpCrbTpmCommand (
   // of 1 by software to Request.cmdReady, as indicated by the Status field\r
   // being cleared to 0.\r
   //\r
-  MmioWrite32((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_COMMAND_READY);\r
+  MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_COMMAND_READY);\r
   Status = PtpCrbWaitRegisterBits (\r
              &CrbReg->CrbControlRequest,\r
              0,\r
@@ -210,6 +216,7 @@ PtpCrbTpmCommand (
     Status = EFI_DEVICE_ERROR;\r
     goto GoIdle_Exit;\r
   }\r
+\r
   Status = PtpCrbWaitRegisterBits (\r
              &CrbReg->CrbControlStatus,\r
              0,\r
@@ -230,19 +237,20 @@ PtpCrbTpmCommand (
   for (Index = 0; Index < SizeIn; Index++) {\r
     MmioWrite8 ((UINTN)&CrbReg->CrbDataBuffer[Index], BufferIn[Index]);\r
   }\r
+\r
   MmioWrite32 ((UINTN)&CrbReg->CrbControlCommandAddressHigh, (UINT32)RShiftU64 ((UINTN)CrbReg->CrbDataBuffer, 32));\r
   MmioWrite32 ((UINTN)&CrbReg->CrbControlCommandAddressLow, (UINT32)(UINTN)CrbReg->CrbDataBuffer);\r
-  MmioWrite32 ((UINTN)&CrbReg->CrbControlCommandSize, sizeof(CrbReg->CrbDataBuffer));\r
+  MmioWrite32 ((UINTN)&CrbReg->CrbControlCommandSize, sizeof (CrbReg->CrbDataBuffer));\r
 \r
   MmioWrite64 ((UINTN)&CrbReg->CrbControlResponseAddrss, (UINT32)(UINTN)CrbReg->CrbDataBuffer);\r
-  MmioWrite32 ((UINTN)&CrbReg->CrbControlResponseSize, sizeof(CrbReg->CrbDataBuffer));\r
+  MmioWrite32 ((UINTN)&CrbReg->CrbControlResponseSize, sizeof (CrbReg->CrbDataBuffer));\r
 \r
   //\r
   // STEP 3:\r
   // Command Execution occurs after receipt of a 1 to Start and the TPM\r
   // clearing Start to 0.\r
   //\r
-  MmioWrite32((UINTN)&CrbReg->CrbControlStart, PTP_CRB_CONTROL_START);\r
+  MmioWrite32 ((UINTN)&CrbReg->CrbControlStart, PTP_CRB_CONTROL_START);\r
   Status = PtpCrbWaitRegisterBits (\r
              &CrbReg->CrbControlStart,\r
              0,\r
@@ -254,16 +262,16 @@ PtpCrbTpmCommand (
     // Command Completion check timeout. Cancel the currently executing command by writing TPM_CRB_CTRL_CANCEL,\r
     // Expect TPM_RC_CANCELLED or successfully completed response.\r
     //\r
-    MmioWrite32((UINTN)&CrbReg->CrbControlCancel, PTP_CRB_CONTROL_CANCEL);\r
+    MmioWrite32 ((UINTN)&CrbReg->CrbControlCancel, PTP_CRB_CONTROL_CANCEL);\r
     Status = PtpCrbWaitRegisterBits (\r
                &CrbReg->CrbControlStart,\r
                0,\r
                PTP_CRB_CONTROL_START,\r
                PTP_TIMEOUT_B\r
                );\r
-    MmioWrite32((UINTN)&CrbReg->CrbControlCancel, 0);\r
+    MmioWrite32 ((UINTN)&CrbReg->CrbControlCancel, 0);\r
 \r
-    if (EFI_ERROR(Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       //\r
       // Still in Command Execution state. Try to goIdle, the behavior is agnostic.\r
       //\r
@@ -285,12 +293,14 @@ PtpCrbTpmCommand (
   for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) {\r
     BufferOut[Index] = MmioRead8 ((UINTN)&CrbReg->CrbDataBuffer[Index]);\r
   }\r
+\r
   DEBUG_CODE_BEGIN ();\r
-    DEBUG ((DEBUG_VERBOSE, "PtpCrbTpmCommand ReceiveHeader - "));\r
-    for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) {\r
-      DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  DEBUG ((DEBUG_VERBOSE, "PtpCrbTpmCommand ReceiveHeader - "));\r
+  for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
   //\r
   // Check the response data header (tag, parasize and returncode)\r
@@ -304,7 +314,7 @@ PtpCrbTpmCommand (
   }\r
 \r
   CopyMem (&Data32, (BufferOut + 2), sizeof (UINT32));\r
-  TpmOutSize  = SwapBytes32 (Data32);\r
+  TpmOutSize = SwapBytes32 (Data32);\r
   if (*SizeOut < TpmOutSize) {\r
     //\r
     // Command completed, but buffer is not enough\r
@@ -312,6 +322,7 @@ PtpCrbTpmCommand (
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto GoReady_Exit;\r
   }\r
+\r
   *SizeOut = TpmOutSize;\r
   //\r
   // Continue reading the remaining data\r
@@ -321,11 +332,12 @@ PtpCrbTpmCommand (
   }\r
 \r
   DEBUG_CODE_BEGIN ();\r
-    DEBUG ((DEBUG_VERBOSE, "PtpCrbTpmCommand Receive - "));\r
-    for (Index = 0; Index < TpmOutSize; Index++) {\r
-      DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  DEBUG ((DEBUG_VERBOSE, "PtpCrbTpmCommand Receive - "));\r
+  for (Index = 0; Index < TpmOutSize; Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
 \r
 GoReady_Exit:\r
@@ -334,7 +346,7 @@ GoReady_Exit:
   // If not supported. flow down to GoIdle\r
   //\r
   if (GetCachedIdleByPass () == 1) {\r
-    MmioWrite32((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_COMMAND_READY);\r
+    MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_COMMAND_READY);\r
     return Status;\r
   }\r
 \r
@@ -347,13 +359,13 @@ GoIdle_Exit:
   //\r
   //  Return to Idle state by setting TPM_CRB_CTRL_STS_x.Status.goIdle to 1.\r
   //\r
-  MmioWrite32((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_GO_IDLE);\r
+  MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_GO_IDLE);\r
 \r
   //\r
   // Only enforce Idle state transition if execution fails when CRBIdleBypass==1\r
   // Leave regular Idle delay at the beginning of next command execution\r
   //\r
-  if (GetCachedIdleByPass () == 1){\r
+  if (GetCachedIdleByPass () == 1) {\r
     Status = PtpCrbWaitRegisterBits (\r
                &CrbReg->CrbControlStatus,\r
                PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE,\r
@@ -382,11 +394,11 @@ GoIdle_Exit:
 **/\r
 EFI_STATUS\r
 Tpm2TisTpmCommand (\r
-  IN     TIS_PC_REGISTERS_PTR       TisReg,\r
-  IN     UINT8                      *BufferIn,\r
-  IN     UINT32                     SizeIn,\r
-  IN OUT UINT8                      *BufferOut,\r
-  IN OUT UINT32                     *SizeOut\r
+  IN     TIS_PC_REGISTERS_PTR  TisReg,\r
+  IN     UINT8                 *BufferIn,\r
+  IN     UINT32                SizeIn,\r
+  IN OUT UINT8                 *BufferOut,\r
+  IN OUT UINT32                *SizeOut\r
   );\r
 \r
 /**\r
@@ -402,7 +414,7 @@ Tpm2TisTpmCommand (
 **/\r
 EFI_STATUS\r
 TisPcRequestUseTpm (\r
-  IN     TIS_PC_REGISTERS_PTR       TisReg\r
+  IN     TIS_PC_REGISTERS_PTR  TisReg\r
   );\r
 \r
 /**\r
@@ -414,32 +426,37 @@ TisPcRequestUseTpm (
 **/\r
 TPM2_PTP_INTERFACE_TYPE\r
 Tpm2GetPtpInterface (\r
-  IN VOID *Register\r
+  IN VOID  *Register\r
   )\r
 {\r
-  PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;\r
-  PTP_FIFO_INTERFACE_CAPABILITY InterfaceCapability;\r
+  PTP_CRB_INTERFACE_IDENTIFIER   InterfaceId;\r
+  PTP_FIFO_INTERFACE_CAPABILITY  InterfaceCapability;\r
 \r
   if (!Tpm2IsPtpPresence (Register)) {\r
     return Tpm2PtpInterfaceMax;\r
   }\r
+\r
   //\r
   // Check interface id\r
   //\r
-  InterfaceId.Uint32 = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);\r
+  InterfaceId.Uint32         = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);\r
   InterfaceCapability.Uint32 = MmioRead32 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->InterfaceCapability);\r
 \r
   if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_CRB) &&\r
       (InterfaceId.Bits.InterfaceVersion == PTP_INTERFACE_IDENTIFIER_INTERFACE_VERSION_CRB) &&\r
-      (InterfaceId.Bits.CapCRB != 0)) {\r
+      (InterfaceId.Bits.CapCRB != 0))\r
+  {\r
     return Tpm2PtpInterfaceCrb;\r
   }\r
+\r
   if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_FIFO) &&\r
       (InterfaceId.Bits.InterfaceVersion == PTP_INTERFACE_IDENTIFIER_INTERFACE_VERSION_FIFO) &&\r
       (InterfaceId.Bits.CapFIFO != 0) &&\r
-      (InterfaceCapability.Bits.InterfaceVersion == INTERFACE_CAPABILITY_INTERFACE_VERSION_PTP)) {\r
+      (InterfaceCapability.Bits.InterfaceVersion == INTERFACE_CAPABILITY_INTERFACE_VERSION_PTP))\r
+  {\r
     return Tpm2PtpInterfaceFifo;\r
   }\r
+\r
   return Tpm2PtpInterfaceTis;\r
 }\r
 \r
@@ -452,7 +469,7 @@ Tpm2GetPtpInterface (
 **/\r
 UINT8\r
 Tpm2GetIdleByPass (\r
-  IN VOID *Register\r
+  IN VOID  *Register\r
   )\r
 {\r
   PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;\r
@@ -472,24 +489,24 @@ Tpm2GetIdleByPass (
 **/\r
 VOID\r
 DumpPtpInfo (\r
-  IN VOID *Register\r
+  IN VOID  *Register\r
   )\r
 {\r
-  PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;\r
-  PTP_FIFO_INTERFACE_CAPABILITY InterfaceCapability;\r
-  UINT8                         StatusEx;\r
-  UINT16                        Vid;\r
-  UINT16                        Did;\r
-  UINT8                         Rid;\r
-  TPM2_PTP_INTERFACE_TYPE       PtpInterface;\r
+  PTP_CRB_INTERFACE_IDENTIFIER   InterfaceId;\r
+  PTP_FIFO_INTERFACE_CAPABILITY  InterfaceCapability;\r
+  UINT8                          StatusEx;\r
+  UINT16                         Vid;\r
+  UINT16                         Did;\r
+  UINT8                          Rid;\r
+  TPM2_PTP_INTERFACE_TYPE        PtpInterface;\r
 \r
   if (!Tpm2IsPtpPresence (Register)) {\r
-    return ;\r
+    return;\r
   }\r
 \r
-  InterfaceId.Uint32 = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);\r
+  InterfaceId.Uint32         = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);\r
   InterfaceCapability.Uint32 = MmioRead32 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->InterfaceCapability);\r
-  StatusEx = MmioRead8 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->StatusEx);\r
+  StatusEx                   = MmioRead8 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->StatusEx);\r
 \r
   //\r
   // Dump InterfaceId Register for PTP\r
@@ -507,7 +524,8 @@ DumpPtpInfo (
   //\r
   DEBUG ((DEBUG_INFO, "InterfaceCapability - 0x%08x\n", InterfaceCapability.Uint32));\r
   if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_TIS) ||\r
-      (InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_FIFO)) {\r
+      (InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_FIFO))\r
+  {\r
     DEBUG ((DEBUG_INFO, "  InterfaceVersion - 0x%x\n", InterfaceCapability.Bits.InterfaceVersion));\r
   }\r
 \r
@@ -519,26 +537,27 @@ DumpPtpInfo (
     DEBUG ((DEBUG_INFO, "  TpmFamily - 0x%x\n", (StatusEx & PTP_FIFO_STS_EX_TPM_FAMILY) >> PTP_FIFO_STS_EX_TPM_FAMILY_OFFSET));\r
   }\r
 \r
-  Vid = 0xFFFF;\r
-  Did = 0xFFFF;\r
-  Rid = 0xFF;\r
+  Vid          = 0xFFFF;\r
+  Did          = 0xFFFF;\r
+  Rid          = 0xFF;\r
   PtpInterface = GetCachedPtpInterface ();\r
   DEBUG ((DEBUG_INFO, "PtpInterface - %x\n", PtpInterface));\r
   switch (PtpInterface) {\r
-  case Tpm2PtpInterfaceCrb:\r
-    Vid = MmioRead16 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->Vid);\r
-    Did = MmioRead16 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->Did);\r
-    Rid = (UINT8)InterfaceId.Bits.Rid;\r
-    break;\r
-  case Tpm2PtpInterfaceFifo:\r
-  case Tpm2PtpInterfaceTis:\r
-    Vid = MmioRead16 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->Vid);\r
-    Did = MmioRead16 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->Did);\r
-    Rid = MmioRead8 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->Rid);\r
-    break;\r
-  default:\r
-    break;\r
+    case Tpm2PtpInterfaceCrb:\r
+      Vid = MmioRead16 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->Vid);\r
+      Did = MmioRead16 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->Did);\r
+      Rid = (UINT8)InterfaceId.Bits.Rid;\r
+      break;\r
+    case Tpm2PtpInterfaceFifo:\r
+    case Tpm2PtpInterfaceTis:\r
+      Vid = MmioRead16 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->Vid);\r
+      Did = MmioRead16 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->Did);\r
+      Rid = MmioRead8 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->Rid);\r
+      break;\r
+    default:\r
+      break;\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "VID - 0x%04x\n", Vid));\r
   DEBUG ((DEBUG_INFO, "DID - 0x%04x\n", Did));\r
   DEBUG ((DEBUG_INFO, "RID - 0x%02x\n", Rid));\r
@@ -559,35 +578,35 @@ DumpPtpInfo (
 EFI_STATUS\r
 EFIAPI\r
 DTpm2SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   )\r
 {\r
   TPM2_PTP_INTERFACE_TYPE  PtpInterface;\r
 \r
   PtpInterface = GetCachedPtpInterface ();\r
   switch (PtpInterface) {\r
-  case Tpm2PtpInterfaceCrb:\r
-    return PtpCrbTpmCommand (\r
-           (PTP_CRB_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress),\r
-           InputParameterBlock,\r
-           InputParameterBlockSize,\r
-           OutputParameterBlock,\r
-           OutputParameterBlockSize\r
-           );\r
-  case Tpm2PtpInterfaceFifo:\r
-  case Tpm2PtpInterfaceTis:\r
-    return Tpm2TisTpmCommand (\r
-           (TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress),\r
-           InputParameterBlock,\r
-           InputParameterBlockSize,\r
-           OutputParameterBlock,\r
-           OutputParameterBlockSize\r
-           );\r
-  default:\r
-    return EFI_NOT_FOUND;\r
+    case Tpm2PtpInterfaceCrb:\r
+      return PtpCrbTpmCommand (\r
+               (PTP_CRB_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress),\r
+               InputParameterBlock,\r
+               InputParameterBlockSize,\r
+               OutputParameterBlock,\r
+               OutputParameterBlockSize\r
+               );\r
+    case Tpm2PtpInterfaceFifo:\r
+    case Tpm2PtpInterfaceTis:\r
+      return Tpm2TisTpmCommand (\r
+               (TIS_PC_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress),\r
+               InputParameterBlock,\r
+               InputParameterBlockSize,\r
+               OutputParameterBlock,\r
+               OutputParameterBlockSize\r
+               );\r
+    default:\r
+      return EFI_NOT_FOUND;\r
   }\r
 }\r
 \r
@@ -608,12 +627,12 @@ DTpm2RequestUseTpm (
 \r
   PtpInterface = GetCachedPtpInterface ();\r
   switch (PtpInterface) {\r
-  case Tpm2PtpInterfaceCrb:\r
-    return PtpCrbRequestUseTpm ((PTP_CRB_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
-  case Tpm2PtpInterfaceFifo:\r
-  case Tpm2PtpInterfaceTis:\r
-    return TisPcRequestUseTpm ((TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
-  default:\r
-    return EFI_NOT_FOUND;\r
+    case Tpm2PtpInterfaceCrb:\r
+      return PtpCrbRequestUseTpm ((PTP_CRB_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
+    case Tpm2PtpInterfaceFifo:\r
+    case Tpm2PtpInterfaceTis:\r
+      return TisPcRequestUseTpm ((TIS_PC_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
+    default:\r
+      return EFI_NOT_FOUND;\r
   }\r
 }\r
index a3c84d8ab491ebb6487cecbc223080f8c61b7d23..49539b78d84db7a54d60f4a3db6a43aa35b2c008 100644 (file)
@@ -19,12 +19,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include <IndustryStandard/TpmTis.h>\r
 \r
-#define TIS_TIMEOUT_MAX             (90000 * 1000)  // 90s\r
+#define TIS_TIMEOUT_MAX  (90000 * 1000)             // 90s\r
 \r
 //\r
 // Max TPM command/response length\r
 //\r
-#define TPMCMDBUFLENGTH             0x500\r
+#define TPMCMDBUFLENGTH  0x500\r
 \r
 /**\r
   Check whether TPM chip exist.\r
@@ -36,10 +36,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 BOOLEAN\r
 TisPcPresenceCheck (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  UINT8                             RegRead;\r
+  UINT8  RegRead;\r
 \r
   RegRead = MmioRead8 ((UINTN)&TisReg->Access);\r
   return (BOOLEAN)(RegRead != (UINT8)-1);\r
@@ -58,21 +58,24 @@ TisPcPresenceCheck (
 **/\r
 EFI_STATUS\r
 TisPcWaitRegisterBits (\r
-  IN      UINT8                     *Register,\r
-  IN      UINT8                     BitSet,\r
-  IN      UINT8                     BitClear,\r
-  IN      UINT32                    TimeOut\r
+  IN      UINT8   *Register,\r
+  IN      UINT8   BitSet,\r
+  IN      UINT8   BitClear,\r
+  IN      UINT32  TimeOut\r
   )\r
 {\r
-  UINT8                             RegRead;\r
-  UINT32                            WaitTime;\r
+  UINT8   RegRead;\r
+  UINT32  WaitTime;\r
 \r
-  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30){\r
+  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30) {\r
     RegRead = MmioRead8 ((UINTN)Register);\r
-    if ((RegRead & BitSet) == BitSet && (RegRead & BitClear) == 0)\r
+    if (((RegRead & BitSet) == BitSet) && ((RegRead & BitClear) == 0)) {\r
       return EFI_SUCCESS;\r
+    }\r
+\r
     MicroSecondDelay (30);\r
   }\r
+\r
   return EFI_TIMEOUT;\r
 }\r
 \r
@@ -89,15 +92,15 @@ TisPcWaitRegisterBits (
 **/\r
 EFI_STATUS\r
 TisPcReadBurstCount (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg,\r
-     OUT  UINT16                    *BurstCount\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg,\r
+  OUT  UINT16                   *BurstCount\r
   )\r
 {\r
-  UINT32                            WaitTime;\r
-  UINT8                             DataByte0;\r
-  UINT8                             DataByte1;\r
+  UINT32  WaitTime;\r
+  UINT8   DataByte0;\r
+  UINT8   DataByte1;\r
 \r
-  if (BurstCount == NULL || TisReg == NULL) {\r
+  if ((BurstCount == NULL) || (TisReg == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -113,6 +116,7 @@ TisPcReadBurstCount (
     if (*BurstCount != 0) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     MicroSecondDelay (30);\r
     WaitTime += 30;\r
   } while (WaitTime < TIS_TIMEOUT_D);\r
@@ -132,16 +136,16 @@ TisPcReadBurstCount (
 **/\r
 EFI_STATUS\r
 TisPcPrepareCommand (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (TisReg == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  MmioWrite8((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
+  MmioWrite8 ((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
   Status = TisPcWaitRegisterBits (\r
              &TisReg->Status,\r
              TIS_PC_STS_READY,\r
@@ -164,10 +168,10 @@ TisPcPrepareCommand (
 **/\r
 EFI_STATUS\r
 TisPcRequestUseTpm (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (TisReg == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -177,7 +181,7 @@ TisPcRequestUseTpm (
     return EFI_NOT_FOUND;\r
   }\r
 \r
-  MmioWrite8((UINTN)&TisReg->Access, TIS_PC_ACC_RQUUSE);\r
+  MmioWrite8 ((UINTN)&TisReg->Access, TIS_PC_ACC_RQUUSE);\r
   Status = TisPcWaitRegisterBits (\r
              &TisReg->Access,\r
              (UINT8)(TIS_PC_ACC_ACTIVE |TIS_PC_VALID),\r
@@ -204,47 +208,51 @@ TisPcRequestUseTpm (
 **/\r
 EFI_STATUS\r
 Tpm2TisTpmCommand (\r
-  IN     TIS_PC_REGISTERS_PTR       TisReg,\r
-  IN     UINT8                      *BufferIn,\r
-  IN     UINT32                     SizeIn,\r
-  IN OUT UINT8                      *BufferOut,\r
-  IN OUT UINT32                     *SizeOut\r
+  IN     TIS_PC_REGISTERS_PTR  TisReg,\r
+  IN     UINT8                 *BufferIn,\r
+  IN     UINT32                SizeIn,\r
+  IN OUT UINT8                 *BufferOut,\r
+  IN OUT UINT32                *SizeOut\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINT16                            BurstCount;\r
-  UINT32                            Index;\r
-  UINT32                            TpmOutSize;\r
-  UINT16                            Data16;\r
-  UINT32                            Data32;\r
+  EFI_STATUS  Status;\r
+  UINT16      BurstCount;\r
+  UINT32      Index;\r
+  UINT32      TpmOutSize;\r
+  UINT16      Data16;\r
+  UINT32      Data32;\r
 \r
   DEBUG_CODE_BEGIN ();\r
-    UINTN  DebugSize;\r
+  UINTN  DebugSize;\r
 \r
-    DEBUG ((DEBUG_VERBOSE, "Tpm2TisTpmCommand Send - "));\r
-    if (SizeIn > 0x100) {\r
-      DebugSize = 0x40;\r
-    } else {\r
-      DebugSize = SizeIn;\r
-    }\r
-    for (Index = 0; Index < DebugSize; Index++) {\r
+  DEBUG ((DEBUG_VERBOSE, "Tpm2TisTpmCommand Send - "));\r
+  if (SizeIn > 0x100) {\r
+    DebugSize = 0x40;\r
+  } else {\r
+    DebugSize = SizeIn;\r
+  }\r
+\r
+  for (Index = 0; Index < DebugSize; Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
+  }\r
+\r
+  if (DebugSize != SizeIn) {\r
+    DEBUG ((DEBUG_VERBOSE, "...... "));\r
+    for (Index = SizeIn - 0x20; Index < SizeIn; Index++) {\r
       DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
     }\r
-    if (DebugSize != SizeIn) {\r
-      DEBUG ((DEBUG_VERBOSE, "...... "));\r
-      for (Index = SizeIn - 0x20; Index < SizeIn; Index++) {\r
-        DEBUG ((DEBUG_VERBOSE, "%02x ", BufferIn[Index]));\r
-      }\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
   TpmOutSize = 0;\r
 \r
   Status = TisPcPrepareCommand (TisReg);\r
-  if (EFI_ERROR (Status)){\r
+  if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2 is not ready for command!\n"));\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   //\r
   // Send the command data to Tpm\r
   //\r
@@ -255,17 +263,19 @@ Tpm2TisTpmCommand (
       Status = EFI_DEVICE_ERROR;\r
       goto Exit;\r
     }\r
-    for (; BurstCount > 0 && Index < SizeIn; BurstCount--) {\r
-      MmioWrite8((UINTN)&TisReg->DataFifo, *(BufferIn + Index));\r
+\r
+    for ( ; BurstCount > 0 && Index < SizeIn; BurstCount--) {\r
+      MmioWrite8 ((UINTN)&TisReg->DataFifo, *(BufferIn + Index));\r
       Index++;\r
     }\r
   }\r
+\r
   //\r
   // Check the Tpm status STS_EXPECT change from 1 to 0\r
   //\r
   Status = TisPcWaitRegisterBits (\r
              &TisReg->Status,\r
-             (UINT8) TIS_PC_VALID,\r
+             (UINT8)TIS_PC_VALID,\r
              TIS_PC_STS_EXPECT,\r
              TIS_TIMEOUT_C\r
              );\r
@@ -274,17 +284,18 @@ Tpm2TisTpmCommand (
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Exit;\r
   }\r
+\r
   //\r
   // Executed the TPM command and waiting for the response data ready\r
   //\r
-  MmioWrite8((UINTN)&TisReg->Status, TIS_PC_STS_GO);\r
+  MmioWrite8 ((UINTN)&TisReg->Status, TIS_PC_STS_GO);\r
 \r
   //\r
   // NOTE: That may take many seconds to minutes for certain commands, such as key generation.\r
   //\r
   Status = TisPcWaitRegisterBits (\r
              &TisReg->Status,\r
-             (UINT8) (TIS_PC_VALID | TIS_PC_STS_DATA),\r
+             (UINT8)(TIS_PC_VALID | TIS_PC_STS_DATA),\r
              0,\r
              TIS_TIMEOUT_MAX\r
              );\r
@@ -295,10 +306,10 @@ Tpm2TisTpmCommand (
     //\r
     DEBUG ((DEBUG_ERROR, "Wait for Tpm2 response data time out. Trying to cancel the command!!\n"));\r
 \r
-    MmioWrite32((UINTN)&TisReg->Status, TIS_PC_STS_CANCEL);\r
+    MmioWrite32 ((UINTN)&TisReg->Status, TIS_PC_STS_CANCEL);\r
     Status = TisPcWaitRegisterBits (\r
                &TisReg->Status,\r
-               (UINT8) (TIS_PC_VALID | TIS_PC_STS_DATA),\r
+               (UINT8)(TIS_PC_VALID | TIS_PC_STS_DATA),\r
                0,\r
                TIS_TIMEOUT_B\r
                );\r
@@ -318,7 +329,7 @@ Tpm2TisTpmCommand (
   //\r
   // Get response data header\r
   //\r
-  Index = 0;\r
+  Index      = 0;\r
   BurstCount = 0;\r
   while (Index < sizeof (TPM2_RESPONSE_HEADER)) {\r
     Status = TisPcReadBurstCount (TisReg, &BurstCount);\r
@@ -326,18 +337,23 @@ Tpm2TisTpmCommand (
       Status = EFI_DEVICE_ERROR;\r
       goto Exit;\r
     }\r
-    for (; BurstCount > 0; BurstCount--) {\r
+\r
+    for ( ; BurstCount > 0; BurstCount--) {\r
       *(BufferOut + Index) = MmioRead8 ((UINTN)&TisReg->DataFifo);\r
       Index++;\r
-      if (Index == sizeof (TPM2_RESPONSE_HEADER)) break;\r
+      if (Index == sizeof (TPM2_RESPONSE_HEADER)) {\r
+        break;\r
+      }\r
     }\r
   }\r
+\r
   DEBUG_CODE_BEGIN ();\r
-    DEBUG ((DEBUG_VERBOSE, "Tpm2TisTpmCommand ReceiveHeader - "));\r
-    for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) {\r
-      DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  DEBUG ((DEBUG_VERBOSE, "Tpm2TisTpmCommand ReceiveHeader - "));\r
+  for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
   //\r
   // Check the response data header (tag,parasize and returncode )\r
@@ -351,17 +367,18 @@ Tpm2TisTpmCommand (
   }\r
 \r
   CopyMem (&Data32, (BufferOut + 2), sizeof (UINT32));\r
-  TpmOutSize  = SwapBytes32 (Data32);\r
+  TpmOutSize = SwapBytes32 (Data32);\r
   if (*SizeOut < TpmOutSize) {\r
     Status = EFI_BUFFER_TOO_SMALL;\r
     goto Exit;\r
   }\r
+\r
   *SizeOut = TpmOutSize;\r
   //\r
   // Continue reading the remaining data\r
   //\r
   while ( Index < TpmOutSize ) {\r
-    for (; BurstCount > 0; BurstCount--) {\r
+    for ( ; BurstCount > 0; BurstCount--) {\r
       *(BufferOut + Index) = MmioRead8 ((UINTN)&TisReg->DataFifo);\r
       Index++;\r
       if (Index == TpmOutSize) {\r
@@ -369,21 +386,24 @@ Tpm2TisTpmCommand (
         goto Exit;\r
       }\r
     }\r
+\r
     Status = TisPcReadBurstCount (TisReg, &BurstCount);\r
     if (EFI_ERROR (Status)) {\r
       Status = EFI_DEVICE_ERROR;\r
       goto Exit;\r
     }\r
   }\r
+\r
 Exit:\r
   DEBUG_CODE_BEGIN ();\r
-    DEBUG ((DEBUG_VERBOSE, "Tpm2TisTpmCommand Receive - "));\r
-    for (Index = 0; Index < TpmOutSize; Index++) {\r
-      DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
-    }\r
-    DEBUG ((DEBUG_VERBOSE, "\n"));\r
+  DEBUG ((DEBUG_VERBOSE, "Tpm2TisTpmCommand Receive - "));\r
+  for (Index = 0; Index < TpmOutSize; Index++) {\r
+    DEBUG ((DEBUG_VERBOSE, "%02x ", BufferOut[Index]));\r
+  }\r
+\r
+  DEBUG ((DEBUG_VERBOSE, "\n"));\r
   DEBUG_CODE_END ();\r
-  MmioWrite8((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
+  MmioWrite8 ((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
   return Status;\r
 }\r
 \r
@@ -402,14 +422,14 @@ Exit:
 EFI_STATUS\r
 EFIAPI\r
 DTpm2TisSubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   )\r
 {\r
   return Tpm2TisTpmCommand (\r
-           (TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress),\r
+           (TIS_PC_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress),\r
            InputParameterBlock,\r
            InputParameterBlockSize,\r
            OutputParameterBlock,\r
@@ -430,5 +450,5 @@ DTpm2TisRequestUseTpm (
   VOID\r
   )\r
 {\r
-  return TisPcRequestUseTpm ((TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
+  return TisPcRequestUseTpm ((TIS_PC_REGISTERS_PTR)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
 }\r
index 227aa406bda2d1ade014653f48e7f91424f735be..de5293ee9eeb908be19fb00ffb637d84513ae2d3 100644 (file)
@@ -31,15 +31,16 @@ TPM2_DEVICE_INTERFACE  mInternalTpm2DeviceInterface;
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   )\r
 {\r
   if (mInternalTpm2DeviceInterface.Tpm2SubmitCommand == NULL) {\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   return mInternalTpm2DeviceInterface.Tpm2SubmitCommand (\r
                                         InputParameterBlockSize,\r
                                         InputParameterBlock,\r
@@ -64,6 +65,7 @@ Tpm2RequestUseTpm (
   if (mInternalTpm2DeviceInterface.Tpm2RequestUseTpm == NULL) {\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   return mInternalTpm2DeviceInterface.Tpm2RequestUseTpm ();\r
 }\r
 \r
@@ -79,14 +81,14 @@ Tpm2RequestUseTpm (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2RegisterTpm2DeviceLib (\r
-  IN TPM2_DEVICE_INTERFACE   *Tpm2Device\r
+  IN TPM2_DEVICE_INTERFACE  *Tpm2Device\r
   )\r
 {\r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &Tpm2Device->ProviderGuid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &Tpm2Device->ProviderGuid)) {\r
     DEBUG ((DEBUG_WARN, "WARNING: Tpm2RegisterTpm2DeviceLib - does not support %g registration\n", &Tpm2Device->ProviderGuid));\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
-  CopyMem (&mInternalTpm2DeviceInterface, Tpm2Device, sizeof(mInternalTpm2DeviceInterface));\r
+  CopyMem (&mInternalTpm2DeviceInterface, Tpm2Device, sizeof (mInternalTpm2DeviceInterface));\r
   return EFI_SUCCESS;\r
 }\r
index e24ef08515f8d9f0a0dab079fc1eba987c7865ca..1c9f54907ff4b5acb17091d779103ebe555cf40f 100644 (file)
@@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/PcdLib.h>\r
 #include <Library/Tpm2DeviceLib.h>\r
 \r
-EFI_GUID mInternalTpm2DeviceInterfaceGuid = {\r
+EFI_GUID  mInternalTpm2DeviceInterfaceGuid = {\r
   0x349cf818, 0xc0ba, 0x4c43, { 0x92, 0x9a, 0xc8, 0xa1, 0xb1, 0xb3, 0xd2, 0x55 }\r
 };\r
 \r
@@ -29,12 +29,13 @@ InternalGetTpm2DeviceInterface (
   VOID\r
   )\r
 {\r
-  EFI_HOB_GUID_TYPE *Hob;\r
+  EFI_HOB_GUID_TYPE  *Hob;\r
 \r
   Hob = GetFirstGuidHob (&mInternalTpm2DeviceInterfaceGuid);\r
   if (Hob == NULL) {\r
     return NULL;\r
   }\r
+\r
   return (TPM2_DEVICE_INTERFACE *)(Hob + 1);\r
 }\r
 \r
@@ -53,13 +54,13 @@ InternalGetTpm2DeviceInterface (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   )\r
 {\r
-  TPM2_DEVICE_INTERFACE *Tpm2DeviceInterface;\r
+  TPM2_DEVICE_INTERFACE  *Tpm2DeviceInterface;\r
 \r
   Tpm2DeviceInterface = InternalGetTpm2DeviceInterface ();\r
   if (Tpm2DeviceInterface == NULL) {\r
@@ -87,12 +88,13 @@ Tpm2RequestUseTpm (
   VOID\r
   )\r
 {\r
-  TPM2_DEVICE_INTERFACE *Tpm2DeviceInterface;\r
+  TPM2_DEVICE_INTERFACE  *Tpm2DeviceInterface;\r
 \r
   Tpm2DeviceInterface = InternalGetTpm2DeviceInterface ();\r
   if (Tpm2DeviceInterface == NULL) {\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   return Tpm2DeviceInterface->Tpm2RequestUseTpm ();\r
 }\r
 \r
@@ -108,12 +110,12 @@ Tpm2RequestUseTpm (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2RegisterTpm2DeviceLib (\r
-  IN TPM2_DEVICE_INTERFACE   *Tpm2Device\r
+  IN TPM2_DEVICE_INTERFACE  *Tpm2Device\r
   )\r
 {\r
-  TPM2_DEVICE_INTERFACE *Tpm2DeviceInterface;\r
+  TPM2_DEVICE_INTERFACE  *Tpm2DeviceInterface;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &Tpm2Device->ProviderGuid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &Tpm2Device->ProviderGuid)) {\r
     DEBUG ((DEBUG_WARN, "WARNING: Tpm2RegisterTpm2DeviceLib - does not support %g registration\n", &Tpm2Device->ProviderGuid));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -124,10 +126,10 @@ Tpm2RegisterTpm2DeviceLib (
     // In PEI phase, there will be shadow driver dispatched again.\r
     //\r
     DEBUG ((DEBUG_INFO, "Tpm2RegisterTpm2DeviceLib - Override\n"));\r
-    CopyMem (Tpm2DeviceInterface, Tpm2Device, sizeof(*Tpm2Device));\r
+    CopyMem (Tpm2DeviceInterface, Tpm2Device, sizeof (*Tpm2Device));\r
     return EFI_SUCCESS;\r
   } else {\r
-    Tpm2Device = BuildGuidDataHob (&mInternalTpm2DeviceInterfaceGuid, Tpm2Device, sizeof(*Tpm2Device));\r
+    Tpm2Device = BuildGuidDataHob (&mInternalTpm2DeviceInterfaceGuid, Tpm2Device, sizeof (*Tpm2Device));\r
     if (Tpm2Device != NULL) {\r
       return EFI_SUCCESS;\r
     } else {\r
index 9d12695a62581f527ed448d5e50b7753a8a2a106..3c8cf4fa117a9ffcc20c6ebdf2b0bf0528c4f176 100644 (file)
@@ -31,17 +31,17 @@ EFI_TCG2_PROTOCOL  *mTcg2Protocol = NULL;
 EFI_STATUS\r
 EFIAPI\r
 Tpm2SubmitCommand (\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN OUT UINT32        *OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN UINT32      InputParameterBlockSize,\r
+  IN UINT8       *InputParameterBlock,\r
+  IN OUT UINT32  *OutputParameterBlockSize,\r
+  IN UINT8       *OutputParameterBlock\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  TPM2_RESPONSE_HEADER      *Header;\r
+  EFI_STATUS            Status;\r
+  TPM2_RESPONSE_HEADER  *Header;\r
 \r
   if (mTcg2Protocol == NULL) {\r
-    Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **) &mTcg2Protocol);\r
+    Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **)&mTcg2Protocol);\r
     if (EFI_ERROR (Status)) {\r
       //\r
       // Tcg2 protocol is not installed. So, TPM2 is not present.\r
@@ -50,6 +50,7 @@ Tpm2SubmitCommand (
       return EFI_NOT_FOUND;\r
     }\r
   }\r
+\r
   //\r
   // Assume when Tcg2 Protocol is ready, RequestUseTpm already done.\r
   //\r
@@ -63,7 +64,8 @@ Tpm2SubmitCommand (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
-  Header = (TPM2_RESPONSE_HEADER *)OutputParameterBlock;\r
+\r
+  Header                    = (TPM2_RESPONSE_HEADER *)OutputParameterBlock;\r
   *OutputParameterBlockSize = SwapBytes32 (Header->paramSize);\r
 \r
   return EFI_SUCCESS;\r
@@ -82,10 +84,10 @@ Tpm2RequestUseTpm (
   VOID\r
   )\r
 {\r
-  EFI_STATUS   Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (mTcg2Protocol == NULL) {\r
-    Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **) &mTcg2Protocol);\r
+    Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **)&mTcg2Protocol);\r
     if (EFI_ERROR (Status)) {\r
       //\r
       // Tcg2 protocol is not installed. So, TPM2 is not present.\r
@@ -94,6 +96,7 @@ Tpm2RequestUseTpm (
       return EFI_NOT_FOUND;\r
     }\r
   }\r
+\r
   //\r
   // Assume when Tcg2 Protocol is ready, RequestUseTpm already done.\r
   //\r
@@ -112,7 +115,7 @@ Tpm2RequestUseTpm (
 EFI_STATUS\r
 EFIAPI\r
 Tpm2RegisterTpm2DeviceLib (\r
-  IN TPM2_DEVICE_INTERFACE   *Tpm2Device\r
+  IN TPM2_DEVICE_INTERFACE  *Tpm2Device\r
   )\r
 {\r
   return EFI_UNSUPPORTED;\r
index 533a42e53cee58c53b775cd92e85e40383d81070..20b5a21b3b3f52727a3a529949f1cf5ce14b2bdd 100644 (file)
@@ -18,10 +18,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 BOOLEAN\r
 TisPcPresenceCheck (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  UINT8                             RegRead;\r
+  UINT8  RegRead;\r
 \r
   RegRead = MmioRead8 ((UINTN)&TisReg->Access);\r
   return (BOOLEAN)(RegRead != (UINT8)-1);\r
@@ -41,21 +41,24 @@ TisPcPresenceCheck (
 EFI_STATUS\r
 EFIAPI\r
 TisPcWaitRegisterBits (\r
-  IN      UINT8                     *Register,\r
-  IN      UINT8                     BitSet,\r
-  IN      UINT8                     BitClear,\r
-  IN      UINT32                    TimeOut\r
+  IN      UINT8   *Register,\r
+  IN      UINT8   BitSet,\r
+  IN      UINT8   BitClear,\r
+  IN      UINT32  TimeOut\r
   )\r
 {\r
-  UINT8                             RegRead;\r
-  UINT32                            WaitTime;\r
+  UINT8   RegRead;\r
+  UINT32  WaitTime;\r
 \r
-  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30){\r
+  for (WaitTime = 0; WaitTime < TimeOut; WaitTime += 30) {\r
     RegRead = MmioRead8 ((UINTN)Register);\r
-    if ((RegRead & BitSet) == BitSet && (RegRead & BitClear) == 0)\r
+    if (((RegRead & BitSet) == BitSet) && ((RegRead & BitClear) == 0)) {\r
       return EFI_SUCCESS;\r
+    }\r
+\r
     MicroSecondDelay (30);\r
   }\r
+\r
   return EFI_TIMEOUT;\r
 }\r
 \r
@@ -73,15 +76,15 @@ TisPcWaitRegisterBits (
 EFI_STATUS\r
 EFIAPI\r
 TisPcReadBurstCount (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg,\r
-     OUT  UINT16                    *BurstCount\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg,\r
+  OUT  UINT16                   *BurstCount\r
   )\r
 {\r
-  UINT32                            WaitTime;\r
-  UINT8                             DataByte0;\r
-  UINT8                             DataByte1;\r
+  UINT32  WaitTime;\r
+  UINT8   DataByte0;\r
+  UINT8   DataByte1;\r
 \r
-  if (BurstCount == NULL || TisReg == NULL) {\r
+  if ((BurstCount == NULL) || (TisReg == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -97,6 +100,7 @@ TisPcReadBurstCount (
     if (*BurstCount != 0) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     MicroSecondDelay (30);\r
     WaitTime += 30;\r
   } while (WaitTime < TIS_TIMEOUT_D);\r
@@ -117,16 +121,16 @@ TisPcReadBurstCount (
 EFI_STATUS\r
 EFIAPI\r
 TisPcPrepareCommand (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (TisReg == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  MmioWrite8((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
+  MmioWrite8 ((UINTN)&TisReg->Status, TIS_PC_STS_READY);\r
   Status = TisPcWaitRegisterBits (\r
              &TisReg->Status,\r
              TIS_PC_STS_READY,\r
@@ -150,10 +154,10 @@ TisPcPrepareCommand (
 EFI_STATUS\r
 EFIAPI\r
 TisPcRequestUseTpm (\r
-  IN      TIS_PC_REGISTERS_PTR      TisReg\r
+  IN      TIS_PC_REGISTERS_PTR  TisReg\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (TisReg == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -163,7 +167,7 @@ TisPcRequestUseTpm (
     return EFI_NOT_FOUND;\r
   }\r
 \r
-  MmioWrite8((UINTN)&TisReg->Access, TIS_PC_ACC_RQUUSE);\r
+  MmioWrite8 ((UINTN)&TisReg->Access, TIS_PC_ACC_RQUUSE);\r
   //\r
   // No locality set before, ACCESS_X.activeLocality MUST be valid within TIMEOUT_A\r
   //\r
index dee64b24ffefbe0c409d10364006a9c01730c6f4..5285d72ece109989b6b48d7ac951c3e5c1e25a60 100644 (file)
@@ -21,13 +21,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 TpmCommHashAll (\r
-  IN  CONST UINT8                   *Data,\r
-  IN        UINTN                   DataLen,\r
-  OUT       TPM_DIGEST              *Digest\r
+  IN  CONST UINT8       *Data,\r
+  IN        UINTN       DataLen,\r
+  OUT       TPM_DIGEST  *Digest\r
   )\r
 {\r
-  VOID     *Sha1Ctx;\r
-  UINTN    CtxSize;\r
+  VOID   *Sha1Ctx;\r
+  UINTN  CtxSize;\r
 \r
   CtxSize = Sha1GetContextSize ();\r
   Sha1Ctx = AllocatePool (CtxSize);\r
@@ -41,4 +41,3 @@ TpmCommHashAll (
 \r
   return EFI_SUCCESS;\r
 }\r
-\r
index 3ddb37cabcb332cb5e2ea0ffa9c8f0922d457ae6..a08def767b5fa8ea739468ee773277e5371e0249 100644 (file)
@@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 GetVariableKey (\r
-      OUT VOID    **VariableKey,\r
-  IN  OUT UINTN   *VariableKeySize\r
+  OUT VOID       **VariableKey,\r
+  IN  OUT UINTN  *VariableKeySize\r
   )\r
 {\r
   ASSERT (FALSE);\r
@@ -64,4 +64,3 @@ LockVariableKeyInterface (
   ASSERT (FALSE);\r
   return EFI_UNSUPPORTED;\r
 }\r
-\r
index 42282e33a91349b57bbbc6ec9e1eaeb8d6111cfb..88d02b11b8f9f09301942c4b6fce65659810a733 100644 (file)
@@ -33,10 +33,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 BOOLEAN\r
 CalculateDataHash (\r
-  IN  VOID               *Data,\r
-  IN  UINTN              DataSize,\r
-  IN  EFI_GUID           *CertGuid,\r
-  OUT UINT8              *HashValue\r
+  IN  VOID      *Data,\r
+  IN  UINTN     DataSize,\r
+  IN  EFI_GUID  *CertGuid,\r
+  OUT UINT8     *HashValue\r
   )\r
 {\r
   BOOLEAN  Status;\r
@@ -55,10 +55,10 @@ CalculateDataHash (
     if (HashCtx == NULL) {\r
       goto _Exit;\r
     }\r
-    Status = Sha1Init   (HashCtx);\r
-    Status = Sha1Update (HashCtx, Data, DataSize);\r
-    Status = Sha1Final  (HashCtx, HashValue);\r
 \r
+    Status = Sha1Init (HashCtx);\r
+    Status = Sha1Update (HashCtx, Data, DataSize);\r
+    Status = Sha1Final (HashCtx, HashValue);\r
   } else if (CompareGuid (CertGuid, &gEfiCertSha256Guid)) {\r
     //\r
     // SHA256 Hash\r
@@ -68,10 +68,10 @@ CalculateDataHash (
     if (HashCtx == NULL) {\r
       goto _Exit;\r
     }\r
-    Status = Sha256Init   (HashCtx);\r
-    Status = Sha256Update (HashCtx, Data, DataSize);\r
-    Status = Sha256Final  (HashCtx, HashValue);\r
 \r
+    Status = Sha256Init (HashCtx);\r
+    Status = Sha256Update (HashCtx, Data, DataSize);\r
+    Status = Sha256Final (HashCtx, HashValue);\r
   } else if (CompareGuid (CertGuid, &gEfiCertSha384Guid)) {\r
     //\r
     // SHA384 Hash\r
@@ -81,10 +81,10 @@ CalculateDataHash (
     if (HashCtx == NULL) {\r
       goto _Exit;\r
     }\r
-    Status = Sha384Init   (HashCtx);\r
-    Status = Sha384Update (HashCtx, Data, DataSize);\r
-    Status = Sha384Final  (HashCtx, HashValue);\r
 \r
+    Status = Sha384Init (HashCtx);\r
+    Status = Sha384Update (HashCtx, Data, DataSize);\r
+    Status = Sha384Final (HashCtx, HashValue);\r
   } else if (CompareGuid (CertGuid, &gEfiCertSha512Guid)) {\r
     //\r
     // SHA512 Hash\r
@@ -94,9 +94,10 @@ CalculateDataHash (
     if (HashCtx == NULL) {\r
       goto _Exit;\r
     }\r
-    Status = Sha512Init   (HashCtx);\r
+\r
+    Status = Sha512Init (HashCtx);\r
     Status = Sha512Update (HashCtx, Data, DataSize);\r
-    Status = Sha512Final  (HashCtx, HashValue);\r
+    Status = Sha512Final (HashCtx, HashValue);\r
   }\r
 \r
 _Exit:\r
@@ -122,9 +123,9 @@ _Exit:
 **/\r
 BOOLEAN\r
 IsContentHashRevokedByHash (\r
-  IN  UINT8              *Hash,\r
-  IN  UINTN              HashSize,\r
-  IN  EFI_SIGNATURE_LIST **RevokedDb\r
+  IN  UINT8               *Hash,\r
+  IN  UINTN               HashSize,\r
+  IN  EFI_SIGNATURE_LIST  **RevokedDb\r
   )\r
 {\r
   EFI_SIGNATURE_LIST  *SigList;\r
@@ -155,17 +156,17 @@ IsContentHashRevokedByHash (
     //\r
     // Search the signature database to search the revoked content hash\r
     //\r
-    SigData    = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) +\r
-                                        SigList->SignatureHeaderSize);\r
+    SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) +\r
+                                     SigList->SignatureHeaderSize);\r
     EntryCount = (SigList->SignatureListSize - SigList->SignatureHeaderSize -\r
-                 sizeof (EFI_SIGNATURE_LIST)) / SigList->SignatureSize;\r
+                  sizeof (EFI_SIGNATURE_LIST)) / SigList->SignatureSize;\r
     for (EntryIndex = 0; EntryIndex < EntryCount; EntryIndex++) {\r
       //\r
       // The problem case.  There's a revocation hash but the sizes\r
       // don't match, meaning it's a different hash algorithm and we\r
       // can't tell if it's revoking our binary or not.  Assume not.\r
       //\r
-      if (SigList->SignatureSize - sizeof(EFI_GUID) == HashSize) {\r
+      if (SigList->SignatureSize - sizeof (EFI_GUID) == HashSize) {\r
         //\r
         // Compare Data Hash with Signature Data\r
         //\r
@@ -175,7 +176,7 @@ IsContentHashRevokedByHash (
         }\r
       }\r
 \r
-      SigData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigData + SigList->SignatureSize);\r
+      SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigData + SigList->SignatureSize);\r
     }\r
   }\r
 \r
@@ -198,9 +199,9 @@ _Exit:
 **/\r
 BOOLEAN\r
 IsContentHashRevoked (\r
-  IN  UINT8              *Content,\r
-  IN  UINTN              ContentSize,\r
-  IN  EFI_SIGNATURE_LIST **RevokedDb\r
+  IN  UINT8               *Content,\r
+  IN  UINTN               ContentSize,\r
+  IN  EFI_SIGNATURE_LIST  **RevokedDb\r
   )\r
 {\r
   EFI_SIGNATURE_LIST  *SigList;\r
@@ -242,10 +243,10 @@ IsContentHashRevoked (
     //\r
     // Search the signature database to search the revoked content hash\r
     //\r
-    SigData    = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) +\r
-                                        SigList->SignatureHeaderSize);\r
+    SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) +\r
+                                     SigList->SignatureHeaderSize);\r
     EntryCount = (SigList->SignatureListSize - SigList->SignatureHeaderSize -\r
-                 sizeof (EFI_SIGNATURE_LIST)) / SigList->SignatureSize;\r
+                  sizeof (EFI_SIGNATURE_LIST)) / SigList->SignatureSize;\r
     for (EntryIndex = 0; EntryIndex < EntryCount; EntryIndex++) {\r
       //\r
       // Compare Data Hash with Signature Data\r
@@ -255,7 +256,7 @@ IsContentHashRevoked (
         goto _Exit;\r
       }\r
 \r
-      SigData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigData + SigList->SignatureSize);\r
+      SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigData + SigList->SignatureSize);\r
     }\r
   }\r
 \r
@@ -279,10 +280,10 @@ _Exit:
 **/\r
 BOOLEAN\r
 IsCertHashRevoked (\r
-  IN  UINT8              *Certificate,\r
-  IN  UINTN              CertSize,\r
-  IN  EFI_SIGNATURE_LIST **RevokedDb,\r
-  OUT EFI_TIME           *RevocationTime\r
+  IN  UINT8               *Certificate,\r
+  IN  UINTN               CertSize,\r
+  IN  EFI_SIGNATURE_LIST  **RevokedDb,\r
+  OUT EFI_TIME            *RevocationTime\r
   )\r
 {\r
   BOOLEAN             Status;\r
@@ -308,7 +309,6 @@ IsCertHashRevoked (
 \r
   Status = FALSE;\r
   for (Index = 0; ; Index++) {\r
-\r
     SigList = (EFI_SIGNATURE_LIST *)(RevokedDb[Index]);\r
     //\r
     // The list is terminated by a NULL pointer.\r
@@ -323,13 +323,10 @@ IsCertHashRevoked (
     //\r
     if (CompareGuid (&SigList->SignatureType, &gEfiCertX509Sha256Guid)) {\r
       Status = CalculateDataHash (TBSCert, TBSCertSize, &gEfiCertSha256Guid, CertHashVal);\r
-\r
     } else if (CompareGuid (&SigList->SignatureType, &gEfiCertX509Sha384Guid)) {\r
       Status = CalculateDataHash (TBSCert, TBSCertSize, &gEfiCertSha384Guid, CertHashVal);\r
-\r
     } else if (CompareGuid (&SigList->SignatureType, &gEfiCertX509Sha512Guid)) {\r
       Status = CalculateDataHash (TBSCert, TBSCertSize, &gEfiCertSha512Guid, CertHashVal);\r
-\r
     } else {\r
       //\r
       // Un-matched Cert Hash GUID\r
@@ -341,16 +338,20 @@ IsCertHashRevoked (
       continue;\r
     }\r
 \r
-    SigData    = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) +\r
-                                      SigList->SignatureHeaderSize);\r
+    SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) +\r
+                                     SigList->SignatureHeaderSize);\r
     EntryCount = (SigList->SignatureListSize - SigList->SignatureHeaderSize -\r
                   sizeof (EFI_SIGNATURE_LIST)) / SigList->SignatureSize;\r
     for (EntryIndex = 0; EntryIndex < EntryCount; Index++) {\r
       //\r
       // Check if the Certificate Hash is revoked.\r
       //\r
-      if (CompareMem (SigData->SignatureData, CertHashVal,\r
-                      SigList->SignatureSize - sizeof (EFI_GUID) - sizeof (EFI_TIME)) == 0) {\r
+      if (CompareMem (\r
+            SigData->SignatureData,\r
+            CertHashVal,\r
+            SigList->SignatureSize - sizeof (EFI_GUID) - sizeof (EFI_TIME)\r
+            ) == 0)\r
+      {\r
         Status = TRUE;\r
         //\r
         // Return the revocation time of this revoked certificate.\r
@@ -363,7 +364,7 @@ IsCertHashRevoked (
         goto _Exit;\r
       }\r
 \r
-      SigData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigData + SigList->SignatureSize);\r
+      SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigData + SigList->SignatureSize);\r
     }\r
   }\r
 \r
@@ -382,11 +383,12 @@ _Exit:
 **/\r
 BOOLEAN\r
 IsTimeZero (\r
-  IN EFI_TIME            *Time\r
+  IN EFI_TIME  *Time\r
   )\r
 {\r
   if ((Time->Year == 0) && (Time->Month == 0) &&  (Time->Day == 0) &&\r
-      (Time->Hour == 0) && (Time->Minute == 0) && (Time->Second == 0)) {\r
+      (Time->Hour == 0) && (Time->Minute == 0) && (Time->Second == 0))\r
+  {\r
     return TRUE;\r
   }\r
 \r
@@ -405,23 +407,23 @@ IsTimeZero (
 **/\r
 BOOLEAN\r
 CompareTimestamp (\r
-  IN EFI_TIME            *SigningTime,\r
-  IN EFI_TIME            *RevocationTime\r
+  IN EFI_TIME  *SigningTime,\r
+  IN EFI_TIME  *RevocationTime\r
   )\r
 {\r
   if (SigningTime->Year != RevocationTime->Year) {\r
-    return (BOOLEAN) (SigningTime->Year < RevocationTime->Year);\r
+    return (BOOLEAN)(SigningTime->Year < RevocationTime->Year);\r
   } else if (SigningTime->Month != RevocationTime->Month) {\r
-    return (BOOLEAN) (SigningTime->Month < RevocationTime->Month);\r
+    return (BOOLEAN)(SigningTime->Month < RevocationTime->Month);\r
   } else if (SigningTime->Day != RevocationTime->Day) {\r
-    return (BOOLEAN) (SigningTime->Day < RevocationTime->Day);\r
+    return (BOOLEAN)(SigningTime->Day < RevocationTime->Day);\r
   } else if (SigningTime->Hour != RevocationTime->Hour) {\r
-    return (BOOLEAN) (SigningTime->Hour < RevocationTime->Hour);\r
+    return (BOOLEAN)(SigningTime->Hour < RevocationTime->Hour);\r
   } else if (SigningTime->Minute != RevocationTime->Minute) {\r
-    return (BOOLEAN) (SigningTime->Minute < RevocationTime->Minute);\r
+    return (BOOLEAN)(SigningTime->Minute < RevocationTime->Minute);\r
   }\r
 \r
-  return (BOOLEAN) (SigningTime->Second <= RevocationTime->Second);\r
+  return (BOOLEAN)(SigningTime->Second <= RevocationTime->Second);\r
 }\r
 \r
 /**\r
@@ -471,7 +473,7 @@ IsValidTimestamp (
   // from that time and onwards.\r
   //\r
   for (Index = 0; ; Index++) {\r
-    SigList = (EFI_SIGNATURE_LIST *) (TimeStampDb[Index]);\r
+    SigList = (EFI_SIGNATURE_LIST *)(TimeStampDb[Index]);\r
 \r
     //\r
     // The list is terminated by a NULL pointer.\r
@@ -487,9 +489,8 @@ IsValidTimestamp (
       continue;\r
     }\r
 \r
-\r
-    SigData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) +\r
-                                      SigList->SignatureHeaderSize);\r
+    SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) +\r
+                                     SigList->SignatureHeaderSize);\r
     TsaCert     = SigData->SignatureData;\r
     TsaCertSize = SigList->SignatureSize - sizeof (EFI_GUID);\r
 \r
@@ -541,12 +542,12 @@ IsValidTimestamp (
 **/\r
 EFI_STATUS\r
 P7CheckRevocationByHash (\r
-  IN UINT8                *SignedData,\r
-  IN UINTN                SignedDataSize,\r
-  IN UINT8                *InHash,\r
-  IN UINTN                InHashSize,\r
-  IN EFI_SIGNATURE_LIST   **RevokedDb,\r
-  IN EFI_SIGNATURE_LIST   **TimeStampDb\r
+  IN UINT8               *SignedData,\r
+  IN UINTN               SignedDataSize,\r
+  IN UINT8               *InHash,\r
+  IN UINTN               InHashSize,\r
+  IN EFI_SIGNATURE_LIST  **RevokedDb,\r
+  IN EFI_SIGNATURE_LIST  **TimeStampDb\r
   )\r
 {\r
   EFI_STATUS          Status;\r
@@ -600,8 +601,8 @@ P7CheckRevocationByHash (
       continue;\r
     }\r
 \r
-    SigData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) +\r
-                                      SigList->SignatureHeaderSize);\r
+    SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) +\r
+                                     SigList->SignatureHeaderSize);\r
 \r
     RevokedCert     = SigData->SignatureData;\r
     RevokedCertSize = SigList->SignatureSize - sizeof (EFI_GUID);\r
@@ -641,13 +642,13 @@ P7CheckRevocationByHash (
   //\r
   // Check if any hash of certificates embedded in P7 data is in the revoked database.\r
   //\r
-  CertNumber = (UINT8) (*CertBuffer);\r
+  CertNumber = (UINT8)(*CertBuffer);\r
   CertPtr    = CertBuffer + 1;\r
   for (Index = 0; Index < CertNumber; Index++) {\r
     //\r
     // Retrieve the Certificate data\r
     //\r
-    CertSize = (UINTN) ReadUnaligned32 ((UINT32 *) CertPtr);\r
+    CertSize = (UINTN)ReadUnaligned32 ((UINT32 *)CertPtr);\r
     Cert     = (UINT8 *)CertPtr + sizeof (UINT32);\r
 \r
     if (IsCertHashRevoked (Cert, CertSize, RevokedDb, &RevocationTime)) {\r
@@ -706,12 +707,12 @@ _Exit:
 **/\r
 EFI_STATUS\r
 P7CheckRevocation (\r
-  IN UINT8                *SignedData,\r
-  IN UINTN                SignedDataSize,\r
-  IN UINT8                *InData,\r
-  IN UINTN                InDataSize,\r
-  IN EFI_SIGNATURE_LIST   **RevokedDb,\r
-  IN EFI_SIGNATURE_LIST   **TimeStampDb\r
+  IN UINT8               *SignedData,\r
+  IN UINTN               SignedDataSize,\r
+  IN UINT8               *InData,\r
+  IN UINTN               InDataSize,\r
+  IN EFI_SIGNATURE_LIST  **RevokedDb,\r
+  IN EFI_SIGNATURE_LIST  **TimeStampDb\r
   )\r
 {\r
   EFI_STATUS          Status;\r
@@ -765,8 +766,8 @@ P7CheckRevocation (
       continue;\r
     }\r
 \r
-    SigData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) +\r
-                                      SigList->SignatureHeaderSize);\r
+    SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) +\r
+                                     SigList->SignatureHeaderSize);\r
 \r
     RevokedCert     = SigData->SignatureData;\r
     RevokedCertSize = SigList->SignatureSize - sizeof (EFI_GUID);\r
@@ -806,13 +807,13 @@ P7CheckRevocation (
   //\r
   // Check if any hash of certificates embedded in P7 data is in the revoked database.\r
   //\r
-  CertNumber = (UINT8) (*CertBuffer);\r
+  CertNumber = (UINT8)(*CertBuffer);\r
   CertPtr    = CertBuffer + 1;\r
   for (Index = 0; Index < CertNumber; Index++) {\r
     //\r
     // Retrieve the Certificate data\r
     //\r
-    CertSize = (UINTN) ReadUnaligned32 ((UINT32 *) CertPtr);\r
+    CertSize = (UINTN)ReadUnaligned32 ((UINT32 *)CertPtr);\r
     Cert     = (UINT8 *)CertPtr + sizeof (UINT32);\r
 \r
     if (IsCertHashRevoked (Cert, CertSize, RevokedDb, &RevocationTime)) {\r
@@ -914,8 +915,8 @@ P7CheckTrustByHash (
       continue;\r
     }\r
 \r
-    SigData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) +\r
-                                      SigList->SignatureHeaderSize);\r
+    SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) +\r
+                                     SigList->SignatureHeaderSize);\r
 \r
     TrustCert     = SigData->SignatureData;\r
     TrustCertSize = SigList->SignatureSize - sizeof (EFI_GUID);\r
@@ -1008,8 +1009,8 @@ P7CheckTrust (
       continue;\r
     }\r
 \r
-    SigData = (EFI_SIGNATURE_DATA *) ((UINT8 *) SigList + sizeof (EFI_SIGNATURE_LIST) +\r
-                                      SigList->SignatureHeaderSize);\r
+    SigData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigList + sizeof (EFI_SIGNATURE_LIST) +\r
+                                     SigList->SignatureHeaderSize);\r
 \r
     TrustCert     = SigData->SignatureData;\r
     TrustCertSize = SigList->SignatureSize - sizeof (EFI_GUID);\r
@@ -1118,16 +1119,16 @@ P7CheckTrust (
 EFI_STATUS\r
 EFIAPI\r
 VerifyBuffer (\r
-  IN EFI_PKCS7_VERIFY_PROTOCOL    *This,\r
-  IN VOID                         *SignedData,\r
-  IN UINTN                        SignedDataSize,\r
-  IN VOID                         *InData          OPTIONAL,\r
-  IN UINTN                        InDataSize,\r
-  IN EFI_SIGNATURE_LIST           **AllowedDb,\r
-  IN EFI_SIGNATURE_LIST           **RevokedDb      OPTIONAL,\r
-  IN EFI_SIGNATURE_LIST           **TimeStampDb    OPTIONAL,\r
-  OUT VOID                        *Content         OPTIONAL,\r
-  IN OUT UINTN                    *ContentSize\r
+  IN EFI_PKCS7_VERIFY_PROTOCOL  *This,\r
+  IN VOID                       *SignedData,\r
+  IN UINTN                      SignedDataSize,\r
+  IN VOID                       *InData          OPTIONAL,\r
+  IN UINTN                      InDataSize,\r
+  IN EFI_SIGNATURE_LIST         **AllowedDb,\r
+  IN EFI_SIGNATURE_LIST         **RevokedDb      OPTIONAL,\r
+  IN EFI_SIGNATURE_LIST         **TimeStampDb    OPTIONAL,\r
+  OUT VOID                      *Content         OPTIONAL,\r
+  IN OUT UINTN                  *ContentSize\r
   )\r
 {\r
   EFI_STATUS          Status;\r
@@ -1144,6 +1145,7 @@ VerifyBuffer (
   if ((SignedData == NULL) || (SignedDataSize == 0) || (AllowedDb == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   if ((Content != NULL) && (ContentSize == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
@@ -1157,9 +1159,11 @@ VerifyBuffer (
     if (SigList == NULL) {\r
       break;\r
     }\r
+\r
     if (SigList->SignatureListSize < sizeof (EFI_SIGNATURE_LIST) +\r
-                                     SigList->SignatureHeaderSize +\r
-                                     SigList->SignatureSize) {\r
+        SigList->SignatureHeaderSize +\r
+        SigList->SignatureSize)\r
+    {\r
       return EFI_ABORTED;\r
     }\r
   }\r
@@ -1174,9 +1178,11 @@ VerifyBuffer (
       if (SigList == NULL) {\r
         break;\r
       }\r
+\r
       if (SigList->SignatureListSize < sizeof (EFI_SIGNATURE_LIST) +\r
-                                       SigList->SignatureHeaderSize +\r
-                                       SigList->SignatureSize) {\r
+          SigList->SignatureHeaderSize +\r
+          SigList->SignatureSize)\r
+      {\r
         return EFI_ABORTED;\r
       }\r
     }\r
@@ -1192,9 +1198,11 @@ VerifyBuffer (
       if (SigList == NULL) {\r
         break;\r
       }\r
+\r
       if (SigList->SignatureListSize < sizeof (EFI_SIGNATURE_LIST) +\r
-                                       SigList->SignatureHeaderSize +\r
-                                       SigList->SignatureSize) {\r
+          SigList->SignatureHeaderSize +\r
+          SigList->SignatureSize)\r
+      {\r
         return EFI_ABORTED;\r
       }\r
     }\r
@@ -1209,12 +1217,15 @@ VerifyBuffer (
          SignedData,\r
          SignedDataSize,\r
          (VOID **)&AttachedData,\r
-         &AttachedDataSize)) {\r
+         &AttachedDataSize\r
+         ))\r
+  {\r
     //\r
     // The SignedData buffer was not correctly formatted for processing\r
     //\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   if (AttachedData != NULL) {\r
     if (InData != NULL) {\r
       //\r
@@ -1223,13 +1234,13 @@ VerifyBuffer (
       Status = EFI_UNSUPPORTED;\r
       goto _Exit;\r
     }\r
+\r
     //\r
     // PKCS7-formatted signedData with attached content; Use the embedded\r
     // content for verification\r
     //\r
     DataPtr  = AttachedData;\r
     DataSize = AttachedDataSize;\r
-\r
   } else if (InData != NULL) {\r
     //\r
     // PKCS7-formatted signedData with detached content; Use the user-supplied\r
@@ -1279,10 +1290,10 @@ VerifyBuffer (
              AllowedDb\r
              );\r
   if (EFI_ERROR (Status)) {\r
-      //\r
-      // Verification failed with AllowedDb\r
-      //\r
-      goto _Exit;\r
+    //\r
+    // Verification failed with AllowedDb\r
+    //\r
+    goto _Exit;\r
   }\r
 \r
   //\r
@@ -1294,7 +1305,7 @@ VerifyBuffer (
       // Caller-allocated buffer is too small to contain content\r
       //\r
       *ContentSize = DataSize;\r
-      Status = EFI_BUFFER_TOO_SMALL;\r
+      Status       = EFI_BUFFER_TOO_SMALL;\r
     } else {\r
       *ContentSize = DataSize;\r
       CopyMem (Content, DataPtr, DataSize);\r
@@ -1378,14 +1389,14 @@ _Exit:
 EFI_STATUS\r
 EFIAPI\r
 VerifySignature (\r
-  IN EFI_PKCS7_VERIFY_PROTOCOL    *This,\r
-  IN VOID                         *Signature,\r
-  IN UINTN                        SignatureSize,\r
-  IN VOID                         *InHash,\r
-  IN UINTN                        InHashSize,\r
-  IN EFI_SIGNATURE_LIST           **AllowedDb,\r
-  IN EFI_SIGNATURE_LIST           **RevokedDb       OPTIONAL,\r
-  IN EFI_SIGNATURE_LIST           **TimeStampDb     OPTIONAL\r
+  IN EFI_PKCS7_VERIFY_PROTOCOL  *This,\r
+  IN VOID                       *Signature,\r
+  IN UINTN                      SignatureSize,\r
+  IN VOID                       *InHash,\r
+  IN UINTN                      InHashSize,\r
+  IN EFI_SIGNATURE_LIST         **AllowedDb,\r
+  IN EFI_SIGNATURE_LIST         **RevokedDb       OPTIONAL,\r
+  IN EFI_SIGNATURE_LIST         **TimeStampDb     OPTIONAL\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -1393,8 +1404,9 @@ VerifySignature (
   //\r
   // Parameters Checking\r
   //\r
-  if ((Signature == NULL) || (SignatureSize == 0) || (AllowedDb == NULL)\r
-      || (InHash == NULL) || (InHashSize == 0)) {\r
+  if (  (Signature == NULL) || (SignatureSize == 0) || (AllowedDb == NULL)\r
+     || (InHash == NULL) || (InHashSize == 0))\r
+  {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -1436,7 +1448,7 @@ VerifySignature (
 //\r
 // The PKCS7 Verification Protocol\r
 //\r
-EFI_PKCS7_VERIFY_PROTOCOL mPkcs7Verify = {\r
+EFI_PKCS7_VERIFY_PROTOCOL  mPkcs7Verify = {\r
   VerifyBuffer,\r
   VerifySignature\r
 };\r
@@ -1455,8 +1467,8 @@ EFI_PKCS7_VERIFY_PROTOCOL mPkcs7Verify = {
 EFI_STATUS\r
 EFIAPI\r
 Pkcs7VerifyDriverEntry (\r
-  IN EFI_HANDLE          ImageHandle,\r
-  IN EFI_SYSTEM_TABLE    *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   EFI_STATUS                 Status;\r
index 1cdc8429661de056ad67998d60a1e727736fc80c..3daf847d46d357ac9ef2e10337da7ee6e7878787 100644 (file)
 EFI_STATUS\r
 EFIAPI\r
 RngGetRNG (\r
-  IN EFI_RNG_PROTOCOL            *This,\r
-  IN EFI_RNG_ALGORITHM           *RNGAlgorithm  OPTIONAL,\r
-  IN UINTN                       RNGValueLength,\r
-  OUT UINT8                      *RNGValue\r
+  IN EFI_RNG_PROTOCOL   *This,\r
+  IN EFI_RNG_ALGORITHM  *RNGAlgorithm  OPTIONAL,\r
+  IN UINTN              RNGValueLength,\r
+  OUT UINT8             *RNGValue\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   if ((RNGValueLength == 0) || (RNGValue == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -103,12 +103,12 @@ RngGetRNG (
 UINTN\r
 EFIAPI\r
 ArchGetSupportedRngAlgorithms (\r
-  IN OUT UINTN                     *RNGAlgorithmListSize,\r
-  OUT    EFI_RNG_ALGORITHM         *RNGAlgorithmList\r
+  IN OUT UINTN              *RNGAlgorithmListSize,\r
+  OUT    EFI_RNG_ALGORITHM  *RNGAlgorithmList\r
   )\r
 {\r
-  UINTN RequiredSize;\r
-  EFI_RNG_ALGORITHM *CpuRngSupportedAlgorithm;\r
+  UINTN              RequiredSize;\r
+  EFI_RNG_ALGORITHM  *CpuRngSupportedAlgorithm;\r
 \r
   RequiredSize = sizeof (EFI_RNG_ALGORITHM);\r
 \r
@@ -119,7 +119,7 @@ ArchGetSupportedRngAlgorithms (
 \r
   CpuRngSupportedAlgorithm = PcdGetPtr (PcdCpuRngSupportedAlgorithm);\r
 \r
-  CopyMem(&RNGAlgorithmList[0], CpuRngSupportedAlgorithm, sizeof (EFI_RNG_ALGORITHM));\r
+  CopyMem (&RNGAlgorithmList[0], CpuRngSupportedAlgorithm, sizeof (EFI_RNG_ALGORITHM));\r
 \r
   *RNGAlgorithmListSize = RequiredSize;\r
   return EFI_SUCCESS;\r
index 66edaf10c468c9627f5a1e7fb1c7329aba9eb15c..3ac20e889cf11fa940c9a893f52ab9c7b5d4676c 100644 (file)
@@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Number of columns (32-bit words) comprising the State.\r
 // AES_NB is a constant (value = 4) for NIST FIPS-197.\r
 //\r
-#define AES_NB                     4\r
+#define AES_NB  4\r
 \r
 //\r
 // Pre-computed AES Forward Table: AesForwardTable[t] = AES_SBOX[t].[02, 01, 01, 03]\r
@@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // This is to speed up execution of the cipher by combining SubBytes and\r
 // ShiftRows with MixColumns steps and transforming them into table lookups.\r
 //\r
-GLOBAL_REMOVE_IF_UNREFERENCED CONST UINT32 AesForwardTable[] = {\r
+GLOBAL_REMOVE_IF_UNREFERENCED CONST UINT32  AesForwardTable[] = {\r
   0xc66363a5, 0xf87c7c84, 0xee777799, 0xf67b7b8d, 0xfff2f20d, 0xd66b6bbd,\r
   0xde6f6fb1, 0x91c5c554, 0x60303050, 0x02010103, 0xce6767a9, 0x562b2b7d,\r
   0xe7fefe19, 0xb5d7d762, 0x4dababe6, 0xec76769a, 0x8fcaca45, 0x1f82829d,\r
@@ -71,7 +71,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED CONST UINT32 AesForwardTable[] = {
 //\r
 // Round constant word array used in AES key expansion.\r
 //\r
-GLOBAL_REMOVE_IF_UNREFERENCED CONST UINT32 Rcon[] = {\r
+GLOBAL_REMOVE_IF_UNREFERENCED CONST UINT32  Rcon[] = {\r
   0x01000000, 0x02000000, 0x04000000, 0x08000000, 0x10000000,\r
   0x20000000, 0x40000000, 0x80000000, 0x1B000000, 0x36000000\r
 };\r
@@ -79,14 +79,14 @@ GLOBAL_REMOVE_IF_UNREFERENCED CONST UINT32 Rcon[] = {
 //\r
 // Rotates x right n bits (circular right shift operation)\r
 //\r
-#define ROTATE_RIGHT32(x, n)    (((x) >> (n)) | ((x) << (32-(n))))\r
+#define ROTATE_RIGHT32(x, n)  (((x) >> (n)) | ((x) << (32-(n))))\r
 \r
 //\r
 // Loading & Storing 32-bit words in big-endian format: y[3..0] --> x; x --> y[3..0];\r
 //\r
-#define LOAD32H(x, y)    { x = ((UINT32)((y)[0] & 0xFF) << 24) | ((UINT32)((y)[1] & 0xFF) << 16) |  \\r
+#define LOAD32H(x, y)   { x = ((UINT32)((y)[0] & 0xFF) << 24) | ((UINT32)((y)[1] & 0xFF) << 16) |   \\r
                                ((UINT32)((y)[2] & 0xFF) <<  8) | ((UINT32)((y)[3] & 0xFF)); }\r
-#define STORE32H(x, y)   { (y)[0] = (UINT8)(((x) >> 24) & 0xFF); (y)[1] = (UINT8)(((x) >> 16) & 0xFF); \\r
+#define STORE32H(x, y)  { (y)[0] = (UINT8)(((x) >> 24) & 0xFF); (y)[1] = (UINT8)(((x) >> 16) & 0xFF);  \\r
                            (y)[2] = (UINT8)(((x) >>  8) & 0xFF); (y)[3] = (UINT8)((x)         & 0xFF); }\r
 \r
 //\r
@@ -121,30 +121,31 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 AesExpandKey (\r
-  IN UINT8         *Key,\r
-  IN UINTN         KeyLenInBits,\r
-  OUT AES_KEY      *AesKey\r
+  IN UINT8     *Key,\r
+  IN UINTN     KeyLenInBits,\r
+  OUT AES_KEY  *AesKey\r
   )\r
 {\r
-  UINTN       Nk;\r
-  UINTN       Nr;\r
-  UINTN       Nw;\r
-  UINTN       Index1;\r
-  UINTN       Index2;\r
-  UINTN       Index3;\r
-  UINT32      *Ek;\r
-  UINT32      Temp;\r
+  UINTN   Nk;\r
+  UINTN   Nr;\r
+  UINTN   Nw;\r
+  UINTN   Index1;\r
+  UINTN   Index2;\r
+  UINTN   Index3;\r
+  UINT32  *Ek;\r
+  UINT32  Temp;\r
 \r
   //\r
   // Nk - Number of 32-bit words comprising the cipher key. (Nk = 4, 6 or 8)\r
   // Nr - Number of rounds. (Nr = 10, 12, or 14), which is dependent on the key size.\r
   //\r
   Nk = KeyLenInBits >> 5;\r
-  if (Nk != 4 && Nk != 6 && Nk != 8) {\r
+  if ((Nk != 4) && (Nk != 6) && (Nk != 8)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
-  Nr = Nk + 6;\r
-  Nw = AES_NB * (Nr + 1);    // Key Expansion generates a total of Nb * (Nr + 1) words\r
+\r
+  Nr         = Nk + 6;\r
+  Nw         = AES_NB * (Nr + 1); // Key Expansion generates a total of Nb * (Nr + 1) words\r
   AesKey->Nk = Nk;\r
 \r
   //\r
@@ -161,31 +162,32 @@ AesExpandKey (
   //\r
   for (Index2 = Nk, Index3 = 0; Index2 < Nw; Index2 += Nk, Index3++) {\r
     Temp       = Ek[Index2 - 1];\r
-    Ek[Index2] = Ek[Index2 - Nk] ^ (AES_FT2((Temp >> 16) & 0xFF) & 0xFF000000) ^\r
-                                   (AES_FT3((Temp >>  8) & 0xFF) & 0x00FF0000) ^\r
-                                   (AES_FT0((Temp)       & 0xFF) & 0x0000FF00) ^\r
-                                   (AES_FT1((Temp >> 24) & 0xFF) & 0x000000FF) ^\r
-                                   Rcon[Index3];\r
+    Ek[Index2] = Ek[Index2 - Nk] ^ (AES_FT2 ((Temp >> 16) & 0xFF) & 0xFF000000) ^\r
+                 (AES_FT3 ((Temp >>  8) & 0xFF) & 0x00FF0000) ^\r
+                 (AES_FT0 ((Temp)       & 0xFF) & 0x0000FF00) ^\r
+                 (AES_FT1 ((Temp >> 24) & 0xFF) & 0x000000FF) ^\r
+                 Rcon[Index3];\r
     if (Nk <= 6) {\r
       //\r
       // If AES Cipher Key is 128 or 192 bits\r
       //\r
       for (Index1 = 1; Index1 < Nk && (Index1 + Index2) < Nw; Index1++) {\r
-        Ek [Index1 + Index2] = Ek [Index1 + Index2 - Nk] ^ Ek[Index1 + Index2 - 1];\r
+        Ek[Index1 + Index2] = Ek[Index1 + Index2 - Nk] ^ Ek[Index1 + Index2 - 1];\r
       }\r
     } else {\r
       //\r
       // Different routine for key expansion If Cipher Key is 256 bits,\r
       //\r
       for (Index1 = 1; Index1 < 4 && (Index1 + Index2) < Nw; Index1++) {\r
-        Ek [Index1 + Index2] = Ek[Index1 + Index2 - Nk] ^ Ek[Index1 + Index2 - 1];\r
+        Ek[Index1 + Index2] = Ek[Index1 + Index2 - Nk] ^ Ek[Index1 + Index2 - 1];\r
       }\r
+\r
       if (Index2 + 4 < Nw) {\r
         Temp           = Ek[Index2 + 3];\r
-        Ek[Index2 + 4] = Ek[Index2 + 4 - Nk] ^ (AES_FT2((Temp >> 24) & 0xFF) & 0xFF000000) ^\r
-                                               (AES_FT3((Temp >> 16) & 0xFF) & 0x00FF0000) ^\r
-                                               (AES_FT0((Temp >>  8) & 0xFF) & 0x0000FF00) ^\r
-                                               (AES_FT1((Temp)       & 0xFF) & 0x000000FF);\r
+        Ek[Index2 + 4] = Ek[Index2 + 4 - Nk] ^ (AES_FT2 ((Temp >> 24) & 0xFF) & 0xFF000000) ^\r
+                         (AES_FT3 ((Temp >> 16) & 0xFF) & 0x00FF0000) ^\r
+                         (AES_FT0 ((Temp >>  8) & 0xFF) & 0x0000FF00) ^\r
+                         (AES_FT1 ((Temp)       & 0xFF) & 0x000000FF);\r
       }\r
 \r
       for (Index1 = 5; Index1 < Nk && (Index1 + Index2) < Nw; Index1++) {\r
@@ -211,9 +213,9 @@ AesExpandKey (
 EFI_STATUS\r
 EFIAPI\r
 AesEncrypt (\r
-  IN  UINT8        *Key,\r
-  IN  UINT8        *InData,\r
-  OUT UINT8        *OutData\r
+  IN  UINT8  *Key,\r
+  IN  UINT8  *InData,\r
+  OUT UINT8  *OutData\r
   )\r
 {\r
   AES_KEY  AesKey;\r
@@ -258,33 +260,35 @@ AesEncrypt (
   // table lookups to speed up the execution.\r
   //\r
   for (Round = 1; Round < Nr; Round++) {\r
-    StateY[0] = AES_FT0 ((StateX[0] >> 24)       ) ^ AES_FT1 ((StateX[1] >> 16) & 0xFF) ^\r
-                AES_FT2 ((StateX[2] >>  8) & 0xFF) ^ AES_FT3 ((StateX[3]      ) & 0xFF) ^ Ek[NbIndex];\r
-    StateY[1] = AES_FT0 ((StateX[1] >> 24)       ) ^ AES_FT1 ((StateX[2] >> 16) & 0xFF) ^\r
-                AES_FT2 ((StateX[3] >>  8) & 0xFF) ^ AES_FT3 ((StateX[0]      ) & 0xFF) ^ Ek[NbIndex + 1];\r
-    StateY[2] = AES_FT0 ((StateX[2] >> 24)       ) ^ AES_FT1 ((StateX[3] >> 16) & 0xFF) ^\r
-                AES_FT2 ((StateX[0] >>  8) & 0xFF) ^ AES_FT3 ((StateX[1]      ) & 0xFF) ^ Ek[NbIndex + 2];\r
-    StateY[3] = AES_FT0 ((StateX[3] >> 24)       ) ^ AES_FT1 ((StateX[0] >> 16) & 0xFF) ^\r
-                AES_FT2 ((StateX[1] >>  8) & 0xFF) ^ AES_FT3 ((StateX[2]      ) & 0xFF) ^ Ek[NbIndex + 3];\r
+    StateY[0] = AES_FT0 ((StateX[0] >> 24)) ^ AES_FT1 ((StateX[1] >> 16) & 0xFF) ^\r
+                AES_FT2 ((StateX[2] >>  8) & 0xFF) ^ AES_FT3 ((StateX[3]) & 0xFF) ^ Ek[NbIndex];\r
+    StateY[1] = AES_FT0 ((StateX[1] >> 24)) ^ AES_FT1 ((StateX[2] >> 16) & 0xFF) ^\r
+                AES_FT2 ((StateX[3] >>  8) & 0xFF) ^ AES_FT3 ((StateX[0]) & 0xFF) ^ Ek[NbIndex + 1];\r
+    StateY[2] = AES_FT0 ((StateX[2] >> 24)) ^ AES_FT1 ((StateX[3] >> 16) & 0xFF) ^\r
+                AES_FT2 ((StateX[0] >>  8) & 0xFF) ^ AES_FT3 ((StateX[1]) & 0xFF) ^ Ek[NbIndex + 2];\r
+    StateY[3] = AES_FT0 ((StateX[3] >> 24)) ^ AES_FT1 ((StateX[0] >> 16) & 0xFF) ^\r
+                AES_FT2 ((StateX[1] >>  8) & 0xFF) ^ AES_FT3 ((StateX[2]) & 0xFF) ^ Ek[NbIndex + 3];\r
 \r
     NbIndex += 4;\r
-    Temp = StateX; StateX = StateY; StateY = Temp;\r
+    Temp     = StateX;\r
+    StateX   = StateY;\r
+    StateY   = Temp;\r
   }\r
 \r
   //\r
   // Apply the final round, which does not include MixColumns() transformation\r
   //\r
-  StateY[0] = (AES_FT2 ((StateX[0] >> 24)       ) & 0xFF000000) ^ (AES_FT3 ((StateX[1] >> 16) & 0xFF) & 0x00FF0000) ^\r
-              (AES_FT0 ((StateX[2] >>  8) & 0xFF) & 0x0000FF00) ^ (AES_FT1 ((StateX[3]      ) & 0xFF) & 0x000000FF) ^\r
+  StateY[0] = (AES_FT2 ((StateX[0] >> 24)) & 0xFF000000) ^ (AES_FT3 ((StateX[1] >> 16) & 0xFF) & 0x00FF0000) ^\r
+              (AES_FT0 ((StateX[2] >>  8) & 0xFF) & 0x0000FF00) ^ (AES_FT1 ((StateX[3]) & 0xFF) & 0x000000FF) ^\r
               Ek[NbIndex];\r
-  StateY[1] = (AES_FT2 ((StateX[1] >> 24)       ) & 0xFF000000) ^ (AES_FT3 ((StateX[2] >> 16) & 0xFF) & 0x00FF0000) ^\r
-              (AES_FT0 ((StateX[3] >>  8) & 0xFF) & 0x0000FF00) ^ (AES_FT1 ((StateX[0]      ) & 0xFF) & 0x000000FF) ^\r
+  StateY[1] = (AES_FT2 ((StateX[1] >> 24)) & 0xFF000000) ^ (AES_FT3 ((StateX[2] >> 16) & 0xFF) & 0x00FF0000) ^\r
+              (AES_FT0 ((StateX[3] >>  8) & 0xFF) & 0x0000FF00) ^ (AES_FT1 ((StateX[0]) & 0xFF) & 0x000000FF) ^\r
               Ek[NbIndex + 1];\r
-  StateY[2] = (AES_FT2 ((StateX[2] >> 24)       ) & 0xFF000000) ^ (AES_FT3 ((StateX[3] >> 16) & 0xFF) & 0x00FF0000) ^\r
-              (AES_FT0 ((StateX[0] >>  8) & 0xFF) & 0x0000FF00) ^ (AES_FT1 ((StateX[1]      ) & 0xFF) & 0x000000FF) ^\r
+  StateY[2] = (AES_FT2 ((StateX[2] >> 24)) & 0xFF000000) ^ (AES_FT3 ((StateX[3] >> 16) & 0xFF) & 0x00FF0000) ^\r
+              (AES_FT0 ((StateX[0] >>  8) & 0xFF) & 0x0000FF00) ^ (AES_FT1 ((StateX[1]) & 0xFF) & 0x000000FF) ^\r
               Ek[NbIndex + 2];\r
-  StateY[3] = (AES_FT2 ((StateX[3] >> 24)       ) & 0xFF000000) ^ (AES_FT3 ((StateX[0] >> 16) & 0xFF) & 0x00FF0000) ^\r
-              (AES_FT0 ((StateX[1] >>  8) & 0xFF) & 0x0000FF00) ^ (AES_FT1 ((StateX[2]      ) & 0xFF) & 0x000000FF) ^\r
+  StateY[3] = (AES_FT2 ((StateX[3] >> 24)) & 0xFF000000) ^ (AES_FT3 ((StateX[0] >> 16) & 0xFF) & 0x00FF0000) ^\r
+              (AES_FT0 ((StateX[1] >>  8) & 0xFF) & 0x0000FF00) ^ (AES_FT1 ((StateX[2]) & 0xFF) & 0x000000FF) ^\r
               Ek[NbIndex + 3];\r
 \r
   //\r
index e07f90050ac33e33ad8a028f9f4e61fce7654b3b..8da1d0fc2ac8a53a055da8b0d96f3c93735e777b 100644 (file)
@@ -23,9 +23,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 AesEncrypt (\r
-  IN  UINT8        *Key,\r
-  IN  UINT8        *InData,\r
-  OUT UINT8        *OutData\r
+  IN  UINT8  *Key,\r
+  IN  UINT8  *InData,\r
+  OUT UINT8  *OutData\r
   );\r
 \r
-#endif  // __AES_CORE_H__\r
+#endif // __AES_CORE_H__\r
index 83025a47d43d442bfe1c324eda2916e6b5599a7e..5b6644138231ddfb07aa778649ebf9b35906bc4e 100644 (file)
@@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 RdRandGetSeed128 (\r
-  OUT UINT8        *SeedBuffer\r
+  OUT UINT8  *SeedBuffer\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -43,7 +43,7 @@ RdRandGetSeed128 (
   // Chose an arbitrary key and zero the feed_forward_value (FFV)\r
   //\r
   for (Index = 0; Index < 16; Index++) {\r
-    Key[Index] = (UINT8) Index;\r
+    Key[Index] = (UINT8)Index;\r
     Ffv[Index] = 0;\r
   }\r
 \r
@@ -88,8 +88,8 @@ RdRandGetSeed128 (
 EFI_STATUS\r
 EFIAPI\r
 RdRandGenerateEntropy (\r
-  IN UINTN         Length,\r
-  OUT UINT8        *Entropy\r
+  IN UINTN   Length,\r
+  OUT UINT8  *Entropy\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -109,6 +109,7 @@ RdRandGenerateEntropy (
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
+\r
     CopyMem (Ptr, Seed, 16);\r
 \r
     BlockCount--;\r
@@ -122,6 +123,7 @@ RdRandGenerateEntropy (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   CopyMem (Ptr, Seed, (Length % 16));\r
 \r
   return Status;\r
index 072378e062e7bee81a7e763fe9b4ed4517e4d82c..7fdb6891bd6344eec6d5ae84938cb143ed395fc5 100644 (file)
@@ -36,8 +36,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 RdRandGenerateEntropy (\r
-  IN UINTN         Length,\r
-  OUT UINT8        *Entropy\r
+  IN UINTN   Length,\r
+  OUT UINT8  *Entropy\r
   );\r
 \r
-#endif  // __RD_RAND_H__\r
+#endif // __RD_RAND_H__\r
index 834123b945f794446466a3faa21cb6cccb98fef7..2df4ed44329ac485282ecf2107d10f007093299d 100644 (file)
 EFI_STATUS\r
 EFIAPI\r
 RngGetRNG (\r
-  IN EFI_RNG_PROTOCOL            *This,\r
-  IN EFI_RNG_ALGORITHM           *RNGAlgorithm  OPTIONAL,\r
-  IN UINTN                       RNGValueLength,\r
-  OUT UINT8                      *RNGValue\r
+  IN EFI_RNG_PROTOCOL   *This,\r
+  IN EFI_RNG_ALGORITHM  *RNGAlgorithm  OPTIONAL,\r
+  IN UINTN              RNGValueLength,\r
+  OUT UINT8             *RNGValue\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   if ((RNGValueLength == 0) || (RNGValue == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -119,12 +119,12 @@ RngGetRNG (
 UINTN\r
 EFIAPI\r
 ArchGetSupportedRngAlgorithms (\r
-  IN OUT UINTN                     *RNGAlgorithmListSize,\r
-  OUT    EFI_RNG_ALGORITHM         *RNGAlgorithmList\r
+  IN OUT UINTN              *RNGAlgorithmListSize,\r
+  OUT    EFI_RNG_ALGORITHM  *RNGAlgorithmList\r
   )\r
 {\r
-  UINTN RequiredSize;\r
-  EFI_RNG_ALGORITHM *CpuRngSupportedAlgorithm;\r
+  UINTN              RequiredSize;\r
+  EFI_RNG_ALGORITHM  *CpuRngSupportedAlgorithm;\r
 \r
   RequiredSize = 2 * sizeof (EFI_RNG_ALGORITHM);\r
 \r
@@ -135,10 +135,10 @@ ArchGetSupportedRngAlgorithms (
 \r
   CpuRngSupportedAlgorithm = PcdGetPtr (PcdCpuRngSupportedAlgorithm);\r
 \r
-  CopyMem(&RNGAlgorithmList[0], CpuRngSupportedAlgorithm, sizeof (EFI_RNG_ALGORITHM));\r
+  CopyMem (&RNGAlgorithmList[0], CpuRngSupportedAlgorithm, sizeof (EFI_RNG_ALGORITHM));\r
 \r
   // x86 platforms also support EFI_RNG_ALGORITHM_RAW via RDSEED\r
-  CopyMem(&RNGAlgorithmList[1], &gEfiRngAlgorithmRaw, sizeof (EFI_RNG_ALGORITHM));\r
+  CopyMem (&RNGAlgorithmList[1], &gEfiRngAlgorithmRaw, sizeof (EFI_RNG_ALGORITHM));\r
 \r
   *RNGAlgorithmListSize = RequiredSize;\r
   return EFI_SUCCESS;\r
index b959c70536ea3b9049905bbfd3d973fc9b2f6dcf..6f52eeff4a09db6303cf9e7d918c9ac23b05a2b4 100644 (file)
@@ -54,12 +54,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 RngGetInfo (\r
-  IN EFI_RNG_PROTOCOL             *This,\r
-  IN OUT UINTN                    *RNGAlgorithmListSize,\r
-  OUT EFI_RNG_ALGORITHM           *RNGAlgorithmList\r
+  IN EFI_RNG_PROTOCOL    *This,\r
+  IN OUT UINTN           *RNGAlgorithmListSize,\r
+  OUT EFI_RNG_ALGORITHM  *RNGAlgorithmList\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   if ((This == NULL) || (RNGAlgorithmListSize == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -80,7 +80,7 @@ RngGetInfo (
 //\r
 // The Random Number Generator (RNG) protocol\r
 //\r
-EFI_RNG_PROTOCOL mRngRdRand = {\r
+EFI_RNG_PROTOCOL  mRngRdRand = {\r
   RngGetInfo,\r
   RngGetRNG\r
 };\r
@@ -99,12 +99,12 @@ EFI_RNG_PROTOCOL mRngRdRand = {
 EFI_STATUS\r
 EFIAPI\r
 RngDriverEntry (\r
-  IN EFI_HANDLE          ImageHandle,\r
-  IN EFI_SYSTEM_TABLE    *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
-  EFI_HANDLE    Handle;\r
+  EFI_STATUS  Status;\r
+  EFI_HANDLE  Handle;\r
 \r
   //\r
   // Install UEFI RNG (Random Number Generator) Protocol\r
@@ -120,7 +120,6 @@ RngDriverEntry (
   return Status;\r
 }\r
 \r
-\r
 /**\r
   Calls RDRAND to fill a buffer of arbitrary size with random bytes.\r
 \r
@@ -134,24 +133,25 @@ RngDriverEntry (
 EFI_STATUS\r
 EFIAPI\r
 RngGetBytes (\r
-  IN UINTN         Length,\r
-  OUT UINT8        *RandBuffer\r
+  IN UINTN   Length,\r
+  OUT UINT8  *RandBuffer\r
   )\r
 {\r
-  BOOLEAN     IsRandom;\r
-  UINT64      TempRand[2];\r
+  BOOLEAN  IsRandom;\r
+  UINT64   TempRand[2];\r
 \r
   while (Length > 0) {\r
     IsRandom = GetRandomNumber128 (TempRand);\r
     if (!IsRandom) {\r
       return EFI_NOT_READY;\r
     }\r
+\r
     if (Length >= sizeof (TempRand)) {\r
-      WriteUnaligned64 ((UINT64*)RandBuffer, TempRand[0]);\r
+      WriteUnaligned64 ((UINT64 *)RandBuffer, TempRand[0]);\r
       RandBuffer += sizeof (UINT64);\r
-      WriteUnaligned64 ((UINT64*)RandBuffer, TempRand[1]);\r
+      WriteUnaligned64 ((UINT64 *)RandBuffer, TempRand[1]);\r
       RandBuffer += sizeof (UINT64);\r
-      Length -= sizeof (TempRand);\r
+      Length     -= sizeof (TempRand);\r
     } else {\r
       CopyMem (RandBuffer, TempRand, Length);\r
       Length = 0;\r
index 25cccbe92c2add10928a867abcb40f8ed96f8f5a..224d8bd4ea5f4dba338675f439886a1c116a4640 100644 (file)
@@ -36,9 +36,9 @@
 EFI_STATUS\r
 EFIAPI\r
 RngGetInfo (\r
-  IN EFI_RNG_PROTOCOL             *This,\r
-  IN OUT UINTN                    *RNGAlgorithmListSize,\r
-  OUT EFI_RNG_ALGORITHM           *RNGAlgorithmList\r
+  IN EFI_RNG_PROTOCOL    *This,\r
+  IN OUT UINTN           *RNGAlgorithmListSize,\r
+  OUT EFI_RNG_ALGORITHM  *RNGAlgorithmList\r
   );\r
 \r
 /**\r
@@ -66,10 +66,10 @@ RngGetInfo (
 EFI_STATUS\r
 EFIAPI\r
 RngGetRNG (\r
-  IN EFI_RNG_PROTOCOL            *This,\r
-  IN EFI_RNG_ALGORITHM           *RNGAlgorithm  OPTIONAL,\r
-  IN UINTN                       RNGValueLength,\r
-  OUT UINT8                      *RNGValue\r
+  IN EFI_RNG_PROTOCOL   *This,\r
+  IN EFI_RNG_ALGORITHM  *RNGAlgorithm  OPTIONAL,\r
+  IN UINTN              RNGValueLength,\r
+  OUT UINT8             *RNGValue\r
   );\r
 \r
 /**\r
@@ -93,8 +93,8 @@ RngGetRNG (
 UINTN\r
 EFIAPI\r
 ArchGetSupportedRngAlgorithms (\r
-  IN OUT UINTN                     *RNGAlgorithmListSize,\r
-  OUT    EFI_RNG_ALGORITHM         *RNGAlgorithmList\r
+  IN OUT UINTN              *RNGAlgorithmListSize,\r
+  OUT    EFI_RNG_ALGORITHM  *RNGAlgorithmList\r
   );\r
 \r
 /**\r
@@ -110,8 +110,8 @@ ArchGetSupportedRngAlgorithms (
 EFI_STATUS\r
 EFIAPI\r
 RngGetBytes (\r
-  IN UINTN         Length,\r
-  OUT UINT8        *RandBuffer\r
+  IN UINTN   Length,\r
+  OUT UINT8  *RandBuffer\r
   );\r
 \r
-#endif  // RNGDXE_INTERNALS_H_\r
+#endif // RNGDXE_INTERNALS_H_\r
index e5dd06ebcf8132e362a2e2f1648a3914aed0a051..0addf575a00395a9c5e27c8e372080f56b27ebef 100644 (file)
@@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "TcgMor.h"\r
 \r
-UINT8    mMorControl;\r
+UINT8  mMorControl;\r
 \r
 /**\r
   Ready to Boot Event notification handler.\r
@@ -24,8 +24,8 @@ UINT8    mMorControl;
 VOID\r
 EFIAPI\r
 OnReadyToBoot (\r
-  IN      EFI_EVENT                 Event,\r
-  IN      VOID                      *Context\r
+  IN      EFI_EVENT  Event,\r
+  IN      VOID       *Context\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -35,8 +35,9 @@ OnReadyToBoot (
     //\r
     // MorControl is expected, directly return to avoid unnecessary variable operation\r
     //\r
-    return ;\r
+    return;\r
   }\r
+\r
   //\r
   // Clear MOR_CLEAR_MEMORY_BIT\r
   //\r
@@ -45,12 +46,12 @@ OnReadyToBoot (
 \r
   DataSize = sizeof (mMorControl);\r
   Status   = gRT->SetVariable (\r
-               MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-               &gEfiMemoryOverwriteControlDataGuid,\r
-               EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-               DataSize,\r
-               &mMorControl\r
-               );\r
+                    MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                    &gEfiMemoryOverwriteControlDataGuid,\r
+                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                    DataSize,\r
+                    &mMorControl\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT failure, Status = %r\n", Status));\r
   }\r
@@ -70,11 +71,10 @@ OnReadyToBoot (
 **/\r
 VOID\r
 InitiateTPerReset (\r
-  IN  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL    *Ssp,\r
-  IN  UINT32                                   MediaId\r
+  IN  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL  *Ssp,\r
+  IN  UINT32                                 MediaId\r
   )\r
 {\r
-\r
   EFI_STATUS                                   Status;\r
   UINT8                                        *Buffer;\r
   UINTN                                        XferSize;\r
@@ -84,17 +84,17 @@ InitiateTPerReset (
   BOOLEAN                                      IeeeFlag;\r
   SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA  *Data;\r
 \r
-  Buffer        = NULL;\r
-  TcgFlag       = FALSE;\r
-  IeeeFlag      = FALSE;\r
+  Buffer   = NULL;\r
+  TcgFlag  = FALSE;\r
+  IeeeFlag = FALSE;\r
 \r
   //\r
   // ATA8-ACS 7.57.6.1 indicates the Transfer Length field requirements a multiple of 512.\r
   // If the length of the TRUSTED RECEIVE parameter data is greater than the Transfer Length,\r
   // then the device shall return the TRUSTED RECEIVE parameter data truncated to the requested Transfer Length.\r
   //\r
-  Len           = ROUNDUP512(sizeof(SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA));\r
-  Buffer        = AllocateZeroPool(Len);\r
+  Len    = ROUNDUP512 (sizeof (SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA));\r
+  Buffer = AllocateZeroPool (Len);\r
 \r
   if (Buffer == NULL) {\r
     return;\r
@@ -122,17 +122,18 @@ InitiateTPerReset (
   // In returned data, the ListLength field indicates the total length, in bytes,\r
   // of the supported security protocol list.\r
   //\r
-  Data = (SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA*)Buffer;\r
-  Len  = ROUNDUP512(sizeof (SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA) +\r
-                    (Data->SupportedSecurityListLength[0] << 8) +\r
-                    (Data->SupportedSecurityListLength[1])\r
-                    );\r
+  Data = (SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA *)Buffer;\r
+  Len  = ROUNDUP512 (\r
+           sizeof (SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA) +\r
+           (Data->SupportedSecurityListLength[0] << 8) +\r
+           (Data->SupportedSecurityListLength[1])\r
+           );\r
 \r
   //\r
   // Free original buffer and allocate new buffer.\r
   //\r
-  FreePool(Buffer);\r
-  Buffer = AllocateZeroPool(Len);\r
+  FreePool (Buffer);\r
+  Buffer = AllocateZeroPool (Len);\r
   if (Buffer == NULL) {\r
     return;\r
   }\r
@@ -155,7 +156,7 @@ InitiateTPerReset (
     goto Exit;\r
   }\r
 \r
-  Data = (SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA*)Buffer;\r
+  Data = (SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA *)Buffer;\r
   Len  = (Data->SupportedSecurityListLength[0] << 8) + Data->SupportedSecurityListLength[1];\r
 \r
   //\r
@@ -219,7 +220,7 @@ InitiateTPerReset (
 Exit:\r
 \r
   if (Buffer != NULL) {\r
-    FreePool(Buffer);\r
+    FreePool (Buffer);\r
   }\r
 }\r
 \r
@@ -237,12 +238,12 @@ TPerResetAtEndOfDxe (
   IN VOID       *Context\r
   )\r
 {\r
-  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL   *Ssp;\r
-  EFI_BLOCK_IO_PROTOCOL                   *BlockIo;\r
-  EFI_STATUS                              Status;\r
-  UINTN                                   HandleCount;\r
-  EFI_HANDLE                              *HandleBuffer;\r
-  UINTN                                   Index;\r
+  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL  *Ssp;\r
+  EFI_BLOCK_IO_PROTOCOL                  *BlockIo;\r
+  EFI_STATUS                             Status;\r
+  UINTN                                  HandleCount;\r
+  EFI_HANDLE                             *HandleBuffer;\r
+  UINTN                                  Index;\r
 \r
   //\r
   // Locate all SSP protocol instances.\r
@@ -262,24 +263,24 @@ TPerResetAtEndOfDxe (
     return;\r
   }\r
 \r
-  for (Index = 0; Index < HandleCount; Index ++) {\r
+  for (Index = 0; Index < HandleCount; Index++) {\r
     //\r
     // Get the SSP interface.\r
     //\r
-    Status = gBS->HandleProtocol(\r
+    Status = gBS->HandleProtocol (\r
                     HandleBuffer[Index],\r
                     &gEfiStorageSecurityCommandProtocolGuid,\r
-                    (VOID **) &Ssp\r
+                    (VOID **)&Ssp\r
                     );\r
 \r
     if (EFI_ERROR (Status)) {\r
       continue;\r
     }\r
 \r
-    Status = gBS->HandleProtocol(\r
+    Status = gBS->HandleProtocol (\r
                     HandleBuffer[Index],\r
                     &gEfiBlockIoProtocolGuid,\r
-                    (VOID **) &BlockIo\r
+                    (VOID **)&BlockIo\r
                     );\r
 \r
     if (EFI_ERROR (Status)) {\r
@@ -317,25 +318,25 @@ MorDriverEntryPoint (
   ///\r
 \r
   DataSize = sizeof (mMorControl);\r
-  Status = gRT->GetVariable (\r
-                  MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-                  &gEfiMemoryOverwriteControlDataGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &mMorControl\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                    &gEfiMemoryOverwriteControlDataGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &mMorControl\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     //\r
     // Set default value to 0\r
     //\r
     mMorControl = 0;\r
-    Status = gRT->SetVariable (\r
-                    MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-                    &gEfiMemoryOverwriteControlDataGuid,\r
-                    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                    DataSize,\r
-                    &mMorControl\r
-                    );\r
+    Status      = gRT->SetVariable (\r
+                         MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                         &gEfiMemoryOverwriteControlDataGuid,\r
+                         EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                         DataSize,\r
+                         &mMorControl\r
+                         );\r
     DEBUG ((DEBUG_INFO, "TcgMor: Create MOR variable! Status = %r\n", Status));\r
   } else {\r
     //\r
index 90cf879169b99e7a8dc1a9305313aaf9c5be22ae..c40517616a6a59ce7e6792e41abe63bdcb6f8f45 100644 (file)
@@ -28,15 +28,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Refer to ATA8-ACS Spec 7.57.6.2 Table 69 or SPC4 7.7.1.3 Table 511.\r
 //\r
 typedef struct  {\r
-  UINT8                            Reserved1[6];\r
-  UINT8                            SupportedSecurityListLength[2];\r
-  UINT8                            SupportedSecurityProtocol[1];\r
+  UINT8    Reserved1[6];\r
+  UINT8    SupportedSecurityListLength[2];\r
+  UINT8    SupportedSecurityProtocol[1];\r
 } SUPPORTED_SECURITY_PROTOCOLS_PARAMETER_DATA;\r
 \r
-#define SECURITY_PROTOCOL_TCG      0x02\r
-#define SECURITY_PROTOCOL_IEEE1667 0xEE\r
+#define SECURITY_PROTOCOL_TCG       0x02\r
+#define SECURITY_PROTOCOL_IEEE1667  0xEE\r
 \r
-#define ROUNDUP512(x) (((x) % 512 == 0) ? (x) : ((x) / 512 + 1) * 512)\r
+#define ROUNDUP512(x)  (((x) % 512 == 0) ? (x) : ((x) / 512 + 1) * 512)\r
 \r
 #endif\r
-\r
index aa230eeefa75f199c5e7925f89c9ad1d5281b0ed..49a663f168cb13e684e1b1ac53fdc322a39f2d55 100644 (file)
@@ -18,13 +18,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include "TcgMorLock.h"\r
 \r
 typedef struct {\r
-  CHAR16                                 *VariableName;\r
-  EFI_GUID                               *VendorGuid;\r
+  CHAR16      *VariableName;\r
+  EFI_GUID    *VendorGuid;\r
 } VARIABLE_TYPE;\r
 \r
 VARIABLE_TYPE  mMorVariableType[] = {\r
-  {MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,      &gEfiMemoryOverwriteControlDataGuid},\r
-  {MEMORY_OVERWRITE_REQUEST_CONTROL_LOCK_NAME,  &gEfiMemoryOverwriteRequestControlLockGuid},\r
+  { MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,     &gEfiMemoryOverwriteControlDataGuid        },\r
+  { MEMORY_OVERWRITE_REQUEST_CONTROL_LOCK_NAME, &gEfiMemoryOverwriteRequestControlLockGuid },\r
 };\r
 \r
 /**\r
@@ -38,18 +38,20 @@ VARIABLE_TYPE  mMorVariableType[] = {
 **/\r
 BOOLEAN\r
 IsAnyMorVariable (\r
-  IN CHAR16                                 *VariableName,\r
-  IN EFI_GUID                               *VendorGuid\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid\r
   )\r
 {\r
-  UINTN   Index;\r
+  UINTN  Index;\r
 \r
-  for (Index = 0; Index < sizeof(mMorVariableType)/sizeof(mMorVariableType[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mMorVariableType)/sizeof (mMorVariableType[0]); Index++) {\r
     if ((StrCmp (VariableName, mMorVariableType[Index].VariableName) == 0) &&\r
-        (CompareGuid (VendorGuid, mMorVariableType[Index].VendorGuid))) {\r
+        (CompareGuid (VendorGuid, mMorVariableType[Index].VendorGuid)))\r
+    {\r
       return TRUE;\r
     }\r
   }\r
+\r
   return FALSE;\r
 }\r
 \r
@@ -64,14 +66,16 @@ IsAnyMorVariable (
 **/\r
 BOOLEAN\r
 IsMorLockVariable (\r
-  IN CHAR16                                 *VariableName,\r
-  IN EFI_GUID                               *VendorGuid\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid\r
   )\r
 {\r
   if ((StrCmp (VariableName, MEMORY_OVERWRITE_REQUEST_CONTROL_LOCK_NAME) == 0) &&\r
-      (CompareGuid (VendorGuid, &gEfiMemoryOverwriteRequestControlLockGuid))) {\r
+      (CompareGuid (VendorGuid, &gEfiMemoryOverwriteRequestControlLockGuid)))\r
+  {\r
     return TRUE;\r
   }\r
+\r
   return FALSE;\r
 }\r
 \r
@@ -104,11 +108,11 @@ IsMorLockVariable (
 EFI_STATUS\r
 EFIAPI\r
 SetVariableCheckHandlerMor (\r
-  IN CHAR16     *VariableName,\r
-  IN EFI_GUID   *VendorGuid,\r
-  IN UINT32     Attributes,\r
-  IN UINTN      DataSize,\r
-  IN VOID       *Data\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN UINT32    Attributes,\r
+  IN UINTN     DataSize,\r
+  IN VOID      *Data\r
   )\r
 {\r
   UINTN       MorLockDataSize;\r
@@ -122,14 +126,14 @@ SetVariableCheckHandlerMor (
     return EFI_SUCCESS;\r
   }\r
 \r
-  MorLockDataSize = sizeof(MorLock);\r
-  Status = InternalGetVariable (\r
-             MEMORY_OVERWRITE_REQUEST_CONTROL_LOCK_NAME,\r
-             &gEfiMemoryOverwriteRequestControlLockGuid,\r
-             NULL,\r
-             &MorLockDataSize,\r
-             &MorLock\r
-             );\r
+  MorLockDataSize = sizeof (MorLock);\r
+  Status          = InternalGetVariable (\r
+                      MEMORY_OVERWRITE_REQUEST_CONTROL_LOCK_NAME,\r
+                      &gEfiMemoryOverwriteRequestControlLockGuid,\r
+                      NULL,\r
+                      &MorLockDataSize,\r
+                      &MorLock\r
+                      );\r
   if (!EFI_ERROR (Status) && MorLock) {\r
     //\r
     // If lock, deny access\r
@@ -140,14 +144,14 @@ SetVariableCheckHandlerMor (
   //\r
   // Delete not OK\r
   //\r
-  if ((DataSize != sizeof(UINT8)) || (Data == NULL) || (Attributes == 0)) {\r
+  if ((DataSize != sizeof (UINT8)) || (Data == NULL) || (Attributes == 0)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
   //\r
   // check format\r
   //\r
-  if (IsMorLockVariable(VariableName, VendorGuid)) {\r
+  if (IsMorLockVariable (VariableName, VendorGuid)) {\r
     //\r
     // set to any other value not OK\r
     //\r
@@ -155,6 +159,7 @@ SetVariableCheckHandlerMor (
       return EFI_INVALID_PARAMETER;\r
     }\r
   }\r
+\r
   //\r
   // Or grant access\r
   //\r
@@ -179,7 +184,7 @@ MorLockDriverInit (
   EFI_STATUS  Status;\r
   UINT8       Data;\r
 \r
-  Data = 0;\r
+  Data   = 0;\r
   Status = InternalSetVariable (\r
              MEMORY_OVERWRITE_REQUEST_CONTROL_LOCK_NAME,\r
              &gEfiMemoryOverwriteRequestControlLockGuid,\r
index 5a6658c158e8db2029e9ab85d44fce8a335d6dc8..bbdb08c5c6c1ea53d5cbc725e437f57c0f38a10c 100644 (file)
@@ -34,11 +34,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 InternalGetVariable (\r
-  IN      CHAR16                   *VariableName,\r
-  IN      EFI_GUID                 *VendorGuid,\r
-  OUT     UINT32                   *Attributes OPTIONAL,\r
-  IN OUT  UINTN                    *DataSize,\r
-  OUT     VOID                     *Data\r
+  IN      CHAR16    *VariableName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  OUT     UINT32    *Attributes OPTIONAL,\r
+  IN OUT  UINTN     *DataSize,\r
+  OUT     VOID      *Data\r
   );\r
 \r
 /**\r
@@ -70,11 +70,11 @@ InternalGetVariable (
 EFI_STATUS\r
 EFIAPI\r
 InternalSetVariable (\r
-  IN CHAR16                       *VariableName,\r
-  IN EFI_GUID                     *VendorGuid,\r
-  IN UINT32                       Attributes,\r
-  IN UINTN                        DataSize,\r
-  IN VOID                         *Data\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN UINT32    Attributes,\r
+  IN UINTN     DataSize,\r
+  IN VOID      *Data\r
   );\r
 \r
 /**\r
@@ -106,11 +106,11 @@ InternalSetVariable (
 EFI_STATUS\r
 EFIAPI\r
 SetVariableCheckHandlerMor (\r
-  IN CHAR16     *VariableName,\r
-  IN EFI_GUID   *VendorGuid,\r
-  IN UINT32     Attributes,\r
-  IN UINTN      DataSize,\r
-  IN VOID       *Data\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN UINT32    Attributes,\r
+  IN UINTN     DataSize,\r
+  IN VOID      *Data\r
   );\r
 \r
 /**\r
index 8e775cb96c0efcf3a50022baa998cc4a9849a7c4..9c09c5623d09a00d34aeda3fcb13679e6c89f7fd 100644 (file)
@@ -13,7 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Protocol/SmmVariable.h>\r
 #include "TcgMorLock.h"\r
 \r
-EFI_SMM_VARIABLE_PROTOCOL *mSmmVariable;\r
+EFI_SMM_VARIABLE_PROTOCOL  *mSmmVariable;\r
 \r
 /**\r
   This service is a wrapper for the UEFI Runtime Service GetVariable().\r
@@ -40,11 +40,11 @@ EFI_SMM_VARIABLE_PROTOCOL *mSmmVariable;
 EFI_STATUS\r
 EFIAPI\r
 InternalGetVariable (\r
-  IN      CHAR16                   *VariableName,\r
-  IN      EFI_GUID                 *VendorGuid,\r
-  OUT     UINT32                   *Attributes OPTIONAL,\r
-  IN OUT  UINTN                    *DataSize,\r
-  OUT     VOID                     *Data\r
+  IN      CHAR16    *VariableName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  OUT     UINT32    *Attributes OPTIONAL,\r
+  IN OUT  UINTN     *DataSize,\r
+  OUT     VOID      *Data\r
   )\r
 {\r
   return mSmmVariable->SmmGetVariable (\r
@@ -85,11 +85,11 @@ InternalGetVariable (
 EFI_STATUS\r
 EFIAPI\r
 InternalSetVariable (\r
-  IN CHAR16                       *VariableName,\r
-  IN EFI_GUID                     *VendorGuid,\r
-  IN UINT32                       Attributes,\r
-  IN UINTN                        DataSize,\r
-  IN VOID                         *Data\r
+  IN CHAR16    *VariableName,\r
+  IN EFI_GUID  *VendorGuid,\r
+  IN UINT32    Attributes,\r
+  IN UINTN     DataSize,\r
+  IN VOID      *Data\r
   )\r
 {\r
   return mSmmVariable->SmmSetVariable (\r
@@ -113,8 +113,8 @@ InternalSetVariable (
 EFI_STATUS\r
 EFIAPI\r
 MorLockDriverEntryPointSmm (\r
-  IN EFI_HANDLE         ImageHandle,\r
-  IN EFI_SYSTEM_TABLE   *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   EFI_STATUS                    Status;\r
@@ -126,17 +126,17 @@ MorLockDriverEntryPointSmm (
   DEBUG ((DEBUG_INFO, "MorLockDriverEntryPointSmm\n"));\r
 \r
   Status = gSmst->SmmLocateProtocol (\r
-                  &gEfiSmmVariableProtocolGuid,\r
-                  NULL,\r
-                  (VOID **) &mSmmVariable\r
-                  );\r
+                    &gEfiSmmVariableProtocolGuid,\r
+                    NULL,\r
+                    (VOID **)&mSmmVariable\r
+                    );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   Status = gSmst->SmmLocateProtocol (\r
-                  &gEdkiiSmmVarCheckProtocolGuid,\r
-                  NULL,\r
-                  (VOID **) &SmmVarCheck\r
-                  );\r
+                    &gEdkiiSmmVarCheckProtocolGuid,\r
+                    NULL,\r
+                    (VOID **)&SmmVarCheck\r
+                    );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   Status = MorLockDriverInit ();\r
index 746916b65f780683cd5dea3d747658b97c810fc5..51786a5d2500facfb3e13e127fe701abf640b805 100644 (file)
@@ -20,18 +20,17 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_COMPONENT_NAME_PROTOCOL  gOpalComponentName =
 //\r
 // EFI Component Name 2 Protocol\r
 //\r
-GLOBAL_REMOVE_IF_UNREFERENCED EFI_COMPONENT_NAME2_PROTOCOL gOpalComponentName2 = {\r
+GLOBAL_REMOVE_IF_UNREFERENCED EFI_COMPONENT_NAME2_PROTOCOL  gOpalComponentName2 = {\r
   OpalEfiDriverComponentName2GetDriverName,\r
   OpalEfiDriverComponentName2GetControllerName,\r
   "en"\r
 };\r
 \r
-\r
 /// The name of the driver in all the languages we support.\r
-GLOBAL_REMOVE_IF_UNREFERENCED EFI_UNICODE_STRING_TABLE mOpalDriverNameTable[] = {\r
-    { LANGUAGE_RFC_3066_ENGLISH, (CHAR16*)EFI_DRIVER_NAME_UNICODE },\r
-    { LANGUAGE_ISO_639_2_ENGLISH, (CHAR16*)EFI_DRIVER_NAME_UNICODE },\r
-    { 0, 0 }\r
+GLOBAL_REMOVE_IF_UNREFERENCED EFI_UNICODE_STRING_TABLE  mOpalDriverNameTable[] = {\r
+  { LANGUAGE_RFC_3066_ENGLISH,  (CHAR16 *)EFI_DRIVER_NAME_UNICODE },\r
+  { LANGUAGE_ISO_639_2_ENGLISH, (CHAR16 *)EFI_DRIVER_NAME_UNICODE },\r
+  { 0,                          0                                 }\r
 };\r
 \r
 /**\r
@@ -75,19 +74,19 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_UNICODE_STRING_TABLE mOpalDriverNameTable[] =
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverComponentNameGetDriverName(\r
-  EFI_COMPONENT_NAME_PROTOCOL*    This,\r
-  CHAR8*                          Language,\r
-  CHAR16**                        DriverName\r
+OpalEfiDriverComponentNameGetDriverName (\r
+  EFI_COMPONENT_NAME_PROTOCOL  *This,\r
+  CHAR8                        *Language,\r
+  CHAR16                       **DriverName\r
   )\r
 {\r
-  return LookupUnicodeString2(\r
-    Language,\r
-    This->SupportedLanguages,\r
-    mOpalDriverNameTable,\r
-    DriverName,\r
-    TRUE\r
-    );\r
+  return LookupUnicodeString2 (\r
+           Language,\r
+           This->SupportedLanguages,\r
+           mOpalDriverNameTable,\r
+           DriverName,\r
+           TRUE\r
+           );\r
 }\r
 \r
 /**\r
@@ -131,19 +130,19 @@ OpalEfiDriverComponentNameGetDriverName(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverComponentName2GetDriverName(\r
-  EFI_COMPONENT_NAME2_PROTOCOL*   This,\r
-  CHAR8*                          Language,\r
-  CHAR16**                        DriverName\r
+OpalEfiDriverComponentName2GetDriverName (\r
+  EFI_COMPONENT_NAME2_PROTOCOL  *This,\r
+  CHAR8                         *Language,\r
+  CHAR16                        **DriverName\r
   )\r
 {\r
-  return LookupUnicodeString2(\r
-    Language,\r
-    This->SupportedLanguages,\r
-    mOpalDriverNameTable,\r
-    DriverName,\r
-    FALSE\r
-    );\r
+  return LookupUnicodeString2 (\r
+           Language,\r
+           This->SupportedLanguages,\r
+           mOpalDriverNameTable,\r
+           DriverName,\r
+           FALSE\r
+           );\r
 }\r
 \r
 /**\r
@@ -213,14 +212,14 @@ OpalEfiDriverComponentName2GetDriverName(
 \r
 **/\r
 EFI_STATUS\r
-GetControllerName(\r
+GetControllerName (\r
   EFI_HANDLE  ControllerHandle,\r
   EFI_HANDLE  ChildHandle,\r
-  CHAR8*      Language,\r
-  CHAR16**    ControllerName\r
+  CHAR8       *Language,\r
+  CHAR16      **ControllerName\r
   )\r
 {\r
-  if (Language == NULL || ControllerName == NULL || ControllerHandle == NULL) {\r
+  if ((Language == NULL) || (ControllerName == NULL) || (ControllerHandle == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -298,15 +297,15 @@ GetControllerName(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverComponentNameGetControllerName(\r
-  EFI_COMPONENT_NAME_PROTOCOL*    This,\r
-  EFI_HANDLE                      ControllerHandle,\r
-  EFI_HANDLE                      ChildHandle,\r
-  CHAR8*                          Language,\r
-  CHAR16**                        ControllerName\r
+OpalEfiDriverComponentNameGetControllerName (\r
+  EFI_COMPONENT_NAME_PROTOCOL  *This,\r
+  EFI_HANDLE                   ControllerHandle,\r
+  EFI_HANDLE                   ChildHandle,\r
+  CHAR8                        *Language,\r
+  CHAR16                       **ControllerName\r
   )\r
 {\r
-  return (GetControllerNameControllerHandle, ChildHandle, Language, ControllerName));\r
+  return (GetControllerName (ControllerHandle, ChildHandle, Language, ControllerName));\r
 }\r
 \r
 /**\r
@@ -379,14 +378,13 @@ OpalEfiDriverComponentNameGetControllerName(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverComponentName2GetControllerName(\r
-  EFI_COMPONENT_NAME2_PROTOCOL*   This,\r
-  EFI_HANDLE                      ControllerHandle,\r
-  EFI_HANDLE                      ChildHandle,\r
-  CHAR8*                          Language,\r
-  CHAR16**                        ControllerName\r
+OpalEfiDriverComponentName2GetControllerName (\r
+  EFI_COMPONENT_NAME2_PROTOCOL  *This,\r
+  EFI_HANDLE                    ControllerHandle,\r
+  EFI_HANDLE                    ChildHandle,\r
+  CHAR8                         *Language,\r
+  CHAR16                        **ControllerName\r
   )\r
 {\r
-  return (GetControllerName(ControllerHandle, ChildHandle, Language, ControllerName));\r
+  return (GetControllerName (ControllerHandle, ChildHandle, Language, ControllerName));\r
 }\r
-\r
index b5b6aec98cafd4b101bacda13479698430e54a8a..f127757ad9f0422d6f8996621a6a128980af4475 100644 (file)
@@ -15,19 +15,19 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include "OpalDriver.h"\r
 #include "OpalHii.h"\r
 \r
-EFI_GUID mOpalDeviceLockBoxGuid = OPAL_DEVICE_LOCKBOX_GUID;\r
+EFI_GUID  mOpalDeviceLockBoxGuid = OPAL_DEVICE_LOCKBOX_GUID;\r
 \r
-BOOLEAN                 mOpalEndOfDxe = FALSE;\r
-OPAL_REQUEST_VARIABLE   *mOpalRequestVariable = NULL;\r
-UINTN                   mOpalRequestVariableSize = 0;\r
-CHAR16                  mPopUpString[100];\r
+BOOLEAN                mOpalEndOfDxe            = FALSE;\r
+OPAL_REQUEST_VARIABLE  *mOpalRequestVariable    = NULL;\r
+UINTN                  mOpalRequestVariableSize = 0;\r
+CHAR16                 mPopUpString[100];\r
 \r
-OPAL_DRIVER mOpalDriver;\r
+OPAL_DRIVER  mOpalDriver;\r
 \r
 //\r
 // Globals\r
 //\r
-EFI_DRIVER_BINDING_PROTOCOL gOpalDriverBinding = {\r
+EFI_DRIVER_BINDING_PROTOCOL  gOpalDriverBinding = {\r
   OpalEfiDriverBindingSupported,\r
   OpalEfiDriverBindingStart,\r
   OpalEfiDriverBindingStop,\r
@@ -48,21 +48,21 @@ EFI_DRIVER_BINDING_PROTOCOL gOpalDriverBinding = {
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalSupportGetAvailableActions(\r
-  IN  OPAL_DISK_SUPPORT_ATTRIBUTE      *SupportedAttributes,\r
-  IN  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature,\r
-  IN  UINT16                           OwnerShip,\r
-  OUT OPAL_DISK_ACTIONS                *AvalDiskActions\r
+OpalSupportGetAvailableActions (\r
+  IN  OPAL_DISK_SUPPORT_ATTRIBUTE     *SupportedAttributes,\r
+  IN  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature,\r
+  IN  UINT16                          OwnerShip,\r
+  OUT OPAL_DISK_ACTIONS               *AvalDiskActions\r
   )\r
 {\r
-  BOOLEAN ExistingPassword;\r
+  BOOLEAN  ExistingPassword;\r
 \r
-  NULL_CHECK(AvalDiskActions);\r
+  NULL_CHECK (AvalDiskActions);\r
 \r
-  AvalDiskActions->AdminPass = 1;\r
-  AvalDiskActions->UserPass = 0;\r
+  AvalDiskActions->AdminPass   = 1;\r
+  AvalDiskActions->UserPass    = 0;\r
   AvalDiskActions->DisableUser = 0;\r
-  AvalDiskActions->Unlock = 0;\r
+  AvalDiskActions->Unlock      = 0;\r
 \r
   //\r
   // Revert is performed on locking sp, so only allow if locking sp is enabled\r
@@ -75,13 +75,12 @@ OpalSupportGetAvailableActions(
   // Psid revert is available for any device with media encryption support or pyrite 2.0 type support.\r
   //\r
   if (SupportedAttributes->PyriteSscV2 || SupportedAttributes->MediaEncryption) {\r
-\r
     //\r
     // Only allow psid revert if media encryption is enabled or pyrite 2.0 type support..\r
     // Otherwise, someone who steals a disk can psid revert the disk and the user Data is still\r
     // intact and accessible\r
     //\r
-    AvalDiskActions->PsidRevert = 1;\r
+    AvalDiskActions->PsidRevert           = 1;\r
     AvalDiskActions->RevertKeepDataForced = 0;\r
 \r
     //\r
@@ -90,7 +89,7 @@ OpalSupportGetAvailableActions(
     //\r
     AvalDiskActions->SecureErase = 1;\r
   } else {\r
-    AvalDiskActions->PsidRevert = 0;\r
+    AvalDiskActions->PsidRevert  = 0;\r
     AvalDiskActions->SecureErase = 0;\r
 \r
     //\r
@@ -109,7 +108,7 @@ OpalSupportGetAvailableActions(
   //\r
   // Only allow user to set password if an admin password exists\r
   //\r
-  ExistingPassword = OpalUtilAdminPasswordExists(OwnerShip, LockingFeature);\r
+  ExistingPassword          = OpalUtilAdminPasswordExists (OwnerShip, LockingFeature);\r
   AvalDiskActions->UserPass = ExistingPassword;\r
 \r
   //\r
@@ -133,42 +132,42 @@ OpalSupportGetAvailableActions(
 TCG_RESULT\r
 EFIAPI\r
 OpalSupportEnableOpalFeature (\r
-  IN OPAL_SESSION              *Session,\r
-  IN VOID                      *Msid,\r
-  IN UINT32                    MsidLength,\r
-  IN VOID                      *Password,\r
-  IN UINT32                    PassLength\r
+  IN OPAL_SESSION  *Session,\r
+  IN VOID          *Msid,\r
+  IN UINT32        MsidLength,\r
+  IN VOID          *Password,\r
+  IN UINT32        PassLength\r
   )\r
 {\r
-  TCG_RESULT   Ret;\r
-\r
-  NULL_CHECK(Session);\r
-  NULL_CHECK(Msid);\r
-  NULL_CHECK(Password);\r
-\r
-  Ret = OpalUtilSetAdminPasswordAsSid(\r
-                          Session,\r
-                          Msid,\r
-                          MsidLength,\r
-                          Password,\r
-                          PassLength\r
-                          );\r
+  TCG_RESULT  Ret;\r
+\r
+  NULL_CHECK (Session);\r
+  NULL_CHECK (Msid);\r
+  NULL_CHECK (Password);\r
+\r
+  Ret = OpalUtilSetAdminPasswordAsSid (\r
+          Session,\r
+          Msid,\r
+          MsidLength,\r
+          Password,\r
+          PassLength\r
+          );\r
   if (Ret == TcgResultSuccess) {\r
     //\r
     // Enable global locking range\r
     //\r
-    Ret = OpalUtilSetOpalLockingRange(\r
-                              Session,\r
-                              Password,\r
-                              PassLength,\r
-                              OPAL_LOCKING_SP_LOCKING_GLOBALRANGE,\r
-                              0,\r
-                              0,\r
-                              TRUE,\r
-                              TRUE,\r
-                              FALSE,\r
-                              FALSE\r
-                              );\r
+    Ret = OpalUtilSetOpalLockingRange (\r
+            Session,\r
+            Password,\r
+            PassLength,\r
+            OPAL_LOCKING_SP_LOCKING_GLOBALRANGE,\r
+            0,\r
+            0,\r
+            TRUE,\r
+            TRUE,\r
+            FALSE,\r
+            FALSE\r
+            );\r
   }\r
 \r
   return Ret;\r
@@ -184,13 +183,13 @@ OpalSupportEnableOpalFeature (
 **/\r
 VOID\r
 OpalSupportUpdatePassword (\r
-  IN OUT OPAL_DISK      *OpalDisk,\r
-  IN VOID               *Password,\r
-  IN UINT32             PasswordLength\r
+  IN OUT OPAL_DISK  *OpalDisk,\r
+  IN VOID           *Password,\r
+  IN UINT32         PasswordLength\r
   )\r
 {\r
   CopyMem (OpalDisk->Password, Password, PasswordLength);\r
-  OpalDisk->PasswordLength = (UINT8) PasswordLength;\r
+  OpalDisk->PasswordLength = (UINT8)PasswordLength;\r
 }\r
 \r
 /**\r
@@ -208,17 +207,17 @@ ExtractDeviceInfoFromDevicePath (
   OUT OPAL_DEVICE_LOCKBOX_DATA  *DevInfo OPTIONAL\r
   )\r
 {\r
-  EFI_DEVICE_PATH_PROTOCOL      *TmpDevPath;\r
-  EFI_DEVICE_PATH_PROTOCOL      *TmpDevPath2;\r
-  PCI_DEVICE_PATH               *PciDevPath;\r
-  UINT8                         DeviceType;\r
-  UINT8                         BusNum;\r
-  OPAL_PCI_DEVICE               *PciDevice;\r
+  EFI_DEVICE_PATH_PROTOCOL  *TmpDevPath;\r
+  EFI_DEVICE_PATH_PROTOCOL  *TmpDevPath2;\r
+  PCI_DEVICE_PATH           *PciDevPath;\r
+  UINT8                     DeviceType;\r
+  UINT8                     BusNum;\r
+  OPAL_PCI_DEVICE           *PciDevice;\r
 \r
   ASSERT (DevicePath != NULL);\r
   ASSERT (DevInfoLength != NULL);\r
 \r
-  DeviceType = OPAL_DEVICE_TYPE_UNKNOWN;\r
+  DeviceType     = OPAL_DEVICE_TYPE_UNKNOWN;\r
   *DevInfoLength = 0;\r
 \r
   TmpDevPath = DevicePath;\r
@@ -228,39 +227,42 @@ ExtractDeviceInfoFromDevicePath (
   //\r
   while (!IsDevicePathEnd (TmpDevPath)) {\r
     if ((TmpDevPath->Type == MESSAGING_DEVICE_PATH) &&\r
-        (TmpDevPath->SubType == MSG_SATA_DP || TmpDevPath->SubType == MSG_NVME_NAMESPACE_DP)) {\r
+        ((TmpDevPath->SubType == MSG_SATA_DP) || (TmpDevPath->SubType == MSG_NVME_NAMESPACE_DP)))\r
+    {\r
       if (DevInfo != NULL) {\r
-        DevInfo->DevicePathLength = (UINT32) GetDevicePathSize (DevicePath);\r
+        DevInfo->DevicePathLength = (UINT32)GetDevicePathSize (DevicePath);\r
         CopyMem (DevInfo->DevicePath, DevicePath, DevInfo->DevicePathLength);\r
       }\r
 \r
-      DeviceType = (TmpDevPath->SubType == MSG_SATA_DP) ? OPAL_DEVICE_TYPE_ATA : OPAL_DEVICE_TYPE_NVME;\r
-      *DevInfoLength = sizeof (OPAL_DEVICE_LOCKBOX_DATA) + (UINT32) GetDevicePathSize (DevicePath);\r
+      DeviceType     = (TmpDevPath->SubType == MSG_SATA_DP) ? OPAL_DEVICE_TYPE_ATA : OPAL_DEVICE_TYPE_NVME;\r
+      *DevInfoLength = sizeof (OPAL_DEVICE_LOCKBOX_DATA) + (UINT32)GetDevicePathSize (DevicePath);\r
       break;\r
     }\r
+\r
     TmpDevPath = NextDevicePathNode (TmpDevPath);\r
   }\r
 \r
   //\r
   // Get device info.\r
   //\r
-  BusNum = 0;\r
-  TmpDevPath = DevicePath;\r
+  BusNum      = 0;\r
+  TmpDevPath  = DevicePath;\r
   TmpDevPath2 = NextDevicePathNode (DevicePath);\r
   while (!IsDevicePathEnd (TmpDevPath2)) {\r
-    if (TmpDevPath->Type == HARDWARE_DEVICE_PATH && TmpDevPath->SubType == HW_PCI_DP) {\r
-      PciDevPath = (PCI_DEVICE_PATH *) TmpDevPath;\r
+    if ((TmpDevPath->Type == HARDWARE_DEVICE_PATH) && (TmpDevPath->SubType == HW_PCI_DP)) {\r
+      PciDevPath = (PCI_DEVICE_PATH *)TmpDevPath;\r
       if ((TmpDevPath2->Type == MESSAGING_DEVICE_PATH) &&\r
-          (TmpDevPath2->SubType == MSG_SATA_DP || TmpDevPath2->SubType == MSG_NVME_NAMESPACE_DP)) {\r
+          ((TmpDevPath2->SubType == MSG_SATA_DP) || (TmpDevPath2->SubType == MSG_NVME_NAMESPACE_DP)))\r
+      {\r
         if (DevInfo != NULL) {\r
-          PciDevice = &DevInfo->Device;\r
-          PciDevice->Segment = 0;\r
-          PciDevice->Bus = BusNum;\r
-          PciDevice->Device = PciDevPath->Device;\r
+          PciDevice           = &DevInfo->Device;\r
+          PciDevice->Segment  = 0;\r
+          PciDevice->Bus      = BusNum;\r
+          PciDevice->Device   = PciDevPath->Device;\r
           PciDevice->Function = PciDevPath->Function;\r
         }\r
       } else {\r
-        if (TmpDevPath2->Type == HARDWARE_DEVICE_PATH && TmpDevPath2->SubType == HW_PCI_DP) {\r
+        if ((TmpDevPath2->Type == HARDWARE_DEVICE_PATH) && (TmpDevPath2->SubType == HW_PCI_DP)) {\r
           BusNum = PciRead8 (PCI_LIB_ADDRESS (BusNum, PciDevPath->Device, PciDevPath->Function, PCI_BRIDGE_SECONDARY_BUS_REGISTER_OFFSET));\r
         }\r
       }\r
@@ -283,23 +285,23 @@ BuildOpalDeviceInfo (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  OPAL_DEVICE_LOCKBOX_DATA    *DevInfo;\r
-  OPAL_DEVICE_LOCKBOX_DATA    *TempDevInfo;\r
-  UINTN                       TotalDevInfoLength;\r
-  UINT32                      DevInfoLength;\r
-  OPAL_DRIVER_DEVICE          *TmpDev;\r
-  UINT8                       DummyData;\r
-  BOOLEAN                     S3InitDevicesExist;\r
-  UINTN                       S3InitDevicesLength;\r
-  EFI_DEVICE_PATH_PROTOCOL    *S3InitDevices;\r
-  EFI_DEVICE_PATH_PROTOCOL    *S3InitDevicesBak;\r
+  EFI_STATUS                Status;\r
+  OPAL_DEVICE_LOCKBOX_DATA  *DevInfo;\r
+  OPAL_DEVICE_LOCKBOX_DATA  *TempDevInfo;\r
+  UINTN                     TotalDevInfoLength;\r
+  UINT32                    DevInfoLength;\r
+  OPAL_DRIVER_DEVICE        *TmpDev;\r
+  UINT8                     DummyData;\r
+  BOOLEAN                   S3InitDevicesExist;\r
+  UINTN                     S3InitDevicesLength;\r
+  EFI_DEVICE_PATH_PROTOCOL  *S3InitDevices;\r
+  EFI_DEVICE_PATH_PROTOCOL  *S3InitDevicesBak;\r
 \r
   //\r
   // Build OPAL device info and save them to LockBox.\r
   //\r
   TotalDevInfoLength = 0;\r
-  TmpDev = mOpalDriver.DeviceList;\r
+  TmpDev             = mOpalDriver.DeviceList;\r
   while (TmpDev != NULL) {\r
     ExtractDeviceInfoFromDevicePath (\r
       TmpDev->OpalDisk.OpalDevicePath,\r
@@ -307,7 +309,7 @@ BuildOpalDeviceInfo (
       NULL\r
       );\r
     TotalDevInfoLength += DevInfoLength;\r
-    TmpDev = TmpDev->Next;\r
+    TmpDev              = TmpDev->Next;\r
   }\r
 \r
   if (TotalDevInfoLength == 0) {\r
@@ -315,11 +317,11 @@ BuildOpalDeviceInfo (
   }\r
 \r
   S3InitDevicesLength = sizeof (DummyData);\r
-  Status = RestoreLockBox (\r
-             &gS3StorageDeviceInitListGuid,\r
-             &DummyData,\r
-             &S3InitDevicesLength\r
-             );\r
+  Status              = RestoreLockBox (\r
+                          &gS3StorageDeviceInitListGuid,\r
+                          &DummyData,\r
+                          &S3InitDevicesLength\r
+                          );\r
   ASSERT ((Status == EFI_NOT_FOUND) || (Status == EFI_BUFFER_TOO_SMALL));\r
   if (Status == EFI_NOT_FOUND) {\r
     S3InitDevices      = NULL;\r
@@ -356,7 +358,7 @@ BuildOpalDeviceInfo (
       &DevInfoLength,\r
       TempDevInfo\r
       );\r
-    TempDevInfo->Length = DevInfoLength;\r
+    TempDevInfo->Length        = DevInfoLength;\r
     TempDevInfo->OpalBaseComId = TmpDev->OpalDisk.OpalBaseComId;\r
     CopyMem (\r
       TempDevInfo->Password,\r
@@ -373,13 +375,14 @@ BuildOpalDeviceInfo (
     if (S3InitDevicesBak != NULL) {\r
       FreePool (S3InitDevicesBak);\r
     }\r
+\r
     ASSERT (S3InitDevices != NULL);\r
     if (S3InitDevices == NULL) {\r
       return;\r
     }\r
 \r
-    TempDevInfo = (OPAL_DEVICE_LOCKBOX_DATA *) ((UINTN) TempDevInfo + DevInfoLength);\r
-    TmpDev = TmpDev->Next;\r
+    TempDevInfo = (OPAL_DEVICE_LOCKBOX_DATA *)((UINTN)TempDevInfo + DevInfoLength);\r
+    TmpDev      = TmpDev->Next;\r
   }\r
 \r
   Status = SaveLockBox (\r
@@ -434,10 +437,10 @@ SendBlockSidCommand (
   VOID\r
   )\r
 {\r
-  OPAL_DRIVER_DEVICE                         *Itr;\r
-  TCG_RESULT                                 Result;\r
-  OPAL_SESSION                               Session;\r
-  UINT32                                     PpStorageFlag;\r
+  OPAL_DRIVER_DEVICE  *Itr;\r
+  TCG_RESULT          Result;\r
+  OPAL_SESSION        Session;\r
+  UINT32              PpStorageFlag;\r
 \r
   PpStorageFlag = Tcg2PhysicalPresenceLibGetManagementFlags ();\r
   if ((PpStorageFlag & TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID) != 0) {\r
@@ -447,9 +450,9 @@ SendBlockSidCommand (
     Itr = mOpalDriver.DeviceList;\r
     while (Itr != NULL) {\r
       if (Itr->OpalDisk.SupportedAttributes.BlockSid) {\r
-        ZeroMem(&Session, sizeof(Session));\r
-        Session.Sscp = Itr->OpalDisk.Sscp;\r
-        Session.MediaId = Itr->OpalDisk.MediaId;\r
+        ZeroMem (&Session, sizeof (Session));\r
+        Session.Sscp          = Itr->OpalDisk.Sscp;\r
+        Session.MediaId       = Itr->OpalDisk.MediaId;\r
         Session.OpalBaseComId = Itr->OpalDisk.OpalBaseComId;\r
 \r
         DEBUG ((DEBUG_INFO, "OpalPassword: EndOfDxe point, send BlockSid command to device!\n"));\r
@@ -482,11 +485,11 @@ SendBlockSidCommand (
 VOID\r
 EFIAPI\r
 OpalEndOfDxeEventNotify (\r
-  EFI_EVENT                               Event,\r
-  VOID                                    *Context\r
+  EFI_EVENT  Event,\r
+  VOID       *Context\r
   )\r
 {\r
-  OPAL_DRIVER_DEVICE    *TmpDev;\r
+  OPAL_DRIVER_DEVICE  *TmpDev;\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
@@ -498,7 +501,7 @@ OpalEndOfDxeEventNotify (
     // as the OPAL requests should have been processed.\r
     //\r
     FreePool (mOpalRequestVariable);\r
-    mOpalRequestVariable = NULL;\r
+    mOpalRequestVariable     = NULL;\r
     mOpalRequestVariableSize = 0;\r
   }\r
 \r
@@ -547,25 +550,25 @@ OpalEndOfDxeEventNotify (
 **/\r
 CHAR8 *\r
 OpalDriverPopUpPsidInput (\r
-  IN OPAL_DRIVER_DEVICE     *Dev,\r
-  IN CHAR16                 *PopUpString,\r
-  IN CHAR16                 *PopUpString2,\r
-  IN CHAR16                 *PopUpString3,\r
-  OUT BOOLEAN               *PressEsc\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *PopUpString,\r
+  IN CHAR16              *PopUpString2,\r
+  IN CHAR16              *PopUpString3,\r
+  OUT BOOLEAN            *PressEsc\r
   )\r
 {\r
-  EFI_INPUT_KEY             InputKey;\r
-  UINTN                     InputLength;\r
-  CHAR16                    Mask[PSID_CHARACTER_LENGTH + 1];\r
-  CHAR16                    Unicode[PSID_CHARACTER_LENGTH + 1];\r
-  CHAR8                     *Ascii;\r
+  EFI_INPUT_KEY  InputKey;\r
+  UINTN          InputLength;\r
+  CHAR16         Mask[PSID_CHARACTER_LENGTH + 1];\r
+  CHAR16         Unicode[PSID_CHARACTER_LENGTH + 1];\r
+  CHAR8          *Ascii;\r
 \r
-  ZeroMem(Unicode, sizeof(Unicode));\r
-  ZeroMem(Mask, sizeof(Mask));\r
+  ZeroMem (Unicode, sizeof (Unicode));\r
+  ZeroMem (Mask, sizeof (Mask));\r
 \r
   *PressEsc = FALSE;\r
 \r
-  gST->ConOut->ClearScreen(gST->ConOut);\r
+  gST->ConOut->ClearScreen (gST->ConOut);\r
 \r
   InputLength = 0;\r
   while (TRUE) {\r
@@ -578,7 +581,7 @@ OpalDriverPopUpPsidInput (
         L"---------------------",\r
         Mask,\r
         NULL\r
-      );\r
+        );\r
     } else {\r
       if (PopUpString3 == NULL) {\r
         CreatePopUp (\r
@@ -589,7 +592,7 @@ OpalDriverPopUpPsidInput (
           L"---------------------",\r
           Mask,\r
           NULL\r
-        );\r
+          );\r
       } else {\r
         CreatePopUp (\r
           EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
@@ -600,7 +603,7 @@ OpalDriverPopUpPsidInput (
           L"---------------------",\r
           Mask,\r
           NULL\r
-        );\r
+          );\r
       }\r
     }\r
 \r
@@ -616,12 +619,13 @@ OpalDriverPopUpPsidInput (
         // Add the null terminator.\r
         //\r
         Unicode[InputLength] = 0;\r
-        Mask[InputLength] = 0;\r
+        Mask[InputLength]    = 0;\r
         break;\r
       } else if ((InputKey.UnicodeChar == CHAR_NULL) ||\r
                  (InputKey.UnicodeChar == CHAR_TAB) ||\r
                  (InputKey.UnicodeChar == CHAR_LINEFEED)\r
-                ) {\r
+                 )\r
+      {\r
         continue;\r
       } else {\r
         //\r
@@ -630,7 +634,7 @@ OpalDriverPopUpPsidInput (
         if (InputKey.UnicodeChar == CHAR_BACKSPACE) {\r
           if (InputLength > 0) {\r
             Unicode[InputLength] = 0;\r
-            Mask[InputLength] = 0;\r
+            Mask[InputLength]    = 0;\r
             InputLength--;\r
           }\r
         } else {\r
@@ -638,14 +642,14 @@ OpalDriverPopUpPsidInput (
           // add Next key entry\r
           //\r
           Unicode[InputLength] = InputKey.UnicodeChar;\r
-          Mask[InputLength] = InputKey.UnicodeChar;\r
+          Mask[InputLength]    = InputKey.UnicodeChar;\r
           InputLength++;\r
           if (InputLength == PSID_CHARACTER_LENGTH) {\r
             //\r
             // Add the null terminator.\r
             //\r
             Unicode[InputLength] = 0;\r
-            Mask[InputLength] = 0;\r
+            Mask[InputLength]    = 0;\r
             break;\r
           }\r
         }\r
@@ -661,9 +665,9 @@ OpalDriverPopUpPsidInput (
     }\r
   }\r
 \r
-  gST->ConOut->ClearScreen(gST->ConOut);\r
+  gST->ConOut->ClearScreen (gST->ConOut);\r
 \r
-  if (InputLength == 0 || InputKey.ScanCode == SCAN_ESC) {\r
+  if ((InputLength == 0) || (InputKey.ScanCode == SCAN_ESC)) {\r
     ZeroMem (Unicode, sizeof (Unicode));\r
     ZeroMem (Mask, sizeof (Mask));\r
     return NULL;\r
@@ -683,7 +687,6 @@ OpalDriverPopUpPsidInput (
   return Ascii;\r
 }\r
 \r
-\r
 /**\r
   Get password input from the popup window.\r
 \r
@@ -699,25 +702,25 @@ OpalDriverPopUpPsidInput (
 **/\r
 CHAR8 *\r
 OpalDriverPopUpPasswordInput (\r
-  IN OPAL_DRIVER_DEVICE     *Dev,\r
-  IN CHAR16                 *PopUpString1,\r
-  IN CHAR16                 *PopUpString2,\r
-  IN CHAR16                 *PopUpString3,\r
-  OUT BOOLEAN               *PressEsc\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *PopUpString1,\r
+  IN CHAR16              *PopUpString2,\r
+  IN CHAR16              *PopUpString3,\r
+  OUT BOOLEAN            *PressEsc\r
   )\r
 {\r
-  EFI_INPUT_KEY             InputKey;\r
-  UINTN                     InputLength;\r
-  CHAR16                    Mask[OPAL_MAX_PASSWORD_SIZE + 1];\r
-  CHAR16                    Unicode[OPAL_MAX_PASSWORD_SIZE + 1];\r
-  CHAR8                     *Ascii;\r
+  EFI_INPUT_KEY  InputKey;\r
+  UINTN          InputLength;\r
+  CHAR16         Mask[OPAL_MAX_PASSWORD_SIZE + 1];\r
+  CHAR16         Unicode[OPAL_MAX_PASSWORD_SIZE + 1];\r
+  CHAR8          *Ascii;\r
 \r
-  ZeroMem(Unicode, sizeof(Unicode));\r
-  ZeroMem(Mask, sizeof(Mask));\r
+  ZeroMem (Unicode, sizeof (Unicode));\r
+  ZeroMem (Mask, sizeof (Mask));\r
 \r
   *PressEsc = FALSE;\r
 \r
-  gST->ConOut->ClearScreen(gST->ConOut);\r
+  gST->ConOut->ClearScreen (gST->ConOut);\r
 \r
   InputLength = 0;\r
   while (TRUE) {\r
@@ -730,7 +733,7 @@ OpalDriverPopUpPasswordInput (
         L"---------------------",\r
         Mask,\r
         NULL\r
-      );\r
+        );\r
     } else {\r
       if (PopUpString3 == NULL) {\r
         CreatePopUp (\r
@@ -741,7 +744,7 @@ OpalDriverPopUpPasswordInput (
           L"---------------------",\r
           Mask,\r
           NULL\r
-        );\r
+          );\r
       } else {\r
         CreatePopUp (\r
           EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
@@ -752,7 +755,7 @@ OpalDriverPopUpPasswordInput (
           L"---------------------",\r
           Mask,\r
           NULL\r
-        );\r
+          );\r
       }\r
     }\r
 \r
@@ -768,12 +771,13 @@ OpalDriverPopUpPasswordInput (
         // Add the null terminator.\r
         //\r
         Unicode[InputLength] = 0;\r
-        Mask[InputLength] = 0;\r
+        Mask[InputLength]    = 0;\r
         break;\r
       } else if ((InputKey.UnicodeChar == CHAR_NULL) ||\r
                  (InputKey.UnicodeChar == CHAR_TAB) ||\r
                  (InputKey.UnicodeChar == CHAR_LINEFEED)\r
-                ) {\r
+                 )\r
+      {\r
         continue;\r
       } else {\r
         //\r
@@ -782,7 +786,7 @@ OpalDriverPopUpPasswordInput (
         if (InputKey.UnicodeChar == CHAR_BACKSPACE) {\r
           if (InputLength > 0) {\r
             Unicode[InputLength] = 0;\r
-            Mask[InputLength] = 0;\r
+            Mask[InputLength]    = 0;\r
             InputLength--;\r
           }\r
         } else {\r
@@ -790,14 +794,14 @@ OpalDriverPopUpPasswordInput (
           // add Next key entry\r
           //\r
           Unicode[InputLength] = InputKey.UnicodeChar;\r
-          Mask[InputLength] = L'*';\r
+          Mask[InputLength]    = L'*';\r
           InputLength++;\r
           if (InputLength == OPAL_MAX_PASSWORD_SIZE) {\r
             //\r
             // Add the null terminator.\r
             //\r
             Unicode[InputLength] = 0;\r
-            Mask[InputLength] = 0;\r
+            Mask[InputLength]    = 0;\r
             break;\r
           }\r
         }\r
@@ -813,9 +817,9 @@ OpalDriverPopUpPasswordInput (
     }\r
   }\r
 \r
-  gST->ConOut->ClearScreen(gST->ConOut);\r
+  gST->ConOut->ClearScreen (gST->ConOut);\r
 \r
-  if (InputLength == 0 || InputKey.ScanCode == SCAN_ESC) {\r
+  if ((InputLength == 0) || (InputKey.ScanCode == SCAN_ESC)) {\r
     ZeroMem (Unicode, sizeof (Unicode));\r
     return NULL;\r
   }\r
@@ -843,8 +847,8 @@ OpalDriverPopUpPasswordInput (
 **/\r
 CHAR16 *\r
 OpalGetPopUpString (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
   if (Dev->Name16 == NULL) {\r
@@ -865,20 +869,20 @@ OpalGetPopUpString (
 **/\r
 VOID\r
 OpalDriverRequestPassword (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
-  UINT8                 Count;\r
-  BOOLEAN               IsEnabled;\r
-  BOOLEAN               IsLocked;\r
-  CHAR8                 *Password;\r
-  UINT32                PasswordLen;\r
-  OPAL_SESSION          Session;\r
-  BOOLEAN               PressEsc;\r
-  EFI_INPUT_KEY         Key;\r
-  TCG_RESULT            Ret;\r
-  CHAR16                *PopUpString;\r
+  UINT8          Count;\r
+  BOOLEAN        IsEnabled;\r
+  BOOLEAN        IsLocked;\r
+  CHAR8          *Password;\r
+  UINT32         PasswordLen;\r
+  OPAL_SESSION   Session;\r
+  BOOLEAN        PressEsc;\r
+  EFI_INPUT_KEY  Key;\r
+  TCG_RESULT     Ret;\r
+  CHAR16         *PopUpString;\r
 \r
   if (Dev == NULL) {\r
     return;\r
@@ -892,9 +896,9 @@ OpalDriverRequestPassword (
 \r
   IsEnabled = OpalFeatureEnabled (&Dev->OpalDisk.SupportedAttributes, &Dev->OpalDisk.LockingFeature);\r
   if (IsEnabled) {\r
-    ZeroMem(&Session, sizeof(Session));\r
-    Session.Sscp = Dev->OpalDisk.Sscp;\r
-    Session.MediaId = Dev->OpalDisk.MediaId;\r
+    ZeroMem (&Session, sizeof (Session));\r
+    Session.Sscp          = Dev->OpalDisk.Sscp;\r
+    Session.MediaId       = Dev->OpalDisk.MediaId;\r
     Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
 \r
     IsLocked = OpalDeviceLocked (&Dev->OpalDisk.SupportedAttributes, &Dev->OpalDisk.LockingFeature);\r
@@ -935,7 +939,7 @@ OpalDriverRequestPassword (
           } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
           if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-            gST->ConOut->ClearScreen(gST->ConOut);\r
+            gST->ConOut->ClearScreen (gST->ConOut);\r
             //\r
             // Keep lock and continue boot.\r
             //\r
@@ -973,17 +977,18 @@ OpalDriverRequestPassword (
       }\r
 \r
       if (Password == NULL) {\r
-        Count ++;\r
+        Count++;\r
         continue;\r
       }\r
-      PasswordLen = (UINT32) AsciiStrLen(Password);\r
+\r
+      PasswordLen = (UINT32)AsciiStrLen (Password);\r
 \r
       if (IsLocked) {\r
-        Ret = OpalUtilUpdateGlobalLockingRange(&Session, Password, PasswordLen, FALSE, FALSE);\r
+        Ret = OpalUtilUpdateGlobalLockingRange (&Session, Password, PasswordLen, FALSE, FALSE);\r
       } else {\r
-        Ret = OpalUtilUpdateGlobalLockingRange(&Session, Password, PasswordLen, TRUE, TRUE);\r
+        Ret = OpalUtilUpdateGlobalLockingRange (&Session, Password, PasswordLen, TRUE, TRUE);\r
         if (Ret == TcgResultSuccess) {\r
-          Ret = OpalUtilUpdateGlobalLockingRange(&Session, Password, PasswordLen, FALSE, FALSE);\r
+          Ret = OpalUtilUpdateGlobalLockingRange (&Session, Password, PasswordLen, FALSE, FALSE);\r
         }\r
       }\r
 \r
@@ -1050,20 +1055,20 @@ OpalDriverRequestPassword (
 **/\r
 VOID\r
 ProcessOpalRequestEnableFeature (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
-  UINT8                 Count;\r
-  CHAR8                 *Password;\r
-  UINT32                PasswordLen;\r
-  CHAR8                 *PasswordConfirm;\r
-  UINT32                PasswordLenConfirm;\r
-  OPAL_SESSION          Session;\r
-  BOOLEAN               PressEsc;\r
-  EFI_INPUT_KEY         Key;\r
-  TCG_RESULT            Ret;\r
-  CHAR16                *PopUpString;\r
+  UINT8          Count;\r
+  CHAR8          *Password;\r
+  UINT32         PasswordLen;\r
+  CHAR8          *PasswordConfirm;\r
+  UINT32         PasswordLenConfirm;\r
+  OPAL_SESSION   Session;\r
+  BOOLEAN        PressEsc;\r
+  EFI_INPUT_KEY  Key;\r
+  TCG_RESULT     Ret;\r
+  CHAR16         *PopUpString;\r
 \r
   if (Dev == NULL) {\r
     return;\r
@@ -1075,51 +1080,54 @@ ProcessOpalRequestEnableFeature (
 \r
   Count = 0;\r
 \r
-  ZeroMem(&Session, sizeof(Session));\r
-  Session.Sscp = Dev->OpalDisk.Sscp;\r
-  Session.MediaId = Dev->OpalDisk.MediaId;\r
+  ZeroMem (&Session, sizeof (Session));\r
+  Session.Sscp          = Dev->OpalDisk.Sscp;\r
+  Session.MediaId       = Dev->OpalDisk.MediaId;\r
   Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
 \r
   while (Count < MAX_PASSWORD_TRY_COUNT) {\r
     Password = OpalDriverPopUpPasswordInput (Dev, PopUpString, L"Please type in your new password", NULL, &PressEsc);\r
     if (PressEsc) {\r
-        do {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Press ENTER to skip the request and continue boot,",\r
-            L"Press ESC to input password again",\r
-            NULL\r
-            );\r
-        } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
+      do {\r
+        CreatePopUp (\r
+          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+          &Key,\r
+          L"Press ENTER to skip the request and continue boot,",\r
+          L"Press ESC to input password again",\r
+          NULL\r
+          );\r
+      } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
-        if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
-          return;\r
-        } else {\r
-          //\r
-          // Let user input password again.\r
-          //\r
-          continue;\r
-        }\r
+      if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
+        gST->ConOut->ClearScreen (gST->ConOut);\r
+        return;\r
+      } else {\r
+        //\r
+        // Let user input password again.\r
+        //\r
+        continue;\r
+      }\r
     }\r
 \r
     if (Password == NULL) {\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLen = (UINT32) AsciiStrLen(Password);\r
+\r
+    PasswordLen = (UINT32)AsciiStrLen (Password);\r
 \r
     PasswordConfirm = OpalDriverPopUpPasswordInput (Dev, PopUpString, L"Please confirm your new password", NULL, &PressEsc);\r
     if (PasswordConfirm == NULL) {\r
       ZeroMem (Password, PasswordLen);\r
       FreePool (Password);\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLenConfirm = (UINT32) AsciiStrLen(PasswordConfirm);\r
+\r
+    PasswordLenConfirm = (UINT32)AsciiStrLen (PasswordConfirm);\r
     if ((PasswordLen != PasswordLenConfirm) ||\r
-        (CompareMem (Password, PasswordConfirm, PasswordLen) != 0)) {\r
+        (CompareMem (Password, PasswordConfirm, PasswordLen) != 0))\r
+    {\r
       ZeroMem (Password, PasswordLen);\r
       FreePool (Password);\r
       ZeroMem (PasswordConfirm, PasswordLenConfirm);\r
@@ -1133,7 +1141,8 @@ ProcessOpalRequestEnableFeature (
           NULL\r
           );\r
       } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-      Count ++;\r
+\r
+      Count++;\r
       continue;\r
     }\r
 \r
@@ -1142,7 +1151,7 @@ ProcessOpalRequestEnableFeature (
       FreePool (PasswordConfirm);\r
     }\r
 \r
-    Ret = OpalSupportEnableOpalFeature (&Session, Dev->OpalDisk.Msid,  Dev->OpalDisk.MsidLength, Password, PasswordLen);\r
+    Ret = OpalSupportEnableOpalFeature (&Session, Dev->OpalDisk.Msid, Dev->OpalDisk.MsidLength, Password, PasswordLen);\r
     if (Ret == TcgResultSuccess) {\r
       OpalSupportUpdatePassword (&Dev->OpalDisk, Password, PasswordLen);\r
       DEBUG ((DEBUG_INFO, "%s Success\n", RequestString));\r
@@ -1182,7 +1191,8 @@ ProcessOpalRequestEnableFeature (
         NULL\r
         );\r
     } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-    gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+    gST->ConOut->ClearScreen (gST->ConOut);\r
   }\r
 }\r
 \r
@@ -1195,19 +1205,19 @@ ProcessOpalRequestEnableFeature (
 **/\r
 VOID\r
 ProcessOpalRequestDisableUser (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
-  UINT8                 Count;\r
-  CHAR8                 *Password;\r
-  UINT32                PasswordLen;\r
-  OPAL_SESSION          Session;\r
-  BOOLEAN               PressEsc;\r
-  EFI_INPUT_KEY         Key;\r
-  TCG_RESULT            Ret;\r
-  BOOLEAN               PasswordFailed;\r
-  CHAR16                *PopUpString;\r
+  UINT8          Count;\r
+  CHAR8          *Password;\r
+  UINT32         PasswordLen;\r
+  OPAL_SESSION   Session;\r
+  BOOLEAN        PressEsc;\r
+  EFI_INPUT_KEY  Key;\r
+  TCG_RESULT     Ret;\r
+  BOOLEAN        PasswordFailed;\r
+  CHAR16         *PopUpString;\r
 \r
   if (Dev == NULL) {\r
     return;\r
@@ -1219,42 +1229,43 @@ ProcessOpalRequestDisableUser (
 \r
   Count = 0;\r
 \r
-  ZeroMem(&Session, sizeof(Session));\r
-  Session.Sscp = Dev->OpalDisk.Sscp;\r
-  Session.MediaId = Dev->OpalDisk.MediaId;\r
+  ZeroMem (&Session, sizeof (Session));\r
+  Session.Sscp          = Dev->OpalDisk.Sscp;\r
+  Session.MediaId       = Dev->OpalDisk.MediaId;\r
   Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
 \r
   while (Count < MAX_PASSWORD_TRY_COUNT) {\r
     Password = OpalDriverPopUpPasswordInput (Dev, PopUpString, NULL, NULL, &PressEsc);\r
     if (PressEsc) {\r
-        do {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Press ENTER to skip the request and continue boot,",\r
-            L"Press ESC to input password again",\r
-            NULL\r
-            );\r
-        } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
+      do {\r
+        CreatePopUp (\r
+          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+          &Key,\r
+          L"Press ENTER to skip the request and continue boot,",\r
+          L"Press ESC to input password again",\r
+          NULL\r
+          );\r
+      } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
-        if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
-          return;\r
-        } else {\r
-          //\r
-          // Let user input password again.\r
-          //\r
-          continue;\r
-        }\r
+      if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
+        gST->ConOut->ClearScreen (gST->ConOut);\r
+        return;\r
+      } else {\r
+        //\r
+        // Let user input password again.\r
+        //\r
+        continue;\r
+      }\r
     }\r
 \r
     if (Password == NULL) {\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLen = (UINT32) AsciiStrLen(Password);\r
 \r
-    Ret = OpalUtilDisableUser(&Session, Password, PasswordLen, &PasswordFailed);\r
+    PasswordLen = (UINT32)AsciiStrLen (Password);\r
+\r
+    Ret = OpalUtilDisableUser (&Session, Password, PasswordLen, &PasswordFailed);\r
     if (Ret == TcgResultSuccess) {\r
       OpalSupportUpdatePassword (&Dev->OpalDisk, Password, PasswordLen);\r
       DEBUG ((DEBUG_INFO, "%s Success\n", RequestString));\r
@@ -1294,7 +1305,8 @@ ProcessOpalRequestDisableUser (
         NULL\r
         );\r
     } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-    gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+    gST->ConOut->ClearScreen (gST->ConOut);\r
   }\r
 }\r
 \r
@@ -1307,21 +1319,21 @@ ProcessOpalRequestDisableUser (
 **/\r
 VOID\r
 ProcessOpalRequestPsidRevert (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
-  UINT8                 Count;\r
-  CHAR8                 *Psid;\r
-  UINT32                PsidLen;\r
-  OPAL_SESSION          Session;\r
-  BOOLEAN               PressEsc;\r
-  EFI_INPUT_KEY         Key;\r
-  TCG_RESULT            Ret;\r
-  CHAR16                *PopUpString;\r
-  CHAR16                *PopUpString2;\r
-  CHAR16                *PopUpString3;\r
-  UINTN                 BufferSize;\r
+  UINT8          Count;\r
+  CHAR8          *Psid;\r
+  UINT32         PsidLen;\r
+  OPAL_SESSION   Session;\r
+  BOOLEAN        PressEsc;\r
+  EFI_INPUT_KEY  Key;\r
+  TCG_RESULT     Ret;\r
+  CHAR16         *PopUpString;\r
+  CHAR16         *PopUpString2;\r
+  CHAR16         *PopUpString3;\r
+  UINTN          BufferSize;\r
 \r
   if (Dev == NULL) {\r
     return;\r
@@ -1332,14 +1344,14 @@ ProcessOpalRequestPsidRevert (
   PopUpString = OpalGetPopUpString (Dev, RequestString);\r
 \r
   if (Dev->OpalDisk.EstimateTimeCost > MAX_ACCEPTABLE_REVERTING_TIME) {\r
-    BufferSize = StrSize (L"Warning: Revert action will take about ####### seconds");\r
+    BufferSize   = StrSize (L"Warning: Revert action will take about ####### seconds");\r
     PopUpString2 = AllocateZeroPool (BufferSize);\r
     ASSERT (PopUpString2 != NULL);\r
     UnicodeSPrint (\r
-        PopUpString2,\r
-        BufferSize,\r
-        L"WARNING: Revert action will take about %d seconds",\r
-        Dev->OpalDisk.EstimateTimeCost\r
+      PopUpString2,\r
+      BufferSize,\r
+      L"WARNING: Revert action will take about %d seconds",\r
+      Dev->OpalDisk.EstimateTimeCost\r
       );\r
     PopUpString3 = L"DO NOT power off system during the revert action!";\r
   } else {\r
@@ -1349,42 +1361,43 @@ ProcessOpalRequestPsidRevert (
 \r
   Count = 0;\r
 \r
-  ZeroMem(&Session, sizeof(Session));\r
-  Session.Sscp = Dev->OpalDisk.Sscp;\r
-  Session.MediaId = Dev->OpalDisk.MediaId;\r
+  ZeroMem (&Session, sizeof (Session));\r
+  Session.Sscp          = Dev->OpalDisk.Sscp;\r
+  Session.MediaId       = Dev->OpalDisk.MediaId;\r
   Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
 \r
   while (Count < MAX_PSID_TRY_COUNT) {\r
     Psid = OpalDriverPopUpPsidInput (Dev, PopUpString, PopUpString2, PopUpString3, &PressEsc);\r
     if (PressEsc) {\r
-        do {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Press ENTER to skip the request and continue boot,",\r
-            L"Press ESC to input Psid again",\r
-            NULL\r
-            );\r
-        } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
+      do {\r
+        CreatePopUp (\r
+          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+          &Key,\r
+          L"Press ENTER to skip the request and continue boot,",\r
+          L"Press ESC to input Psid again",\r
+          NULL\r
+          );\r
+      } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
-        if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
-          goto Done;\r
-        } else {\r
-          //\r
-          // Let user input Psid again.\r
-          //\r
-          continue;\r
-        }\r
+      if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
+        gST->ConOut->ClearScreen (gST->ConOut);\r
+        goto Done;\r
+      } else {\r
+        //\r
+        // Let user input Psid again.\r
+        //\r
+        continue;\r
+      }\r
     }\r
 \r
     if (Psid == NULL) {\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PsidLen = (UINT32) AsciiStrLen(Psid);\r
 \r
-    Ret = OpalUtilPsidRevert(&Session, Psid, PsidLen);\r
+    PsidLen = (UINT32)AsciiStrLen (Psid);\r
+\r
+    Ret = OpalUtilPsidRevert (&Session, Psid, PsidLen);\r
     if (Ret == TcgResultSuccess) {\r
       DEBUG ((DEBUG_INFO, "%s Success\n", RequestString));\r
     } else {\r
@@ -1423,7 +1436,8 @@ ProcessOpalRequestPsidRevert (
         NULL\r
         );\r
     } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-    gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+    gST->ConOut->ClearScreen (gST->ConOut);\r
   }\r
 \r
 Done:\r
@@ -1442,23 +1456,23 @@ Done:
 **/\r
 VOID\r
 ProcessOpalRequestRevert (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN BOOLEAN            KeepUserData,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN BOOLEAN             KeepUserData,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
-  UINT8                 Count;\r
-  CHAR8                 *Password;\r
-  UINT32                PasswordLen;\r
-  OPAL_SESSION          Session;\r
-  BOOLEAN               PressEsc;\r
-  EFI_INPUT_KEY         Key;\r
-  TCG_RESULT            Ret;\r
-  BOOLEAN               PasswordFailed;\r
-  CHAR16                *PopUpString;\r
-  CHAR16                *PopUpString2;\r
-  CHAR16                *PopUpString3;\r
-  UINTN                 BufferSize;\r
+  UINT8          Count;\r
+  CHAR8          *Password;\r
+  UINT32         PasswordLen;\r
+  OPAL_SESSION   Session;\r
+  BOOLEAN        PressEsc;\r
+  EFI_INPUT_KEY  Key;\r
+  TCG_RESULT     Ret;\r
+  BOOLEAN        PasswordFailed;\r
+  CHAR16         *PopUpString;\r
+  CHAR16         *PopUpString2;\r
+  CHAR16         *PopUpString3;\r
+  UINTN          BufferSize;\r
 \r
   if (Dev == NULL) {\r
     return;\r
@@ -1469,15 +1483,16 @@ ProcessOpalRequestRevert (
   PopUpString = OpalGetPopUpString (Dev, RequestString);\r
 \r
   if ((!KeepUserData) &&\r
-      (Dev->OpalDisk.EstimateTimeCost > MAX_ACCEPTABLE_REVERTING_TIME)) {\r
-    BufferSize = StrSize (L"Warning: Revert action will take about ####### seconds");\r
+      (Dev->OpalDisk.EstimateTimeCost > MAX_ACCEPTABLE_REVERTING_TIME))\r
+  {\r
+    BufferSize   = StrSize (L"Warning: Revert action will take about ####### seconds");\r
     PopUpString2 = AllocateZeroPool (BufferSize);\r
     ASSERT (PopUpString2 != NULL);\r
     UnicodeSPrint (\r
-        PopUpString2,\r
-        BufferSize,\r
-        L"WARNING: Revert action will take about %d seconds",\r
-        Dev->OpalDisk.EstimateTimeCost\r
+      PopUpString2,\r
+      BufferSize,\r
+      L"WARNING: Revert action will take about %d seconds",\r
+      Dev->OpalDisk.EstimateTimeCost\r
       );\r
     PopUpString3 = L"DO NOT power off system during the revert action!";\r
   } else {\r
@@ -1487,49 +1502,51 @@ ProcessOpalRequestRevert (
 \r
   Count = 0;\r
 \r
-  ZeroMem(&Session, sizeof(Session));\r
-  Session.Sscp = Dev->OpalDisk.Sscp;\r
-  Session.MediaId = Dev->OpalDisk.MediaId;\r
+  ZeroMem (&Session, sizeof (Session));\r
+  Session.Sscp          = Dev->OpalDisk.Sscp;\r
+  Session.MediaId       = Dev->OpalDisk.MediaId;\r
   Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
 \r
   while (Count < MAX_PASSWORD_TRY_COUNT) {\r
     Password = OpalDriverPopUpPasswordInput (Dev, PopUpString, PopUpString2, PopUpString3, &PressEsc);\r
     if (PressEsc) {\r
-        do {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Press ENTER to skip the request and continue boot,",\r
-            L"Press ESC to input password again",\r
-            NULL\r
-            );\r
-        } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
+      do {\r
+        CreatePopUp (\r
+          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+          &Key,\r
+          L"Press ENTER to skip the request and continue boot,",\r
+          L"Press ESC to input password again",\r
+          NULL\r
+          );\r
+      } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
-        if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
-          goto Done;\r
-        } else {\r
-          //\r
-          // Let user input password again.\r
-          //\r
-          continue;\r
-        }\r
+      if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
+        gST->ConOut->ClearScreen (gST->ConOut);\r
+        goto Done;\r
+      } else {\r
+        //\r
+        // Let user input password again.\r
+        //\r
+        continue;\r
+      }\r
     }\r
 \r
     if (Password == NULL) {\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLen = (UINT32) AsciiStrLen(Password);\r
+\r
+    PasswordLen = (UINT32)AsciiStrLen (Password);\r
 \r
     if ((Dev->OpalDisk.SupportedAttributes.PyriteSsc == 1) &&\r
-        (Dev->OpalDisk.LockingFeature.MediaEncryption == 0)) {\r
+        (Dev->OpalDisk.LockingFeature.MediaEncryption == 0))\r
+    {\r
       //\r
       // For pyrite type device which does not support media encryption,\r
       // it does not accept "Keep User Data" parameter.\r
       // So here hardcode a FALSE for this case.\r
       //\r
-      Ret = OpalUtilRevert(\r
+      Ret = OpalUtilRevert (\r
               &Session,\r
               FALSE,\r
               Password,\r
@@ -1539,7 +1556,7 @@ ProcessOpalRequestRevert (
               Dev->OpalDisk.MsidLength\r
               );\r
     } else {\r
-      Ret = OpalUtilRevert(\r
+      Ret = OpalUtilRevert (\r
               &Session,\r
               KeepUserData,\r
               Password,\r
@@ -1549,6 +1566,7 @@ ProcessOpalRequestRevert (
               Dev->OpalDisk.MsidLength\r
               );\r
     }\r
+\r
     if (Ret == TcgResultSuccess) {\r
       OpalSupportUpdatePassword (&Dev->OpalDisk, Password, PasswordLen);\r
       DEBUG ((DEBUG_INFO, "%s Success\n", RequestString));\r
@@ -1588,7 +1606,8 @@ ProcessOpalRequestRevert (
         NULL\r
         );\r
     } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-    gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+    gST->ConOut->ClearScreen (gST->ConOut);\r
   }\r
 \r
 Done:\r
@@ -1606,22 +1625,22 @@ Done:
 **/\r
 VOID\r
 ProcessOpalRequestSecureErase (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
-  UINT8                 Count;\r
-  CHAR8                 *Password;\r
-  UINT32                PasswordLen;\r
-  OPAL_SESSION          Session;\r
-  BOOLEAN               PressEsc;\r
-  EFI_INPUT_KEY         Key;\r
-  TCG_RESULT            Ret;\r
-  BOOLEAN               PasswordFailed;\r
-  CHAR16                *PopUpString;\r
-  CHAR16                *PopUpString2;\r
-  CHAR16                *PopUpString3;\r
-  UINTN                 BufferSize;\r
+  UINT8          Count;\r
+  CHAR8          *Password;\r
+  UINT32         PasswordLen;\r
+  OPAL_SESSION   Session;\r
+  BOOLEAN        PressEsc;\r
+  EFI_INPUT_KEY  Key;\r
+  TCG_RESULT     Ret;\r
+  BOOLEAN        PasswordFailed;\r
+  CHAR16         *PopUpString;\r
+  CHAR16         *PopUpString2;\r
+  CHAR16         *PopUpString3;\r
+  UINTN          BufferSize;\r
 \r
   if (Dev == NULL) {\r
     return;\r
@@ -1632,58 +1651,60 @@ ProcessOpalRequestSecureErase (
   PopUpString = OpalGetPopUpString (Dev, RequestString);\r
 \r
   if (Dev->OpalDisk.EstimateTimeCost > MAX_ACCEPTABLE_REVERTING_TIME) {\r
-    BufferSize = StrSize (L"Warning: Secure erase action will take about ####### seconds");\r
+    BufferSize   = StrSize (L"Warning: Secure erase action will take about ####### seconds");\r
     PopUpString2 = AllocateZeroPool (BufferSize);\r
     ASSERT (PopUpString2 != NULL);\r
     UnicodeSPrint (\r
-        PopUpString2,\r
-        BufferSize,\r
-        L"WARNING: Secure erase action will take about %d seconds",\r
-        Dev->OpalDisk.EstimateTimeCost\r
+      PopUpString2,\r
+      BufferSize,\r
+      L"WARNING: Secure erase action will take about %d seconds",\r
+      Dev->OpalDisk.EstimateTimeCost\r
       );\r
     PopUpString3 = L"DO NOT power off system during the action!";\r
   } else {\r
     PopUpString2 = NULL;\r
     PopUpString3 = NULL;\r
   }\r
+\r
   Count = 0;\r
 \r
-  ZeroMem(&Session, sizeof(Session));\r
-  Session.Sscp = Dev->OpalDisk.Sscp;\r
-  Session.MediaId = Dev->OpalDisk.MediaId;\r
+  ZeroMem (&Session, sizeof (Session));\r
+  Session.Sscp          = Dev->OpalDisk.Sscp;\r
+  Session.MediaId       = Dev->OpalDisk.MediaId;\r
   Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
 \r
   while (Count < MAX_PASSWORD_TRY_COUNT) {\r
     Password = OpalDriverPopUpPasswordInput (Dev, PopUpString, PopUpString2, PopUpString3, &PressEsc);\r
     if (PressEsc) {\r
-        do {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Press ENTER to skip the request and continue boot,",\r
-            L"Press ESC to input password again",\r
-            NULL\r
-            );\r
-        } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
+      do {\r
+        CreatePopUp (\r
+          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+          &Key,\r
+          L"Press ENTER to skip the request and continue boot,",\r
+          L"Press ESC to input password again",\r
+          NULL\r
+          );\r
+      } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
-        if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
-          goto Done;\r
-        } else {\r
-          //\r
-          // Let user input password again.\r
-          //\r
-          continue;\r
-        }\r
+      if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
+        gST->ConOut->ClearScreen (gST->ConOut);\r
+        goto Done;\r
+      } else {\r
+        //\r
+        // Let user input password again.\r
+        //\r
+        continue;\r
+      }\r
     }\r
 \r
     if (Password == NULL) {\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLen = (UINT32) AsciiStrLen(Password);\r
 \r
-    Ret = OpalUtilSecureErase(&Session, Password, PasswordLen, &PasswordFailed);\r
+    PasswordLen = (UINT32)AsciiStrLen (Password);\r
+\r
+    Ret = OpalUtilSecureErase (&Session, Password, PasswordLen, &PasswordFailed);\r
     if (Ret == TcgResultSuccess) {\r
       OpalSupportUpdatePassword (&Dev->OpalDisk, Password, PasswordLen);\r
       DEBUG ((DEBUG_INFO, "%s Success\n", RequestString));\r
@@ -1723,7 +1744,8 @@ ProcessOpalRequestSecureErase (
         NULL\r
         );\r
     } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-    gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+    gST->ConOut->ClearScreen (gST->ConOut);\r
   }\r
 \r
 Done:\r
@@ -1741,22 +1763,22 @@ Done:
 **/\r
 VOID\r
 ProcessOpalRequestSetUserPwd (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
-  UINT8                 Count;\r
-  CHAR8                 *OldPassword;\r
-  UINT32                OldPasswordLen;\r
-  CHAR8                 *Password;\r
-  UINT32                PasswordLen;\r
-  CHAR8                 *PasswordConfirm;\r
-  UINT32                PasswordLenConfirm;\r
-  OPAL_SESSION          Session;\r
-  BOOLEAN               PressEsc;\r
-  EFI_INPUT_KEY         Key;\r
-  TCG_RESULT            Ret;\r
-  CHAR16                *PopUpString;\r
+  UINT8          Count;\r
+  CHAR8          *OldPassword;\r
+  UINT32         OldPasswordLen;\r
+  CHAR8          *Password;\r
+  UINT32         PasswordLen;\r
+  CHAR8          *PasswordConfirm;\r
+  UINT32         PasswordLenConfirm;\r
+  OPAL_SESSION   Session;\r
+  BOOLEAN        PressEsc;\r
+  EFI_INPUT_KEY  Key;\r
+  TCG_RESULT     Ret;\r
+  CHAR16         *PopUpString;\r
 \r
   if (Dev == NULL) {\r
     return;\r
@@ -1771,38 +1793,39 @@ ProcessOpalRequestSetUserPwd (
   while (Count < MAX_PASSWORD_TRY_COUNT) {\r
     OldPassword = OpalDriverPopUpPasswordInput (Dev, PopUpString, L"Please type in your password", NULL, &PressEsc);\r
     if (PressEsc) {\r
-        do {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Press ENTER to skip the request and continue boot,",\r
-            L"Press ESC to input password again",\r
-            NULL\r
-            );\r
-        } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
+      do {\r
+        CreatePopUp (\r
+          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+          &Key,\r
+          L"Press ENTER to skip the request and continue boot,",\r
+          L"Press ESC to input password again",\r
+          NULL\r
+          );\r
+      } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
-        if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
-          return;\r
-        } else {\r
-          //\r
-          // Let user input password again.\r
-          //\r
-          continue;\r
-        }\r
+      if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
+        gST->ConOut->ClearScreen (gST->ConOut);\r
+        return;\r
+      } else {\r
+        //\r
+        // Let user input password again.\r
+        //\r
+        continue;\r
+      }\r
     }\r
 \r
     if (OldPassword == NULL) {\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    OldPasswordLen = (UINT32) AsciiStrLen(OldPassword);\r
 \r
-    ZeroMem(&Session, sizeof(Session));\r
-    Session.Sscp = Dev->OpalDisk.Sscp;\r
-    Session.MediaId = Dev->OpalDisk.MediaId;\r
+    OldPasswordLen = (UINT32)AsciiStrLen (OldPassword);\r
+\r
+    ZeroMem (&Session, sizeof (Session));\r
+    Session.Sscp          = Dev->OpalDisk.Sscp;\r
+    Session.MediaId       = Dev->OpalDisk.MediaId;\r
     Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
-    Ret = OpalUtilVerifyPassword (&Session, OldPassword, OldPasswordLen, OPAL_LOCKING_SP_USER1_AUTHORITY);\r
+    Ret                   = OpalUtilVerifyPassword (&Session, OldPassword, OldPasswordLen, OPAL_LOCKING_SP_USER1_AUTHORITY);\r
     if (Ret == TcgResultSuccess) {\r
       DEBUG ((DEBUG_INFO, "Verify with USER1 authority : Success\n"));\r
     } else {\r
@@ -1822,7 +1845,8 @@ ProcessOpalRequestSetUserPwd (
             NULL\r
             );\r
         } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-        Count ++;\r
+\r
+        Count++;\r
         continue;\r
       }\r
     }\r
@@ -1831,10 +1855,11 @@ ProcessOpalRequestSetUserPwd (
     if (Password == NULL) {\r
       ZeroMem (OldPassword, OldPasswordLen);\r
       FreePool (OldPassword);\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLen = (UINT32) AsciiStrLen(Password);\r
+\r
+    PasswordLen = (UINT32)AsciiStrLen (Password);\r
 \r
     PasswordConfirm = OpalDriverPopUpPasswordInput (Dev, PopUpString, L"Please confirm your new password", NULL, &PressEsc);\r
     if (PasswordConfirm == NULL) {\r
@@ -1842,12 +1867,14 @@ ProcessOpalRequestSetUserPwd (
       FreePool (OldPassword);\r
       ZeroMem (Password, PasswordLen);\r
       FreePool (Password);\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLenConfirm = (UINT32) AsciiStrLen(PasswordConfirm);\r
+\r
+    PasswordLenConfirm = (UINT32)AsciiStrLen (PasswordConfirm);\r
     if ((PasswordLen != PasswordLenConfirm) ||\r
-        (CompareMem (Password, PasswordConfirm, PasswordLen) != 0)) {\r
+        (CompareMem (Password, PasswordConfirm, PasswordLen) != 0))\r
+    {\r
       ZeroMem (OldPassword, OldPasswordLen);\r
       FreePool (OldPassword);\r
       ZeroMem (Password, PasswordLen);\r
@@ -1863,7 +1890,8 @@ ProcessOpalRequestSetUserPwd (
           NULL\r
           );\r
       } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-      Count ++;\r
+\r
+      Count++;\r
       continue;\r
     }\r
 \r
@@ -1872,17 +1900,17 @@ ProcessOpalRequestSetUserPwd (
       FreePool (PasswordConfirm);\r
     }\r
 \r
-    ZeroMem(&Session, sizeof(Session));\r
-    Session.Sscp = Dev->OpalDisk.Sscp;\r
-    Session.MediaId = Dev->OpalDisk.MediaId;\r
+    ZeroMem (&Session, sizeof (Session));\r
+    Session.Sscp          = Dev->OpalDisk.Sscp;\r
+    Session.MediaId       = Dev->OpalDisk.MediaId;\r
     Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
-    Ret = OpalUtilSetUserPassword(\r
-            &Session,\r
-            OldPassword,\r
-            OldPasswordLen,\r
-            Password,\r
-            PasswordLen\r
-            );\r
+    Ret                   = OpalUtilSetUserPassword (\r
+                              &Session,\r
+                              OldPassword,\r
+                              OldPasswordLen,\r
+                              Password,\r
+                              PasswordLen\r
+                              );\r
     if (Ret == TcgResultSuccess) {\r
       OpalSupportUpdatePassword (&Dev->OpalDisk, Password, PasswordLen);\r
       DEBUG ((DEBUG_INFO, "%s Success\n", RequestString));\r
@@ -1927,7 +1955,8 @@ ProcessOpalRequestSetUserPwd (
         NULL\r
         );\r
     } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-    gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+    gST->ConOut->ClearScreen (gST->ConOut);\r
   }\r
 }\r
 \r
@@ -1940,22 +1969,22 @@ ProcessOpalRequestSetUserPwd (
 **/\r
 VOID\r
 ProcessOpalRequestSetAdminPwd (\r
-  IN OPAL_DRIVER_DEVICE *Dev,\r
-  IN CHAR16             *RequestString\r
+  IN OPAL_DRIVER_DEVICE  *Dev,\r
+  IN CHAR16              *RequestString\r
   )\r
 {\r
-  UINT8                 Count;\r
-  CHAR8                 *OldPassword;\r
-  UINT32                OldPasswordLen;\r
-  CHAR8                 *Password;\r
-  UINT32                PasswordLen;\r
-  CHAR8                 *PasswordConfirm;\r
-  UINT32                PasswordLenConfirm;\r
-  OPAL_SESSION          Session;\r
-  BOOLEAN               PressEsc;\r
-  EFI_INPUT_KEY         Key;\r
-  TCG_RESULT            Ret;\r
-  CHAR16                *PopUpString;\r
+  UINT8          Count;\r
+  CHAR8          *OldPassword;\r
+  UINT32         OldPasswordLen;\r
+  CHAR8          *Password;\r
+  UINT32         PasswordLen;\r
+  CHAR8          *PasswordConfirm;\r
+  UINT32         PasswordLenConfirm;\r
+  OPAL_SESSION   Session;\r
+  BOOLEAN        PressEsc;\r
+  EFI_INPUT_KEY  Key;\r
+  TCG_RESULT     Ret;\r
+  CHAR16         *PopUpString;\r
 \r
   if (Dev == NULL) {\r
     return;\r
@@ -1970,38 +1999,39 @@ ProcessOpalRequestSetAdminPwd (
   while (Count < MAX_PASSWORD_TRY_COUNT) {\r
     OldPassword = OpalDriverPopUpPasswordInput (Dev, PopUpString, L"Please type in your password", NULL, &PressEsc);\r
     if (PressEsc) {\r
-        do {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Press ENTER to skip the request and continue boot,",\r
-            L"Press ESC to input password again",\r
-            NULL\r
-            );\r
-        } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
+      do {\r
+        CreatePopUp (\r
+          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+          &Key,\r
+          L"Press ENTER to skip the request and continue boot,",\r
+          L"Press ESC to input password again",\r
+          NULL\r
+          );\r
+      } while ((Key.ScanCode != SCAN_ESC) && (Key.UnicodeChar != CHAR_CARRIAGE_RETURN));\r
 \r
-        if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
-          gST->ConOut->ClearScreen(gST->ConOut);\r
-          return;\r
-        } else {\r
-          //\r
-          // Let user input password again.\r
-          //\r
-          continue;\r
-        }\r
+      if (Key.UnicodeChar == CHAR_CARRIAGE_RETURN) {\r
+        gST->ConOut->ClearScreen (gST->ConOut);\r
+        return;\r
+      } else {\r
+        //\r
+        // Let user input password again.\r
+        //\r
+        continue;\r
+      }\r
     }\r
 \r
     if (OldPassword == NULL) {\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    OldPasswordLen = (UINT32) AsciiStrLen(OldPassword);\r
 \r
-    ZeroMem(&Session, sizeof(Session));\r
-    Session.Sscp = Dev->OpalDisk.Sscp;\r
-    Session.MediaId = Dev->OpalDisk.MediaId;\r
+    OldPasswordLen = (UINT32)AsciiStrLen (OldPassword);\r
+\r
+    ZeroMem (&Session, sizeof (Session));\r
+    Session.Sscp          = Dev->OpalDisk.Sscp;\r
+    Session.MediaId       = Dev->OpalDisk.MediaId;\r
     Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
-    Ret = OpalUtilVerifyPassword (&Session, OldPassword, OldPasswordLen, OPAL_LOCKING_SP_ADMIN1_AUTHORITY);\r
+    Ret                   = OpalUtilVerifyPassword (&Session, OldPassword, OldPasswordLen, OPAL_LOCKING_SP_ADMIN1_AUTHORITY);\r
     if (Ret == TcgResultSuccess) {\r
       DEBUG ((DEBUG_INFO, "Verify: Success\n"));\r
     } else {\r
@@ -2017,7 +2047,8 @@ ProcessOpalRequestSetAdminPwd (
           NULL\r
           );\r
       } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-      Count ++;\r
+\r
+      Count++;\r
       continue;\r
     }\r
 \r
@@ -2025,10 +2056,11 @@ ProcessOpalRequestSetAdminPwd (
     if (Password == NULL) {\r
       ZeroMem (OldPassword, OldPasswordLen);\r
       FreePool (OldPassword);\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLen = (UINT32) AsciiStrLen(Password);\r
+\r
+    PasswordLen = (UINT32)AsciiStrLen (Password);\r
 \r
     PasswordConfirm = OpalDriverPopUpPasswordInput (Dev, PopUpString, L"Please confirm your new password", NULL, &PressEsc);\r
     if (PasswordConfirm == NULL) {\r
@@ -2036,12 +2068,14 @@ ProcessOpalRequestSetAdminPwd (
       FreePool (OldPassword);\r
       ZeroMem (Password, PasswordLen);\r
       FreePool (Password);\r
-      Count ++;\r
+      Count++;\r
       continue;\r
     }\r
-    PasswordLenConfirm = (UINT32) AsciiStrLen(PasswordConfirm);\r
+\r
+    PasswordLenConfirm = (UINT32)AsciiStrLen (PasswordConfirm);\r
     if ((PasswordLen != PasswordLenConfirm) ||\r
-        (CompareMem (Password, PasswordConfirm, PasswordLen) != 0)) {\r
+        (CompareMem (Password, PasswordConfirm, PasswordLen) != 0))\r
+    {\r
       ZeroMem (OldPassword, OldPasswordLen);\r
       FreePool (OldPassword);\r
       ZeroMem (Password, PasswordLen);\r
@@ -2057,7 +2091,8 @@ ProcessOpalRequestSetAdminPwd (
           NULL\r
           );\r
       } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-      Count ++;\r
+\r
+      Count++;\r
       continue;\r
     }\r
 \r
@@ -2066,18 +2101,17 @@ ProcessOpalRequestSetAdminPwd (
       FreePool (PasswordConfirm);\r
     }\r
 \r
-\r
-    ZeroMem(&Session, sizeof(Session));\r
-    Session.Sscp = Dev->OpalDisk.Sscp;\r
-    Session.MediaId = Dev->OpalDisk.MediaId;\r
+    ZeroMem (&Session, sizeof (Session));\r
+    Session.Sscp          = Dev->OpalDisk.Sscp;\r
+    Session.MediaId       = Dev->OpalDisk.MediaId;\r
     Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
-    Ret = OpalUtilSetAdminPassword(\r
-            &Session,\r
-            OldPassword,\r
-            OldPasswordLen,\r
-            Password,\r
-            PasswordLen\r
-            );\r
+    Ret                   = OpalUtilSetAdminPassword (\r
+                              &Session,\r
+                              OldPassword,\r
+                              OldPasswordLen,\r
+                              Password,\r
+                              PasswordLen\r
+                              );\r
     if (Ret == TcgResultSuccess) {\r
       OpalSupportUpdatePassword (&Dev->OpalDisk, Password, PasswordLen);\r
       DEBUG ((DEBUG_INFO, "%s Success\n", RequestString));\r
@@ -2122,7 +2156,8 @@ ProcessOpalRequestSetAdminPwd (
         NULL\r
         );\r
     } while (Key.UnicodeChar != CHAR_CARRIAGE_RETURN);\r
-    gST->ConOut->ClearScreen(gST->ConOut);\r
+\r
+    gST->ConOut->ClearScreen (gST->ConOut);\r
   }\r
 }\r
 \r
@@ -2134,7 +2169,7 @@ ProcessOpalRequestSetAdminPwd (
 **/\r
 VOID\r
 ProcessOpalRequest (\r
-  IN OPAL_DRIVER_DEVICE     *Dev\r
+  IN OPAL_DRIVER_DEVICE  *Dev\r
   )\r
 {\r
   EFI_STATUS                Status;\r
@@ -2153,13 +2188,14 @@ ProcessOpalRequest (
     Status = GetVariable2 (\r
                OPAL_REQUEST_VARIABLE_NAME,\r
                &gHiiSetupVariableGuid,\r
-               (VOID **) &Variable,\r
+               (VOID **)&Variable,\r
                &VariableSize\r
                );\r
     if (EFI_ERROR (Status) || (Variable == NULL)) {\r
       return;\r
     }\r
-    mOpalRequestVariable = Variable;\r
+\r
+    mOpalRequestVariable     = Variable;\r
     mOpalRequestVariableSize = VariableSize;\r
 \r
     //\r
@@ -2167,14 +2203,14 @@ ProcessOpalRequest (
     //\r
     Status = gRT->SetVariable (\r
                     OPAL_REQUEST_VARIABLE_NAME,\r
-                    (EFI_GUID *) &gHiiSetupVariableGuid,\r
+                    (EFI_GUID *)&gHiiSetupVariableGuid,\r
                     0,\r
                     0,\r
                     NULL\r
                     );\r
     ASSERT_EFI_ERROR (Status);\r
   } else {\r
-    Variable = mOpalRequestVariable;\r
+    Variable     = mOpalRequestVariable;\r
     VariableSize = mOpalRequestVariableSize;\r
   }\r
 \r
@@ -2184,39 +2220,47 @@ ProcessOpalRequest (
   TempVariable = Variable;\r
   while ((VariableSize > sizeof (OPAL_REQUEST_VARIABLE)) &&\r
          (VariableSize >= TempVariable->Length) &&\r
-         (TempVariable->Length > sizeof (OPAL_REQUEST_VARIABLE))) {\r
-    DevicePathInVariable = (EFI_DEVICE_PATH_PROTOCOL *) ((UINTN) TempVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
+         (TempVariable->Length > sizeof (OPAL_REQUEST_VARIABLE)))\r
+  {\r
+    DevicePathInVariable     = (EFI_DEVICE_PATH_PROTOCOL *)((UINTN)TempVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
     DevicePathSizeInVariable = GetDevicePathSize (DevicePathInVariable);\r
-    DevicePath = Dev->OpalDisk.OpalDevicePath;\r
-    DevicePathSize = GetDevicePathSize (DevicePath);\r
+    DevicePath               = Dev->OpalDisk.OpalDevicePath;\r
+    DevicePathSize           = GetDevicePathSize (DevicePath);\r
     if ((DevicePathSize == DevicePathSizeInVariable) &&\r
-        (CompareMem (DevicePath, DevicePathInVariable, DevicePathSize) == 0)) {\r
+        (CompareMem (DevicePath, DevicePathInVariable, DevicePathSize) == 0))\r
+    {\r
       //\r
       // Found the node for the OPAL device.\r
       //\r
       if (TempVariable->OpalRequest.SetAdminPwd != 0) {\r
         ProcessOpalRequestSetAdminPwd (Dev, L"Update Admin Pwd:");\r
       }\r
+\r
       if (TempVariable->OpalRequest.SetUserPwd != 0) {\r
         ProcessOpalRequestSetUserPwd (Dev, L"Set User Pwd:");\r
       }\r
-      if (TempVariable->OpalRequest.SecureErase!= 0) {\r
+\r
+      if (TempVariable->OpalRequest.SecureErase != 0) {\r
         ProcessOpalRequestSecureErase (Dev, L"Secure Erase:");\r
       }\r
+\r
       if (TempVariable->OpalRequest.Revert != 0) {\r
-        KeepUserData = (BOOLEAN) TempVariable->OpalRequest.KeepUserData;\r
+        KeepUserData = (BOOLEAN)TempVariable->OpalRequest.KeepUserData;\r
         ProcessOpalRequestRevert (\r
           Dev,\r
           KeepUserData,\r
           KeepUserData ? L"Admin Revert(keep):" : L"Admin Revert:"\r
           );\r
       }\r
+\r
       if (TempVariable->OpalRequest.PsidRevert != 0) {\r
         ProcessOpalRequestPsidRevert (Dev, L"Psid Revert:");\r
       }\r
+\r
       if (TempVariable->OpalRequest.DisableUser != 0) {\r
         ProcessOpalRequestDisableUser (Dev, L"Disable User:");\r
       }\r
+\r
       if (TempVariable->OpalRequest.EnableFeature != 0) {\r
         ProcessOpalRequestEnableFeature (Dev, L"Enable Feature:");\r
       }\r
@@ -2231,7 +2275,7 @@ ProcessOpalRequest (
     }\r
 \r
     VariableSize -= TempVariable->Length;\r
-    TempVariable = (OPAL_REQUEST_VARIABLE *) ((UINTN) TempVariable + TempVariable->Length);\r
+    TempVariable  = (OPAL_REQUEST_VARIABLE *)((UINTN)TempVariable + TempVariable->Length);\r
   }\r
 \r
   DEBUG ((DEBUG_INFO, "%a() - exit\n", __FUNCTION__));\r
@@ -2244,11 +2288,11 @@ ProcessOpalRequest (
 \r
 **/\r
 VOID\r
-AddDeviceToTail(\r
-  IN OPAL_DRIVER_DEVICE    *Dev\r
+AddDeviceToTail (\r
+  IN OPAL_DRIVER_DEVICE  *Dev\r
   )\r
 {\r
-  OPAL_DRIVER_DEVICE                *TmpDev;\r
+  OPAL_DRIVER_DEVICE  *TmpDev;\r
 \r
   if (mOpalDriver.DeviceList == NULL) {\r
     mOpalDriver.DeviceList = Dev;\r
@@ -2270,10 +2314,10 @@ AddDeviceToTail(
 **/\r
 VOID\r
 RemoveDevice (\r
-  IN OPAL_DRIVER_DEVICE    *Dev\r
+  IN OPAL_DRIVER_DEVICE  *Dev\r
   )\r
 {\r
-  OPAL_DRIVER_DEVICE                *TmpDev;\r
+  OPAL_DRIVER_DEVICE  *TmpDev;\r
 \r
   if (mOpalDriver.DeviceList == NULL) {\r
     return;\r
@@ -2304,10 +2348,10 @@ GetDeviceCount (
   VOID\r
   )\r
 {\r
-  UINT8                Count;\r
-  OPAL_DRIVER_DEVICE   *TmpDev;\r
+  UINT8               Count;\r
+  OPAL_DRIVER_DEVICE  *TmpDev;\r
 \r
-  Count = 0;\r
+  Count  = 0;\r
   TmpDev = mOpalDriver.DeviceList;\r
 \r
   while (TmpDev != NULL) {\r
@@ -2323,8 +2367,8 @@ GetDeviceCount (
 \r
   @retval     return the device list pointer.\r
 **/\r
-OPAL_DRIVER_DEVICE*\r
-OpalDriverGetDeviceList(\r
+OPAL_DRIVER_DEVICE *\r
+OpalDriverGetDeviceList (\r
   VOID\r
   )\r
 {\r
@@ -2339,38 +2383,38 @@ OpalDriverGetDeviceList(
 **/\r
 VOID\r
 OpalDriverStopDevice (\r
-  OPAL_DRIVER_DEVICE     *Dev\r
+  OPAL_DRIVER_DEVICE  *Dev\r
   )\r
 {\r
   //\r
   // free each name\r
   //\r
-  FreePool(Dev->Name16);\r
+  FreePool (Dev->Name16);\r
 \r
   //\r
   // remove OPAL_DRIVER_DEVICE from the list\r
   // it updates the controllerList pointer\r
   //\r
-  RemoveDevice(Dev);\r
+  RemoveDevice (Dev);\r
 \r
   //\r
   // close protocols that were opened\r
   //\r
-  gBS->CloseProtocol(\r
-    Dev->Handle,\r
-    &gEfiStorageSecurityCommandProtocolGuid,\r
-    gOpalDriverBinding.DriverBindingHandle,\r
-    Dev->Handle\r
-    );\r
-\r
-  gBS->CloseProtocol(\r
-    Dev->Handle,\r
-    &gEfiBlockIoProtocolGuid,\r
-    gOpalDriverBinding.DriverBindingHandle,\r
-    Dev->Handle\r
-    );\r
-\r
-  FreePool(Dev);\r
+  gBS->CloseProtocol (\r
+         Dev->Handle,\r
+         &gEfiStorageSecurityCommandProtocolGuid,\r
+         gOpalDriverBinding.DriverBindingHandle,\r
+         Dev->Handle\r
+         );\r
+\r
+  gBS->CloseProtocol (\r
+         Dev->Handle,\r
+         &gEfiBlockIoProtocolGuid,\r
+         gOpalDriverBinding.DriverBindingHandle,\r
+         Dev->Handle\r
+         );\r
+\r
+  FreePool (Dev);\r
 }\r
 \r
 /**\r
@@ -2385,26 +2429,26 @@ OpalDriverStopDevice (
   @retval     FALSE       Not found the name for this device.\r
 **/\r
 BOOLEAN\r
-OpalDriverGetDeviceNameByProtocol(\r
-  EFI_HANDLE             *AllHandlesBuffer,\r
-  UINTN                  NumAllHandles,\r
-  OPAL_DRIVER_DEVICE     *Dev,\r
-  BOOLEAN                UseComp1\r
+OpalDriverGetDeviceNameByProtocol (\r
+  EFI_HANDLE          *AllHandlesBuffer,\r
+  UINTN               NumAllHandles,\r
+  OPAL_DRIVER_DEVICE  *Dev,\r
+  BOOLEAN             UseComp1\r
   )\r
 {\r
-  EFI_HANDLE*                   ProtocolHandlesBuffer;\r
+  EFI_HANDLE                    *ProtocolHandlesBuffer;\r
   UINTN                         NumProtocolHandles;\r
   EFI_STATUS                    Status;\r
-  EFI_COMPONENT_NAME2_PROTOCOLCnp1_2; // efi component name and componentName2 have same layout\r
+  EFI_COMPONENT_NAME2_PROTOCOL  *Cnp1_2; // efi component name and componentName2 have same layout\r
   EFI_GUID                      Protocol;\r
   UINTN                         StrLength;\r
-  EFI_DEVICE_PATH_PROTOCOL*     TmpDevPath;\r
+  EFI_DEVICE_PATH_PROTOCOL      *TmpDevPath;\r
   UINTN                         Index1;\r
   UINTN                         Index2;\r
   EFI_HANDLE                    TmpHandle;\r
   CHAR16                        *DevName;\r
 \r
-  if (Dev == NULL || AllHandlesBuffer == NULL || NumAllHandles == 0) {\r
+  if ((Dev == NULL) || (AllHandlesBuffer == NULL) || (NumAllHandles == 0)) {\r
     return FALSE;\r
   }\r
 \r
@@ -2413,18 +2457,17 @@ OpalDriverGetDeviceNameByProtocol(
   //\r
   // Find all EFI_HANDLES with protocol\r
   //\r
-  Status = gBS->LocateHandleBuffer(\r
-               ByProtocol,\r
-               &Protocol,\r
-               NULL,\r
-               &NumProtocolHandles,\r
-               &ProtocolHandlesBuffer\r
-               );\r
-  if (EFI_ERROR(Status)) {\r
+  Status = gBS->LocateHandleBuffer (\r
+                  ByProtocol,\r
+                  &Protocol,\r
+                  NULL,\r
+                  &NumProtocolHandles,\r
+                  &ProtocolHandlesBuffer\r
+                  );\r
+  if (EFI_ERROR (Status)) {\r
     return FALSE;\r
   }\r
 \r
-\r
   //\r
   // Exit early if no supported devices\r
   //\r
@@ -2448,15 +2491,15 @@ OpalDriverGetDeviceNameByProtocol(
 \r
     TmpHandle = ProtocolHandlesBuffer[Index1];\r
 \r
-    Status = gBS->OpenProtocol(\r
-                 TmpHandle,\r
-                 &Protocol,\r
-                 (VOID**)&Cnp1_2,\r
-                 gImageHandle,\r
-                 NULL,\r
-                 EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
-                 );\r
-    if (EFI_ERROR(Status) || Cnp1_2 == NULL) {\r
+    Status = gBS->OpenProtocol (\r
+                    TmpHandle,\r
+                    &Protocol,\r
+                    (VOID **)&Cnp1_2,\r
+                    gImageHandle,\r
+                    NULL,\r
+                    EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
+                    );\r
+    if (EFI_ERROR (Status) || (Cnp1_2 == NULL)) {\r
       continue;\r
     }\r
 \r
@@ -2464,53 +2507,55 @@ OpalDriverGetDeviceNameByProtocol(
     // Use all handles array as controller handle\r
     //\r
     for (Index2 = 0; Index2 < NumAllHandles; Index2++) {\r
-      Status = Cnp1_2->GetControllerName(\r
-                   Cnp1_2,\r
-                   AllHandlesBuffer[Index2],\r
-                   Dev->Handle,\r
-                   LANGUAGE_ISO_639_2_ENGLISH,\r
-                   &DevName\r
-                   );\r
-      if (EFI_ERROR(Status)) {\r
-        Status = Cnp1_2->GetControllerName(\r
-                     Cnp1_2,\r
-                     AllHandlesBuffer[Index2],\r
-                     Dev->Handle,\r
-                     LANGUAGE_RFC_3066_ENGLISH,\r
-                     &DevName\r
-                     );\r
+      Status = Cnp1_2->GetControllerName (\r
+                         Cnp1_2,\r
+                         AllHandlesBuffer[Index2],\r
+                         Dev->Handle,\r
+                         LANGUAGE_ISO_639_2_ENGLISH,\r
+                         &DevName\r
+                         );\r
+      if (EFI_ERROR (Status)) {\r
+        Status = Cnp1_2->GetControllerName (\r
+                           Cnp1_2,\r
+                           AllHandlesBuffer[Index2],\r
+                           Dev->Handle,\r
+                           LANGUAGE_RFC_3066_ENGLISH,\r
+                           &DevName\r
+                           );\r
       }\r
-      if (!EFI_ERROR(Status) && DevName != NULL) {\r
-        StrLength = StrLen(DevName) + 1;        // Add one for NULL terminator\r
-        Dev->Name16 = AllocateZeroPool(StrLength * sizeof (CHAR16));\r
+\r
+      if (!EFI_ERROR (Status) && (DevName != NULL)) {\r
+        StrLength   = StrLen (DevName) + 1;     // Add one for NULL terminator\r
+        Dev->Name16 = AllocateZeroPool (StrLength * sizeof (CHAR16));\r
         ASSERT (Dev->Name16 != NULL);\r
         StrCpyS (Dev->Name16, StrLength, DevName);\r
-        Dev->NameZ = (CHAR8*)AllocateZeroPool(StrLength);\r
+        Dev->NameZ = (CHAR8 *)AllocateZeroPool (StrLength);\r
         UnicodeStrToAsciiStrS (DevName, Dev->NameZ, StrLength);\r
 \r
         //\r
         // Retrieve bridge BDF info and port number or namespace depending on type\r
         //\r
         TmpDevPath = NULL;\r
-        Status = gBS->OpenProtocol(\r
-            Dev->Handle,\r
-            &gEfiDevicePathProtocolGuid,\r
-            (VOID**)&TmpDevPath,\r
-            gImageHandle,\r
-            NULL,\r
-            EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
-            );\r
-        if (!EFI_ERROR(Status)) {\r
+        Status     = gBS->OpenProtocol (\r
+                            Dev->Handle,\r
+                            &gEfiDevicePathProtocolGuid,\r
+                            (VOID **)&TmpDevPath,\r
+                            gImageHandle,\r
+                            NULL,\r
+                            EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
+                            );\r
+        if (!EFI_ERROR (Status)) {\r
           Dev->OpalDevicePath = DuplicateDevicePath (TmpDevPath);\r
           return TRUE;\r
         }\r
 \r
         if (Dev->Name16 != NULL) {\r
-          FreePool(Dev->Name16);\r
+          FreePool (Dev->Name16);\r
           Dev->Name16 = NULL;\r
         }\r
+\r
         if (Dev->NameZ != NULL) {\r
-          FreePool(Dev->NameZ);\r
+          FreePool (Dev->NameZ);\r
           Dev->NameZ = NULL;\r
         }\r
       }\r
@@ -2529,16 +2574,16 @@ OpalDriverGetDeviceNameByProtocol(
   @retval     FALSE       Not found the name for this device.\r
 **/\r
 BOOLEAN\r
-OpalDriverGetDriverDeviceName(\r
-  OPAL_DRIVER_DEVICE          *Dev\r
+OpalDriverGetDriverDeviceName (\r
+  OPAL_DRIVER_DEVICE  *Dev\r
   )\r
 {\r
-  EFI_HANDLE*                  AllHandlesBuffer;\r
-  UINTN                        NumAllHandles;\r
-  EFI_STATUS                   Status;\r
+  EFI_HANDLE  *AllHandlesBuffer;\r
+  UINTN       NumAllHandles;\r
+  EFI_STATUS  Status;\r
 \r
   if (Dev == NULL) {\r
-    DEBUG((DEBUG_ERROR | DEBUG_INIT, "OpalDriverGetDriverDeviceName Exiting, Dev=NULL\n"));\r
+    DEBUG ((DEBUG_ERROR | DEBUG_INIT, "OpalDriverGetDriverDeviceName Exiting, Dev=NULL\n"));\r
     return FALSE;\r
   }\r
 \r
@@ -2546,29 +2591,29 @@ OpalDriverGetDriverDeviceName(
   // Iterate through ComponentName2 handles to get name, if fails, try ComponentName\r
   //\r
   if (Dev->Name16 == NULL) {\r
-    DEBUG((DEBUG_ERROR | DEBUG_INIT, "Name is null, update it\n"));\r
+    DEBUG ((DEBUG_ERROR | DEBUG_INIT, "Name is null, update it\n"));\r
     //\r
     // Find all EFI_HANDLES\r
     //\r
-    Status = gBS->LocateHandleBuffer(\r
-                 AllHandles,\r
-                 NULL,\r
-                 NULL,\r
-                 &NumAllHandles,\r
-                 &AllHandlesBuffer\r
-                 );\r
-    if (EFI_ERROR(Status)) {\r
-      DEBUG ((DEBUG_INFO, "LocateHandleBuffer for AllHandles failed %r\n", Status ));\r
+    Status = gBS->LocateHandleBuffer (\r
+                    AllHandles,\r
+                    NULL,\r
+                    NULL,\r
+                    &NumAllHandles,\r
+                    &AllHandlesBuffer\r
+                    );\r
+    if (EFI_ERROR (Status)) {\r
+      DEBUG ((DEBUG_INFO, "LocateHandleBuffer for AllHandles failed %r\n", Status));\r
       return FALSE;\r
     }\r
 \r
     //\r
     // Try component Name2\r
     //\r
-    if (!OpalDriverGetDeviceNameByProtocol(AllHandlesBuffer, NumAllHandles, Dev, FALSE)) {\r
-      DEBUG((DEBUG_ERROR | DEBUG_INIT, "ComponentName2 failed to get device name, try ComponentName\n"));\r
-      if (!OpalDriverGetDeviceNameByProtocol(AllHandlesBuffer, NumAllHandles, Dev, TRUE)) {\r
-        DEBUG((DEBUG_ERROR | DEBUG_INIT, "ComponentName failed to get device name, skip device\n"));\r
+    if (!OpalDriverGetDeviceNameByProtocol (AllHandlesBuffer, NumAllHandles, Dev, FALSE)) {\r
+      DEBUG ((DEBUG_ERROR | DEBUG_INIT, "ComponentName2 failed to get device name, try ComponentName\n"));\r
+      if (!OpalDriverGetDeviceNameByProtocol (AllHandlesBuffer, NumAllHandles, Dev, TRUE)) {\r
+        DEBUG ((DEBUG_ERROR | DEBUG_INIT, "ComponentName failed to get device name, skip device\n"));\r
         return FALSE;\r
       }\r
     }\r
@@ -2587,13 +2632,13 @@ OpalDriverGetDriverDeviceName(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-EfiDriverEntryPoint(\r
-  IN EFI_HANDLE         ImageHandle,\r
-  IN EFI_SYSTEM_TABLE*  SystemTable\r
+EfiDriverEntryPoint (\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  EFI_EVENT                      EndOfDxeEvent;\r
+  EFI_STATUS  Status;\r
+  EFI_EVENT   EndOfDxeEvent;\r
 \r
   Status = EfiLibInstallDriverBindingComponentName2 (\r
              ImageHandle,\r
@@ -2604,15 +2649,15 @@ EfiDriverEntryPoint(
              &gOpalComponentName2\r
              );\r
 \r
-  if (EFI_ERROR(Status)) {\r
-    DEBUG((DEBUG_ERROR, "Install protocols to Opal driver Handle failed\n"));\r
-    return Status ;\r
+  if (EFI_ERROR (Status)) {\r
+    DEBUG ((DEBUG_ERROR, "Install protocols to Opal driver Handle failed\n"));\r
+    return Status;\r
   }\r
 \r
   //\r
   // Initialize Driver object\r
   //\r
-  ZeroMem(&mOpalDriver, sizeof(mOpalDriver));\r
+  ZeroMem (&mOpalDriver, sizeof (mOpalDriver));\r
   mOpalDriver.Handle = ImageHandle;\r
 \r
   Status = gBS->CreateEventEx (\r
@@ -2628,7 +2673,7 @@ EfiDriverEntryPoint(
   //\r
   // Install Hii packages.\r
   //\r
-  HiiInstall();\r
+  HiiInstall ();\r
 \r
   return Status;\r
 }\r
@@ -2659,14 +2704,14 @@ EfiDriverEntryPoint(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverBindingSupported(\r
-  IN EFI_DRIVER_BINDING_PROTOCOLThis,\r
+OpalEfiDriverBindingSupported (\r
+  IN EFI_DRIVER_BINDING_PROTOCOL  *This,\r
   IN EFI_HANDLE                   Controller,\r
-  IN EFI_DEVICE_PATH_PROTOCOL*    RemainingDevicePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL     *RemainingDevicePath\r
   )\r
 {\r
-  EFI_STATUS                              Status;\r
-  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL*  SecurityCommand;\r
+  EFI_STATUS                             Status;\r
+  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL  *SecurityCommand;\r
 \r
   if (mOpalEndOfDxe) {\r
     return EFI_UNSUPPORTED;\r
@@ -2675,33 +2720,32 @@ OpalEfiDriverBindingSupported(
   //\r
   // Test EFI_STORAGE_SECURITY_COMMAND_PROTOCOL on controller Handle.\r
   //\r
-  Status = gBS->OpenProtocol(\r
-    Controller,\r
-    &gEfiStorageSecurityCommandProtocolGuid,\r
-    ( VOID ** )&SecurityCommand,\r
-    This->DriverBindingHandle,\r
-    Controller,\r
-    EFI_OPEN_PROTOCOL_BY_DRIVER\r
-    );\r
+  Status = gBS->OpenProtocol (\r
+                  Controller,\r
+                  &gEfiStorageSecurityCommandProtocolGuid,\r
+                  (VOID **)&SecurityCommand,\r
+                  This->DriverBindingHandle,\r
+                  Controller,\r
+                  EFI_OPEN_PROTOCOL_BY_DRIVER\r
+                  );\r
 \r
   if (Status == EFI_ALREADY_STARTED) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
   //\r
   // Close protocol and reopen in Start call\r
   //\r
-  gBS->CloseProtocol(\r
-      Controller,\r
-      &gEfiStorageSecurityCommandProtocolGuid,\r
-      This->DriverBindingHandle,\r
-      Controller\r
-      );\r
-\r
+  gBS->CloseProtocol (\r
+         Controller,\r
+         &gEfiStorageSecurityCommandProtocolGuid,\r
+         This->DriverBindingHandle,\r
+         Controller\r
+         );\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -2739,23 +2783,24 @@ OpalEfiDriverBindingSupported(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverBindingStart(\r
-  IN EFI_DRIVER_BINDING_PROTOCOLThis,\r
+OpalEfiDriverBindingStart (\r
+  IN EFI_DRIVER_BINDING_PROTOCOL  *This,\r
   IN EFI_HANDLE                   Controller,\r
-  IN EFI_DEVICE_PATH_PROTOCOL*    RemainingDevicePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL     *RemainingDevicePath\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  EFI_BLOCK_IO_PROTOCOL       *BlkIo;\r
-  OPAL_DRIVER_DEVICE          *Dev;\r
-  OPAL_DRIVER_DEVICE          *Itr;\r
-  BOOLEAN                     Result;\r
+  EFI_STATUS             Status;\r
+  EFI_BLOCK_IO_PROTOCOL  *BlkIo;\r
+  OPAL_DRIVER_DEVICE     *Dev;\r
+  OPAL_DRIVER_DEVICE     *Itr;\r
+  BOOLEAN                Result;\r
 \r
   Itr = mOpalDriver.DeviceList;\r
   while (Itr != NULL) {\r
     if (Controller == Itr->Handle) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     Itr = Itr->Next;\r
   }\r
 \r
@@ -2763,25 +2808,26 @@ OpalEfiDriverBindingStart(
   // Create internal device for tracking.  This allows all disks to be tracked\r
   // by same HII form\r
   //\r
-  Dev = (OPAL_DRIVER_DEVICE*)AllocateZeroPool(sizeof(OPAL_DRIVER_DEVICE));\r
+  Dev = (OPAL_DRIVER_DEVICE *)AllocateZeroPool (sizeof (OPAL_DRIVER_DEVICE));\r
   if (Dev == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
+\r
   Dev->Handle = Controller;\r
 \r
   //\r
   // Open EFI_STORAGE_SECURITY_COMMAND_PROTOCOL to perform Opal supported checks\r
   //\r
-  Status = gBS->OpenProtocol(\r
-    Controller,\r
-    &gEfiStorageSecurityCommandProtocolGuid,\r
-    (VOID **)&Dev->Sscp,\r
-    This->DriverBindingHandle,\r
-    Controller,\r
-    EFI_OPEN_PROTOCOL_BY_DRIVER\r
-    );\r
-  if (EFI_ERROR(Status)) {\r
-    FreePool(Dev);\r
+  Status = gBS->OpenProtocol (\r
+                  Controller,\r
+                  &gEfiStorageSecurityCommandProtocolGuid,\r
+                  (VOID **)&Dev->Sscp,\r
+                  This->DriverBindingHandle,\r
+                  Controller,\r
+                  EFI_OPEN_PROTOCOL_BY_DRIVER\r
+                  );\r
+  if (EFI_ERROR (Status)) {\r
+    FreePool (Dev);\r
     return Status;\r
   }\r
 \r
@@ -2789,32 +2835,32 @@ OpalEfiDriverBindingStart(
   // Open EFI_BLOCK_IO_PROTOCOL on controller Handle, required by EFI_STORAGE_SECURITY_COMMAND_PROTOCOL\r
   // function APIs\r
   //\r
-  Status = gBS->OpenProtocol(\r
-    Controller,\r
-    &gEfiBlockIoProtocolGuid,\r
-    (VOID **)&BlkIo,\r
-    This->DriverBindingHandle,\r
-    Controller,\r
-    EFI_OPEN_PROTOCOL_BY_DRIVER\r
-    );\r
-  if (EFI_ERROR(Status)) {\r
+  Status = gBS->OpenProtocol (\r
+                  Controller,\r
+                  &gEfiBlockIoProtocolGuid,\r
+                  (VOID **)&BlkIo,\r
+                  This->DriverBindingHandle,\r
+                  Controller,\r
+                  EFI_OPEN_PROTOCOL_BY_DRIVER\r
+                  );\r
+  if (EFI_ERROR (Status)) {\r
     //\r
     // Block_IO not supported on handle\r
     //\r
-    if(Status == EFI_UNSUPPORTED) {\r
+    if (Status == EFI_UNSUPPORTED) {\r
       BlkIo = NULL;\r
     } else {\r
       //\r
       // Close storage security that was opened\r
       //\r
-      gBS->CloseProtocol(\r
-          Controller,\r
-          &gEfiStorageSecurityCommandProtocolGuid,\r
-          This->DriverBindingHandle,\r
-          Controller\r
-          );\r
+      gBS->CloseProtocol (\r
+             Controller,\r
+             &gEfiStorageSecurityCommandProtocolGuid,\r
+             This->DriverBindingHandle,\r
+             Controller\r
+             );\r
 \r
-      FreePool(Dev);\r
+      FreePool (Dev);\r
       return Status;\r
     }\r
   }\r
@@ -2822,18 +2868,18 @@ OpalEfiDriverBindingStart(
   //\r
   // Save mediaId\r
   //\r
-  if(BlkIo == NULL) {\r
+  if (BlkIo == NULL) {\r
     // If no Block IO present, use defined MediaId value.\r
     Dev->MediaId = 0x0;\r
   } else {\r
     Dev->MediaId = BlkIo->Media->MediaId;\r
 \r
-    gBS->CloseProtocol(\r
-      Controller,\r
-      &gEfiBlockIoProtocolGuid,\r
-      This->DriverBindingHandle,\r
-      Controller\r
-    );\r
+    gBS->CloseProtocol (\r
+           Controller,\r
+           &gEfiBlockIoProtocolGuid,\r
+           This->DriverBindingHandle,\r
+           Controller\r
+           );\r
   }\r
 \r
   //\r
@@ -2849,7 +2895,7 @@ OpalEfiDriverBindingStart(
     goto Done;\r
   }\r
 \r
-  AddDeviceToTail(Dev);\r
+  AddDeviceToTail (Dev);\r
 \r
   //\r
   // Check if device is locked and prompt for password.\r
@@ -2867,14 +2913,14 @@ Done:
   //\r
   // free device, close protocols and exit\r
   //\r
-  gBS->CloseProtocol(\r
-      Controller,\r
-      &gEfiStorageSecurityCommandProtocolGuid,\r
-      This->DriverBindingHandle,\r
-      Controller\r
-      );\r
+  gBS->CloseProtocol (\r
+         Controller,\r
+         &gEfiStorageSecurityCommandProtocolGuid,\r
+         This->DriverBindingHandle,\r
+         Controller\r
+         );\r
 \r
-  FreePool(Dev);\r
+  FreePool (Dev);\r
 \r
   return EFI_DEVICE_ERROR;\r
 }\r
@@ -2894,14 +2940,14 @@ Done:
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverBindingStop(\r
-  EFI_DRIVER_BINDING_PROTOCOL*    This,\r
-  EFI_HANDLE                      Controller,\r
-  UINTN                           NumberOfChildren,\r
-  EFI_HANDLE*                     ChildHandleBuffer\r
+OpalEfiDriverBindingStop (\r
+  EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  EFI_HANDLE                   Controller,\r
+  UINTN                        NumberOfChildren,\r
+  EFI_HANDLE                   *ChildHandleBuffer\r
   )\r
 {\r
-  OPAL_DRIVER_DEVICE*   Itr;\r
+  OPAL_DRIVER_DEVICE  *Itr;\r
 \r
   Itr = mOpalDriver.DeviceList;\r
 \r
@@ -2920,7 +2966,6 @@ OpalEfiDriverBindingStop(
   return EFI_NOT_FOUND;\r
 }\r
 \r
-\r
 /**\r
   Unloads UEFI Driver.  Very useful for debugging and testing.\r
 \r
@@ -2932,11 +2977,11 @@ OpalEfiDriverBindingStop(
 EFI_STATUS\r
 EFIAPI\r
 OpalEfiDriverUnload (\r
-  IN EFI_HANDLE ImageHandle\r
+  IN EFI_HANDLE  ImageHandle\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  OPAL_DRIVER_DEVICE                   *Itr;\r
+  EFI_STATUS          Status;\r
+  OPAL_DRIVER_DEVICE  *Itr;\r
 \r
   Status = EFI_SUCCESS;\r
 \r
@@ -2953,14 +2998,13 @@ OpalEfiDriverUnload (
     // Remove OPAL_DRIVER_DEVICE from the list\r
     // it updates the controllerList pointer\r
     //\r
-    OpalDriverStopDevice(Itr);\r
+    OpalDriverStopDevice (Itr);\r
   }\r
 \r
   //\r
   // Uninstall the HII capability\r
   //\r
-  Status = HiiUninstall();\r
+  Status = HiiUninstall ();\r
 \r
   return Status;\r
 }\r
-\r
index c19d78218ec9e83d9de14d2cc8a0bda9376f3b0c..2089bd81b6a82c0d7a000066fc610e64639ff4e9 100644 (file)
@@ -44,37 +44,37 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include "OpalPasswordCommon.h"\r
 #include "OpalHiiFormValues.h"\r
 \r
-#define EFI_DRIVER_NAME_UNICODE L"1.0 UEFI Opal Driver"\r
+#define EFI_DRIVER_NAME_UNICODE  L"1.0 UEFI Opal Driver"\r
 \r
 // UEFI 2.1\r
-#define LANGUAGE_RFC_3066_ENGLISH ((CHAR8*)"en")\r
+#define LANGUAGE_RFC_3066_ENGLISH  ((CHAR8*)"en")\r
 \r
 // UEFI/EFI < 2.1\r
-#define LANGUAGE_ISO_639_2_ENGLISH ((CHAR8*)"eng")\r
+#define LANGUAGE_ISO_639_2_ENGLISH  ((CHAR8*)"eng")\r
 \r
-#define CONCAT_(x, y) x ## y\r
-#define CONCAT(x, y) CONCAT_(x, y)\r
+#define CONCAT_(x, y)  x ## y\r
+#define CONCAT(x, y)   CONCAT_(x, y)\r
 \r
-#define UNICODE_STR(x) CONCAT( L, x )\r
+#define UNICODE_STR(x)  CONCAT( L, x )\r
 \r
 extern EFI_DRIVER_BINDING_PROTOCOL   gOpalDriverBinding;\r
 extern EFI_COMPONENT_NAME_PROTOCOL   gOpalComponentName;\r
 extern EFI_COMPONENT_NAME2_PROTOCOL  gOpalComponentName2;\r
 \r
-#define OPAL_MSID_LENGTH        128\r
+#define OPAL_MSID_LENGTH  128\r
 \r
 #define MAX_PASSWORD_TRY_COUNT  5\r
 \r
 // PSID Length\r
-#define PSID_CHARACTER_LENGTH   0x20\r
-#define MAX_PSID_TRY_COUNT      5\r
+#define PSID_CHARACTER_LENGTH  0x20\r
+#define MAX_PSID_TRY_COUNT     5\r
 \r
 //\r
 // The max timeout value assume the user can wait for the revert action. The unit of this macro is second.\r
 // If the revert time value bigger than this one, driver needs to popup a dialog to let user confirm the\r
 // revert action.\r
 //\r
-#define MAX_ACCEPTABLE_REVERTING_TIME    10\r
+#define MAX_ACCEPTABLE_REVERTING_TIME  10\r
 \r
 #pragma pack(1)\r
 \r
@@ -84,66 +84,66 @@ extern EFI_COMPONENT_NAME2_PROTOCOL  gOpalComponentName2;
 // by the consumer of this library.\r
 //\r
 typedef struct {\r
-    //\r
-    // Indicates if the disk can support PSID Revert action.  should verify disk supports PSID authority\r
-    //\r
-    UINT16 PsidRevert : 1;\r
-\r
-    //\r
-    // Indicates if the disk can support Revert action\r
-    //\r
-    UINT16 Revert : 1;\r
-\r
-    //\r
-    // Indicates if the user must keep data for revert action.  It is true if no media encryption is supported.\r
-    //\r
-    UINT16 RevertKeepDataForced : 1;\r
-\r
-    //\r
-    // Indicates if the disk can support set Admin password\r
-    //\r
-    UINT16 AdminPass : 1;\r
-\r
-    //\r
-    // Indicates if the disk can support set User password.  This action requires that a user\r
-    // password is first enabled.\r
-    //\r
-    UINT16 UserPass : 1;\r
-\r
-    //\r
-    // Indicates if unlock action is available.  Requires disk to be currently locked.\r
-    //\r
-    UINT16 Unlock : 1;\r
-\r
-    //\r
-    // Indicates if Secure Erase action is available.  Action requires admin credentials and media encryption support.\r
-    //\r
-    UINT16 SecureErase : 1;\r
-\r
-    //\r
-    // Indicates if Disable User action is available.  Action requires admin credentials.\r
-    //\r
-    UINT16 DisableUser : 1;\r
+  //\r
+  // Indicates if the disk can support PSID Revert action.  should verify disk supports PSID authority\r
+  //\r
+  UINT16    PsidRevert           : 1;\r
+\r
+  //\r
+  // Indicates if the disk can support Revert action\r
+  //\r
+  UINT16    Revert               : 1;\r
+\r
+  //\r
+  // Indicates if the user must keep data for revert action.  It is true if no media encryption is supported.\r
+  //\r
+  UINT16    RevertKeepDataForced : 1;\r
+\r
+  //\r
+  // Indicates if the disk can support set Admin password\r
+  //\r
+  UINT16    AdminPass            : 1;\r
+\r
+  //\r
+  // Indicates if the disk can support set User password.  This action requires that a user\r
+  // password is first enabled.\r
+  //\r
+  UINT16    UserPass             : 1;\r
+\r
+  //\r
+  // Indicates if unlock action is available.  Requires disk to be currently locked.\r
+  //\r
+  UINT16    Unlock               : 1;\r
+\r
+  //\r
+  // Indicates if Secure Erase action is available.  Action requires admin credentials and media encryption support.\r
+  //\r
+  UINT16    SecureErase          : 1;\r
+\r
+  //\r
+  // Indicates if Disable User action is available.  Action requires admin credentials.\r
+  //\r
+  UINT16    DisableUser          : 1;\r
 } OPAL_DISK_ACTIONS;\r
 \r
 //\r
 // Structure that is used to represent an OPAL_DISK.\r
 //\r
 typedef struct {\r
-  UINT32                                          MsidLength;             // Byte length of MSID Pin for device\r
-  UINT8                                           Msid[OPAL_MSID_LENGTH]; // MSID Pin for device\r
-  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL           *Sscp;\r
-  UINT32                                          MediaId;                // MediaId is used by Ssc Protocol.\r
-  EFI_DEVICE_PATH_PROTOCOL                        *OpalDevicePath;\r
-  UINT16                                          OpalBaseComId;          // Opal SSC 1 base com id.\r
-  OPAL_OWNER_SHIP                                 Owner;\r
-  OPAL_DISK_SUPPORT_ATTRIBUTE                     SupportedAttributes;\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR                  LockingFeature;         // Locking Feature Descriptor retrieved from performing a Level 0 Discovery\r
-  UINT8                                           PasswordLength;\r
-  UINT8                                           Password[OPAL_MAX_PASSWORD_SIZE];\r
-\r
-  UINT32                                          EstimateTimeCost;\r
-  BOOLEAN                                         SentBlockSID;           // Check whether BlockSid command has been sent.\r
+  UINT32                                   MsidLength;                    // Byte length of MSID Pin for device\r
+  UINT8                                    Msid[OPAL_MSID_LENGTH];        // MSID Pin for device\r
+  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL    *Sscp;\r
+  UINT32                                   MediaId;                       // MediaId is used by Ssc Protocol.\r
+  EFI_DEVICE_PATH_PROTOCOL                 *OpalDevicePath;\r
+  UINT16                                   OpalBaseComId;                 // Opal SSC 1 base com id.\r
+  OPAL_OWNER_SHIP                          Owner;\r
+  OPAL_DISK_SUPPORT_ATTRIBUTE              SupportedAttributes;\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR           LockingFeature;                // Locking Feature Descriptor retrieved from performing a Level 0 Discovery\r
+  UINT8                                    PasswordLength;\r
+  UINT8                                    Password[OPAL_MAX_PASSWORD_SIZE];\r
+\r
+  UINT32                                   EstimateTimeCost;\r
+  BOOLEAN                                  SentBlockSID;                  // Check whether BlockSid command has been sent.\r
 } OPAL_DISK;\r
 \r
 //\r
@@ -152,23 +152,23 @@ typedef struct {
 typedef struct _OPAL_DRIVER_DEVICE OPAL_DRIVER_DEVICE;\r
 \r
 struct _OPAL_DRIVER_DEVICE {\r
-  OPAL_DRIVER_DEVICE                              *Next;              ///< Linked list pointer\r
-  EFI_HANDLE                                      Handle;             ///< Device handle\r
-  OPAL_DISK                                       OpalDisk;           ///< User context\r
-  CHAR16                                          *Name16;            ///< Allocated/freed by UEFI Filter Driver at device creation/removal\r
-  CHAR8                                           *NameZ;             ///< Allocated/freed by UEFI Filter Driver at device creation/removal\r
-  UINT32                                          MediaId;            ///< Required parameter for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL, from BLOCK_IO_MEDIA\r
-\r
-  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL           *Sscp;              /// Device protocols consumed\r
-  EFI_DEVICE_PATH_PROTOCOL                        *OpalDevicePath;\r
+  OPAL_DRIVER_DEVICE                       *Next;                     ///< Linked list pointer\r
+  EFI_HANDLE                               Handle;                    ///< Device handle\r
+  OPAL_DISK                                OpalDisk;                  ///< User context\r
+  CHAR16                                   *Name16;                   ///< Allocated/freed by UEFI Filter Driver at device creation/removal\r
+  CHAR8                                    *NameZ;                    ///< Allocated/freed by UEFI Filter Driver at device creation/removal\r
+  UINT32                                   MediaId;                   ///< Required parameter for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL, from BLOCK_IO_MEDIA\r
+\r
+  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL    *Sscp;                     /// Device protocols consumed\r
+  EFI_DEVICE_PATH_PROTOCOL                 *OpalDevicePath;\r
 };\r
 \r
 //\r
 // Opal Driver UEFI Driver Model\r
 //\r
 typedef struct {\r
-  EFI_HANDLE           Handle;              ///< Driver image handle\r
-  OPAL_DRIVER_DEVICE   *DeviceList;         ///< Linked list of controllers owned by this Driver\r
+  EFI_HANDLE            Handle;             ///< Driver image handle\r
+  OPAL_DRIVER_DEVICE    *DeviceList;        ///< Linked list of controllers owned by this Driver\r
 } OPAL_DRIVER;\r
 \r
 #pragma pack()\r
@@ -176,15 +176,15 @@ typedef struct {
 //\r
 // Retrieves a OPAL_DRIVER_DEVICE based on the pointer to its StorageSecurity protocol.\r
 //\r
-#define DRIVER_DEVICE_FROM_OPALDISK(OpalDiskPointer) (OPAL_DRIVER_DEVICE*)(BASE_CR(OpalDiskPointer, OPAL_DRIVER_DEVICE, OpalDisk))\r
+#define DRIVER_DEVICE_FROM_OPALDISK(OpalDiskPointer)  (OPAL_DRIVER_DEVICE*)(BASE_CR(OpalDiskPointer, OPAL_DRIVER_DEVICE, OpalDisk))\r
 \r
 /**\r
   Get devcie list info.\r
 \r
   @retval     return the device list pointer.\r
 **/\r
-OPAL_DRIVER_DEVICE*\r
-OpalDriverGetDeviceList(\r
+OPAL_DRIVER_DEVICE *\r
+OpalDriverGetDeviceList (\r
   VOID\r
   );\r
 \r
@@ -197,8 +197,8 @@ OpalDriverGetDeviceList(
   @retval     FALSE       Not found the name for this device.\r
 **/\r
 BOOLEAN\r
-OpalDriverGetDriverDeviceName(\r
-  OPAL_DRIVER_DEVICE          *Dev\r
+OpalDriverGetDriverDeviceName (\r
+  OPAL_DRIVER_DEVICE  *Dev\r
   );\r
 \r
 /**\r
@@ -222,9 +222,9 @@ GetDeviceCount (
 **/\r
 VOID\r
 OpalSupportUpdatePassword (\r
-  IN OUT OPAL_DISK      *OpalDisk,\r
-  IN VOID               *Password,\r
-  IN UINT32             PasswordLength\r
+  IN OUT OPAL_DISK  *OpalDisk,\r
+  IN VOID           *Password,\r
+  IN UINT32         PasswordLength\r
   );\r
 \r
 /**\r
@@ -239,11 +239,11 @@ OpalSupportUpdatePassword (
 **/\r
 TCG_RESULT\r
 EFIAPI\r
-OpalSupportGetAvailableActions(\r
-  IN  OPAL_DISK_SUPPORT_ATTRIBUTE      *SupportedAttributes,\r
-  IN  TCG_LOCKING_FEATURE_DESCRIPTOR   *LockingFeature,\r
-  IN  UINT16                           OwnerShip,\r
-  OUT OPAL_DISK_ACTIONS                *AvalDiskActions\r
+OpalSupportGetAvailableActions (\r
+  IN  OPAL_DISK_SUPPORT_ATTRIBUTE     *SupportedAttributes,\r
+  IN  TCG_LOCKING_FEATURE_DESCRIPTOR  *LockingFeature,\r
+  IN  UINT16                          OwnerShip,\r
+  OUT OPAL_DISK_ACTIONS               *AvalDiskActions\r
   );\r
 \r
 /**\r
@@ -259,11 +259,11 @@ OpalSupportGetAvailableActions(
 TCG_RESULT\r
 EFIAPI\r
 OpalSupportEnableOpalFeature (\r
-  IN OPAL_SESSION              *Session,\r
-  IN VOID                      *Msid,\r
-  IN UINT32                    MsidLength,\r
-  IN VOID                      *Password,\r
-  IN UINT32                    PassLength\r
+  IN OPAL_SESSION  *Session,\r
+  IN VOID          *Msid,\r
+  IN UINT32        MsidLength,\r
+  IN VOID          *Password,\r
+  IN UINT32        PassLength\r
   );\r
 \r
 /**\r
@@ -276,11 +276,10 @@ OpalSupportEnableOpalFeature (
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-EfiDriverUnload(\r
-  EFI_HANDLE ImageHandle\r
+EfiDriverUnload (\r
+  EFI_HANDLE  ImageHandle\r
   );\r
 \r
-\r
 /**\r
   Test to see if this driver supports Controller.\r
 \r
@@ -296,10 +295,10 @@ EfiDriverUnload(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverBindingSupported(\r
-  EFI_DRIVER_BINDING_PROTOCOL*    This,\r
-  EFI_HANDLE                      Controller,\r
-  EFI_DEVICE_PATH_PROTOCOL*       RemainingDevicePath\r
+OpalEfiDriverBindingSupported (\r
+  EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  EFI_HANDLE                   Controller,\r
+  EFI_DEVICE_PATH_PROTOCOL     *RemainingDevicePath\r
   );\r
 \r
 /**\r
@@ -335,10 +334,10 @@ OpalEfiDriverBindingSupported(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverBindingStart(\r
-  EFI_DRIVER_BINDING_PROTOCOL*    This,\r
-  EFI_HANDLE                      Controller,\r
-  EFI_DEVICE_PATH_PROTOCOL*       RemainingDevicePath\r
+OpalEfiDriverBindingStart (\r
+  EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  EFI_HANDLE                   Controller,\r
+  EFI_DEVICE_PATH_PROTOCOL     *RemainingDevicePath\r
   );\r
 \r
 /**\r
@@ -356,11 +355,11 @@ OpalEfiDriverBindingStart(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverBindingStop(\r
-  EFI_DRIVER_BINDING_PROTOCOL*    This,\r
-  EFI_HANDLE                      Controller,\r
-  UINTN                           NumberOfChildren,\r
-  EFI_HANDLE*                     ChildHandleBuffer\r
+OpalEfiDriverBindingStop (\r
+  EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  EFI_HANDLE                   Controller,\r
+  UINTN                        NumberOfChildren,\r
+  EFI_HANDLE                   *ChildHandleBuffer\r
   );\r
 \r
 /**\r
@@ -404,10 +403,10 @@ OpalEfiDriverBindingStop(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverComponentNameGetDriverName(\r
-  EFI_COMPONENT_NAME_PROTOCOL*    This,\r
-  CHAR8*                          Language,\r
-  CHAR16**                        DriverName\r
+OpalEfiDriverComponentNameGetDriverName (\r
+  EFI_COMPONENT_NAME_PROTOCOL  *This,\r
+  CHAR8                        *Language,\r
+  CHAR16                       **DriverName\r
   );\r
 \r
 /**\r
@@ -480,12 +479,12 @@ OpalEfiDriverComponentNameGetDriverName(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverComponentNameGetControllerName(\r
-  EFI_COMPONENT_NAME_PROTOCOL*    This,\r
-  EFI_HANDLE                      ControllerHandle,\r
-  EFI_HANDLE                      ChildHandle,\r
-  CHAR8*                          Language,\r
-  CHAR16**                        ControllerName\r
+OpalEfiDriverComponentNameGetControllerName (\r
+  EFI_COMPONENT_NAME_PROTOCOL  *This,\r
+  EFI_HANDLE                   ControllerHandle,\r
+  EFI_HANDLE                   ChildHandle,\r
+  CHAR8                        *Language,\r
+  CHAR16                       **ControllerName\r
   );\r
 \r
 /**\r
@@ -529,10 +528,10 @@ OpalEfiDriverComponentNameGetControllerName(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverComponentName2GetDriverName(\r
-  EFI_COMPONENT_NAME2_PROTOCOL*   This,\r
-  CHAR8*                          Language,\r
-  CHAR16**                        DriverName\r
+OpalEfiDriverComponentName2GetDriverName (\r
+  EFI_COMPONENT_NAME2_PROTOCOL  *This,\r
+  CHAR8                         *Language,\r
+  CHAR16                        **DriverName\r
   );\r
 \r
 /**\r
@@ -605,12 +604,12 @@ OpalEfiDriverComponentName2GetDriverName(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-OpalEfiDriverComponentName2GetControllerName(\r
-  EFI_COMPONENT_NAME2_PROTOCOL*   This,\r
-  EFI_HANDLE                      ControllerHandle,\r
-  EFI_HANDLE                      ChildHandle,\r
-  CHAR8*                          Language,\r
-  CHAR16**                        ControllerName\r
+OpalEfiDriverComponentName2GetControllerName (\r
+  EFI_COMPONENT_NAME2_PROTOCOL  *This,\r
+  EFI_HANDLE                    ControllerHandle,\r
+  EFI_HANDLE                    ChildHandle,\r
+  CHAR8                         *Language,\r
+  CHAR16                        **ControllerName\r
   );\r
 \r
 #endif //_OPAL_DRIVER_H_\r
index 0ab71a3665c76a28aa1c35d915c8e5dd16bee2c4..c4f96bee8a3e14773b49947821092001b01ee990 100644 (file)
@@ -10,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Character definitions\r
 //\r
-#define UPPER_LOWER_CASE_OFFSET 0x20\r
+#define UPPER_LOWER_CASE_OFFSET  0x20\r
 \r
 //\r
 // This is the generated IFR binary Data for each formset defined in VFR.\r
@@ -28,49 +28,49 @@ extern UINT8  OpalPasswordDxeStrings[];
 \r
 CHAR16  OpalPasswordStorageName[] = L"OpalHiiConfig";\r
 \r
-EFI_HII_CONFIG_ACCESS_PROTOCOL gHiiConfigAccessProtocol;\r
+EFI_HII_CONFIG_ACCESS_PROTOCOL  gHiiConfigAccessProtocol;\r
 \r
 //\r
 // Handle to the list of HII packages (forms and strings) for this driver\r
 //\r
-EFI_HII_HANDLE gHiiPackageListHandle = NULL;\r
+EFI_HII_HANDLE  gHiiPackageListHandle = NULL;\r
 \r
 //\r
 // Package List GUID containing all form and string packages\r
 //\r
-const EFI_GUID gHiiPackageListGuid = PACKAGE_LIST_GUID;\r
-const EFI_GUID gHiiSetupVariableGuid = SETUP_VARIABLE_GUID;\r
+const EFI_GUID  gHiiPackageListGuid   = PACKAGE_LIST_GUID;\r
+const EFI_GUID  gHiiSetupVariableGuid = SETUP_VARIABLE_GUID;\r
 \r
 //\r
 // Structure that contains state of the HII\r
 // This structure is updated by Hii.cpp and its contents\r
 // is rendered in the HII.\r
 //\r
-OPAL_HII_CONFIGURATION gHiiConfiguration;\r
+OPAL_HII_CONFIGURATION  gHiiConfiguration;\r
 \r
 //\r
 // The device path containing the VENDOR_DEVICE_PATH and EFI_DEVICE_PATH_PROTOCOL\r
 //\r
-HII_VENDOR_DEVICE_PATH gHiiVendorDevicePath = {\r
+HII_VENDOR_DEVICE_PATH  gHiiVendorDevicePath = {\r
+  {\r
     {\r
-        {\r
-            HARDWARE_DEVICE_PATH,\r
-            HW_VENDOR_DP,\r
-            {\r
-                (UINT8)(sizeof(VENDOR_DEVICE_PATH)),\r
-                (UINT8)((sizeof(VENDOR_DEVICE_PATH)) >> 8)\r
-            }\r
-        },\r
-        OPAL_PASSWORD_CONFIG_GUID\r
+      HARDWARE_DEVICE_PATH,\r
+      HW_VENDOR_DP,\r
+      {\r
+        (UINT8)(sizeof (VENDOR_DEVICE_PATH)),\r
+        (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
+      }\r
     },\r
+    OPAL_PASSWORD_CONFIG_GUID\r
+  },\r
+  {\r
+    END_DEVICE_PATH_TYPE,\r
+    END_ENTIRE_DEVICE_PATH_SUBTYPE,\r
     {\r
-        END_DEVICE_PATH_TYPE,\r
-        END_ENTIRE_DEVICE_PATH_SUBTYPE,\r
-        {\r
-            (UINT8)(END_DEVICE_PATH_LENGTH),\r
-            (UINT8)((END_DEVICE_PATH_LENGTH) >> 8)\r
-        }\r
+      (UINT8)(END_DEVICE_PATH_LENGTH),\r
+      (UINT8)((END_DEVICE_PATH_LENGTH) >> 8)\r
     }\r
+  }\r
 };\r
 \r
 /**\r
@@ -82,8 +82,8 @@ HII_VENDOR_DEVICE_PATH gHiiVendorDevicePath = {
 **/\r
 VOID\r
 GetSavedOpalRequest (\r
-  IN OPAL_DISK              *OpalDisk,\r
-  OUT OPAL_REQUEST          *OpalRequest\r
+  IN OPAL_DISK      *OpalDisk,\r
+  OUT OPAL_REQUEST  *OpalRequest\r
   )\r
 {\r
   EFI_STATUS                Status;\r
@@ -97,13 +97,13 @@ GetSavedOpalRequest (
 \r
   DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__));\r
 \r
-  Variable = NULL;\r
+  Variable     = NULL;\r
   VariableSize = 0;\r
 \r
   Status = GetVariable2 (\r
              OPAL_REQUEST_VARIABLE_NAME,\r
              &gHiiSetupVariableGuid,\r
-             (VOID **) &Variable,\r
+             (VOID **)&Variable,\r
              &VariableSize\r
              );\r
   if (EFI_ERROR (Status) || (Variable == NULL)) {\r
@@ -113,13 +113,15 @@ GetSavedOpalRequest (
   TempVariable = Variable;\r
   while ((VariableSize > sizeof (OPAL_REQUEST_VARIABLE)) &&\r
          (VariableSize >= TempVariable->Length) &&\r
-         (TempVariable->Length > sizeof (OPAL_REQUEST_VARIABLE))) {\r
-    DevicePathInVariable = (EFI_DEVICE_PATH_PROTOCOL *) ((UINTN) TempVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
+         (TempVariable->Length > sizeof (OPAL_REQUEST_VARIABLE)))\r
+  {\r
+    DevicePathInVariable     = (EFI_DEVICE_PATH_PROTOCOL *)((UINTN)TempVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
     DevicePathSizeInVariable = GetDevicePathSize (DevicePathInVariable);\r
-    DevicePath = OpalDisk->OpalDevicePath;\r
-    DevicePathSize = GetDevicePathSize (DevicePath);\r
+    DevicePath               = OpalDisk->OpalDevicePath;\r
+    DevicePathSize           = GetDevicePathSize (DevicePath);\r
     if ((DevicePathSize == DevicePathSizeInVariable) &&\r
-        (CompareMem (DevicePath, DevicePathInVariable, DevicePathSize) == 0)) {\r
+        (CompareMem (DevicePath, DevicePathInVariable, DevicePathSize) == 0))\r
+    {\r
       //\r
       // Found the node for the OPAL device.\r
       // Get the OPAL request.\r
@@ -132,8 +134,9 @@ GetSavedOpalRequest (
         ));\r
       break;\r
     }\r
+\r
     VariableSize -= TempVariable->Length;\r
-    TempVariable = (OPAL_REQUEST_VARIABLE *) ((UINTN) TempVariable + TempVariable->Length);\r
+    TempVariable  = (OPAL_REQUEST_VARIABLE *)((UINTN)TempVariable + TempVariable->Length);\r
   }\r
 \r
   FreePool (Variable);\r
@@ -150,8 +153,8 @@ GetSavedOpalRequest (
 **/\r
 VOID\r
 SaveOpalRequest (\r
-  IN OPAL_DISK              *OpalDisk,\r
-  IN OPAL_REQUEST           OpalRequest\r
+  IN OPAL_DISK     *OpalDisk,\r
+  IN OPAL_REQUEST  OpalRequest\r
   )\r
 {\r
   EFI_STATUS                Status;\r
@@ -174,72 +177,77 @@ SaveOpalRequest (
     OpalRequest\r
     ));\r
 \r
-  Variable = NULL;\r
-  VariableSize = 0;\r
-  NewVariable = NULL;\r
+  Variable        = NULL;\r
+  VariableSize    = 0;\r
+  NewVariable     = NULL;\r
   NewVariableSize = 0;\r
 \r
   Status = GetVariable2 (\r
              OPAL_REQUEST_VARIABLE_NAME,\r
              &gHiiSetupVariableGuid,\r
-             (VOID **) &Variable,\r
+             (VOID **)&Variable,\r
              &VariableSize\r
              );\r
   if (!EFI_ERROR (Status) && (Variable != NULL)) {\r
-    TempVariable = Variable;\r
+    TempVariable     = Variable;\r
     TempVariableSize = VariableSize;\r
     while ((TempVariableSize > sizeof (OPAL_REQUEST_VARIABLE)) &&\r
            (TempVariableSize >= TempVariable->Length) &&\r
-           (TempVariable->Length > sizeof (OPAL_REQUEST_VARIABLE))) {\r
-      DevicePathInVariable = (EFI_DEVICE_PATH_PROTOCOL *) ((UINTN) TempVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
+           (TempVariable->Length > sizeof (OPAL_REQUEST_VARIABLE)))\r
+    {\r
+      DevicePathInVariable     = (EFI_DEVICE_PATH_PROTOCOL *)((UINTN)TempVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
       DevicePathSizeInVariable = GetDevicePathSize (DevicePathInVariable);\r
-      DevicePath = OpalDisk->OpalDevicePath;\r
-      DevicePathSize = GetDevicePathSize (DevicePath);\r
+      DevicePath               = OpalDisk->OpalDevicePath;\r
+      DevicePathSize           = GetDevicePathSize (DevicePath);\r
       if ((DevicePathSize == DevicePathSizeInVariable) &&\r
-          (CompareMem (DevicePath, DevicePathInVariable, DevicePathSize) == 0)) {\r
+          (CompareMem (DevicePath, DevicePathInVariable, DevicePathSize) == 0))\r
+      {\r
         //\r
         // Found the node for the OPAL device.\r
         // Update the OPAL request.\r
         //\r
         CopyMem (&TempVariable->OpalRequest, &OpalRequest, sizeof (OPAL_REQUEST));\r
-        NewVariable = Variable;\r
+        NewVariable     = Variable;\r
         NewVariableSize = VariableSize;\r
         break;\r
       }\r
+\r
       TempVariableSize -= TempVariable->Length;\r
-      TempVariable = (OPAL_REQUEST_VARIABLE *) ((UINTN) TempVariable + TempVariable->Length);\r
+      TempVariable      = (OPAL_REQUEST_VARIABLE *)((UINTN)TempVariable + TempVariable->Length);\r
     }\r
+\r
     if (NewVariable == NULL) {\r
       //\r
       // The node for the OPAL device is not found.\r
       // Create node for the OPAL device.\r
       //\r
-      DevicePath = OpalDisk->OpalDevicePath;\r
-      DevicePathSize = GetDevicePathSize (DevicePath);\r
+      DevicePath      = OpalDisk->OpalDevicePath;\r
+      DevicePathSize  = GetDevicePathSize (DevicePath);\r
       NewVariableSize = VariableSize + sizeof (OPAL_REQUEST_VARIABLE) + DevicePathSize;\r
-      NewVariable = AllocatePool (NewVariableSize);\r
+      NewVariable     = AllocatePool (NewVariableSize);\r
       ASSERT (NewVariable != NULL);\r
       CopyMem (NewVariable, Variable, VariableSize);\r
-      TempVariable = (OPAL_REQUEST_VARIABLE *) ((UINTN) NewVariable + VariableSize);\r
-      TempVariable->Length = (UINT32) (sizeof (OPAL_REQUEST_VARIABLE) + DevicePathSize);\r
+      TempVariable         = (OPAL_REQUEST_VARIABLE *)((UINTN)NewVariable + VariableSize);\r
+      TempVariable->Length = (UINT32)(sizeof (OPAL_REQUEST_VARIABLE) + DevicePathSize);\r
       CopyMem (&TempVariable->OpalRequest, &OpalRequest, sizeof (OPAL_REQUEST));\r
-      DevicePathInVariable = (EFI_DEVICE_PATH_PROTOCOL *) ((UINTN) TempVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
+      DevicePathInVariable = (EFI_DEVICE_PATH_PROTOCOL *)((UINTN)TempVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
       CopyMem (DevicePathInVariable, DevicePath, DevicePathSize);\r
     }\r
   } else {\r
-    DevicePath = OpalDisk->OpalDevicePath;\r
-    DevicePathSize = GetDevicePathSize (DevicePath);\r
+    DevicePath      = OpalDisk->OpalDevicePath;\r
+    DevicePathSize  = GetDevicePathSize (DevicePath);\r
     NewVariableSize = sizeof (OPAL_REQUEST_VARIABLE) + DevicePathSize;\r
-    NewVariable = AllocatePool (NewVariableSize);\r
+    NewVariable     = AllocatePool (NewVariableSize);\r
     ASSERT (NewVariable != NULL);\r
-    NewVariable->Length = (UINT32) (sizeof (OPAL_REQUEST_VARIABLE) + DevicePathSize);\r
+    NewVariable->Length = (UINT32)(sizeof (OPAL_REQUEST_VARIABLE) + DevicePathSize);\r
     CopyMem (&NewVariable->OpalRequest, &OpalRequest, sizeof (OPAL_REQUEST));\r
-    DevicePathInVariable = (EFI_DEVICE_PATH_PROTOCOL *) ((UINTN) NewVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
+    DevicePathInVariable = (EFI_DEVICE_PATH_PROTOCOL *)((UINTN)NewVariable + sizeof (OPAL_REQUEST_VARIABLE));\r
     CopyMem (DevicePathInVariable, DevicePath, DevicePathSize);\r
   }\r
+\r
   Status = gRT->SetVariable (\r
                   OPAL_REQUEST_VARIABLE_NAME,\r
-                  (EFI_GUID *) &gHiiSetupVariableGuid,\r
+                  (EFI_GUID *)&gHiiSetupVariableGuid,\r
                   EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,\r
                   NewVariableSize,\r
                   NewVariable\r
@@ -247,9 +255,11 @@ SaveOpalRequest (
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_INFO, "OpalRequest variable set failed (%r)\n", Status));\r
   }\r
+\r
   if (NewVariable != Variable) {\r
     FreePool (NewVariable);\r
   }\r
+\r
   if (Variable != NULL) {\r
     FreePool (Variable);\r
   }\r
@@ -262,14 +272,14 @@ SaveOpalRequest (
 \r
 **/\r
 VOID\r
-HiiSetCurrentConfiguration(\r
+HiiSetCurrentConfiguration (\r
   VOID\r
   )\r
 {\r
-  UINT32                                       PpStorageFlag;\r
-  EFI_STRING                                   NewString;\r
+  UINT32      PpStorageFlag;\r
+  EFI_STRING  NewString;\r
 \r
-  gHiiConfiguration.NumDisks = GetDeviceCount();\r
+  gHiiConfiguration.NumDisks = GetDeviceCount ();\r
 \r
   //\r
   // Update the BlockSID status string.\r
@@ -277,51 +287,54 @@ HiiSetCurrentConfiguration(
   PpStorageFlag = Tcg2PhysicalPresenceLibGetManagementFlags ();\r
 \r
   if ((PpStorageFlag & TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID) != 0) {\r
-    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN(STR_ENABLED), NULL);\r
+    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN (STR_ENABLED), NULL);\r
     if (NewString == NULL) {\r
-      DEBUG ((DEBUG_INFO,  "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
+      DEBUG ((DEBUG_INFO, "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
       return;\r
     }\r
   } else {\r
-    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN(STR_DISABLED), NULL);\r
+    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN (STR_DISABLED), NULL);\r
     if (NewString == NULL) {\r
-      DEBUG ((DEBUG_INFO,  "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
+      DEBUG ((DEBUG_INFO, "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
       return;\r
     }\r
   }\r
-  HiiSetString(gHiiPackageListHandle, STRING_TOKEN(STR_BLOCKSID_STATUS1), NewString, NULL);\r
+\r
+  HiiSetString (gHiiPackageListHandle, STRING_TOKEN (STR_BLOCKSID_STATUS1), NewString, NULL);\r
   FreePool (NewString);\r
 \r
   if ((PpStorageFlag & TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE_BLOCK_SID) != 0) {\r
-    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN(STR_DISK_INFO_ENABLE_BLOCKSID_TRUE), NULL);\r
+    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN (STR_DISK_INFO_ENABLE_BLOCKSID_TRUE), NULL);\r
     if (NewString == NULL) {\r
-      DEBUG ((DEBUG_INFO,  "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
+      DEBUG ((DEBUG_INFO, "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
       return;\r
     }\r
   } else {\r
-    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN(STR_DISK_INFO_ENABLE_BLOCKSID_FALSE), NULL);\r
+    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN (STR_DISK_INFO_ENABLE_BLOCKSID_FALSE), NULL);\r
     if (NewString == NULL) {\r
-      DEBUG ((DEBUG_INFO,  "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
+      DEBUG ((DEBUG_INFO, "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
       return;\r
     }\r
   }\r
-  HiiSetString(gHiiPackageListHandle, STRING_TOKEN(STR_BLOCKSID_STATUS2), NewString, NULL);\r
+\r
+  HiiSetString (gHiiPackageListHandle, STRING_TOKEN (STR_BLOCKSID_STATUS2), NewString, NULL);\r
   FreePool (NewString);\r
 \r
   if ((PpStorageFlag & TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BLOCK_SID) != 0) {\r
-    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN(STR_DISK_INFO_DISABLE_BLOCKSID_TRUE), NULL);\r
+    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN (STR_DISK_INFO_DISABLE_BLOCKSID_TRUE), NULL);\r
     if (NewString == NULL) {\r
-      DEBUG ((DEBUG_INFO,  "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
+      DEBUG ((DEBUG_INFO, "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
       return;\r
     }\r
   } else {\r
-    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN(STR_DISK_INFO_DISABLE_BLOCKSID_FALSE), NULL);\r
+    NewString = HiiGetString (gHiiPackageListHandle, STRING_TOKEN (STR_DISK_INFO_DISABLE_BLOCKSID_FALSE), NULL);\r
     if (NewString == NULL) {\r
-      DEBUG ((DEBUG_INFO,  "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
+      DEBUG ((DEBUG_INFO, "HiiSetCurrentConfiguration: HiiGetString( ) failed\n"));\r
       return;\r
     }\r
   }\r
-  HiiSetString(gHiiPackageListHandle, STRING_TOKEN(STR_BLOCKSID_STATUS3), NewString, NULL);\r
+\r
+  HiiSetString (gHiiPackageListHandle, STRING_TOKEN (STR_BLOCKSID_STATUS3), NewString, NULL);\r
   FreePool (NewString);\r
 }\r
 \r
@@ -332,47 +345,47 @@ HiiSetCurrentConfiguration(
   @retval  other              Error occur when install the resources.\r
 **/\r
 EFI_STATUS\r
-HiiInstall(\r
+HiiInstall (\r
   VOID\r
   )\r
 {\r
-  EFI_STATUS                   Status;\r
-  EFI_HANDLE                   DriverHandle;\r
+  EFI_STATUS  Status;\r
+  EFI_HANDLE  DriverHandle;\r
 \r
   //\r
   // Clear the global configuration.\r
   //\r
-  ZeroMem(&gHiiConfiguration, sizeof(gHiiConfiguration));\r
+  ZeroMem (&gHiiConfiguration, sizeof (gHiiConfiguration));\r
 \r
   //\r
   // Obtain the driver handle that the BIOS assigned us\r
   //\r
-  DriverHandle = HiiGetDriverImageHandleCB();\r
+  DriverHandle = HiiGetDriverImageHandleCB ();\r
 \r
   //\r
   // Populate the config access protocol with the three functions we are publishing\r
   //\r
   gHiiConfigAccessProtocol.ExtractConfig = ExtractConfig;\r
-  gHiiConfigAccessProtocol.RouteConfig = RouteConfig;\r
-  gHiiConfigAccessProtocol.Callback = DriverCallback;\r
+  gHiiConfigAccessProtocol.RouteConfig   = RouteConfig;\r
+  gHiiConfigAccessProtocol.Callback      = DriverCallback;\r
 \r
   //\r
   // Associate the required protocols with our driver handle\r
   //\r
-  Status = gBS->InstallMultipleProtocolInterfaces(\r
-               &DriverHandle,\r
-               &gEfiHiiConfigAccessProtocolGuid,\r
-               &gHiiConfigAccessProtocol,      // HII callback\r
-               &gEfiDevicePathProtocolGuid,\r
-               &gHiiVendorDevicePath,        // required for HII callback allow all disks to be shown in same hii\r
-               NULL\r
-           );\r
+  Status = gBS->InstallMultipleProtocolInterfaces (\r
+                  &DriverHandle,\r
+                  &gEfiHiiConfigAccessProtocolGuid,\r
+                  &gHiiConfigAccessProtocol,   // HII callback\r
+                  &gEfiDevicePathProtocolGuid,\r
+                  &gHiiVendorDevicePath,     // required for HII callback allow all disks to be shown in same hii\r
+                  NULL\r
+                  );\r
 \r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  return OpalHiiAddPackages();\r
+  return OpalHiiAddPackages ();\r
 }\r
 \r
 /**\r
@@ -382,24 +395,24 @@ HiiInstall(
   @retval  EFI_OUT_OF_RESOURCES  Out of resource error.\r
 **/\r
 EFI_STATUS\r
-OpalHiiAddPackages(\r
+OpalHiiAddPackages (\r
   VOID\r
   )\r
 {\r
-  EFI_HANDLE                   DriverHandle;\r
+  EFI_HANDLE  DriverHandle;\r
 \r
-  DriverHandle = HiiGetDriverImageHandleCB();\r
+  DriverHandle = HiiGetDriverImageHandleCB ();\r
 \r
   //\r
   // Publish the HII form and HII string packages\r
   //\r
-  gHiiPackageListHandle = HiiAddPackages(\r
-                                &gHiiPackageListGuid,\r
-                                DriverHandle,\r
-                                OpalPasswordDxeStrings,\r
-                                OpalPasswordFormBin,\r
-                                (VOID*)NULL\r
-                                );\r
+  gHiiPackageListHandle = HiiAddPackages (\r
+                            &gHiiPackageListGuid,\r
+                            DriverHandle,\r
+                            OpalPasswordDxeStrings,\r
+                            OpalPasswordFormBin,\r
+                            (VOID *)NULL\r
+                            );\r
 \r
   //\r
   // Make sure the packages installed successfully\r
@@ -419,29 +432,29 @@ OpalHiiAddPackages(
   @retval  others                Other errors occur when unistall the hii resource.\r
 **/\r
 EFI_STATUS\r
-HiiUninstall(\r
+HiiUninstall (\r
   VOID\r
   )\r
 {\r
-  EFI_STATUS                   Status;\r
+  EFI_STATUS  Status;\r
 \r
   //\r
   // Remove the packages we've provided to the BIOS\r
   //\r
-  HiiRemovePackages(gHiiPackageListHandle);\r
+  HiiRemovePackages (gHiiPackageListHandle);\r
 \r
   //\r
   // Remove the protocols from our driver handle\r
   //\r
-  Status = gBS->UninstallMultipleProtocolInterfaces(\r
-                          HiiGetDriverImageHandleCB(),\r
-                          &gEfiHiiConfigAccessProtocolGuid,\r
-                          &gHiiConfigAccessProtocol,        // HII callback\r
-                          &gEfiDevicePathProtocolGuid,\r
-                          &gHiiVendorDevicePath,            // required for HII callback\r
-                          NULL\r
-                      );\r
-  if (EFI_ERROR(Status)) {\r
+  Status = gBS->UninstallMultipleProtocolInterfaces (\r
+                  HiiGetDriverImageHandleCB (),\r
+                  &gEfiHiiConfigAccessProtocolGuid,\r
+                  &gHiiConfigAccessProtocol,                // HII callback\r
+                  &gEfiDevicePathProtocolGuid,\r
+                  &gHiiVendorDevicePath,                    // required for HII callback\r
+                  NULL\r
+                  );\r
+  if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_INFO, "Cannot uninstall Hii Protocols: %r\n", Status));\r
   }\r
 \r
@@ -458,12 +471,12 @@ HiiPopulateMainMenuForm (
   VOID\r
   )\r
 {\r
-  UINT8         Index;\r
-  CHAR8         *DiskName;\r
-  EFI_STRING_ID DiskNameId;\r
-  OPAL_DISK     *OpalDisk;\r
+  UINT8          Index;\r
+  CHAR8          *DiskName;\r
+  EFI_STRING_ID  DiskNameId;\r
+  OPAL_DISK      *OpalDisk;\r
 \r
-  HiiSetCurrentConfiguration();\r
+  HiiSetCurrentConfiguration ();\r
 \r
   gHiiConfiguration.SupportedDisks = 0;\r
 \r
@@ -471,12 +484,13 @@ HiiPopulateMainMenuForm (
     OpalDisk = HiiGetOpalDiskCB (Index);\r
     if ((OpalDisk != NULL) && OpalFeatureSupported (&OpalDisk->SupportedAttributes)) {\r
       gHiiConfiguration.SupportedDisks |= (1 << Index);\r
-      DiskNameId = GetDiskNameStringId (Index);\r
-      DiskName = HiiDiskGetNameCB (Index);\r
+      DiskNameId                        = GetDiskNameStringId (Index);\r
+      DiskName                          = HiiDiskGetNameCB (Index);\r
       if ((DiskName == NULL) || (DiskNameId == 0)) {\r
         return EFI_UNSUPPORTED;\r
       }\r
-      HiiSetFormString(DiskNameId, DiskName);\r
+\r
+      HiiSetFormString (DiskNameId, DiskName);\r
     }\r
   }\r
 \r
@@ -493,18 +507,19 @@ HiiPopulateMainMenuForm (
 \r
 **/\r
 EFI_STRING_ID\r
-GetDiskNameStringId(\r
-  UINT8 DiskIndex\r
+GetDiskNameStringId (\r
+  UINT8  DiskIndex\r
   )\r
 {\r
   switch (DiskIndex) {\r
-    case 0: return STRING_TOKEN(STR_MAIN_GOTO_DISK_INFO_0);\r
-    case 1: return STRING_TOKEN(STR_MAIN_GOTO_DISK_INFO_1);\r
-    case 2: return STRING_TOKEN(STR_MAIN_GOTO_DISK_INFO_2);\r
-    case 3: return STRING_TOKEN(STR_MAIN_GOTO_DISK_INFO_3);\r
-    case 4: return STRING_TOKEN(STR_MAIN_GOTO_DISK_INFO_4);\r
-    case 5: return STRING_TOKEN(STR_MAIN_GOTO_DISK_INFO_5);\r
+    case 0: return STRING_TOKEN (STR_MAIN_GOTO_DISK_INFO_0);\r
+    case 1: return STRING_TOKEN (STR_MAIN_GOTO_DISK_INFO_1);\r
+    case 2: return STRING_TOKEN (STR_MAIN_GOTO_DISK_INFO_2);\r
+    case 3: return STRING_TOKEN (STR_MAIN_GOTO_DISK_INFO_3);\r
+    case 4: return STRING_TOKEN (STR_MAIN_GOTO_DISK_INFO_4);\r
+    case 5: return STRING_TOKEN (STR_MAIN_GOTO_DISK_INFO_5);\r
   }\r
+\r
   return 0;\r
 }\r
 \r
@@ -518,15 +533,15 @@ GetDiskNameStringId(
 **/\r
 EFI_STATUS\r
 HiiConfirmDataRemovalAction (\r
-  IN OPAL_DISK                  *OpalDisk,\r
-  IN CHAR16                     *ActionString\r
+  IN OPAL_DISK  *OpalDisk,\r
+  IN CHAR16     *ActionString\r
 \r
   )\r
 {\r
-  CHAR16                        Unicode[512];\r
-  EFI_INPUT_KEY                 Key;\r
-  CHAR16                        ApproveResponse;\r
-  CHAR16                        RejectResponse;\r
+  CHAR16         Unicode[512];\r
+  EFI_INPUT_KEY  Key;\r
+  CHAR16         ApproveResponse;\r
+  CHAR16         RejectResponse;\r
 \r
   //\r
   // When the estimate cost time bigger than MAX_ACCEPTABLE_REVERTING_TIME, pop up dialog to let user confirm\r
@@ -539,22 +554,22 @@ HiiConfirmDataRemovalAction (
   ApproveResponse = L'Y';\r
   RejectResponse  = L'N';\r
 \r
-  UnicodeSPrint(Unicode, StrSize(L"WARNING: ############# action needs about ####### seconds"), L"WARNING: %s action needs about %d seconds", ActionString, OpalDisk->EstimateTimeCost);\r
+  UnicodeSPrint (Unicode, StrSize (L"WARNING: ############# action needs about ####### seconds"), L"WARNING: %s action needs about %d seconds", ActionString, OpalDisk->EstimateTimeCost);\r
 \r
   do {\r
-    CreatePopUp(\r
-        EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-        &Key,\r
-        Unicode,\r
-        L" System should not be powered off until action completion ",\r
-        L" ",\r
-        L" Press 'Y/y' to continue, press 'N/n' to cancel ",\r
-        NULL\r
-    );\r
+    CreatePopUp (\r
+      EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+      &Key,\r
+      Unicode,\r
+      L" System should not be powered off until action completion ",\r
+      L" ",\r
+      L" Press 'Y/y' to continue, press 'N/n' to cancel ",\r
+      NULL\r
+      );\r
   } while (\r
-      ((Key.UnicodeChar | UPPER_LOWER_CASE_OFFSET) != (ApproveResponse | UPPER_LOWER_CASE_OFFSET)) &&\r
-      ((Key.UnicodeChar | UPPER_LOWER_CASE_OFFSET) != (RejectResponse | UPPER_LOWER_CASE_OFFSET))\r
-    );\r
+           ((Key.UnicodeChar | UPPER_LOWER_CASE_OFFSET) != (ApproveResponse | UPPER_LOWER_CASE_OFFSET)) &&\r
+           ((Key.UnicodeChar | UPPER_LOWER_CASE_OFFSET) != (RejectResponse | UPPER_LOWER_CASE_OFFSET))\r
+           );\r
 \r
   if ((Key.UnicodeChar | UPPER_LOWER_CASE_OFFSET) == (RejectResponse | UPPER_LOWER_CASE_OFFSET)) {\r
     return EFI_ABORTED;\r
@@ -587,13 +602,13 @@ HiiConfirmDataRemovalAction (
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-DriverCallback(\r
-  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL    *This,\r
-  EFI_BROWSER_ACTION                      Action,\r
-  EFI_QUESTION_ID                         QuestionId,\r
-  UINT8                                   Type,\r
-  EFI_IFR_TYPE_VALUE                      *Value,\r
-  EFI_BROWSER_ACTION_REQUEST              *ActionRequest\r
+DriverCallback (\r
+  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  EFI_BROWSER_ACTION                    Action,\r
+  EFI_QUESTION_ID                       QuestionId,\r
+  UINT8                                 Type,\r
+  EFI_IFR_TYPE_VALUE                    *Value,\r
+  EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
   )\r
 {\r
   HII_KEY    HiiKey;\r
@@ -615,26 +630,26 @@ DriverCallback(
   }\r
 \r
   HiiKey.Raw = QuestionId;\r
-  HiiKeyId   = (UINT8) HiiKey.KeyBits.Id;\r
+  HiiKeyId   = (UINT8)HiiKey.KeyBits.Id;\r
 \r
   if (Action == EFI_BROWSER_ACTION_FORM_OPEN) {\r
     switch (HiiKeyId) {\r
       case HII_KEY_ID_VAR_SUPPORTED_DISKS:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_VAR_SUPPORTED_DISKS\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_VAR_SUPPORTED_DISKS\n"));\r
         return HiiPopulateMainMenuForm ();\r
 \r
       case HII_KEY_ID_VAR_SELECTED_DISK_AVAILABLE_ACTIONS:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_VAR_SELECTED_DISK_AVAILABLE_ACTIONS\n"));\r
-        return HiiPopulateDiskInfoForm();\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_VAR_SELECTED_DISK_AVAILABLE_ACTIONS\n"));\r
+        return HiiPopulateDiskInfoForm ();\r
     }\r
   } else if (Action == EFI_BROWSER_ACTION_CHANGING) {\r
     switch (HiiKeyId) {\r
       case HII_KEY_ID_GOTO_DISK_INFO:\r
-        return HiiSelectDisk((UINT8)HiiKey.KeyBits.Index);\r
+        return HiiSelectDisk ((UINT8)HiiKey.KeyBits.Index);\r
 \r
       case HII_KEY_ID_REVERT:\r
       case HII_KEY_ID_PSID_REVERT:\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           return HiiConfirmDataRemovalAction (OpalDisk, L"Revert");\r
         } else {\r
@@ -643,14 +658,13 @@ DriverCallback(
         }\r
 \r
       case HII_KEY_ID_SECURE_ERASE:\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           return HiiConfirmDataRemovalAction (OpalDisk, L"Secure erase");\r
         } else {\r
           ASSERT (FALSE);\r
           return EFI_SUCCESS;\r
         }\r
-\r
     }\r
   } else if (Action == EFI_BROWSER_ACTION_CHANGED) {\r
     switch (HiiKeyId) {\r
@@ -689,87 +703,96 @@ DriverCallback(
             DEBUG ((DEBUG_ERROR, "Invalid value input!\n"));\r
             break;\r
         }\r
-        HiiSetBlockSidAction(PpRequest);\r
+\r
+        HiiSetBlockSidAction (PpRequest);\r
 \r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
 \r
       case HII_KEY_ID_SET_ADMIN_PWD:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_SET_ADMIN_PWD\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_SET_ADMIN_PWD\n"));\r
         gHiiConfiguration.OpalRequest.SetAdminPwd = Value->b;\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk                                  = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           SaveOpalRequest (OpalDisk, gHiiConfiguration.OpalRequest);\r
         }\r
+\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
 \r
       case HII_KEY_ID_SET_USER_PWD:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_SET_USER_PWD\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_SET_USER_PWD\n"));\r
         gHiiConfiguration.OpalRequest.SetUserPwd = Value->b;\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk                                 = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           SaveOpalRequest (OpalDisk, gHiiConfiguration.OpalRequest);\r
         }\r
+\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
 \r
       case HII_KEY_ID_SECURE_ERASE:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_SECURE_ERASE\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_SECURE_ERASE\n"));\r
         gHiiConfiguration.OpalRequest.SecureErase = Value->b;\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk                                  = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           SaveOpalRequest (OpalDisk, gHiiConfiguration.OpalRequest);\r
         }\r
+\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
 \r
       case HII_KEY_ID_REVERT:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_REVERT\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_REVERT\n"));\r
         gHiiConfiguration.OpalRequest.Revert = Value->b;\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk                             = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           SaveOpalRequest (OpalDisk, gHiiConfiguration.OpalRequest);\r
         }\r
+\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
       case HII_KEY_ID_KEEP_USER_DATA:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_KEEP_USER_DATA\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_KEEP_USER_DATA\n"));\r
         gHiiConfiguration.OpalRequest.KeepUserData = Value->b;\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk                                   = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           SaveOpalRequest (OpalDisk, gHiiConfiguration.OpalRequest);\r
         }\r
+\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
 \r
       case HII_KEY_ID_PSID_REVERT:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_PSID_REVERT\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_PSID_REVERT\n"));\r
         gHiiConfiguration.OpalRequest.PsidRevert = Value->b;\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk                                 = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           SaveOpalRequest (OpalDisk, gHiiConfiguration.OpalRequest);\r
         }\r
+\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
 \r
       case HII_KEY_ID_DISABLE_USER:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_DISABLE_USER\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_DISABLE_USER\n"));\r
         gHiiConfiguration.OpalRequest.DisableUser = Value->b;\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk                                  = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           SaveOpalRequest (OpalDisk, gHiiConfiguration.OpalRequest);\r
         }\r
+\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
 \r
       case HII_KEY_ID_ENABLE_FEATURE:\r
-        DEBUG ((DEBUG_INFO,  "HII_KEY_ID_ENABLE_FEATURE\n"));\r
+        DEBUG ((DEBUG_INFO, "HII_KEY_ID_ENABLE_FEATURE\n"));\r
         gHiiConfiguration.OpalRequest.EnableFeature = Value->b;\r
-        OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+        OpalDisk                                    = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
         if (OpalDisk != NULL) {\r
           SaveOpalRequest (OpalDisk, gHiiConfiguration.OpalRequest);\r
         }\r
+\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         return EFI_SUCCESS;\r
 \r
@@ -790,11 +813,11 @@ DriverCallback(
 \r
 **/\r
 EFI_STATUS\r
-HiiSelectDisk(\r
-  UINT8 Index\r
+HiiSelectDisk (\r
+  UINT8  Index\r
   )\r
 {\r
-  OpalHiiGetBrowserData();\r
+  OpalHiiGetBrowserData ();\r
   gHiiConfiguration.SelectedDiskIndex = Index;\r
   OpalHiiSetBrowserData ();\r
 \r
@@ -808,32 +831,33 @@ HiiSelectDisk(
 \r
 **/\r
 EFI_STATUS\r
-HiiPopulateDiskInfoForm(\r
+HiiPopulateDiskInfoForm (\r
   VOID\r
   )\r
 {\r
-  OPAL_DISK*                    OpalDisk;\r
-  OPAL_DISK_ACTIONS             AvailActions;\r
-  TCG_RESULT                    Ret;\r
-  CHAR8                         *DiskName;\r
+  OPAL_DISK          *OpalDisk;\r
+  OPAL_DISK_ACTIONS  AvailActions;\r
+  TCG_RESULT         Ret;\r
+  CHAR8              *DiskName;\r
 \r
-  OpalHiiGetBrowserData();\r
+  OpalHiiGetBrowserData ();\r
 \r
   DiskName = HiiDiskGetNameCB (gHiiConfiguration.SelectedDiskIndex);\r
   if (DiskName == NULL) {\r
     return EFI_UNSUPPORTED;\r
   }\r
-  HiiSetFormString(STRING_TOKEN(STR_DISK_INFO_SELECTED_DISK_NAME), DiskName);\r
+\r
+  HiiSetFormString (STRING_TOKEN (STR_DISK_INFO_SELECTED_DISK_NAME), DiskName);\r
 \r
   gHiiConfiguration.SelectedDiskAvailableActions = HII_ACTION_NONE;\r
   ZeroMem (&gHiiConfiguration.OpalRequest, sizeof (OPAL_REQUEST));\r
   gHiiConfiguration.KeepUserDataForced = FALSE;\r
 \r
-  OpalDisk = HiiGetOpalDiskCB(gHiiConfiguration.SelectedDiskIndex);\r
+  OpalDisk = HiiGetOpalDiskCB (gHiiConfiguration.SelectedDiskIndex);\r
 \r
   if (OpalDisk != NULL) {\r
     OpalDiskUpdateStatus (OpalDisk);\r
-    Ret = OpalSupportGetAvailableActions(&OpalDisk->SupportedAttributes, &OpalDisk->LockingFeature, OpalDisk->Owner, &AvailActions);\r
+    Ret = OpalSupportGetAvailableActions (&OpalDisk->SupportedAttributes, &OpalDisk->LockingFeature, OpalDisk->Owner, &AvailActions);\r
     if (Ret == TcgResultSuccess) {\r
       //\r
       // Update actions, always allow PSID Revert\r
@@ -852,7 +876,7 @@ HiiPopulateDiskInfoForm(
           //\r
           // Update strings\r
           //\r
-          HiiSetFormString( STRING_TOKEN(STR_DISK_INFO_PSID_REVERT), "PSID Revert to factory default");\r
+          HiiSetFormString (STRING_TOKEN (STR_DISK_INFO_PSID_REVERT), "PSID Revert to factory default");\r
         } else {\r
           DEBUG ((DEBUG_INFO, "Feature disabled but ownership != nobody\n"));\r
         }\r
@@ -863,7 +887,7 @@ HiiPopulateDiskInfoForm(
         gHiiConfiguration.SelectedDiskAvailableActions |= (AvailActions.SecureErase == 1) ? HII_ACTION_SECURE_ERASE : HII_ACTION_NONE;\r
         gHiiConfiguration.SelectedDiskAvailableActions |= (AvailActions.DisableUser == 1) ? HII_ACTION_DISABLE_USER : HII_ACTION_NONE;\r
 \r
-        HiiSetFormString (STRING_TOKEN(STR_DISK_INFO_PSID_REVERT), "PSID Revert to factory default and Disable");\r
+        HiiSetFormString (STRING_TOKEN (STR_DISK_INFO_PSID_REVERT), "PSID Revert to factory default and Disable");\r
 \r
         //\r
         // Determine revert options for disk\r
@@ -898,11 +922,11 @@ HiiPopulateDiskInfoForm(
 **/\r
 EFI_STATUS\r
 HiiSetBlockSidAction (\r
-  IN UINT32          PpRequest\r
+  IN UINT32  PpRequest\r
   )\r
 {\r
-  UINT32                           ReturnCode;\r
-  EFI_STATUS                       Status;\r
+  UINT32      ReturnCode;\r
+  EFI_STATUS  Status;\r
 \r
   ReturnCode = Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (PpRequest, 0);\r
   if (ReturnCode == TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) {\r
@@ -938,13 +962,13 @@ HiiSetBlockSidAction (
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-RouteConfig(\r
-  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL    *This,\r
-  CONST EFI_STRING                        Configuration,\r
-  EFI_STRING                              *Progress\r
+RouteConfig (\r
+  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  CONST EFI_STRING                      Configuration,\r
+  EFI_STRING                            *Progress\r
   )\r
 {\r
-  if (Configuration == NULL || Progress == NULL) {\r
+  if ((Configuration == NULL) || (Progress == NULL)) {\r
     return (EFI_INVALID_PARAMETER);\r
   }\r
 \r
@@ -986,50 +1010,52 @@ RouteConfig(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-ExtractConfig(\r
-  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL    *This,\r
-  CONST EFI_STRING                        Request,\r
-  EFI_STRING                              *Progress,\r
-  EFI_STRING                              *Results\r
+ExtractConfig (\r
+  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  CONST EFI_STRING                      Request,\r
+  EFI_STRING                            *Progress,\r
+  EFI_STRING                            *Results\r
   )\r
 {\r
-  EFI_STATUS                              Status;\r
-  EFI_STRING                              ConfigRequest;\r
-  EFI_STRING                              ConfigRequestHdr;\r
-  UINTN                                   BufferSize;\r
-  UINTN                                   Size;\r
-  BOOLEAN                                 AllocatedRequest;\r
-  EFI_HANDLE                              DriverHandle;\r
+  EFI_STATUS  Status;\r
+  EFI_STRING  ConfigRequest;\r
+  EFI_STRING  ConfigRequestHdr;\r
+  UINTN       BufferSize;\r
+  UINTN       Size;\r
+  BOOLEAN     AllocatedRequest;\r
+  EFI_HANDLE  DriverHandle;\r
 \r
   //\r
   // Check for valid parameters\r
   //\r
-  if (Progress == NULL || Results == NULL) {\r
+  if ((Progress == NULL) || (Results == NULL)) {\r
     return (EFI_INVALID_PARAMETER);\r
   }\r
 \r
   *Progress = Request;\r
   if ((Request != NULL) &&\r
-    !HiiIsConfigHdrMatch (Request, &gHiiSetupVariableGuid, OpalPasswordStorageName)) {\r
+      !HiiIsConfigHdrMatch (Request, &gHiiSetupVariableGuid, OpalPasswordStorageName))\r
+  {\r
     return EFI_NOT_FOUND;\r
   }\r
 \r
   AllocatedRequest = FALSE;\r
-  BufferSize = sizeof (OPAL_HII_CONFIGURATION);\r
-  ConfigRequest = Request;\r
+  BufferSize       = sizeof (OPAL_HII_CONFIGURATION);\r
+  ConfigRequest    = Request;\r
   if ((Request == NULL) || (StrStr (Request, L"OFFSET") == NULL)) {\r
     //\r
     // Request has no request element, construct full request string.\r
     // Allocate and fill a buffer large enough to hold the <ConfigHdr> template\r
     // followed by "&OFFSET=0&WIDTH=WWWWWWWWWWWWWWWW" followed by a Null-terminator\r
     //\r
-    DriverHandle = HiiGetDriverImageHandleCB();\r
+    DriverHandle     = HiiGetDriverImageHandleCB ();\r
     ConfigRequestHdr = HiiConstructConfigHdr (&gHiiSetupVariableGuid, OpalPasswordStorageName, DriverHandle);\r
-    Size = (StrLen (ConfigRequestHdr) + 32 + 1) * sizeof (CHAR16);\r
-    ConfigRequest = AllocateZeroPool (Size);\r
+    Size             = (StrLen (ConfigRequestHdr) + 32 + 1) * sizeof (CHAR16);\r
+    ConfigRequest    = AllocateZeroPool (Size);\r
     if (ConfigRequest == NULL) {\r
       return EFI_OUT_OF_RESOURCES;\r
     }\r
+\r
     AllocatedRequest = TRUE;\r
     UnicodeSPrint (ConfigRequest, Size, L"%s&OFFSET=0&WIDTH=%016LX", ConfigRequestHdr, (UINT64)BufferSize);\r
     FreePool (ConfigRequestHdr);\r
@@ -1038,14 +1064,14 @@ ExtractConfig(
   //\r
   // Convert Buffer Data to <ConfigResp> by helper function BlockToConfig( )\r
   //\r
-  Status = gHiiConfigRouting->BlockToConfig(\r
-               gHiiConfigRouting,\r
-               ConfigRequest,\r
-               (UINT8*)&gHiiConfiguration,\r
-               sizeof(OPAL_HII_CONFIGURATION),\r
-               Results,\r
-               Progress\r
-           );\r
+  Status = gHiiConfigRouting->BlockToConfig (\r
+                                gHiiConfigRouting,\r
+                                ConfigRequest,\r
+                                (UINT8 *)&gHiiConfiguration,\r
+                                sizeof (OPAL_HII_CONFIGURATION),\r
+                                Results,\r
+                                Progress\r
+                                );\r
 \r
   //\r
   // Free the allocated config request string.\r
@@ -1067,7 +1093,6 @@ ExtractConfig(
   return (Status);\r
 }\r
 \r
-\r
 /**\r
 \r
   Pass the current system state to the bios via the hii_G_Configuration.\r
@@ -1078,16 +1103,15 @@ OpalHiiSetBrowserData (
   VOID\r
   )\r
 {\r
-  HiiSetBrowserData(\r
-      &gHiiSetupVariableGuid,\r
-      (CHAR16*)L"OpalHiiConfig",\r
-      sizeof(gHiiConfiguration),\r
-      (UINT8*)&gHiiConfiguration,\r
-      NULL\r
-  );\r
+  HiiSetBrowserData (\r
+    &gHiiSetupVariableGuid,\r
+    (CHAR16 *)L"OpalHiiConfig",\r
+    sizeof (gHiiConfiguration),\r
+    (UINT8 *)&gHiiConfiguration,\r
+    NULL\r
+    );\r
 }\r
 \r
-\r
 /**\r
 \r
   Populate the hii_g_Configuration with the browser Data.\r
@@ -1098,12 +1122,12 @@ OpalHiiGetBrowserData (
   VOID\r
   )\r
 {\r
-  HiiGetBrowserData(\r
-      &gHiiSetupVariableGuid,\r
-      (CHAR16*)L"OpalHiiConfig",\r
-      sizeof(gHiiConfiguration),\r
-      (UINT8*)&gHiiConfiguration\r
-  );\r
+  HiiGetBrowserData (\r
+    &gHiiSetupVariableGuid,\r
+    (CHAR16 *)L"OpalHiiConfig",\r
+    sizeof (gHiiConfiguration),\r
+    (UINT8 *)&gHiiConfiguration\r
+    );\r
 }\r
 \r
 /**\r
@@ -1117,44 +1141,44 @@ OpalHiiGetBrowserData (
 \r
 **/\r
 EFI_STATUS\r
-HiiSetFormString(\r
-  EFI_STRING_ID       DestStringId,\r
-  CHAR8               *SrcAsciiStr\r
+HiiSetFormString (\r
+  EFI_STRING_ID  DestStringId,\r
+  CHAR8          *SrcAsciiStr\r
   )\r
 {\r
-  UINT32                    Len;\r
-  UINT32                    UniSize;\r
-  CHAR16*                   UniStr;\r
+  UINT32  Len;\r
+  UINT32  UniSize;\r
+  CHAR16  *UniStr;\r
 \r
   //\r
   // Determine the Length of the sting\r
   //\r
-  Len = ( UINT32 )AsciiStrLen( SrcAsciiStr );\r
+  Len = (UINT32)AsciiStrLen (SrcAsciiStr);\r
 \r
   //\r
   // Allocate space for the unicode string, including terminator\r
   //\r
-  UniSize = (Len + 1) * sizeof(CHAR16);\r
-  UniStr = (CHAR16*)AllocateZeroPool(UniSize);\r
+  UniSize = (Len + 1) * sizeof (CHAR16);\r
+  UniStr  = (CHAR16 *)AllocateZeroPool (UniSize);\r
 \r
   //\r
   // Copy into unicode string, then copy into string id\r
   //\r
-  AsciiStrToUnicodeStrS ( SrcAsciiStr, UniStr, Len + 1);\r
+  AsciiStrToUnicodeStrS (SrcAsciiStr, UniStr, Len + 1);\r
 \r
   //\r
   // Update the string in the form\r
   //\r
-  if (HiiSetString(gHiiPackageListHandle, DestStringId, UniStr, NULL) == 0) {\r
-    DEBUG ((DEBUG_INFO,  "HiiSetFormString( ) failed\n"));\r
-    FreePool(UniStr);\r
+  if (HiiSetString (gHiiPackageListHandle, DestStringId, UniStr, NULL) == 0) {\r
+    DEBUG ((DEBUG_INFO, "HiiSetFormString( ) failed\n"));\r
+    FreePool (UniStr);\r
     return (EFI_OUT_OF_RESOURCES);\r
   }\r
 \r
   //\r
   // Free the memory\r
   //\r
-  FreePool(UniStr);\r
+  FreePool (UniStr);\r
 \r
   return (EFI_SUCCESS);\r
 }\r
@@ -1170,27 +1194,28 @@ HiiSetFormString(
 **/\r
 EFI_STATUS\r
 OpalDiskInitialize (\r
-  IN OPAL_DRIVER_DEVICE          *Dev\r
+  IN OPAL_DRIVER_DEVICE  *Dev\r
   )\r
 {\r
-  TCG_RESULT                  TcgResult;\r
-  OPAL_SESSION                Session;\r
-  UINT8                       ActiveDataRemovalMechanism;\r
-  UINT32                      RemovalMechanishLists[ResearvedMechanism];\r
-\r
-  ZeroMem(&Dev->OpalDisk, sizeof(OPAL_DISK));\r
-  Dev->OpalDisk.Sscp = Dev->Sscp;\r
-  Dev->OpalDisk.MediaId = Dev->MediaId;\r
+  TCG_RESULT    TcgResult;\r
+  OPAL_SESSION  Session;\r
+  UINT8         ActiveDataRemovalMechanism;\r
+  UINT32        RemovalMechanishLists[ResearvedMechanism];\r
+\r
+  ZeroMem (&Dev->OpalDisk, sizeof (OPAL_DISK));\r
+  Dev->OpalDisk.Sscp           = Dev->Sscp;\r
+  Dev->OpalDisk.MediaId        = Dev->MediaId;\r
   Dev->OpalDisk.OpalDevicePath = Dev->OpalDevicePath;\r
 \r
-  ZeroMem(&Session, sizeof(Session));\r
-  Session.Sscp = Dev->Sscp;\r
+  ZeroMem (&Session, sizeof (Session));\r
+  Session.Sscp    = Dev->Sscp;\r
   Session.MediaId = Dev->MediaId;\r
 \r
   TcgResult = OpalGetSupportedAttributesInfo (&Session, &Dev->OpalDisk.SupportedAttributes, &Dev->OpalDisk.OpalBaseComId);\r
   if (TcgResult != TcgResultSuccess) {\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   Session.OpalBaseComId = Dev->OpalDisk.OpalBaseComId;\r
 \r
   TcgResult = OpalUtilGetMsid (&Session, Dev->OpalDisk.Msid, OPAL_MSID_LENGTH, &Dev->OpalDisk.MsidLength);\r
@@ -1227,7 +1252,7 @@ OpalDiskInitialize (
 **/\r
 EFI_STATUS\r
 OpalDiskUpdateOwnerShip (\r
-  OPAL_DISK        *OpalDisk\r
+  OPAL_DISK  *OpalDisk\r
   )\r
 {\r
   OPAL_SESSION  Session;\r
@@ -1240,12 +1265,12 @@ OpalDiskUpdateOwnerShip (
     return EFI_ACCESS_DENIED;\r
   }\r
 \r
-  ZeroMem(&Session, sizeof(Session));\r
-  Session.Sscp = OpalDisk->Sscp;\r
-  Session.MediaId = OpalDisk->MediaId;\r
+  ZeroMem (&Session, sizeof (Session));\r
+  Session.Sscp          = OpalDisk->Sscp;\r
+  Session.MediaId       = OpalDisk->MediaId;\r
   Session.OpalBaseComId = OpalDisk->OpalBaseComId;\r
 \r
-  OpalDisk->Owner = OpalUtilDetermineOwnership(&Session, OpalDisk->Msid, OpalDisk->MsidLength);\r
+  OpalDisk->Owner = OpalUtilDetermineOwnership (&Session, OpalDisk->Msid, OpalDisk->MsidLength);\r
   return EFI_SUCCESS;\r
 }\r
 \r
@@ -1262,22 +1287,21 @@ OpalDiskUpdateOwnerShip (
 **/\r
 EFI_STATUS\r
 OpalDiskUpdateStatus (\r
-  OPAL_DISK        *OpalDisk\r
+  OPAL_DISK  *OpalDisk\r
   )\r
 {\r
-  TCG_RESULT                  TcgResult;\r
-  OPAL_SESSION                Session;\r
+  TCG_RESULT    TcgResult;\r
+  OPAL_SESSION  Session;\r
 \r
-  ZeroMem(&Session, sizeof(Session));\r
-  Session.Sscp = OpalDisk->Sscp;\r
-  Session.MediaId = OpalDisk->MediaId;\r
+  ZeroMem (&Session, sizeof (Session));\r
+  Session.Sscp          = OpalDisk->Sscp;\r
+  Session.MediaId       = OpalDisk->MediaId;\r
   Session.OpalBaseComId = OpalDisk->OpalBaseComId;\r
 \r
-  TcgResult = OpalGetLockingInfo(&Session, &OpalDisk->LockingFeature);\r
+  TcgResult = OpalGetLockingInfo (&Session, &OpalDisk->LockingFeature);\r
   if (TcgResult != TcgResultSuccess) {\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
   return OpalDiskUpdateOwnerShip (OpalDisk);\r
 }\r
-\r
index 557c1f8d68da7f62ef3ce0a3242fedd47baf890e..3b294d8e1449492ced931e03a4e091842bda0a22 100644 (file)
@@ -20,35 +20,35 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0x0d510a4f, 0xa81b, 0x473f, { 0x87, 0x07, 0xb7, 0xfd, 0xfb, 0xc0, 0x45, 0xba } \\r
   }\r
 \r
-#define OPAL_REQUEST_VARIABLE_NAME     L"OpalRequest"\r
+#define OPAL_REQUEST_VARIABLE_NAME  L"OpalRequest"\r
 \r
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  UINT32                   Length;\r
-  OPAL_REQUEST             OpalRequest;\r
-  //EFI_DEVICE_PATH_PROTOCOL OpalDevicePath;\r
+  UINT32          Length;\r
+  OPAL_REQUEST    OpalRequest;\r
+  // EFI_DEVICE_PATH_PROTOCOL OpalDevicePath;\r
 } OPAL_REQUEST_VARIABLE;\r
 \r
 typedef struct {\r
-  UINT16 Id: HII_KEY_ID_BITS;\r
-  UINT16 Index: HII_KEY_INDEX_BITS;\r
-  UINT16 Flag: HII_KEY_FLAG_BITS;\r
+  UINT16    Id    : HII_KEY_ID_BITS;\r
+  UINT16    Index : HII_KEY_INDEX_BITS;\r
+  UINT16    Flag  : HII_KEY_FLAG_BITS;\r
 } KEY_BITS;\r
 \r
 typedef union {\r
-    UINT16    Raw;\r
-    KEY_BITS  KeyBits;\r
+  UINT16      Raw;\r
+  KEY_BITS    KeyBits;\r
 } HII_KEY;\r
 \r
 typedef struct {\r
-    VENDOR_DEVICE_PATH             VendorDevicePath;\r
-    EFI_DEVICE_PATH_PROTOCOL       End;\r
+  VENDOR_DEVICE_PATH          VendorDevicePath;\r
+  EFI_DEVICE_PATH_PROTOCOL    End;\r
 } HII_VENDOR_DEVICE_PATH;\r
 \r
 #pragma pack()\r
 \r
-extern const EFI_GUID gHiiSetupVariableGuid;\r
+extern const EFI_GUID  gHiiSetupVariableGuid;\r
 \r
 /**\r
   This function processes the results of changes in configuration.\r
@@ -70,10 +70,10 @@ extern const EFI_GUID gHiiSetupVariableGuid;
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-RouteConfig(\r
-  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL    *This,\r
-  CONST EFI_STRING                        Configuration,\r
-  EFI_STRING                              *Progress\r
+RouteConfig (\r
+  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  CONST EFI_STRING                      Configuration,\r
+  EFI_STRING                            *Progress\r
   );\r
 \r
 /**\r
@@ -104,11 +104,11 @@ RouteConfig(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-ExtractConfig(\r
-  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL    *This,\r
-  CONST EFI_STRING                        Request,\r
-  EFI_STRING                              *Progress,\r
-  EFI_STRING                              *Results\r
+ExtractConfig (\r
+  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  CONST EFI_STRING                      Request,\r
+  EFI_STRING                            *Progress,\r
+  EFI_STRING                            *Results\r
   );\r
 \r
 /**\r
@@ -135,13 +135,13 @@ ExtractConfig(
 **/\r
 EFI_STATUS\r
 EFIAPI\r
-DriverCallback(\r
-  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL*   This,\r
-  EFI_BROWSER_ACTION                      Action,\r
-  EFI_QUESTION_ID                         QuestionId,\r
-  UINT8                                   Type,\r
-  EFI_IFR_TYPE_VALUE*                     Value,\r
-  EFI_BROWSER_ACTION_REQUEST*             ActionRequest\r
+DriverCallback (\r
+  CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  EFI_BROWSER_ACTION                    Action,\r
+  EFI_QUESTION_ID                       QuestionId,\r
+  UINT8                                 Type,\r
+  EFI_IFR_TYPE_VALUE                    *Value,\r
+  EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
   );\r
 \r
 /**\r
@@ -171,7 +171,7 @@ OpalHiiGetBrowserData (
 \r
 **/\r
 EFI_STATUS\r
-HiiPopulateDiskInfoForm(\r
+HiiPopulateDiskInfoForm (\r
   VOID\r
   );\r
 \r
@@ -184,8 +184,8 @@ HiiPopulateDiskInfoForm(
 \r
 **/\r
 EFI_STATUS\r
-HiiSelectDisk(\r
-  UINT8 Index\r
+HiiSelectDisk (\r
+  UINT8  Index\r
   );\r
 \r
 /**\r
@@ -198,8 +198,8 @@ HiiSelectDisk(
 \r
 **/\r
 EFI_STATUS\r
-HiiPasswordEntered(\r
-  EFI_STRING_ID            Str\r
+HiiPasswordEntered (\r
+  EFI_STRING_ID  Str\r
   );\r
 \r
 /**\r
@@ -213,7 +213,7 @@ HiiPasswordEntered(
 **/\r
 EFI_STATUS\r
 HiiSetBlockSidAction (\r
-  UINT32          PpRequest\r
+  UINT32  PpRequest\r
   );\r
 \r
 /**\r
@@ -225,8 +225,8 @@ HiiSetBlockSidAction (
 \r
 **/\r
 EFI_STATUS\r
-HiiPsidRevert(\r
-  EFI_STRING_ID         PsidStringId\r
+HiiPsidRevert (\r
+  EFI_STRING_ID  PsidStringId\r
   );\r
 \r
 /**\r
@@ -238,8 +238,8 @@ HiiPsidRevert(
 \r
 **/\r
 EFI_STRING_ID\r
-GetDiskNameStringId(\r
-  UINT8 DiskIndex\r
+GetDiskNameStringId (\r
+  UINT8  DiskIndex\r
   );\r
 \r
 /**\r
@@ -254,7 +254,7 @@ GetDiskNameStringId(
 **/\r
 EFI_STATUS\r
 OpalDiskUpdateStatus (\r
-  OPAL_DISK        *OpalDisk\r
+  OPAL_DISK  *OpalDisk\r
   );\r
 \r
 /**\r
@@ -264,7 +264,7 @@ OpalDiskUpdateStatus (
 \r
 **/\r
 EFI_HANDLE\r
-HiiGetDriverImageHandleCB(\r
+HiiGetDriverImageHandleCB (\r
   VOID\r
   );\r
 \r
@@ -275,7 +275,7 @@ HiiGetDriverImageHandleCB(
   @retval  EFI_OUT_OF_RESOURCES  Out of resource error.\r
 **/\r
 EFI_STATUS\r
-OpalHiiAddPackages(\r
+OpalHiiAddPackages (\r
   VOID\r
   );\r
 \r
@@ -287,9 +287,9 @@ OpalHiiAddPackages(
   @retval The device pointer.\r
 \r
 **/\r
-OPAL_DISK*\r
-HiiGetOpalDiskCB(\r
-  UINT8 DiskIndex\r
+OPAL_DISK *\r
+HiiGetOpalDiskCB (\r
+  UINT8  DiskIndex\r
   );\r
 \r
 /**\r
@@ -300,9 +300,9 @@ HiiGetOpalDiskCB(
   @retval Returns the disk name.\r
 \r
 **/\r
-CHAR8*\r
-HiiDiskGetNameCB(\r
-  UINT8 DiskIndex\r
+CHAR8 *\r
+HiiDiskGetNameCB (\r
+  UINT8  DiskIndex\r
   );\r
 \r
 /**\r
@@ -316,9 +316,9 @@ HiiDiskGetNameCB(
 \r
 **/\r
 EFI_STATUS\r
-HiiSetFormString(\r
-  EFI_STRING_ID       DestStringId,\r
-  CHAR8               *SrcAsciiStr\r
+HiiSetFormString (\r
+  EFI_STRING_ID  DestStringId,\r
+  CHAR8          *SrcAsciiStr\r
   );\r
 \r
 /**\r
@@ -328,7 +328,7 @@ HiiSetFormString(
   @retval  other              Error occur when install the resources.\r
 **/\r
 EFI_STATUS\r
-HiiInstall(\r
+HiiInstall (\r
   VOID\r
   );\r
 \r
@@ -339,7 +339,7 @@ HiiInstall(
   @retval  others                Other errors occur when unistall the hii resource.\r
 **/\r
 EFI_STATUS\r
-HiiUninstall(\r
+HiiUninstall (\r
   VOID\r
   );\r
 \r
@@ -354,7 +354,7 @@ HiiUninstall(
 **/\r
 EFI_STATUS\r
 OpalDiskInitialize (\r
-  IN OPAL_DRIVER_DEVICE          *Dev\r
+  IN OPAL_DRIVER_DEVICE  *Dev\r
   );\r
 \r
 /**\r
@@ -369,7 +369,7 @@ OpalDiskInitialize (
 **/\r
 EFI_STATUS\r
 OpalDiskUpdateOwnerShip (\r
-  OPAL_DISK        *OpalDisk\r
+  OPAL_DISK  *OpalDisk\r
   );\r
 \r
 #endif // _HII_H_\r
index 2f270e5516eb2da910a44b5352c41d87eeb2e5ee..105b019959ad0b22b16fe7d3fddc1f638d33e11c 100644 (file)
@@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 **/\r
 EFI_HANDLE\r
-HiiGetDriverImageHandleCB(\r
+HiiGetDriverImageHandleCB (\r
   VOID\r
   )\r
 {\r
@@ -32,17 +32,17 @@ HiiGetDriverImageHandleCB(
 \r
 **/\r
 VOID *\r
-HiiGetDiskContextCB(\r
-  UINT8 DiskIndex\r
+HiiGetDiskContextCB (\r
+  UINT8  DiskIndex\r
   )\r
 {\r
-  OPAL_DRIVER_DEVICE*                Dev;\r
-  UINT8                              CurrentDisk;\r
+  OPAL_DRIVER_DEVICE  *Dev;\r
+  UINT8               CurrentDisk;\r
 \r
-  Dev = OpalDriverGetDeviceList();\r
+  Dev         = OpalDriverGetDeviceList ();\r
   CurrentDisk = 0;\r
 \r
-  if (DiskIndex >= GetDeviceCount()) {\r
+  if (DiskIndex >= GetDeviceCount ()) {\r
     return NULL;\r
   }\r
 \r
@@ -66,13 +66,13 @@ HiiGetDiskContextCB(
   @retval The device pointer.\r
 \r
 **/\r
-OPAL_DISK*\r
-HiiGetOpalDiskCB(\r
-  UINT8 DiskIndex\r
+OPAL_DISK *\r
+HiiGetOpalDiskCB (\r
+  UINT8  DiskIndex\r
   )\r
 {\r
-  VOID                           *Ctx;\r
-  OPAL_DRIVER_DEVICE             *Tmp;\r
+  VOID                *Ctx;\r
+  OPAL_DRIVER_DEVICE  *Tmp;\r
 \r
   Ctx = HiiGetDiskContextCB (DiskIndex);\r
 \r
@@ -80,7 +80,7 @@ HiiGetOpalDiskCB(
     return NULL;\r
   }\r
 \r
-  Tmp = (OPAL_DRIVER_DEVICE*) Ctx;\r
+  Tmp = (OPAL_DRIVER_DEVICE *)Ctx;\r
 \r
   return &Tmp->OpalDisk;\r
 }\r
@@ -93,20 +93,22 @@ HiiGetOpalDiskCB(
   @retval Returns the disk name.\r
 \r
 **/\r
-CHAR8*\r
-HiiDiskGetNameCB(\r
-  UINT8 DiskIndex\r
+CHAR8 *\r
+HiiDiskGetNameCB (\r
+  UINT8  DiskIndex\r
   )\r
 {\r
-  OPAL_DRIVER_DEVICE*                Ctx;\r
+  OPAL_DRIVER_DEVICE  *Ctx;\r
 \r
-  Ctx = (OPAL_DRIVER_DEVICE*) HiiGetDiskContextCB (DiskIndex);\r
+  Ctx = (OPAL_DRIVER_DEVICE *)HiiGetDiskContextCB (DiskIndex);\r
 \r
   if (Ctx != NULL) {\r
     if (Ctx->NameZ == NULL) {\r
       OpalDriverGetDriverDeviceName (Ctx);\r
     }\r
+\r
     return Ctx->NameZ;\r
   }\r
+\r
   return NULL;\r
 }\r
index 9e1aadccf1a7f6846fabdfd74cb3217c936d473e..ab6957fc6fe5432ef5811e3020ceed94072fec4a 100644 (file)
@@ -6,28 +6,27 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 **/\r
 \r
-\r
 #ifndef _OPAL_HII_FORM_VALUES_H_\r
 #define _OPAL_HII_FORM_VALUES_H_\r
 \r
 // ID's for various forms that will be used by HII\r
-#define FORMID_VALUE_MAIN_MENU                             0x01\r
-#define FORMID_VALUE_DISK_INFO_FORM_MAIN                   0x02\r
+#define FORMID_VALUE_MAIN_MENU            0x01\r
+#define FORMID_VALUE_DISK_INFO_FORM_MAIN  0x02\r
 \r
 #pragma pack(1)\r
 typedef struct {\r
-  UINT16    Lock:1;\r
-  UINT16    Unlock:1;\r
-  UINT16    SetAdminPwd:1;\r
-  UINT16    SetUserPwd:1;\r
-  UINT16    SecureErase:1;\r
-  UINT16    Revert:1;\r
-  UINT16    PsidRevert:1;\r
-  UINT16    DisableUser:1;\r
-  UINT16    DisableFeature:1;\r
-  UINT16    EnableFeature:1;\r
-  UINT16    Reserved:5;\r
-  UINT16    KeepUserData:1;\r
+  UINT16    Lock           : 1;\r
+  UINT16    Unlock         : 1;\r
+  UINT16    SetAdminPwd    : 1;\r
+  UINT16    SetUserPwd     : 1;\r
+  UINT16    SecureErase    : 1;\r
+  UINT16    Revert         : 1;\r
+  UINT16    PsidRevert     : 1;\r
+  UINT16    DisableUser    : 1;\r
+  UINT16    DisableFeature : 1;\r
+  UINT16    EnableFeature  : 1;\r
+  UINT16    Reserved       : 5;\r
+  UINT16    KeepUserData   : 1;\r
 } OPAL_REQUEST;\r
 \r
 typedef struct {\r
@@ -43,17 +42,17 @@ typedef struct {
 #pragma pack()\r
 \r
 /* Action Flags */\r
-#define HII_ACTION_NONE                                        0x0000\r
-#define HII_ACTION_LOCK                                        0x0001\r
-#define HII_ACTION_UNLOCK                                      0x0002\r
-#define HII_ACTION_SET_ADMIN_PWD                               0x0004\r
-#define HII_ACTION_SET_USER_PWD                                0x0008\r
-#define HII_ACTION_SECURE_ERASE                                0x0010\r
-#define HII_ACTION_REVERT                                      0x0020\r
-#define HII_ACTION_PSID_REVERT                                 0x0040\r
-#define HII_ACTION_DISABLE_USER                                0x0080\r
-#define HII_ACTION_DISABLE_FEATURE                             0x0100\r
-#define HII_ACTION_ENABLE_FEATURE                              0x0200\r
+#define HII_ACTION_NONE             0x0000\r
+#define HII_ACTION_LOCK             0x0001\r
+#define HII_ACTION_UNLOCK           0x0002\r
+#define HII_ACTION_SET_ADMIN_PWD    0x0004\r
+#define HII_ACTION_SET_USER_PWD     0x0008\r
+#define HII_ACTION_SECURE_ERASE     0x0010\r
+#define HII_ACTION_REVERT           0x0020\r
+#define HII_ACTION_PSID_REVERT      0x0040\r
+#define HII_ACTION_DISABLE_USER     0x0080\r
+#define HII_ACTION_DISABLE_FEATURE  0x0100\r
+#define HII_ACTION_ENABLE_FEATURE   0x0200\r
 \r
 /* Number of bits allocated for each part of a unique key for an HII_ITEM\r
  * all bits together must be <= 16 (EFI_QUESTION_ID is UINT16)\r
@@ -61,32 +60,32 @@ typedef struct {
  * |   |-----------------------|   |---------------------------|\r
  * FLG INDEX                       ID\r
  */\r
-#define HII_KEY_ID_BITS                                     8\r
-#define HII_KEY_INDEX_BITS                                  7\r
-#define HII_KEY_FLAG_BITS                                   1\r
+#define HII_KEY_ID_BITS     8\r
+#define HII_KEY_INDEX_BITS  7\r
+#define HII_KEY_FLAG_BITS   1\r
 \r
-#define HII_KEY_FLAG                                        0x8000 // bit 15 (zero based)\r
+#define HII_KEY_FLAG  0x8000                                       // bit 15 (zero based)\r
 \r
 /***********/\r
 /* Key IDs */\r
 /***********/\r
 \r
-#define HII_KEY_ID_GOTO_DISK_INFO                       1\r
+#define HII_KEY_ID_GOTO_DISK_INFO  1\r
 \r
 #define HII_KEY_ID_VAR_SUPPORTED_DISKS                  2\r
 #define HII_KEY_ID_VAR_SELECTED_DISK_AVAILABLE_ACTIONS  3\r
 \r
-#define HII_KEY_ID_BLOCKSID                             4\r
-#define HII_KEY_ID_SET_ADMIN_PWD                        5\r
-#define HII_KEY_ID_SET_USER_PWD                         6\r
-#define HII_KEY_ID_SECURE_ERASE                         7\r
-#define HII_KEY_ID_REVERT                               8\r
-#define HII_KEY_ID_KEEP_USER_DATA                       9\r
-#define HII_KEY_ID_PSID_REVERT                          0xA\r
-#define HII_KEY_ID_DISABLE_USER                         0xB\r
-#define HII_KEY_ID_ENABLE_FEATURE                       0xC\r
+#define HII_KEY_ID_BLOCKSID        4\r
+#define HII_KEY_ID_SET_ADMIN_PWD   5\r
+#define HII_KEY_ID_SET_USER_PWD    6\r
+#define HII_KEY_ID_SECURE_ERASE    7\r
+#define HII_KEY_ID_REVERT          8\r
+#define HII_KEY_ID_KEEP_USER_DATA  9\r
+#define HII_KEY_ID_PSID_REVERT     0xA\r
+#define HII_KEY_ID_DISABLE_USER    0xB\r
+#define HII_KEY_ID_ENABLE_FEATURE  0xC\r
 \r
-#define HII_KEY_ID_MAX                                  0xC // !!Update each time a new ID is added!!\r
+#define HII_KEY_ID_MAX  0xC                                 // !!Update each time a new ID is added!!\r
 \r
 #define HII_KEY_WITH_INDEX(id, index) \\r
     ( \\r
@@ -95,15 +94,14 @@ typedef struct {
         ((index) << HII_KEY_ID_BITS) \\r
     )\r
 \r
-#define HII_KEY(id) HII_KEY_WITH_INDEX(id, 0)\r
+#define HII_KEY(id)  HII_KEY_WITH_INDEX(id, 0)\r
 \r
-#define PACKAGE_LIST_GUID { 0xf0308176, 0x9058, 0x4153, { 0x93, 0x3d, 0xda, 0x2f, 0xdc, 0xc8, 0x3e, 0x44 } }\r
+#define PACKAGE_LIST_GUID  { 0xf0308176, 0x9058, 0x4153, { 0x93, 0x3d, 0xda, 0x2f, 0xdc, 0xc8, 0x3e, 0x44 } }\r
 \r
 /* {410483CF-F4F9-4ece-848A-1958FD31CEB7} */\r
-#define SETUP_FORMSET_GUID { 0x410483cf, 0xf4f9, 0x4ece, { 0x84, 0x8a, 0x19, 0x58, 0xfd, 0x31, 0xce, 0xb7 } }\r
+#define SETUP_FORMSET_GUID  { 0x410483cf, 0xf4f9, 0x4ece, { 0x84, 0x8a, 0x19, 0x58, 0xfd, 0x31, 0xce, 0xb7 } }\r
 \r
 // {BBF1ACD2-28D8-44ea-A291-58A237FEDF1A}\r
-#define SETUP_VARIABLE_GUID { 0xbbf1acd2, 0x28d8, 0x44ea, { 0xa2, 0x91, 0x58, 0xa2, 0x37, 0xfe, 0xdf, 0x1a } }\r
+#define SETUP_VARIABLE_GUID  { 0xbbf1acd2, 0x28d8, 0x44ea, { 0xa2, 0x91, 0x58, 0xa2, 0x37, 0xfe, 0xdf, 0x1a } }\r
 \r
 #endif //_HII_FORM_VALUES_H_\r
-\r
index 22db5e605c0adb5a315c0ba566134dc336392541..404367f0df2f97c475dd9f92496a32fae76af6fb 100644 (file)
@@ -9,18 +9,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #ifndef _OPAL_PASSWORD_COMMON_H_\r
 #define _OPAL_PASSWORD_COMMON_H_\r
 \r
-#define OPAL_MAX_PASSWORD_SIZE      32\r
+#define OPAL_MAX_PASSWORD_SIZE  32\r
 \r
-#define OPAL_DEVICE_TYPE_UNKNOWN    0x0\r
-#define OPAL_DEVICE_TYPE_ATA        0x1\r
-#define OPAL_DEVICE_TYPE_NVME       0x2\r
+#define OPAL_DEVICE_TYPE_UNKNOWN  0x0\r
+#define OPAL_DEVICE_TYPE_ATA      0x1\r
+#define OPAL_DEVICE_TYPE_NVME     0x2\r
 \r
 typedef struct {\r
-  UINT16            Segment;\r
-  UINT8             Bus;\r
-  UINT8             Device;\r
-  UINT8             Function;\r
-  UINT8             Reserved;\r
+  UINT16    Segment;\r
+  UINT8     Bus;\r
+  UINT8     Device;\r
+  UINT8     Function;\r
+  UINT8     Reserved;\r
 } OPAL_PCI_DEVICE;\r
 \r
 typedef struct {\r
index 4e5e4eaa932d9ba617914c091166e5244d6fdc11..c998b50be5e8b1a27deb0a846587d3b4b967e948 100644 (file)
@@ -8,8 +8,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "OpalPasswordPei.h"\r
 \r
-EFI_GUID mOpalDeviceLockBoxGuid = OPAL_DEVICE_LOCKBOX_GUID;\r
-\r
+EFI_GUID  mOpalDeviceLockBoxGuid = OPAL_DEVICE_LOCKBOX_GUID;\r
 \r
 /**\r
   Send a security protocol command to a device that receives data and/or the result\r
@@ -86,17 +85,17 @@ EFI_GUID mOpalDeviceLockBoxGuid = OPAL_DEVICE_LOCKBOX_GUID;
 EFI_STATUS\r
 EFIAPI\r
 SecurityReceiveData (\r
-  IN  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL    *This,\r
-  IN  UINT32                                   MediaId,\r
-  IN  UINT64                                   Timeout,\r
-  IN  UINT8                                    SecurityProtocolId,\r
-  IN  UINT16                                   SecurityProtocolSpecificData,\r
-  IN  UINTN                                    PayloadBufferSize,\r
-  OUT VOID                                     *PayloadBuffer,\r
-  OUT UINTN                                    *PayloadTransferSize\r
+  IN  EFI_STORAGE_SECURITY_COMMAND_PROTOCOL  *This,\r
+  IN  UINT32                                 MediaId,\r
+  IN  UINT64                                 Timeout,\r
+  IN  UINT8                                  SecurityProtocolId,\r
+  IN  UINT16                                 SecurityProtocolSpecificData,\r
+  IN  UINTN                                  PayloadBufferSize,\r
+  OUT VOID                                   *PayloadBuffer,\r
+  OUT UINTN                                  *PayloadTransferSize\r
   )\r
 {\r
-  OPAL_PEI_DEVICE               *PeiDev;\r
+  OPAL_PEI_DEVICE  *PeiDev;\r
 \r
   PeiDev = OPAL_PEI_DEVICE_FROM_THIS (This);\r
   if (PeiDev == NULL) {\r
@@ -179,16 +178,16 @@ SecurityReceiveData (
 EFI_STATUS\r
 EFIAPI\r
 SecuritySendData (\r
-  IN EFI_STORAGE_SECURITY_COMMAND_PROTOCOL    *This,\r
-  IN UINT32                                   MediaId,\r
-  IN UINT64                                   Timeout,\r
-  IN UINT8                                    SecurityProtocolId,\r
-  IN UINT16                                   SecurityProtocolSpecificData,\r
-  IN UINTN                                    PayloadBufferSize,\r
-  IN VOID                                     *PayloadBuffer\r
+  IN EFI_STORAGE_SECURITY_COMMAND_PROTOCOL  *This,\r
+  IN UINT32                                 MediaId,\r
+  IN UINT64                                 Timeout,\r
+  IN UINT8                                  SecurityProtocolId,\r
+  IN UINT16                                 SecurityProtocolSpecificData,\r
+  IN UINTN                                  PayloadBufferSize,\r
+  IN VOID                                   *PayloadBuffer\r
   )\r
 {\r
-  OPAL_PEI_DEVICE               *PeiDev;\r
+  OPAL_PEI_DEVICE  *PeiDev;\r
 \r
   PeiDev = OPAL_PEI_DEVICE_FROM_THIS (This);\r
   if (PeiDev == NULL) {\r
@@ -217,18 +216,18 @@ SecuritySendData (
 \r
 **/\r
 BOOLEAN\r
-IsOpalDeviceLocked(\r
-  OPAL_PEI_DEVICE    *OpalDev,\r
-  BOOLEAN            *BlockSidSupported\r
+IsOpalDeviceLocked (\r
+  OPAL_PEI_DEVICE  *OpalDev,\r
+  BOOLEAN          *BlockSidSupported\r
   )\r
 {\r
-  OPAL_SESSION                   Session;\r
-  OPAL_DISK_SUPPORT_ATTRIBUTE    SupportedAttributes;\r
-  TCG_LOCKING_FEATURE_DESCRIPTOR LockingFeature;\r
-  UINT16                         OpalBaseComId;\r
-  TCG_RESULT                     Ret;\r
+  OPAL_SESSION                    Session;\r
+  OPAL_DISK_SUPPORT_ATTRIBUTE     SupportedAttributes;\r
+  TCG_LOCKING_FEATURE_DESCRIPTOR  LockingFeature;\r
+  UINT16                          OpalBaseComId;\r
+  TCG_RESULT                      Ret;\r
 \r
-  Session.Sscp = &OpalDev->Sscp;\r
+  Session.Sscp    = &OpalDev->Sscp;\r
   Session.MediaId = 0;\r
 \r
   Ret = OpalGetSupportedAttributesInfo (&Session, &SupportedAttributes, &OpalBaseComId);\r
@@ -236,10 +235,10 @@ IsOpalDeviceLocked(
     return FALSE;\r
   }\r
 \r
-  Session.OpalBaseComId  = OpalBaseComId;\r
-  *BlockSidSupported     = SupportedAttributes.BlockSid == 1 ? TRUE : FALSE;\r
+  Session.OpalBaseComId = OpalBaseComId;\r
+  *BlockSidSupported    = SupportedAttributes.BlockSid == 1 ? TRUE : FALSE;\r
 \r
-  Ret = OpalGetLockingInfo(&Session, &LockingFeature);\r
+  Ret = OpalGetLockingInfo (&Session, &LockingFeature);\r
   if (Ret != TcgResultSuccess) {\r
     return FALSE;\r
   }\r
@@ -255,20 +254,20 @@ IsOpalDeviceLocked(
 **/\r
 VOID\r
 UnlockOpalPassword (\r
-  IN OPAL_PEI_DEVICE            *OpalDev\r
+  IN OPAL_PEI_DEVICE  *OpalDev\r
   )\r
 {\r
-  TCG_RESULT                    Result;\r
-  OPAL_SESSION                  Session;\r
-  BOOLEAN                       BlockSidSupport;\r
-  UINT32                        PpStorageFlags;\r
-  BOOLEAN                       BlockSIDEnabled;\r
+  TCG_RESULT    Result;\r
+  OPAL_SESSION  Session;\r
+  BOOLEAN       BlockSidSupport;\r
+  UINT32        PpStorageFlags;\r
+  BOOLEAN       BlockSIDEnabled;\r
 \r
   BlockSidSupport = FALSE;\r
   if (IsOpalDeviceLocked (OpalDev, &BlockSidSupport)) {\r
-    ZeroMem(&Session, sizeof (Session));\r
-    Session.Sscp = &OpalDev->Sscp;\r
-    Session.MediaId = 0;\r
+    ZeroMem (&Session, sizeof (Session));\r
+    Session.Sscp          = &OpalDev->Sscp;\r
+    Session.MediaId       = 0;\r
     Session.OpalBaseComId = OpalDev->Device->OpalBaseComId;\r
 \r
     Result = OpalUtilUpdateGlobalLockingRange (\r
@@ -292,13 +291,14 @@ UnlockOpalPassword (
   } else {\r
     BlockSIDEnabled = FALSE;\r
   }\r
+\r
   if (BlockSIDEnabled && BlockSidSupport) {\r
     DEBUG ((DEBUG_INFO, "OpalPassword: S3 phase send BlockSid command to device!\n"));\r
-    ZeroMem(&Session, sizeof (Session));\r
-    Session.Sscp = &OpalDev->Sscp;\r
-    Session.MediaId = 0;\r
+    ZeroMem (&Session, sizeof (Session));\r
+    Session.Sscp          = &OpalDev->Sscp;\r
+    Session.MediaId       = 0;\r
     Session.OpalBaseComId = OpalDev->Device->OpalBaseComId;\r
-    Result = OpalBlockSid (&Session, TRUE);\r
+    Result                = OpalBlockSid (&Session, TRUE);\r
     DEBUG ((\r
       DEBUG_INFO,\r
       "%a() OpalBlockSid() Result = 0x%x\n",\r
@@ -316,33 +316,34 @@ UnlockOpalPassword (
 **/\r
 VOID\r
 UnlockOpalPasswordDevices (\r
-  IN EDKII_PEI_STORAGE_SECURITY_CMD_PPI    *SscPpi\r
+  IN EDKII_PEI_STORAGE_SECURITY_CMD_PPI  *SscPpi\r
   )\r
 {\r
-  EFI_STATUS                            Status;\r
-  UINT8                                 *DevInfoBuffer;\r
-  UINT8                                 DummyData;\r
-  OPAL_DEVICE_LOCKBOX_DATA              *DevInfo;\r
-  UINTN                                 DevInfoLength;\r
-  EFI_DEVICE_PATH_PROTOCOL              *SscDevicePath;\r
-  UINTN                                 SscDevicePathLength;\r
-  UINTN                                 SscDeviceNum;\r
-  UINTN                                 SscDeviceIndex;\r
-  OPAL_PEI_DEVICE                       OpalDev;\r
+  EFI_STATUS                Status;\r
+  UINT8                     *DevInfoBuffer;\r
+  UINT8                     DummyData;\r
+  OPAL_DEVICE_LOCKBOX_DATA  *DevInfo;\r
+  UINTN                     DevInfoLength;\r
+  EFI_DEVICE_PATH_PROTOCOL  *SscDevicePath;\r
+  UINTN                     SscDevicePathLength;\r
+  UINTN                     SscDeviceNum;\r
+  UINTN                     SscDeviceIndex;\r
+  OPAL_PEI_DEVICE           OpalDev;\r
 \r
   //\r
   // Get OPAL devices info from LockBox.\r
   //\r
   DevInfoBuffer = &DummyData;\r
   DevInfoLength = sizeof (DummyData);\r
-  Status = RestoreLockBox (&mOpalDeviceLockBoxGuid, DevInfoBuffer, &DevInfoLength);\r
+  Status        = RestoreLockBox (&mOpalDeviceLockBoxGuid, DevInfoBuffer, &DevInfoLength);\r
   if (Status == EFI_BUFFER_TOO_SMALL) {\r
     DevInfoBuffer = AllocatePages (EFI_SIZE_TO_PAGES (DevInfoLength));\r
     if (DevInfoBuffer != NULL) {\r
       Status = RestoreLockBox (&mOpalDeviceLockBoxGuid, DevInfoBuffer, &DevInfoLength);\r
     }\r
   }\r
-  if (DevInfoBuffer == NULL || DevInfoBuffer == &DummyData) {\r
+\r
+  if ((DevInfoBuffer == NULL) || (DevInfoBuffer == &DummyData)) {\r
     return;\r
   } else if (EFI_ERROR (Status)) {\r
     FreePages (DevInfoBuffer, EFI_SIZE_TO_PAGES (DevInfoLength));\r
@@ -356,6 +357,7 @@ UnlockOpalPasswordDevices (
   if (EFI_ERROR (Status)) {\r
     goto Exit;\r
   }\r
+\r
   for (SscDeviceIndex = 1; SscDeviceIndex <= SscDeviceNum; SscDeviceIndex++) {\r
     Status = SscPpi->GetDevicePath (\r
                        SscPpi,\r
@@ -373,9 +375,10 @@ UnlockOpalPasswordDevices (
     //\r
     // Search the device in the restored LockBox.\r
     //\r
-    for (DevInfo = (OPAL_DEVICE_LOCKBOX_DATA *) DevInfoBuffer;\r
-         (UINTN) DevInfo < ((UINTN) DevInfoBuffer + DevInfoLength);\r
-         DevInfo = (OPAL_DEVICE_LOCKBOX_DATA *) ((UINTN) DevInfo + DevInfo->Length)) {\r
+    for (DevInfo = (OPAL_DEVICE_LOCKBOX_DATA *)DevInfoBuffer;\r
+         (UINTN)DevInfo < ((UINTN)DevInfoBuffer + DevInfoLength);\r
+         DevInfo = (OPAL_DEVICE_LOCKBOX_DATA *)((UINTN)DevInfo + DevInfo->Length))\r
+    {\r
       //\r
       // Find the matching device.\r
       //\r
@@ -383,7 +386,9 @@ UnlockOpalPasswordDevices (
           (CompareMem (\r
              DevInfo->DevicePath,\r
              SscDevicePath,\r
-             SscDevicePathLength - sizeof (EFI_DEVICE_PATH_PROTOCOL)) == 0)) {\r
+             SscDevicePathLength - sizeof (EFI_DEVICE_PATH_PROTOCOL)\r
+             ) == 0))\r
+      {\r
         OpalDev.Signature        = OPAL_PEI_DEVICE_SIGNATURE;\r
         OpalDev.Sscp.ReceiveData = SecurityReceiveData;\r
         OpalDev.Sscp.SendData    = SecuritySendData;\r
@@ -400,7 +405,6 @@ UnlockOpalPasswordDevices (
 Exit:\r
   ZeroMem (DevInfoBuffer, DevInfoLength);\r
   FreePages (DevInfoBuffer, EFI_SIZE_TO_PAGES (DevInfoLength));\r
-\r
 }\r
 \r
 /**\r
@@ -418,28 +422,26 @@ Exit:
 EFI_STATUS\r
 EFIAPI\r
 OpalPasswordStorageSecurityPpiNotify (\r
-  IN EFI_PEI_SERVICES             **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR    *NotifyDesc,\r
-  IN VOID                         *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDesc,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
   DEBUG ((DEBUG_INFO, "%a entered at S3 resume!\n", __FUNCTION__));\r
 \r
-  UnlockOpalPasswordDevices ((EDKII_PEI_STORAGE_SECURITY_CMD_PPI *) Ppi);\r
+  UnlockOpalPasswordDevices ((EDKII_PEI_STORAGE_SECURITY_CMD_PPI *)Ppi);\r
 \r
   DEBUG ((DEBUG_INFO, "%a exit at S3 resume!\n", __FUNCTION__));\r
 \r
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
-EFI_PEI_NOTIFY_DESCRIPTOR mOpalPasswordStorageSecurityPpiNotifyDesc = {\r
+EFI_PEI_NOTIFY_DESCRIPTOR  mOpalPasswordStorageSecurityPpiNotifyDesc = {\r
   (EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST),\r
   &gEdkiiPeiStorageSecurityCommandPpiGuid,\r
   OpalPasswordStorageSecurityPpiNotify\r
 };\r
 \r
-\r
 /**\r
   Main entry for this module.\r
 \r
@@ -452,12 +454,12 @@ EFI_PEI_NOTIFY_DESCRIPTOR mOpalPasswordStorageSecurityPpiNotifyDesc = {
 EFI_STATUS\r
 EFIAPI\r
 OpalPasswordPeiInit (\r
-  IN EFI_PEI_FILE_HANDLE        FileHandle,\r
-  IN CONST EFI_PEI_SERVICES     **PeiServices\r
+  IN EFI_PEI_FILE_HANDLE     FileHandle,\r
+  IN CONST EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS       Status;\r
-  EFI_BOOT_MODE    BootMode;\r
+  EFI_STATUS     Status;\r
+  EFI_BOOT_MODE  BootMode;\r
 \r
   Status = PeiServicesGetBootMode (&BootMode);\r
   if ((EFI_ERROR (Status)) || (BootMode != BOOT_ON_S3_RESUME)) {\r
index bd7007094f65dfd9238a53c854e8425857b38b7e..e2b3f416de81f4a67d542a8c1b28f879a648ef27 100644 (file)
@@ -31,16 +31,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "OpalPasswordCommon.h"\r
 \r
-\r
 //\r
 // The generic command timeout value (unit in us) for Storage Security Command\r
 // PPI ReceiveData/SendData services\r
 //\r
-#define SSC_PPI_GENERIC_TIMEOUT                  30000000\r
+#define SSC_PPI_GENERIC_TIMEOUT  30000000\r
 \r
 #pragma pack(1)\r
 \r
-#define OPAL_PEI_DEVICE_SIGNATURE       SIGNATURE_32 ('o', 'p', 'd', 's')\r
+#define OPAL_PEI_DEVICE_SIGNATURE  SIGNATURE_32 ('o', 'p', 'd', 's')\r
 \r
 typedef struct {\r
   UINTN                                    Signature;\r
@@ -57,4 +56,3 @@ typedef struct {
 #pragma pack()\r
 \r
 #endif // _OPAL_PASSWORD_PEI_H_\r
-\r
index 89c1be0417ed6f75c176dd56ea618c4ef7083051..d4bfc6d1e7d9386fde6f4145024ea094014e3ec2 100644 (file)
@@ -27,17 +27,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 BOOLEAN\r
 EFIAPI\r
 LockTpmPhysicalPresence (\r
-  IN CONST  EFI_PEI_SERVICES             **PeiServices\r
+  IN CONST  EFI_PEI_SERVICES  **PeiServices\r
   );\r
 \r
 //\r
 // Global definitions for lock physical presence PPI and its descriptor.\r
 //\r
-PEI_LOCK_PHYSICAL_PRESENCE_PPI    mLockPhysicalPresencePpi = {\r
+PEI_LOCK_PHYSICAL_PRESENCE_PPI  mLockPhysicalPresencePpi = {\r
   LockTpmPhysicalPresence\r
 };\r
 \r
-EFI_PEI_PPI_DESCRIPTOR       mLockPhysicalPresencePpiList = {\r
+EFI_PEI_PPI_DESCRIPTOR  mLockPhysicalPresencePpiList = {\r
   EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,\r
   &gPeiLockPhysicalPresencePpiGuid,\r
   &mLockPhysicalPresencePpi\r
@@ -55,13 +55,13 @@ EFI_PEI_PPI_DESCRIPTOR       mLockPhysicalPresencePpiList = {
 BOOLEAN\r
 EFIAPI\r
 LockTpmPhysicalPresence (\r
-  IN CONST  EFI_PEI_SERVICES             **PeiServices\r
+  IN CONST  EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                         Status;\r
-  EFI_PEI_READ_ONLY_VARIABLE2_PPI    *Variable;\r
-  UINTN                              DataSize;\r
-  EFI_PHYSICAL_PRESENCE              TcgPpData;\r
+  EFI_STATUS                       Status;\r
+  EFI_PEI_READ_ONLY_VARIABLE2_PPI  *Variable;\r
+  UINTN                            DataSize;\r
+  EFI_PHYSICAL_PRESENCE            TcgPpData;\r
 \r
   //\r
   // The CRTM has sensed the physical presence assertion of the user. For example,\r
@@ -85,14 +85,14 @@ LockTpmPhysicalPresence (
              );\r
   if (!EFI_ERROR (Status)) {\r
     DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-    Status = Variable->GetVariable (\r
-                         Variable,\r
-                         PHYSICAL_PRESENCE_VARIABLE,\r
-                         &gEfiPhysicalPresenceGuid,\r
-                         NULL,\r
-                         &DataSize,\r
-                         &TcgPpData\r
-                         );\r
+    Status   = Variable->GetVariable (\r
+                           Variable,\r
+                           PHYSICAL_PRESENCE_VARIABLE,\r
+                           &gEfiPhysicalPresenceGuid,\r
+                           NULL,\r
+                           &DataSize,\r
+                           &TcgPpData\r
+                           );\r
     if (!EFI_ERROR (Status)) {\r
       if (TcgPpData.PPRequest != 0) {\r
         return FALSE;\r
@@ -120,8 +120,8 @@ LockTpmPhysicalPresence (
 EFI_STATUS\r
 EFIAPI\r
 PeimEntry (\r
-  IN       EFI_PEI_FILE_HANDLE       FileHandle,\r
-  IN CONST EFI_PEI_SERVICES          **PeiServices\r
+  IN       EFI_PEI_FILE_HANDLE  FileHandle,\r
+  IN CONST EFI_PEI_SERVICES     **PeiServices\r
   )\r
 {\r
   return PeiServicesInstallPpi (&mLockPhysicalPresencePpiList);\r
index e8844e474a9ba217e71c2d27c886eac777c1441d..e8822cbeb0155b3c1d4c3ee5db7865d2b1235300 100644 (file)
@@ -43,19 +43,19 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Physical Presence Interface Version supported by Platform\r
 //\r
-#define PHYSICAL_PRESENCE_VERSION_TAG                              "$PV"\r
-#define PHYSICAL_PRESENCE_VERSION_SIZE                             4\r
+#define PHYSICAL_PRESENCE_VERSION_TAG   "$PV"\r
+#define PHYSICAL_PRESENCE_VERSION_SIZE  4\r
 \r
 //\r
 // PNP _HID for TPM2 device\r
 //\r
-#define TPM_HID_TAG                                                "NNNN0000"\r
-#define TPM_HID_PNP_SIZE                                           8\r
-#define TPM_HID_ACPI_SIZE                                          9\r
+#define TPM_HID_TAG        "NNNN0000"\r
+#define TPM_HID_PNP_SIZE   8\r
+#define TPM_HID_ACPI_SIZE  9\r
 \r
-#define TPM_PRS_RESL                                               "RESL"\r
-#define TPM_PRS_RESS                                               "RESS"\r
-#define TPM_PRS_RES_NAME_SIZE                                      4\r
+#define TPM_PRS_RESL           "RESL"\r
+#define TPM_PRS_RESS           "RESS"\r
+#define TPM_PRS_RES_NAME_SIZE  4\r
 //\r
 // Minimum PRS resource template size\r
 //  1 byte    for  BufferOp\r
@@ -65,27 +65,27 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //  5 bytes   for  Interrupt descriptor\r
 //  2 bytes   for  END Tag\r
 //\r
-#define TPM_POS_RES_TEMPLATE_MIN_SIZE                              (1 + 1 + 2 + 12 + 5 + 2)\r
+#define TPM_POS_RES_TEMPLATE_MIN_SIZE  (1 + 1 + 2 + 12 + 5 + 2)\r
 \r
 //\r
 // Max Interrupt buffer size for PRS interrupt resource\r
 // Now support 15 interrupts in maxmum\r
 //\r
-#define MAX_PRS_INT_BUF_SIZE                                       (15*4)\r
+#define MAX_PRS_INT_BUF_SIZE  (15*4)\r
 \r
 #pragma pack(1)\r
 \r
 typedef struct {\r
-  EFI_ACPI_DESCRIPTION_HEADER Header;\r
+  EFI_ACPI_DESCRIPTION_HEADER    Header;\r
   // Flags field is replaced in version 4 and above\r
   //    BIT0~15:  PlatformClass      This field is only valid for version 4 and above\r
   //    BIT16~31: Reserved\r
-  UINT32                      Flags;\r
-  UINT64                      AddressOfControlArea;\r
-  UINT32                      StartMethod;\r
-  UINT8                       PlatformSpecificParameters[12];  // size up to 12\r
-  UINT32                      Laml;                          // Optional\r
-  UINT64                      Lasa;                          // Optional\r
+  UINT32                         Flags;\r
+  UINT64                         AddressOfControlArea;\r
+  UINT32                         StartMethod;\r
+  UINT8                          PlatformSpecificParameters[12]; // size up to 12\r
+  UINT32                         Laml;                           // Optional\r
+  UINT64                         Lasa;                           // Optional\r
 } EFI_TPM2_ACPI_TABLE_V4;\r
 \r
 #pragma pack()\r
@@ -102,11 +102,11 @@ EFI_TPM2_ACPI_TABLE_V4  mTpm2AcpiTemplate = {
   },\r
   0, // BIT0~15:  PlatformClass\r
      // BIT16~31: Reserved\r
-  0, // Control Area\r
+  0,                                    // Control Area\r
   EFI_TPM2_ACPI_TABLE_START_METHOD_TIS, // StartMethod\r
 };\r
 \r
-TCG_NVS                    *mTcgNvs;\r
+TCG_NVS  *mTcgNvs;\r
 \r
 /**\r
   Find the operation region in TCG ACPI table by given Name and Size,\r
@@ -121,43 +121,45 @@ TCG_NVS                    *mTcgNvs;
 **/\r
 VOID *\r
 AssignOpRegion (\r
-  EFI_ACPI_DESCRIPTION_HEADER    *Table,\r
-  UINT32                         Name,\r
-  UINT16                         Size\r
+  EFI_ACPI_DESCRIPTION_HEADER  *Table,\r
+  UINT32                       Name,\r
+  UINT16                       Size\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  AML_OP_REGION_32_8             *OpRegion;\r
-  EFI_PHYSICAL_ADDRESS           MemoryAddress;\r
+  EFI_STATUS            Status;\r
+  AML_OP_REGION_32_8    *OpRegion;\r
+  EFI_PHYSICAL_ADDRESS  MemoryAddress;\r
 \r
   MemoryAddress = SIZE_4GB - 1;\r
 \r
   //\r
   // Patch some pointers for the ASL code before loading the SSDT.\r
   //\r
-  for (OpRegion  = (AML_OP_REGION_32_8 *) (Table + 1);\r
-       OpRegion <= (AML_OP_REGION_32_8 *) ((UINT8 *) Table + Table->Length);\r
-       OpRegion  = (AML_OP_REGION_32_8 *) ((UINT8 *) OpRegion + 1)) {\r
+  for (OpRegion  = (AML_OP_REGION_32_8 *)(Table + 1);\r
+       OpRegion <= (AML_OP_REGION_32_8 *)((UINT8 *)Table + Table->Length);\r
+       OpRegion  = (AML_OP_REGION_32_8 *)((UINT8 *)OpRegion + 1))\r
+  {\r
     if ((OpRegion->OpRegionOp  == AML_EXT_REGION_OP) &&\r
         (OpRegion->NameString  == Name) &&\r
         (OpRegion->DWordPrefix == AML_DWORD_PREFIX) &&\r
-        (OpRegion->BytePrefix  == AML_BYTE_PREFIX)) {\r
-\r
-      Status = gBS->AllocatePages(AllocateMaxAddress, EfiACPIMemoryNVS, EFI_SIZE_TO_PAGES (Size), &MemoryAddress);\r
+        (OpRegion->BytePrefix  == AML_BYTE_PREFIX))\r
+    {\r
+      Status = gBS->AllocatePages (AllocateMaxAddress, EfiACPIMemoryNVS, EFI_SIZE_TO_PAGES (Size), &MemoryAddress);\r
       ASSERT_EFI_ERROR (Status);\r
       ZeroMem ((VOID *)(UINTN)MemoryAddress, Size);\r
-      OpRegion->RegionOffset = (UINT32) (UINTN) MemoryAddress;\r
-      OpRegion->RegionLen    = (UINT8) Size;\r
+      OpRegion->RegionOffset = (UINT32)(UINTN)MemoryAddress;\r
+      OpRegion->RegionLen    = (UINT8)Size;\r
       // Request to unblock this region from MM core\r
       Status = MmUnblockMemoryRequest (MemoryAddress, EFI_SIZE_TO_PAGES (Size));\r
-      if (Status != EFI_UNSUPPORTED && EFI_ERROR (Status)) {\r
+      if ((Status != EFI_UNSUPPORTED) && EFI_ERROR (Status)) {\r
         ASSERT_EFI_ERROR (Status);\r
       }\r
+\r
       break;\r
     }\r
   }\r
 \r
-  return (VOID *) (UINTN) MemoryAddress;\r
+  return (VOID *)(UINTN)MemoryAddress;\r
 }\r
 \r
 /**\r
@@ -172,17 +174,17 @@ AssignOpRegion (
 EFI_STATUS\r
 EFIAPI\r
 ExchangeCommonBuffer (\r
-  IN OUT  TCG_NVS                 *TcgNvs\r
-)\r
+  IN OUT  TCG_NVS  *TcgNvs\r
+  )\r
 {\r
-  EFI_STATUS                                Status;\r
-  EFI_MM_COMMUNICATION_PROTOCOL             *MmCommunication;\r
-  EDKII_PI_SMM_COMMUNICATION_REGION_TABLE   *PiSmmCommunicationRegionTable;\r
-  EFI_MEMORY_DESCRIPTOR                     *MmCommMemRegion;\r
-  EFI_MM_COMMUNICATE_HEADER                 *CommHeader;\r
-  TPM_NVS_MM_COMM_BUFFER                    *CommBuffer;\r
-  UINTN                                     CommBufferSize;\r
-  UINTN                                     Index;\r
+  EFI_STATUS                               Status;\r
+  EFI_MM_COMMUNICATION_PROTOCOL            *MmCommunication;\r
+  EDKII_PI_SMM_COMMUNICATION_REGION_TABLE  *PiSmmCommunicationRegionTable;\r
+  EFI_MEMORY_DESCRIPTOR                    *MmCommMemRegion;\r
+  EFI_MM_COMMUNICATE_HEADER                *CommHeader;\r
+  TPM_NVS_MM_COMM_BUFFER                   *CommBuffer;\r
+  UINTN                                    CommBufferSize;\r
+  UINTN                                    Index;\r
 \r
   // Step 0: Sanity check for input argument\r
   if (TcgNvs == NULL) {\r
@@ -191,15 +193,15 @@ ExchangeCommonBuffer (
   }\r
 \r
   // Step 1: Grab the common buffer header\r
-  Status = EfiGetSystemConfigurationTable (&gEdkiiPiSmmCommunicationRegionTableGuid, (VOID**) &PiSmmCommunicationRegionTable);\r
+  Status = EfiGetSystemConfigurationTable (&gEdkiiPiSmmCommunicationRegionTableGuid, (VOID **)&PiSmmCommunicationRegionTable);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "%a - Failed to locate SMM communciation common buffer - %r!\n", __FUNCTION__, Status));\r
     return Status;\r
   }\r
 \r
   // Step 2: Grab one that is large enough to hold TPM_NVS_MM_COMM_BUFFER, the IPL one should be sufficient\r
-  CommBufferSize = 0;\r
-  MmCommMemRegion = (EFI_MEMORY_DESCRIPTOR*) (PiSmmCommunicationRegionTable + 1);\r
+  CommBufferSize  = 0;\r
+  MmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *)(PiSmmCommunicationRegionTable + 1);\r
   for (Index = 0; Index < PiSmmCommunicationRegionTable->NumberOfEntries; Index++) {\r
     if (MmCommMemRegion->Type == EfiConventionalMemory) {\r
       CommBufferSize = EFI_PAGES_TO_SIZE ((UINTN)MmCommMemRegion->NumberOfPages);\r
@@ -207,7 +209,8 @@ ExchangeCommonBuffer (
         break;\r
       }\r
     }\r
-    MmCommMemRegion = (EFI_MEMORY_DESCRIPTOR*)((UINT8*)MmCommMemRegion + PiSmmCommunicationRegionTable->DescriptorSize);\r
+\r
+    MmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *)((UINT8 *)MmCommMemRegion + PiSmmCommunicationRegionTable->DescriptorSize);\r
   }\r
 \r
   if (Index >= PiSmmCommunicationRegionTable->NumberOfEntries) {\r
@@ -218,24 +221,23 @@ ExchangeCommonBuffer (
 \r
   // Step 3: Start to populate contents\r
   // Step 3.1: MM Communication common header\r
-  CommHeader = (EFI_MM_COMMUNICATE_HEADER *) (UINTN) MmCommMemRegion->PhysicalStart;\r
+  CommHeader     = (EFI_MM_COMMUNICATE_HEADER *)(UINTN)MmCommMemRegion->PhysicalStart;\r
   CommBufferSize = sizeof (TPM_NVS_MM_COMM_BUFFER) + OFFSET_OF (EFI_MM_COMMUNICATE_HEADER, Data);\r
   ZeroMem (CommHeader, CommBufferSize);\r
   CopyGuid (&CommHeader->HeaderGuid, &gTpmNvsMmGuid);\r
   CommHeader->MessageLength = sizeof (TPM_NVS_MM_COMM_BUFFER);\r
 \r
   // Step 3.2: TPM_NVS_MM_COMM_BUFFER content per our needs\r
-  CommBuffer = (TPM_NVS_MM_COMM_BUFFER *) (CommHeader->Data);\r
-  CommBuffer->Function = TpmNvsMmExchangeInfo;\r
-  CommBuffer->TargetAddress = (EFI_PHYSICAL_ADDRESS) (UINTN) TcgNvs;\r
+  CommBuffer                = (TPM_NVS_MM_COMM_BUFFER *)(CommHeader->Data);\r
+  CommBuffer->Function      = TpmNvsMmExchangeInfo;\r
+  CommBuffer->TargetAddress = (EFI_PHYSICAL_ADDRESS)(UINTN)TcgNvs;\r
 \r
   // Step 4: Locate the protocol and signal Mmi.\r
-  Status = gBS->LocateProtocol (&gEfiMmCommunicationProtocolGuid, NULL, (VOID**) &MmCommunication);\r
+  Status = gBS->LocateProtocol (&gEfiMmCommunicationProtocolGuid, NULL, (VOID **)&MmCommunication);\r
   if (!EFI_ERROR (Status)) {\r
     Status = MmCommunication->Communicate (MmCommunication, CommHeader, &CommBufferSize);\r
     DEBUG ((DEBUG_INFO, "%a - Communicate() = %r\n", __FUNCTION__, Status));\r
-  }\r
-  else {\r
+  } else {\r
     DEBUG ((DEBUG_ERROR, "%a - Failed to locate MmCommunication protocol - %r\n", __FUNCTION__, Status));\r
     return Status;\r
   }\r
@@ -243,8 +245,8 @@ ExchangeCommonBuffer (
   // Step 5: If everything goes well, populate the channel number\r
   if (!EFI_ERROR (CommBuffer->ReturnStatus)) {\r
     // Need to demote to UINT8 according to SMI value definition\r
-    TcgNvs->PhysicalPresence.SoftwareSmi = (UINT8) CommBuffer->RegisteredPpSwiValue;\r
-    TcgNvs->MemoryClear.SoftwareSmi = (UINT8) CommBuffer->RegisteredMcSwiValue;\r
+    TcgNvs->PhysicalPresence.SoftwareSmi = (UINT8)CommBuffer->RegisteredPpSwiValue;\r
+    TcgNvs->MemoryClear.SoftwareSmi      = (UINT8)CommBuffer->RegisteredMcSwiValue;\r
     DEBUG ((\r
       DEBUG_INFO,\r
       "%a Communication returned software SMI value. PP: 0x%x; MC: 0x%x.\n",\r
@@ -254,7 +256,7 @@ ExchangeCommonBuffer (
       ));\r
   }\r
 \r
-  return (EFI_STATUS) CommBuffer->ReturnStatus;\r
+  return (EFI_STATUS)CommBuffer->ReturnStatus;\r
 }\r
 \r
 /**\r
@@ -269,8 +271,8 @@ ACPI table is "$PV".
 **/\r
 EFI_STATUS\r
 UpdatePPVersion (\r
-  EFI_ACPI_DESCRIPTION_HEADER    *Table,\r
-  CHAR8                          *PPVer\r
+  EFI_ACPI_DESCRIPTION_HEADER  *Table,\r
+  CHAR8                        *PPVer\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -280,11 +282,12 @@ UpdatePPVersion (
   // Patch some pointers for the ASL code before loading the SSDT.\r
   //\r
   for (DataPtr  = (UINT8 *)(Table + 1);\r
-       DataPtr <= (UINT8 *) ((UINT8 *) Table + Table->Length - PHYSICAL_PRESENCE_VERSION_SIZE);\r
-       DataPtr += 1) {\r
-    if (AsciiStrCmp((CHAR8 *)DataPtr,  PHYSICAL_PRESENCE_VERSION_TAG) == 0) {\r
-      Status = AsciiStrCpyS((CHAR8 *)DataPtr, PHYSICAL_PRESENCE_VERSION_SIZE, PPVer);\r
-      DEBUG((DEBUG_INFO, "TPM2 Physical Presence Interface Version update status 0x%x\n", Status));\r
+       DataPtr <= (UINT8 *)((UINT8 *)Table + Table->Length - PHYSICAL_PRESENCE_VERSION_SIZE);\r
+       DataPtr += 1)\r
+  {\r
+    if (AsciiStrCmp ((CHAR8 *)DataPtr, PHYSICAL_PRESENCE_VERSION_TAG) == 0) {\r
+      Status = AsciiStrCpyS ((CHAR8 *)DataPtr, PHYSICAL_PRESENCE_VERSION_SIZE, PPVer);\r
+      DEBUG ((DEBUG_INFO, "TPM2 Physical Presence Interface Version update status 0x%x\n", Status));\r
       return Status;\r
     }\r
   }\r
@@ -306,16 +309,16 @@ UpdatePPVersion (
 **/\r
 EFI_STATUS\r
 UpdatePossibleResource (\r
-  IN OUT  EFI_ACPI_DESCRIPTION_HEADER    *Table,\r
-  IN      UINT32                         *IrqBuffer,\r
-  IN      UINT32                         IrqBuffserSize,\r
-  OUT     BOOLEAN                        *IsShortFormPkgLength\r
+  IN OUT  EFI_ACPI_DESCRIPTION_HEADER  *Table,\r
+  IN      UINT32                       *IrqBuffer,\r
+  IN      UINT32                       IrqBuffserSize,\r
+  OUT     BOOLEAN                      *IsShortFormPkgLength\r
   )\r
 {\r
-  UINT8       *DataPtr;\r
-  UINT8       *DataEndPtr;\r
-  UINT32      NewPkgLength;\r
-  UINT32      OrignalPkgLength;\r
+  UINT8   *DataPtr;\r
+  UINT8   *DataEndPtr;\r
+  UINT32  NewPkgLength;\r
+  UINT32  OrignalPkgLength;\r
 \r
   NewPkgLength     = 0;\r
   OrignalPkgLength = 0;\r
@@ -345,24 +348,25 @@ UpdatePossibleResource (
   //                               <bit 5-4: Only used if PkgLength <= 63 >\r
   //                               <bit 3-0: Least significant package length nybble>\r
   //\r
-  //==============BufferSize==================\r
+  // ==============BufferSize==================\r
   //        BufferSize := Integer\r
   //           Integer := ByteConst|WordConst|DwordConst....\r
   //\r
   //           ByteConst := BytePrefix ByteData\r
   //\r
-  //==============ByteList===================\r
+  // ==============ByteList===================\r
   //          ByteList := ByteData ByteList\r
   //\r
-  //=========================================\r
+  // =========================================\r
 \r
   //\r
   // 1. Check TPM_PRS_RESS with PkgLength <=63 can hold the input interrupt number buffer for patching\r
   //\r
   for (DataPtr  = (UINT8 *)(Table + 1);\r
-       DataPtr < (UINT8 *) ((UINT8 *) Table + Table->Length - (TPM_PRS_RES_NAME_SIZE + TPM_POS_RES_TEMPLATE_MIN_SIZE));\r
-       DataPtr += 1) {\r
-    if (CompareMem(DataPtr, TPM_PRS_RESS, TPM_PRS_RES_NAME_SIZE) == 0) {\r
+       DataPtr < (UINT8 *)((UINT8 *)Table + Table->Length - (TPM_PRS_RES_NAME_SIZE + TPM_POS_RES_TEMPLATE_MIN_SIZE));\r
+       DataPtr += 1)\r
+  {\r
+    if (CompareMem (DataPtr, TPM_PRS_RESS, TPM_PRS_RES_NAME_SIZE) == 0) {\r
       //\r
       // Jump over object name & BufferOp\r
       //\r
@@ -387,11 +391,11 @@ UpdatePossibleResource (
         } else if (*(DataPtr + 1) == AML_DWORD_PREFIX) {\r
           NewPkgLength += 5;\r
         } else {\r
-          ASSERT(FALSE);\r
+          ASSERT (FALSE);\r
           return EFI_UNSUPPORTED;\r
         }\r
       } else {\r
-        ASSERT(FALSE);\r
+        ASSERT (FALSE);\r
         return EFI_UNSUPPORTED;\r
       }\r
 \r
@@ -404,7 +408,7 @@ UpdatePossibleResource (
       }\r
 \r
       if (NewPkgLength > OrignalPkgLength) {\r
-        ASSERT(FALSE);\r
+        ASSERT (FALSE);\r
         return EFI_INVALID_PARAMETER;\r
       }\r
 \r
@@ -435,9 +439,10 @@ UpdatePossibleResource (
     NewPkgLength     = 0;\r
     OrignalPkgLength = 0;\r
     for (DataPtr  = (UINT8 *)(Table + 1);\r
-         DataPtr < (UINT8 *) ((UINT8 *) Table + Table->Length - (TPM_PRS_RES_NAME_SIZE + TPM_POS_RES_TEMPLATE_MIN_SIZE));\r
-         DataPtr += 1) {\r
-      if (CompareMem(DataPtr, TPM_PRS_RESL, TPM_PRS_RES_NAME_SIZE) == 0) {\r
+         DataPtr < (UINT8 *)((UINT8 *)Table + Table->Length - (TPM_PRS_RES_NAME_SIZE + TPM_POS_RES_TEMPLATE_MIN_SIZE));\r
+         DataPtr += 1)\r
+    {\r
+      if (CompareMem (DataPtr, TPM_PRS_RESL, TPM_PRS_RES_NAME_SIZE) == 0) {\r
         //\r
         // Jump over object name & BufferOp\r
         //\r
@@ -461,11 +466,11 @@ UpdatePossibleResource (
           } else if (*(DataPtr + NewPkgLength) == AML_DWORD_PREFIX) {\r
             NewPkgLength += 5;\r
           } else {\r
-            ASSERT(FALSE);\r
+            ASSERT (FALSE);\r
             return EFI_UNSUPPORTED;\r
           }\r
         } else {\r
-          ASSERT(FALSE);\r
+          ASSERT (FALSE);\r
           return EFI_UNSUPPORTED;\r
         }\r
 \r
@@ -475,14 +480,14 @@ UpdatePossibleResource (
         NewPkgLength += 19 + IrqBuffserSize;\r
 \r
         if (NewPkgLength > OrignalPkgLength) {\r
-          ASSERT(FALSE);\r
+          ASSERT (FALSE);\r
           return EFI_INVALID_PARAMETER;\r
         }\r
 \r
         //\r
         // 2.1 Patch PkgLength. Only patch PkgLeadByte and first ByteData\r
         //\r
-        *DataPtr = (UINT8)((*DataPtr) & 0xF0) | (NewPkgLength & 0x0F);\r
+        *DataPtr       = (UINT8)((*DataPtr) & 0xF0) | (NewPkgLength & 0x0F);\r
         *(DataPtr + 1) = (UINT8)((NewPkgLength & 0xFF0) >> 4);\r
 \r
         //\r
@@ -500,7 +505,7 @@ UpdatePossibleResource (
     }\r
   }\r
 \r
-  if (DataPtr >= (UINT8 *) ((UINT8 *) Table + Table->Length - (TPM_PRS_RES_NAME_SIZE + TPM_POS_RES_TEMPLATE_MIN_SIZE))) {\r
+  if (DataPtr >= (UINT8 *)((UINT8 *)Table + Table->Length - (TPM_PRS_RES_NAME_SIZE + TPM_POS_RES_TEMPLATE_MIN_SIZE))) {\r
     return EFI_NOT_FOUND;\r
   }\r
 \r
@@ -516,11 +521,11 @@ UpdatePossibleResource (
   //\r
   //   3.2 Patch Interrupt Table Length\r
   //\r
-  *(DataPtr + 4) = (UINT8)(IrqBuffserSize / sizeof(UINT32));\r
+  *(DataPtr + 4) = (UINT8)(IrqBuffserSize / sizeof (UINT32));\r
   //\r
   //   3.3 Copy patched InterruptNumBuffer\r
   //\r
-  CopyMem(DataPtr + 5, IrqBuffer, IrqBuffserSize);\r
+  CopyMem (DataPtr + 5, IrqBuffer, IrqBuffserSize);\r
 \r
   //\r
   // 4. Jump over Interrupt descriptor and Patch END Tag, set Checksum field to 0\r
@@ -534,7 +539,7 @@ UpdatePossibleResource (
   //\r
   DataPtr += 2;\r
   if (DataPtr < DataEndPtr) {\r
-    SetMem(DataPtr, (UINTN)DataEndPtr - (UINTN)DataPtr, AML_NOOP_OP);\r
+    SetMem (DataPtr, (UINTN)DataEndPtr - (UINTN)DataPtr, AML_NOOP_OP);\r
   }\r
 \r
   return EFI_SUCCESS;\r
@@ -550,7 +555,7 @@ UpdatePossibleResource (
 **/\r
 EFI_STATUS\r
 UpdateHID (\r
-  EFI_ACPI_DESCRIPTION_HEADER    *Table\r
+  EFI_ACPI_DESCRIPTION_HEADER  *Table\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -566,54 +571,53 @@ UpdateHID (
   //\r
   // Initialize HID with Default PNP string\r
   //\r
-  ZeroMem(Hid, TPM_HID_ACPI_SIZE);\r
+  ZeroMem (Hid, TPM_HID_ACPI_SIZE);\r
 \r
   //\r
   // Get Manufacturer ID\r
   //\r
-  Status = Tpm2GetCapabilityManufactureID(&ManufacturerID);\r
-  if (!EFI_ERROR(Status)) {\r
-    DEBUG((DEBUG_INFO, "TPM_PT_MANUFACTURER 0x%08x\n", ManufacturerID));\r
+  Status = Tpm2GetCapabilityManufactureID (&ManufacturerID);\r
+  if (!EFI_ERROR (Status)) {\r
+    DEBUG ((DEBUG_INFO, "TPM_PT_MANUFACTURER 0x%08x\n", ManufacturerID));\r
     //\r
     // ManufacturerID defined in TCG Vendor ID Registry\r
     // may tailed with 0x00 or 0x20\r
     //\r
-    if ((ManufacturerID >> 24) == 0x00 || ((ManufacturerID >> 24) == 0x20)) {\r
+    if (((ManufacturerID >> 24) == 0x00) || ((ManufacturerID >> 24) == 0x20)) {\r
       //\r
       //  HID containing PNP ID "NNN####"\r
       //   NNN is uppercase letter for Vendor ID specified by manufacturer\r
       //\r
-      CopyMem(Hid, &ManufacturerID, 3);\r
+      CopyMem (Hid, &ManufacturerID, 3);\r
     } else {\r
       //\r
       //  HID containing ACP ID "NNNN####"\r
       //   NNNN is uppercase letter for Vendor ID specified by manufacturer\r
       //\r
-      CopyMem(Hid, &ManufacturerID, 4);\r
+      CopyMem (Hid, &ManufacturerID, 4);\r
       PnpHID = FALSE;\r
     }\r
   } else {\r
     DEBUG ((DEBUG_ERROR, "Get TPM_PT_MANUFACTURER failed %x!\n", Status));\r
-    ASSERT(FALSE);\r
+    ASSERT (FALSE);\r
     return Status;\r
   }\r
 \r
-  Status = Tpm2GetCapabilityFirmwareVersion(&FirmwareVersion1, &FirmwareVersion2);\r
-  if (!EFI_ERROR(Status)) {\r
-    DEBUG((DEBUG_INFO, "TPM_PT_FIRMWARE_VERSION_1 0x%x\n", FirmwareVersion1));\r
-    DEBUG((DEBUG_INFO, "TPM_PT_FIRMWARE_VERSION_2 0x%x\n", FirmwareVersion2));\r
+  Status = Tpm2GetCapabilityFirmwareVersion (&FirmwareVersion1, &FirmwareVersion2);\r
+  if (!EFI_ERROR (Status)) {\r
+    DEBUG ((DEBUG_INFO, "TPM_PT_FIRMWARE_VERSION_1 0x%x\n", FirmwareVersion1));\r
+    DEBUG ((DEBUG_INFO, "TPM_PT_FIRMWARE_VERSION_2 0x%x\n", FirmwareVersion2));\r
     //\r
     //   #### is Firmware Version 1\r
     //\r
     if (PnpHID) {\r
-      AsciiSPrint(Hid + 3, TPM_HID_PNP_SIZE - 3, "%02d%02d", ((FirmwareVersion1 & 0xFFFF0000) >> 16), (FirmwareVersion1 & 0x0000FFFF));\r
+      AsciiSPrint (Hid + 3, TPM_HID_PNP_SIZE - 3, "%02d%02d", ((FirmwareVersion1 & 0xFFFF0000) >> 16), (FirmwareVersion1 & 0x0000FFFF));\r
     } else {\r
-      AsciiSPrint(Hid + 4, TPM_HID_ACPI_SIZE - 4, "%02d%02d", ((FirmwareVersion1 & 0xFFFF0000) >> 16), (FirmwareVersion1 & 0x0000FFFF));\r
+      AsciiSPrint (Hid + 4, TPM_HID_ACPI_SIZE - 4, "%02d%02d", ((FirmwareVersion1 & 0xFFFF0000) >> 16), (FirmwareVersion1 & 0x0000FFFF));\r
     }\r
-\r
   } else {\r
     DEBUG ((DEBUG_ERROR, "Get TPM_PT_FIRMWARE_VERSION_X failed %x!\n", Status));\r
-    ASSERT(FALSE);\r
+    ASSERT (FALSE);\r
     return Status;\r
   }\r
 \r
@@ -621,26 +625,27 @@ UpdateHID (
   // Patch HID in ASL code before loading the SSDT.\r
   //\r
   for (DataPtr  = (UINT8 *)(Table + 1);\r
-       DataPtr <= (UINT8 *) ((UINT8 *) Table + Table->Length - TPM_HID_PNP_SIZE);\r
-       DataPtr += 1) {\r
-    if (AsciiStrCmp((CHAR8 *)DataPtr,  TPM_HID_TAG) == 0) {\r
+       DataPtr <= (UINT8 *)((UINT8 *)Table + Table->Length - TPM_HID_PNP_SIZE);\r
+       DataPtr += 1)\r
+  {\r
+    if (AsciiStrCmp ((CHAR8 *)DataPtr, TPM_HID_TAG) == 0) {\r
       if (PnpHID) {\r
-        CopyMem(DataPtr, Hid, TPM_HID_PNP_SIZE);\r
+        CopyMem (DataPtr, Hid, TPM_HID_PNP_SIZE);\r
         //\r
         // if HID is PNP ID, patch the last byte in HID TAG to Noop\r
         //\r
         *(DataPtr + TPM_HID_PNP_SIZE) = AML_NOOP_OP;\r
       } else {\r
-\r
-        CopyMem(DataPtr, Hid, TPM_HID_ACPI_SIZE);\r
+        CopyMem (DataPtr, Hid, TPM_HID_ACPI_SIZE);\r
       }\r
-      DEBUG((DEBUG_INFO, "TPM2 ACPI _HID is patched to %a\n", DataPtr));\r
+\r
+      DEBUG ((DEBUG_INFO, "TPM2 ACPI _HID is patched to %a\n", DataPtr));\r
 \r
       return Status;\r
     }\r
   }\r
 \r
-  DEBUG((DEBUG_ERROR, "TPM2 ACPI HID TAG for patch not found!\n"));\r
+  DEBUG ((DEBUG_ERROR, "TPM2 ACPI HID TAG for patch not found!\n"));\r
   return EFI_NOT_FOUND;\r
 }\r
 \r
@@ -656,14 +661,14 @@ PublishAcpiTable (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  EFI_ACPI_TABLE_PROTOCOL        *AcpiTable;\r
-  UINTN                          TableKey;\r
-  EFI_ACPI_DESCRIPTION_HEADER    *Table;\r
-  UINTN                          TableSize;\r
-  UINT32                         *PossibleIrqNumBuf;\r
-  UINT32                         PossibleIrqNumBufSize;\r
-  BOOLEAN                        IsShortFormPkgLength;\r
+  EFI_STATUS                   Status;\r
+  EFI_ACPI_TABLE_PROTOCOL      *AcpiTable;\r
+  UINTN                        TableKey;\r
+  EFI_ACPI_DESCRIPTION_HEADER  *Table;\r
+  UINTN                        TableSize;\r
+  UINT32                       *PossibleIrqNumBuf;\r
+  UINT32                       PossibleIrqNumBufSize;\r
+  BOOLEAN                      IsShortFormPkgLength;\r
 \r
   IsShortFormPkgLength = FALSE;\r
 \r
@@ -671,7 +676,7 @@ PublishAcpiTable (
              &gEfiCallerIdGuid,\r
              EFI_SECTION_RAW,\r
              0,\r
-             (VOID **) &Table,\r
+             (VOID **)&Table,\r
              &TableSize\r
              );\r
   ASSERT_EFI_ERROR (Status);\r
@@ -682,7 +687,7 @@ PublishAcpiTable (
   // Otherwise, the PCR record would be different after TPM FW update\r
   // or the PCD configuration change.\r
   //\r
-  TpmMeasureAndLogData(\r
+  TpmMeasureAndLogData (\r
     0,\r
     EV_POST_CODE,\r
     EV_POSTCODE_INFO_ACPI_DATA,\r
@@ -694,32 +699,32 @@ PublishAcpiTable (
   //\r
   // Update Table version before measuring it to PCR\r
   //\r
-  Status = UpdatePPVersion(Table, (CHAR8 *)PcdGetPtr(PcdTcgPhysicalPresenceInterfaceVer));\r
+  Status = UpdatePPVersion (Table, (CHAR8 *)PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer));\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   DEBUG ((\r
     DEBUG_INFO,\r
     "Current physical presence interface version - %a\n",\r
-    (CHAR8 *) PcdGetPtr(PcdTcgPhysicalPresenceInterfaceVer)\r
+    (CHAR8 *)PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer)\r
     ));\r
 \r
   //\r
   // Update TPM2 HID after measuring it to PCR\r
   //\r
-  Status = UpdateHID(Table);\r
-  if (EFI_ERROR(Status)) {\r
+  Status = UpdateHID (Table);\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  if (PcdGet32(PcdTpm2CurrentIrqNum) != 0) {\r
+  if (PcdGet32 (PcdTpm2CurrentIrqNum) != 0) {\r
     //\r
     // Patch _PRS interrupt resource only when TPM interrupt is supported\r
     //\r
-    PossibleIrqNumBuf     = (UINT32 *)PcdGetPtr(PcdTpm2PossibleIrqNumBuf);\r
-    PossibleIrqNumBufSize = (UINT32)PcdGetSize(PcdTpm2PossibleIrqNumBuf);\r
+    PossibleIrqNumBuf     = (UINT32 *)PcdGetPtr (PcdTpm2PossibleIrqNumBuf);\r
+    PossibleIrqNumBufSize = (UINT32)PcdGetSize (PcdTpm2PossibleIrqNumBuf);\r
 \r
-    if (PossibleIrqNumBufSize <= MAX_PRS_INT_BUF_SIZE && (PossibleIrqNumBufSize % sizeof(UINT32)) == 0) {\r
-      Status = UpdatePossibleResource(Table, PossibleIrqNumBuf, PossibleIrqNumBufSize, &IsShortFormPkgLength);\r
+    if ((PossibleIrqNumBufSize <= MAX_PRS_INT_BUF_SIZE) && ((PossibleIrqNumBufSize % sizeof (UINT32)) == 0)) {\r
+      Status = UpdatePossibleResource (Table, PossibleIrqNumBuf, PossibleIrqNumBufSize, &IsShortFormPkgLength);\r
       DEBUG ((\r
         DEBUG_INFO,\r
         "UpdatePossibleResource status - %x. TPM2 service may not ready in OS.\n",\r
@@ -730,15 +735,15 @@ PublishAcpiTable (
         DEBUG_INFO,\r
         "PcdTpm2PossibleIrqNumBuf size %x is not correct. TPM2 service may not ready in OS.\n",\r
         PossibleIrqNumBufSize\r
-      ));\r
+        ));\r
     }\r
   }\r
 \r
   ASSERT (Table->OemTableId == SIGNATURE_64 ('T', 'p', 'm', '2', 'T', 'a', 'b', 'l'));\r
-  CopyMem (Table->OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (Table->OemId) );\r
-  mTcgNvs = AssignOpRegion (Table, SIGNATURE_32 ('T', 'N', 'V', 'S'), (UINT16) sizeof (TCG_NVS));\r
+  CopyMem (Table->OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (Table->OemId));\r
+  mTcgNvs = AssignOpRegion (Table, SIGNATURE_32 ('T', 'N', 'V', 'S'), (UINT16)sizeof (TCG_NVS));\r
   ASSERT (mTcgNvs != NULL);\r
-  mTcgNvs->TpmIrqNum            = PcdGet32(PcdTpm2CurrentIrqNum);\r
+  mTcgNvs->TpmIrqNum            = PcdGet32 (PcdTpm2CurrentIrqNum);\r
   mTcgNvs->IsShortFormPkgLength = IsShortFormPkgLength;\r
 \r
   Status = ExchangeCommonBuffer (mTcgNvs);\r
@@ -746,16 +751,16 @@ PublishAcpiTable (
   //\r
   // Publish the TPM ACPI table. Table is re-checksummed.\r
   //\r
-  Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **) &AcpiTable);\r
+  Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **)&AcpiTable);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   TableKey = 0;\r
-  Status = AcpiTable->InstallAcpiTable (\r
-                        AcpiTable,\r
-                        Table,\r
-                        TableSize,\r
-                        &TableKey\r
-                        );\r
+  Status   = AcpiTable->InstallAcpiTable (\r
+                          AcpiTable,\r
+                          Table,\r
+                          TableSize,\r
+                          &TableKey\r
+                          );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   return Status;\r
@@ -773,12 +778,12 @@ PublishTpm2 (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  EFI_ACPI_TABLE_PROTOCOL        *AcpiTable;\r
-  UINTN                          TableKey;\r
-  UINT64                         OemTableId;\r
-  EFI_TPM2_ACPI_CONTROL_AREA     *ControlArea;\r
-  TPM2_PTP_INTERFACE_TYPE        InterfaceType;\r
+  EFI_STATUS                  Status;\r
+  EFI_ACPI_TABLE_PROTOCOL     *AcpiTable;\r
+  UINTN                       TableKey;\r
+  UINT64                      OemTableId;\r
+  EFI_TPM2_ACPI_CONTROL_AREA  *ControlArea;\r
+  TPM2_PTP_INTERFACE_TYPE     InterfaceType;\r
 \r
   //\r
   // Measure to PCR[0] with event EV_POST_CODE ACPI DATA.\r
@@ -786,7 +791,7 @@ PublishTpm2 (
   // Otherwise, the PCR record would be different after event log update\r
   // or the PCD configuration change.\r
   //\r
-  TpmMeasureAndLogData(\r
+  TpmMeasureAndLogData (\r
     0,\r
     EV_POST_CODE,\r
     EV_POSTCODE_INFO_ACPI_DATA,\r
@@ -795,8 +800,8 @@ PublishTpm2 (
     mTpm2AcpiTemplate.Header.Length\r
     );\r
 \r
-  mTpm2AcpiTemplate.Header.Revision = PcdGet8(PcdTpm2AcpiTableRev);\r
-  DEBUG((DEBUG_INFO, "Tpm2 ACPI table revision is %d\n", mTpm2AcpiTemplate.Header.Revision));\r
+  mTpm2AcpiTemplate.Header.Revision = PcdGet8 (PcdTpm2AcpiTableRev);\r
+  DEBUG ((DEBUG_INFO, "Tpm2 ACPI table revision is %d\n", mTpm2AcpiTemplate.Header.Revision));\r
 \r
   //\r
   // PlatformClass is only valid for version 4 and above\r
@@ -804,50 +809,51 @@ PublishTpm2 (
   //    BIT16~31: Reserved\r
   //\r
   if (mTpm2AcpiTemplate.Header.Revision >= EFI_TPM2_ACPI_TABLE_REVISION_4) {\r
-    mTpm2AcpiTemplate.Flags = (mTpm2AcpiTemplate.Flags & 0xFFFF0000) | PcdGet8(PcdTpmPlatformClass);\r
-    DEBUG((DEBUG_INFO, "Tpm2 ACPI table PlatformClass is %d\n", (mTpm2AcpiTemplate.Flags & 0x0000FFFF)));\r
+    mTpm2AcpiTemplate.Flags = (mTpm2AcpiTemplate.Flags & 0xFFFF0000) | PcdGet8 (PcdTpmPlatformClass);\r
+    DEBUG ((DEBUG_INFO, "Tpm2 ACPI table PlatformClass is %d\n", (mTpm2AcpiTemplate.Flags & 0x0000FFFF)));\r
   }\r
 \r
-  mTpm2AcpiTemplate.Laml = PcdGet32(PcdTpm2AcpiTableLaml);\r
-  mTpm2AcpiTemplate.Lasa = PcdGet64(PcdTpm2AcpiTableLasa);\r
+  mTpm2AcpiTemplate.Laml = PcdGet32 (PcdTpm2AcpiTableLaml);\r
+  mTpm2AcpiTemplate.Lasa = PcdGet64 (PcdTpm2AcpiTableLasa);\r
   if ((mTpm2AcpiTemplate.Header.Revision < EFI_TPM2_ACPI_TABLE_REVISION_4) ||\r
-      (mTpm2AcpiTemplate.Laml == 0) || (mTpm2AcpiTemplate.Lasa == 0)) {\r
+      (mTpm2AcpiTemplate.Laml == 0) || (mTpm2AcpiTemplate.Lasa == 0))\r
+  {\r
     //\r
     // If version is smaller than 4 or Laml/Lasa is not valid, rollback to original Length.\r
     //\r
-    mTpm2AcpiTemplate.Header.Length = sizeof(EFI_TPM2_ACPI_TABLE);\r
+    mTpm2AcpiTemplate.Header.Length = sizeof (EFI_TPM2_ACPI_TABLE);\r
   }\r
 \r
-  InterfaceType = PcdGet8(PcdActiveTpmInterfaceType);\r
+  InterfaceType = PcdGet8 (PcdActiveTpmInterfaceType);\r
   switch (InterfaceType) {\r
-  case Tpm2PtpInterfaceCrb:\r
-    mTpm2AcpiTemplate.StartMethod = EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_INTERFACE;\r
-    mTpm2AcpiTemplate.AddressOfControlArea = PcdGet64 (PcdTpmBaseAddress) + 0x40;\r
-    ControlArea = (EFI_TPM2_ACPI_CONTROL_AREA *)(UINTN)mTpm2AcpiTemplate.AddressOfControlArea;\r
-    ControlArea->CommandSize  = 0xF80;\r
-    ControlArea->ResponseSize = 0xF80;\r
-    ControlArea->Command      = PcdGet64 (PcdTpmBaseAddress) + 0x80;\r
-    ControlArea->Response     = PcdGet64 (PcdTpmBaseAddress) + 0x80;\r
-    break;\r
-  case Tpm2PtpInterfaceFifo:\r
-  case Tpm2PtpInterfaceTis:\r
-    break;\r
-  default:\r
-    DEBUG((DEBUG_ERROR, "TPM2 InterfaceType get error! %d\n", InterfaceType));\r
-    break;\r
+    case Tpm2PtpInterfaceCrb:\r
+      mTpm2AcpiTemplate.StartMethod          = EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_INTERFACE;\r
+      mTpm2AcpiTemplate.AddressOfControlArea = PcdGet64 (PcdTpmBaseAddress) + 0x40;\r
+      ControlArea                            = (EFI_TPM2_ACPI_CONTROL_AREA *)(UINTN)mTpm2AcpiTemplate.AddressOfControlArea;\r
+      ControlArea->CommandSize               = 0xF80;\r
+      ControlArea->ResponseSize              = 0xF80;\r
+      ControlArea->Command                   = PcdGet64 (PcdTpmBaseAddress) + 0x80;\r
+      ControlArea->Response                  = PcdGet64 (PcdTpmBaseAddress) + 0x80;\r
+      break;\r
+    case Tpm2PtpInterfaceFifo:\r
+    case Tpm2PtpInterfaceTis:\r
+      break;\r
+    default:\r
+      DEBUG ((DEBUG_ERROR, "TPM2 InterfaceType get error! %d\n", InterfaceType));\r
+      break;\r
   }\r
 \r
   CopyMem (mTpm2AcpiTemplate.Header.OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (mTpm2AcpiTemplate.Header.OemId));\r
   OemTableId = PcdGet64 (PcdAcpiDefaultOemTableId);\r
   CopyMem (&mTpm2AcpiTemplate.Header.OemTableId, &OemTableId, sizeof (UINT64));\r
-  mTpm2AcpiTemplate.Header.OemRevision      = PcdGet32 (PcdAcpiDefaultOemRevision);\r
-  mTpm2AcpiTemplate.Header.CreatorId        = PcdGet32 (PcdAcpiDefaultCreatorId);\r
-  mTpm2AcpiTemplate.Header.CreatorRevision  = PcdGet32 (PcdAcpiDefaultCreatorRevision);\r
+  mTpm2AcpiTemplate.Header.OemRevision     = PcdGet32 (PcdAcpiDefaultOemRevision);\r
+  mTpm2AcpiTemplate.Header.CreatorId       = PcdGet32 (PcdAcpiDefaultCreatorId);\r
+  mTpm2AcpiTemplate.Header.CreatorRevision = PcdGet32 (PcdAcpiDefaultCreatorRevision);\r
 \r
   //\r
   // Construct ACPI table\r
   //\r
-  Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **) &AcpiTable);\r
+  Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **)&AcpiTable);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   Status = AcpiTable->InstallAcpiTable (\r
@@ -877,13 +883,13 @@ PublishTpm2 (
 EFI_STATUS\r
 EFIAPI\r
 InitializeTcgAcpi (\r
-  IN EFI_HANDLE                  ImageHandle,\r
-  IN EFI_SYSTEM_TABLE            *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
+  EFI_STATUS  Status;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm20DtpmGuid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm20DtpmGuid)) {\r
     DEBUG ((DEBUG_ERROR, "No TPM2 DTPM instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -899,4 +905,3 @@ InitializeTcgAcpi (
 \r
   return EFI_SUCCESS;\r
 }\r
-\r
index fca5ae2645c141932e090144ed1b2033a7a6523b..edf5f0fc77cae40063d4ac1520caee9d90f09a5c 100644 (file)
@@ -20,38 +20,42 @@ extern TPM_INSTANCE_ID  mTpmInstanceId[TPM_DEVICE_MAX + 1];
 **/\r
 VOID\r
 UpdateDefaultPCRBanks (\r
-  IN VOID                           *HiiPackage,\r
-  IN UINTN                          HiiPackageSize,\r
-  IN UINT32                         PCRBanks\r
+  IN VOID    *HiiPackage,\r
+  IN UINTN   HiiPackageSize,\r
+  IN UINT32  PCRBanks\r
   )\r
 {\r
-  EFI_HII_PACKAGE_HEADER        *HiiPackageHeader;\r
-  EFI_IFR_OP_HEADER             *IfrOpCodeHeader;\r
-  EFI_IFR_CHECKBOX              *IfrCheckBox;\r
-  EFI_IFR_DEFAULT               *IfrDefault;\r
+  EFI_HII_PACKAGE_HEADER  *HiiPackageHeader;\r
+  EFI_IFR_OP_HEADER       *IfrOpCodeHeader;\r
+  EFI_IFR_CHECKBOX        *IfrCheckBox;\r
+  EFI_IFR_DEFAULT         *IfrDefault;\r
 \r
   HiiPackageHeader = (EFI_HII_PACKAGE_HEADER *)HiiPackage;\r
 \r
   switch (HiiPackageHeader->Type) {\r
-  case EFI_HII_PACKAGE_FORMS:\r
-    IfrOpCodeHeader = (EFI_IFR_OP_HEADER *)(HiiPackageHeader + 1);\r
-    while ((UINTN)IfrOpCodeHeader < (UINTN)HiiPackageHeader + HiiPackageHeader->Length) {\r
-      switch (IfrOpCodeHeader->OpCode) {\r
-      case EFI_IFR_CHECKBOX_OP:\r
-        IfrCheckBox = (EFI_IFR_CHECKBOX *)IfrOpCodeHeader;\r
-        if ((IfrCheckBox->Question.QuestionId >= KEY_TPM2_PCR_BANKS_REQUEST_0) && (IfrCheckBox->Question.QuestionId <= KEY_TPM2_PCR_BANKS_REQUEST_4)) {\r
-          IfrDefault = (EFI_IFR_DEFAULT *)(IfrCheckBox + 1);\r
-          ASSERT (IfrDefault->Header.OpCode == EFI_IFR_DEFAULT_OP);\r
-          ASSERT (IfrDefault->Type == EFI_IFR_TYPE_BOOLEAN);\r
-          IfrDefault->Value.b = (BOOLEAN)((PCRBanks >> (IfrCheckBox->Question.QuestionId - KEY_TPM2_PCR_BANKS_REQUEST_0)) & 0x1);\r
+    case EFI_HII_PACKAGE_FORMS:\r
+      IfrOpCodeHeader = (EFI_IFR_OP_HEADER *)(HiiPackageHeader + 1);\r
+      while ((UINTN)IfrOpCodeHeader < (UINTN)HiiPackageHeader + HiiPackageHeader->Length) {\r
+        switch (IfrOpCodeHeader->OpCode) {\r
+          case EFI_IFR_CHECKBOX_OP:\r
+            IfrCheckBox = (EFI_IFR_CHECKBOX *)IfrOpCodeHeader;\r
+            if ((IfrCheckBox->Question.QuestionId >= KEY_TPM2_PCR_BANKS_REQUEST_0) && (IfrCheckBox->Question.QuestionId <= KEY_TPM2_PCR_BANKS_REQUEST_4)) {\r
+              IfrDefault = (EFI_IFR_DEFAULT *)(IfrCheckBox + 1);\r
+              ASSERT (IfrDefault->Header.OpCode == EFI_IFR_DEFAULT_OP);\r
+              ASSERT (IfrDefault->Type == EFI_IFR_TYPE_BOOLEAN);\r
+              IfrDefault->Value.b = (BOOLEAN)((PCRBanks >> (IfrCheckBox->Question.QuestionId - KEY_TPM2_PCR_BANKS_REQUEST_0)) & 0x1);\r
+            }\r
+\r
+            break;\r
         }\r
-        break;\r
+\r
+        IfrOpCodeHeader = (EFI_IFR_OP_HEADER *)((UINTN)IfrOpCodeHeader + IfrOpCodeHeader->Length);\r
       }\r
-      IfrOpCodeHeader = (EFI_IFR_OP_HEADER *)((UINTN)IfrOpCodeHeader + IfrOpCodeHeader->Length);\r
-    }\r
-    break;\r
+\r
+      break;\r
   }\r
-  return ;\r
+\r
+  return;\r
 }\r
 \r
 /**\r
@@ -67,16 +71,16 @@ UpdateDefaultPCRBanks (
 **/\r
 VOID\r
 InitializeTcg2VersionInfo (\r
-  IN TCG2_CONFIG_PRIVATE_DATA   *PrivateData\r
+  IN TCG2_CONFIG_PRIVATE_DATA  *PrivateData\r
   )\r
 {\r
-  EFI_STATUS                    Status;\r
-  EFI_STRING                    ConfigRequestHdr;\r
-  BOOLEAN                       ActionFlag;\r
-  TCG2_VERSION                  Tcg2Version;\r
-  UINTN                         DataSize;\r
-  UINT64                        PcdTcg2PpiVersion;\r
-  UINT8                         PcdTpm2AcpiTableRev;\r
+  EFI_STATUS    Status;\r
+  EFI_STRING    ConfigRequestHdr;\r
+  BOOLEAN       ActionFlag;\r
+  TCG2_VERSION  Tcg2Version;\r
+  UINTN         DataSize;\r
+  UINT64        PcdTcg2PpiVersion;\r
+  UINT8         PcdTpm2AcpiTableRev;\r
 \r
   //\r
   // Get the PCD value before initializing efi varstore configuration data.\r
@@ -85,7 +89,7 @@ InitializeTcg2VersionInfo (
   CopyMem (\r
     &PcdTcg2PpiVersion,\r
     PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer),\r
-    AsciiStrSize ((CHAR8 *) PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))\r
+    AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))\r
     );\r
 \r
   PcdTpm2AcpiTableRev = PcdGet8 (PcdTpm2AcpiTableRev);\r
@@ -101,13 +105,13 @@ InitializeTcg2VersionInfo (
                        );\r
   ASSERT (ConfigRequestHdr != NULL);\r
   DataSize = sizeof (Tcg2Version);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_VERSION_NAME,\r
-                  &gTcg2ConfigFormSetGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &Tcg2Version\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_VERSION_NAME,\r
+                    &gTcg2ConfigFormSetGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &Tcg2Version\r
+                    );\r
   if (!EFI_ERROR (Status)) {\r
     //\r
     // EFI variable does exist and validate current setting.\r
@@ -123,13 +127,13 @@ InitializeTcg2VersionInfo (
       // Get the default values from variable.\r
       //\r
       DataSize = sizeof (Tcg2Version);\r
-      Status = gRT->GetVariable (\r
-                      TCG2_VERSION_NAME,\r
-                      &gTcg2ConfigFormSetGuid,\r
-                      NULL,\r
-                      &DataSize,\r
-                      &Tcg2Version\r
-                      );\r
+      Status   = gRT->GetVariable (\r
+                        TCG2_VERSION_NAME,\r
+                        &gTcg2ConfigFormSetGuid,\r
+                        NULL,\r
+                        &DataSize,\r
+                        &Tcg2Version\r
+                        );\r
       ASSERT_EFI_ERROR (Status);\r
     }\r
   } else {\r
@@ -160,24 +164,26 @@ InitializeTcg2VersionInfo (
       // Get the default values from variable.\r
       //\r
       DataSize = sizeof (Tcg2Version);\r
-      Status = gRT->GetVariable (\r
-                      TCG2_VERSION_NAME,\r
-                      &gTcg2ConfigFormSetGuid,\r
-                      NULL,\r
-                      &DataSize,\r
-                      &Tcg2Version\r
-                      );\r
+      Status   = gRT->GetVariable (\r
+                        TCG2_VERSION_NAME,\r
+                        &gTcg2ConfigFormSetGuid,\r
+                        NULL,\r
+                        &DataSize,\r
+                        &Tcg2Version\r
+                        );\r
       ASSERT_EFI_ERROR (Status);\r
       if (PcdTcg2PpiVersion != Tcg2Version.PpiVersion) {\r
         DEBUG ((DEBUG_WARN, "WARNING: PcdTcgPhysicalPresenceInterfaceVer default value is not same with the default value in VFR\n"));\r
         DEBUG ((DEBUG_WARN, "WARNING: The default value in VFR has be chosen\n"));\r
       }\r
+\r
       if (PcdTpm2AcpiTableRev != Tcg2Version.Tpm2AcpiTableRev) {\r
         DEBUG ((DEBUG_WARN, "WARNING: PcdTpm2AcpiTableRev default value is not same with the default value in VFR\n"));\r
         DEBUG ((DEBUG_WARN, "WARNING: The default value in VFR has be chosen\n"));\r
       }\r
     }\r
   }\r
+\r
   FreePool (ConfigRequestHdr);\r
 \r
   //\r
@@ -189,7 +195,7 @@ InitializeTcg2VersionInfo (
   CopyMem (\r
     &PcdTcg2PpiVersion,\r
     PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer),\r
-    AsciiStrSize ((CHAR8 *) PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))\r
+    AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))\r
     );\r
   if (PcdTcg2PpiVersion != Tcg2Version.PpiVersion) {\r
     DEBUG ((DEBUG_WARN, "WARNING: PcdTcgPhysicalPresenceInterfaceVer is not DynamicHii type and does not map to TCG2_VERSION.PpiVersion\n"));\r
@@ -247,8 +253,8 @@ InitializeTcg2VersionInfo (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2ConfigDriverEntryPoint (\r
-  IN EFI_HANDLE          ImageHandle,\r
-  IN EFI_SYSTEM_TABLE    *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   EFI_STATUS                    Status;\r
@@ -289,36 +295,36 @@ Tcg2ConfigDriverEntryPoint (
                   );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **) &PrivateData->Tcg2Protocol);\r
+  Status = gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **)&PrivateData->Tcg2Protocol);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  PrivateData->ProtocolCapability.Size = sizeof(PrivateData->ProtocolCapability);\r
-  Status = PrivateData->Tcg2Protocol->GetCapability (\r
-                                        PrivateData->Tcg2Protocol,\r
-                                        &PrivateData->ProtocolCapability\r
-                                        );\r
+  PrivateData->ProtocolCapability.Size = sizeof (PrivateData->ProtocolCapability);\r
+  Status                               = PrivateData->Tcg2Protocol->GetCapability (\r
+                                                                      PrivateData->Tcg2Protocol,\r
+                                                                      &PrivateData->ProtocolCapability\r
+                                                                      );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  DataSize = sizeof(Tcg2Configuration);\r
-  Status = gRT->GetVariable (\r
-                  TCG2_STORAGE_NAME,\r
-                  &gTcg2ConfigFormSetGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &Tcg2Configuration\r
-                  );\r
+  DataSize = sizeof (Tcg2Configuration);\r
+  Status   = gRT->GetVariable (\r
+                    TCG2_STORAGE_NAME,\r
+                    &gTcg2ConfigFormSetGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &Tcg2Configuration\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     //\r
     // Variable not ready, set default value\r
     //\r
-    Tcg2Configuration.TpmDevice           = TPM_DEVICE_DEFAULT;\r
+    Tcg2Configuration.TpmDevice = TPM_DEVICE_DEFAULT;\r
   }\r
 \r
   //\r
   // Validation\r
   //\r
   if ((Tcg2Configuration.TpmDevice > TPM_DEVICE_MAX) || (Tcg2Configuration.TpmDevice < TPM_DEVICE_MIN)) {\r
-    Tcg2Configuration.TpmDevice   = TPM_DEVICE_DEFAULT;\r
+    Tcg2Configuration.TpmDevice = TPM_DEVICE_DEFAULT;\r
   }\r
 \r
   //\r
@@ -328,21 +334,21 @@ Tcg2ConfigDriverEntryPoint (
   Status = PrivateData->Tcg2Protocol->GetActivePcrBanks (PrivateData->Tcg2Protocol, &CurrentActivePCRBanks);\r
   ASSERT_EFI_ERROR (Status);\r
   PrivateData->PCRBanksDesired = CurrentActivePCRBanks;\r
-  UpdateDefaultPCRBanks (Tcg2ConfigBin + sizeof(UINT32), ReadUnaligned32((UINT32 *)Tcg2ConfigBin) - sizeof(UINT32), CurrentActivePCRBanks);\r
+  UpdateDefaultPCRBanks (Tcg2ConfigBin + sizeof (UINT32), ReadUnaligned32 ((UINT32 *)Tcg2ConfigBin) - sizeof (UINT32), CurrentActivePCRBanks);\r
 \r
   //\r
   // Sync data from PCD to variable, so that we do not need detect again in S3 phase.\r
   //\r
   Tcg2DeviceDetection.TpmDeviceDetected = TPM_DEVICE_NULL;\r
-  for (Index = 0; Index < sizeof(mTpmInstanceId)/sizeof(mTpmInstanceId[0]); Index++) {\r
-    if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &mTpmInstanceId[Index].TpmInstanceGuid)) {\r
+  for (Index = 0; Index < sizeof (mTpmInstanceId)/sizeof (mTpmInstanceId[0]); Index++) {\r
+    if (CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &mTpmInstanceId[Index].TpmInstanceGuid)) {\r
       Tcg2DeviceDetection.TpmDeviceDetected = mTpmInstanceId[Index].TpmDevice;\r
       break;\r
     }\r
   }\r
 \r
   PrivateData->TpmDeviceDetected = Tcg2DeviceDetection.TpmDeviceDetected;\r
-  Tcg2Configuration.TpmDevice = Tcg2DeviceDetection.TpmDeviceDetected;\r
+  Tcg2Configuration.TpmDevice    = Tcg2DeviceDetection.TpmDeviceDetected;\r
 \r
   //\r
   // Save to variable so platform driver can get it.\r
@@ -351,7 +357,7 @@ Tcg2ConfigDriverEntryPoint (
                   TCG2_DEVICE_DETECTION_NAME,\r
                   &gTcg2ConfigFormSetGuid,\r
                   EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,\r
-                  sizeof(Tcg2DeviceDetection),\r
+                  sizeof (Tcg2DeviceDetection),\r
                   &Tcg2DeviceDetection\r
                   );\r
   if (EFI_ERROR (Status)) {\r
@@ -373,7 +379,7 @@ Tcg2ConfigDriverEntryPoint (
                   TCG2_STORAGE_NAME,\r
                   &gTcg2ConfigFormSetGuid,\r
                   EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,\r
-                  sizeof(Tcg2Configuration),\r
+                  sizeof (Tcg2Configuration),\r
                   &Tcg2Configuration\r
                   );\r
   if (EFI_ERROR (Status)) {\r
@@ -428,13 +434,13 @@ Tcg2ConfigDriverUnload (
   IN EFI_HANDLE  ImageHandle\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  TCG2_CONFIG_PRIVATE_DATA    *PrivateData;\r
+  EFI_STATUS                Status;\r
+  TCG2_CONFIG_PRIVATE_DATA  *PrivateData;\r
 \r
   Status = gBS->HandleProtocol (\r
                   ImageHandle,\r
                   &gEfiCallerIdGuid,\r
-                  (VOID **) &PrivateData\r
+                  (VOID **)&PrivateData\r
                   );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
index a7446ef2f69d05c9ac2dda13f24a76bbda10a435..6eb04c0144487372679031a111d9e951b3b7f975 100644 (file)
@@ -18,12 +18,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include <IndustryStandard/TpmPtp.h>\r
 \r
-#define EFI_TCG2_EVENT_LOG_FORMAT_ALL   (EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2 | EFI_TCG2_EVENT_LOG_FORMAT_TCG_2)\r
+#define EFI_TCG2_EVENT_LOG_FORMAT_ALL  (EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2 | EFI_TCG2_EVENT_LOG_FORMAT_TCG_2)\r
 \r
 TPM_INSTANCE_ID  mTpmInstanceId[TPM_DEVICE_MAX + 1] = TPM_INSTANCE_ID_LIST;\r
 \r
-TCG2_CONFIG_PRIVATE_DATA         *mTcg2ConfigPrivateDate;\r
-TCG2_CONFIG_PRIVATE_DATA         mTcg2ConfigPrivateDateTemplate = {\r
+TCG2_CONFIG_PRIVATE_DATA  *mTcg2ConfigPrivateDate;\r
+TCG2_CONFIG_PRIVATE_DATA  mTcg2ConfigPrivateDateTemplate = {\r
   TCG2_CONFIG_PRIVATE_DATA_SIGNATURE,\r
   {\r
     Tcg2ExtractConfig,\r
@@ -32,14 +32,14 @@ TCG2_CONFIG_PRIVATE_DATA         mTcg2ConfigPrivateDateTemplate = {
   }\r
 };\r
 \r
-HII_VENDOR_DEVICE_PATH          mTcg2HiiVendorDevicePath = {\r
+HII_VENDOR_DEVICE_PATH  mTcg2HiiVendorDevicePath = {\r
   {\r
     {\r
       HARDWARE_DEVICE_PATH,\r
       HW_VENDOR_DP,\r
       {\r
-        (UINT8) (sizeof (VENDOR_DEVICE_PATH)),\r
-        (UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
+        (UINT8)(sizeof (VENDOR_DEVICE_PATH)),\r
+        (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
       }\r
     },\r
     TCG2_CONFIG_FORM_SET_GUID\r
@@ -48,8 +48,8 @@ HII_VENDOR_DEVICE_PATH          mTcg2HiiVendorDevicePath = {
     END_DEVICE_PATH_TYPE,\r
     END_ENTIRE_DEVICE_PATH_SUBTYPE,\r
     {\r
-      (UINT8) (END_DEVICE_PATH_LENGTH),\r
-      (UINT8) ((END_DEVICE_PATH_LENGTH) >> 8)\r
+      (UINT8)(END_DEVICE_PATH_LENGTH),\r
+      (UINT8)((END_DEVICE_PATH_LENGTH) >> 8)\r
     }\r
   }\r
 };\r
@@ -66,7 +66,7 @@ UINT8  mCurrentPpRequest;
 **/\r
 BOOLEAN\r
 IsPtpCrbSupported (\r
-  IN VOID                 *Register\r
+  IN VOID  *Register\r
   )\r
 {\r
   PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;\r
@@ -78,9 +78,11 @@ IsPtpCrbSupported (
 \r
   if (((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_CRB) ||\r
        (InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_FIFO)) &&\r
-      (InterfaceId.Bits.CapCRB != 0)) {\r
+      (InterfaceId.Bits.CapCRB != 0))\r
+  {\r
     return TRUE;\r
   }\r
+\r
   return FALSE;\r
 }\r
 \r
@@ -94,7 +96,7 @@ IsPtpCrbSupported (
 **/\r
 BOOLEAN\r
 IsPtpFifoSupported (\r
-  IN VOID                 *Register\r
+  IN VOID  *Register\r
   )\r
 {\r
   PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;\r
@@ -106,9 +108,11 @@ IsPtpFifoSupported (
 \r
   if (((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_CRB) ||\r
        (InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_FIFO)) &&\r
-      (InterfaceId.Bits.CapFIFO != 0)) {\r
+      (InterfaceId.Bits.CapFIFO != 0))\r
+  {\r
     return TRUE;\r
   }\r
+\r
   return FALSE;\r
 }\r
 \r
@@ -126,40 +130,44 @@ IsPtpFifoSupported (
 **/\r
 EFI_STATUS\r
 SetPtpInterface (\r
-  IN VOID                 *Register,\r
-  IN UINT8                PtpInterface\r
+  IN VOID   *Register,\r
+  IN UINT8  PtpInterface\r
   )\r
 {\r
   TPM2_PTP_INTERFACE_TYPE       PtpInterfaceCurrent;\r
   PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;\r
 \r
-  PtpInterfaceCurrent = PcdGet8(PcdActiveTpmInterfaceType);\r
+  PtpInterfaceCurrent = PcdGet8 (PcdActiveTpmInterfaceType);\r
   if ((PtpInterfaceCurrent != Tpm2PtpInterfaceFifo) &&\r
-      (PtpInterfaceCurrent != Tpm2PtpInterfaceCrb)) {\r
+      (PtpInterfaceCurrent != Tpm2PtpInterfaceCrb))\r
+  {\r
     return EFI_UNSUPPORTED;\r
   }\r
+\r
   InterfaceId.Uint32 = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);\r
   if (InterfaceId.Bits.IntfSelLock != 0) {\r
     return EFI_WRITE_PROTECTED;\r
   }\r
 \r
   switch (PtpInterface) {\r
-  case Tpm2PtpInterfaceFifo:\r
-    if (InterfaceId.Bits.CapFIFO == 0) {\r
-      return EFI_UNSUPPORTED;\r
-    }\r
-    InterfaceId.Bits.InterfaceSelector = PTP_INTERFACE_IDENTIFIER_INTERFACE_SELECTOR_FIFO;\r
-    MmioWrite32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId, InterfaceId.Uint32);\r
-    return EFI_SUCCESS;\r
-  case Tpm2PtpInterfaceCrb:\r
-    if (InterfaceId.Bits.CapCRB == 0) {\r
-      return EFI_UNSUPPORTED;\r
-    }\r
-    InterfaceId.Bits.InterfaceSelector = PTP_INTERFACE_IDENTIFIER_INTERFACE_SELECTOR_CRB;\r
-    MmioWrite32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId, InterfaceId.Uint32);\r
-    return EFI_SUCCESS;\r
-  default:\r
-    return EFI_INVALID_PARAMETER;\r
+    case Tpm2PtpInterfaceFifo:\r
+      if (InterfaceId.Bits.CapFIFO == 0) {\r
+        return EFI_UNSUPPORTED;\r
+      }\r
+\r
+      InterfaceId.Bits.InterfaceSelector = PTP_INTERFACE_IDENTIFIER_INTERFACE_SELECTOR_FIFO;\r
+      MmioWrite32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId, InterfaceId.Uint32);\r
+      return EFI_SUCCESS;\r
+    case Tpm2PtpInterfaceCrb:\r
+      if (InterfaceId.Bits.CapCRB == 0) {\r
+        return EFI_UNSUPPORTED;\r
+      }\r
+\r
+      InterfaceId.Bits.InterfaceSelector = PTP_INTERFACE_IDENTIFIER_INTERFACE_SELECTOR_CRB;\r
+      MmioWrite32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId, InterfaceId.Uint32);\r
+      return EFI_SUCCESS;\r
+    default:\r
+      return EFI_INVALID_PARAMETER;\r
   }\r
 }\r
 \r
@@ -192,13 +200,13 @@ SetPtpInterface (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2ExtractConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL        *This,\r
-  IN CONST EFI_STRING                            Request,\r
-       OUT EFI_STRING                            *Progress,\r
-       OUT EFI_STRING                            *Results\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Request,\r
+  OUT EFI_STRING                           *Progress,\r
+  OUT EFI_STRING                           *Results\r
   )\r
 {\r
-  if (Progress == NULL || Results == NULL) {\r
+  if ((Progress == NULL) || (Results == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -217,7 +225,7 @@ Tcg2ExtractConfig (
 **/\r
 EFI_STATUS\r
 SaveTcg2PpRequest (\r
-  IN UINT8                         PpRequest\r
+  IN UINT8  PpRequest\r
   )\r
 {\r
   UINT32      ReturnCode;\r
@@ -226,7 +234,7 @@ SaveTcg2PpRequest (
   ReturnCode = Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction (PpRequest, 0);\r
   if (ReturnCode == TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) {\r
     mCurrentPpRequest = PpRequest;\r
-    Status = EFI_SUCCESS;\r
+    Status            = EFI_SUCCESS;\r
   } else if (ReturnCode == TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
   } else if (ReturnCode == TCG_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED) {\r
@@ -249,7 +257,7 @@ SaveTcg2PpRequest (
 **/\r
 EFI_STATUS\r
 SaveTcg2PpRequestParameter (\r
-  IN UINT32                        PpRequestParameter\r
+  IN UINT32  PpRequestParameter\r
   )\r
 {\r
   UINT32      ReturnCode;\r
@@ -281,8 +289,8 @@ SaveTcg2PpRequestParameter (
 **/\r
 EFI_STATUS\r
 SaveTcg2PCRBanksRequest (\r
-  IN UINTN   PCRBankIndex,\r
-  IN BOOLEAN Enable\r
+  IN UINTN    PCRBankIndex,\r
+  IN BOOLEAN  Enable\r
   )\r
 {\r
   UINT32      ReturnCode;\r
@@ -329,12 +337,12 @@ SaveTcg2PCRBanksRequest (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2RouteConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN CONST EFI_STRING                          Configuration,\r
-       OUT EFI_STRING                          *Progress\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Configuration,\r
+  OUT EFI_STRING                           *Progress\r
   )\r
 {\r
-  if (Configuration == NULL || Progress == NULL) {\r
+  if ((Configuration == NULL) || (Progress == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -353,9 +361,9 @@ Tcg2RouteConfig (
 \r
 **/\r
 EFI_STATUS\r
-GetTpm2HID(\r
-   CHAR8 *Hid,\r
-   UINTN  Size\r
+GetTpm2HID (\r
+  CHAR8  *Hid,\r
+  UINTN  Size\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -366,54 +374,53 @@ GetTpm2HID(
 \r
   PnpHID = TRUE;\r
 \r
-  ZeroMem(Hid, Size);\r
+  ZeroMem (Hid, Size);\r
 \r
   //\r
   // Get Manufacturer ID\r
   //\r
-  Status = Tpm2GetCapabilityManufactureID(&ManufacturerID);\r
-  if (!EFI_ERROR(Status)) {\r
-    DEBUG((DEBUG_INFO, "TPM_PT_MANUFACTURER 0x%08x\n", ManufacturerID));\r
+  Status = Tpm2GetCapabilityManufactureID (&ManufacturerID);\r
+  if (!EFI_ERROR (Status)) {\r
+    DEBUG ((DEBUG_INFO, "TPM_PT_MANUFACTURER 0x%08x\n", ManufacturerID));\r
     //\r
     // ManufacturerID defined in TCG Vendor ID Registry\r
     // may tailed with 0x00 or 0x20\r
     //\r
-    if ((ManufacturerID >> 24) == 0x00 || ((ManufacturerID >> 24) == 0x20)) {\r
+    if (((ManufacturerID >> 24) == 0x00) || ((ManufacturerID >> 24) == 0x20)) {\r
       //\r
       //  HID containing PNP ID "NNN####"\r
       //   NNN is uppercase letter for Vendor ID specified by manufacturer\r
       //\r
-      CopyMem(Hid, &ManufacturerID, 3);\r
+      CopyMem (Hid, &ManufacturerID, 3);\r
     } else {\r
       //\r
       //  HID containing ACP ID "NNNN####"\r
       //   NNNN is uppercase letter for Vendor ID specified by manufacturer\r
       //\r
-      CopyMem(Hid, &ManufacturerID, 4);\r
+      CopyMem (Hid, &ManufacturerID, 4);\r
       PnpHID = FALSE;\r
     }\r
   } else {\r
     DEBUG ((DEBUG_ERROR, "Get TPM_PT_MANUFACTURER failed %x!\n", Status));\r
-    ASSERT(FALSE);\r
+    ASSERT (FALSE);\r
     return Status;\r
   }\r
 \r
-  Status = Tpm2GetCapabilityFirmwareVersion(&FirmwareVersion1, &FirmwareVersion2);\r
-  if (!EFI_ERROR(Status)) {\r
-    DEBUG((DEBUG_INFO, "TPM_PT_FIRMWARE_VERSION_1 0x%x\n", FirmwareVersion1));\r
-    DEBUG((DEBUG_INFO, "TPM_PT_FIRMWARE_VERSION_2 0x%x\n", FirmwareVersion2));\r
+  Status = Tpm2GetCapabilityFirmwareVersion (&FirmwareVersion1, &FirmwareVersion2);\r
+  if (!EFI_ERROR (Status)) {\r
+    DEBUG ((DEBUG_INFO, "TPM_PT_FIRMWARE_VERSION_1 0x%x\n", FirmwareVersion1));\r
+    DEBUG ((DEBUG_INFO, "TPM_PT_FIRMWARE_VERSION_2 0x%x\n", FirmwareVersion2));\r
     //\r
     //   #### is Firmware Version 1\r
     //\r
     if (PnpHID) {\r
-      AsciiSPrint(Hid + 3, TPM_HID_PNP_SIZE - 3, "%02d%02d", ((FirmwareVersion1 & 0xFFFF0000) >> 16), (FirmwareVersion1 & 0x0000FFFF));\r
+      AsciiSPrint (Hid + 3, TPM_HID_PNP_SIZE - 3, "%02d%02d", ((FirmwareVersion1 & 0xFFFF0000) >> 16), (FirmwareVersion1 & 0x0000FFFF));\r
     } else {\r
-      AsciiSPrint(Hid + 4, TPM_HID_ACPI_SIZE - 4, "%02d%02d", ((FirmwareVersion1 & 0xFFFF0000) >> 16), (FirmwareVersion1 & 0x0000FFFF));\r
+      AsciiSPrint (Hid + 4, TPM_HID_ACPI_SIZE - 4, "%02d%02d", ((FirmwareVersion1 & 0xFFFF0000) >> 16), (FirmwareVersion1 & 0x0000FFFF));\r
     }\r
-\r
   } else {\r
     DEBUG ((DEBUG_ERROR, "Get TPM_PT_FIRMWARE_VERSION_X failed %x!\n", Status));\r
-    ASSERT(FALSE);\r
+    ASSERT (FALSE);\r
     return Status;\r
   }\r
 \r
@@ -438,15 +445,15 @@ GetTpm2HID(
 **/\r
 EFI_STATUS\r
 Tcg2VersionInfoCallback (\r
-  IN EFI_BROWSER_ACTION         Action,\r
-  IN EFI_QUESTION_ID            QuestionId,\r
-  IN UINT8                      Type,\r
-  IN EFI_IFR_TYPE_VALUE         *Value\r
+  IN EFI_BROWSER_ACTION  Action,\r
+  IN EFI_QUESTION_ID     QuestionId,\r
+  IN UINT8               Type,\r
+  IN EFI_IFR_TYPE_VALUE  *Value\r
   )\r
 {\r
-  EFI_INPUT_KEY                 Key;\r
-  UINT64                        PcdTcg2PpiVersion;\r
-  UINT8                         PcdTpm2AcpiTableRev;\r
+  EFI_INPUT_KEY  Key;\r
+  UINT64         PcdTcg2PpiVersion;\r
+  UINT8          PcdTpm2AcpiTableRev;\r
 \r
   ASSERT (Action == EFI_BROWSER_ACTION_SUBMITTED);\r
 \r
@@ -461,7 +468,7 @@ Tcg2VersionInfoCallback (
     CopyMem (\r
       &PcdTcg2PpiVersion,\r
       PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer),\r
-      AsciiStrSize ((CHAR8 *) PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))\r
+      AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))\r
       );\r
     if (PcdTcg2PpiVersion != Value->u64) {\r
       CreatePopUp (\r
@@ -472,7 +479,7 @@ Tcg2VersionInfoCallback (
         NULL\r
         );\r
     }\r
-  } else if (QuestionId == KEY_TPM2_ACPI_REVISION){\r
+  } else if (QuestionId == KEY_TPM2_ACPI_REVISION) {\r
     //\r
     // Get the PCD value after EFI_BROWSER_ACTION_SUBMITTED,\r
     // the SetVariable to TCG2_VERSION_NAME should have been done.\r
@@ -520,19 +527,19 @@ Tcg2VersionInfoCallback (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2Callback (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN     EFI_BROWSER_ACTION                    Action,\r
-  IN     EFI_QUESTION_ID                       QuestionId,\r
-  IN     UINT8                                 Type,\r
-  IN     EFI_IFR_TYPE_VALUE                    *Value,\r
-     OUT EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN     EFI_BROWSER_ACTION                Action,\r
+  IN     EFI_QUESTION_ID                   QuestionId,\r
+  IN     UINT8                             Type,\r
+  IN     EFI_IFR_TYPE_VALUE                *Value,\r
+  OUT EFI_BROWSER_ACTION_REQUEST           *ActionRequest\r
   )\r
 {\r
-  EFI_STATUS                 Status;\r
-  EFI_INPUT_KEY              Key;\r
-  CHAR8                      HidStr[16];\r
-  CHAR16                     UnHidStr[16];\r
-  TCG2_CONFIG_PRIVATE_DATA   *Private;\r
+  EFI_STATUS                Status;\r
+  EFI_INPUT_KEY             Key;\r
+  CHAR8                     HidStr[16];\r
+  CHAR16                    UnHidStr[16];\r
+  TCG2_CONFIG_PRIVATE_DATA  *Private;\r
 \r
   if ((This == NULL) || (Value == NULL) || (ActionRequest == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -545,24 +552,25 @@ Tcg2Callback (
     // Update TPM2 HID info\r
     //\r
     if (QuestionId == KEY_TPM_DEVICE) {\r
-      Status = GetTpm2HID(HidStr, 16);\r
+      Status = GetTpm2HID (HidStr, 16);\r
 \r
-      if (EFI_ERROR(Status)) {\r
+      if (EFI_ERROR (Status)) {\r
         //\r
         //  Fail to get TPM2 HID\r
         //\r
         HiiSetString (Private->HiiHandle, STRING_TOKEN (STR_TPM2_ACPI_HID_CONTENT), L"Unknown", NULL);\r
       } else {\r
-        AsciiStrToUnicodeStrS(HidStr, UnHidStr, 16);\r
+        AsciiStrToUnicodeStrS (HidStr, UnHidStr, 16);\r
         HiiSetString (Private->HiiHandle, STRING_TOKEN (STR_TPM2_ACPI_HID_CONTENT), UnHidStr, NULL);\r
       }\r
     }\r
+\r
     return EFI_SUCCESS;\r
   }\r
 \r
   if (Action == EFI_BROWSER_ACTION_CHANGING) {\r
     if (QuestionId == KEY_TPM_DEVICE_INTERFACE) {\r
-      Status = SetPtpInterface ((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress), Value->u8);\r
+      Status = SetPtpInterface ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress), Value->u8);\r
       if (EFI_ERROR (Status)) {\r
         CreatePopUp (\r
           EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
@@ -579,19 +587,22 @@ Tcg2Callback (
     if (QuestionId == KEY_TPM_DEVICE) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     if (QuestionId == KEY_TPM2_OPERATION) {\r
       return SaveTcg2PpRequest (Value->u8);\r
     }\r
+\r
     if (QuestionId == KEY_TPM2_OPERATION_PARAMETER) {\r
       return SaveTcg2PpRequestParameter (Value->u32);\r
     }\r
+\r
     if ((QuestionId >= KEY_TPM2_PCR_BANKS_REQUEST_0) && (QuestionId <= KEY_TPM2_PCR_BANKS_REQUEST_4)) {\r
       return SaveTcg2PCRBanksRequest (QuestionId - KEY_TPM2_PCR_BANKS_REQUEST_0, Value->b);\r
     }\r
   }\r
 \r
   if (Action == EFI_BROWSER_ACTION_SUBMITTED) {\r
-    if (QuestionId == KEY_TCG2_PPI_VERSION || QuestionId == KEY_TPM2_ACPI_REVISION) {\r
+    if ((QuestionId == KEY_TCG2_PPI_VERSION) || (QuestionId == KEY_TPM2_ACPI_REVISION)) {\r
       return Tcg2VersionInfoCallback (Action, QuestionId, Type, Value);\r
     }\r
   }\r
@@ -615,36 +626,41 @@ AppendBufferWithTpmAlgHash (
   )\r
 {\r
   switch (TpmAlgHash) {\r
-  case TPM_ALG_SHA1:\r
-    if (Buffer[0] != 0) {\r
-      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
-    }\r
-    StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA1");\r
-    break;\r
-  case TPM_ALG_SHA256:\r
-    if (Buffer[0] != 0) {\r
-      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
-    }\r
-    StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA256");\r
-    break;\r
-  case TPM_ALG_SHA384:\r
-    if (Buffer[0] != 0) {\r
-      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
-    }\r
-    StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA384");\r
-    break;\r
-  case TPM_ALG_SHA512:\r
-    if (Buffer[0] != 0) {\r
-      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
-    }\r
-    StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA512");\r
-    break;\r
-  case TPM_ALG_SM3_256:\r
-    if (Buffer[0] != 0) {\r
-      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
-    }\r
-    StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SM3_256");\r
-    break;\r
+    case TPM_ALG_SHA1:\r
+      if (Buffer[0] != 0) {\r
+        StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
+      }\r
+\r
+      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA1");\r
+      break;\r
+    case TPM_ALG_SHA256:\r
+      if (Buffer[0] != 0) {\r
+        StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
+      }\r
+\r
+      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA256");\r
+      break;\r
+    case TPM_ALG_SHA384:\r
+      if (Buffer[0] != 0) {\r
+        StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
+      }\r
+\r
+      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA384");\r
+      break;\r
+    case TPM_ALG_SHA512:\r
+      if (Buffer[0] != 0) {\r
+        StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
+      }\r
+\r
+      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA512");\r
+      break;\r
+    case TPM_ALG_SM3_256:\r
+      if (Buffer[0] != 0) {\r
+        StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
+      }\r
+\r
+      StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SM3_256");\r
+      break;\r
   }\r
 }\r
 \r
@@ -668,30 +684,39 @@ FillBufferWithBootHashAlg (
     if (Buffer[0] != 0) {\r
       StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
     }\r
+\r
     StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA1");\r
   }\r
+\r
   if ((BootHashAlg & EFI_TCG2_BOOT_HASH_ALG_SHA256) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
     }\r
+\r
     StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA256");\r
   }\r
+\r
   if ((BootHashAlg & EFI_TCG2_BOOT_HASH_ALG_SHA384) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
     }\r
+\r
     StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA384");\r
   }\r
+\r
   if ((BootHashAlg & EFI_TCG2_BOOT_HASH_ALG_SHA512) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
     }\r
+\r
     StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SHA512");\r
   }\r
+\r
   if ((BootHashAlg & EFI_TCG2_BOOT_HASH_ALG_SM3_256) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
     }\r
+\r
     StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"SM3_256");\r
   }\r
 }\r
@@ -705,26 +730,26 @@ FillBufferWithBootHashAlg (
 **/\r
 VOID\r
 SetConfigInfo (\r
-  IN OUT TCG2_CONFIGURATION_INFO         *Tcg2ConfigInfo,\r
-  IN UINT32                              TpmAlgHash\r
+  IN OUT TCG2_CONFIGURATION_INFO  *Tcg2ConfigInfo,\r
+  IN UINT32                       TpmAlgHash\r
   )\r
 {\r
   switch (TpmAlgHash) {\r
-  case TPM_ALG_SHA1:\r
-    Tcg2ConfigInfo->Sha1Supported = TRUE;\r
-    break;\r
-  case TPM_ALG_SHA256:\r
-    Tcg2ConfigInfo->Sha256Supported = TRUE;\r
-    break;\r
-  case TPM_ALG_SHA384:\r
-    Tcg2ConfigInfo->Sha384Supported = TRUE;\r
-    break;\r
-  case TPM_ALG_SHA512:\r
-    Tcg2ConfigInfo->Sha512Supported = TRUE;\r
-    break;\r
-  case TPM_ALG_SM3_256:\r
-    Tcg2ConfigInfo->Sm3Supported = TRUE;\r
-    break;\r
+    case TPM_ALG_SHA1:\r
+      Tcg2ConfigInfo->Sha1Supported = TRUE;\r
+      break;\r
+    case TPM_ALG_SHA256:\r
+      Tcg2ConfigInfo->Sha256Supported = TRUE;\r
+      break;\r
+    case TPM_ALG_SHA384:\r
+      Tcg2ConfigInfo->Sha384Supported = TRUE;\r
+      break;\r
+    case TPM_ALG_SHA512:\r
+      Tcg2ConfigInfo->Sha512Supported = TRUE;\r
+      break;\r
+    case TPM_ALG_SM3_256:\r
+      Tcg2ConfigInfo->Sm3Supported = TRUE;\r
+      break;\r
   }\r
 }\r
 \r
@@ -748,18 +773,23 @@ FillBufferWithTCG2EventLogFormat (
     if (Buffer[0] != 0) {\r
       StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
     }\r
+\r
     StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"TCG_1_2");\r
   }\r
+\r
   if ((TCG2EventLogFormat & EFI_TCG2_EVENT_LOG_FORMAT_TCG_2) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
     }\r
+\r
     StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"TCG_2");\r
   }\r
+\r
   if ((TCG2EventLogFormat & (~EFI_TCG2_EVENT_LOG_FORMAT_ALL)) != 0) {\r
     if (Buffer[0] != 0) {\r
       StrCatS (Buffer, BufferSize / sizeof (CHAR16), L", ");\r
     }\r
+\r
     StrCatS (Buffer, BufferSize / sizeof (CHAR16), L"UNKNOWN");\r
   }\r
 }\r
@@ -792,14 +822,14 @@ InstallTcg2ConfigForm (
 \r
   DriverHandle = NULL;\r
   ConfigAccess = &PrivateData->ConfigAccess;\r
-  Status = gBS->InstallMultipleProtocolInterfaces (\r
-                  &DriverHandle,\r
-                  &gEfiDevicePathProtocolGuid,\r
-                  &mTcg2HiiVendorDevicePath,\r
-                  &gEfiHiiConfigAccessProtocolGuid,\r
-                  ConfigAccess,\r
-                  NULL\r
-                  );\r
+  Status       = gBS->InstallMultipleProtocolInterfaces (\r
+                        &DriverHandle,\r
+                        &gEfiDevicePathProtocolGuid,\r
+                        &mTcg2HiiVendorDevicePath,\r
+                        &gEfiHiiConfigAccessProtocolGuid,\r
+                        ConfigAccess,\r
+                        NULL\r
+                        );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -835,21 +865,21 @@ InstallTcg2ConfigForm (
   // Update static data\r
   //\r
   switch (PrivateData->TpmDeviceDetected) {\r
-  case TPM_DEVICE_NULL:\r
-    HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_STATE_CONTENT), L"Not Found", NULL);\r
-    break;\r
-  case TPM_DEVICE_1_2:\r
-    HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_STATE_CONTENT), L"TPM 1.2", NULL);\r
-    break;\r
-  case TPM_DEVICE_2_0_DTPM:\r
-    HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_STATE_CONTENT), L"TPM 2.0", NULL);\r
-    break;\r
-  default:\r
-    HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_STATE_CONTENT), L"Unknown", NULL);\r
-    break;\r
-  }\r
-\r
-  ZeroMem (&Tcg2ConfigInfo, sizeof(Tcg2ConfigInfo));\r
+    case TPM_DEVICE_NULL:\r
+      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_STATE_CONTENT), L"Not Found", NULL);\r
+      break;\r
+    case TPM_DEVICE_1_2:\r
+      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_STATE_CONTENT), L"TPM 1.2", NULL);\r
+      break;\r
+    case TPM_DEVICE_2_0_DTPM:\r
+      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_STATE_CONTENT), L"TPM 2.0", NULL);\r
+      break;\r
+    default:\r
+      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_STATE_CONTENT), L"Unknown", NULL);\r
+      break;\r
+  }\r
+\r
+  ZeroMem (&Tcg2ConfigInfo, sizeof (Tcg2ConfigInfo));\r
   Status = Tpm2GetCapabilityPcrs (&Pcrs);\r
   if (EFI_ERROR (Status)) {\r
     HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TPM2_ACTIVE_HASH_ALGO_CONTENT), L"[Unknown]", NULL);\r
@@ -858,16 +888,18 @@ InstallTcg2ConfigForm (
     TempBuffer[0] = 0;\r
     for (Index = 0; Index < Pcrs.count; Index++) {\r
       if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, Pcrs.pcrSelections[Index].sizeofSelect)) {\r
-        AppendBufferWithTpmAlgHash (TempBuffer, sizeof(TempBuffer), Pcrs.pcrSelections[Index].hash);\r
+        AppendBufferWithTpmAlgHash (TempBuffer, sizeof (TempBuffer), Pcrs.pcrSelections[Index].hash);\r
       }\r
     }\r
+\r
     HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TPM2_ACTIVE_HASH_ALGO_CONTENT), TempBuffer, NULL);\r
 \r
     TempBuffer[0] = 0;\r
     for (Index = 0; Index < Pcrs.count; Index++) {\r
-      AppendBufferWithTpmAlgHash (TempBuffer, sizeof(TempBuffer), Pcrs.pcrSelections[Index].hash);\r
+      AppendBufferWithTpmAlgHash (TempBuffer, sizeof (TempBuffer), Pcrs.pcrSelections[Index].hash);\r
       SetConfigInfo (&Tcg2ConfigInfo, Pcrs.pcrSelections[Index].hash);\r
     }\r
+\r
     HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TPM2_SUPPORTED_HASH_ALGO_CONTENT), TempBuffer, NULL);\r
   }\r
 \r
@@ -875,77 +907,82 @@ InstallTcg2ConfigForm (
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Tpm2GetCapabilityIsCmdImpl fails %r\n", Status));\r
   }\r
+\r
   Tcg2ConfigInfo.ChangeEPSSupported = IsCmdImp;\r
 \r
-  FillBufferWithBootHashAlg (TempBuffer, sizeof(TempBuffer), PcdGet32 (PcdTcg2HashAlgorithmBitmap));\r
+  FillBufferWithBootHashAlg (TempBuffer, sizeof (TempBuffer), PcdGet32 (PcdTcg2HashAlgorithmBitmap));\r
   HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_BIOS_HASH_ALGO_CONTENT), TempBuffer, NULL);\r
 \r
   //\r
   // Tcg2 Capability\r
   //\r
-  FillBufferWithTCG2EventLogFormat (TempBuffer, sizeof(TempBuffer), PrivateData->ProtocolCapability.SupportedEventLogs);\r
+  FillBufferWithTCG2EventLogFormat (TempBuffer, sizeof (TempBuffer), PrivateData->ProtocolCapability.SupportedEventLogs);\r
   HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_SUPPORTED_EVENT_LOG_FORMAT_CONTENT), TempBuffer, NULL);\r
 \r
-  FillBufferWithBootHashAlg (TempBuffer, sizeof(TempBuffer), PrivateData->ProtocolCapability.HashAlgorithmBitmap);\r
+  FillBufferWithBootHashAlg (TempBuffer, sizeof (TempBuffer), PrivateData->ProtocolCapability.HashAlgorithmBitmap);\r
   HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_HASH_ALGO_BITMAP_CONTENT), TempBuffer, NULL);\r
 \r
   UnicodeSPrint (TempBuffer, sizeof (TempBuffer), L"%d", PrivateData->ProtocolCapability.NumberOfPCRBanks);\r
   HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_NUMBER_OF_PCR_BANKS_CONTENT), TempBuffer, NULL);\r
 \r
-  FillBufferWithBootHashAlg (TempBuffer, sizeof(TempBuffer), PrivateData->ProtocolCapability.ActivePcrBanks);\r
+  FillBufferWithBootHashAlg (TempBuffer, sizeof (TempBuffer), PrivateData->ProtocolCapability.ActivePcrBanks);\r
   HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_ACTIVE_PCR_BANKS_CONTENT), TempBuffer, NULL);\r
 \r
   //\r
   // Update TPM device interface type\r
   //\r
   if (PrivateData->TpmDeviceDetected == TPM_DEVICE_2_0_DTPM) {\r
-    TpmDeviceInterfaceDetected = PcdGet8(PcdActiveTpmInterfaceType);\r
+    TpmDeviceInterfaceDetected = PcdGet8 (PcdActiveTpmInterfaceType);\r
     switch (TpmDeviceInterfaceDetected) {\r
-    case Tpm2PtpInterfaceTis:\r
-      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_STATE_CONTENT), L"TIS", NULL);\r
-      break;\r
-    case Tpm2PtpInterfaceFifo:\r
-      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_STATE_CONTENT), L"PTP FIFO", NULL);\r
-      break;\r
-    case Tpm2PtpInterfaceCrb:\r
-      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_STATE_CONTENT), L"PTP CRB", NULL);\r
-      break;\r
-     default:\r
-      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_STATE_CONTENT), L"Unknown", NULL);\r
-      break;\r
+      case Tpm2PtpInterfaceTis:\r
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_STATE_CONTENT), L"TIS", NULL);\r
+        break;\r
+      case Tpm2PtpInterfaceFifo:\r
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_STATE_CONTENT), L"PTP FIFO", NULL);\r
+        break;\r
+      case Tpm2PtpInterfaceCrb:\r
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_STATE_CONTENT), L"PTP CRB", NULL);\r
+        break;\r
+      default:\r
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_STATE_CONTENT), L"Unknown", NULL);\r
+        break;\r
     }\r
 \r
     Tcg2ConfigInfo.TpmDeviceInterfaceAttempt = TpmDeviceInterfaceDetected;\r
     switch (TpmDeviceInterfaceDetected) {\r
-    case Tpm2PtpInterfaceTis:\r
-      Tcg2ConfigInfo.TpmDeviceInterfacePtpFifoSupported = FALSE;\r
-      Tcg2ConfigInfo.TpmDeviceInterfacePtpCrbSupported  = FALSE;\r
-      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_CAPABILITY_CONTENT), L"TIS", NULL);\r
-      break;\r
-    case Tpm2PtpInterfaceFifo:\r
-    case Tpm2PtpInterfaceCrb:\r
-      Tcg2ConfigInfo.TpmDeviceInterfacePtpFifoSupported = IsPtpFifoSupported((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
-      Tcg2ConfigInfo.TpmDeviceInterfacePtpCrbSupported  = IsPtpCrbSupported((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));\r
-      TempBuffer[0] = 0;\r
-      if (Tcg2ConfigInfo.TpmDeviceInterfacePtpFifoSupported) {\r
-        if (TempBuffer[0] != 0) {\r
-          StrCatS (TempBuffer, sizeof(TempBuffer) / sizeof (CHAR16), L", ");\r
+      case Tpm2PtpInterfaceTis:\r
+        Tcg2ConfigInfo.TpmDeviceInterfacePtpFifoSupported = FALSE;\r
+        Tcg2ConfigInfo.TpmDeviceInterfacePtpCrbSupported  = FALSE;\r
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_CAPABILITY_CONTENT), L"TIS", NULL);\r
+        break;\r
+      case Tpm2PtpInterfaceFifo:\r
+      case Tpm2PtpInterfaceCrb:\r
+        Tcg2ConfigInfo.TpmDeviceInterfacePtpFifoSupported = IsPtpFifoSupported ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
+        Tcg2ConfigInfo.TpmDeviceInterfacePtpCrbSupported  = IsPtpCrbSupported ((VOID *)(UINTN)PcdGet64 (PcdTpmBaseAddress));\r
+        TempBuffer[0]                                     = 0;\r
+        if (Tcg2ConfigInfo.TpmDeviceInterfacePtpFifoSupported) {\r
+          if (TempBuffer[0] != 0) {\r
+            StrCatS (TempBuffer, sizeof (TempBuffer) / sizeof (CHAR16), L", ");\r
+          }\r
+\r
+          StrCatS (TempBuffer, sizeof (TempBuffer) / sizeof (CHAR16), L"PTP FIFO");\r
         }\r
-        StrCatS (TempBuffer, sizeof(TempBuffer) / sizeof (CHAR16), L"PTP FIFO");\r
-      }\r
-      if (Tcg2ConfigInfo.TpmDeviceInterfacePtpCrbSupported) {\r
-        if (TempBuffer[0] != 0) {\r
-          StrCatS (TempBuffer, sizeof(TempBuffer) / sizeof (CHAR16), L", ");\r
+\r
+        if (Tcg2ConfigInfo.TpmDeviceInterfacePtpCrbSupported) {\r
+          if (TempBuffer[0] != 0) {\r
+            StrCatS (TempBuffer, sizeof (TempBuffer) / sizeof (CHAR16), L", ");\r
+          }\r
+\r
+          StrCatS (TempBuffer, sizeof (TempBuffer) / sizeof (CHAR16), L"PTP CRB");\r
         }\r
-        StrCatS (TempBuffer, sizeof(TempBuffer) / sizeof (CHAR16), L"PTP CRB");\r
-      }\r
-      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_CAPABILITY_CONTENT), TempBuffer, NULL);\r
-      break;\r
-    default:\r
-      Tcg2ConfigInfo.TpmDeviceInterfacePtpFifoSupported = FALSE;\r
-      Tcg2ConfigInfo.TpmDeviceInterfacePtpCrbSupported  = FALSE;\r
-      HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_CAPABILITY_CONTENT), L"Unknown", NULL);\r
-      break;\r
+\r
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_CAPABILITY_CONTENT), TempBuffer, NULL);\r
+        break;\r
+      default:\r
+        Tcg2ConfigInfo.TpmDeviceInterfacePtpFifoSupported = FALSE;\r
+        Tcg2ConfigInfo.TpmDeviceInterfacePtpCrbSupported  = FALSE;\r
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TCG2_DEVICE_INTERFACE_CAPABILITY_CONTENT), L"Unknown", NULL);\r
+        break;\r
     }\r
   }\r
 \r
@@ -956,7 +993,7 @@ InstallTcg2ConfigForm (
                   TCG2_STORAGE_INFO_NAME,\r
                   &gTcg2ConfigFormSetGuid,\r
                   EFI_VARIABLE_BOOTSERVICE_ACCESS,\r
-                  sizeof(Tcg2ConfigInfo),\r
+                  sizeof (Tcg2ConfigInfo),\r
                   &Tcg2ConfigInfo\r
                   );\r
   if (EFI_ERROR (Status)) {\r
@@ -974,7 +1011,7 @@ InstallTcg2ConfigForm (
 **/\r
 VOID\r
 UninstallTcg2ConfigForm (\r
-  IN OUT TCG2_CONFIG_PRIVATE_DATA    *PrivateData\r
+  IN OUT TCG2_CONFIG_PRIVATE_DATA  *PrivateData\r
   )\r
 {\r
   //\r
index af542d52efdd3a1f7727cb3cb6c9f9127a101cb1..3e0d5f31dfae52dbce65d64d7c5df121d2e1b126 100644 (file)
@@ -38,42 +38,42 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include "Tcg2ConfigNvData.h"\r
 #include "Tcg2Internal.h"\r
 \r
-#define TCG2_PROTOCOL_VERSION_DEFAULT        0x0001\r
+#define TCG2_PROTOCOL_VERSION_DEFAULT  0x0001\r
 \r
 //\r
 // Tool generated IFR binary data and String package data\r
 //\r
-extern UINT8                        Tcg2ConfigBin[];\r
-extern UINT8                        Tcg2ConfigDxeStrings[];\r
+extern UINT8  Tcg2ConfigBin[];\r
+extern UINT8  Tcg2ConfigDxeStrings[];\r
 \r
 ///\r
 /// HII specific Vendor Device Path definition.\r
 ///\r
 typedef struct {\r
-  VENDOR_DEVICE_PATH                VendorDevicePath;\r
-  EFI_DEVICE_PATH_PROTOCOL          End;\r
+  VENDOR_DEVICE_PATH          VendorDevicePath;\r
+  EFI_DEVICE_PATH_PROTOCOL    End;\r
 } HII_VENDOR_DEVICE_PATH;\r
 \r
 typedef struct {\r
-  UINTN                             Signature;\r
+  UINTN                               Signature;\r
 \r
-  EFI_HII_CONFIG_ACCESS_PROTOCOL    ConfigAccess;\r
-  EFI_HII_HANDLE                    HiiHandle;\r
-  EFI_HANDLE                        DriverHandle;\r
+  EFI_HII_CONFIG_ACCESS_PROTOCOL      ConfigAccess;\r
+  EFI_HII_HANDLE                      HiiHandle;\r
+  EFI_HANDLE                          DriverHandle;\r
 \r
-  UINT8                             TpmDeviceDetected;\r
-  EFI_TCG2_PROTOCOL                 *Tcg2Protocol;\r
-  EFI_TCG2_BOOT_SERVICE_CAPABILITY  ProtocolCapability;\r
-  UINT32                            PCRBanksDesired;\r
+  UINT8                               TpmDeviceDetected;\r
+  EFI_TCG2_PROTOCOL                   *Tcg2Protocol;\r
+  EFI_TCG2_BOOT_SERVICE_CAPABILITY    ProtocolCapability;\r
+  UINT32                              PCRBanksDesired;\r
 } TCG2_CONFIG_PRIVATE_DATA;\r
 \r
-extern TCG2_CONFIG_PRIVATE_DATA      mTcg2ConfigPrivateDateTemplate;\r
-extern TCG2_CONFIG_PRIVATE_DATA      *mTcg2ConfigPrivateDate;\r
-#define TCG2_CONFIG_PRIVATE_DATA_SIGNATURE     SIGNATURE_32 ('T', 'r', 'E', 'D')\r
+extern TCG2_CONFIG_PRIVATE_DATA  mTcg2ConfigPrivateDateTemplate;\r
+extern TCG2_CONFIG_PRIVATE_DATA  *mTcg2ConfigPrivateDate;\r
+#define TCG2_CONFIG_PRIVATE_DATA_SIGNATURE  SIGNATURE_32 ('T', 'r', 'E', 'D')\r
 #define TCG2_CONFIG_PRIVATE_DATA_FROM_THIS(a)  CR (a, TCG2_CONFIG_PRIVATE_DATA, ConfigAccess, TCG2_CONFIG_PRIVATE_DATA_SIGNATURE)\r
 \r
-#define TPM_HID_PNP_SIZE                                           8\r
-#define TPM_HID_ACPI_SIZE                                          9\r
+#define TPM_HID_PNP_SIZE   8\r
+#define TPM_HID_ACPI_SIZE  9\r
 \r
 /**\r
   This function publish the TCG2 configuration Form for TPM device.\r
@@ -98,7 +98,7 @@ InstallTcg2ConfigForm (
 **/\r
 VOID\r
 UninstallTcg2ConfigForm (\r
-  IN OUT TCG2_CONFIG_PRIVATE_DATA    *PrivateData\r
+  IN OUT TCG2_CONFIG_PRIVATE_DATA  *PrivateData\r
   );\r
 \r
 /**\r
@@ -130,10 +130,10 @@ UninstallTcg2ConfigForm (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2ExtractConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL        *This,\r
-  IN CONST EFI_STRING                            Request,\r
-       OUT EFI_STRING                            *Progress,\r
-       OUT EFI_STRING                            *Results\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Request,\r
+  OUT EFI_STRING                           *Progress,\r
+  OUT EFI_STRING                           *Results\r
   );\r
 \r
 /**\r
@@ -157,9 +157,9 @@ Tcg2ExtractConfig (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2RouteConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN CONST EFI_STRING                          Configuration,\r
-       OUT EFI_STRING                          *Progress\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Configuration,\r
+  OUT EFI_STRING                           *Progress\r
   );\r
 \r
 /**\r
@@ -187,12 +187,12 @@ Tcg2RouteConfig (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2Callback (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN     EFI_BROWSER_ACTION                    Action,\r
-  IN     EFI_QUESTION_ID                       QuestionId,\r
-  IN     UINT8                                 Type,\r
-  IN     EFI_IFR_TYPE_VALUE                    *Value,\r
-     OUT EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN     EFI_BROWSER_ACTION                Action,\r
+  IN     EFI_QUESTION_ID                   QuestionId,\r
+  IN     UINT8                             Type,\r
+  IN     EFI_IFR_TYPE_VALUE                *Value,\r
+  OUT EFI_BROWSER_ACTION_REQUEST           *ActionRequest\r
   );\r
 \r
 #endif\r
index b84af40a0412e5a0481d8ac108d6fff1cd78da76..69ef5600478d80e11a4dbc9af34f196c48c715f1 100644 (file)
@@ -13,32 +13,32 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Guid/Tcg2ConfigHii.h>\r
 #include <IndustryStandard/TcgPhysicalPresence.h>\r
 \r
-#define TCG2_CONFIGURATION_VARSTORE_ID  0x0001\r
-#define TCG2_CONFIGURATION_INFO_VARSTORE_ID     0x0002\r
-#define TCG2_VERSION_VARSTORE_ID        0x0003\r
-#define TCG2_CONFIGURATION_FORM_ID      0x0001\r
-\r
-#define KEY_TPM_DEVICE                                 0x2000\r
-#define KEY_TPM2_OPERATION                             0x2001\r
-#define KEY_TPM2_OPERATION_PARAMETER            0x2002\r
-#define KEY_TPM2_PCR_BANKS_REQUEST_0            0x2003\r
-#define KEY_TPM2_PCR_BANKS_REQUEST_1            0x2004\r
-#define KEY_TPM2_PCR_BANKS_REQUEST_2            0x2005\r
-#define KEY_TPM2_PCR_BANKS_REQUEST_3            0x2006\r
-#define KEY_TPM2_PCR_BANKS_REQUEST_4            0x2007\r
-#define KEY_TPM_DEVICE_INTERFACE                       0x2008\r
-#define KEY_TCG2_PPI_VERSION                    0x2009\r
-#define KEY_TPM2_ACPI_REVISION                  0x200A\r
-\r
-#define TPM_DEVICE_NULL           0\r
-#define TPM_DEVICE_1_2            1\r
-#define TPM_DEVICE_2_0_DTPM       2\r
-#define TPM_DEVICE_MIN            TPM_DEVICE_1_2\r
-#define TPM_DEVICE_MAX            TPM_DEVICE_2_0_DTPM\r
-#define TPM_DEVICE_DEFAULT        TPM_DEVICE_1_2\r
-\r
-#define TPM2_ACPI_REVISION_3       3\r
-#define TPM2_ACPI_REVISION_4       4\r
+#define TCG2_CONFIGURATION_VARSTORE_ID       0x0001\r
+#define TCG2_CONFIGURATION_INFO_VARSTORE_ID  0x0002\r
+#define TCG2_VERSION_VARSTORE_ID             0x0003\r
+#define TCG2_CONFIGURATION_FORM_ID           0x0001\r
+\r
+#define KEY_TPM_DEVICE                0x2000\r
+#define KEY_TPM2_OPERATION            0x2001\r
+#define KEY_TPM2_OPERATION_PARAMETER  0x2002\r
+#define KEY_TPM2_PCR_BANKS_REQUEST_0  0x2003\r
+#define KEY_TPM2_PCR_BANKS_REQUEST_1  0x2004\r
+#define KEY_TPM2_PCR_BANKS_REQUEST_2  0x2005\r
+#define KEY_TPM2_PCR_BANKS_REQUEST_3  0x2006\r
+#define KEY_TPM2_PCR_BANKS_REQUEST_4  0x2007\r
+#define KEY_TPM_DEVICE_INTERFACE      0x2008\r
+#define KEY_TCG2_PPI_VERSION          0x2009\r
+#define KEY_TPM2_ACPI_REVISION        0x200A\r
+\r
+#define TPM_DEVICE_NULL      0\r
+#define TPM_DEVICE_1_2       1\r
+#define TPM_DEVICE_2_0_DTPM  2\r
+#define TPM_DEVICE_MIN       TPM_DEVICE_1_2\r
+#define TPM_DEVICE_MAX       TPM_DEVICE_2_0_DTPM\r
+#define TPM_DEVICE_DEFAULT   TPM_DEVICE_1_2\r
+\r
+#define TPM2_ACPI_REVISION_3  3\r
+#define TPM2_ACPI_REVISION_4  4\r
 \r
 #define TPM_DEVICE_INTERFACE_TIS       0\r
 #define TPM_DEVICE_INTERFACE_PTP_FIFO  1\r
@@ -46,31 +46,31 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define TPM_DEVICE_INTERFACE_MAX       TPM_DEVICE_INTERFACE_PTP_FIFO\r
 #define TPM_DEVICE_INTERFACE_DEFAULT   TPM_DEVICE_INTERFACE_PTP_CRB\r
 \r
-#define TCG2_PPI_VERSION_1_2                    0x322E31  // "1.2"\r
-#define TCG2_PPI_VERSION_1_3                    0x332E31  // "1.3"\r
+#define TCG2_PPI_VERSION_1_2  0x322E31                    // "1.2"\r
+#define TCG2_PPI_VERSION_1_3  0x332E31                    // "1.3"\r
 \r
 //\r
 // Nv Data structure referenced by IFR, TPM device user desired\r
 //\r
 typedef struct {\r
-  UINT8   TpmDevice;\r
+  UINT8    TpmDevice;\r
 } TCG2_CONFIGURATION;\r
 \r
 typedef struct {\r
-  UINT64  PpiVersion;\r
-  UINT8   Tpm2AcpiTableRev;\r
+  UINT64    PpiVersion;\r
+  UINT8     Tpm2AcpiTableRev;\r
 } TCG2_VERSION;\r
 \r
 typedef struct {\r
-  BOOLEAN  Sha1Supported;\r
-  BOOLEAN  Sha256Supported;\r
-  BOOLEAN  Sha384Supported;\r
-  BOOLEAN  Sha512Supported;\r
-  BOOLEAN  Sm3Supported;\r
-  UINT8    TpmDeviceInterfaceAttempt;\r
-  BOOLEAN  TpmDeviceInterfacePtpFifoSupported;\r
-  BOOLEAN  TpmDeviceInterfacePtpCrbSupported;\r
-  BOOLEAN  ChangeEPSSupported;\r
+  BOOLEAN    Sha1Supported;\r
+  BOOLEAN    Sha256Supported;\r
+  BOOLEAN    Sha384Supported;\r
+  BOOLEAN    Sha512Supported;\r
+  BOOLEAN    Sm3Supported;\r
+  UINT8      TpmDeviceInterfaceAttempt;\r
+  BOOLEAN    TpmDeviceInterfacePtpFifoSupported;\r
+  BOOLEAN    TpmDeviceInterfacePtpCrbSupported;\r
+  BOOLEAN    ChangeEPSSupported;\r
 } TCG2_CONFIGURATION_INFO;\r
 \r
 //\r
@@ -78,7 +78,7 @@ typedef struct {
 // This variable is ReadOnly.\r
 //\r
 typedef struct {\r
-  UINT8   TpmDeviceDetected;\r
+  UINT8    TpmDeviceDetected;\r
 } TCG2_DEVICE_DETECTION;\r
 \r
 #define TCG2_STORAGE_NAME           L"TCG2_CONFIGURATION"\r
index 8abc33efd4b0fc16794c939ce98e362acc77ae36..21a01f07e1455d065fd889b69b8489922361617a 100644 (file)
@@ -6,7 +6,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 **/\r
 \r
-\r
 #include <PiPei.h>\r
 \r
 #include <Guid/TpmInstance.h>\r
@@ -27,7 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 TPM_INSTANCE_ID  mTpmInstanceId[] = TPM_INSTANCE_ID_LIST;\r
 \r
-CONST EFI_PEI_PPI_DESCRIPTOR gTpmSelectedPpi = {\r
+CONST EFI_PEI_PPI_DESCRIPTOR  gTpmSelectedPpi = {\r
   (EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST),\r
   &gEfiTpmDeviceSelectedGuid,\r
   NULL\r
@@ -48,7 +47,7 @@ EFI_PEI_PPI_DESCRIPTOR  mTpmInitializationDonePpiList = {
 **/\r
 UINT8\r
 DetectTpmDevice (\r
-  IN UINT8 SetupTpmDevice\r
+  IN UINT8  SetupTpmDevice\r
   );\r
 \r
 /**\r
@@ -67,18 +66,18 @@ Tcg2ConfigPeimEntryPoint (
   IN CONST EFI_PEI_SERVICES     **PeiServices\r
   )\r
 {\r
-  UINTN                           Size;\r
-  EFI_STATUS                      Status;\r
-  EFI_STATUS                      Status2;\r
-  EFI_PEI_READ_ONLY_VARIABLE2_PPI *VariablePpi;\r
-  TCG2_CONFIGURATION              Tcg2Configuration;\r
-  UINTN                           Index;\r
-  UINT8                           TpmDevice;\r
-\r
-  Status = PeiServicesLocatePpi (&gEfiPeiReadOnlyVariable2PpiGuid, 0, NULL, (VOID **) &VariablePpi);\r
+  UINTN                            Size;\r
+  EFI_STATUS                       Status;\r
+  EFI_STATUS                       Status2;\r
+  EFI_PEI_READ_ONLY_VARIABLE2_PPI  *VariablePpi;\r
+  TCG2_CONFIGURATION               Tcg2Configuration;\r
+  UINTN                            Index;\r
+  UINT8                            TpmDevice;\r
+\r
+  Status = PeiServicesLocatePpi (&gEfiPeiReadOnlyVariable2PpiGuid, 0, NULL, (VOID **)&VariablePpi);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  Size = sizeof(Tcg2Configuration);\r
+  Size   = sizeof (Tcg2Configuration);\r
   Status = VariablePpi->GetVariable (\r
                           VariablePpi,\r
                           TCG2_STORAGE_NAME,\r
@@ -91,7 +90,7 @@ Tcg2ConfigPeimEntryPoint (
     //\r
     // Variable not ready, set default value\r
     //\r
-    Tcg2Configuration.TpmDevice           = TPM_DEVICE_DEFAULT;\r
+    Tcg2Configuration.TpmDevice = TPM_DEVICE_DEFAULT;\r
   }\r
 \r
   //\r
@@ -124,9 +123,9 @@ Tcg2ConfigPeimEntryPoint (
   // NOTE: Tcg2Configuration variable contains the desired TpmDevice type,\r
   // while PcdTpmInstanceGuid PCD contains the real detected TpmDevice type\r
   //\r
-  for (Index = 0; Index < sizeof(mTpmInstanceId)/sizeof(mTpmInstanceId[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTpmInstanceId)/sizeof (mTpmInstanceId[0]); Index++) {\r
     if (TpmDevice == mTpmInstanceId[Index].TpmDevice) {\r
-      Size = sizeof(mTpmInstanceId[Index].TpmInstanceGuid);\r
+      Size   = sizeof (mTpmInstanceId[Index].TpmInstanceGuid);\r
       Status = PcdSetPtrS (PcdTpmInstanceGuid, &Size, &mTpmInstanceId[Index].TpmInstanceGuid);\r
       ASSERT_EFI_ERROR (Status);\r
       DEBUG ((DEBUG_INFO, "TpmDevice PCD: %g\n", &mTpmInstanceId[Index].TpmInstanceGuid));\r
@@ -145,7 +144,7 @@ Tcg2ConfigPeimEntryPoint (
   // Because TcgPei or Tcg2Pei will not run, but we still need a way to notify other driver.\r
   // Other driver can know TPM initialization state by TpmInitializedPpi.\r
   //\r
-  if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceNoneGuid)) {\r
+  if (CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceNoneGuid)) {\r
     Status2 = PeiServicesInstallPpi (&mTpmInitializationDonePpiList);\r
     ASSERT_EFI_ERROR (Status2);\r
   }\r
index 6ed1015ef23084b1699887b33bf5edee991dab97..391010cbb4b554f7569074567aabd533ae05dd9b 100644 (file)
@@ -9,8 +9,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #ifndef __TCG2_INTERNAL_H__\r
 #define __TCG2_INTERNAL_H__\r
 \r
-#define EFI_TCG2_EVENT_LOG_FORMAT_DEFAULT    EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2\r
-#define EFI_TCG2_EVENT_LOG_FORMAT_ALL        (EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2 | EFI_TCG2_EVENT_LOG_FORMAT_TCG_2)\r
+#define EFI_TCG2_EVENT_LOG_FORMAT_DEFAULT  EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2\r
+#define EFI_TCG2_EVENT_LOG_FORMAT_ALL      (EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2 | EFI_TCG2_EVENT_LOG_FORMAT_TCG_2)\r
 \r
 #define TPM_INSTANCE_ID_LIST  { \\r
   {TPM_DEVICE_INTERFACE_NONE,           TPM_DEVICE_NULL},      \\r
@@ -19,8 +19,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 }\r
 \r
 typedef struct {\r
-  GUID       TpmInstanceGuid;\r
-  UINT8      TpmDevice;\r
+  GUID     TpmInstanceGuid;\r
+  UINT8    TpmDevice;\r
 } TPM_INSTANCE_ID;\r
 \r
 #endif\r
index 57d3638f0c2a0183f34ee098bf1d58ca1bfa0a5e..64ec2ad699bc0b682e189f409c468d8fdc5c10a7 100644 (file)
@@ -6,7 +6,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 **/\r
 \r
-\r
 #include <PiPei.h>\r
 #include <Ppi/ReadOnlyVariable2.h>\r
 \r
@@ -31,14 +30,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 UINT8\r
 DetectTpmDevice (\r
-  IN UINT8 SetupTpmDevice\r
+  IN UINT8  SetupTpmDevice\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_BOOT_MODE                     BootMode;\r
-  TCG2_DEVICE_DETECTION             Tcg2DeviceDetection;\r
-  EFI_PEI_READ_ONLY_VARIABLE2_PPI   *VariablePpi;\r
-  UINTN                             Size;\r
+  EFI_STATUS                       Status;\r
+  EFI_BOOT_MODE                    BootMode;\r
+  TCG2_DEVICE_DETECTION            Tcg2DeviceDetection;\r
+  EFI_PEI_READ_ONLY_VARIABLE2_PPI  *VariablePpi;\r
+  UINTN                            Size;\r
 \r
   Status = PeiServicesGetBootMode (&BootMode);\r
   ASSERT_EFI_ERROR (Status);\r
@@ -49,11 +48,11 @@ DetectTpmDevice (
   if (BootMode == BOOT_ON_S3_RESUME) {\r
     DEBUG ((DEBUG_INFO, "DetectTpmDevice: S3 mode\n"));\r
 \r
-    Status = PeiServicesLocatePpi (&gEfiPeiReadOnlyVariable2PpiGuid, 0, NULL, (VOID **) &VariablePpi);\r
+    Status = PeiServicesLocatePpi (&gEfiPeiReadOnlyVariable2PpiGuid, 0, NULL, (VOID **)&VariablePpi);\r
     ASSERT_EFI_ERROR (Status);\r
 \r
-    Size = sizeof(TCG2_DEVICE_DETECTION);\r
-    ZeroMem (&Tcg2DeviceDetection, sizeof(Tcg2DeviceDetection));\r
+    Size = sizeof (TCG2_DEVICE_DETECTION);\r
+    ZeroMem (&Tcg2DeviceDetection, sizeof (Tcg2DeviceDetection));\r
     Status = VariablePpi->GetVariable (\r
                             VariablePpi,\r
                             TCG2_DEVICE_DETECTION_NAME,\r
@@ -64,7 +63,8 @@ DetectTpmDevice (
                             );\r
     if (!EFI_ERROR (Status) &&\r
         (Tcg2DeviceDetection.TpmDeviceDetected >= TPM_DEVICE_MIN) &&\r
-        (Tcg2DeviceDetection.TpmDeviceDetected <= TPM_DEVICE_MAX)) {\r
+        (Tcg2DeviceDetection.TpmDeviceDetected <= TPM_DEVICE_MAX))\r
+    {\r
       DEBUG ((DEBUG_ERROR, "TpmDevice from DeviceDetection: %x\n", Tcg2DeviceDetection.TpmDeviceDetected));\r
       return Tcg2DeviceDetection.TpmDeviceDetected;\r
     }\r
@@ -89,6 +89,7 @@ DetectTpmDevice (
   } else {\r
     Status = Tpm12Startup (TPM_ST_CLEAR);\r
   }\r
+\r
   if (EFI_ERROR (Status)) {\r
     return TPM_DEVICE_2_0_DTPM;\r
   }\r
index 347c6ab702c6a01a349ce383d3c07de25474dd2e..b6c6faf2d24ba91d60d6a714bbe6068065456b72 100644 (file)
@@ -43,15 +43,15 @@ UINTN  mTcg2DxeImageSize = 0;
 EFI_STATUS\r
 EFIAPI\r
 Tcg2DxeImageRead (\r
-  IN     VOID    *FileHandle,\r
-  IN     UINTN   FileOffset,\r
-  IN OUT UINTN   *ReadSize,\r
-  OUT    VOID    *Buffer\r
+  IN     VOID   *FileHandle,\r
+  IN     UINTN  FileOffset,\r
+  IN OUT UINTN  *ReadSize,\r
+  OUT    VOID   *Buffer\r
   )\r
 {\r
-  UINTN               EndPosition;\r
+  UINTN  EndPosition;\r
 \r
-  if (FileHandle == NULL || ReadSize == NULL || Buffer == NULL) {\r
+  if ((FileHandle == NULL) || (ReadSize == NULL) || (Buffer == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -68,7 +68,7 @@ Tcg2DxeImageRead (
     *ReadSize = 0;\r
   }\r
 \r
-  CopyMem (Buffer, (UINT8 *)((UINTN) FileHandle + FileOffset), *ReadSize);\r
+  CopyMem (Buffer, (UINT8 *)((UINTN)FileHandle + FileOffset), *ReadSize);\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -94,10 +94,10 @@ Tcg2DxeImageRead (
 **/\r
 EFI_STATUS\r
 MeasurePeImageAndExtend (\r
-  IN  UINT32                    PCRIndex,\r
-  IN  EFI_PHYSICAL_ADDRESS      ImageAddress,\r
-  IN  UINTN                     ImageSize,\r
-  OUT TPML_DIGEST_VALUES        *DigestList\r
+  IN  UINT32                PCRIndex,\r
+  IN  EFI_PHYSICAL_ADDRESS  ImageAddress,\r
+  IN  UINTN                 ImageSize,\r
+  OUT TPML_DIGEST_VALUES    *DigestList\r
   )\r
 {\r
   EFI_STATUS                           Status;\r
@@ -125,9 +125,9 @@ MeasurePeImageAndExtend (
   // Check PE/COFF image\r
   //\r
   ZeroMem (&ImageContext, sizeof (ImageContext));\r
-  ImageContext.Handle    = (VOID *) (UINTN) ImageAddress;\r
+  ImageContext.Handle    = (VOID *)(UINTN)ImageAddress;\r
   mTcg2DxeImageSize      = ImageSize;\r
-  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE) Tcg2DxeImageRead;\r
+  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE)Tcg2DxeImageRead;\r
 \r
   //\r
   // Get information about the image being loaded\r
@@ -141,13 +141,13 @@ MeasurePeImageAndExtend (
     goto Finish;\r
   }\r
 \r
-  DosHdr = (EFI_IMAGE_DOS_HEADER *) (UINTN) ImageAddress;\r
+  DosHdr             = (EFI_IMAGE_DOS_HEADER *)(UINTN)ImageAddress;\r
   PeCoffHeaderOffset = 0;\r
   if (DosHdr->e_magic == EFI_IMAGE_DOS_SIGNATURE) {\r
     PeCoffHeaderOffset = DosHdr->e_lfanew;\r
   }\r
 \r
-  Hdr.Pe32 = (EFI_IMAGE_NT_HEADERS32 *)((UINT8 *) (UINTN) ImageAddress + PeCoffHeaderOffset);\r
+  Hdr.Pe32 = (EFI_IMAGE_NT_HEADERS32 *)((UINT8 *)(UINTN)ImageAddress + PeCoffHeaderOffset);\r
   if (Hdr.Pe32->Signature != EFI_IMAGE_NT_SIGNATURE) {\r
     Status = EFI_UNSUPPORTED;\r
     goto Finish;\r
@@ -179,19 +179,19 @@ MeasurePeImageAndExtend (
   // 3.  Calculate the distance from the base of the image header to the image checksum address.\r
   // 4.  Hash the image header from its base to beginning of the image checksum.\r
   //\r
-  HashBase = (UINT8 *) (UINTN) ImageAddress;\r
+  HashBase = (UINT8 *)(UINTN)ImageAddress;\r
   if (Hdr.Pe32->OptionalHeader.Magic == EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC) {\r
     //\r
     // Use PE32 offset\r
     //\r
     NumberOfRvaAndSizes = Hdr.Pe32->OptionalHeader.NumberOfRvaAndSizes;\r
-    HashSize = (UINTN) (&Hdr.Pe32->OptionalHeader.CheckSum) - (UINTN) HashBase;\r
+    HashSize            = (UINTN)(&Hdr.Pe32->OptionalHeader.CheckSum) - (UINTN)HashBase;\r
   } else {\r
     //\r
     // Use PE32+ offset\r
     //\r
     NumberOfRvaAndSizes = Hdr.Pe32Plus->OptionalHeader.NumberOfRvaAndSizes;\r
-    HashSize = (UINTN) (&Hdr.Pe32Plus->OptionalHeader.CheckSum) - (UINTN) HashBase;\r
+    HashSize            = (UINTN)(&Hdr.Pe32Plus->OptionalHeader.CheckSum) - (UINTN)HashBase;\r
   }\r
 \r
   Status = HashUpdate (HashHandle, HashBase, HashSize);\r
@@ -211,18 +211,18 @@ MeasurePeImageAndExtend (
       //\r
       // Use PE32 offset.\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = Hdr.Pe32->OptionalHeader.SizeOfHeaders - (UINTN) (HashBase - ImageAddress);\r
+      HashBase = (UINT8 *)&Hdr.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = Hdr.Pe32->OptionalHeader.SizeOfHeaders - (UINTN)(HashBase - ImageAddress);\r
     } else {\r
       //\r
       // Use PE32+ offset.\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = Hdr.Pe32Plus->OptionalHeader.SizeOfHeaders - (UINTN) (HashBase - ImageAddress);\r
+      HashBase = (UINT8 *)&Hdr.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = Hdr.Pe32Plus->OptionalHeader.SizeOfHeaders - (UINTN)(HashBase - ImageAddress);\r
     }\r
 \r
     if (HashSize != 0) {\r
-      Status  = HashUpdate (HashHandle, HashBase, HashSize);\r
+      Status = HashUpdate (HashHandle, HashBase, HashSize);\r
       if (EFI_ERROR (Status)) {\r
         goto Finish;\r
       }\r
@@ -235,18 +235,18 @@ MeasurePeImageAndExtend (
       //\r
       // Use PE32 offset\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = (UINTN) (&Hdr.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN) HashBase;\r
+      HashBase = (UINT8 *)&Hdr.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = (UINTN)(&Hdr.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN)HashBase;\r
     } else {\r
       //\r
       // Use PE32+ offset\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
-      HashSize = (UINTN) (&Hdr.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN) HashBase;\r
+      HashBase = (UINT8 *)&Hdr.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
+      HashSize = (UINTN)(&Hdr.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN)HashBase;\r
     }\r
 \r
     if (HashSize != 0) {\r
-      Status  = HashUpdate (HashHandle, HashBase, HashSize);\r
+      Status = HashUpdate (HashHandle, HashBase, HashSize);\r
       if (EFI_ERROR (Status)) {\r
         goto Finish;\r
       }\r
@@ -260,18 +260,18 @@ MeasurePeImageAndExtend (
       //\r
       // Use PE32 offset\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
-      HashSize = Hdr.Pe32->OptionalHeader.SizeOfHeaders - (UINTN) (HashBase - ImageAddress);\r
+      HashBase = (UINT8 *)&Hdr.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
+      HashSize = Hdr.Pe32->OptionalHeader.SizeOfHeaders - (UINTN)(HashBase - ImageAddress);\r
     } else {\r
       //\r
       // Use PE32+ offset\r
       //\r
-      HashBase = (UINT8 *) &Hdr.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
-      HashSize = Hdr.Pe32Plus->OptionalHeader.SizeOfHeaders - (UINTN) (HashBase - ImageAddress);\r
+      HashBase = (UINT8 *)&Hdr.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
+      HashSize = Hdr.Pe32Plus->OptionalHeader.SizeOfHeaders - (UINTN)(HashBase - ImageAddress);\r
     }\r
 \r
     if (HashSize != 0) {\r
-      Status  = HashUpdate (HashHandle, HashBase, HashSize);\r
+      Status = HashUpdate (HashHandle, HashBase, HashSize);\r
       if (EFI_ERROR (Status)) {\r
         goto Finish;\r
       }\r
@@ -299,7 +299,7 @@ MeasurePeImageAndExtend (
   //     header indicates how big the table should be. Do not include any\r
   //     IMAGE_SECTION_HEADERs in the table whose 'SizeOfRawData' field is zero.\r
   //\r
-  SectionHeader = (EFI_IMAGE_SECTION_HEADER *) AllocateZeroPool (sizeof (EFI_IMAGE_SECTION_HEADER) * Hdr.Pe32->FileHeader.NumberOfSections);\r
+  SectionHeader = (EFI_IMAGE_SECTION_HEADER *)AllocateZeroPool (sizeof (EFI_IMAGE_SECTION_HEADER) * Hdr.Pe32->FileHeader.NumberOfSections);\r
   if (SectionHeader == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto Finish;\r
@@ -311,20 +311,21 @@ MeasurePeImageAndExtend (
   //      words, sort the section headers according to the disk-file offset of\r
   //      the section.\r
   //\r
-  Section = (EFI_IMAGE_SECTION_HEADER *) (\r
-               (UINT8 *) (UINTN) ImageAddress +\r
-               PeCoffHeaderOffset +\r
-               sizeof(UINT32) +\r
-               sizeof(EFI_IMAGE_FILE_HEADER) +\r
-               Hdr.Pe32->FileHeader.SizeOfOptionalHeader\r
-               );\r
+  Section = (EFI_IMAGE_SECTION_HEADER *)(\r
+                                         (UINT8 *)(UINTN)ImageAddress +\r
+                                         PeCoffHeaderOffset +\r
+                                         sizeof (UINT32) +\r
+                                         sizeof (EFI_IMAGE_FILE_HEADER) +\r
+                                         Hdr.Pe32->FileHeader.SizeOfOptionalHeader\r
+                                         );\r
   for (Index = 0; Index < Hdr.Pe32->FileHeader.NumberOfSections; Index++) {\r
     Pos = Index;\r
     while ((Pos > 0) && (Section->PointerToRawData < SectionHeader[Pos - 1].PointerToRawData)) {\r
-      CopyMem (&SectionHeader[Pos], &SectionHeader[Pos - 1], sizeof(EFI_IMAGE_SECTION_HEADER));\r
+      CopyMem (&SectionHeader[Pos], &SectionHeader[Pos - 1], sizeof (EFI_IMAGE_SECTION_HEADER));\r
       Pos--;\r
     }\r
-    CopyMem (&SectionHeader[Pos], Section, sizeof(EFI_IMAGE_SECTION_HEADER));\r
+\r
+    CopyMem (&SectionHeader[Pos], Section, sizeof (EFI_IMAGE_SECTION_HEADER));\r
     Section += 1;\r
   }\r
 \r
@@ -336,12 +337,13 @@ MeasurePeImageAndExtend (
   // 15.  Repeat steps 13 and 14 for all the sections in the sorted table.\r
   //\r
   for (Index = 0; Index < Hdr.Pe32->FileHeader.NumberOfSections; Index++) {\r
-    Section  = (EFI_IMAGE_SECTION_HEADER *) &SectionHeader[Index];\r
+    Section = (EFI_IMAGE_SECTION_HEADER *)&SectionHeader[Index];\r
     if (Section->SizeOfRawData == 0) {\r
       continue;\r
     }\r
-    HashBase = (UINT8 *) (UINTN) ImageAddress + Section->PointerToRawData;\r
-    HashSize = (UINTN) Section->SizeOfRawData;\r
+\r
+    HashBase = (UINT8 *)(UINTN)ImageAddress + Section->PointerToRawData;\r
+    HashSize = (UINTN)Section->SizeOfRawData;\r
 \r
     Status = HashUpdate (HashHandle, HashBase, HashSize);\r
     if (EFI_ERROR (Status)) {\r
@@ -358,7 +360,7 @@ MeasurePeImageAndExtend (
   //             FileSize  -  (CertDirectory->Size)\r
   //\r
   if (ImageSize > SumOfBytesHashed) {\r
-    HashBase = (UINT8 *) (UINTN) ImageAddress + SumOfBytesHashed;\r
+    HashBase = (UINT8 *)(UINTN)ImageAddress + SumOfBytesHashed;\r
 \r
     if (NumberOfRvaAndSizes <= EFI_IMAGE_DIRECTORY_ENTRY_SECURITY) {\r
       CertSize = 0;\r
@@ -377,7 +379,7 @@ MeasurePeImageAndExtend (
     }\r
 \r
     if (ImageSize > CertSize + SumOfBytesHashed) {\r
-      HashSize = (UINTN) (ImageSize - CertSize - SumOfBytesHashed);\r
+      HashSize = (UINTN)(ImageSize - CertSize - SumOfBytesHashed);\r
 \r
       Status = HashUpdate (HashHandle, HashBase, HashSize);\r
       if (EFI_ERROR (Status)) {\r
index 2dc6d11e39ad4aa3e2f5f7c9b5061e856e997902..f6ea8b2bbf189267289c378f53322f6808e8d4c3 100644 (file)
@@ -48,72 +48,72 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define PERF_ID_TCG2_DXE  0x3120\r
 \r
 typedef struct {\r
-  CHAR16                                 *VariableName;\r
-  EFI_GUID                               *VendorGuid;\r
+  CHAR16      *VariableName;\r
+  EFI_GUID    *VendorGuid;\r
 } VARIABLE_TYPE;\r
 \r
-#define  TCG2_DEFAULT_MAX_COMMAND_SIZE        0x1000\r
-#define  TCG2_DEFAULT_MAX_RESPONSE_SIZE       0x1000\r
+#define  TCG2_DEFAULT_MAX_COMMAND_SIZE   0x1000\r
+#define  TCG2_DEFAULT_MAX_RESPONSE_SIZE  0x1000\r
 \r
 typedef struct {\r
-  EFI_GUID               *EventGuid;\r
-  EFI_TCG2_EVENT_LOG_FORMAT  LogFormat;\r
+  EFI_GUID                     *EventGuid;\r
+  EFI_TCG2_EVENT_LOG_FORMAT    LogFormat;\r
 } TCG2_EVENT_INFO_STRUCT;\r
 \r
-TCG2_EVENT_INFO_STRUCT mTcg2EventInfo[] = {\r
-  {&gTcgEventEntryHobGuid,             EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2},\r
-  {&gTcgEvent2EntryHobGuid,            EFI_TCG2_EVENT_LOG_FORMAT_TCG_2},\r
+TCG2_EVENT_INFO_STRUCT  mTcg2EventInfo[] = {\r
+  { &gTcgEventEntryHobGuid,  EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2 },\r
+  { &gTcgEvent2EntryHobGuid, EFI_TCG2_EVENT_LOG_FORMAT_TCG_2   },\r
 };\r
 \r
-#define TCG_EVENT_LOG_AREA_COUNT_MAX   2\r
+#define TCG_EVENT_LOG_AREA_COUNT_MAX  2\r
 \r
 typedef struct {\r
-  EFI_TCG2_EVENT_LOG_FORMAT         EventLogFormat;\r
-  EFI_PHYSICAL_ADDRESS              Lasa;\r
-  UINT64                            Laml;\r
-  UINTN                             EventLogSize;\r
-  UINT8                             *LastEvent;\r
-  BOOLEAN                           EventLogStarted;\r
-  BOOLEAN                           EventLogTruncated;\r
-  UINTN                             Next800155EventOffset;\r
+  EFI_TCG2_EVENT_LOG_FORMAT    EventLogFormat;\r
+  EFI_PHYSICAL_ADDRESS         Lasa;\r
+  UINT64                       Laml;\r
+  UINTN                        EventLogSize;\r
+  UINT8                        *LastEvent;\r
+  BOOLEAN                      EventLogStarted;\r
+  BOOLEAN                      EventLogTruncated;\r
+  UINTN                        Next800155EventOffset;\r
 } TCG_EVENT_LOG_AREA_STRUCT;\r
 \r
 typedef struct _TCG_DXE_DATA {\r
-  EFI_TCG2_BOOT_SERVICE_CAPABILITY  BsCap;\r
-  TCG_EVENT_LOG_AREA_STRUCT         EventLogAreaStruct[TCG_EVENT_LOG_AREA_COUNT_MAX];\r
-  BOOLEAN                           GetEventLogCalled[TCG_EVENT_LOG_AREA_COUNT_MAX];\r
-  TCG_EVENT_LOG_AREA_STRUCT         FinalEventLogAreaStruct[TCG_EVENT_LOG_AREA_COUNT_MAX];\r
-  EFI_TCG2_FINAL_EVENTS_TABLE       *FinalEventsTable[TCG_EVENT_LOG_AREA_COUNT_MAX];\r
+  EFI_TCG2_BOOT_SERVICE_CAPABILITY    BsCap;\r
+  TCG_EVENT_LOG_AREA_STRUCT           EventLogAreaStruct[TCG_EVENT_LOG_AREA_COUNT_MAX];\r
+  BOOLEAN                             GetEventLogCalled[TCG_EVENT_LOG_AREA_COUNT_MAX];\r
+  TCG_EVENT_LOG_AREA_STRUCT           FinalEventLogAreaStruct[TCG_EVENT_LOG_AREA_COUNT_MAX];\r
+  EFI_TCG2_FINAL_EVENTS_TABLE         *FinalEventsTable[TCG_EVENT_LOG_AREA_COUNT_MAX];\r
 } TCG_DXE_DATA;\r
 \r
-TCG_DXE_DATA                 mTcgDxeData = {\r
+TCG_DXE_DATA  mTcgDxeData = {\r
   {\r
-    sizeof (EFI_TCG2_BOOT_SERVICE_CAPABILITY),     // Size\r
-    { 1, 1 },                           // StructureVersion\r
-    { 1, 1 },                           // ProtocolVersion\r
-    EFI_TCG2_BOOT_HASH_ALG_SHA1,        // HashAlgorithmBitmap\r
-    EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2,  // SupportedEventLogs\r
-    TRUE,                               // TPMPresentFlag\r
-    TCG2_DEFAULT_MAX_COMMAND_SIZE,      // MaxCommandSize\r
-    TCG2_DEFAULT_MAX_RESPONSE_SIZE,     // MaxResponseSize\r
-    0,                                  // ManufacturerID\r
-    0,  // NumberOfPCRBanks\r
-    0,  // ActivePcrBanks\r
+    sizeof (EFI_TCG2_BOOT_SERVICE_CAPABILITY), // Size\r
+    { 1, 1 },                                  // StructureVersion\r
+    { 1, 1 },                                  // ProtocolVersion\r
+    EFI_TCG2_BOOT_HASH_ALG_SHA1,               // HashAlgorithmBitmap\r
+    EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2,         // SupportedEventLogs\r
+    TRUE,                                      // TPMPresentFlag\r
+    TCG2_DEFAULT_MAX_COMMAND_SIZE,             // MaxCommandSize\r
+    TCG2_DEFAULT_MAX_RESPONSE_SIZE,            // MaxResponseSize\r
+    0,                                         // ManufacturerID\r
+    0,                                         // NumberOfPCRBanks\r
+    0,                                         // ActivePcrBanks\r
   },\r
 };\r
 \r
-UINTN  mBootAttempts  = 0;\r
-CHAR16 mBootVarName[] = L"BootOrder";\r
+UINTN   mBootAttempts  = 0;\r
+CHAR16  mBootVarName[] = L"BootOrder";\r
 \r
 VARIABLE_TYPE  mVariableType[] = {\r
-  {EFI_SECURE_BOOT_MODE_NAME,    &gEfiGlobalVariableGuid},\r
-  {EFI_PLATFORM_KEY_NAME,        &gEfiGlobalVariableGuid},\r
-  {EFI_KEY_EXCHANGE_KEY_NAME,    &gEfiGlobalVariableGuid},\r
-  {EFI_IMAGE_SECURITY_DATABASE,  &gEfiImageSecurityDatabaseGuid},\r
-  {EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid},\r
+  { EFI_SECURE_BOOT_MODE_NAME,    &gEfiGlobalVariableGuid        },\r
+  { EFI_PLATFORM_KEY_NAME,        &gEfiGlobalVariableGuid        },\r
+  { EFI_KEY_EXCHANGE_KEY_NAME,    &gEfiGlobalVariableGuid        },\r
+  { EFI_IMAGE_SECURITY_DATABASE,  &gEfiImageSecurityDatabaseGuid },\r
+  { EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid },\r
 };\r
 \r
-EFI_HANDLE mImageHandle;\r
+EFI_HANDLE  mImageHandle;\r
 \r
 /**\r
   Measure PE image into TPM log based on the authenticode image hashing in\r
@@ -136,10 +136,10 @@ EFI_HANDLE mImageHandle;
 **/\r
 EFI_STATUS\r
 MeasurePeImageAndExtend (\r
-  IN  UINT32                    PCRIndex,\r
-  IN  EFI_PHYSICAL_ADDRESS      ImageAddress,\r
-  IN  UINTN                     ImageSize,\r
-  OUT TPML_DIGEST_VALUES        *DigestList\r
+  IN  UINT32                PCRIndex,\r
+  IN  EFI_PHYSICAL_ADDRESS  ImageAddress,\r
+  IN  UINTN                 ImageSize,\r
+  OUT TPML_DIGEST_VALUES    *DigestList\r
   );\r
 \r
 /**\r
@@ -157,6 +157,7 @@ InternalDumpData (
   )\r
 {\r
   UINTN  Index;\r
+\r
   for (Index = 0; Index < Size; Index++) {\r
     DEBUG ((DEBUG_INFO, "%02x", (UINTN)Data[Index]));\r
   }\r
@@ -175,11 +176,11 @@ VOID
 InitNoActionEvent (\r
   IN OUT TCG_PCR_EVENT2_HDR  *NoActionEvent,\r
   IN UINT32                  EventSize\r
- )\r
 )\r
 {\r
-  UINT32          DigestListCount;\r
-  TPMI_ALG_HASH   HashAlgId;\r
-  UINT8           *DigestBuffer;\r
+  UINT32         DigestListCount;\r
+  TPMI_ALG_HASH  HashAlgId;\r
+  UINT8          *DigestBuffer;\r
 \r
   DigestBuffer    = (UINT8 *)NoActionEvent->Digests.digests;\r
   DigestListCount = 0;\r
@@ -190,40 +191,40 @@ InitNoActionEvent (
   //\r
   // Set Hash count & hashAlg accordingly, while Digest.digests[n].digest to all 0\r
   //\r
-  ZeroMem (&NoActionEvent->Digests, sizeof(NoActionEvent->Digests));\r
+  ZeroMem (&NoActionEvent->Digests, sizeof (NoActionEvent->Digests));\r
 \r
   if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SHA1) != 0) {\r
-     HashAlgId = TPM_ALG_SHA1;\r
-     CopyMem (DigestBuffer, &HashAlgId, sizeof(TPMI_ALG_HASH));\r
-     DigestBuffer += sizeof(TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
-     DigestListCount++;\r
+    HashAlgId = TPM_ALG_SHA1;\r
+    CopyMem (DigestBuffer, &HashAlgId, sizeof (TPMI_ALG_HASH));\r
+    DigestBuffer += sizeof (TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
+    DigestListCount++;\r
   }\r
 \r
   if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SHA256) != 0) {\r
-     HashAlgId = TPM_ALG_SHA256;\r
-     CopyMem (DigestBuffer, &HashAlgId, sizeof(TPMI_ALG_HASH));\r
-     DigestBuffer += sizeof(TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
-     DigestListCount++;\r
+    HashAlgId = TPM_ALG_SHA256;\r
+    CopyMem (DigestBuffer, &HashAlgId, sizeof (TPMI_ALG_HASH));\r
+    DigestBuffer += sizeof (TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
+    DigestListCount++;\r
   }\r
 \r
   if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SHA384) != 0) {\r
     HashAlgId = TPM_ALG_SHA384;\r
-    CopyMem (DigestBuffer, &HashAlgId, sizeof(TPMI_ALG_HASH));\r
-    DigestBuffer += sizeof(TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
+    CopyMem (DigestBuffer, &HashAlgId, sizeof (TPMI_ALG_HASH));\r
+    DigestBuffer += sizeof (TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
     DigestListCount++;\r
   }\r
 \r
   if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SHA512) != 0) {\r
     HashAlgId = TPM_ALG_SHA512;\r
-    CopyMem (DigestBuffer, &HashAlgId, sizeof(TPMI_ALG_HASH));\r
-    DigestBuffer += sizeof(TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
+    CopyMem (DigestBuffer, &HashAlgId, sizeof (TPMI_ALG_HASH));\r
+    DigestBuffer += sizeof (TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
     DigestListCount++;\r
   }\r
 \r
   if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SM3_256) != 0) {\r
     HashAlgId = TPM_ALG_SM3_256;\r
-    CopyMem (DigestBuffer, &HashAlgId, sizeof(TPMI_ALG_HASH));\r
-    DigestBuffer += sizeof(TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
+    CopyMem (DigestBuffer, &HashAlgId, sizeof (TPMI_ALG_HASH));\r
+    DigestBuffer += sizeof (TPMI_ALG_HASH) + GetHashSizeFromAlgo (HashAlgId);\r
     DigestListCount++;\r
   }\r
 \r
@@ -235,7 +236,7 @@ InitNoActionEvent (
   //\r
   // Set Event Size\r
   //\r
-  WriteUnaligned32((UINT32 *)DigestBuffer, EventSize);\r
+  WriteUnaligned32 ((UINT32 *)DigestBuffer, EventSize);\r
 }\r
 \r
 /**\r
@@ -252,11 +253,11 @@ InternalDumpHex (
   IN UINTN  Size\r
   )\r
 {\r
-  UINTN   Index;\r
-  UINTN   Count;\r
-  UINTN   Left;\r
+  UINTN  Index;\r
+  UINTN  Count;\r
+  UINTN  Left;\r
 \r
-#define COLUME_SIZE  (16 * 2)\r
+  #define COLUME_SIZE  (16 * 2)\r
 \r
   Count = Size / COLUME_SIZE;\r
   Left  = Size % COLUME_SIZE;\r
@@ -286,19 +287,19 @@ InternalDumpHex (
 **/\r
 EFI_STATUS\r
 GetProcessorsCpuLocation (\r
-    OUT  EFI_CPU_PHYSICAL_LOCATION   **LocationBuf,\r
-    OUT  UINTN                       *Num\r
+  OUT  EFI_CPU_PHYSICAL_LOCATION  **LocationBuf,\r
+  OUT  UINTN                      *Num\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_MP_SERVICES_PROTOCOL          *MpProtocol;\r
-  UINTN                             ProcessorNum;\r
-  UINTN                             EnabledProcessorNum;\r
-  EFI_PROCESSOR_INFORMATION         ProcessorInfo;\r
-  EFI_CPU_PHYSICAL_LOCATION         *ProcessorLocBuf;\r
-  UINTN                             Index;\r
-\r
-  Status = gBS->LocateProtocol (&gEfiMpServiceProtocolGuid, NULL, (VOID **) &MpProtocol);\r
+  EFI_STATUS                 Status;\r
+  EFI_MP_SERVICES_PROTOCOL   *MpProtocol;\r
+  UINTN                      ProcessorNum;\r
+  UINTN                      EnabledProcessorNum;\r
+  EFI_PROCESSOR_INFORMATION  ProcessorInfo;\r
+  EFI_CPU_PHYSICAL_LOCATION  *ProcessorLocBuf;\r
+  UINTN                      Index;\r
+\r
+  Status = gBS->LocateProtocol (&gEfiMpServiceProtocolGuid, NULL, (VOID **)&MpProtocol);\r
   if (EFI_ERROR (Status)) {\r
     //\r
     // MP protocol is not installed\r
@@ -306,21 +307,21 @@ GetProcessorsCpuLocation (
     return EFI_UNSUPPORTED;\r
   }\r
 \r
-  Status = MpProtocol->GetNumberOfProcessors(\r
+  Status = MpProtocol->GetNumberOfProcessors (\r
                          MpProtocol,\r
                          &ProcessorNum,\r
                          &EnabledProcessorNum\r
                          );\r
-  if (EFI_ERROR(Status)){\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  Status = gBS->AllocatePool(\r
+  Status = gBS->AllocatePool (\r
                   EfiBootServicesData,\r
-                  sizeof(EFI_CPU_PHYSICAL_LOCATION) * ProcessorNum,\r
-                  (VOID **) &ProcessorLocBuf\r
+                  sizeof (EFI_CPU_PHYSICAL_LOCATION) * ProcessorNum,\r
+                  (VOID **)&ProcessorLocBuf\r
                   );\r
-  if (EFI_ERROR(Status)){\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
@@ -328,28 +329,28 @@ GetProcessorsCpuLocation (
   // Get each processor Location info\r
   //\r
   for (Index = 0; Index < ProcessorNum; Index++) {\r
-    Status = MpProtocol->GetProcessorInfo(\r
+    Status = MpProtocol->GetProcessorInfo (\r
                            MpProtocol,\r
                            Index,\r
                            &ProcessorInfo\r
                            );\r
-    if (EFI_ERROR(Status)){\r
-      FreePool(ProcessorLocBuf);\r
+    if (EFI_ERROR (Status)) {\r
+      FreePool (ProcessorLocBuf);\r
       return Status;\r
     }\r
 \r
     //\r
     // Get all Processor Location info & measure\r
     //\r
-    CopyMem(\r
+    CopyMem (\r
       &ProcessorLocBuf[Index],\r
       &ProcessorInfo.Location,\r
-      sizeof(EFI_CPU_PHYSICAL_LOCATION)\r
+      sizeof (EFI_CPU_PHYSICAL_LOCATION)\r
       );\r
   }\r
 \r
   *LocationBuf = ProcessorLocBuf;\r
-  *Num = ProcessorNum;\r
+  *Num         = ProcessorNum;\r
 \r
   return Status;\r
 }\r
@@ -376,8 +377,8 @@ GetProcessorsCpuLocation (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2GetCapability (\r
-  IN EFI_TCG2_PROTOCOL                    *This,\r
-  IN OUT EFI_TCG2_BOOT_SERVICE_CAPABILITY *ProtocolCapability\r
+  IN EFI_TCG2_PROTOCOL                     *This,\r
+  IN OUT EFI_TCG2_BOOT_SERVICE_CAPABILITY  *ProtocolCapability\r
   )\r
 {\r
   DEBUG ((DEBUG_VERBOSE, "Tcg2GetCapability ...\n"));\r
@@ -387,25 +388,27 @@ Tcg2GetCapability (
   }\r
 \r
   DEBUG ((DEBUG_VERBOSE, "Size - 0x%x\n", ProtocolCapability->Size));\r
-  DEBUG ((DEBUG_VERBOSE, " 1.1 - 0x%x, 1.0 - 0x%x\n", sizeof(EFI_TCG2_BOOT_SERVICE_CAPABILITY), sizeof(TREE_BOOT_SERVICE_CAPABILITY_1_0)));\r
+  DEBUG ((DEBUG_VERBOSE, " 1.1 - 0x%x, 1.0 - 0x%x\n", sizeof (EFI_TCG2_BOOT_SERVICE_CAPABILITY), sizeof (TREE_BOOT_SERVICE_CAPABILITY_1_0)));\r
 \r
   if (ProtocolCapability->Size < mTcgDxeData.BsCap.Size) {\r
     //\r
     // Handle the case that firmware support 1.1 but OS only support 1.0.\r
     //\r
     if ((mTcgDxeData.BsCap.ProtocolVersion.Major > 0x01) ||\r
-        ((mTcgDxeData.BsCap.ProtocolVersion.Major == 0x01) && ((mTcgDxeData.BsCap.ProtocolVersion.Minor > 0x00)))) {\r
-      if (ProtocolCapability->Size >= sizeof(TREE_BOOT_SERVICE_CAPABILITY_1_0)) {\r
-        CopyMem (ProtocolCapability, &mTcgDxeData.BsCap, sizeof(TREE_BOOT_SERVICE_CAPABILITY_1_0));\r
-        ProtocolCapability->Size = sizeof(TREE_BOOT_SERVICE_CAPABILITY_1_0);\r
+        ((mTcgDxeData.BsCap.ProtocolVersion.Major == 0x01) && ((mTcgDxeData.BsCap.ProtocolVersion.Minor > 0x00))))\r
+    {\r
+      if (ProtocolCapability->Size >= sizeof (TREE_BOOT_SERVICE_CAPABILITY_1_0)) {\r
+        CopyMem (ProtocolCapability, &mTcgDxeData.BsCap, sizeof (TREE_BOOT_SERVICE_CAPABILITY_1_0));\r
+        ProtocolCapability->Size                   = sizeof (TREE_BOOT_SERVICE_CAPABILITY_1_0);\r
         ProtocolCapability->StructureVersion.Major = 1;\r
         ProtocolCapability->StructureVersion.Minor = 0;\r
-        ProtocolCapability->ProtocolVersion.Major = 1;\r
-        ProtocolCapability->ProtocolVersion.Minor = 0;\r
+        ProtocolCapability->ProtocolVersion.Major  = 1;\r
+        ProtocolCapability->ProtocolVersion.Minor  = 0;\r
         DEBUG ((DEBUG_ERROR, "TreeGetCapability (Compatible) - %r\n", EFI_SUCCESS));\r
         return EFI_SUCCESS;\r
       }\r
     }\r
+\r
     ProtocolCapability->Size = mTcgDxeData.BsCap.Size;\r
     return EFI_BUFFER_TOO_SMALL;\r
   }\r
@@ -422,18 +425,19 @@ Tcg2GetCapability (
 **/\r
 VOID\r
 DumpEvent (\r
-  IN TCG_PCR_EVENT_HDR         *EventHdr\r
+  IN TCG_PCR_EVENT_HDR  *EventHdr\r
   )\r
 {\r
-  UINTN                     Index;\r
+  UINTN  Index;\r
 \r
   DEBUG ((DEBUG_INFO, "  Event:\n"));\r
   DEBUG ((DEBUG_INFO, "    PCRIndex  - %d\n", EventHdr->PCRIndex));\r
   DEBUG ((DEBUG_INFO, "    EventType - 0x%08x\n", EventHdr->EventType));\r
   DEBUG ((DEBUG_INFO, "    Digest    - "));\r
-  for (Index = 0; Index < sizeof(TCG_DIGEST); Index++) {\r
+  for (Index = 0; Index < sizeof (TCG_DIGEST); Index++) {\r
     DEBUG ((DEBUG_INFO, "%02x ", EventHdr->Digest.digest[Index]));\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "\n"));\r
   DEBUG ((DEBUG_INFO, "    EventSize - 0x%08x\n", EventHdr->EventSize));\r
   InternalDumpHex ((UINT8 *)(EventHdr + 1), EventHdr->EventSize);\r
@@ -446,7 +450,7 @@ DumpEvent (
 **/\r
 VOID\r
 DumpTcgEfiSpecIdEventStruct (\r
-  IN TCG_EfiSpecIDEventStruct   *TcgEfiSpecIdEventStruct\r
+  IN TCG_EfiSpecIDEventStruct  *TcgEfiSpecIdEventStruct\r
   )\r
 {\r
   TCG_EfiSpecIdEventAlgorithmSize  *DigestSize;\r
@@ -457,23 +461,25 @@ DumpTcgEfiSpecIdEventStruct (
 \r
   DEBUG ((DEBUG_INFO, "  TCG_EfiSpecIDEventStruct:\n"));\r
   DEBUG ((DEBUG_INFO, "    signature          - '"));\r
-  for (Index = 0; Index < sizeof(TcgEfiSpecIdEventStruct->signature); Index++) {\r
+  for (Index = 0; Index < sizeof (TcgEfiSpecIdEventStruct->signature); Index++) {\r
     DEBUG ((DEBUG_INFO, "%c", TcgEfiSpecIdEventStruct->signature[Index]));\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "'\n"));\r
   DEBUG ((DEBUG_INFO, "    platformClass      - 0x%08x\n", TcgEfiSpecIdEventStruct->platformClass));\r
   DEBUG ((DEBUG_INFO, "    specVersion        - %d.%d%d\n", TcgEfiSpecIdEventStruct->specVersionMajor, TcgEfiSpecIdEventStruct->specVersionMinor, TcgEfiSpecIdEventStruct->specErrata));\r
   DEBUG ((DEBUG_INFO, "    uintnSize          - 0x%02x\n", TcgEfiSpecIdEventStruct->uintnSize));\r
 \r
-  CopyMem (&NumberOfAlgorithms, TcgEfiSpecIdEventStruct + 1, sizeof(NumberOfAlgorithms));\r
+  CopyMem (&NumberOfAlgorithms, TcgEfiSpecIdEventStruct + 1, sizeof (NumberOfAlgorithms));\r
   DEBUG ((DEBUG_INFO, "    NumberOfAlgorithms - 0x%08x\n", NumberOfAlgorithms));\r
 \r
-  DigestSize = (TCG_EfiSpecIdEventAlgorithmSize *)((UINT8 *)TcgEfiSpecIdEventStruct + sizeof(*TcgEfiSpecIdEventStruct) + sizeof(NumberOfAlgorithms));\r
+  DigestSize = (TCG_EfiSpecIdEventAlgorithmSize *)((UINT8 *)TcgEfiSpecIdEventStruct + sizeof (*TcgEfiSpecIdEventStruct) + sizeof (NumberOfAlgorithms));\r
   for (Index = 0; Index < NumberOfAlgorithms; Index++) {\r
     DEBUG ((DEBUG_INFO, "    digest(%d)\n", Index));\r
     DEBUG ((DEBUG_INFO, "      algorithmId      - 0x%04x\n", DigestSize[Index].algorithmId));\r
     DEBUG ((DEBUG_INFO, "      digestSize       - 0x%04x\n", DigestSize[Index].digestSize));\r
   }\r
+\r
   VendorInfoSize = (UINT8 *)&DigestSize[NumberOfAlgorithms];\r
   DEBUG ((DEBUG_INFO, "    VendorInfoSize     - 0x%02x\n", *VendorInfoSize));\r
   VendorInfo = VendorInfoSize + 1;\r
@@ -481,6 +487,7 @@ DumpTcgEfiSpecIdEventStruct (
   for (Index = 0; Index < *VendorInfoSize; Index++) {\r
     DEBUG ((DEBUG_INFO, "%02x ", VendorInfo[Index]));\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "\n"));\r
 }\r
 \r
@@ -491,18 +498,18 @@ DumpTcgEfiSpecIdEventStruct (
 **/\r
 UINTN\r
 GetTcgEfiSpecIdEventStructSize (\r
-  IN TCG_EfiSpecIDEventStruct   *TcgEfiSpecIdEventStruct\r
+  IN TCG_EfiSpecIDEventStruct  *TcgEfiSpecIdEventStruct\r
   )\r
 {\r
   TCG_EfiSpecIdEventAlgorithmSize  *DigestSize;\r
   UINT8                            *VendorInfoSize;\r
   UINT32                           NumberOfAlgorithms;\r
 \r
-  CopyMem (&NumberOfAlgorithms, TcgEfiSpecIdEventStruct + 1, sizeof(NumberOfAlgorithms));\r
+  CopyMem (&NumberOfAlgorithms, TcgEfiSpecIdEventStruct + 1, sizeof (NumberOfAlgorithms));\r
 \r
-  DigestSize = (TCG_EfiSpecIdEventAlgorithmSize *)((UINT8 *)TcgEfiSpecIdEventStruct + sizeof(*TcgEfiSpecIdEventStruct) + sizeof(NumberOfAlgorithms));\r
+  DigestSize     = (TCG_EfiSpecIdEventAlgorithmSize *)((UINT8 *)TcgEfiSpecIdEventStruct + sizeof (*TcgEfiSpecIdEventStruct) + sizeof (NumberOfAlgorithms));\r
   VendorInfoSize = (UINT8 *)&DigestSize[NumberOfAlgorithms];\r
-  return sizeof(TCG_EfiSpecIDEventStruct) + sizeof(UINT32) + (NumberOfAlgorithms * sizeof(TCG_EfiSpecIdEventAlgorithmSize)) + sizeof(UINT8) + (*VendorInfoSize);\r
+  return sizeof (TCG_EfiSpecIDEventStruct) + sizeof (UINT32) + (NumberOfAlgorithms * sizeof (TCG_EfiSpecIdEventAlgorithmSize)) + sizeof (UINT8) + (*VendorInfoSize);\r
 }\r
 \r
 /**\r
@@ -512,17 +519,17 @@ GetTcgEfiSpecIdEventStructSize (
 **/\r
 VOID\r
 DumpEvent2 (\r
-  IN TCG_PCR_EVENT2        *TcgPcrEvent2\r
+  IN TCG_PCR_EVENT2  *TcgPcrEvent2\r
   )\r
 {\r
-  UINTN                     Index;\r
-  UINT32                    DigestIndex;\r
-  UINT32                    DigestCount;\r
-  TPMI_ALG_HASH             HashAlgo;\r
-  UINT32                    DigestSize;\r
-  UINT8                     *DigestBuffer;\r
-  UINT32                    EventSize;\r
-  UINT8                     *EventBuffer;\r
+  UINTN          Index;\r
+  UINT32         DigestIndex;\r
+  UINT32         DigestCount;\r
+  TPMI_ALG_HASH  HashAlgo;\r
+  UINT32         DigestSize;\r
+  UINT8          *DigestBuffer;\r
+  UINT32         EventSize;\r
+  UINT8          *EventBuffer;\r
 \r
   DEBUG ((DEBUG_INFO, "  Event:\n"));\r
   DEBUG ((DEBUG_INFO, "    PCRIndex  - %d\n", TcgPcrEvent2->PCRIndex));\r
@@ -530,8 +537,8 @@ DumpEvent2 (
 \r
   DEBUG ((DEBUG_INFO, "    DigestCount: 0x%08x\n", TcgPcrEvent2->Digest.count));\r
 \r
-  DigestCount = TcgPcrEvent2->Digest.count;\r
-  HashAlgo = TcgPcrEvent2->Digest.digests[0].hashAlg;\r
+  DigestCount  = TcgPcrEvent2->Digest.count;\r
+  HashAlgo     = TcgPcrEvent2->Digest.digests[0].hashAlg;\r
   DigestBuffer = (UINT8 *)&TcgPcrEvent2->Digest.digests[0].digest;\r
   for (DigestIndex = 0; DigestIndex < DigestCount; DigestIndex++) {\r
     DEBUG ((DEBUG_INFO, "      HashAlgo : 0x%04x\n", HashAlgo));\r
@@ -540,19 +547,21 @@ DumpEvent2 (
     for (Index = 0; Index < DigestSize; Index++) {\r
       DEBUG ((DEBUG_INFO, "%02x ", DigestBuffer[Index]));\r
     }\r
+\r
     DEBUG ((DEBUG_INFO, "\n"));\r
     //\r
     // Prepare next\r
     //\r
-    CopyMem (&HashAlgo, DigestBuffer + DigestSize, sizeof(TPMI_ALG_HASH));\r
-    DigestBuffer = DigestBuffer + DigestSize + sizeof(TPMI_ALG_HASH);\r
+    CopyMem (&HashAlgo, DigestBuffer + DigestSize, sizeof (TPMI_ALG_HASH));\r
+    DigestBuffer = DigestBuffer + DigestSize + sizeof (TPMI_ALG_HASH);\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "\n"));\r
-  DigestBuffer = DigestBuffer - sizeof(TPMI_ALG_HASH);\r
+  DigestBuffer = DigestBuffer - sizeof (TPMI_ALG_HASH);\r
 \r
-  CopyMem (&EventSize, DigestBuffer, sizeof(TcgPcrEvent2->EventSize));\r
+  CopyMem (&EventSize, DigestBuffer, sizeof (TcgPcrEvent2->EventSize));\r
   DEBUG ((DEBUG_INFO, "    EventSize - 0x%08x\n", EventSize));\r
-  EventBuffer = DigestBuffer + sizeof(TcgPcrEvent2->EventSize);\r
+  EventBuffer = DigestBuffer + sizeof (TcgPcrEvent2->EventSize);\r
   InternalDumpHex (EventBuffer, EventSize);\r
 }\r
 \r
@@ -565,32 +574,33 @@ DumpEvent2 (
 **/\r
 UINTN\r
 GetPcrEvent2Size (\r
-  IN TCG_PCR_EVENT2        *TcgPcrEvent2\r
+  IN TCG_PCR_EVENT2  *TcgPcrEvent2\r
   )\r
 {\r
-  UINT32                    DigestIndex;\r
-  UINT32                    DigestCount;\r
-  TPMI_ALG_HASH             HashAlgo;\r
-  UINT32                    DigestSize;\r
-  UINT8                     *DigestBuffer;\r
-  UINT32                    EventSize;\r
-  UINT8                     *EventBuffer;\r
-\r
-  DigestCount = TcgPcrEvent2->Digest.count;\r
-  HashAlgo = TcgPcrEvent2->Digest.digests[0].hashAlg;\r
+  UINT32         DigestIndex;\r
+  UINT32         DigestCount;\r
+  TPMI_ALG_HASH  HashAlgo;\r
+  UINT32         DigestSize;\r
+  UINT8          *DigestBuffer;\r
+  UINT32         EventSize;\r
+  UINT8          *EventBuffer;\r
+\r
+  DigestCount  = TcgPcrEvent2->Digest.count;\r
+  HashAlgo     = TcgPcrEvent2->Digest.digests[0].hashAlg;\r
   DigestBuffer = (UINT8 *)&TcgPcrEvent2->Digest.digests[0].digest;\r
   for (DigestIndex = 0; DigestIndex < DigestCount; DigestIndex++) {\r
     DigestSize = GetHashSizeFromAlgo (HashAlgo);\r
     //\r
     // Prepare next\r
     //\r
-    CopyMem (&HashAlgo, DigestBuffer + DigestSize, sizeof(TPMI_ALG_HASH));\r
-    DigestBuffer = DigestBuffer + DigestSize + sizeof(TPMI_ALG_HASH);\r
+    CopyMem (&HashAlgo, DigestBuffer + DigestSize, sizeof (TPMI_ALG_HASH));\r
+    DigestBuffer = DigestBuffer + DigestSize + sizeof (TPMI_ALG_HASH);\r
   }\r
-  DigestBuffer = DigestBuffer - sizeof(TPMI_ALG_HASH);\r
 \r
-  CopyMem (&EventSize, DigestBuffer, sizeof(TcgPcrEvent2->EventSize));\r
-  EventBuffer = DigestBuffer + sizeof(TcgPcrEvent2->EventSize);\r
+  DigestBuffer = DigestBuffer - sizeof (TPMI_ALG_HASH);\r
+\r
+  CopyMem (&EventSize, DigestBuffer, sizeof (TcgPcrEvent2->EventSize));\r
+  EventBuffer = DigestBuffer + sizeof (TcgPcrEvent2->EventSize);\r
 \r
   return (UINTN)EventBuffer + EventSize - (UINTN)TcgPcrEvent2;\r
 }\r
@@ -606,10 +616,10 @@ GetPcrEvent2Size (
 **/\r
 VOID\r
 DumpEventLog (\r
-  IN EFI_TCG2_EVENT_LOG_FORMAT   EventLogFormat,\r
-  IN EFI_PHYSICAL_ADDRESS        EventLogLocation,\r
-  IN EFI_PHYSICAL_ADDRESS        EventLogLastEntry,\r
-  IN EFI_TCG2_FINAL_EVENTS_TABLE *FinalEventsTable\r
+  IN EFI_TCG2_EVENT_LOG_FORMAT    EventLogFormat,\r
+  IN EFI_PHYSICAL_ADDRESS         EventLogLocation,\r
+  IN EFI_PHYSICAL_ADDRESS         EventLogLastEntry,\r
+  IN EFI_TCG2_FINAL_EVENTS_TABLE  *FinalEventsTable\r
   )\r
 {\r
   TCG_PCR_EVENT_HDR         *EventHdr;\r
@@ -620,59 +630,62 @@ DumpEventLog (
   DEBUG ((DEBUG_INFO, "EventLogFormat: (0x%x)\n", EventLogFormat));\r
 \r
   switch (EventLogFormat) {\r
-  case EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2:\r
-    EventHdr = (TCG_PCR_EVENT_HDR *)(UINTN)EventLogLocation;\r
-    while ((UINTN)EventHdr <= EventLogLastEntry) {\r
-      DumpEvent (EventHdr);\r
-      EventHdr = (TCG_PCR_EVENT_HDR *)((UINTN)EventHdr + sizeof(TCG_PCR_EVENT_HDR) + EventHdr->EventSize);\r
-    }\r
-    if (FinalEventsTable == NULL) {\r
-      DEBUG ((DEBUG_INFO, "FinalEventsTable: NOT FOUND\n"));\r
-    } else {\r
-      DEBUG ((DEBUG_INFO, "FinalEventsTable:    (0x%x)\n", FinalEventsTable));\r
-      DEBUG ((DEBUG_INFO, "  Version:           (0x%x)\n", FinalEventsTable->Version));\r
-      DEBUG ((DEBUG_INFO, "  NumberOfEvents:    (0x%x)\n", FinalEventsTable->NumberOfEvents));\r
-\r
-      EventHdr = (TCG_PCR_EVENT_HDR *)(UINTN)(FinalEventsTable + 1);\r
-      for (NumberOfEvents = 0; NumberOfEvents < FinalEventsTable->NumberOfEvents; NumberOfEvents++) {\r
+    case EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2:\r
+      EventHdr = (TCG_PCR_EVENT_HDR *)(UINTN)EventLogLocation;\r
+      while ((UINTN)EventHdr <= EventLogLastEntry) {\r
         DumpEvent (EventHdr);\r
-        EventHdr = (TCG_PCR_EVENT_HDR *)((UINTN)EventHdr + sizeof(TCG_PCR_EVENT_HDR) + EventHdr->EventSize);\r
+        EventHdr = (TCG_PCR_EVENT_HDR *)((UINTN)EventHdr + sizeof (TCG_PCR_EVENT_HDR) + EventHdr->EventSize);\r
       }\r
-    }\r
-    break;\r
-  case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:\r
-    //\r
-    // Dump first event\r
-    //\r
-    EventHdr = (TCG_PCR_EVENT_HDR *)(UINTN)EventLogLocation;\r
-    DumpEvent (EventHdr);\r
 \r
-    TcgEfiSpecIdEventStruct = (TCG_EfiSpecIDEventStruct *)(EventHdr + 1);\r
-    DumpTcgEfiSpecIdEventStruct (TcgEfiSpecIdEventStruct);\r
+      if (FinalEventsTable == NULL) {\r
+        DEBUG ((DEBUG_INFO, "FinalEventsTable: NOT FOUND\n"));\r
+      } else {\r
+        DEBUG ((DEBUG_INFO, "FinalEventsTable:    (0x%x)\n", FinalEventsTable));\r
+        DEBUG ((DEBUG_INFO, "  Version:           (0x%x)\n", FinalEventsTable->Version));\r
+        DEBUG ((DEBUG_INFO, "  NumberOfEvents:    (0x%x)\n", FinalEventsTable->NumberOfEvents));\r
+\r
+        EventHdr = (TCG_PCR_EVENT_HDR *)(UINTN)(FinalEventsTable + 1);\r
+        for (NumberOfEvents = 0; NumberOfEvents < FinalEventsTable->NumberOfEvents; NumberOfEvents++) {\r
+          DumpEvent (EventHdr);\r
+          EventHdr = (TCG_PCR_EVENT_HDR *)((UINTN)EventHdr + sizeof (TCG_PCR_EVENT_HDR) + EventHdr->EventSize);\r
+        }\r
+      }\r
 \r
-    TcgPcrEvent2 = (TCG_PCR_EVENT2 *)((UINTN)TcgEfiSpecIdEventStruct + GetTcgEfiSpecIdEventStructSize (TcgEfiSpecIdEventStruct));\r
-    while ((UINTN)TcgPcrEvent2 <= EventLogLastEntry) {\r
-      DumpEvent2 (TcgPcrEvent2);\r
-      TcgPcrEvent2 = (TCG_PCR_EVENT2 *)((UINTN)TcgPcrEvent2 + GetPcrEvent2Size (TcgPcrEvent2));\r
-    }\r
+      break;\r
+    case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:\r
+      //\r
+      // Dump first event\r
+      //\r
+      EventHdr = (TCG_PCR_EVENT_HDR *)(UINTN)EventLogLocation;\r
+      DumpEvent (EventHdr);\r
 \r
-    if (FinalEventsTable == NULL) {\r
-      DEBUG ((DEBUG_INFO, "FinalEventsTable: NOT FOUND\n"));\r
-    } else {\r
-      DEBUG ((DEBUG_INFO, "FinalEventsTable:    (0x%x)\n", FinalEventsTable));\r
-      DEBUG ((DEBUG_INFO, "  Version:           (0x%x)\n", FinalEventsTable->Version));\r
-      DEBUG ((DEBUG_INFO, "  NumberOfEvents:    (0x%x)\n", FinalEventsTable->NumberOfEvents));\r
+      TcgEfiSpecIdEventStruct = (TCG_EfiSpecIDEventStruct *)(EventHdr + 1);\r
+      DumpTcgEfiSpecIdEventStruct (TcgEfiSpecIdEventStruct);\r
 \r
-      TcgPcrEvent2 = (TCG_PCR_EVENT2 *)(UINTN)(FinalEventsTable + 1);\r
-      for (NumberOfEvents = 0; NumberOfEvents < FinalEventsTable->NumberOfEvents; NumberOfEvents++) {\r
+      TcgPcrEvent2 = (TCG_PCR_EVENT2 *)((UINTN)TcgEfiSpecIdEventStruct + GetTcgEfiSpecIdEventStructSize (TcgEfiSpecIdEventStruct));\r
+      while ((UINTN)TcgPcrEvent2 <= EventLogLastEntry) {\r
         DumpEvent2 (TcgPcrEvent2);\r
         TcgPcrEvent2 = (TCG_PCR_EVENT2 *)((UINTN)TcgPcrEvent2 + GetPcrEvent2Size (TcgPcrEvent2));\r
       }\r
-    }\r
-    break;\r
+\r
+      if (FinalEventsTable == NULL) {\r
+        DEBUG ((DEBUG_INFO, "FinalEventsTable: NOT FOUND\n"));\r
+      } else {\r
+        DEBUG ((DEBUG_INFO, "FinalEventsTable:    (0x%x)\n", FinalEventsTable));\r
+        DEBUG ((DEBUG_INFO, "  Version:           (0x%x)\n", FinalEventsTable->Version));\r
+        DEBUG ((DEBUG_INFO, "  NumberOfEvents:    (0x%x)\n", FinalEventsTable->NumberOfEvents));\r
+\r
+        TcgPcrEvent2 = (TCG_PCR_EVENT2 *)(UINTN)(FinalEventsTable + 1);\r
+        for (NumberOfEvents = 0; NumberOfEvents < FinalEventsTable->NumberOfEvents; NumberOfEvents++) {\r
+          DumpEvent2 (TcgPcrEvent2);\r
+          TcgPcrEvent2 = (TCG_PCR_EVENT2 *)((UINTN)TcgPcrEvent2 + GetPcrEvent2Size (TcgPcrEvent2));\r
+        }\r
+      }\r
+\r
+      break;\r
   }\r
 \r
-  return ;\r
+  return;\r
 }\r
 \r
 /**\r
@@ -695,11 +708,11 @@ DumpEventLog (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2GetEventLog (\r
-  IN EFI_TCG2_PROTOCOL         *This,\r
-  IN EFI_TCG2_EVENT_LOG_FORMAT EventLogFormat,\r
-  OUT EFI_PHYSICAL_ADDRESS     *EventLogLocation,\r
-  OUT EFI_PHYSICAL_ADDRESS     *EventLogLastEntry,\r
-  OUT BOOLEAN                  *EventLogTruncated\r
+  IN EFI_TCG2_PROTOCOL          *This,\r
+  IN EFI_TCG2_EVENT_LOG_FORMAT  EventLogFormat,\r
+  OUT EFI_PHYSICAL_ADDRESS      *EventLogLocation,\r
+  OUT EFI_PHYSICAL_ADDRESS      *EventLogLastEntry,\r
+  OUT BOOLEAN                   *EventLogTruncated\r
   )\r
 {\r
   UINTN  Index;\r
@@ -710,13 +723,13 @@ Tcg2GetEventLog (
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  for (Index = 0; Index < sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0]); Index++) {\r
     if (EventLogFormat == mTcg2EventInfo[Index].LogFormat) {\r
       break;\r
     }\r
   }\r
 \r
-  if (Index == sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0])) {\r
+  if (Index == sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0])) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -728,12 +741,15 @@ Tcg2GetEventLog (
     if (EventLogLocation != NULL) {\r
       *EventLogLocation = 0;\r
     }\r
+\r
     if (EventLogLastEntry != NULL) {\r
       *EventLogLastEntry = 0;\r
     }\r
+\r
     if (EventLogTruncated != NULL) {\r
       *EventLogTruncated = FALSE;\r
     }\r
+\r
     return EFI_SUCCESS;\r
   }\r
 \r
@@ -748,6 +764,7 @@ Tcg2GetEventLog (
     } else {\r
       *EventLogLastEntry = (EFI_PHYSICAL_ADDRESS)(UINTN)mTcgDxeData.EventLogAreaStruct[Index].LastEvent;\r
     }\r
+\r
     DEBUG ((DEBUG_INFO, "Tcg2GetEventLog (EventLogLastEntry - %x)\n", *EventLogLastEntry));\r
   }\r
 \r
@@ -786,18 +803,23 @@ Tcg2GetEventLog (
 **/\r
 BOOLEAN\r
 Is800155Event (\r
-  IN      VOID                      *NewEventHdr,\r
-  IN      UINT32                    NewEventHdrSize,\r
-  IN      UINT8                     *NewEventData,\r
-  IN      UINT32                    NewEventSize\r
+  IN      VOID    *NewEventHdr,\r
+  IN      UINT32  NewEventHdrSize,\r
+  IN      UINT8   *NewEventData,\r
+  IN      UINT32  NewEventSize\r
   )\r
 {\r
   if ((((TCG_PCR_EVENT2_HDR *)NewEventHdr)->EventType == EV_NO_ACTION) &&\r
-      (NewEventSize >= sizeof(TCG_Sp800_155_PlatformId_Event2)) &&\r
-      (CompareMem (NewEventData, TCG_Sp800_155_PlatformId_Event2_SIGNATURE,\r
-        sizeof(TCG_Sp800_155_PlatformId_Event2_SIGNATURE) - 1) == 0)) {\r
+      (NewEventSize >= sizeof (TCG_Sp800_155_PlatformId_Event2)) &&\r
+      (CompareMem (\r
+         NewEventData,\r
+         TCG_Sp800_155_PlatformId_Event2_SIGNATURE,\r
+         sizeof (TCG_Sp800_155_PlatformId_Event2_SIGNATURE) - 1\r
+         ) == 0))\r
+  {\r
     return TRUE;\r
   }\r
+\r
   return FALSE;\r
 }\r
 \r
@@ -816,15 +838,15 @@ Is800155Event (
 **/\r
 EFI_STATUS\r
 TcgCommLogEvent (\r
-  IN OUT  TCG_EVENT_LOG_AREA_STRUCT *EventLogAreaStruct,\r
-  IN      VOID                      *NewEventHdr,\r
-  IN      UINT32                    NewEventHdrSize,\r
-  IN      UINT8                     *NewEventData,\r
-  IN      UINT32                    NewEventSize\r
+  IN OUT  TCG_EVENT_LOG_AREA_STRUCT  *EventLogAreaStruct,\r
+  IN      VOID                       *NewEventHdr,\r
+  IN      UINT32                     NewEventHdrSize,\r
+  IN      UINT8                      *NewEventData,\r
+  IN      UINT32                     NewEventSize\r
   )\r
 {\r
-  UINTN                            NewLogSize;\r
-  BOOLEAN                          Record800155Event;\r
+  UINTN    NewLogSize;\r
+  BOOLEAN  Record800155Event;\r
 \r
   if (NewEventSize > MAX_ADDRESS -  NewEventHdrSize) {\r
     return EFI_OUT_OF_RESOURCES;\r
@@ -870,13 +892,14 @@ TcgCommLogEvent (
         );\r
 \r
       EventLogAreaStruct->Next800155EventOffset += NewLogSize;\r
-      EventLogAreaStruct->LastEvent += NewLogSize;\r
-      EventLogAreaStruct->EventLogSize += NewLogSize;\r
+      EventLogAreaStruct->LastEvent             += NewLogSize;\r
+      EventLogAreaStruct->EventLogSize          += NewLogSize;\r
     }\r
+\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  EventLogAreaStruct->LastEvent = (UINT8 *)(UINTN)EventLogAreaStruct->Lasa + EventLogAreaStruct->EventLogSize;\r
+  EventLogAreaStruct->LastEvent     = (UINT8 *)(UINTN)EventLogAreaStruct->Lasa + EventLogAreaStruct->EventLogSize;\r
   EventLogAreaStruct->EventLogSize += NewLogSize;\r
   CopyMem (EventLogAreaStruct->LastEvent, NewEventHdr, NewEventHdrSize);\r
   CopyMem (\r
@@ -902,24 +925,24 @@ TcgCommLogEvent (
 **/\r
 EFI_STATUS\r
 TcgDxeLogEvent (\r
-  IN      EFI_TCG2_EVENT_LOG_FORMAT EventLogFormat,\r
-  IN      VOID                      *NewEventHdr,\r
-  IN      UINT32                    NewEventHdrSize,\r
-  IN      UINT8                     *NewEventData,\r
-  IN      UINT32                    NewEventSize\r
+  IN      EFI_TCG2_EVENT_LOG_FORMAT  EventLogFormat,\r
+  IN      VOID                       *NewEventHdr,\r
+  IN      UINT32                     NewEventHdrSize,\r
+  IN      UINT8                      *NewEventData,\r
+  IN      UINT32                     NewEventSize\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  UINTN                     Index;\r
-  TCG_EVENT_LOG_AREA_STRUCT *EventLogAreaStruct;\r
+  EFI_STATUS                 Status;\r
+  UINTN                      Index;\r
+  TCG_EVENT_LOG_AREA_STRUCT  *EventLogAreaStruct;\r
 \r
-  for (Index = 0; Index < sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0]); Index++) {\r
     if (EventLogFormat == mTcg2EventInfo[Index].LogFormat) {\r
       break;\r
     }\r
   }\r
 \r
-  if (Index == sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0])) {\r
+  if (Index == sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0])) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -957,6 +980,7 @@ TcgDxeLogEvent (
       //\r
       return EFI_SUCCESS;\r
     }\r
+\r
     EventLogAreaStruct = &mTcgDxeData.FinalEventLogAreaStruct[Index];\r
 \r
     if (EventLogAreaStruct->EventLogTruncated) {\r
@@ -978,7 +1002,7 @@ TcgDxeLogEvent (
       //\r
       // Increase the NumberOfEvents in FinalEventsTable\r
       //\r
-      (mTcgDxeData.FinalEventsTable[Index])->NumberOfEvents ++;\r
+      (mTcgDxeData.FinalEventsTable[Index])->NumberOfEvents++;\r
       DEBUG ((DEBUG_INFO, "FinalEventsTable->NumberOfEvents - 0x%x\n", (mTcgDxeData.FinalEventsTable[Index])->NumberOfEvents));\r
       DEBUG ((DEBUG_INFO, "  Size - 0x%x\n", (UINTN)EventLogAreaStruct->EventLogSize));\r
     }\r
@@ -996,25 +1020,25 @@ TcgDxeLogEvent (
 **/\r
 UINT32\r
 GetDigestListBinSize (\r
-  IN VOID   *DigestListBin\r
+  IN VOID  *DigestListBin\r
   )\r
 {\r
-  UINTN         Index;\r
-  UINT16        DigestSize;\r
-  UINT32        TotalSize;\r
-  UINT32        Count;\r
-  TPMI_ALG_HASH HashAlg;\r
-\r
-  Count = ReadUnaligned32 (DigestListBin);\r
-  TotalSize = sizeof(Count);\r
-  DigestListBin = (UINT8 *)DigestListBin + sizeof(Count);\r
+  UINTN          Index;\r
+  UINT16         DigestSize;\r
+  UINT32         TotalSize;\r
+  UINT32         Count;\r
+  TPMI_ALG_HASH  HashAlg;\r
+\r
+  Count         = ReadUnaligned32 (DigestListBin);\r
+  TotalSize     = sizeof (Count);\r
+  DigestListBin = (UINT8 *)DigestListBin + sizeof (Count);\r
   for (Index = 0; Index < Count; Index++) {\r
-    HashAlg = ReadUnaligned16 (DigestListBin);\r
-    TotalSize += sizeof(HashAlg);\r
-    DigestListBin = (UINT8 *)DigestListBin + sizeof(HashAlg);\r
+    HashAlg       = ReadUnaligned16 (DigestListBin);\r
+    TotalSize    += sizeof (HashAlg);\r
+    DigestListBin = (UINT8 *)DigestListBin + sizeof (HashAlg);\r
 \r
-    DigestSize = GetHashSizeFromAlgo (HashAlg);\r
-    TotalSize += DigestSize;\r
+    DigestSize    = GetHashSizeFromAlgo (HashAlg);\r
+    TotalSize    += DigestSize;\r
     DigestListBin = (UINT8 *)DigestListBin + DigestSize;\r
   }\r
 \r
@@ -1033,34 +1057,34 @@ GetDigestListBinSize (
 **/\r
 VOID *\r
 CopyDigestListBinToBuffer (\r
-  IN OUT VOID                       *Buffer,\r
-  IN VOID                           *DigestListBin,\r
-  IN UINT32                         HashAlgorithmMask,\r
-  OUT UINT32                        *HashAlgorithmMaskCopied\r
+  IN OUT VOID  *Buffer,\r
+  IN VOID      *DigestListBin,\r
+  IN UINT32    HashAlgorithmMask,\r
+  OUT UINT32   *HashAlgorithmMaskCopied\r
   )\r
 {\r
-  UINTN         Index;\r
-  UINT16        DigestSize;\r
-  UINT32        Count;\r
-  TPMI_ALG_HASH HashAlg;\r
-  UINT32        DigestListCount;\r
-  UINT32        *DigestListCountPtr;\r
-\r
-  DigestListCountPtr = (UINT32 *) Buffer;\r
-  DigestListCount = 0;\r
+  UINTN          Index;\r
+  UINT16         DigestSize;\r
+  UINT32         Count;\r
+  TPMI_ALG_HASH  HashAlg;\r
+  UINT32         DigestListCount;\r
+  UINT32         *DigestListCountPtr;\r
+\r
+  DigestListCountPtr         = (UINT32 *)Buffer;\r
+  DigestListCount            = 0;\r
   (*HashAlgorithmMaskCopied) = 0;\r
 \r
-  Count = ReadUnaligned32 (DigestListBin);\r
-  Buffer = (UINT8 *)Buffer + sizeof(Count);\r
-  DigestListBin = (UINT8 *)DigestListBin + sizeof(Count);\r
+  Count         = ReadUnaligned32 (DigestListBin);\r
+  Buffer        = (UINT8 *)Buffer + sizeof (Count);\r
+  DigestListBin = (UINT8 *)DigestListBin + sizeof (Count);\r
   for (Index = 0; Index < Count; Index++) {\r
-    HashAlg = ReadUnaligned16 (DigestListBin);\r
-    DigestListBin = (UINT8 *)DigestListBin + sizeof(HashAlg);\r
-    DigestSize = GetHashSizeFromAlgo (HashAlg);\r
+    HashAlg       = ReadUnaligned16 (DigestListBin);\r
+    DigestListBin = (UINT8 *)DigestListBin + sizeof (HashAlg);\r
+    DigestSize    = GetHashSizeFromAlgo (HashAlg);\r
 \r
-    if (IsHashAlgSupportedInHashAlgorithmMask(HashAlg, HashAlgorithmMask)) {\r
-      CopyMem (Buffer, &HashAlg, sizeof(HashAlg));\r
-      Buffer = (UINT8 *)Buffer + sizeof(HashAlg);\r
+    if (IsHashAlgSupportedInHashAlgorithmMask (HashAlg, HashAlgorithmMask)) {\r
+      CopyMem (Buffer, &HashAlg, sizeof (HashAlg));\r
+      Buffer = (UINT8 *)Buffer + sizeof (HashAlg);\r
       CopyMem (Buffer, DigestListBin, DigestSize);\r
       Buffer = (UINT8 *)Buffer + DigestSize;\r
       DigestListCount++;\r
@@ -1068,8 +1092,10 @@ CopyDigestListBinToBuffer (
     } else {\r
       DEBUG ((DEBUG_ERROR, "WARNING: CopyDigestListBinToBuffer Event log has HashAlg unsupported by PCR bank (0x%x)\n", HashAlg));\r
     }\r
+\r
     DigestListBin = (UINT8 *)DigestListBin + DigestSize;\r
   }\r
+\r
   WriteUnaligned32 (DigestListCountPtr, DigestListCount);\r
 \r
   return Buffer;\r
@@ -1087,76 +1113,79 @@ CopyDigestListBinToBuffer (
 **/\r
 EFI_STATUS\r
 TcgDxeLogHashEvent (\r
-  IN TPML_DIGEST_VALUES             *DigestList,\r
-  IN OUT  TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN TPML_DIGEST_VALUES      *DigestList,\r
+  IN OUT  TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_TPL                           OldTpl;\r
-  UINTN                             Index;\r
-  EFI_STATUS                        RetStatus;\r
-  TCG_PCR_EVENT2                    TcgPcrEvent2;\r
-  UINT8                             *DigestBuffer;\r
-  UINT32                            *EventSizePtr;\r
+  EFI_STATUS      Status;\r
+  EFI_TPL         OldTpl;\r
+  UINTN           Index;\r
+  EFI_STATUS      RetStatus;\r
+  TCG_PCR_EVENT2  TcgPcrEvent2;\r
+  UINT8           *DigestBuffer;\r
+  UINT32          *EventSizePtr;\r
 \r
   DEBUG ((DEBUG_INFO, "SupportedEventLogs - 0x%08x\n", mTcgDxeData.BsCap.SupportedEventLogs));\r
 \r
   RetStatus = EFI_SUCCESS;\r
-  for (Index = 0; Index < sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0]); Index++) {\r
     if ((mTcgDxeData.BsCap.SupportedEventLogs & mTcg2EventInfo[Index].LogFormat) != 0) {\r
       DEBUG ((DEBUG_INFO, "  LogFormat - 0x%08x\n", mTcg2EventInfo[Index].LogFormat));\r
       switch (mTcg2EventInfo[Index].LogFormat) {\r
-      case EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2:\r
-        Status = GetDigestFromDigestList (TPM_ALG_SHA1, DigestList, &NewEventHdr->Digest);\r
-        if (!EFI_ERROR (Status)) {\r
+        case EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2:\r
+          Status = GetDigestFromDigestList (TPM_ALG_SHA1, DigestList, &NewEventHdr->Digest);\r
+          if (!EFI_ERROR (Status)) {\r
+            //\r
+            // Enter critical region\r
+            //\r
+            OldTpl = gBS->RaiseTPL (TPL_HIGH_LEVEL);\r
+            Status = TcgDxeLogEvent (\r
+                       mTcg2EventInfo[Index].LogFormat,\r
+                       NewEventHdr,\r
+                       sizeof (TCG_PCR_EVENT_HDR),\r
+                       NewEventData,\r
+                       NewEventHdr->EventSize\r
+                       );\r
+            if (Status != EFI_SUCCESS) {\r
+              RetStatus = Status;\r
+            }\r
+\r
+            gBS->RestoreTPL (OldTpl);\r
+            //\r
+            // Exit critical region\r
+            //\r
+          }\r
+\r
+          break;\r
+        case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:\r
+          ZeroMem (&TcgPcrEvent2, sizeof (TcgPcrEvent2));\r
+          TcgPcrEvent2.PCRIndex  = NewEventHdr->PCRIndex;\r
+          TcgPcrEvent2.EventType = NewEventHdr->EventType;\r
+          DigestBuffer           = (UINT8 *)&TcgPcrEvent2.Digest;\r
+          EventSizePtr           = CopyDigestListToBuffer (DigestBuffer, DigestList, mTcgDxeData.BsCap.ActivePcrBanks);\r
+          CopyMem (EventSizePtr, &NewEventHdr->EventSize, sizeof (NewEventHdr->EventSize));\r
+\r
           //\r
           // Enter critical region\r
           //\r
           OldTpl = gBS->RaiseTPL (TPL_HIGH_LEVEL);\r
           Status = TcgDxeLogEvent (\r
                      mTcg2EventInfo[Index].LogFormat,\r
-                     NewEventHdr,\r
-                     sizeof(TCG_PCR_EVENT_HDR),\r
+                     &TcgPcrEvent2,\r
+                     sizeof (TcgPcrEvent2.PCRIndex) + sizeof (TcgPcrEvent2.EventType) + GetDigestListBinSize (DigestBuffer) + sizeof (TcgPcrEvent2.EventSize),\r
                      NewEventData,\r
                      NewEventHdr->EventSize\r
                      );\r
           if (Status != EFI_SUCCESS) {\r
             RetStatus = Status;\r
           }\r
+\r
           gBS->RestoreTPL (OldTpl);\r
           //\r
           // Exit critical region\r
           //\r
-        }\r
-        break;\r
-      case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:\r
-        ZeroMem (&TcgPcrEvent2, sizeof(TcgPcrEvent2));\r
-        TcgPcrEvent2.PCRIndex = NewEventHdr->PCRIndex;\r
-        TcgPcrEvent2.EventType = NewEventHdr->EventType;\r
-        DigestBuffer = (UINT8 *)&TcgPcrEvent2.Digest;\r
-        EventSizePtr = CopyDigestListToBuffer (DigestBuffer, DigestList, mTcgDxeData.BsCap.ActivePcrBanks);\r
-        CopyMem (EventSizePtr, &NewEventHdr->EventSize, sizeof(NewEventHdr->EventSize));\r
-\r
-        //\r
-        // Enter critical region\r
-        //\r
-        OldTpl = gBS->RaiseTPL (TPL_HIGH_LEVEL);\r
-        Status = TcgDxeLogEvent (\r
-                   mTcg2EventInfo[Index].LogFormat,\r
-                   &TcgPcrEvent2,\r
-                   sizeof(TcgPcrEvent2.PCRIndex) + sizeof(TcgPcrEvent2.EventType) + GetDigestListBinSize (DigestBuffer) + sizeof(TcgPcrEvent2.EventSize),\r
-                   NewEventData,\r
-                   NewEventHdr->EventSize\r
-                   );\r
-        if (Status != EFI_SUCCESS) {\r
-          RetStatus = Status;\r
-        }\r
-        gBS->RestoreTPL (OldTpl);\r
-        //\r
-        // Exit critical region\r
-        //\r
-        break;\r
+          break;\r
       }\r
     }\r
   }\r
@@ -1182,16 +1211,16 @@ TcgDxeLogHashEvent (
 **/\r
 EFI_STATUS\r
 TcgDxeHashLogExtendEvent (\r
-  IN      UINT64                    Flags,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINT64                    HashDataLen,\r
-  IN OUT  TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      UINT64             Flags,\r
+  IN      UINT8              *HashData,\r
+  IN      UINT64             HashDataLen,\r
+  IN OUT  TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPML_DIGEST_VALUES                DigestList;\r
-  TCG_PCR_EVENT2_HDR                NoActionEvent;\r
+  EFI_STATUS          Status;\r
+  TPML_DIGEST_VALUES  DigestList;\r
+  TCG_PCR_EVENT2_HDR  NoActionEvent;\r
 \r
   if (!mTcgDxeData.BsCap.TPMPresentFlag) {\r
     return EFI_DEVICE_ERROR;\r
@@ -1256,22 +1285,23 @@ TcgDxeHashLogExtendEvent (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2HashLogExtendEvent (\r
-  IN EFI_TCG2_PROTOCOL    *This,\r
-  IN UINT64               Flags,\r
-  IN EFI_PHYSICAL_ADDRESS DataToHash,\r
-  IN UINT64               DataToHashLen,\r
-  IN EFI_TCG2_EVENT       *Event\r
+  IN EFI_TCG2_PROTOCOL     *This,\r
+  IN UINT64                Flags,\r
+  IN EFI_PHYSICAL_ADDRESS  DataToHash,\r
+  IN UINT64                DataToHashLen,\r
+  IN EFI_TCG2_EVENT        *Event\r
   )\r
 {\r
-  EFI_STATUS         Status;\r
-  TCG_PCR_EVENT_HDR  NewEventHdr;\r
-  TPML_DIGEST_VALUES DigestList;\r
+  EFI_STATUS          Status;\r
+  TCG_PCR_EVENT_HDR   NewEventHdr;\r
+  TPML_DIGEST_VALUES  DigestList;\r
 \r
   DEBUG ((DEBUG_VERBOSE, "Tcg2HashLogExtendEvent ...\n"));\r
 \r
   if ((This == NULL) || (Event == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   //\r
   // Do not check hash data size for EV_NO_ACTION event.\r
   //\r
@@ -1283,7 +1313,7 @@ Tcg2HashLogExtendEvent (
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  if (Event->Size < Event->Header.HeaderSize + sizeof(UINT32)) {\r
+  if (Event->Size < Event->Header.HeaderSize + sizeof (UINT32)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -1293,7 +1323,7 @@ Tcg2HashLogExtendEvent (
 \r
   NewEventHdr.PCRIndex  = Event->Header.PCRIndex;\r
   NewEventHdr.EventType = Event->Header.EventType;\r
-  NewEventHdr.EventSize = Event->Size - sizeof(UINT32) - Event->Header.HeaderSize;\r
+  NewEventHdr.EventSize = Event->Size - sizeof (UINT32) - Event->Header.HeaderSize;\r
   if ((Flags & PE_COFF_IMAGE) != 0) {\r
     Status = MeasurePeImageAndExtend (\r
                NewEventHdr.PCRIndex,\r
@@ -1306,6 +1336,7 @@ Tcg2HashLogExtendEvent (
         Status = TcgDxeLogHashEvent (&DigestList, &NewEventHdr, Event->Event);\r
       }\r
     }\r
+\r
     if (Status == EFI_DEVICE_ERROR) {\r
       DEBUG ((DEBUG_ERROR, "MeasurePeImageAndExtend - %r. Disable TPM.\n", Status));\r
       mTcgDxeData.BsCap.TPMPresentFlag = FALSE;\r
@@ -1317,12 +1348,13 @@ Tcg2HashLogExtendEvent (
   } else {\r
     Status = TcgDxeHashLogExtendEvent (\r
                Flags,\r
-               (UINT8 *) (UINTN) DataToHash,\r
+               (UINT8 *)(UINTN)DataToHash,\r
                DataToHashLen,\r
                &NewEventHdr,\r
                Event->Event\r
                );\r
   }\r
+\r
   DEBUG ((DEBUG_VERBOSE, "Tcg2HashLogExtendEvent - %r\n", Status));\r
   return Status;\r
 }\r
@@ -1344,20 +1376,21 @@ Tcg2HashLogExtendEvent (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2SubmitCommand (\r
-  IN EFI_TCG2_PROTOCOL *This,\r
-  IN UINT32            InputParameterBlockSize,\r
-  IN UINT8             *InputParameterBlock,\r
-  IN UINT32            OutputParameterBlockSize,\r
-  IN UINT8             *OutputParameterBlock\r
+  IN EFI_TCG2_PROTOCOL  *This,\r
+  IN UINT32             InputParameterBlockSize,\r
+  IN UINT8              *InputParameterBlock,\r
+  IN UINT32             OutputParameterBlockSize,\r
+  IN UINT8              *OutputParameterBlock\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   DEBUG ((DEBUG_INFO, "Tcg2SubmitCommand ...\n"));\r
 \r
   if ((This == NULL) ||\r
       (InputParameterBlockSize == 0) || (InputParameterBlock == NULL) ||\r
-      (OutputParameterBlockSize == 0) || (OutputParameterBlock == NULL)) {\r
+      (OutputParameterBlockSize == 0) || (OutputParameterBlock == NULL))\r
+  {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -1368,6 +1401,7 @@ Tcg2SubmitCommand (
   if (InputParameterBlockSize > mTcgDxeData.BsCap.MaxCommandSize) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   if (OutputParameterBlockSize > mTcgDxeData.BsCap.MaxResponseSize) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
@@ -1394,13 +1428,14 @@ Tcg2SubmitCommand (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2GetActivePCRBanks (\r
-  IN  EFI_TCG2_PROTOCOL *This,\r
-  OUT UINT32            *ActivePcrBanks\r
+  IN  EFI_TCG2_PROTOCOL  *This,\r
+  OUT UINT32             *ActivePcrBanks\r
   )\r
 {\r
   if (ActivePcrBanks == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   *ActivePcrBanks = mTcgDxeData.BsCap.ActivePcrBanks;\r
   return EFI_SUCCESS;\r
 }\r
@@ -1417,8 +1452,8 @@ Tcg2GetActivePCRBanks (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2SetActivePCRBanks (\r
-  IN EFI_TCG2_PROTOCOL *This,\r
-  IN UINT32            ActivePcrBanks\r
+  IN EFI_TCG2_PROTOCOL  *This,\r
+  IN UINT32             ActivePcrBanks\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -1429,9 +1464,11 @@ Tcg2SetActivePCRBanks (
   if (ActivePcrBanks == 0) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   if ((ActivePcrBanks & (~mTcgDxeData.BsCap.HashAlgorithmBitmap)) != 0) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   if (ActivePcrBanks == mTcgDxeData.BsCap.ActivePcrBanks) {\r
     //\r
     // Need clear previous SET_PCR_BANKS setting\r
@@ -1488,14 +1525,14 @@ Tcg2GetResultOfSetActivePcrBanks (
   }\r
 }\r
 \r
-EFI_TCG2_PROTOCOL mTcg2Protocol = {\r
-    Tcg2GetCapability,\r
-    Tcg2GetEventLog,\r
-    Tcg2HashLogExtendEvent,\r
-    Tcg2SubmitCommand,\r
-    Tcg2GetActivePCRBanks,\r
-    Tcg2SetActivePCRBanks,\r
-    Tcg2GetResultOfSetActivePcrBanks,\r
+EFI_TCG2_PROTOCOL  mTcg2Protocol = {\r
+  Tcg2GetCapability,\r
+  Tcg2GetEventLog,\r
+  Tcg2HashLogExtendEvent,\r
+  Tcg2SubmitCommand,\r
+  Tcg2GetActivePCRBanks,\r
+  Tcg2SetActivePCRBanks,\r
+  Tcg2GetResultOfSetActivePcrBanks,\r
 };\r
 \r
 /**\r
@@ -1510,37 +1547,37 @@ SetupEventLog (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                      Status;\r
-  VOID                            *TcgEvent;\r
-  EFI_PEI_HOB_POINTERS            GuidHob;\r
-  EFI_PHYSICAL_ADDRESS            Lasa;\r
-  UINTN                           Index;\r
-  VOID                            *DigestListBin;\r
-  TPML_DIGEST_VALUES              TempDigestListBin;\r
-  UINT32                          DigestListBinSize;\r
-  UINT8                           *Event;\r
-  UINT32                          EventSize;\r
-  UINT32                          *EventSizePtr;\r
-  UINT32                          HashAlgorithmMaskCopied;\r
-  TCG_EfiSpecIDEventStruct        *TcgEfiSpecIdEventStruct;\r
-  UINT8                           TempBuf[sizeof(TCG_EfiSpecIDEventStruct) + sizeof(UINT32) + (HASH_COUNT * sizeof(TCG_EfiSpecIdEventAlgorithmSize)) + sizeof(UINT8)];\r
-  TCG_PCR_EVENT_HDR               SpecIdEvent;\r
-  TCG_PCR_EVENT2_HDR              NoActionEvent;\r
-  TCG_EfiSpecIdEventAlgorithmSize *DigestSize;\r
-  TCG_EfiSpecIdEventAlgorithmSize *TempDigestSize;\r
-  UINT8                           *VendorInfoSize;\r
-  UINT32                          NumberOfAlgorithms;\r
-  TCG_EfiStartupLocalityEvent     StartupLocalityEvent;\r
+  EFI_STATUS                       Status;\r
+  VOID                             *TcgEvent;\r
+  EFI_PEI_HOB_POINTERS             GuidHob;\r
+  EFI_PHYSICAL_ADDRESS             Lasa;\r
+  UINTN                            Index;\r
+  VOID                             *DigestListBin;\r
+  TPML_DIGEST_VALUES               TempDigestListBin;\r
+  UINT32                           DigestListBinSize;\r
+  UINT8                            *Event;\r
+  UINT32                           EventSize;\r
+  UINT32                           *EventSizePtr;\r
+  UINT32                           HashAlgorithmMaskCopied;\r
+  TCG_EfiSpecIDEventStruct         *TcgEfiSpecIdEventStruct;\r
+  UINT8                            TempBuf[sizeof (TCG_EfiSpecIDEventStruct) + sizeof (UINT32) + (HASH_COUNT * sizeof (TCG_EfiSpecIdEventAlgorithmSize)) + sizeof (UINT8)];\r
+  TCG_PCR_EVENT_HDR                SpecIdEvent;\r
+  TCG_PCR_EVENT2_HDR               NoActionEvent;\r
+  TCG_EfiSpecIdEventAlgorithmSize  *DigestSize;\r
+  TCG_EfiSpecIdEventAlgorithmSize  *TempDigestSize;\r
+  UINT8                            *VendorInfoSize;\r
+  UINT32                           NumberOfAlgorithms;\r
+  TCG_EfiStartupLocalityEvent      StartupLocalityEvent;\r
 \r
   DEBUG ((DEBUG_INFO, "SetupEventLog\n"));\r
 \r
   //\r
   // 1. Create Log Area\r
   //\r
-  for (Index = 0; Index < sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0]); Index++) {\r
     if ((mTcgDxeData.BsCap.SupportedEventLogs & mTcg2EventInfo[Index].LogFormat) != 0) {\r
       mTcgDxeData.EventLogAreaStruct[Index].EventLogFormat = mTcg2EventInfo[Index].LogFormat;\r
-      if (PcdGet8(PcdTpm2AcpiTableRev) >= 4) {\r
+      if (PcdGet8 (PcdTpm2AcpiTableRev) >= 4) {\r
         Status = gBS->AllocatePages (\r
                         AllocateAnyPages,\r
                         EfiACPIMemoryNVS,\r
@@ -1555,21 +1592,24 @@ SetupEventLog (
                         &Lasa\r
                         );\r
       }\r
+\r
       if (EFI_ERROR (Status)) {\r
         return Status;\r
       }\r
-      mTcgDxeData.EventLogAreaStruct[Index].Lasa = Lasa;\r
-      mTcgDxeData.EventLogAreaStruct[Index].Laml = PcdGet32 (PcdTcgLogAreaMinLen);\r
+\r
+      mTcgDxeData.EventLogAreaStruct[Index].Lasa                  = Lasa;\r
+      mTcgDxeData.EventLogAreaStruct[Index].Laml                  = PcdGet32 (PcdTcgLogAreaMinLen);\r
       mTcgDxeData.EventLogAreaStruct[Index].Next800155EventOffset = 0;\r
 \r
-      if ((PcdGet8(PcdTpm2AcpiTableRev) >= 4) ||\r
-          (mTcg2EventInfo[Index].LogFormat == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2)) {\r
+      if ((PcdGet8 (PcdTpm2AcpiTableRev) >= 4) ||\r
+          (mTcg2EventInfo[Index].LogFormat == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2))\r
+      {\r
         //\r
         // Report TCG2 event log address and length, so that they can be reported in TPM2 ACPI table.\r
         // Ignore the return status, because those fields are optional.\r
         //\r
-        PcdSet32S(PcdTpm2AcpiTableLaml, (UINT32)mTcgDxeData.EventLogAreaStruct[Index].Laml);\r
-        PcdSet64S(PcdTpm2AcpiTableLasa, mTcgDxeData.EventLogAreaStruct[Index].Lasa);\r
+        PcdSet32S (PcdTpm2AcpiTableLaml, (UINT32)mTcgDxeData.EventLogAreaStruct[Index].Laml);\r
+        PcdSet64S (PcdTpm2AcpiTableLasa, mTcgDxeData.EventLogAreaStruct[Index].Lasa);\r
       }\r
 \r
       //\r
@@ -1585,58 +1625,63 @@ SetupEventLog (
         // TcgEfiSpecIdEventStruct\r
         //\r
         TcgEfiSpecIdEventStruct = (TCG_EfiSpecIDEventStruct *)TempBuf;\r
-        CopyMem (TcgEfiSpecIdEventStruct->signature, TCG_EfiSpecIDEventStruct_SIGNATURE_03, sizeof(TcgEfiSpecIdEventStruct->signature));\r
-        TcgEfiSpecIdEventStruct->platformClass = PcdGet8 (PcdTpmPlatformClass);\r
+        CopyMem (TcgEfiSpecIdEventStruct->signature, TCG_EfiSpecIDEventStruct_SIGNATURE_03, sizeof (TcgEfiSpecIdEventStruct->signature));\r
+        TcgEfiSpecIdEventStruct->platformClass    = PcdGet8 (PcdTpmPlatformClass);\r
         TcgEfiSpecIdEventStruct->specVersionMajor = TCG_EfiSpecIDEventStruct_SPEC_VERSION_MAJOR_TPM2;\r
         TcgEfiSpecIdEventStruct->specVersionMinor = TCG_EfiSpecIDEventStruct_SPEC_VERSION_MINOR_TPM2;\r
-        TcgEfiSpecIdEventStruct->specErrata = (UINT8)PcdGet32(PcdTcgPfpMeasurementRevision);\r
-        TcgEfiSpecIdEventStruct->uintnSize = sizeof(UINTN)/sizeof(UINT32);\r
-        NumberOfAlgorithms = 0;\r
-        DigestSize = (TCG_EfiSpecIdEventAlgorithmSize *)((UINT8 *)TcgEfiSpecIdEventStruct + sizeof(*TcgEfiSpecIdEventStruct) + sizeof(NumberOfAlgorithms));\r
+        TcgEfiSpecIdEventStruct->specErrata       = (UINT8)PcdGet32 (PcdTcgPfpMeasurementRevision);\r
+        TcgEfiSpecIdEventStruct->uintnSize        = sizeof (UINTN)/sizeof (UINT32);\r
+        NumberOfAlgorithms                        = 0;\r
+        DigestSize                                = (TCG_EfiSpecIdEventAlgorithmSize *)((UINT8 *)TcgEfiSpecIdEventStruct + sizeof (*TcgEfiSpecIdEventStruct) + sizeof (NumberOfAlgorithms));\r
         if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SHA1) != 0) {\r
-          TempDigestSize = DigestSize;\r
-          TempDigestSize += NumberOfAlgorithms;\r
+          TempDigestSize              = DigestSize;\r
+          TempDigestSize             += NumberOfAlgorithms;\r
           TempDigestSize->algorithmId = TPM_ALG_SHA1;\r
-          TempDigestSize->digestSize = SHA1_DIGEST_SIZE;\r
+          TempDigestSize->digestSize  = SHA1_DIGEST_SIZE;\r
           NumberOfAlgorithms++;\r
         }\r
+\r
         if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SHA256) != 0) {\r
-          TempDigestSize = DigestSize;\r
-          TempDigestSize += NumberOfAlgorithms;\r
+          TempDigestSize              = DigestSize;\r
+          TempDigestSize             += NumberOfAlgorithms;\r
           TempDigestSize->algorithmId = TPM_ALG_SHA256;\r
-          TempDigestSize->digestSize = SHA256_DIGEST_SIZE;\r
+          TempDigestSize->digestSize  = SHA256_DIGEST_SIZE;\r
           NumberOfAlgorithms++;\r
         }\r
+\r
         if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SHA384) != 0) {\r
-          TempDigestSize = DigestSize;\r
-          TempDigestSize += NumberOfAlgorithms;\r
+          TempDigestSize              = DigestSize;\r
+          TempDigestSize             += NumberOfAlgorithms;\r
           TempDigestSize->algorithmId = TPM_ALG_SHA384;\r
-          TempDigestSize->digestSize = SHA384_DIGEST_SIZE;\r
+          TempDigestSize->digestSize  = SHA384_DIGEST_SIZE;\r
           NumberOfAlgorithms++;\r
         }\r
+\r
         if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SHA512) != 0) {\r
-          TempDigestSize = DigestSize;\r
-          TempDigestSize += NumberOfAlgorithms;\r
+          TempDigestSize              = DigestSize;\r
+          TempDigestSize             += NumberOfAlgorithms;\r
           TempDigestSize->algorithmId = TPM_ALG_SHA512;\r
-          TempDigestSize->digestSize = SHA512_DIGEST_SIZE;\r
+          TempDigestSize->digestSize  = SHA512_DIGEST_SIZE;\r
           NumberOfAlgorithms++;\r
         }\r
+\r
         if ((mTcgDxeData.BsCap.ActivePcrBanks & EFI_TCG2_BOOT_HASH_ALG_SM3_256) != 0) {\r
-          TempDigestSize = DigestSize;\r
-          TempDigestSize += NumberOfAlgorithms;\r
+          TempDigestSize              = DigestSize;\r
+          TempDigestSize             += NumberOfAlgorithms;\r
           TempDigestSize->algorithmId = TPM_ALG_SM3_256;\r
-          TempDigestSize->digestSize = SM3_256_DIGEST_SIZE;\r
+          TempDigestSize->digestSize  = SM3_256_DIGEST_SIZE;\r
           NumberOfAlgorithms++;\r
         }\r
-        CopyMem (TcgEfiSpecIdEventStruct + 1, &NumberOfAlgorithms, sizeof(NumberOfAlgorithms));\r
-        TempDigestSize = DigestSize;\r
+\r
+        CopyMem (TcgEfiSpecIdEventStruct + 1, &NumberOfAlgorithms, sizeof (NumberOfAlgorithms));\r
+        TempDigestSize  = DigestSize;\r
         TempDigestSize += NumberOfAlgorithms;\r
-        VendorInfoSize = (UINT8 *)TempDigestSize;\r
+        VendorInfoSize  = (UINT8 *)TempDigestSize;\r
         *VendorInfoSize = 0;\r
 \r
-        SpecIdEvent.PCRIndex = 0;\r
+        SpecIdEvent.PCRIndex  = 0;\r
         SpecIdEvent.EventType = EV_NO_ACTION;\r
-        ZeroMem (&SpecIdEvent.Digest, sizeof(SpecIdEvent.Digest));\r
+        ZeroMem (&SpecIdEvent.Digest, sizeof (SpecIdEvent.Digest));\r
         SpecIdEvent.EventSize = (UINT32)GetTcgEfiSpecIdEventStructSize (TcgEfiSpecIdEventStruct);\r
 \r
         //\r
@@ -1647,7 +1692,7 @@ SetupEventLog (
         Status = TcgDxeLogEvent (\r
                    mTcg2EventInfo[Index].LogFormat,\r
                    &SpecIdEvent,\r
-                   sizeof(SpecIdEvent),\r
+                   sizeof (SpecIdEvent),\r
                    (UINT8 *)TcgEfiSpecIdEventStruct,\r
                    SpecIdEvent.EventSize\r
                    );\r
@@ -1663,12 +1708,12 @@ SetupEventLog (
         //\r
         GuidHob.Guid = GetFirstGuidHob (&gTcg800155PlatformIdEventHobGuid);\r
         while (GuidHob.Guid != NULL) {\r
-          InitNoActionEvent(&NoActionEvent, GET_GUID_HOB_DATA_SIZE (GuidHob.Guid));\r
+          InitNoActionEvent (&NoActionEvent, GET_GUID_HOB_DATA_SIZE (GuidHob.Guid));\r
 \r
           Status = TcgDxeLogEvent (\r
                      mTcg2EventInfo[Index].LogFormat,\r
                      &NoActionEvent,\r
-                     sizeof(NoActionEvent.PCRIndex) + sizeof(NoActionEvent.EventType) + GetDigestListBinSize (&NoActionEvent.Digests) + sizeof(NoActionEvent.EventSize),\r
+                     sizeof (NoActionEvent.PCRIndex) + sizeof (NoActionEvent.EventType) + GetDigestListBinSize (&NoActionEvent.Digests) + sizeof (NoActionEvent.EventSize),\r
                      GET_GUID_HOB_DATA (GuidHob.Guid),\r
                      GET_GUID_HOB_DATA_SIZE (GuidHob.Guid)\r
                      );\r
@@ -1686,13 +1731,13 @@ SetupEventLog (
           // Get Locality Indicator from StartupLocality HOB\r
           //\r
           StartupLocalityEvent.StartupLocality = *(UINT8 *)(GET_GUID_HOB_DATA (GuidHob.Guid));\r
-          CopyMem (StartupLocalityEvent.Signature, TCG_EfiStartupLocalityEvent_SIGNATURE, sizeof(StartupLocalityEvent.Signature));\r
+          CopyMem (StartupLocalityEvent.Signature, TCG_EfiStartupLocalityEvent_SIGNATURE, sizeof (StartupLocalityEvent.Signature));\r
           DEBUG ((DEBUG_INFO, "SetupEventLog: Set Locality from HOB into StartupLocalityEvent 0x%02x\n", StartupLocalityEvent.StartupLocality));\r
 \r
           //\r
           // Initialize StartupLocalityEvent\r
           //\r
-          InitNoActionEvent(&NoActionEvent, sizeof(StartupLocalityEvent));\r
+          InitNoActionEvent (&NoActionEvent, sizeof (StartupLocalityEvent));\r
 \r
           //\r
           // Log EfiStartupLocalityEvent as the second Event\r
@@ -1701,11 +1746,10 @@ SetupEventLog (
           Status = TcgDxeLogEvent (\r
                      mTcg2EventInfo[Index].LogFormat,\r
                      &NoActionEvent,\r
-                     sizeof(NoActionEvent.PCRIndex) + sizeof(NoActionEvent.EventType) + GetDigestListBinSize (&NoActionEvent.Digests) + sizeof(NoActionEvent.EventSize),\r
+                     sizeof (NoActionEvent.PCRIndex) + sizeof (NoActionEvent.EventType) + GetDigestListBinSize (&NoActionEvent.Digests) + sizeof (NoActionEvent.EventSize),\r
                      (UINT8 *)&StartupLocalityEvent,\r
-                     sizeof(StartupLocalityEvent)\r
+                     sizeof (StartupLocalityEvent)\r
                      );\r
-\r
         }\r
       }\r
     }\r
@@ -1714,7 +1758,7 @@ SetupEventLog (
   //\r
   // 2. Create Final Log Area\r
   //\r
-  for (Index = 0; Index < sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0]); Index++) {\r
     if ((mTcgDxeData.BsCap.SupportedEventLogs & mTcg2EventInfo[Index].LogFormat) != 0) {\r
       if (mTcg2EventInfo[Index].LogFormat == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2) {\r
         Status = gBS->AllocatePages (\r
@@ -1726,22 +1770,23 @@ SetupEventLog (
         if (EFI_ERROR (Status)) {\r
           return Status;\r
         }\r
+\r
         SetMem ((VOID *)(UINTN)Lasa, PcdGet32 (PcdTcg2FinalLogAreaLen), 0xFF);\r
 \r
         //\r
         // Initialize\r
         //\r
-        mTcgDxeData.FinalEventsTable[Index] = (VOID *)(UINTN)Lasa;\r
-        (mTcgDxeData.FinalEventsTable[Index])->Version = EFI_TCG2_FINAL_EVENTS_TABLE_VERSION;\r
+        mTcgDxeData.FinalEventsTable[Index]                   = (VOID *)(UINTN)Lasa;\r
+        (mTcgDxeData.FinalEventsTable[Index])->Version        = EFI_TCG2_FINAL_EVENTS_TABLE_VERSION;\r
         (mTcgDxeData.FinalEventsTable[Index])->NumberOfEvents = 0;\r
 \r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogFormat = mTcg2EventInfo[Index].LogFormat;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].Lasa = Lasa + sizeof(EFI_TCG2_FINAL_EVENTS_TABLE);\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].Laml = PcdGet32 (PcdTcg2FinalLogAreaLen) - sizeof(EFI_TCG2_FINAL_EVENTS_TABLE);\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogSize = 0;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].LastEvent = (VOID *)(UINTN)mTcgDxeData.FinalEventLogAreaStruct[Index].Lasa;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogStarted = FALSE;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogTruncated = FALSE;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogFormat        = mTcg2EventInfo[Index].LogFormat;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].Lasa                  = Lasa + sizeof (EFI_TCG2_FINAL_EVENTS_TABLE);\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].Laml                  = PcdGet32 (PcdTcg2FinalLogAreaLen) - sizeof (EFI_TCG2_FINAL_EVENTS_TABLE);\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogSize          = 0;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].LastEvent             = (VOID *)(UINTN)mTcgDxeData.FinalEventLogAreaStruct[Index].Lasa;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogStarted       = FALSE;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogTruncated     = FALSE;\r
         mTcgDxeData.FinalEventLogAreaStruct[Index].Next800155EventOffset = 0;\r
 \r
         //\r
@@ -1755,14 +1800,14 @@ SetupEventLog (
         //\r
         // No need to handle EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2\r
         //\r
-        mTcgDxeData.FinalEventsTable[Index] = NULL;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogFormat = mTcg2EventInfo[Index].LogFormat;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].Lasa = 0;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].Laml = 0;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogSize = 0;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].LastEvent = 0;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogStarted = FALSE;\r
-        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogTruncated = FALSE;\r
+        mTcgDxeData.FinalEventsTable[Index]                              = NULL;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogFormat        = mTcg2EventInfo[Index].LogFormat;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].Lasa                  = 0;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].Laml                  = 0;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogSize          = 0;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].LastEvent             = 0;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogStarted       = FALSE;\r
+        mTcgDxeData.FinalEventLogAreaStruct[Index].EventLogTruncated     = FALSE;\r
         mTcgDxeData.FinalEventLogAreaStruct[Index].Next800155EventOffset = 0;\r
       }\r
     }\r
@@ -1772,66 +1817,69 @@ SetupEventLog (
   // 3. Sync data from PEI to DXE\r
   //\r
   Status = EFI_SUCCESS;\r
-  for (Index = 0; Index < sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0]); Index++) {\r
     if ((mTcgDxeData.BsCap.SupportedEventLogs & mTcg2EventInfo[Index].LogFormat) != 0) {\r
       GuidHob.Raw = GetHobList ();\r
-      Status = EFI_SUCCESS;\r
+      Status      = EFI_SUCCESS;\r
       while (!EFI_ERROR (Status) &&\r
-             (GuidHob.Raw = GetNextGuidHob (mTcg2EventInfo[Index].EventGuid, GuidHob.Raw)) != NULL) {\r
-        TcgEvent    = AllocateCopyPool (GET_GUID_HOB_DATA_SIZE (GuidHob.Guid), GET_GUID_HOB_DATA (GuidHob.Guid));\r
+             (GuidHob.Raw = GetNextGuidHob (mTcg2EventInfo[Index].EventGuid, GuidHob.Raw)) != NULL)\r
+      {\r
+        TcgEvent = AllocateCopyPool (GET_GUID_HOB_DATA_SIZE (GuidHob.Guid), GET_GUID_HOB_DATA (GuidHob.Guid));\r
         ASSERT (TcgEvent != NULL);\r
         GuidHob.Raw = GET_NEXT_HOB (GuidHob);\r
         switch (mTcg2EventInfo[Index].LogFormat) {\r
-        case EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2:\r
-          Status = TcgDxeLogEvent (\r
-                     mTcg2EventInfo[Index].LogFormat,\r
-                     TcgEvent,\r
-                     sizeof(TCG_PCR_EVENT_HDR),\r
-                     ((TCG_PCR_EVENT*)TcgEvent)->Event,\r
-                     ((TCG_PCR_EVENT_HDR*)TcgEvent)->EventSize\r
-                     );\r
-          break;\r
-        case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:\r
-          DigestListBin = (UINT8 *)TcgEvent + sizeof(TCG_PCRINDEX) + sizeof(TCG_EVENTTYPE);\r
-          DigestListBinSize = GetDigestListBinSize (DigestListBin);\r
-          //\r
-          // Save event size.\r
-          //\r
-          CopyMem (&EventSize, (UINT8 *)DigestListBin + DigestListBinSize, sizeof(UINT32));\r
-          Event = (UINT8 *)DigestListBin + DigestListBinSize + sizeof(UINT32);\r
-          //\r
-          // Filter inactive digest in the event2 log from PEI HOB.\r
-          //\r
-          CopyMem (&TempDigestListBin, DigestListBin, GetDigestListBinSize (DigestListBin));\r
-          EventSizePtr = CopyDigestListBinToBuffer (\r
-                           DigestListBin,\r
-                           &TempDigestListBin,\r
-                           mTcgDxeData.BsCap.ActivePcrBanks,\r
-                           &HashAlgorithmMaskCopied\r
-                           );\r
-          if (HashAlgorithmMaskCopied != mTcgDxeData.BsCap.ActivePcrBanks) {\r
-            DEBUG ((\r
-              DEBUG_ERROR,\r
-              "ERROR: The event2 log includes digest hash mask 0x%x, but required digest hash mask is 0x%x\n",\r
-              HashAlgorithmMaskCopied,\r
-              mTcgDxeData.BsCap.ActivePcrBanks\r
-              ));\r
-          }\r
-          //\r
-          // Restore event size.\r
-          //\r
-          CopyMem (EventSizePtr, &EventSize, sizeof(UINT32));\r
-          DigestListBinSize = GetDigestListBinSize (DigestListBin);\r
-\r
-          Status = TcgDxeLogEvent (\r
-                     mTcg2EventInfo[Index].LogFormat,\r
-                     TcgEvent,\r
-                     sizeof(TCG_PCRINDEX) + sizeof(TCG_EVENTTYPE) + DigestListBinSize + sizeof(UINT32),\r
-                     Event,\r
-                     EventSize\r
-                     );\r
-          break;\r
+          case EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2:\r
+            Status = TcgDxeLogEvent (\r
+                       mTcg2EventInfo[Index].LogFormat,\r
+                       TcgEvent,\r
+                       sizeof (TCG_PCR_EVENT_HDR),\r
+                       ((TCG_PCR_EVENT *)TcgEvent)->Event,\r
+                       ((TCG_PCR_EVENT_HDR *)TcgEvent)->EventSize\r
+                       );\r
+            break;\r
+          case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:\r
+            DigestListBin     = (UINT8 *)TcgEvent + sizeof (TCG_PCRINDEX) + sizeof (TCG_EVENTTYPE);\r
+            DigestListBinSize = GetDigestListBinSize (DigestListBin);\r
+            //\r
+            // Save event size.\r
+            //\r
+            CopyMem (&EventSize, (UINT8 *)DigestListBin + DigestListBinSize, sizeof (UINT32));\r
+            Event = (UINT8 *)DigestListBin + DigestListBinSize + sizeof (UINT32);\r
+            //\r
+            // Filter inactive digest in the event2 log from PEI HOB.\r
+            //\r
+            CopyMem (&TempDigestListBin, DigestListBin, GetDigestListBinSize (DigestListBin));\r
+            EventSizePtr = CopyDigestListBinToBuffer (\r
+                             DigestListBin,\r
+                             &TempDigestListBin,\r
+                             mTcgDxeData.BsCap.ActivePcrBanks,\r
+                             &HashAlgorithmMaskCopied\r
+                             );\r
+            if (HashAlgorithmMaskCopied != mTcgDxeData.BsCap.ActivePcrBanks) {\r
+              DEBUG ((\r
+                DEBUG_ERROR,\r
+                "ERROR: The event2 log includes digest hash mask 0x%x, but required digest hash mask is 0x%x\n",\r
+                HashAlgorithmMaskCopied,\r
+                mTcgDxeData.BsCap.ActivePcrBanks\r
+                ));\r
+            }\r
+\r
+            //\r
+            // Restore event size.\r
+            //\r
+            CopyMem (EventSizePtr, &EventSize, sizeof (UINT32));\r
+            DigestListBinSize = GetDigestListBinSize (DigestListBin);\r
+\r
+            Status = TcgDxeLogEvent (\r
+                       mTcg2EventInfo[Index].LogFormat,\r
+                       TcgEvent,\r
+                       sizeof (TCG_PCRINDEX) + sizeof (TCG_EVENTTYPE) + DigestListBinSize + sizeof (UINT32),\r
+                       Event,\r
+                       EventSize\r
+                       );\r
+            break;\r
         }\r
+\r
         FreePool (TcgEvent);\r
       }\r
     }\r
@@ -1852,21 +1900,21 @@ SetupEventLog (
 **/\r
 EFI_STATUS\r
 TcgMeasureAction (\r
-  IN      TPM_PCRINDEX       PCRIndex,\r
-  IN      CHAR8              *String\r
+  IN      TPM_PCRINDEX  PCRIndex,\r
+  IN      CHAR8         *String\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
+  TCG_PCR_EVENT_HDR  TcgEvent;\r
 \r
   TcgEvent.PCRIndex  = PCRIndex;\r
   TcgEvent.EventType = EV_EFI_ACTION;\r
   TcgEvent.EventSize = (UINT32)AsciiStrLen (String);\r
   return TcgDxeHashLogExtendEvent (\r
            0,\r
-           (UINT8*)String,\r
+           (UINT8 *)String,\r
            TcgEvent.EventSize,\r
            &TcgEvent,\r
-           (UINT8 *) String\r
+           (UINT8 *)String\r
            );\r
 }\r
 \r
@@ -1882,40 +1930,40 @@ MeasureHandoffTables (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
-  EFI_HANDOFF_TABLE_POINTERS        HandoffTables;\r
-  UINTN                             ProcessorNum;\r
-  EFI_CPU_PHYSICAL_LOCATION         *ProcessorLocBuf;\r
+  EFI_STATUS                  Status;\r
+  TCG_PCR_EVENT_HDR           TcgEvent;\r
+  EFI_HANDOFF_TABLE_POINTERS  HandoffTables;\r
+  UINTN                       ProcessorNum;\r
+  EFI_CPU_PHYSICAL_LOCATION   *ProcessorLocBuf;\r
 \r
   ProcessorLocBuf = NULL;\r
-  Status = EFI_SUCCESS;\r
+  Status          = EFI_SUCCESS;\r
 \r
   if (PcdGet8 (PcdTpmPlatformClass) == TCG_PLATFORM_TYPE_SERVER) {\r
     //\r
     // Tcg Server spec.\r
     // Measure each processor EFI_CPU_PHYSICAL_LOCATION with EV_TABLE_OF_DEVICES to PCR[1]\r
     //\r
-    Status = GetProcessorsCpuLocation(&ProcessorLocBuf, &ProcessorNum);\r
+    Status = GetProcessorsCpuLocation (&ProcessorLocBuf, &ProcessorNum);\r
 \r
-    if (!EFI_ERROR(Status)){\r
+    if (!EFI_ERROR (Status)) {\r
       TcgEvent.PCRIndex  = 1;\r
       TcgEvent.EventType = EV_TABLE_OF_DEVICES;\r
       TcgEvent.EventSize = sizeof (HandoffTables);\r
 \r
-      HandoffTables.NumberOfTables = 1;\r
+      HandoffTables.NumberOfTables            = 1;\r
       HandoffTables.TableEntry[0].VendorGuid  = gEfiMpServiceProtocolGuid;\r
       HandoffTables.TableEntry[0].VendorTable = ProcessorLocBuf;\r
 \r
       Status = TcgDxeHashLogExtendEvent (\r
                  0,\r
-                 (UINT8*)(UINTN)ProcessorLocBuf,\r
-                 sizeof(EFI_CPU_PHYSICAL_LOCATION) * ProcessorNum,\r
+                 (UINT8 *)(UINTN)ProcessorLocBuf,\r
+                 sizeof (EFI_CPU_PHYSICAL_LOCATION) * ProcessorNum,\r
                  &TcgEvent,\r
-                 (UINT8*)&HandoffTables\r
+                 (UINT8 *)&HandoffTables\r
                  );\r
 \r
-      FreePool(ProcessorLocBuf);\r
+      FreePool (ProcessorLocBuf);\r
     }\r
   }\r
 \r
@@ -1933,15 +1981,15 @@ MeasureHandoffTables (
 **/\r
 EFI_STATUS\r
 MeasureSeparatorEvent (\r
-  IN      TPM_PCRINDEX              PCRIndex\r
+  IN      TPM_PCRINDEX  PCRIndex\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
-  UINT32                            EventData;\r
+  TCG_PCR_EVENT_HDR  TcgEvent;\r
+  UINT32             EventData;\r
 \r
   DEBUG ((DEBUG_INFO, "MeasureSeparatorEvent Pcr - %x\n", PCRIndex));\r
 \r
-  EventData = 0;\r
+  EventData          = 0;\r
   TcgEvent.PCRIndex  = PCRIndex;\r
   TcgEvent.EventType = EV_SEPARATOR;\r
   TcgEvent.EventSize = (UINT32)sizeof (EventData);\r
@@ -1971,18 +2019,18 @@ MeasureSeparatorEvent (
 **/\r
 EFI_STATUS\r
 MeasureVariable (\r
-  IN      TPM_PCRINDEX              PCRIndex,\r
-  IN      TCG_EVENTTYPE             EventType,\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  IN      VOID                      *VarData,\r
-  IN      UINTN                     VarSize\r
+  IN      TPM_PCRINDEX   PCRIndex,\r
+  IN      TCG_EVENTTYPE  EventType,\r
+  IN      CHAR16         *VarName,\r
+  IN      EFI_GUID       *VendorGuid,\r
+  IN      VOID           *VarData,\r
+  IN      UINTN          VarSize\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
-  UINTN                             VarNameLength;\r
-  UEFI_VARIABLE_DATA                *VarLog;\r
+  EFI_STATUS          Status;\r
+  TCG_PCR_EVENT_HDR   TcgEvent;\r
+  UINTN               VarNameLength;\r
+  UEFI_VARIABLE_DATA  *VarLog;\r
 \r
   DEBUG ((DEBUG_INFO, "Tcg2Dxe: MeasureVariable (Pcr - %x, EventType - %x, ", (UINTN)PCRIndex, (UINTN)EventType));\r
   DEBUG ((DEBUG_INFO, "VariableName - %s, VendorGuid - %g)\n", VarName, VendorGuid));\r
@@ -1992,7 +2040,7 @@ MeasureVariable (
   TcgEvent.EventType = EventType;\r
 \r
   TcgEvent.EventSize = (UINT32)(sizeof (*VarLog) + VarNameLength * sizeof (*VarName) + VarSize\r
-                        - sizeof (VarLog->UnicodeName) - sizeof (VarLog->VariableData));\r
+                                - sizeof (VarLog->UnicodeName) - sizeof (VarLog->VariableData));\r
 \r
   VarLog = (UEFI_VARIABLE_DATA *)AllocatePool (TcgEvent.EventSize);\r
   if (VarLog == NULL) {\r
@@ -2003,16 +2051,16 @@ MeasureVariable (
   VarLog->UnicodeNameLength  = VarNameLength;\r
   VarLog->VariableDataLength = VarSize;\r
   CopyMem (\r
-     VarLog->UnicodeName,\r
-     VarName,\r
-     VarNameLength * sizeof (*VarName)\r
-     );\r
-  if (VarSize != 0 && VarData != NULL) {\r
+    VarLog->UnicodeName,\r
+    VarName,\r
+    VarNameLength * sizeof (*VarName)\r
+    );\r
+  if ((VarSize != 0) && (VarData != NULL)) {\r
     CopyMem (\r
-       (CHAR16 *)VarLog->UnicodeName + VarNameLength,\r
-       VarData,\r
-       VarSize\r
-       );\r
+      (CHAR16 *)VarLog->UnicodeName + VarNameLength,\r
+      VarData,\r
+      VarSize\r
+      );\r
   }\r
 \r
   if (EventType == EV_EFI_VARIABLE_DRIVER_CONFIG) {\r
@@ -2021,21 +2069,22 @@ MeasureVariable (
     //\r
     Status = TcgDxeHashLogExtendEvent (\r
                0,\r
-               (UINT8*)VarLog,\r
+               (UINT8 *)VarLog,\r
                TcgEvent.EventSize,\r
                &TcgEvent,\r
-               (UINT8*)VarLog\r
+               (UINT8 *)VarLog\r
                );\r
   } else {\r
     ASSERT (VarData != NULL);\r
     Status = TcgDxeHashLogExtendEvent (\r
                0,\r
-               (UINT8*)VarData,\r
+               (UINT8 *)VarData,\r
                VarSize,\r
                &TcgEvent,\r
-               (UINT8*)VarLog\r
+               (UINT8 *)VarLog\r
                );\r
   }\r
+\r
   FreePool (VarLog);\r
   return Status;\r
 }\r
@@ -2057,15 +2106,15 @@ MeasureVariable (
 **/\r
 EFI_STATUS\r
 ReadAndMeasureVariable (\r
-  IN      TPM_PCRINDEX              PCRIndex,\r
-  IN      TCG_EVENTTYPE             EventType,\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  OUT     UINTN                     *VarSize,\r
-  OUT     VOID                      **VarData\r
+  IN      TPM_PCRINDEX   PCRIndex,\r
+  IN      TCG_EVENTTYPE  EventType,\r
+  IN      CHAR16         *VarName,\r
+  IN      EFI_GUID       *VendorGuid,\r
+  OUT     UINTN          *VarSize,\r
+  OUT     VOID           **VarData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = GetVariable2 (VarName, VendorGuid, VarData, VarSize);\r
   if (EventType == EV_EFI_VARIABLE_DRIVER_CONFIG) {\r
@@ -2112,10 +2161,10 @@ according to TCG PC Client PFP spec 0021 Section 2.4.4.2
 **/\r
 EFI_STATUS\r
 ReadAndMeasureBootVariable (\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  OUT     UINTN                     *VarSize,\r
-  OUT     VOID                      **VarData\r
+  IN      CHAR16    *VarName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  OUT     UINTN     *VarSize,\r
+  OUT     VOID      **VarData\r
   )\r
 {\r
   return ReadAndMeasureVariable (\r
@@ -2143,10 +2192,10 @@ ReadAndMeasureBootVariable (
 **/\r
 EFI_STATUS\r
 ReadAndMeasureSecureVariable (\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  OUT     UINTN                     *VarSize,\r
-  OUT     VOID                      **VarData\r
+  IN      CHAR16    *VarName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  OUT     UINTN     *VarSize,\r
+  OUT     VOID      **VarData\r
   )\r
 {\r
   return ReadAndMeasureVariable (\r
@@ -2174,20 +2223,20 @@ MeasureAllBootVariables (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINT16                            *BootOrder;\r
-  UINTN                             BootCount;\r
-  UINTN                             Index;\r
-  VOID                              *BootVarData;\r
-  UINTN                             Size;\r
+  EFI_STATUS  Status;\r
+  UINT16      *BootOrder;\r
+  UINTN       BootCount;\r
+  UINTN       Index;\r
+  VOID        *BootVarData;\r
+  UINTN       Size;\r
 \r
   Status = ReadAndMeasureBootVariable (\r
              mBootVarName,\r
              &gEfiGlobalVariableGuid,\r
              &BootCount,\r
-             (VOID **) &BootOrder\r
+             (VOID **)&BootOrder\r
              );\r
-  if (Status == EFI_NOT_FOUND || BootOrder == NULL) {\r
+  if ((Status == EFI_NOT_FOUND) || (BootOrder == NULL)) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
@@ -2232,13 +2281,13 @@ MeasureAllSecureVariables (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  VOID                              *Data;\r
-  UINTN                             DataSize;\r
-  UINTN                             Index;\r
+  EFI_STATUS  Status;\r
+  VOID        *Data;\r
+  UINTN       DataSize;\r
+  UINTN       Index;\r
 \r
   Status = EFI_NOT_FOUND;\r
-  for (Index = 0; Index < sizeof(mVariableType)/sizeof(mVariableType[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mVariableType)/sizeof (mVariableType[0]); Index++) {\r
     Status = ReadAndMeasureSecureVariable (\r
                mVariableType[Index].VariableName,\r
                mVariableType[Index].VendorGuid,\r
@@ -2256,7 +2305,7 @@ MeasureAllSecureVariables (
   // Measure DBT if present and not empty\r
   //\r
   Status = GetVariable2 (EFI_IMAGE_SECURITY_DATABASE2, &gEfiImageSecurityDatabaseGuid, &Data, &DataSize);\r
-  if (!EFI_ERROR(Status)) {\r
+  if (!EFI_ERROR (Status)) {\r
     Status = MeasureVariable (\r
                7,\r
                EV_EFI_VARIABLE_DRIVER_CONFIG,\r
@@ -2265,9 +2314,9 @@ MeasureAllSecureVariables (
                Data,\r
                DataSize\r
                );\r
-    FreePool(Data);\r
+    FreePool (Data);\r
   } else {\r
-    DEBUG((DEBUG_INFO, "Skip measuring variable %s since it's deleted\n", EFI_IMAGE_SECURITY_DATABASE2));\r
+    DEBUG ((DEBUG_INFO, "Skip measuring variable %s since it's deleted\n", EFI_IMAGE_SECURITY_DATABASE2));\r
   }\r
 \r
   return EFI_SUCCESS;\r
@@ -2286,15 +2335,15 @@ MeasureLaunchOfFirmwareDebugger (
   VOID\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
+  TCG_PCR_EVENT_HDR  TcgEvent;\r
 \r
   TcgEvent.PCRIndex  = 7;\r
   TcgEvent.EventType = EV_EFI_ACTION;\r
-  TcgEvent.EventSize = sizeof(FIRMWARE_DEBUGGER_EVENT_STRING) - 1;\r
+  TcgEvent.EventSize = sizeof (FIRMWARE_DEBUGGER_EVENT_STRING) - 1;\r
   return TcgDxeHashLogExtendEvent (\r
            0,\r
            (UINT8 *)FIRMWARE_DEBUGGER_EVENT_STRING,\r
-           sizeof(FIRMWARE_DEBUGGER_EVENT_STRING) - 1,\r
+           sizeof (FIRMWARE_DEBUGGER_EVENT_STRING) - 1,\r
            &TcgEvent,\r
            (UINT8 *)FIRMWARE_DEBUGGER_EVENT_STRING\r
            );\r
@@ -2321,8 +2370,8 @@ MeasureLaunchOfFirmwareDebugger (
 VOID\r
 EFIAPI\r
 MeasureSecureBootPolicy (\r
-  IN EFI_EVENT                      Event,\r
-  IN VOID                           *Context\r
+  IN EFI_EVENT  Event,\r
+  IN VOID       *Context\r
   )\r
 {\r
   EFI_STATUS  Status;\r
@@ -2349,7 +2398,7 @@ MeasureSecureBootPolicy (
   //\r
   Status = MeasureSeparatorEvent (7);\r
   DEBUG ((DEBUG_INFO, "MeasureSeparatorEvent - %r\n", Status));\r
-  return ;\r
+  return;\r
 }\r
 \r
 /**\r
@@ -2364,16 +2413,15 @@ MeasureSecureBootPolicy (
 VOID\r
 EFIAPI\r
 OnReadyToBoot (\r
-  IN      EFI_EVENT                 Event,\r
-  IN      VOID                      *Context\r
+  IN      EFI_EVENT  Event,\r
+  IN      VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM_PCRINDEX                      PcrIndex;\r
+  EFI_STATUS    Status;\r
+  TPM_PCRINDEX  PcrIndex;\r
 \r
   PERF_START_EX (mImageHandle, "EventRec", "Tcg2Dxe", 0, PERF_ID_TCG2_DXE);\r
   if (mBootAttempts == 0) {\r
-\r
     //\r
     // Measure handoff tables.\r
     //\r
@@ -2468,11 +2516,11 @@ OnReadyToBoot (
 VOID\r
 EFIAPI\r
 OnExitBootServices (\r
-  IN      EFI_EVENT                 Event,\r
-  IN      VOID                      *Context\r
+  IN      EFI_EVENT  Event,\r
+  IN      VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   //\r
   // Measure invocation of ExitBootServices,\r
@@ -2509,11 +2557,11 @@ OnExitBootServices (
 VOID\r
 EFIAPI\r
 OnExitBootServicesFailed (\r
-  IN      EFI_EVENT                 Event,\r
-  IN      VOID                      *Context\r
+  IN      EFI_EVENT  Event,\r
+  IN      VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   //\r
   // Measure Failure of ExitBootServices,\r
@@ -2525,7 +2573,6 @@ OnExitBootServicesFailed (
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "%a not Measured. Error!\n", EFI_EXIT_BOOT_SERVICES_FAILED));\r
   }\r
-\r
 }\r
 \r
 /**\r
@@ -2548,13 +2595,14 @@ OnExitBootServicesFailed (
 VOID\r
 EFIAPI\r
 ShutdownTpmOnReset (\r
-  IN EFI_RESET_TYPE           ResetType,\r
-  IN EFI_STATUS               ResetStatus,\r
-  IN UINTN                    DataSize,\r
-  IN VOID                     *ResetData OPTIONAL\r
+  IN EFI_RESET_TYPE  ResetType,\r
+  IN EFI_STATUS      ResetStatus,\r
+  IN UINTN           DataSize,\r
+  IN VOID            *ResetData OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
+  EFI_STATUS  Status;\r
+\r
   Status = Tpm2Shutdown (TPM_SU_CLEAR);\r
   DEBUG ((DEBUG_VERBOSE, "Tpm2Shutdown (SU_CLEAR) - %r\n", Status));\r
 }\r
@@ -2570,14 +2618,14 @@ ShutdownTpmOnReset (
 VOID\r
 EFIAPI\r
 OnResetNotificationInstall (\r
-  IN EFI_EVENT                      Event,\r
-  IN VOID                           *Context\r
+  IN EFI_EVENT  Event,\r
+  IN VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_RESET_NOTIFICATION_PROTOCOL   *ResetNotify;\r
+  EFI_STATUS                       Status;\r
+  EFI_RESET_NOTIFICATION_PROTOCOL  *ResetNotify;\r
 \r
-  Status = gBS->LocateProtocol (&gEfiResetNotificationProtocolGuid, NULL, (VOID **) &ResetNotify);\r
+  Status = gBS->LocateProtocol (&gEfiResetNotificationProtocolGuid, NULL, (VOID **)&ResetNotify);\r
   if (!EFI_ERROR (Status)) {\r
     Status = ResetNotify->RegisterResetNotify (ResetNotify, ShutdownTpmOnReset);\r
     ASSERT_EFI_ERROR (Status);\r
@@ -2598,8 +2646,8 @@ InstallTcg2 (
   VOID\r
   )\r
 {\r
-  EFI_STATUS        Status;\r
-  EFI_HANDLE        Handle;\r
+  EFI_STATUS  Status;\r
+  EFI_HANDLE  Handle;\r
 \r
   Handle = NULL;\r
   Status = gBS->InstallMultipleProtocolInterfaces (\r
@@ -2623,24 +2671,25 @@ InstallTcg2 (
 EFI_STATUS\r
 EFIAPI\r
 DriverEntry (\r
-  IN    EFI_HANDLE                  ImageHandle,\r
-  IN    EFI_SYSTEM_TABLE            *SystemTable\r
+  IN    EFI_HANDLE        ImageHandle,\r
+  IN    EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_EVENT                         Event;\r
-  VOID                              *Registration;\r
-  UINT32                            MaxCommandSize;\r
-  UINT32                            MaxResponseSize;\r
-  UINTN                             Index;\r
-  EFI_TCG2_EVENT_ALGORITHM_BITMAP   TpmHashAlgorithmBitmap;\r
-  UINT32                            ActivePCRBanks;\r
-  UINT32                            NumberOfPCRBanks;\r
+  EFI_STATUS                       Status;\r
+  EFI_EVENT                        Event;\r
+  VOID                             *Registration;\r
+  UINT32                           MaxCommandSize;\r
+  UINT32                           MaxResponseSize;\r
+  UINTN                            Index;\r
+  EFI_TCG2_EVENT_ALGORITHM_BITMAP  TpmHashAlgorithmBitmap;\r
+  UINT32                           ActivePCRBanks;\r
+  UINT32                           NumberOfPCRBanks;\r
 \r
   mImageHandle = ImageHandle;\r
 \r
-  if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceNoneGuid) ||\r
-      CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)){\r
+  if (CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceNoneGuid) ||\r
+      CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid))\r
+  {\r
     DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -2659,11 +2708,11 @@ DriverEntry (
   //\r
   // Fill information\r
   //\r
-  ASSERT (TCG_EVENT_LOG_AREA_COUNT_MAX == sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0]));\r
+  ASSERT (TCG_EVENT_LOG_AREA_COUNT_MAX == sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0]));\r
 \r
-  mTcgDxeData.BsCap.Size = sizeof(EFI_TCG2_BOOT_SERVICE_CAPABILITY);\r
-  mTcgDxeData.BsCap.ProtocolVersion.Major = 1;\r
-  mTcgDxeData.BsCap.ProtocolVersion.Minor = 1;\r
+  mTcgDxeData.BsCap.Size                   = sizeof (EFI_TCG2_BOOT_SERVICE_CAPABILITY);\r
+  mTcgDxeData.BsCap.ProtocolVersion.Major  = 1;\r
+  mTcgDxeData.BsCap.ProtocolVersion.Minor  = 1;\r
   mTcgDxeData.BsCap.StructureVersion.Major = 1;\r
   mTcgDxeData.BsCap.StructureVersion.Minor = 1;\r
 \r
@@ -2678,15 +2727,16 @@ DriverEntry (
   }\r
 \r
   DEBUG_CODE_BEGIN ();\r
-    UINT32                    FirmwareVersion1;\r
-    UINT32                    FirmwareVersion2;\r
+  UINT32  FirmwareVersion1;\r
+  UINT32  FirmwareVersion2;\r
+\r
+  Status = Tpm2GetCapabilityFirmwareVersion (&FirmwareVersion1, &FirmwareVersion2);\r
+  if (EFI_ERROR (Status)) {\r
+    DEBUG ((DEBUG_ERROR, "Tpm2GetCapabilityFirmwareVersion fail!\n"));\r
+  } else {\r
+    DEBUG ((DEBUG_INFO, "Tpm2GetCapabilityFirmwareVersion - %08x %08x\n", FirmwareVersion1, FirmwareVersion2));\r
+  }\r
 \r
-    Status = Tpm2GetCapabilityFirmwareVersion (&FirmwareVersion1, &FirmwareVersion2);\r
-    if (EFI_ERROR (Status)) {\r
-      DEBUG ((DEBUG_ERROR, "Tpm2GetCapabilityFirmwareVersion fail!\n"));\r
-    } else {\r
-      DEBUG ((DEBUG_INFO, "Tpm2GetCapabilityFirmwareVersion - %08x %08x\n", FirmwareVersion1, FirmwareVersion2));\r
-    }\r
   DEBUG_CODE_END ();\r
 \r
   Status = Tpm2GetCapabilityMaxCommandResponseSize (&MaxCommandSize, &MaxResponseSize);\r
@@ -2705,7 +2755,7 @@ DriverEntry (
   ASSERT_EFI_ERROR (Status);\r
 \r
   mTcgDxeData.BsCap.HashAlgorithmBitmap = TpmHashAlgorithmBitmap & PcdGet32 (PcdTcg2HashAlgorithmBitmap);\r
-  mTcgDxeData.BsCap.ActivePcrBanks = ActivePCRBanks & PcdGet32 (PcdTcg2HashAlgorithmBitmap);\r
+  mTcgDxeData.BsCap.ActivePcrBanks      = ActivePCRBanks & PcdGet32 (PcdTcg2HashAlgorithmBitmap);\r
 \r
   //\r
   // Need calculate NumberOfPCRBanks here, because HashAlgorithmBitmap might be removed by PCD.\r
index 7eb02f08f94fd9982baf93b5c3b1acf1f3af9ba8..a97a4e7f2d7a40e971bcff7ae3a438d277a0fe18 100644 (file)
@@ -44,17 +44,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define PERF_ID_TCG2_PEI  0x3080\r
 \r
 typedef struct {\r
-  EFI_GUID                   *EventGuid;\r
-  EFI_TCG2_EVENT_LOG_FORMAT  LogFormat;\r
+  EFI_GUID                     *EventGuid;\r
+  EFI_TCG2_EVENT_LOG_FORMAT    LogFormat;\r
 } TCG2_EVENT_INFO_STRUCT;\r
 \r
-TCG2_EVENT_INFO_STRUCT mTcg2EventInfo[] = {\r
-  {&gTcgEventEntryHobGuid,   EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2},\r
-  {&gTcgEvent2EntryHobGuid,  EFI_TCG2_EVENT_LOG_FORMAT_TCG_2},\r
+TCG2_EVENT_INFO_STRUCT  mTcg2EventInfo[] = {\r
+  { &gTcgEventEntryHobGuid,  EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2 },\r
+  { &gTcgEvent2EntryHobGuid, EFI_TCG2_EVENT_LOG_FORMAT_TCG_2   },\r
 };\r
 \r
-BOOLEAN                 mImageInMemory  = FALSE;\r
-EFI_PEI_FILE_HANDLE     mFileHandle;\r
+BOOLEAN              mImageInMemory = FALSE;\r
+EFI_PEI_FILE_HANDLE  mFileHandle;\r
 \r
 EFI_PEI_PPI_DESCRIPTOR  mTpmInitializedPpiList = {\r
   EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,\r
@@ -92,15 +92,15 @@ EFI_PEI_PPI_DESCRIPTOR  mTpmInitializationDonePpiList = {
 EFI_STATUS\r
 EFIAPI\r
 HashLogExtendEvent (\r
-  IN      EDKII_TCG_PPI             *This,\r
-  IN      UINT64                    Flags,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINTN                     HashDataLen,\r
-  IN      TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      EDKII_TCG_PPI      *This,\r
+  IN      UINT64             Flags,\r
+  IN      UINT8              *HashData,\r
+  IN      UINTN              HashDataLen,\r
+  IN      TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   );\r
 \r
-EDKII_TCG_PPI mEdkiiTcgPpi = {\r
+EDKII_TCG_PPI  mEdkiiTcgPpi = {\r
   HashLogExtendEvent\r
 };\r
 \r
@@ -113,24 +113,24 @@ EFI_PEI_PPI_DESCRIPTOR  mTcgPpiList = {
 //\r
 // Number of firmware blobs to grow by each time we run out of room\r
 //\r
-#define FIRMWARE_BLOB_GROWTH_STEP 4\r
+#define FIRMWARE_BLOB_GROWTH_STEP  4\r
 \r
-EFI_PLATFORM_FIRMWARE_BLOB *mMeasuredBaseFvInfo;\r
-UINT32 mMeasuredMaxBaseFvIndex = 0;\r
-UINT32 mMeasuredBaseFvIndex = 0;\r
+EFI_PLATFORM_FIRMWARE_BLOB  *mMeasuredBaseFvInfo;\r
+UINT32                      mMeasuredMaxBaseFvIndex = 0;\r
+UINT32                      mMeasuredBaseFvIndex    = 0;\r
 \r
-EFI_PLATFORM_FIRMWARE_BLOB *mMeasuredChildFvInfo;\r
-UINT32 mMeasuredMaxChildFvIndex = 0;\r
-UINT32 mMeasuredChildFvIndex = 0;\r
+EFI_PLATFORM_FIRMWARE_BLOB  *mMeasuredChildFvInfo;\r
+UINT32                      mMeasuredMaxChildFvIndex = 0;\r
+UINT32                      mMeasuredChildFvIndex    = 0;\r
 \r
 #pragma pack (1)\r
 \r
 #define FV_HANDOFF_TABLE_DESC  "Fv(XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX)"\r
 typedef struct {\r
-  UINT8                             BlobDescriptionSize;\r
-  UINT8                             BlobDescription[sizeof(FV_HANDOFF_TABLE_DESC)];\r
-  EFI_PHYSICAL_ADDRESS              BlobBase;\r
-  UINT64                            BlobLength;\r
+  UINT8                   BlobDescriptionSize;\r
+  UINT8                   BlobDescription[sizeof (FV_HANDOFF_TABLE_DESC)];\r
+  EFI_PHYSICAL_ADDRESS    BlobBase;\r
+  UINT64                  BlobLength;\r
 } FV_HANDOFF_TABLE_POINTERS2;\r
 \r
 #pragma pack ()\r
@@ -149,9 +149,9 @@ typedef struct {
 EFI_STATUS\r
 EFIAPI\r
 FirmwareVolumeInfoPpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   );\r
 \r
 /**\r
@@ -168,12 +168,12 @@ FirmwareVolumeInfoPpiNotifyCallback (
 EFI_STATUS\r
 EFIAPI\r
 EndofPeiSignalNotifyCallBack (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   );\r
 \r
-EFI_PEI_NOTIFY_DESCRIPTOR           mNotifyList[] = {\r
+EFI_PEI_NOTIFY_DESCRIPTOR  mNotifyList[] = {\r
   {\r
     EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK,\r
     &gEfiPeiFirmwareVolumeInfoPpiGuid,\r
@@ -191,7 +191,6 @@ EFI_PEI_NOTIFY_DESCRIPTOR           mNotifyList[] = {
   }\r
 };\r
 \r
-\r
 /**\r
   Record all measured Firmware Volume Information into a Guid Hob\r
   Guid Hob payload layout is\r
@@ -210,12 +209,12 @@ EFI_PEI_NOTIFY_DESCRIPTOR           mNotifyList[] = {
 EFI_STATUS\r
 EFIAPI\r
 EndofPeiSignalNotifyCallBack (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
-  MEASURED_HOB_DATA *MeasuredHobData;\r
+  MEASURED_HOB_DATA  *MeasuredHobData;\r
 \r
   MeasuredHobData = NULL;\r
 \r
@@ -224,12 +223,12 @@ EndofPeiSignalNotifyCallBack (
   //\r
   // Create a Guid hob to save all measured Fv\r
   //\r
-  MeasuredHobData = BuildGuidHob(\r
+  MeasuredHobData = BuildGuidHob (\r
                       &gMeasuredFvHobGuid,\r
-                      sizeof(UINTN) + sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex + mMeasuredChildFvIndex)\r
+                      sizeof (UINTN) + sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex + mMeasuredChildFvIndex)\r
                       );\r
 \r
-  if (MeasuredHobData != NULL){\r
+  if (MeasuredHobData != NULL) {\r
     //\r
     // Save measured FV info enty number\r
     //\r
@@ -238,12 +237,12 @@ EndofPeiSignalNotifyCallBack (
     //\r
     // Save measured base Fv info\r
     //\r
-    CopyMem (MeasuredHobData->MeasuredFvBuf, mMeasuredBaseFvInfo, sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex));\r
+    CopyMem (MeasuredHobData->MeasuredFvBuf, mMeasuredBaseFvInfo, sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex));\r
 \r
     //\r
     // Save measured child Fv info\r
     //\r
-    CopyMem (&MeasuredHobData->MeasuredFvBuf[mMeasuredBaseFvIndex] , mMeasuredChildFvInfo, sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredChildFvIndex));\r
+    CopyMem (&MeasuredHobData->MeasuredFvBuf[mMeasuredBaseFvIndex], mMeasuredChildFvInfo, sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredChildFvIndex));\r
   }\r
 \r
   PERF_CALLBACK_END (&gEfiEndOfPeiSignalPpiGuid);\r
@@ -260,12 +259,12 @@ SyncPcrAllocationsAndPcrMask (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_TCG2_EVENT_ALGORITHM_BITMAP   TpmHashAlgorithmBitmap;\r
-  UINT32                            TpmActivePcrBanks;\r
-  UINT32                            NewTpmActivePcrBanks;\r
-  UINT32                            Tpm2PcrMask;\r
-  UINT32                            NewTpm2PcrMask;\r
+  EFI_STATUS                       Status;\r
+  EFI_TCG2_EVENT_ALGORITHM_BITMAP  TpmHashAlgorithmBitmap;\r
+  UINT32                           TpmActivePcrBanks;\r
+  UINT32                           NewTpmActivePcrBanks;\r
+  UINT32                           Tpm2PcrMask;\r
+  UINT32                           NewTpm2PcrMask;\r
 \r
   DEBUG ((DEBUG_ERROR, "SyncPcrAllocationsAndPcrMask!\n"));\r
 \r
@@ -310,10 +309,11 @@ SyncPcrAllocationsAndPcrMask (
         DEBUG ((DEBUG_ERROR, "%a - Failed to reallocate PCRs!\n", __FUNCTION__));\r
         ASSERT_EFI_ERROR (Status);\r
       }\r
+\r
       //\r
       // Need reset system, since we just called Tpm2PcrAllocateBanks().\r
       //\r
-      ResetCold();\r
+      ResetCold ();\r
     }\r
   }\r
 \r
@@ -347,66 +347,67 @@ SyncPcrAllocationsAndPcrMask (
 **/\r
 EFI_STATUS\r
 LogHashEvent (\r
-  IN TPML_DIGEST_VALUES             *DigestList,\r
-  IN OUT  TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN TPML_DIGEST_VALUES      *DigestList,\r
+  IN OUT  TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
-  VOID                              *HobData;\r
-  EFI_STATUS                        Status;\r
-  UINTN                             Index;\r
-  EFI_STATUS                        RetStatus;\r
-  UINT32                            SupportedEventLogs;\r
-  TCG_PCR_EVENT2                    *TcgPcrEvent2;\r
-  UINT8                             *DigestBuffer;\r
+  VOID            *HobData;\r
+  EFI_STATUS      Status;\r
+  UINTN           Index;\r
+  EFI_STATUS      RetStatus;\r
+  UINT32          SupportedEventLogs;\r
+  TCG_PCR_EVENT2  *TcgPcrEvent2;\r
+  UINT8           *DigestBuffer;\r
 \r
   SupportedEventLogs = EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2 | EFI_TCG2_EVENT_LOG_FORMAT_TCG_2;\r
 \r
   RetStatus = EFI_SUCCESS;\r
-  for (Index = 0; Index < sizeof(mTcg2EventInfo)/sizeof(mTcg2EventInfo[0]); Index++) {\r
+  for (Index = 0; Index < sizeof (mTcg2EventInfo)/sizeof (mTcg2EventInfo[0]); Index++) {\r
     if ((SupportedEventLogs & mTcg2EventInfo[Index].LogFormat) != 0) {\r
       DEBUG ((DEBUG_INFO, "  LogFormat - 0x%08x\n", mTcg2EventInfo[Index].LogFormat));\r
       switch (mTcg2EventInfo[Index].LogFormat) {\r
-      case EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2:\r
-        Status = GetDigestFromDigestList (TPM_ALG_SHA1, DigestList, &NewEventHdr->Digest);\r
-        if (!EFI_ERROR (Status)) {\r
+        case EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2:\r
+          Status = GetDigestFromDigestList (TPM_ALG_SHA1, DigestList, &NewEventHdr->Digest);\r
+          if (!EFI_ERROR (Status)) {\r
+            HobData = BuildGuidHob (\r
+                        &gTcgEventEntryHobGuid,\r
+                        sizeof (*NewEventHdr) + NewEventHdr->EventSize\r
+                        );\r
+            if (HobData == NULL) {\r
+              RetStatus = EFI_OUT_OF_RESOURCES;\r
+              break;\r
+            }\r
+\r
+            CopyMem (HobData, NewEventHdr, sizeof (*NewEventHdr));\r
+            HobData = (VOID *)((UINT8 *)HobData + sizeof (*NewEventHdr));\r
+            CopyMem (HobData, NewEventData, NewEventHdr->EventSize);\r
+          }\r
+\r
+          break;\r
+        case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:\r
+          //\r
+          // Use GetDigestListSize (DigestList) in the GUID HOB DataLength calculation\r
+          // to reserve enough buffer to hold TPML_DIGEST_VALUES compact binary.\r
+          //\r
           HobData = BuildGuidHob (\r
-                     &gTcgEventEntryHobGuid,\r
-                     sizeof (*NewEventHdr) + NewEventHdr->EventSize\r
-                     );\r
+                      &gTcgEvent2EntryHobGuid,\r
+                      sizeof (TcgPcrEvent2->PCRIndex) + sizeof (TcgPcrEvent2->EventType) + GetDigestListSize (DigestList) + sizeof (TcgPcrEvent2->EventSize) + NewEventHdr->EventSize\r
+                      );\r
           if (HobData == NULL) {\r
             RetStatus = EFI_OUT_OF_RESOURCES;\r
             break;\r
           }\r
 \r
-          CopyMem (HobData, NewEventHdr, sizeof (*NewEventHdr));\r
-          HobData = (VOID *) ((UINT8*)HobData + sizeof (*NewEventHdr));\r
-          CopyMem (HobData, NewEventData, NewEventHdr->EventSize);\r
-        }\r
-        break;\r
-      case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:\r
-        //\r
-        // Use GetDigestListSize (DigestList) in the GUID HOB DataLength calculation\r
-        // to reserve enough buffer to hold TPML_DIGEST_VALUES compact binary.\r
-        //\r
-        HobData = BuildGuidHob (\r
-                   &gTcgEvent2EntryHobGuid,\r
-                   sizeof(TcgPcrEvent2->PCRIndex) + sizeof(TcgPcrEvent2->EventType) + GetDigestListSize (DigestList) + sizeof(TcgPcrEvent2->EventSize) + NewEventHdr->EventSize\r
-                   );\r
-        if (HobData == NULL) {\r
-          RetStatus = EFI_OUT_OF_RESOURCES;\r
+          TcgPcrEvent2            = HobData;\r
+          TcgPcrEvent2->PCRIndex  = NewEventHdr->PCRIndex;\r
+          TcgPcrEvent2->EventType = NewEventHdr->EventType;\r
+          DigestBuffer            = (UINT8 *)&TcgPcrEvent2->Digest;\r
+          DigestBuffer            = CopyDigestListToBuffer (DigestBuffer, DigestList, PcdGet32 (PcdTpm2HashMask));\r
+          CopyMem (DigestBuffer, &NewEventHdr->EventSize, sizeof (TcgPcrEvent2->EventSize));\r
+          DigestBuffer = DigestBuffer + sizeof (TcgPcrEvent2->EventSize);\r
+          CopyMem (DigestBuffer, NewEventData, NewEventHdr->EventSize);\r
           break;\r
-        }\r
-\r
-        TcgPcrEvent2 = HobData;\r
-        TcgPcrEvent2->PCRIndex = NewEventHdr->PCRIndex;\r
-        TcgPcrEvent2->EventType = NewEventHdr->EventType;\r
-        DigestBuffer = (UINT8 *)&TcgPcrEvent2->Digest;\r
-        DigestBuffer = CopyDigestListToBuffer (DigestBuffer, DigestList, PcdGet32 (PcdTpm2HashMask));\r
-        CopyMem (DigestBuffer, &NewEventHdr->EventSize, sizeof(TcgPcrEvent2->EventSize));\r
-        DigestBuffer = DigestBuffer + sizeof(TcgPcrEvent2->EventSize);\r
-        CopyMem (DigestBuffer, NewEventData, NewEventHdr->EventSize);\r
-        break;\r
       }\r
     }\r
   }\r
@@ -438,30 +439,30 @@ LogHashEvent (
 EFI_STATUS\r
 EFIAPI\r
 HashLogExtendEvent (\r
-  IN      EDKII_TCG_PPI             *This,\r
-  IN      UINT64                    Flags,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINTN                     HashDataLen,\r
-  IN      TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      EDKII_TCG_PPI      *This,\r
+  IN      UINT64             Flags,\r
+  IN      UINT8              *HashData,\r
+  IN      UINTN              HashDataLen,\r
+  IN      TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPML_DIGEST_VALUES                DigestList;\r
+  EFI_STATUS          Status;\r
+  TPML_DIGEST_VALUES  DigestList;\r
 \r
   if (GetFirstGuidHob (&gTpmErrorHobGuid) != NULL) {\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  if ((Flags & EDKII_TCG_PRE_HASH) != 0 || (Flags & EDKII_TCG_PRE_HASH_LOG_ONLY) != 0) {\r
-    ZeroMem (&DigestList, sizeof(DigestList));\r
-    CopyMem (&DigestList, HashData, sizeof(DigestList));\r
+  if (((Flags & EDKII_TCG_PRE_HASH) != 0) || ((Flags & EDKII_TCG_PRE_HASH_LOG_ONLY) != 0)) {\r
+    ZeroMem (&DigestList, sizeof (DigestList));\r
+    CopyMem (&DigestList, HashData, sizeof (DigestList));\r
     Status = EFI_SUCCESS;\r
-    if ((Flags & EDKII_TCG_PRE_HASH) !=0 ) {\r
+    if ((Flags & EDKII_TCG_PRE_HASH) != 0 ) {\r
       Status = Tpm2PcrExtend (\r
-               NewEventHdr->PCRIndex,\r
-               &DigestList\r
-               );\r
+                 NewEventHdr->PCRIndex,\r
+                 &DigestList\r
+                 );\r
     }\r
   } else {\r
     Status = HashAndExtend (\r
@@ -471,13 +472,14 @@ HashLogExtendEvent (
                &DigestList\r
                );\r
   }\r
+\r
   if (!EFI_ERROR (Status)) {\r
     Status = LogHashEvent (&DigestList, NewEventHdr, NewEventData);\r
   }\r
 \r
   if (Status == EFI_DEVICE_ERROR) {\r
     DEBUG ((DEBUG_ERROR, "HashLogExtendEvent - %r. Disable TPM.\n", Status));\r
-    BuildGuidHob (&gTpmErrorHobGuid,0);\r
+    BuildGuidHob (&gTpmErrorHobGuid, 0);\r
     REPORT_STATUS_CODE (\r
       EFI_ERROR_CODE | EFI_ERROR_MINOR,\r
       (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERROR)\r
@@ -500,7 +502,7 @@ MeasureCRTMVersion (
   VOID\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEventHdr;\r
+  TCG_PCR_EVENT_HDR  TcgEventHdr;\r
 \r
   //\r
   // Use FirmwareVersion string to represent CRTM version.\r
@@ -509,15 +511,15 @@ MeasureCRTMVersion (
 \r
   TcgEventHdr.PCRIndex  = 0;\r
   TcgEventHdr.EventType = EV_S_CRTM_VERSION;\r
-  TcgEventHdr.EventSize = (UINT32) StrSize((CHAR16*)PcdGetPtr (PcdFirmwareVersionString));\r
+  TcgEventHdr.EventSize = (UINT32)StrSize ((CHAR16 *)PcdGetPtr (PcdFirmwareVersionString));\r
 \r
   return HashLogExtendEvent (\r
            &mEdkiiTcgPpi,\r
            0,\r
-           (UINT8*)PcdGetPtr (PcdFirmwareVersionString),\r
+           (UINT8 *)PcdGetPtr (PcdFirmwareVersionString),\r
            TcgEventHdr.EventSize,\r
            &TcgEventHdr,\r
-           (UINT8*)PcdGetPtr (PcdFirmwareVersionString)\r
+           (UINT8 *)PcdGetPtr (PcdFirmwareVersionString)\r
            );\r
 }\r
 \r
@@ -534,8 +536,8 @@ MeasureCRTMVersion (
 **/\r
 VOID *\r
 GetFvName (\r
-  IN EFI_PHYSICAL_ADDRESS           FvBase,\r
-  IN UINT64                         FvLength\r
+  IN EFI_PHYSICAL_ADDRESS  FvBase,\r
+  IN UINT64                FvLength\r
   )\r
 {\r
   EFI_FIRMWARE_VOLUME_HEADER      *FvHeader;\r
@@ -544,20 +546,24 @@ GetFvName (
   if (FvBase >= MAX_ADDRESS) {\r
     return NULL;\r
   }\r
+\r
   if (FvLength >= MAX_ADDRESS - FvBase) {\r
     return NULL;\r
   }\r
-  if (FvLength < sizeof(EFI_FIRMWARE_VOLUME_HEADER)) {\r
+\r
+  if (FvLength < sizeof (EFI_FIRMWARE_VOLUME_HEADER)) {\r
     return NULL;\r
   }\r
 \r
   FvHeader = (EFI_FIRMWARE_VOLUME_HEADER *)(UINTN)FvBase;\r
-  if (FvHeader->ExtHeaderOffset < sizeof(EFI_FIRMWARE_VOLUME_HEADER)) {\r
+  if (FvHeader->ExtHeaderOffset < sizeof (EFI_FIRMWARE_VOLUME_HEADER)) {\r
     return NULL;\r
   }\r
-  if (FvHeader->ExtHeaderOffset + sizeof(EFI_FIRMWARE_VOLUME_EXT_HEADER) > FvLength) {\r
+\r
+  if (FvHeader->ExtHeaderOffset + sizeof (EFI_FIRMWARE_VOLUME_EXT_HEADER) > FvLength) {\r
     return NULL;\r
   }\r
+\r
   FvExtHeader = (EFI_FIRMWARE_VOLUME_EXT_HEADER *)(UINTN)(FvBase + FvHeader->ExtHeaderOffset);\r
 \r
   return &FvExtHeader->FvName;\r
@@ -578,45 +584,46 @@ GetFvName (
 **/\r
 EFI_STATUS\r
 MeasureFvImage (\r
-  IN EFI_PHYSICAL_ADDRESS           FvBase,\r
-  IN UINT64                         FvLength\r
+  IN EFI_PHYSICAL_ADDRESS  FvBase,\r
+  IN UINT64                FvLength\r
   )\r
 {\r
-  UINT32                                                Index;\r
-  EFI_STATUS                                            Status;\r
-  EFI_PLATFORM_FIRMWARE_BLOB                            FvBlob;\r
-  FV_HANDOFF_TABLE_POINTERS2                            FvBlob2;\r
-  VOID                                                  *EventData;\r
-  VOID                                                  *FvName;\r
-  TCG_PCR_EVENT_HDR                                     TcgEventHdr;\r
-  UINT32                                                Instance;\r
-  UINT32                                                Tpm2HashMask;\r
-  TPML_DIGEST_VALUES                                    DigestList;\r
-  UINT32                                                DigestCount;\r
-  EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI *MeasurementExcludedFvPpi;\r
-  EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI       *PrehashedFvPpi;\r
-  HASH_INFO                                             *PreHashInfo;\r
-  UINT32                                                HashAlgoMask;\r
-  EFI_PHYSICAL_ADDRESS                                  FvOrgBase;\r
-  EFI_PHYSICAL_ADDRESS                                  FvDataBase;\r
-  EFI_PEI_HOB_POINTERS                                  Hob;\r
-  EDKII_MIGRATED_FV_INFO                                *MigratedFvInfo;\r
+  UINT32                                                 Index;\r
+  EFI_STATUS                                             Status;\r
+  EFI_PLATFORM_FIRMWARE_BLOB                             FvBlob;\r
+  FV_HANDOFF_TABLE_POINTERS2                             FvBlob2;\r
+  VOID                                                   *EventData;\r
+  VOID                                                   *FvName;\r
+  TCG_PCR_EVENT_HDR                                      TcgEventHdr;\r
+  UINT32                                                 Instance;\r
+  UINT32                                                 Tpm2HashMask;\r
+  TPML_DIGEST_VALUES                                     DigestList;\r
+  UINT32                                                 DigestCount;\r
+  EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI  *MeasurementExcludedFvPpi;\r
+  EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI        *PrehashedFvPpi;\r
+  HASH_INFO                                              *PreHashInfo;\r
+  UINT32                                                 HashAlgoMask;\r
+  EFI_PHYSICAL_ADDRESS                                   FvOrgBase;\r
+  EFI_PHYSICAL_ADDRESS                                   FvDataBase;\r
+  EFI_PEI_HOB_POINTERS                                   Hob;\r
+  EDKII_MIGRATED_FV_INFO                                 *MigratedFvInfo;\r
 \r
   //\r
   // Check Excluded FV list\r
   //\r
   Instance = 0;\r
   do {\r
-    Status = PeiServicesLocatePpi(\r
-                 &gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid,\r
-                 Instance,\r
-                 NULL,\r
-                 (VOID**)&MeasurementExcludedFvPpi\r
-                 );\r
-    if (!EFI_ERROR(Status)) {\r
-      for (Index = 0; Index < MeasurementExcludedFvPpi->Count; Index ++) {\r
-        if (MeasurementExcludedFvPpi->Fv[Index].FvBase == FvBase\r
-         && MeasurementExcludedFvPpi->Fv[Index].FvLength == FvLength) {\r
+    Status = PeiServicesLocatePpi (\r
+               &gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid,\r
+               Instance,\r
+               NULL,\r
+               (VOID **)&MeasurementExcludedFvPpi\r
+               );\r
+    if (!EFI_ERROR (Status)) {\r
+      for (Index = 0; Index < MeasurementExcludedFvPpi->Count; Index++) {\r
+        if (  (MeasurementExcludedFvPpi->Fv[Index].FvBase == FvBase)\r
+           && (MeasurementExcludedFvPpi->Fv[Index].FvLength == FvLength))\r
+        {\r
           DEBUG ((DEBUG_INFO, "The FV which is excluded by Tcg2Pei starts at: 0x%x\n", FvBase));\r
           DEBUG ((DEBUG_INFO, "The FV which is excluded by Tcg2Pei has the size: 0x%x\n", FvLength));\r
           return EFI_SUCCESS;\r
@@ -625,13 +632,13 @@ MeasureFvImage (
 \r
       Instance++;\r
     }\r
-  } while (!EFI_ERROR(Status));\r
+  } while (!EFI_ERROR (Status));\r
 \r
   //\r
   // Check measured FV list\r
   //\r
-  for (Index = 0; Index < mMeasuredBaseFvIndex; Index ++) {\r
-    if (mMeasuredBaseFvInfo[Index].BlobBase == FvBase && mMeasuredBaseFvInfo[Index].BlobLength == FvLength) {\r
+  for (Index = 0; Index < mMeasuredBaseFvIndex; Index++) {\r
+    if ((mMeasuredBaseFvInfo[Index].BlobBase == FvBase) && (mMeasuredBaseFvInfo[Index].BlobLength == FvLength)) {\r
       DEBUG ((DEBUG_INFO, "The FV which is already measured by Tcg2Pei starts at: 0x%x\n", FvBase));\r
       DEBUG ((DEBUG_INFO, "The FV which is already measured by Tcg2Pei has the size: 0x%x\n", FvLength));\r
       return EFI_SUCCESS;\r
@@ -648,23 +655,23 @@ MeasureFvImage (
                &gEdkiiPeiFirmwareVolumeInfoPrehashedFvPpiGuid,\r
                Instance,\r
                NULL,\r
-               (VOID**)&PrehashedFvPpi\r
+               (VOID **)&PrehashedFvPpi\r
                );\r
-    if (!EFI_ERROR(Status) && PrehashedFvPpi->FvBase == FvBase && PrehashedFvPpi->FvLength == FvLength) {\r
-      ZeroMem (&DigestList, sizeof(TPML_DIGEST_VALUES));\r
+    if (!EFI_ERROR (Status) && (PrehashedFvPpi->FvBase == FvBase) && (PrehashedFvPpi->FvLength == FvLength)) {\r
+      ZeroMem (&DigestList, sizeof (TPML_DIGEST_VALUES));\r
 \r
       //\r
       // The FV is prehashed, check against TPM hash mask\r
       //\r
       PreHashInfo = (HASH_INFO *)(PrehashedFvPpi + 1);\r
       for (Index = 0, DigestCount = 0; Index < PrehashedFvPpi->Count; Index++) {\r
-        DEBUG((DEBUG_INFO, "Hash Algo ID in PrehashedFvPpi=0x%x\n", PreHashInfo->HashAlgoId));\r
-        HashAlgoMask = GetHashMaskFromAlgo(PreHashInfo->HashAlgoId);\r
+        DEBUG ((DEBUG_INFO, "Hash Algo ID in PrehashedFvPpi=0x%x\n", PreHashInfo->HashAlgoId));\r
+        HashAlgoMask = GetHashMaskFromAlgo (PreHashInfo->HashAlgoId);\r
         if ((Tpm2HashMask & HashAlgoMask) != 0 ) {\r
           //\r
           // Hash is required, copy it to DigestList\r
           //\r
-          WriteUnaligned16(&(DigestList.digests[DigestCount].hashAlg), PreHashInfo->HashAlgoId);\r
+          WriteUnaligned16 (&(DigestList.digests[DigestCount].hashAlg), PreHashInfo->HashAlgoId);\r
           CopyMem (\r
             &DigestList.digests[DigestCount].digest,\r
             PreHashInfo + 1,\r
@@ -676,32 +683,35 @@ MeasureFvImage (
           //\r
           Tpm2HashMask &= ~HashAlgoMask;\r
         }\r
+\r
         PreHashInfo = (HASH_INFO *)((UINT8 *)(PreHashInfo + 1) + PreHashInfo->HashSize);\r
       }\r
 \r
-      WriteUnaligned32(&DigestList.count, DigestCount);\r
+      WriteUnaligned32 (&DigestList.count, DigestCount);\r
 \r
       break;\r
     }\r
+\r
     Instance++;\r
-  } while (!EFI_ERROR(Status));\r
+  } while (!EFI_ERROR (Status));\r
 \r
   //\r
   // Search the matched migration FV info\r
   //\r
   FvOrgBase  = FvBase;\r
   FvDataBase = FvBase;\r
-  Hob.Raw  = GetFirstGuidHob (&gEdkiiMigratedFvInfoGuid);\r
+  Hob.Raw    = GetFirstGuidHob (&gEdkiiMigratedFvInfoGuid);\r
   while (Hob.Raw != NULL) {\r
     MigratedFvInfo = GET_GUID_HOB_DATA (Hob);\r
-    if ((MigratedFvInfo->FvNewBase == (UINT32) FvBase) && (MigratedFvInfo->FvLength == (UINT32) FvLength)) {\r
+    if ((MigratedFvInfo->FvNewBase == (UINT32)FvBase) && (MigratedFvInfo->FvLength == (UINT32)FvLength)) {\r
       //\r
       // Found the migrated FV info\r
       //\r
-      FvOrgBase  = (EFI_PHYSICAL_ADDRESS) (UINTN) MigratedFvInfo->FvOrgBase;\r
-      FvDataBase = (EFI_PHYSICAL_ADDRESS) (UINTN) MigratedFvInfo->FvDataBase;\r
+      FvOrgBase  = (EFI_PHYSICAL_ADDRESS)(UINTN)MigratedFvInfo->FvOrgBase;\r
+      FvDataBase = (EFI_PHYSICAL_ADDRESS)(UINTN)MigratedFvInfo->FvDataBase;\r
       break;\r
     }\r
+\r
     Hob.Raw = GET_NEXT_HOB (Hob);\r
     Hob.Raw = GetNextGuidHob (&gEdkiiMigratedFvInfoGuid, Hob.Raw);\r
   }\r
@@ -709,13 +719,14 @@ MeasureFvImage (
   //\r
   // Init the log event for FV measurement\r
   //\r
-  if (PcdGet32(PcdTcgPfpMeasurementRevision) >= TCG_EfiSpecIDEventStruct_SPEC_ERRATA_TPM2_REV_105) {\r
-    FvBlob2.BlobDescriptionSize = sizeof(FvBlob2.BlobDescription);\r
-    CopyMem (FvBlob2.BlobDescription, FV_HANDOFF_TABLE_DESC, sizeof(FvBlob2.BlobDescription));\r
+  if (PcdGet32 (PcdTcgPfpMeasurementRevision) >= TCG_EfiSpecIDEventStruct_SPEC_ERRATA_TPM2_REV_105) {\r
+    FvBlob2.BlobDescriptionSize = sizeof (FvBlob2.BlobDescription);\r
+    CopyMem (FvBlob2.BlobDescription, FV_HANDOFF_TABLE_DESC, sizeof (FvBlob2.BlobDescription));\r
     FvName = GetFvName (FvBase, FvLength);\r
     if (FvName != NULL) {\r
-      AsciiSPrint ((CHAR8 *)FvBlob2.BlobDescription, sizeof(FvBlob2.BlobDescription), "Fv(%g)", FvName);\r
+      AsciiSPrint ((CHAR8 *)FvBlob2.BlobDescription, sizeof (FvBlob2.BlobDescription), "Fv(%g)", FvName);\r
     }\r
+\r
     FvBlob2.BlobBase      = FvOrgBase;\r
     FvBlob2.BlobLength    = FvLength;\r
     TcgEventHdr.PCRIndex  = 0;\r
@@ -739,8 +750,8 @@ MeasureFvImage (
     Status = HashLogExtendEvent (\r
                &mEdkiiTcgPpi,\r
                EDKII_TCG_PRE_HASH,\r
-               (UINT8*) &DigestList,        // HashData\r
-               (UINTN) sizeof(DigestList),  // HashDataLen\r
+               (UINT8 *)&DigestList,        // HashData\r
+               (UINTN)sizeof (DigestList),  // HashDataLen\r
                &TcgEventHdr,                // EventHdr\r
                EventData                    // EventData\r
                );\r
@@ -753,16 +764,16 @@ MeasureFvImage (
     Status = HashLogExtendEvent (\r
                &mEdkiiTcgPpi,\r
                0,\r
-               (UINT8*) (UINTN) FvDataBase, // HashData\r
-               (UINTN) FvLength,        // HashDataLen\r
-               &TcgEventHdr,            // EventHdr\r
-               EventData                // EventData\r
+               (UINT8 *)(UINTN)FvDataBase, // HashData\r
+               (UINTN)FvLength,            // HashDataLen\r
+               &TcgEventHdr,               // EventHdr\r
+               EventData                   // EventData\r
                );\r
     DEBUG ((DEBUG_INFO, "The FV which is measured by Tcg2Pei starts at: 0x%x\n", FvBase));\r
     DEBUG ((DEBUG_INFO, "The FV which is measured by Tcg2Pei has the size: 0x%x\n", FvLength));\r
   }\r
 \r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "The FV which failed to be measured starts at: 0x%x\n", FvBase));\r
     return Status;\r
   }\r
@@ -800,10 +811,10 @@ MeasureMainBios (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_PEI_FV_HANDLE                 VolumeHandle;\r
-  EFI_FV_INFO                       VolumeInfo;\r
-  EFI_PEI_FIRMWARE_VOLUME_PPI       *FvPpi;\r
+  EFI_STATUS                   Status;\r
+  EFI_PEI_FV_HANDLE            VolumeHandle;\r
+  EFI_FV_INFO                  VolumeInfo;\r
+  EFI_PEI_FIRMWARE_VOLUME_PPI  *FvPpi;\r
 \r
   PERF_START_EX (mFileHandle, "EventRec", "Tcg2Pei", 0, PERF_ID_TCG2_PEI);\r
 \r
@@ -830,11 +841,11 @@ MeasureMainBios (
              &VolumeInfo.FvFormat,\r
              0,\r
              NULL,\r
-             (VOID**)&FvPpi\r
+             (VOID **)&FvPpi\r
              );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  Status = MeasureFvImage ((EFI_PHYSICAL_ADDRESS) (UINTN) VolumeInfo.FvStart, VolumeInfo.FvSize);\r
+  Status = MeasureFvImage ((EFI_PHYSICAL_ADDRESS)(UINTN)VolumeInfo.FvStart, VolumeInfo.FvSize);\r
 \r
   PERF_END_EX (mFileHandle, "EventRec", "Tcg2Pei", 0, PERF_ID_TCG2_PEI + 1);\r
 \r
@@ -855,9 +866,9 @@ MeasureMainBios (
 EFI_STATUS\r
 EFIAPI\r
 FirmwareVolumeInfoPpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES               **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR      *NotifyDescriptor,\r
-  IN VOID                           *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
   EFI_PEI_FIRMWARE_VOLUME_INFO_PPI  *Fv;\r
@@ -865,7 +876,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
   EFI_PEI_FIRMWARE_VOLUME_PPI       *FvPpi;\r
   UINTN                             Index;\r
 \r
-  Fv = (EFI_PEI_FIRMWARE_VOLUME_INFO_PPI *) Ppi;\r
+  Fv = (EFI_PEI_FIRMWARE_VOLUME_INFO_PPI *)Ppi;\r
 \r
   //\r
   // The PEI Core can not dispatch or load files from memory mapped FVs that do not support FvPpi.\r
@@ -874,7 +885,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
              &Fv->FvFormat,\r
              0,\r
              NULL,\r
-             (VOID**)&FvPpi\r
+             (VOID **)&FvPpi\r
              );\r
   if (EFI_ERROR (Status)) {\r
     return EFI_SUCCESS;\r
@@ -884,8 +895,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
   // This is an FV from an FFS file, and the parent FV must have already been measured,\r
   // No need to measure twice, so just record the FV and return\r
   //\r
-  if (Fv->ParentFvName != NULL || Fv->ParentFileName != NULL ) {\r
-\r
+  if ((Fv->ParentFvName != NULL) || (Fv->ParentFileName != NULL)) {\r
     if (mMeasuredChildFvIndex >= mMeasuredMaxChildFvIndex) {\r
       mMeasuredChildFvInfo = ReallocatePool (\r
                                sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * mMeasuredMaxChildFvIndex,\r
@@ -895,21 +905,23 @@ FirmwareVolumeInfoPpiNotifyCallback (
       ASSERT (mMeasuredChildFvInfo != NULL);\r
       mMeasuredMaxChildFvIndex = mMeasuredMaxChildFvIndex + FIRMWARE_BLOB_GROWTH_STEP;\r
     }\r
+\r
     //\r
     // Check whether FV is in the measured child FV list.\r
     //\r
     for (Index = 0; Index < mMeasuredChildFvIndex; Index++) {\r
-      if (mMeasuredChildFvInfo[Index].BlobBase == (EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo) {\r
+      if (mMeasuredChildFvInfo[Index].BlobBase == (EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo) {\r
         return EFI_SUCCESS;\r
       }\r
     }\r
-    mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobBase   = (EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo;\r
+\r
+    mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobBase   = (EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo;\r
     mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobLength = Fv->FvInfoSize;\r
     mMeasuredChildFvIndex++;\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  return MeasureFvImage ((EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo, Fv->FvInfoSize);\r
+  return MeasureFvImage ((EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo, Fv->FvInfoSize);\r
 }\r
 \r
 /**\r
@@ -924,10 +936,10 @@ FirmwareVolumeInfoPpiNotifyCallback (
 **/\r
 EFI_STATUS\r
 PeimEntryMP (\r
-  IN      EFI_PEI_SERVICES          **PeiServices\r
+  IN      EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   //\r
   // install Tcg Services\r
@@ -940,7 +952,7 @@ PeimEntryMP (
   }\r
 \r
   Status = MeasureMainBios ();\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
@@ -966,20 +978,20 @@ PeimEntryMP (
 **/\r
 EFI_STATUS\r
 MeasureSeparatorEventWithError (\r
-  IN      TPM_PCRINDEX              PCRIndex\r
+  IN      TPM_PCRINDEX  PCRIndex\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
-  UINT32                            EventData;\r
+  TCG_PCR_EVENT_HDR  TcgEvent;\r
+  UINT32             EventData;\r
 \r
   //\r
   // Use EventData 0x1 to indicate there is error.\r
   //\r
-  EventData = 0x1;\r
+  EventData          = 0x1;\r
   TcgEvent.PCRIndex  = PCRIndex;\r
   TcgEvent.EventType = EV_SEPARATOR;\r
   TcgEvent.EventSize = (UINT32)sizeof (EventData);\r
-  return HashLogExtendEvent(&mEdkiiTcgPpi, 0, (UINT8 *)&EventData, TcgEvent.EventSize, &TcgEvent,(UINT8 *)&EventData);\r
+  return HashLogExtendEvent (&mEdkiiTcgPpi, 0, (UINT8 *)&EventData, TcgEvent.EventSize, &TcgEvent, (UINT8 *)&EventData);\r
 }\r
 \r
 /**\r
@@ -994,18 +1006,19 @@ MeasureSeparatorEventWithError (
 EFI_STATUS\r
 EFIAPI\r
 PeimEntryMA (\r
-  IN       EFI_PEI_FILE_HANDLE      FileHandle,\r
-  IN CONST EFI_PEI_SERVICES         **PeiServices\r
+  IN       EFI_PEI_FILE_HANDLE  FileHandle,\r
+  IN CONST EFI_PEI_SERVICES     **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_STATUS                        Status2;\r
-  EFI_BOOT_MODE                     BootMode;\r
-  TPM_PCRINDEX                      PcrIndex;\r
-  BOOLEAN                           S3ErrorReport;\r
-\r
-  if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceNoneGuid) ||\r
-      CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)){\r
+  EFI_STATUS     Status;\r
+  EFI_STATUS     Status2;\r
+  EFI_BOOT_MODE  BootMode;\r
+  TPM_PCRINDEX   PcrIndex;\r
+  BOOLEAN        S3ErrorReport;\r
+\r
+  if (CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceNoneGuid) ||\r
+      CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid))\r
+  {\r
     DEBUG ((DEBUG_INFO, "No TPM2 instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -1022,10 +1035,10 @@ PeimEntryMA (
   // In S3 path, skip shadow logic. no measurement is required\r
   //\r
   if (BootMode != BOOT_ON_S3_RESUME) {\r
-    Status = (**PeiServices).RegisterForShadow(FileHandle);\r
+    Status = (**PeiServices).RegisterForShadow (FileHandle);\r
     if (Status == EFI_ALREADY_STARTED) {\r
       mImageInMemory = TRUE;\r
-      mFileHandle = FileHandle;\r
+      mFileHandle    = FileHandle;\r
     } else if (Status == EFI_NOT_FOUND) {\r
       ASSERT_EFI_ERROR (Status);\r
     }\r
@@ -1045,16 +1058,17 @@ PeimEntryMA (
     if (PcdGet8 (PcdTpm2InitializationPolicy) == 1) {\r
       if (BootMode == BOOT_ON_S3_RESUME) {\r
         Status = Tpm2Startup (TPM_SU_STATE);\r
-        if (EFI_ERROR (Status) ) {\r
+        if (EFI_ERROR (Status)) {\r
           Status = Tpm2Startup (TPM_SU_CLEAR);\r
-          if (!EFI_ERROR(Status)) {\r
+          if (!EFI_ERROR (Status)) {\r
             S3ErrorReport = TRUE;\r
           }\r
         }\r
       } else {\r
         Status = Tpm2Startup (TPM_SU_CLEAR);\r
       }\r
-      if (EFI_ERROR (Status) ) {\r
+\r
+      if (EFI_ERROR (Status)) {\r
         goto Done;\r
       }\r
     }\r
@@ -1100,19 +1114,20 @@ PeimEntryMA (
   }\r
 \r
   if (mImageInMemory) {\r
-    Status = PeimEntryMP ((EFI_PEI_SERVICES**)PeiServices);\r
+    Status = PeimEntryMP ((EFI_PEI_SERVICES **)PeiServices);\r
     return Status;\r
   }\r
 \r
 Done:\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "TPM2 error! Build Hob\n"));\r
-    BuildGuidHob (&gTpmErrorHobGuid,0);\r
+    BuildGuidHob (&gTpmErrorHobGuid, 0);\r
     REPORT_STATUS_CODE (\r
       EFI_ERROR_CODE | EFI_ERROR_MINOR,\r
       (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERROR)\r
       );\r
   }\r
+\r
   //\r
   // Always install TpmInitializationDonePpi no matter success or fail.\r
   // Other driver can know TPM initialization state by TpmInitializedPpi.\r
index 150cf748ffd07d7e5d79412bec1a1d02ff6d4f30..b9ed6cf8f94dd3c54495f06426e0a93b2ed19859 100644 (file)
@@ -30,8 +30,8 @@ SmmReadyToLockEventCallBack (
   IN VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS   Status;\r
-  VOID         *Interface;\r
+  EFI_STATUS  Status;\r
+  VOID        *Interface;\r
 \r
   //\r
   // Try to locate it because EfiCreateProtocolNotifyEvent will trigger it once when registration.\r
@@ -43,7 +43,7 @@ SmmReadyToLockEventCallBack (
                   &Interface\r
                   );\r
   if (EFI_ERROR (Status)) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   ConfigureTpmPlatformHierarchy ();\r
@@ -64,8 +64,8 @@ SmmReadyToLockEventCallBack (
 EFI_STATUS\r
 EFIAPI\r
 Tcg2PlatformDxeEntryPoint (\r
-  IN    EFI_HANDLE                  ImageHandle,\r
-  IN    EFI_SYSTEM_TABLE            *SystemTable\r
+  IN    EFI_HANDLE        ImageHandle,\r
+  IN    EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   VOID       *Registration;\r
index 21d2c1433dfe201f8ca44a3d5c46538dfdf5b729..de475318bd86b269b50bc7ef6b6171b311f4276e 100644 (file)
@@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include <Ppi/EndOfPeiPhase.h>\r
 \r
-#define MAX_NEW_AUTHORIZATION_SIZE        SHA512_DIGEST_SIZE\r
+#define MAX_NEW_AUTHORIZATION_SIZE  SHA512_DIGEST_SIZE\r
 \r
 /**\r
   This function handles PlatformInit task at the end of PEI\r
@@ -41,14 +41,14 @@ PlatformInitEndOfPei (
   IN VOID                       *Ppi\r
   )\r
 {\r
-  VOID *TcgEventLog;\r
+  VOID  *TcgEventLog;\r
 \r
   //\r
   // Try to get TcgEventLog in S3 to see if S3 error is reported.\r
   //\r
-  TcgEventLog = GetFirstGuidHob(&gTcgEventEntryHobGuid);\r
+  TcgEventLog = GetFirstGuidHob (&gTcgEventEntryHobGuid);\r
   if (TcgEventLog == NULL) {\r
-    TcgEventLog = GetFirstGuidHob(&gTcgEvent2EntryHobGuid);\r
+    TcgEventLog = GetFirstGuidHob (&gTcgEvent2EntryHobGuid);\r
   }\r
 \r
   if (TcgEventLog == NULL) {\r
@@ -89,11 +89,11 @@ Tcg2PlatformPeiEntryPoint (
   IN CONST EFI_PEI_SERVICES     **PeiServices\r
   )\r
 {\r
-  EFI_STATUS               Status;\r
-  EFI_BOOT_MODE            BootMode;\r
+  EFI_STATUS     Status;\r
+  EFI_BOOT_MODE  BootMode;\r
 \r
   Status = PeiServicesGetBootMode (&BootMode);\r
-  ASSERT_EFI_ERROR(Status);\r
+  ASSERT_EFI_ERROR (Status);\r
 \r
   if (BootMode != BOOT_ON_S3_RESUME) {\r
     return EFI_SUCCESS;\r
index 4f2d7c58ed8653f583686c9fc8a9c9b411f62c35..eb69b870ed432deb1eb9cfcb45ad4624f3de98ce 100644 (file)
@@ -29,12 +29,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 Tcg2MmDependencyDxeEntryPoint (\r
-  IN EFI_HANDLE                           ImageHandle,\r
-  IN EFI_SYSTEM_TABLE                     *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  EFI_HANDLE            Handle;\r
+  EFI_STATUS  Status;\r
+  EFI_HANDLE  Handle;\r
 \r
   Handle = NULL;\r
   Status = gBS->InstallProtocolInterface (\r
index 9f5111552b82309fbaddeb0f38058751f8120cfe..498fb626bd9c956b57f412a1cba0d7e9cb4c31eb 100644 (file)
@@ -18,10 +18,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include "Tcg2Smm.h"\r
 \r
 EFI_SMM_VARIABLE_PROTOCOL  *mSmmVariable = NULL;\r
-TCG_NVS                    *mTcgNvs = NULL;\r
-UINTN                       mPpSoftwareSmi;\r
-UINTN                       mMcSoftwareSmi;\r
-EFI_HANDLE                  mReadyToLockHandle;\r
+TCG_NVS                    *mTcgNvs      = NULL;\r
+UINTN                      mPpSoftwareSmi;\r
+UINTN                      mMcSoftwareSmi;\r
+EFI_HANDLE                 mReadyToLockHandle;\r
 \r
 /**\r
   Communication service SMI Handler entry.\r
@@ -47,32 +47,33 @@ EFI_HANDLE                  mReadyToLockHandle;
 EFI_STATUS\r
 EFIAPI\r
 TpmNvsCommunciate (\r
-  IN     EFI_HANDLE                   DispatchHandle,\r
-  IN     CONST VOID                   *RegisterContext,\r
-  IN OUT VOID                         *CommBuffer,\r
-  IN OUT UINTN                        *CommBufferSize\r
+  IN     EFI_HANDLE  DispatchHandle,\r
+  IN     CONST VOID  *RegisterContext,\r
+  IN OUT VOID        *CommBuffer,\r
+  IN OUT UINTN       *CommBufferSize\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  UINTN                     TempCommBufferSize;\r
-  TPM_NVS_MM_COMM_BUFFER    *CommParams;\r
+  EFI_STATUS              Status;\r
+  UINTN                   TempCommBufferSize;\r
+  TPM_NVS_MM_COMM_BUFFER  *CommParams;\r
 \r
   DEBUG ((DEBUG_VERBOSE, "%a()\n", __FUNCTION__));\r
 \r
   //\r
   // If input is invalid, stop processing this SMI\r
   //\r
-  if (CommBuffer == NULL || CommBufferSize == NULL) {\r
+  if ((CommBuffer == NULL) || (CommBufferSize == NULL)) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
   TempCommBufferSize = *CommBufferSize;\r
 \r
-  if(TempCommBufferSize != sizeof (TPM_NVS_MM_COMM_BUFFER)) {\r
+  if (TempCommBufferSize != sizeof (TPM_NVS_MM_COMM_BUFFER)) {\r
     DEBUG ((DEBUG_ERROR, "[%a] MM Communication buffer size is invalid for this handler!\n", __FUNCTION__));\r
     return EFI_ACCESS_DENIED;\r
   }\r
-  if (!IsBufferOutsideMmValid ((UINTN) CommBuffer, TempCommBufferSize)) {\r
+\r
+  if (!IsBufferOutsideMmValid ((UINTN)CommBuffer, TempCommBufferSize)) {\r
     DEBUG ((DEBUG_ERROR, "[%a] - MM Communication buffer in invalid location!\n", __FUNCTION__));\r
     return EFI_ACCESS_DENIED;\r
   }\r
@@ -80,14 +81,14 @@ TpmNvsCommunciate (
   //\r
   // Farm out the job to individual functions based on what was requested.\r
   //\r
-  CommParams = (TPM_NVS_MM_COMM_BUFFER*) CommBuffer;\r
-  Status = EFI_SUCCESS;\r
+  CommParams = (TPM_NVS_MM_COMM_BUFFER *)CommBuffer;\r
+  Status     = EFI_SUCCESS;\r
   switch (CommParams->Function) {\r
     case TpmNvsMmExchangeInfo:\r
       DEBUG ((DEBUG_VERBOSE, "[%a] - Function requested: MM_EXCHANGE_NVS_INFO\n", __FUNCTION__));\r
       CommParams->RegisteredPpSwiValue = mPpSoftwareSmi;\r
       CommParams->RegisteredMcSwiValue = mMcSoftwareSmi;\r
-      mTcgNvs = (TCG_NVS*) (UINTN) CommParams->TargetAddress;\r
+      mTcgNvs                          = (TCG_NVS *)(UINTN)CommParams->TargetAddress;\r
       break;\r
 \r
     default:\r
@@ -96,7 +97,7 @@ TpmNvsCommunciate (
       break;\r
   }\r
 \r
-  CommParams->ReturnStatus = (UINT64) Status;\r
+  CommParams->ReturnStatus = (UINT64)Status;\r
   return EFI_SUCCESS;\r
 }\r
 \r
@@ -120,17 +121,16 @@ TpmNvsCommunciate (
 EFI_STATUS\r
 EFIAPI\r
 PhysicalPresenceCallback (\r
-  IN EFI_HANDLE                  DispatchHandle,\r
-  IN CONST VOID                  *Context,\r
-  IN OUT VOID                    *CommBuffer,\r
-  IN OUT UINTN                   *CommBufferSize\r
+  IN EFI_HANDLE  DispatchHandle,\r
+  IN CONST VOID  *Context,\r
+  IN OUT VOID    *CommBuffer,\r
+  IN OUT UINTN   *CommBufferSize\r
   )\r
 {\r
-  UINT32                MostRecentRequest;\r
-  UINT32                Response;\r
-  UINT32                OperationRequest;\r
-  UINT32                RequestParameter;\r
-\r
+  UINT32  MostRecentRequest;\r
+  UINT32  Response;\r
+  UINT32  OperationRequest;\r
+  UINT32  RequestParameter;\r
 \r
   if (mTcgNvs->PhysicalPresence.Parameter == TCG_ACPI_FUNCTION_RETURN_REQUEST_RESPONSE_TO_OS) {\r
     mTcgNvs->PhysicalPresence.ReturnCode = Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (\r
@@ -138,18 +138,18 @@ PhysicalPresenceCallback (
                                              &Response\r
                                              );\r
     mTcgNvs->PhysicalPresence.LastRequest = MostRecentRequest;\r
-    mTcgNvs->PhysicalPresence.Response = Response;\r
+    mTcgNvs->PhysicalPresence.Response    = Response;\r
     return EFI_SUCCESS;\r
-  } else if ((mTcgNvs->PhysicalPresence.Parameter == TCG_ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS)\r
-          || (mTcgNvs->PhysicalPresence.Parameter == TCG_ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS_2)) {\r
-\r
-    OperationRequest = mTcgNvs->PhysicalPresence.Request;\r
-    RequestParameter = mTcgNvs->PhysicalPresence.RequestParameter;\r
+  } else if (  (mTcgNvs->PhysicalPresence.Parameter == TCG_ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS)\r
+            || (mTcgNvs->PhysicalPresence.Parameter == TCG_ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS_2))\r
+  {\r
+    OperationRequest                     = mTcgNvs->PhysicalPresence.Request;\r
+    RequestParameter                     = mTcgNvs->PhysicalPresence.RequestParameter;\r
     mTcgNvs->PhysicalPresence.ReturnCode = Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx (\r
                                              &OperationRequest,\r
                                              &RequestParameter\r
                                              );\r
-    mTcgNvs->PhysicalPresence.Request = OperationRequest;\r
+    mTcgNvs->PhysicalPresence.Request          = OperationRequest;\r
     mTcgNvs->PhysicalPresence.RequestParameter = RequestParameter;\r
   } else if (mTcgNvs->PhysicalPresence.Parameter == TCG_ACPI_FUNCTION_GET_USER_CONFIRMATION_STATUS_FOR_REQUEST) {\r
     mTcgNvs->PhysicalPresence.ReturnCode = Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (mTcgNvs->PPRequestUserConfirm);\r
@@ -158,7 +158,6 @@ PhysicalPresenceCallback (
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Software SMI callback for MemoryClear which is called from ACPI method.\r
 \r
@@ -179,28 +178,28 @@ PhysicalPresenceCallback (
 EFI_STATUS\r
 EFIAPI\r
 MemoryClearCallback (\r
-  IN EFI_HANDLE                  DispatchHandle,\r
-  IN CONST VOID                  *Context,\r
-  IN OUT VOID                    *CommBuffer,\r
-  IN OUT UINTN                   *CommBufferSize\r
+  IN EFI_HANDLE  DispatchHandle,\r
+  IN CONST VOID  *Context,\r
+  IN OUT VOID    *CommBuffer,\r
+  IN OUT UINTN   *CommBufferSize\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  UINTN                          DataSize;\r
-  UINT8                          MorControl;\r
+  EFI_STATUS  Status;\r
+  UINTN       DataSize;\r
+  UINT8       MorControl;\r
 \r
   mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_SUCCESS;\r
   if (mTcgNvs->MemoryClear.Parameter == ACPI_FUNCTION_DSM_MEMORY_CLEAR_INTERFACE) {\r
-    MorControl = (UINT8) mTcgNvs->MemoryClear.Request;\r
+    MorControl = (UINT8)mTcgNvs->MemoryClear.Request;\r
   } else if (mTcgNvs->MemoryClear.Parameter == ACPI_FUNCTION_PTS_CLEAR_MOR_BIT) {\r
     DataSize = sizeof (UINT8);\r
-    Status = mSmmVariable->SmmGetVariable (\r
-                             MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-                             &gEfiMemoryOverwriteControlDataGuid,\r
-                             NULL,\r
-                             &DataSize,\r
-                             &MorControl\r
-                             );\r
+    Status   = mSmmVariable->SmmGetVariable (\r
+                               MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                               &gEfiMemoryOverwriteControlDataGuid,\r
+                               NULL,\r
+                               &DataSize,\r
+                               &MorControl\r
+                               );\r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
       DEBUG ((DEBUG_ERROR, "[TPM] Get MOR variable failure! Status = %r\n", Status));\r
@@ -210,6 +209,7 @@ MemoryClearCallback (
     if (MOR_CLEAR_MEMORY_VALUE (MorControl) == 0x0) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     MorControl &= ~MOR_CLEAR_MEMORY_BIT_MASK;\r
   } else {\r
     mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
@@ -218,13 +218,13 @@ MemoryClearCallback (
   }\r
 \r
   DataSize = sizeof (UINT8);\r
-  Status = mSmmVariable->SmmSetVariable (\r
-                           MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-                           &gEfiMemoryOverwriteControlDataGuid,\r
-                           EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                           DataSize,\r
-                           &MorControl\r
-                           );\r
+  Status   = mSmmVariable->SmmSetVariable (\r
+                             MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                             &gEfiMemoryOverwriteControlDataGuid,\r
+                             EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                             DataSize,\r
+                             &MorControl\r
+                             );\r
   if (EFI_ERROR (Status)) {\r
     mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
     DEBUG ((DEBUG_ERROR, "[TPM] Set MOR variable failure! Status = %r\n", Status));\r
@@ -249,16 +249,17 @@ TcgMmReadyToLock (
   IN CONST EFI_GUID  *Protocol,\r
   IN VOID            *Interface,\r
   IN EFI_HANDLE      Handle\r
-)\r
+  )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = EFI_SUCCESS;\r
 \r
   if (mReadyToLockHandle != NULL) {\r
-    Status = gMmst->MmiHandlerUnRegister (mReadyToLockHandle);\r
+    Status             = gMmst->MmiHandlerUnRegister (mReadyToLockHandle);\r
     mReadyToLockHandle = NULL;\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -284,17 +285,17 @@ InitializeTcgCommon (
   EFI_HANDLE                     McSwHandle;\r
   EFI_HANDLE                     NotifyHandle;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm20DtpmGuid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm20DtpmGuid)) {\r
     DEBUG ((DEBUG_ERROR, "No TPM2 DTPM instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
   // Initialize variables first\r
   mReadyToLockHandle = NULL;\r
-  SwDispatch = NULL;\r
-  PpSwHandle = NULL;\r
-  McSwHandle = NULL;\r
-  NotifyHandle = NULL;\r
+  SwDispatch         = NULL;\r
+  PpSwHandle         = NULL;\r
+  McSwHandle         = NULL;\r
+  NotifyHandle       = NULL;\r
 \r
   // Register a root handler to communicate the NVS region and SMI channel between MM and DXE\r
   Status = gMmst->MmiHandlerRegister (TpmNvsCommunciate, &gTpmNvsMmGuid, &mReadyToLockHandle);\r
@@ -307,35 +308,37 @@ InitializeTcgCommon (
   //\r
   // Get the Sw dispatch protocol and register SMI callback functions.\r
   //\r
-  Status = gMmst->MmLocateProtocol (&gEfiSmmSwDispatch2ProtocolGuid, NULL, (VOID**)&SwDispatch);\r
+  Status = gMmst->MmLocateProtocol (&gEfiSmmSwDispatch2ProtocolGuid, NULL, (VOID **)&SwDispatch);\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "[%a] Failed to locate Sw dispatch protocol - %r!\n", __FUNCTION__, Status));\r
     goto Cleanup;\r
   }\r
 \r
-  SwContext.SwSmiInputValue = (UINTN) -1;\r
-  Status = SwDispatch->Register (SwDispatch, PhysicalPresenceCallback, &SwContext, &PpSwHandle);\r
+  SwContext.SwSmiInputValue = (UINTN)-1;\r
+  Status                    = SwDispatch->Register (SwDispatch, PhysicalPresenceCallback, &SwContext, &PpSwHandle);\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "[%a] Failed to register PP callback as SW MM handler - %r!\n", __FUNCTION__, Status));\r
     goto Cleanup;\r
   }\r
+\r
   mPpSoftwareSmi = SwContext.SwSmiInputValue;\r
 \r
-  SwContext.SwSmiInputValue = (UINTN) -1;\r
-  Status = SwDispatch->Register (SwDispatch, MemoryClearCallback, &SwContext, &McSwHandle);\r
+  SwContext.SwSmiInputValue = (UINTN)-1;\r
+  Status                    = SwDispatch->Register (SwDispatch, MemoryClearCallback, &SwContext, &McSwHandle);\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "[%a] Failed to register MC callback as SW MM handler - %r!\n", __FUNCTION__, Status));\r
     goto Cleanup;\r
   }\r
+\r
   mMcSoftwareSmi = SwContext.SwSmiInputValue;\r
 \r
   //\r
   // Locate SmmVariableProtocol.\r
   //\r
-  Status = gMmst->MmLocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID**)&mSmmVariable);\r
+  Status = gMmst->MmLocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID **)&mSmmVariable);\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
     // Should not happen\r
@@ -359,12 +362,15 @@ Cleanup:
     if (NotifyHandle != NULL) {\r
       gMmst->MmRegisterProtocolNotify (&gEfiMmReadyToLockProtocolGuid, NULL, &NotifyHandle);\r
     }\r
-    if (McSwHandle != NULL && SwDispatch != NULL) {\r
+\r
+    if ((McSwHandle != NULL) && (SwDispatch != NULL)) {\r
       SwDispatch->UnRegister (SwDispatch, McSwHandle);\r
     }\r
-    if (PpSwHandle != NULL && SwDispatch != NULL) {\r
+\r
+    if ((PpSwHandle != NULL) && (SwDispatch != NULL)) {\r
       SwDispatch->UnRegister (SwDispatch, PpSwHandle);\r
     }\r
+\r
     if (mReadyToLockHandle != NULL) {\r
       gMmst->MmiHandlerUnRegister (mReadyToLockHandle);\r
     }\r
index d7f78aa432752c479ba0b69b85b49686b25c6985..84b65eb0897c3a2d444c1f8ccc69a296b771f1fb 100644 (file)
@@ -37,14 +37,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // The definition for TCG MOR\r
 //\r
-#define ACPI_FUNCTION_DSM_MEMORY_CLEAR_INTERFACE                   1\r
-#define ACPI_FUNCTION_PTS_CLEAR_MOR_BIT                            2\r
+#define ACPI_FUNCTION_DSM_MEMORY_CLEAR_INTERFACE  1\r
+#define ACPI_FUNCTION_PTS_CLEAR_MOR_BIT           2\r
 \r
 //\r
 // The return code for Memory Clear Interface Functions\r
 //\r
-#define MOR_REQUEST_SUCCESS                                        0\r
-#define MOR_REQUEST_GENERAL_FAILURE                                1\r
+#define MOR_REQUEST_SUCCESS          0\r
+#define MOR_REQUEST_GENERAL_FAILURE  1\r
 \r
 /**\r
   Notify the system that the SMM variable driver is ready.\r
@@ -84,4 +84,4 @@ InitializeTcgCommon (
   VOID\r
   );\r
 \r
-#endif  // __TCG_SMM_H__\r
+#endif // __TCG_SMM_H__\r
index 9e0095efbc5e21fd921f83cd165f6c0d48e34273..77fa3691f4939429bebb984096e5d734917ccd57 100644 (file)
@@ -63,8 +63,8 @@ IsBufferOutsideMmValid (
 EFI_STATUS\r
 EFIAPI\r
 InitializeTcgStandaloneMm (\r
-  IN EFI_HANDLE                  ImageHandle,\r
-  IN EFI_MM_SYSTEM_TABLE         *SystemTable\r
+  IN EFI_HANDLE           ImageHandle,\r
+  IN EFI_MM_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   return InitializeTcgCommon ();\r
index 5930090b4e46a045c67560e9a83e61cf94a5f89b..514171cfacf6c3cab7c455684d745750ba1c4d1c 100644 (file)
@@ -27,8 +27,8 @@ Tcg2NotifyMmReady (
   VOID\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  EFI_HANDLE            Handle;\r
+  EFI_STATUS  Status;\r
+  EFI_HANDLE  Handle;\r
 \r
   Handle = NULL;\r
   Status = gBS->InstallProtocolInterface (\r
@@ -74,8 +74,8 @@ IsBufferOutsideMmValid (
 EFI_STATUS\r
 EFIAPI\r
 InitializeTcgSmm (\r
-  IN EFI_HANDLE                  ImageHandle,\r
-  IN EFI_SYSTEM_TABLE            *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   return InitializeTcgCommon ();\r
index 4bc60864544d8c31c0f07bbc130ac625cbc8fdbc..b3b5540ede5b90356584f2013562b28b4dc4a127 100644 (file)
@@ -24,15 +24,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 TcgConfigDriverEntryPoint (\r
-  IN EFI_HANDLE          ImageHandle,\r
-  IN EFI_SYSTEM_TABLE    *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  TCG_CONFIG_PRIVATE_DATA   *PrivateData;\r
-  EFI_TCG_PROTOCOL          *TcgProtocol;\r
+  EFI_STATUS               Status;\r
+  TCG_CONFIG_PRIVATE_DATA  *PrivateData;\r
+  EFI_TCG_PROTOCOL         *TcgProtocol;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)) {\r
     DEBUG ((DEBUG_ERROR, "No TPM12 instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -43,7 +43,7 @@ TcgConfigDriverEntryPoint (
     return Status;\r
   }\r
 \r
-  Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **) &TcgProtocol);\r
+  Status = gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **)&TcgProtocol);\r
   if (EFI_ERROR (Status)) {\r
     TcgProtocol = NULL;\r
   }\r
@@ -123,13 +123,13 @@ TcgConfigDriverUnload (
   IN EFI_HANDLE  ImageHandle\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  TCG_CONFIG_PRIVATE_DATA   *PrivateData;\r
+  EFI_STATUS               Status;\r
+  TCG_CONFIG_PRIVATE_DATA  *PrivateData;\r
 \r
   Status = gBS->HandleProtocol (\r
                   ImageHandle,\r
                   &gEfiCallerIdGuid,\r
-                  (VOID **) &PrivateData\r
+                  (VOID **)&PrivateData\r
                   );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
index 09cb4b0ee949e644e10069c421444c46f253996f..52ea1ac3aeaf1ada0ed22664787078e9cee5c4d6 100644 (file)
@@ -8,9 +8,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "TcgConfigImpl.h"\r
 \r
-CHAR16                          mTcgStorageName[] = L"TCG_CONFIGURATION";\r
+CHAR16  mTcgStorageName[] = L"TCG_CONFIGURATION";\r
 \r
-TCG_CONFIG_PRIVATE_DATA         mTcgConfigPrivateDateTemplate = {\r
+TCG_CONFIG_PRIVATE_DATA  mTcgConfigPrivateDateTemplate = {\r
   TCG_CONFIG_PRIVATE_DATA_SIGNATURE,\r
   {\r
     TcgExtractConfig,\r
@@ -19,14 +19,14 @@ TCG_CONFIG_PRIVATE_DATA         mTcgConfigPrivateDateTemplate = {
   }\r
 };\r
 \r
-HII_VENDOR_DEVICE_PATH          mTcgHiiVendorDevicePath = {\r
+HII_VENDOR_DEVICE_PATH  mTcgHiiVendorDevicePath = {\r
   {\r
     {\r
       HARDWARE_DEVICE_PATH,\r
       HW_VENDOR_DP,\r
       {\r
-        (UINT8) (sizeof (VENDOR_DEVICE_PATH)),\r
-        (UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
+        (UINT8)(sizeof (VENDOR_DEVICE_PATH)),\r
+        (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
       }\r
     },\r
     TCG_CONFIG_FORM_SET_GUID\r
@@ -35,8 +35,8 @@ HII_VENDOR_DEVICE_PATH          mTcgHiiVendorDevicePath = {
     END_DEVICE_PATH_TYPE,\r
     END_ENTIRE_DEVICE_PATH_SUBTYPE,\r
     {\r
-      (UINT8) (END_DEVICE_PATH_LENGTH),\r
-      (UINT8) ((END_DEVICE_PATH_LENGTH) >> 8)\r
+      (UINT8)(END_DEVICE_PATH_LENGTH),\r
+      (UINT8)((END_DEVICE_PATH_LENGTH) >> 8)\r
     }\r
   }\r
 };\r
@@ -55,16 +55,16 @@ HII_VENDOR_DEVICE_PATH          mTcgHiiVendorDevicePath = {
 **/\r
 EFI_STATUS\r
 GetTpmState (\r
-  IN  EFI_TCG_PROTOCOL          *TcgProtocol,\r
-  OUT BOOLEAN                   *TpmEnable   OPTIONAL,\r
-  OUT BOOLEAN                   *TpmActivate OPTIONAL\r
+  IN  EFI_TCG_PROTOCOL  *TcgProtocol,\r
+  OUT BOOLEAN           *TpmEnable   OPTIONAL,\r
+  OUT BOOLEAN           *TpmActivate OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS                    Status;\r
-  TPM_RSP_COMMAND_HDR           *TpmRsp;\r
-  UINT32                        TpmSendSize;\r
-  TPM_PERMANENT_FLAGS           *TpmPermanentFlags;\r
-  UINT8                         CmdBuf[64];\r
+  EFI_STATUS           Status;\r
+  TPM_RSP_COMMAND_HDR  *TpmRsp;\r
+  UINT32               TpmSendSize;\r
+  TPM_PERMANENT_FLAGS  *TpmPermanentFlags;\r
+  UINT8                CmdBuf[64];\r
 \r
   ASSERT (TcgProtocol != NULL);\r
 \r
@@ -73,13 +73,13 @@ GetTpmState (
   //\r
   if ((TpmEnable != NULL) || (TpmActivate != NULL)) {\r
     TpmSendSize           = sizeof (TPM_RQU_COMMAND_HDR) + sizeof (UINT32) * 3;\r
-    *(UINT16*)&CmdBuf[0]  = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
-    *(UINT32*)&CmdBuf[2]  = SwapBytes32 (TpmSendSize);\r
-    *(UINT32*)&CmdBuf[6]  = SwapBytes32 (TPM_ORD_GetCapability);\r
+    *(UINT16 *)&CmdBuf[0] = SwapBytes16 (TPM_TAG_RQU_COMMAND);\r
+    *(UINT32 *)&CmdBuf[2] = SwapBytes32 (TpmSendSize);\r
+    *(UINT32 *)&CmdBuf[6] = SwapBytes32 (TPM_ORD_GetCapability);\r
 \r
-    *(UINT32*)&CmdBuf[10] = SwapBytes32 (TPM_CAP_FLAG);\r
-    *(UINT32*)&CmdBuf[14] = SwapBytes32 (sizeof (TPM_CAP_FLAG_PERMANENT));\r
-    *(UINT32*)&CmdBuf[18] = SwapBytes32 (TPM_CAP_FLAG_PERMANENT);\r
+    *(UINT32 *)&CmdBuf[10] = SwapBytes32 (TPM_CAP_FLAG);\r
+    *(UINT32 *)&CmdBuf[14] = SwapBytes32 (sizeof (TPM_CAP_FLAG_PERMANENT));\r
+    *(UINT32 *)&CmdBuf[18] = SwapBytes32 (TPM_CAP_FLAG_PERMANENT);\r
 \r
     Status = TcgProtocol->PassThroughToTpm (\r
                             TcgProtocol,\r
@@ -88,12 +88,12 @@ GetTpmState (
                             sizeof (CmdBuf),\r
                             CmdBuf\r
                             );\r
-    TpmRsp = (TPM_RSP_COMMAND_HDR *) &CmdBuf[0];\r
+    TpmRsp = (TPM_RSP_COMMAND_HDR *)&CmdBuf[0];\r
     if (EFI_ERROR (Status) || (TpmRsp->tag != SwapBytes16 (TPM_TAG_RSP_COMMAND)) || (TpmRsp->returnCode != 0)) {\r
       return EFI_DEVICE_ERROR;\r
     }\r
 \r
-    TpmPermanentFlags = (TPM_PERMANENT_FLAGS *) &CmdBuf[sizeof (TPM_RSP_COMMAND_HDR) + sizeof (UINT32)];\r
+    TpmPermanentFlags = (TPM_PERMANENT_FLAGS *)&CmdBuf[sizeof (TPM_RSP_COMMAND_HDR) + sizeof (UINT32)];\r
 \r
     if (TpmEnable != NULL) {\r
       *TpmEnable = (BOOLEAN) !TpmPermanentFlags->disable;\r
@@ -136,22 +136,22 @@ GetTpmState (
 EFI_STATUS\r
 EFIAPI\r
 TcgExtractConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL        *This,\r
-  IN CONST EFI_STRING                            Request,\r
-       OUT EFI_STRING                            *Progress,\r
-       OUT EFI_STRING                            *Results\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Request,\r
+  OUT EFI_STRING                           *Progress,\r
+  OUT EFI_STRING                           *Results\r
   )\r
 {\r
-  EFI_STATUS                 Status;\r
-  TCG_CONFIG_PRIVATE_DATA    *PrivateData;\r
-  EFI_STRING                 ConfigRequestHdr;\r
-  EFI_STRING                 ConfigRequest;\r
-  BOOLEAN                    AllocatedRequest;\r
-  UINTN                      Size;\r
-  BOOLEAN                    TpmEnable;\r
-  BOOLEAN                    TpmActivate;\r
-\r
-  if (Progress == NULL || Results == NULL) {\r
+  EFI_STATUS               Status;\r
+  TCG_CONFIG_PRIVATE_DATA  *PrivateData;\r
+  EFI_STRING               ConfigRequestHdr;\r
+  EFI_STRING               ConfigRequest;\r
+  BOOLEAN                  AllocatedRequest;\r
+  UINTN                    Size;\r
+  BOOLEAN                  TpmEnable;\r
+  BOOLEAN                  TpmActivate;\r
+\r
+  if ((Progress == NULL) || (Results == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -193,8 +193,8 @@ TcgExtractConfig (
     // followed by "&OFFSET=0&WIDTH=WWWWWWWWWWWWWWWW" followed by a Null-terminator\r
     //\r
     ConfigRequestHdr = HiiConstructConfigHdr (&gTcgConfigFormSetGuid, mTcgStorageName, PrivateData->DriverHandle);\r
-    Size = (StrLen (ConfigRequestHdr) + 32 + 1) * sizeof (CHAR16);\r
-    ConfigRequest = AllocateZeroPool (Size);\r
+    Size             = (StrLen (ConfigRequestHdr) + 32 + 1) * sizeof (CHAR16);\r
+    ConfigRequest    = AllocateZeroPool (Size);\r
     ASSERT (ConfigRequest != NULL);\r
     AllocatedRequest = TRUE;\r
     UnicodeSPrint (ConfigRequest, Size, L"%s&OFFSET=0&WIDTH=%016LX", ConfigRequestHdr, sizeof (TCG_CONFIGURATION));\r
@@ -204,7 +204,7 @@ TcgExtractConfig (
   Status = gHiiConfigRouting->BlockToConfig (\r
                                 gHiiConfigRouting,\r
                                 ConfigRequest,\r
-                                (UINT8 *) PrivateData->Configuration,\r
+                                (UINT8 *)PrivateData->Configuration,\r
                                 sizeof (TCG_CONFIGURATION),\r
                                 Results,\r
                                 Progress\r
@@ -215,6 +215,7 @@ TcgExtractConfig (
   if (AllocatedRequest) {\r
     FreePool (ConfigRequest);\r
   }\r
+\r
   //\r
   // Set Progress string to the original request string.\r
   //\r
@@ -248,16 +249,16 @@ TcgExtractConfig (
 EFI_STATUS\r
 EFIAPI\r
 TcgRouteConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN CONST EFI_STRING                          Configuration,\r
-       OUT EFI_STRING                          *Progress\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Configuration,\r
+  OUT EFI_STRING                           *Progress\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
-  UINTN                            BufferSize;\r
-  TCG_CONFIGURATION                TcgConfiguration;\r
+  EFI_STATUS         Status;\r
+  UINTN              BufferSize;\r
+  TCG_CONFIGURATION  TcgConfiguration;\r
 \r
-  if (Configuration == NULL || Progress == NULL) {\r
+  if ((Configuration == NULL) || (Progress == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -270,13 +271,13 @@ TcgRouteConfig (
   // Convert <ConfigResp> to buffer data by helper function ConfigToBlock()\r
   //\r
   BufferSize = sizeof (TCG_CONFIGURATION);\r
-  Status = gHiiConfigRouting->ConfigToBlock (\r
-                                gHiiConfigRouting,\r
-                                Configuration,\r
-                                (UINT8 *) &TcgConfiguration,\r
-                                &BufferSize,\r
-                                Progress\r
-                                );\r
+  Status     = gHiiConfigRouting->ConfigToBlock (\r
+                                    gHiiConfigRouting,\r
+                                    Configuration,\r
+                                    (UINT8 *)&TcgConfiguration,\r
+                                    &BufferSize,\r
+                                    Progress\r
+                                    );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -295,37 +296,37 @@ TcgRouteConfig (
 **/\r
 EFI_STATUS\r
 SavePpRequest (\r
-  IN UINT8                         PpRequest\r
+  IN UINT8  PpRequest\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
-  UINTN                            DataSize;\r
-  EFI_PHYSICAL_PRESENCE            PpData;\r
+  EFI_STATUS             Status;\r
+  UINTN                  DataSize;\r
+  EFI_PHYSICAL_PRESENCE  PpData;\r
 \r
   //\r
   // Save TPM command to variable.\r
   //\r
   DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-  Status = gRT->GetVariable (\r
-                  PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiPhysicalPresenceGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  &PpData\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    PHYSICAL_PRESENCE_VARIABLE,\r
+                    &gEfiPhysicalPresenceGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    &PpData\r
+                    );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
   PpData.PPRequest = PpRequest;\r
-  Status = gRT->SetVariable (\r
-                  PHYSICAL_PRESENCE_VARIABLE,\r
-                  &gEfiPhysicalPresenceGuid,\r
-                  EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                  DataSize,\r
-                  &PpData\r
-                  );\r
-  if (EFI_ERROR(Status)) {\r
+  Status           = gRT->SetVariable (\r
+                            PHYSICAL_PRESENCE_VARIABLE,\r
+                            &gEfiPhysicalPresenceGuid,\r
+                            EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                            DataSize,\r
+                            &PpData\r
+                            );\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
@@ -357,16 +358,16 @@ SavePpRequest (
 EFI_STATUS\r
 EFIAPI\r
 TcgCallback (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN     EFI_BROWSER_ACTION                    Action,\r
-  IN     EFI_QUESTION_ID                       QuestionId,\r
-  IN     UINT8                                 Type,\r
-  IN     EFI_IFR_TYPE_VALUE                    *Value,\r
-     OUT EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN     EFI_BROWSER_ACTION                Action,\r
+  IN     EFI_QUESTION_ID                   QuestionId,\r
+  IN     UINT8                             Type,\r
+  IN     EFI_IFR_TYPE_VALUE                *Value,\r
+  OUT EFI_BROWSER_ACTION_REQUEST           *ActionRequest\r
   )\r
 {\r
-  TCG_CONFIG_PRIVATE_DATA    *PrivateData;\r
-  CHAR16                     State[32];\r
+  TCG_CONFIG_PRIVATE_DATA  *PrivateData;\r
+  CHAR16                   State[32];\r
 \r
   if ((This == NULL) || (Value == NULL) || (ActionRequest == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -374,7 +375,6 @@ TcgCallback (
 \r
   if (Action == EFI_BROWSER_ACTION_FORM_OPEN) {\r
     if (QuestionId == KEY_TPM_ACTION) {\r
-\r
       PrivateData = TCG_CONFIG_PRIVATE_DATA_FROM_THIS (This);\r
       UnicodeSPrint (\r
         State,\r
@@ -385,6 +385,7 @@ TcgCallback (
         );\r
       HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_TPM_STATE_CONTENT), State, NULL);\r
     }\r
+\r
     return EFI_SUCCESS;\r
   }\r
 \r
@@ -420,14 +421,14 @@ InstallTcgConfigForm (
 \r
   DriverHandle = NULL;\r
   ConfigAccess = &PrivateData->ConfigAccess;\r
-  Status = gBS->InstallMultipleProtocolInterfaces (\r
-                  &DriverHandle,\r
-                  &gEfiDevicePathProtocolGuid,\r
-                  &mTcgHiiVendorDevicePath,\r
-                  &gEfiHiiConfigAccessProtocolGuid,\r
-                  ConfigAccess,\r
-                  NULL\r
-                  );\r
+  Status       = gBS->InstallMultipleProtocolInterfaces (\r
+                        &DriverHandle,\r
+                        &gEfiDevicePathProtocolGuid,\r
+                        &mTcgHiiVendorDevicePath,\r
+                        &gEfiHiiConfigAccessProtocolGuid,\r
+                        ConfigAccess,\r
+                        NULL\r
+                        );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -470,7 +471,7 @@ InstallTcgConfigForm (
 **/\r
 VOID\r
 UninstallTcgConfigForm (\r
-  IN OUT TCG_CONFIG_PRIVATE_DATA    *PrivateData\r
+  IN OUT TCG_CONFIG_PRIVATE_DATA  *PrivateData\r
   )\r
 {\r
   //\r
@@ -497,7 +498,8 @@ UninstallTcgConfigForm (
   }\r
 \r
   if (PrivateData->Configuration != NULL) {\r
-    FreePool(PrivateData->Configuration);\r
+    FreePool (PrivateData->Configuration);\r
   }\r
+\r
   FreePool (PrivateData);\r
 }\r
index 14842e7976d156ffb012cc5aad4cf8e35c15ad33..0373a7ff678edf299c98a0f913999acb907fca53 100644 (file)
@@ -37,15 +37,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Tool generated IFR binary data and String package data\r
 //\r
-extern UINT8                        TcgConfigBin[];\r
-extern UINT8                        TcgConfigDxeStrings[];\r
+extern UINT8  TcgConfigBin[];\r
+extern UINT8  TcgConfigDxeStrings[];\r
 \r
 ///\r
 /// HII specific Vendor Device Path definition.\r
 ///\r
 typedef struct {\r
-  VENDOR_DEVICE_PATH                VendorDevicePath;\r
-  EFI_DEVICE_PATH_PROTOCOL          End;\r
+  VENDOR_DEVICE_PATH          VendorDevicePath;\r
+  EFI_DEVICE_PATH_PROTOCOL    End;\r
 } HII_VENDOR_DEVICE_PATH;\r
 \r
 typedef struct {\r
@@ -59,12 +59,11 @@ typedef struct {
   EFI_TCG_PROTOCOL                  *TcgProtocol;\r
 } TCG_CONFIG_PRIVATE_DATA;\r
 \r
-extern TCG_CONFIG_PRIVATE_DATA      mTcgConfigPrivateDateTemplate;\r
+extern TCG_CONFIG_PRIVATE_DATA  mTcgConfigPrivateDateTemplate;\r
 \r
-#define TCG_CONFIG_PRIVATE_DATA_SIGNATURE     SIGNATURE_32 ('T', 'C', 'G', 'D')\r
+#define TCG_CONFIG_PRIVATE_DATA_SIGNATURE  SIGNATURE_32 ('T', 'C', 'G', 'D')\r
 #define TCG_CONFIG_PRIVATE_DATA_FROM_THIS(a)  CR (a, TCG_CONFIG_PRIVATE_DATA, ConfigAccess, TCG_CONFIG_PRIVATE_DATA_SIGNATURE)\r
 \r
-\r
 /**\r
   This function publish the TCG configuration Form for TPM device.\r
 \r
@@ -88,7 +87,7 @@ InstallTcgConfigForm (
 **/\r
 VOID\r
 UninstallTcgConfigForm (\r
-  IN OUT TCG_CONFIG_PRIVATE_DATA    *PrivateData\r
+  IN OUT TCG_CONFIG_PRIVATE_DATA  *PrivateData\r
   );\r
 \r
 /**\r
@@ -120,10 +119,10 @@ UninstallTcgConfigForm (
 EFI_STATUS\r
 EFIAPI\r
 TcgExtractConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL        *This,\r
-  IN CONST EFI_STRING                            Request,\r
-       OUT EFI_STRING                            *Progress,\r
-       OUT EFI_STRING                            *Results\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Request,\r
+  OUT EFI_STRING                           *Progress,\r
+  OUT EFI_STRING                           *Results\r
   );\r
 \r
 /**\r
@@ -147,9 +146,9 @@ TcgExtractConfig (
 EFI_STATUS\r
 EFIAPI\r
 TcgRouteConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN CONST EFI_STRING                          Configuration,\r
-       OUT EFI_STRING                          *Progress\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Configuration,\r
+  OUT EFI_STRING                           *Progress\r
   );\r
 \r
 /**\r
@@ -177,12 +176,12 @@ TcgRouteConfig (
 EFI_STATUS\r
 EFIAPI\r
 TcgCallback (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN     EFI_BROWSER_ACTION                    Action,\r
-  IN     EFI_QUESTION_ID                       QuestionId,\r
-  IN     UINT8                                 Type,\r
-  IN     EFI_IFR_TYPE_VALUE                    *Value,\r
-     OUT EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN     EFI_BROWSER_ACTION                Action,\r
+  IN     EFI_QUESTION_ID                   QuestionId,\r
+  IN     UINT8                             Type,\r
+  IN     EFI_IFR_TYPE_VALUE                *Value,\r
+  OUT EFI_BROWSER_ACTION_REQUEST           *ActionRequest\r
   );\r
 \r
 #endif\r
index 43f740c585a955b1233b176e06c280715efe4337..d0fafc48efb93b4a74d25f177b8429808da92ef1 100644 (file)
@@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define TCG_CONFIGURATION_VARSTORE_ID  0x0001\r
 #define TCG_CONFIGURATION_FORM_ID      0x0001\r
 \r
-#define KEY_TPM_ACTION                         0x3000\r
+#define KEY_TPM_ACTION  0x3000\r
 \r
 #define LABEL_TCG_CONFIGURATION_TPM_OPERATION  0x0001\r
 #define LABEL_END                              0xffff\r
@@ -25,9 +25,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Nv Data structure referenced by IFR\r
 //\r
 typedef struct {\r
-  UINT8   TpmOperation;\r
-  BOOLEAN TpmEnable;\r
-  BOOLEAN TpmActivate;\r
+  UINT8      TpmOperation;\r
+  BOOLEAN    TpmEnable;\r
+  BOOLEAN    TpmActivate;\r
 } TCG_CONFIGURATION;\r
 \r
 #endif\r
index 7019c666b1b0b5dd55449d3c0430ad97a707329a..ee6c6273033bde5120d02641ca8da2da382c58b6 100644 (file)
@@ -52,29 +52,27 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
   BASE_CR (this, TCG_DXE_DATA, TcgProtocol)\r
 \r
 typedef struct _TCG_DXE_DATA {\r
-  EFI_TCG_PROTOCOL                  TcgProtocol;\r
-  TCG_EFI_BOOT_SERVICE_CAPABILITY   BsCap;\r
-  EFI_TCG_CLIENT_ACPI_TABLE         *TcgClientAcpiTable;\r
-  EFI_TCG_SERVER_ACPI_TABLE         *TcgServerAcpiTable;\r
-  UINTN                             EventLogSize;\r
-  UINT8                             *LastEvent;\r
+  EFI_TCG_PROTOCOL                   TcgProtocol;\r
+  TCG_EFI_BOOT_SERVICE_CAPABILITY    BsCap;\r
+  EFI_TCG_CLIENT_ACPI_TABLE          *TcgClientAcpiTable;\r
+  EFI_TCG_SERVER_ACPI_TABLE          *TcgServerAcpiTable;\r
+  UINTN                              EventLogSize;\r
+  UINT8                              *LastEvent;\r
 } TCG_DXE_DATA;\r
 \r
-\r
-\r
-EFI_TCG_CLIENT_ACPI_TABLE           mTcgClientAcpiTemplate = {\r
+EFI_TCG_CLIENT_ACPI_TABLE  mTcgClientAcpiTemplate = {\r
   {\r
     EFI_ACPI_3_0_TRUSTED_COMPUTING_PLATFORM_ALLIANCE_CAPABILITIES_TABLE_SIGNATURE,\r
     sizeof (mTcgClientAcpiTemplate),\r
-    0x02                      //Revision\r
+    0x02                      // Revision\r
     //\r
     // Compiler initializes the remaining bytes to 0\r
     // These fields should be filled in in production\r
     //\r
   },\r
-  0,                          // 0 for PC Client Platform Class\r
-  0,                          // Log Area Max Length\r
-  (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1)  // Log Area Start Address\r
+  0,                                   // 0 for PC Client Platform Class\r
+  0,                                   // Log Area Max Length\r
+  (EFI_PHYSICAL_ADDRESS)(SIZE_4GB - 1) // Log Area Start Address\r
 };\r
 \r
 //\r
@@ -83,26 +81,26 @@ EFI_TCG_CLIENT_ACPI_TABLE           mTcgClientAcpiTemplate = {
 // this _UID can be changed and should match with the _UID setting of the TPM\r
 // ACPI device object\r
 //\r
-EFI_TCG_SERVER_ACPI_TABLE           mTcgServerAcpiTemplate = {\r
+EFI_TCG_SERVER_ACPI_TABLE  mTcgServerAcpiTemplate = {\r
   {\r
     EFI_ACPI_3_0_TRUSTED_COMPUTING_PLATFORM_ALLIANCE_CAPABILITIES_TABLE_SIGNATURE,\r
     sizeof (mTcgServerAcpiTemplate),\r
-    0x02                      //Revision\r
+    0x02                      // Revision\r
     //\r
     // Compiler initializes the remaining bytes to 0\r
     // These fields should be filled in in production\r
     //\r
   },\r
-  1,                          // 1 for Server Platform Class\r
-  0,                          // Reserved\r
-  0,                          // Log Area Max Length\r
-  (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1), // Log Area Start Address\r
-  0x0120,                     // TCG Specification revision 1.2\r
-  0,                          // Device Flags\r
-  0,                          // Interrupt Flags\r
-  0,                          // GPE\r
-  {0},                        // Reserved 3 bytes\r
-  0,                          // Global System Interrupt\r
+  1,                                    // 1 for Server Platform Class\r
+  0,                                    // Reserved\r
+  0,                                    // Log Area Max Length\r
+  (EFI_PHYSICAL_ADDRESS)(SIZE_4GB - 1), // Log Area Start Address\r
+  0x0120,                               // TCG Specification revision 1.2\r
+  0,                                    // Device Flags\r
+  0,                                    // Interrupt Flags\r
+  0,                                    // GPE\r
+  { 0 },                                // Reserved 3 bytes\r
+  0,                                    // Global System Interrupt\r
   {\r
     EFI_ACPI_3_0_SYSTEM_MEMORY,\r
     0,\r
@@ -111,15 +109,15 @@ EFI_TCG_SERVER_ACPI_TABLE           mTcgServerAcpiTemplate = {
     0                         // Base Address\r
   },\r
   0,                          // Reserved\r
-  {0},                        // Configuration Address\r
+  { 0 },                      // Configuration Address\r
   0xFF,                       // ACPI _UID value of the device, can be changed for different platforms\r
   0,                          // ACPI _UID value of the device, can be changed for different platforms\r
   0,                          // ACPI _UID value of the device, can be changed for different platforms\r
   0                           // ACPI _UID value of the device, can be changed for different platforms\r
 };\r
 \r
-UINTN  mBootAttempts  = 0;\r
-CHAR16 mBootVarName[] = L"BootOrder";\r
+UINTN   mBootAttempts  = 0;\r
+CHAR16  mBootVarName[] = L"BootOrder";\r
 \r
 /**\r
   Get All processors EFI_CPU_LOCATION in system. LocationBuf is allocated inside the function\r
@@ -134,19 +132,19 @@ CHAR16 mBootVarName[] = L"BootOrder";
 **/\r
 EFI_STATUS\r
 GetProcessorsCpuLocation (\r
-    OUT  EFI_CPU_PHYSICAL_LOCATION   **LocationBuf,\r
-    OUT  UINTN                       *Num\r
+  OUT  EFI_CPU_PHYSICAL_LOCATION  **LocationBuf,\r
+  OUT  UINTN                      *Num\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_MP_SERVICES_PROTOCOL          *MpProtocol;\r
-  UINTN                             ProcessorNum;\r
-  UINTN                             EnabledProcessorNum;\r
-  EFI_PROCESSOR_INFORMATION         ProcessorInfo;\r
-  EFI_CPU_PHYSICAL_LOCATION         *ProcessorLocBuf;\r
-  UINTN                             Index;\r
-\r
-  Status = gBS->LocateProtocol (&gEfiMpServiceProtocolGuid, NULL, (VOID **) &MpProtocol);\r
+  EFI_STATUS                 Status;\r
+  EFI_MP_SERVICES_PROTOCOL   *MpProtocol;\r
+  UINTN                      ProcessorNum;\r
+  UINTN                      EnabledProcessorNum;\r
+  EFI_PROCESSOR_INFORMATION  ProcessorInfo;\r
+  EFI_CPU_PHYSICAL_LOCATION  *ProcessorLocBuf;\r
+  UINTN                      Index;\r
+\r
+  Status = gBS->LocateProtocol (&gEfiMpServiceProtocolGuid, NULL, (VOID **)&MpProtocol);\r
   if (EFI_ERROR (Status)) {\r
     //\r
     // MP protocol is not installed\r
@@ -154,21 +152,21 @@ GetProcessorsCpuLocation (
     return EFI_UNSUPPORTED;\r
   }\r
 \r
-  Status = MpProtocol->GetNumberOfProcessors(\r
+  Status = MpProtocol->GetNumberOfProcessors (\r
                          MpProtocol,\r
                          &ProcessorNum,\r
                          &EnabledProcessorNum\r
                          );\r
-  if (EFI_ERROR(Status)){\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
-  Status = gBS->AllocatePool(\r
+  Status = gBS->AllocatePool (\r
                   EfiBootServicesData,\r
-                  sizeof(EFI_CPU_PHYSICAL_LOCATION) * ProcessorNum,\r
-                  (VOID **) &ProcessorLocBuf\r
+                  sizeof (EFI_CPU_PHYSICAL_LOCATION) * ProcessorNum,\r
+                  (VOID **)&ProcessorLocBuf\r
                   );\r
-  if (EFI_ERROR(Status)){\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
@@ -176,28 +174,28 @@ GetProcessorsCpuLocation (
   // Get each processor Location info\r
   //\r
   for (Index = 0; Index < ProcessorNum; Index++) {\r
-    Status = MpProtocol->GetProcessorInfo(\r
+    Status = MpProtocol->GetProcessorInfo (\r
                            MpProtocol,\r
                            Index,\r
                            &ProcessorInfo\r
                            );\r
-    if (EFI_ERROR(Status)){\r
-      FreePool(ProcessorLocBuf);\r
+    if (EFI_ERROR (Status)) {\r
+      FreePool (ProcessorLocBuf);\r
       return Status;\r
     }\r
 \r
     //\r
     // Get all Processor Location info & measure\r
     //\r
-    CopyMem(\r
+    CopyMem (\r
       &ProcessorLocBuf[Index],\r
       &ProcessorInfo.Location,\r
-      sizeof(EFI_CPU_PHYSICAL_LOCATION)\r
+      sizeof (EFI_CPU_PHYSICAL_LOCATION)\r
       );\r
   }\r
 \r
   *LocationBuf = ProcessorLocBuf;\r
-  *Num = ProcessorNum;\r
+  *Num         = ProcessorNum;\r
 \r
   return Status;\r
 }\r
@@ -234,7 +232,7 @@ TcgDxeStatusCheck (
   OUT     EFI_PHYSICAL_ADDRESS             *EventLogLastEntry\r
   )\r
 {\r
-  TCG_DXE_DATA                      *TcgData;\r
+  TCG_DXE_DATA  *TcgData;\r
 \r
   TcgData = TCG_DXE_DATA_FROM_THIS (This);\r
 \r
@@ -320,15 +318,15 @@ TpmCommHashAll (
 EFI_STATUS\r
 EFIAPI\r
 TcgDxeHashAll (\r
-  IN      EFI_TCG_PROTOCOL          *This,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINT64                    HashDataLen,\r
-  IN      TCG_ALGORITHM_ID          AlgorithmId,\r
-  IN OUT  UINT64                    *HashedDataLen,\r
-  IN OUT  UINT8                     **HashedDataResult\r
+  IN      EFI_TCG_PROTOCOL  *This,\r
+  IN      UINT8             *HashData,\r
+  IN      UINT64            HashDataLen,\r
+  IN      TCG_ALGORITHM_ID  AlgorithmId,\r
+  IN OUT  UINT64            *HashedDataLen,\r
+  IN OUT  UINT8             **HashedDataResult\r
   )\r
 {\r
-  if (HashedDataLen == NULL || HashedDataResult == NULL) {\r
+  if ((HashedDataLen == NULL) || (HashedDataResult == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -336,7 +334,7 @@ TcgDxeHashAll (
     case TPM_ALG_SHA:\r
       if (*HashedDataLen == 0) {\r
         *HashedDataLen    = sizeof (TPM_DIGEST);\r
-        *HashedDataResult = AllocatePool ((UINTN) *HashedDataLen);\r
+        *HashedDataResult = AllocatePool ((UINTN)*HashedDataLen);\r
         if (*HashedDataResult == NULL) {\r
           return EFI_OUT_OF_RESOURCES;\r
         }\r
@@ -346,16 +344,17 @@ TcgDxeHashAll (
         *HashedDataLen = sizeof (TPM_DIGEST);\r
         return EFI_BUFFER_TOO_SMALL;\r
       }\r
+\r
       *HashedDataLen = sizeof (TPM_DIGEST);\r
 \r
       if (*HashedDataResult == NULL) {\r
-        *HashedDataResult = AllocatePool ((UINTN) *HashedDataLen);\r
+        *HashedDataResult = AllocatePool ((UINTN)*HashedDataLen);\r
       }\r
 \r
       return TpmCommHashAll (\r
                HashData,\r
-               (UINTN) HashDataLen,\r
-               (TPM_DIGEST*)*HashedDataResult\r
+               (UINTN)HashDataLen,\r
+               (TPM_DIGEST *)*HashedDataResult\r
                );\r
     default:\r
       return EFI_UNSUPPORTED;\r
@@ -377,19 +376,19 @@ Add a new entry to the Event Log.
 **/\r
 EFI_STATUS\r
 TpmCommLogEvent (\r
-  IN OUT  UINT8                     **EventLogPtr,\r
-  IN OUT  UINTN                     *LogSize,\r
-  IN      UINTN                     MaxSize,\r
-  IN      TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN OUT  UINT8              **EventLogPtr,\r
+  IN OUT  UINTN              *LogSize,\r
+  IN      UINTN              MaxSize,\r
+  IN      TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
-  UINTN                            NewLogSize;\r
+  UINTN  NewLogSize;\r
 \r
   //\r
   // Prevent Event Overflow\r
   //\r
-  if ((UINTN) NewEventHdr->EventSize > MAX_UINTN - sizeof (*NewEventHdr)) {\r
+  if ((UINTN)NewEventHdr->EventSize > MAX_UINTN - sizeof (*NewEventHdr)) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
@@ -399,7 +398,7 @@ TpmCommLogEvent (
   }\r
 \r
   *EventLogPtr += *LogSize;\r
-  *LogSize += NewLogSize;\r
+  *LogSize     += NewLogSize;\r
   CopyMem (*EventLogPtr, NewEventHdr, sizeof (*NewEventHdr));\r
   CopyMem (\r
     *EventLogPtr + sizeof (*NewEventHdr),\r
@@ -423,13 +422,13 @@ TpmCommLogEvent (
 EFI_STATUS\r
 EFIAPI\r
 TcgDxeLogEventI (\r
-  IN      TCG_DXE_DATA              *TcgData,\r
-  IN      TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      TCG_DXE_DATA       *TcgData,\r
+  IN      TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
   if (PcdGet8 (PcdTpmPlatformClass) == TCG_PLATFORM_TYPE_CLIENT) {\r
-    TcgData->LastEvent = (UINT8*)(UINTN)TcgData->TcgClientAcpiTable->Lasa;\r
+    TcgData->LastEvent = (UINT8 *)(UINTN)TcgData->TcgClientAcpiTable->Lasa;\r
     return TpmCommLogEvent (\r
              &TcgData->LastEvent,\r
              &TcgData->EventLogSize,\r
@@ -438,7 +437,7 @@ TcgDxeLogEventI (
              NewEventData\r
              );\r
   } else {\r
-    TcgData->LastEvent = (UINT8*)(UINTN)TcgData->TcgServerAcpiTable->Lasa;\r
+    TcgData->LastEvent = (UINT8 *)(UINTN)TcgData->TcgServerAcpiTable->Lasa;\r
     return TpmCommLogEvent (\r
              &TcgData->LastEvent,\r
              &TcgData->EventLogSize,\r
@@ -469,15 +468,15 @@ TcgDxeLogEventI (
 EFI_STATUS\r
 EFIAPI\r
 TcgDxeLogEvent (\r
-  IN      EFI_TCG_PROTOCOL          *This,\r
-  IN      TCG_PCR_EVENT             *TCGLogData,\r
-  IN OUT  UINT32                    *EventNumber,\r
-  IN      UINT32                    Flags\r
+  IN      EFI_TCG_PROTOCOL  *This,\r
+  IN      TCG_PCR_EVENT     *TCGLogData,\r
+  IN OUT  UINT32            *EventNumber,\r
+  IN      UINT32            Flags\r
   )\r
 {\r
   TCG_DXE_DATA  *TcgData;\r
 \r
-  if (TCGLogData == NULL){\r
+  if (TCGLogData == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -486,9 +485,10 @@ TcgDxeLogEvent (
   if (TcgData->BsCap.TPMDeactivatedFlag || (!TcgData->BsCap.TPMPresentFlag)) {\r
     return EFI_DEVICE_ERROR;\r
   }\r
+\r
   return TcgDxeLogEventI (\r
            TcgData,\r
-           (TCG_PCR_EVENT_HDR*)TCGLogData,\r
+           (TCG_PCR_EVENT_HDR *)TCGLogData,\r
            TCGLogData->Event\r
            );\r
 }\r
@@ -511,17 +511,18 @@ TcgDxeLogEvent (
 EFI_STATUS\r
 EFIAPI\r
 TcgDxePassThroughToTpm (\r
-  IN      EFI_TCG_PROTOCOL          *This,\r
-  IN      UINT32                    TpmInputParameterBlockSize,\r
-  IN      UINT8                     *TpmInputParameterBlock,\r
-  IN      UINT32                    TpmOutputParameterBlockSize,\r
-  IN      UINT8                     *TpmOutputParameterBlock\r
+  IN      EFI_TCG_PROTOCOL  *This,\r
+  IN      UINT32            TpmInputParameterBlockSize,\r
+  IN      UINT8             *TpmInputParameterBlock,\r
+  IN      UINT32            TpmOutputParameterBlockSize,\r
+  IN      UINT8             *TpmOutputParameterBlock\r
   )\r
 {\r
-  if (TpmInputParameterBlock == NULL ||\r
-      TpmOutputParameterBlock == NULL ||\r
-      TpmInputParameterBlockSize == 0 ||\r
-      TpmOutputParameterBlockSize == 0) {\r
+  if ((TpmInputParameterBlock == NULL) ||\r
+      (TpmOutputParameterBlock == NULL) ||\r
+      (TpmInputParameterBlockSize == 0) ||\r
+      (TpmOutputParameterBlockSize == 0))\r
+  {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -552,26 +553,26 @@ TcgDxePassThroughToTpm (
 EFI_STATUS\r
 EFIAPI\r
 TcgDxeHashLogExtendEventI (\r
-  IN      TCG_DXE_DATA              *TcgData,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINT64                    HashDataLen,\r
-  IN OUT  TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      TCG_DXE_DATA       *TcgData,\r
+  IN      UINT8              *HashData,\r
+  IN      UINT64             HashDataLen,\r
+  IN OUT  TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   if (!TcgData->BsCap.TPMPresentFlag) {\r
     return EFI_DEVICE_ERROR;\r
   }\r
 \r
-  if (HashDataLen > 0 || HashData != NULL) {\r
+  if ((HashDataLen > 0) || (HashData != NULL)) {\r
     Status = TpmCommHashAll (\r
                HashData,\r
-               (UINTN) HashDataLen,\r
+               (UINTN)HashDataLen,\r
                &NewEventHdr->Digest\r
                );\r
-    if (EFI_ERROR(Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       DEBUG ((DEBUG_ERROR, "TpmCommHashAll Failed. %x\n", Status));\r
       goto Done;\r
     }\r
@@ -627,19 +628,19 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 TcgDxeHashLogExtendEvent (\r
-  IN      EFI_TCG_PROTOCOL          *This,\r
-  IN      EFI_PHYSICAL_ADDRESS      HashData,\r
-  IN      UINT64                    HashDataLen,\r
-  IN      TPM_ALGORITHM_ID          AlgorithmId,\r
-  IN OUT  TCG_PCR_EVENT             *TCGLogData,\r
-  IN OUT  UINT32                    *EventNumber,\r
-     OUT  EFI_PHYSICAL_ADDRESS      *EventLogLastEntry\r
+  IN      EFI_TCG_PROTOCOL      *This,\r
+  IN      EFI_PHYSICAL_ADDRESS  HashData,\r
+  IN      UINT64                HashDataLen,\r
+  IN      TPM_ALGORITHM_ID      AlgorithmId,\r
+  IN OUT  TCG_PCR_EVENT         *TCGLogData,\r
+  IN OUT  UINT32                *EventNumber,\r
+  OUT  EFI_PHYSICAL_ADDRESS     *EventLogLastEntry\r
   )\r
 {\r
   TCG_DXE_DATA  *TcgData;\r
   EFI_STATUS    Status;\r
 \r
-  if (TCGLogData == NULL || EventLogLastEntry == NULL){\r
+  if ((TCGLogData == NULL) || (EventLogLastEntry == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -653,26 +654,26 @@ TcgDxeHashLogExtendEvent (
     return EFI_UNSUPPORTED;\r
   }\r
 \r
-  if (HashData == 0 && HashDataLen > 0) {\r
+  if ((HashData == 0) && (HashDataLen > 0)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
   Status = TcgDxeHashLogExtendEventI (\r
              TcgData,\r
-             (UINT8 *) (UINTN) HashData,\r
+             (UINT8 *)(UINTN)HashData,\r
              HashDataLen,\r
-             (TCG_PCR_EVENT_HDR*)TCGLogData,\r
+             (TCG_PCR_EVENT_HDR *)TCGLogData,\r
              TCGLogData->Event\r
              );\r
 \r
-  if (!EFI_ERROR(Status)){\r
-    *EventLogLastEntry = (EFI_PHYSICAL_ADDRESS)(UINTN) TcgData->LastEvent;\r
+  if (!EFI_ERROR (Status)) {\r
+    *EventLogLastEntry = (EFI_PHYSICAL_ADDRESS)(UINTN)TcgData->LastEvent;\r
   }\r
 \r
   return Status;\r
 }\r
 \r
-TCG_DXE_DATA                 mTcgDxeData = {\r
+TCG_DXE_DATA  mTcgDxeData = {\r
   {\r
     TcgDxeStatusCheck,\r
     TcgDxeHashAll,\r
@@ -724,6 +725,7 @@ SetupEventLog (
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
+\r
     mTcgClientAcpiTemplate.Lasa = Lasa;\r
     //\r
     // To initialize them as 0xFF is recommended\r
@@ -731,7 +733,6 @@ SetupEventLog (
     //\r
     SetMem ((VOID *)(UINTN)mTcgClientAcpiTemplate.Lasa, PcdGet32 (PcdTcgLogAreaMinLen), 0xFF);\r
     mTcgClientAcpiTemplate.Laml = PcdGet32 (PcdTcgLogAreaMinLen);\r
-\r
   } else {\r
     Lasa = mTcgServerAcpiTemplate.Lasa;\r
 \r
@@ -744,6 +745,7 @@ SetupEventLog (
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
+\r
     mTcgServerAcpiTemplate.Lasa = Lasa;\r
     //\r
     // To initialize them as 0xFF is recommended\r
@@ -755,14 +757,15 @@ SetupEventLog (
 \r
   GuidHob.Raw = GetHobList ();\r
   while (!EFI_ERROR (Status) &&\r
-         (GuidHob.Raw = GetNextGuidHob (&gTcgEventEntryHobGuid, GuidHob.Raw)) != NULL) {\r
+         (GuidHob.Raw = GetNextGuidHob (&gTcgEventEntryHobGuid, GuidHob.Raw)) != NULL)\r
+  {\r
     TcgEvent    = GET_GUID_HOB_DATA (GuidHob.Guid);\r
     GuidHob.Raw = GET_NEXT_HOB (GuidHob);\r
-    Status = TcgDxeLogEventI (\r
-               &mTcgDxeData,\r
-               (TCG_PCR_EVENT_HDR*)TcgEvent,\r
-               TcgEvent->Event\r
-               );\r
+    Status      = TcgDxeLogEventI (\r
+                    &mTcgDxeData,\r
+                    (TCG_PCR_EVENT_HDR *)TcgEvent,\r
+                    TcgEvent->Event\r
+                    );\r
   }\r
 \r
   return Status;\r
@@ -780,20 +783,20 @@ SetupEventLog (
 EFI_STATUS\r
 EFIAPI\r
 TcgMeasureAction (\r
-  IN      CHAR8                     *String\r
+  IN      CHAR8  *String\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
+  TCG_PCR_EVENT_HDR  TcgEvent;\r
 \r
   TcgEvent.PCRIndex  = 5;\r
   TcgEvent.EventType = EV_EFI_ACTION;\r
   TcgEvent.EventSize = (UINT32)AsciiStrLen (String);\r
   return TcgDxeHashLogExtendEventI (\r
            &mTcgDxeData,\r
-           (UINT8*)String,\r
+           (UINT8 *)String,\r
            TcgEvent.EventSize,\r
            &TcgEvent,\r
-           (UINT8 *) String\r
+           (UINT8 *)String\r
            );\r
 }\r
 \r
@@ -810,40 +813,40 @@ MeasureHandoffTables (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
-  EFI_HANDOFF_TABLE_POINTERS        HandoffTables;\r
-  UINTN                             ProcessorNum;\r
-  EFI_CPU_PHYSICAL_LOCATION         *ProcessorLocBuf;\r
+  EFI_STATUS                  Status;\r
+  TCG_PCR_EVENT_HDR           TcgEvent;\r
+  EFI_HANDOFF_TABLE_POINTERS  HandoffTables;\r
+  UINTN                       ProcessorNum;\r
+  EFI_CPU_PHYSICAL_LOCATION   *ProcessorLocBuf;\r
 \r
   ProcessorLocBuf = NULL;\r
-  Status = EFI_SUCCESS;\r
+  Status          = EFI_SUCCESS;\r
 \r
   if (PcdGet8 (PcdTpmPlatformClass) == TCG_PLATFORM_TYPE_SERVER) {\r
     //\r
     // Tcg Server spec.\r
     // Measure each processor EFI_CPU_PHYSICAL_LOCATION with EV_TABLE_OF_DEVICES to PCR[1]\r
     //\r
-    Status = GetProcessorsCpuLocation(&ProcessorLocBuf, &ProcessorNum);\r
+    Status = GetProcessorsCpuLocation (&ProcessorLocBuf, &ProcessorNum);\r
 \r
-    if (!EFI_ERROR(Status)){\r
+    if (!EFI_ERROR (Status)) {\r
       TcgEvent.PCRIndex  = 1;\r
       TcgEvent.EventType = EV_TABLE_OF_DEVICES;\r
       TcgEvent.EventSize = sizeof (HandoffTables);\r
 \r
-      HandoffTables.NumberOfTables = 1;\r
+      HandoffTables.NumberOfTables            = 1;\r
       HandoffTables.TableEntry[0].VendorGuid  = gEfiMpServiceProtocolGuid;\r
       HandoffTables.TableEntry[0].VendorTable = ProcessorLocBuf;\r
 \r
       Status = TcgDxeHashLogExtendEventI (\r
                  &mTcgDxeData,\r
-                 (UINT8*)(UINTN)ProcessorLocBuf,\r
-                 sizeof(EFI_CPU_PHYSICAL_LOCATION) * ProcessorNum,\r
+                 (UINT8 *)(UINTN)ProcessorLocBuf,\r
+                 sizeof (EFI_CPU_PHYSICAL_LOCATION) * ProcessorNum,\r
                  &TcgEvent,\r
-                 (UINT8*)&HandoffTables\r
+                 (UINT8 *)&HandoffTables\r
                  );\r
 \r
-      FreePool(ProcessorLocBuf);\r
+      FreePool (ProcessorLocBuf);\r
     }\r
   }\r
 \r
@@ -862,13 +865,13 @@ MeasureHandoffTables (
 EFI_STATUS\r
 EFIAPI\r
 MeasureSeparatorEvent (\r
-  IN      TPM_PCRINDEX              PCRIndex\r
+  IN      TPM_PCRINDEX  PCRIndex\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
-  UINT32                            EventData;\r
+  TCG_PCR_EVENT_HDR  TcgEvent;\r
+  UINT32             EventData;\r
 \r
-  EventData = 0;\r
+  EventData          = 0;\r
   TcgEvent.PCRIndex  = PCRIndex;\r
   TcgEvent.EventType = EV_SEPARATOR;\r
   TcgEvent.EventSize = (UINT32)sizeof (EventData);\r
@@ -897,22 +900,22 @@ MeasureSeparatorEvent (
 VOID *\r
 EFIAPI\r
 ReadVariable (\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  OUT     UINTN                     *VarSize\r
+  IN      CHAR16    *VarName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  OUT     UINTN     *VarSize\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  VOID                              *VarData;\r
+  EFI_STATUS  Status;\r
+  VOID        *VarData;\r
 \r
   *VarSize = 0;\r
-  Status = gRT->GetVariable (\r
-                  VarName,\r
-                  VendorGuid,\r
-                  NULL,\r
-                  VarSize,\r
-                  NULL\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    VarName,\r
+                    VendorGuid,\r
+                    NULL,\r
+                    VarSize,\r
+                    NULL\r
+                    );\r
   if (Status != EFI_BUFFER_TOO_SMALL) {\r
     return NULL;\r
   }\r
@@ -928,10 +931,11 @@ ReadVariable (
                     );\r
     if (EFI_ERROR (Status)) {\r
       FreePool (VarData);\r
-      VarData = NULL;\r
+      VarData  = NULL;\r
       *VarSize = 0;\r
     }\r
   }\r
+\r
   return VarData;\r
 }\r
 \r
@@ -953,26 +957,26 @@ ReadVariable (
 EFI_STATUS\r
 EFIAPI\r
 MeasureVariable (\r
-  IN      TPM_PCRINDEX              PCRIndex,\r
-  IN      TCG_EVENTTYPE             EventType,\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  IN      VOID                      *VarData,\r
-  IN      UINTN                     VarSize\r
+  IN      TPM_PCRINDEX   PCRIndex,\r
+  IN      TCG_EVENTTYPE  EventType,\r
+  IN      CHAR16         *VarName,\r
+  IN      EFI_GUID       *VendorGuid,\r
+  IN      VOID           *VarData,\r
+  IN      UINTN          VarSize\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TCG_PCR_EVENT_HDR                 TcgEvent;\r
-  UINTN                             VarNameLength;\r
-  EFI_VARIABLE_DATA                 *VarLog;\r
+  EFI_STATUS         Status;\r
+  TCG_PCR_EVENT_HDR  TcgEvent;\r
+  UINTN              VarNameLength;\r
+  EFI_VARIABLE_DATA  *VarLog;\r
 \r
   VarNameLength      = StrLen (VarName);\r
   TcgEvent.PCRIndex  = PCRIndex;\r
   TcgEvent.EventType = EventType;\r
   TcgEvent.EventSize = (UINT32)(sizeof (*VarLog) + VarNameLength * sizeof (*VarName) + VarSize\r
-                        - sizeof (VarLog->UnicodeName) - sizeof (VarLog->VariableData));\r
+                                - sizeof (VarLog->UnicodeName) - sizeof (VarLog->VariableData));\r
 \r
-  VarLog = (EFI_VARIABLE_DATA*)AllocatePool (TcgEvent.EventSize);\r
+  VarLog = (EFI_VARIABLE_DATA *)AllocatePool (TcgEvent.EventSize);\r
   if (VarLog == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
@@ -981,22 +985,22 @@ MeasureVariable (
   VarLog->UnicodeNameLength  = VarNameLength;\r
   VarLog->VariableDataLength = VarSize;\r
   CopyMem (\r
-     VarLog->UnicodeName,\r
-     VarName,\r
-     VarNameLength * sizeof (*VarName)\r
-     );\r
+    VarLog->UnicodeName,\r
+    VarName,\r
+    VarNameLength * sizeof (*VarName)\r
+    );\r
   CopyMem (\r
-     (CHAR16 *)VarLog->UnicodeName + VarNameLength,\r
-     VarData,\r
-     VarSize\r
-     );\r
+    (CHAR16 *)VarLog->UnicodeName + VarNameLength,\r
+    VarData,\r
+    VarSize\r
+    );\r
 \r
   Status = TcgDxeHashLogExtendEventI (\r
              &mTcgDxeData,\r
-             (UINT8*)VarLog,\r
+             (UINT8 *)VarLog,\r
              TcgEvent.EventSize,\r
              &TcgEvent,\r
-             (UINT8*)VarLog\r
+             (UINT8 *)VarLog\r
              );\r
   FreePool (VarLog);\r
   return Status;\r
@@ -1018,13 +1022,13 @@ MeasureVariable (
 EFI_STATUS\r
 EFIAPI\r
 ReadAndMeasureBootVariable (\r
-  IN      CHAR16                    *VarName,\r
-  IN      EFI_GUID                  *VendorGuid,\r
-  OUT     UINTN                     *VarSize,\r
-  OUT     VOID                      **VarData\r
+  IN      CHAR16    *VarName,\r
+  IN      EFI_GUID  *VendorGuid,\r
+  OUT     UINTN     *VarSize,\r
+  OUT     VOID      **VarData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   *VarData = ReadVariable (VarName, VendorGuid, VarSize);\r
   if (*VarData == NULL) {\r
@@ -1058,20 +1062,20 @@ MeasureAllBootVariables (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINT16                            *BootOrder;\r
-  UINTN                             BootCount;\r
-  UINTN                             Index;\r
-  VOID                              *BootVarData;\r
-  UINTN                             Size;\r
+  EFI_STATUS  Status;\r
+  UINT16      *BootOrder;\r
+  UINTN       BootCount;\r
+  UINTN       Index;\r
+  VOID        *BootVarData;\r
+  UINTN       Size;\r
 \r
   Status = ReadAndMeasureBootVariable (\r
              mBootVarName,\r
              &gEfiGlobalVariableGuid,\r
              &BootCount,\r
-             (VOID **) &BootOrder\r
+             (VOID **)&BootOrder\r
              );\r
-  if (Status == EFI_NOT_FOUND || BootOrder == NULL) {\r
+  if ((Status == EFI_NOT_FOUND) || (BootOrder == NULL)) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
@@ -1113,15 +1117,14 @@ MeasureAllBootVariables (
 VOID\r
 EFIAPI\r
 OnReadyToBoot (\r
-  IN      EFI_EVENT                 Event,\r
-  IN      VOID                      *Context\r
+  IN      EFI_EVENT  Event,\r
+  IN      VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM_PCRINDEX                      PcrIndex;\r
+  EFI_STATUS    Status;\r
+  TPM_PCRINDEX  PcrIndex;\r
 \r
   if (mBootAttempts == 0) {\r
-\r
     //\r
     // Measure handoff tables.\r
     //\r
@@ -1201,15 +1204,15 @@ OnReadyToBoot (
 VOID\r
 EFIAPI\r
 InstallAcpiTable (\r
-  IN EFI_EVENT                      Event,\r
-  IN VOID*                          Context\r
+  IN EFI_EVENT  Event,\r
+  IN VOID       *Context\r
   )\r
 {\r
-  UINTN                             TableKey;\r
-  EFI_STATUS                        Status;\r
-  EFI_ACPI_TABLE_PROTOCOL           *AcpiTable;\r
-  UINT8                             Checksum;\r
-  UINT64                            OemTableId;\r
+  UINTN                    TableKey;\r
+  EFI_STATUS               Status;\r
+  EFI_ACPI_TABLE_PROTOCOL  *AcpiTable;\r
+  UINT8                    Checksum;\r
+  UINT64                   OemTableId;\r
 \r
   Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **)&AcpiTable);\r
   if (EFI_ERROR (Status)) {\r
@@ -1220,47 +1223,47 @@ InstallAcpiTable (
     CopyMem (mTcgClientAcpiTemplate.Header.OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (mTcgClientAcpiTemplate.Header.OemId));\r
     OemTableId = PcdGet64 (PcdAcpiDefaultOemTableId);\r
     CopyMem (&mTcgClientAcpiTemplate.Header.OemTableId, &OemTableId, sizeof (UINT64));\r
-    mTcgClientAcpiTemplate.Header.OemRevision      = PcdGet32 (PcdAcpiDefaultOemRevision);\r
-    mTcgClientAcpiTemplate.Header.CreatorId        = PcdGet32 (PcdAcpiDefaultCreatorId);\r
-    mTcgClientAcpiTemplate.Header.CreatorRevision  = PcdGet32 (PcdAcpiDefaultCreatorRevision);\r
+    mTcgClientAcpiTemplate.Header.OemRevision     = PcdGet32 (PcdAcpiDefaultOemRevision);\r
+    mTcgClientAcpiTemplate.Header.CreatorId       = PcdGet32 (PcdAcpiDefaultCreatorId);\r
+    mTcgClientAcpiTemplate.Header.CreatorRevision = PcdGet32 (PcdAcpiDefaultCreatorRevision);\r
     //\r
     // The ACPI table must be checksummed before calling the InstallAcpiTable()\r
     // service of the ACPI table protocol to install it.\r
     //\r
-    Checksum = CalculateCheckSum8 ((UINT8 *)&mTcgClientAcpiTemplate, sizeof (mTcgClientAcpiTemplate));\r
+    Checksum                               = CalculateCheckSum8 ((UINT8 *)&mTcgClientAcpiTemplate, sizeof (mTcgClientAcpiTemplate));\r
     mTcgClientAcpiTemplate.Header.Checksum = Checksum;\r
 \r
     Status = AcpiTable->InstallAcpiTable (\r
-                            AcpiTable,\r
-                            &mTcgClientAcpiTemplate,\r
-                            sizeof (mTcgClientAcpiTemplate),\r
-                            &TableKey\r
-                            );\r
+                          AcpiTable,\r
+                          &mTcgClientAcpiTemplate,\r
+                          sizeof (mTcgClientAcpiTemplate),\r
+                          &TableKey\r
+                          );\r
   } else {\r
     CopyMem (mTcgServerAcpiTemplate.Header.OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (mTcgServerAcpiTemplate.Header.OemId));\r
     OemTableId = PcdGet64 (PcdAcpiDefaultOemTableId);\r
     CopyMem (&mTcgServerAcpiTemplate.Header.OemTableId, &OemTableId, sizeof (UINT64));\r
-    mTcgServerAcpiTemplate.Header.OemRevision      = PcdGet32 (PcdAcpiDefaultOemRevision);\r
-    mTcgServerAcpiTemplate.Header.CreatorId        = PcdGet32 (PcdAcpiDefaultCreatorId);\r
-    mTcgServerAcpiTemplate.Header.CreatorRevision  = PcdGet32 (PcdAcpiDefaultCreatorRevision);\r
+    mTcgServerAcpiTemplate.Header.OemRevision     = PcdGet32 (PcdAcpiDefaultOemRevision);\r
+    mTcgServerAcpiTemplate.Header.CreatorId       = PcdGet32 (PcdAcpiDefaultCreatorId);\r
+    mTcgServerAcpiTemplate.Header.CreatorRevision = PcdGet32 (PcdAcpiDefaultCreatorRevision);\r
     //\r
     // The ACPI table must be checksummed before calling the InstallAcpiTable()\r
     // service of the ACPI table protocol to install it.\r
     //\r
-    Checksum = CalculateCheckSum8 ((UINT8 *)&mTcgServerAcpiTemplate, sizeof (mTcgServerAcpiTemplate));\r
+    Checksum                               = CalculateCheckSum8 ((UINT8 *)&mTcgServerAcpiTemplate, sizeof (mTcgServerAcpiTemplate));\r
     mTcgServerAcpiTemplate.Header.Checksum = Checksum;\r
 \r
     mTcgServerAcpiTemplate.BaseAddress.Address = PcdGet64 (PcdTpmBaseAddress);\r
-    Status = AcpiTable->InstallAcpiTable (\r
-                            AcpiTable,\r
-                            &mTcgServerAcpiTemplate,\r
-                            sizeof (mTcgServerAcpiTemplate),\r
-                            &TableKey\r
-                            );\r
+    Status                                     = AcpiTable->InstallAcpiTable (\r
+                                                              AcpiTable,\r
+                                                              &mTcgServerAcpiTemplate,\r
+                                                              sizeof (mTcgServerAcpiTemplate),\r
+                                                              &TableKey\r
+                                                              );\r
   }\r
 \r
   if (EFI_ERROR (Status)) {\r
-    DEBUG((DEBUG_ERROR, "Tcg Acpi Table installation failure"));\r
+    DEBUG ((DEBUG_ERROR, "Tcg Acpi Table installation failure"));\r
   }\r
 }\r
 \r
@@ -1276,11 +1279,11 @@ InstallAcpiTable (
 VOID\r
 EFIAPI\r
 OnExitBootServices (\r
-  IN      EFI_EVENT                 Event,\r
-  IN      VOID                      *Context\r
+  IN      EFI_EVENT  Event,\r
+  IN      VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   //\r
   // Measure invocation of ExitBootServices,\r
@@ -1298,7 +1301,7 @@ OnExitBootServices (
   Status = TcgMeasureAction (\r
              EFI_EXIT_BOOT_SERVICES_SUCCEEDED\r
              );\r
-  if (EFI_ERROR (Status)){\r
+  if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "%a not Measured. Error!\n", EFI_EXIT_BOOT_SERVICES_SUCCEEDED));\r
   }\r
 }\r
@@ -1315,11 +1318,11 @@ OnExitBootServices (
 VOID\r
 EFIAPI\r
 OnExitBootServicesFailed (\r
-  IN      EFI_EVENT                 Event,\r
-  IN      VOID                      *Context\r
+  IN      EFI_EVENT  Event,\r
+  IN      VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS    Status;\r
+  EFI_STATUS  Status;\r
 \r
   //\r
   // Measure Failure of ExitBootServices,\r
@@ -1327,7 +1330,7 @@ OnExitBootServicesFailed (
   Status = TcgMeasureAction (\r
              EFI_EXIT_BOOT_SERVICES_FAILED\r
              );\r
-  if (EFI_ERROR (Status)){\r
+  if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "%a not Measured. Error!\n", EFI_EXIT_BOOT_SERVICES_FAILED));\r
   }\r
 }\r
@@ -1372,15 +1375,15 @@ GetTpmStatus (
 EFI_STATUS\r
 EFIAPI\r
 DriverEntry (\r
-  IN    EFI_HANDLE                  ImageHandle,\r
-  IN    EFI_SYSTEM_TABLE            *SystemTable\r
+  IN    EFI_HANDLE        ImageHandle,\r
+  IN    EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_EVENT                         Event;\r
-  VOID                              *Registration;\r
+  EFI_STATUS  Status;\r
+  EFI_EVENT   Event;\r
+  VOID        *Registration;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)) {\r
     DEBUG ((DEBUG_ERROR, "No TPM12 instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
index 536bd5a40820ba37067856a13e8d942924a487e1..5aa80511aa814e9146333ab6a3affe04553747b4 100644 (file)
@@ -39,7 +39,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/BaseCryptLib.h>\r
 #include <Library/PerformanceLib.h>\r
 \r
-BOOLEAN                 mImageInMemory  = FALSE;\r
+BOOLEAN  mImageInMemory = FALSE;\r
 \r
 EFI_PEI_PPI_DESCRIPTOR  mTpmInitializedPpiList = {\r
   EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,\r
@@ -74,15 +74,15 @@ EFI_PEI_PPI_DESCRIPTOR  mTpmInitializationDonePpiList = {
 EFI_STATUS\r
 EFIAPI\r
 HashLogExtendEvent (\r
-  IN      EDKII_TCG_PPI             *This,\r
-  IN      UINT64                    Flags,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINTN                     HashDataLen,\r
-  IN      TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      EDKII_TCG_PPI      *This,\r
+  IN      UINT64             Flags,\r
+  IN      UINT8              *HashData,\r
+  IN      UINTN              HashDataLen,\r
+  IN      TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   );\r
 \r
-EDKII_TCG_PPI mEdkiiTcgPpi = {\r
+EDKII_TCG_PPI  mEdkiiTcgPpi = {\r
   HashLogExtendEvent\r
 };\r
 \r
@@ -95,17 +95,17 @@ EFI_PEI_PPI_DESCRIPTOR  mTcgPpiList = {
 //\r
 // Number of firmware blobs to grow by each time we run out of room\r
 //\r
-#define FIRMWARE_BLOB_GROWTH_STEP 4\r
+#define FIRMWARE_BLOB_GROWTH_STEP  4\r
 \r
-EFI_PLATFORM_FIRMWARE_BLOB *mMeasuredBaseFvInfo;\r
-UINT32 mMeasuredMaxBaseFvIndex = 0;\r
-UINT32 mMeasuredBaseFvIndex = 0;\r
+EFI_PLATFORM_FIRMWARE_BLOB  *mMeasuredBaseFvInfo;\r
+UINT32                      mMeasuredMaxBaseFvIndex = 0;\r
+UINT32                      mMeasuredBaseFvIndex    = 0;\r
 \r
-EFI_PLATFORM_FIRMWARE_BLOB *mMeasuredChildFvInfo;\r
-UINT32 mMeasuredMaxChildFvIndex = 0;\r
-UINT32 mMeasuredChildFvIndex = 0;\r
+EFI_PLATFORM_FIRMWARE_BLOB  *mMeasuredChildFvInfo;\r
+UINT32                      mMeasuredMaxChildFvIndex = 0;\r
+UINT32                      mMeasuredChildFvIndex    = 0;\r
 \r
-EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI *mMeasurementExcludedFvPpi;\r
+EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI  *mMeasurementExcludedFvPpi;\r
 \r
 /**\r
   Lock physical presence if needed.\r
@@ -120,9 +120,9 @@ EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI *mMeasurementExcludedFvPpi
 EFI_STATUS\r
 EFIAPI\r
 PhysicalPresencePpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   );\r
 \r
 /**\r
@@ -139,9 +139,9 @@ PhysicalPresencePpiNotifyCallback (
 EFI_STATUS\r
 EFIAPI\r
 FirmwareVolumeInfoPpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   );\r
 \r
 /**\r
@@ -158,12 +158,12 @@ FirmwareVolumeInfoPpiNotifyCallback (
 EFI_STATUS\r
 EFIAPI\r
 EndofPeiSignalNotifyCallBack (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   );\r
 \r
-EFI_PEI_NOTIFY_DESCRIPTOR           mNotifyList[] = {\r
+EFI_PEI_NOTIFY_DESCRIPTOR  mNotifyList[] = {\r
   {\r
     EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK,\r
     &gPeiLockPhysicalPresencePpiGuid,\r
@@ -204,12 +204,12 @@ EFI_PEI_NOTIFY_DESCRIPTOR           mNotifyList[] = {
 EFI_STATUS\r
 EFIAPI\r
 EndofPeiSignalNotifyCallBack (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
-  MEASURED_HOB_DATA *MeasuredHobData;\r
+  MEASURED_HOB_DATA  *MeasuredHobData;\r
 \r
   MeasuredHobData = NULL;\r
 \r
@@ -218,12 +218,12 @@ EndofPeiSignalNotifyCallBack (
   //\r
   // Create a Guid hob to save all measured Fv\r
   //\r
-  MeasuredHobData = BuildGuidHob(\r
+  MeasuredHobData = BuildGuidHob (\r
                       &gMeasuredFvHobGuid,\r
-                      sizeof(UINTN) + sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex + mMeasuredChildFvIndex)\r
+                      sizeof (UINTN) + sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex + mMeasuredChildFvIndex)\r
                       );\r
 \r
-  if (MeasuredHobData != NULL){\r
+  if (MeasuredHobData != NULL) {\r
     //\r
     // Save measured FV info enty number\r
     //\r
@@ -232,12 +232,12 @@ EndofPeiSignalNotifyCallBack (
     //\r
     // Save measured base Fv info\r
     //\r
-    CopyMem (MeasuredHobData->MeasuredFvBuf, mMeasuredBaseFvInfo, sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex));\r
+    CopyMem (MeasuredHobData->MeasuredFvBuf, mMeasuredBaseFvInfo, sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex));\r
 \r
     //\r
     // Save measured child Fv info\r
     //\r
-    CopyMem (&MeasuredHobData->MeasuredFvBuf[mMeasuredBaseFvIndex] , mMeasuredChildFvInfo, sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredChildFvIndex));\r
+    CopyMem (&MeasuredHobData->MeasuredFvBuf[mMeasuredBaseFvIndex], mMeasuredChildFvInfo, sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredChildFvIndex));\r
   }\r
 \r
   PERF_CALLBACK_END (&gEfiEndOfPeiSignalPpiGuid);\r
@@ -300,16 +300,16 @@ TpmCommHashAll (
 EFI_STATUS\r
 EFIAPI\r
 HashLogExtendEvent (\r
-  IN      EDKII_TCG_PPI             *This,\r
-  IN      UINT64                    Flags,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINTN                     HashDataLen,\r
-  IN      TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      EDKII_TCG_PPI      *This,\r
+  IN      UINT64             Flags,\r
+  IN      UINT8              *HashData,\r
+  IN      UINTN              HashDataLen,\r
+  IN      TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  VOID                              *HobData;\r
+  EFI_STATUS  Status;\r
+  VOID        *HobData;\r
 \r
   if (GetFirstGuidHob (&gTpmErrorHobGuid) != NULL) {\r
     return EFI_DEVICE_ERROR;\r
@@ -337,28 +337,29 @@ HashLogExtendEvent (
   }\r
 \r
   HobData = BuildGuidHob (\r
-             &gTcgEventEntryHobGuid,\r
-             sizeof (*NewEventHdr) + NewEventHdr->EventSize\r
-             );\r
+              &gTcgEventEntryHobGuid,\r
+              sizeof (*NewEventHdr) + NewEventHdr->EventSize\r
+              );\r
   if (HobData == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
 \r
   CopyMem (HobData, NewEventHdr, sizeof (*NewEventHdr));\r
-  HobData = (VOID *) ((UINT8*)HobData + sizeof (*NewEventHdr));\r
+  HobData = (VOID *)((UINT8 *)HobData + sizeof (*NewEventHdr));\r
   CopyMem (HobData, NewEventData, NewEventHdr->EventSize);\r
 \r
 Done:\r
   if ((Status == EFI_DEVICE_ERROR) || (Status == EFI_TIMEOUT)) {\r
     DEBUG ((DEBUG_ERROR, "HashLogExtendEvent - %r. Disable TPM.\n", Status));\r
-    BuildGuidHob (&gTpmErrorHobGuid,0);\r
+    BuildGuidHob (&gTpmErrorHobGuid, 0);\r
     REPORT_STATUS_CODE (\r
       EFI_ERROR_CODE | EFI_ERROR_MINOR,\r
       (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERROR)\r
       );\r
     Status = EFI_DEVICE_ERROR;\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -375,10 +376,10 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 MeasureCRTMVersion (\r
-  IN      EFI_PEI_SERVICES          **PeiServices\r
+  IN      EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEventHdr;\r
+  TCG_PCR_EVENT_HDR  TcgEventHdr;\r
 \r
   //\r
   // Use FirmwareVersion string to represent CRTM version.\r
@@ -387,15 +388,15 @@ MeasureCRTMVersion (
 \r
   TcgEventHdr.PCRIndex  = 0;\r
   TcgEventHdr.EventType = EV_S_CRTM_VERSION;\r
-  TcgEventHdr.EventSize = (UINT32) StrSize((CHAR16*)PcdGetPtr (PcdFirmwareVersionString));\r
+  TcgEventHdr.EventSize = (UINT32)StrSize ((CHAR16 *)PcdGetPtr (PcdFirmwareVersionString));\r
 \r
   return HashLogExtendEvent (\r
            &mEdkiiTcgPpi,\r
            0,\r
-           (UINT8*)PcdGetPtr (PcdFirmwareVersionString),\r
+           (UINT8 *)PcdGetPtr (PcdFirmwareVersionString),\r
            TcgEventHdr.EventSize,\r
            &TcgEventHdr,\r
-           (UINT8*)PcdGetPtr (PcdFirmwareVersionString)\r
+           (UINT8 *)PcdGetPtr (PcdFirmwareVersionString)\r
            );\r
 }\r
 \r
@@ -415,24 +416,24 @@ MeasureCRTMVersion (
 EFI_STATUS\r
 EFIAPI\r
 MeasureFvImage (\r
-  IN EFI_PHYSICAL_ADDRESS           FvBase,\r
-  IN UINT64                         FvLength\r
+  IN EFI_PHYSICAL_ADDRESS  FvBase,\r
+  IN UINT64                FvLength\r
   )\r
 {\r
-  UINT32                            Index;\r
-  EFI_STATUS                        Status;\r
-  EFI_PLATFORM_FIRMWARE_BLOB        FvBlob;\r
-  TCG_PCR_EVENT_HDR                 TcgEventHdr;\r
-  EFI_PHYSICAL_ADDRESS              FvOrgBase;\r
-  EFI_PHYSICAL_ADDRESS              FvDataBase;\r
-  EFI_PEI_HOB_POINTERS              Hob;\r
-  EDKII_MIGRATED_FV_INFO            *MigratedFvInfo;\r
+  UINT32                      Index;\r
+  EFI_STATUS                  Status;\r
+  EFI_PLATFORM_FIRMWARE_BLOB  FvBlob;\r
+  TCG_PCR_EVENT_HDR           TcgEventHdr;\r
+  EFI_PHYSICAL_ADDRESS        FvOrgBase;\r
+  EFI_PHYSICAL_ADDRESS        FvDataBase;\r
+  EFI_PEI_HOB_POINTERS        Hob;\r
+  EDKII_MIGRATED_FV_INFO      *MigratedFvInfo;\r
 \r
   //\r
   // Check if it is in Excluded FV list\r
   //\r
   if (mMeasurementExcludedFvPpi != NULL) {\r
-    for (Index = 0; Index < mMeasurementExcludedFvPpi->Count; Index ++) {\r
+    for (Index = 0; Index < mMeasurementExcludedFvPpi->Count; Index++) {\r
       if (mMeasurementExcludedFvPpi->Fv[Index].FvBase == FvBase) {\r
         DEBUG ((DEBUG_INFO, "The FV which is excluded by TcgPei starts at: 0x%x\n", FvBase));\r
         DEBUG ((DEBUG_INFO, "The FV which is excluded by TcgPei has the size: 0x%x\n", FvLength));\r
@@ -444,7 +445,7 @@ MeasureFvImage (
   //\r
   // Check whether FV is in the measured FV list.\r
   //\r
-  for (Index = 0; Index < mMeasuredBaseFvIndex; Index ++) {\r
+  for (Index = 0; Index < mMeasuredBaseFvIndex; Index++) {\r
     if (mMeasuredBaseFvInfo[Index].BlobBase == FvBase) {\r
       return EFI_SUCCESS;\r
     }\r
@@ -455,17 +456,18 @@ MeasureFvImage (
   //\r
   FvOrgBase  = FvBase;\r
   FvDataBase = FvBase;\r
-  Hob.Raw  = GetFirstGuidHob (&gEdkiiMigratedFvInfoGuid);\r
+  Hob.Raw    = GetFirstGuidHob (&gEdkiiMigratedFvInfoGuid);\r
   while (Hob.Raw != NULL) {\r
     MigratedFvInfo = GET_GUID_HOB_DATA (Hob);\r
-    if ((MigratedFvInfo->FvNewBase == (UINT32) FvBase) && (MigratedFvInfo->FvLength == (UINT32) FvLength)) {\r
+    if ((MigratedFvInfo->FvNewBase == (UINT32)FvBase) && (MigratedFvInfo->FvLength == (UINT32)FvLength)) {\r
       //\r
       // Found the migrated FV info\r
       //\r
-      FvOrgBase  = (EFI_PHYSICAL_ADDRESS) (UINTN) MigratedFvInfo->FvOrgBase;\r
-      FvDataBase = (EFI_PHYSICAL_ADDRESS) (UINTN) MigratedFvInfo->FvDataBase;\r
+      FvOrgBase  = (EFI_PHYSICAL_ADDRESS)(UINTN)MigratedFvInfo->FvOrgBase;\r
+      FvDataBase = (EFI_PHYSICAL_ADDRESS)(UINTN)MigratedFvInfo->FvDataBase;\r
       break;\r
     }\r
+\r
     Hob.Raw = GET_NEXT_HOB (Hob);\r
     Hob.Raw = GetNextGuidHob (&gEdkiiMigratedFvInfoGuid, Hob.Raw);\r
   }\r
@@ -479,17 +481,17 @@ MeasureFvImage (
   DEBUG ((DEBUG_INFO, "The FV which is measured by TcgPei starts at: 0x%x\n", FvBlob.BlobBase));\r
   DEBUG ((DEBUG_INFO, "The FV which is measured by TcgPei has the size: 0x%x\n", FvBlob.BlobLength));\r
 \r
-  TcgEventHdr.PCRIndex = 0;\r
+  TcgEventHdr.PCRIndex  = 0;\r
   TcgEventHdr.EventType = EV_EFI_PLATFORM_FIRMWARE_BLOB;\r
   TcgEventHdr.EventSize = sizeof (FvBlob);\r
 \r
   Status = HashLogExtendEvent (\r
              &mEdkiiTcgPpi,\r
              0,\r
-             (UINT8*) (UINTN) FvDataBase,\r
-             (UINTN) FvBlob.BlobLength,\r
+             (UINT8 *)(UINTN)FvDataBase,\r
+             (UINTN)FvBlob.BlobLength,\r
              &TcgEventHdr,\r
-             (UINT8*) &FvBlob\r
+             (UINT8 *)&FvBlob\r
              );\r
 \r
   //\r
@@ -525,16 +527,16 @@ MeasureFvImage (
 EFI_STATUS\r
 EFIAPI\r
 MeasureMainBios (\r
-  IN      EFI_PEI_SERVICES          **PeiServices\r
+  IN      EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINT32                            FvInstances;\r
-  EFI_PEI_FV_HANDLE                 VolumeHandle;\r
-  EFI_FV_INFO                       VolumeInfo;\r
-  EFI_PEI_FIRMWARE_VOLUME_PPI       *FvPpi;\r
+  EFI_STATUS                   Status;\r
+  UINT32                       FvInstances;\r
+  EFI_PEI_FV_HANDLE            VolumeHandle;\r
+  EFI_FV_INFO                  VolumeInfo;\r
+  EFI_PEI_FIRMWARE_VOLUME_PPI  *FvPpi;\r
 \r
-  FvInstances    = 0;\r
+  FvInstances = 0;\r
   while (TRUE) {\r
     //\r
     // Traverse all firmware volume instances of Static Core Root of Trust for Measurement\r
@@ -558,10 +560,10 @@ MeasureMainBios (
                &VolumeInfo.FvFormat,\r
                0,\r
                NULL,\r
-               (VOID**)&FvPpi\r
+               (VOID **)&FvPpi\r
                );\r
     if (!EFI_ERROR (Status)) {\r
-      MeasureFvImage ((EFI_PHYSICAL_ADDRESS) (UINTN) VolumeInfo.FvStart, VolumeInfo.FvSize);\r
+      MeasureFvImage ((EFI_PHYSICAL_ADDRESS)(UINTN)VolumeInfo.FvStart, VolumeInfo.FvSize);\r
     }\r
 \r
     FvInstances++;\r
@@ -584,9 +586,9 @@ MeasureMainBios (
 EFI_STATUS\r
 EFIAPI\r
 FirmwareVolumeInfoPpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES               **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR      *NotifyDescriptor,\r
-  IN VOID                           *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
   EFI_PEI_FIRMWARE_VOLUME_INFO_PPI  *Fv;\r
@@ -594,7 +596,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
   EFI_PEI_FIRMWARE_VOLUME_PPI       *FvPpi;\r
   UINTN                             Index;\r
 \r
-  Fv = (EFI_PEI_FIRMWARE_VOLUME_INFO_PPI *) Ppi;\r
+  Fv = (EFI_PEI_FIRMWARE_VOLUME_INFO_PPI *)Ppi;\r
 \r
   //\r
   // The PEI Core can not dispatch or load files from memory mapped FVs that do not support FvPpi.\r
@@ -603,7 +605,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
              &Fv->FvFormat,\r
              0,\r
              NULL,\r
-             (VOID**)&FvPpi\r
+             (VOID **)&FvPpi\r
              );\r
   if (EFI_ERROR (Status)) {\r
     return EFI_SUCCESS;\r
@@ -613,8 +615,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
   // This is an FV from an FFS file, and the parent FV must have already been measured,\r
   // No need to measure twice, so just record the FV and return\r
   //\r
-  if (Fv->ParentFvName != NULL || Fv->ParentFileName != NULL ) {\r
-\r
+  if ((Fv->ParentFvName != NULL) || (Fv->ParentFileName != NULL)) {\r
     if (mMeasuredChildFvIndex >= mMeasuredMaxChildFvIndex) {\r
       mMeasuredChildFvInfo = ReallocatePool (\r
                                sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * mMeasuredMaxChildFvIndex,\r
@@ -624,21 +625,23 @@ FirmwareVolumeInfoPpiNotifyCallback (
       ASSERT (mMeasuredChildFvInfo != NULL);\r
       mMeasuredMaxChildFvIndex = mMeasuredMaxChildFvIndex + FIRMWARE_BLOB_GROWTH_STEP;\r
     }\r
+\r
     //\r
     // Check whether FV is in the measured child FV list.\r
     //\r
     for (Index = 0; Index < mMeasuredChildFvIndex; Index++) {\r
-      if (mMeasuredChildFvInfo[Index].BlobBase == (EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo) {\r
+      if (mMeasuredChildFvInfo[Index].BlobBase == (EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo) {\r
         return EFI_SUCCESS;\r
       }\r
     }\r
-    mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobBase   = (EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo;\r
+\r
+    mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobBase   = (EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo;\r
     mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobLength = Fv->FvInfoSize;\r
     mMeasuredChildFvIndex++;\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  return MeasureFvImage ((EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo, Fv->FvInfoSize);\r
+  return MeasureFvImage ((EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo, Fv->FvInfoSize);\r
 }\r
 \r
 /**\r
@@ -657,15 +660,15 @@ FirmwareVolumeInfoPpiNotifyCallback (
 EFI_STATUS\r
 EFIAPI\r
 PhysicalPresencePpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES               **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR      *NotifyDescriptor,\r
-  IN VOID                           *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM_PERMANENT_FLAGS               TpmPermanentFlags;\r
-  PEI_LOCK_PHYSICAL_PRESENCE_PPI    *LockPhysicalPresencePpi;\r
-  TPM_PHYSICAL_PRESENCE             PhysicalPresenceValue;\r
+  EFI_STATUS                      Status;\r
+  TPM_PERMANENT_FLAGS             TpmPermanentFlags;\r
+  PEI_LOCK_PHYSICAL_PRESENCE_PPI  *LockPhysicalPresencePpi;\r
+  TPM_PHYSICAL_PRESENCE           PhysicalPresenceValue;\r
 \r
   Status = Tpm12GetCapabilityFlagPermanent (&TpmPermanentFlags);\r
   if (EFI_ERROR (Status)) {\r
@@ -679,14 +682,14 @@ PhysicalPresencePpiNotifyCallback (
     //\r
     // Lock TPM LifetimeLock is required, and LifetimeLock is not locked yet.\r
     //\r
-    PhysicalPresenceValue = TPM_PHYSICAL_PRESENCE_LIFETIME_LOCK;\r
+    PhysicalPresenceValue                          = TPM_PHYSICAL_PRESENCE_LIFETIME_LOCK;\r
     TpmPermanentFlags.physicalPresenceLifetimeLock = TRUE;\r
 \r
     if (PcdGetBool (PcdPhysicalPresenceCmdEnable)) {\r
-      PhysicalPresenceValue |= TPM_PHYSICAL_PRESENCE_CMD_ENABLE;\r
+      PhysicalPresenceValue                      |= TPM_PHYSICAL_PRESENCE_CMD_ENABLE;\r
       TpmPermanentFlags.physicalPresenceCMDEnable = TRUE;\r
     } else {\r
-      PhysicalPresenceValue |= TPM_PHYSICAL_PRESENCE_CMD_DISABLE;\r
+      PhysicalPresenceValue                      |= TPM_PHYSICAL_PRESENCE_CMD_DISABLE;\r
       TpmPermanentFlags.physicalPresenceCMDEnable = FALSE;\r
     }\r
 \r
@@ -707,8 +710,8 @@ PhysicalPresencePpiNotifyCallback (
   //\r
   // 2. Lock physical presence if it is required.\r
   //\r
-  LockPhysicalPresencePpi = (PEI_LOCK_PHYSICAL_PRESENCE_PPI *) Ppi;\r
-  if (!LockPhysicalPresencePpi->LockPhysicalPresence ((CONST EFI_PEI_SERVICES**) PeiServices)) {\r
+  LockPhysicalPresencePpi = (PEI_LOCK_PHYSICAL_PRESENCE_PPI *)Ppi;\r
+  if (!LockPhysicalPresencePpi->LockPhysicalPresence ((CONST EFI_PEI_SERVICES **)PeiServices)) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
@@ -736,8 +739,8 @@ PhysicalPresencePpiNotifyCallback (
   // Lock physical presence\r
   //\r
   Status = Tpm12PhysicalPresence (\r
-              TPM_PHYSICAL_PRESENCE_LOCK\r
-              );\r
+             TPM_PHYSICAL_PRESENCE_LOCK\r
+             );\r
   return Status;\r
 }\r
 \r
@@ -762,6 +765,7 @@ IsTpmUsable (
   if (EFI_ERROR (Status)) {\r
     return FALSE;\r
   }\r
+\r
   return (BOOLEAN)(!TpmPermanentFlags.deactivated);\r
 }\r
 \r
@@ -778,17 +782,17 @@ IsTpmUsable (
 EFI_STATUS\r
 EFIAPI\r
 PeimEntryMP (\r
-  IN      EFI_PEI_SERVICES          **PeiServices\r
+  IN      EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = PeiServicesLocatePpi (\r
-               &gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid,\r
-               0,\r
-               NULL,\r
-               (VOID**)&mMeasurementExcludedFvPpi\r
-               );\r
+             &gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid,\r
+             0,\r
+             NULL,\r
+             (VOID **)&mMeasurementExcludedFvPpi\r
+             );\r
   // Do not check status, because it is optional\r
 \r
   Status = Tpm12RequestUseTpm ();\r
@@ -835,15 +839,15 @@ PeimEntryMP (
 EFI_STATUS\r
 EFIAPI\r
 PeimEntryMA (\r
-  IN       EFI_PEI_FILE_HANDLE      FileHandle,\r
-  IN CONST EFI_PEI_SERVICES         **PeiServices\r
+  IN       EFI_PEI_FILE_HANDLE  FileHandle,\r
+  IN CONST EFI_PEI_SERVICES     **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_STATUS                        Status2;\r
-  EFI_BOOT_MODE                     BootMode;\r
+  EFI_STATUS     Status;\r
+  EFI_STATUS     Status2;\r
+  EFI_BOOT_MODE  BootMode;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)) {\r
     DEBUG ((DEBUG_ERROR, "No TPM12 instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -863,7 +867,7 @@ PeimEntryMA (
   // In S3 path, skip shadow logic. no measurement is required\r
   //\r
   if (BootMode != BOOT_ON_S3_RESUME) {\r
-    Status = (**PeiServices).RegisterForShadow(FileHandle);\r
+    Status = (**PeiServices).RegisterForShadow (FileHandle);\r
     if (Status == EFI_ALREADY_STARTED) {\r
       mImageInMemory = TRUE;\r
     } else if (Status == EFI_NOT_FOUND) {\r
@@ -884,7 +888,8 @@ PeimEntryMA (
       } else {\r
         Status = Tpm12Startup (TPM_ST_CLEAR);\r
       }\r
-      if (EFI_ERROR (Status) ) {\r
+\r
+      if (EFI_ERROR (Status)) {\r
         goto Done;\r
       }\r
     }\r
@@ -907,19 +912,20 @@ PeimEntryMA (
   }\r
 \r
   if (mImageInMemory) {\r
-    Status = PeimEntryMP ((EFI_PEI_SERVICES**)PeiServices);\r
+    Status = PeimEntryMP ((EFI_PEI_SERVICES **)PeiServices);\r
     return Status;\r
   }\r
 \r
 Done:\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "TPM error! Build Hob\n"));\r
-    BuildGuidHob (&gTpmErrorHobGuid,0);\r
+    BuildGuidHob (&gTpmErrorHobGuid, 0);\r
     REPORT_STATUS_CODE (\r
       EFI_ERROR_CODE | EFI_ERROR_MINOR,\r
       (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERROR)\r
       );\r
   }\r
+\r
   //\r
   // Always install TpmInitializationDonePpi no matter success or fail.\r
   // Other driver can know TPM initialization state by TpmInitializedPpi.\r
index 25f443c04fa1b31ed5f05353f9f20cbbae56c9f2..96327a483ba9dfbd222519322210d5d834c6af9b 100644 (file)
@@ -38,29 +38,29 @@ TCG_NVS                    *mTcgNvs;
 EFI_STATUS\r
 EFIAPI\r
 PhysicalPresenceCallback (\r
-  IN EFI_HANDLE                  DispatchHandle,\r
-  IN CONST VOID                  *Context,\r
-  IN OUT VOID                    *CommBuffer,\r
-  IN OUT UINTN                   *CommBufferSize\r
+  IN EFI_HANDLE  DispatchHandle,\r
+  IN CONST VOID  *Context,\r
+  IN OUT VOID    *CommBuffer,\r
+  IN OUT UINTN   *CommBufferSize\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  UINTN                          DataSize;\r
-  EFI_PHYSICAL_PRESENCE          PpData;\r
-  EFI_PHYSICAL_PRESENCE_FLAGS    Flags;\r
-  BOOLEAN                        RequestConfirmed;\r
+  EFI_STATUS                   Status;\r
+  UINTN                        DataSize;\r
+  EFI_PHYSICAL_PRESENCE        PpData;\r
+  EFI_PHYSICAL_PRESENCE_FLAGS  Flags;\r
+  BOOLEAN                      RequestConfirmed;\r
 \r
   //\r
   // Get the Physical Presence variable\r
   //\r
   DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-  Status = mSmmVariable->SmmGetVariable (\r
-                           PHYSICAL_PRESENCE_VARIABLE,\r
-                           &gEfiPhysicalPresenceGuid,\r
-                           NULL,\r
-                           &DataSize,\r
-                           &PpData\r
-                           );\r
+  Status   = mSmmVariable->SmmGetVariable (\r
+                             PHYSICAL_PRESENCE_VARIABLE,\r
+                             &gEfiPhysicalPresenceGuid,\r
+                             NULL,\r
+                             &DataSize,\r
+                             &PpData\r
+                             );\r
 \r
   DEBUG ((DEBUG_INFO, "[TPM] PP callback, Parameter = %x\n", mTcgNvs->PhysicalPresence.Parameter));\r
   if (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_RETURN_REQUEST_RESPONSE_TO_OS) {\r
@@ -71,16 +71,19 @@ PhysicalPresenceCallback (
       DEBUG ((DEBUG_ERROR, "[TPM] Get PP variable failure! Status = %r\n", Status));\r
       return EFI_SUCCESS;\r
     }\r
+\r
     mTcgNvs->PhysicalPresence.ReturnCode  = PP_RETURN_TPM_OPERATION_RESPONSE_SUCCESS;\r
     mTcgNvs->PhysicalPresence.LastRequest = PpData.LastPPRequest;\r
     mTcgNvs->PhysicalPresence.Response    = PpData.PPResponse;\r
-  } else if ((mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS)\r
-          || (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS_2)) {\r
+  } else if (  (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS)\r
+            || (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS_2))\r
+  {\r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE;\r
       DEBUG ((DEBUG_ERROR, "[TPM] Get PP variable failure! Status = %r\n", Status));\r
       return EFI_SUCCESS;\r
     }\r
+\r
     if (mTcgNvs->PhysicalPresence.Request == PHYSICAL_PRESENCE_SET_OPERATOR_AUTH) {\r
       //\r
       // This command requires UI to prompt user for Auth data.\r
@@ -90,35 +93,37 @@ PhysicalPresenceCallback (
     }\r
 \r
     if (PpData.PPRequest != mTcgNvs->PhysicalPresence.Request) {\r
-      PpData.PPRequest = (UINT8) mTcgNvs->PhysicalPresence.Request;\r
-      DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-      Status = mSmmVariable->SmmSetVariable (\r
-                               PHYSICAL_PRESENCE_VARIABLE,\r
-                               &gEfiPhysicalPresenceGuid,\r
-                               EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                               DataSize,\r
-                               &PpData\r
-                               );\r
+      PpData.PPRequest = (UINT8)mTcgNvs->PhysicalPresence.Request;\r
+      DataSize         = sizeof (EFI_PHYSICAL_PRESENCE);\r
+      Status           = mSmmVariable->SmmSetVariable (\r
+                                         PHYSICAL_PRESENCE_VARIABLE,\r
+                                         &gEfiPhysicalPresenceGuid,\r
+                                         EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                                         DataSize,\r
+                                         &PpData\r
+                                         );\r
     }\r
 \r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE;\r
       return EFI_SUCCESS;\r
     }\r
+\r
     mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS;\r
 \r
     if (mTcgNvs->PhysicalPresence.Request >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
       DataSize = sizeof (EFI_PHYSICAL_PRESENCE_FLAGS);\r
-      Status = mSmmVariable->SmmGetVariable (\r
-                               PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                               &gEfiPhysicalPresenceGuid,\r
-                               NULL,\r
-                               &DataSize,\r
-                               &Flags\r
-                               );\r
+      Status   = mSmmVariable->SmmGetVariable (\r
+                                 PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                                 &gEfiPhysicalPresenceGuid,\r
+                                 NULL,\r
+                                 &DataSize,\r
+                                 &Flags\r
+                                 );\r
       if (EFI_ERROR (Status)) {\r
         Flags.PPFlags = TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION;\r
       }\r
+\r
       mTcgNvs->PhysicalPresence.ReturnCode = TcgPpVendorLibSubmitRequestToPreOSFunction (mTcgNvs->PhysicalPresence.Request, Flags.PPFlags);\r
     }\r
   } else if (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_GET_USER_CONFIRMATION_STATUS_FOR_REQUEST) {\r
@@ -127,17 +132,18 @@ PhysicalPresenceCallback (
       DEBUG ((DEBUG_ERROR, "[TPM] Get PP variable failure! Status = %r\n", Status));\r
       return EFI_SUCCESS;\r
     }\r
+\r
     //\r
     // Get the Physical Presence flags\r
     //\r
     DataSize = sizeof (EFI_PHYSICAL_PRESENCE_FLAGS);\r
-    Status = mSmmVariable->SmmGetVariable (\r
-                             PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                             &gEfiPhysicalPresenceGuid,\r
-                             NULL,\r
-                             &DataSize,\r
-                             &Flags\r
-                             );\r
+    Status   = mSmmVariable->SmmGetVariable (\r
+                               PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                               &gEfiPhysicalPresenceGuid,\r
+                               NULL,\r
+                               &DataSize,\r
+                               &Flags\r
+                               );\r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_GET_USER_CONFIRMATION_BLOCKED_BY_BIOS_CONFIGURATION;\r
       DEBUG ((DEBUG_ERROR, "[TPM] Get PP flags failure! Status = %r\n", Status));\r
@@ -160,6 +166,7 @@ PhysicalPresenceCallback (
         if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0) {\r
           RequestConfirmed = TRUE;\r
         }\r
+\r
         break;\r
 \r
       case PHYSICAL_PRESENCE_CLEAR:\r
@@ -167,19 +174,22 @@ PhysicalPresenceCallback (
         if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0) {\r
           RequestConfirmed = TRUE;\r
         }\r
+\r
         break;\r
 \r
       case PHYSICAL_PRESENCE_DEFERRED_PP_UNOWNERED_FIELD_UPGRADE:\r
         if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_MAINTENANCE) != 0) {\r
           RequestConfirmed = TRUE;\r
         }\r
+\r
         break;\r
 \r
       case PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE:\r
       case PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE:\r
-        if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0 && (Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0) {\r
+        if (((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0) && ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0)) {\r
           RequestConfirmed = TRUE;\r
         }\r
+\r
         break;\r
 \r
       case PHYSICAL_PRESENCE_SET_NO_PPI_PROVISION_FALSE:\r
@@ -204,6 +214,7 @@ PhysicalPresenceCallback (
     } else {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_GET_USER_CONFIRMATION_ALLOWED_AND_PPUSER_REQUIRED;\r
     }\r
+\r
     if (mTcgNvs->PhysicalPresence.Request >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TcgPpVendorLibGetUserConfirmationStatusFunction (mTcgNvs->PhysicalPresence.Request, Flags.PPFlags);\r
     }\r
@@ -212,7 +223,6 @@ PhysicalPresenceCallback (
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Software SMI callback for MemoryClear which is called from ACPI method.\r
 \r
@@ -233,28 +243,28 @@ PhysicalPresenceCallback (
 EFI_STATUS\r
 EFIAPI\r
 MemoryClearCallback (\r
-  IN EFI_HANDLE                  DispatchHandle,\r
-  IN CONST VOID                  *Context,\r
-  IN OUT VOID                    *CommBuffer,\r
-  IN OUT UINTN                   *CommBufferSize\r
+  IN EFI_HANDLE  DispatchHandle,\r
+  IN CONST VOID  *Context,\r
+  IN OUT VOID    *CommBuffer,\r
+  IN OUT UINTN   *CommBufferSize\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  UINTN                          DataSize;\r
-  UINT8                          MorControl;\r
+  EFI_STATUS  Status;\r
+  UINTN       DataSize;\r
+  UINT8       MorControl;\r
 \r
   mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_SUCCESS;\r
   if (mTcgNvs->MemoryClear.Parameter == ACPI_FUNCTION_DSM_MEMORY_CLEAR_INTERFACE) {\r
-    MorControl = (UINT8) mTcgNvs->MemoryClear.Request;\r
+    MorControl = (UINT8)mTcgNvs->MemoryClear.Request;\r
   } else if (mTcgNvs->MemoryClear.Parameter == ACPI_FUNCTION_PTS_CLEAR_MOR_BIT) {\r
     DataSize = sizeof (UINT8);\r
-    Status = mSmmVariable->SmmGetVariable (\r
-                             MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-                             &gEfiMemoryOverwriteControlDataGuid,\r
-                             NULL,\r
-                             &DataSize,\r
-                             &MorControl\r
-                             );\r
+    Status   = mSmmVariable->SmmGetVariable (\r
+                               MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                               &gEfiMemoryOverwriteControlDataGuid,\r
+                               NULL,\r
+                               &DataSize,\r
+                               &MorControl\r
+                               );\r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
       DEBUG ((DEBUG_ERROR, "[TPM] Get MOR variable failure! Status = %r\n", Status));\r
@@ -264,6 +274,7 @@ MemoryClearCallback (
     if (MOR_CLEAR_MEMORY_VALUE (MorControl) == 0x0) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     MorControl &= ~MOR_CLEAR_MEMORY_BIT_MASK;\r
   } else {\r
     mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
@@ -272,13 +283,13 @@ MemoryClearCallback (
   }\r
 \r
   DataSize = sizeof (UINT8);\r
-  Status = mSmmVariable->SmmSetVariable (\r
-                           MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-                           &gEfiMemoryOverwriteControlDataGuid,\r
-                           EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                           DataSize,\r
-                           &MorControl\r
-                           );\r
+  Status   = mSmmVariable->SmmSetVariable (\r
+                             MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                             &gEfiMemoryOverwriteControlDataGuid,\r
+                             EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                             DataSize,\r
+                             &MorControl\r
+                             );\r
   if (EFI_ERROR (Status)) {\r
     mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
     DEBUG ((DEBUG_ERROR, "[TPM] Set MOR variable failure! Status = %r\n", Status));\r
@@ -300,38 +311,39 @@ MemoryClearCallback (
 **/\r
 VOID *\r
 AssignOpRegion (\r
-  EFI_ACPI_DESCRIPTION_HEADER    *Table,\r
-  UINT32                         Name,\r
-  UINT16                         Size\r
+  EFI_ACPI_DESCRIPTION_HEADER  *Table,\r
+  UINT32                       Name,\r
+  UINT16                       Size\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  AML_OP_REGION_32_8             *OpRegion;\r
-  EFI_PHYSICAL_ADDRESS           MemoryAddress;\r
+  EFI_STATUS            Status;\r
+  AML_OP_REGION_32_8    *OpRegion;\r
+  EFI_PHYSICAL_ADDRESS  MemoryAddress;\r
 \r
   MemoryAddress = SIZE_4GB - 1;\r
 \r
   //\r
   // Patch some pointers for the ASL code before loading the SSDT.\r
   //\r
-  for (OpRegion  = (AML_OP_REGION_32_8 *) (Table + 1);\r
-       OpRegion <= (AML_OP_REGION_32_8 *) ((UINT8 *) Table + Table->Length);\r
-       OpRegion  = (AML_OP_REGION_32_8 *) ((UINT8 *) OpRegion + 1)) {\r
+  for (OpRegion  = (AML_OP_REGION_32_8 *)(Table + 1);\r
+       OpRegion <= (AML_OP_REGION_32_8 *)((UINT8 *)Table + Table->Length);\r
+       OpRegion  = (AML_OP_REGION_32_8 *)((UINT8 *)OpRegion + 1))\r
+  {\r
     if ((OpRegion->OpRegionOp  == AML_EXT_REGION_OP) &&\r
         (OpRegion->NameString  == Name) &&\r
         (OpRegion->DWordPrefix == AML_DWORD_PREFIX) &&\r
-        (OpRegion->BytePrefix  == AML_BYTE_PREFIX)) {\r
-\r
-      Status = gBS->AllocatePages(AllocateMaxAddress, EfiACPIMemoryNVS, EFI_SIZE_TO_PAGES (Size), &MemoryAddress);\r
+        (OpRegion->BytePrefix  == AML_BYTE_PREFIX))\r
+    {\r
+      Status = gBS->AllocatePages (AllocateMaxAddress, EfiACPIMemoryNVS, EFI_SIZE_TO_PAGES (Size), &MemoryAddress);\r
       ASSERT_EFI_ERROR (Status);\r
       ZeroMem ((VOID *)(UINTN)MemoryAddress, Size);\r
-      OpRegion->RegionOffset = (UINT32) (UINTN) MemoryAddress;\r
-      OpRegion->RegionLen    = (UINT8) Size;\r
+      OpRegion->RegionOffset = (UINT32)(UINTN)MemoryAddress;\r
+      OpRegion->RegionLen    = (UINT8)Size;\r
       break;\r
     }\r
   }\r
 \r
-  return (VOID *) (UINTN) MemoryAddress;\r
+  return (VOID *)(UINTN)MemoryAddress;\r
 }\r
 \r
 /**\r
@@ -346,26 +358,25 @@ PublishAcpiTable (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  EFI_ACPI_TABLE_PROTOCOL        *AcpiTable;\r
-  UINTN                          TableKey;\r
-  EFI_ACPI_DESCRIPTION_HEADER    *Table;\r
-  UINTN                          TableSize;\r
+  EFI_STATUS                   Status;\r
+  EFI_ACPI_TABLE_PROTOCOL      *AcpiTable;\r
+  UINTN                        TableKey;\r
+  EFI_ACPI_DESCRIPTION_HEADER  *Table;\r
+  UINTN                        TableSize;\r
 \r
   Status = GetSectionFromFv (\r
              &gEfiCallerIdGuid,\r
              EFI_SECTION_RAW,\r
              0,\r
-             (VOID **) &Table,\r
+             (VOID **)&Table,\r
              &TableSize\r
              );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-\r
   //\r
   // Measure to PCR[0] with event EV_POST_CODE ACPI DATA\r
   //\r
-  TpmMeasureAndLogData(\r
+  TpmMeasureAndLogData (\r
     0,\r
     EV_POST_CODE,\r
     EV_POSTCODE_INFO_ACPI_DATA,\r
@@ -374,25 +385,24 @@ PublishAcpiTable (
     TableSize\r
     );\r
 \r
-\r
   ASSERT (Table->OemTableId == SIGNATURE_64 ('T', 'c', 'g', 'T', 'a', 'b', 'l', 'e'));\r
-  CopyMem (Table->OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (Table->OemId) );\r
-  mTcgNvs = AssignOpRegion (Table, SIGNATURE_32 ('T', 'N', 'V', 'S'), (UINT16) sizeof (TCG_NVS));\r
+  CopyMem (Table->OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (Table->OemId));\r
+  mTcgNvs = AssignOpRegion (Table, SIGNATURE_32 ('T', 'N', 'V', 'S'), (UINT16)sizeof (TCG_NVS));\r
   ASSERT (mTcgNvs != NULL);\r
 \r
   //\r
   // Publish the TPM ACPI table\r
   //\r
-  Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **) &AcpiTable);\r
+  Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **)&AcpiTable);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   TableKey = 0;\r
-  Status = AcpiTable->InstallAcpiTable (\r
-                        AcpiTable,\r
-                        Table,\r
-                        TableSize,\r
-                        &TableKey\r
-                        );\r
+  Status   = AcpiTable->InstallAcpiTable (\r
+                          AcpiTable,\r
+                          Table,\r
+                          TableSize,\r
+                          &TableKey\r
+                          );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   return Status;\r
@@ -414,8 +424,8 @@ PublishAcpiTable (
 EFI_STATUS\r
 EFIAPI\r
 InitializeTcgSmm (\r
-  IN EFI_HANDLE                  ImageHandle,\r
-  IN EFI_SYSTEM_TABLE            *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   EFI_STATUS                     Status;\r
@@ -423,7 +433,7 @@ InitializeTcgSmm (
   EFI_SMM_SW_REGISTER_CONTEXT    SwContext;\r
   EFI_HANDLE                     SwHandle;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)) {\r
     DEBUG ((DEBUG_ERROR, "No TPM12 instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -434,28 +444,30 @@ InitializeTcgSmm (
   //\r
   // Get the Sw dispatch protocol and register SMI callback functions.\r
   //\r
-  Status = gSmst->SmmLocateProtocol (&gEfiSmmSwDispatch2ProtocolGuid, NULL, (VOID**)&SwDispatch);\r
+  Status = gSmst->SmmLocateProtocol (&gEfiSmmSwDispatch2ProtocolGuid, NULL, (VOID **)&SwDispatch);\r
   ASSERT_EFI_ERROR (Status);\r
-  SwContext.SwSmiInputValue = (UINTN) -1;\r
-  Status = SwDispatch->Register (SwDispatch, PhysicalPresenceCallback, &SwContext, &SwHandle);\r
+  SwContext.SwSmiInputValue = (UINTN)-1;\r
+  Status                    = SwDispatch->Register (SwDispatch, PhysicalPresenceCallback, &SwContext, &SwHandle);\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
-  mTcgNvs->PhysicalPresence.SoftwareSmi = (UINT8) SwContext.SwSmiInputValue;\r
 \r
-  SwContext.SwSmiInputValue = (UINTN) -1;\r
-  Status = SwDispatch->Register (SwDispatch, MemoryClearCallback, &SwContext, &SwHandle);\r
+  mTcgNvs->PhysicalPresence.SoftwareSmi = (UINT8)SwContext.SwSmiInputValue;\r
+\r
+  SwContext.SwSmiInputValue = (UINTN)-1;\r
+  Status                    = SwDispatch->Register (SwDispatch, MemoryClearCallback, &SwContext, &SwHandle);\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
-  mTcgNvs->MemoryClear.SoftwareSmi = (UINT8) SwContext.SwSmiInputValue;\r
+\r
+  mTcgNvs->MemoryClear.SoftwareSmi = (UINT8)SwContext.SwSmiInputValue;\r
 \r
   //\r
   // Locate SmmVariableProtocol.\r
   //\r
-  Status = gSmst->SmmLocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID**)&mSmmVariable);\r
+  Status = gSmst->SmmLocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID **)&mSmmVariable);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   return EFI_SUCCESS;\r
index 443f5871bfb5d469919f8c33cd05265859a223eb..e348ad105499447588ba87e6540af9f01b03ce68 100644 (file)
@@ -34,66 +34,66 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #pragma pack(1)\r
 typedef struct {\r
-  UINT8                  SoftwareSmi;\r
-  UINT32                 Parameter;\r
-  UINT32                 Response;\r
-  UINT32                 Request;\r
-  UINT32                 LastRequest;\r
-  UINT32                 ReturnCode;\r
+  UINT8     SoftwareSmi;\r
+  UINT32    Parameter;\r
+  UINT32    Response;\r
+  UINT32    Request;\r
+  UINT32    LastRequest;\r
+  UINT32    ReturnCode;\r
 } PHYSICAL_PRESENCE_NVS;\r
 \r
 typedef struct {\r
-  UINT8                  SoftwareSmi;\r
-  UINT32                 Parameter;\r
-  UINT32                 Request;\r
-  UINT32                 ReturnCode;\r
+  UINT8     SoftwareSmi;\r
+  UINT32    Parameter;\r
+  UINT32    Request;\r
+  UINT32    ReturnCode;\r
 } MEMORY_CLEAR_NVS;\r
 \r
 typedef struct {\r
-  PHYSICAL_PRESENCE_NVS  PhysicalPresence;\r
-  MEMORY_CLEAR_NVS       MemoryClear;\r
-  UINT32                 PPRequestUserConfirm;\r
+  PHYSICAL_PRESENCE_NVS    PhysicalPresence;\r
+  MEMORY_CLEAR_NVS         MemoryClear;\r
+  UINT32                   PPRequestUserConfirm;\r
 } TCG_NVS;\r
 \r
 typedef struct {\r
-  UINT8                  OpRegionOp;\r
-  UINT32                 NameString;\r
-  UINT8                  RegionSpace;\r
-  UINT8                  DWordPrefix;\r
-  UINT32                 RegionOffset;\r
-  UINT8                  BytePrefix;\r
-  UINT8                  RegionLen;\r
+  UINT8     OpRegionOp;\r
+  UINT32    NameString;\r
+  UINT8     RegionSpace;\r
+  UINT8     DWordPrefix;\r
+  UINT32    RegionOffset;\r
+  UINT8     BytePrefix;\r
+  UINT8     RegionLen;\r
 } AML_OP_REGION_32_8;\r
 #pragma pack()\r
 \r
 //\r
 // The definition for TCG physical presence ACPI function\r
 //\r
-#define ACPI_FUNCTION_GET_PHYSICAL_PRESENCE_INTERFACE_VERSION      1\r
-#define ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS                       2\r
-#define ACPI_FUNCTION_GET_PENDING_REQUEST_BY_OS                    3\r
-#define ACPI_FUNCTION_GET_PLATFORM_ACTION_TO_TRANSITION_TO_BIOS    4\r
-#define ACPI_FUNCTION_RETURN_REQUEST_RESPONSE_TO_OS                5\r
-#define ACPI_FUNCTION_SUBMIT_PREFERRED_USER_LANGUAGE               6\r
-#define ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS_2                     7\r
-#define ACPI_FUNCTION_GET_USER_CONFIRMATION_STATUS_FOR_REQUEST     8\r
+#define ACPI_FUNCTION_GET_PHYSICAL_PRESENCE_INTERFACE_VERSION    1\r
+#define ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS                     2\r
+#define ACPI_FUNCTION_GET_PENDING_REQUEST_BY_OS                  3\r
+#define ACPI_FUNCTION_GET_PLATFORM_ACTION_TO_TRANSITION_TO_BIOS  4\r
+#define ACPI_FUNCTION_RETURN_REQUEST_RESPONSE_TO_OS              5\r
+#define ACPI_FUNCTION_SUBMIT_PREFERRED_USER_LANGUAGE             6\r
+#define ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS_2                   7\r
+#define ACPI_FUNCTION_GET_USER_CONFIRMATION_STATUS_FOR_REQUEST   8\r
 \r
 //\r
 // The return code for Return TPM Operation Response to OS Environment\r
 //\r
-#define PP_RETURN_TPM_OPERATION_RESPONSE_SUCCESS                   0\r
-#define PP_RETURN_TPM_OPERATION_RESPONSE_FAILURE                   1\r
+#define PP_RETURN_TPM_OPERATION_RESPONSE_SUCCESS  0\r
+#define PP_RETURN_TPM_OPERATION_RESPONSE_FAILURE  1\r
 \r
 //\r
 // The definition for TCG MOR\r
 //\r
-#define ACPI_FUNCTION_DSM_MEMORY_CLEAR_INTERFACE                   1\r
-#define ACPI_FUNCTION_PTS_CLEAR_MOR_BIT                            2\r
+#define ACPI_FUNCTION_DSM_MEMORY_CLEAR_INTERFACE  1\r
+#define ACPI_FUNCTION_PTS_CLEAR_MOR_BIT           2\r
 \r
 //\r
 // The return code for Memory Clear Interface Functions\r
 //\r
-#define MOR_REQUEST_SUCCESS                                        0\r
-#define MOR_REQUEST_GENERAL_FAILURE                                1\r
+#define MOR_REQUEST_SUCCESS          0\r
+#define MOR_REQUEST_GENERAL_FAILURE  1\r
 \r
-#endif  // __TCG_SMM_H__\r
+#endif // __TCG_SMM_H__\r
index 1e27f7a28ce9b49c038b9df20ba4db40c590423d..40d989dab6c873c9743c9d0ba842a6c4446bf6c1 100644 (file)
@@ -8,7 +8,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "SecureBootConfigImpl.h"\r
 \r
-\r
 /**\r
   This function converts an input device structure to a Unicode string.\r
 \r
@@ -20,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 CHAR16 *\r
 EFIAPI\r
 DevicePathToStr (\r
-  IN EFI_DEVICE_PATH_PROTOCOL     *DevPath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *DevPath\r
   )\r
 {\r
   return ConvertDevicePathToText (\r
@@ -29,4 +28,3 @@ DevicePathToStr (
            TRUE\r
            );\r
 }\r
-\r
index 8936a0a634cf20d47adab835b40b11e65ef41139..46ddcab0080b7e4a02baeb172485150ed8f9574f 100644 (file)
@@ -23,17 +23,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 SecureBootConfigDriverEntryPoint (\r
-  IN EFI_HANDLE          ImageHandle,\r
-  IN EFI_SYSTEM_TABLE    *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
-  SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData;\r
+  EFI_STATUS                      Status;\r
+  SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData;\r
 \r
   //\r
   // If already started, return.\r
   //\r
-    Status = gBS->OpenProtocol (\r
+  Status = gBS->OpenProtocol (\r
                   ImageHandle,\r
                   &gEfiCallerIdGuid,\r
                   NULL,\r
@@ -100,13 +100,13 @@ SecureBootConfigDriverUnload (
   IN EFI_HANDLE  ImageHandle\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData;\r
+  EFI_STATUS                      Status;\r
+  SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData;\r
 \r
   Status = gBS->HandleProtocol (\r
                   ImageHandle,\r
                   &gEfiCallerIdGuid,\r
-                  (VOID **) &PrivateData\r
+                  (VOID **)&PrivateData\r
                   );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
index 8bea707d4e189e9ccec8d2f51b446bc7980dc9b9..5a23dc517aa75a8f399203e3695c2b8e7c313bea 100644 (file)
@@ -8,10 +8,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 \r
 #include "SecureBootConfigImpl.h"\r
 \r
-VOID                  *mStartOpCodeHandle = NULL;\r
-VOID                  *mEndOpCodeHandle = NULL;\r
-EFI_IFR_GUID_LABEL    *mStartLabel = NULL;\r
-EFI_IFR_GUID_LABEL    *mEndLabel = NULL;\r
+VOID                *mStartOpCodeHandle = NULL;\r
+VOID                *mEndOpCodeHandle   = NULL;\r
+EFI_IFR_GUID_LABEL  *mStartLabel        = NULL;\r
+EFI_IFR_GUID_LABEL  *mEndLabel          = NULL;\r
 \r
 /**\r
   Refresh the global UpdateData structure.\r
@@ -37,12 +37,12 @@ RefreshUpdateData (
   //\r
   // Create Hii Extend Label OpCode as the start opcode\r
   //\r
-  mStartLabel = (EFI_IFR_GUID_LABEL *) HiiCreateGuidOpCode (\r
-                                         mStartOpCodeHandle,\r
-                                         &gEfiIfrTianoGuid,\r
-                                         NULL,\r
-                                         sizeof (EFI_IFR_GUID_LABEL)\r
-                                         );\r
+  mStartLabel = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
+                                        mStartOpCodeHandle,\r
+                                        &gEfiIfrTianoGuid,\r
+                                        NULL,\r
+                                        sizeof (EFI_IFR_GUID_LABEL)\r
+                                        );\r
   mStartLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
 }\r
 \r
@@ -55,8 +55,8 @@ RefreshUpdateData (
 **/\r
 VOID\r
 CleanUpPage (\r
-  IN UINT16                           LabelId,\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData\r
+  IN UINT16                          LabelId,\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData\r
   )\r
 {\r
   RefreshUpdateData ();\r
@@ -87,39 +87,38 @@ CleanUpPage (
 **/\r
 CHAR16 *\r
 ExtractFileNameFromDevicePath (\r
-  IN   EFI_DEVICE_PATH_PROTOCOL *DevicePath\r
+  IN   EFI_DEVICE_PATH_PROTOCOL  *DevicePath\r
   )\r
 {\r
-  CHAR16          *String;\r
-  CHAR16          *MatchString;\r
-  CHAR16          *LastMatch;\r
-  CHAR16          *FileName;\r
-  UINTN           Length;\r
+  CHAR16  *String;\r
+  CHAR16  *MatchString;\r
+  CHAR16  *LastMatch;\r
+  CHAR16  *FileName;\r
+  UINTN   Length;\r
 \r
-  ASSERT(DevicePath != NULL);\r
+  ASSERT (DevicePath != NULL);\r
 \r
-  String = DevicePathToStr(DevicePath);\r
+  String      = DevicePathToStr (DevicePath);\r
   MatchString = String;\r
   LastMatch   = String;\r
   FileName    = NULL;\r
 \r
-  while(MatchString != NULL){\r
+  while (MatchString != NULL) {\r
     LastMatch   = MatchString + 1;\r
-    MatchString = StrStr(LastMatch,L"\\");\r
+    MatchString = StrStr (LastMatch, L"\\");\r
   }\r
 \r
-  Length = StrLen(LastMatch);\r
-  FileName = AllocateCopyPool ((Length + 1) * sizeof(CHAR16), LastMatch);\r
+  Length   = StrLen (LastMatch);\r
+  FileName = AllocateCopyPool ((Length + 1) * sizeof (CHAR16), LastMatch);\r
   if (FileName != NULL) {\r
     *(FileName + Length) = 0;\r
   }\r
 \r
-  FreePool(String);\r
+  FreePool (String);\r
 \r
   return FileName;\r
 }\r
 \r
-\r
 /**\r
   Update  the form base on the selected file.\r
 \r
@@ -131,19 +130,20 @@ ExtractFileNameFromDevicePath (
 \r
 **/\r
 BOOLEAN\r
-UpdatePage(\r
+UpdatePage (\r
   IN  EFI_DEVICE_PATH_PROTOCOL  *FilePath,\r
   IN  EFI_FORM_ID               FormId\r
   )\r
 {\r
-  CHAR16                *FileName;\r
-  EFI_STRING_ID         StringToken;\r
+  CHAR16         *FileName;\r
+  EFI_STRING_ID  StringToken;\r
 \r
   FileName = NULL;\r
 \r
   if (FilePath != NULL) {\r
-    FileName = ExtractFileNameFromDevicePath(FilePath);\r
+    FileName = ExtractFileNameFromDevicePath (FilePath);\r
   }\r
+\r
   if (FileName == NULL) {\r
     //\r
     // FileName = NULL has two case:\r
@@ -153,6 +153,7 @@ UpdatePage(
     //\r
     return TRUE;\r
   }\r
+\r
   StringToken =  HiiSetString (gSecureBootPrivateData->HiiHandle, 0, FileName, NULL);\r
 \r
   gSecureBootPrivateData->FileContext->FileName = FileName;\r
@@ -175,7 +176,7 @@ UpdatePage(
     0,\r
     0,\r
     0\r
-   );\r
+    );\r
 \r
   HiiUpdateForm (\r
     gSecureBootPrivateData->HiiHandle,\r
@@ -199,11 +200,10 @@ UpdatePage(
 BOOLEAN\r
 EFIAPI\r
 UpdatePKFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   )\r
 {\r
-  return UpdatePage(FilePath, FORMID_ENROLL_PK_FORM);\r
-\r
+  return UpdatePage (FilePath, FORMID_ENROLL_PK_FORM);\r
 }\r
 \r
 /**\r
@@ -217,10 +217,10 @@ UpdatePKFromFile (
 BOOLEAN\r
 EFIAPI\r
 UpdateKEKFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   )\r
 {\r
-  return UpdatePage(FilePath, FORMID_ENROLL_KEK_FORM);\r
+  return UpdatePage (FilePath, FORMID_ENROLL_KEK_FORM);\r
 }\r
 \r
 /**\r
@@ -234,10 +234,10 @@ UpdateKEKFromFile (
 BOOLEAN\r
 EFIAPI\r
 UpdateDBFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   )\r
 {\r
-  return UpdatePage(FilePath, SECUREBOOT_ENROLL_SIGNATURE_TO_DB);\r
+  return UpdatePage (FilePath, SECUREBOOT_ENROLL_SIGNATURE_TO_DB);\r
 }\r
 \r
 /**\r
@@ -251,10 +251,10 @@ UpdateDBFromFile (
 BOOLEAN\r
 EFIAPI\r
 UpdateDBXFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   )\r
 {\r
-  return UpdatePage(FilePath, SECUREBOOT_ENROLL_SIGNATURE_TO_DBX);\r
+  return UpdatePage (FilePath, SECUREBOOT_ENROLL_SIGNATURE_TO_DBX);\r
 }\r
 \r
 /**\r
@@ -268,9 +268,8 @@ UpdateDBXFromFile (
 BOOLEAN\r
 EFIAPI\r
 UpdateDBTFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   )\r
 {\r
-  return UpdatePage(FilePath, SECUREBOOT_ENROLL_SIGNATURE_TO_DBT);\r
+  return UpdatePage (FilePath, SECUREBOOT_ENROLL_SIGNATURE_TO_DBT);\r
 }\r
-\r
index c19f9e7b90836085c8250080fbbbb85eaaa2d360..0122e8d55fa0f9de49cf4d2b2d95da4ef8311f07 100644 (file)
@@ -13,9 +13,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/SecureBootVariableLib.h>\r
 #include <Library/SecureBootVariableProvisionLib.h>\r
 \r
-CHAR16              mSecureBootStorageName[] = L"SECUREBOOT_CONFIGURATION";\r
+CHAR16  mSecureBootStorageName[] = L"SECUREBOOT_CONFIGURATION";\r
 \r
-SECUREBOOT_CONFIG_PRIVATE_DATA         mSecureBootConfigPrivateDateTemplate = {\r
+SECUREBOOT_CONFIG_PRIVATE_DATA  mSecureBootConfigPrivateDateTemplate = {\r
   SECUREBOOT_CONFIG_PRIVATE_DATA_SIGNATURE,\r
   {\r
     SecureBootExtractConfig,\r
@@ -24,14 +24,14 @@ SECUREBOOT_CONFIG_PRIVATE_DATA         mSecureBootConfigPrivateDateTemplate = {
   }\r
 };\r
 \r
-HII_VENDOR_DEVICE_PATH          mSecureBootHiiVendorDevicePath = {\r
+HII_VENDOR_DEVICE_PATH  mSecureBootHiiVendorDevicePath = {\r
   {\r
     {\r
       HARDWARE_DEVICE_PATH,\r
       HW_VENDOR_DP,\r
       {\r
-        (UINT8) (sizeof (VENDOR_DEVICE_PATH)),\r
-        (UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
+        (UINT8)(sizeof (VENDOR_DEVICE_PATH)),\r
+        (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)\r
       }\r
     },\r
     SECUREBOOT_CONFIG_FORM_SET_GUID\r
@@ -40,69 +40,68 @@ HII_VENDOR_DEVICE_PATH          mSecureBootHiiVendorDevicePath = {
     END_DEVICE_PATH_TYPE,\r
     END_ENTIRE_DEVICE_PATH_SUBTYPE,\r
     {\r
-      (UINT8) (END_DEVICE_PATH_LENGTH),\r
-      (UINT8) ((END_DEVICE_PATH_LENGTH) >> 8)\r
+      (UINT8)(END_DEVICE_PATH_LENGTH),\r
+      (UINT8)((END_DEVICE_PATH_LENGTH) >> 8)\r
     }\r
   }\r
 };\r
 \r
-\r
-BOOLEAN mIsEnterSecureBootForm = FALSE;\r
+BOOLEAN  mIsEnterSecureBootForm = FALSE;\r
 \r
 //\r
 // OID ASN.1 Value for Hash Algorithms\r
 //\r
-UINT8 mHashOidValue[] = {\r
-  0x2A, 0x86, 0x48, 0x86, 0xF7, 0x0D, 0x02, 0x05,         // OBJ_md5\r
-  0x2B, 0x0E, 0x03, 0x02, 0x1A,                           // OBJ_sha1\r
-  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x04,   // OBJ_sha224\r
-  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x01,   // OBJ_sha256\r
-  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x02,   // OBJ_sha384\r
-  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x03,   // OBJ_sha512\r
-  };\r
-\r
-HASH_TABLE mHash[] = {\r
-  { L"SHA224", 28, &mHashOidValue[13], 9, NULL,                 NULL,       NULL,         NULL       },\r
-  { L"SHA256", 32, &mHashOidValue[22], 9, Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final},\r
-  { L"SHA384", 48, &mHashOidValue[31], 9, Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final},\r
-  { L"SHA512", 64, &mHashOidValue[40], 9, Sha512GetContextSize, Sha512Init, Sha512Update, Sha512Final}\r
+UINT8  mHashOidValue[] = {\r
+  0x2A, 0x86, 0x48, 0x86, 0xF7, 0x0D, 0x02, 0x05,       // OBJ_md5\r
+  0x2B, 0x0E, 0x03, 0x02, 0x1A,                         // OBJ_sha1\r
+  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x04, // OBJ_sha224\r
+  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x01, // OBJ_sha256\r
+  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x02, // OBJ_sha384\r
+  0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x03, // OBJ_sha512\r
+};\r
+\r
+HASH_TABLE  mHash[] = {\r
+  { L"SHA224", 28, &mHashOidValue[13], 9, NULL,                 NULL,       NULL,         NULL        },\r
+  { L"SHA256", 32, &mHashOidValue[22], 9, Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },\r
+  { L"SHA384", 48, &mHashOidValue[31], 9, Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final },\r
+  { L"SHA512", 64, &mHashOidValue[40], 9, Sha512GetContextSize, Sha512Init, Sha512Update, Sha512Final }\r
 };\r
 \r
 //\r
 // Variable Definitions\r
 //\r
-UINT32            mPeCoffHeaderOffset = 0;\r
-WIN_CERTIFICATE   *mCertificate = NULL;\r
-IMAGE_TYPE        mImageType;\r
-UINT8             *mImageBase = NULL;\r
-UINTN             mImageSize = 0;\r
-UINT8             mImageDigest[MAX_DIGEST_SIZE];\r
-UINTN             mImageDigestSize;\r
-EFI_GUID          mCertType;\r
+UINT32                               mPeCoffHeaderOffset = 0;\r
+WIN_CERTIFICATE                      *mCertificate       = NULL;\r
+IMAGE_TYPE                           mImageType;\r
+UINT8                                *mImageBase = NULL;\r
+UINTN                                mImageSize  = 0;\r
+UINT8                                mImageDigest[MAX_DIGEST_SIZE];\r
+UINTN                                mImageDigestSize;\r
+EFI_GUID                             mCertType;\r
 EFI_IMAGE_SECURITY_DATA_DIRECTORY    *mSecDataDir = NULL;\r
 EFI_IMAGE_OPTIONAL_HEADER_PTR_UNION  mNtHeader;\r
 \r
 //\r
 // Possible DER-encoded certificate file suffixes, end with NULL pointer.\r
 //\r
-CHAR16mDerEncodedSuffix[] = {\r
+CHAR16  *mDerEncodedSuffix[] = {\r
   L".cer",\r
   L".der",\r
   L".crt",\r
   NULL\r
 };\r
-CHAR16mSupportX509Suffix = L"*.cer/der/crt";\r
+CHAR16  *mSupportX509Suffix = L"*.cer/der/crt";\r
 \r
 //\r
 // Prompt strings during certificate enrollment.\r
 //\r
-CHAR16mX509EnrollPromptTitle[] = {\r
+CHAR16  *mX509EnrollPromptTitle[] = {\r
   L"",\r
   L"ERROR: Unsupported file type!",\r
   L"ERROR: Unsupported certificate!",\r
   NULL\r
 };\r
-CHAR16mX509EnrollPromptString[] = {\r
+CHAR16  *mX509EnrollPromptString[] = {\r
   L"",\r
   L"Only DER encoded certificate file (*.cer/der/crt) is supported.",\r
   L"Public key length should be equal to or greater than 2048 bits.",\r
@@ -119,21 +118,21 @@ SECUREBOOT_CONFIG_PRIVATE_DATA  *gSecureBootPrivateData = NULL;
 \r
 **/\r
 VOID\r
-CloseEnrolledFile(\r
-  IN SECUREBOOT_FILE_CONTEXT *FileContext\r
-)\r
+CloseEnrolledFile (\r
+  IN SECUREBOOT_FILE_CONTEXT  *FileContext\r
+  )\r
 {\r
   if (FileContext->FHandle != NULL) {\r
     CloseFile (FileContext->FHandle);\r
     FileContext->FHandle = NULL;\r
   }\r
 \r
-  if (FileContext->FileName != NULL){\r
-    FreePool(FileContext->FileName);\r
+  if (FileContext->FileName != NULL) {\r
+    FreePool (FileContext->FileName);\r
     FileContext->FileName = NULL;\r
   }\r
-  FileContext->FileType = UNKNOWN_FILE_TYPE;\r
 \r
+  FileContext->FileType = UNKNOWN_FILE_TYPE;\r
 }\r
 \r
 /**\r
@@ -147,15 +146,17 @@ CloseEnrolledFile(
 **/\r
 BOOLEAN\r
 IsDerEncodeCertificate (\r
-  IN CONST CHAR16         *FileSuffix\r
-)\r
+  IN CONST CHAR16  *FileSuffix\r
+  )\r
 {\r
-  UINTN     Index;\r
+  UINTN  Index;\r
+\r
   for (Index = 0; mDerEncodedSuffix[Index] != NULL; Index++) {\r
     if (StrCmp (FileSuffix, mDerEncodedSuffix[Index]) == 0) {\r
       return TRUE;\r
     }\r
   }\r
+\r
   return FALSE;\r
 }\r
 \r
@@ -171,8 +172,8 @@ The function reads file content but won't open/close given FileHandle.
 **/\r
 BOOLEAN\r
 IsAuthentication2Format (\r
-  IN   EFI_FILE_HANDLE    FileHandle\r
-)\r
+  IN   EFI_FILE_HANDLE  FileHandle\r
+  )\r
 {\r
   EFI_STATUS                     Status;\r
   EFI_VARIABLE_AUTHENTICATION_2  *Auth2;\r
@@ -183,9 +184,9 @@ IsAuthentication2Format (
   //\r
   // Read the whole file content\r
   //\r
-  Status = ReadFileContent(\r
+  Status = ReadFileContent (\r
              FileHandle,\r
-             (VOID **) &mImageBase,\r
+             (VOID **)&mImageBase,\r
              &mImageSize,\r
              0\r
              );\r
@@ -198,7 +199,7 @@ IsAuthentication2Format (
     goto ON_EXIT;\r
   }\r
 \r
-  if (CompareGuid(&gEfiCertPkcs7Guid, &Auth2->AuthInfo.CertType)) {\r
+  if (CompareGuid (&gEfiCertPkcs7Guid, &Auth2->AuthInfo.CertType)) {\r
     IsAuth2Format = TRUE;\r
   }\r
 \r
@@ -225,18 +226,18 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 SaveSecureBootVariable (\r
-  IN UINT8                         VarValue\r
+  IN UINT8  VarValue\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = gRT->SetVariable (\r
-             EFI_SECURE_BOOT_ENABLE_NAME,\r
-             &gEfiSecureBootEnableDisableGuid,\r
-             EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,\r
-             sizeof (UINT8),\r
-             &VarValue\r
-             );\r
+                  EFI_SECURE_BOOT_ENABLE_NAME,\r
+                  &gEfiSecureBootEnableDisableGuid,\r
+                  EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,\r
+                  sizeof (UINT8),\r
+                  &VarValue\r
+                  );\r
   return Status;\r
 }\r
 \r
@@ -255,27 +256,27 @@ SaveSecureBootVariable (
 **/\r
 EFI_STATUS\r
 CheckX509Certificate (\r
-  IN    SECUREBOOT_FILE_CONTEXT*    X509FileContext,\r
-  OUT   ENROLL_KEY_ERROR*           Error\r
-)\r
+  IN    SECUREBOOT_FILE_CONTEXT  *X509FileContext,\r
+  OUT   ENROLL_KEY_ERROR         *Error\r
+  )\r
 {\r
-  EFI_STATUS     Status;\r
-  UINT16*        FilePostFix;\r
-  UINTN          NameLength;\r
-  UINT8*         X509Data;\r
-  UINTN          X509DataSize;\r
-  void*          X509PubKey;\r
-  UINTN          PubKeyModSize;\r
+  EFI_STATUS  Status;\r
+  UINT16      *FilePostFix;\r
+  UINTN       NameLength;\r
+  UINT8       *X509Data;\r
+  UINTN       X509DataSize;\r
+  void        *X509PubKey;\r
+  UINTN       PubKeyModSize;\r
 \r
   if (X509FileContext->FileName == NULL) {\r
     *Error = Unsupported_Type;\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  X509Data       = NULL;\r
-  X509DataSize   = 0;\r
-  X509PubKey     = NULL;\r
-  PubKeyModSize  = 0;\r
+  X509Data      = NULL;\r
+  X509DataSize  = 0;\r
+  X509PubKey    = NULL;\r
+  PubKeyModSize = 0;\r
 \r
   //\r
   // Parse the file's postfix. Only support DER encoded X.509 certificate files.\r
@@ -286,19 +287,21 @@ CheckX509Certificate (
     *Error = Unsupported_Type;\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   FilePostFix = X509FileContext->FileName + NameLength - 4;\r
   if (!IsDerEncodeCertificate (FilePostFix)) {\r
     DEBUG ((DEBUG_ERROR, "Unsupported file type, only DER encoded certificate (%s) is supported.\n", mSupportX509Suffix));\r
     *Error = Unsupported_Type;\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   DEBUG ((DEBUG_INFO, "FileName= %s\n", X509FileContext->FileName));\r
   DEBUG ((DEBUG_INFO, "FilePostFix = %s\n", FilePostFix));\r
 \r
   //\r
   // Read the certificate file content\r
   //\r
-  Status = ReadFileContent (X509FileContext->FHandle, (VOID**) &X509Data, &X509DataSize, 0);\r
+  Status = ReadFileContent (X509FileContext->FHandle, (VOID **)&X509Data, &X509DataSize, 0);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Error occured while reading the file.\n"));\r
     goto ON_EXIT;\r
@@ -325,10 +328,11 @@ CheckX509Certificate (
       Status = EFI_INVALID_PARAMETER;\r
       *Error = Unqualified_Key;\r
     }\r
+\r
     RsaFree (X509PubKey);\r
   }\r
 \r
- ON_EXIT:\r
+ON_EXIT:\r
   if (X509Data != NULL) {\r
     FreePool (X509Data);\r
   }\r
@@ -348,47 +352,48 @@ CheckX509Certificate (
 **/\r
 EFI_STATUS\r
 CreatePkX509SignatureList (\r
-  IN    EFI_FILE_HANDLE             X509File,\r
-  OUT   EFI_SIGNATURE_LIST          **PkCert\r
+  IN    EFI_FILE_HANDLE     X509File,\r
+  OUT   EFI_SIGNATURE_LIST  **PkCert\r
   )\r
 {\r
-  EFI_STATUS              Status;\r
-  UINT8                   *X509Data;\r
-  UINTN                   X509DataSize;\r
-  EFI_SIGNATURE_DATA      *PkCertData;\r
+  EFI_STATUS          Status;\r
+  UINT8               *X509Data;\r
+  UINTN               X509DataSize;\r
+  EFI_SIGNATURE_DATA  *PkCertData;\r
 \r
-  X509Data = NULL;\r
-  PkCertData = NULL;\r
+  X509Data     = NULL;\r
+  PkCertData   = NULL;\r
   X509DataSize = 0;\r
 \r
-  Status = ReadFileContent (X509File, (VOID**) &X509Data, &X509DataSize, 0);\r
+  Status = ReadFileContent (X509File, (VOID **)&X509Data, &X509DataSize, 0);\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
+\r
   ASSERT (X509Data != NULL);\r
 \r
   //\r
   // Allocate space for PK certificate list and initialize it.\r
   // Create PK database entry with SignatureHeaderSize equals 0.\r
   //\r
-  *PkCert = (EFI_SIGNATURE_LIST*) AllocateZeroPool (\r
-              sizeof(EFI_SIGNATURE_LIST) + sizeof(EFI_SIGNATURE_DATA) - 1\r
-              + X509DataSize\r
-              );\r
+  *PkCert = (EFI_SIGNATURE_LIST *)AllocateZeroPool (\r
+                                    sizeof (EFI_SIGNATURE_LIST) + sizeof (EFI_SIGNATURE_DATA) - 1\r
+                                    + X509DataSize\r
+                                    );\r
   if (*PkCert == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
 \r
-  (*PkCert)->SignatureListSize   = (UINT32) (sizeof(EFI_SIGNATURE_LIST)\r
-                                    + sizeof(EFI_SIGNATURE_DATA) - 1\r
-                                    + X509DataSize);\r
-  (*PkCert)->SignatureSize       = (UINT32) (sizeof(EFI_SIGNATURE_DATA) - 1 + X509DataSize);\r
+  (*PkCert)->SignatureListSize = (UINT32)(sizeof (EFI_SIGNATURE_LIST)\r
+                                          + sizeof (EFI_SIGNATURE_DATA) - 1\r
+                                          + X509DataSize);\r
+  (*PkCert)->SignatureSize       = (UINT32)(sizeof (EFI_SIGNATURE_DATA) - 1 + X509DataSize);\r
   (*PkCert)->SignatureHeaderSize = 0;\r
   CopyGuid (&(*PkCert)->SignatureType, &gEfiCertX509Guid);\r
-  PkCertData                     = (EFI_SIGNATURE_DATA*) ((UINTN)(*PkCert)\r
-                                                          + sizeof(EFI_SIGNATURE_LIST)\r
-                                                          + (*PkCert)->SignatureHeaderSize);\r
+  PkCertData = (EFI_SIGNATURE_DATA *)((UINTN)(*PkCert)\r
+                                      + sizeof (EFI_SIGNATURE_LIST)\r
+                                      + (*PkCert)->SignatureHeaderSize);\r
   CopyGuid (&PkCertData->SignatureOwner, &gEfiGlobalVariableGuid);\r
   //\r
   // Fill the PK database with PKpub data from X509 certificate file.\r
@@ -401,7 +406,7 @@ ON_EXIT:
     FreePool (X509Data);\r
   }\r
 \r
-  if (EFI_ERROR(Status) && *PkCert != NULL) {\r
+  if (EFI_ERROR (Status) && (*PkCert != NULL)) {\r
     FreePool (*PkCert);\r
     *PkCert = NULL;\r
   }\r
@@ -423,17 +428,17 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 EnrollPlatformKey (\r
-   IN  SECUREBOOT_CONFIG_PRIVATE_DATA*   Private\r
+  IN  SECUREBOOT_CONFIG_PRIVATE_DATA  *Private\r
   )\r
 {\r
-  EFI_STATUS                      Status;\r
-  UINT32                          Attr;\r
-  UINTN                           DataSize;\r
-  EFI_SIGNATURE_LIST              *PkCert;\r
+  EFI_STATUS          Status;\r
+  UINT32              Attr;\r
+  UINTN               DataSize;\r
+  EFI_SIGNATURE_LIST  *PkCert;\r
 \r
   PkCert = NULL;\r
 \r
-  Status = SetSecureBootMode(CUSTOM_SECURE_BOOT_MODE);\r
+  Status = SetSecureBootMode (CUSTOM_SECURE_BOOT_MODE);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -442,27 +447,28 @@ EnrollPlatformKey (
   // Prase the selected PK file and generate PK certificate list.\r
   //\r
   Status = CreatePkX509SignatureList (\r
-            Private->FileContext->FHandle,\r
-            &PkCert\r
-            );\r
+             Private->FileContext->FHandle,\r
+             &PkCert\r
+             );\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
+\r
   ASSERT (PkCert != NULL);\r
 \r
   //\r
   // Set Platform Key variable.\r
   //\r
   Attr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS\r
-          | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
+         | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
   DataSize = PkCert->SignatureListSize;\r
-  Status = CreateTimeBasedPayload (&DataSize, (UINT8**) &PkCert);\r
+  Status   = CreateTimeBasedPayload (&DataSize, (UINT8 **)&PkCert);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Fail to create time-based data payload: %r", Status));\r
     goto ON_EXIT;\r
   }\r
 \r
-  Status = gRT->SetVariable(\r
+  Status = gRT->SetVariable (\r
                   EFI_PLATFORM_KEY_NAME,\r
                   &gEfiGlobalVariableGuid,\r
                   Attr,\r
@@ -473,16 +479,17 @@ EnrollPlatformKey (
     if (Status == EFI_OUT_OF_RESOURCES) {\r
       DEBUG ((DEBUG_ERROR, "Enroll PK failed with out of resource.\n"));\r
     }\r
+\r
     goto ON_EXIT;\r
   }\r
 \r
 ON_EXIT:\r
 \r
   if (PkCert != NULL) {\r
-    FreePool(PkCert);\r
+    FreePool (PkCert);\r
   }\r
 \r
-  CloseEnrolledFile(Private->FileContext);\r
+  CloseEnrolledFile (Private->FileContext);\r
 \r
   return Status;\r
 }\r
@@ -500,29 +507,29 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 EnrollRsa2048ToKek (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *Private\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private\r
   )\r
 {\r
-  EFI_STATUS                      Status;\r
-  UINT32                          Attr;\r
-  UINTN                           DataSize;\r
-  EFI_SIGNATURE_LIST              *KekSigList;\r
-  UINTN                           KeyBlobSize;\r
-  UINT8                           *KeyBlob;\r
-  CPL_KEY_INFO                    *KeyInfo;\r
-  EFI_SIGNATURE_DATA              *KEKSigData;\r
-  UINTN                           KekSigListSize;\r
-  UINT8                           *KeyBuffer;\r
-  UINTN                           KeyLenInBytes;\r
-\r
-  Attr        = 0;\r
-  DataSize    = 0;\r
-  KeyBuffer   = NULL;\r
-  KeyBlobSize = 0;\r
-  KeyBlob     = NULL;\r
-  KeyInfo     = NULL;\r
-  KEKSigData  = NULL;\r
-  KekSigList  = NULL;\r
+  EFI_STATUS          Status;\r
+  UINT32              Attr;\r
+  UINTN               DataSize;\r
+  EFI_SIGNATURE_LIST  *KekSigList;\r
+  UINTN               KeyBlobSize;\r
+  UINT8               *KeyBlob;\r
+  CPL_KEY_INFO        *KeyInfo;\r
+  EFI_SIGNATURE_DATA  *KEKSigData;\r
+  UINTN               KekSigListSize;\r
+  UINT8               *KeyBuffer;\r
+  UINTN               KeyLenInBytes;\r
+\r
+  Attr           = 0;\r
+  DataSize       = 0;\r
+  KeyBuffer      = NULL;\r
+  KeyBlobSize    = 0;\r
+  KeyBlob        = NULL;\r
+  KeyInfo        = NULL;\r
+  KEKSigData     = NULL;\r
+  KekSigList     = NULL;\r
   KekSigListSize = 0;\r
 \r
   //\r
@@ -531,15 +538,16 @@ EnrollRsa2048ToKek (
   //\r
   Status = ReadFileContent (\r
              Private->FileContext->FHandle,\r
-             (VOID**) &KeyBlob,\r
+             (VOID **)&KeyBlob,\r
              &KeyBlobSize,\r
              0\r
              );\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
+\r
   ASSERT (KeyBlob != NULL);\r
-  KeyInfo = (CPL_KEY_INFO *) KeyBlob;\r
+  KeyInfo = (CPL_KEY_INFO *)KeyBlob;\r
   if (KeyInfo->KeyLengthInBits / 8 != WIN_CERT_UEFI_RSA2048_SIZE) {\r
     DEBUG ((DEBUG_ERROR, "Unsupported key length, Only RSA2048 is supported.\n"));\r
     Status = EFI_UNSUPPORTED;\r
@@ -550,44 +558,45 @@ EnrollRsa2048ToKek (
   // Convert the Public key to fix octet string format represented in RSA PKCS#1.\r
   //\r
   KeyLenInBytes = KeyInfo->KeyLengthInBits / 8;\r
-  KeyBuffer = AllocateZeroPool (KeyLenInBytes);\r
+  KeyBuffer     = AllocateZeroPool (KeyLenInBytes);\r
   if (KeyBuffer == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
+\r
   Int2OctStr (\r
-    (UINTN*) (KeyBlob + sizeof (CPL_KEY_INFO)),\r
+    (UINTN *)(KeyBlob + sizeof (CPL_KEY_INFO)),\r
     KeyLenInBytes / sizeof (UINTN),\r
     KeyBuffer,\r
     KeyLenInBytes\r
     );\r
-  CopyMem(KeyBlob + sizeof(CPL_KEY_INFO), KeyBuffer, KeyLenInBytes);\r
+  CopyMem (KeyBlob + sizeof (CPL_KEY_INFO), KeyBuffer, KeyLenInBytes);\r
 \r
   //\r
   // Form an new EFI_SIGNATURE_LIST.\r
   //\r
-  KekSigListSize = sizeof(EFI_SIGNATURE_LIST)\r
-                     + sizeof(EFI_SIGNATURE_DATA) - 1\r
-                     + WIN_CERT_UEFI_RSA2048_SIZE;\r
+  KekSigListSize = sizeof (EFI_SIGNATURE_LIST)\r
+                   + sizeof (EFI_SIGNATURE_DATA) - 1\r
+                   + WIN_CERT_UEFI_RSA2048_SIZE;\r
 \r
-  KekSigList = (EFI_SIGNATURE_LIST*) AllocateZeroPool (KekSigListSize);\r
+  KekSigList = (EFI_SIGNATURE_LIST *)AllocateZeroPool (KekSigListSize);\r
   if (KekSigList == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
 \r
-  KekSigList->SignatureListSize   = sizeof(EFI_SIGNATURE_LIST)\r
-                                  + sizeof(EFI_SIGNATURE_DATA) - 1\r
+  KekSigList->SignatureListSize = sizeof (EFI_SIGNATURE_LIST)\r
+                                  + sizeof (EFI_SIGNATURE_DATA) - 1\r
                                   + WIN_CERT_UEFI_RSA2048_SIZE;\r
   KekSigList->SignatureHeaderSize = 0;\r
-  KekSigList->SignatureSize = sizeof(EFI_SIGNATURE_DATA) - 1 + WIN_CERT_UEFI_RSA2048_SIZE;\r
+  KekSigList->SignatureSize       = sizeof (EFI_SIGNATURE_DATA) - 1 + WIN_CERT_UEFI_RSA2048_SIZE;\r
   CopyGuid (&KekSigList->SignatureType, &gEfiCertRsa2048Guid);\r
 \r
-  KEKSigData = (EFI_SIGNATURE_DATA*)((UINT8*)KekSigList + sizeof(EFI_SIGNATURE_LIST));\r
+  KEKSigData = (EFI_SIGNATURE_DATA *)((UINT8 *)KekSigList + sizeof (EFI_SIGNATURE_LIST));\r
   CopyGuid (&KEKSigData->SignatureOwner, Private->SignatureGUID);\r
   CopyMem (\r
     KEKSigData->SignatureData,\r
-    KeyBlob + sizeof(CPL_KEY_INFO),\r
+    KeyBlob + sizeof (CPL_KEY_INFO),\r
     WIN_CERT_UEFI_RSA2048_SIZE\r
     );\r
 \r
@@ -598,13 +607,13 @@ EnrollRsa2048ToKek (
   //\r
   Attr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS\r
          | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
-  Status = CreateTimeBasedPayload (&KekSigListSize, (UINT8**) &KekSigList);\r
+  Status = CreateTimeBasedPayload (&KekSigListSize, (UINT8 **)&KekSigList);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Fail to create time-based data payload: %r", Status));\r
     goto ON_EXIT;\r
   }\r
 \r
-  Status = gRT->GetVariable(\r
+  Status = gRT->GetVariable (\r
                   EFI_KEY_EXCHANGE_KEY_NAME,\r
                   &gEfiGlobalVariableGuid,\r
                   NULL,\r
@@ -620,7 +629,7 @@ EnrollRsa2048ToKek (
   //\r
   // Done. Now we have formed the correct KEKpub database item, just set it into variable storage,\r
   //\r
-  Status = gRT->SetVariable(\r
+  Status = gRT->SetVariable (\r
                   EFI_KEY_EXCHANGE_KEY_NAME,\r
                   &gEfiGlobalVariableGuid,\r
                   Attr,\r
@@ -633,7 +642,7 @@ EnrollRsa2048ToKek (
 \r
 ON_EXIT:\r
 \r
-  CloseEnrolledFile(Private->FileContext);\r
+  CloseEnrolledFile (Private->FileContext);\r
 \r
   if (Private->SignatureGUID != NULL) {\r
     FreePool (Private->SignatureGUID);\r
@@ -643,9 +652,11 @@ ON_EXIT:
   if (KeyBlob != NULL) {\r
     FreePool (KeyBlob);\r
   }\r
+\r
   if (KeyBuffer != NULL) {\r
     FreePool (KeyBuffer);\r
   }\r
+\r
   if (KekSigList != NULL) {\r
     FreePool (KekSigList);\r
   }\r
@@ -666,17 +677,17 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 EnrollX509ToKek (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *Private\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINTN                             X509DataSize;\r
-  VOID                              *X509Data;\r
-  EFI_SIGNATURE_DATA                *KEKSigData;\r
-  EFI_SIGNATURE_LIST                *KekSigList;\r
-  UINTN                             DataSize;\r
-  UINTN                             KekSigListSize;\r
-  UINT32                            Attr;\r
+  EFI_STATUS          Status;\r
+  UINTN               X509DataSize;\r
+  VOID                *X509Data;\r
+  EFI_SIGNATURE_DATA  *KEKSigData;\r
+  EFI_SIGNATURE_LIST  *KekSigList;\r
+  UINTN               DataSize;\r
+  UINTN               KekSigListSize;\r
+  UINT32              Attr;\r
 \r
   X509Data       = NULL;\r
   X509DataSize   = 0;\r
@@ -694,10 +705,11 @@ EnrollX509ToKek (
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
+\r
   ASSERT (X509Data != NULL);\r
 \r
-  KekSigListSize = sizeof(EFI_SIGNATURE_LIST) + sizeof(EFI_SIGNATURE_DATA) - 1 + X509DataSize;\r
-  KekSigList = (EFI_SIGNATURE_LIST*) AllocateZeroPool (KekSigListSize);\r
+  KekSigListSize = sizeof (EFI_SIGNATURE_LIST) + sizeof (EFI_SIGNATURE_DATA) - 1 + X509DataSize;\r
+  KekSigList     = (EFI_SIGNATURE_LIST *)AllocateZeroPool (KekSigListSize);\r
   if (KekSigList == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
@@ -706,12 +718,12 @@ EnrollX509ToKek (
   //\r
   // Fill Certificate Database parameters.\r
   //\r
-  KekSigList->SignatureListSize   = (UINT32) KekSigListSize;\r
+  KekSigList->SignatureListSize   = (UINT32)KekSigListSize;\r
   KekSigList->SignatureHeaderSize = 0;\r
-  KekSigList->SignatureSize = (UINT32) (sizeof(EFI_SIGNATURE_DATA) - 1 + X509DataSize);\r
+  KekSigList->SignatureSize       = (UINT32)(sizeof (EFI_SIGNATURE_DATA) - 1 + X509DataSize);\r
   CopyGuid (&KekSigList->SignatureType, &gEfiCertX509Guid);\r
 \r
-  KEKSigData = (EFI_SIGNATURE_DATA*) ((UINT8*) KekSigList + sizeof (EFI_SIGNATURE_LIST));\r
+  KEKSigData = (EFI_SIGNATURE_DATA *)((UINT8 *)KekSigList + sizeof (EFI_SIGNATURE_LIST));\r
   CopyGuid (&KEKSigData->SignatureOwner, Private->SignatureGUID);\r
   CopyMem (KEKSigData->SignatureData, X509Data, X509DataSize);\r
 \r
@@ -721,14 +733,14 @@ EnrollX509ToKek (
   // new kek to original variable\r
   //\r
   Attr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS\r
-          | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
-  Status = CreateTimeBasedPayload (&KekSigListSize, (UINT8**) &KekSigList);\r
+         | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
+  Status = CreateTimeBasedPayload (&KekSigListSize, (UINT8 **)&KekSigList);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Fail to create time-based data payload: %r", Status));\r
     goto ON_EXIT;\r
   }\r
 \r
-  Status = gRT->GetVariable(\r
+  Status = gRT->GetVariable (\r
                   EFI_KEY_EXCHANGE_KEY_NAME,\r
                   &gEfiGlobalVariableGuid,\r
                   NULL,\r
@@ -741,7 +753,7 @@ EnrollX509ToKek (
     goto ON_EXIT;\r
   }\r
 \r
-  Status = gRT->SetVariable(\r
+  Status = gRT->SetVariable (\r
                   EFI_KEY_EXCHANGE_KEY_NAME,\r
                   &gEfiGlobalVariableGuid,\r
                   Attr,\r
@@ -754,7 +766,7 @@ EnrollX509ToKek (
 \r
 ON_EXIT:\r
 \r
-  CloseEnrolledFile(Private->FileContext);\r
+  CloseEnrolledFile (Private->FileContext);\r
 \r
   if (Private->SignatureGUID != NULL) {\r
     FreePool (Private->SignatureGUID);\r
@@ -781,10 +793,10 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 EnrollKeyExchangeKey (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *Private\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private\r
   )\r
 {\r
-  UINT16*     FilePostFix;\r
+  UINT16      *FilePostFix;\r
   EFI_STATUS  Status;\r
   UINTN       NameLength;\r
 \r
@@ -792,7 +804,7 @@ EnrollKeyExchangeKey (
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  Status = SetSecureBootMode(CUSTOM_SECURE_BOOT_MODE);\r
+  Status = SetSecureBootMode (CUSTOM_SECURE_BOOT_MODE);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -805,16 +817,17 @@ EnrollKeyExchangeKey (
   if (NameLength <= 4) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   FilePostFix = Private->FileContext->FileName + NameLength - 4;\r
-  if (IsDerEncodeCertificate(FilePostFix)) {\r
+  if (IsDerEncodeCertificate (FilePostFix)) {\r
     return EnrollX509ToKek (Private);\r
-  } else if (CompareMem (FilePostFix, L".pbk",4) == 0) {\r
+  } else if (CompareMem (FilePostFix, L".pbk", 4) == 0) {\r
     return EnrollRsa2048ToKek (Private);\r
   } else {\r
     //\r
     // File type is wrong, simply close it\r
     //\r
-    CloseEnrolledFile(Private->FileContext);\r
+    CloseEnrolledFile (Private->FileContext);\r
 \r
     return EFI_INVALID_PARAMETER;\r
   }\r
@@ -834,19 +847,19 @@ EnrollKeyExchangeKey (
 **/\r
 EFI_STATUS\r
 EnrollX509toSigDB (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *Private,\r
-  IN CHAR16                         *VariableName\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private,\r
+  IN CHAR16                          *VariableName\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINTN                             X509DataSize;\r
-  VOID                              *X509Data;\r
-  EFI_SIGNATURE_LIST                *SigDBCert;\r
-  EFI_SIGNATURE_DATA                *SigDBCertData;\r
-  VOID                              *Data;\r
-  UINTN                             DataSize;\r
-  UINTN                             SigDBSize;\r
-  UINT32                            Attr;\r
+  EFI_STATUS          Status;\r
+  UINTN               X509DataSize;\r
+  VOID                *X509Data;\r
+  EFI_SIGNATURE_LIST  *SigDBCert;\r
+  EFI_SIGNATURE_DATA  *SigDBCertData;\r
+  VOID                *Data;\r
+  UINTN               DataSize;\r
+  UINTN               SigDBSize;\r
+  UINT32              Attr;\r
 \r
   X509DataSize  = 0;\r
   SigDBSize     = 0;\r
@@ -865,9 +878,10 @@ EnrollX509toSigDB (
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
+\r
   ASSERT (X509Data != NULL);\r
 \r
-  SigDBSize = sizeof(EFI_SIGNATURE_LIST) + sizeof(EFI_SIGNATURE_DATA) - 1 + X509DataSize;\r
+  SigDBSize = sizeof (EFI_SIGNATURE_LIST) + sizeof (EFI_SIGNATURE_DATA) - 1 + X509DataSize;\r
 \r
   Data = AllocateZeroPool (SigDBSize);\r
   if (Data == NULL) {\r
@@ -878,15 +892,15 @@ EnrollX509toSigDB (
   //\r
   // Fill Certificate Database parameters.\r
   //\r
-  SigDBCert = (EFI_SIGNATURE_LIST*) Data;\r
-  SigDBCert->SignatureListSize   = (UINT32) SigDBSize;\r
+  SigDBCert                      = (EFI_SIGNATURE_LIST *)Data;\r
+  SigDBCert->SignatureListSize   = (UINT32)SigDBSize;\r
   SigDBCert->SignatureHeaderSize = 0;\r
-  SigDBCert->SignatureSize = (UINT32) (sizeof(EFI_SIGNATURE_DATA) - 1 + X509DataSize);\r
+  SigDBCert->SignatureSize       = (UINT32)(sizeof (EFI_SIGNATURE_DATA) - 1 + X509DataSize);\r
   CopyGuid (&SigDBCert->SignatureType, &gEfiCertX509Guid);\r
 \r
-  SigDBCertData = (EFI_SIGNATURE_DATA*) ((UINT8* ) SigDBCert + sizeof (EFI_SIGNATURE_LIST));\r
+  SigDBCertData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigDBCert + sizeof (EFI_SIGNATURE_LIST));\r
   CopyGuid (&SigDBCertData->SignatureOwner, Private->SignatureGUID);\r
-  CopyMem ((UINT8* ) (SigDBCertData->SignatureData), X509Data, X509DataSize);\r
+  CopyMem ((UINT8 *)(SigDBCertData->SignatureData), X509Data, X509DataSize);\r
 \r
   //\r
   // Check if signature database entry has been already existed.\r
@@ -894,14 +908,14 @@ EnrollX509toSigDB (
   // new signature data to original variable\r
   //\r
   Attr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS\r
-          | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
-  Status = CreateTimeBasedPayload (&SigDBSize, (UINT8**) &Data);\r
+         | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
+  Status = CreateTimeBasedPayload (&SigDBSize, (UINT8 **)&Data);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Fail to create time-based data payload: %r", Status));\r
     goto ON_EXIT;\r
   }\r
 \r
-  Status = gRT->GetVariable(\r
+  Status = gRT->GetVariable (\r
                   VariableName,\r
                   &gEfiImageSecurityDatabaseGuid,\r
                   NULL,\r
@@ -914,7 +928,7 @@ EnrollX509toSigDB (
     goto ON_EXIT;\r
   }\r
 \r
-  Status = gRT->SetVariable(\r
+  Status = gRT->SetVariable (\r
                   VariableName,\r
                   &gEfiImageSecurityDatabaseGuid,\r
                   Attr,\r
@@ -927,7 +941,7 @@ EnrollX509toSigDB (
 \r
 ON_EXIT:\r
 \r
-  CloseEnrolledFile(Private->FileContext);\r
+  CloseEnrolledFile (Private->FileContext);\r
 \r
   if (Private->SignatureGUID != NULL) {\r
     FreePool (Private->SignatureGUID);\r
@@ -958,9 +972,9 @@ ON_EXIT:
 **/\r
 BOOLEAN\r
 IsSignatureFoundInDatabase (\r
-  IN CHAR16             *VariableName,\r
-  IN UINT8              *Signature,\r
-  IN UINTN              SignatureSize\r
+  IN CHAR16  *VariableName,\r
+  IN UINT8   *Signature,\r
+  IN UINTN   SignatureSize\r
   )\r
 {\r
   EFI_STATUS          Status;\r
@@ -975,15 +989,15 @@ IsSignatureFoundInDatabase (
   //\r
   // Read signature database variable.\r
   //\r
-  IsFound   = FALSE;\r
-  Data      = NULL;\r
-  DataSize  = 0;\r
-  Status    = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, NULL);\r
+  IsFound  = FALSE;\r
+  Data     = NULL;\r
+  DataSize = 0;\r
+  Status   = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, NULL);\r
   if (Status != EFI_BUFFER_TOO_SMALL) {\r
     return FALSE;\r
   }\r
 \r
-  Data = (UINT8 *) AllocateZeroPool (DataSize);\r
+  Data = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (Data == NULL) {\r
     return FALSE;\r
   }\r
@@ -996,11 +1010,11 @@ IsSignatureFoundInDatabase (
   //\r
   // Enumerate all signature data in SigDB to check if signature exists for executable.\r
   //\r
-  CertList = (EFI_SIGNATURE_LIST *) Data;\r
+  CertList = (EFI_SIGNATURE_LIST *)Data;\r
   while ((DataSize > 0) && (DataSize >= CertList->SignatureListSize)) {\r
     CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
-    Cert      = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
-    if ((CertList->SignatureSize == sizeof(EFI_SIGNATURE_DATA) - 1 + SignatureSize) && (CompareGuid(&CertList->SignatureType, &gEfiCertX509Guid))) {\r
+    Cert      = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+    if ((CertList->SignatureSize == sizeof (EFI_SIGNATURE_DATA) - 1 + SignatureSize) && (CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid))) {\r
       for (Index = 0; Index < CertCount; Index++) {\r
         if (CompareMem (Cert->SignatureData, Signature, SignatureSize) == 0) {\r
           //\r
@@ -1009,7 +1023,8 @@ IsSignatureFoundInDatabase (
           IsFound = TRUE;\r
           break;\r
         }\r
-        Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) Cert + CertList->SignatureSize);\r
+\r
+        Cert = (EFI_SIGNATURE_DATA *)((UINT8 *)Cert + CertList->SignatureSize);\r
       }\r
 \r
       if (IsFound) {\r
@@ -1018,7 +1033,7 @@ IsSignatureFoundInDatabase (
     }\r
 \r
     DataSize -= CertList->SignatureListSize;\r
-    CertList  = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList  = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
 Done:\r
@@ -1043,17 +1058,17 @@ Done:
 **/\r
 BOOLEAN\r
 CalculateCertHash (\r
-  IN  UINT8                 *CertData,\r
-  IN  UINTN                 CertSize,\r
-  IN  UINT32                HashAlg,\r
-  OUT UINT8                 *CertHash\r
+  IN  UINT8   *CertData,\r
+  IN  UINTN   CertSize,\r
+  IN  UINT32  HashAlg,\r
+  OUT UINT8   *CertHash\r
   )\r
 {\r
-  BOOLEAN                   Status;\r
-  VOID                      *HashCtx;\r
-  UINTN                     CtxSize;\r
-  UINT8                     *TBSCert;\r
-  UINTN                     TBSCertSize;\r
+  BOOLEAN  Status;\r
+  VOID     *HashCtx;\r
+  UINTN    CtxSize;\r
+  UINT8    *TBSCert;\r
+  UINTN    TBSCertSize;\r
 \r
   HashCtx = NULL;\r
   Status  = FALSE;\r
@@ -1087,7 +1102,7 @@ CalculateCertHash (
   //\r
   // 3. Calculate the hash.\r
   //\r
-  Status  = mHash[HashAlg].HashUpdate (HashCtx, TBSCert, TBSCertSize);\r
+  Status = mHash[HashAlg].HashUpdate (HashCtx, TBSCert, TBSCertSize);\r
   if (!Status) {\r
     goto Done;\r
   }\r
@@ -1096,7 +1111,7 @@ CalculateCertHash (
   // 4. Get the hash result.\r
   //\r
   ZeroMem (CertHash, mHash[HashAlg].DigestLength);\r
-  Status  = mHash[HashAlg].HashFinal (HashCtx, CertHash);\r
+  Status = mHash[HashAlg].HashFinal (HashCtx, CertHash);\r
 \r
 Done:\r
   if (HashCtx != NULL) {\r
@@ -1118,37 +1133,37 @@ Done:
 **/\r
 BOOLEAN\r
 IsCertHashFoundInDbx (\r
-  IN  UINT8               *Certificate,\r
-  IN  UINTN               CertSize\r
+  IN  UINT8  *Certificate,\r
+  IN  UINTN  CertSize\r
   )\r
 {\r
-  BOOLEAN                 IsFound;\r
-  EFI_STATUS              Status;\r
-  EFI_SIGNATURE_LIST      *DbxList;\r
-  EFI_SIGNATURE_DATA      *CertHash;\r
-  UINTN                   CertHashCount;\r
-  UINTN                   Index;\r
-  UINT32                  HashAlg;\r
-  UINT8                   CertDigest[MAX_DIGEST_SIZE];\r
-  UINT8                   *DbxCertHash;\r
-  UINTN                   SiglistHeaderSize;\r
-  UINT8                   *Data;\r
-  UINTN                   DataSize;\r
+  BOOLEAN             IsFound;\r
+  EFI_STATUS          Status;\r
+  EFI_SIGNATURE_LIST  *DbxList;\r
+  EFI_SIGNATURE_DATA  *CertHash;\r
+  UINTN               CertHashCount;\r
+  UINTN               Index;\r
+  UINT32              HashAlg;\r
+  UINT8               CertDigest[MAX_DIGEST_SIZE];\r
+  UINT8               *DbxCertHash;\r
+  UINTN               SiglistHeaderSize;\r
+  UINT8               *Data;\r
+  UINTN               DataSize;\r
 \r
-  IsFound  = FALSE;\r
-  HashAlg  = HASHALG_MAX;\r
-  Data     = NULL;\r
+  IsFound = FALSE;\r
+  HashAlg = HASHALG_MAX;\r
+  Data    = NULL;\r
 \r
   //\r
   // Read signature database variable.\r
   //\r
-  DataSize  = 0;\r
-  Status    = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, NULL);\r
+  DataSize = 0;\r
+  Status   = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, NULL);\r
   if (Status != EFI_BUFFER_TOO_SMALL) {\r
     return FALSE;\r
   }\r
 \r
-  Data = (UINT8 *) AllocateZeroPool (DataSize);\r
+  Data = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (Data == NULL) {\r
     return FALSE;\r
   }\r
@@ -1161,7 +1176,7 @@ IsCertHashFoundInDbx (
   //\r
   // Check whether the certificate hash exists in the forbidden database.\r
   //\r
-  DbxList = (EFI_SIGNATURE_LIST *) Data;\r
+  DbxList = (EFI_SIGNATURE_LIST *)Data;\r
   while ((DataSize > 0) && (DataSize >= DbxList->SignatureListSize)) {\r
     //\r
     // Determine Hash Algorithm of Certificate in the forbidden database.\r
@@ -1174,7 +1189,7 @@ IsCertHashFoundInDbx (
       HashAlg = HASHALG_SHA512;\r
     } else {\r
       DataSize -= DbxList->SignatureListSize;\r
-      DbxList   = (EFI_SIGNATURE_LIST *) ((UINT8 *) DbxList + DbxList->SignatureListSize);\r
+      DbxList   = (EFI_SIGNATURE_LIST *)((UINT8 *)DbxList + DbxList->SignatureListSize);\r
       continue;\r
     }\r
 \r
@@ -1186,7 +1201,7 @@ IsCertHashFoundInDbx (
     }\r
 \r
     SiglistHeaderSize = sizeof (EFI_SIGNATURE_LIST) + DbxList->SignatureHeaderSize;\r
-    CertHash          = (EFI_SIGNATURE_DATA *) ((UINT8 *) DbxList + SiglistHeaderSize);\r
+    CertHash          = (EFI_SIGNATURE_DATA *)((UINT8 *)DbxList + SiglistHeaderSize);\r
     CertHashCount     = (DbxList->SignatureListSize - SiglistHeaderSize) / DbxList->SignatureSize;\r
     for (Index = 0; Index < CertHashCount; Index++) {\r
       //\r
@@ -1200,11 +1215,12 @@ IsCertHashFoundInDbx (
         IsFound = TRUE;\r
         goto Done;\r
       }\r
-      CertHash = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertHash + DbxList->SignatureSize);\r
+\r
+      CertHash = (EFI_SIGNATURE_DATA *)((UINT8 *)CertHash + DbxList->SignatureSize);\r
     }\r
 \r
     DataSize -= DbxList->SignatureListSize;\r
-    DbxList   = (EFI_SIGNATURE_LIST *) ((UINT8 *) DbxList + DbxList->SignatureListSize);\r
+    DbxList   = (EFI_SIGNATURE_LIST *)((UINT8 *)DbxList + DbxList->SignatureListSize);\r
   }\r
 \r
 Done:\r
@@ -1238,8 +1254,8 @@ GetSignaturelistOffset (
   OUT UINTN               *Offset\r
   )\r
 {\r
-  EFI_SIGNATURE_LIST      *SigList;\r
-  UINTN                   SiglistSize;\r
+  EFI_SIGNATURE_LIST  *SigList;\r
+  UINTN               SiglistSize;\r
 \r
   if ((Database == NULL) || (DatabaseSize == 0)) {\r
     *Offset = 0;\r
@@ -1253,9 +1269,11 @@ GetSignaturelistOffset (
       *Offset = DatabaseSize - SiglistSize;\r
       return TRUE;\r
     }\r
+\r
     SiglistSize -= SigList->SignatureListSize;\r
-    SigList      = (EFI_SIGNATURE_LIST *) ((UINT8 *) SigList + SigList->SignatureListSize);\r
+    SigList      = (EFI_SIGNATURE_LIST *)((UINT8 *)SigList + SigList->SignatureListSize);\r
   }\r
+\r
   *Offset = 0;\r
   return FALSE;\r
 }\r
@@ -1277,11 +1295,11 @@ GetSignaturelistOffset (
 **/\r
 EFI_STATUS\r
 EnrollX509HashtoSigDB (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *Private,\r
-  IN UINT32                         HashAlg,\r
-  IN EFI_HII_DATE                   *RevocationDate,\r
-  IN EFI_HII_TIME                   *RevocationTime,\r
-  IN BOOLEAN                        AlwaysRevocation\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private,\r
+  IN UINT32                          HashAlg,\r
+  IN EFI_HII_DATE                    *RevocationDate,\r
+  IN EFI_HII_TIME                    *RevocationTime,\r
+  IN BOOLEAN                         AlwaysRevocation\r
   )\r
 {\r
   EFI_STATUS          Status;\r
@@ -1299,7 +1317,7 @@ EnrollX509HashtoSigDB (
   EFI_GUID            SignatureType;\r
   UINTN               Offset;\r
   UINT8               CertHash[MAX_DIGEST_SIZE];\r
-  UINT16*             FilePostFix;\r
+  UINT16              *FilePostFix;\r
   UINTN               NameLength;\r
   EFI_TIME            *Time;\r
 \r
@@ -1327,8 +1345,9 @@ EnrollX509HashtoSigDB (
   if (NameLength <= 4) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   FilePostFix = Private->FileContext->FileName + NameLength - 4;\r
-  if (!IsDerEncodeCertificate(FilePostFix)) {\r
+  if (!IsDerEncodeCertificate (FilePostFix)) {\r
     //\r
     // Only supports DER-encoded X509 certificate.\r
     //\r
@@ -1347,6 +1366,7 @@ EnrollX509HashtoSigDB (
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
+\r
   ASSERT (X509Data != NULL);\r
 \r
   if (!CalculateCertHash (X509Data, X509DataSize, HashAlg, CertHash)) {\r
@@ -1359,7 +1379,7 @@ EnrollX509HashtoSigDB (
   DataSize = 0;\r
   Status   = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, NULL);\r
   if (Status == EFI_BUFFER_TOO_SMALL) {\r
-    Data = (UINT8 *) AllocateZeroPool (DataSize);\r
+    Data = (UINT8 *)AllocateZeroPool (DataSize);\r
     if (Data == NULL) {\r
       return EFI_OUT_OF_RESOURCES;\r
     }\r
@@ -1373,11 +1393,12 @@ EnrollX509HashtoSigDB (
   //\r
   // Allocate memory for Signature and fill the Signature\r
   //\r
-  SignatureSize = sizeof(EFI_SIGNATURE_DATA) - 1 + sizeof (EFI_TIME) + mHash[HashAlg].DigestLength;\r
-  SignatureData = (EFI_SIGNATURE_DATA *) AllocateZeroPool (SignatureSize);\r
+  SignatureSize = sizeof (EFI_SIGNATURE_DATA) - 1 + sizeof (EFI_TIME) + mHash[HashAlg].DigestLength;\r
+  SignatureData = (EFI_SIGNATURE_DATA *)AllocateZeroPool (SignatureSize);\r
   if (SignatureData == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
+\r
   CopyGuid (&SignatureData->SignatureOwner, Private->SignatureGUID);\r
   CopyMem (SignatureData->SignatureData, CertHash, mHash[HashAlg].DigestLength);\r
 \r
@@ -1385,7 +1406,7 @@ EnrollX509HashtoSigDB (
   // Fill the time.\r
   //\r
   if (!AlwaysRevocation) {\r
-    Time = (EFI_TIME *)(&SignatureData->SignatureData + mHash[HashAlg].DigestLength);\r
+    Time         = (EFI_TIME *)(&SignatureData->SignatureData + mHash[HashAlg].DigestLength);\r
     Time->Year   = RevocationDate->Year;\r
     Time->Month  = RevocationDate->Month;\r
     Time->Day    = RevocationDate->Day;\r
@@ -1398,23 +1419,23 @@ EnrollX509HashtoSigDB (
   // Determine the GUID for certificate hash.\r
   //\r
   switch (HashAlg) {\r
-  case HASHALG_SHA256:\r
-    SignatureType = gEfiCertX509Sha256Guid;\r
-    break;\r
-  case HASHALG_SHA384:\r
-    SignatureType = gEfiCertX509Sha384Guid;\r
-    break;\r
-  case HASHALG_SHA512:\r
-    SignatureType = gEfiCertX509Sha512Guid;\r
-    break;\r
-  default:\r
-    return FALSE;\r
+    case HASHALG_SHA256:\r
+      SignatureType = gEfiCertX509Sha256Guid;\r
+      break;\r
+    case HASHALG_SHA384:\r
+      SignatureType = gEfiCertX509Sha384Guid;\r
+      break;\r
+    case HASHALG_SHA512:\r
+      SignatureType = gEfiCertX509Sha512Guid;\r
+      break;\r
+    default:\r
+      return FALSE;\r
   }\r
 \r
   //\r
   // Add signature into the new variable data buffer\r
   //\r
-  if (GetSignaturelistOffset((EFI_SIGNATURE_LIST *)Data, DataSize, &SignatureType, &Offset)) {\r
+  if (GetSignaturelistOffset ((EFI_SIGNATURE_LIST *)Data, DataSize, &SignatureType, &Offset)) {\r
     //\r
     // Add the signature to the found signaturelist.\r
     //\r
@@ -1426,11 +1447,11 @@ EnrollX509HashtoSigDB (
     }\r
 \r
     SignatureList     = (EFI_SIGNATURE_LIST *)(Data + Offset);\r
-    SignatureListSize = (UINTN) ReadUnaligned32 ((UINT32 *)&SignatureList->SignatureListSize);\r
+    SignatureListSize = (UINTN)ReadUnaligned32 ((UINT32 *)&SignatureList->SignatureListSize);\r
     CopyMem (NewData, Data, Offset + SignatureListSize);\r
 \r
     SignatureList = (EFI_SIGNATURE_LIST *)(NewData + Offset);\r
-    WriteUnaligned32 ((UINT32 *) &SignatureList->SignatureListSize, (UINT32)(SignatureListSize + SignatureSize));\r
+    WriteUnaligned32 ((UINT32 *)&SignatureList->SignatureListSize, (UINT32)(SignatureListSize + SignatureSize));\r
 \r
     Offset += SignatureListSize;\r
     CopyMem (NewData + Offset, SignatureData, SignatureSize);\r
@@ -1443,37 +1464,39 @@ EnrollX509HashtoSigDB (
     //\r
     // Create a new signaturelist, and add the signature into the signaturelist.\r
     //\r
-    DbSize  = DataSize + sizeof(EFI_SIGNATURE_LIST) + SignatureSize;\r
+    DbSize  = DataSize + sizeof (EFI_SIGNATURE_LIST) + SignatureSize;\r
     NewData = AllocateZeroPool (DbSize);\r
     if (NewData == NULL) {\r
       Status = EFI_OUT_OF_RESOURCES;\r
       goto ON_EXIT;\r
     }\r
+\r
     //\r
     // Fill Certificate Database parameters.\r
     //\r
-    SignatureList     = (EFI_SIGNATURE_LIST*) (NewData + DataSize);\r
-    SignatureListSize = sizeof(EFI_SIGNATURE_LIST) + SignatureSize;\r
-    WriteUnaligned32 ((UINT32 *) &SignatureList->SignatureListSize, (UINT32) SignatureListSize);\r
-    WriteUnaligned32 ((UINT32 *) &SignatureList->SignatureSize, (UINT32) SignatureSize);\r
+    SignatureList     = (EFI_SIGNATURE_LIST *)(NewData + DataSize);\r
+    SignatureListSize = sizeof (EFI_SIGNATURE_LIST) + SignatureSize;\r
+    WriteUnaligned32 ((UINT32 *)&SignatureList->SignatureListSize, (UINT32)SignatureListSize);\r
+    WriteUnaligned32 ((UINT32 *)&SignatureList->SignatureSize, (UINT32)SignatureSize);\r
     CopyGuid (&SignatureList->SignatureType, &SignatureType);\r
-    CopyMem ((UINT8* ) SignatureList + sizeof (EFI_SIGNATURE_LIST), SignatureData, SignatureSize);\r
+    CopyMem ((UINT8 *)SignatureList + sizeof (EFI_SIGNATURE_LIST), SignatureData, SignatureSize);\r
     if ((DataSize != 0) && (Data != NULL)) {\r
       CopyMem (NewData, Data, DataSize);\r
       FreePool (Data);\r
     }\r
+\r
     Data     = NewData;\r
     DataSize = DbSize;\r
   }\r
 \r
-  Status = CreateTimeBasedPayload (&DataSize, (UINT8**) &Data);\r
+  Status = CreateTimeBasedPayload (&DataSize, (UINT8 **)&Data);\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
 \r
   Attr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS\r
-          | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
-  Status = gRT->SetVariable(\r
+         | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
+  Status = gRT->SetVariable (\r
                   EFI_IMAGE_SECURITY_DATABASE1,\r
                   &gEfiImageSecurityDatabaseGuid,\r
                   Attr,\r
@@ -1486,7 +1509,7 @@ EnrollX509HashtoSigDB (
 \r
 ON_EXIT:\r
 \r
-  CloseEnrolledFile(Private->FileContext);\r
+  CloseEnrolledFile (Private->FileContext);\r
 \r
   if (Private->SignatureGUID != NULL) {\r
     FreePool (Private->SignatureGUID);\r
@@ -1520,26 +1543,26 @@ ON_EXIT:
 **/\r
 BOOLEAN\r
 IsX509CertInDbx (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *Private,\r
-  IN CHAR16                         *VariableName\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private,\r
+  IN CHAR16                          *VariableName\r
   )\r
 {\r
-  EFI_STATUS          Status;\r
-  UINTN               X509DataSize;\r
-  VOID                *X509Data;\r
-  BOOLEAN             IsFound;\r
+  EFI_STATUS  Status;\r
+  UINTN       X509DataSize;\r
+  VOID        *X509Data;\r
+  BOOLEAN     IsFound;\r
 \r
   //\r
   //  Read the certificate from file\r
   //\r
-  X509DataSize  = 0;\r
-  X509Data      = NULL;\r
-  Status = ReadFileContent (\r
-             Private->FileContext->FHandle,\r
-             &X509Data,\r
-             &X509DataSize,\r
-             0\r
-             );\r
+  X509DataSize = 0;\r
+  X509Data     = NULL;\r
+  Status       = ReadFileContent (\r
+                   Private->FileContext->FHandle,\r
+                   &X509Data,\r
+                   &X509DataSize,\r
+                   0\r
+                   );\r
   if (EFI_ERROR (Status)) {\r
     return FALSE;\r
   }\r
@@ -1587,15 +1610,15 @@ ON_EXIT:
 EFI_STATUS\r
 EFIAPI\r
 SecureBootConfigImageRead (\r
-  IN     VOID    *FileHandle,\r
-  IN     UINTN   FileOffset,\r
-  IN OUT UINTN   *ReadSize,\r
-  OUT    VOID    *Buffer\r
+  IN     VOID   *FileHandle,\r
+  IN     UINTN  FileOffset,\r
+  IN OUT UINTN  *ReadSize,\r
+  OUT    VOID   *Buffer\r
   )\r
 {\r
-  UINTN               EndPosition;\r
+  UINTN  EndPosition;\r
 \r
-  if (FileHandle == NULL || ReadSize == NULL || Buffer == NULL) {\r
+  if ((FileHandle == NULL) || (ReadSize == NULL) || (Buffer == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -1612,7 +1635,7 @@ SecureBootConfigImageRead (
     *ReadSize = 0;\r
   }\r
 \r
-  CopyMem (Buffer, (UINT8 *)((UINTN) FileHandle + FileOffset), *ReadSize);\r
+  CopyMem (Buffer, (UINT8 *)((UINTN)FileHandle + FileOffset), *ReadSize);\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -1630,18 +1653,18 @@ LoadPeImage (
   VOID\r
   )\r
 {\r
-  EFI_IMAGE_DOS_HEADER                  *DosHdr;\r
-  EFI_IMAGE_NT_HEADERS32                *NtHeader32;\r
-  EFI_IMAGE_NT_HEADERS64                *NtHeader64;\r
-  PE_COFF_LOADER_IMAGE_CONTEXT          ImageContext;\r
-  EFI_STATUS                            Status;\r
+  EFI_IMAGE_DOS_HEADER          *DosHdr;\r
+  EFI_IMAGE_NT_HEADERS32        *NtHeader32;\r
+  EFI_IMAGE_NT_HEADERS64        *NtHeader64;\r
+  PE_COFF_LOADER_IMAGE_CONTEXT  ImageContext;\r
+  EFI_STATUS                    Status;\r
 \r
   NtHeader32 = NULL;\r
   NtHeader64 = NULL;\r
 \r
   ZeroMem (&ImageContext, sizeof (ImageContext));\r
-  ImageContext.Handle    = (VOID *) mImageBase;\r
-  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE) SecureBootConfigImageRead;\r
+  ImageContext.Handle    = (VOID *)mImageBase;\r
+  ImageContext.ImageRead = (PE_COFF_LOADER_READ_FILE)SecureBootConfigImageRead;\r
 \r
   //\r
   // Get information about the image being loaded\r
@@ -1658,26 +1681,22 @@ LoadPeImage (
   //\r
   // Read the Dos header\r
   //\r
-  DosHdr = (EFI_IMAGE_DOS_HEADER*)(mImageBase);\r
-  if (DosHdr->e_magic == EFI_IMAGE_DOS_SIGNATURE)\r
-  {\r
+  DosHdr = (EFI_IMAGE_DOS_HEADER *)(mImageBase);\r
+  if (DosHdr->e_magic == EFI_IMAGE_DOS_SIGNATURE) {\r
     //\r
     // DOS image header is present,\r
     // So read the PE header after the DOS image header\r
     //\r
     mPeCoffHeaderOffset = DosHdr->e_lfanew;\r
-  }\r
-  else\r
-  {\r
+  } else {\r
     mPeCoffHeaderOffset = 0;\r
   }\r
 \r
   //\r
   // Read PE header and check the signature validity and machine compatibility\r
   //\r
-  NtHeader32 = (EFI_IMAGE_NT_HEADERS32*) (mImageBase + mPeCoffHeaderOffset);\r
-  if (NtHeader32->Signature != EFI_IMAGE_NT_SIGNATURE)\r
-  {\r
+  NtHeader32 = (EFI_IMAGE_NT_HEADERS32 *)(mImageBase + mPeCoffHeaderOffset);\r
+  if (NtHeader32->Signature != EFI_IMAGE_NT_SIGNATURE) {\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
@@ -1687,24 +1706,25 @@ LoadPeImage (
   // Check the architecture field of PE header and get the Certificate Data Directory data\r
   // Note the size of FileHeader field is constant for both IA32 and X64 arch\r
   //\r
-  if ((NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_IA32)\r
-      || (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_EBC)\r
-      || (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)) {\r
+  if (  (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_IA32)\r
+     || (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_EBC)\r
+     || (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED))\r
+  {\r
     //\r
     // 32-bits Architecture\r
     //\r
-    mImageType = ImageType_IA32;\r
-    mSecDataDir = (EFI_IMAGE_SECURITY_DATA_DIRECTORY*) &(NtHeader32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]);\r
-  }\r
-  else if ((NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_IA64)\r
-          || (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_X64)\r
-          || (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_AARCH64)) {\r
+    mImageType  = ImageType_IA32;\r
+    mSecDataDir = (EFI_IMAGE_SECURITY_DATA_DIRECTORY *)&(NtHeader32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]);\r
+  } else if (  (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_IA64)\r
+            || (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_X64)\r
+            || (NtHeader32->FileHeader.Machine == EFI_IMAGE_MACHINE_AARCH64))\r
+  {\r
     //\r
     // 64-bits Architecture\r
     //\r
-    mImageType = ImageType_X64;\r
-    NtHeader64 = (EFI_IMAGE_NT_HEADERS64 *) (mImageBase + mPeCoffHeaderOffset);\r
-    mSecDataDir = (EFI_IMAGE_SECURITY_DATA_DIRECTORY*) &(NtHeader64->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]);\r
+    mImageType  = ImageType_X64;\r
+    NtHeader64  = (EFI_IMAGE_NT_HEADERS64 *)(mImageBase + mPeCoffHeaderOffset);\r
+    mSecDataDir = (EFI_IMAGE_SECURITY_DATA_DIRECTORY *)&(NtHeader64->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]);\r
   } else {\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -1727,7 +1747,7 @@ LoadPeImage (
 **/\r
 BOOLEAN\r
 HashPeImage (\r
-  IN  UINT32                HashAlg\r
+  IN  UINT32  HashAlg\r
   )\r
 {\r
   BOOLEAN                   Status;\r
@@ -1754,10 +1774,10 @@ HashPeImage (
   //\r
   ZeroMem (mImageDigest, MAX_DIGEST_SIZE);\r
 \r
-  mImageDigestSize  = SHA256_DIGEST_SIZE;\r
-  mCertType         = gEfiCertSha256Guid;\r
+  mImageDigestSize = SHA256_DIGEST_SIZE;\r
+  mCertType        = gEfiCertSha256Guid;\r
 \r
-  CtxSize   = mHash[HashAlg].GetContextSize();\r
+  CtxSize = mHash[HashAlg].GetContextSize ();\r
 \r
   HashCtx = AllocatePool (CtxSize);\r
   ASSERT (HashCtx != NULL);\r
@@ -1765,10 +1785,11 @@ HashPeImage (
   // 1.  Load the image header into memory.\r
 \r
   // 2.  Initialize a SHA hash context.\r
-  Status = mHash[HashAlg].HashInit(HashCtx);\r
+  Status = mHash[HashAlg].HashInit (HashCtx);\r
   if (!Status) {\r
     goto Done;\r
   }\r
+\r
   //\r
   // Measuring PE/COFF Image Header;\r
   // But CheckSum field and SECURITY data directory (certificate) are excluded\r
@@ -1783,18 +1804,19 @@ HashPeImage (
     //\r
     // Use PE32 offset.\r
     //\r
-    HashSize = (UINTN) (&mNtHeader.Pe32->OptionalHeader.CheckSum) - (UINTN) HashBase;\r
+    HashSize = (UINTN)(&mNtHeader.Pe32->OptionalHeader.CheckSum) - (UINTN)HashBase;\r
   } else {\r
     //\r
     // Use PE32+ offset.\r
     //\r
-    HashSize = (UINTN) (&mNtHeader.Pe32Plus->OptionalHeader.CheckSum) - (UINTN) HashBase;\r
+    HashSize = (UINTN)(&mNtHeader.Pe32Plus->OptionalHeader.CheckSum) - (UINTN)HashBase;\r
   }\r
 \r
-  Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+  Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
   if (!Status) {\r
     goto Done;\r
   }\r
+\r
   //\r
   // 5.  Skip over the image checksum (it occupies a single ULONG).\r
   // 6.  Get the address of the beginning of the Cert Directory.\r
@@ -1804,20 +1826,21 @@ HashPeImage (
     //\r
     // Use PE32 offset.\r
     //\r
-    HashBase = (UINT8 *) &mNtHeader.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
-    HashSize = (UINTN) (&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN) HashBase;\r
+    HashBase = (UINT8 *)&mNtHeader.Pe32->OptionalHeader.CheckSum + sizeof (UINT32);\r
+    HashSize = (UINTN)(&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN)HashBase;\r
   } else {\r
     //\r
     // Use PE32+ offset.\r
     //\r
-    HashBase = (UINT8 *) &mNtHeader.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
-    HashSize = (UINTN) (&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN) HashBase;\r
+    HashBase = (UINT8 *)&mNtHeader.Pe32Plus->OptionalHeader.CheckSum + sizeof (UINT32);\r
+    HashSize = (UINTN)(&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY]) - (UINTN)HashBase;\r
   }\r
 \r
-  Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+  Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
   if (!Status) {\r
     goto Done;\r
   }\r
+\r
   //\r
   // 8.  Skip over the Cert Directory. (It is sizeof(IMAGE_DATA_DIRECTORY) bytes.)\r
   // 9.  Hash everything from the end of the Cert Directory to the end of image header.\r
@@ -1826,20 +1849,21 @@ HashPeImage (
     //\r
     // Use PE32 offset\r
     //\r
-    HashBase = (UINT8 *) &mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
-    HashSize = mNtHeader.Pe32->OptionalHeader.SizeOfHeaders - ((UINTN) (&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1]) - (UINTN) mImageBase);\r
+    HashBase = (UINT8 *)&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
+    HashSize = mNtHeader.Pe32->OptionalHeader.SizeOfHeaders - ((UINTN)(&mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1]) - (UINTN)mImageBase);\r
   } else {\r
     //\r
     // Use PE32+ offset.\r
     //\r
-    HashBase = (UINT8 *) &mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
-    HashSize = mNtHeader.Pe32Plus->OptionalHeader.SizeOfHeaders - ((UINTN) (&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1]) - (UINTN) mImageBase);\r
+    HashBase = (UINT8 *)&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1];\r
+    HashSize = mNtHeader.Pe32Plus->OptionalHeader.SizeOfHeaders - ((UINTN)(&mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY + 1]) - (UINTN)mImageBase);\r
   }\r
 \r
-  Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+  Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
   if (!Status) {\r
     goto Done;\r
   }\r
+\r
   //\r
   // 10. Set the SUM_OF_BYTES_HASHED to the size of the header.\r
   //\r
@@ -1861,7 +1885,7 @@ HashPeImage (
   //     header indicates how big the table should be. Do not include any\r
   //     IMAGE_SECTION_HEADERs in the table whose 'SizeOfRawData' field is zero.\r
   //\r
-  SectionHeader = (EFI_IMAGE_SECTION_HEADER *) AllocateZeroPool (sizeof (EFI_IMAGE_SECTION_HEADER) * mNtHeader.Pe32->FileHeader.NumberOfSections);\r
+  SectionHeader = (EFI_IMAGE_SECTION_HEADER *)AllocateZeroPool (sizeof (EFI_IMAGE_SECTION_HEADER) * mNtHeader.Pe32->FileHeader.NumberOfSections);\r
   ASSERT (SectionHeader != NULL);\r
   //\r
   // 12.  Using the 'PointerToRawData' in the referenced section headers as\r
@@ -1869,19 +1893,20 @@ HashPeImage (
   //      words, sort the section headers according to the disk-file offset of\r
   //      the section.\r
   //\r
-  Section = (EFI_IMAGE_SECTION_HEADER *) (\r
-               mImageBase +\r
-               mPeCoffHeaderOffset +\r
-               sizeof (UINT32) +\r
-               sizeof (EFI_IMAGE_FILE_HEADER) +\r
-               mNtHeader.Pe32->FileHeader.SizeOfOptionalHeader\r
-               );\r
+  Section = (EFI_IMAGE_SECTION_HEADER *)(\r
+                                         mImageBase +\r
+                                         mPeCoffHeaderOffset +\r
+                                         sizeof (UINT32) +\r
+                                         sizeof (EFI_IMAGE_FILE_HEADER) +\r
+                                         mNtHeader.Pe32->FileHeader.SizeOfOptionalHeader\r
+                                         );\r
   for (Index = 0; Index < mNtHeader.Pe32->FileHeader.NumberOfSections; Index++) {\r
     Pos = Index;\r
     while ((Pos > 0) && (Section->PointerToRawData < SectionHeader[Pos - 1].PointerToRawData)) {\r
       CopyMem (&SectionHeader[Pos], &SectionHeader[Pos - 1], sizeof (EFI_IMAGE_SECTION_HEADER));\r
       Pos--;\r
     }\r
+\r
     CopyMem (&SectionHeader[Pos], Section, sizeof (EFI_IMAGE_SECTION_HEADER));\r
     Section += 1;\r
   }\r
@@ -1898,10 +1923,11 @@ HashPeImage (
     if (Section->SizeOfRawData == 0) {\r
       continue;\r
     }\r
-    HashBase  = mImageBase + Section->PointerToRawData;\r
-    HashSize  = (UINTN) Section->SizeOfRawData;\r
 \r
-    Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+    HashBase = mImageBase + Section->PointerToRawData;\r
+    HashSize = (UINTN)Section->SizeOfRawData;\r
+\r
+    Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
     if (!Status) {\r
       goto Done;\r
     }\r
@@ -1922,34 +1948,36 @@ HashPeImage (
       // Use PE32 offset.\r
       //\r
       HashSize = (UINTN)(\r
-                 mImageSize -\r
-                 mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY].Size -\r
-                 SumOfBytesHashed);\r
+                         mImageSize -\r
+                         mNtHeader.Pe32->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY].Size -\r
+                         SumOfBytesHashed);\r
     } else {\r
       //\r
       // Use PE32+ offset.\r
       //\r
       HashSize = (UINTN)(\r
-                 mImageSize -\r
-                 mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY].Size -\r
-                 SumOfBytesHashed);\r
+                         mImageSize -\r
+                         mNtHeader.Pe32Plus->OptionalHeader.DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_SECURITY].Size -\r
+                         SumOfBytesHashed);\r
     }\r
 \r
-    Status  = mHash[HashAlg].HashUpdate(HashCtx, HashBase, HashSize);\r
+    Status = mHash[HashAlg].HashUpdate (HashCtx, HashBase, HashSize);\r
     if (!Status) {\r
       goto Done;\r
     }\r
   }\r
 \r
-  Status  = mHash[HashAlg].HashFinal(HashCtx, mImageDigest);\r
+  Status = mHash[HashAlg].HashFinal (HashCtx, mImageDigest);\r
 \r
 Done:\r
   if (HashCtx != NULL) {\r
     FreePool (HashCtx);\r
   }\r
+\r
   if (SectionHeader != NULL) {\r
     FreePool (SectionHeader);\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -1970,7 +1998,7 @@ HashPeImageByType (
   UINT8                     Index;\r
   WIN_CERTIFICATE_EFI_PKCS  *PkcsCertData;\r
 \r
-  PkcsCertData = (WIN_CERTIFICATE_EFI_PKCS *) (mImageBase + mSecDataDir->Offset);\r
+  PkcsCertData = (WIN_CERTIFICATE_EFI_PKCS *)(mImageBase + mSecDataDir->Offset);\r
 \r
   for (Index = 0; Index < HASHALG_MAX; Index++) {\r
     //\r
@@ -1984,7 +2012,7 @@ HashPeImageByType (
     //    The DigestAlgorithmIdentifiers can be used to determine the hash algorithm in PE/COFF hashing\r
     //    This field has the fixed offset (+32) in final Authenticode ASN.1 data.\r
     //    Fixed offset (+32) is calculated based on two bytes of length encoding.\r
-     //\r
+    //\r
     if ((*(PkcsCertData->CertData + 1) & TWO_BYTE_ENCODE) != TWO_BYTE_ENCODE) {\r
       //\r
       // Only support two bytes of Long Form of Length Encoding.\r
@@ -2005,7 +2033,7 @@ HashPeImageByType (
   //\r
   // HASH PE Image based on Hash algorithm in PE/COFF Authenticode.\r
   //\r
-  if (!HashPeImage(Index)) {\r
+  if (!HashPeImage (Index)) {\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
@@ -2028,14 +2056,14 @@ HashPeImageByType (
 **/\r
 EFI_STATUS\r
 EnrollAuthentication2Descriptor (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *Private,\r
-  IN CHAR16                         *VariableName\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private,\r
+  IN CHAR16                          *VariableName\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  VOID                              *Data;\r
-  UINTN                             DataSize;\r
-  UINT32                            Attr;\r
+  EFI_STATUS  Status;\r
+  VOID        *Data;\r
+  UINTN       DataSize;\r
+  UINT32      Attr;\r
 \r
   Data = NULL;\r
 \r
@@ -2049,15 +2077,16 @@ EnrollAuthentication2Descriptor (
   //\r
   // Read the whole file content\r
   //\r
-  Status = ReadFileContent(\r
+  Status = ReadFileContent (\r
              Private->FileContext->FHandle,\r
-             (VOID **) &mImageBase,\r
+             (VOID **)&mImageBase,\r
              &mImageSize,\r
              0\r
              );\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
+\r
   ASSERT (mImageBase != NULL);\r
 \r
   Attr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS\r
@@ -2069,13 +2098,13 @@ EnrollAuthentication2Descriptor (
   // new signature data to original variable\r
   //\r
   DataSize = 0;\r
-  Status = gRT->GetVariable(\r
-                  VariableName,\r
-                  &gEfiImageSecurityDatabaseGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  NULL\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    VariableName,\r
+                    &gEfiImageSecurityDatabaseGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    NULL\r
+                    );\r
   if (Status == EFI_BUFFER_TOO_SMALL) {\r
     Attr |= EFI_VARIABLE_APPEND_WRITE;\r
   } else if (Status != EFI_NOT_FOUND) {\r
@@ -2085,7 +2114,7 @@ EnrollAuthentication2Descriptor (
   //\r
   // Directly set AUTHENTICATION_2 data to SetVariable\r
   //\r
-  Status = gRT->SetVariable(\r
+  Status = gRT->SetVariable (\r
                   VariableName,\r
                   &gEfiImageSecurityDatabaseGuid,\r
                   Attr,\r
@@ -2093,11 +2122,11 @@ EnrollAuthentication2Descriptor (
                   mImageBase\r
                   );\r
 \r
-  DEBUG((DEBUG_INFO, "Enroll AUTH_2 data to Var:%s Status: %x\n", VariableName, Status));\r
+  DEBUG ((DEBUG_INFO, "Enroll AUTH_2 data to Var:%s Status: %x\n", VariableName, Status));\r
 \r
 ON_EXIT:\r
 \r
-  CloseEnrolledFile(Private->FileContext);\r
+  CloseEnrolledFile (Private->FileContext);\r
 \r
   if (Data != NULL) {\r
     FreePool (Data);\r
@@ -2109,10 +2138,8 @@ ON_EXIT:
   }\r
 \r
   return Status;\r
-\r
 }\r
 \r
-\r
 /**\r
   Enroll a new signature of executable into Signature Database.\r
 \r
@@ -2129,20 +2156,20 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 EnrollImageSignatureToSigDB (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *Private,\r
-  IN CHAR16                         *VariableName\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private,\r
+  IN CHAR16                          *VariableName\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_SIGNATURE_LIST                *SigDBCert;\r
-  EFI_SIGNATURE_DATA                *SigDBCertData;\r
-  VOID                              *Data;\r
-  UINTN                             DataSize;\r
-  UINTN                             SigDBSize;\r
-  UINT32                            Attr;\r
-  WIN_CERTIFICATE_UEFI_GUID         *GuidCertData;\r
-\r
-  Data = NULL;\r
+  EFI_STATUS                 Status;\r
+  EFI_SIGNATURE_LIST         *SigDBCert;\r
+  EFI_SIGNATURE_DATA         *SigDBCertData;\r
+  VOID                       *Data;\r
+  UINTN                      DataSize;\r
+  UINTN                      SigDBSize;\r
+  UINT32                     Attr;\r
+  WIN_CERTIFICATE_UEFI_GUID  *GuidCertData;\r
+\r
+  Data         = NULL;\r
   GuidCertData = NULL;\r
 \r
   if (StrCmp (VariableName, EFI_IMAGE_SECURITY_DATABASE2) == 0) {\r
@@ -2161,15 +2188,16 @@ EnrollImageSignatureToSigDB (
   //\r
   // Read the whole file content\r
   //\r
-  Status = ReadFileContent(\r
+  Status = ReadFileContent (\r
              Private->FileContext->FHandle,\r
-             (VOID **) &mImageBase,\r
+             (VOID **)&mImageBase,\r
              &mImageSize,\r
              0\r
              );\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
+\r
   ASSERT (mImageBase != NULL);\r
 \r
   Status = LoadPeImage ();\r
@@ -2183,29 +2211,26 @@ EnrollImageSignatureToSigDB (
       goto ON_EXIT;\r
     }\r
   } else {\r
-\r
     //\r
     // Read the certificate data\r
     //\r
     mCertificate = (WIN_CERTIFICATE *)(mImageBase + mSecDataDir->Offset);\r
 \r
     if (mCertificate->wCertificateType == WIN_CERT_TYPE_EFI_GUID) {\r
-      GuidCertData = (WIN_CERTIFICATE_UEFI_GUID*) mCertificate;\r
-      if (CompareMem (&GuidCertData->CertType, &gEfiCertTypeRsa2048Sha256Guid, sizeof(EFI_GUID)) != 0) {\r
+      GuidCertData = (WIN_CERTIFICATE_UEFI_GUID *)mCertificate;\r
+      if (CompareMem (&GuidCertData->CertType, &gEfiCertTypeRsa2048Sha256Guid, sizeof (EFI_GUID)) != 0) {\r
         Status = EFI_ABORTED;\r
         goto ON_EXIT;\r
       }\r
 \r
       if (!HashPeImage (HASHALG_SHA256)) {\r
         Status = EFI_ABORTED;\r
-        goto ON_EXIT;;\r
+        goto ON_EXIT;\r
       }\r
-\r
     } else if (mCertificate->wCertificateType == WIN_CERT_TYPE_PKCS_SIGNED_DATA) {\r
-\r
       Status = HashPeImageByType ();\r
       if (EFI_ERROR (Status)) {\r
-        goto ON_EXIT;;\r
+        goto ON_EXIT;\r
       }\r
     } else {\r
       Status = EFI_ABORTED;\r
@@ -2216,11 +2241,11 @@ EnrollImageSignatureToSigDB (
   //\r
   // Create a new SigDB entry.\r
   //\r
-  SigDBSize = sizeof(EFI_SIGNATURE_LIST)\r
-              + sizeof(EFI_SIGNATURE_DATA) - 1\r
-              + (UINT32) mImageDigestSize;\r
+  SigDBSize = sizeof (EFI_SIGNATURE_LIST)\r
+              + sizeof (EFI_SIGNATURE_DATA) - 1\r
+              + (UINT32)mImageDigestSize;\r
 \r
-  Data = (UINT8*) AllocateZeroPool (SigDBSize);\r
+  Data = (UINT8 *)AllocateZeroPool (SigDBSize);\r
   if (Data == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
@@ -2229,19 +2254,19 @@ EnrollImageSignatureToSigDB (
   //\r
   // Adjust the Certificate Database parameters.\r
   //\r
-  SigDBCert = (EFI_SIGNATURE_LIST*) Data;\r
-  SigDBCert->SignatureListSize   = (UINT32) SigDBSize;\r
+  SigDBCert                      = (EFI_SIGNATURE_LIST *)Data;\r
+  SigDBCert->SignatureListSize   = (UINT32)SigDBSize;\r
   SigDBCert->SignatureHeaderSize = 0;\r
-  SigDBCert->SignatureSize       = sizeof(EFI_SIGNATURE_DATA) - 1 + (UINT32) mImageDigestSize;\r
+  SigDBCert->SignatureSize       = sizeof (EFI_SIGNATURE_DATA) - 1 + (UINT32)mImageDigestSize;\r
   CopyGuid (&SigDBCert->SignatureType, &mCertType);\r
 \r
-  SigDBCertData = (EFI_SIGNATURE_DATA*)((UINT8*)SigDBCert + sizeof(EFI_SIGNATURE_LIST));\r
+  SigDBCertData = (EFI_SIGNATURE_DATA *)((UINT8 *)SigDBCert + sizeof (EFI_SIGNATURE_LIST));\r
   CopyGuid (&SigDBCertData->SignatureOwner, Private->SignatureGUID);\r
   CopyMem (SigDBCertData->SignatureData, mImageDigest, mImageDigestSize);\r
 \r
   Attr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS\r
-          | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
-  Status = CreateTimeBasedPayload (&SigDBSize, (UINT8**) &Data);\r
+         | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS;\r
+  Status = CreateTimeBasedPayload (&SigDBSize, (UINT8 **)&Data);\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Fail to create time-based data payload: %r", Status));\r
     goto ON_EXIT;\r
@@ -2253,13 +2278,13 @@ EnrollImageSignatureToSigDB (
   // new signature data to original variable\r
   //\r
   DataSize = 0;\r
-  Status = gRT->GetVariable(\r
-                  VariableName,\r
-                  &gEfiImageSecurityDatabaseGuid,\r
-                  NULL,\r
-                  &DataSize,\r
-                  NULL\r
-                  );\r
+  Status   = gRT->GetVariable (\r
+                    VariableName,\r
+                    &gEfiImageSecurityDatabaseGuid,\r
+                    NULL,\r
+                    &DataSize,\r
+                    NULL\r
+                    );\r
   if (Status == EFI_BUFFER_TOO_SMALL) {\r
     Attr |= EFI_VARIABLE_APPEND_WRITE;\r
   } else if (Status != EFI_NOT_FOUND) {\r
@@ -2269,7 +2294,7 @@ EnrollImageSignatureToSigDB (
   //\r
   // Enroll the variable.\r
   //\r
-  Status = gRT->SetVariable(\r
+  Status = gRT->SetVariable (\r
                   VariableName,\r
                   &gEfiImageSecurityDatabaseGuid,\r
                   Attr,\r
@@ -2282,7 +2307,7 @@ EnrollImageSignatureToSigDB (
 \r
 ON_EXIT:\r
 \r
-  CloseEnrolledFile(Private->FileContext);\r
+  CloseEnrolledFile (Private->FileContext);\r
 \r
   if (Private->SignatureGUID != NULL) {\r
     FreePool (Private->SignatureGUID);\r
@@ -2316,13 +2341,13 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 EnrollSignatureDatabase (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA     *Private,\r
-  IN CHAR16                             *VariableName\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private,\r
+  IN CHAR16                          *VariableName\r
   )\r
 {\r
-  UINT16*      FilePostFix;\r
-  EFI_STATUS   Status;\r
-  UINTN        NameLength;\r
+  UINT16      *FilePostFix;\r
+  EFI_STATUS  Status;\r
+  UINTN       NameLength;\r
 \r
   if ((Private->FileContext->FileName == NULL) || (Private->FileContext->FHandle == NULL) || (Private->SignatureGUID == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -2340,14 +2365,15 @@ EnrollSignatureDatabase (
   if (NameLength <= 4) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   FilePostFix = Private->FileContext->FileName + NameLength - 4;\r
   if (IsDerEncodeCertificate (FilePostFix)) {\r
     //\r
     // Supports DER-encoded X509 certificate.\r
     //\r
     return EnrollX509toSigDB (Private, VariableName);\r
-  } else if (IsAuthentication2Format(Private->FileContext->FHandle)){\r
-    return EnrollAuthentication2Descriptor(Private, VariableName);\r
+  } else if (IsAuthentication2Format (Private->FileContext->FHandle)) {\r
+    return EnrollAuthentication2Descriptor (Private, VariableName);\r
   } else {\r
     return EnrollImageSignatureToSigDB (Private, VariableName);\r
   }\r
@@ -2370,35 +2396,35 @@ EnrollSignatureDatabase (
 **/\r
 EFI_STATUS\r
 UpdateDeletePage (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData,\r
-  IN CHAR16                           *VariableName,\r
-  IN EFI_GUID                         *VendorGuid,\r
-  IN UINT16                           LabelNumber,\r
-  IN EFI_FORM_ID                      FormId,\r
-  IN EFI_QUESTION_ID                  QuestionIdBase\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData,\r
+  IN CHAR16                          *VariableName,\r
+  IN EFI_GUID                        *VendorGuid,\r
+  IN UINT16                          LabelNumber,\r
+  IN EFI_FORM_ID                     FormId,\r
+  IN EFI_QUESTION_ID                 QuestionIdBase\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  UINT32                      Index;\r
-  UINTN                       CertCount;\r
-  UINTN                       GuidIndex;\r
-  VOID                        *StartOpCodeHandle;\r
-  VOID                        *EndOpCodeHandle;\r
-  EFI_IFR_GUID_LABEL          *StartLabel;\r
-  EFI_IFR_GUID_LABEL          *EndLabel;\r
-  UINTN                       DataSize;\r
-  UINT8                       *Data;\r
-  EFI_SIGNATURE_LIST          *CertList;\r
-  EFI_SIGNATURE_DATA          *Cert;\r
-  UINT32                      ItemDataSize;\r
-  CHAR16                      *GuidStr;\r
-  EFI_STRING_ID               GuidID;\r
-  EFI_STRING_ID               Help;\r
-\r
-  Data     = NULL;\r
-  CertList = NULL;\r
-  Cert     = NULL;\r
-  GuidStr  = NULL;\r
+  EFI_STATUS          Status;\r
+  UINT32              Index;\r
+  UINTN               CertCount;\r
+  UINTN               GuidIndex;\r
+  VOID                *StartOpCodeHandle;\r
+  VOID                *EndOpCodeHandle;\r
+  EFI_IFR_GUID_LABEL  *StartLabel;\r
+  EFI_IFR_GUID_LABEL  *EndLabel;\r
+  UINTN               DataSize;\r
+  UINT8               *Data;\r
+  EFI_SIGNATURE_LIST  *CertList;\r
+  EFI_SIGNATURE_DATA  *Cert;\r
+  UINT32              ItemDataSize;\r
+  CHAR16              *GuidStr;\r
+  EFI_STRING_ID       GuidID;\r
+  EFI_STRING_ID       Help;\r
+\r
+  Data              = NULL;\r
+  CertList          = NULL;\r
+  Cert              = NULL;\r
+  GuidStr           = NULL;\r
   StartOpCodeHandle = NULL;\r
   EndOpCodeHandle   = NULL;\r
 \r
@@ -2420,34 +2446,34 @@ UpdateDeletePage (
   //\r
   // Create Hii Extend Label OpCode.\r
   //\r
-  StartLabel = (EFI_IFR_GUID_LABEL *) HiiCreateGuidOpCode (\r
-                                        StartOpCodeHandle,\r
-                                        &gEfiIfrTianoGuid,\r
-                                        NULL,\r
-                                        sizeof (EFI_IFR_GUID_LABEL)\r
-                                        );\r
-  StartLabel->ExtendOpCode  = EFI_IFR_EXTEND_OP_LABEL;\r
-  StartLabel->Number        = LabelNumber;\r
+  StartLabel = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
+                                       StartOpCodeHandle,\r
+                                       &gEfiIfrTianoGuid,\r
+                                       NULL,\r
+                                       sizeof (EFI_IFR_GUID_LABEL)\r
+                                       );\r
+  StartLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
+  StartLabel->Number       = LabelNumber;\r
 \r
-  EndLabel = (EFI_IFR_GUID_LABEL *) HiiCreateGuidOpCode (\r
-                                      EndOpCodeHandle,\r
-                                      &gEfiIfrTianoGuid,\r
-                                      NULL,\r
-                                      sizeof (EFI_IFR_GUID_LABEL)\r
-                                      );\r
-  EndLabel->ExtendOpCode  = EFI_IFR_EXTEND_OP_LABEL;\r
-  EndLabel->Number        = LABEL_END;\r
+  EndLabel = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
+                                     EndOpCodeHandle,\r
+                                     &gEfiIfrTianoGuid,\r
+                                     NULL,\r
+                                     sizeof (EFI_IFR_GUID_LABEL)\r
+                                     );\r
+  EndLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
+  EndLabel->Number       = LABEL_END;\r
 \r
   //\r
   // Read Variable.\r
   //\r
   DataSize = 0;\r
-  Status = gRT->GetVariable (VariableName, VendorGuid, NULL, &DataSize, Data);\r
-  if (EFI_ERROR (Status) && Status != EFI_BUFFER_TOO_SMALL) {\r
+  Status   = gRT->GetVariable (VariableName, VendorGuid, NULL, &DataSize, Data);\r
+  if (EFI_ERROR (Status) && (Status != EFI_BUFFER_TOO_SMALL)) {\r
     goto ON_EXIT;\r
   }\r
 \r
-  Data = (UINT8 *) AllocateZeroPool (DataSize);\r
+  Data = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (Data == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
@@ -2467,12 +2493,11 @@ UpdateDeletePage (
   //\r
   // Enumerate all KEK pub data.\r
   //\r
-  ItemDataSize = (UINT32) DataSize;\r
-  CertList = (EFI_SIGNATURE_LIST *) Data;\r
-  GuidIndex = 0;\r
+  ItemDataSize = (UINT32)DataSize;\r
+  CertList     = (EFI_SIGNATURE_LIST *)Data;\r
+  GuidIndex    = 0;\r
 \r
   while ((ItemDataSize > 0) && (ItemDataSize >= CertList->SignatureListSize)) {\r
-\r
     if (CompareGuid (&CertList->SignatureType, &gEfiCertRsa2048Guid)) {\r
       Help = STRING_TOKEN (STR_CERT_TYPE_RSA2048_SHA256_GUID);\r
     } else if (CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid)) {\r
@@ -2492,24 +2517,24 @@ UpdateDeletePage (
       // The signature type is not supported in current implementation.\r
       //\r
       ItemDataSize -= CertList->SignatureListSize;\r
-      CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+      CertList      = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
       continue;\r
     }\r
 \r
-    CertCount  = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
+    CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
     for (Index = 0; Index < CertCount; Index++) {\r
-      Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList\r
-                                              + sizeof (EFI_SIGNATURE_LIST)\r
-                                              + CertList->SignatureHeaderSize\r
-                                              + Index * CertList->SignatureSize);\r
+      Cert = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList\r
+                                    + sizeof (EFI_SIGNATURE_LIST)\r
+                                    + CertList->SignatureHeaderSize\r
+                                    + Index * CertList->SignatureSize);\r
       //\r
       // Display GUID and help\r
       //\r
       GuidToString (&Cert->SignatureOwner, GuidStr, 100);\r
-      GuidID  = HiiSetString (PrivateData->HiiHandle, 0, GuidStr, NULL);\r
+      GuidID = HiiSetString (PrivateData->HiiHandle, 0, GuidStr, NULL);\r
       HiiCreateCheckBoxOpCode (\r
         StartOpCodeHandle,\r
-        (EFI_QUESTION_ID) (QuestionIdBase + GuidIndex++),\r
+        (EFI_QUESTION_ID)(QuestionIdBase + GuidIndex++),\r
         0,\r
         0,\r
         GuidID,\r
@@ -2521,7 +2546,7 @@ UpdateDeletePage (
     }\r
 \r
     ItemDataSize -= CertList->SignatureListSize;\r
-    CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList      = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
 ON_EXIT:\r
@@ -2564,34 +2589,34 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 DeleteKeyExchangeKey (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData,\r
-  IN EFI_QUESTION_ID                  QuestionId\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData,\r
+  IN EFI_QUESTION_ID                 QuestionId\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  UINTN                       DataSize;\r
-  UINT8                       *Data;\r
-  UINT8                       *OldData;\r
-  UINT32                      Attr;\r
-  UINT32                      Index;\r
-  EFI_SIGNATURE_LIST          *CertList;\r
-  EFI_SIGNATURE_LIST          *NewCertList;\r
-  EFI_SIGNATURE_DATA          *Cert;\r
-  UINTN                       CertCount;\r
-  UINT32                      Offset;\r
-  BOOLEAN                     IsKEKItemFound;\r
-  UINT32                      KekDataSize;\r
-  UINTN                       DeleteKekIndex;\r
-  UINTN                       GuidIndex;\r
-\r
-  Data            = NULL;\r
-  OldData         = NULL;\r
-  CertList        = NULL;\r
-  Cert            = NULL;\r
-  Attr            = 0;\r
-  DeleteKekIndex  = QuestionId - OPTION_DEL_KEK_QUESTION_ID;\r
-\r
-  Status = SetSecureBootMode(CUSTOM_SECURE_BOOT_MODE);\r
+  EFI_STATUS          Status;\r
+  UINTN               DataSize;\r
+  UINT8               *Data;\r
+  UINT8               *OldData;\r
+  UINT32              Attr;\r
+  UINT32              Index;\r
+  EFI_SIGNATURE_LIST  *CertList;\r
+  EFI_SIGNATURE_LIST  *NewCertList;\r
+  EFI_SIGNATURE_DATA  *Cert;\r
+  UINTN               CertCount;\r
+  UINT32              Offset;\r
+  BOOLEAN             IsKEKItemFound;\r
+  UINT32              KekDataSize;\r
+  UINTN               DeleteKekIndex;\r
+  UINTN               GuidIndex;\r
+\r
+  Data           = NULL;\r
+  OldData        = NULL;\r
+  CertList       = NULL;\r
+  Cert           = NULL;\r
+  Attr           = 0;\r
+  DeleteKekIndex = QuestionId - OPTION_DEL_KEK_QUESTION_ID;\r
+\r
+  Status = SetSecureBootMode (CUSTOM_SECURE_BOOT_MODE);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -2600,28 +2625,28 @@ DeleteKeyExchangeKey (
   // Get original KEK variable.\r
   //\r
   DataSize = 0;\r
-  Status = gRT->GetVariable (EFI_KEY_EXCHANGE_KEY_NAME, &gEfiGlobalVariableGuid, NULL, &DataSize, NULL);\r
-  if (EFI_ERROR(Status) && Status != EFI_BUFFER_TOO_SMALL) {\r
+  Status   = gRT->GetVariable (EFI_KEY_EXCHANGE_KEY_NAME, &gEfiGlobalVariableGuid, NULL, &DataSize, NULL);\r
+  if (EFI_ERROR (Status) && (Status != EFI_BUFFER_TOO_SMALL)) {\r
     goto ON_EXIT;\r
   }\r
 \r
-  OldData = (UINT8*)AllocateZeroPool(DataSize);\r
+  OldData = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (OldData == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
 \r
   Status = gRT->GetVariable (EFI_KEY_EXCHANGE_KEY_NAME, &gEfiGlobalVariableGuid, &Attr, &DataSize, OldData);\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
 \r
   //\r
   // Allocate space for new variable.\r
   //\r
-  Data = (UINT8*) AllocateZeroPool (DataSize);\r
+  Data = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (Data == NULL) {\r
-    Status  =  EFI_OUT_OF_RESOURCES;\r
+    Status =  EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
 \r
@@ -2629,25 +2654,26 @@ DeleteKeyExchangeKey (
   // Enumerate all KEK pub data and erasing the target item.\r
   //\r
   IsKEKItemFound = FALSE;\r
-  KekDataSize = (UINT32) DataSize;\r
-  CertList = (EFI_SIGNATURE_LIST *) OldData;\r
-  Offset = 0;\r
-  GuidIndex = 0;\r
+  KekDataSize    = (UINT32)DataSize;\r
+  CertList       = (EFI_SIGNATURE_LIST *)OldData;\r
+  Offset         = 0;\r
+  GuidIndex      = 0;\r
   while ((KekDataSize > 0) && (KekDataSize >= CertList->SignatureListSize)) {\r
     if (CompareGuid (&CertList->SignatureType, &gEfiCertRsa2048Guid) ||\r
-        CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid)) {\r
-      CopyMem (Data + Offset, CertList, (sizeof(EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize));\r
+        CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid))\r
+    {\r
+      CopyMem (Data + Offset, CertList, (sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize));\r
       NewCertList = (EFI_SIGNATURE_LIST *)(Data + Offset);\r
-      Offset += (sizeof(EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
-      Cert      = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
-      CertCount  = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
+      Offset     += (sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+      Cert        = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+      CertCount   = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
       for (Index = 0; Index < CertCount; Index++) {\r
         if (GuidIndex == DeleteKekIndex ) {\r
           //\r
           // Find it! Skip it!\r
           //\r
           NewCertList->SignatureListSize -= CertList->SignatureSize;\r
-          IsKEKItemFound = TRUE;\r
+          IsKEKItemFound                  = TRUE;\r
         } else {\r
           //\r
           // This item doesn't match. Copy it to the Data buffer.\r
@@ -2655,8 +2681,9 @@ DeleteKeyExchangeKey (
           CopyMem (Data + Offset, Cert, CertList->SignatureSize);\r
           Offset += CertList->SignatureSize;\r
         }\r
+\r
         GuidIndex++;\r
-        Cert = (EFI_SIGNATURE_DATA *) ((UINT8*) Cert + CertList->SignatureSize);\r
+        Cert = (EFI_SIGNATURE_DATA *)((UINT8 *)Cert + CertList->SignatureSize);\r
       }\r
     } else {\r
       //\r
@@ -2667,7 +2694,7 @@ DeleteKeyExchangeKey (
     }\r
 \r
     KekDataSize -= CertList->SignatureListSize;\r
-    CertList = (EFI_SIGNATURE_LIST*) ((UINT8*) CertList + CertList->SignatureListSize);\r
+    CertList     = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
   if (!IsKEKItemFound) {\r
@@ -2682,18 +2709,19 @@ DeleteKeyExchangeKey (
   // Delete the Signature header if there is no signature in the list.\r
   //\r
   KekDataSize = Offset;\r
-  CertList = (EFI_SIGNATURE_LIST*) Data;\r
-  Offset = 0;\r
+  CertList    = (EFI_SIGNATURE_LIST *)Data;\r
+  Offset      = 0;\r
   ZeroMem (OldData, KekDataSize);\r
   while ((KekDataSize > 0) && (KekDataSize >= CertList->SignatureListSize)) {\r
-    CertCount  = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
+    CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
     DEBUG ((DEBUG_INFO, "       CertCount = %x\n", CertCount));\r
     if (CertCount != 0) {\r
       CopyMem (OldData + Offset, CertList, CertList->SignatureListSize);\r
       Offset += CertList->SignatureListSize;\r
     }\r
+\r
     KekDataSize -= CertList->SignatureListSize;\r
-    CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList     = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
   DataSize = Offset;\r
@@ -2705,7 +2733,7 @@ DeleteKeyExchangeKey (
     }\r
   }\r
 \r
-  Status = gRT->SetVariable(\r
+  Status = gRT->SetVariable (\r
                   EFI_KEY_EXCHANGE_KEY_NAME,\r
                   &gEfiGlobalVariableGuid,\r
                   Attr,\r
@@ -2719,11 +2747,11 @@ DeleteKeyExchangeKey (
 \r
 ON_EXIT:\r
   if (Data != NULL) {\r
-    FreePool(Data);\r
+    FreePool (Data);\r
   }\r
 \r
   if (OldData != NULL) {\r
-    FreePool(OldData);\r
+    FreePool (OldData);\r
   }\r
 \r
   return UpdateDeletePage (\r
@@ -2753,37 +2781,37 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 DeleteSignature (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData,\r
-  IN CHAR16                           *VariableName,\r
-  IN EFI_GUID                         *VendorGuid,\r
-  IN UINT16                           LabelNumber,\r
-  IN EFI_FORM_ID                      FormId,\r
-  IN EFI_QUESTION_ID                  QuestionIdBase,\r
-  IN UINTN                            DeleteIndex\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData,\r
+  IN CHAR16                          *VariableName,\r
+  IN EFI_GUID                        *VendorGuid,\r
+  IN UINT16                          LabelNumber,\r
+  IN EFI_FORM_ID                     FormId,\r
+  IN EFI_QUESTION_ID                 QuestionIdBase,\r
+  IN UINTN                           DeleteIndex\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  UINTN                       DataSize;\r
-  UINT8                       *Data;\r
-  UINT8                       *OldData;\r
-  UINT32                      Attr;\r
-  UINT32                      Index;\r
-  EFI_SIGNATURE_LIST          *CertList;\r
-  EFI_SIGNATURE_LIST          *NewCertList;\r
-  EFI_SIGNATURE_DATA          *Cert;\r
-  UINTN                       CertCount;\r
-  UINT32                      Offset;\r
-  BOOLEAN                     IsItemFound;\r
-  UINT32                      ItemDataSize;\r
-  UINTN                       GuidIndex;\r
-\r
-  Data            = NULL;\r
-  OldData         = NULL;\r
-  CertList        = NULL;\r
-  Cert            = NULL;\r
-  Attr            = 0;\r
-\r
-  Status = SetSecureBootMode(CUSTOM_SECURE_BOOT_MODE);\r
+  EFI_STATUS          Status;\r
+  UINTN               DataSize;\r
+  UINT8               *Data;\r
+  UINT8               *OldData;\r
+  UINT32              Attr;\r
+  UINT32              Index;\r
+  EFI_SIGNATURE_LIST  *CertList;\r
+  EFI_SIGNATURE_LIST  *NewCertList;\r
+  EFI_SIGNATURE_DATA  *Cert;\r
+  UINTN               CertCount;\r
+  UINT32              Offset;\r
+  BOOLEAN             IsItemFound;\r
+  UINT32              ItemDataSize;\r
+  UINTN               GuidIndex;\r
+\r
+  Data     = NULL;\r
+  OldData  = NULL;\r
+  CertList = NULL;\r
+  Cert     = NULL;\r
+  Attr     = 0;\r
+\r
+  Status = SetSecureBootMode (CUSTOM_SECURE_BOOT_MODE);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -2792,39 +2820,39 @@ DeleteSignature (
   // Get original signature list data.\r
   //\r
   DataSize = 0;\r
-  Status = gRT->GetVariable (VariableName, VendorGuid, NULL, &DataSize, NULL);\r
-  if (EFI_ERROR (Status) && Status != EFI_BUFFER_TOO_SMALL) {\r
+  Status   = gRT->GetVariable (VariableName, VendorGuid, NULL, &DataSize, NULL);\r
+  if (EFI_ERROR (Status) && (Status != EFI_BUFFER_TOO_SMALL)) {\r
     goto ON_EXIT;\r
   }\r
 \r
-  OldData = (UINT8 *) AllocateZeroPool (DataSize);\r
+  OldData = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (OldData == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
 \r
   Status = gRT->GetVariable (VariableName, VendorGuid, &Attr, &DataSize, OldData);\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
 \r
   //\r
   // Allocate space for new variable.\r
   //\r
-  Data = (UINT8*) AllocateZeroPool (DataSize);\r
+  Data = (UINT8 *)AllocateZeroPool (DataSize);\r
   if (Data == NULL) {\r
-    Status  =  EFI_OUT_OF_RESOURCES;\r
+    Status =  EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
 \r
   //\r
   // Enumerate all signature data and erasing the target item.\r
   //\r
-  IsItemFound = FALSE;\r
-  ItemDataSize = (UINT32) DataSize;\r
-  CertList = (EFI_SIGNATURE_LIST *) OldData;\r
-  Offset = 0;\r
-  GuidIndex = 0;\r
+  IsItemFound  = FALSE;\r
+  ItemDataSize = (UINT32)DataSize;\r
+  CertList     = (EFI_SIGNATURE_LIST *)OldData;\r
+  Offset       = 0;\r
+  GuidIndex    = 0;\r
   while ((ItemDataSize > 0) && (ItemDataSize >= CertList->SignatureListSize)) {\r
     if (CompareGuid (&CertList->SignatureType, &gEfiCertRsa2048Guid) ||\r
         CompareGuid (&CertList->SignatureType, &gEfiCertX509Guid) ||\r
@@ -2833,42 +2861,44 @@ DeleteSignature (
         CompareGuid (&CertList->SignatureType, &gEfiCertX509Sha256Guid) ||\r
         CompareGuid (&CertList->SignatureType, &gEfiCertX509Sha384Guid) ||\r
         CompareGuid (&CertList->SignatureType, &gEfiCertX509Sha512Guid)\r
-        ) {\r
+        )\r
+    {\r
       //\r
       // Copy EFI_SIGNATURE_LIST header then calculate the signature count in this list.\r
       //\r
-      CopyMem (Data + Offset, CertList, (sizeof(EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize));\r
-      NewCertList = (EFI_SIGNATURE_LIST*) (Data + Offset);\r
-      Offset += (sizeof(EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
-      Cert      = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
-      CertCount  = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
+      CopyMem (Data + Offset, CertList, (sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize));\r
+      NewCertList = (EFI_SIGNATURE_LIST *)(Data + Offset);\r
+      Offset     += (sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+      Cert        = (EFI_SIGNATURE_DATA *)((UINT8 *)CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);\r
+      CertCount   = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
       for (Index = 0; Index < CertCount; Index++) {\r
         if (GuidIndex == DeleteIndex) {\r
           //\r
           // Find it! Skip it!\r
           //\r
           NewCertList->SignatureListSize -= CertList->SignatureSize;\r
-          IsItemFound = TRUE;\r
+          IsItemFound                     = TRUE;\r
         } else {\r
           //\r
           // This item doesn't match. Copy it to the Data buffer.\r
           //\r
-          CopyMem (Data + Offset, (UINT8*)(Cert), CertList->SignatureSize);\r
+          CopyMem (Data + Offset, (UINT8 *)(Cert), CertList->SignatureSize);\r
           Offset += CertList->SignatureSize;\r
         }\r
+\r
         GuidIndex++;\r
-        Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) Cert + CertList->SignatureSize);\r
+        Cert = (EFI_SIGNATURE_DATA *)((UINT8 *)Cert + CertList->SignatureSize);\r
       }\r
     } else {\r
       //\r
       // This List doesn't match. Just copy it to the Data buffer.\r
       //\r
-      CopyMem (Data + Offset, (UINT8*)(CertList), CertList->SignatureListSize);\r
+      CopyMem (Data + Offset, (UINT8 *)(CertList), CertList->SignatureListSize);\r
       Offset += CertList->SignatureListSize;\r
     }\r
 \r
     ItemDataSize -= CertList->SignatureListSize;\r
-    CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList      = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
   if (!IsItemFound) {\r
@@ -2883,18 +2913,19 @@ DeleteSignature (
   // Delete the EFI_SIGNATURE_LIST header if there is no signature in the list.\r
   //\r
   ItemDataSize = Offset;\r
-  CertList = (EFI_SIGNATURE_LIST *) Data;\r
-  Offset = 0;\r
+  CertList     = (EFI_SIGNATURE_LIST *)Data;\r
+  Offset       = 0;\r
   ZeroMem (OldData, ItemDataSize);\r
   while ((ItemDataSize > 0) && (ItemDataSize >= CertList->SignatureListSize)) {\r
-    CertCount  = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
+    CertCount = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;\r
     DEBUG ((DEBUG_INFO, "       CertCount = %x\n", CertCount));\r
     if (CertCount != 0) {\r
-      CopyMem (OldData + Offset, (UINT8*)(CertList), CertList->SignatureListSize);\r
+      CopyMem (OldData + Offset, (UINT8 *)(CertList), CertList->SignatureListSize);\r
       Offset += CertList->SignatureListSize;\r
     }\r
+\r
     ItemDataSize -= CertList->SignatureListSize;\r
-    CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);\r
+    CertList      = (EFI_SIGNATURE_LIST *)((UINT8 *)CertList + CertList->SignatureListSize);\r
   }\r
 \r
   DataSize = Offset;\r
@@ -2906,7 +2937,7 @@ DeleteSignature (
     }\r
   }\r
 \r
-  Status = gRT->SetVariable(\r
+  Status = gRT->SetVariable (\r
                   VariableName,\r
                   VendorGuid,\r
                   Attr,\r
@@ -2920,11 +2951,11 @@ DeleteSignature (
 \r
 ON_EXIT:\r
   if (Data != NULL) {\r
-    FreePool(Data);\r
+    FreePool (Data);\r
   }\r
 \r
   if (OldData != NULL) {\r
-    FreePool(OldData);\r
+    FreePool (OldData);\r
   }\r
 \r
   return UpdateDeletePage (\r
@@ -2950,9 +2981,9 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 DeleteSignatureEx (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData,\r
-  IN SIGNATURE_DELETE_TYPE            DelType,\r
-  IN UINT32                           CheckedCount\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData,\r
+  IN SIGNATURE_DELETE_TYPE           DelType,\r
+  IN UINT32                          CheckedCount\r
   )\r
 {\r
   EFI_STATUS          Status;\r
@@ -2969,13 +3000,13 @@ DeleteSignatureEx (
   UINT8               *VariableData;\r
   UINT8               *NewVariableData;\r
 \r
-  Status              = EFI_SUCCESS;\r
-  VariableAttr        = 0;\r
-  VariableDataSize    = 0;\r
-  ListIndex           = 0;\r
-  Offset              = 0;\r
-  VariableData        = NULL;\r
-  NewVariableData     = NULL;\r
+  Status           = EFI_SUCCESS;\r
+  VariableAttr     = 0;\r
+  VariableDataSize = 0;\r
+  ListIndex        = 0;\r
+  Offset           = 0;\r
+  VariableData     = NULL;\r
+  NewVariableData  = NULL;\r
 \r
   if (PrivateData->VariableName == Variable_DB) {\r
     UnicodeSPrint (VariableName, sizeof (VariableName), EFI_IMAGE_SECURITY_DATABASE);\r
@@ -2993,8 +3024,8 @@ DeleteSignatureEx (
                   &VariableAttr,\r
                   &VariableDataSize,\r
                   VariableData\r
-                );\r
-  if (EFI_ERROR (Status) && Status != EFI_BUFFER_TOO_SMALL) {\r
+                  );\r
+  if (EFI_ERROR (Status) && (Status != EFI_BUFFER_TOO_SMALL)) {\r
     goto ON_EXIT;\r
   }\r
 \r
@@ -3010,7 +3041,7 @@ DeleteSignatureEx (
                   &VariableAttr,\r
                   &VariableDataSize,\r
                   VariableData\r
-                );\r
+                  );\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
@@ -3027,7 +3058,7 @@ DeleteSignatureEx (
   }\r
 \r
   RemainingSize = VariableDataSize;\r
-  ListWalker = (EFI_SIGNATURE_LIST *)(VariableData);\r
+  ListWalker    = (EFI_SIGNATURE_LIST *)(VariableData);\r
   if (DelType == Delete_Signature_List_All) {\r
     VariableDataSize = 0;\r
   } else {\r
@@ -3039,7 +3070,7 @@ DeleteSignatureEx (
       Offset += ListWalker->SignatureListSize;\r
 \r
       RemainingSize -= ListWalker->SignatureListSize;\r
-      ListWalker = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize);\r
+      ListWalker     = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize);\r
       ListIndex++;\r
     }\r
 \r
@@ -3048,7 +3079,7 @@ DeleteSignatureEx (
     //  If CheckedCount == SIGNATURE_DATA_COUNTS (ListWalker) or DelType == Delete_Signature_List_One\r
     //  it means delete the whole EFI_SIGNATURE_LIST, So we just skip this EFI_SIGNATURE_LIST.\r
     //\r
-    if (CheckedCount < SIGNATURE_DATA_COUNTS (ListWalker) && DelType == Delete_Signature_Data) {\r
+    if ((CheckedCount < SIGNATURE_DATA_COUNTS (ListWalker)) && (DelType == Delete_Signature_Data)) {\r
       NewCertList = (EFI_SIGNATURE_LIST *)(NewVariableData + Offset);\r
       //\r
       // Copy header.\r
@@ -3056,8 +3087,8 @@ DeleteSignatureEx (
       CopyMem ((UINT8 *)NewVariableData + Offset, ListWalker, sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize);\r
       Offset += sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize;\r
 \r
-      DataWalker = (EFI_SIGNATURE_DATA *)((UINT8 *)ListWalker + sizeof(EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize);\r
-      for (Index = 0; Index < SIGNATURE_DATA_COUNTS(ListWalker); Index = Index + 1) {\r
+      DataWalker = (EFI_SIGNATURE_DATA *)((UINT8 *)ListWalker + sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize);\r
+      for (Index = 0; Index < SIGNATURE_DATA_COUNTS (ListWalker); Index = Index + 1) {\r
         if (PrivateData->CheckArray[Index]) {\r
           //\r
           // Delete checked signature data, and update the size of whole signature list.\r
@@ -3070,17 +3101,18 @@ DeleteSignatureEx (
           CopyMem ((UINT8 *)NewVariableData + Offset, DataWalker, ListWalker->SignatureSize);\r
           Offset += ListWalker->SignatureSize;\r
         }\r
+\r
         DataWalker = (EFI_SIGNATURE_DATA *)((UINT8 *)DataWalker + ListWalker->SignatureSize);\r
       }\r
     }\r
 \r
     RemainingSize -= ListWalker->SignatureListSize;\r
-    ListWalker = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize);\r
+    ListWalker     = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize);\r
 \r
     //\r
     // Copy remaining data, maybe 0.\r
     //\r
-    CopyMem((UINT8 *)NewVariableData + Offset, ListWalker, RemainingSize);\r
+    CopyMem ((UINT8 *)NewVariableData + Offset, ListWalker, RemainingSize);\r
     Offset += RemainingSize;\r
 \r
     VariableDataSize = Offset;\r
@@ -3100,7 +3132,7 @@ DeleteSignatureEx (
                   VariableAttr,\r
                   VariableDataSize,\r
                   NewVariableData\r
-                );\r
+                  );\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "Failed to set variable, Status = %r", Status));\r
     goto ON_EXIT;\r
@@ -3125,18 +3157,18 @@ ON_EXIT:
 \r
 **/\r
 EFI_STATUS\r
-UpdateSecureBootString(\r
+UpdateSecureBootString (\r
   IN SECUREBOOT_CONFIG_PRIVATE_DATA  *Private\r
   )\r
 {\r
-  UINT8       *SecureBoot;\r
+  UINT8  *SecureBoot;\r
 \r
   SecureBoot = NULL;\r
 \r
   //\r
   // Get current secure boot state.\r
   //\r
-  GetVariable2 (EFI_SECURE_BOOT_MODE_NAME, &gEfiGlobalVariableGuid, (VOID**)&SecureBoot, NULL);\r
+  GetVariable2 (EFI_SECURE_BOOT_MODE_NAME, &gEfiGlobalVariableGuid, (VOID **)&SecureBoot, NULL);\r
   if (SecureBoot == NULL) {\r
     return EFI_NOT_FOUND;\r
   }\r
@@ -3147,7 +3179,7 @@ UpdateSecureBootString(
     HiiSetString (Private->HiiHandle, STRING_TOKEN (STR_SECURE_BOOT_STATE_CONTENT), L"Disabled", NULL);\r
   }\r
 \r
-  FreePool(SecureBoot);\r
+  FreePool (SecureBoot);\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -3178,7 +3210,7 @@ SecureBootExtractConfigFromVariable (
   // Initialize the Date and Time using system time.\r
   //\r
   ConfigData->CertificateFormat = HASHALG_RAW;\r
-  ConfigData->AlwaysRevocation = TRUE;\r
+  ConfigData->AlwaysRevocation  = TRUE;\r
   gRT->GetTime (&CurrTime, NULL);\r
   ConfigData->RevocationDate.Year   = CurrTime.Year;\r
   ConfigData->RevocationDate.Month  = CurrTime.Month;\r
@@ -3195,7 +3227,7 @@ SecureBootExtractConfigFromVariable (
   //\r
   // If it is Physical Presence User, set the PhysicalPresent to true.\r
   //\r
-  if (UserPhysicalPresent()) {\r
+  if (UserPhysicalPresent ()) {\r
     ConfigData->PhysicalPresent = TRUE;\r
   } else {\r
     ConfigData->PhysicalPresent = FALSE;\r
@@ -3204,10 +3236,10 @@ SecureBootExtractConfigFromVariable (
   //\r
   // If there is no PK then the Delete Pk button will be gray.\r
   //\r
-  GetVariable2 (EFI_SETUP_MODE_NAME, &gEfiGlobalVariableGuid, (VOID**)&SetupMode, NULL);\r
-  if (SetupMode == NULL || (*SetupMode) == SETUP_MODE) {\r
+  GetVariable2 (EFI_SETUP_MODE_NAME, &gEfiGlobalVariableGuid, (VOID **)&SetupMode, NULL);\r
+  if ((SetupMode == NULL) || ((*SetupMode) == SETUP_MODE)) {\r
     ConfigData->HasPk = FALSE;\r
-  } else  {\r
+  } else {\r
     ConfigData->HasPk = TRUE;\r
   }\r
 \r
@@ -3217,12 +3249,12 @@ SecureBootExtractConfigFromVariable (
   // Checkbox.\r
   //\r
   ConfigData->AttemptSecureBoot = FALSE;\r
-  GetVariable2 (EFI_SECURE_BOOT_ENABLE_NAME, &gEfiSecureBootEnableDisableGuid, (VOID**)&SecureBootEnable, NULL);\r
+  GetVariable2 (EFI_SECURE_BOOT_ENABLE_NAME, &gEfiSecureBootEnableDisableGuid, (VOID **)&SecureBootEnable, NULL);\r
 \r
   //\r
   // Fix Pk and SecureBootEnable inconsistency\r
   //\r
-  if ((SetupMode != NULL) && (*SetupMode) == USER_MODE) {\r
+  if ((SetupMode != NULL) && ((*SetupMode) == USER_MODE)) {\r
     ConfigData->HideSecureBoot = FALSE;\r
     if ((SecureBootEnable != NULL) && (*SecureBootEnable == SECURE_BOOT_ENABLE)) {\r
       ConfigData->AttemptSecureBoot = TRUE;\r
@@ -3234,7 +3266,7 @@ SecureBootExtractConfigFromVariable (
   //\r
   // Get the SecureBootMode from CustomMode variable.\r
   //\r
-  GetVariable2 (EFI_CUSTOM_MODE_NAME, &gEfiCustomModeEnableGuid, (VOID**)&SecureBootMode, NULL);\r
+  GetVariable2 (EFI_CUSTOM_MODE_NAME, &gEfiCustomModeEnableGuid, (VOID **)&SecureBootMode, NULL);\r
   if (SecureBootMode == NULL) {\r
     ConfigData->SecureBootMode = STANDARD_SECURE_BOOT_MODE;\r
   } else {\r
@@ -3244,9 +3276,11 @@ SecureBootExtractConfigFromVariable (
   if (SecureBootEnable != NULL) {\r
     FreePool (SecureBootEnable);\r
   }\r
+\r
   if (SetupMode != NULL) {\r
     FreePool (SetupMode);\r
   }\r
+\r
   if (SecureBootMode != NULL) {\r
     FreePool (SecureBootMode);\r
   }\r
@@ -3281,22 +3315,22 @@ SecureBootExtractConfigFromVariable (
 EFI_STATUS\r
 EFIAPI\r
 SecureBootExtractConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL        *This,\r
-  IN CONST EFI_STRING                            Request,\r
-       OUT EFI_STRING                            *Progress,\r
-       OUT EFI_STRING                            *Results\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Request,\r
+  OUT EFI_STRING                           *Progress,\r
+  OUT EFI_STRING                           *Results\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINTN                             BufferSize;\r
-  UINTN                             Size;\r
-  SECUREBOOT_CONFIGURATION          Configuration;\r
-  EFI_STRING                        ConfigRequest;\r
-  EFI_STRING                        ConfigRequestHdr;\r
-  SECUREBOOT_CONFIG_PRIVATE_DATA    *PrivateData;\r
-  BOOLEAN                           AllocatedRequest;\r
-\r
-  if (Progress == NULL || Results == NULL) {\r
+  EFI_STATUS                      Status;\r
+  UINTN                           BufferSize;\r
+  UINTN                           Size;\r
+  SECUREBOOT_CONFIGURATION        Configuration;\r
+  EFI_STRING                      ConfigRequest;\r
+  EFI_STRING                      ConfigRequestHdr;\r
+  SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData;\r
+  BOOLEAN                         AllocatedRequest;\r
+\r
+  if ((Progress == NULL) || (Results == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -3306,21 +3340,21 @@ SecureBootExtractConfig (
   Size             = 0;\r
 \r
   ZeroMem (&Configuration, sizeof (Configuration));\r
-  PrivateData      = SECUREBOOT_CONFIG_PRIVATE_FROM_THIS (This);\r
-  *Progress        = Request;\r
+  PrivateData = SECUREBOOT_CONFIG_PRIVATE_FROM_THIS (This);\r
+  *Progress   = Request;\r
 \r
   if ((Request != NULL) && !HiiIsConfigHdrMatch (Request, &gSecureBootConfigFormSetGuid, mSecureBootStorageName)) {\r
     return EFI_NOT_FOUND;\r
   }\r
 \r
-  ZeroMem(&Configuration, sizeof(SECUREBOOT_CONFIGURATION));\r
+  ZeroMem (&Configuration, sizeof (SECUREBOOT_CONFIGURATION));\r
 \r
   //\r
   // Get Configuration from Variable.\r
   //\r
   SecureBootExtractConfigFromVariable (PrivateData, &Configuration);\r
 \r
-  BufferSize = sizeof (SECUREBOOT_CONFIGURATION);\r
+  BufferSize    = sizeof (SECUREBOOT_CONFIGURATION);\r
   ConfigRequest = Request;\r
   if ((Request == NULL) || (StrStr (Request, L"OFFSET") == NULL)) {\r
     //\r
@@ -3330,8 +3364,8 @@ SecureBootExtractConfig (
     // followed by "&OFFSET=0&WIDTH=WWWWWWWWWWWWWWWW" followed by a Null-terminator\r
     //\r
     ConfigRequestHdr = HiiConstructConfigHdr (&gSecureBootConfigFormSetGuid, mSecureBootStorageName, PrivateData->DriverHandle);\r
-    Size = (StrLen (ConfigRequestHdr) + 32 + 1) * sizeof (CHAR16);\r
-    ConfigRequest = AllocateZeroPool (Size);\r
+    Size             = (StrLen (ConfigRequestHdr) + 32 + 1) * sizeof (CHAR16);\r
+    ConfigRequest    = AllocateZeroPool (Size);\r
     ASSERT (ConfigRequest != NULL);\r
     AllocatedRequest = TRUE;\r
     UnicodeSPrint (ConfigRequest, Size, L"%s&OFFSET=0&WIDTH=%016LX", ConfigRequestHdr, (UINT64)BufferSize);\r
@@ -3342,7 +3376,7 @@ SecureBootExtractConfig (
   Status = gHiiConfigRouting->BlockToConfig (\r
                                 gHiiConfigRouting,\r
                                 ConfigRequest,\r
-                                (UINT8 *) &Configuration,\r
+                                (UINT8 *)&Configuration,\r
                                 BufferSize,\r
                                 Results,\r
                                 Progress\r
@@ -3388,17 +3422,17 @@ SecureBootExtractConfig (
 EFI_STATUS\r
 EFIAPI\r
 SecureBootRouteConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN CONST EFI_STRING                          Configuration,\r
-       OUT EFI_STRING                          *Progress\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Configuration,\r
+  OUT EFI_STRING                           *Progress\r
   )\r
 {\r
-  SECUREBOOT_CONFIGURATION          IfrNvData;\r
-  UINTN                             BufferSize;\r
-  SECUREBOOT_CONFIG_PRIVATE_DATA    *PrivateData;\r
-  EFI_STATUS                        Status;\r
+  SECUREBOOT_CONFIGURATION        IfrNvData;\r
+  UINTN                           BufferSize;\r
+  SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData;\r
+  EFI_STATUS                      Status;\r
 \r
-  if (Configuration == NULL || Progress == NULL) {\r
+  if ((Configuration == NULL) || (Progress == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -3418,13 +3452,13 @@ SecureBootRouteConfig (
   // Map the Configuration to the configuration block.\r
   //\r
   BufferSize = sizeof (SECUREBOOT_CONFIGURATION);\r
-  Status = gHiiConfigRouting->ConfigToBlock (\r
-                                gHiiConfigRouting,\r
-                                Configuration,\r
-                                (UINT8 *)&IfrNvData,\r
-                                &BufferSize,\r
-                                Progress\r
-                                );\r
+  Status     = gHiiConfigRouting->ConfigToBlock (\r
+                                    gHiiConfigRouting,\r
+                                    Configuration,\r
+                                    (UINT8 *)&IfrNvData,\r
+                                    &BufferSize,\r
+                                    Progress\r
+                                    );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -3456,44 +3490,44 @@ SecureBootRouteConfig (
 **/\r
 EFI_STATUS\r
 LoadSignatureList (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *PrivateData,\r
-  IN UINT16                         LabelId,\r
-  IN EFI_FORM_ID                    FormId,\r
-  IN EFI_QUESTION_ID                QuestionIdBase\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData,\r
+  IN UINT16                          LabelId,\r
+  IN EFI_FORM_ID                     FormId,\r
+  IN EFI_QUESTION_ID                 QuestionIdBase\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  EFI_STRING_ID         ListType;\r
-  EFI_STRING            FormatNameString;\r
-  EFI_STRING            FormatHelpString;\r
-  EFI_STRING            FormatTypeString;\r
-  EFI_SIGNATURE_LIST    *ListWalker;\r
-  EFI_IFR_GUID_LABEL    *StartLabel;\r
-  EFI_IFR_GUID_LABEL    *EndLabel;\r
-  EFI_IFR_GUID_LABEL    *StartGoto;\r
-  EFI_IFR_GUID_LABEL    *EndGoto;\r
-  EFI_FORM_ID           DstFormId;\r
-  VOID                  *StartOpCodeHandle;\r
-  VOID                  *EndOpCodeHandle;\r
-  VOID                  *StartGotoHandle;\r
-  VOID                  *EndGotoHandle;\r
-  UINTN                 DataSize;\r
-  UINTN                 RemainingSize;\r
-  UINT16                Index;\r
-  UINT8                 *VariableData;\r
-  CHAR16                VariableName[BUFFER_MAX_SIZE];\r
-  CHAR16                NameBuffer[BUFFER_MAX_SIZE];\r
-  CHAR16                HelpBuffer[BUFFER_MAX_SIZE];\r
-\r
-  Status                = EFI_SUCCESS;\r
-  FormatNameString      = NULL;\r
-  FormatHelpString      = NULL;\r
-  StartOpCodeHandle     = NULL;\r
-  EndOpCodeHandle       = NULL;\r
-  StartGotoHandle       = NULL;\r
-  EndGotoHandle         = NULL;\r
-  Index                 = 0;\r
-  VariableData          = NULL;\r
+  EFI_STATUS          Status;\r
+  EFI_STRING_ID       ListType;\r
+  EFI_STRING          FormatNameString;\r
+  EFI_STRING          FormatHelpString;\r
+  EFI_STRING          FormatTypeString;\r
+  EFI_SIGNATURE_LIST  *ListWalker;\r
+  EFI_IFR_GUID_LABEL  *StartLabel;\r
+  EFI_IFR_GUID_LABEL  *EndLabel;\r
+  EFI_IFR_GUID_LABEL  *StartGoto;\r
+  EFI_IFR_GUID_LABEL  *EndGoto;\r
+  EFI_FORM_ID         DstFormId;\r
+  VOID                *StartOpCodeHandle;\r
+  VOID                *EndOpCodeHandle;\r
+  VOID                *StartGotoHandle;\r
+  VOID                *EndGotoHandle;\r
+  UINTN               DataSize;\r
+  UINTN               RemainingSize;\r
+  UINT16              Index;\r
+  UINT8               *VariableData;\r
+  CHAR16              VariableName[BUFFER_MAX_SIZE];\r
+  CHAR16              NameBuffer[BUFFER_MAX_SIZE];\r
+  CHAR16              HelpBuffer[BUFFER_MAX_SIZE];\r
+\r
+  Status            = EFI_SUCCESS;\r
+  FormatNameString  = NULL;\r
+  FormatHelpString  = NULL;\r
+  StartOpCodeHandle = NULL;\r
+  EndOpCodeHandle   = NULL;\r
+  StartGotoHandle   = NULL;\r
+  EndGotoHandle     = NULL;\r
+  Index             = 0;\r
+  VariableData      = NULL;\r
 \r
   //\r
   // Initialize the container for dynamic opcodes.\r
@@ -3530,36 +3564,36 @@ LoadSignatureList (
                                        &gEfiIfrTianoGuid,\r
                                        NULL,\r
                                        sizeof (EFI_IFR_GUID_LABEL)\r
-                                     );\r
-  StartLabel->ExtendOpCode  = EFI_IFR_EXTEND_OP_LABEL;\r
-  StartLabel->Number        = LabelId;\r
+                                       );\r
+  StartLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
+  StartLabel->Number       = LabelId;\r
 \r
   EndLabel = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
                                      EndOpCodeHandle,\r
                                      &gEfiIfrTianoGuid,\r
                                      NULL,\r
                                      sizeof (EFI_IFR_GUID_LABEL)\r
-                                   );\r
-  EndLabel->ExtendOpCode  = EFI_IFR_EXTEND_OP_LABEL;\r
-  EndLabel->Number        = LABEL_END;\r
+                                     );\r
+  EndLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
+  EndLabel->Number       = LABEL_END;\r
 \r
-  StartGoto = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode(\r
+  StartGoto = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
                                       StartGotoHandle,\r
                                       &gEfiIfrTianoGuid,\r
                                       NULL,\r
-                                      sizeof(EFI_IFR_GUID_LABEL)\r
-                                    );\r
-  StartGoto->ExtendOpCode  = EFI_IFR_EXTEND_OP_LABEL;\r
-  StartGoto->Number        = LABEL_DELETE_ALL_LIST_BUTTON;\r
+                                      sizeof (EFI_IFR_GUID_LABEL)\r
+                                      );\r
+  StartGoto->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
+  StartGoto->Number       = LABEL_DELETE_ALL_LIST_BUTTON;\r
 \r
-  EndGoto = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode(\r
+  EndGoto = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
                                     EndGotoHandle,\r
                                     &gEfiIfrTianoGuid,\r
                                     NULL,\r
-                                    sizeof(EFI_IFR_GUID_LABEL)\r
-                                  );\r
+                                    sizeof (EFI_IFR_GUID_LABEL)\r
+                                    );\r
   EndGoto->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
-  EndGoto->Number = LABEL_END;\r
+  EndGoto->Number       = LABEL_END;\r
 \r
   if (PrivateData->VariableName == Variable_DB) {\r
     UnicodeSPrint (VariableName, sizeof (VariableName), EFI_IMAGE_SECURITY_DATABASE);\r
@@ -3581,14 +3615,14 @@ LoadSignatureList (
     STRING_TOKEN (STR_SECURE_BOOT_DELETE_ALL_LIST),\r
     EFI_IFR_FLAG_CALLBACK,\r
     KEY_SECURE_BOOT_DELETE_ALL_LIST\r
-  );\r
+    );\r
 \r
   //\r
   // Read Variable, the variable name save in the PrivateData->VariableName.\r
   //\r
   DataSize = 0;\r
-  Status = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, VariableData);\r
-  if (EFI_ERROR (Status) && Status != EFI_BUFFER_TOO_SMALL) {\r
+  Status   = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, VariableData);\r
+  if (EFI_ERROR (Status) && (Status != EFI_BUFFER_TOO_SMALL)) {\r
     goto ON_EXIT;\r
   }\r
 \r
@@ -3597,6 +3631,7 @@ LoadSignatureList (
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
+\r
   Status = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, VariableData);\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
@@ -3604,7 +3639,7 @@ LoadSignatureList (
 \r
   FormatNameString = HiiGetString (PrivateData->HiiHandle, STRING_TOKEN (STR_SIGNATURE_LIST_NAME_FORMAT), NULL);\r
   FormatHelpString = HiiGetString (PrivateData->HiiHandle, STRING_TOKEN (STR_SIGNATURE_LIST_HELP_FORMAT), NULL);\r
-  if (FormatNameString == NULL || FormatHelpString == NULL) {\r
+  if ((FormatNameString == NULL) || (FormatHelpString == NULL)) {\r
     goto ON_EXIT;\r
   }\r
 \r
@@ -3628,6 +3663,7 @@ LoadSignatureList (
     } else {\r
       ListType = STRING_TOKEN (STR_LIST_TYPE_UNKNOWN);\r
     }\r
+\r
     FormatTypeString = HiiGetString (PrivateData->HiiHandle, ListType, NULL);\r
     if (FormatTypeString == NULL) {\r
       goto ON_EXIT;\r
@@ -3637,12 +3673,13 @@ LoadSignatureList (
     UnicodeSPrint (NameBuffer, sizeof (NameBuffer), FormatNameString, Index + 1);\r
 \r
     ZeroMem (HelpBuffer, sizeof (HelpBuffer));\r
-    UnicodeSPrint (HelpBuffer,\r
+    UnicodeSPrint (\r
+      HelpBuffer,\r
       sizeof (HelpBuffer),\r
       FormatHelpString,\r
       FormatTypeString,\r
       SIGNATURE_DATA_COUNTS (ListWalker)\r
-    );\r
+      );\r
     SECUREBOOT_FREE_NON_NULL (FormatTypeString);\r
     FormatTypeString = NULL;\r
 \r
@@ -3653,10 +3690,10 @@ LoadSignatureList (
       HiiSetString (PrivateData->HiiHandle, 0, HelpBuffer, NULL),\r
       EFI_IFR_FLAG_CALLBACK,\r
       QuestionIdBase + Index++\r
-    );\r
+      );\r
 \r
     RemainingSize -= ListWalker->SignatureListSize;\r
-    ListWalker = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize);\r
+    ListWalker     = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize);\r
   }\r
 \r
 ON_EXIT:\r
@@ -3666,7 +3703,7 @@ ON_EXIT:
     FormId,\r
     StartOpCodeHandle,\r
     EndOpCodeHandle\r
-  );\r
+    );\r
 \r
   HiiUpdateForm (\r
     PrivateData->HiiHandle,\r
@@ -3674,7 +3711,7 @@ ON_EXIT:
     FormId,\r
     StartGotoHandle,\r
     EndGotoHandle\r
-  );\r
+    );\r
 \r
   SECUREBOOT_FREE_NON_OPCODE (StartOpCodeHandle);\r
   SECUREBOOT_FREE_NON_OPCODE (EndOpCodeHandle);\r
@@ -3704,47 +3741,49 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 ParseHashValue (\r
-  IN     EFI_SIGNATURE_LIST    *ListEntry,\r
-  IN     EFI_SIGNATURE_DATA    *DataEntry,\r
-     OUT CHAR16                **BufferToReturn\r
+  IN     EFI_SIGNATURE_LIST  *ListEntry,\r
+  IN     EFI_SIGNATURE_DATA  *DataEntry,\r
+  OUT CHAR16                 **BufferToReturn\r
   )\r
 {\r
-  UINTN       Index;\r
-  UINTN       BufferIndex;\r
-  UINTN       TotalSize;\r
-  UINTN       DataSize;\r
-  UINTN       Line;\r
-  UINTN       OneLineBytes;\r
+  UINTN  Index;\r
+  UINTN  BufferIndex;\r
+  UINTN  TotalSize;\r
+  UINTN  DataSize;\r
+  UINTN  Line;\r
+  UINTN  OneLineBytes;\r
 \r
   //\r
   //  Assume that, display 8 bytes in one line.\r
   //\r
   OneLineBytes = 8;\r
 \r
-  if (ListEntry == NULL || DataEntry == NULL || BufferToReturn == NULL) {\r
+  if ((ListEntry == NULL) || (DataEntry == NULL) || (BufferToReturn == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
-  DataSize = ListEntry->SignatureSize - sizeof(EFI_GUID);\r
-  Line = (DataSize + OneLineBytes - 1) / OneLineBytes;\r
+  DataSize = ListEntry->SignatureSize - sizeof (EFI_GUID);\r
+  Line     = (DataSize + OneLineBytes - 1) / OneLineBytes;\r
 \r
   //\r
   // Each byte will split two Hex-number, and each line need additional memory to save '\r\n'.\r
   //\r
-  TotalSize = ((DataSize + Line) * 2 * sizeof(CHAR16));\r
+  TotalSize = ((DataSize + Line) * 2 * sizeof (CHAR16));\r
 \r
-  *BufferToReturn = AllocateZeroPool(TotalSize);\r
+  *BufferToReturn = AllocateZeroPool (TotalSize);\r
   if (*BufferToReturn == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
   for (Index = 0, BufferIndex = 0; Index < DataSize; Index = Index + 1) {\r
     if ((Index > 0) && (Index % OneLineBytes == 0)) {\r
-      BufferIndex += UnicodeSPrint(&(*BufferToReturn)[BufferIndex], TotalSize - sizeof(CHAR16) * BufferIndex, L"\n");\r
+      BufferIndex += UnicodeSPrint (&(*BufferToReturn)[BufferIndex], TotalSize - sizeof (CHAR16) * BufferIndex, L"\n");\r
     }\r
-    BufferIndex += UnicodeSPrint(&(*BufferToReturn)[BufferIndex], TotalSize - sizeof(CHAR16) * BufferIndex, L"%02x", DataEntry->SignatureData[Index]);\r
+\r
+    BufferIndex += UnicodeSPrint (&(*BufferToReturn)[BufferIndex], TotalSize - sizeof (CHAR16) * BufferIndex, L"%02x", DataEntry->SignatureData[Index]);\r
   }\r
-  BufferIndex += UnicodeSPrint(&(*BufferToReturn)[BufferIndex], TotalSize - sizeof(CHAR16) * BufferIndex, L"\n");\r
+\r
+  BufferIndex += UnicodeSPrint (&(*BufferToReturn)[BufferIndex], TotalSize - sizeof (CHAR16) * BufferIndex, L"\n");\r
 \r
   return EFI_SUCCESS;\r
 }\r
@@ -3764,19 +3803,19 @@ ParseHashValue (
 **/\r
 EFI_STATUS\r
 GetCommonNameFromX509 (\r
-  IN     EFI_SIGNATURE_LIST    *ListEntry,\r
-  IN     EFI_SIGNATURE_DATA    *DataEntry,\r
-     OUT CHAR16                **BufferToReturn\r
+  IN     EFI_SIGNATURE_LIST  *ListEntry,\r
+  IN     EFI_SIGNATURE_DATA  *DataEntry,\r
+  OUT CHAR16                 **BufferToReturn\r
   )\r
 {\r
-  EFI_STATUS      Status;\r
-  CHAR8           *CNBuffer;\r
-  UINTN           CNBufferSize;\r
+  EFI_STATUS  Status;\r
+  CHAR8       *CNBuffer;\r
+  UINTN       CNBufferSize;\r
 \r
-  Status        = EFI_SUCCESS;\r
-  CNBuffer      = NULL;\r
+  Status   = EFI_SUCCESS;\r
+  CNBuffer = NULL;\r
 \r
-  CNBuffer = AllocateZeroPool(256);\r
+  CNBuffer = AllocateZeroPool (256);\r
   if (CNBuffer == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
@@ -3784,13 +3823,13 @@ GetCommonNameFromX509 (
 \r
   CNBufferSize = 256;\r
   X509GetCommonName (\r
-    (UINT8 *)DataEntry + sizeof(EFI_GUID),\r
-    ListEntry->SignatureSize - sizeof(EFI_GUID),\r
+    (UINT8 *)DataEntry + sizeof (EFI_GUID),\r
+    ListEntry->SignatureSize - sizeof (EFI_GUID),\r
     CNBuffer,\r
     &CNBufferSize\r
-  );\r
+    );\r
 \r
-  *BufferToReturn = AllocateZeroPool(256 * sizeof(CHAR16));\r
+  *BufferToReturn = AllocateZeroPool (256 * sizeof (CHAR16));\r
   if (*BufferToReturn == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
@@ -3820,60 +3859,60 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 FormatHelpInfo (\r
-  IN     SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData,\r
-  IN     EFI_SIGNATURE_LIST               *ListEntry,\r
-  IN     EFI_SIGNATURE_DATA               *DataEntry,\r
-     OUT EFI_STRING_ID                    *StringId\r
+  IN     SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData,\r
+  IN     EFI_SIGNATURE_LIST              *ListEntry,\r
+  IN     EFI_SIGNATURE_DATA              *DataEntry,\r
+  OUT EFI_STRING_ID                      *StringId\r
   )\r
 {\r
-  EFI_STATUS      Status;\r
-  EFI_TIME        *Time;\r
-  EFI_STRING_ID   ListTypeId;\r
-  EFI_STRING      FormatHelpString;\r
-  EFI_STRING      FormatTypeString;\r
-  UINTN           DataSize;\r
-  UINTN           HelpInfoIndex;\r
-  UINTN           TotalSize;\r
-  CHAR16          GuidString[BUFFER_MAX_SIZE];\r
-  CHAR16          TimeString[BUFFER_MAX_SIZE];\r
-  CHAR16          *DataString;\r
-  CHAR16          *HelpInfoString;\r
-  BOOLEAN         IsCert;\r
-\r
-  Status            = EFI_SUCCESS;\r
-  Time              = NULL;\r
-  FormatTypeString  = NULL;\r
-  HelpInfoIndex     = 0;\r
-  DataString        = NULL;\r
-  HelpInfoString    = NULL;\r
-  IsCert            = FALSE;\r
-\r
-  if (CompareGuid(&ListEntry->SignatureType, &gEfiCertRsa2048Guid)) {\r
-    ListTypeId = STRING_TOKEN(STR_LIST_TYPE_RSA2048_SHA256);\r
-    DataSize = ListEntry->SignatureSize - sizeof(EFI_GUID);\r
-    IsCert = TRUE;\r
-  } else if (CompareGuid(&ListEntry->SignatureType, &gEfiCertX509Guid)) {\r
-    ListTypeId = STRING_TOKEN(STR_LIST_TYPE_X509);\r
-    DataSize = ListEntry->SignatureSize - sizeof(EFI_GUID);\r
-    IsCert = TRUE;\r
-  } else if (CompareGuid(&ListEntry->SignatureType, &gEfiCertSha1Guid)) {\r
-    ListTypeId = STRING_TOKEN(STR_LIST_TYPE_SHA1);\r
-    DataSize = 20;\r
-  } else if (CompareGuid(&ListEntry->SignatureType, &gEfiCertSha256Guid)) {\r
-    ListTypeId = STRING_TOKEN(STR_LIST_TYPE_SHA256);\r
-    DataSize = 32;\r
-  } else if (CompareGuid(&ListEntry->SignatureType, &gEfiCertX509Sha256Guid)) {\r
-    ListTypeId = STRING_TOKEN(STR_LIST_TYPE_X509_SHA256);\r
-    DataSize = 32;\r
-    Time = (EFI_TIME *)(DataEntry->SignatureData + DataSize);\r
-  } else if (CompareGuid(&ListEntry->SignatureType, &gEfiCertX509Sha384Guid)) {\r
-    ListTypeId = STRING_TOKEN(STR_LIST_TYPE_X509_SHA384);\r
-    DataSize = 48;\r
-    Time = (EFI_TIME *)(DataEntry->SignatureData + DataSize);\r
-  } else if (CompareGuid(&ListEntry->SignatureType, &gEfiCertX509Sha512Guid)) {\r
-    ListTypeId = STRING_TOKEN(STR_LIST_TYPE_X509_SHA512);\r
-    DataSize = 64;\r
-    Time = (EFI_TIME *)(DataEntry->SignatureData + DataSize);\r
+  EFI_STATUS     Status;\r
+  EFI_TIME       *Time;\r
+  EFI_STRING_ID  ListTypeId;\r
+  EFI_STRING     FormatHelpString;\r
+  EFI_STRING     FormatTypeString;\r
+  UINTN          DataSize;\r
+  UINTN          HelpInfoIndex;\r
+  UINTN          TotalSize;\r
+  CHAR16         GuidString[BUFFER_MAX_SIZE];\r
+  CHAR16         TimeString[BUFFER_MAX_SIZE];\r
+  CHAR16         *DataString;\r
+  CHAR16         *HelpInfoString;\r
+  BOOLEAN        IsCert;\r
+\r
+  Status           = EFI_SUCCESS;\r
+  Time             = NULL;\r
+  FormatTypeString = NULL;\r
+  HelpInfoIndex    = 0;\r
+  DataString       = NULL;\r
+  HelpInfoString   = NULL;\r
+  IsCert           = FALSE;\r
+\r
+  if (CompareGuid (&ListEntry->SignatureType, &gEfiCertRsa2048Guid)) {\r
+    ListTypeId = STRING_TOKEN (STR_LIST_TYPE_RSA2048_SHA256);\r
+    DataSize   = ListEntry->SignatureSize - sizeof (EFI_GUID);\r
+    IsCert     = TRUE;\r
+  } else if (CompareGuid (&ListEntry->SignatureType, &gEfiCertX509Guid)) {\r
+    ListTypeId = STRING_TOKEN (STR_LIST_TYPE_X509);\r
+    DataSize   = ListEntry->SignatureSize - sizeof (EFI_GUID);\r
+    IsCert     = TRUE;\r
+  } else if (CompareGuid (&ListEntry->SignatureType, &gEfiCertSha1Guid)) {\r
+    ListTypeId = STRING_TOKEN (STR_LIST_TYPE_SHA1);\r
+    DataSize   = 20;\r
+  } else if (CompareGuid (&ListEntry->SignatureType, &gEfiCertSha256Guid)) {\r
+    ListTypeId = STRING_TOKEN (STR_LIST_TYPE_SHA256);\r
+    DataSize   = 32;\r
+  } else if (CompareGuid (&ListEntry->SignatureType, &gEfiCertX509Sha256Guid)) {\r
+    ListTypeId = STRING_TOKEN (STR_LIST_TYPE_X509_SHA256);\r
+    DataSize   = 32;\r
+    Time       = (EFI_TIME *)(DataEntry->SignatureData + DataSize);\r
+  } else if (CompareGuid (&ListEntry->SignatureType, &gEfiCertX509Sha384Guid)) {\r
+    ListTypeId = STRING_TOKEN (STR_LIST_TYPE_X509_SHA384);\r
+    DataSize   = 48;\r
+    Time       = (EFI_TIME *)(DataEntry->SignatureData + DataSize);\r
+  } else if (CompareGuid (&ListEntry->SignatureType, &gEfiCertX509Sha512Guid)) {\r
+    ListTypeId = STRING_TOKEN (STR_LIST_TYPE_X509_SHA512);\r
+    DataSize   = 64;\r
+    Time       = (EFI_TIME *)(DataEntry->SignatureData + DataSize);\r
   } else {\r
     Status = EFI_UNSUPPORTED;\r
     goto ON_EXIT;\r
@@ -3884,7 +3923,7 @@ FormatHelpInfo (
     goto ON_EXIT;\r
   }\r
 \r
-  TotalSize = 1024;\r
+  TotalSize      = 1024;\r
   HelpInfoString = AllocateZeroPool (TotalSize);\r
   if (HelpInfoString == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
@@ -3895,17 +3934,18 @@ FormatHelpInfo (
   // Format GUID part.\r
   //\r
   ZeroMem (GuidString, sizeof (GuidString));\r
-  GuidToString(&DataEntry->SignatureOwner, GuidString, BUFFER_MAX_SIZE);\r
+  GuidToString (&DataEntry->SignatureOwner, GuidString, BUFFER_MAX_SIZE);\r
   FormatHelpString = HiiGetString (PrivateData->HiiHandle, STRING_TOKEN (STR_SIGNATURE_DATA_HELP_FORMAT_GUID), NULL);\r
   if (FormatHelpString == NULL) {\r
     goto ON_EXIT;\r
   }\r
+\r
   HelpInfoIndex += UnicodeSPrint (\r
                      &HelpInfoString[HelpInfoIndex],\r
-                     TotalSize - sizeof(CHAR16) * HelpInfoIndex,\r
+                     TotalSize - sizeof (CHAR16) * HelpInfoIndex,\r
                      FormatHelpString,\r
                      GuidString\r
-                   );\r
+                     );\r
   SECUREBOOT_FREE_NON_NULL (FormatHelpString);\r
   FormatHelpString = NULL;\r
 \r
@@ -3922,9 +3962,11 @@ FormatHelpInfo (
     ParseHashValue (ListEntry, DataEntry, &DataString);\r
     FormatHelpString = HiiGetString (PrivateData->HiiHandle, STRING_TOKEN (STR_SIGNATURE_DATA_HELP_FORMAT_HASH), NULL);\r
   }\r
+\r
   if (FormatHelpString == NULL) {\r
     goto ON_EXIT;\r
   }\r
+\r
   HelpInfoIndex += UnicodeSPrint (\r
                      &HelpInfoString[HelpInfoIndex],\r
                      TotalSize - sizeof (CHAR16) * HelpInfoIndex,\r
@@ -3932,7 +3974,7 @@ FormatHelpInfo (
                      FormatTypeString,\r
                      DataSize,\r
                      DataString\r
-                   );\r
+                     );\r
   SECUREBOOT_FREE_NON_NULL (FormatHelpString);\r
   FormatHelpString = NULL;\r
 \r
@@ -3951,17 +3993,18 @@ FormatHelpInfo (
       Time->Hour,\r
       Time->Minute,\r
       Time->Second\r
-    );\r
+      );\r
     FormatHelpString = HiiGetString (PrivateData->HiiHandle, STRING_TOKEN (STR_SIGNATURE_DATA_HELP_FORMAT_TIME), NULL);\r
     if (FormatHelpString == NULL) {\r
       goto ON_EXIT;\r
     }\r
+\r
     UnicodeSPrint (\r
       &HelpInfoString[HelpInfoIndex],\r
       TotalSize - sizeof (CHAR16) * HelpInfoIndex,\r
       FormatHelpString,\r
       TimeString\r
-    );\r
+      );\r
     SECUREBOOT_FREE_NON_NULL (FormatHelpString);\r
     FormatHelpString = NULL;\r
   }\r
@@ -3990,35 +4033,35 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 LoadSignatureData (\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA *PrivateData,\r
-  IN UINT16                         LabelId,\r
-  IN EFI_FORM_ID                    FormId,\r
-  IN EFI_QUESTION_ID                QuestionIdBase,\r
-  IN UINT16                         ListIndex\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData,\r
+  IN UINT16                          LabelId,\r
+  IN EFI_FORM_ID                     FormId,\r
+  IN EFI_QUESTION_ID                 QuestionIdBase,\r
+  IN UINT16                          ListIndex\r
   )\r
 {\r
-  EFI_STATUS            Status;\r
-  EFI_SIGNATURE_LIST    *ListWalker;\r
-  EFI_SIGNATURE_DATA    *DataWalker;\r
-  EFI_IFR_GUID_LABEL    *StartLabel;\r
-  EFI_IFR_GUID_LABEL    *EndLabel;\r
-  EFI_STRING_ID         HelpStringId;\r
-  EFI_STRING            FormatNameString;\r
-  VOID                  *StartOpCodeHandle;\r
-  VOID                  *EndOpCodeHandle;\r
-  UINTN                 DataSize;\r
-  UINTN                 RemainingSize;\r
-  UINT16                Index;\r
-  UINT8                 *VariableData;\r
-  CHAR16                VariableName[BUFFER_MAX_SIZE];\r
-  CHAR16                NameBuffer[BUFFER_MAX_SIZE];\r
-\r
-  Status              = EFI_SUCCESS;\r
-  FormatNameString    = NULL;\r
-  StartOpCodeHandle   = NULL;\r
-  EndOpCodeHandle     = NULL;\r
-  Index               = 0;\r
-  VariableData        = NULL;\r
+  EFI_STATUS          Status;\r
+  EFI_SIGNATURE_LIST  *ListWalker;\r
+  EFI_SIGNATURE_DATA  *DataWalker;\r
+  EFI_IFR_GUID_LABEL  *StartLabel;\r
+  EFI_IFR_GUID_LABEL  *EndLabel;\r
+  EFI_STRING_ID       HelpStringId;\r
+  EFI_STRING          FormatNameString;\r
+  VOID                *StartOpCodeHandle;\r
+  VOID                *EndOpCodeHandle;\r
+  UINTN               DataSize;\r
+  UINTN               RemainingSize;\r
+  UINT16              Index;\r
+  UINT8               *VariableData;\r
+  CHAR16              VariableName[BUFFER_MAX_SIZE];\r
+  CHAR16              NameBuffer[BUFFER_MAX_SIZE];\r
+\r
+  Status            = EFI_SUCCESS;\r
+  FormatNameString  = NULL;\r
+  StartOpCodeHandle = NULL;\r
+  EndOpCodeHandle   = NULL;\r
+  Index             = 0;\r
+  VariableData      = NULL;\r
 \r
   //\r
   // Initialize the container for dynamic opcodes.\r
@@ -4043,18 +4086,18 @@ LoadSignatureData (
                                        &gEfiIfrTianoGuid,\r
                                        NULL,\r
                                        sizeof (EFI_IFR_GUID_LABEL)\r
-                                     );\r
-  StartLabel->ExtendOpCode  = EFI_IFR_EXTEND_OP_LABEL;\r
-  StartLabel->Number        = LabelId;\r
+                                       );\r
+  StartLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
+  StartLabel->Number       = LabelId;\r
 \r
   EndLabel = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
                                      EndOpCodeHandle,\r
                                      &gEfiIfrTianoGuid,\r
                                      NULL,\r
                                      sizeof (EFI_IFR_GUID_LABEL)\r
-                                   );\r
-  EndLabel->ExtendOpCode  = EFI_IFR_EXTEND_OP_LABEL;\r
-  EndLabel->Number        = LABEL_END;\r
+                                     );\r
+  EndLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
+  EndLabel->Number       = LABEL_END;\r
 \r
   if (PrivateData->VariableName == Variable_DB) {\r
     UnicodeSPrint (VariableName, sizeof (VariableName), EFI_IMAGE_SECURITY_DATABASE);\r
@@ -4070,8 +4113,8 @@ LoadSignatureData (
   // Read Variable, the variable name save in the PrivateData->VariableName.\r
   //\r
   DataSize = 0;\r
-  Status = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, VariableData);\r
-  if (EFI_ERROR (Status) && Status != EFI_BUFFER_TOO_SMALL) {\r
+  Status   = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, VariableData);\r
+  if (EFI_ERROR (Status) && (Status != EFI_BUFFER_TOO_SMALL)) {\r
     goto ON_EXIT;\r
   }\r
 \r
@@ -4080,20 +4123,21 @@ LoadSignatureData (
     Status = EFI_OUT_OF_RESOURCES;\r
     goto ON_EXIT;\r
   }\r
+\r
   Status = gRT->GetVariable (VariableName, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, VariableData);\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
 \r
   RemainingSize = DataSize;\r
-  ListWalker = (EFI_SIGNATURE_LIST *)VariableData;\r
+  ListWalker    = (EFI_SIGNATURE_LIST *)VariableData;\r
 \r
   //\r
   // Skip signature list.\r
   //\r
   while ((RemainingSize > 0) && (RemainingSize >= ListWalker->SignatureListSize) && ListIndex-- > 0) {\r
     RemainingSize -= ListWalker->SignatureListSize;\r
-    ListWalker = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize);\r
+    ListWalker     = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize);\r
   }\r
 \r
   FormatNameString = HiiGetString (PrivateData->HiiHandle, STRING_TOKEN (STR_SIGNATURE_DATA_NAME_FORMAT), NULL);\r
@@ -4101,8 +4145,8 @@ LoadSignatureData (
     goto ON_EXIT;\r
   }\r
 \r
-  DataWalker = (EFI_SIGNATURE_DATA *)((UINT8 *)ListWalker + sizeof(EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize);\r
-  for (Index = 0; Index < SIGNATURE_DATA_COUNTS(ListWalker); Index = Index + 1) {\r
+  DataWalker = (EFI_SIGNATURE_DATA *)((UINT8 *)ListWalker + sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize);\r
+  for (Index = 0; Index < SIGNATURE_DATA_COUNTS (ListWalker); Index = Index + 1) {\r
     //\r
     // Format name buffer.\r
     //\r
@@ -4127,9 +4171,9 @@ LoadSignatureData (
       EFI_IFR_FLAG_CALLBACK,\r
       0,\r
       NULL\r
-    );\r
+      );\r
 \r
-    ZeroMem(NameBuffer, 100);\r
+    ZeroMem (NameBuffer, 100);\r
     DataWalker = (EFI_SIGNATURE_DATA *)((UINT8 *)DataWalker + ListWalker->SignatureSize);\r
   }\r
 \r
@@ -4145,7 +4189,7 @@ ON_EXIT:
     FormId,\r
     StartOpCodeHandle,\r
     EndOpCodeHandle\r
-  );\r
+    );\r
 \r
   SECUREBOOT_FREE_NON_OPCODE (StartOpCodeHandle);\r
   SECUREBOOT_FREE_NON_OPCODE (EndOpCodeHandle);\r
@@ -4174,7 +4218,7 @@ KeyEnrollReset (
   Status = EFI_SUCCESS;\r
 \r
   Status = SetSecureBootMode (CUSTOM_SECURE_BOOT_MODE);\r
-  if (EFI_ERROR(Status)) {\r
+  if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
 \r
@@ -4212,20 +4256,26 @@ KeyEnrollReset (
   // After PK clear, Setup Mode shall be enabled\r
   Status = GetSetupMode (&SetupMode);\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "Cannot get SetupMode variable: %r\n",\r
-      Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "Cannot get SetupMode variable: %r\n",\r
+      Status\r
+      ));\r
     return Status;\r
   }\r
 \r
   if (SetupMode == USER_MODE) {\r
-    DEBUG((DEBUG_INFO, "Skipped - USER_MODE\n"));\r
+    DEBUG ((DEBUG_INFO, "Skipped - USER_MODE\n"));\r
     return EFI_SUCCESS;\r
   }\r
 \r
   Status = SetSecureBootMode (CUSTOM_SECURE_BOOT_MODE);\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "Cannot set CUSTOM_SECURE_BOOT_MODE: %r\n",\r
-      Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "Cannot set CUSTOM_SECURE_BOOT_MODE: %r\n",\r
+      Status\r
+      ));\r
     return EFI_SUCCESS;\r
   }\r
 \r
@@ -4260,8 +4310,11 @@ KeyEnrollReset (
 \r
   Status = SetSecureBootMode (STANDARD_SECURE_BOOT_MODE);\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "Cannot set CustomMode to STANDARD_SECURE_BOOT_MODE\n"\r
-      "Please do it manually, otherwise system can be easily compromised\n"));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "Cannot set CustomMode to STANDARD_SECURE_BOOT_MODE\n"\r
+      "Please do it manually, otherwise system can be easily compromised\n"\r
+      ));\r
   }\r
 \r
   return Status;\r
@@ -4278,6 +4331,7 @@ error:
   if (SetSecureBootMode (STANDARD_SECURE_BOOT_MODE) != EFI_SUCCESS) {\r
     DEBUG ((DEBUG_ERROR, "Cannot set mode to Secure: %r\n", Status));\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -4306,12 +4360,12 @@ error:
 EFI_STATUS\r
 EFIAPI\r
 SecureBootCallback (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN     EFI_BROWSER_ACTION                    Action,\r
-  IN     EFI_QUESTION_ID                       QuestionId,\r
-  IN     UINT8                                 Type,\r
-  IN     EFI_IFR_TYPE_VALUE                    *Value,\r
-     OUT EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN     EFI_BROWSER_ACTION                Action,\r
+  IN     EFI_QUESTION_ID                   QuestionId,\r
+  IN     UINT8                             Type,\r
+  IN     EFI_IFR_TYPE_VALUE                *Value,\r
+  OUT EFI_BROWSER_ACTION_REQUEST           *ActionRequest\r
   )\r
 {\r
   EFI_INPUT_KEY                   Key;\r
@@ -4354,19 +4408,19 @@ SecureBootCallback (
   // Retrieve uncommitted data from Browser\r
   //\r
   BufferSize = sizeof (SECUREBOOT_CONFIGURATION);\r
-  IfrNvData = AllocateZeroPool (BufferSize);\r
+  IfrNvData  = AllocateZeroPool (BufferSize);\r
   if (IfrNvData == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  GetBrowserDataResult = HiiGetBrowserData (&gSecureBootConfigFormSetGuid, mSecureBootStorageName, BufferSize, (UINT8 *) IfrNvData);\r
+  GetBrowserDataResult = HiiGetBrowserData (&gSecureBootConfigFormSetGuid, mSecureBootStorageName, BufferSize, (UINT8 *)IfrNvData);\r
 \r
   if (Action == EFI_BROWSER_ACTION_FORM_OPEN) {\r
     if (QuestionId == KEY_SECURE_BOOT_MODE) {\r
       //\r
       // Update secure boot strings when opening this form\r
       //\r
-      Status = UpdateSecureBootString(Private);\r
+      Status = UpdateSecureBootString (Private);\r
       SecureBootExtractConfigFromVariable (Private, IfrNvData);\r
       mIsEnterSecureBootForm = TRUE;\r
     } else {\r
@@ -4378,8 +4432,9 @@ SecureBootCallback (
           (QuestionId == KEY_SECURE_BOOT_KEK_OPTION) ||\r
           (QuestionId == KEY_SECURE_BOOT_DB_OPTION) ||\r
           (QuestionId == KEY_SECURE_BOOT_DBX_OPTION) ||\r
-          (QuestionId == KEY_SECURE_BOOT_DBT_OPTION)) {\r
-        CloseEnrolledFile(Private->FileContext);\r
+          (QuestionId == KEY_SECURE_BOOT_DBT_OPTION))\r
+      {\r
+        CloseEnrolledFile (Private->FileContext);\r
       } else if (QuestionId == KEY_SECURE_BOOT_DELETE_ALL_LIST) {\r
         //\r
         // Update ListCount field in varstore\r
@@ -4389,6 +4444,7 @@ SecureBootCallback (
         IfrNvData->ListCount = Private->ListCount;\r
       }\r
     }\r
+\r
     goto EXIT;\r
   }\r
 \r
@@ -4397,541 +4453,567 @@ SecureBootCallback (
     if (QuestionId == KEY_SECURE_BOOT_MODE) {\r
       if (mIsEnterSecureBootForm) {\r
         Value->u8 = SECURE_BOOT_MODE_STANDARD;\r
-        Status = EFI_SUCCESS;\r
+        Status    = EFI_SUCCESS;\r
       }\r
     }\r
+\r
     goto EXIT;\r
   }\r
 \r
   if ((Action != EFI_BROWSER_ACTION_CHANGED) &&\r
       (Action != EFI_BROWSER_ACTION_CHANGING) &&\r
       (Action != EFI_BROWSER_ACTION_FORM_CLOSE) &&\r
-      (Action != EFI_BROWSER_ACTION_DEFAULT_STANDARD)) {\r
+      (Action != EFI_BROWSER_ACTION_DEFAULT_STANDARD))\r
+  {\r
     Status = EFI_UNSUPPORTED;\r
     goto EXIT;\r
   }\r
 \r
   if (Action == EFI_BROWSER_ACTION_CHANGING) {\r
-\r
     switch (QuestionId) {\r
-    case KEY_SECURE_BOOT_ENABLE:\r
-      GetVariable2 (EFI_SECURE_BOOT_ENABLE_NAME, &gEfiSecureBootEnableDisableGuid, (VOID**)&SecureBootEnable, NULL);\r
-      if (NULL != SecureBootEnable) {\r
-        FreePool (SecureBootEnable);\r
-        if (EFI_ERROR (SaveSecureBootVariable (Value->u8))) {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Only Physical Presence User could disable secure boot!",\r
-            NULL\r
-            );\r
-          Status = EFI_UNSUPPORTED;\r
-        } else {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            L"Configuration changed, please reset the platform to take effect!",\r
-            NULL\r
-            );\r
+      case KEY_SECURE_BOOT_ENABLE:\r
+        GetVariable2 (EFI_SECURE_BOOT_ENABLE_NAME, &gEfiSecureBootEnableDisableGuid, (VOID **)&SecureBootEnable, NULL);\r
+        if (NULL != SecureBootEnable) {\r
+          FreePool (SecureBootEnable);\r
+          if (EFI_ERROR (SaveSecureBootVariable (Value->u8))) {\r
+            CreatePopUp (\r
+              EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+              &Key,\r
+              L"Only Physical Presence User could disable secure boot!",\r
+              NULL\r
+              );\r
+            Status = EFI_UNSUPPORTED;\r
+          } else {\r
+            CreatePopUp (\r
+              EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+              &Key,\r
+              L"Configuration changed, please reset the platform to take effect!",\r
+              NULL\r
+              );\r
+          }\r
         }\r
-      }\r
-      break;\r
 \r
-    case KEY_SECURE_BOOT_KEK_OPTION:\r
-    case KEY_SECURE_BOOT_DB_OPTION:\r
-    case KEY_SECURE_BOOT_DBX_OPTION:\r
-    case KEY_SECURE_BOOT_DBT_OPTION:\r
-      PrivateData = SECUREBOOT_CONFIG_PRIVATE_FROM_THIS (This);\r
-      //\r
-      // Clear Signature GUID.\r
-      //\r
-      ZeroMem (IfrNvData->SignatureGuid, sizeof (IfrNvData->SignatureGuid));\r
-      if (Private->SignatureGUID == NULL) {\r
-        Private->SignatureGUID = (EFI_GUID *) AllocateZeroPool (sizeof (EFI_GUID));\r
+        break;\r
+\r
+      case KEY_SECURE_BOOT_KEK_OPTION:\r
+      case KEY_SECURE_BOOT_DB_OPTION:\r
+      case KEY_SECURE_BOOT_DBX_OPTION:\r
+      case KEY_SECURE_BOOT_DBT_OPTION:\r
+        PrivateData = SECUREBOOT_CONFIG_PRIVATE_FROM_THIS (This);\r
+        //\r
+        // Clear Signature GUID.\r
+        //\r
+        ZeroMem (IfrNvData->SignatureGuid, sizeof (IfrNvData->SignatureGuid));\r
         if (Private->SignatureGUID == NULL) {\r
-          return EFI_OUT_OF_RESOURCES;\r
+          Private->SignatureGUID = (EFI_GUID *)AllocateZeroPool (sizeof (EFI_GUID));\r
+          if (Private->SignatureGUID == NULL) {\r
+            return EFI_OUT_OF_RESOURCES;\r
+          }\r
         }\r
-      }\r
 \r
-      //\r
-      // Cleanup VFRData once leaving PK/KEK/DB/DBX/DBT enroll/delete page\r
-      //\r
-      SecureBootExtractConfigFromVariable (PrivateData, IfrNvData);\r
-\r
-      if (QuestionId == KEY_SECURE_BOOT_DB_OPTION) {\r
-        LabelId = SECUREBOOT_ENROLL_SIGNATURE_TO_DB;\r
-      } else if (QuestionId == KEY_SECURE_BOOT_DBX_OPTION) {\r
-        LabelId = SECUREBOOT_ENROLL_SIGNATURE_TO_DBX;\r
-      } else if (QuestionId == KEY_SECURE_BOOT_DBT_OPTION) {\r
-        LabelId = SECUREBOOT_ENROLL_SIGNATURE_TO_DBT;\r
-      } else {\r
-        LabelId = FORMID_ENROLL_KEK_FORM;\r
-      }\r
-\r
-      //\r
-      // Refresh selected file.\r
-      //\r
-      CleanUpPage (LabelId, Private);\r
-      break;\r
-    case KEY_SECURE_BOOT_PK_OPTION:\r
-      LabelId = FORMID_ENROLL_PK_FORM;\r
-      //\r
-      // Refresh selected file.\r
-      //\r
-      CleanUpPage (LabelId, Private);\r
-      break;\r
+        //\r
+        // Cleanup VFRData once leaving PK/KEK/DB/DBX/DBT enroll/delete page\r
+        //\r
+        SecureBootExtractConfigFromVariable (PrivateData, IfrNvData);\r
+\r
+        if (QuestionId == KEY_SECURE_BOOT_DB_OPTION) {\r
+          LabelId = SECUREBOOT_ENROLL_SIGNATURE_TO_DB;\r
+        } else if (QuestionId == KEY_SECURE_BOOT_DBX_OPTION) {\r
+          LabelId = SECUREBOOT_ENROLL_SIGNATURE_TO_DBX;\r
+        } else if (QuestionId == KEY_SECURE_BOOT_DBT_OPTION) {\r
+          LabelId = SECUREBOOT_ENROLL_SIGNATURE_TO_DBT;\r
+        } else {\r
+          LabelId = FORMID_ENROLL_KEK_FORM;\r
+        }\r
 \r
-    case FORMID_ENROLL_PK_FORM:\r
-      ChooseFile (NULL, NULL, UpdatePKFromFile, &File);\r
-      break;\r
+        //\r
+        // Refresh selected file.\r
+        //\r
+        CleanUpPage (LabelId, Private);\r
+        break;\r
+      case KEY_SECURE_BOOT_PK_OPTION:\r
+        LabelId = FORMID_ENROLL_PK_FORM;\r
+        //\r
+        // Refresh selected file.\r
+        //\r
+        CleanUpPage (LabelId, Private);\r
+        break;\r
 \r
-    case FORMID_ENROLL_KEK_FORM:\r
-      ChooseFile (NULL, NULL, UpdateKEKFromFile, &File);\r
-      break;\r
+      case FORMID_ENROLL_PK_FORM:\r
+        ChooseFile (NULL, NULL, UpdatePKFromFile, &File);\r
+        break;\r
 \r
-    case SECUREBOOT_ENROLL_SIGNATURE_TO_DB:\r
-      ChooseFile (NULL, NULL, UpdateDBFromFile, &File);\r
-      break;\r
+      case FORMID_ENROLL_KEK_FORM:\r
+        ChooseFile (NULL, NULL, UpdateKEKFromFile, &File);\r
+        break;\r
 \r
-    case SECUREBOOT_ENROLL_SIGNATURE_TO_DBX:\r
-      ChooseFile (NULL, NULL, UpdateDBXFromFile, &File);\r
+      case SECUREBOOT_ENROLL_SIGNATURE_TO_DB:\r
+        ChooseFile (NULL, NULL, UpdateDBFromFile, &File);\r
+        break;\r
 \r
-      if (Private->FileContext->FHandle != NULL) {\r
-        //\r
-        // Parse the file's postfix.\r
-        //\r
-        NameLength = StrLen (Private->FileContext->FileName);\r
-        if (NameLength <= 4) {\r
-          return FALSE;\r
-        }\r
-        FilePostFix = Private->FileContext->FileName + NameLength - 4;\r
+      case SECUREBOOT_ENROLL_SIGNATURE_TO_DBX:\r
+        ChooseFile (NULL, NULL, UpdateDBXFromFile, &File);\r
 \r
-        if (IsDerEncodeCertificate (FilePostFix)) {\r
+        if (Private->FileContext->FHandle != NULL) {\r
           //\r
-          // Supports DER-encoded X509 certificate.\r
+          // Parse the file's postfix.\r
           //\r
-          IfrNvData->FileEnrollType = X509_CERT_FILE_TYPE;\r
-        } else if (IsAuthentication2Format(Private->FileContext->FHandle)){\r
-          IfrNvData->FileEnrollType = AUTHENTICATION_2_FILE_TYPE;\r
-        } else {\r
-          IfrNvData->FileEnrollType = PE_IMAGE_FILE_TYPE;\r
-        }\r
-        Private->FileContext->FileType = IfrNvData->FileEnrollType;\r
-\r
-        //\r
-        // Clean up Certificate Format if File type is not X509 DER\r
-        //\r
-        if (IfrNvData->FileEnrollType != X509_CERT_FILE_TYPE) {\r
-          IfrNvData->CertificateFormat = HASHALG_RAW;\r
-        }\r
-        DEBUG((DEBUG_ERROR, "IfrNvData->FileEnrollType %d\n", Private->FileContext->FileType));\r
-      }\r
+          NameLength = StrLen (Private->FileContext->FileName);\r
+          if (NameLength <= 4) {\r
+            return FALSE;\r
+          }\r
 \r
-      break;\r
+          FilePostFix = Private->FileContext->FileName + NameLength - 4;\r
+\r
+          if (IsDerEncodeCertificate (FilePostFix)) {\r
+            //\r
+            // Supports DER-encoded X509 certificate.\r
+            //\r
+            IfrNvData->FileEnrollType = X509_CERT_FILE_TYPE;\r
+          } else if (IsAuthentication2Format (Private->FileContext->FHandle)) {\r
+            IfrNvData->FileEnrollType = AUTHENTICATION_2_FILE_TYPE;\r
+          } else {\r
+            IfrNvData->FileEnrollType = PE_IMAGE_FILE_TYPE;\r
+          }\r
 \r
-    case SECUREBOOT_ENROLL_SIGNATURE_TO_DBT:\r
-      ChooseFile (NULL, NULL, UpdateDBTFromFile, &File);\r
-      break;\r
+          Private->FileContext->FileType = IfrNvData->FileEnrollType;\r
 \r
-    case KEY_SECURE_BOOT_DELETE_PK:\r
-      if (Value->u8) {\r
-        CreatePopUp (\r
-          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-          &Key,\r
-          L"Are you sure you want to delete PK? Secure boot will be disabled!",\r
-          L"Press 'Y' to delete PK and exit, 'N' to discard change and return",\r
-          NULL\r
-          );\r
-        if (Key.UnicodeChar == 'y' || Key.UnicodeChar == 'Y') {\r
-          Status = DeletePlatformKey ();\r
-          if (EFI_ERROR (Status)) {\r
-            CreatePopUp (\r
-              EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-              &Key,\r
-              L"Only Physical Presence User could delete PK in custom mode!",\r
-              NULL\r
-              );\r
+          //\r
+          // Clean up Certificate Format if File type is not X509 DER\r
+          //\r
+          if (IfrNvData->FileEnrollType != X509_CERT_FILE_TYPE) {\r
+            IfrNvData->CertificateFormat = HASHALG_RAW;\r
           }\r
+\r
+          DEBUG ((DEBUG_ERROR, "IfrNvData->FileEnrollType %d\n", Private->FileContext->FileType));\r
         }\r
-      }\r
-      break;\r
 \r
-    case KEY_DELETE_KEK:\r
-      UpdateDeletePage (\r
-        Private,\r
-        EFI_KEY_EXCHANGE_KEY_NAME,\r
-        &gEfiGlobalVariableGuid,\r
-        LABEL_KEK_DELETE,\r
-        FORMID_DELETE_KEK_FORM,\r
-        OPTION_DEL_KEK_QUESTION_ID\r
-        );\r
-      break;\r
+        break;\r
 \r
-    case SECUREBOOT_DELETE_SIGNATURE_FROM_DB:\r
-      UpdateDeletePage (\r
-        Private,\r
-        EFI_IMAGE_SECURITY_DATABASE,\r
-        &gEfiImageSecurityDatabaseGuid,\r
-        LABEL_DB_DELETE,\r
-        SECUREBOOT_DELETE_SIGNATURE_FROM_DB,\r
-        OPTION_DEL_DB_QUESTION_ID\r
-        );\r
-       break;\r
+      case SECUREBOOT_ENROLL_SIGNATURE_TO_DBT:\r
+        ChooseFile (NULL, NULL, UpdateDBTFromFile, &File);\r
+        break;\r
 \r
-    //\r
-    // From DBX option to the level-1 form, display signature list.\r
-    //\r
-    case KEY_VALUE_FROM_DBX_TO_LIST_FORM:\r
-      Private->VariableName = Variable_DBX;\r
-      LoadSignatureList (\r
-        Private,\r
-        LABEL_SIGNATURE_LIST_START,\r
-        SECUREBOOT_DELETE_SIGNATURE_LIST_FORM,\r
-        OPTION_SIGNATURE_LIST_QUESTION_ID\r
-      );\r
-      break;\r
+      case KEY_SECURE_BOOT_DELETE_PK:\r
+        if (Value->u8) {\r
+          CreatePopUp (\r
+            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+            &Key,\r
+            L"Are you sure you want to delete PK? Secure boot will be disabled!",\r
+            L"Press 'Y' to delete PK and exit, 'N' to discard change and return",\r
+            NULL\r
+            );\r
+          if ((Key.UnicodeChar == 'y') || (Key.UnicodeChar == 'Y')) {\r
+            Status = DeletePlatformKey ();\r
+            if (EFI_ERROR (Status)) {\r
+              CreatePopUp (\r
+                EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+                &Key,\r
+                L"Only Physical Presence User could delete PK in custom mode!",\r
+                NULL\r
+                );\r
+            }\r
+          }\r
+        }\r
 \r
-      //\r
-      // Delete all signature list and reload.\r
-      //\r
-    case KEY_SECURE_BOOT_DELETE_ALL_LIST:\r
-      CreatePopUp(\r
-        EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-        &Key,\r
-        L"Press 'Y' to delete signature list.",\r
-        L"Press other key to cancel and exit.",\r
-        NULL\r
-      );\r
+        break;\r
 \r
-      if (Key.UnicodeChar == L'Y' || Key.UnicodeChar == L'y') {\r
-        DeleteSignatureEx (Private, Delete_Signature_List_All, IfrNvData->CheckedDataCount);\r
-      }\r
+      case KEY_DELETE_KEK:\r
+        UpdateDeletePage (\r
+          Private,\r
+          EFI_KEY_EXCHANGE_KEY_NAME,\r
+          &gEfiGlobalVariableGuid,\r
+          LABEL_KEK_DELETE,\r
+          FORMID_DELETE_KEK_FORM,\r
+          OPTION_DEL_KEK_QUESTION_ID\r
+          );\r
+        break;\r
 \r
-      LoadSignatureList (\r
-        Private,\r
-        LABEL_SIGNATURE_LIST_START,\r
-        SECUREBOOT_DELETE_SIGNATURE_LIST_FORM,\r
-        OPTION_SIGNATURE_LIST_QUESTION_ID\r
-      );\r
-      break;\r
+      case SECUREBOOT_DELETE_SIGNATURE_FROM_DB:\r
+        UpdateDeletePage (\r
+          Private,\r
+          EFI_IMAGE_SECURITY_DATABASE,\r
+          &gEfiImageSecurityDatabaseGuid,\r
+          LABEL_DB_DELETE,\r
+          SECUREBOOT_DELETE_SIGNATURE_FROM_DB,\r
+          OPTION_DEL_DB_QUESTION_ID\r
+          );\r
+        break;\r
 \r
       //\r
-      // Delete one signature list and reload.\r
+      // From DBX option to the level-1 form, display signature list.\r
       //\r
-    case KEY_SECURE_BOOT_DELETE_ALL_DATA:\r
-      CreatePopUp(\r
-        EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-        &Key,\r
-        L"Press 'Y' to delete signature data.",\r
-        L"Press other key to cancel and exit.",\r
-        NULL\r
-      );\r
-\r
-      if (Key.UnicodeChar == L'Y' || Key.UnicodeChar == L'y') {\r
-        DeleteSignatureEx (Private, Delete_Signature_List_One, IfrNvData->CheckedDataCount);\r
-      }\r
-\r
-      LoadSignatureList (\r
-        Private,\r
-        LABEL_SIGNATURE_LIST_START,\r
-        SECUREBOOT_DELETE_SIGNATURE_LIST_FORM,\r
-        OPTION_SIGNATURE_LIST_QUESTION_ID\r
-      );\r
-      break;\r
+      case KEY_VALUE_FROM_DBX_TO_LIST_FORM:\r
+        Private->VariableName = Variable_DBX;\r
+        LoadSignatureList (\r
+          Private,\r
+          LABEL_SIGNATURE_LIST_START,\r
+          SECUREBOOT_DELETE_SIGNATURE_LIST_FORM,\r
+          OPTION_SIGNATURE_LIST_QUESTION_ID\r
+          );\r
+        break;\r
 \r
       //\r
-      // Delete checked signature data and reload.\r
+      // Delete all signature list and reload.\r
       //\r
-    case KEY_SECURE_BOOT_DELETE_CHECK_DATA:\r
-      CreatePopUp(\r
-        EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-        &Key,\r
-        L"Press 'Y' to delete signature data.",\r
-        L"Press other key to cancel and exit.",\r
-        NULL\r
-      );\r
-\r
-      if (Key.UnicodeChar == L'Y' || Key.UnicodeChar == L'y') {\r
-        DeleteSignatureEx (Private, Delete_Signature_Data, IfrNvData->CheckedDataCount);\r
-      }\r
-\r
-      LoadSignatureList (\r
-        Private,\r
-        LABEL_SIGNATURE_LIST_START,\r
-        SECUREBOOT_DELETE_SIGNATURE_LIST_FORM,\r
-        OPTION_SIGNATURE_LIST_QUESTION_ID\r
-      );\r
-      break;\r
-\r
-    case SECUREBOOT_DELETE_SIGNATURE_FROM_DBT:\r
-      UpdateDeletePage (\r
-        Private,\r
-        EFI_IMAGE_SECURITY_DATABASE2,\r
-        &gEfiImageSecurityDatabaseGuid,\r
-        LABEL_DBT_DELETE,\r
-        SECUREBOOT_DELETE_SIGNATURE_FROM_DBT,\r
-        OPTION_DEL_DBT_QUESTION_ID\r
-        );\r
-\r
-      break;\r
-\r
-    case KEY_VALUE_SAVE_AND_EXIT_KEK:\r
-      Status = EnrollKeyExchangeKey (Private);\r
-      if (EFI_ERROR (Status)) {\r
+      case KEY_SECURE_BOOT_DELETE_ALL_LIST:\r
         CreatePopUp (\r
           EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
           &Key,\r
-          L"ERROR: Unsupported file type!",\r
-          L"Only supports DER-encoded X509 certificate",\r
+          L"Press 'Y' to delete signature list.",\r
+          L"Press other key to cancel and exit.",\r
           NULL\r
           );\r
-      }\r
-      break;\r
 \r
-    case KEY_VALUE_SAVE_AND_EXIT_DB:\r
-      Status = EnrollSignatureDatabase (Private, EFI_IMAGE_SECURITY_DATABASE);\r
-      if (EFI_ERROR (Status)) {\r
-        CreatePopUp (\r
-          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-          &Key,\r
-          L"ERROR: Unsupported file type!",\r
-          L"Only supports DER-encoded X509 certificate and executable EFI image",\r
-          NULL\r
-          );\r
-      }\r
-      break;\r
+        if ((Key.UnicodeChar == L'Y') || (Key.UnicodeChar == L'y')) {\r
+          DeleteSignatureEx (Private, Delete_Signature_List_All, IfrNvData->CheckedDataCount);\r
+        }\r
 \r
-    case KEY_VALUE_SAVE_AND_EXIT_DBX:\r
-      if (IsX509CertInDbx (Private, EFI_IMAGE_SECURITY_DATABASE1)) {\r
-        CreatePopUp (\r
-          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-          &Key,\r
-          L"Enrollment failed! Same certificate had already been in the dbx!",\r
-          NULL\r
+        LoadSignatureList (\r
+          Private,\r
+          LABEL_SIGNATURE_LIST_START,\r
+          SECUREBOOT_DELETE_SIGNATURE_LIST_FORM,\r
+          OPTION_SIGNATURE_LIST_QUESTION_ID\r
           );\r
-\r
-        //\r
-        // Cert already exists in DBX. Close opened file before exit.\r
-        //\r
-        CloseEnrolledFile(Private->FileContext);\r
         break;\r
-      }\r
 \r
-      if ((IfrNvData != NULL) && (IfrNvData->CertificateFormat < HASHALG_MAX)) {\r
-        Status = EnrollX509HashtoSigDB (\r
-                   Private,\r
-                   IfrNvData->CertificateFormat,\r
-                   &IfrNvData->RevocationDate,\r
-                   &IfrNvData->RevocationTime,\r
-                   IfrNvData->AlwaysRevocation\r
-                   );\r
-        IfrNvData->CertificateFormat = HASHALG_RAW;\r
-      } else {\r
-        Status = EnrollSignatureDatabase (Private, EFI_IMAGE_SECURITY_DATABASE1);\r
-      }\r
-      if (EFI_ERROR (Status)) {\r
+      //\r
+      // Delete one signature list and reload.\r
+      //\r
+      case KEY_SECURE_BOOT_DELETE_ALL_DATA:\r
         CreatePopUp (\r
           EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
           &Key,\r
-          L"ERROR: Unsupported file type!",\r
-          L"Only supports DER-encoded X509 certificate, AUTH_2 format data & executable EFI image",\r
+          L"Press 'Y' to delete signature data.",\r
+          L"Press other key to cancel and exit.",\r
           NULL\r
           );\r
-      }\r
-      break;\r
 \r
-    case KEY_VALUE_SAVE_AND_EXIT_DBT:\r
-      Status = EnrollSignatureDatabase (Private, EFI_IMAGE_SECURITY_DATABASE2);\r
-      if (EFI_ERROR (Status)) {\r
-        CreatePopUp (\r
-          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-          &Key,\r
-          L"ERROR: Unsupported file type!",\r
-          L"Only supports DER-encoded X509 certificate.",\r
-          NULL\r
+        if ((Key.UnicodeChar == L'Y') || (Key.UnicodeChar == L'y')) {\r
+          DeleteSignatureEx (Private, Delete_Signature_List_One, IfrNvData->CheckedDataCount);\r
+        }\r
+\r
+        LoadSignatureList (\r
+          Private,\r
+          LABEL_SIGNATURE_LIST_START,\r
+          SECUREBOOT_DELETE_SIGNATURE_LIST_FORM,\r
+          OPTION_SIGNATURE_LIST_QUESTION_ID\r
           );\r
-      }\r
-      break;\r
-    case KEY_VALUE_SAVE_AND_EXIT_PK:\r
+        break;\r
+\r
       //\r
-      // Check the suffix, encode type and the key strength of PK certificate.\r
+      // Delete checked signature data and reload.\r
       //\r
-      Status = CheckX509Certificate (Private->FileContext, &EnrollKeyErrorCode);\r
-      if (EFI_ERROR (Status)) {\r
-        if (EnrollKeyErrorCode != None_Error && EnrollKeyErrorCode < Enroll_Error_Max) {\r
-          CreatePopUp (\r
-            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
-            &Key,\r
-            mX509EnrollPromptTitle[EnrollKeyErrorCode],\r
-            mX509EnrollPromptString[EnrollKeyErrorCode],\r
-            NULL\r
-            );\r
-          break;\r
-        }\r
-      } else {\r
-        Status = EnrollPlatformKey (Private);\r
-      }\r
-      if (EFI_ERROR (Status)) {\r
-        UnicodeSPrint (\r
-          PromptString,\r
-          sizeof (PromptString),\r
-          L"Error status: %x.",\r
-          Status\r
-          );\r
+      case KEY_SECURE_BOOT_DELETE_CHECK_DATA:\r
         CreatePopUp (\r
           EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
           &Key,\r
-          L"ERROR: Enrollment failed!",\r
-          PromptString,\r
+          L"Press 'Y' to delete signature data.",\r
+          L"Press other key to cancel and exit.",\r
           NULL\r
           );\r
-      }\r
-      break;\r
-    default:\r
-      if ((QuestionId >= OPTION_DEL_KEK_QUESTION_ID) &&\r
-                 (QuestionId < (OPTION_DEL_KEK_QUESTION_ID + OPTION_CONFIG_RANGE))) {\r
-        DeleteKeyExchangeKey (Private, QuestionId);\r
-      } else if ((QuestionId >= OPTION_DEL_DB_QUESTION_ID) &&\r
-                 (QuestionId < (OPTION_DEL_DB_QUESTION_ID + OPTION_CONFIG_RANGE))) {\r
-        DeleteSignature (\r
+\r
+        if ((Key.UnicodeChar == L'Y') || (Key.UnicodeChar == L'y')) {\r
+          DeleteSignatureEx (Private, Delete_Signature_Data, IfrNvData->CheckedDataCount);\r
+        }\r
+\r
+        LoadSignatureList (\r
           Private,\r
-          EFI_IMAGE_SECURITY_DATABASE,\r
-          &gEfiImageSecurityDatabaseGuid,\r
-          LABEL_DB_DELETE,\r
-          SECUREBOOT_DELETE_SIGNATURE_FROM_DB,\r
-          OPTION_DEL_DB_QUESTION_ID,\r
-          QuestionId - OPTION_DEL_DB_QUESTION_ID\r
+          LABEL_SIGNATURE_LIST_START,\r
+          SECUREBOOT_DELETE_SIGNATURE_LIST_FORM,\r
+          OPTION_SIGNATURE_LIST_QUESTION_ID\r
           );\r
-      } else if ((QuestionId >= OPTION_SIGNATURE_LIST_QUESTION_ID) &&\r
-                 (QuestionId < (OPTION_SIGNATURE_LIST_QUESTION_ID + OPTION_CONFIG_RANGE))) {\r
-        LoadSignatureData (\r
-          Private,\r
-          LABEL_SIGNATURE_DATA_START,\r
-          SECUREBOOT_DELETE_SIGNATURE_DATA_FORM,\r
-          OPTION_SIGNATURE_DATA_QUESTION_ID,\r
-          QuestionId - OPTION_SIGNATURE_LIST_QUESTION_ID\r
-        );\r
-        Private->ListIndex = QuestionId - OPTION_SIGNATURE_LIST_QUESTION_ID;\r
-      } else if ((QuestionId >= OPTION_SIGNATURE_DATA_QUESTION_ID) &&\r
-                 (QuestionId < (OPTION_SIGNATURE_DATA_QUESTION_ID + OPTION_CONFIG_RANGE))) {\r
-        if (Private->CheckArray[QuestionId - OPTION_SIGNATURE_DATA_QUESTION_ID]) {\r
-          IfrNvData->CheckedDataCount--;\r
-          Private->CheckArray[QuestionId - OPTION_SIGNATURE_DATA_QUESTION_ID] = FALSE;\r
-        } else {\r
-          IfrNvData->CheckedDataCount++;\r
-          Private->CheckArray[QuestionId - OPTION_SIGNATURE_DATA_QUESTION_ID] = TRUE;\r
-        }\r
-      } else if ((QuestionId >= OPTION_DEL_DBT_QUESTION_ID) &&\r
-                 (QuestionId < (OPTION_DEL_DBT_QUESTION_ID + OPTION_CONFIG_RANGE))) {\r
-        DeleteSignature (\r
+        break;\r
+\r
+      case SECUREBOOT_DELETE_SIGNATURE_FROM_DBT:\r
+        UpdateDeletePage (\r
           Private,\r
           EFI_IMAGE_SECURITY_DATABASE2,\r
           &gEfiImageSecurityDatabaseGuid,\r
           LABEL_DBT_DELETE,\r
           SECUREBOOT_DELETE_SIGNATURE_FROM_DBT,\r
-          OPTION_DEL_DBT_QUESTION_ID,\r
-          QuestionId - OPTION_DEL_DBT_QUESTION_ID\r
+          OPTION_DEL_DBT_QUESTION_ID\r
           );\r
-      }\r
-      break;\r
 \r
-    case KEY_VALUE_NO_SAVE_AND_EXIT_PK:\r
-    case KEY_VALUE_NO_SAVE_AND_EXIT_KEK:\r
-    case KEY_VALUE_NO_SAVE_AND_EXIT_DB:\r
-    case KEY_VALUE_NO_SAVE_AND_EXIT_DBX:\r
-    case KEY_VALUE_NO_SAVE_AND_EXIT_DBT:\r
-      CloseEnrolledFile(Private->FileContext);\r
+        break;\r
 \r
-      if (Private->SignatureGUID != NULL) {\r
-        FreePool (Private->SignatureGUID);\r
-        Private->SignatureGUID = NULL;\r
-      }\r
-      break;\r
+      case KEY_VALUE_SAVE_AND_EXIT_KEK:\r
+        Status = EnrollKeyExchangeKey (Private);\r
+        if (EFI_ERROR (Status)) {\r
+          CreatePopUp (\r
+            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+            &Key,\r
+            L"ERROR: Unsupported file type!",\r
+            L"Only supports DER-encoded X509 certificate",\r
+            NULL\r
+            );\r
+        }\r
+\r
+        break;\r
+\r
+      case KEY_VALUE_SAVE_AND_EXIT_DB:\r
+        Status = EnrollSignatureDatabase (Private, EFI_IMAGE_SECURITY_DATABASE);\r
+        if (EFI_ERROR (Status)) {\r
+          CreatePopUp (\r
+            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+            &Key,\r
+            L"ERROR: Unsupported file type!",\r
+            L"Only supports DER-encoded X509 certificate and executable EFI image",\r
+            NULL\r
+            );\r
+        }\r
+\r
+        break;\r
+\r
+      case KEY_VALUE_SAVE_AND_EXIT_DBX:\r
+        if (IsX509CertInDbx (Private, EFI_IMAGE_SECURITY_DATABASE1)) {\r
+          CreatePopUp (\r
+            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+            &Key,\r
+            L"Enrollment failed! Same certificate had already been in the dbx!",\r
+            NULL\r
+            );\r
+\r
+          //\r
+          // Cert already exists in DBX. Close opened file before exit.\r
+          //\r
+          CloseEnrolledFile (Private->FileContext);\r
+          break;\r
+        }\r
+\r
+        if ((IfrNvData != NULL) && (IfrNvData->CertificateFormat < HASHALG_MAX)) {\r
+          Status = EnrollX509HashtoSigDB (\r
+                     Private,\r
+                     IfrNvData->CertificateFormat,\r
+                     &IfrNvData->RevocationDate,\r
+                     &IfrNvData->RevocationTime,\r
+                     IfrNvData->AlwaysRevocation\r
+                     );\r
+          IfrNvData->CertificateFormat = HASHALG_RAW;\r
+        } else {\r
+          Status = EnrollSignatureDatabase (Private, EFI_IMAGE_SECURITY_DATABASE1);\r
+        }\r
+\r
+        if (EFI_ERROR (Status)) {\r
+          CreatePopUp (\r
+            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+            &Key,\r
+            L"ERROR: Unsupported file type!",\r
+            L"Only supports DER-encoded X509 certificate, AUTH_2 format data & executable EFI image",\r
+            NULL\r
+            );\r
+        }\r
+\r
+        break;\r
+\r
+      case KEY_VALUE_SAVE_AND_EXIT_DBT:\r
+        Status = EnrollSignatureDatabase (Private, EFI_IMAGE_SECURITY_DATABASE2);\r
+        if (EFI_ERROR (Status)) {\r
+          CreatePopUp (\r
+            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+            &Key,\r
+            L"ERROR: Unsupported file type!",\r
+            L"Only supports DER-encoded X509 certificate.",\r
+            NULL\r
+            );\r
+        }\r
+\r
+        break;\r
+      case KEY_VALUE_SAVE_AND_EXIT_PK:\r
+        //\r
+        // Check the suffix, encode type and the key strength of PK certificate.\r
+        //\r
+        Status = CheckX509Certificate (Private->FileContext, &EnrollKeyErrorCode);\r
+        if (EFI_ERROR (Status)) {\r
+          if ((EnrollKeyErrorCode != None_Error) && (EnrollKeyErrorCode < Enroll_Error_Max)) {\r
+            CreatePopUp (\r
+              EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+              &Key,\r
+              mX509EnrollPromptTitle[EnrollKeyErrorCode],\r
+              mX509EnrollPromptString[EnrollKeyErrorCode],\r
+              NULL\r
+              );\r
+            break;\r
+          }\r
+        } else {\r
+          Status = EnrollPlatformKey (Private);\r
+        }\r
+\r
+        if (EFI_ERROR (Status)) {\r
+          UnicodeSPrint (\r
+            PromptString,\r
+            sizeof (PromptString),\r
+            L"Error status: %x.",\r
+            Status\r
+            );\r
+          CreatePopUp (\r
+            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,\r
+            &Key,\r
+            L"ERROR: Enrollment failed!",\r
+            PromptString,\r
+            NULL\r
+            );\r
+        }\r
+\r
+        break;\r
+      default:\r
+        if ((QuestionId >= OPTION_DEL_KEK_QUESTION_ID) &&\r
+            (QuestionId < (OPTION_DEL_KEK_QUESTION_ID + OPTION_CONFIG_RANGE)))\r
+        {\r
+          DeleteKeyExchangeKey (Private, QuestionId);\r
+        } else if ((QuestionId >= OPTION_DEL_DB_QUESTION_ID) &&\r
+                   (QuestionId < (OPTION_DEL_DB_QUESTION_ID + OPTION_CONFIG_RANGE)))\r
+        {\r
+          DeleteSignature (\r
+            Private,\r
+            EFI_IMAGE_SECURITY_DATABASE,\r
+            &gEfiImageSecurityDatabaseGuid,\r
+            LABEL_DB_DELETE,\r
+            SECUREBOOT_DELETE_SIGNATURE_FROM_DB,\r
+            OPTION_DEL_DB_QUESTION_ID,\r
+            QuestionId - OPTION_DEL_DB_QUESTION_ID\r
+            );\r
+        } else if ((QuestionId >= OPTION_SIGNATURE_LIST_QUESTION_ID) &&\r
+                   (QuestionId < (OPTION_SIGNATURE_LIST_QUESTION_ID + OPTION_CONFIG_RANGE)))\r
+        {\r
+          LoadSignatureData (\r
+            Private,\r
+            LABEL_SIGNATURE_DATA_START,\r
+            SECUREBOOT_DELETE_SIGNATURE_DATA_FORM,\r
+            OPTION_SIGNATURE_DATA_QUESTION_ID,\r
+            QuestionId - OPTION_SIGNATURE_LIST_QUESTION_ID\r
+            );\r
+          Private->ListIndex = QuestionId - OPTION_SIGNATURE_LIST_QUESTION_ID;\r
+        } else if ((QuestionId >= OPTION_SIGNATURE_DATA_QUESTION_ID) &&\r
+                   (QuestionId < (OPTION_SIGNATURE_DATA_QUESTION_ID + OPTION_CONFIG_RANGE)))\r
+        {\r
+          if (Private->CheckArray[QuestionId - OPTION_SIGNATURE_DATA_QUESTION_ID]) {\r
+            IfrNvData->CheckedDataCount--;\r
+            Private->CheckArray[QuestionId - OPTION_SIGNATURE_DATA_QUESTION_ID] = FALSE;\r
+          } else {\r
+            IfrNvData->CheckedDataCount++;\r
+            Private->CheckArray[QuestionId - OPTION_SIGNATURE_DATA_QUESTION_ID] = TRUE;\r
+          }\r
+        } else if ((QuestionId >= OPTION_DEL_DBT_QUESTION_ID) &&\r
+                   (QuestionId < (OPTION_DEL_DBT_QUESTION_ID + OPTION_CONFIG_RANGE)))\r
+        {\r
+          DeleteSignature (\r
+            Private,\r
+            EFI_IMAGE_SECURITY_DATABASE2,\r
+            &gEfiImageSecurityDatabaseGuid,\r
+            LABEL_DBT_DELETE,\r
+            SECUREBOOT_DELETE_SIGNATURE_FROM_DBT,\r
+            OPTION_DEL_DBT_QUESTION_ID,\r
+            QuestionId - OPTION_DEL_DBT_QUESTION_ID\r
+            );\r
+        }\r
+\r
+        break;\r
+\r
+      case KEY_VALUE_NO_SAVE_AND_EXIT_PK:\r
+      case KEY_VALUE_NO_SAVE_AND_EXIT_KEK:\r
+      case KEY_VALUE_NO_SAVE_AND_EXIT_DB:\r
+      case KEY_VALUE_NO_SAVE_AND_EXIT_DBX:\r
+      case KEY_VALUE_NO_SAVE_AND_EXIT_DBT:\r
+        CloseEnrolledFile (Private->FileContext);\r
+\r
+        if (Private->SignatureGUID != NULL) {\r
+          FreePool (Private->SignatureGUID);\r
+          Private->SignatureGUID = NULL;\r
+        }\r
+\r
+        break;\r
     }\r
   } else if (Action == EFI_BROWSER_ACTION_CHANGED) {\r
     switch (QuestionId) {\r
-    case KEY_SECURE_BOOT_ENABLE:\r
-      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
-      break;\r
-    case KEY_SECURE_BOOT_MODE:\r
-      mIsEnterSecureBootForm = FALSE;\r
-      break;\r
-    case KEY_SECURE_BOOT_KEK_GUID:\r
-    case KEY_SECURE_BOOT_SIGNATURE_GUID_DB:\r
-    case KEY_SECURE_BOOT_SIGNATURE_GUID_DBX:\r
-    case KEY_SECURE_BOOT_SIGNATURE_GUID_DBT:\r
-      ASSERT (Private->SignatureGUID != NULL);\r
-      RStatus = StrToGuid (IfrNvData->SignatureGuid, Private->SignatureGUID);\r
-      if (RETURN_ERROR (RStatus) || (IfrNvData->SignatureGuid[GUID_STRING_LENGTH] != L'\0')) {\r
-        Status = EFI_INVALID_PARAMETER;\r
+      case KEY_SECURE_BOOT_ENABLE:\r
+        *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
         break;\r
-      }\r
+      case KEY_SECURE_BOOT_MODE:\r
+        mIsEnterSecureBootForm = FALSE;\r
+        break;\r
+      case KEY_SECURE_BOOT_KEK_GUID:\r
+      case KEY_SECURE_BOOT_SIGNATURE_GUID_DB:\r
+      case KEY_SECURE_BOOT_SIGNATURE_GUID_DBX:\r
+      case KEY_SECURE_BOOT_SIGNATURE_GUID_DBT:\r
+        ASSERT (Private->SignatureGUID != NULL);\r
+        RStatus = StrToGuid (IfrNvData->SignatureGuid, Private->SignatureGUID);\r
+        if (RETURN_ERROR (RStatus) || (IfrNvData->SignatureGuid[GUID_STRING_LENGTH] != L'\0')) {\r
+          Status = EFI_INVALID_PARAMETER;\r
+          break;\r
+        }\r
 \r
-      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
-      break;\r
-    case KEY_SECURE_BOOT_DELETE_PK:\r
-      GetVariable2 (EFI_SETUP_MODE_NAME, &gEfiGlobalVariableGuid, (VOID**)&SetupMode, NULL);\r
-      if (SetupMode == NULL || (*SetupMode) == SETUP_MODE) {\r
-        IfrNvData->DeletePk = TRUE;\r
-        IfrNvData->HasPk    = FALSE;\r
-        *ActionRequest = EFI_BROWSER_ACTION_REQUEST_SUBMIT;\r
-      } else  {\r
-        IfrNvData->DeletePk = FALSE;\r
-        IfrNvData->HasPk    = TRUE;\r
         *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
+        break;\r
+      case KEY_SECURE_BOOT_DELETE_PK:\r
+        GetVariable2 (EFI_SETUP_MODE_NAME, &gEfiGlobalVariableGuid, (VOID **)&SetupMode, NULL);\r
+        if ((SetupMode == NULL) || ((*SetupMode) == SETUP_MODE)) {\r
+          IfrNvData->DeletePk = TRUE;\r
+          IfrNvData->HasPk    = FALSE;\r
+          *ActionRequest      = EFI_BROWSER_ACTION_REQUEST_SUBMIT;\r
+        } else {\r
+          IfrNvData->DeletePk = FALSE;\r
+          IfrNvData->HasPk    = TRUE;\r
+          *ActionRequest      = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY;\r
+        }\r
+\r
+        if (SetupMode != NULL) {\r
+          FreePool (SetupMode);\r
+        }\r
+\r
+        break;\r
+      case KEY_SECURE_BOOT_RESET_TO_DEFAULT:\r
+      {\r
+        Status = gBS->LocateProtocol (&gEfiHiiPopupProtocolGuid, NULL, (VOID **)&HiiPopup);\r
+        if (EFI_ERROR (Status)) {\r
+          return Status;\r
+        }\r
+\r
+        Status = HiiPopup->CreatePopup (\r
+                             HiiPopup,\r
+                             EfiHiiPopupStyleInfo,\r
+                             EfiHiiPopupTypeYesNo,\r
+                             Private->HiiHandle,\r
+                             STRING_TOKEN (STR_RESET_TO_DEFAULTS_POPUP),\r
+                             &UserSelection\r
+                             );\r
+        if (UserSelection == EfiHiiPopupSelectionYes) {\r
+          Status = KeyEnrollReset ();\r
+        }\r
+\r
+        //\r
+        // Update secure boot strings after key reset\r
+        //\r
+        if (Status == EFI_SUCCESS) {\r
+          Status = UpdateSecureBootString (Private);\r
+          SecureBootExtractConfigFromVariable (Private, IfrNvData);\r
+        }\r
       }\r
-      if (SetupMode != NULL) {\r
-        FreePool (SetupMode);\r
-      }\r
-      break;\r
-    case KEY_SECURE_BOOT_RESET_TO_DEFAULT:\r
-    {\r
-      Status = gBS->LocateProtocol (&gEfiHiiPopupProtocolGuid, NULL, (VOID **) &HiiPopup);\r
-      if (EFI_ERROR (Status)) {\r
-        return Status;\r
-      }\r
-      Status = HiiPopup->CreatePopup (\r
-                           HiiPopup,\r
-                           EfiHiiPopupStyleInfo,\r
-                           EfiHiiPopupTypeYesNo,\r
-                           Private->HiiHandle,\r
-                           STRING_TOKEN (STR_RESET_TO_DEFAULTS_POPUP),\r
-                           &UserSelection\r
-                           );\r
-      if (UserSelection == EfiHiiPopupSelectionYes) {\r
-        Status = KeyEnrollReset ();\r
-      }\r
-      //\r
-      // Update secure boot strings after key reset\r
-      //\r
-      if (Status == EFI_SUCCESS) {\r
-        Status = UpdateSecureBootString (Private);\r
-        SecureBootExtractConfigFromVariable (Private, IfrNvData);\r
-      }\r
-    }\r
-    default:\r
-      break;\r
+      default:\r
+        break;\r
     }\r
   } else if (Action == EFI_BROWSER_ACTION_DEFAULT_STANDARD) {\r
     if (QuestionId == KEY_HIDE_SECURE_BOOT) {\r
-      GetVariable2 (EFI_PLATFORM_KEY_NAME, &gEfiGlobalVariableGuid, (VOID**)&Pk, NULL);\r
+      GetVariable2 (EFI_PLATFORM_KEY_NAME, &gEfiGlobalVariableGuid, (VOID **)&Pk, NULL);\r
       if (Pk == NULL) {\r
         IfrNvData->HideSecureBoot = TRUE;\r
       } else {\r
         FreePool (Pk);\r
         IfrNvData->HideSecureBoot = FALSE;\r
       }\r
+\r
       Value->b = IfrNvData->HideSecureBoot;\r
     }\r
   } else if (Action == EFI_BROWSER_ACTION_FORM_CLOSE) {\r
     //\r
     // Force the platform back to Standard Mode once user leave the setup screen.\r
     //\r
-    GetVariable2 (EFI_CUSTOM_MODE_NAME, &gEfiCustomModeEnableGuid, (VOID**)&SecureBootMode, NULL);\r
-    if (NULL != SecureBootMode && *SecureBootMode == CUSTOM_SECURE_BOOT_MODE) {\r
+    GetVariable2 (EFI_CUSTOM_MODE_NAME, &gEfiCustomModeEnableGuid, (VOID **)&SecureBootMode, NULL);\r
+    if ((NULL != SecureBootMode) && (*SecureBootMode == CUSTOM_SECURE_BOOT_MODE)) {\r
       IfrNvData->SecureBootMode = STANDARD_SECURE_BOOT_MODE;\r
-      SetSecureBootMode(STANDARD_SECURE_BOOT_MODE);\r
+      SetSecureBootMode (STANDARD_SECURE_BOOT_MODE);\r
     }\r
+\r
     if (SecureBootMode != NULL) {\r
       FreePool (SecureBootMode);\r
     }\r
@@ -4949,13 +5031,13 @@ EXIT:
 \r
   if (!EFI_ERROR (Status) && GetBrowserDataResult) {\r
     BufferSize = sizeof (SECUREBOOT_CONFIGURATION);\r
-    HiiSetBrowserData (&gSecureBootConfigFormSetGuid, mSecureBootStorageName, BufferSize, (UINT8*) IfrNvData, NULL);\r
+    HiiSetBrowserData (&gSecureBootConfigFormSetGuid, mSecureBootStorageName, BufferSize, (UINT8 *)IfrNvData, NULL);\r
   }\r
 \r
   FreePool (IfrNvData);\r
 \r
-  if (File != NULL){\r
-    FreePool(File);\r
+  if (File != NULL) {\r
+    FreePool (File);\r
     File = NULL;\r
   }\r
 \r
@@ -4984,14 +5066,14 @@ InstallSecureBootConfigForm (
 \r
   DriverHandle = NULL;\r
   ConfigAccess = &PrivateData->ConfigAccess;\r
-  Status = gBS->InstallMultipleProtocolInterfaces (\r
-                  &DriverHandle,\r
-                  &gEfiDevicePathProtocolGuid,\r
-                  &mSecureBootHiiVendorDevicePath,\r
-                  &gEfiHiiConfigAccessProtocolGuid,\r
-                  ConfigAccess,\r
-                  NULL\r
-                  );\r
+  Status       = gBS->InstallMultipleProtocolInterfaces (\r
+                        &DriverHandle,\r
+                        &gEfiDevicePathProtocolGuid,\r
+                        &mSecureBootHiiVendorDevicePath,\r
+                        &gEfiHiiConfigAccessProtocolGuid,\r
+                        ConfigAccess,\r
+                        NULL\r
+                        );\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
@@ -5047,23 +5129,23 @@ InstallSecureBootConfigForm (
   //\r
   // Create Hii Extend Label OpCode as the start opcode\r
   //\r
-  mStartLabel = (EFI_IFR_GUID_LABEL *) HiiCreateGuidOpCode (\r
-                                         mStartOpCodeHandle,\r
-                                         &gEfiIfrTianoGuid,\r
-                                         NULL,\r
-                                         sizeof (EFI_IFR_GUID_LABEL)\r
-                                         );\r
+  mStartLabel = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
+                                        mStartOpCodeHandle,\r
+                                        &gEfiIfrTianoGuid,\r
+                                        NULL,\r
+                                        sizeof (EFI_IFR_GUID_LABEL)\r
+                                        );\r
   mStartLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
 \r
   //\r
   // Create Hii Extend Label OpCode as the end opcode\r
   //\r
-  mEndLabel = (EFI_IFR_GUID_LABEL *) HiiCreateGuidOpCode (\r
-                                       mEndOpCodeHandle,\r
-                                       &gEfiIfrTianoGuid,\r
-                                       NULL,\r
-                                       sizeof (EFI_IFR_GUID_LABEL)\r
-                                       );\r
+  mEndLabel = (EFI_IFR_GUID_LABEL *)HiiCreateGuidOpCode (\r
+                                      mEndOpCodeHandle,\r
+                                      &gEfiIfrTianoGuid,\r
+                                      NULL,\r
+                                      sizeof (EFI_IFR_GUID_LABEL)\r
+                                      );\r
   mEndLabel->ExtendOpCode = EFI_IFR_EXTEND_OP_LABEL;\r
   mEndLabel->Number       = LABEL_END;\r
 \r
@@ -5078,7 +5160,7 @@ InstallSecureBootConfigForm (
 **/\r
 VOID\r
 UninstallSecureBootConfigForm (\r
-  IN OUT SECUREBOOT_CONFIG_PRIVATE_DATA    *PrivateData\r
+  IN OUT SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData\r
   )\r
 {\r
   //\r
index 268f015e8e7dabe71031c79fc22a665b9a202ed2..37c66f1b954fe563f8c67ae6ef176f3af5c7c21b 100644 (file)
@@ -48,20 +48,20 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Tool generated IFR binary data and String package data\r
 //\r
-extern  UINT8                      SecureBootConfigBin[];\r
-extern  UINT8                      SecureBootConfigDxeStrings[];\r
+extern  UINT8  SecureBootConfigBin[];\r
+extern  UINT8  SecureBootConfigDxeStrings[];\r
 \r
 //\r
 // Shared IFR form update data\r
 //\r
-extern  VOID                       *mStartOpCodeHandle;\r
-extern  VOID                       *mEndOpCodeHandle;\r
-extern  EFI_IFR_GUID_LABEL         *mStartLabel;\r
-extern  EFI_IFR_GUID_LABEL         *mEndLabel;\r
+extern  VOID                *mStartOpCodeHandle;\r
+extern  VOID                *mEndOpCodeHandle;\r
+extern  EFI_IFR_GUID_LABEL  *mStartLabel;\r
+extern  EFI_IFR_GUID_LABEL  *mEndLabel;\r
 \r
-#define MAX_CHAR              480\r
-#define TWO_BYTE_ENCODE       0x82\r
-#define BUFFER_MAX_SIZE       100\r
+#define MAX_CHAR         480\r
+#define TWO_BYTE_ENCODE  0x82\r
+#define BUFFER_MAX_SIZE  100\r
 \r
 //\r
 // SHA-256 digest size in bytes\r
@@ -79,24 +79,24 @@ extern  EFI_IFR_GUID_LABEL         *mEndLabel;
 //\r
 // Set max digest size as SHA512 Output (64 bytes) by far\r
 //\r
-#define MAX_DIGEST_SIZE    SHA512_DIGEST_SIZE\r
+#define MAX_DIGEST_SIZE  SHA512_DIGEST_SIZE\r
 \r
-#define WIN_CERT_UEFI_RSA2048_SIZE               256\r
+#define WIN_CERT_UEFI_RSA2048_SIZE  256\r
 \r
 //\r
 // Support hash types\r
 //\r
-#define HASHALG_SHA224                         0x00000000\r
-#define HASHALG_SHA256                         0x00000001\r
-#define HASHALG_SHA384                         0x00000002\r
-#define HASHALG_SHA512                         0x00000003\r
-#define HASHALG_RAW                            0x00000004\r
-#define HASHALG_MAX                            0x00000004\r
+#define HASHALG_SHA224  0x00000000\r
+#define HASHALG_SHA256  0x00000001\r
+#define HASHALG_SHA384  0x00000002\r
+#define HASHALG_SHA512  0x00000003\r
+#define HASHALG_RAW     0x00000004\r
+#define HASHALG_MAX     0x00000004\r
 \r
 //\r
 // Certificate public key minimum size (bytes)\r
 //\r
-#define CER_PUBKEY_MIN_SIZE     256\r
+#define CER_PUBKEY_MIN_SIZE  256\r
 \r
 //\r
 // Types of errors may occur during certificate enrollment.\r
@@ -113,18 +113,18 @@ typedef enum {
   //\r
   Unqualified_Key,\r
   Enroll_Error_Max\r
-}ENROLL_KEY_ERROR;\r
+} ENROLL_KEY_ERROR;\r
 \r
 typedef struct {\r
-  UINTN             Signature;\r
-  LIST_ENTRY        Head;\r
-  UINTN             MenuNumber;\r
+  UINTN         Signature;\r
+  LIST_ENTRY    Head;\r
+  UINTN         MenuNumber;\r
 } SECUREBOOT_MENU_OPTION;\r
 \r
 typedef struct {\r
-  EFI_FILE_HANDLE                   FHandle;\r
-  UINT16                            *FileName;\r
-  UINT8                             FileType;\r
+  EFI_FILE_HANDLE    FHandle;\r
+  UINT16             *FileName;\r
+  UINT8              FileType;\r
 } SECUREBOOT_FILE_CONTEXT;\r
 \r
 #define SECUREBOOT_FREE_NON_NULL(Pointer)   \\r
@@ -149,11 +149,11 @@ typedef struct {
 // We define another format of 5th directory entry: security directory\r
 //\r
 typedef struct {\r
-  UINT32               Offset;      // Offset of certificate\r
-  UINT32               SizeOfCert;  // size of certificate appended\r
+  UINT32    Offset;                 // Offset of certificate\r
+  UINT32    SizeOfCert;             // size of certificate appended\r
 } EFI_IMAGE_SECURITY_DATA_DIRECTORY;\r
 \r
-typedef enum{\r
+typedef enum {\r
   ImageType_IA32,\r
   ImageType_X64\r
 } IMAGE_TYPE;\r
@@ -162,8 +162,8 @@ typedef enum{
 /// HII specific Vendor Device Path definition.\r
 ///\r
 typedef struct {\r
-  VENDOR_DEVICE_PATH                VendorDevicePath;\r
-  EFI_DEVICE_PATH_PROTOCOL          End;\r
+  VENDOR_DEVICE_PATH          VendorDevicePath;\r
+  EFI_DEVICE_PATH_PROTOCOL    End;\r
 } HII_VENDOR_DEVICE_PATH;\r
 \r
 typedef enum {\r
@@ -177,7 +177,7 @@ typedef enum {
   Delete_Signature_List_All,\r
   Delete_Signature_List_One,\r
   Delete_Signature_Data\r
-}SIGNATURE_DELETE_TYPE;\r
+} SIGNATURE_DELETE_TYPE;\r
 \r
 typedef struct {\r
   UINTN                             Signature;\r
@@ -196,10 +196,10 @@ typedef struct {
   BOOLEAN                           *CheckArray;      // Record which signature data checked.\r
 } SECUREBOOT_CONFIG_PRIVATE_DATA;\r
 \r
-extern SECUREBOOT_CONFIG_PRIVATE_DATA      mSecureBootConfigPrivateDateTemplate;\r
-extern SECUREBOOT_CONFIG_PRIVATE_DATA      *gSecureBootPrivateData;\r
+extern SECUREBOOT_CONFIG_PRIVATE_DATA  mSecureBootConfigPrivateDateTemplate;\r
+extern SECUREBOOT_CONFIG_PRIVATE_DATA  *gSecureBootPrivateData;\r
 \r
-#define SECUREBOOT_CONFIG_PRIVATE_DATA_SIGNATURE     SIGNATURE_32 ('S', 'E', 'C', 'B')\r
+#define SECUREBOOT_CONFIG_PRIVATE_DATA_SIGNATURE  SIGNATURE_32 ('S', 'E', 'C', 'B')\r
 #define SECUREBOOT_CONFIG_PRIVATE_FROM_THIS(a)  CR (a, SECUREBOOT_CONFIG_PRIVATE_DATA, ConfigAccess, SECUREBOOT_CONFIG_PRIVATE_DATA_SIGNATURE)\r
 \r
 //\r
@@ -207,16 +207,15 @@ extern SECUREBOOT_CONFIG_PRIVATE_DATA      *gSecureBootPrivateData;
 //\r
 #pragma pack(1)\r
 typedef struct _CPL_KEY_INFO {\r
-  UINT32        KeyLengthInBits;    // Key Length In Bits\r
-  UINT32        BlockSize;          // Operation Block Size in Bytes\r
-  UINT32        CipherBlockSize;    // Output Cipher Block Size in Bytes\r
-  UINT32        KeyType;            // Key Type\r
-  UINT32        CipherMode;         // Cipher Mode for Symmetric Algorithm\r
-  UINT32        Flags;              // Additional Key Property Flags\r
+  UINT32    KeyLengthInBits;        // Key Length In Bits\r
+  UINT32    BlockSize;              // Operation Block Size in Bytes\r
+  UINT32    CipherBlockSize;        // Output Cipher Block Size in Bytes\r
+  UINT32    KeyType;                // Key Type\r
+  UINT32    CipherMode;             // Cipher Mode for Symmetric Algorithm\r
+  UINT32    Flags;                  // Additional Key Property Flags\r
 } CPL_KEY_INFO;\r
 #pragma pack()\r
 \r
-\r
 /**\r
   Retrieves the size, in bytes, of the context buffer required for hash operations.\r
 \r
@@ -247,7 +246,6 @@ BOOLEAN
   IN OUT  VOID  *HashContext\r
   );\r
 \r
-\r
 /**\r
   Performs digest on a data buffer of the specified length. This function can\r
   be called multiple times to compute the digest of long or discontinuous data streams.\r
@@ -308,11 +306,10 @@ typedef struct {
 } HASH_TABLE;\r
 \r
 typedef struct {\r
-  WIN_CERTIFICATE Hdr;\r
-  UINT8           CertData[1];\r
+  WIN_CERTIFICATE    Hdr;\r
+  UINT8              CertData[1];\r
 } WIN_CERTIFICATE_EFI_PKCS;\r
 \r
-\r
 /**\r
   This function publish the SecureBoot configuration Form.\r
 \r
@@ -328,7 +325,6 @@ InstallSecureBootConfigForm (
   IN OUT SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData\r
   );\r
 \r
-\r
 /**\r
   This function removes SecureBoot configuration Form.\r
 \r
@@ -337,10 +333,9 @@ InstallSecureBootConfigForm (
 **/\r
 VOID\r
 UninstallSecureBootConfigForm (\r
-  IN OUT SECUREBOOT_CONFIG_PRIVATE_DATA    *PrivateData\r
+  IN OUT SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData\r
   );\r
 \r
-\r
 /**\r
   This function allows a caller to extract the current configuration for one\r
   or more named elements from the target driver.\r
@@ -370,13 +365,12 @@ UninstallSecureBootConfigForm (
 EFI_STATUS\r
 EFIAPI\r
 SecureBootExtractConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL        *This,\r
-  IN CONST EFI_STRING                            Request,\r
-       OUT EFI_STRING                            *Progress,\r
-       OUT EFI_STRING                            *Results\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Request,\r
+  OUT EFI_STRING                           *Progress,\r
+  OUT EFI_STRING                           *Results\r
   );\r
 \r
-\r
 /**\r
   This function processes the results of changes in configuration.\r
 \r
@@ -398,12 +392,11 @@ SecureBootExtractConfig (
 EFI_STATUS\r
 EFIAPI\r
 SecureBootRouteConfig (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN CONST EFI_STRING                          Configuration,\r
-       OUT EFI_STRING                          *Progress\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN CONST EFI_STRING                      Configuration,\r
+  OUT EFI_STRING                           *Progress\r
   );\r
 \r
-\r
 /**\r
   This function processes the results of changes in configuration.\r
 \r
@@ -429,15 +422,14 @@ SecureBootRouteConfig (
 EFI_STATUS\r
 EFIAPI\r
 SecureBootCallback (\r
-  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL      *This,\r
-  IN     EFI_BROWSER_ACTION                    Action,\r
-  IN     EFI_QUESTION_ID                       QuestionId,\r
-  IN     UINT8                                 Type,\r
-  IN     EFI_IFR_TYPE_VALUE                    *Value,\r
-     OUT EFI_BROWSER_ACTION_REQUEST            *ActionRequest\r
+  IN CONST EFI_HII_CONFIG_ACCESS_PROTOCOL  *This,\r
+  IN     EFI_BROWSER_ACTION                Action,\r
+  IN     EFI_QUESTION_ID                   QuestionId,\r
+  IN     UINT8                             Type,\r
+  IN     EFI_IFR_TYPE_VALUE                *Value,\r
+  OUT EFI_BROWSER_ACTION_REQUEST           *ActionRequest\r
   );\r
 \r
-\r
 /**\r
   This function converts an input device structure to a Unicode string.\r
 \r
@@ -449,10 +441,9 @@ SecureBootCallback (
 CHAR16 *\r
 EFIAPI\r
 DevicePathToStr (\r
-  IN EFI_DEVICE_PATH_PROTOCOL     *DevPath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *DevPath\r
   );\r
 \r
-\r
 /**\r
   Clean up the dynamic opcode at label and form specified by both LabelId.\r
 \r
@@ -462,11 +453,10 @@ DevicePathToStr (
 **/\r
 VOID\r
 CleanUpPage (\r
-  IN UINT16                           LabelId,\r
-  IN SECUREBOOT_CONFIG_PRIVATE_DATA   *PrivateData\r
+  IN UINT16                          LabelId,\r
+  IN SECUREBOOT_CONFIG_PRIVATE_DATA  *PrivateData\r
   );\r
 \r
-\r
 /**\r
   Read file content into BufferPtr, the size of the allocate buffer\r
   is *FileSize plus AdditionAllocateSize.\r
@@ -485,13 +475,12 @@ CleanUpPage (
 **/\r
 EFI_STATUS\r
 ReadFileContent (\r
-  IN      EFI_FILE_HANDLE           FileHandle,\r
-  IN OUT  VOID                      **BufferPtr,\r
-     OUT  UINTN                     *FileSize,\r
-  IN      UINTN                     AdditionAllocateSize\r
+  IN      EFI_FILE_HANDLE  FileHandle,\r
+  IN OUT  VOID             **BufferPtr,\r
+  OUT  UINTN               *FileSize,\r
+  IN      UINTN            AdditionAllocateSize\r
   );\r
 \r
-\r
 /**\r
   Close an open file handle.\r
 \r
@@ -500,10 +489,9 @@ ReadFileContent (
 **/\r
 VOID\r
 CloseFile (\r
-  IN EFI_FILE_HANDLE   FileHandle\r
+  IN EFI_FILE_HANDLE  FileHandle\r
   );\r
 \r
-\r
 /**\r
   Converts a nonnegative integer to an octet string of a specified length.\r
 \r
@@ -521,10 +509,10 @@ Returns:
 EFI_STATUS\r
 EFIAPI\r
 Int2OctStr (\r
-  IN     CONST UINTN       *Integer,\r
-  IN     UINTN             IntSizeInWords,\r
-     OUT UINT8             *OctetString,\r
-  IN     UINTN             OSSizeInBytes\r
+  IN     CONST UINTN  *Integer,\r
+  IN     UINTN        IntSizeInWords,\r
+  OUT UINT8           *OctetString,\r
+  IN     UINTN        OSSizeInBytes\r
   );\r
 \r
 /**\r
@@ -555,7 +543,7 @@ GuidToString (
 BOOLEAN\r
 EFIAPI\r
 UpdatePKFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   );\r
 \r
 /**\r
@@ -569,7 +557,7 @@ UpdatePKFromFile (
 BOOLEAN\r
 EFIAPI\r
 UpdateKEKFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   );\r
 \r
 /**\r
@@ -583,7 +571,7 @@ UpdateKEKFromFile (
 BOOLEAN\r
 EFIAPI\r
 UpdateDBFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   );\r
 \r
 /**\r
@@ -597,7 +585,7 @@ UpdateDBFromFile (
 BOOLEAN\r
 EFIAPI\r
 UpdateDBXFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   );\r
 \r
 /**\r
@@ -611,7 +599,7 @@ UpdateDBXFromFile (
 BOOLEAN\r
 EFIAPI\r
 UpdateDBTFromFile (\r
-  IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
+  IN EFI_DEVICE_PATH_PROTOCOL  *FilePath\r
   );\r
 \r
 #endif\r
index 3730fbe64649d6911a7b480340195668171a1eaf..aee1683120a998ded4e7c9ed8a2be7b2bd5328eb 100644 (file)
@@ -26,17 +26,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/\r
 EFI_STATUS\r
 ReadFileContent (\r
-  IN      EFI_FILE_HANDLE           FileHandle,\r
-  IN OUT  VOID                      **BufferPtr,\r
-     OUT  UINTN                     *FileSize,\r
-  IN      UINTN                     AdditionAllocateSize\r
+  IN      EFI_FILE_HANDLE  FileHandle,\r
+  IN OUT  VOID             **BufferPtr,\r
+  OUT  UINTN               *FileSize,\r
+  IN      UINTN            AdditionAllocateSize\r
   )\r
 \r
 {\r
-  UINTN      BufferSize;\r
-  UINT64     SourceFileSize;\r
-  VOID       *Buffer;\r
-  EFI_STATUS Status;\r
+  UINTN       BufferSize;\r
+  UINT64      SourceFileSize;\r
+  VOID        *Buffer;\r
+  EFI_STATUS  Status;\r
 \r
   if ((FileHandle == NULL) || (FileSize == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -47,7 +47,7 @@ ReadFileContent (
   //\r
   // Get the file size\r
   //\r
-  Status = FileHandle->SetPosition (FileHandle, (UINT64) -1);\r
+  Status = FileHandle->SetPosition (FileHandle, (UINT64)-1);\r
   if (EFI_ERROR (Status)) {\r
     goto ON_EXIT;\r
   }\r
@@ -62,20 +62,20 @@ ReadFileContent (
     goto ON_EXIT;\r
   }\r
 \r
-  BufferSize = (UINTN) SourceFileSize + AdditionAllocateSize;\r
-  Buffer =  AllocateZeroPool(BufferSize);\r
+  BufferSize = (UINTN)SourceFileSize + AdditionAllocateSize;\r
+  Buffer     =  AllocateZeroPool (BufferSize);\r
   if (Buffer == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  BufferSize = (UINTN) SourceFileSize;\r
+  BufferSize = (UINTN)SourceFileSize;\r
   *FileSize  = BufferSize;\r
 \r
   Status = FileHandle->Read (FileHandle, &BufferSize, Buffer);\r
-  if (EFI_ERROR (Status) || BufferSize != *FileSize) {\r
+  if (EFI_ERROR (Status) || (BufferSize != *FileSize)) {\r
     FreePool (Buffer);\r
     Buffer = NULL;\r
-    Status  = EFI_BAD_BUFFER_SIZE;\r
+    Status = EFI_BAD_BUFFER_SIZE;\r
     goto ON_EXIT;\r
   }\r
 \r
@@ -93,7 +93,7 @@ ON_EXIT:
 **/\r
 VOID\r
 CloseFile (\r
-  IN EFI_FILE_HANDLE   FileHandle\r
+  IN EFI_FILE_HANDLE  FileHandle\r
   )\r
 {\r
   if (FileHandle != NULL) {\r
@@ -118,10 +118,10 @@ Returns:
 EFI_STATUS\r
 EFIAPI\r
 Int2OctStr (\r
-  IN     CONST UINTN                *Integer,\r
-  IN     UINTN                      IntSizeInWords,\r
-     OUT UINT8                      *OctetString,\r
-  IN     UINTN                      OSSizeInBytes\r
+  IN     CONST UINTN  *Integer,\r
+  IN     UINTN        IntSizeInWords,\r
+  OUT UINT8           *OctetString,\r
+  IN     UINTN        OSSizeInBytes\r
   )\r
 {\r
   CONST UINT8  *Ptr1;\r
@@ -129,11 +129,13 @@ Int2OctStr (
 \r
   for (Ptr1 = (CONST UINT8 *)Integer, Ptr2 = OctetString + OSSizeInBytes - 1;\r
        Ptr1 < (UINT8 *)(Integer + IntSizeInWords) && Ptr2 >= OctetString;\r
-       Ptr1++, Ptr2--) {\r
+       Ptr1++, Ptr2--)\r
+  {\r
     *Ptr2 = *Ptr1;\r
   }\r
 \r
-  for (; Ptr1 < (CONST UINT8 *)(Integer + IntSizeInWords) && *Ptr1 == 0; Ptr1++);\r
+  for ( ; Ptr1 < (CONST UINT8 *)(Integer + IntSizeInWords) && *Ptr1 == 0; Ptr1++) {\r
+  }\r
 \r
   if (Ptr1 < (CONST UINT8 *)(Integer + IntSizeInWords)) {\r
     return EFI_BUFFER_TOO_SMALL;\r
@@ -163,24 +165,24 @@ GuidToString (
   IN  UINTN     BufferSize\r
   )\r
 {\r
-  UINTN Size;\r
+  UINTN  Size;\r
 \r
   Size = UnicodeSPrint (\r
-            Buffer,\r
-            BufferSize,\r
-            L"%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",\r
-            (UINTN)Guid->Data1,\r
-            (UINTN)Guid->Data2,\r
-            (UINTN)Guid->Data3,\r
-            (UINTN)Guid->Data4[0],\r
-            (UINTN)Guid->Data4[1],\r
-            (UINTN)Guid->Data4[2],\r
-            (UINTN)Guid->Data4[3],\r
-            (UINTN)Guid->Data4[4],\r
-            (UINTN)Guid->Data4[5],\r
-            (UINTN)Guid->Data4[6],\r
-            (UINTN)Guid->Data4[7]\r
-            );\r
+           Buffer,\r
+           BufferSize,\r
+           L"%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",\r
+           (UINTN)Guid->Data1,\r
+           (UINTN)Guid->Data2,\r
+           (UINTN)Guid->Data3,\r
+           (UINTN)Guid->Data4[0],\r
+           (UINTN)Guid->Data4[1],\r
+           (UINTN)Guid->Data4[2],\r
+           (UINTN)Guid->Data4[3],\r
+           (UINTN)Guid->Data4[4],\r
+           (UINTN)Guid->Data4[5],\r
+           (UINTN)Guid->Data4[6],\r
+           (UINTN)Guid->Data4[7]\r
+           );\r
 \r
   //\r
   // SPrint will null terminate the string. The -1 skips the null\r
index 4ecc25efc3be061edbaddfe74f2ad59feb6e88a1..34720bb5e29d1e7073dc9529519be7184e6abf0d 100644 (file)
@@ -15,128 +15,128 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // Used by VFR for form or button identification\r
 //\r
-#define SECUREBOOT_CONFIGURATION_VARSTORE_ID  0x0001\r
-#define SECUREBOOT_CONFIGURATION_FORM_ID      0x01\r
-#define FORMID_SECURE_BOOT_OPTION_FORM        0x02\r
-#define FORMID_SECURE_BOOT_PK_OPTION_FORM     0x03\r
-#define FORMID_SECURE_BOOT_KEK_OPTION_FORM    0x04\r
-#define FORMID_SECURE_BOOT_DB_OPTION_FORM     0x05\r
-#define FORMID_SECURE_BOOT_DBX_OPTION_FORM    0x06\r
-#define FORMID_ENROLL_PK_FORM                 0x07\r
-#define SECUREBOOT_ADD_PK_FILE_FORM_ID        0x08\r
-#define FORMID_ENROLL_KEK_FORM                0x09\r
-#define FORMID_DELETE_KEK_FORM                0x0a\r
-#define SECUREBOOT_ENROLL_SIGNATURE_TO_DB     0x0b\r
-#define SECUREBOOT_DELETE_SIGNATURE_FROM_DB   0x0c\r
-#define SECUREBOOT_ENROLL_SIGNATURE_TO_DBX    0x0d\r
-#define FORMID_SECURE_BOOT_DBT_OPTION_FORM    0x14\r
-#define SECUREBOOT_ENROLL_SIGNATURE_TO_DBT    0x15\r
-#define SECUREBOOT_DELETE_SIGNATURE_FROM_DBT  0x16\r
-#define SECUREBOOT_DELETE_SIGNATURE_LIST_FORM 0x17\r
-#define SECUREBOOT_DELETE_SIGNATURE_DATA_FORM 0x18\r
-\r
-#define SECURE_BOOT_MODE_CUSTOM               0x01\r
-#define SECURE_BOOT_MODE_STANDARD             0x00\r
-\r
-#define KEY_SECURE_BOOT_ENABLE                0x1000\r
-#define KEY_SECURE_BOOT_MODE                  0x1001\r
-#define KEY_VALUE_SAVE_AND_EXIT_DB            0x1002\r
-#define KEY_VALUE_NO_SAVE_AND_EXIT_DB         0x1003\r
-#define KEY_VALUE_SAVE_AND_EXIT_PK            0x1004\r
-#define KEY_VALUE_NO_SAVE_AND_EXIT_PK         0x1005\r
-#define KEY_VALUE_SAVE_AND_EXIT_KEK           0x1008\r
-#define KEY_VALUE_NO_SAVE_AND_EXIT_KEK        0x1009\r
-#define KEY_VALUE_SAVE_AND_EXIT_DBX           0x100a\r
-#define KEY_VALUE_NO_SAVE_AND_EXIT_DBX        0x100b\r
-#define KEY_HIDE_SECURE_BOOT                  0x100c\r
-#define KEY_VALUE_SAVE_AND_EXIT_DBT           0x100d\r
-#define KEY_VALUE_NO_SAVE_AND_EXIT_DBT        0x100e\r
-\r
-#define KEY_VALUE_FROM_DBX_TO_LIST_FORM       0x100f\r
-\r
-#define KEY_SECURE_BOOT_RESET_TO_DEFAULT      0x1010\r
-\r
-#define KEY_SECURE_BOOT_OPTION                0x1100\r
-#define KEY_SECURE_BOOT_PK_OPTION             0x1101\r
-#define KEY_SECURE_BOOT_KEK_OPTION            0x1102\r
-#define KEY_SECURE_BOOT_DB_OPTION             0x1103\r
-#define KEY_SECURE_BOOT_DBX_OPTION            0x1104\r
-#define KEY_SECURE_BOOT_DELETE_PK             0x1105\r
-#define KEY_ENROLL_PK                         0x1106\r
-#define KEY_ENROLL_KEK                        0x1107\r
-#define KEY_DELETE_KEK                        0x1108\r
-#define KEY_SECURE_BOOT_KEK_GUID              0x110a\r
-#define KEY_SECURE_BOOT_SIGNATURE_GUID_DB     0x110b\r
-#define KEY_SECURE_BOOT_SIGNATURE_GUID_DBX    0x110c\r
-#define KEY_SECURE_BOOT_DBT_OPTION            0x110d\r
-#define KEY_SECURE_BOOT_SIGNATURE_GUID_DBT    0x110e\r
-#define KEY_SECURE_BOOT_DELETE_ALL_LIST       0x110f\r
-#define KEY_SECURE_BOOT_DELETE_ALL_DATA       0x1110\r
-#define KEY_SECURE_BOOT_DELETE_CHECK_DATA     0x1111\r
-\r
-#define LABEL_KEK_DELETE                      0x1200\r
-#define LABEL_DB_DELETE                       0x1201\r
-#define LABEL_SIGNATURE_LIST_START            0x1202\r
-#define LABEL_DBT_DELETE                      0x1203\r
-#define LABEL_SIGNATURE_DATA_START            0x1204\r
-#define LABEL_DELETE_ALL_LIST_BUTTON          0x1300\r
-#define LABEL_END                             0xffff\r
-\r
-#define SECURE_BOOT_MAX_ATTEMPTS_NUM          255\r
-\r
-#define CONFIG_OPTION_OFFSET                  0x2000\r
-\r
-#define OPTION_CONFIG_QUESTION_ID             0x2000\r
-#define OPTION_CONFIG_RANGE                   0x1000\r
+#define SECUREBOOT_CONFIGURATION_VARSTORE_ID   0x0001\r
+#define SECUREBOOT_CONFIGURATION_FORM_ID       0x01\r
+#define FORMID_SECURE_BOOT_OPTION_FORM         0x02\r
+#define FORMID_SECURE_BOOT_PK_OPTION_FORM      0x03\r
+#define FORMID_SECURE_BOOT_KEK_OPTION_FORM     0x04\r
+#define FORMID_SECURE_BOOT_DB_OPTION_FORM      0x05\r
+#define FORMID_SECURE_BOOT_DBX_OPTION_FORM     0x06\r
+#define FORMID_ENROLL_PK_FORM                  0x07\r
+#define SECUREBOOT_ADD_PK_FILE_FORM_ID         0x08\r
+#define FORMID_ENROLL_KEK_FORM                 0x09\r
+#define FORMID_DELETE_KEK_FORM                 0x0a\r
+#define SECUREBOOT_ENROLL_SIGNATURE_TO_DB      0x0b\r
+#define SECUREBOOT_DELETE_SIGNATURE_FROM_DB    0x0c\r
+#define SECUREBOOT_ENROLL_SIGNATURE_TO_DBX     0x0d\r
+#define FORMID_SECURE_BOOT_DBT_OPTION_FORM     0x14\r
+#define SECUREBOOT_ENROLL_SIGNATURE_TO_DBT     0x15\r
+#define SECUREBOOT_DELETE_SIGNATURE_FROM_DBT   0x16\r
+#define SECUREBOOT_DELETE_SIGNATURE_LIST_FORM  0x17\r
+#define SECUREBOOT_DELETE_SIGNATURE_DATA_FORM  0x18\r
+\r
+#define SECURE_BOOT_MODE_CUSTOM    0x01\r
+#define SECURE_BOOT_MODE_STANDARD  0x00\r
+\r
+#define KEY_SECURE_BOOT_ENABLE          0x1000\r
+#define KEY_SECURE_BOOT_MODE            0x1001\r
+#define KEY_VALUE_SAVE_AND_EXIT_DB      0x1002\r
+#define KEY_VALUE_NO_SAVE_AND_EXIT_DB   0x1003\r
+#define KEY_VALUE_SAVE_AND_EXIT_PK      0x1004\r
+#define KEY_VALUE_NO_SAVE_AND_EXIT_PK   0x1005\r
+#define KEY_VALUE_SAVE_AND_EXIT_KEK     0x1008\r
+#define KEY_VALUE_NO_SAVE_AND_EXIT_KEK  0x1009\r
+#define KEY_VALUE_SAVE_AND_EXIT_DBX     0x100a\r
+#define KEY_VALUE_NO_SAVE_AND_EXIT_DBX  0x100b\r
+#define KEY_HIDE_SECURE_BOOT            0x100c\r
+#define KEY_VALUE_SAVE_AND_EXIT_DBT     0x100d\r
+#define KEY_VALUE_NO_SAVE_AND_EXIT_DBT  0x100e\r
+\r
+#define KEY_VALUE_FROM_DBX_TO_LIST_FORM  0x100f\r
+\r
+#define KEY_SECURE_BOOT_RESET_TO_DEFAULT  0x1010\r
+\r
+#define KEY_SECURE_BOOT_OPTION              0x1100\r
+#define KEY_SECURE_BOOT_PK_OPTION           0x1101\r
+#define KEY_SECURE_BOOT_KEK_OPTION          0x1102\r
+#define KEY_SECURE_BOOT_DB_OPTION           0x1103\r
+#define KEY_SECURE_BOOT_DBX_OPTION          0x1104\r
+#define KEY_SECURE_BOOT_DELETE_PK           0x1105\r
+#define KEY_ENROLL_PK                       0x1106\r
+#define KEY_ENROLL_KEK                      0x1107\r
+#define KEY_DELETE_KEK                      0x1108\r
+#define KEY_SECURE_BOOT_KEK_GUID            0x110a\r
+#define KEY_SECURE_BOOT_SIGNATURE_GUID_DB   0x110b\r
+#define KEY_SECURE_BOOT_SIGNATURE_GUID_DBX  0x110c\r
+#define KEY_SECURE_BOOT_DBT_OPTION          0x110d\r
+#define KEY_SECURE_BOOT_SIGNATURE_GUID_DBT  0x110e\r
+#define KEY_SECURE_BOOT_DELETE_ALL_LIST     0x110f\r
+#define KEY_SECURE_BOOT_DELETE_ALL_DATA     0x1110\r
+#define KEY_SECURE_BOOT_DELETE_CHECK_DATA   0x1111\r
+\r
+#define LABEL_KEK_DELETE              0x1200\r
+#define LABEL_DB_DELETE               0x1201\r
+#define LABEL_SIGNATURE_LIST_START    0x1202\r
+#define LABEL_DBT_DELETE              0x1203\r
+#define LABEL_SIGNATURE_DATA_START    0x1204\r
+#define LABEL_DELETE_ALL_LIST_BUTTON  0x1300\r
+#define LABEL_END                     0xffff\r
+\r
+#define SECURE_BOOT_MAX_ATTEMPTS_NUM  255\r
+\r
+#define CONFIG_OPTION_OFFSET  0x2000\r
+\r
+#define OPTION_CONFIG_QUESTION_ID  0x2000\r
+#define OPTION_CONFIG_RANGE        0x1000\r
 \r
 //\r
 // Question ID 0x2000 ~ 0x2FFF is for KEK\r
 //\r
-#define OPTION_DEL_KEK_QUESTION_ID            0x2000\r
+#define OPTION_DEL_KEK_QUESTION_ID  0x2000\r
 //\r
 // Question ID 0x3000 ~ 0x3FFF is for DB\r
 //\r
-#define OPTION_DEL_DB_QUESTION_ID             0x3000\r
+#define OPTION_DEL_DB_QUESTION_ID  0x3000\r
 //\r
 // Question ID 0x4000 ~ 0x4FFF is for signature list.\r
 //\r
-#define OPTION_SIGNATURE_LIST_QUESTION_ID     0X4000\r
+#define OPTION_SIGNATURE_LIST_QUESTION_ID  0X4000\r
 //\r
 // Question ID 0x6000 ~ 0x6FFF is for signature data.\r
 //\r
-#define OPTION_SIGNATURE_DATA_QUESTION_ID     0x6000\r
+#define OPTION_SIGNATURE_DATA_QUESTION_ID  0x6000\r
 \r
 //\r
 // Question ID 0x5000 ~ 0x5FFF is for DBT\r
 //\r
-#define OPTION_DEL_DBT_QUESTION_ID            0x5000\r
+#define OPTION_DEL_DBT_QUESTION_ID  0x5000\r
 \r
-#define SECURE_BOOT_GUID_SIZE                 36\r
-#define SECURE_BOOT_GUID_STORAGE_SIZE         37\r
+#define SECURE_BOOT_GUID_SIZE          36\r
+#define SECURE_BOOT_GUID_STORAGE_SIZE  37\r
 \r
-#define UNKNOWN_FILE_TYPE                     0\r
-#define X509_CERT_FILE_TYPE                   1\r
-#define PE_IMAGE_FILE_TYPE                    2\r
-#define AUTHENTICATION_2_FILE_TYPE            3\r
+#define UNKNOWN_FILE_TYPE           0\r
+#define X509_CERT_FILE_TYPE         1\r
+#define PE_IMAGE_FILE_TYPE          2\r
+#define AUTHENTICATION_2_FILE_TYPE  3\r
 \r
 //\r
 // Nv Data structure referenced by IFR\r
 //\r
 typedef struct {\r
-  BOOLEAN AttemptSecureBoot;   // Attempt to enable/disable Secure Boot\r
-  BOOLEAN HideSecureBoot;      // Hidden Attempt Secure Boot\r
-  CHAR16  SignatureGuid[SECURE_BOOT_GUID_STORAGE_SIZE];\r
-  BOOLEAN PhysicalPresent;     // If a Physical Present User\r
-  UINT8   SecureBootMode;      // Secure Boot Mode: Standard Or Custom\r
-  BOOLEAN DeletePk;\r
-  BOOLEAN HasPk;               // If Pk is existed it is true\r
-  BOOLEAN AlwaysRevocation;    // If the certificate is always revoked. Revocation time is hidden\r
-  UINT8   CertificateFormat;   // The type of the certificate\r
-  EFI_HII_DATE RevocationDate; // The revocation date of the certificate\r
-  EFI_HII_TIME RevocationTime; // The revocation time of the certificate\r
-  UINT8   FileEnrollType;      // File type of signature enroll\r
-  UINT32  ListCount;           // The count of signature list.\r
-  UINT32  CheckedDataCount;    // The count of checked signature data.\r
+  BOOLEAN         AttemptSecureBoot; // Attempt to enable/disable Secure Boot\r
+  BOOLEAN         HideSecureBoot;    // Hidden Attempt Secure Boot\r
+  CHAR16          SignatureGuid[SECURE_BOOT_GUID_STORAGE_SIZE];\r
+  BOOLEAN         PhysicalPresent; // If a Physical Present User\r
+  UINT8           SecureBootMode;  // Secure Boot Mode: Standard Or Custom\r
+  BOOLEAN         DeletePk;\r
+  BOOLEAN         HasPk;             // If Pk is existed it is true\r
+  BOOLEAN         AlwaysRevocation;  // If the certificate is always revoked. Revocation time is hidden\r
+  UINT8           CertificateFormat; // The type of the certificate\r
+  EFI_HII_DATE    RevocationDate;    // The revocation date of the certificate\r
+  EFI_HII_TIME    RevocationTime;    // The revocation time of the certificate\r
+  UINT8           FileEnrollType;    // File type of signature enroll\r
+  UINT32          ListCount;         // The count of signature list.\r
+  UINT32          CheckedDataCount;  // The count of checked signature data.\r
 } SECUREBOOT_CONFIGURATION;\r
 \r
 #endif\r
index 10bdb1b58e6f1dfe82fd972412b8864cdeb63dda..ef7b01f16119cb47520e9b767954942125be490f 100644 (file)
@@ -33,15 +33,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 EFI_STATUS\r
 EFIAPI\r
 SecureBootDefaultKeysEntryPoint (\r
-  IN EFI_HANDLE          ImageHandle,\r
-  IN EFI_SYSTEM_TABLE    *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   EFI_STATUS  Status;\r
 \r
   Status = SecureBootInitPKDefault ();\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG((DEBUG_ERROR, "%a: Cannot initialize PKDefault: %r\n", __FUNCTION__, Status));\r
+    DEBUG ((DEBUG_ERROR, "%a: Cannot initialize PKDefault: %r\n", __FUNCTION__, Status));\r
     return Status;\r
   }\r
 \r
@@ -50,6 +50,7 @@ SecureBootDefaultKeysEntryPoint (
     DEBUG ((DEBUG_ERROR, "%a: Cannot initialize KEKDefault: %r\n", __FUNCTION__, Status));\r
     return Status;\r
   }\r
+\r
   Status = SecureBootInitDbDefault ();\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "%a: Cannot initialize dbDefault: %r\n", __FUNCTION__, Status));\r