]>
git.proxmox.com Git - pve-manager.git/log
Thomas Lamprecht [Wed, 19 May 2021 14:10:04 +0000 (16:10 +0200)]
ui: window/FW Log Rate: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:08:52 +0000 (16:08 +0200)]
ui: window/wizard: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:08:14 +0000 (16:08 +0200)]
ui: window/ceph install: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:08:01 +0000 (16:08 +0200)]
ui: window/bulkaction: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:07:51 +0000 (16:07 +0200)]
ui: window/startup: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 12:17:50 +0000 (14:17 +0200)]
ui: snapshot tree: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:22 +0000 (12:56 +0200)]
ui: panel/StatusPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:21 +0000 (12:56 +0200)]
ui: panel/RunningChart: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:20 +0000 (12:56 +0200)]
ui: panel/NotesView: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:19 +0000 (12:56 +0200)]
ui: panel/IPSet: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:18 +0000 (12:56 +0200)]
ui: panel/ConfigPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 12:00:59 +0000 (14:00 +0200)]
ui: resource tree: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:30:06 +0000 (12:30 +0200)]
ui: form/pci: add simple IOMMU group renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:29:29 +0000 (12:29 +0200)]
ui: qemu/PCI Edit: code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 09:14:19 +0000 (11:14 +0200)]
ui: storage/PBS edit: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 09:14:18 +0000 (11:14 +0200)]
ui: qemu: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:11:46 +0000 (12:11 +0200)]
ui: node/ZFS-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:11:37 +0000 (12:11 +0200)]
ui: node/LVM-Thin-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:11:27 +0000 (12:11 +0200)]
ui: node/LVM-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:11:19 +0000 (12:11 +0200)]
ui: node/directory-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:17:24 +0000 (11:17 +0200)]
ui: node/command menu: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:07:32 +0000 (11:07 +0200)]
ui: node certs: use new loadFile helper to avoid confusion
we did not handle those cert related files like SSH keys, so do not
suggest so.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:07:03 +0000 (11:07 +0200)]
ui: utils: split out general "load local file" helper
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:05:18 +0000 (11:05 +0200)]
ui: node/certs: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:03:28 +0000 (11:03 +0200)]
ui: node certs: make delete button safer, add confirmation
IMO the behavior was really dangerous prev., possibly causing
downtime of API accessing stuff with a single mistaken click.
Follow our general pattern and ask for confirmation
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 08:19:07 +0000 (10:19 +0200)]
ui: lxc/context cmd: factor out confirmed CT command
unifying CT and VM command menu would be pretty easy now, but I need
to wrap the eslint stuff up, so cannot chase all tails..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 08:18:48 +0000 (10:18 +0200)]
fixup! ui: qemu/context cmd: code cleanup/refactoring/modernize
Thomas Lamprecht [Wed, 19 May 2021 08:14:18 +0000 (10:14 +0200)]
ui: lxc/context cmd: code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 08:00:57 +0000 (10:00 +0200)]
ui: menu/item: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 07:58:35 +0000 (09:58 +0200)]
ui: menu/template: hide clone/migrate button if not possible
Depending on permissions and cluster state those action may not make
sense to be shown.
This streamlines behavior with the one we already have for
non-templates.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 07:56:50 +0000 (09:56 +0200)]
ui: menu/template: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 07:55:15 +0000 (09:55 +0200)]
ui: qemu/context cmd: factor out confirmed VM command
could be also a generator (higher order fn), but it's easier to
grasp the scope and the like this way
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 07:36:02 +0000 (09:36 +0200)]
ui: qemu/context cmd: code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 06:46:35 +0000 (08:46 +0200)]
ui: lxc/Network: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 06:45:46 +0000 (08:45 +0200)]
ui: lxc/Mountpoints: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 06:45:29 +0000 (08:45 +0200)]
ui: parser: fixup printLxcMountPoint object iteration
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 06:20:01 +0000 (08:20 +0200)]
ui: lxc/CreateWizard: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 05:01:51 +0000 (07:01 +0200)]
ui: ha/Resources: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 05:01:31 +0000 (07:01 +0200)]
ui: ha/GroupView: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 16:17:55 +0000 (18:17 +0200)]
ui: ha/Group Edit: use simple map+join to serialize nodes-prio
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 16:17:12 +0000 (18:17 +0200)]
ui: ha/Group Edit: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 16:00:42 +0000 (18:00 +0200)]
ui: grid/Resources: eslint fixes and code cleanup/refactoring
this is a major cleanup, using the current ExtJS and ES2018 features
allows to do a lot more concise and nicer.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 16:00:30 +0000 (18:00 +0200)]
ui: grid/Replication: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 15:59:16 +0000 (17:59 +0200)]
ui: grid/Firewall: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:53:22 +0000 (16:53 +0200)]
ui: qemu/OS defaults: code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:52:53 +0000 (16:52 +0200)]
ui: form/Guest Selector: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:52:40 +0000 (16:52 +0200)]
ui: form/View Selector: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:51:31 +0000 (16:51 +0200)]
ui: form/USB Selector: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:51:21 +0000 (16:51 +0200)]
ui: form/API Token Selector: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:50:53 +0000 (16:50 +0200)]
ui: form/Priv.Selector: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:50:38 +0000 (16:50 +0200)]
ui: form/Node Selector: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:50:14 +0000 (16:50 +0200)]
ui: form/Global Search: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:50:03 +0000 (16:50 +0200)]
ui: form/Controller Selector: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 14:42:35 +0000 (16:42 +0200)]
ui: parser: fixup printing LXC network
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 13:21:58 +0000 (15:21 +0200)]
ui: eslint auto-fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Tue, 18 May 2021 12:12:18 +0000 (14:12 +0200)]
ui: eslint: Miscellaneous eslint fixes
Function syntax, raw words, string templates, no prototype builtins
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Tue, 18 May 2021 12:12:17 +0000 (14:12 +0200)]
ui: eslint: State equalities more precisely
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Tue, 18 May 2021 12:12:16 +0000 (14:12 +0200)]
ui: eslint: Remove useless escapes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Tue, 18 May 2021 12:12:15 +0000 (14:12 +0200)]
ui: eslint: Functions may not be completely empty
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Tue, 18 May 2021 12:12:14 +0000 (14:12 +0200)]
ui: eslint: No unused or duplicate variables
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Tue, 18 May 2021 12:12:13 +0000 (14:12 +0200)]
ui: eslint: fix usage of 'me'
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 12:45:55 +0000 (14:45 +0200)]
ui: dc: log, options, support: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 12:40:44 +0000 (14:40 +0200)]
ui: dc/StorageView: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 12:39:40 +0000 (14:39 +0200)]
ui: dc/UserEdit: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 12:32:20 +0000 (14:32 +0200)]
ui: dc/Tasks: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 12:07:36 +0000 (14:07 +0200)]
ui: dc/TFA Edit: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 11:54:00 +0000 (13:54 +0200)]
ui: dc/Summary: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 11:09:20 +0000 (13:09 +0200)]
ui: dc/FW Security Group: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 10:45:43 +0000 (12:45 +0200)]
ui: dc/RoleView: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 10:26:11 +0000 (12:26 +0200)]
ui: dc/NodeView: mark only usage over 75% with a warning
As 60% is pretty low, and normally still OK and even wanted to have
(no need for having an over-dimensioned setup with lots of unused
resources).
Note, this is not a off-by-one, I want to compare real bigger > 75%
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 10:19:24 +0000 (12:19 +0200)]
ui: dc/NodeView: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 10:13:26 +0000 (12:13 +0200)]
ui: dc: health, config, guests; eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 09:34:53 +0000 (11:34 +0200)]
ui: dc/corosync-link: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 08:04:17 +0000 (10:04 +0200)]
ui: dc/cluster: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 18:40:10 +0000 (20:40 +0200)]
ui: dc/Backup: eslint fixes and code cleanup/refactoring
this one would deserve much more, especially the newer backup job
detail and not-backed-up view should be split out and done in a
declarative way (view view-controller)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 18:11:28 +0000 (20:11 +0200)]
ui: dc/ACMEPlugins: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 18:11:07 +0000 (20:11 +0200)]
ui: dc/ACLView: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 18:03:47 +0000 (20:03 +0200)]
ui: data/ResourceStore: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 17:58:52 +0000 (19:58 +0200)]
ui: buttons: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 17:40:33 +0000 (19:40 +0200)]
ui: workspace: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 17:20:33 +0000 (19:20 +0200)]
ui: utils: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 16:21:50 +0000 (18:21 +0200)]
ui: state provider: try to find string encoded values in dictionary
My browser here is pretty fixated on the history, and due to some
unknown reason I got a history fragment string like:
`#v1:=0:=18:=4:::::::` so the "hashes" got into strings, and I was
not able to move them back.
Adding a match here to always try reverse-mapping the hash to the
original input helps to fix that here.
We'd only run into issues if we'd use a integer-string as id, but we
really don't (IIRC not even allowed in extjs) so this is safe to do.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 14:45:00 +0000 (16:45 +0200)]
ui: state provider: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 14:40:54 +0000 (16:40 +0200)]
state provider: drop confirm-query when going back over initial history
eslint complains about the window.confirm call, and neither I nor
some other colleagues here did see that dialogue ever in practice.
The confirm here does not adds any real value, as all other back
navigation are unprotected, but have similar potential in loosing
state.
One can always navigate forward via their user agent and for console
(noVNC, xterm.js) we have now a separate check.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 14:02:50 +0000 (16:02 +0200)]
ui: toolkit: eslint fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 14:01:21 +0000 (16:01 +0200)]
ui: parser: eslint fixes and refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 17 May 2021 13:49:27 +0000 (15:49 +0200)]
ui: parser: drop old openVZ parser
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Lorenz Stechauner [Fri, 14 May 2021 10:13:17 +0000 (12:13 +0200)]
fix #3426: ui: parser: adapt parseSSHKey to accept "sk-" prefix
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Lorenz Stechauner [Fri, 14 May 2021 10:13:16 +0000 (12:13 +0200)]
ui: cloudinit: use PVE.Parser.parseSSHKey
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Fabian Grünbichler [Mon, 17 May 2021 07:46:47 +0000 (09:46 +0200)]
fix #3430: handle hook script paths better
if passing the hook script command as string, it might get interpreted
as shell command with side-effects. this is pretty harmless, since only
root is allowed to set the script parameter anyway, but making it more
robust and future-proof does not hurt.
tested with a reproducer of "/bin/echo $(touch $(whoami))" as script
parameter, with a file with that name existing, being executable and
having the following contents:
----8<----
echo "hello from hook script"
---->8----
without this change, the hookscript itself is not executed, but
'/bin/sh -c "/bin/echo $(touch $(whoami)) job"' and similar calls are,
which cause the file 'root' to be touched in the current working
directory of the vzdump process (or task worker).
with this change, the file is executed as is without any side-effects of
shell commands in the file name, and the 'hello from hook script' lines
are printed whenever the hook script is called by vzdump.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Thomas Lamprecht [Tue, 11 May 2021 13:57:58 +0000 (15:57 +0200)]
report: top: also print command line arguments
at least the first 512 characters, which is the biggest width one can
instruct `top` too.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 11 May 2021 13:23:30 +0000 (15:23 +0200)]
report: top: list more processes and order them by CPU time spent
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 11 May 2021 13:20:10 +0000 (15:20 +0200)]
report: re-organize: add systemd-load, unify bios/pci in HW one
Also rename disks to blockdevices, as especially with the iSCSI stuff
the listed devices do not necessarily need to be real disks.
Grouping current(ish) load info in it's own system-load section seems
to be a better fit in general too.
bios/pci stuff is all hardware, so group it there to avoid adding to
much sections.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 11 May 2021 13:12:15 +0000 (15:12 +0200)]
report: dir2text: print what we process on STDERR
to avoid those "lonely" "OK" prints for those
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 11 May 2021 12:58:15 +0000 (14:58 +0200)]
report: avoid extra oder array, define it inline
Makes all report-def entries hashes which allows to drop some
handling for the ARRAY ref case.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 11 May 2021 12:28:46 +0000 (14:28 +0200)]
report: avoid adding to report by side-effects, be more explicit
And move the helper methods up and scope them to module-local only
Uses the fact that perl methods return the last statement, so the
dir2text sub closures in the command list do not need to be changed
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 11 May 2021 12:27:40 +0000 (14:27 +0200)]
report: set timeout and PATH env only locally
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 11 May 2021 12:26:15 +0000 (14:26 +0200)]
report: whitespace cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Oguz Bektas [Tue, 11 May 2021 11:04:00 +0000 (13:04 +0200)]
pvereport: get pressure stall information
PSI can be queried in /proc/pressure/{cpu,io,memory} for the
corresponding resources. this helps us track down disruptions caused
by resource overcommitment.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Lorenz Stechauner [Mon, 10 May 2021 07:43:13 +0000 (09:43 +0200)]
api: pools: fix typo/syntax error
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>