Update For R9 Review.

[mirror_edk2.git] / IntelFrameworkModulePkg / Bus / Pci / VgaMiniPortDxe / VgaMiniPort.c

diff --git a/IntelFrameworkModulePkg/Bus/Pci/VgaMiniPortDxe/VgaMiniPort.c b/IntelFrameworkModulePkg/Bus/Pci/VgaMiniPortDxe/VgaMiniPort.c
index 2e6f56f0dfcad0db1b70f1e24698a6bc84b02984..b0963a45f8134e53a45d2c52cfdae6c797ffed41 100644 (file)
--- a/IntelFrameworkModulePkg/Bus/Pci/VgaMiniPortDxe/VgaMiniPort.c
+++ b/IntelFrameworkModulePkg/Bus/Pci/VgaMiniPortDxe/VgaMiniPort.c
@@ -36,8 +36,8 @@ EFI_DRIVER_BINDING_PROTOCOL gPciVgaMiniPortDriverBinding = {
 /**\r
   Driver entry point for VgaMiniPort driver.\r
   \r
-  @param ImageHandle  Driver image handle\r
-  @param SystemTable  Point to EFI_SYSTEM_TABLE\r
+  @param ImageHandle  Driver image handle.\r
+  @param SystemTable  Point to EFI_SYSTEM_TABLE.\r
   \r
   @retval Status of install driver binding protocol.\r
 **/\r
@@ -64,7 +64,12 @@ PciVgaMiniPortDriverEntryPoint (
 \r
   (Standard DriverBinding Protocol Supported() function)\r
 \r
-  @return EFI_STATUS\r
+  @param  This                   The driver binding protocol.\r
+  @param  Controller             The controller handle to check.\r
+  @param  RemainingDevicePath    The remaining device path.\r
+\r
+  @retval EFI_SUCCESS            The driver supports this controller.\r
+  @retval EFI_UNSUPPORTED        This device isn't supported.\r
 \r
 **/\r
 EFI_STATUS\r
@@ -134,7 +139,13 @@ Done:
 \r
   (Standard DriverBinding Protocol Start() function)\r
 \r
-  @return EFI_STATUS\r
+  @param  This                   The driver binding instance.\r
+  @param  Controller             The controller to check.\r
+  @param  RemainingDevicePath    The remaining device patch.\r
+\r
+  @retval EFI_SUCCESS            The controller is controlled by the driver.\r
+  @retval EFI_ALREADY_STARTED    The controller is already controlled by the driver.\r
+  @retval EFI_OUT_OF_RESOURCES   Failed to allocate resources.\r
 \r
 **/\r
 EFI_STATUS\r
@@ -212,7 +223,7 @@ Done:
           This->DriverBindingHandle,\r
           Controller\r
           );\r
-    if (PciVgaMiniPortPrivate) {\r
+    if (PciVgaMiniPortPrivate != NULL) {\r
       gBS->FreePool (PciVgaMiniPortPrivate);\r
     }\r
   }\r
@@ -226,7 +237,14 @@ Done:
 \r
   (Standard DriverBinding Protocol Stop() function)\r
 \r
-  @return EFI_STATUS\r
+  @param  This                   The driver binding protocol.\r
+  @param  Controller             The controller to release.\r
+  @param  NumberOfChildren       The child number that opened controller\r
+                                 BY_CHILD.\r
+  @param  ChildHandleBuffer      The array of child handle.\r
+\r
+  @retval EFI_SUCCESS            The controller or children are stopped.\r
+  @retval EFI_DEVICE_ERROR       Failed to stop the driver.\r
 \r
 **/\r
 EFI_STATUS\r
@@ -281,13 +299,13 @@ PciVgaMiniPortDriverBindingStop (
 //\r
 \r
 /**\r
-  Thunk function of EFI_VGA_MINI_PORT_SET_MODE\r
+  Thunk function of EFI_VGA_MINI_PORT_SET_MODE.\r
 \r
-  @param  This             Point to instance of EFI_VGA_MINI_PORT_PROTOCOL\r
-  @param  ModeNumber       Mode number\r
+  @param  This             Point to instance of EFI_VGA_MINI_PORT_PROTOCOL.\r
+  @param  ModeNumber       Mode number.\r
 \r
-  @retval EFI_UNSUPPORTED  Invalid mode number\r
-  @retval EFI_SUCCESS      Success\r
+  @retval EFI_UNSUPPORTED  Invalid mode number.\r
+  @retval EFI_SUCCESS      Success.\r
 \r
 **/\r
 EFI_STATUS\r