]> git.proxmox.com Git - mirror_edk2.git/blobdiff - MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
MdeModulePkg/PciBusDxe: Fix small memory leak in FreePciDevice
[mirror_edk2.git] / MdeModulePkg / Bus / Pci / PciBusDxe / PciLib.c
index 3e275e34ecebe4c998d18cf05184e373120494c6..b81f81a1368a028dfb1c5bbd6df4ca714318959a 100644 (file)
@@ -1,7 +1,7 @@
 /** @file\r
   Internal library implementation for PCI Bus module.\r
 \r
-Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>\r
+Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>\r
 (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>\r
 This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
@@ -29,6 +29,43 @@ CHAR16 *mBarTypeStr[] = {
   L"Unknow"\r
   };\r
 \r
+/**\r
+  Retrieve the max bus number that is assigned to the Root Bridge hierarchy.\r
+  It can support the case that there are multiple bus ranges.\r
+\r
+  @param  Bridge           Bridge device instance.\r
+\r
+  @retval                  The max bus number that is assigned to this Root Bridge hierarchy.\r
+\r
+**/\r
+UINT16\r
+PciGetMaxBusNumber (\r
+  IN PCI_IO_DEVICE                      *Bridge\r
+  )\r
+{\r
+  PCI_IO_DEVICE                      *RootBridge;\r
+  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR  *BusNumberRanges;\r
+  UINT64                             MaxNumberInRange;\r
+\r
+  //\r
+  // Get PCI Root Bridge device\r
+  //\r
+  RootBridge = Bridge;\r
+  while (RootBridge->Parent != NULL) {\r
+    RootBridge = RootBridge->Parent;\r
+  }\r
+  MaxNumberInRange = 0;\r
+  //\r
+  // Iterate the bus number ranges to get max PCI bus number\r
+  //\r
+  BusNumberRanges = RootBridge->BusNumberRanges;\r
+  while (BusNumberRanges->Desc != ACPI_END_TAG_DESCRIPTOR) {\r
+    MaxNumberInRange = BusNumberRanges->AddrRangeMin + BusNumberRanges->AddrLen - 1;\r
+    BusNumberRanges++;\r
+  }\r
+  return (UINT16) MaxNumberInRange;\r
+}\r
+\r
 /**\r
   Retrieve the PCI Card device BAR information via PciIo interface.\r
 \r
@@ -188,19 +225,21 @@ DumpBridgeResource (
       BridgeResource->PciDev->PciBar[BridgeResource->Bar].BaseAddress,\r
       BridgeResource->Length, BridgeResource->Alignment\r
       ));\r
-    for ( Link = BridgeResource->ChildList.ForwardLink\r
-        ; Link != &BridgeResource->ChildList\r
-        ; Link = Link->ForwardLink\r
+    for ( Link = GetFirstNode (&BridgeResource->ChildList)\r
+        ; !IsNull (&BridgeResource->ChildList, Link)\r
+        ; Link = GetNextNode (&BridgeResource->ChildList, Link)\r
         ) {\r
       Resource = RESOURCE_NODE_FROM_LINK (Link);\r
       if (Resource->ResourceUsage == PciResUsageTypical) {\r
         Bar = Resource->Virtual ? Resource->PciDev->VfPciBar : Resource->PciDev->PciBar;\r
         DEBUG ((\r
-          EFI_D_INFO, " Base = 0x%lx;\tLength = 0x%lx;\tAlignment = 0x%lx;\tOwner = %s ",\r
+          EFI_D_INFO, "   Base = 0x%lx;\tLength = 0x%lx;\tAlignment = 0x%lx;\tOwner = %s [%02x|%02x|%02x:",\r
           Bar[Resource->Bar].BaseAddress, Resource->Length, Resource->Alignment,\r
           IS_PCI_BRIDGE (&Resource->PciDev->Pci)     ? L"PPB" :\r
           IS_CARDBUS_BRIDGE (&Resource->PciDev->Pci) ? L"P2C" :\r
-                                                       L"PCI"\r
+                                                       L"PCI",\r
+          Resource->PciDev->BusNumber, Resource->PciDev->DeviceNumber,\r
+          Resource->PciDev->FunctionNumber\r
           ));\r
 \r
         if ((!IS_PCI_BRIDGE (&Resource->PciDev->Pci) && !IS_CARDBUS_BRIDGE (&Resource->PciDev->Pci)) ||\r
@@ -210,88 +249,82 @@ DumpBridgeResource (
           //\r
           // The resource requirement comes from the device itself.\r
           //\r
-          DEBUG ((\r
-            EFI_D_INFO, " [%02x|%02x|%02x:%02x]\n",\r
-            Resource->PciDev->BusNumber, Resource->PciDev->DeviceNumber,\r
-            Resource->PciDev->FunctionNumber, Bar[Resource->Bar].Offset\r
-            ));\r
+          DEBUG ((EFI_D_INFO, "%02x]", Bar[Resource->Bar].Offset));\r
         } else {\r
           //\r
           // The resource requirement comes from the subordinate devices.\r
           //\r
-          DEBUG ((\r
-            EFI_D_INFO, " [%02x|%02x|%02x:**]\n",\r
-            Resource->PciDev->BusNumber, Resource->PciDev->DeviceNumber,\r
-            Resource->PciDev->FunctionNumber\r
-            ));\r
+          DEBUG ((EFI_D_INFO, "**]"));\r
         }\r
       } else {\r
-        DEBUG ((EFI_D_INFO, " Padding:Length = 0x%lx;\tAlignment = 0x%lx\n", Resource->Length, Resource->Alignment));\r
+        DEBUG ((EFI_D_INFO, "   Base = Padding;\tLength = 0x%lx;\tAlignment = 0x%lx", Resource->Length, Resource->Alignment));\r
+      }\r
+      if (BridgeResource->ResType != Resource->ResType) {\r
+        DEBUG ((EFI_D_INFO, "; Type = %s", mBarTypeStr[MIN (Resource->ResType, PciBarTypeMaxType)]));\r
       }\r
+      DEBUG ((EFI_D_INFO, "\n"));\r
     }\r
   }\r
 }\r
 \r
 /**\r
   Find the corresponding resource node for the Device in child list of BridgeResource.\r
-  \r
-  @param[in] Device         Pointer to PCI_IO_DEVICE.\r
-  @param[in] BridgeResource Pointer to PCI_RESOURCE_NODE.\r
-  \r
-  @return !NULL  The corresponding resource node for the Device.\r
-  @return NULL   No corresponding resource node for the Device.\r
+\r
+  @param[in]  Device          Pointer to PCI_IO_DEVICE.\r
+  @param[in]  BridgeResource  Pointer to PCI_RESOURCE_NODE.\r
+  @param[out] DeviceResources Pointer to a buffer to receive resources for the Device.\r
+\r
+  @return Count of the resource descriptors returned.\r
 **/\r
-PCI_RESOURCE_NODE *\r
+UINTN\r
 FindResourceNode (\r
-  IN PCI_IO_DEVICE     *Device,\r
-  IN PCI_RESOURCE_NODE *BridgeResource\r
+  IN  PCI_IO_DEVICE     *Device,\r
+  IN  PCI_RESOURCE_NODE *BridgeResource,\r
+  OUT PCI_RESOURCE_NODE **DeviceResources OPTIONAL\r
   )\r
 {\r
   LIST_ENTRY               *Link;\r
   PCI_RESOURCE_NODE        *Resource;\r
+  UINTN                    Count;\r
 \r
+  Count = 0;\r
   for ( Link = BridgeResource->ChildList.ForwardLink\r
       ; Link != &BridgeResource->ChildList\r
       ; Link = Link->ForwardLink\r
       ) {\r
     Resource = RESOURCE_NODE_FROM_LINK (Link);\r
     if (Resource->PciDev == Device) {\r
-      return Resource;\r
+      if (DeviceResources != NULL) {\r
+        DeviceResources[Count] = Resource;\r
+      }\r
+      Count++;\r
     }\r
   }\r
 \r
-  return NULL;\r
+  return Count;\r
 }\r
 \r
 /**\r
   Dump the resource map of all the devices under Bridge.\r
-  \r
-  @param[in] Bridge     Bridge device instance.\r
-  @param[in] IoNode     IO resource descriptor for the bridge device.\r
-  @param[in] Mem32Node  Mem32 resource descriptor for the bridge device.\r
-  @param[in] PMem32Node PMem32 resource descriptor for the bridge device.\r
-  @param[in] Mem64Node  Mem64 resource descriptor for the bridge device.\r
-  @param[in] PMem64Node PMem64 resource descriptor for the bridge device.\r
+\r
+  @param[in] Bridge        Bridge device instance.\r
+  @param[in] Resources     Resource descriptors for the bridge device.\r
+  @param[in] ResourceCount Count of resource descriptors.\r
 **/\r
 VOID\r
 DumpResourceMap (\r
   IN PCI_IO_DEVICE     *Bridge,\r
-  IN PCI_RESOURCE_NODE *IoNode,\r
-  IN PCI_RESOURCE_NODE *Mem32Node,\r
-  IN PCI_RESOURCE_NODE *PMem32Node,\r
-  IN PCI_RESOURCE_NODE *Mem64Node,\r
-  IN PCI_RESOURCE_NODE *PMem64Node\r
+  IN PCI_RESOURCE_NODE **Resources,\r
+  IN UINTN             ResourceCount\r
   )\r
 {\r
-  EFI_STATUS                       Status;\r
-  LIST_ENTRY                       *Link;\r
-  PCI_IO_DEVICE                    *Device;\r
-  PCI_RESOURCE_NODE                *ChildIoNode;\r
-  PCI_RESOURCE_NODE                *ChildMem32Node;\r
-  PCI_RESOURCE_NODE                *ChildPMem32Node;\r
-  PCI_RESOURCE_NODE                *ChildMem64Node;\r
-  PCI_RESOURCE_NODE                *ChildPMem64Node;\r
-  CHAR16                           *Str;\r
+  EFI_STATUS           Status;\r
+  LIST_ENTRY           *Link;\r
+  PCI_IO_DEVICE        *Device;\r
+  UINTN                Index;\r
+  CHAR16               *Str;\r
+  PCI_RESOURCE_NODE    **ChildResources;\r
+  UINTN                ChildResourceCount;\r
 \r
   DEBUG ((EFI_D_INFO, "PciBus: Resource Map for "));\r
 \r
@@ -320,11 +353,9 @@ DumpResourceMap (
     }\r
   }\r
 \r
-  DumpBridgeResource (IoNode);\r
-  DumpBridgeResource (Mem32Node);\r
-  DumpBridgeResource (PMem32Node);\r
-  DumpBridgeResource (Mem64Node);\r
-  DumpBridgeResource (PMem64Node);\r
+  for (Index = 0; Index < ResourceCount; Index++) {\r
+    DumpBridgeResource (Resources[Index]);\r
+  }\r
   DEBUG ((EFI_D_INFO, "\n"));\r
 \r
   for ( Link = Bridge->ChildList.ForwardLink\r
@@ -334,20 +365,19 @@ DumpResourceMap (
     Device = PCI_IO_DEVICE_FROM_LINK (Link);\r
     if (IS_PCI_BRIDGE (&Device->Pci)) {\r
 \r
-      ChildIoNode     = (IoNode     == NULL ? NULL : FindResourceNode (Device, IoNode));\r
-      ChildMem32Node  = (Mem32Node  == NULL ? NULL : FindResourceNode (Device, Mem32Node));\r
-      ChildPMem32Node = (PMem32Node == NULL ? NULL : FindResourceNode (Device, PMem32Node));\r
-      ChildMem64Node  = (Mem64Node  == NULL ? NULL : FindResourceNode (Device, Mem64Node));\r
-      ChildPMem64Node = (PMem64Node == NULL ? NULL : FindResourceNode (Device, PMem64Node));\r
-\r
-      DumpResourceMap (\r
-        Device,\r
-        ChildIoNode,\r
-        ChildMem32Node,\r
-        ChildPMem32Node,\r
-        ChildMem64Node,\r
-        ChildPMem64Node\r
-        );\r
+      ChildResourceCount = 0;\r
+      for (Index = 0; Index < ResourceCount; Index++) {\r
+        ChildResourceCount += FindResourceNode (Device, Resources[Index], NULL);\r
+      }\r
+      ChildResources = AllocatePool (sizeof (PCI_RESOURCE_NODE *) * ChildResourceCount);\r
+      ASSERT (ChildResources != NULL);\r
+      ChildResourceCount = 0;\r
+      for (Index = 0; Index < ResourceCount; Index++) {\r
+        ChildResourceCount += FindResourceNode (Device, Resources[Index], &ChildResources[ChildResourceCount]);\r
+      }\r
+\r
+      DumpResourceMap (Device, ChildResources, ChildResourceCount);\r
+      FreePool (ChildResources);\r
     }\r
   }\r
 }\r
@@ -436,7 +466,7 @@ PciHostBridgeResourceAllocator (
       //\r
 \r
       //\r
-      // If non-stardard PCI Bridge I/O window alignment is supported,\r
+      // If non-standard PCI Bridge I/O window alignment is supported,\r
       // set I/O aligment to minimum possible alignment for root bridge.\r
       //\r
       IoBridge = CreateResourceNode (\r
@@ -529,7 +559,7 @@ PciHostBridgeResourceAllocator (
       }\r
 \r
       //\r
-      // Based on the all the resource tree, contruct ACPI resource node to\r
+      // Based on the all the resource tree, construct ACPI resource node to\r
       // submit the resource aperture to pci host bridge protocol\r
       //\r
       Status = ConstructAcpiResourceRequestor (\r
@@ -807,11 +837,11 @@ PciHostBridgeResourceAllocator (
     // Create the entire system resource map from the information collected by\r
     // enumerator. Several resource tree was created\r
     //\r
-    IoBridge     = FindResourceNode (RootBridgeDev, &IoPool);\r
-    Mem32Bridge  = FindResourceNode (RootBridgeDev, &Mem32Pool);\r
-    PMem32Bridge = FindResourceNode (RootBridgeDev, &PMem32Pool);\r
-    Mem64Bridge  = FindResourceNode (RootBridgeDev, &Mem64Pool);\r
-    PMem64Bridge = FindResourceNode (RootBridgeDev, &PMem64Pool);\r
+    FindResourceNode (RootBridgeDev, &IoPool, &IoBridge);\r
+    FindResourceNode (RootBridgeDev, &Mem32Pool, &Mem32Bridge);\r
+    FindResourceNode (RootBridgeDev, &PMem32Pool, &PMem32Bridge);\r
+    FindResourceNode (RootBridgeDev, &Mem64Pool, &Mem64Bridge);\r
+    FindResourceNode (RootBridgeDev, &PMem64Pool, &PMem64Bridge);\r
 \r
     ASSERT (IoBridge     != NULL);\r
     ASSERT (Mem32Bridge  != NULL);\r
@@ -869,14 +899,13 @@ PciHostBridgeResourceAllocator (
     // Dump the resource map for current root bridge\r
     //\r
     DEBUG_CODE (\r
-      DumpResourceMap (\r
-        RootBridgeDev,\r
-        IoBridge,\r
-        Mem32Bridge,\r
-        PMem32Bridge,\r
-        Mem64Bridge,\r
-        PMem64Bridge\r
-        );\r
+      PCI_RESOURCE_NODE *Resources[5];\r
+      Resources[0] = IoBridge;\r
+      Resources[1] = Mem32Bridge;\r
+      Resources[2] = PMem32Bridge;\r
+      Resources[3] = Mem64Bridge;\r
+      Resources[4] = PMem64Bridge;\r
+      DumpResourceMap (RootBridgeDev, Resources, ARRAY_SIZE (Resources));\r
     );\r
 \r
     FreePool (AcpiConfig);\r
@@ -984,7 +1013,8 @@ PciScanBus (
   UINT8                             Device;\r
   UINT8                             Func;\r
   UINT64                            Address;\r
-  UINTN                             SecondBus;\r
+  UINT8                             SecondBus;\r
+  UINT8                             PaddedSubBus;\r
   UINT16                            Register;\r
   UINTN                             HpIndex;\r
   PCI_IO_DEVICE                     *PciDevice;\r
@@ -993,6 +1023,7 @@ PciScanBus (
   UINT64                            PciAddress;\r
   EFI_HPC_PADDING_ATTRIBUTES        Attributes;\r
   EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptors;\r
+  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *NextDescriptors;\r
   UINT16                            BusRange;\r
   EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL   *PciRootBridgeIo;\r
   BOOLEAN                           BusPadding;\r
@@ -1131,14 +1162,14 @@ PciScanBus (
           BusPadding = FALSE;\r
           if (gPciHotPlugInit != NULL) {\r
 \r
-            if (IsRootPciHotPlugBus (PciDevice->DevicePath, &HpIndex)) {\r
+            if (IsPciHotPlugBus (PciDevice)) {\r
 \r
               //\r
               // If it is initialized, get the padded bus range\r
               //\r
               Status = gPciHotPlugInit->GetResourcePadding (\r
                                           gPciHotPlugInit,\r
-                                          gPciRootHpcPool[HpIndex].HpbDevicePath,\r
+                                          PciDevice->DevicePath,\r
                                           PciAddress,\r
                                           &State,\r
                                           (VOID **) &Descriptors,\r
@@ -1150,8 +1181,9 @@ PciScanBus (
               }\r
 \r
               BusRange = 0;\r
+              NextDescriptors = Descriptors;\r
               Status = PciGetBusRange (\r
-                        &Descriptors,\r
+                        &NextDescriptors,\r
                         NULL,\r
                         NULL,\r
                         &BusRange\r
@@ -1159,11 +1191,14 @@ PciScanBus (
 \r
               FreePool (Descriptors);\r
 \r
-              if (EFI_ERROR (Status)) {\r
+              if (!EFI_ERROR (Status)) {\r
+                BusPadding = TRUE;\r
+              } else if (Status != EFI_NOT_FOUND) {\r
+                //\r
+                // EFI_NOT_FOUND is not a real error. It indicates no bus number padding requested.\r
+                //\r
                 return Status;\r
               }\r
-\r
-              BusPadding = TRUE;\r
             }\r
           }\r
         }\r
@@ -1195,7 +1230,7 @@ PciScanBus (
           // Temporarily initialize SubBusNumber to maximum bus number to ensure the\r
           // PCI configuration transaction to go through any PPB\r
           //\r
-          Register  = 0xFF;\r
+          Register  = PciGetMaxBusNumber (Bridge);\r
           Address   = EFI_PCI_ADDRESS (StartBusNumber, Device, Func, PCI_BRIDGE_SUBORDINATE_BUS_REGISTER_OFFSET);\r
           Status = PciRootBridgeIo->Pci.Write (\r
                                           PciRootBridgeIo,\r
@@ -1218,7 +1253,7 @@ PciScanBus (
 \r
           Status = PciScanBus (\r
                     PciDevice,\r
-                    (UINT8) (SecondBus),\r
+                    SecondBus,\r
                     SubBusNumber,\r
                     PaddedBusRange\r
                     );\r
@@ -1234,12 +1269,16 @@ PciScanBus (
           if ((Attributes == EfiPaddingPciRootBridge) &&\r
               (State & EFI_HPC_STATE_ENABLED) != 0    &&\r
               (State & EFI_HPC_STATE_INITIALIZED) != 0) {\r
-            *PaddedBusRange = (UINT8) ((UINT8) (BusRange) +*PaddedBusRange);\r
+            *PaddedBusRange = (UINT8) ((UINT8) (BusRange) + *PaddedBusRange);\r
           } else {\r
-            Status = PciAllocateBusNumber (PciDevice, *SubBusNumber, (UINT8) (BusRange), SubBusNumber);\r
+            //\r
+            // Reserve the larger one between the actual occupied bus number and padded bus number\r
+            //\r
+            Status = PciAllocateBusNumber (PciDevice, SecondBus, (UINT8) (BusRange), &PaddedSubBus);\r
             if (EFI_ERROR (Status)) {\r
               return Status;\r
             }\r
+            *SubBusNumber = MAX (PaddedSubBus, *SubBusNumber);\r
           }\r
         }\r
 \r