]> git.proxmox.com Git - mirror_edk2.git/commit - PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c
PcAtChipsetPkg/IsaAcpiDxe: Fix VS2012 build failure
authorDandan Bi <dandan.bi@intel.com>
Wed, 22 Nov 2017 01:54:10 +0000 (09:54 +0800)
committerHao Wu <hao.a.wu@intel.com>
Thu, 23 Nov 2017 00:43:21 +0000 (08:43 +0800)
commit2d3a626e3e9577348f9ef4cf6b3118d5e81063cf
tree1ea62caf00bea65a3115809315f6eb98e356d4ea
parent8284b1791ea99416db42075626d7098fa4f89598
PcAtChipsetPkg/IsaAcpiDxe: Fix VS2012 build failure

Done:
if (EFI_ERROR (Status)) {
  if (PciIo != NULL && Enabled) {
    PciIo->Attributes (
             PciIo,
             EfiPciIoAttributeOperationSet,
             OriginalAttributes,
             NULL
             );
  }
}
In above codes, VS2012/VS2010 will report that "OriginalAttributes"
will be used without initialization. But in fact, when the if expression
is true(if (PciIo != NULL && Enabled)), the "OriginalAttributes" must be
initialized. In order to fix this false positive issue, we initialize the
"OriginalAttributes" after declaration.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c