]> git.proxmox.com Git - mirror_edk2.git/commitdiff
PcAtChipsetPkg/IsaAcpiDxe: Fix VS2012 build failure
authorDandan Bi <dandan.bi@intel.com>
Wed, 22 Nov 2017 01:54:10 +0000 (09:54 +0800)
committerHao Wu <hao.a.wu@intel.com>
Thu, 23 Nov 2017 00:43:21 +0000 (08:43 +0800)
Done:
if (EFI_ERROR (Status)) {
  if (PciIo != NULL && Enabled) {
    PciIo->Attributes (
             PciIo,
             EfiPciIoAttributeOperationSet,
             OriginalAttributes,
             NULL
             );
  }
}
In above codes, VS2012/VS2010 will report that "OriginalAttributes"
will be used without initialization. But in fact, when the if expression
is true(if (PciIo != NULL && Enabled)), the "OriginalAttributes" must be
initialized. In order to fix this false positive issue, we initialize the
"OriginalAttributes" after declaration.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c

index d82e2c4641b5ff081a9bdc7d9830c50144518e42..c7ea559006fe27d712e1a237dd4ae3011cd8bcf6 100644 (file)
@@ -178,6 +178,7 @@ PcatIsaAcpiDriverBindingStart (
   Enabled = FALSE;\r
   Supports = 0;\r
   PcatIsaAcpiDev = NULL;\r
+  OriginalAttributes = 0;\r
   //\r
   // Open the PCI I/O Protocol Interface\r
   //\r