]> git.proxmox.com Git - mirror_edk2.git/commit
UefiCpuPkg/CpuCommonFeaturesLib: Aesni.c uses BIT0 and BIT1 reversedly
authorStar Zeng <star.zeng@intel.com>
Thu, 14 Mar 2019 02:10:21 +0000 (10:10 +0800)
committerStar Zeng <star.zeng@intel.com>
Mon, 18 Mar 2019 01:14:15 +0000 (09:14 +0800)
commit34b162d078aa59d55059f08a0f15dd114e7b7db4
tree542b7b24bda10db58313468a95fdf60793904b3a
parentc49f298d28cb90c332f8d495a6dfb355bc4014f0
UefiCpuPkg/CpuCommonFeaturesLib: Aesni.c uses BIT0 and BIT1 reversedly

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1621

According to Intel SDM as below, the BIT0 should be treated as
lock bit, and BIT1 should be treated as disable(1)/enable(0) bit.

"11b: AES instructions are not available until next
RESET.
Otherwise, AES instructions are available.
If the configuration is not 01b, AES
instructions can be mis-configured if a privileged agent
unintentionally writes 11b"

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Chandana Kumar <chandana.c.kumar@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
UefiCpuPkg/Library/CpuCommonFeaturesLib/Aesni.c