]> git.proxmox.com Git - mirror_edk2.git/commit
ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo
authorLaszlo Ersek <lersek@redhat.com>
Fri, 6 Sep 2019 20:02:06 +0000 (22:02 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Wed, 9 Oct 2019 07:40:10 +0000 (09:40 +0200)
commit61d505dfc11a44601cc4b7bf8122df7e300cd5a2
tree986f39a19d0d0b6e4c30c7264414d76076442160
parentfcf8bdcd5313ae076506cbbf8474bb660fa47a93
ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo

The ShellCommandRunConnect() function passes EFI_HANDLE -- (VOID*) --
objects to ConvertAndConnectControllers(), and
ConvertAndConnectControllers() passes those to gBS->OpenProtocol().

Accordingly, ConvertAndConnectControllers() should specify EFI_HANDLE
parameter types, not (EFI_HANDLE*) -- (VOID**) -- types.

This typo is masked because (VOID*) converts to and from any
pointer-to-object type silently.

Note that functionally speaking there is no problem, so this patch does
not change beavior, only cleans up the code.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c