]> git.proxmox.com Git - mirror_edk2.git/commitdiff
ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables
authorShenglei Zhang <shenglei.zhang@intel.com>
Thu, 15 Aug 2019 05:35:42 +0000 (13:35 +0800)
committerLiming Gao <liming.gao@intel.com>
Fri, 16 Aug 2019 06:01:49 +0000 (14:01 +0800)
At latest edk2 version, there is build failure when building ShellPkg
with VS2012x86, which results from uninitialized local variables.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c

index 2d6ff80e299eebe7853061d3db89332197c0dc0e..94bafa22ef4c427f2e27cad3d8d96b1bd44e4633 100644 (file)
@@ -121,6 +121,10 @@ VerifyChecksum (
   UINT8 Checksum;\r
   UINTN OriginalAttribute;\r
 \r
+  //\r
+  // set local variables to suppress incorrect compiler/analyzer warnings\r
+  //\r
+  OriginalAttribute = 0;\r
   ByteCount = 0;\r
   Checksum = 0;\r
 \r
@@ -472,6 +476,10 @@ ParseAcpi (
   BOOLEAN HighLight;\r
   UINTN   OriginalAttribute;\r
 \r
+  //\r
+  // set local variables to suppress incorrect compiler/analyzer warnings\r
+  //\r
+  OriginalAttribute = 0;\r
   Offset = 0;\r
 \r
   // Increment the Indent\r
index 9feb2df2078f5aff41e1d39081fbb8cbc0bc32dd..de0851dd5fbae51308def95bd4964f792fb9e680 100644 (file)
@@ -211,6 +211,10 @@ ProcessTableReportOptions (
   BOOLEAN Log;\r
   BOOLEAN HighLight;\r
 \r
+  //\r
+  // set local variables to suppress incorrect compiler/analyzer warnings\r
+  //\r
+  OriginalAttribute = 0;\r
   SignaturePtr = (UINT8*)(UINTN)&Signature;\r
   Log = FALSE;\r
   HighLight = GetColourHighlighting ();\r
@@ -347,6 +351,12 @@ AcpiView (
   PARSE_ACPI_TABLE_PROC    RsdpParserProc;\r
   BOOLEAN                  Trace;\r
 \r
+  //\r
+  // set local variables to suppress incorrect compiler/analyzer warnings\r
+  //\r
+  EfiConfigurationTable = NULL;\r
+  OriginalAttribute = 0;\r
+\r
   // Search the table for an entry that matches the ACPI Table Guid\r
   FoundAcpiTable = FALSE;\r
   for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) {\r