MdePkg: Avoid Non-Boolean type used as Boolean

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Leo Duran  <leo.duran@amd.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c b/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c
index e388549b3caa3d418c49dc1e71233e8a208d3f88..b84134b75739b67243ed676df4e294b68d0ae875 100644 (file)
--- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c
+++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c
@@ -282,7 +282,7 @@ IoReadFifo8 (
   UINT8 *Buffer8;\r
 \r
   Buffer8 = (UINT8 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     *Buffer8++ = IoRead8 (Port);\r
   }\r
 }\r
@@ -315,7 +315,7 @@ IoReadFifo16 (
   UINT16 *Buffer16;\r
 \r
   Buffer16 = (UINT16 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     *Buffer16++ = IoRead16 (Port);\r
   }\r
 }\r
@@ -348,7 +348,7 @@ IoReadFifo32 (
   UINT32 *Buffer32;\r
 \r
   Buffer32 = (UINT32 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     *Buffer32++ = IoRead32 (Port);\r
   }\r
 }\r
@@ -381,7 +381,7 @@ IoWriteFifo8 (
   UINT8 *Buffer8;\r
 \r
   Buffer8 = (UINT8 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     IoWrite8 (Port, *Buffer8++);\r
   }\r
 }\r
@@ -414,7 +414,7 @@ IoWriteFifo16 (
   UINT16 *Buffer16;\r
 \r
   Buffer16 = (UINT16 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     IoWrite16 (Port, *Buffer16++);\r
   }\r
 }\r
@@ -447,7 +447,7 @@ IoWriteFifo32 (
   UINT32 *Buffer32;\r
 \r
   Buffer32 = (UINT32 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     IoWrite32 (Port, *Buffer32++);\r
   }\r
 }\r

diff --git a/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h b/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h
index c84ce6bf9e80d72a4a1f04aabcbb15c06e166325..8c289cb20df70a0a0ec7258219a42776508ad5ed 100644 (file)
--- a/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h
+++ b/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h
@@ -135,7 +135,6 @@ IoWriteFifoWorker (
   @param  Address       The MMIO register to read.\r
                         The caller is responsible for aligning the Address if required.\r
   @param  Width         The width of the I/O operation.\r
-  @param  Count         The number of times to write I/O port.\r
 \r
   @return Data read from registers in the EFI system memory space.\r
 \r

diff --git a/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c b/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c
index 0279bde27eb385aa99a8c65037de4e8f27e7f176..69acb80f2d6a03419cb066a48d717248d8fbecc6 100644 (file)
--- a/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c
+++ b/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c
@@ -396,7 +396,7 @@ IoReadFifo8 (
   UINT8 *Buffer8;\r
 \r
   Buffer8 = (UINT8 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     *Buffer8++ = IoRead8 (Port);\r
   }\r
 }\r
@@ -429,7 +429,7 @@ IoWriteFifo8 (
   UINT8 *Buffer8;\r
 \r
   Buffer8 = (UINT8 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     IoWrite8 (Port, *Buffer8++);\r
   }\r
 }\r
@@ -466,7 +466,7 @@ IoReadFifo16 (
   //\r
   ASSERT ((Port & 1) == 0);\r
   Buffer16 = (UINT16 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     *Buffer16++ = IoRead16 (Port);\r
   }\r
 }\r
@@ -503,7 +503,7 @@ IoWriteFifo16 (
   //\r
   ASSERT ((Port & 1) == 0);\r
   Buffer16 = (UINT16 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     IoWrite16 (Port, *Buffer16++);\r
   }\r
 }\r
@@ -540,7 +540,7 @@ IoReadFifo32 (
   //\r
   ASSERT ((Port & 3) == 0);\r
   Buffer32 = (UINT32 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     *Buffer32++ = IoRead32 (Port);\r
   }\r
 }\r
@@ -577,7 +577,7 @@ IoWriteFifo32 (
   //\r
   ASSERT ((Port & 3) == 0);\r
   Buffer32 = (UINT32 *)Buffer;\r
-  while (Count--) {\r
+  while (Count-- > 0) {\r
     IoWrite32 (Port, *Buffer32++);\r
   }\r
 }\r