Change functional static variable to Global variable. No STATIC modifier is recommend...

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6315 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/Nt32Pkg/MiscSubClassPlatformDxe/MiscPortInternalConnectorDesignatorFunction.c b/Nt32Pkg/MiscSubClassPlatformDxe/MiscPortInternalConnectorDesignatorFunction.c
index bdea1be9eabf2404d15a27df7444a1a67d63139f..49d2c50f6a648711fb620d9f82e1b4590b211a27 100644 (file)
--- a/Nt32Pkg/MiscSubClassPlatformDxe/MiscPortInternalConnectorDesignatorFunction.c
+++ b/Nt32Pkg/MiscSubClassPlatformDxe/MiscPortInternalConnectorDesignatorFunction.c
@@ -22,6 +22,21 @@ Abstract:
 \r
 #include "MiscSubclassDriver.h"\r
 \r
 \r
 #include "MiscSubclassDriver.h"\r
 \r

+BOOLEAN                    mDone                   = FALSE;\r
+PS2_CONN_DEVICE_PATH       mPs2KeyboardDevicePath  = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0303, 0), DP_END };\r
+PS2_CONN_DEVICE_PATH       mPs2MouseDevicePath     = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0303, 1), DP_END };\r
+SERIAL_CONN_DEVICE_PATH    mCom1DevicePath         = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0501, 0), DP_END };\r
+SERIAL_CONN_DEVICE_PATH    mCom2DevicePath         = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0501, 1), DP_END };\r
+PARALLEL_CONN_DEVICE_PATH  mLpt1DevicePath         = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0401, 0), DP_END };\r
+FLOOPY_CONN_DEVICE_PATH    mFloopyADevicePath      = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0604, 0), DP_END };\r
+FLOOPY_CONN_DEVICE_PATH    mFloopyBDevicePath      = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0604, 1), DP_END };\r
+USB_PORT_DEVICE_PATH       mUsb0DevicePath         = { DP_ACPI, DP_PCI (0x1d, 0x00), DP_END };\r
+USB_PORT_DEVICE_PATH       mUsb1DevicePath         = { DP_ACPI, DP_PCI (0x1d, 0x01), DP_END };\r
+USB_PORT_DEVICE_PATH       mUsb2DevicePath         = { DP_ACPI, DP_PCI (0x1d, 0x02), DP_END };\r
+USB_PORT_DEVICE_PATH       mUsb3DevicePath         = { DP_ACPI, DP_PCI (0x1d, 0x07), DP_END };\r
+IDE_DEVICE_PATH            mIdeDevicePath          = { DP_ACPI, DP_PCI (0x1F, 0x01), DP_END };\r
+GB_NIC_DEVICE_PATH         mGbNicDevicePath        = { DP_ACPI, DP_PCI( 0x03,0x00 ),DP_PCI( 0x1F,0x00 ),DP_PCI( 0x07,0x00 ), DP_END };\r
+\r

 //\r
 //\r
 //\r
 //\r
 //\r
 //\r


@@ -69,20 +84,6 @@ Returns:
       LogRecordData was NULL.\r
 --*/\r
 {\r
       LogRecordData was NULL.\r
 --*/\r
 {\r

-  STATIC BOOLEAN                    Done                    = FALSE;\r
-  STATIC PS2_CONN_DEVICE_PATH       mPs2KeyboardDevicePath  = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0303, 0), DP_END };\r
-  STATIC PS2_CONN_DEVICE_PATH       mPs2MouseDevicePath     = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0303, 1), DP_END };\r
-  STATIC SERIAL_CONN_DEVICE_PATH    mCom1DevicePath         = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0501, 0), DP_END };\r
-  STATIC SERIAL_CONN_DEVICE_PATH    mCom2DevicePath         = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0501, 1), DP_END };\r
-  STATIC PARALLEL_CONN_DEVICE_PATH  mLpt1DevicePath         = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0401, 0), DP_END };\r
-  STATIC FLOOPY_CONN_DEVICE_PATH    mFloopyADevicePath      = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0604, 0), DP_END };\r
-  STATIC FLOOPY_CONN_DEVICE_PATH    mFloopyBDevicePath      = { DP_ACPI, DP_PCI (0x1F, 0x00), DP_LPC (0x0604, 1), DP_END };\r
-  STATIC USB_PORT_DEVICE_PATH       mUsb0DevicePath         = { DP_ACPI, DP_PCI (0x1d, 0x00), DP_END };\r
-  STATIC USB_PORT_DEVICE_PATH       mUsb1DevicePath         = { DP_ACPI, DP_PCI (0x1d, 0x01), DP_END };\r
-  STATIC USB_PORT_DEVICE_PATH       mUsb2DevicePath         = { DP_ACPI, DP_PCI (0x1d, 0x02), DP_END };\r
-  STATIC USB_PORT_DEVICE_PATH       mUsb3DevicePath         = { DP_ACPI, DP_PCI (0x1d, 0x07), DP_END };\r
-  STATIC IDE_DEVICE_PATH            mIdeDevicePath          = { DP_ACPI, DP_PCI (0x1F, 0x01), DP_END };\r
-  STATIC GB_NIC_DEVICE_PATH         mGbNicDevicePath        = { DP_ACPI, DP_PCI( 0x03,0x00 ),DP_PCI( 0x1F,0x00 ),DP_PCI( 0x07,0x00 ), DP_END };\r

   EFI_DEVICE_PATH_PROTOCOL          EndDevicePath           = DP_END;\r
 \r
   //\r
   EFI_DEVICE_PATH_PROTOCOL          EndDevicePath           = DP_END;\r
 \r
   //\r


@@ -106,7 +107,7 @@ Returns:
   //\r
   // Is this the first time through this function?\r
   //\r
   //\r
   // Is this the first time through this function?\r
   //\r

-  if (!Done) {\r
+  if (!mDone) {\r

     //\r
     // Yes, this is the first time.  Inspect/Change the contents of the\r
     // RecordData structure.\r
     //\r
     // Yes, this is the first time.  Inspect/Change the contents of the\r
     // RecordData structure.\r


@@ -244,19 +245,19 @@ Returns:
     //\r
     // End Shanmu\r
     //\r
     //\r
     // End Shanmu\r
     //\r

-    // Set Done flag to TRUE for next pass through this function.\r
+    // Set mDone flag to TRUE for next pass through this function.\r

     // Set *LogRecordData to TRUE so data will get logged to Data Hub.\r
     //\r
     // Set *LogRecordData to TRUE so data will get logged to Data Hub.\r
     //\r

-    Done            = TRUE;\r
+    mDone            = TRUE;\r

     *LogRecordData  = TRUE;\r
   } else {\r
     //\r
     *LogRecordData  = TRUE;\r
   } else {\r
     //\r

-    // No, this is the second time.  Reset the state of the Done flag\r
+    // No, this is the second time.  Reset the state of the mDone flag\r

     // to FALSE and tell the data logger that there is no more data\r
     // to be logged for this record type.  If any memory allocations\r
     // were made by earlier passes, they must be released now.\r
     //\r
     // to FALSE and tell the data logger that there is no more data\r
     // to be logged for this record type.  If any memory allocations\r
     // were made by earlier passes, they must be released now.\r
     //\r

-    Done            = FALSE;\r
+    mDone            = FALSE;\r

     *LogRecordData  = FALSE;\r
   }\r
 \r
     *LogRecordData  = FALSE;\r
   }\r
 \r